platform/upstream/coreclr.git
5 years agoTranslate [rip +- offset] to absolute RVA's in R2RDump (#19219)
Tomáš Rylek [Tue, 14 Aug 2018 10:37:19 +0000 (12:37 +0200)]
Translate [rip +- offset] to absolute RVA's in R2RDump (#19219)

* Translate [rip +- offset] to absoluate RVA's in R2RDump

The existing logic for displaying rip-relative addressed on X64
make it very hard to calculate the final addresses. I have added
a horrendous hack using textual analysis of the disassembled
instruction to translate this notation to absolute RVA's.

As part of this effort I have also encapsulated the CorDisTools
helper in a new class Disassembler that also contains customizable
provisions for handling special assembly cases on the individual
architectures.

Thanks

Tomas

* Temporarily block out disassembly to make tests pass

In my initial commit I removed the line blocking out disassembly
however this ends up failing several lab tests so I'm putting the
line back.

Thanks

Tomas

5 years agoCode review feedback for the alternate stack changes (PR #19309). (#19476)
Mike McLaughlin [Tue, 14 Aug 2018 07:46:13 +0000 (00:46 -0700)]
Code review feedback for the alternate stack changes (PR #19309). (#19476)

Fixed SOS plugin for core dumps.

5 years agoUpdate URLs and exclusion list for staging (#19423)
Andon Andonov [Tue, 14 Aug 2018 03:43:10 +0000 (20:43 -0700)]
Update URLs and exclusion list for staging (#19423)

* Update URLs and exclusion list for staging

* Update Failing tests

* Fix IO test namespace

* Add 2 failing Ubuntu tests

* Exclude test under Ubuntu

* Add regressed test

* Roll-back CI URLs

* Add issue number

5 years agoMerge pull request #19463 from BruceForstall/FixArmHeapVerify
Bruce Forstall [Mon, 13 Aug 2018 23:53:22 +0000 (16:53 -0700)]
Merge pull request #19463 from BruceForstall/FixArmHeapVerify

Disable 3 tests for Windows/arm32 HeapVerify runs

5 years agodisable tests\src\JIT\Methodical\fp\exgen\10w5d_cs_do (#19465)
Sergey Andreenko [Mon, 13 Aug 2018 23:16:50 +0000 (16:16 -0700)]
disable tests\src\JIT\Methodical\fp\exgen\10w5d_cs_do (#19465)

in stress modes. The issue is #18988

5 years agoMerge pull request #19469 from BruceForstall/DisableVectorDot
Bruce Forstall [Mon, 13 Aug 2018 22:21:23 +0000 (15:21 -0700)]
Merge pull request #19469 from BruceForstall/DisableVectorDot

Disable VectorDot_ro.cmd_9267 for Windows arm64 R2R

5 years agoDisable VectorDot_ro.cmd_9267 for Windows arm64 R2R
Bruce Forstall [Mon, 13 Aug 2018 22:19:49 +0000 (15:19 -0700)]
Disable VectorDot_ro.cmd_9267 for Windows arm64 R2R

Tracked by #18991

5 years agoMerge pull request #19466 from BruceForstall/Disable163200
Bruce Forstall [Mon, 13 Aug 2018 22:04:49 +0000 (15:04 -0700)]
Merge pull request #19466 from BruceForstall/Disable163200

Disable test b163200 under GCStress

5 years agoDisable test b163200 under GCStress
Bruce Forstall [Mon, 13 Aug 2018 22:03:23 +0000 (15:03 -0700)]
Disable test b163200 under GCStress

Tracked by #19464

5 years agoDisable 3 tests for Windows/arm32 HeapVerify runs
Bruce Forstall [Mon, 13 Aug 2018 21:06:29 +0000 (14:06 -0700)]
Disable 3 tests for Windows/arm32 HeapVerify runs

They all time out.

Fixes #19462

5 years agoMerge pull request #19459 from BruceForstall/Disable437044
Bruce Forstall [Mon, 13 Aug 2018 19:42:25 +0000 (12:42 -0700)]
Merge pull request #19459 from BruceForstall/Disable437044

Exclude 437044.cmd_10304 from GCStress runs

5 years agoExclude 437044.cmd_10304 from GCStress runs
Bruce Forstall [Mon, 13 Aug 2018 19:40:23 +0000 (12:40 -0700)]
Exclude 437044.cmd_10304 from GCStress runs

This test times out on ARM Windows R2R GCStress15 runs.

5 years agoAdd a skipmanaged option to build.sh (#19111)
Omair Majid [Mon, 13 Aug 2018 19:38:37 +0000 (15:38 -0400)]
Add a skipmanaged option to build.sh (#19111)

This option is the opposite of -msbuildonunsupportedplatform, and an
managed version of of -skipnative.

This is useful for bootstrapping on new Linux/x64 distributions, where
dotnet may not work (yet) but coreclr will try and use it anyway,
failing the bootstrap scripts.

See also https://github.com/dotnet/source-build/issues/663 for
additional background information.

5 years agoMerge pull request #19458 from BruceForstall/DisableTests
Bruce Forstall [Mon, 13 Aug 2018 19:12:23 +0000 (12:12 -0700)]
Merge pull request #19458 from BruceForstall/DisableTests

Disable System.Linq.Expressions.Tests against #19457

5 years agoDisable System.Linq.Expressions.Tests against #19457
Bruce Forstall [Mon, 13 Aug 2018 19:10:50 +0000 (12:10 -0700)]
Disable System.Linq.Expressions.Tests against #19457

5 years agoRemove unused local from List<T>.RemoveRange (dotnet/corefx#31727)
Robin Sue [Mon, 13 Aug 2018 02:49:39 +0000 (04:49 +0200)]
Remove unused local from List<T>.RemoveRange (dotnet/corefx#31727)

`int i` appears to be unused so i removed it.

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
5 years agonon shared changes and feedback addressed
Anipik [Sun, 12 Aug 2018 22:42:34 +0000 (15:42 -0700)]
non shared changes and feedback addressed

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
5 years agoFix a couple of apartment state issues (#19384)
Koundinya Veluri [Mon, 13 Aug 2018 01:35:48 +0000 (18:35 -0700)]
Fix a couple of apartment state issues (#19384)

* Fix a couple of apartment state issues

Fix for https://github.com/dotnet/coreclr/issues/17822
- The apartment state now defaults to MTA for the main thread along with a CoInitialize
- Calling `Thread.SetApartmentState` with STA now fails as expected (different behavior from previous netcore, same behavior as netfx)

Fix for https://github.com/dotnet/coreclr/issues/17787
- `WaitHandle.WaitAll` for multiple handles is not supported on an STA thread due to issues described in https://github.com/dotnet/coreclr/issues/17787#issuecomment-385117537
- It now throws `NotSupportedException` as expected (different behavior from previous netcore, same behavior as netfx)

Fix for https://github.com/dotnet/coreclr/issues/19225

* Temporarily exclude invalid CoreFX test

5 years agoCreate Microsoft.IO.Redist (dotnet/corefx#31679)
Jeremy Kuhne [Sat, 11 Aug 2018 00:06:39 +0000 (17:06 -0700)]
Create Microsoft.IO.Redist (dotnet/corefx#31679)

* Create Microsoft.Internal.IO

Includes all of Path, Directory, *Info, etc. from System.IO with targets of NetFX 4.6.1 and NetCore 2.1.

* Tweaks / minor fixes

* Remove netstandard build.

* Add package

Update to build for 4.7.2 only

* Rename folder to prepare for project rename

* Change the name to Microsoft.IO.Redist

* Namespace tweaks

* Use open key, tweak references

* More tweaks on feedback

Also grab latest build tools for 4.7.x RIDs

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
5 years agoSilence WinRT type assert in crossgen (#19442)
Simon Nattress [Mon, 13 Aug 2018 00:09:55 +0000 (17:09 -0700)]
Silence WinRT type assert in crossgen (#19442)

Disable type loader assert that fires when resolving a type from a WinMD. Instead, compilation should fail gracefully, or at runtime a type load exception will be thrown.

5 years ago[local gc] disable feature redhawk (#17769)
David Mason [Sat, 11 Aug 2018 17:11:49 +0000 (10:11 -0700)]
[local gc] disable feature redhawk  (#17769)

5 years agoMake RuntimeType sealed and deleted support for introspection only loads (#19427)
Jan Kotas [Sat, 11 Aug 2018 14:43:16 +0000 (07:43 -0700)]
Make RuntimeType sealed and deleted support for introspection only loads (#19427)

- Sealed Runtime makes `is RuntimeType` and similar checks faster. These checks are fairly common in reflection.
- Delete support for introspection only loads from the runtime. We do not plan to use in .NET Core. The support for introspection loads inherited from RuntimeType and thus it is incompatible with sealed RuntimeType.

6 years agomoved to shared (#19419)
Anirudh Agnihotry [Sat, 11 Aug 2018 07:31:01 +0000 (00:31 -0700)]
moved to shared (#19419)

6 years agoMoved SpinLock.cs to shared (#19391)
Anirudh Agnihotry [Sat, 11 Aug 2018 06:19:28 +0000 (23:19 -0700)]
Moved SpinLock.cs to shared (#19391)

* m removed from names, spaces after \\ and braces added

* Moved to shared

6 years agoDon't early terminate on null for 64bit NR HashCode (#19331)
Ben Adams [Sat, 11 Aug 2018 05:44:19 +0000 (06:44 +0100)]
Don't early terminate on null for 64bit NR HashCode (#19331)

* Don't early terminate on null for 64bit NR HashCode

* Improved GetNonRandomizedHashCode

* Update message on GetNonRandomizedHashCode

* Consume null terminator rather than special case odd lengths

6 years agoMerge pull request #19434 from BruceForstall/DisableR2rDumpTest2
Bruce Forstall [Sat, 11 Aug 2018 03:00:44 +0000 (20:00 -0700)]
Merge pull request #19434 from BruceForstall/DisableR2rDumpTest2

Disable R2RDumpTest for JIT stress modes

6 years agoDisable R2RDumpTest for JIT stress modes
Bruce Forstall [Sat, 11 Aug 2018 00:41:17 +0000 (17:41 -0700)]
Disable R2RDumpTest for JIT stress modes

6 years agoMerge pull request #19433 from BruceForstall/UpdateTriggerPhrases
Bruce Forstall [Sat, 11 Aug 2018 00:32:02 +0000 (17:32 -0700)]
Merge pull request #19433 from BruceForstall/UpdateTriggerPhrases

Update existing trigger phrases documentation

6 years agoUpdate existing trigger phrases documentation
Bruce Forstall [Sat, 11 Aug 2018 00:29:59 +0000 (17:29 -0700)]
Update existing trigger phrases documentation

6 years agoCORDbgSetInstruction: clear thumb bit of the address before flushing icache (#19409)
Konstantin Baladurin [Fri, 10 Aug 2018 23:10:53 +0000 (02:10 +0300)]
CORDbgSetInstruction: clear thumb bit of the address before flushing icache (#19409)

We should clear thumb bit of the address before flushing icache otherwise
we may not flush the cache for the first byte of the instruction.

6 years agoMoved to shared (#19399)
Anirudh Agnihotry [Fri, 10 Aug 2018 23:09:48 +0000 (16:09 -0700)]
Moved to shared (#19399)

6 years agoupdate order of locks so jitstress is unblocked (#19401)
David Mason [Fri, 10 Aug 2018 22:40:39 +0000 (15:40 -0700)]
update order of locks so jitstress is unblocked (#19401)

6 years agoFix non-lclVar odd-byte struct passing
Carol Eidt [Thu, 9 Aug 2018 23:31:11 +0000 (16:31 -0700)]
Fix non-lclVar odd-byte struct passing

When a non-power-of-2 struct is passed, we can only use an IND if the arg is a local.

Fix #19288

6 years agoMerge pull request #19344 from adityamandaleeka/aa64_vm_callconv_changes
Aditya Mandaleeka [Fri, 10 Aug 2018 20:38:09 +0000 (13:38 -0700)]
Merge pull request #19344 from adityamandaleeka/aa64_vm_callconv_changes

CallDescr/TransitionBlock changes for ARM64 calling convention

6 years agoAdd SoA raytracer as a CQ test for Intel hardware intrinsic
Fei Peng [Mon, 6 Aug 2018 22:10:50 +0000 (15:10 -0700)]
Add SoA raytracer as a CQ test for Intel hardware intrinsic

6 years agoMerge pull request #19414 from BruceForstall/ReduceCorefxInnerloopTesting
Bruce Forstall [Fri, 10 Aug 2018 18:43:05 +0000 (11:43 -0700)]
Merge pull request #19414 from BruceForstall/ReduceCorefxInnerloopTesting

Reduce the number of innerloop CoreFX jobs

6 years agoReduce the number of innerloop CoreFX jobs
Bruce Forstall [Fri, 10 Aug 2018 18:30:04 +0000 (11:30 -0700)]
Reduce the number of innerloop CoreFX jobs

1. Stop doing any OSX CoreFX jobs; they're too unreliable.
2. Stop running Debug jobs.

6 years agoMerge pull request #19387 from dotnetrt/parallel-test-build
Bruce Forstall [Fri, 10 Aug 2018 18:10:21 +0000 (11:10 -0700)]
Merge pull request #19387 from dotnetrt/parallel-test-build

Reenable parallel msbuild execution - 2x faster test build

6 years agoAlign the Contents of EventPipeBuffers (#19375)
Brian Robbins [Fri, 10 Aug 2018 17:22:40 +0000 (10:22 -0700)]
Align the Contents of EventPipeBuffers (#19375)

6 years agoUpdating the ilproj-sdk to also copy native dependencies from Microsoft.NETCore.JIT
Tanner Gooding [Thu, 9 Aug 2018 19:33:21 +0000 (12:33 -0700)]
Updating the ilproj-sdk to also copy native dependencies from Microsoft.NETCore.JIT

6 years agoUpdate DynamicHelper for Unix to match Win.
Aditya Mandaleeka [Thu, 9 Aug 2018 22:43:35 +0000 (15:43 -0700)]
Update DynamicHelper for Unix to match Win.

6 years agoMerge pull request #19385 from BruceForstall/WhichCoreFxCommit
Bruce Forstall [Thu, 9 Aug 2018 21:01:34 +0000 (14:01 -0700)]
Merge pull request #19385 from BruceForstall/WhichCoreFxCommit

Print out the checked out commit hash

6 years agoFix evaluation order for block copy
Carol Eidt [Tue, 7 Aug 2018 15:58:59 +0000 (08:58 -0700)]
Fix evaluation order for block copy

This order was changed five years ago, as a workaround for data flow analysis issues around the block copy. Now that block copies are handled as regular assignments, this is no longer needed - and is, in fact, incorrect as it causes side effects to be handled in the wrong order.

However, for the case where the lhs is an indirection of a local address, it must be evaluated 2nd for SSA renaming to be correct.

In the process, also remove the special-casing for the size operand of `DYN_BLK` under `ASG`.

Fix #19243

6 years agoAdding the Avx.MaskStore tests
Tanner Gooding [Wed, 8 Aug 2018 18:03:53 +0000 (11:03 -0700)]
Adding the Avx.MaskStore tests

6 years agoImplementing the Avx.MaskStore intrinsics
Tanner Gooding [Tue, 7 Aug 2018 20:31:30 +0000 (13:31 -0700)]
Implementing the Avx.MaskStore intrinsics

6 years agoReenable parallel msbuild execution - 2x faster test build
Jacek Blaszczynski [Thu, 9 Aug 2018 18:04:43 +0000 (20:04 +0200)]
Reenable parallel msbuild execution - 2x faster test build

6 years agoPrint out the checked out commit hash
Bruce Forstall [Thu, 9 Aug 2018 18:52:56 +0000 (11:52 -0700)]
Print out the checked out commit hash

This is useful to see exactly which version of CoreFX you are testing against.

6 years agoUpdating init-tools to be inline with the CoreFX copy
Tanner Gooding [Thu, 9 Aug 2018 15:02:43 +0000 (08:02 -0700)]
Updating init-tools to be inline with the CoreFX copy

6 years agoUpdate CheckProjects to support `DebugType=Embedded` for RelType projects
Tanner Gooding [Thu, 9 Aug 2018 14:56:22 +0000 (07:56 -0700)]
Update CheckProjects to support `DebugType=Embedded` for RelType projects

6 years agoUpdating the x86 HWIntrinsic tests to include embedded pdbs
Tanner Gooding [Wed, 8 Aug 2018 19:52:23 +0000 (12:52 -0700)]
Updating the x86 HWIntrinsic tests to include embedded pdbs

6 years agoMerge pull request #19350 from dotnet/dev/unix_test_workflow
Bruce Forstall [Thu, 9 Aug 2018 18:06:21 +0000 (11:06 -0700)]
Merge pull request #19350 from dotnet/dev/unix_test_workflow

Simplify PR trigger creation; fix related bugs

6 years agoMerge pull request #19382 from BruceForstall/FixSwitch
Bruce Forstall [Thu, 9 Aug 2018 17:38:09 +0000 (10:38 -0700)]
Merge pull request #19382 from BruceForstall/FixSwitch

Fix `--` application to managed tests build command-line

6 years agoFix `--` application to managed tests build comamnd-line
Bruce Forstall [Thu, 9 Aug 2018 17:20:25 +0000 (10:20 -0700)]
Fix `--` application to managed tests build comamnd-line

6 years agoChange CoreLib native image to be R2R by default on all platforms (#19359)
Jan Kotas [Thu, 9 Aug 2018 06:29:32 +0000 (23:29 -0700)]
Change CoreLib native image to be R2R by default on all platforms (#19359)

* Change CoreLib native image to be R2R by default on all platforms

* Delete unused argument

6 years agoUpdating init-tools.cmd to pass through PACKAGES_DIR
Tanner Gooding [Wed, 8 Aug 2018 22:04:07 +0000 (15:04 -0700)]
Updating init-tools.cmd to pass through PACKAGES_DIR

6 years agoUpdate BuildTools, CoreSetup to preview1-03108-01, preview1-26808-05, respectively
dotnet-maestro-bot [Wed, 8 Aug 2018 20:53:23 +0000 (13:53 -0700)]
Update BuildTools, CoreSetup to preview1-03108-01, preview1-26808-05, respectively

6 years agoMove methodbody and exceptionHandlingClause to shared (#19364)
Anirudh Agnihotry [Thu, 9 Aug 2018 03:08:38 +0000 (20:08 -0700)]
Move methodbody and exceptionHandlingClause to shared  (#19364)

* Changing names and making runtime files

* Movel methodbody and exceptionHandlingClause to shared

* Fixing build error

6 years agoMerge pull request #19363 from nattress/crossgen_skip_windowsruntime
Bruce Forstall [Thu, 9 Aug 2018 03:03:13 +0000 (20:03 -0700)]
Merge pull request #19363 from nattress/crossgen_skip_windowsruntime

Skip Crossgen of S.R.WindowsRuntime.dll

6 years agoMerge pull request #19367 from BruceForstall/RestorePassThroughArg
Bruce Forstall [Thu, 9 Aug 2018 02:53:41 +0000 (19:53 -0700)]
Merge pull request #19367 from BruceForstall/RestorePassThroughArg

Restore handling of __PassThroughArg for `--`

6 years agoFix R2R DynamicHelper to use the correct offset to x0 reg.
Aditya Mandaleeka [Thu, 9 Aug 2018 02:30:48 +0000 (19:30 -0700)]
Fix R2R DynamicHelper to use the correct offset to x0 reg.

6 years agoReNaming and rearranging the variables to reduce the diff (#19338)
Anirudh Agnihotry [Wed, 8 Aug 2018 22:54:13 +0000 (15:54 -0700)]
ReNaming and rearranging the variables to reduce the diff (#19338)

* Names changes in managed side and native side

* name changes in native side

* Removing serialization field

* lower case corrected

6 years agoRestore handling of __PassThroughArg for `--`
Bruce Forstall [Wed, 8 Aug 2018 21:27:22 +0000 (14:27 -0700)]
Restore handling of __PassThroughArg for `--`

6 years agoMerge pull request #19275 from dotnetrt/test-warnings-msbuild
Bruce Forstall [Wed, 8 Aug 2018 20:38:23 +0000 (13:38 -0700)]
Merge pull request #19275 from dotnetrt/test-warnings-msbuild

build-test - fix ~ 2.1k MSBuild warnings due to bad framework and bad project references

6 years agoJIT: update lvaGrabTemp for new minopts/debug ref counting approach (#19351)
Andy Ayers [Wed, 8 Aug 2018 20:05:47 +0000 (13:05 -0700)]
JIT: update lvaGrabTemp for new minopts/debug ref counting approach (#19351)

If the jit has started normal ref counting and is in minopts or debug,
set all new temps to be implicitly referenced by default.

Closes #19346.

6 years agoSkip Crossgen of S.R.WindowsRuntime.dll
Simon Nattress [Wed, 8 Aug 2018 18:44:33 +0000 (11:44 -0700)]
Skip Crossgen of S.R.WindowsRuntime.dll

System.Runtime.WindowsRuntime contains assembly refs to Windows platform WinMD types which are not available on Unix and required to crossgen the assembly.

6 years agoUpdate BuildTools, CoreClr, CoreFx, CoreSetup, PgoData to preview1-03107-02, preview1...
dotnet-maestro-bot [Wed, 8 Aug 2018 17:02:46 +0000 (10:02 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, PgoData to preview1-03107-02, preview1-26808-04, preview1-26807-04, preview1-26807-04, master-20180808-0056, respectively (#19329)

6 years agoMerge pull request #19343 from BruceForstall/SimplifyPrTriggers
Bruce Forstall [Wed, 8 Aug 2018 05:56:56 +0000 (22:56 -0700)]
Merge pull request #19343 from BruceForstall/SimplifyPrTriggers

Simplify the code to create PR triggers

6 years agoSimplify the code to create PR triggers
Bruce Forstall [Wed, 8 Aug 2018 00:46:43 +0000 (17:46 -0700)]
Simplify the code to create PR triggers

Also, create PR triggers for jobs that currently don't have them
(which is a bug), such as Debug and Release Windows x64 jobs.

6 years agoFix non-Windows assembly code to match Windows calldescr/arg reg changes.
Aditya Mandaleeka [Wed, 8 Aug 2018 00:47:43 +0000 (17:47 -0700)]
Fix non-Windows assembly code to match Windows calldescr/arg reg changes.

6 years agoUse dotnet MSBuild for tests (#19324)
Aaron Robinson [Wed, 8 Aug 2018 00:42:15 +0000 (17:42 -0700)]
Use dotnet MSBuild for tests (#19324)

* Revert "Revert "Build managed tests with dotnet (#19254)""
* Reenable MSBuild support through dotnet instead of global MSBuild

6 years agoFillRegDisplay: initialize volatileCurrContextPointers for ARM and ARM64 (#19332)
Konstantin Baladurin [Tue, 7 Aug 2018 23:25:07 +0000 (02:25 +0300)]
FillRegDisplay: initialize volatileCurrContextPointers for ARM and ARM64 (#19332)

We need to initialize volatileCurrContextPointers because they could be
used by GC in the case of the leaf frame. This patch fixes crashes during
GC when we are single stepping using managed debugger.

6 years agoMake VM-side changes for ARM64 Windows calling convention.
Aditya Mandaleeka [Tue, 7 Aug 2018 22:17:52 +0000 (15:17 -0700)]
Make VM-side changes for ARM64 Windows calling convention.

6 years agoR2RDump - Tests for Debug, avoid copying expected xml files (#19321)
Amy [Tue, 7 Aug 2018 22:06:01 +0000 (15:06 -0700)]
R2RDump - Tests for Debug, avoid copying expected xml files (#19321)

* Add Debug expected xml, pass xml path to R2RDumpTest

* Pass expected xml path as argument

* Remove copy expected xml, clean up

6 years agoAdd basic check that the correct number of tests is built (#19290)
Bruce Forstall [Tue, 7 Aug 2018 21:58:12 +0000 (14:58 -0700)]
Add basic check that the correct number of tests is built (#19290)

Fixes #19286

6 years agoMerge pull request #19336 from dotnet/dev/unix_test_workflow
Bruce Forstall [Tue, 7 Aug 2018 21:43:39 +0000 (14:43 -0700)]
Merge pull request #19336 from dotnet/dev/unix_test_workflow

Update vc-runtime package used by Windows ARM/ARM64 testing

6 years agoMerge pull request #19325 from AndyAyersMS/RecomputeRefCounts2
Andy Ayers [Tue, 7 Aug 2018 21:42:47 +0000 (14:42 -0700)]
Merge pull request #19325 from AndyAyersMS/RecomputeRefCounts2

JIT: recompute local ref counts after lower

6 years agoMerge pull request #19335 from AndyAyersMS/FixDumpIssue
Andy Ayers [Tue, 7 Aug 2018 21:19:29 +0000 (14:19 -0700)]
Merge pull request #19335 from AndyAyersMS/FixDumpIssue

fix bug in jit dump output

6 years agoAdd support to use an indirected address for JMP instructions to ARM64 (#19281)
David Wrighton [Tue, 7 Aug 2018 20:49:03 +0000 (13:49 -0700)]
Add support to use an indirected address for JMP instructions to ARM64 (#19281)

* Add support to use an indirected address for JMP instructions to ARM64
- Merge logic between ARM and ARM64

6 years agoMerge pull request #19291 from BruceForstall/CleanUpBuildCmd
Bruce Forstall [Tue, 7 Aug 2018 19:35:11 +0000 (12:35 -0700)]
Merge pull request #19291 from BruceForstall/CleanUpBuildCmd

Clean up build.cmd/build-test.cmd/runtest.cmd

6 years agofix bug in jit dump output
Andy Ayers [Tue, 7 Aug 2018 18:25:00 +0000 (11:25 -0700)]
fix bug in jit dump output

6 years agoUpdate BuildTools, CoreClr, CoreFx, CoreSetup, PgoData to preview1-03106-01, preview1...
dotnet-maestro-bot [Tue, 7 Aug 2018 05:37:31 +0000 (22:37 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, PgoData to preview1-03106-01, preview1-26806-04, preview1-26806-04, preview1-26806-01, master-20180802-0110, respectively (master) (#19263)

* Update BuildTools, CoreClr, CoreFx, CoreSetup, PgoData to preview1-03106-01, preview1-26806-04, preview1-26806-04, preview1-26806-01, master-20180802-0110, respectively

* Disable outdated tests

6 years agoJIT: recompute local ref counts after lower
Andy Ayers [Thu, 2 Aug 2018 18:23:27 +0000 (11:23 -0700)]
JIT: recompute local ref counts after lower

Update `lvaComputeRefCounts` to encapsulate running ref counts post-lower
and to also handle the fast jitting cases.

Invoke this after lower to provide recomputed (and more accurate) counts.

Part of #18969.

6 years agoJIT: refactor ref count computation into a reusable utility method (#19240)
Andy Ayers [Tue, 7 Aug 2018 01:55:56 +0000 (18:55 -0700)]
JIT: refactor ref count computation into a reusable utility method (#19240)

Extract out the basic ref count computation into a method that we
can conceptually call later on if we want to recompute counts.

Move one existing RCS_EARLY count for promoted fields of register
args into this recomputation since losing this count bump causes
quite a few diffs.

The hope is to eventually call this method again later in the jit
phase pipeline and then possibly get rid of all the (non-early)
incremental count maintenance we do currently.

Part of #18969

6 years agoFix throughput testing (#19314)
Michelle McDaniel [Tue, 7 Aug 2018 01:46:02 +0000 (18:46 -0700)]
Fix throughput testing (#19314)

Also adds architecture to throughput trigger phrase.

6 years agoMerge pull request #19319 from BruceForstall/UpdateArmCrtDependendencies
Bruce Forstall [Tue, 7 Aug 2018 00:34:34 +0000 (17:34 -0700)]
Merge pull request #19319 from BruceForstall/UpdateArmCrtDependendencies

Update vc-runtime package to support ARM and ARM64 with current builds

6 years agoR2RDumpTests on Windows_NT.x64.Release (#19315)
Amy [Tue, 7 Aug 2018 00:28:39 +0000 (17:28 -0700)]
R2RDumpTests on Windows_NT.x64.Release (#19315)

6 years agoMerge pull request #19318 from BruceForstall/AddDavidArm64
Bruce Forstall [Tue, 7 Aug 2018 00:16:58 +0000 (17:16 -0700)]
Merge pull request #19318 from BruceForstall/AddDavidArm64

Update arm64 users list

6 years ago[WIP] Update vc-runtime package to support ARM and ARM64 with current builds.
Bruce Forstall [Fri, 3 Aug 2018 03:34:21 +0000 (20:34 -0700)]
[WIP] Update vc-runtime package to support ARM and ARM64 with current builds.

6 years agoUpdate arm64 users list
Bruce Forstall [Mon, 6 Aug 2018 23:02:08 +0000 (16:02 -0700)]
Update arm64 users list

6 years agoPort x86 unwinder fix from .NET Framework (#19311)
Jan Kotas [Mon, 6 Aug 2018 22:43:30 +0000 (15:43 -0700)]
Port x86 unwinder fix from .NET Framework (#19311)

We have not hit this case in CoreCLR yet, but there is a good chance that we will at some point.

6 years agoMerge pull request #19228 from AndyAyersMS/FixDevirtFinalMethod
Andy Ayers [Mon, 6 Aug 2018 21:25:12 +0000 (14:25 -0700)]
Merge pull request #19228 from AndyAyersMS/FixDevirtFinalMethod

Fix resolveVirtualMethodHelper to check for explicit override cases

6 years agoOnly register signals and create alt exception stack in coreclr. (#19309)
Mike McLaughlin [Mon, 6 Aug 2018 19:16:49 +0000 (12:16 -0700)]
Only register signals and create alt exception stack in coreclr. (#19309)

There was a couple of places where the DAC (IsValidObject, GetAppDomainForObject)
assumed that a NULL target/debuggee address would throw an exception that would
be caught by try/catch. Any other invalid address is handled with a software
exception throwed by the read memory functions. In general it is a better overall
design not to have any of the DBI/DAC, etc. code depend on hardware exceptions
being caught. On Linux the C++ runtime sometimes can't handle it. There is a
slight risk that there are other places in the DAC that make the NULL address
assumption but testing so far has found any.

Added PAL_SetInitializeDLLFlags as a fallback to allow the PAL_InitializeDLL flags
to be set for a PAL instance for the DAC where we could still register h/w signals
but not the altstack switching to reduce this risk. The flags can't be build time
conditional because we only build one coreclrpal.a library that all the modules
used. Having a PAL_InitializeFlags function doesn't really help either because of
the PAL_RegisterModule call to PAL_IntializeDLL and the LoadLibrary dance/protocol
that uses it to call the loading module's DLLMain.

Add PAL_SetInitializeFlags; remove flags from PAL_INITIALIZE and PAL_INITIALIZE_DLL
default. Add PAL_InitializeFlags() to allowing the default to be overriden.

6 years agoRegenerating the templated x86 HWIntrinsic tests.
Tanner Gooding [Mon, 6 Aug 2018 15:08:06 +0000 (08:08 -0700)]
Regenerating the templated x86 HWIntrinsic tests.

6 years agoUpdating the x86 HWIntrinsic test templates to log the scenarios they run.
Tanner Gooding [Mon, 6 Aug 2018 15:06:32 +0000 (08:06 -0700)]
Updating the x86 HWIntrinsic test templates to log the scenarios they run.

6 years agoupdate test case
Andy Ayers [Mon, 6 Aug 2018 17:34:04 +0000 (10:34 -0700)]
update test case

6 years agoR2RDump - Ignore sensitive properties to pass tests (#19155)
Amy [Mon, 6 Aug 2018 17:29:08 +0000 (10:29 -0700)]
R2RDump - Ignore sensitive properties to pass tests (#19155)

* Ignore sensitive properties in tests

* Enable for JIT stress

* Keep logic for ignoreSensitive in XmlDumper

* Only ignoreSensitive when option is set

6 years agoImprove StreamWriter format perf (#19235)
Jeremy Kuhne [Mon, 6 Aug 2018 06:22:57 +0000 (23:22 -0700)]
Improve StreamWriter format perf (#19235)

* Improve StreamWriter format perf

Override the format overloads for TextWriter and skip the extra string allocation for the formatted string by using StringBuilder directly, copying straight to the output buffer.

Improves performance roughtly 10% and cuts allocations by 10x and up (formatting a string into a string goes to *zero* allocations).

* Fix copy/paste slipup- test added to CoreFX PR

6 years agoDisable NETClientPrimitives test (#19294)
Bruce Forstall [Mon, 6 Aug 2018 01:07:02 +0000 (18:07 -0700)]
Disable NETClientPrimitives test (#19294)

* Disable NETClientPrimitives test

Fails on many R2R and JitStress jobs.

Tracked by #19164

* Remove disabling under build against packages

6 years agoClean up build.cmd/build-test.cmd/runtest.cmd
Bruce Forstall [Sat, 4 Aug 2018 23:45:59 +0000 (16:45 -0700)]
Clean up build.cmd/build-test.cmd/runtest.cmd

Various minor cleanups:
1. Use the same naming/style for all three.
2. Make the style consistent throughout each. E.g., consistent indents,
   capitalization.
3. Add more consistent output, including the prefix tag used everywhere.
4. build.cmd: only build cross components if native build is enabled.
5. Use new __Logging variable to consolidate all logging arguments,
   to reduce large (unexpanded) command line lengths.

6 years agoMerge pull request #19287 from BruceForstall/Revert19254
Bruce Forstall [Sat, 4 Aug 2018 03:38:39 +0000 (20:38 -0700)]
Merge pull request #19287 from BruceForstall/Revert19254

Revert "Build managed tests with dotnet (#19254)"