Aditya Mandaleeka [Tue, 17 May 2016 23:37:35 +0000 (16:37 -0700)]
Merge pull request #4995 from adityamandaleeka/reenable_native_callable
Reenable NativeCallable test on x86 legacy backend
Aditya Mandaleeka [Tue, 17 May 2016 23:35:45 +0000 (16:35 -0700)]
Update contributing-workflow.md
Fix broken link to CODE_OWNERS file.
Dmitri-Botcharnikov [Tue, 17 May 2016 23:21:36 +0000 (03:21 +0400)]
Fix breakpoints on jitted code for Linux/ARM (#5014)
noahfalk [Tue, 17 May 2016 23:18:15 +0000 (16:18 -0700)]
Start using CODE_OWNERS.TXT (#5027)
Jose Perez Rodriguez [Tue, 17 May 2016 22:21:08 +0000 (17:21 -0500)]
Enable Checksum csc param for mscorlib (#4996)
Enable Checksum csc param for mscorlib
noahfalk [Tue, 17 May 2016 22:10:20 +0000 (15:10 -0700)]
Merge pull request #4954 from kvochko/sos_tests
Added tests for libsosplugin
William Godbe [Tue, 17 May 2016 21:07:45 +0000 (14:07 -0700)]
Merge pull request #5023 from wtgodbe/pipeline
Add dev workflow scripts for build pipeline
wtgodbe [Wed, 27 Apr 2016 21:35:45 +0000 (14:35 -0700)]
Add dev workflow scripts for build pipeline
AlexGhiondea [Tue, 17 May 2016 20:45:59 +0000 (13:45 -0700)]
Merge pull request #4874 from gkhanna79/SPC_S1
Add support for System.Private.CoreLib to be core library
Sejong Oh [Tue, 17 May 2016 20:35:32 +0000 (13:35 -0700)]
Merge pull request #4999 from sejongoh/avoid_ti_method_check
Add typeInfo::GetMehtod2 to avoid checking GetType == TI_METHOD.
Fadi Hanna [Tue, 17 May 2016 18:51:14 +0000 (11:51 -0700)]
Implementing the Unix calling convention for the generic dictionary access stubs in R2R (#4998)
Sejong OH [Mon, 16 May 2016 22:42:07 +0000 (15:42 -0700)]
Add typeInfo::GetMehtod2 to avoid checking GetType == TI_METHOD.
If FEATURE_CORECLR is enabled, the pointer type is not known to be a method pointer type when GetMethod is called in the importer.
Sejong Oh [Tue, 17 May 2016 18:16:27 +0000 (11:16 -0700)]
Merge pull request #4789 from sejongoh/always_download_coredistools
Always download coredistools package
Yi Zhang (CLR) [Tue, 17 May 2016 17:12:04 +0000 (10:12 -0700)]
Merge pull request #5008 from yizhang82/dllimportpath-fix2
Enable DefaultDllImportSearchPathsAttribute in CoreCLR Windows. Host …
Carol Eidt [Tue, 17 May 2016 16:41:30 +0000 (09:41 -0700)]
Merge pull request #5002 from CarolEidt/Long32Doc
Document about supporting long on 32-bit architectures.
James Ko [Tue, 17 May 2016 15:46:08 +0000 (11:46 -0400)]
Optimize Array.GetLength, GetUpperBound, GetLowerBound (#4993)
... if the argument is 0. As the rank will always be greater, this is safe.
Matt Warren [Tue, 17 May 2016 15:42:25 +0000 (16:42 +0100)]
Update StringObject comment in object.h (#5011)
* m_ArrayLength is no longer present (I did a search of the source and couldn't find it), so this comment is misleading.
* Also removing mis-leading comment about high two bits of field
Jan Kotas [Tue, 17 May 2016 15:36:57 +0000 (08:36 -0700)]
Move notion of restricted physical memory behind the GCToOSInterface (#5007)
Russ Keldorph [Tue, 17 May 2016 15:32:15 +0000 (08:32 -0700)]
Merge pull request #4997 from RussKeldorph/fix3379
Rename some IL tests whose names conflicted with C# tests
Yi Zhang (CLR) [Wed, 4 May 2016 06:02:10 +0000 (23:02 -0700)]
Enable DefaultDllImportSearchPathsAttribute in CoreCLR Windows. Host NATIVE_DLL_SEARCH_DIRECTORIES has higher priority.
Jan Kotas [Tue, 17 May 2016 05:46:36 +0000 (22:46 -0700)]
Merge pull request #5003 from jkotas/corert-gc
Update GC from CoreRT
Gaurav Khanna [Mon, 9 May 2016 22:57:44 +0000 (15:57 -0700)]
Initial change to support System.Private.CoreLib.dll as Core Library.
Kshama Pawar [Tue, 17 May 2016 02:25:33 +0000 (19:25 -0700)]
Merge pull request #4975 from kspawa/ldiv
Replace ldiv with normal division for PAL
Sejong Oh [Wed, 4 May 2016 21:06:16 +0000 (14:06 -0700)]
Always download coredistools package
runtest.sh/cmd currently downloads the coredistools package if COMPlus_GCStress variable is set by TestEnv or test-env options. This is a bit complicated and this doesn't work with a new option for GC stress testing in build/buildtest.cmd. This changeset moves downloading the coredistools package to buildtest.cmd where it takes gcstress option and downloads other packages.
Linux build doesn't have buildtest.sh, so package donwloading is still in
runtest.sh
Jan Kotas [Mon, 16 May 2016 23:50:07 +0000 (16:50 -0700)]
Update GC from CoreRT
https://github.com/dotnet/corert/tree/master/src/Native/gc
854b9ea7accfbd24423a10382c1a5a2bd6753450
Russ Keldorph [Mon, 16 May 2016 22:23:15 +0000 (15:23 -0700)]
Rename some IL tests whose names conflicted with C# tests
For catchrettoinnertry, we appeared to have some redundant test projects.
I removed the redundant ones and cleaned up the remaining.
Fixes #3379
Carol Eidt [Tue, 17 May 2016 00:03:30 +0000 (17:03 -0700)]
Document about supporting long on 32-bit architectures.
Carol Eidt [Mon, 16 May 2016 23:29:13 +0000 (16:29 -0700)]
Merge pull request #4962 from CarolEidt/FixIssue3964
Fix CircleInConvex to check result within 1 ULP
Davis Goodin [Mon, 16 May 2016 22:28:47 +0000 (17:28 -0500)]
Merge pull request #4620 from dagood/remove-infer-runtimes
Remove --infer-runtimes restore argument
Michelle McDaniel [Mon, 16 May 2016 22:03:35 +0000 (15:03 -0700)]
Merge pull request #4985 from adiaaida/2442
Update Boxing\xlang projs with correct project includes
Aditya Mandaleeka [Mon, 16 May 2016 21:31:05 +0000 (14:31 -0700)]
Reenable NativeCallable test on x86.
Lubomir Litchev [Mon, 16 May 2016 20:42:06 +0000 (13:42 -0700)]
Merge pull request #4982 from LLITCHEV/Issue4853
Remove invalid tests.
Michelle McDaniel [Fri, 13 May 2016 15:15:20 +0000 (08:15 -0700)]
Update sin projs with correct project includes
All of the xlang sin ilprojs were missing includes to the correct
references. This change updates the proj files with those
ProjectReferences. Additionally, this change updates the includes in the
il tests to match the name of sinlib assemblies.
Fixes #2442.
Michelle McDaniel [Mon, 16 May 2016 19:47:52 +0000 (12:47 -0700)]
Merge pull request #4965 from adiaaida/disableRegPair
Disable RegPair for x86 Longs
Carol Eidt [Fri, 13 May 2016 17:57:18 +0000 (10:57 -0700)]
Fix CircleInConvex to check result within 1 ULP
This test was checking for the result to be within epsilon of the
expected result, but this is not correct unless the algorithm is
evaluating all interim results to a larger precision.
It would also be more reasonable for the test to compute the expected
result (e.g. using an alternate algorithm), and it would also be nice
to have a method to compute ULP for a given value, but those are beyond
the scope of this fix.
Re-enable the test except for RyuJIT/x86.
Fix #3964
Jeremy Kuhne [Mon, 16 May 2016 18:52:36 +0000 (11:52 -0700)]
Merge pull request #4905 from JeremyKuhne/JeremyKuhne-buildupdate
Update windows instructions
Matt Ellis [Mon, 16 May 2016 18:19:23 +0000 (11:19 -0700)]
Merge pull request #4978 from ellismg/add-fedora-23
Add Fedora 23 runs
Lubomir Litchev [Mon, 16 May 2016 17:35:30 +0000 (10:35 -0700)]
Merge remote-tracking branch 'origin/master' into Issue4853
Conflicts:
tests/testsFailingOutsideWindows.txt
Russ Keldorph [Mon, 16 May 2016 17:24:42 +0000 (10:24 -0700)]
Merge pull request #4974 from RussKeldorph/xfails
Test cleanup (mostly non-Windows failures)
Michelle McDaniel [Fri, 13 May 2016 15:35:23 +0000 (08:35 -0700)]
Disable RegPair for x86 Longs
We are not using regpairs for longs on x86 ryujit, so we need to turn off
CPU_LONG_USES_REGPAIR. This is the first step to getting var = call for
GT_CALLs with long return types on x86.
Davis Goodin [Wed, 27 Apr 2016 16:42:54 +0000 (11:42 -0500)]
Add runtimes to each project.json in tests/src missing a runtimes section.
Davis Goodin [Tue, 26 Apr 2016 23:17:22 +0000 (18:17 -0500)]
Remove --infer-runtimes restore arg: runtimes specified in project.json files.
Andrey Kvochko [Mon, 16 May 2016 12:07:14 +0000 (15:07 +0300)]
Added a README with instructions on running and writing tests.
Lubomir Litchev [Mon, 16 May 2016 06:42:55 +0000 (23:42 -0700)]
Merge remote-tracking branch 'origin/master' into Issue4853
Conflicts:
tests/issues.targets
tests/src/JIT/Methodical/cctor/misc/tail.il
tests/src/JIT/Methodical/cctor/misc/threads3.il
tests/src/JIT/Methodical/cctor/simple/precise3.il
tests/x86_legacy_backend_issues.targets
Gaurav Khanna [Mon, 16 May 2016 03:55:02 +0000 (20:55 -0700)]
Merge pull request #4969 from gkhanna79/RelaxALC
Enable overriding assemblies from TPA
Lubomir Litchev [Sun, 15 May 2016 22:54:30 +0000 (15:54 -0700)]
Remove invalid tests.
See comments at issue #4853 for the why these tests are invalid.
Other tests in the same directories are covering the valid cases, so
removing these.
Fixes #4853
Jan Kotas [Sun, 15 May 2016 19:57:06 +0000 (12:57 -0700)]
Merge pull request #4979 from dotnet-bot/from-tfs
Merge changes from TFS
Gaurav Khanna [Fri, 13 May 2016 16:55:19 +0000 (09:55 -0700)]
Enable overriding assemblies from TPA
Jan Kotas [Sun, 15 May 2016 07:28:02 +0000 (00:28 -0700)]
Fix arm and x86 build breaks
[tfs-changeset: 1604843]
Matt Ellis [Sun, 15 May 2016 06:54:21 +0000 (23:54 -0700)]
Add Fedora 23 runs
Bruce Forstall [Sun, 15 May 2016 06:53:51 +0000 (23:53 -0700)]
Remove unneeded INLINE_NDIRECT and INLINE_PINVOKE #ifdefs (#4977)
Matt Ellis [Sun, 15 May 2016 06:09:52 +0000 (23:09 -0700)]
Merge pull request #4976 from dotnet-bot/from-tfs
Merge changes from TFS
Bruce Forstall [Sun, 15 May 2016 04:23:52 +0000 (21:23 -0700)]
Merge pull request #4967 from BruceForstall/Fix3235
Change referenced common.dll assembly to lower-case
Jan Kotas [Sun, 15 May 2016 04:20:09 +0000 (21:20 -0700)]
Fix build breaks in arm64 and legacy internal amd64 builds
[tfs-changeset: 1604829]
AlexGhiondea [Sun, 15 May 2016 04:15:16 +0000 (21:15 -0700)]
Use different value for win32resource for System.Private.CoreLib. (#4964)
When building both mscorlib and System.Private.CoreLib we should use a different name to avoid conflicting on this file.
Kshama Pawar [Sun, 15 May 2016 03:05:50 +0000 (20:05 -0700)]
Replace ldiv with normal division for PAL
Russ Keldorph [Sat, 14 May 2016 13:52:19 +0000 (06:52 -0700)]
Test cleanup (mostly non-Windows failures)
Clean up the hodgepodge of failures in #2450. Many of them are simply bad
exclusions for tests that don't exist either because they were deleted or
never actually ported. The rest were fixed more or less as recommended by
@LLITCHEV.
Fixes #2450
Russ Keldorph [Sun, 15 May 2016 00:41:18 +0000 (17:41 -0700)]
Merge pull request #4972 from RussKeldorph/fix2235
Re-enable arrres.il test
Bruce Forstall [Fri, 13 May 2016 16:42:17 +0000 (09:42 -0700)]
Change referenced common.dll assembly to lower-case
Also, change ILPart.dll to lower-case.
Fixes a bunch of tests that were failing on Ubuntu. Re-enable those.
Fixes #3235.
Jan Kotas [Sat, 14 May 2016 06:40:00 +0000 (23:40 -0700)]
Add support for reverse PInvoke callouts to the JIT (#4952)
Rama krishnan Raghupathy [Sat, 14 May 2016 05:32:52 +0000 (22:32 -0700)]
Merge pull request #4927 from ramarag/ModifyBuildOnly
Removing Redundant Projects that are BuildOnly:
Russ Keldorph [Sat, 14 May 2016 04:19:36 +0000 (21:19 -0700)]
Re-enable arrres.il test
arrres.il is a quesionable test case because it relies on finalizers being
run even though the JIT is allowed to extend the lifetime of objects
beyond the point where finalizer effects are checked. The test could be
fixed, but for now I'm just marking it as requiring optimization, which is
what has been done previously. I'm deleting the "dbg" project because it
is the same as the "rel" project except that it disables optimization.
Fixes #2330
Fadi Hanna [Sat, 14 May 2016 03:35:54 +0000 (20:35 -0700)]
Initial implementation of generic dictionary access for R2R. (#4519)
For now, only TypeHandle dictionary entry slots are supported and encoded in a R2R version resilient format (the rest to come soon).
Support is only limited for x64 Windows platforms (rest is still TODO)
The basic idea: each dictionary access is initally a call to a DynamicHelper R2R cell that computes the dictionary signature, and patches the R2R cell address with an assembly stub that performs the dictionary lookup.
Rama krishnan Raghupathy [Thu, 12 May 2016 06:56:29 +0000 (23:56 -0700)]
Removing Redundant Projects that are BuildOnly :
RunOnly Projects should refer to only BuildAndRun projects
BuildOnly projects are to be used only for Non-Execution cases
and custom execution drivers
Bruce Bowyer-Smyth [Sat, 14 May 2016 02:25:22 +0000 (12:25 +1000)]
Port string.PadLeft and string.PadRight from CoreRT (#4968)
Jan Kotas [Sat, 14 May 2016 02:24:38 +0000 (19:24 -0700)]
Merge pull request #4970 from dotnet-bot/from-tfs
Merge changes from TFS
Pat Gavlin [Fri, 13 May 2016 23:39:52 +0000 (16:39 -0700)]
Fix a PCH-related issue in the jitstdout change.
[tfs-changeset: 1604771]
Jarret Shook [Fri, 13 May 2016 23:37:32 +0000 (16:37 -0700)]
Merge pull request #4901 from LLITCHEV/Issue4801
Add a issues target file with tests to be excluded on jit32 x86.
Lubomir Litchev [Tue, 10 May 2016 23:44:40 +0000 (16:44 -0700)]
Add a issues target file with thests to be excluded on jit32 x86.
Aditya Mandaleeka [Fri, 13 May 2016 21:45:27 +0000 (14:45 -0700)]
Merge pull request #4922 from adityamandaleeka/remove_getfilenamefromsymlink
Change how PAL file I/O functions treat symbolic links
Sean Gillespie [Fri, 13 May 2016 21:13:21 +0000 (14:13 -0700)]
Merge pull request #4958 from swgillespie/disable-gcstress
Exclude from GCStress a few tests that take an unreasonably long time to complete
Pat Gavlin [Fri, 13 May 2016 21:02:56 +0000 (14:02 -0700)]
Merge pull request #4942 from pgavlin/gh4832
Use a JIT-specific stdout `FILE*`.
Russ Keldorph [Fri, 13 May 2016 20:55:41 +0000 (13:55 -0700)]
Merge pull request #4957 from RussKeldorph/fix2235
Reenable passing tests
Andy Ayers [Fri, 13 May 2016 20:23:49 +0000 (13:23 -0700)]
Merge pull request #4961 from AndyAyersMS/RandomInlineBudgetLimit
Add budget check to RandomPolicy
Brian Sullivan [Fri, 13 May 2016 19:51:37 +0000 (12:51 -0700)]
Merge pull request #4955 from briansull/fix-asmdiff
Fix issue with Arm64 AsmDiffs
Matt Mitchell [Fri, 13 May 2016 19:02:43 +0000 (12:02 -0700)]
Merge pull request #4956 from mmitche/gcstress-no-push
Run gcstress pri1r2r only a few times a week
tijoytom [Fri, 13 May 2016 18:44:26 +0000 (11:44 -0700)]
Merge pull request #4959 from tijoytom/master
Renaming to StringToCoTaskMemUTF8
Andy Ayers [Fri, 13 May 2016 18:32:49 +0000 (11:32 -0700)]
Add budget check to RandomPolicy
Prevents RandomPolicy from being overly aggressive with small methods
that can lead to excessive inlining.
Closes #4711. Undoes #4704.
tijoytk [Fri, 13 May 2016 18:07:28 +0000 (11:07 -0700)]
Renaming the API StringToCoTaskMemUTF8 since we
need to be consistent with existing one.Also
fixing a merge conflict.
Sean Gillespie [Fri, 13 May 2016 17:38:19 +0000 (10:38 -0700)]
Exclude from GCStress a few tests that take an unreasonably long time to complete
Matt Mitchell [Fri, 13 May 2016 17:19:57 +0000 (10:19 -0700)]
Run gcstress pri1r2r only a few times a week
Currently this is set on push, but since it can take days to run this is a bad idea
Russ Keldorph [Fri, 13 May 2016 17:12:52 +0000 (10:12 -0700)]
Reenable passing tests
Many of the tests listed in #2235 are now passing since their dependencies
have been fixed. b57367 is a notable exception; it's static dependency is
now satisfied, but at runtime it loads a type that is not present in .NET
Core. I'm deleting it because I verified there are other tests that test
the same load/invoke pattern (on different types).
The rest of the tests listed in #2235 have already been deleted for other
reasons.
Fixes #2235
Brian Sullivan [Fri, 13 May 2016 17:11:58 +0000 (10:11 -0700)]
Fix issue with Arm64 AsmDiffs
tijoytom [Fri, 13 May 2016 17:08:23 +0000 (10:08 -0700)]
Merge pull request #4911 from tijoytom/master
Marshaling helpers for MarshalAs LPUTF8Str.
Andrey Kvochko [Fri, 13 May 2016 15:02:13 +0000 (18:02 +0300)]
Added tests for libsosplugin
Pat Gavlin [Fri, 13 May 2016 13:30:46 +0000 (06:30 -0700)]
Merge pull request #4813 from pgavlin/gh3058
Disable FEATURE_MERGE_JIT_AND_ENGINE on *nix.
Andy Ayers [Fri, 13 May 2016 07:34:40 +0000 (00:34 -0700)]
Merge pull request #4921 from AndyAyersMS/InlineReplay
Inliner: introduce ReplayPolicy
Pat Gavlin [Fri, 13 May 2016 03:48:39 +0000 (20:48 -0700)]
Address code review feedback.
Flip the order of the PID and activation function checks in the activation
signal handler.
Pat Gavlin [Wed, 11 May 2016 20:41:07 +0000 (13:41 -0700)]
Chain activation signal handlers in the PAL.
The handler for the PAL's activation signal (`SIGRTMIN` on Linux) was
not properly chaining to the previous handler. This caused problems
with thread suspension on Linux in the case that multiple PALs were
loaded in a process: whichever PAL was loaded last would handle the
signal, and if that PAL was not configured to perform the appropriate
thread suspension, the runtime would hang.
Gaurav Khanna [Fri, 13 May 2016 03:42:13 +0000 (20:42 -0700)]
Merge pull request #4941 from gkhanna79/Fix4938
Enable SHA256 to be used as hashing algorithm for compiler/assembler
Matt Ellis [Fri, 13 May 2016 02:48:23 +0000 (19:48 -0700)]
Merge pull request #4945 from dotnet-bot/from-tfs
Merge changes from TFS
Aditya Mandaleeka [Fri, 13 May 2016 01:04:47 +0000 (18:04 -0700)]
Stop using SYS_delete syscall for deleting files.
Aditya Mandaleeka [Wed, 11 May 2016 23:58:54 +0000 (16:58 -0700)]
Add tests for file IO functions operating on symlinks.
John Chen [Fri, 13 May 2016 00:39:03 +0000 (17:39 -0700)]
Merge pull request #4932 from JohnChen0/r2r
Fix contract violations in Ready to Run code
Kyungwoo Lee [Fri, 13 May 2016 00:00:18 +0000 (17:00 -0700)]
Merge pull request #4933 from dotnet-bot/from-tfs
Merge changes from TFS
Andy Ayers [Tue, 10 May 2016 21:19:41 +0000 (14:19 -0700)]
Inliner: introduce ReplayPolicy
The ReplayPolicy reads an external script to determine which inlines
to perform. The script is the same Xml syntax that's produced by
the inliner when JitInlineDumpXml is enabled. This format can be edited
by hand or tool to force particular inlining patterns to occur. Methods
or calls sites not mentioned in the script are considered as noinline.
There's a bunch of work still left to make this fully robust, but in
testing it works well enough for my immediate use case that I'll hold
off on further polish until it's needed. But, for future reference,
here's a laundry list:
* Need better ways to identify methods. Token and hash are not enough.
* Need better ways to identify call sites. Callee token is not enough.
* Consider preparsing or mapping the script into memory.
* Consider caching node positions in the InlineContexts.
* Make it robust for multithreading.
* Handle the prejit root case somehow.
* Possibly allow overriding of inline attributes.
Carol Eidt [Thu, 12 May 2016 23:34:00 +0000 (16:34 -0700)]
Update first-class-structs.md
Update some progress and fix some formatting
Pat Gavlin [Thu, 12 May 2016 21:32:13 +0000 (14:32 -0700)]
Use a JIT-specific stdout `FILE*`.
Historically, the JIT has had issues with logging inside of processes
that change the output mode of stdout (e.g. crossgen). This change
replaces the previous solution (which relied on #ifdefs) by dup'ing
the stdout file and wrapping it in a new `FILE*` set to a known
output mode.
Gaurav Khanna [Thu, 12 May 2016 23:08:10 +0000 (16:08 -0700)]
Enable SHA256 to be used as hashing algorithm for compiler/assembler
Russ Keldorph [Thu, 12 May 2016 23:07:27 +0000 (16:07 -0700)]
Small formatting fix