maxerba [Wed, 29 Jan 2014 18:20:39 +0000 (19:20 +0100)]
Updating hungarian translation
Mike Blumenkrantz [Wed, 29 Jan 2014 15:52:36 +0000 (10:52 -0500)]
add screensaver active edje signal for idle freezing
I forgot to commit this the other day I guess
Ryuan Choi [Wed, 29 Jan 2014 14:08:55 +0000 (23:08 +0900)]
fileselector: Fixed that data of "done" signal may start with two slash
When moved to root(/) and typed something in name_entry,
ok button sent //something as as data of "done" signal.
This patch checked current path string not to concatenate two slash.
Carsten Haitzler (Rasterman) [Wed, 29 Jan 2014 09:53:10 +0000 (18:53 +0900)]
theme - support icon provider message for e comp frames
Daniel Hirt [Tue, 28 Jan 2014 14:36:38 +0000 (14:36 +0000)]
elm entry: Fix anchor bug finding wrong anchor geometry.
Summary: Fix a bug with finding the proper geometry when reporting anchor
interaction. It's easy to see in entry anchor2 test in elementary_test
when clicking on the lower border of the anchor.
Anchor geometries are relative to the textblock object. The problem was
that this was accounted for using the edje object's geometry instead of
the textblock geometry thus causing an offset.
Reviewers: JackDanielZ, tasn
CC: seoz
Differential Revision: https://phab.enlightenment.org/D436
TAsn: Commit message edited by me.
Ryuan Choi [Tue, 28 Jan 2014 07:16:44 +0000 (16:16 +0900)]
fileselector: Fixed that does not navigate / on path_entry
href=/> are not working because /> is considered to self closing tag.
Instead. href='/'> is fine since rEFL2d4ba9e8d
Mike Blumenkrantz [Mon, 27 Jan 2014 14:46:22 +0000 (09:46 -0500)]
reduce iconify animation durations for fast comp effect groups
T860
davemds [Sun, 26 Jan 2014 22:49:07 +0000 (23:49 +0100)]
Packagekit module: try a new icon.
New icon for the E module as discussed on T427, I'm not
really happy by all the bits but its a good start. Also put
in the inkscape svg mockup file.
Thanks to ragecryx that draw the base icon!
Daniel Juyung Seo [Sun, 26 Jan 2014 17:07:44 +0000 (02:07 +0900)]
elm: Unified the usage of strncmp.
- Use strlen instead of sizeof(x) - 1 for string length calculation.
- Use !strncmp for null check.
Ryuan Choi [Sun, 26 Jan 2014 03:20:03 +0000 (12:20 +0900)]
test_web_ui: Added a button to test select tag and window.open()
elm_web provide UI compoents by extending ewebkit.
This patch adds a button to test select tag and window.open()
Ryuan Choi [Sun, 26 Jan 2014 03:16:07 +0000 (12:16 +0900)]
web: Follow latest webkit change to fix build break with latest ewebkit
ewk_view_tiled was dropped.
ewk_view_single -> ewk_view.
ChunEon Park [Sat, 25 Jan 2014 17:19:23 +0000 (02:19 +0900)]
fileselector - use the internal widget apis as possible.
We already know some apis are just wrapping the internal widget apis.
Iternally we don't need to call the external apis that have additional object validation checking.
Tom Hacohen [Fri, 24 Jan 2014 17:35:37 +0000 (17:35 +0000)]
Revert "[naviframe] Fix to hide the previous view by emitting signal"
This breaks elementary_config (open it and you'll see the weird bugs on
the top left corner). Please fix it and recommit as needed. I have no
time to dive into naviframe and see what this patch is meant to be
doing.
This reverts commit
e3784b68e01849a99e06f31e02192ffb19d1275c.
Cedric BAIL [Fri, 24 Jan 2014 03:08:33 +0000 (12:08 +0900)]
PKGBUILD - follow changes in defining version with efl.m4
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D492
Signed-off-by: Cedric BAIL <cedric.bail@samsung.com>
Cedric BAIL [Fri, 24 Jan 2014 02:13:28 +0000 (11:13 +0900)]
autotools: let's override what we just did set.
ChunEon Park [Fri, 24 Jan 2014 02:07:58 +0000 (11:07 +0900)]
elementary - fix the build break.
caused by commit
9aa68bca91678dcd83de3e35be1a7121094d6ef7.
fix please cedric if this is wrong.
Daniel Juyung Seo [Fri, 24 Jan 2014 01:51:12 +0000 (10:51 +0900)]
naviframe: Better structure packing for naviframe item and added more
description about item structure members.
Cedric BAIL [Fri, 24 Jan 2014 01:28:05 +0000 (10:28 +0900)]
autotools: restore support of static compilation.
This should fix T599.
Daniel Juyung Seo [Thu, 23 Jan 2014 14:15:39 +0000 (23:15 +0900)]
elm: Defined the same macro, MAX and MIN, in elm_priv.h
MAX and MIN are defined in a couple of places and they was already
defined in elm_priv.h. So use elm_priv.h's one.
I also moved CEIL to elm_priv.h that can be used in another places.
Daniel Juyung Seo [Thu, 23 Jan 2014 14:11:12 +0000 (23:11 +0900)]
list: Used macro for list swipe time like genlist.
Daniel Juyung Seo [Thu, 23 Jan 2014 14:09:28 +0000 (23:09 +0900)]
entry: Renamed internal macro name with prefix ELM_ENTRY for
consistency.
_CHUNK_SIZE -> ELM_ENTRY_CHUNK_SIZE.
Daniel Juyung Seo [Thu, 23 Jan 2014 14:05:24 +0000 (23:05 +0900)]
entry: Used macro for entry delay write time.
Daniel Juyung Seo [Thu, 23 Jan 2014 13:58:56 +0000 (22:58 +0900)]
conform: Use macro for indicator timer.
Daniel Juyung Seo [Thu, 23 Jan 2014 11:08:10 +0000 (20:08 +0900)]
edje_externals: Fixed formatting before working on it.
Ryuan Choi [Thu, 23 Jan 2014 13:22:33 +0000 (22:22 +0900)]
elm_cnp: Fix that calls _x11_elm_widget_xwin_get two times at elm_cnp_selection_{set|get}
small refactoring.
ChunEon Park [Thu, 23 Jan 2014 11:20:43 +0000 (20:20 +0900)]
elementary - override widget translation but work also the base widget's behavior.
Some widgets override the widget translation but it didn't inherit the base widget's function.
Becuase of it,The language changed won't be properly called in the widget tree.
Now it fixed it.
ChunEon Park [Thu, 23 Jan 2014 11:07:20 +0000 (20:07 +0900)]
elementary - support language changed callback from a few widgets.
support a language,changed callback if a widget has the text part in default.
ChunEon Park [Thu, 23 Jan 2014 10:30:34 +0000 (19:30 +0900)]
elementary - send signal "language,changed" with one way in the widget.
Call the smart callback in the widget infra so that each widget don't need to hook the smart_translate only for the smart call.
This makes reducing duplicated code and supporting language,chagned from all widgets.
ChunEon Park [Thu, 23 Jan 2014 08:24:19 +0000 (17:24 +0900)]
elementary - use the focused/unfocused string in widget defined.
Now, it will share the strings so that reduce the binary size also user uses it in one way.
WooHyun Jung [Thu, 23 Jan 2014 06:07:33 +0000 (15:07 +0900)]
test_focus3: Correct wrong data for smart callback.
Amitesh Singh [Thu, 23 Jan 2014 05:12:46 +0000 (14:12 +0900)]
focus: Fixed focus issue that the highlight was not visible on first
click.
Summary:
Focus highlight was not visible on first click on a widget with focus_highlight enabled on the window.
This happens because on first click, the "elm,action,focus,show" signal was emitted before setting focus highlight edje object as theme object of elm window.
In this patch, moved the _elm_win_focus_highlight_visible_set() call after focus highlight edje object set as theme object of window.
This fixes T774.
Test Plan:
elementary_test->focus then click any widget. Focus won't appear for the first time.
Reviewers: seoz, raster, woohyun
Maniphest Tasks: T774
Differential Revision: https://phab.enlightenment.org/D462
Carsten Haitzler (Rasterman) [Thu, 23 Jan 2014 02:59:07 +0000 (11:59 +0900)]
naviframe - don't access item after del
Daniel Juyung Seo [Wed, 22 Jan 2014 16:51:04 +0000 (01:51 +0900)]
test_hoversel: Change the hoversel button text when an hoversel item is
selected.
This reveals hoversel bug on mobile profile that changes the size of
text parts on continuous item change.
Daniel Juyung Seo [Wed, 22 Jan 2014 16:24:42 +0000 (01:24 +0900)]
spinner: Uncomment ctype.h inclusion because isspace is used.
It looks like ctype.h is included in some other headers by luck but it
is recommended to explicitly include the necessary header.
Confirmed by glima as he commented this out.
Daniel Juyung Seo [Wed, 22 Jan 2014 15:11:48 +0000 (00:11 +0900)]
spinner: Internal code clean up for spinner.
- Used macro for constant.
- Changed timer name to be more descriptive.
- Added descriptions about timers.
Carsten Haitzler (Rasterman) [Wed, 22 Jan 2014 15:28:13 +0000 (00:28 +0900)]
theme - win shadow - stack under all so pulsing icon is not BELOW the shadow.
Daniel Juyung Seo [Wed, 22 Jan 2014 14:33:16 +0000 (23:33 +0900)]
naviframe: Use elm_widget_item_del() when you want to delete the item
data.
It will call del_pre_func and free the item data.
Special thanks to glima for the report.
Jaehyun Cho [Wed, 22 Jan 2014 13:13:51 +0000 (22:13 +0900)]
[naviframe] Fix to enable item deletion in pop_cb
Summary: Fix to enable item deletion in the registered pop_cb function
Reviewers: Hermet
Reviewed By: Hermet
CC: seoz
Differential Revision: https://phab.enlightenment.org/D487
Jaehyun Cho [Wed, 22 Jan 2014 13:09:16 +0000 (22:09 +0900)]
[naviframe] do not size evaluate during deletion
Summary: Author: Shinwoo Kim <cinoo.kim@samsung.com> 2012-12-11 20:13:39
Reviewers: Hermet
CC: seoz
Differential Revision: https://phab.enlightenment.org/D485
Jaehyun Cho [Wed, 22 Jan 2014 13:07:30 +0000 (22:07 +0900)]
[naviframe] Fix to hide the previous view by emitting signal
Summary:
Previously, previous view was hidden by evas_object_hide.
However, this method is no longer correct because size calculation of naviframe causes evas_object_show.
Now, previous view is hidden by emitting signal to naviframe theme and clipper hides the previous view.
Reviewers: Hermet
Reviewed By: Hermet
CC: seoz
Differential Revision: https://phab.enlightenment.org/D484
Daniel Juyung Seo [Wed, 22 Jan 2014 06:53:49 +0000 (15:53 +0900)]
fileselector: Make fileselector focusable. Ok on Enter key and Cancel on Escape key.
Now fileselector accepts the key event on Enter and Escape.
Daniel Juyung Seo [Wed, 22 Jan 2014 09:25:55 +0000 (18:25 +0900)]
fileselector_button: Added missing description about focus signals.
WooHyun Jung [Wed, 22 Jan 2014 09:36:13 +0000 (18:36 +0900)]
popup: Replace focus_direction_go with focus_cycle.
Carsten Haitzler (Rasterman) [Wed, 22 Jan 2014 09:32:24 +0000 (18:32 +0900)]
theme update to handle rename on/off in efm
shoudl fix T799
WooHyun Jung [Wed, 22 Jan 2014 07:24:25 +0000 (16:24 +0900)]
elm_widget: Fixed some codes about focus custom chain.
- When appending an object to the focus custom chain,
event callback about deletion should be added.
- When a widget is deleted, its focus custom chain should be
managed correctly.
Daniel Juyung Seo [Wed, 22 Jan 2014 06:17:45 +0000 (15:17 +0900)]
ctxpopup: Fixed typo and flourished comment.
Carsten Haitzler (Rasterman) [Wed, 22 Jan 2014 06:19:17 +0000 (15:19 +0900)]
elm filesel - scale button in filesel button.
Carsten Haitzler (Rasterman) [Wed, 22 Jan 2014 06:17:47 +0000 (15:17 +0900)]
elm filesel - fix theme layout for button+entry
Carsten Haitzler (Rasterman) [Wed, 22 Jan 2014 06:14:15 +0000 (15:14 +0900)]
inwin - the "greying out" fade looks just wrong - make it black.
Jihoon Kim [Wed, 22 Jan 2014 04:20:15 +0000 (13:20 +0900)]
fix some typos in comment and description
Daniel Juyung Seo [Wed, 22 Jan 2014 03:32:32 +0000 (12:32 +0900)]
test_conform_indicator: Refactor internal code of conform_indicator test
code.
- removed unnecessary casting.
- removed unnecessary internal variables.
- removed wrong window resize object addition.
- changed parent parameter correctly.
- fixed wrong grammar in command line message.
- fixed resource leak.
- enhanced comments.
- removed unnecessary size hint align set.
- removed unnecessary parameter passing.
Daniel Juyung Seo [Wed, 22 Jan 2014 03:07:55 +0000 (12:07 +0900)]
config: Added more description about elm_config_indicator_service_get().
Youngbok Shin [Wed, 22 Jan 2014 02:32:08 +0000 (11:32 +0900)]
entry: Fixed to emit "*enabled" signal to scr_edje when it is not disabled.
Summary: This fixes coverity issue CID 1162751.
Reviewers: seoz, woohyun, tasn
Reviewed By: seoz
Differential Revision: https://phab.enlightenment.org/D482
Daniel Juyung Seo [Wed, 22 Jan 2014 02:14:23 +0000 (11:14 +0900)]
elm: Removed unnecessary null checks.
As all efl public free apis and free function get null as valid parameter,
we do not need to check null. I also used ELM_SAFE_FREE if necessary.
After this job code got cleaner.
This is a continue of a commit
e3372339.
Daniel Juyung Seo [Wed, 22 Jan 2014 02:13:30 +0000 (11:13 +0900)]
elm: Removed unnecessary null check for eina_hash_free and
elm_widget_stringlist_free.
Daniel Juyung Seo [Wed, 22 Jan 2014 02:08:47 +0000 (11:08 +0900)]
elm: Removed unnecessary null check for free.
Daniel Juyung Seo [Wed, 22 Jan 2014 01:47:33 +0000 (10:47 +0900)]
elm: Removed unnecessary null check for eina_list_free.
Daniel Juyung Seo [Wed, 22 Jan 2014 01:47:03 +0000 (10:47 +0900)]
elm: Removed unnecessary null check for ecore_event_handler_del.
Daniel Juyung Seo [Wed, 22 Jan 2014 01:38:55 +0000 (10:38 +0900)]
elm: Removed unnecessary null check for evas_object_del.
Daniel Juyung Seo [Wed, 22 Jan 2014 01:12:44 +0000 (10:12 +0900)]
elm: Removed unnecessary null check for eina_stringshare_del.
Daniel Juyung Seo [Wed, 22 Jan 2014 00:55:58 +0000 (09:55 +0900)]
elm: Removed unnecessary null check for ecore_idler_del, ecore_idle_enterer_del.
Daniel Juyung Seo [Tue, 21 Jan 2014 14:53:48 +0000 (23:53 +0900)]
test, examples fileselector_entry: Changed the usage of deprecated APIs
to recommended APIs.
Daniel Juyung Seo [Tue, 21 Jan 2014 14:50:31 +0000 (23:50 +0900)]
fileselector_entry: Moved declarations of deprecated APIs to
elm_deprecated.h and marked them as EINA_DEPRECATED in c code.
Daniel Juyung Seo [Tue, 21 Jan 2014 14:43:59 +0000 (23:43 +0900)]
test, examples fileselector_button: Changed the usage of deprecated APIs to recommended
APIs.
Daniel Juyung Seo [Tue, 21 Jan 2014 14:42:56 +0000 (23:42 +0900)]
fileselector_button: Moved declarations of deprecated APIs to
elm_deprecated.h and marked them as EINA_DEPRECATED in c code.
Daniel Juyung Seo [Tue, 21 Jan 2014 14:23:37 +0000 (23:23 +0900)]
url: Added underscore(_) to elm internal functions, elm_url_xxx.
- _elm_url_download, _elm_url_cancel, _elm_url_get
- other internal functions in elm_priv.h also have same prefix.
Daniel Juyung Seo [Tue, 21 Jan 2014 14:16:41 +0000 (23:16 +0900)]
elm: Removed unnecessary null check for ecore_timer_del,
ecore_animator_del, and ecore_job_del.
As all efl public free apis get null as valid parameter, we do not need
to check null. I also removed some null check for other free apis which
were right next to timer/animator/job del. After this job code got
cleaner.
Ryuan Choi [Tue, 21 Jan 2014 13:50:35 +0000 (22:50 +0900)]
Introduce fileselector interface and applied to elm_fileselector.
Summary:
fileselector_button and fileselector_entry should have almost same interfaces with fileselector.
Previously , we exposed them individually such as elm_fileselector_is_save_set().
Instead of adding the same APIs three times, we can reuse one fileselector's API using Eo interface.
This patch introduced fileselector interface and applied it to elm_fileselector.
Reviewers: seoz, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D475
Daniel Juyung Seo [Tue, 21 Jan 2014 13:12:53 +0000 (22:12 +0900)]
spinner: Create an internal entry when it is really needed.
Do not create the internal entry on smart add. Create that when it is
needed with editable mode.
Daniel Juyung Seo [Tue, 21 Jan 2014 12:59:41 +0000 (21:59 +0900)]
spinner: Toggle entry on Enter and space key.
WooHyun Jung [Tue, 21 Jan 2014 12:00:29 +0000 (21:00 +0900)]
entry: NULL should be set to the correct position of tmpbuf.
If edje_object_part_text_get gives different text from original one,
length of text can be changed. So the last position of tmpbuf should
be calculated again refering to the current text to be returned.
Daniel Juyung Seo [Tue, 21 Jan 2014 10:57:22 +0000 (19:57 +0900)]
toolbar: Do not check ev->string for Return key and react on space key.
space key works as same as Return key.
Daniel Juyung Seo [Tue, 21 Jan 2014 03:08:20 +0000 (12:08 +0900)]
elm: Fixed formatting about EINA_LOG stuff.
Daniel Juyung Seo [Thu, 16 Jan 2014 00:34:16 +0000 (09:34 +0900)]
test_focus: Call window object show after its content creation.
This is a successor commit of
64fd5a825b24591aedb9cac695d03f5b4d867442.
Window show call triggers all smart objects' smart calculation and in case of
X11, XMapWindow() is called directly.
Also moved resize of window accordingly.
Yakov Goldberg [Tue, 21 Jan 2014 09:29:57 +0000 (11:29 +0200)]
widget: doxygen fix
Yakov Goldberg [Tue, 21 Jan 2014 08:44:45 +0000 (10:44 +0200)]
all widgets: change Eo API for "elm_widget_theme()" to "theme_apply"
There are elm_widget_theme/theme_set/theme_get functions.
In Eolian these functions will be described as "theme" method and
"theme" property. There is clash here.
So add suffix "_apply" to Eo API for "elm_widget_theme".
SangHyeon Lee [Tue, 21 Jan 2014 07:54:59 +0000 (16:54 +0900)]
[Gengrid] Refactoring gengrid item show reigion calculation
Summary:
Gengrid _item_show_region function calculate gengrid x, y moving postion with scroll to type.
Belows are summaries of this refactoring works.
1. Refactoring recalculation of scroll type.
2. Bug fix :
- when x or y is 0, y or x value is set as default value, it->position-1.
- when x or y is less then 1, calculation is not correct.
- make calculate correct position of y when even though scroll direction is horiziontal
(when virtical, x is also calculation correct position).
3. change smart data variable s_type to scroll_to_type to make unity on gen widget.
(genlist smart data variable name is scroll_to_type);
Reviewers: seoz, Hermet, raster
Reviewed By: raster
CC: bluezery
Differential Revision: https://phab.enlightenment.org/D474
davemds [Mon, 20 Jan 2014 19:22:41 +0000 (20:22 +0100)]
PackageKit theme: pass make distcheck
Also the image used by the edc need to be included in the tarball
zmike [Mon, 20 Jan 2014 18:25:59 +0000 (13:25 -0500)]
prefs init should probably clean up after itself when it fucks up
zmike [Mon, 20 Jan 2014 18:25:37 +0000 (13:25 -0500)]
prefs should CRI on add/file_set if init has failed
Stefan Schmidt [Mon, 20 Jan 2014 14:37:06 +0000 (15:37 +0100)]
theme: Add packagekit edc to fix make distcheck
Adding it to EXTRA_DIST makes ure it gets packaged in the tarball
and is available for a plain tarball build.
Youngbok Shin [Mon, 20 Jan 2014 09:54:20 +0000 (18:54 +0900)]
conform: Fixed to get a geometry from *focus_region_get for show_region_job.
Summary:
The geometry of elm_widget_show_region_get is only updated by elm_widget_show_region_set.
If the geometry of *show_region_get is not updated, the result of show_region_job would be incorrect.
So, we need to get a proper geometry using *focus_region_get for focused object.
Reviewers: seoz, woohyun, Hermet, raster, tasn
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D466
Youngbok Shin [Mon, 20 Jan 2014 09:45:51 +0000 (18:45 +0900)]
entry: Add smart activate for accessbility.
Summary:
In TTS mode, when the entry is highlighten and double tap to the entry,
the entry will be focused. But "clicked" smart callback is not called, input panel is not shown.
So I we need to call the callback and show input panel in smart activate.
Reviewers: seoz, Hermet, woohyun, tasn, jaehwan, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D465
Youngbok Shin [Mon, 20 Jan 2014 09:04:30 +0000 (18:04 +0900)]
entry: If the scrollable entry is set disable, send "*,disabled" signal to scr_edje too.
Summary:
Default theme of entry does not have any disabled state in "elm/scroller/entry/*" styles.
But EFL developer can make any custom style for entry and scroller and it can has disabled state.
So _elm_entry_smart_disable has to emit "*disabled" signal to scr_edje.
Reviewers: woohyun, tasn, seoz, Hermet, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D464
davemds [Sun, 19 Jan 2014 10:37:00 +0000 (11:37 +0100)]
theme for the packagekit module IN
Ryuan Choi [Sun, 19 Jan 2014 06:31:20 +0000 (15:31 +0900)]
fileselector_button, fileselector_entry: Updated FOO_inwin_mode_set() documentation.
fileselector_button initialize inwin mode using the configuration.
Fixed wrong information about default value in API documentation.
In addition, fixed test_fileselector_button.cpp not to show wrong information at initial time.
Carsten Haitzler (Rasterman) [Sat, 18 Jan 2014 10:52:24 +0000 (19:52 +0900)]
theme - ibar - emit show doen signal for ibar menu
zmike [Sat, 18 Jan 2014 06:56:12 +0000 (01:56 -0500)]
SHUT UP ELM PREFS!!!!!!!!!!
seriously, this is and has been bullshit since it was added. I don't need an error message every time I do ANYTHING just because some module has never been found.
Mike Blumenkrantz [Thu, 16 Jan 2014 16:44:31 +0000 (11:44 -0500)]
tweak e menu shadow offsets
T793
Ryuan Choi [Thu, 16 Jan 2014 15:19:49 +0000 (00:19 +0900)]
flipselector: Remove unused variable of Elm_Flipselector_Item
The data for callback is stored in Widget's data variable.
So, Elm_Flipselector_Item's data variable is not needed.
Ryuan Choi [Thu, 16 Jan 2014 14:48:36 +0000 (23:48 +0900)]
test_flipselector: Fixed that buttons use wrong flipselector which is not intended.
Since
e2db48abe, disabled flipselector was passed button callbacks.
So, buttons just print warnings instead of the intended behavior.
Ryuan Choi [Thu, 16 Jan 2014 13:44:07 +0000 (22:44 +0900)]
datetime: Delay elm_layout_theme_set until memebers are initialized in _smart_add
There are some warnings in elm_object_disabled_set() because elm_layout_theme_set()
calls _elm_datetime_smart_disable() before creating file->item_obj.
This patch refactors _smart_add to initialize file->item_obj before calling
elm_layout_theme_set().
Jihoon Kim [Wed, 15 Jan 2014 23:43:58 +0000 (08:43 +0900)]
Fix unknown command warning in generating doxygen
elementary/src/lib/elm_access.h:238: warning: Found unknown command `\type'
elementary/src/lib/elm_bg_legacy.h:98: warning: Found unknown command `\r'
elementary/src/lib/elm_bg_legacy.h:98: warning: Found unknown command `\g'
elementary/src/lib/elm_object.h:124: warning: Found unknown command `\content'
elementary/src/lib/elm_image_legacy.h:82: warning: Found unknown command `\group'
elementary/src/lib/elm_image_legacy.h:56: warning: Found unknown command `\group'
Ryuan Choi [Wed, 15 Jan 2014 19:27:47 +0000 (04:27 +0900)]
panel: Guarantee the integrity of parameter
- Check whether ret is NULL.
- Guarantee hidden variable is only EINA_TRUE or EINA_FALSE.
Ryuan Choi [Wed, 15 Jan 2014 19:10:38 +0000 (04:10 +0900)]
panel: Check whether sd->content is NULL in _panel_toggle
sd->content can be NULL when elm_panel_hidden_set is called.
Ryuan Choi [Wed, 15 Jan 2014 19:02:11 +0000 (04:02 +0900)]
panel: Delay elm_layout_theme_set until memebers are initialized in _smart_add
elm_layout_theme_set can call some methods like _elm_panel_smart_theme and there are some warnings
when these methods manipulate some member variabls which are not initialized yet.
It's because elm_layout_theme_set is called too early in _smart_add.
Spotted while digging warnings after rELM4c3e23de9e46
Ryuan Choi [Wed, 15 Jan 2014 18:33:40 +0000 (03:33 +0900)]
elm_widget_xxx.h: Adopt EINA_UNLIKELY and fix indentation in FOO_DATA_GET macros.
Daniel Juyung Seo [Wed, 15 Jan 2014 17:33:46 +0000 (02:33 +0900)]
win: Check null before calling elm_widget_highlight_in_theme_get(). It
can be null.
'target' can be null when the focus in is just called.
Daniel Juyung Seo [Wed, 15 Jan 2014 17:10:21 +0000 (02:10 +0900)]
test: Cleaned up elementary_test internal code.
- removed unnecessary/unused macro.
- fixed formatting.
- added prefix '_' for internal function.
Ryuan Choi [Wed, 15 Jan 2014 12:58:07 +0000 (21:58 +0900)]
fileselector_entry: Removed _mirrored_set(), one line local function
Small refactoring.
It is unnecessary one line function which just calls elm_widget_mirrored_set.