caitpotter88 [Thu, 9 Apr 2015 22:40:16 +0000 (15:40 -0700)]
[es6] do not add caller/arguments to ES6 function definitions
BUG=v8:3946, v8:3982
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
LOG=N
R=arv@chromium.org, rossberg@chromium.org
Review URL: https://codereview.chromium.org/
1027283004
Cr-Commit-Position: refs/heads/master@{#27729}
michael_dawson [Thu, 9 Apr 2015 22:32:11 +0000 (15:32 -0700)]
PPC: Vector-ICs - speed towards the monomorphic exit as quickly as possible.
Port
35a67b745d862c5b1f584c2786ebf1369dc4f1ff
Original commit message:
Thanks to some careful assumptions, we can examine the object found at
vector[slot] and trust it's a heap object where the second field is
either a map if it's a WeakCell, or definitely not a map if it's a
Symbol, String or FixedArray. Use this to save a memory read.
R=mbrandy@us.ibm.com
BUG=
Review URL: https://codereview.chromium.org/
1059133005
Cr-Commit-Position: refs/heads/master@{#27728}
michael_dawson [Thu, 9 Apr 2015 22:29:25 +0000 (15:29 -0700)]
PPC: [turbofan] Add new Float32Abs and Float64Abs operators.
Port
9af9f1d0262e2dab66c62331a03f6a76504f3866
Original commit message:
These operators compute the absolute floating point value of some
arbitrary input, and are implemented without any branches (i.e. using
vabs on arm, and andps/andpd on x86).
R=mbrandy@us.ibm.com
BUG=
Review URL: https://codereview.chromium.org/
1072963002
Cr-Commit-Position: refs/heads/master@{#27727}
michael_dawson [Thu, 9 Apr 2015 22:14:23 +0000 (15:14 -0700)]
PPC: Make --always-opt also optimize top-level code.
Port
2d281e71ac49058ef5696f4255ff1fa30796bc5e
Original commit message:
This enables eager optimization of top-level code with TurboFan and
extends test coverage by triggering it with the --always-opt flag.
Script contexts are now also properly allocated in TurboFan.
R=titzer@chromium.org, mstarzinger@chromium.org,mbrandy@us.ibm.com
BUG=
Review URL: https://codereview.chromium.org/
1052123005
Cr-Commit-Position: refs/heads/master@{#27726}
michael_dawson [Thu, 9 Apr 2015 22:13:16 +0000 (15:13 -0700)]
PPC: Code cleanup in GenerateRecordCallTarget.
Port
6a222b8ff033eb523149794d37c0d0f29bc8fc40
R=mbrandy@us.ibm.com
BUG=
Review URL: https://codereview.chromium.org/
1070333002
Cr-Commit-Position: refs/heads/master@{#27725}
adamk [Thu, 9 Apr 2015 22:09:44 +0000 (15:09 -0700)]
Collect list of requested modules in ModuleDescriptor while parsing
BUG=v8:1569
LOG=n
Review URL: https://codereview.chromium.org/
1078903002
Cr-Commit-Position: refs/heads/master@{#27724}
michael_dawson [Thu, 9 Apr 2015 21:45:42 +0000 (14:45 -0700)]
PPC: Reland "Merge old data and pointer space."
Port
59be4ba7f4f70dedcaac60914adaa2885a3da5d0
Original commit message:
This reverts commit
cbfcee557503514bef20abdfc78ceb262c9c4d64.
R=mbrandy@us.ibm.com
BUG=
Review URL: https://codereview.chromium.org/
1074953002
Cr-Commit-Position: refs/heads/master@{#27723}
machenbach [Thu, 9 Apr 2015 21:37:33 +0000 (14:37 -0700)]
[release-tools] Make chromium roll more robust after failing rolls.
Always use the same branch name (the old version leaked
branches). Always try to delete a possibly existing branch
on start-up and also clean up in the end.
NOTRY=true
TBR=tandrii@chromium.org
Review URL: https://codereview.chromium.org/
1077633002
Cr-Commit-Position: refs/heads/master@{#27722}
thakis [Thu, 9 Apr 2015 21:22:46 +0000 (14:22 -0700)]
Fix C++ violation.
gcc rejects the following snippet, clang rejects it in -std=c++11 mode:
namespace A { template<class T> class C {}; }
namespace B { template class A::C<int>; }
Indeed, the C++ standard says in 14.7.2p2 "An explicit instantiation shall
appear in an enclosing namespace of its template", so cl.exe is incorrect to
allow this.
Just move the instantiation out of the v8 namespace to fix. No intended
behavior change. Fixes building with clang-cl on Windows.
BUG=chromium:475643
LOG=N
TBR=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/
1073903002
Cr-Commit-Position: refs/heads/master@{#27721}
caitpotter88 [Thu, 9 Apr 2015 20:53:46 +0000 (13:53 -0700)]
[es6] don't "replace" Object.prototype.toString for --harmony-tostring
When ObjectToString is installed on Object.prototype twice (once in v8natives.js, and once in harmony-tostring.js), this pollutes old code spaces on some devices. To prevent this, the function is only installed once, preventing test failures when the --harmony-tostring flag is flipped on by default.
BUG=v8:3502
LOG=N
R=arv@chromium.org
Review URL: https://codereview.chromium.org/
1072083002
Cr-Commit-Position: refs/heads/master@{#27720}
michael_dawson [Thu, 9 Apr 2015 20:52:38 +0000 (13:52 -0700)]
PPC: JSEntryTrampoline: check for stack space before pushing arguments
Port
146598f44a1efd0f942745abfd6c08a073972c01
Original commit message:
Optimistically pushing a lot of arguments can run into the stack limit of the process, at least on operating systems where this limit is close to the limit that V8 sets for itself.
R=mbrandy@us.ibm.com
BUG=
Review URL: https://codereview.chromium.org/
1073893002
Cr-Commit-Position: refs/heads/master@{#27719}
michael_dawson [Thu, 9 Apr 2015 20:51:28 +0000 (13:51 -0700)]
PPC: Match -0 - x with sign bit flip.
Optimiation similar to what is done for x86
R=mbrandy@us.ibm.com
BUG=
Review URL: https://codereview.chromium.org/
1072173002
Cr-Commit-Position: refs/heads/master@{#27718}
mstarzinger [Thu, 9 Apr 2015 19:40:43 +0000 (12:40 -0700)]
[turbofan] Fix FrameInspector when deoptimizer is disabled.
This is a workaround to make the debugger happy about TurboFan frames
when the debugger causes frame inspection. Note that this can happen
because the debugger can be activated while there still are optimized
TurboFan activations on the stack.
R=ishell@chromium.org
BUG=chromium:465298
TEST=mjsunit/regress/regress-crbug-465298
LOG=N
Review URL: https://codereview.chromium.org/
1074793003
Cr-Commit-Position: refs/heads/master@{#27717}
arv [Thu, 9 Apr 2015 19:39:34 +0000 (12:39 -0700)]
Lexical arguments for arrow functions
Only allocate 'arguments' if the scope is not an arrow scope.
BUG=v8:2700
LOG=N
R=adamk@chromium.org, wingo@igalia.cmo
Review URL: https://codereview.chromium.org/
1078483002
Cr-Commit-Position: refs/heads/master@{#27716}
adamk [Thu, 9 Apr 2015 19:38:24 +0000 (12:38 -0700)]
Remove comparison operator and helper function from AstRawString interface
These comparisons are only meant to be done by AstValueFactory itself (in
its string_table_ operations), so make the Compare() function a private
member of AstValueFactory.
All other clients of AstRawStrings should compare them by pointer value.
There were only two clients which failed to abide by this rule, one
recently-added (in ModuleDescriptor) and the other in Literal::Match
(in ast.cc, added in https://code.google.com/p/v8/source/detail?r=24396).
Review URL: https://codereview.chromium.org/
1069423003
Cr-Commit-Position: refs/heads/master@{#27715}
caitpotter88 [Thu, 9 Apr 2015 19:37:14 +0000 (12:37 -0700)]
[es6] implement spread calls
BUG=v8:3018
R=
LOG=N
Review URL: https://codereview.chromium.org/
938443002
Cr-Commit-Position: refs/heads/master@{#27714}
brettw [Thu, 9 Apr 2015 19:36:02 +0000 (12:36 -0700)]
Windows GN component build fixes.
This fixes the d8 target which previously was getting both USING_V8_SHARED
and BUILDING_V8_SHARED defined at the same time.
Renames direct_dependent_configs to public_configs (new name, same thing).
Review URL: https://codereview.chromium.org/
1065403002
Cr-Commit-Position: refs/heads/master@{#27713}
yangguo [Thu, 9 Apr 2015 19:34:54 +0000 (12:34 -0700)]
Correctly wrap uri.js into a function.
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/
1076833002
Cr-Commit-Position: refs/heads/master@{#27712}
adamk [Thu, 9 Apr 2015 18:16:33 +0000 (11:16 -0700)]
Revert of Merge cellspace into old pointer space (patchset #8 id:180001 of https://codereview.chromium.org/
1010803012/)
Reason for revert:
Causes test failures on ARM bots related to cells and write barriers.
Original issue's description:
> Merge cellspace into old pointer space
>
> BUG=
>
> Committed: https://crrev.com/
4e7163ce05f135918205c7855ae60a48e5d46cc5
> Cr-Commit-Position: refs/heads/master@{#27707}
TBR=hpayer@chromium.org,balazs.kilvady@imgtec.com,yangguo@chromium.org,verwaest@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/
1053243003
Cr-Commit-Position: refs/heads/master@{#27711}
Adam Klein [Thu, 9 Apr 2015 17:46:08 +0000 (10:46 -0700)]
Skip another debug test that fails in always-opt/turbofan
TBR=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
1072143002
Cr-Commit-Position: refs/heads/master@{#27710}
dcarney [Thu, 9 Apr 2015 14:06:19 +0000 (07:06 -0700)]
[turbofan] support small immediates
R=titzer@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1075903002
Cr-Commit-Position: refs/heads/master@{#27709}
torne [Thu, 9 Apr 2015 13:38:20 +0000 (06:38 -0700)]
Remove android_webview_build conditions.
Remove references to android_webview_build now that we no longer support
that build configuration. This also removes use_system_stlport which was
only supported with android_webview_build.
BUG=chromium:440793
LOG=n
Review URL: https://codereview.chromium.org/
1069663002
Cr-Commit-Position: refs/heads/master@{#27708}
verwaest [Thu, 9 Apr 2015 13:34:16 +0000 (06:34 -0700)]
Merge cellspace into old pointer space
BUG=
Review URL: https://codereview.chromium.org/
1010803012
Cr-Commit-Position: refs/heads/master@{#27707}
chunyang.dai [Thu, 9 Apr 2015 13:26:29 +0000 (06:26 -0700)]
Set the default compiler for X87 to GCC.
Compiling v8 for X87 platform with clang compiler leads to some test case failure.
So we set the default compiler for X87 to GCC.
BUG=
Review URL: https://codereview.chromium.org/
1031793002
Cr-Commit-Position: refs/heads/master@{#27706}
yangguo [Thu, 9 Apr 2015 13:22:17 +0000 (06:22 -0700)]
Eagerly escape RegExp.source.
Escaping used to happen lazily, implemented in an accessor property.
However, native implementation of RegExp methods use .source as well.
This leads to performance regressions. Now we do it eagerly instead.
R=jkummerow@chromium.org
BUG=chromium:436447
LOG=N
Review URL: https://codereview.chromium.org/
1070093002
Cr-Commit-Position: refs/heads/master@{#27705}
machenbach [Thu, 9 Apr 2015 12:43:28 +0000 (05:43 -0700)]
[cq] Add win nosnap shared trybot.
TBR=tandrii@chromium.org
Review URL: https://codereview.chromium.org/
1078703002
Cr-Commit-Position: refs/heads/master@{#27704}
erikcorry [Thu, 9 Apr 2015 12:42:22 +0000 (05:42 -0700)]
Relax heap size assert during compaction
R=ulan@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1078533003
Cr-Commit-Position: refs/heads/master@{#27703}
titzer [Thu, 9 Apr 2015 12:41:15 +0000 (05:41 -0700)]
[turbofan] Disable select matching due to bug manifesting on arm.
R=machenbach@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1077613002
Cr-Commit-Position: refs/heads/master@{#27702}
dcarney [Thu, 9 Apr 2015 11:28:54 +0000 (04:28 -0700)]
[turbofan] Push layout descriptors to InstructionOperand subclasses.
Review URL: https://codereview.chromium.org/
1070043002
Cr-Commit-Position: refs/heads/master@{#27701}
balazs.kilvady [Thu, 9 Apr 2015 11:16:02 +0000 (04:16 -0700)]
MIPS: [turbofan] Materialize JSFunction from frame if possible.
Port
725cdc533cb4e31c042d32ce1979012b5bd99ced
Original commit message:
This reduces the overhead of recursive calls when context specialization
is enabled. Based on this it might be possible to further reduce the
overhead by also specializing the call itself.
As a drive-by-fix, port the fast context materialization optimization to
arm and arm64, that was previously only supported on x64 and ia32.
BUG=
Review URL: https://codereview.chromium.org/
1074743002
Cr-Commit-Position: refs/heads/master@{#27700}
mstarzinger [Thu, 9 Apr 2015 11:01:19 +0000 (04:01 -0700)]
Make TestInternalWeakLists more robust against flags.
This makes some tests in test-heap.cc more robust against flags, now
that top-level code can be optimized by the --always-opt flag.
R=hpayer@chromium.org
TEST=cctest/test-heap/TestInternalWeakLists
Review URL: https://codereview.chromium.org/
1071063004
Cr-Commit-Position: refs/heads/master@{#27699}
dcarney [Thu, 9 Apr 2015 10:40:41 +0000 (03:40 -0700)]
[turbofan] Make AllocatedOperand an InstructionOperand::Kind.
This is preparatory work to have MachineTypes encoded in AllocatedOperands.
Review URL: https://codereview.chromium.org/
1075863002
Cr-Commit-Position: refs/heads/master@{#27698}
Benedikt Meurer [Thu, 9 Apr 2015 10:29:15 +0000 (12:29 +0200)]
[turbofan] Add poor man's store elimination for storing to fields.
This is a very simple dead store elimination that removes StoreField
nodes which are immediately followed by other StoreField nodes that
store to the same field. Ideally there should be a fully featured store
elimination, which walks over the effect graph starting from the end,
but there are some technical difficulties to solve before we can get to
that, esp. we need to think about "effect producing" operators like
ValueEffect first. Once we have that, it is trivial to remove this temporary
poor man's store elimination.
R=dcarney@chromium.org
Review URL: https://codereview.chromium.org/
1070003002
Cr-Commit-Position: refs/heads/master@{#27697}
machenbach [Thu, 9 Apr 2015 09:55:59 +0000 (02:55 -0700)]
[test-runner] Pass slowest test durations to buildbot.
BUG=
Review URL: https://codereview.chromium.org/
1070753003
Cr-Commit-Position: refs/heads/master@{#27696}
v8-autoroll [Thu, 9 Apr 2015 09:51:40 +0000 (02:51 -0700)]
Update V8 DEPS.
Rolling v8/tools/clang to
5e71fff34c77c4ee9056fe3f2124c433768e2282
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
1069983004
Cr-Commit-Position: refs/heads/master@{#27695}
chunyang.dai [Thu, 9 Apr 2015 09:31:53 +0000 (02:31 -0700)]
X87: Code cleanup in GenerateRecordCallTarget.
port
6a222b8ff033eb523149794d37c0d0f29bc8fc40 (r27630)
original commit message:
Code cleanup in GenerateRecordCallTarget
BUG=
Review URL: https://codereview.chromium.org/
1074683003
Cr-Commit-Position: refs/heads/master@{#27694}
chunyang.dai [Thu, 9 Apr 2015 09:30:47 +0000 (02:30 -0700)]
X87: Make --always-opt also optimize top-level code
port
2d281e71ac49058ef5696f4255ff1fa30796bc5e (r27633)
original commit message:
Make --always-opt also optimize top-level code.
This enables eager optimization of top-level code with TurboFan and
extends test coverage by triggering it with the --always-opt flag.
Script contexts are now also properly allocated in TurboFan.
BUG=
Review URL: https://codereview.chromium.org/
1077523002
Cr-Commit-Position: refs/heads/master@{#27693}
dcarney [Thu, 9 Apr 2015 09:15:28 +0000 (02:15 -0700)]
[turbofan] cleanup InstructionOperand a little
- ConstantOperand was using a too-small field too store its virtual register
- drop ConvertTo, replace it with simple copy
- split AllocatedOperand off from Immediate and Constant to make assignment clearer, also paving the way for small Immediates
- put zone first in *Operand::New
- driveby: drop delayed ssa deconstruction experiment
R=titzer@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1050803002
Cr-Commit-Position: refs/heads/master@{#27692}
mvstanton [Thu, 9 Apr 2015 09:06:00 +0000 (02:06 -0700)]
VectorICs - turn on vector ICs for LoadIC and KeyedLoadIC
BUG=
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/
1075823002
Cr-Commit-Position: refs/heads/master@{#27691}
brucedawson [Thu, 9 Apr 2015 09:02:52 +0000 (02:02 -0700)]
Don't #define snprintf in VS2015 - it's illegal and unneeded.
VS 2015 supplies a conforming snprintf implementation, so #define
snprintf is no longer needed. Also, VS 2015 checks for #define of
snprintf and treats it as a fatal error.
LOG=Y
R=jarin@chromium.org
BUG=440500
Review URL: https://codereview.chromium.org/
1078453002
Cr-Commit-Position: refs/heads/master@{#27690}
hpayer [Thu, 9 Apr 2015 08:55:37 +0000 (01:55 -0700)]
MarkBit cleanup: They have to be accessed through Marking accessors. Avoid arbitrary abuse of mark bits and make marking explicit.
Added DCHECKs to mark bit transitions to check source state.
BUG=
Review URL: https://codereview.chromium.org/
1040443002
Cr-Commit-Position: refs/heads/master@{#27689}
yangguo [Thu, 9 Apr 2015 08:47:28 +0000 (01:47 -0700)]
Blacklist tests due to optimizing toplevel with --always-opt.
Those two tests fail in gc-stress and custom snapshot (embedding mjsunit.js).
This is likely due to different GC timing with the custom snapshot.
R=mstarzinger@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1078653002
Cr-Commit-Position: refs/heads/master@{#27688}
mstarzinger [Thu, 9 Apr 2015 08:21:38 +0000 (01:21 -0700)]
Disable more failing tests after
f3338dd3b01c.
TBR=machenbach@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1075813002
Cr-Commit-Position: refs/heads/master@{#27687}
bmeurer [Thu, 9 Apr 2015 07:41:06 +0000 (00:41 -0700)]
[turbofan] Materialize JSFunction from frame if possible.
This reduces the overhead of recursive calls when context specialization
is enabled. Based on this it might be possible to further reduce the
overhead by also specializing the call itself.
As a drive-by-fix, port the fast context materialization optimization to
arm and arm64, that was previously only supported on x64 and ia32.
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/
1072743002
Cr-Commit-Position: refs/heads/master@{#27686}
hablich [Thu, 9 Apr 2015 07:11:12 +0000 (00:11 -0700)]
Revert of Revert of X87: Reimplement Maps and Sets in JS (patchset #1 id:1 of https://codereview.chromium.org/
1073723002/)
Reason for revert:
Revert the revert as this commit cannot be the cause for the closed tree.
Original issue's description:
> Revert of X87: Reimplement Maps and Sets in JS (patchset #1 id:1 of https://codereview.chromium.org/
1066373002/)
>
> Reason for revert:
> Reverting as it resulted in a closed waterfall.
>
> Original issue's description:
> > X87: Reimplement Maps and Sets in JS
> >
> > port
909500aa1db9789b68e101045a6359a7fcb30e83 (r27605)
> >
> > original commit message:
> > Previously, the only optimized code path for Maps and Sets was for String keys.
> > This was achieved through an implementation of various complex operations
> > in Hydrogen. This approach was neither scalable nor forward-compatible.
> >
> > This patch adds the necessary intrinsics to implement Maps and Sets almost entirely
> > in JS. The added intrinsics are:
> >
> > %_FixedArrayGet
> > %_FixedArraySet
> > %_TheHole
> > %_JSCollectionGetTable
> > %_StringGetRawHashField
> >
> > With these additions, as well as a few changes to what's exposed as runtime functions,
> > most of the C++ code backing Maps and Sets is gone (including both runtime code in
> > objects.cc and Crankshaft in hydrogen.cc).
> >
> > BUG=
> >
> > Committed: https://crrev.com/
56600a35a49ffa5abcba66b14839089de3589ad9
> > Cr-Commit-Position: refs/heads/master@{#27681}
>
> TBR=weiliang.lin@intel.com,chunyang.dai@intel.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=
>
> Committed: https://crrev.com/
a0486f128109443ed07802fb463c267e53533d81
> Cr-Commit-Position: refs/heads/master@{#27682}
TBR=weiliang.lin@intel.com,chunyang.dai@intel.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/
1077543002
Cr-Commit-Position: refs/heads/master@{#27685}
chunyang.dai [Thu, 9 Apr 2015 06:51:59 +0000 (23:51 -0700)]
X87: JSEntryTrampoline: check for stack space before pushing arguments
port
146598f44a1efd0f942745abfd6c08a073972c01 (r27614)
original commit message:
Optimistically pushing a lot of arguments can run into the stack limit of the
process, at least on operating systems where this limit is close to the limit
that V8 sets for itself.
BUG=
Review URL: https://codereview.chromium.org/
1069283002
Cr-Commit-Position: refs/heads/master@{#27684}
jing.bao [Thu, 9 Apr 2015 06:50:52 +0000 (23:50 -0700)]
[ia32] Introduce BMI instructions.
BUG=v8:4015
LOG=n
Review URL: https://codereview.chromium.org/
1069683002
Cr-Commit-Position: refs/heads/master@{#27683}
hablich [Thu, 9 Apr 2015 06:49:30 +0000 (23:49 -0700)]
Revert of X87: Reimplement Maps and Sets in JS (patchset #1 id:1 of https://codereview.chromium.org/
1066373002/)
Reason for revert:
Reverting as it resulted in a closed waterfall.
Original issue's description:
> X87: Reimplement Maps and Sets in JS
>
> port
909500aa1db9789b68e101045a6359a7fcb30e83 (r27605)
>
> original commit message:
> Previously, the only optimized code path for Maps and Sets was for String keys.
> This was achieved through an implementation of various complex operations
> in Hydrogen. This approach was neither scalable nor forward-compatible.
>
> This patch adds the necessary intrinsics to implement Maps and Sets almost entirely
> in JS. The added intrinsics are:
>
> %_FixedArrayGet
> %_FixedArraySet
> %_TheHole
> %_JSCollectionGetTable
> %_StringGetRawHashField
>
> With these additions, as well as a few changes to what's exposed as runtime functions,
> most of the C++ code backing Maps and Sets is gone (including both runtime code in
> objects.cc and Crankshaft in hydrogen.cc).
>
> BUG=
>
> Committed: https://crrev.com/
56600a35a49ffa5abcba66b14839089de3589ad9
> Cr-Commit-Position: refs/heads/master@{#27681}
TBR=weiliang.lin@intel.com,chunyang.dai@intel.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/
1073723002
Cr-Commit-Position: refs/heads/master@{#27682}
chunyang.dai [Thu, 9 Apr 2015 02:24:04 +0000 (19:24 -0700)]
X87: Reimplement Maps and Sets in JS
port
909500aa1db9789b68e101045a6359a7fcb30e83 (r27605)
original commit message:
Previously, the only optimized code path for Maps and Sets was for String keys.
This was achieved through an implementation of various complex operations
in Hydrogen. This approach was neither scalable nor forward-compatible.
This patch adds the necessary intrinsics to implement Maps and Sets almost entirely
in JS. The added intrinsics are:
%_FixedArrayGet
%_FixedArraySet
%_TheHole
%_JSCollectionGetTable
%_StringGetRawHashField
With these additions, as well as a few changes to what's exposed as runtime functions,
most of the C++ code backing Maps and Sets is gone (including both runtime code in
objects.cc and Crankshaft in hydrogen.cc).
BUG=
Review URL: https://codereview.chromium.org/
1066373002
Cr-Commit-Position: refs/heads/master@{#27681}
arv [Wed, 8 Apr 2015 21:18:31 +0000 (14:18 -0700)]
ES6: Number and Boolean prototype should be ordinary objects
BUG=v8:4001
LOG=N
R=adamk@chromium.org, rossberg@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/
1051373002
Cr-Commit-Position: refs/heads/master@{#27680}
balazs.kilvady [Wed, 8 Apr 2015 19:30:04 +0000 (12:30 -0700)]
MIPS: [turbofan] Add new Float32Abs and Float64Abs operators.
Port
9af9f1d0262e2dab66c62331a03f6a76504f3866
Original commit message:
These operators compute the absolute floating point value of some
arbitrary input, and are implemented without any branches (i.e. using
vabs on arm, and andps/andpd on x86).
BUG=
Review URL: https://codereview.chromium.org/
1073463003
Cr-Commit-Position: refs/heads/master@{#27679}
dusan.milosavljevic [Wed, 8 Apr 2015 19:03:39 +0000 (12:03 -0700)]
MIPS: Fix in-object memory slack tracking bug.
TEST=
BUG=
Review URL: https://codereview.chromium.org/
1067393003
Cr-Commit-Position: refs/heads/master@{#27678}
caitpotter88 [Wed, 8 Apr 2015 18:47:36 +0000 (11:47 -0700)]
[parser] report better errors for multiple ForBindings in ForIn/Of loops
Instead of "unexpected token" errors, report something meatier and more actionable.
BUG=
R=marja@chromium.org, arv@chromium.org
LOG=N
Review URL: https://codereview.chromium.org/
1062263002
Cr-Commit-Position: refs/heads/master@{#27677}
arv [Wed, 8 Apr 2015 17:49:11 +0000 (10:49 -0700)]
Ship ES6 computed property names
BUG=v8:3754
LOG=N
R=dslomov@chromium.org, rossberg@chromium.org
Review URL: https://codereview.chromium.org/
1054883003
Cr-Commit-Position: refs/heads/master@{#27676}
mstarzinger [Wed, 8 Apr 2015 17:28:52 +0000 (10:28 -0700)]
Disable more failing tests after
f3338dd3b01c.
TBR=machenbach@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1070843002
Cr-Commit-Position: refs/heads/master@{#27675}
loislo [Wed, 8 Apr 2015 16:13:24 +0000 (09:13 -0700)]
CpuProfiler: public API for deopt info in cpu profiler.
BUG=chromium:452067
LOG=n
Committed: https://crrev.com/
baf927ff5115ec62a6dad684b9232ed9d3960e3a
Cr-Commit-Position: refs/heads/master@{#27626}
Review URL: https://codereview.chromium.org/
1045753002
Cr-Commit-Position: refs/heads/master@{#27674}
ulan [Wed, 8 Apr 2015 15:58:14 +0000 (08:58 -0700)]
Check mark bit of the found object in MarkCompactCollector::IsSlotInBlackObject.
BUG=
Review URL: https://codereview.chromium.org/
1069763002
Cr-Commit-Position: refs/heads/master@{#27673}
svenpanne [Wed, 8 Apr 2015 15:57:06 +0000 (08:57 -0700)]
[TurboFan] Fixed handling of CompareIC return type.
Although all this code might be moved around later, it's a good idea
to unhackify it now. :-)
Review URL: https://codereview.chromium.org/
1067193004
Cr-Commit-Position: refs/heads/master@{#27672}
mvstanton [Wed, 8 Apr 2015 15:55:58 +0000 (08:55 -0700)]
Tests that carefully checks opt/deopt status shouldn't --always-opt.
If we optimize a function before gathering feedback it may be
peppered with soft deoptimizations. So it can't help but deoptimize.
A judicious reading of the code isn't enough to determine what the
optimization state should be in the face of such chaotic gyrations.
BUG=
R=verwaest@chromium.org
Review URL: https://codereview.chromium.org/
1069363003
Cr-Commit-Position: refs/heads/master@{#27671}
mstarzinger [Wed, 8 Apr 2015 14:16:50 +0000 (07:16 -0700)]
Disable more failing tests after
f3338dd3b01c.
TBR=machenbach@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1067413002
Cr-Commit-Position: refs/heads/master@{#27670}
titzer [Wed, 8 Apr 2015 13:28:00 +0000 (06:28 -0700)]
[turbofan] Reduce JSLoadProperty and JSStoreProperty of strings to JSLoadNamed and JSStoreNamed.
R=mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1038953002
Cr-Commit-Position: refs/heads/master@{#27669}
titzer [Wed, 8 Apr 2015 13:15:34 +0000 (06:15 -0700)]
Add more systematic tests for comparisons.
Because, well, JavaScript is tricky and compilers like folding.
R=mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1069673002
Cr-Commit-Position: refs/heads/master@{#27668}
titzer [Wed, 8 Apr 2015 13:14:26 +0000 (06:14 -0700)]
Fix maybe_string_add for adds that have no type feedback where --always-opt is on.
R=mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1071473003
Cr-Commit-Position: refs/heads/master@{#27667}
mstarzinger [Wed, 8 Apr 2015 12:54:56 +0000 (05:54 -0700)]
[turbofan] Add JSStackCheck into loop bodies.
This allows loopy TurboFan code to be interrupted by placing a stack
check (i.e. JSStackCheck node) into each loop. Note that we currently
limit this to non-asm.js code. Also note that stack checks are actually
placed after loop headers and not at back-branches, which allows us to
reuse existing BailoutIds from Crankshaft.
R=titzer@chromium.org
Review URL: https://codereview.chromium.org/
1065923002
Cr-Commit-Position: refs/heads/master@{#27666}
dusan.milosavljevic [Wed, 8 Apr 2015 12:53:49 +0000 (05:53 -0700)]
MIPS64: Unbreak cross build.
TEST=
BUG=
Review URL: https://codereview.chromium.org/
1066403002
Cr-Commit-Position: refs/heads/master@{#27665}
mvstanton [Wed, 8 Apr 2015 12:52:42 +0000 (05:52 -0700)]
Revert of VectorICs: Turn on vector ICs for LOAD and KEYED_LOAD cases. (patchset #1 id:1 of https://codereview.chromium.org/
1070653002/)
Reason for revert:
ARM test failure, need to investigate.
Original issue's description:
> VectorICs: Turn on vector ICs for LOAD and KEYED_LOAD cases.
>
> R=verwaest@chromium.org
> BUG=
>
> Committed: https://crrev.com/
2395eda3bb7aca938751938df76e01ac2b89b0a6
> Cr-Commit-Position: refs/heads/master@{#27657}
TBR=verwaest@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/
1072463002
Cr-Commit-Position: refs/heads/master@{#27664}
mstarzinger [Wed, 8 Apr 2015 12:06:52 +0000 (05:06 -0700)]
[ia32] Fix MacroAssembler::Move for int64 to float64 moves.
R=bmeurer@chromium.org
TEST=test262-es6/language/expressions/addition/S9.3_A4.1_T2
Review URL: https://codereview.chromium.org/
1071543003
Cr-Commit-Position: refs/heads/master@{#27663}
Benedikt Meurer [Wed, 8 Apr 2015 11:54:53 +0000 (13:54 +0200)]
[turbofan] Add new Float32Abs and Float64Abs operators.
These operators compute the absolute floating point value of some
arbitrary input, and are implemented without any branches (i.e. using
vabs on arm, and andps/andpd on x86).
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/
1066393002
Cr-Commit-Position: refs/heads/master@{#27662}
mstarzinger [Wed, 8 Apr 2015 11:42:19 +0000 (04:42 -0700)]
Disable more failing tests after
f3338dd3b01c.
TBR=machenbach@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1067303003
Cr-Commit-Position: refs/heads/master@{#27661}
marja [Wed, 8 Apr 2015 11:16:02 +0000 (04:16 -0700)]
[es6] Stage unicode escapes in strings, var names etc.
R=rossberg@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1071533002
Cr-Commit-Position: refs/heads/master@{#27660}
yangguo [Wed, 8 Apr 2015 11:14:56 +0000 (04:14 -0700)]
Create result array of %DebugGetLoadedScripts outside the debug context.
R=jarin@chromium.org
BUG=chromium:474297
LOG=N
Review URL: https://codereview.chromium.org/
1062143002
Cr-Commit-Position: refs/heads/master@{#27659}
titzer [Wed, 8 Apr 2015 11:13:43 +0000 (04:13 -0700)]
[turbofan] Match selects in control reducer (configurable).
R=bmeurer@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1061303002
Cr-Commit-Position: refs/heads/master@{#27658}
mvstanton [Wed, 8 Apr 2015 11:12:37 +0000 (04:12 -0700)]
VectorICs: Turn on vector ICs for LOAD and KEYED_LOAD cases.
R=verwaest@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1070653002
Cr-Commit-Position: refs/heads/master@{#27657}
yangguo [Wed, 8 Apr 2015 11:11:29 +0000 (04:11 -0700)]
Blacklist failing test on arm64 (issue 4016).
TBR=jkummerow@chromium.org
BUG=v8:4016
LOG=N
Review URL: https://codereview.chromium.org/
1071513002
Cr-Commit-Position: refs/heads/master@{#27656}
mstarzinger [Wed, 8 Apr 2015 10:35:09 +0000 (03:35 -0700)]
Disable more failing tests after
f3338dd3b01c.
TBR=yangguo@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1072433002
Cr-Commit-Position: refs/heads/master@{#27655}
yangguo [Wed, 8 Apr 2015 10:29:23 +0000 (03:29 -0700)]
Revert of Remove support for thread-based recompilation (patchset #1 id:1 of https://codereview.chromium.org/
966653002/)
Reason for revert:
speculative revert due to gc-stress timeouts.
Original issue's description:
> Remove support for thread-based recompilation
>
> BUG=v8:3608
> R=yangguo@chromium.org
> LOG=y
>
> Committed: https://crrev.com/
ed5db223a19dfe126af012e894582251aa3635d7
> Cr-Commit-Position: refs/heads/master@{#27619}
TBR=jochen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
BUG=v8:3608
LOG=N
Review URL: https://codereview.chromium.org/
1063383004
Cr-Commit-Position: refs/heads/master@{#27654}
machenbach [Wed, 8 Apr 2015 09:53:35 +0000 (02:53 -0700)]
Make test runner more chatty to avoid it getting killed by buildbot.
NOTRY=true
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/
1064043002
Cr-Commit-Position: refs/heads/master@{#27653}
mstarzinger [Wed, 8 Apr 2015 09:51:14 +0000 (02:51 -0700)]
Disable more failing tests after
f3338dd3b01c.
TBR=yangguo@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1067353002
Cr-Commit-Position: refs/heads/master@{#27652}
mstarzinger [Wed, 8 Apr 2015 09:24:55 +0000 (02:24 -0700)]
Disable failing test after
f3338dd3b01c.
R=yangguo@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1070663002
Cr-Commit-Position: refs/heads/master@{#27651}
svenpanne [Wed, 8 Apr 2015 09:10:10 +0000 (02:10 -0700)]
Make GetDebugContext a bit more robust.
Perhaps we should throw an exception and/or change our external API to
use a MaybeLocal, but that would be a bigger change. For now, we just
return undefined when something goes wrong with the DebugContext,
which is good enough to avoid crashing.
BUG=chromium:474538
LOG=y
Review URL: https://codereview.chromium.org/
1065213002
Cr-Commit-Position: refs/heads/master@{#27650}
mstarzinger [Wed, 8 Apr 2015 09:00:41 +0000 (02:00 -0700)]
Prevent overzealous bailout due to script context.
This is a follow-up to
2d281e71ac49 and prevents bailouts on empty
script contexts in Crankshaft, which don't need allocation. Only
non-empty script contexts should cause a bailout.
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
1063373003
Cr-Commit-Position: refs/heads/master@{#27649}
jing.bao [Wed, 8 Apr 2015 07:15:51 +0000 (00:15 -0700)]
[x64] Introduce BMI instructions.
BUG=v8:4015
LOG=n
Review URL: https://codereview.chromium.org/
1040603002
Cr-Commit-Position: refs/heads/master@{#27648}
svenpanne [Wed, 8 Apr 2015 07:04:07 +0000 (00:04 -0700)]
Unbreak check-name-clashes.py after recent macro renamings.
This should have been part of https://codereview.chromium.org/
1056863002/. :-/
TBR=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/
1070593002
Cr-Commit-Position: refs/heads/master@{#27647}
bmeurer [Wed, 8 Apr 2015 06:50:10 +0000 (23:50 -0700)]
[arm] Use position independent table switches.
Performance measurements show that the position independent code is
usually slightly faster than the position dependent code, and there
seems to be no noticable regression.
This also gets rid of a lot of support code that was only required to allow
embedding labels into the code stream. And it implies that neither the GC
nor the deserializer need to do anything for jump tables.
R=svenpanne@chromium.org
BUG=v8:3872
LOG=n
Review URL: https://codereview.chromium.org/
1069633002
Cr-Commit-Position: refs/heads/master@{#27646}
v8-autoroll [Wed, 8 Apr 2015 03:39:22 +0000 (20:39 -0700)]
Update V8 DEPS.
Rolling v8/tools/clang to
7ec0c52c7a66cd94c96b8eb37bacd26d152e40e6
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
1070533002
Cr-Commit-Position: refs/heads/master@{#27645}
balazs.kilvady [Tue, 7 Apr 2015 21:12:13 +0000 (14:12 -0700)]
MIPS64: Fix typo of 'Always update raw pointers when handling interrupts inside RegExp code.'
Port
c67cb287a901ddf03d4ae4dafcf431d09fd3e22c
BUG=
Review URL: https://codereview.chromium.org/
1061363003
Cr-Commit-Position: refs/heads/master@{#27644}
balazs.kilvady [Tue, 7 Apr 2015 21:11:05 +0000 (14:11 -0700)]
MIPS64: Make --always-opt also optimize top-level code.
Port
2d281e71ac49058ef5696f4255ff1fa30796bc5e
Original commit message:
This enables eager optimization of top-level code with TurboFan and
extends test coverage by triggering it with the --always-opt flag.
Script contexts are now also properly allocated in TurboFan.
BUG=
Review URL: https://codereview.chromium.org/
1066843005
Cr-Commit-Position: refs/heads/master@{#27643}
adamk [Tue, 7 Apr 2015 20:09:57 +0000 (13:09 -0700)]
Disable another debug test under turbo always-opt
TBR=mstarzinger@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1064133002
Cr-Commit-Position: refs/heads/master@{#27642}
adamk [Tue, 7 Apr 2015 19:52:17 +0000 (12:52 -0700)]
Use NumberIsNaN in collections.js and make it inlined
Review URL: https://codereview.chromium.org/
1067933002
Cr-Commit-Position: refs/heads/master@{#27641}
machenbach [Tue, 7 Apr 2015 19:42:32 +0000 (12:42 -0700)]
[release-tools] Only read from the chromium checkout in v8rel.
Don't create local branches or otherwise manipulate the
checkout. This reads refs from remote branches and
reads file contents using show. It is faster and requires
less bootstrapping and cleanup.
TBR=tandrii@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/
1060013003
Cr-Commit-Position: refs/heads/master@{#27640}
caitpotter88 [Tue, 7 Apr 2015 19:28:33 +0000 (12:28 -0700)]
[es6] emit error when for-in loop declarations are initialized in strict mode
The ES6 grammar forbids the initialization of variable declarations in IterationStatements.
This CL will report `for (var x = y in z)` as a SyntaxError in strict mode (as done in JSC). It is possible that this could break sites in sloppy mode, and so that change can wait.
BUG=
R=
LOG=N
Review URL: https://codereview.chromium.org/
1033823002
Cr-Commit-Position: refs/heads/master@{#27639}
adamk [Tue, 7 Apr 2015 19:00:34 +0000 (12:00 -0700)]
Simplify collections.js now that it's wrapped in an IIFE
Also wrap templates.js in an IIFE to avoid unnecessary pollution
of the builtins object.
Review URL: https://codereview.chromium.org/
1067903004
Cr-Commit-Position: refs/heads/master@{#27638}
erikcorry [Tue, 7 Apr 2015 17:22:10 +0000 (10:22 -0700)]
More robust when allocation fails during compaction
R=ulan@chromium.org
BUG=chromium:473307
LOG=yes
Review URL: https://codereview.chromium.org/
1068833002
Cr-Commit-Position: refs/heads/master@{#27637}
mstarzinger [Tue, 7 Apr 2015 17:06:12 +0000 (10:06 -0700)]
Disabled failing tests after
2d281e71ac49.
R=titzer@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1065983002
Cr-Commit-Position: refs/heads/master@{#27636}
verwaest [Tue, 7 Apr 2015 16:11:20 +0000 (09:11 -0700)]
Simplify instanceof optimization; don't duplicate lookup
BUG=
Review URL: https://codereview.chromium.org/
1066873002
Cr-Commit-Position: refs/heads/master@{#27635}
balazs.kilvady [Tue, 7 Apr 2015 15:59:00 +0000 (08:59 -0700)]
MIPS: JSEntryTrampoline: check for stack space before pushing arguments
Port
146598f44a1efd0f942745abfd6c08a073972c01
Original commit message:
Optimistically pushing a lot of arguments can run into the stack limit of the process, at least on operating systems where this limit is close to the limit that V8 sets for itself.
BUG=chromium:469768
LOG=y
Review URL: https://codereview.chromium.org/
1066843003
Cr-Commit-Position: refs/heads/master@{#27634}
mstarzinger [Tue, 7 Apr 2015 15:44:16 +0000 (08:44 -0700)]
Make --always-opt also optimize top-level code.
This enables eager optimization of top-level code with TurboFan and
extends test coverage by triggering it with the --always-opt flag.
Script contexts are now also properly allocated in TurboFan.
R=titzer@chromium.org
Review URL: https://codereview.chromium.org/
1053063003
Cr-Commit-Position: refs/heads/master@{#27633}
mvstanton [Tue, 7 Apr 2015 15:16:48 +0000 (08:16 -0700)]
MIPS: Fix compilation error.
BUG=
TBR=verwaest@chromium.org
Review URL: https://codereview.chromium.org/
1068723006
Cr-Commit-Position: refs/heads/master@{#27632}
mvstanton [Tue, 7 Apr 2015 14:49:59 +0000 (07:49 -0700)]
Vector-ICs - speed towards the monomorphic exit as quickly as possible.
Thanks to some careful assumptions, we can examine the object found at
vector[slot] and trust it's a heap object where the second field is
either a map if it's a WeakCell, or definitely not a map if it's a
Symbol, String or FixedArray. Use this to save a memory read.
BUG=
Review URL: https://codereview.chromium.org/
1032163002
Cr-Commit-Position: refs/heads/master@{#27631}
mvstanton [Tue, 7 Apr 2015 13:39:32 +0000 (06:39 -0700)]
Code cleanup in GenerateRecordCallTarget.
BUG=
Review URL: https://codereview.chromium.org/
1057613003
Cr-Commit-Position: refs/heads/master@{#27630}