external/binutils.git
21 years ago2003-04-14 David Carlton <carlton@math.stanford.edu>
David Carlton [Mon, 14 Apr 2003 19:55:27 +0000 (19:55 +0000)]
2003-04-14  David Carlton  <carlton@math.stanford.edu>

* symtab.c (symbol_set_names): Rename 'name' arg to
'linkage_name', and 'tmpname' variable to 'linkage_name_copy'.
* symtab.h: Change 'name' argument in declaration of
symbol_set_names to 'linkage_name'.
(SYMBOL_SET_NAMES): Change 'name' argument to 'linkage_name'.

21 years ago2003-04-14 Andrew Cagney <cagney@redhat.com>
Andrew Cagney [Mon, 14 Apr 2003 19:16:13 +0000 (19:16 +0000)]
2003-04-14  Andrew Cagney  <cagney@redhat.com>

* mips-tdep.c (mips_read_sp): Do not apply ADDR_BITS_REMOVE,
return the fully sign-extended register value.
(get_frame_pointer): Ditto.
(mips_pop_frame): Initialize "proc_desc" after checking for a
dummy frame.

21 years ago2003-04-14 Andrew Cagney <cagney@redhat.com>
Andrew Cagney [Mon, 14 Apr 2003 19:06:48 +0000 (19:06 +0000)]
2003-04-14  Andrew Cagney  <cagney@redhat.com>

* mips-tdep.c (mips_push_dummy_frame): Delete function.
(MASK, PUSH_FP_REGNUM, GEN_REG_SAVE_MASK): Delete macros.
(FLOAT_REG_SAVE_MASK, FLOAT_SINGLE_REG_SAVE_MASK): Delete macro.
(mips_push_register): Delete function.
(mips_dump_tdep): Delete references to GEN_REG_SAVE_MASK and
PUSH_FP_REGNUM.

21 years agogdb/ChangeLog:
Jim Blandy [Mon, 14 Apr 2003 18:42:28 +0000 (18:42 +0000)]
gdb/ChangeLog:
2003-04-10  Jim Blandy  <jimb@redhat.com>

* symmisc.c: #include "gdb_regex.h".
(maintenance_list_symtabs, maintenance_list_psymtabs): New
functions.
* maint.c (maintenance_list_command): New function.
(_initialize_maint_cmds): Register the above as commands.
* symtab.h (maintenance_list_symtabs,
maintenance_list_psymtabs): New declarations.
* cli/cli-cmds.c (maintenancelistlist): New variable.
(init_cmd_lists): Initialize it.
* cli/cli-cmds.h (maintenancelistlist): New declaration.
* gdbcmd.h (maintenancelistlist): New declaration.
* Makefile.in (symmisc.o): Update dependencies.

gdb/doc/ChangeLog:
2003-04-09  Jim Blandy  <jimb@redhat.com>

* gdb.texinfo (Symbols): Document 'maint list symtabs' and 'maint
list psymtabs'.

21 years agomerge from gcc
DJ Delorie [Mon, 14 Apr 2003 18:27:58 +0000 (18:27 +0000)]
merge from gcc

21 years ago2003-04-08 Elena Zannoni <ezannoni@redhat.com>
Elena Zannoni [Mon, 14 Apr 2003 14:21:07 +0000 (14:21 +0000)]
2003-04-08  Elena Zannoni  <ezannoni@redhat.com>

* s390-nat.c: Include asm/types.h for addr_t.

21 years ago2003-04-14 Elena Zannoni <ezannoni@redhat.com>
Elena Zannoni [Mon, 14 Apr 2003 14:04:06 +0000 (14:04 +0000)]
2003-04-14  Elena Zannoni  <ezannoni@redhat.com>

        * gdb.base/attach.exp: Add new message from ptrace in case of
        attaching to nonexistent process.

21 years ago * scripttempl/elf.sc (CTOR): Handle crtbeginS.o, crtendS.o and
Alan Modra [Mon, 14 Apr 2003 13:03:17 +0000 (13:03 +0000)]
* scripttempl/elf.sc (CTOR): Handle crtbeginS.o, crtendS.o and
other variants of crtbegin.o, crtend.o.
(DTOR): Likewise.
* scripttempl/crisaout.sc (ctors, dtors): Likewise.
* scripttempl/elf_chaos.sc (CTOR, DTOR): Likewise.
* scripttempl/elfd10v.sc (CTOR, DTOR): Likewise.
* scripttempl/elfd30v.sc (CTOR, DTOR): Likewise.
* scripttempl/elfxtensa.sc (CTOR, DTOR): Likewise.
* scripttempl/iq2000.sc (CTOR, DTOR): Likewise.
* scripttempl/mmo.sc (ctors, dtors): Likewise.
* scripttempl/xstormy16.sc (CTOR, DTOR): Likewise.

21 years agoMaintain maximum alignment for common symbols. Warn reducing alignment for
Nick Clifton [Mon, 14 Apr 2003 11:06:25 +0000 (11:06 +0000)]
Maintain maximum alignment for common symbols. Warn reducing alignment for
common symbols. Report old filename when symbol size changes.

21 years ago * cp-valprint.c (cp_print_class_method): Call unpack_pointer() with
Corinna Vinschen [Mon, 14 Apr 2003 08:47:42 +0000 (08:47 +0000)]
* cp-valprint.c (cp_print_class_method): Call unpack_pointer() with
actually incoming type.

21 years ago2003-04-13 Andrew Cagney <cagney@redhat.com>
Andrew Cagney [Mon, 14 Apr 2003 02:29:40 +0000 (02:29 +0000)]
2003-04-13  Andrew Cagney  <cagney@redhat.com>

* ppc-linux-tdep.c: Use get_frame_base, get_frame_pc,
get_next_frame and get_frame_saved_regs.

21 years ago*** empty log message ***
gdbadmin [Mon, 14 Apr 2003 00:00:31 +0000 (00:00 +0000)]
*** empty log message ***

21 years agodaily update
Alan Modra [Mon, 14 Apr 2003 00:00:06 +0000 (00:00 +0000)]
daily update

21 years ago2003-04-13 Andrew Cagney <cagney@redhat.com>
Andrew Cagney [Sun, 13 Apr 2003 22:34:27 +0000 (22:34 +0000)]
2003-04-13  Andrew Cagney  <cagney@redhat.com>

* reggroups.c (default_register_reggroup_p): Use NUM_REGS instead
of gdbarch_num_regs.

21 years ago2003-04-13 Michael Snyder <msnyder@redhat.com>
Michael Snyder [Sun, 13 Apr 2003 17:45:11 +0000 (17:45 +0000)]
2003-04-13  Michael Snyder  <msnyder@redhat.com>

* Make-common.in (sim-events.o, sim-config.o): Depend on sim-main.h.

21 years ago2003-04-13 Michael Snyder <msnyder@redhat.com>
Michael Snyder [Sun, 13 Apr 2003 17:06:29 +0000 (17:06 +0000)]
2003-04-13  Michael Snyder  <msnyder@redhat.com>

* compile.c (sim_resume): Implement 'daa' and 'das' instructions.

21 years ago2003-04-07 Michael Snyder <msnyder@redhat.com>
Michael Snyder [Sun, 13 Apr 2003 16:50:31 +0000 (16:50 +0000)]
2003-04-07  Michael Snyder  <msnyder@redhat.com>

* h8300.h (ldc/stc): Fix up src/dst swaps.

21 years ago2003-04-13 Michael Snyder <msnyder@redhat.com>
Michael Snyder [Sun, 13 Apr 2003 16:44:57 +0000 (16:44 +0000)]
2003-04-13  Michael Snyder  <msnyder@redhat.com>

* configure.in: Add testsuite to extra_subdirs.
* configure: Regenerate.

2003-04-13  Michael Snyder  <msnyder@redhat.com>

* sim/h8300: New directory.  Tests for Hitachi h8/300 family.

21 years ago2003-04-13 Andrew Cagney <cagney@redhat.com>
Andrew Cagney [Sun, 13 Apr 2003 15:54:58 +0000 (15:54 +0000)]
2003-04-13  Andrew Cagney  <cagney@redhat.com>

* frame.h: Mention what replaced what in "struct frame_info".
* hppa-hpux-tdep.c: Use get_frame_base, get_frame_pc and
deprecated_update_frame_base_hack and
deprecated_update_frame_pc_hack.
* hppa-tdep.c: Ditto.

21 years ago * dwarf2expr.h (struct dwarf_expr_context): Remove extra arguments
Daniel Jacobowitz [Sun, 13 Apr 2003 15:53:44 +0000 (15:53 +0000)]
* dwarf2expr.h (struct dwarf_expr_context): Remove extra arguments
to read_reg and update its comment.  Remove regnum member.
* dwarf2expr.c (execute_stack_op): Remove memaddr and expr_lval.
Don't call read_reg when setting in_reg.  Call read_reg to get
the frame base if it's in a register.  Return the register number
on the stack instead of in the context.  Remove extra arguments
to read_reg.
* dwarf2loc.c (dwarf_expr_read_reg): Remove extra arguments.
(dwarf2_evaluate_loc_desc): Call value_from_register.  Expect
the register number on the expression stack.
(needs_frame_read_reg): Remove extra arguments.

21 years ago2003-04-13 Daniel Jacobowitz <drow@mvista.com>
Daniel Jacobowitz [Sun, 13 Apr 2003 15:43:35 +0000 (15:43 +0000)]
2003-04-13  Daniel Jacobowitz  <drow@mvista.com>

* dwarf2expr.c (dwarf2_read_address): Renamed from read_address;
made non-static.
(execute_stack_op): All callers updated.
* dwarf2expr.h: Add prototype for dwarf2_read_address.
* dwarf2loc.c (find_location_expression): New function.
(dwarf_expr_frame_base): Call it.
(dwarf2_evaluate_loc_desc): Handle 0-length location expressions.
(dwarf2_tracepoint_var_ref): New function, broken out from
locexpr_tracepoint_var_ref.
(locexpr_tracepoint_var_ref): Call dwarf2_tracepoint_var_ref.
Make static.
(loclist_read_variable, loclist_read_needs_frame): New functions.
(loclist_describe_location, loclist_tracepoint_var_ref): New
functions.
(dwarf2_loclist_funcs): New struct location_funcs.
* dwarf2loc.h (struct dwarf2_loclist_baton): New type.
(struct dwarf2_locexpr_baton): Add comments.
(dwarf2_loclist_funcs): New extern.
* dwarf2read.c (struct comp_unit_head): Remove DIE member, add
base_address and base_known.
(dwarf_loc_buffer): New variable.
(struct dwarf2_pinfo): Add dwarf_loc_buffer and dwarf_loc_size.
(DWARF_LOC_BUFFER, DWARF_LOC_SIZE): New macros.
(dwarf2_has_info): Initialize dwarf_loc_offset.
(dwarf2_build_psymtabs): Read in .debug_loc.
(dwarf2_build_psymtabs_hard): Use DWARF_LOC_BUFFER and
DWARF_LOC_SIZE.
(psymtab_to_symtab_1): Likewise.  Move base address calculation
here, from...
(dwarf2_get_pc_bounds): ... here.  Use the base address from
cu_header.
(dwarf2_symbol_mark_computed): Handle location lists.

21 years ago * minsyms.c (install_minimal_symbols): Only switch to gnu-v3 mode
Daniel Jacobowitz [Sun, 13 Apr 2003 15:25:23 +0000 (15:25 +0000)]
* minsyms.c (install_minimal_symbols): Only switch to gnu-v3 mode
if the linkage name demangled successfully.

21 years ago* x86-64-tdep.c (att_flavour, intel_flavour, valid_flavours,
Mark Kettenis [Sun, 13 Apr 2003 14:51:20 +0000 (14:51 +0000)]
* x86-64-tdep.c (att_flavour, intel_flavour, valid_flavours,
disassmbly_flavour): Removed.

21 years ago * ld-discard/extern.s, ld-discard/start.s, ld-discard/static.s,
Daniel Jacobowitz [Sun, 13 Apr 2003 14:42:22 +0000 (14:42 +0000)]
* ld-discard/extern.s, ld-discard/start.s, ld-discard/static.s,
ld-sh/refdbg.s: Add leading 0 to .debug_info to prevent parsing it
for error messages.

21 years ago* x86-64-tdep.c (gdb_print_insn_x86_64): Removed.
Mark Kettenis [Sun, 13 Apr 2003 13:33:49 +0000 (13:33 +0000)]
* x86-64-tdep.c (gdb_print_insn_x86_64): Removed.

21 years ago* x86-64-tdep.c (x86_64_breakpoint_from_pc): Removed.
Mark Kettenis [Sun, 13 Apr 2003 12:32:02 +0000 (12:32 +0000)]
* x86-64-tdep.c (x86_64_breakpoint_from_pc): Removed.

21 years agoOnly call XScale_check_memacc if in XScale mode.
Nick Clifton [Sun, 13 Apr 2003 08:54:06 +0000 (08:54 +0000)]
Only call XScale_check_memacc if in XScale mode.

21 years ago2003-04-12 Andrew Cagney <cagney@redhat.com>
Andrew Cagney [Sun, 13 Apr 2003 00:10:22 +0000 (00:10 +0000)]
2003-04-12  Andrew Cagney  <cagney@redhat.com>

* frame.h (struct frame_info): Move definition from here ...
* frame.c (struct frame_info): ... to here.

21 years ago*** empty log message ***
gdbadmin [Sun, 13 Apr 2003 00:00:31 +0000 (00:00 +0000)]
*** empty log message ***

21 years agodaily update
Alan Modra [Sun, 13 Apr 2003 00:00:04 +0000 (00:00 +0000)]
daily update

21 years ago2003-04-12 Andrew Cagney <cagney@redhat.com>
Andrew Cagney [Sat, 12 Apr 2003 17:48:55 +0000 (17:48 +0000)]
2003-04-12  Andrew Cagney  <cagney@redhat.com>

* gdbthread.h (save_infrun_state): Delete parameter
"prev_func_start".
(struct thread_info): Delete field "prev_func_start".
(load_infrun_state): Ditto.
* thread.c (load_infrun_state, save_infrun_state): Update.
* infrun.c (prev_func_start): Delete variable.
(context_switch, init_wait_for_inferior): Update.
(stop_stepping, keep_going): Update.

21 years ago2003-04-12 Andrew Cagney <cagney@redhat.com>
Andrew Cagney [Sat, 12 Apr 2003 17:41:26 +0000 (17:41 +0000)]
2003-04-12  Andrew Cagney  <cagney@redhat.com>

* gdbarch.sh: Add missing opaque declarations.
* gdbarch.h: Regnerate.
* symtab.h: Add missing opaque declarations.
* value.h, target.h, symfile.h, stabsread.h: Ditto.
* x86-64-tdep.h, xmodem.h, monitor.h, typeprint.h: Ditto.
* srec.h, solib-svr4.h, source.h, inferior.h: Ditto.
* ser-unix.h, serial.h, remote-utils.h, gdbcore.h: Ditto.
* ppc-tdep.h, ocd.h, mips-tdep.h, gdbtypes.h: Ditto.
* buildsym.h, builtin-regs.h, linespec.h, language.h: Ditto.
* i387-tdep.h, gdbthread.h, event-top.h, gdb.h: Ditto.
* dwarf2cfi.h, doublest.h, disasm.h, cp-abi.h: Ditto.
* cli-out.h, c-lang.h, ax-gdb.h, arch-utils.h: Ditto.
* ada-lang.h, config/nm-lynx.h, config/nm-linux.h: Ditto.
* config/sparc/tm-sp64.h, config/rs6000/tm-rs6000.h: Ditto.
* config/pa/tm-hppah.h, config/m68k/tm-delta68.h: Ditto.
* cli/cli-setshow.h, cli/cli-script.h: Ditto.

21 years ago* elfxx-mips.c (mips_elf_calculate_relocation): Adjust two other
Alexandre Oliva [Sat, 12 Apr 2003 08:50:28 +0000 (08:50 +0000)]
* elfxx-mips.c (mips_elf_calculate_relocation): Adjust two other
occurrences of the same test changed in the previous patch.
Optimize.

21 years ago2003-04-11 Andrew Cagney <cagney@redhat.com>
Andrew Cagney [Sat, 12 Apr 2003 04:27:29 +0000 (04:27 +0000)]
2003-04-11  Andrew Cagney  <cagney@redhat.com>

* frame.c (get_frame_id): Return this frame's "id".
(legacy_get_prev_frame): Set prev's frame ID code_addr to the
function start.
(legacy_saved_regs_this_id): Replace function body with
internal-error.
(deprecated_frame_xmalloc): Mark the frame ID as valid, use
FRAME_OBSTACK_ZALLOC.
(create_new_frame): Mark the frame ID as valid.

21 years ago* elfxx-mips.c (mips_elf_get_global_gotsym_index): New.
Alexandre Oliva [Sat, 12 Apr 2003 00:31:42 +0000 (00:31 +0000)]
* elfxx-mips.c (mips_elf_get_global_gotsym_index): New.
(mips_elf_calculate_relocation): Decay GOT_PAGE/GOT_OFST to
GOT_DISP/addend only if the symbol got a global GOT entry.

21 years ago* Makefile.in (libbfd_h): Added missing setting.
Alexandre Oliva [Sat, 12 Apr 2003 00:31:30 +0000 (00:31 +0000)]
* Makefile.in (libbfd_h): Added missing setting.
* mips-tdep.c (mips_gdbarch_init): Set disassembler_options
according to the selected ABI.

21 years agodaily update
Alan Modra [Sat, 12 Apr 2003 00:00:07 +0000 (00:00 +0000)]
daily update

21 years ago*** empty log message ***
gdbadmin [Sat, 12 Apr 2003 00:00:02 +0000 (00:00 +0000)]
*** empty log message ***

21 years ago2003-04-11 Jeff Johnston <jjohnstn@redhat.com>
Jeff Johnston [Fri, 11 Apr 2003 20:56:40 +0000 (20:56 +0000)]
2003-04-11  Jeff Johnston  <jjohnstn@redhat.com>

        * gdb_indent.sh: Recognize pid_t and sigset_t as types.

21 years ago* gdb.c++/derivation.exp, gdb.c++/overload.exp,
Jim Blandy [Fri, 11 Apr 2003 19:57:33 +0000 (19:57 +0000)]
* gdb.c++/derivation.exp, gdb.c++/overload.exp,
gdb.c++/userdef.cc: Place comments on the lines to which the
marker function might return.
* gdb.c++/derivation.exp, gdb.c++/overload.exp,
gdb.c++/userdef.exp: Look for those comments to check that we've
returned to the right place, instead of checking line numbers.

21 years ago2003-04-11 Andrew Cagney <cagney@redhat.com>
Andrew Cagney [Fri, 11 Apr 2003 18:15:40 +0000 (18:15 +0000)]
2003-04-11  Andrew Cagney  <cagney@redhat.com>

* gdbarch.sh (DEPRECATED_SAVED_PC_AFTER_CALL): Deprecate
SAVED_PC_AFTER_CALL.
* gdbarch.h, gdbarch.c: Regenerate.
* xstormy16-tdep.c (xstormy16_gdbarch_init): Update.
* x86-64-tdep.c (x86_64_init_abi): Update.
* vax-tdep.c (vax_gdbarch_init): Update.
* v850-tdep.c (v850_gdbarch_init): Update.
* sparc-tdep.c (sparc_gdbarch_init): Update.
* sh-tdep.c (sh_gdbarch_init): Update.
* s390-tdep.c (s390_gdbarch_init): Update.
* rs6000-tdep.c (rs6000_gdbarch_init): Update.
* ns32k-tdep.c (ns32k_gdbarch_init): Update.
* mn10300-tdep.c (mn10300_gdbarch_init): Update.
* mips-tdep.c (mips_gdbarch_init): Update.
* mcore-tdep.c (mcore_gdbarch_init): Update.
* m68k-tdep.c (m68k_gdbarch_init): Update.
* m68hc11-tdep.c (m68hc11_gdbarch_init): Update.
* ia64-tdep.c (ia64_gdbarch_init): Update.
(ia64_saved_pc_after_call): Update declaration.
* i386ly-tdep.c (i386lynx_init_abi): Update.
* i386-tdep.c (i386_gdbarch_init): Update.
* hppa-tdep.c (hppa_gdbarch_init): Update.
* h8300-tdep.c (h8300_gdbarch_init): Update.
* frv-tdep.c (frv_gdbarch_init): Update.
* cris-tdep.c (cris_gdbarch_init): Update.
* avr-tdep.c (avr_gdbarch_init): Update.
* arm-tdep.c (arm_gdbarch_init): Update.
* alpha-tdep.c (alpha_gdbarch_init): Update.
* ns32knbsd-nat.c (frame_num_args): Update.
* ns32k-tdep.c (umax_frame_num_args): Update.
* mips-tdep.c (mips_init_frame_pc_first): Update.
* infrun.c (step_over_function): Update.
* i386-linux-tdep.c (skip_hurd_resolver): Update.
* i386-interix-tdep.c (i386_interix_back_one_frame): Update.
* config/sparc/tm-sparc.h (DEPRECATED_SAVED_PC_AFTER_CALL): Update.
(DEPRECATED_INIT_FRAME_PC_FIRST): Update.
* config/rs6000/tm-rs6000.h (DEPRECATED_INIT_FRAME_PC_FIRST): Update.
* config/pa/tm-hppa.h (DEPRECATED_SAVED_PC_AFTER_CALL): Update.
* arm-linux-tdep.c (skip_hurd_resolver): Update.
* arch-utils.c (init_frame_pc_default): Update.
* alpha-tdep.c (alpha_init_frame_pc_first): Update.
* x86-64-tdep.h (x86_64_linux_saved_pc_after_call): Update
declaration.

21 years ago2003-04-11 Andrew Cagney <cagney@redhat.com>
Andrew Cagney [Fri, 11 Apr 2003 14:56:40 +0000 (14:56 +0000)]
2003-04-11  Andrew Cagney  <cagney@redhat.com>

* i387-tdep.c: Update copyright.
(i387_to_double): Delete function.
(double_to_i387): Delete function.

21 years ago2003-04-11 Elena Zannoni <ezannoni@redhat.com>
Elena Zannoni [Fri, 11 Apr 2003 13:55:32 +0000 (13:55 +0000)]
2003-04-11  Elena Zannoni  <ezannoni@redhat.com>

        * gdb.threads/pthreads.exp (test_startup): When setting a breakpoint
        match on sourcefile name, instead of directory name.

21 years ago* libtool.m4 (lt_cv_deplibs_check_method): Use pass_all on mips*.
Alexandre Oliva [Fri, 11 Apr 2003 03:58:39 +0000 (03:58 +0000)]
* libtool.m4 (lt_cv_deplibs_check_method): Use pass_all on mips*.
* */configure: Rebuilt.

21 years ago2003-04-10 Andrew Cagney <cagney@redhat.com>
Andrew Cagney [Fri, 11 Apr 2003 03:12:58 +0000 (03:12 +0000)]
2003-04-10  Andrew Cagney  <cagney@redhat.com>

* d10v-tdep.c (d10v_frame_this_id): Set the code addr to the
frame's function's address.  Simplify.
(d10v_frame_unwind_cache): Check that the frame's function is
non-zero.

21 years ago* gas/mips/elf-rel-got-n32.d, gas/mips/elf-rel-got-n32.s,
Alexandre Oliva [Fri, 11 Apr 2003 01:56:52 +0000 (01:56 +0000)]
* gas/mips/elf-rel-got-n32.d, gas/mips/elf-rel-got-n32.s,
gas/mips/elf-rel-got-n64.d, gas/mips/elf-rel-got-n64.s,
gas/mips/elf-rel-xgot-n32.d, gas/mips/elf-rel-xgot-n64.d: New.
* gas/mips/mips.exp: Test them.

21 years ago* ld-mips-elf/elf-rel-got-n32.d,
Alexandre Oliva [Fri, 11 Apr 2003 01:56:51 +0000 (01:56 +0000)]
* ld-mips-elf/elf-rel-got-n32.d,
ld-mips-elf/elf-rel-got-n64.d, ld-mips-elf/elf-rel-xgot-n32.d,
ld-mips-elf/elf-rel-xgot-n64.d: New.
* ld-mips-elf/mips-elf.exp (hasn32): Define as condition for
new tests to run.

21 years ago* config/tc-mips.h (tc_frag_data_type, TC_FRAG_TYPE): New.
Alexandre Oliva [Fri, 11 Apr 2003 01:56:50 +0000 (01:56 +0000)]
* config/tc-mips.h (tc_frag_data_type, TC_FRAG_TYPE): New.
* config/tc-mips.c: Use signed add for n32 address arithmetic.
(append_insn): When filling delay slots with instructions
that have fixups that tc_gen_reloc might consider modifyable
in variant frags, start a new frag.
(load_address): Generate GOT_DISP with of without offset
depending on whether symbol is local.  For -xgot, use
GOT_PAGE/GOT_OFST or GOT_HI16/GOT_LO16.
(macro) <M_DLA_AB, M_LA_AB>: Likewise.
<M_JAL_A>: In NewABI, use CALL16 or GOT_DISP for small got,
CALL_HI16/CALL_LO16 or GOT_PAGE/GOT_OFST for big got.
<ld_st>: In NewABI with small got, always use
GOT_PAGE/GOT_OFST, with the latter in the load/store
instruction.  With big got, use GOT_HI16/GOT_LO16 or
GOT_PAGE/GOT_OFST.
(tc_gen_reloc): Adjust variant frags with GOT_DISP in NewABI.
Add tc_frag_data.tc_fr_offset to addends.  Decay CALL16,
GOT_OFST and GOT_DISP to GOT_DISP in NewABI.
(md_convert_frag): Use memmove for safe copying of overlapping
regions.

21 years ago* elfxx-mips.c (mips_elf_calculate_relocation): Decay
Alexandre Oliva [Fri, 11 Apr 2003 01:56:49 +0000 (01:56 +0000)]
* elfxx-mips.c (mips_elf_calculate_relocation): Decay
GOT_PAGE/GOT_OFST referencing overridable symbol to
GOT_DISP/addend.
(_bfd_mips_elf_check_relocs): Handle GOT_PAGE referencing
global symbol as GOT_DISP.

21 years agodaily update
Alan Modra [Fri, 11 Apr 2003 00:00:05 +0000 (00:00 +0000)]
daily update

21 years ago*** empty log message ***
gdbadmin [Fri, 11 Apr 2003 00:00:03 +0000 (00:00 +0000)]
*** empty log message ***

21 years ago* s390-tdep.c (s390_gdbarch_init): Put back accidentally deleted
Jim Blandy [Thu, 10 Apr 2003 22:40:38 +0000 (22:40 +0000)]
* s390-tdep.c (s390_gdbarch_init): Put back accidentally deleted
call to set_gdbarch_deprecated_push_arguments.

21 years ago * elf32-xtensa.c (elf_xtensa_relocate_section): Don't continue to the
Bob Wilson [Thu, 10 Apr 2003 19:19:02 +0000 (19:19 +0000)]
    * elf32-xtensa.c (elf_xtensa_relocate_section): Don't continue to the
        next relocation on an undefined symbol.

21 years ago2003-04-10 Andrew Cagney <cagney@redhat.com>
Andrew Cagney [Thu, 10 Apr 2003 15:32:27 +0000 (15:32 +0000)]
2003-04-10  Andrew Cagney  <cagney@redhat.com>

* frame.c (fprint_frame_id): New function.
(fprint_frame_type, fprint_frame): New function.
(frame_pc_unwind, frame_func_unwind): Add/update trace code.
(create_sentinel_frame, get_frame_id): Ditto.
(frame_id_p, frame_id_eq): Ditto.
(frame_id_inner, create_new_frame): Ditto.
(legacy_get_prev_frame, get_prev_frame): Ditto.
(deprecated_update_frame_pc_hack): Ditto.
(frame_register_unwind): Ditto.
(deprecated_update_frame_base_hack): Ditto.

21 years ago2003-04-10 Elena Zannoni <ezannoni@redhat.com>
Elena Zannoni [Thu, 10 Apr 2003 13:38:15 +0000 (13:38 +0000)]
2003-04-10  Elena Zannoni  <ezannoni@redhat.com>

* gdb.base/completion.exp: Use string_to_regexp to match the
working directory name.

21 years ago * i386-cygwin-tdep.c (i386_cygwin_frame_chain): New function.
Corinna Vinschen [Thu, 10 Apr 2003 13:15:50 +0000 (13:15 +0000)]
* i386-cygwin-tdep.c (i386_cygwin_frame_chain): New function.
(i386_cygwin_init_abi): Set i386_cygwin_frame_chain as new
frame_chain function.
* Makefile.in: Add dependencies due to above change.

21 years ago * blockframe.c (legacy_frame_chain_valid): Move call to
Corinna Vinschen [Thu, 10 Apr 2003 11:12:30 +0000 (11:12 +0000)]
* blockframe.c (legacy_frame_chain_valid): Move call to
DEPRECATED_FRAME_CHAIN_VALID before calls to inside_entry_func and
inside_entry_file.

21 years ago2003-04-09 Andrew Cagney <cagney@redhat.com>
Andrew Cagney [Thu, 10 Apr 2003 03:30:36 +0000 (03:30 +0000)]
2003-04-09  Andrew Cagney  <cagney@redhat.com>

* frame.h (struct frame_id): Replace "pc" and "base" with
"stack_addr" and "code_addr".  Update comments.
(frame_id_build): Update parameter names and comment.
(struct frame_info): Replace "id_p" and "id" with "this_id".
* dummy-frame.c (dummy_frame_this_id): Update.
* breakpoint.c (print_one_breakpoint): Update.
* frame.c (get_frame_id): Update.
(get_frame_base, frame_id_build): Update.
(create_sentinel_frame, legacy_get_prev_frame): Update.
(deprecated_update_frame_base_hack): Update.
(frame_id_p, frame_id_eq): Rework, return 0 when an invalid ID.
(frame_id_inner): Ditto.

21 years ago2003-04-09 Andrew Cagney <cagney@redhat.com>
Andrew Cagney [Thu, 10 Apr 2003 02:18:40 +0000 (02:18 +0000)]
2003-04-09  Andrew Cagney  <cagney@redhat.com>

* defs.h (gdb_print_host_address): Make "addr" parameter a
pointer constant.
* utils.c (gdb_print_host_address): Update.

21 years ago*** empty log message ***
gdbadmin [Thu, 10 Apr 2003 00:00:31 +0000 (00:00 +0000)]
*** empty log message ***

21 years agodaily update
Alan Modra [Thu, 10 Apr 2003 00:00:06 +0000 (00:00 +0000)]
daily update

21 years ago* gdb.c++/derivation.exp, gdb.c++/overload.exp,
Jim Blandy [Wed, 9 Apr 2003 23:21:14 +0000 (23:21 +0000)]
* gdb.c++/derivation.exp, gdb.c++/overload.exp,
gdb.c++/userdef.exp: If GDB fails to restore the selected frame
after an inferior function call, report the failure, but allow the
test to continue.

21 years ago * rs6000-tdep.c (frame_get_saved_regs): Don't assume that the
Kevin Buettner [Wed, 9 Apr 2003 22:44:24 +0000 (22:44 +0000)]
* rs6000-tdep.c (frame_get_saved_regs): Don't assume that the
register number for R0 is 0.

21 years ago * frame.h (struct gdbarch): Add opaque structure definition
Joel Brobecker [Wed, 9 Apr 2003 21:53:28 +0000 (21:53 +0000)]
    * frame.h (struct gdbarch): Add opaque structure definition
        to avoid a compilation warning on LynxOS 4.0.

21 years ago * doc/c-m68hc11.texi (M68HC11-Opts): Document -m68hcs12, -mshort,
Stephane Carrez [Wed, 9 Apr 2003 21:48:39 +0000 (21:48 +0000)]
* doc/c-m68hc11.texi (M68HC11-Opts): Document -m68hcs12, -mshort,
-mlong, -mshort-double and -mlong-double options; use table @code.
(M68HC11-Syntax): Update to document 68HC12 operands.
(M68HC11-Modifiers): New section for operand modifiers.
(M68HC11-Directives): New section for specific assembler directives.
(M68HC11-Branch): Fix Overfull hbox error.

21 years ago2003-04-09 Andrew Cagney <cagney@redhat.com>
Andrew Cagney [Wed, 9 Apr 2003 20:49:22 +0000 (20:49 +0000)]
2003-04-09  Andrew Cagney  <cagney@redhat.com>

* frame.h (struct frame_info): Delete field "pc".  Replace
"pc_unwind_cache" and "pc_unwind_cache_p" with "prev_pc"
structure.
* frame.c (frame_pc_unwind): Update.
(create_sentinel_frame): Do not set "pc".
(get_prev_frame): Do not set "pc".  Use frame_pc_unwind.
(get_frame_pc): Call frame_pc_unwind.
(deprecated_update_frame_pc_hack): Update.
(create_new_frame): Use "pc" not "->pc".

21 years ago * elf64-alpha.c (elf64_alpha_relocate_section) <R_ALPHA_GPREL32>:
Richard Henderson [Wed, 9 Apr 2003 20:08:14 +0000 (20:08 +0000)]
    * elf64-alpha.c (elf64_alpha_relocate_section) <R_ALPHA_GPREL32>:
        Ignore relocations against r_symndx == 0.

21 years ago2003-04-09 Andrew Cagney <cagney@redhat.com>
Andrew Cagney [Wed, 9 Apr 2003 18:24:01 +0000 (18:24 +0000)]
2003-04-09  Andrew Cagney  <cagney@redhat.com>

* frame.c (get_frame_id): Eliminate code updating "frame".
(legacy_get_prev_frame): Ditto.
(get_frame_base): Return id.base directly.
(deprecated_update_frame_base_hack): Update "id.base".
* frame.h (struct frame_info): Delete field "frame".

21 years ago2003-04-09 H.J. Lu <hjl@gnu.org>
H.J. Lu [Wed, 9 Apr 2003 16:19:53 +0000 (16:19 +0000)]
2003-04-09  H.J. Lu <hjl@gnu.org>

* elf64-alpha.c (elf64_alpha_relocate_section): Don't return
FALSE for undefined symbols.
* elfxx-ia64.c (elfNN_ia64_relocate_section): Likewise.

21 years ago2003-04-09 Andrew Cagney <cagney@redhat.com>
Andrew Cagney [Wed, 9 Apr 2003 16:19:52 +0000 (16:19 +0000)]
2003-04-09  Andrew Cagney  <cagney@redhat.com>

* NEWS: Mention that the "Sequent family" is obsolete.
* configure.tgt: Obsolete i[3456]86-sequent-bsd*,
i[3456]86-sequent-sysv4*, and i[3456]86-sequent-sysv*.
* configure.host: Obsolete i[3456]86-sequent-bsd*,
i[3456]86-sequent-sysv4*, and i[3456]86-sequent-sysv*.
* config/i386/tm-ptx4.h: Obsolete file.
* config/i386/tm-ptx.h: Obsolete file.
* symm-tdep.c: Obsolete file.
* config/i386/symmetry.mt: Obsolete file.
* config/i386/tm-symmetry.h: Obsolete file.
* symm-nat.c: Obsolete file.
* config/i386/nm-symmetry.h: Obsolete file.
* config/i386/xm-symmetry.h: Obsolete file.
* config/i386/symmetry.mh: Obsolete file.
* config/i386/nm-ptx4.h: Obsolete file.
* config/i386/ptx4.mh: Obsolete file.
* config/i386/ptx.mt: Obsolete file.
* config/i386/ptx.mh: Obsolete file.
* config/i386/xm-ptx4.h: Obsolete file.
* config/i386/xm-ptx.h: Obsolete file.

21 years ago2003-04-09 Andrew Cagney <cagney@redhat.com>
Andrew Cagney [Wed, 9 Apr 2003 16:10:06 +0000 (16:10 +0000)]
2003-04-09  Andrew Cagney  <cagney@redhat.com>

Obsolete mips*-*-mach3*.
* NEWS: Mention that mips*-*-mach3* is obsolete.
* m3-nat.c: Obsolete file.
* config/nm-m3.h: Obsolete file.
* config/mips/tm-mipsm3.h: Obsolete file.
* config/mips/mipsm3.mt: Obsolete file.
* config/mips/mipsm3.mh: Obsolete file.
* config/mips/xm-mipsm3.h: Obsolete file.
* mipsm3-nat.c: Obsolete file.
* configure.host: Obsolete mips-dec-mach3*.
* configure.tgt: Obsolete mips*-*-mach3*.

21 years ago2003-04-09 Andrew Cagney <cagney@redhat.com>
Andrew Cagney [Wed, 9 Apr 2003 15:08:27 +0000 (15:08 +0000)]
2003-04-09  Andrew Cagney  <cagney@redhat.com>

* doublest.h: Update copyright.
(deprecated_store_floating, deprecated_extract_floating): Rename
store_floating and extract_floating.  Update comments.
* doublest.c: Update copyright.
(extract_floating_by_length): Replace extract_floating.
(store_floating_by_length): Replace store_floating.
(deprecated_extract_floating): New function.
(deprecated_store_floating): New function.
(extract_typed_floating): Call extract_floating_by_length.
(store_typed_floating): Call store_floating_by_length.
* x86-64-tdep.c (x86_64_store_return_value): Update.
* sh-tdep.c (sh3e_sh4_extract_return_value): Update.
(sh64_extract_return_value): Update.
(sh_sh4_register_convert_to_virtual): Update.
(sh_sh64_register_convert_to_virtual): Update.
(sh_sh4_register_convert_to_raw): Update.
(sh_sh64_register_convert_to_raw): Update.
* rs6000-tdep.c (rs6000_register_convert_to_virtual): Update.
(rs6000_register_convert_to_raw): Update.
* ia64-tdep.c (ia64_register_convert_to_virtual): Update.
(ia64_register_convert_to_raw): Update.
* config/i386/tm-symmetry.h (REGISTER_CONVERT_TO_RAW): Update.
(REGISTER_CONVERT_TO_VIRTUAL): Update.
* arm-linux-tdep.c (arm_linux_push_arguments): Update.
* alpha-tdep.c (alpha_register_convert_to_virtual): Update.
(alpha_register_convert_to_raw): Update.

21 years agoAdd initX, finiX, ctors, dtors sections to respect C++ constructor/destructor.
Nick Clifton [Wed, 9 Apr 2003 11:07:51 +0000 (11:07 +0000)]
Add initX, finiX, ctors, dtors sections to respect C++ constructor/destructor.
Add ctors/dtors start/stop definitions.

21 years ago* dwarf2.c (_bfd_dwarf2_find_nearest_line): Try DWARF3-standard
Alexandre Oliva [Wed, 9 Apr 2003 09:56:17 +0000 (09:56 +0000)]
* dwarf2.c (_bfd_dwarf2_find_nearest_line): Try DWARF3-standard
and IRIX-specific shift-to-64-bit 4-byte lengths before following
addr_size.

21 years ago* doc/binutils.texi (objdump) [--debugging]: Suggest readelf -w
Alexandre Oliva [Wed, 9 Apr 2003 09:55:13 +0000 (09:55 +0000)]
* doc/binutils.texi (objdump) [--debugging]: Suggest readelf -w
for debugging information types not supported by objdump.

21 years ago * configure.in: Recognize canonical form of i[3-6]86-pe*.
Alan Modra [Wed, 9 Apr 2003 05:14:35 +0000 (05:14 +0000)]
* configure.in: Recognize canonical form of i[3-6]86-pe*.
* configure: Regenerate.

21 years ago* readelf.c (display_debug_info): Apply RELA relocations on the
Alexandre Oliva [Wed, 9 Apr 2003 04:07:56 +0000 (04:07 +0000)]
* readelf.c (display_debug_info): Apply RELA relocations on the
entire section.
(byte_put_little_endian, byte_put_big_endian): New functions.
(byte_put): New variable.
(get_file_header): Initialize it.

21 years ago* config/tc-mips.c (macro): Add comments explaining the rationale
Alexandre Oliva [Wed, 9 Apr 2003 03:09:12 +0000 (03:09 +0000)]
* config/tc-mips.c (macro): Add comments explaining the rationale
for Chris' change.

21 years ago* config/tc-mips.c (macro): Put back `+ 0x8000' in test for 64-bit
Alexandre Oliva [Wed, 9 Apr 2003 03:07:48 +0000 (03:07 +0000)]
* config/tc-mips.c (macro): Put back `+ 0x8000' in test for 64-bit
constant address that Alexandre took out by accident.  Reject
64-bit addresses that are not sign extensions of 32 bits only if
we don't support 64-bit address constants.

21 years ago* elf32-mips.c (bfd_elf32_bfd_reloc_type_lookup): Detect (ctor)
Alexandre Oliva [Wed, 9 Apr 2003 02:55:40 +0000 (02:55 +0000)]
* elf32-mips.c (bfd_elf32_bfd_reloc_type_lookup): Detect (ctor)
pointer size from ABI, not arch_bits_per_address.

21 years ago * mips.h: Correct comment typo.
Alan Modra [Wed, 9 Apr 2003 00:12:24 +0000 (00:12 +0000)]
* mips.h: Correct comment typo.

21 years ago*** empty log message ***
gdbadmin [Wed, 9 Apr 2003 00:00:32 +0000 (00:00 +0000)]
*** empty log message ***

21 years agodaily update
Alan Modra [Wed, 9 Apr 2003 00:00:05 +0000 (00:00 +0000)]
daily update

21 years ago * config/tc-ppc.c (md_apply_fix3): Generate ADDR16 relocs.
Alan Modra [Tue, 8 Apr 2003 23:01:47 +0000 (23:01 +0000)]
* config/tc-ppc.c (md_apply_fix3): Generate ADDR16 relocs.

21 years ago2003-04-08 Andrew Cagney <cagney@redhat.com>
Andrew Cagney [Tue, 8 Apr 2003 21:56:10 +0000 (21:56 +0000)]
2003-04-08  Andrew Cagney  <cagney@redhat.com>

* gdbarch.sh (SAVED_PC_AFTER_CALL): Add a predicate.
* gdbarch.h, gdbarch.c: Re-generate.
* d10v-tdep.c (d10v_saved_pc_after_call): Delete function.
(d10v_gdbarch_init): Do not set saved_pc_after_call.
* infrun.c (step_over_function): Call SAVED_PC_AFTER_CALL_P
conditionally, use frame_pc_unwind as an alternative.  Add
comments.
* arch-utils.c (init_frame_pc_default): Only call
SAVED_PC_AFTER_CALL when available.

21 years ago2003-04-08 Andrew Cagney <cagney@redhat.com>
Andrew Cagney [Tue, 8 Apr 2003 21:48:40 +0000 (21:48 +0000)]
2003-04-08  Andrew Cagney  <cagney@redhat.com>

* gdb792.exp: Skip when C++.

21 years ago2003-04-08 Andrew Cagney <cagney@redhat.com>
Andrew Cagney [Tue, 8 Apr 2003 21:25:33 +0000 (21:25 +0000)]
2003-04-08  Andrew Cagney  <cagney@redhat.com>

* gdbint.texinfo (Target Architecture Definition): Delete
references to EXTRA_FRAME_INFO.

21 years ago2003-04-08 Andrew Cagney <cagney@redhat.com>
Andrew Cagney [Tue, 8 Apr 2003 21:20:06 +0000 (21:20 +0000)]
2003-04-08  Andrew Cagney  <cagney@redhat.com>

* gdbint.texinfo (Target Architecture Definition): Delete
PRINT_TYPELESS_INTEGER.

21 years ago2003-04-08 Elena Zannoni <ezannoni@redhat.com>
Elena Zannoni [Tue, 8 Apr 2003 19:21:15 +0000 (19:21 +0000)]
2003-04-08  Elena Zannoni  <ezannoni@redhat.com>

        * infrun.c (stop_soon): Rename from stop_soon_quietly.
(struct inferior_status): Rename stop_soon_quietly field to stop_soon.
(clear_proceed_status): Rename stop_soon_quietly to stop_soon.
(start_remote): Ditto.
(handle_inferior_event): Ditto.
(save_inferior_status): Ditto.
(restore_inferior_status): Ditto.
* infcmd.c (attach_command): Ditto.
* fork-child.c (startup_inferior): Ditto.
        * inferior.h (stop_soon): Rename from stop_soon_quietly.
* alpha-tdep.c (heuristic_proc_start): Ditto.
* mips-tdep.c (heuristic_proc_start): Ditto.
* solib-svr4.c (svr4_solib_create_inferior_hook): Ditto.
* solib-sunos.c (sunos_solib_create_inferior_hook): Ditto.
* solib-osf.c (osf_solib_create_inferior_hook): Ditto.
* solib-irix.c (irix_solib_create_inferior_hook): Ditto.
* remote-vx.c (vx_create_inferior): Ditto.

21 years ago2003-04-08 Elena Zannoni <ezannoni@redhat.com>
Elena Zannoni [Tue, 8 Apr 2003 18:52:04 +0000 (18:52 +0000)]
2003-04-08  Elena Zannoni  <ezannoni@redhat.com>

* infrun.c (stop_soon_quietly): Make it an enum, to better
override the default behavior of handle_inferior_event.
(clear_proceed_status): Update uses of stop_soon_quietly to
reflect that it is now an enum.
(start_remote): Ditto.
(handle_inferior_event): Change logic a bit if stop_soon_quietly
is set to handle the new GNU/Linux kernel behavior for
attach/sigstop.  Update uses of stop_soon_quietly.
* inferior.h (enum stop_kind): New enum.
* infcmd.c (attach_command): Use STOP_QUIETLY_NO_SIGSTOP.
Reset normal handle_inferior_event behavior, afterwards.
* fork-child.c (startup_inferior): Update.
* alpha-tdep.c (heuristic_proc_start): Update.
* solib-svr4.c (svr4_solib_create_inferior_hook): Update.
* solib-sunos.c (sunos_solib_create_inferior_hook): Update.
* solib-osf.c (osf_solib_create_inferior_hook): Update.
* solib-irix.c (irix_solib_create_inferior_hook): Update.
* remote-vx.c (vx_create_inferior): Update.
* mips-tdep.c (heuristic_proc_start): Update.

21 years ago* as.c (perform_an_assembly_pass): If using cgen, call gas_cgen_begin.
Nick Clifton [Tue, 8 Apr 2003 12:47:08 +0000 (12:47 +0000)]
* as.c (perform_an_assembly_pass): If using cgen, call gas_cgen_begin.
* cgen.c (gas_cgen_begin): New function.  If flag_signed_overflow_ok is set
call cgen_set_signed_overflow_ok otherwise call cgen_clear_signed_overflow_ok.
* cgen.h: Prototype gas_cgen_begin.
* testsuite/gas/m32r/m32r.exp: Run signed-relocs test.
* testsuite/gas/m32r/signed-relocs.s: New file: Test signed relocs.
* testsuite/gas/m32r/signed-relocs.d: New file: Expected results

21 years ago* ia64-ic.tbl (fr-readers): Add mem-writers-fp.
Nick Clifton [Tue, 8 Apr 2003 09:50:07 +0000 (09:50 +0000)]
* ia64-ic.tbl (fr-readers): Add mem-writers-fp.
* ia64-asmtab.c: Regenerate.
* gas/ia64/dependency-1.s: New file: Test read before write dependency.
* gas/ia64/dependency-1.d: New file: Expected assembly results.
* gas/ia64/ia64.exp: Run the new test.

21 years ago* mips-dis.c (mips_gpr_names_newabi): Reverted previous patch.
Alexandre Oliva [Tue, 8 Apr 2003 07:14:47 +0000 (07:14 +0000)]
* mips-dis.c (mips_gpr_names_newabi): Reverted previous patch.

21 years ago2003-04-04 Elena Zannoni <ezannoni@redhat.com>
Elena Zannoni [Tue, 8 Apr 2003 01:40:31 +0000 (01:40 +0000)]
2003-04-04  Elena Zannoni  <ezannoni@redhat.com>

* disasm.c (dump_insns):  Move variables inside loop, or they will
        be freed more than once, causing wild memory corruptions.
(gdb_disassembly): Look for the substring "-thread",
        instead of "-threads" in the target name, to make sure to find
        the 'multi-thread' target.  Also, make sure we do the right thing
        with the "core" target.

21 years ago* mips-dis.c (mips_gpr_names_newabi): $12-$15 are named $t4-$t7.
Alexandre Oliva [Tue, 8 Apr 2003 00:39:16 +0000 (00:39 +0000)]
* mips-dis.c (mips_gpr_names_newabi): $12-$15 are named $t4-$t7.

21 years ago*** empty log message ***
gdbadmin [Tue, 8 Apr 2003 00:00:31 +0000 (00:00 +0000)]
*** empty log message ***

21 years agodaily update
Alan Modra [Tue, 8 Apr 2003 00:00:06 +0000 (00:00 +0000)]
daily update

21 years ago * elfn32-mips.c (elf32_mips_grok_prstatus): Adjust core file related
Kevin Buettner [Mon, 7 Apr 2003 20:08:10 +0000 (20:08 +0000)]
* elfn32-mips.c (elf32_mips_grok_prstatus): Adjust core file related
constants for n32 ABI.

21 years ago * mips-tdep.c (mips_print_fp_register): New function, created from
Kevin Buettner [Mon, 7 Apr 2003 18:38:04 +0000 (18:38 +0000)]
* mips-tdep.c (mips_print_fp_register): New function, created from
do_fp_register_row().  Registers are now (also) printed as hex.
Only one register is printed per row.
(mips_print_register, do_fp_register_row): Print floating point
registers with mips_print_fp_register().

21 years agooops - omitted from previous delta
Nick Clifton [Mon, 7 Apr 2003 10:09:54 +0000 (10:09 +0000)]
oops - omitted from previous delta