Brandon Philips [Wed, 1 Feb 2017 23:54:42 +0000 (00:54 +0100)]
man: fix spelling error parth -> path
Zbigniew Jędrzejewski-Szmek [Wed, 1 Feb 2017 23:23:46 +0000 (18:23 -0500)]
systemctl: restore --failed (#5198)
'systemctl --failed' is an extremely common operation and it's nice to have
a shortcut for it.
Revert "man: don't document systemctl --failed" and add the option back to
systemctl's help and shell completion scripts.
This reverts commit
036359ba8d0aba7db7eac75d10073a849a033fd1.
Zbigniew Jędrzejewski-Szmek [Wed, 1 Feb 2017 20:50:03 +0000 (15:50 -0500)]
system-update-generator: warn if the command line blocks updates (#5173)
If "3", "5", "systemd.unit=", or similar are present on the kernel command line,
the system will not enter into offline update. This behaviour is in line with the
general logic that configuration on the kernel command line has higher priority
than the configuration on disk, but is rather surprising. Emit a warning to help
users diagnose the situation.
https://bugzilla.redhat.com/show_bug.cgi?id=1405439#c4
Zbigniew Jędrzejewski-Szmek [Wed, 1 Feb 2017 15:27:32 +0000 (10:27 -0500)]
Merge pull request #5191 from keszybz/tweaks
Zbigniew Jędrzejewski-Szmek [Wed, 1 Feb 2017 15:26:50 +0000 (10:26 -0500)]
Revert "Trivial typo fixes and code refactorings (#5191)"
Let's do a merge to preserve all the commit messages.
This reverts commit
785d345145bbd06c8f1c75c6a0b119c4e8f411db.
Zbigniew Jędrzejewski-Szmek [Wed, 1 Feb 2017 14:04:27 +0000 (09:04 -0500)]
Trivial typo fixes and code refactorings (#5191)
* logind: trivial simplification
free_and_strdup() handles NULL arg, so make use of that.
* boot: fix two typos
* pid1: rewrite check in ignore_proc() to not check condition twice
It's harmless, but it seems nicer to evaluate a condition just a single time.
* core/execute: reformat exec_context_named_iofds() for legibility
* core/execute.c: check asprintf return value in the usual fashion
This is unlikely to fail, but we cannot rely on asprintf return value
on failure, so let's just be correct here.
CID #1368227.
* core/timer: use (void)
CID #1368234.
* journal-file: check asprintf return value in the usual fashion
This is unlikely to fail, but we cannot rely on asprintf return value
on failure, so let's just be correct here.
CID #1368236.
* shared/cgroup-show: use (void)
CID #1368243.
* cryptsetup: do not return uninitialized value on error
CID #1368416.
Philip Withnall [Wed, 1 Feb 2017 13:36:16 +0000 (13:36 +0000)]
nspawn: Print attempted execv() path on failure (#5199)
The failure message is typically currently:
execv() failed: No such file or directory
which is not very useful because it doesn’t tell you which file or
directory it was trying to exec.
Evgeny Vereshchagin [Wed, 1 Feb 2017 09:02:50 +0000 (12:02 +0300)]
Merge pull request #5166 from keszybz/gcc7
Fixes for gcc 7 and new µhttpd & glibc warnings
Zbigniew Jędrzejewski-Szmek [Wed, 1 Feb 2017 01:36:20 +0000 (20:36 -0500)]
Merge pull request #5146 from ssahani/ifname-alias
networkd: Allow ':' in label
This reverts
a341dfe563 and takes a slightly different approach: anything is
allowed in network interface labels, but network interface names are verified
as before (i.e. amongst other things, no colons are allowed there).
Zbigniew Jędrzejewski-Szmek [Wed, 1 Feb 2017 00:55:33 +0000 (19:55 -0500)]
nss-util: silence warning about deprecated RES_USE_INET6
src/nss-resolve/nss-resolve.c: In function ‘_nss_resolve_gethostbyname_r’:
src/nss-resolve/nss-resolve.c:680:13: warning: RES_USE_INET6 is deprecated
NSS_GETHOSTBYNAME_FALLBACKS(resolve);
^~~~~~~~~~~~~~~~~~~~~~~~~
In glibc bz #19582, RES_USE_INET6 was deprecated. This might make sense for
clients, but they didn't take into account nss module implementations which
*must* continue to support the option. glibc internally defines
DEPRECATED_RES_USE_INET6 which can be used without emitting a warning, but
it's not exported publicly. Let's do the same, and just copy the definition
to our header.
Zbigniew Jędrzejewski-Szmek [Wed, 1 Feb 2017 00:35:04 +0000 (19:35 -0500)]
MurmurHash: all /* fall through */ comments
Zbigniew Jędrzejewski-Szmek [Tue, 31 Jan 2017 19:01:53 +0000 (14:01 -0500)]
cryptsetup: do not return uninitialized value on error
CID #1368416.
Zbigniew Jędrzejewski-Szmek [Fri, 27 Jan 2017 06:08:08 +0000 (01:08 -0500)]
journal/lookup3: silence gcc 7 implicit-fallthrough warning
This file doesn't include any of our headers, so just use the pragma
without defining it in macros.h
Zbigniew Jędrzejewski-Szmek [Fri, 27 Jan 2017 05:50:10 +0000 (00:50 -0500)]
tree-wide: adjust fall through comments so that gcc is happy
gcc 7 adds -Wimplicit-fallthrough=3 to -Wextra. There are a few ways
we could deal with that. After we take into account the need to stay compatible
with older versions of the compiler (and other compilers), I don't think adding
__attribute__((fallthrough)), even as a macro, is worth the trouble. It sticks
out too much, a comment is just as good. But gcc has some very specific
requiremnts how the comment should look. Adjust it the specific form that it
likes. I don't think the extra stuff we had in those comments was adding much
value.
(Note: the documentation seems to be wrong, and seems to describe a different
pattern from the one that is actually used. I guess either the docs or the code
will have to change before gcc 7 is finalized.)
Zbigniew Jędrzejewski-Szmek [Fri, 27 Jan 2017 05:45:38 +0000 (00:45 -0500)]
nspawn: fix clobbering of selinux context arg
First bug fixed by gcc 7. Yikes.
Zbigniew Jędrzejewski-Szmek [Fri, 27 Jan 2017 05:25:20 +0000 (00:25 -0500)]
pid1: remove duplicate const attribute
gcc 7 started warning about this.
Zbigniew Jędrzejewski-Szmek [Fri, 27 Jan 2017 05:15:07 +0000 (00:15 -0500)]
microhttpd-util: silence warnings about deprecated options
Evgeny Vereshchagin [Tue, 31 Jan 2017 18:04:01 +0000 (21:04 +0300)]
core: fix copy paste error (s/source/destination/) (#5197)
```
-bash-4.3# systemd-run --property BindPaths=/etc:tmp/hey sh -c 'ls /tmp/hey'
```
prints
`Destination path tmp/hey is not absolute.`
instead of
`Destination path /etc is not absolute.`
CID #1368239
Zbigniew Jędrzejewski-Szmek [Tue, 31 Jan 2017 16:39:04 +0000 (11:39 -0500)]
shared/cgroup-show: use (void)
CID #1368243.
Zbigniew Jędrzejewski-Szmek [Tue, 31 Jan 2017 16:36:08 +0000 (11:36 -0500)]
journal-file: check asprintf return value in the usual fashion
This is unlikely to fail, but we cannot rely on asprintf return value
on failure, so let's just be correct here.
CID #1368236.
Zbigniew Jędrzejewski-Szmek [Tue, 31 Jan 2017 16:33:56 +0000 (11:33 -0500)]
core/timer: use (void)
CID #1368234.
Zbigniew Jędrzejewski-Szmek [Tue, 31 Jan 2017 16:31:47 +0000 (11:31 -0500)]
core/execute.c: check asprintf return value in the usual fashion
This is unlikely to fail, but we cannot rely on asprintf return value
on failure, so let's just be correct here.
CID #1368227.
Zbigniew Jędrzejewski-Szmek [Tue, 31 Jan 2017 16:23:10 +0000 (11:23 -0500)]
core/execute: reformat exec_context_named_iofds() for legibility
Evgeny Vereshchagin [Tue, 31 Jan 2017 16:04:20 +0000 (19:04 +0300)]
coredump: really extract container cmdline (#5167)
Fixes:
```
root# systemd-nspawn -D ./cont/ --register=no /bin/sh -c '/bin/sh -c "kill -ABRT \$\$"'
...
Container cont failed with error code 134.
root# journalctl MESSAGE_ID=
fc2e22bc6ee647b6b90729ab34a250b1 -o verbose | grep -i container_cmdline
...prints nothing...
...should be COREDUMP_CONTAINER_CMDLINE=systemd-nspawn -D ./cont/ --register=no /bin/sh -c /bin/sh -c "kill -ABRT \$\$"
```
Also, fixes CID #1368263
```
==352== 130 bytes in 1 blocks are definitely lost in loss record 1 of 2
==352== at 0x4C2ED5F: realloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==352== by 0x4ED8581: greedy_realloc (alloc-util.c:57)
==352== by 0x4ECAAD5: get_process_cmdline (process-util.c:147)
==352== by 0x10E385: get_process_container_parent_cmdline (coredump.c:645)
==352== by 0x112949: process_kernel (coredump.c:1240)
==352== by 0x113003: main (coredump.c:1297)
==352==
```
Zbigniew Jędrzejewski-Szmek [Tue, 31 Jan 2017 15:56:09 +0000 (10:56 -0500)]
Merge pull request #5168 from ddstreet/apply_format_helper
simplify udev_event_apply_format().
Zbigniew Jędrzejewski-Szmek [Tue, 31 Jan 2017 15:51:56 +0000 (10:51 -0500)]
Merge pull request #5177 from M0Rf30/master
hwdb: quirk for kionix accelerometer on Asus TP500LB
Zbigniew Jędrzejewski-Szmek [Tue, 31 Jan 2017 15:36:30 +0000 (10:36 -0500)]
Merge pull request #5192 from keszybz/systemctl-ignore-sigterm
Fix for initrd-switch-root failing and causing emergency.target to be started.
3chas3 [Tue, 31 Jan 2017 13:21:15 +0000 (08:21 -0500)]
util-lib: Fix chase_symlinks() with absolute symlinks (#5185)
If chase_symlinks() encouters an absolute symlink, it resets the todo
buffer to just the newly discovered symlink and discards any of the
remaining previous symlink path. Regardless of whether or not the
symlink is absolute or relative, we need to preserve the remainder of
the path that has not yet been resolved.
Evgeny Vereshchagin [Tue, 31 Jan 2017 07:27:14 +0000 (10:27 +0300)]
basic: check strdup result in khash_dup (#5176)
Fixes CID #1368249
Martin Pitt [Tue, 31 Jan 2017 07:26:42 +0000 (08:26 +0100)]
Merge pull request #5175 from keszybz/hostname-fallback
Allow distributions to override the "localhost" fallback
Zbigniew Jędrzejewski-Szmek [Tue, 31 Jan 2017 07:25:19 +0000 (02:25 -0500)]
man: mention ConditionFirstBoot= in systemd-firstboot(1) (#5186)
Zbigniew Jędrzejewski-Szmek [Tue, 31 Jan 2017 05:34:33 +0000 (00:34 -0500)]
units: restore Before dependencies for systemd-vconsole-setup.service
When the service is run in the initramfs, it is possible for it to get started
and not be fast enough to exit before the root switch happens. It is started
multiple times (depending on the consoles being detected), and runs
asynchronously, so this is quite likely. It'll then get killed by killall(),
and systemd will consider the service failed. To avoid all this, just wait
for the service to terminate on it's own.
Before=initrd-switch-root.target should be good for the initramfs, and
Before=shutdown.tuarget should be good for the real system, although it's
unlikely to make any difference there.
Zbigniew Jędrzejewski-Szmek [Mon, 30 Jan 2017 18:06:10 +0000 (13:06 -0500)]
systemctl: ignore SIGTERM after switch root
https://bugzilla.redhat.com/show_bug.cgi?id=1414904#c14 and #c15.
Zbigniew Jędrzejewski-Szmek [Sun, 29 Jan 2017 17:45:51 +0000 (12:45 -0500)]
units: drop KillMode= from initrd-switch-root.service
The service already has DefaultDeps disabled, so systemd should not try to stop
it. And if it *does* get stopped, we don't want the zombie process around.
KillMode=none does not change anything in the killall() phase, and we already
use argv[0][0] = '@' to protect against that anyway. KillMode=none should not
be useful in normal operation, so let's leave it out.
Zbigniew Jędrzejewski-Szmek [Sun, 29 Jan 2017 02:18:31 +0000 (21:18 -0500)]
systemctl: always avoid being killed when doing switch-root
The same logic as described in
acc28e2e3037d689d6481e applies to any time we are
switching root, to just set the flag unconditionally.
Zbigniew Jędrzejewski-Szmek [Sun, 29 Jan 2017 02:09:08 +0000 (21:09 -0500)]
pid1: rewrite check in ignore_proc() to not check condition twice
It's harmless, but it seems nicer to evaluate a condition just a single time.
Zbigniew Jędrzejewski-Szmek [Sat, 28 Jan 2017 04:06:57 +0000 (23:06 -0500)]
boot: fix two typos
Zbigniew Jędrzejewski-Szmek [Sat, 28 Jan 2017 02:50:06 +0000 (21:50 -0500)]
logind: trivial simplification
free_and_strdup() handles NULL arg, so make use of that.
Yi EungJun [Mon, 30 Jan 2017 15:24:06 +0000 (00:24 +0900)]
journal-gatewayd: return -EINVAL if ARG_TRUST and HAVE_GNUTLS (#5181)
This bug was introduced by 1aa1e59.
Ivan Shapovalov [Sun, 29 Jan 2017 19:33:37 +0000 (23:33 +0400)]
journal-gatewayd: actually recognize -D as a synonym for --directory (#5180)
M0Rf30 [Sat, 28 Jan 2017 22:48:55 +0000 (23:48 +0100)]
hwdb: Asus TP500LB accelerometer support
M0Rf30 [Sat, 28 Jan 2017 22:48:15 +0000 (23:48 +0100)]
hwdb: references added to hwdb rules format, needed to write syntax-correctly rules
M0Rf30 [Sat, 28 Jan 2017 12:49:40 +0000 (13:49 +0100)]
hwdb: use -y option to udevadm trigger to correctly do sysname-match
Zbigniew Jędrzejewski-Szmek [Sat, 28 Jan 2017 04:36:01 +0000 (23:36 -0500)]
build-sys,hostnamed: allow distributions to override the "localhost" fallback
A configure param is added to make this easy to change if distributions want
to differentiate on that. The default remains unchanged.
https://bugzilla.redhat.com/show_bug.cgi?id=1392925#c10
Zbigniew Jędrzejewski-Szmek [Sat, 28 Jan 2017 04:18:29 +0000 (23:18 -0500)]
configure: use lowercase for "nobody" and "system"
No reason to capitalize words which are not names. And "nobody" is
a user name, traditionally lowercase.
Dan Streetman [Thu, 26 Jan 2017 19:18:10 +0000 (14:18 -0500)]
udev-event: use in-place whitespace replacement
Instead of using a temp buffer to replace whitespace in variable
substitutions, just allow util_replace_whitespace to replace in-place.
Add a comment to util_replace_whitespace indicating it is used to replace
in-place, to prevent accidental future breakage.
Dan Streetman [Thu, 26 Jan 2017 01:06:54 +0000 (20:06 -0500)]
udev-event: refactor udev_event_apply_format
Move the large case statement into its own function
llua [Fri, 27 Jan 2017 12:50:40 +0000 (07:50 -0500)]
zsh-completion: _journalctl fixes (#5165)
allow _journalctl to work when the rcquotes option is set, broken in
ba89f80620d619867b4838973785d529c5a959f6.
allow the completion of --file multiple times, which
ba89f80620d619867b4838973785d529c5a959f6 claims is true.
Fixes #4842
Dan Streetman [Thu, 26 Jan 2017 01:24:52 +0000 (20:24 -0500)]
tests: add tests for SYMLINK containing whitespace in variable (#5158)
add udev-test.pl tests for whitespace in a substituted variable,
to verify the variable whitespace is replaced with underscores.
Tests for the change made by commit
0a10235ed453 ("udev-rules:
perform whitespace replacement for symlink subst values")
clearyf [Thu, 26 Jan 2017 01:20:17 +0000 (02:20 +0100)]
hwdb: add Razer DeathAdder Black Edition (#5157)
Evgeny Vereshchagin [Wed, 25 Jan 2017 13:31:11 +0000 (16:31 +0300)]
Merge pull request #5152 from keszybz/strv-free
Use strv_free where appropriate
Jan Synacek [Wed, 25 Jan 2017 12:44:04 +0000 (13:44 +0100)]
bash-completion: add support for --now (#5155)
Zbigniew Jędrzejewski-Szmek [Wed, 25 Jan 2017 03:27:21 +0000 (22:27 -0500)]
resolve: fix strv memleak
sd_bus_message_read_strv() returns a normal strv...
Zbigniew Jędrzejewski-Szmek [Wed, 25 Jan 2017 03:24:07 +0000 (22:24 -0500)]
core/execute: fix strv memleak
compile_read_write_paths() returns a normal strv from strv_copy(), and
setup_namespace() uses it read-only, so we should use strv_free to deallocate.
Zbigniew Jędrzejewski-Szmek [Wed, 25 Jan 2017 03:21:16 +0000 (22:21 -0500)]
core/dbus: fix two strv memleaks
job_dbus_path and unit_dbus_path both allocate new strings, so we should use
strv_free.
Evgeny Vereshchagin [Wed, 25 Jan 2017 02:53:50 +0000 (05:53 +0300)]
core: fix memleak in bus_exec_context_set_transient_property (#5143)
Fixes:
```sh
systemd-run --property EnvironmentFile=/some/environment/file /bin/sleep 30
```
```
23 bytes in 1 blocks are definitely lost in loss record 1 of 7
at 0x4C2DB9D: malloc (vg_replace_malloc.c:299)
by 0x4E85488: malloc_multiply (alloc-util.h:70)
by 0x4E85F19: strjoin_real (string-util.c:252)
by 0x1AF741: bus_exec_context_set_transient_property (dbus-execute.c:1418)
by 0x1A907C: bus_service_set_property (dbus-service.c:330)
by 0x1A66DD: bus_unit_set_properties (dbus-unit.c:1456)
by 0x19CF93: transient_unit_from_message (dbus-manager.c:892)
by 0x19D388: method_start_transient_unit (dbus-manager.c:980)
by 0x4F60544: method_callbacks_run (bus-objects.c:418)
by 0x4F62D9D: object_find_and_run (bus-objects.c:1255)
by 0x4F633CE: bus_process_object (bus-objects.c:1371)
by 0x4F2CE1D: process_message (sd-bus.c:2563)
```
Closes: #5142
Jakub Wilk [Wed, 25 Jan 2017 02:45:58 +0000 (03:45 +0100)]
po: Fix invalid date in Croatian translation (#5147)
Stefan Schweter [Wed, 25 Jan 2017 02:45:30 +0000 (03:45 +0100)]
tree-wide: remove consecutive duplicate words in comments (#5148)
Stefan Schweter [Wed, 25 Jan 2017 02:44:59 +0000 (03:44 +0100)]
virt: update url to hypervisor top-level functional specification (#5149)
Stefan Schweter [Wed, 25 Jan 2017 02:44:19 +0000 (03:44 +0100)]
catalog: make support URL to show in shipped catalog entries configurable (#5150)
Susant Sahani [Tue, 24 Jan 2017 18:37:52 +0000 (00:07 +0530)]
networkd: Allow ':' in label
IFA_LABEL does not need much of a validation except the length
that is IFNAMSIZ as seen from kernel code.
Susant Sahani [Tue, 24 Jan 2017 18:24:34 +0000 (23:54 +0530)]
socket-utils: revert
f1811313f42dc7ddaed3c47edc834c2bfd1309b2
':' in not a a valid interface name.
Franck Bui [Tue, 24 Jan 2017 13:29:57 +0000 (14:29 +0100)]
core: don't load dropin data multiple times for the same unit (#5139)
When an alias is loaded, we resolve this alias to its final unit first to load
the dropin data.
However if the final unit was already loaded, there's no point in reloading the
dropin data a second time.
This patch optimizes this case.
Also this allows the dropin loading code to assume that only units not yet
loaded are passed down. This assumption is not yet used but might be in the
future.
[zj: invert the condition in the if]
peoronoob [Tue, 24 Jan 2017 03:26:41 +0000 (04:26 +0100)]
network: accept colons in network interface names, normally used for alias interfaces (#5117)
Jan Synacek [Tue, 24 Jan 2017 03:06:05 +0000 (04:06 +0100)]
core: improve error message when RefuseManualStart(Stop) is hit (#5132)
Michal Sekletar [Tue, 24 Jan 2017 02:18:40 +0000 (03:18 +0100)]
load-fragment: fix comment to reflect changes made in 43eb109 (#5138)
Lucas Werkmeister [Tue, 24 Jan 2017 02:18:07 +0000 (03:18 +0100)]
README: document CONFIG_USER_NS requirement for PrivateUsers (#5140)
Evgeny Vereshchagin [Tue, 24 Jan 2017 02:12:58 +0000 (05:12 +0300)]
sd-network: fix memleak in dhcp6_lease_set_domains (#5113)
The simplest way to reproduce:
```diff
diff --git a/src/libsystemd-network/test-dhcp6-client.c b/src/libsystemd-network/test-dhcp6-client.c
index bd289fa..4e14d8f 100644
--- a/src/libsystemd-network/test-dhcp6-client.c
+++ b/src/libsystemd-network/test-dhcp6-client.c
@@ -286,6 +286,8 @@ static int test_advertise_option(sd_event *e) {
assert_se(optlen == 11);
assert_se(dhcp6_lease_set_domains(lease, optval,
optlen) >= 0);
+ assert_se(dhcp6_lease_set_domains(lease, optval,
+ optlen) >= 0);
break;
case SD_DHCP6_OPTION_SNTP_SERVERS:
```
Fixes:
```
==27369==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 10 byte(s) in 1 object(s) allocated from:
#0 0x7f90e7d21160 in strdup (/lib64/libasan.so.3+0x5a160)
#1 0x7f90e7467f69 in strv_extend src/basic/strv.c:552
#2 0x5612fcc19379 in dhcp6_option_parse_domainname src/libsystemd-network/dhcp6-option.c:399
#3 0x5612fcc1acdf in dhcp6_lease_set_domains src/libsystemd-network/sd-dhcp6-lease.c:225
#4 0x5612fcc06b95 in test_advertise_option src/libsystemd-network/test-dhcp6-client.c:287
#5 0x5612fcc0a987 in main src/libsystemd-network/test-dhcp6-client.c:761
#6 0x7f90e6d46400 in __libc_start_main (/lib64/libc.so.6+0x20400)
SUMMARY: AddressSanitizer: 10 byte(s) leaked in 1 allocation(s).
```
Evgeny Vereshchagin [Tue, 24 Jan 2017 02:11:59 +0000 (05:11 +0300)]
sd-network: fix memleak in dhcp6_option_parse_domainname (#5114)
The simplest way to reproduce:
```diff
diff --git a/src/libsystemd-network/test-dhcp6-client.c b/src/libsystemd-network/test-dhcp6-client.c
index bd289fa..7b0a5ef 100644
--- a/src/libsystemd-network/test-dhcp6-client.c
+++ b/src/libsystemd-network/test-dhcp6-client.c
@@ -168,7 +168,7 @@ static uint8_t msg_advertise[198] = {
0x00, 0x17, 0x00, 0x10, 0x20, 0x01, 0x0d, 0xb8,
0xde, 0xad, 0xbe, 0xef, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x01, 0x00, 0x18, 0x00, 0x0b,
- 0x03, 0x6c, 0x61, 0x62, 0x05, 0x69, 0x6e, 0x74,
+ 0x01, 0x6c, 0x01, 0x62, 0x00, 0x0a, 0x6e, 0x74,
0x72, 0x61, 0x00, 0x00, 0x1f, 0x00, 0x10, 0x20,
0x01, 0x0d, 0xb8, 0xde, 0xad, 0xbe, 0xef, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00,
@@ -338,9 +338,7 @@ static int test_advertise_option(sd_event *e) {
assert_se(!memcmp(addrs, &msg_advertise[124], r * 16));
r = sd_dhcp6_lease_get_domains(lease, &domains);
- assert_se(r == 1);
- assert_se(!strcmp("lab.intra", domains[0]));
- assert_se(domains[1] == NULL);
+ assert_se(r == -ENOENT);
r = sd_dhcp6_lease_get_ntp_addrs(lease, &addrs);
assert_se(r == 1);
```
Fixes:
```
=================================================================
==15043==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 4 byte(s) in 1 object(s) allocated from:
#0 0x7f13c8564160 in strdup (/lib64/libasan.so.3+0x5a160)
#1 0x7f13c7caaf69 in strv_extend src/basic/strv.c:552
#2 0x55f775787230 in dhcp6_option_parse_domainname src/libsystemd-network/dhcp6-option.c:399
#3 0x55f775788b96 in dhcp6_lease_set_domains src/libsystemd-network/sd-dhcp6-lease.c:225
#4 0x55f775774b95 in test_advertise_option src/libsystemd-network/test-dhcp6-client.c:287
#5 0x55f77577883e in main src/libsystemd-network/test-dhcp6-client.c:759
#6 0x7f13c7589400 in __libc_start_main (/lib64/libc.so.6+0x20400)
Direct leak of 4 byte(s) in 1 object(s) allocated from:
#0 0x7f13c8564160 in strdup (/lib64/libasan.so.3+0x5a160)
#1 0x7f13c7caaf69 in strv_extend src/basic/strv.c:552
#2 0x55f775787230 in dhcp6_option_parse_domainname src/libsystemd-network/dhcp6-option.c:399
#3 0x55f775788b96 in dhcp6_lease_set_domains src/libsystemd-network/sd-dhcp6-lease.c:225
#4 0x55f775781348 in client_parse_message src/libsystemd-network/sd-dhcp6-client.c:807
#5 0x55f775781ba2 in client_receive_advertise src/libsystemd-network/sd-dhcp6-client.c:895
#6 0x55f775782453 in client_receive_message src/libsystemd-network/sd-dhcp6-client.c:994
#7 0x7f13c7e447f4 in source_dispatch src/libsystemd/sd-event/sd-event.c:2268
#8 0x7f13c7e471b0 in sd_event_dispatch src/libsystemd/sd-event/sd-event.c:2627
#9 0x7f13c7e47ab3 in sd_event_run src/libsystemd/sd-event/sd-event.c:2686
#10 0x7f13c7e47c21 in sd_event_loop src/libsystemd/sd-event/sd-event.c:2706
#11 0x55f77577863c in test_client_solicit src/libsystemd-network/test-dhcp6-client.c:737
#12 0x55f77577884b in main src/libsystemd-network/test-dhcp6-client.c:760
#13 0x7f13c7589400 in __libc_start_main (/lib64/libc.so.6+0x20400)
SUMMARY: AddressSanitizer: 8 byte(s) leaked in 2 allocation(s).
```
Peter Hutterer [Tue, 24 Jan 2017 02:10:33 +0000 (12:10 +1000)]
hwdb: mark Wacom touchpads as external (#5115)
Wacom doesn't have any internal touchpads.
Zbigniew Jędrzejewski-Szmek [Tue, 24 Jan 2017 01:20:13 +0000 (20:20 -0500)]
Merge pull request #5112 from yuwata/fix-5105
core: add missing unit_add_to_load_queue() to mount_setup_new_unit()
Yu Watanabe [Fri, 20 Jan 2017 00:46:47 +0000 (09:46 +0900)]
core: add missing unit_add_to_load_queue() to mount_setup_new_unit()
unit_add_to_load_queue was present in the code before
03b8cfede9ff3441b1ec8ff5cdf6876294846aa4,
and was inadvertently dropped.
Fixes #5105
Yu Watanabe [Fri, 20 Jan 2017 00:45:58 +0000 (09:45 +0900)]
core: minor error handling fix in mount_setup_new_unit()
The function mount_setup_new_unit() should return -ENOMEM
if at least one of `strdup` calls are failed.
Александр Тихонов [Sat, 21 Jan 2017 19:53:09 +0000 (23:53 +0400)]
Fixi caching in zsh completion (#5122)
I found several issues with zsh completion code:
1. typo in cache filename: "SYS_ALL_PROPRTIES", so cache just not loading from this file
2. cache stored in one file, despite user or system mode. So it can be loaded later in wrong mode
3. most serious problem: broken logic - it retrieves cache when _cache_invalid is true
How to reproduce: type "systemctl --user status <TAB>" and you will see user units. Then press
control+C and type "systemctl --system status <TAB>" in same session and you'll see user units again
Zbigniew Jędrzejewski-Szmek [Sat, 21 Jan 2017 17:48:27 +0000 (12:48 -0500)]
Merge pull request #5126 from namhyung/journalctl-completion
bash_completion: Small update for journalctl completion.
Namhyung Kim [Sat, 21 Jan 2017 07:38:23 +0000 (16:38 +0900)]
bash_completion: journalctl: Complete -t option values
The -t or --identifier requires a syslog identifier.
Namhyung Kim [Sat, 21 Jan 2017 07:36:20 +0000 (16:36 +0900)]
bash_completion: journalctl: add missing options
The --no-hostname and --vacuum-files were missing, add them.
Rike-Benjamin Schuppner [Fri, 20 Jan 2017 00:10:30 +0000 (01:10 +0100)]
man: fix flag in systemd-run (#5107)
Jakub Wilk [Thu, 19 Jan 2017 15:54:22 +0000 (16:54 +0100)]
man: fix typos (#5109)
Djalal Harouni [Wed, 18 Jan 2017 13:36:07 +0000 (14:36 +0100)]
Merge pull request #5098 from evverx/fix-nspawn-notifications
nspawn: change owner/group of /run/systemd/nspawn/notify to userns-root
Zbigniew Jędrzejewski-Szmek [Wed, 18 Jan 2017 04:10:46 +0000 (23:10 -0500)]
Merge pull request #4991 from poettering/seccomp-fix
Zbigniew Jędrzejewski-Szmek [Wed, 18 Jan 2017 03:38:55 +0000 (22:38 -0500)]
pid1: provide a more detailed error message when execution fails (#5074)
Fixes #5000.
Lennart Poettering [Tue, 27 Dec 2016 15:50:02 +0000 (16:50 +0100)]
seccomp: minor simplifications for is_seccomp_available()
Lennart Poettering [Tue, 27 Dec 2016 14:28:25 +0000 (15:28 +0100)]
seccomp: rework seccomp code, to improve compat with some archs
This substantially reworks the seccomp code, to ensure better
compatibility with some architectures, including i386.
So far we relied on libseccomp's internal handling of the multiple
syscall ABIs supported on Linux. This is problematic however, as it does
not define clear semantics if an ABI is not able to support specific
seccomp rules we install.
This rework hence changes a couple of things:
- We no longer use seccomp_rule_add(), but only
seccomp_rule_add_exact(), and fail the installation of a filter if the
architecture doesn't support it.
- We no longer rely on adding multiple syscall architectures to a single filter,
but instead install a separate filter for each syscall architecture
supported. This way, we can install a strict filter for x86-64, while
permitting a less strict filter for i386.
- All high-level filter additions are now moved from execute.c to
seccomp-util.c, so that we can test them independently of the service
execution logic.
- Tests have been added for all types of our seccomp filters.
- SystemCallFilters= and SystemCallArchitectures= are now implemented in
independent filters and installation logic, as they semantically are
very much independent of each other.
Fixes: #4575
AsciiWolf [Tue, 17 Jan 2017 11:09:38 +0000 (12:09 +0100)]
man: fix typo (#5093)
Evgeny Vereshchagin [Tue, 17 Jan 2017 01:37:05 +0000 (01:37 +0000)]
tests: check that we can write to /run/systemd/nspawn/notify
See https://github.com/systemd/systemd/issues/4944
Evgeny Vereshchagin [Tue, 17 Jan 2017 01:19:34 +0000 (01:19 +0000)]
nspawn: change owner/group of /run/systemd/nspawn/notify to userns-root
Fixes #4944
Franck Bui [Mon, 16 Jan 2017 20:19:13 +0000 (21:19 +0100)]
core: make sure to init mount params before calling mount_is_extrinsic() (#5087)
When a new entry appears in /proc/self/mountinfo, mount_setup_unit()
allocated a new mount unit for it and starts initializing it.
mount_setup_unit() is also used to update a mount unit when a change happens in
/proc/self/mountinfo, for example a mountpoint can be remounted with additional
mount options.
This patch introduces 2 separate functions to deal with those 2 cases instead
of mount_setup_unit() dealing with both of them. The common code is small and
doing the split makes the code easier to read and less error prone if extended
later.
It also makes sure to initialize in both functions the mount parameters of the
mount unit before calling mount_is_extrinsic() since this function relies on
them.
Fixes: #4902
Cédric Schieli [Mon, 16 Jan 2017 17:23:26 +0000 (18:23 +0100)]
ndisc: honor IPv6AcceptRA.UseDNS when parsing RA options (#5071)
RDNSS and DNSLL options received in RA are always used, possibly breaking the resolution of private domains hosted on a local DNS server. When setting UseDNS=no in a [IPv6AcceptRA] section of a .network file, both RDNSS and DNSLL options in received RA should be ignored.
Fixes: #5040
Björn [Mon, 16 Jan 2017 17:19:04 +0000 (18:19 +0100)]
hwdb: add axis range corrections for Lenovo X1 Carbon 4th gen. / X1 Yoga (#5089)
The parameters were calculated on my X1 Yoga using touchpad-edge-detector; As as the device name indicates, the Touchpad is exactly the same as the X1 Carbon 4th gen.
Martin Pitt [Mon, 16 Jan 2017 06:56:53 +0000 (07:56 +0100)]
Merge pull request #5085 from keszybz/variables
Fixes for gcc and coverity warnings
Earnestly [Mon, 16 Jan 2017 01:41:59 +0000 (01:41 +0000)]
hwdb: Include X220 for pointingstick sensitivity (#5083)
Without this the trackpoint is very difficult to manoeuvre until
manually correcting the sysfs serio1/sensitivity entry.
kilian-k [Sun, 15 Jan 2017 22:21:33 +0000 (23:21 +0100)]
hwdb: add Logitech TrackMan Wheel (#5084)
Zbigniew Jędrzejewski-Szmek [Sun, 15 Jan 2017 21:57:57 +0000 (16:57 -0500)]
nspawn: fix memleak
CID #1368262: fn is allocated with new, so it should be freed.
Zbigniew Jędrzejewski-Szmek [Sun, 15 Jan 2017 18:42:53 +0000 (13:42 -0500)]
shared/install-printf: fix memleak
instance might be "", and that string would be leaked.
CID #1368264.
Zbigniew Jędrzejewski-Szmek [Sun, 15 Jan 2017 18:38:43 +0000 (13:38 -0500)]
systemctl: fix alignment with units in not-found state
A fixed value (6 and later 5) was added back in
4deb3b93911, and
not updated when load_len was added later on.
Also the other 5 with 1 + 1 + 1 + 1 + 1 to make it easier to see
that this is about the column separators.
Zbigniew Jędrzejewski-Szmek [Sun, 15 Jan 2017 18:27:37 +0000 (13:27 -0500)]
systemctl: uninitalized variable
CID #1368270.
Easily reproduced with COLUMNS=50 ./systemctl --no-pager.
Zbigniew Jędrzejewski-Szmek [Sun, 15 Jan 2017 17:41:34 +0000 (12:41 -0500)]
process-util: rename char *r to ans and add comment
Add a comment about the return value and rename r to ans. r is
nowadays reserved for the integer return value, and char *r is confusing.
Zbigniew Jędrzejewski-Szmek [Sun, 15 Jan 2017 16:55:46 +0000 (11:55 -0500)]
journalctl: fix memleak
This is harmless, it would only happen if --verify-key is used multiple times.
But let's fix it for correctness.
CID ##1368415.
Zbigniew Jędrzejewski-Szmek [Sun, 15 Jan 2017 16:51:48 +0000 (11:51 -0500)]
cryptsetup: fix unitialized variable
CID #1368416.
Coverity web interface is back, yay!