Larry Sachs [Thu, 29 Sep 2016 17:46:19 +0000 (10:46 -0700)]
Throw OcException for invalid (null) parameters in Java Layer of android_api
[IOT-1323] -- [RI][Android] observe(with QualityOfService) API does not throw OcException while passing parameter-observeType as Null value
Change-Id: If0d7acb0f5bbfda75e2fd774b6cccc8ce21e5650
Signed-off-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12573
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
Randeep Singh [Thu, 29 Sep 2016 08:36:44 +0000 (14:06 +0530)]
Andorid(JNI) Implementation for Cloud Provisioning.
Patch #1: Add JNI interface for getAclByDeviceID API.
Patch #2: Fixes.
Change-Id: I0e8b09f9f1be66d202834e56f3d535604f6a766b
Signed-off-by: Sandeep Sharma <sandeep.s9@samsung.com>
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11507
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Sandipan Patra [Tue, 27 Sep 2016 12:49:56 +0000 (18:19 +0530)]
Fix for Jira issue: IOT-1252
Simulator error codes compatible with OC stack error codes
Change-Id: If03fff46fae4144db4318c5e5d95c97c9ae377fd
Signed-off-by: Sandipan Patra <sandipan.p@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12335
Reviewed-by: Senthil Kumar G S <senthil.gs@samsung.com>
Reviewed-by: Harish Marappa <h.marappa@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
abitha.s [Wed, 28 Sep 2016 14:33:27 +0000 (20:03 +0530)]
Svace fixes for Notification service C++ changes for formatting
Change-Id: I58404514f8f5112fa7897dc3771595ba84a8c8f9
Signed-off-by: abitha.s <abitha.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12435
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
abitha.s [Tue, 27 Sep 2016 13:32:01 +0000 (19:02 +0530)]
[IOT-1363] Fix from C++ changes
patch 2 : resolved merge conflict
Change-Id: I535084c3e1c9fcf302038ccbf98aaff02cd97167
Signed-off-by: abitha.s <abitha.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12343
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
KIM JungYong [Thu, 29 Sep 2016 05:33:09 +0000 (14:33 +0900)]
Modify generating notification consumer id.
generating consumer id is replaced with device id generated by base layer.
Change-Id: I4e8157b938c0e9ea524c838d7d355443f9bb0c41
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12549
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
jaesick.shin [Thu, 29 Sep 2016 01:04:43 +0000 (10:04 +0900)]
Modify coding idiom and unittest, Add function declaration.
this patch include
1. modify coding idiom.
2. modify unittest about delay time.
3. add function declaration about NSSetResourceSecurity.
Change-Id: Id992c731f057580c060ccf08daee54ba6656250d
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12517
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
KIM JungYong [Thu, 29 Sep 2016 02:51:55 +0000 (11:51 +0900)]
Delete NSStorageAdapter header file.
NSStorageAdapter.h file is used by both of provider and consumer.
For the above reason, when import both library, app will crash or build fail.
So in this patch,
NSStorageAdapter.h file is deleted, and related function was renamed.
Change-Id: Iaa243334e644014ea16eefd7338e90b112c0b633
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12535
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
KIM JungYong [Wed, 28 Sep 2016 23:22:56 +0000 (08:22 +0900)]
Fix bug for parse payload on notification service.
When the parsing payload on introspection of notification resource,
finding mandatory logic is incorrect on a payload.
In this patch, finding mandatory logic is fixed.
And incorrect typing is fixed,
enable running of consumer test on building with TEST option.
Change-Id: I707ebe06eed49c00f5d7c850dd82a93424fc8ce1
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12513
Reviewed-by: Chihyun Cho <ch79.cho@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Jaewook Jung [Wed, 28 Sep 2016 01:40:45 +0000 (10:40 +0900)]
annotate OIC_LOG_BUFFER when looking for client callback and observer
Printing all token info while looking for client callback or observer
is burden and makes it hard to see entire log message
even though it is needless.
Change-Id: I25e0c3f1922f207a9d6652017495270db34e6bbc
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12375
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
jihwan.seo [Tue, 27 Sep 2016 09:52:13 +0000 (18:52 +0900)]
[IOT-1324] Fix crash issue which call getPlatformInfo with QoS.
The Listener for getPlatformInfo with QoS used DeviceInfoListener.
So, it replace with PlatformInfoListener.
(it was occurred in Android Platform)
Change-Id: Ia9f0530465267a6f338dc67ba42a8c5b396271ef
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12293
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit
c4dbbd77989f236ab1ae900b45a764cf2eb5d024)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12507
jihwan.seo [Tue, 27 Sep 2016 13:24:33 +0000 (22:24 +0900)]
disable fragmentaton file when BLE is not included
Change-Id: I77105748503fcffe8c815b09db5295dc9dc292cf
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12341
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit
790ac8a8fc696c4fcfc134a32d20629475f580a2)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12509
jihwan.seo [Tue, 27 Sep 2016 04:22:34 +0000 (13:22 +0900)]
Clean up handling argument of the gbsbuild script for Tizen.
Change-Id: Idb7925a3b83bfe31b66139af72597310c9bb3b1e
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12253
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Jaehong Jo [Wed, 7 Sep 2016 06:15:54 +0000 (15:15 +0900)]
Add gnustl_shared library.
For support Android API earlier than level 18 (Android 4.3)
Change-Id: I7b1eefd05a9ff1c8b7f93fadc7596920531725e7
Signed-off-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11483
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
hyuna0213.jo [Mon, 26 Sep 2016 00:19:40 +0000 (09:19 +0900)]
[IOT-1346] Enable network status monitoring for tcp network
In case a connected wifi ap is changed, we have to close
the connected session previously. Otherwise we will use the
invalid session. If network status is down, we try to close
the session. and If network status is up, we create new socket
for listening.
Change-Id: I662df1a9a28d0ca629a8b23f83f94833787c5312
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12185
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Andrii Shtompel [Tue, 27 Sep 2016 14:17:38 +0000 (17:17 +0300)]
[IOT-1351] CloudClient App crashed while Signing Out
[Patch #2] Resolve possible crash reason on 32-bit arch
[Patch #3] Implement correct Sign Up/In/Out flow according to spec
Change-Id: I566dcedee363ab91ecec883e531cdb8ad6fa1f42
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12347
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Md. Imtiaz Hossain <imtiaz.h@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit
ae968b32534707581ed0926a5ced00168e63e6c9)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12545
Randeep Singh [Fri, 2 Sep 2016 11:35:18 +0000 (17:05 +0530)]
Added Cloud provisioning java class
Change-Id: I57a37af84f2202051d99627cfbc18bad6de5d8e4
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11339
Reviewed-by: sandeep sharma <sandeep.s9@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Randeep Singh [Mon, 26 Sep 2016 06:57:01 +0000 (12:27 +0530)]
Removed svace defects
Change-Id: I63cfad7d1b507c4bcb3d6714880e14971bd231cc
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12199
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Greg Zaverucha <gregz@microsoft.com>
(cherry picked from commit
6e9a85dffe9e363a6f44dc2a75fc29be7023dbac)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12541
Jongmin Choi [Wed, 28 Sep 2016 11:05:30 +0000 (20:05 +0900)]
Modify AddCredential API to prevent invalid CredID generation
Three patches combined together
1. Add checking credential uniqueness
- Prevent credential duplication by checking when saving credential
http://suprem.sec.samsung.net/gerrit/#/c/92486/
2. Update the CompareCredential API
- Update CompareCredential API to improve readability
http://suprem.sec.samsung.net/gerrit/#/c/93190/
2. Modify AddCredential API to prevent invalid CredID generation
- Prevent invalid CredID generation
http://suprem.sec.samsung.net/gerrit/#/c/93042/
Patch #3-4: Build error fixed
Patch #5: Old comment removed
Change-Id: I14c16ade352c2011d6b124c374a6b1cece1a0d4d
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12407
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Greg Zaverucha <gregz@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit
2c2788972e68024300ec2bcbd9a0aa1f440f72ee)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12539
Andrii Shtompel [Wed, 28 Sep 2016 12:11:56 +0000 (15:11 +0300)]
[IOT-1350] Multiple APIs Return OC_STACK_OK if callback is absent
Add appropriate comments to public API
Change-Id: I08178de15e047234e470e157c5c2b07a9f956cba
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12415
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Greg Zaverucha <gregz@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit
64829896fb9d59e5caaea4a17a85cef2b16f65a7)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12537
Andrii Shtompel [Mon, 12 Sep 2016 16:25:29 +0000 (01:25 +0900)]
ACL fix for supporting few ACEs
Verified using 41 request
(read user input, convert it to OCpayload, parse it and save to db)
[Patch #5] Correctly clean-up single-linked list in 41 request
Change-Id: Id2da459f776ae756cff4408688143946c7085de9
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12041
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit
552951a50ee2264ebf6723c0c08cdd7c356fd14d)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11707
daeken.kwon [Sun, 18 Sep 2016 23:45:59 +0000 (08:45 +0900)]
To build static libarary from CSDK
Change-Id: I8e1e7a3ca76780cbedefdcfd2c84fbf316ed3058
Signed-off-by: daeken.kwon <daeken.kwon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11611
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hyuna Jo <hyuna0213.jo@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Dave Thaler [Mon, 19 Sep 2016 03:04:48 +0000 (20:04 -0700)]
IOT-1302 Thread-unsafe code in oicgroup.c
Remove potential thread safety bugs in oicgroup
Make RD mutex implementation work on Windows
Remove duplicate mutex implementations
Change-Id: Ie47b24619a10ab3d9cab2d421f3a7d8be7ac7b55
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11941
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Larry Sachs [Fri, 16 Sep 2016 17:22:28 +0000 (10:22 -0700)]
Throw OcException for invalid (null) parameters in Java Layer of android_api.
[IOT-1254] -- OcPlatform.notifyListOfObservers() ocObservationIdList is null.
[IOT-1255] -- OcResource.observe() observeType is null.
[IOT-1256] -- OcPlatform.bindResources() ocResourceHandleList is null.
[IOT-1257] -- OcPlatform.unbindResources() ocResourceHandleList is null.
Change-Id: Ib1c20dba6d0e85a05e8099ba1276d65334560c9d
Signed-off-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11877
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
Jihun Ha [Wed, 28 Sep 2016 12:51:12 +0000 (21:51 +0900)]
Fix a wrong variable name in enrolleesecurity.cpp
In cert provisioning callback, certResult variable should be used.
Change-Id: I0ab9b7d0c688c8c819240231529ba7975eec869f
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12419
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
Jongmin Choi [Wed, 28 Sep 2016 10:55:29 +0000 (19:55 +0900)]
Fix the bug in RemoveDeviceInfoFromLocal API
Fix the bug in RemoveDeviceInfoFromLocal API
in case of remove the single linked device
http://suprem.sec.samsung.net/gerrit/#/c/93085/
Change-Id: I88f025cb589a7893323197aa321d312d62f9be52
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12413
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Jongmin Choi [Fri, 23 Sep 2016 07:20:21 +0000 (16:20 +0900)]
Remove unnecessary resource properties for ACL
Observable and Explicit discoverable flags removed for ACL
Change-Id: Iec22c29acfdc1da087a3d999889da74a47779210
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12171
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit
e34781eab632c8af1f6c4c12a5e666cb4dfaaf75)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12409
Ziran Sun [Tue, 27 Sep 2016 10:16:36 +0000 (11:16 +0100)]
Update icv and dmv version to 1.1.0.
Bug: https://jira.iotivity.org/browse/IOT-1360
Change-Id: Icc3065f285481f443f3028db01d0ec3f67e47646
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12305
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Dwarkaprasad Dayama <dwarka.dayama@samsung.com>
abitha.s [Thu, 22 Sep 2016 09:32:57 +0000 (15:02 +0530)]
Added ExtraInfo representation to the Notification Service Message
1. Modified the required changes for ExtraInfo in C++ layer
2. Modified the JNI for extraInfo conversions
3. Added a feature to create NonSecure resources while building with Secured option
Patch 2 : updated the review comments
Change-Id: I54f13ec9de564b52dbe86f2b2731a32350175223
Signed-off-by: abitha.s <abitha.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12157
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
Parkhi [Tue, 27 Sep 2016 10:39:03 +0000 (19:39 +0900)]
Fix warning codes in Easysetup
Change-Id: I98657cf28e67db3956540a7a27eb4a7fc28d79ac
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12309
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
KIM JungYong [Tue, 27 Sep 2016 13:55:35 +0000 (22:55 +0900)]
Fix to apply Coding convention on services.
Change-Id: I9bdb0e8147bcbbad6a28a6635cd7c4c3c16d9359
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12345
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
jaesick.shin [Wed, 28 Sep 2016 06:50:37 +0000 (15:50 +0900)]
modify results of static analyzer.
this patch include
almost check the null about malloc case.
Change-Id: I873362768d6010b63039d7c6d3d9f10912344953
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12393
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
ch79.cho [Tue, 27 Sep 2016 10:41:10 +0000 (19:41 +0900)]
Update resource type and attribute
Implementation of resource has a gap with requirement.
Resource type and attribute are changed.
Change-Id: I80a22ab92fa5c0a8d01425e242569624ba35c105
Signed-off-by: ch79.cho <ch79.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12311
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
jaesick.shin [Tue, 27 Sep 2016 07:40:02 +0000 (16:40 +0900)]
fix bug with unittest about topic.
this patch include,
1. fix bug about topic API lock.
2. modify unittest for related topic.
second patch inlcude,
rename variables name.
Change-Id: I7f6768e367b016cc58e14c14e1e94c27e08289ad
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12273
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
KIM JungYong [Fri, 23 Sep 2016 06:56:56 +0000 (15:56 +0900)]
Fix bug for topic is changed to empty.
When the provider delete topic, consumer never callback changed when topic is empty.
In this patch, consumer will callback changed topic to upper layer
when topic is empty from not empty.
Change-Id: I41d0ad42f19298ce2773ab4c17d37cd7c1aa6b5e
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12167
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Chihyun Cho <ch79.cho@samsung.com>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
KIM JungYong [Tue, 27 Sep 2016 13:14:59 +0000 (22:14 +0900)]
Fix bug for invaild parse mediaContents.
When consumer service receive message and parse mediaContents,
sometime app crashed cause by mediaContents consist in the payload but this value is invalid.
In this patch, added logic for check to consist and correct mediaContents.
Change-Id: Iff2be18efce2697843ea5c73074ada72d2eb751b
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12339
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Hauke Mehrtens [Fri, 15 Jan 2016 23:03:07 +0000 (00:03 +0100)]
tinydtls: fix some compile warnings
This fixes multiple compiler warnings.
Change-Id: I403fb09b6b8ffc4bc1ca2cc03c90605d9005f8d5
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4823
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Soemin Tjong <stjong@microsoft.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Greg Zaverucha <gregz@microsoft.com>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Sandipan Patra [Mon, 26 Sep 2016 12:39:45 +0000 (18:09 +0530)]
Fixed JIRA tickets:
For [IOT-1314,1315,1316]
Fixed null pointer dereference.
Change-Id: I3d824b8c585b818a9c376b6e8466941c3044a1c8
Signed-off-by: Sandipan Patra <sandipan.p@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12211
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
Andrii Shtompel [Tue, 27 Sep 2016 12:51:13 +0000 (15:51 +0300)]
[IOT-1354] Multiple APIs crashed instead of returning OC_STACK_INVALID_PARAM while endpoint is kept NULL
Change-Id: Ie04acb860f5c06d298940db9944086eb929baf05
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12337
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit
6dfe30611bfe104aed8aeedcd0bf85b23d820263)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12385
ch79.cho [Wed, 28 Sep 2016 06:52:40 +0000 (15:52 +0900)]
Replace gets function
gets() function does not check for buffer length
and always results in a vulnerability.
Change-Id: I74abbe3f8a746513bb955455891ab1ca4746f1a7
Signed-off-by: ch79.cho <ch79.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12395
Reviewed-by: JungYong KIM <jyong2.kim@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
jihwan.seo [Tue, 20 Sep 2016 07:27:22 +0000 (16:27 +0900)]
[IOT-1332] add unregister network state changed callback in APIs
As apply multi network state changed callback,
Unregister API is added.
https://gerrit.iotivity.org/eventIndexgerrit/#/c/11505/
Change-Id: I417f6f7cfebd92c9dc120386d0146666df8ffa30
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11969
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Ziran Sun [Mon, 12 Sep 2016 15:30:24 +0000 (16:30 +0100)]
Remove OC_REST_CANCEL_OBSERVE from OCMethod.
OC_REST_CANCEL_OBSERVE was created for internal uses but
has not been used. Since it is defined as one of OCMethod,
Users attemp to call it in OCDoResrouce(...). OCDoResrouce(...)
is to discover or Perform requests on a specified resource and
OCCancel(...) should be used to cancel the operation supported in
OCDoResource(...).
Bug: https://jira.iotivity.org/browse/IOT-1240
Change-Id: Ie40d8961949f1fa3f0c2c04899c58d6ae62241af
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11703
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Abhishek Sharma [Tue, 27 Sep 2016 11:56:04 +0000 (17:26 +0530)]
RM fix for JIRA issue [1342]
https://jira.iotivity.org/browse/IOT-1342
Change-Id: I80a8d442f93ac0f197029f32bc0918b668c2d708
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12325
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Jaehong Jo [Tue, 20 Sep 2016 07:48:35 +0000 (16:48 +0900)]
[IOT-1335] Add check connectivityType when cancelObserve.
If adapter is IP and QoS is Low, delete observe list.
Change-Id: I232321d82ec2991da791587e0275c20fcc91c912
Signed-off-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11971
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Andrii Shtompel [Mon, 19 Sep 2016 16:12:44 +0000 (01:12 +0900)]
Close tls session with tcp session
[Patch #2] Move it before socket close
Change-Id: I5bede5ab75b4e67faff932e77c30565062916c95
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12039
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit
27cec1f345003807cf719fe69c46660b5363b527)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11951
Andrii Shtompel [Mon, 26 Sep 2016 13:23:57 +0000 (16:23 +0300)]
Print Acl Id & minor updates
Change-Id: Ib6b48be6e9f5da3dafb27632b2b93a986b6da2ab
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12323
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
George Nash [Mon, 26 Sep 2016 17:18:11 +0000 (10:18 -0700)]
[IOT-1331] Arduino with SECURED=1 prints build failure
Arduino does not support security at all. The crypto
stack is not avalible. If the SECURED=1 option is
provided the build will instantly fail.
Change-Id: I2fd72b5debf05d214b606a1ff95da1161b6da4a9
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12227
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
Habib Virji [Mon, 26 Sep 2016 22:26:15 +0000 (23:26 +0100)]
InProcServerWrapper null pointer dereference
clientResponse is redundant or null pointer dereference
https://jira.iotivity.org/browse/IOT-1311
Change-Id: Id1f0d7088443bc875c6a99a20a4e30cdcbc4b4a0
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12235
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Dmitriy Zhuravlev [Thu, 8 Sep 2016 09:22:27 +0000 (12:22 +0300)]
Exposing CASelectCipherSuite to OC layer
Select the cipher suite for TLS/DTLS handshake
Change-Id: Idb346fc2c5eb3bfa7f624562ef72a02c37db821b
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11567
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Randeep Singh [Thu, 8 Sep 2016 13:06:02 +0000 (18:36 +0530)]
Added CASelectCipherSuite for android
Change-Id: I073d1191e6a114c3c34f67f48d1ab7c7443bf1d6
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11605
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Ashwini Kumar [Mon, 26 Sep 2016 09:39:02 +0000 (15:09 +0530)]
svace issue fixes
Change-Id: I7832bab14a433e3a6b55c378ae0000b5e24882a5
Signed-off-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12205
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit
897dc94c292bb5b0433bbb10e8f47a1d88bd0059)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12319
Tested-by: Randeep Singh <randeep.s@samsung.com>
Andrii Shtompel [Mon, 26 Sep 2016 14:49:35 +0000 (17:49 +0300)]
Svace fix for cloud Client functionality
Change-Id: Ib2ae875106422654635ee02e7fa89e3cf37b57cd
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12223
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit
0ca71f3fcca638bdd199bfe7c856fd4da08e7822)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12321
Tested-by: Randeep Singh <randeep.s@samsung.com>
hyuna0213.jo [Mon, 19 Sep 2016 23:34:35 +0000 (08:34 +0900)]
add functions to test cloud resource-directory in simplebase
- find resource from resource-directory
- register observation
- unregister observation
Change-Id: I1cea9ef5f181cf3de3b9f5c438b28f74514e33d8
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11957
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Habib Virji [Mon, 26 Sep 2016 22:15:36 +0000 (23:15 +0100)]
Fix strcpy in occlientcoll
occlientcoll was using strcpy, changed it with OICStrcpy.
https://jira.iotivity.org/browse/IOT-1310
Change-Id: I51b6c46ea3095eea60c225953c38dfbe65985e7c
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12233
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Tested-by: Ziran Sun <ziran.sun@samsung.com>
KIM JungYong [Tue, 27 Sep 2016 06:37:44 +0000 (15:37 +0900)]
Add README file for RE Tizen Samples.
Change-Id: Iae22d5fdc35e6edf282419e4ef150eaf543e982a
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12267
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
ch79.cho [Tue, 27 Sep 2016 02:27:47 +0000 (11:27 +0900)]
Update API description
API description is updated including the usage of subControllability.
Change-Id: I141d47d2c655b29531b9251dbbf50ecdb8a1c1de
Signed-off-by: ch79.cho <ch79.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12251
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
jaesick.shin [Fri, 23 Sep 2016 05:01:35 +0000 (14:01 +0900)]
aSync change to sync about topic API.
This patch include,
1. NSAddTopics, NSDeleteTopics are changed to sync call.
2. when NSDeleteTopics function is called,
It notify consumer that topic is updated.
second patch include,
1. bug fix about double free.
2. bug fix about setTopics.
third patch inlcude,
rename Task Type, Function and struct about topic.
Change-Id: I657775489adc2d316544164ef81752f763143a40
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12163
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Veeraj Khokale [Tue, 27 Sep 2016 05:45:45 +0000 (11:15 +0530)]
Fix for Tizen BLE build
Changed CAWaitResult_t to OCWaitResult_t in tizen caleclient.c
to fix the build error.
Change-Id: I46881f5c0a496babae1bc5adcb05d630ac58024f
Signed-off-by: Veeraj Khokale <veeraj.sk@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12259
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Jaewook Jung [Mon, 26 Sep 2016 05:30:23 +0000 (14:30 +0900)]
modified SConscript for building arduino with tcp
Since arduino with WIFI shield does not support tcp,
build script should be closed expectedly.
Change-Id: Icad92654355153574ed5928922164366271946ec
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12193
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
sy01.youn [Tue, 27 Sep 2016 01:18:39 +0000 (10:18 +0900)]
EasySetup Script files are changed to make static library.
Also mistyping is fixed in easysetup sample app.
Change-Id: I339a34a9d8eef0c69af7d9a3ba2388db073935c5
Signed-off-by: sy01.youn <sy01.youn@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12247
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Ziran Sun [Tue, 30 Aug 2016 14:26:22 +0000 (15:26 +0100)]
Add generic APIs for set/get header option.
These APIs should be applicable for setting/getting
header option operations for version number and proxy-uri.
Bug: https://jira.iotivity.org/browse/IOT-1223
Change-Id: Ifd2d1b6ad30dff3a247c84b63d139c9552bfb32f
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11161
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Abhishek Sharma [Mon, 26 Sep 2016 09:56:54 +0000 (15:26 +0530)]
Enable Tizen build for proxy
Change-Id: Id5a8091ae5d1544581bb9991e18d20dd5b67e292
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12207
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
hyuna0213.jo [Thu, 22 Sep 2016 01:56:19 +0000 (10:56 +0900)]
Improve log message in tcpserver.
Added logging to check the remote device address for connection.
Change-Id: Ia4ed72ba227ba5a2e2f06f8120f144301291cfe9
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12117
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Ziran Sun [Wed, 21 Sep 2016 10:02:23 +0000 (11:02 +0100)]
Delete Client callback when receive observe cancel response.
Bug: https://jira.iotivity.org/browse/IOT-1317
Change-Id: I4e5ef2a1c848b963c036efe4ddf73dfd76b2b262
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12055
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Abhishek Sharma [Wed, 21 Sep 2016 13:14:46 +0000 (18:44 +0530)]
Add option to create proxy as secured resource
Modify CHPInitialize() api to allow secured
mode. Also minor code formating optimizations.
Change-Id: I4041c506d8ce41769b9c55d4850d551fae87ad2e
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12071
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
jaesick.shin [Fri, 23 Sep 2016 07:55:58 +0000 (16:55 +0900)]
Add condition about provider initialize.
This patch include,
It added the code to verify that the provider is already started.
Second patch include,
modify invalid return type.
Change-Id: Ib3038f8cc2c74ab465a6178eac56d1f8e508a238
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12173
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: JungYong KIM <jyong2.kim@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Parkhi [Mon, 26 Sep 2016 04:51:48 +0000 (13:51 +0900)]
Fix Jira issues (IOT-1338)
Change-Id: Id3949851748bbcf8a528b7e86a4b07a91fbcedab
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12189
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Parkhi [Mon, 26 Sep 2016 02:54:47 +0000 (11:54 +0900)]
Fix Jira issues(IOT-1268)
Change-Id: Ifaf1708cbcf2f0b3f66ecc10b8d2ee389ddb723e
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12187
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Jihun Ha [Wed, 21 Sep 2016 01:37:54 +0000 (10:37 +0900)]
Update a condition of security provisioning failures for timeout
A request of a kind of security provisioning like ownership transfer,
ACL provisioning, cert provisioning, is sent as a CON message which
has a retransmission. And if retransmission timeout happens, then
we can say the security provisioning is failed. Thus, when timeout error
code is arrived at its callback function, mediator has to inform an app of
its failure.
Change-Id: I2e89f27f01cc6b834f4f60d106ec834b4c0d4a51
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11991
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
Jongmin Choi [Mon, 26 Sep 2016 08:56:16 +0000 (17:56 +0900)]
[IOT-1329] Include OCResetDevice in header
Include OCResetDevice in ocprovisioningmanager.h
Change-Id: I0f55e2503b0dc5bd809b64edc4f812c1d646cb9a
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12203
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Philippe Coval [Wed, 21 Sep 2016 16:59:02 +0000 (18:59 +0200)]
tizen: Use 1/0 for booleans
To prevent ambuiguity of low/up/case.
Bug: https://jira.iotivity.org/browse/IOT-1295
Change-Id: Ic918e0c95f13462cab85ade3828e635f47ee7484
Origin: https://gerrit.iotivity.org/gerrit/#/c/12097/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12145
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Gregg Reynolds [Mon, 6 Jun 2016 07:52:32 +0000 (02:52 -0500)]
add darwin feature test for bits/atomic_base.h etc.
Change-Id: I2f0dc21a7f11f6f071f37f6dec78685ce89354ba
Signed-off-by: Gregg Reynolds <reynolds-gregg@norc.org>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8491
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Randeep Singh [Thu, 22 Sep 2016 05:32:02 +0000 (11:02 +0530)]
[IOT-1319] Resolved potential buffer overflow case
Change-Id: Ic5779a529085514a9269321c60770cd13c8fcd25
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12137
Reviewed-by: Greg Zaverucha <gregz@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Jaehong Jo [Fri, 23 Sep 2016 06:04:24 +0000 (15:04 +0900)]
Only multicast case, set to Low of QoS.
Application can set QoS in unicast case.
Change-Id: I14658d90bf36a76e6f9beccc470edb9f75d75859
Signed-off-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12165
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Jihun Ha [Thu, 22 Sep 2016 12:46:35 +0000 (21:46 +0900)]
fixed Cloud provisioning logic fault.
- The issued is when credId & CloudId is not valid,
Cloud provisioning is skipped.
associate with https://gerrit.iotivity.org/gerrit/#/c/11909/
Change-Id: Ida3045047da0fe3082119a703360160f2d43fc53
Signed-off-by: Parkhi <h_w.park@samsung.com>
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12155
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Senthil Kumar G S <senthil.gs@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
hyuna0213.jo [Tue, 20 Sep 2016 23:40:51 +0000 (08:40 +0900)]
Support CAGetNetworkInformation API for TCP
Support CAGetNetworkInformation API for TCP to get
tcp address and port information from CA.
Change-Id: I6da57d85267c26bf605c6e9f8679d263076e637a
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11999
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
jihwan.seo [Fri, 9 Sep 2016 06:15:28 +0000 (15:15 +0900)]
[IOT-1295] remove wrong step related Security in Tizen gbs build.
the stop related secure mode should not be trigerred by default.
Change-Id: I4cf684b4af392fdd5b428028ade1479066ae6809
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11623
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
jihwan.seo [Wed, 7 Sep 2016 11:40:29 +0000 (20:40 +0900)]
[IOT-1332] support multi network state changed callback in base layer.
Change-Id: I1027bb11d276d1daceafea1673ceaa5f2d9b4411
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11505
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Philippe Coval [Wed, 21 Sep 2016 09:10:16 +0000 (11:10 +0200)]
provisioning: Fix type mismatch for sessionObject.expiresin
Failure to build was observed on Tizen:Common (armv7l):
cloudAuth.cpp:127:59: error: cannot convert 'long int*' to 'int64_t* \
{aka long long int*}' for argument '3' to \
'bool OCRepPayloadGetPropInt(const OCRepPayload*, const char*, int64_t*)'
Change-Id: I3feaea196d91e22d29cc0a2b1d5fc859ecb6ea6c
Origin: https://gerrit.iotivity.org/gerrit/#/c/12049/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12049
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
(cherry picked from commit
cdca139c2403d88e3cb92af30f4cfe15b5e6b9fa)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12143
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Ashwini Kumar [Wed, 21 Sep 2016 05:33:14 +0000 (11:03 +0530)]
Solve build issue
https://gerrit.iotivity.org/gerrit/#/c/11331/
older g++ version support (4.6.4)
Change-Id: Icd8750bd622247f9c3086560350e0c0d46ca9f28
Signed-off-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12009
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Parkhi [Thu, 22 Sep 2016 07:58:36 +0000 (16:58 +0900)]
fixed android build fail with SECURED flag.
associated with https://gerrit.iotivity.org/gerrit/#/c/11331/25
Change-Id: I7b2aa38167d5573bd9b845c1d2e604c9ec23a3f4
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12139
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
KIM JungYong [Wed, 21 Sep 2016 04:35:14 +0000 (13:35 +0900)]
Add parsing logic for extraInfo in the NSMessage.
extraInfo formed OCRepPayload was added in the NSMessage structure.
So, related parsing logic is added in consumer service.
Change-Id: Id0c0038dd8082ca6edcc037847a984df8bdfca9d
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12005
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Parkhi [Thu, 22 Sep 2016 10:21:27 +0000 (19:21 +0900)]
Updated ESResult which supports more detail on Android layer.
- The patch is associated with "https://gerrit.iotivity.org/gerrit/#/c/11947/"
Change-Id: I9e20fbccef12678c6f70a27e167ac2d7fdff9b00
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12151
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Daniel Ferguson [Wed, 14 Sep 2016 22:13:06 +0000 (15:13 -0700)]
Enable unit tests on Windows
* Add OCPlatformTest.cpp back into build process. Disabled specific tests
that cause the delta in exception handling between Windows and Linux to
be a problem. Replaced use of NULL with nullptr
* Add OCRepresentationEncodingTest.cpp back into build process
only for cl.exe 14.0 (not 12.0)
* Add OCDevicePayloadCreate to octbstack_product.def
* Add OCByteStringCopy to octbstack_product.def
* Explanation:
On the Windows platform, certain exceptions are not being
caught by Gtests' EXPECT_ANY_THROW macro.
Specifically; on Windows, asynchronous structured exceptions
are not caught with C++'s try/catch exception handling. Unfortunately,
these tests raise asynchronous structured exceptions, and the result
is the unit tests crash instead of reporting a failure.
The two most common exception tests being disabled are:
1) Assigning a null pointer to a std::string
2) Indexing into an empty vector
For a specific example, where an asynchronous structured exception
is provoked, look at:
TEST(BindInterfaceToResourceTest, BindZeroResourceInterface)
inside of resource/unittests/OCPlatformTest.cpp
The tests could be refactored because both of
the operations causing the exceptions are not acceptable for the caller to
perform. Expecting anything afterward may be hazardous.
Furthermore, these tests just prove that the C++ documentation is
correct when it states that passing a null pointer to a std::string
constructor, or indexing into an empty vector is a bad idea.
"If s is a null pointer, if n == npos, or if the range specified by
[first,last) is not valid, it causes undefined behavior."
http://www.cplusplus.com/reference/string/string/string/#exceptions
"Portable programs should never call this function with an argument n
that is out of range, since this causes undefined behavior."
http://www.cplusplus.com/reference/vector/vector/operator[]/
Change-Id: If8dbdcb54d7a0fe22ca71fc8513eab413620beed
Signed-off-by: Daniel Ferguson <daniel.j.ferguson@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11783
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
jaesick.shin [Tue, 20 Sep 2016 09:02:04 +0000 (18:02 +0900)]
Add logic for extra Information.
This patch include,
1. Add extraInfo field in NSMessage.
2. Modify logic for related sendMessage.
second patch include,
modify setting Message payload.
third and fourth patch include,
add defence code for double free.
Change-Id: I2dcfaa9cf9bc0e42b1c0aaff83de99819433f01e
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11975
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
jaesick.shin [Thu, 22 Sep 2016 05:10:06 +0000 (14:10 +0900)]
Fix bug about NSProvider Config
the changes about wrong parameter input.
Change-Id: I25e4f864d5e5713c3fdd04aea56271ba14362f23
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12123
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
Randeep Singh [Thu, 22 Sep 2016 05:15:00 +0000 (10:45 +0530)]
[IOT-1309] Remove potential buffer overflow
Change-Id: I4804381daf85003929a2d8f96945b170083c2ab4
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12125
Reviewed-by: Greg Zaverucha <gregz@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Ashwini Kumar [Wed, 21 Sep 2016 06:15:19 +0000 (11:45 +0530)]
Modified c++ provisioning to support cert provisioning
Change-Id: I98b41b2b65d4f3ee52e3cabdbe3fab35789f555b
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Signed-off-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10999
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
ch79.cho [Wed, 21 Sep 2016 08:32:29 +0000 (17:32 +0900)]
Fix warning codes
2 warnings are fixed.
1. warning implicit declaration of function
1. warning ignoring return value of 'scanf'
Change-Id: Id7e5caa3902b9a5b4be04b383b4ef54a2b8a68df
Signed-off-by: ch79.cho <ch79.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12043
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
uzchoi [Wed, 21 Sep 2016 06:03:21 +0000 (15:03 +0900)]
Create build_linux_secure_with_tcp and cleanup build_android job
- build_linux_secure_with_tcp
flag: SECURED=1, WITH_TCP=1, WITH_CLOUD=1
- clean up build_android
place the android armeabi build job only
TRANSPORT=All is applied which will verify all transports.
This will not affect currently running Jenkins build trigger.
So related yaml file should be modified for this change effective
Change-Id: Id77f4fb23d45316b876356ba9b1e062c9f1e7f79
Reviewed-on: https://gerrit.iotivity.org/gerrit/12019
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Parkhi [Wed, 21 Sep 2016 04:27:50 +0000 (13:27 +0900)]
Update a condition to do ownership transfer in easy setup
In case that Only mediator's PDM db is deleted, ownership transfer SHOULD
be terminated.
Change-Id: I6513da5fb1bd56e7fb132da94fa6be40dbe2d7f6
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12003
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
jaesick.shin [Wed, 21 Sep 2016 05:55:53 +0000 (14:55 +0900)]
Fixed bug for conditional in API.
Fixed bug for invalid compare.
Change-Id: I3396a4884a8691edf08364ea7e65dfbcd9514c6e
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12013
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
jaesick.shin [Wed, 21 Sep 2016 06:38:21 +0000 (15:38 +0900)]
Add unittest for negative case.
Add unittest for negative case in provider side.
and remove printf, cout.
Change-Id: I6fd7119e4cade3da6d87e85f0c8e1957f3bf0ce4
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12025
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Parkhi [Tue, 20 Sep 2016 02:18:56 +0000 (11:18 +0900)]
Updated all of request using High QOS.
Change-Id: Icdb0805a29f6385900b22703cda2eb824330f0d6
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11963
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
js126.lee [Mon, 19 Sep 2016 12:00:03 +0000 (21:00 +0900)]
Modify SRPSaveTrustCertChain
When saved CertCahin as PEM format in SVR_DB file, null termination is required.
Change-Id: Icdb15c447f91c42b98a665ed82c169052245e61e
Signed-off-by: js126.lee <js126.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11939
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit
677e3b7e0e37f852be8a5c4e62d22b925f991ce1)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12015
Tested-by: Randeep Singh <randeep.s@samsung.com>
Parkhi [Tue, 20 Sep 2016 06:37:48 +0000 (15:37 +0900)]
Updated doxygen comment due to ESResult is changed
Change-Id: I1dbbb6fe36d05797a27cd80c4e21331390a7179b
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11967
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Ziran Sun [Tue, 13 Sep 2016 10:41:06 +0000 (11:41 +0100)]
Allow multiple calls on OCResource::observe().
Remove check against m_observeHandle in OCResource::observe().
This will allow mutliple calls on observe with different query
parameters.
Bug: https://jira.iotivity.org/browse/IOT-1115
Change-Id: I1bae9e8db8999bf6e805eec75ebcbe9f4af8b3c7
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11735
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Todd Malsbary <todd.malsbary@intel.com>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Abhishek Sharma [Mon, 19 Sep 2016 11:46:34 +0000 (17:16 +0530)]
Remove WITH_CHPROXY flag for build cleanup
To minimize feature specific build flags,
removed proxy flag from base layer.
Change-Id: Ic3498e181209b31aa7d531f1eb6f86a2fc92ba54
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11937
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Sudarsana Nagineni [Tue, 30 Aug 2016 11:01:11 +0000 (14:01 +0300)]
Fix memory leak in OCDoResource
OCDoResource was leaking the resourceUri when the presence enabled,
so this patch fixes the issue by freeing the resourceUri before
re-assigning the presence uri.
Change-Id: I2fc2a6c42e5079e67cc72a8be22803bf7157ad36
Signed-off-by: Sudarsana Nagineni <sudarsana.nagineni@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11145
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Abhishek Sharma [Sat, 17 Sep 2016 07:27:28 +0000 (12:57 +0530)]
Check parsing response from cjson
Prevent crash if invalid json response received from server.
Change-Id: I339796be64ca4ec46d2e68a02b7f128a8c2fcdab
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11905
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
projects / platform / upstream / iotivity.git / log