noahfalk [Sat, 25 Mar 2017 05:43:47 +0000 (22:43 -0700)]
Tiered Compilation step 1
Tiered compilation is a new feature we are experimenting with that aims to improve startup times. Initially we jit methods non-optimized, then switch to an optimized version once the method has been called a number of times. More details about the current feature operation are in the comments of TieredCompilation.cpp.
This is only the first step in a longer process building the feature. The primary goal for now is to avoid regressing any runtime behavior in the shipping configuration in which the complus variable is OFF, while putting enough code in place that we can measure performance in the daily builds and make incremental progress visible to collaborators and reviewers. The design of the TieredCompilationManager is likely to change substantively, and the call counter may also change.
Commit migrated from https://github.com/dotnet/coreclr/commit/
850164ee70077e0970d7ab4e4bf2ca51809b92e8
Jan Kotas [Wed, 29 Mar 2017 01:56:43 +0000 (18:56 -0700)]
Delete moved file
Commit migrated from https://github.com/dotnet/coreclr/commit/
e3eecaa56ec08d47941bc7191656a7559ac8b3c0
Jan Kotas [Wed, 29 Mar 2017 01:45:38 +0000 (18:45 -0700)]
Merge pull request dotnet/corertdotnet/coreclr#3134 from dotnet/nmirror
Merge nmirror to master
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
18e9e27b945a8a1ddf7b3c8aff5892726b6a248e
Jonghyun Park [Wed, 29 Mar 2017 03:39:37 +0000 (12:39 +0900)]
[x86/Linux] Fix signature mismatch inside InstantiatingStub (dotnet/coreclr#10538)
Commit migrated from https://github.com/dotnet/coreclr/commit/
a8459520aaf5663e7b97c1b4b42f16859d5e129d
Rama krishnan Raghupathy [Wed, 29 Mar 2017 02:37:43 +0000 (19:37 -0700)]
Merge pull request dotnet/coreclr#10537 from ramarag/cleanup_longfile
Removing Unnecessary CloseBuffer calls
Commit migrated from https://github.com/dotnet/coreclr/commit/
a2907e7e0ff8c064b96fc33727f83c31f61d32c4
Rama Krishnan Raghupathy [Wed, 29 Mar 2017 01:09:12 +0000 (18:09 -0700)]
Removing Unnecessary CloseBuffer calls
Commit migrated from https://github.com/dotnet/coreclr/commit/
c082bf271567b3dc44d80b37b2b5c8eed5b95f64
Brian Sullivan [Wed, 29 Mar 2017 00:37:39 +0000 (17:37 -0700)]
Merge pull request dotnet/coreclr#10534 from sdmaclea/PR-ARM64-GC-ASSIGN-BYREF
[Arm64] Revise CORINFO_HELP_ASSIGN_BYREF code
Commit migrated from https://github.com/dotnet/coreclr/commit/
bff1ee64d07bf72beed3c6474624e9cd8f49ac78
Zverev Eugene [Tue, 28 Mar 2017 23:50:14 +0000 (02:50 +0300)]
TimeSpan.FromMilliseconds(TimeSpan.MaxValue.TotalMilliseconds) exception fix (dotnet/coreclr#10352)
The problem is discussed here: https://connect.microsoft.com/VisualStudio/feedback/details/542235/timespan-structure-incorrectly-handles-values-close-to-min-and-max-value
The existing overflow checks are ignorant and superfluous.
Commit migrated from https://github.com/dotnet/coreclr/commit/
7951bc9accbbf9552d9b5c8105df8f5a32d6c3ab
Jonghyun Park [Tue, 28 Mar 2017 23:43:34 +0000 (08:43 +0900)]
[x86/Linux] Align frame before SetObjectAppDomain call (dotnet/coreclr#10519)
Commit migrated from https://github.com/dotnet/coreclr/commit/
e05aa41840d1551d4048fff8192a4598cabb0573
Sergey Andreenko [Tue, 28 Mar 2017 23:25:58 +0000 (16:25 -0700)]
Ctor Jit-EE interface change (dotnet/coreclr#10512)
Change JIT-EE interface for getReadyToRunDelegateCtorHelper.
Update GUID.
Commit migrated from https://github.com/dotnet/coreclr/commit/
9afde0a2de16b0df63f77847c29e88613cb96ff4
[Arm64] Revise CORINFO_HELP_ASSIGN_BYREF code
Reverts dotnet/coreclr#9655 which didn't work correctly
Revised code to match amd64
Fixes many failing GCStress tests
Commit migrated from https://github.com/dotnet/coreclr/commit/
915df991419a5da16bc6fbb81d3218eac96d451c
Sergey Andreenko [Tue, 28 Mar 2017 21:39:44 +0000 (14:39 -0700)]
Merge pull request dotnet/coreclr#10503 from sandreenko/fgOptimizeDelegateConstructor-cleanup
small fgOptimizeDelegateConstructor code refactoring
Commit migrated from https://github.com/dotnet/coreclr/commit/
1b12399658ad04ced9a0478308094caa57e475e2
Atsushi Kanamori [Tue, 28 Mar 2017 21:03:21 +0000 (14:03 -0700)]
Get VS to quit bugging me about replacing SR.cs already. (dotnet/coreclr#10530)
Fix https://github.com/dotnet/coreclr/issues/10358
Commit migrated from https://github.com/dotnet/coreclr/commit/
9e9eb4548e055f2aa12a5300c0ce207d524ee9ca
Swaroop Sridhar [Thu, 23 Mar 2017 01:09:05 +0000 (18:09 -0700)]
Add support for CoreCLR testing via ILLINK on Linux
Made changes to the test infrastructure to
1) Generate <test>.sh with commands to invoke ILLINK and run the output
2) Add runtest.sh --link=<path-to-illink> to invoke the ILLINK testing
Commit migrated from https://github.com/dotnet/coreclr/commit/
5f05a462321923ee6d9975cc3f88a233b3143332
303248153 [Tue, 28 Mar 2017 18:12:18 +0000 (02:12 +0800)]
Fix comment on mark::recover_plug_info (dotnet/coreclr#10516)
Commit migrated from https://github.com/dotnet/coreclr/commit/
c9a0d6d510e92dc4ebd4b78f766c706abce0a9af
Eric Erhardt [Tue, 28 Mar 2017 17:56:04 +0000 (12:56 -0500)]
Merge pull request dotnet/coreclr#10507 from eerhardt/TZBinarySearch
Binary Search in TimeZoneInfo.GetAdjustmentRuleForTime
Commit migrated from https://github.com/dotnet/coreclr/commit/
1e63a3efa9135c713c8fd5ae7e73dfca0ed6256e
Sean Gillespie [Tue, 28 Mar 2017 16:59:04 +0000 (09:59 -0700)]
[Local GC] Use standard C++ types (bool) and consistent types (void*) on the interface (dotnet/coreclr#10463)
* [Local GC] BOOL -> bool on IGCHeap
* [Local GC] size_t -> void* on IGCHeap
* [Local GC] Silence warnings by being explicit about BOOl -> bool conversions
* Address code review feedback: FinalizeAppDomain BOOL -> bool
* Fix warnings
* Address code review feedback:
1) Fix a missed default parameter (FALSE) on a parameter of type bool,
2) Fix invocations of the diagnostic callbacks to use boolean literals
instead of TRUE and FALSE,
3) Fix various invocations of GC interface methods in the VM to use
boolean literals instead of TRUE and FALSE
* Address code review feedback: fix inconsistency
Commit migrated from https://github.com/dotnet/coreclr/commit/
7e4afb4fbf900b789f53ccb816c6ddba7807de68
Hanjoung Lee [Tue, 28 Mar 2017 15:53:08 +0000 (00:53 +0900)]
Fix usage text of runtest.sh (dotnet/coreclr#10518)
Commit migrated from https://github.com/dotnet/coreclr/commit/
e23bfb25d4fde28d2f1648ae381f5e44538b1827
dotnet bot [Tue, 28 Mar 2017 14:47:07 +0000 (07:47 -0700)]
Update CoreClr to beta-25128-03 (dotnet/coreclr#10517)
Commit migrated from https://github.com/dotnet/coreclr/commit/
67938086beb9b9e6ef4b58e1f6e8543c0f5caba0
Eric Erhardt [Mon, 27 Mar 2017 17:50:36 +0000 (12:50 -0500)]
Binary Search in TimeZoneInfo.GetAdjustmentRuleForTime
Since Unix uses IANA tzdata files, there can be hundreds of adjustment rules for each time zone. To make the search for a given rule faster, use a binary search since the rules are guaranteed to be in chronological order. See ValidateTimeZoneInfo.
Fix dotnet/coreclr#5716
Commit migrated from https://github.com/dotnet/coreclr/commit/
8db6c57bc9768b0387cb045b19afee3c721ea348
Koundinya Veluri [Tue, 28 Mar 2017 05:38:53 +0000 (22:38 -0700)]
Don't ignore exceptions thrown from handlers of some events (dotnet/coreclr#10502)
Fixes dotnet/corefxdotnet/coreclr#14747:
- Events include: AssemblyLoadContext.Unloading, AppDomain.ProcessExit
- Made the same change for AppDomain.DomainUnload for consistency, but it's not raised
Commit migrated from https://github.com/dotnet/coreclr/commit/
54b2c88f5a8c4623a4a465218a9cef94b92642bf
Olof Olsson [Tue, 28 Mar 2017 03:32:35 +0000 (05:32 +0200)]
Fix link for up-for-grabs issues (dotnet/coreclr#10488)
* Fix link for up-for-grabs issues
Commit migrated from https://github.com/dotnet/coreclr/commit/
440a2871f11d75defe58edd1bf8b535edfd17b42
Alex Perovich [Mon, 27 Mar 2017 22:44:34 +0000 (15:44 -0700)]
Move deleted files and remove m_ prefix in shared file
Commit migrated from https://github.com/dotnet/coreclr/commit/
b15749642d928dad5652487a759bf0db4d494502
Alex Perovich [Mon, 27 Mar 2017 18:12:31 +0000 (11:12 -0700)]
Add DateTimeFormat and Parse to shared and remove moved file
Commit migrated from https://github.com/dotnet/coreclr/commit/
6c68f33332e090d0b8cec12aeede82d6c17b1e2a
dotnet bot [Tue, 28 Mar 2017 00:59:59 +0000 (17:59 -0700)]
Update CoreClr, CoreFx to beta-25127-03, beta-25124-07, respectively (dotnet/coreclr#10468)
Commit migrated from https://github.com/dotnet/coreclr/commit/
810f9398337485b30ffb447ccaab5d4c85cadb3a
Dan Moseley [Tue, 28 Mar 2017 00:58:14 +0000 (17:58 -0700)]
Some missing stragglers (dotnet/coreclr#10509)
Commit migrated from https://github.com/dotnet/coreclr/commit/
1490075c8887ce277bb2ae2f2a77ad7feb7cc125
Bruce Forstall [Tue, 28 Mar 2017 00:05:45 +0000 (17:05 -0700)]
Implement TLS field handles for RyuJIT/x86 (dotnet/coreclr#10510)
Implement TLS field handles for RyuJIT/x86
This isn't used by .NET Core, but helps us run desktop testing.
Commit migrated from https://github.com/dotnet/coreclr/commit/
5061b6c0c261ca475187375725f4a324c7f8b20c
Sergey Andreenko [Mon, 27 Mar 2017 19:46:59 +0000 (12:46 -0700)]
small changes in fgOptimizeDelegateConstructor
Delete unnecessary condition.
Use default methods to work with lists.
ArgList construction reordering.
Commit migrated from https://github.com/dotnet/coreclr/commit/
1502744c6915bf4b53e64fe766f7136a2edd0fd3
Koundinya Veluri [Mon, 27 Mar 2017 18:10:07 +0000 (11:10 -0700)]
Add heuristic to trigger GC to finalize dead threads and clean up han… (dotnet/coreclr#10413)
Add heuristic to trigger GC to finalize dead threads and clean up handles and memory
A thread that is started allocates some handles in Thread::AllocHandles(). After it terminates, the managed thread object needs to be collected by a GC for the handles to be released. Some applications that are mostly idle but have a timer ticking periodically will cause a thread pool thread to be created on each tick, since the thread pool preserves threads for a maximum of 20 seconds currently. Over time the number of handles accumulates to a high value. Thread creation adds some memory pressure, but that does not force a GC until a sufficiently large handle count, and for some mostly idle apps, that can be very long. The same issue arises with directly starting threads as well.
Fixes dotnet/coreclr#6602:
- Track a dead thread count separately from the current dead thread count. This is the count that will contribute to triggering a GC, once it reaches a threshold. The count is tracked separately so that it may be reset to zero when a max-generation GC occurs, preventing dead threads that survive a GC due to references from contributing to triggering a GC again in this fashion.
- If the count exceeds a threshold, enumerate dead threads to see which GC generation the corresponding managed thread objects are in. If the duration of time since the last GC of the desired generation also exceeds a threshold, trigger a preferably non-blocking GC on the finalizer thread.
- Removed a couple of handles and some code paths specific to user-requested thread suspension, which is not supported on CoreCLR
Commit migrated from https://github.com/dotnet/coreclr/commit/
2401b6ed08252d48831bfd804c3533cd0142c76c
Atsushi Kanamori [Mon, 27 Mar 2017 18:09:21 +0000 (11:09 -0700)]
Move Pointer.cs to the shared partition. (dotnet/coreclr#10499)
* Move Pointer.cs to the shared partition.
(The two internal helpers are not yet used
on CoreRT but that's only because CoreRT
doesn't yet implement Pointer support
for Reflection invoke. Exposing them
unconditionally now to save us the trouble
of removing the #ifdef's later.)
Commit migrated from https://github.com/dotnet/coreclr/commit/
47d333c856e567884594e1efd3497a254b6a04fb
Ben Monroe [Mon, 27 Mar 2017 17:04:32 +0000 (02:04 +0900)]
Path may contain spaces. Wrap in quotes. (dotnet/coreclr#10493)
Commit migrated from https://github.com/dotnet/coreclr/commit/
7ef462c87850f85ccf41daf54e970161737a65b3
Joseph Tremoulet [Mon, 27 Mar 2017 15:45:18 +0000 (11:45 -0400)]
Merge pull request dotnet/coreclr#10484 from mikedn/map-vn-assert
Correctly update bitvector in optAddVnAssertionMapping
Commit migrated from https://github.com/dotnet/coreclr/commit/
61830e9d70423d0d48bf1d2912fdb921d618e60f
Stephen Toub [Sun, 26 Mar 2017 21:04:40 +0000 (17:04 -0400)]
Merge pull request dotnet/coreclr#10489 from stephentoub/capturethrow
Add static ExceptionDispatchInfo.Throw method
Commit migrated from https://github.com/dotnet/coreclr/commit/
48e244855c98c6f280c986d0981238f403a49ff3
Stephen Toub [Sun, 26 Mar 2017 18:26:34 +0000 (14:26 -0400)]
Add static ExceptionDispatchInfo.Throw method
Commit migrated from https://github.com/dotnet/coreclr/commit/
49fba828bdc1cfc437e1adfbdaf0e0b498c28872
Aditya Mandaleeka [Sun, 26 Mar 2017 14:59:49 +0000 (07:59 -0700)]
Change typedef for BOOL in gcenv.base.h to int. (dotnet/coreclr#10486)
Commit migrated from https://github.com/dotnet/coreclr/commit/
840554e77f01a327e0c5df59d229149fd50b5c2d
Cyd Haselton [Sun, 26 Mar 2017 14:57:46 +0000 (09:57 -0500)]
Update for Android cross build script (dotnet/coreclr#10483)
Updated URLs for libandroid-support and libandroid-support-dev downloads.
Added URLs and folders for libunwind and libunwind-dev
Removed libunwind build
Commit migrated from https://github.com/dotnet/coreclr/commit/
2d30a07e73aebc656d851391a8619c70c184b7dd
Mandar Sahasrabuddhe [Sun, 26 Mar 2017 02:07:42 +0000 (07:37 +0530)]
CoreFx 14486 Update API summary. (dotnet/coreclr#10485)
Commit migrated from https://github.com/dotnet/coreclr/commit/
030fa861f611829f52c27c7c24b1aa046b0daebf
Mike Danes [Sat, 25 Mar 2017 07:45:15 +0000 (09:45 +0200)]
Correctly update bitvector in optAddVnAssertionMapping
When short bitvectors are used only the first assertion was stored in the map stored bitvector, all subsequent assertions were stored into copies of that bitvector.
Commit migrated from https://github.com/dotnet/coreclr/commit/
fb604c571325fb1a2d4e2b0d5f98dce61f1f0475
Tarek Mahmoud Sayed [Sat, 25 Mar 2017 17:41:39 +0000 (10:41 -0700)]
Enable global invariant on OSX (dotnet/coreclr#10470)
* Enable Globalization Invariant on OSX
* Fix typo
* Fix small typo
* Remove static link to ICU lib
* Addressing the feedback
Commit migrated from https://github.com/dotnet/coreclr/commit/
094f808f2b4587c4409d5d7ac5ed5b992d41864e
Ofer Zelig [Sat, 25 Mar 2017 15:31:45 +0000 (02:31 +1100)]
Typo correction (dotnet/coreclr#10482)
Commit migrated from https://github.com/dotnet/coreclr/commit/
ab849639db83ee65e51838ef147cee8d21b813c7
Jan Kotas [Sat, 25 Mar 2017 15:30:40 +0000 (08:30 -0700)]
Delete pointless <internalonly/> comments (dotnet/coreclr#10479)
Commit migrated from https://github.com/dotnet/coreclr/commit/
d4a6cf7bc9d1b5ccbf671f1c8fae1b4f83027cbd
Mandar Sahasrabuddhe [Sat, 25 Mar 2017 15:04:23 +0000 (20:34 +0530)]
Issue dotnet/coreclr#7061 Remove private _Prop from StreamReader, StreamWriter (dotnet/coreclr#10480)
Commit migrated from https://github.com/dotnet/coreclr/commit/
d9ec6e2cf0c921da14e90c4a07afc72239db1969
mikedn [Sat, 25 Mar 2017 14:45:10 +0000 (16:45 +0200)]
Some BitVecOps improvements (dotnet/coreclr#10437)
* Avoid virtual calls when allocating bitvectors
* Use specialized BitVecOps when possible
* Avoid unnecessary bitvector copying
* Cleanup CSE_DataFlow
Commit migrated from https://github.com/dotnet/coreclr/commit/
6d5ce09e13a3ff43d592cc67c04e026a12cce008
Jan Kotas [Sat, 25 Mar 2017 07:42:49 +0000 (00:42 -0700)]
Add Interlocked.MemoryBarrierProcessWide (dotnet/coreclr#10476)
Contributes to dotnet/coreclr#16799
Commit migrated from https://github.com/dotnet/coreclr/commit/
76b7d89f6e32ff51ae4809827163864c40a6a76f
Ahson Ahmed Khan [Sat, 25 Mar 2017 05:50:14 +0000 (22:50 -0700)]
Remove return statement and throwing directly for obselete methods. (dotnet/coreclr#10477)
Commit migrated from https://github.com/dotnet/coreclr/commit/
082fd6e07823b7418820708641b1640376e7bfc6
Brian Sullivan [Sat, 25 Mar 2017 04:45:50 +0000 (21:45 -0700)]
Merge pull request dotnet/coreclr#10469 from briansull/ibc-dump
Change the Jit Disasm message when we have profile data
Commit migrated from https://github.com/dotnet/coreclr/commit/
41ac197533a80943a313b15660ab311d36a72e40
Brian Sullivan [Sat, 25 Mar 2017 04:44:51 +0000 (21:44 -0700)]
Merge pull request dotnet/coreclr#10466 from briansull/stress-fix
Fix for JitStress test failures
Commit migrated from https://github.com/dotnet/coreclr/commit/
f9772e89c3126185b8b319954de9dcc93256fab1
Alex Perovich [Sat, 25 Mar 2017 04:10:49 +0000 (23:10 -0500)]
Move DateTime to shared partition (dotnet/coreclr#10460)
* Move DateTime to shared partition
Depends on dotnet/corefxdotnet/coreclr#17484
* Use CoreCLR specific impl of UtcNow on windows
* Use the internal call on unix as well
* Port good corert changes
Commit migrated from https://github.com/dotnet/coreclr/commit/
92b6ab81670b3e284a58dd282098ce782aed7617
Alex Perovich [Sat, 25 Mar 2017 03:13:09 +0000 (22:13 -0500)]
Cleanup unnecessary import (dotnet/coreclr#10472)
Commit migrated from https://github.com/dotnet/coreclr/commit/
2a5355996742034c88a4c5da592e56627d753b40
Dan Moseley [Sat, 25 Mar 2017 03:02:35 +0000 (20:02 -0700)]
Rename resource strings to match resx (dotnet/coreclr#10475)
Commit migrated from https://github.com/dotnet/coreclr/commit/
67ab2b3b406731712c80d37b6b23f0445bf96632
Jan Kotas [Sat, 25 Mar 2017 02:31:22 +0000 (19:31 -0700)]
Fixed m_ prefixes in a few files from shared partition (dotnet/coreclr#10473)
Commit migrated from https://github.com/dotnet/coreclr/commit/
9851f95cd3d4cefe824b8ad90c61f05ff2fddbf1
Brian Sullivan [Fri, 24 Mar 2017 23:29:27 +0000 (16:29 -0700)]
Change the Jit Disasm message when we have profile date to include
information about the edge weights and the value of fgCalledCount.
Example:
; with IBC profile data, edge weights are valid, and fgCalledCount is 145
Commit migrated from https://github.com/dotnet/coreclr/commit/
99e2889af4e7ff9bba4fb8cd920a5bcba9407370
Mandar Sahasrabuddhe [Sat, 25 Mar 2017 01:21:56 +0000 (06:51 +0530)]
CoreFx 14486 Remove argument validation in DangerousCreate (dotnet/coreclr#10462)
Commit migrated from https://github.com/dotnet/coreclr/commit/
7e5aef990eb4c8d7b34fc5f8a9a1fd5ed326410d
Brian Sullivan [Sat, 25 Mar 2017 00:51:47 +0000 (17:51 -0700)]
CR feedback
Removed assert about BB_NONE
Commit migrated from https://github.com/dotnet/coreclr/commit/
794c465391dfea71d493889ccd0c0123179720d1
Dan Moseley [Sat, 25 Mar 2017 00:42:44 +0000 (17:42 -0700)]
Remove dead strings (dotnet/coreclr#10445)
Removed 436 dead strings from .resx, kept 1034
Commit migrated from https://github.com/dotnet/coreclr/commit/
9f1f3d52a9c25e8dab75516a913ca00ea2ba2332
Alex Perovich [Sat, 25 Mar 2017 00:18:37 +0000 (19:18 -0500)]
Sort entries in shared project (dotnet/coreclr#10465)
Commit migrated from https://github.com/dotnet/coreclr/commit/
15d79636cc00503c4ca66e5f3921153ed12789e9
Brian Sullivan [Fri, 24 Mar 2017 22:42:04 +0000 (15:42 -0700)]
Fix for JitStress test failures
Commit migrated from https://github.com/dotnet/coreclr/commit/
0ef7c0bdfaad3c5e46e47922341b390a52b8dc79
Jan Kotas [Fri, 24 Mar 2017 21:59:25 +0000 (14:59 -0700)]
Merge pull request dotnet/coreclr#10459 from dotnet/mirror-merge-9061692
Mirror changes from dotnet/corert
Commit migrated from https://github.com/dotnet/coreclr/commit/
1b74dc44b28c8afa2e5b79051891b30708da9010
Jan Kotas [Fri, 24 Mar 2017 20:16:39 +0000 (13:16 -0700)]
Delete moved file
Commit migrated from https://github.com/dotnet/coreclr/commit/
40c4c3c866fd08842710f38ddc3998e8d214aa1c
Alex Perovich [Fri, 24 Mar 2017 18:40:21 +0000 (11:40 -0700)]
Use Array.Copy with index and remove coreclr specific function
Commit migrated from https://github.com/dotnet/coreclr/commit/
6e9f1b4a2b98a6a268a69816d80f80063686b7b2
Atsushi Kanamori [Thu, 23 Mar 2017 22:34:07 +0000 (15:34 -0700)]
NS2.0 Complete DBNull's surface area. (dotnet/coreclr#3085)
* Copy over CoreCLRs' DBNull.cs
* Make it presentable, then move it into the shared partition.
Commit migrated from https://github.com/dotnet/coreclr/commit/
a4cffe635dad862249899f0a181a72b791c6fafd
dotnet bot [Fri, 24 Mar 2017 17:39:37 +0000 (10:39 -0700)]
Update CoreClr to beta-25123-08 (dotnet/coreclr#10435)
Commit migrated from https://github.com/dotnet/coreclr/commit/
249902311a4f15712cb8e2553920948eaa21e87a
Joseph Tremoulet [Fri, 24 Mar 2017 16:55:01 +0000 (12:55 -0400)]
Merge pull request dotnet/coreclr#10149 from JosephTremoulet/DestSingleField
Scalarize single-field-to-lclVar block copy
Commit migrated from https://github.com/dotnet/coreclr/commit/
4388703f3e25f9290d37da9d4d1de844a3a6154a
Bruce Forstall [Fri, 24 Mar 2017 15:57:23 +0000 (08:57 -0700)]
Merge pull request dotnet/coreclr#10451 from ionuttamas/patch-1
Update ryujit-overview.md
Commit migrated from https://github.com/dotnet/coreclr/commit/
d0b09418c5033e1d9f646460c59f38e467649d36
Igor Kulaychuk [Fri, 24 Mar 2017 15:52:47 +0000 (18:52 +0300)]
[Linux][GDB-JIT] Add lexical scopes info for local variables (dotnet/coreclr#10307)
* Fix memory leak when getting local variable names
* Pass locals from SymbolReader using new LocalVarInfo struct
* Map IL to native addresses for variable scopes
* Dump variables with scopes
* Add scope info to VarDebugInfo
* Remove unnecessary usage of lines info in BuildDebugInfo
* Use holders for scopes and local var names
* Move array of FunctionMember from global scope to local scope
* Move SymbolNames from global scope to local scope
Commit migrated from https://github.com/dotnet/coreclr/commit/
a50348830471e9d821da525ed862e72e061b0766
Ilya [Fri, 24 Mar 2017 15:48:02 +0000 (18:48 +0300)]
Copy-paste errors found by PVS-Studio. (dotnet/coreclr#10450)
I used PVS-Studio static analyzer to check this project. I would like to suggest a variant of the way to fix the copy-paste errors, detected with the help of V778 diagnostic. Description of the diagnostic: https://www.viva64.com/en/w/V778/
Commit migrated from https://github.com/dotnet/coreclr/commit/
3c61ffd676603bb14d4e815e1e249f816d4cbc74
Ionut Tamas [Fri, 24 Mar 2017 11:58:53 +0000 (13:58 +0200)]
Update ryujit-overview.md
Commit migrated from https://github.com/dotnet/coreclr/commit/
02ae52f495edae9ec40fdee088524a922197ce72
Hyeongseok Oh [Fri, 24 Mar 2017 07:16:47 +0000 (16:16 +0900)]
Update ci-trigger-phrases.md (dotnet/coreclr#10444)
- Add Linux arm/x86 CI trigger phrases
- Add Ubuntu16.10 x64 pri0 trigger phrase
- Remove Ubuntu15.10 x64 pri0 trigger phrase
Commit migrated from https://github.com/dotnet/coreclr/commit/
e1b0f8a1d353d41de515c4cc219339b220714777
Dan Moseley [Fri, 24 Mar 2017 06:47:38 +0000 (23:47 -0700)]
Add PNSE messages (dotnet/coreclr#10440)
* PNSE messages
* threading
* marshal
* interop svc
* More
* more
* Remove env var special casing for UWP
* Pending question
* remove pinvoke
Commit migrated from https://github.com/dotnet/coreclr/commit/
ad746a9b698c3cd5f603db8974a196dfcbc10267
Jan Kotas [Fri, 24 Mar 2017 04:02:52 +0000 (21:02 -0700)]
Merge pull request dotnet/coreclr#10426 from BruceForstall/FixIlasmRoundtrip
Enable FEATURE_METADATA_EMIT_ALL for non-crossgen compiles
Commit migrated from https://github.com/dotnet/coreclr/commit/
14b09e8777615f57fc1e78c0c7775962ee5b44a0
Sean Gillespie [Fri, 24 Mar 2017 01:40:56 +0000 (18:40 -0700)]
[Local GC] Redirect fatal errors to the EE (dotnet/coreclr#10436)
* [Local GC] Redirect fatal errors to the EE
* Address code review feedback: don't fetch the IP when reporting a fatal error
Commit migrated from https://github.com/dotnet/coreclr/commit/
b04644c55ae003bd1c6c8fefe33d5dfe6ef240f0
Maoni Stephens [Fri, 24 Mar 2017 01:24:55 +0000 (18:24 -0700)]
GetContainingObject is inconsistent with the lowest address it chooses. (dotnet/coreclr#10438)
For profiling purpose it only cares about condemned ranges; for byref
validation it cares about any object on the heap.
Commit migrated from https://github.com/dotnet/coreclr/commit/
c5bfdd98204d7cb265f633534d593ca9c008ca6b
Brian Sullivan [Fri, 24 Mar 2017 01:24:40 +0000 (18:24 -0700)]
Merge pull request dotnet/coreclr#10400 from briansull/ibc-counts
Change setBBProfileWeight so that we no longer multiply a profile counts by 100
Commit migrated from https://github.com/dotnet/coreclr/commit/
799473b93db0405bee78d5bbe2aadb23313efb01
Jan Kotas [Fri, 24 Mar 2017 00:39:59 +0000 (17:39 -0700)]
Merge pull request dotnet/coreclr#10434 from dotnet/mirror-merge-9060302
Mirror changes from dotnet/corert
Commit migrated from https://github.com/dotnet/coreclr/commit/
e6c2d88ef3ec9811f032087e710c3a7ef6181ffa
Alex Perovich [Thu, 23 Mar 2017 23:33:46 +0000 (18:33 -0500)]
Move StringBuilder to shared partition (dotnet/coreclr#10357)
* Move StringBuilder to shared partition
* Fix PR comments
* s/CoreClr/CoreCLR
* Remove unused ThreadSafeCopy overload
* Actually rename the file
Commit migrated from https://github.com/dotnet/coreclr/commit/
1e2d938881cd9193614c245760ab49efaecb100c
Jan Kotas [Thu, 23 Mar 2017 18:55:26 +0000 (11:55 -0700)]
Delete NewMerger
This was only used as part of C++ link.exe for IJW
Commit migrated from https://github.com/dotnet/coreclr/commit/
5c8cb3f135289edba7d79d121e6861fd611e3404
Bruce Forstall [Thu, 23 Mar 2017 16:31:35 +0000 (09:31 -0700)]
Enable FEATURE_METADATA_EMIT_ALL for non-crossgen compiles
This allows ilasm roundtrip test to work with NetStandard 2.0
changes where C# compiler emits a ".permissionset" attribute
into the assembly that ildasm emits. This define enables the
APIs that ilasm uses to process this attribute.
Re-enable ilasm roundtrip test.
Fixes dotnet/coreclr#8418
Commit migrated from https://github.com/dotnet/coreclr/commit/
e4849aae67375a2dfbe73bf2bf94e4abc17464d4
Aditya Mandaleeka [Thu, 23 Mar 2017 22:14:48 +0000 (15:14 -0700)]
Merge pull request dotnet/coreclr#10417 from viva64/master
Missing comma
Commit migrated from https://github.com/dotnet/coreclr/commit/
c6ce2171adf92137e7f256200a8a46dc2337de33
Alex Perovich [Thu, 23 Mar 2017 22:08:35 +0000 (15:08 -0700)]
Add missing
Commit migrated from https://github.com/dotnet/coreclr/commit/
1060c55c8126085fe36628a814aad0d266907a8b
Alex Perovich [Thu, 23 Mar 2017 21:49:30 +0000 (14:49 -0700)]
Remove moved files
Commit migrated from https://github.com/dotnet/coreclr/commit/
c03502b1064f5df5126e0a5a4f28e9a03443c7ac
Maoni Stephens [Thu, 23 Mar 2017 21:37:47 +0000 (14:37 -0700)]
porting desktop changes to enable up to 1024 CPUs (dotnet/coreclr#10404)
porting desktop changes to enable up to 1024 CPUs
Commit migrated from https://github.com/dotnet/coreclr/commit/
41c47b8555d7d471547cfb641112cd31e37cb7ae
Atsushi Kanamori [Thu, 23 Mar 2017 13:54:08 +0000 (06:54 -0700)]
Move IReflect.cs to shared partition. (dotnet/coreclr#3074)
Split AssemblyAttributes.cs into properly named files.
Commit migrated from https://github.com/dotnet/coreclr/commit/
08f09d185cdd213ef60702f9d9be1a2a7a123ad8
Atsushi Kanamori [Wed, 22 Mar 2017 18:16:35 +0000 (11:16 -0700)]
Move the easy files in System\Reflection to the shared partition. (dotnet/coreclr#3060)
* Prepare the "easy" System\Reflection .cs files for move to shared partition
Files to be moved the shared partition (after https://github.com/dotnet/coreclr/pull/10387 side is in)
AmbiguousMatchException.cs
AssemblyAttributes.cs
AssemblyContentType.cs
AssemblyNameFlags.cs
Binder.cs
BindingFlags.cs
CallingConventions.cs
CustomAttributeFormatException.cs
DefaultMemberAttribute.cs
EventAttributes.cs
ExceptionHandlingClauseOptions.cs
FieldAttributes.cs
GenericParameterAttributes.cs
ICustomAttributeProvider.cs
ImageFileMachine.cs
InterfaceMapping.cs
IntrospectionExtensions.cs
InvalidFilterCriteriaException.cs
IReflectableType.cs
ManifestResourceInfo.cs
MemberFilter.cs
MemberTypes.cs
MethodAttributes.cs
MethodImplAttributes.cs
Missing.cs
ModuleResolveEventHandler.cs
ParameterAttributes.cs
ParameterModifier.cs
PortableExecutableKinds.cs
ProcessorArchitecture.cs
PropertyAttributes.cs
ReflectionContext.cs
ReflectionTypeLoadException.cs
ResourceAttributes.cs
ResourceLocation.cs
StrongNameKeyPair.cs
TargetException.cs
TargetInvocationException.cs
TargetParameterCountException.cs
TypeAttributes.cs
TypeFilter.cs
* Prepare the "easy" System\Reflection .cs files for move to shared partition
Files to be moved the shared partition (after https://github.com/dotnet/coreclr/pull/10387 side is in)
AmbiguousMatchException.cs
AssemblyAttributes.cs
AssemblyContentType.cs
AssemblyNameFlags.cs
Binder.cs
BindingFlags.cs
CallingConventions.cs
CustomAttributeFormatException.cs
DefaultMemberAttribute.cs
EventAttributes.cs
ExceptionHandlingClauseOptions.cs
FieldAttributes.cs
GenericParameterAttributes.cs
ICustomAttributeProvider.cs
ImageFileMachine.cs
InterfaceMapping.cs
IntrospectionExtensions.cs
InvalidFilterCriteriaException.cs
IReflectableType.cs
ManifestResourceInfo.cs
MemberFilter.cs
MemberTypes.cs
MethodAttributes.cs
MethodImplAttributes.cs
Missing.cs
ModuleResolveEventHandler.cs
ParameterAttributes.cs
ParameterModifier.cs
PortableExecutableKinds.cs
ProcessorArchitecture.cs
PropertyAttributes.cs
ReflectionContext.cs
ReflectionTypeLoadException.cs
ResourceAttributes.cs
ResourceLocation.cs
StrongNameKeyPair.cs
TargetException.cs
TargetInvocationException.cs
TargetParameterCountException.cs
TypeAttributes.cs
TypeFilter.cs
* Move to shared.
Commit migrated from https://github.com/dotnet/coreclr/commit/
cd6048c74e97caf3c46429992854074ecaccecf7
Noah Falk [Thu, 23 Mar 2017 20:21:48 +0000 (13:21 -0700)]
Merge pull request dotnet/coreclr#10336 from noahfalk/wer_resource
Support Windows Minidump
Commit migrated from https://github.com/dotnet/coreclr/commit/
d6fe0910c7dd3aabc469623102d0771ddb47ace0
Steve MacLean [Thu, 23 Mar 2017 20:05:55 +0000 (16:05 -0400)]
Mark b425314 Incompatible (dotnet/coreclr#10431)
b425314 has internal logic to determine if it making forward progress
If test takes too long, test self check fails and test aborts with a
failure. This makes this test difficult in GCStress/HeapVerify situations
where run time is substantially longer.
This test was already marked incompatible for x86. Remove x86 condition
to mark incompatible on al platforms.
Commit migrated from https://github.com/dotnet/coreclr/commit/
713ca23d1888e4122fc9bbfa8251e999697d1855
Andy Ayers [Thu, 23 Mar 2017 20:03:07 +0000 (13:03 -0700)]
Merge pull request dotnet/coreclr#10432 from AndyAyersMS/ImproveTypes3
Jit: track ref types for inlinee locals and args
Commit migrated from https://github.com/dotnet/coreclr/commit/
e3510e183f1858b9cc6d89947d1e54fdc8c3b65d
dotnet bot [Thu, 23 Mar 2017 19:34:59 +0000 (12:34 -0700)]
Update CoreClr to beta-25123-07 (dotnet/coreclr#10428)
Commit migrated from https://github.com/dotnet/coreclr/commit/
77e183000b7fbe33531cf9e3dbacb8f74b481c90
chcosta [Thu, 23 Mar 2017 18:56:52 +0000 (11:56 -0700)]
Use roslyn common props (dotnet/coreclr#10430)
Commit migrated from https://github.com/dotnet/coreclr/commit/
1976320a1a56afb23f3049fb91d93a85cb4fb1d4
Jonghyun Park [Thu, 23 Mar 2017 18:51:13 +0000 (03:51 +0900)]
[PAL] Do NOT check execute bit in INIT_FindEXEPath (dotnet/coreclr#10342)
* Do NOT check execute bit in INIT_FindEXEPath
* Do NOT lookup path during PAL_Initialize
This commmit removes path lookup inside INIT_FindEXEPath, and renames
INIT_FindEXEPath as INIT_EXEPath.
Commit migrated from https://github.com/dotnet/coreclr/commit/
63319760a8ae80a397fd7fdc80bbb64cebab310e
Atsushi Kanamori [Thu, 23 Mar 2017 18:49:42 +0000 (11:49 -0700)]
Migrate the Reflection serialization holders to the shared partition. (dotnet/coreclr#10429)
* String => string, SR.GetResourceString() => SR.
* Copy over CoreRT files verbatim.
* Get things building and running again.
* Don't bring CoreRT's visibility sins into CoreCLR
* String => string, Object => object
* De-"m_" the field names.
* Move the files to the shared directory.
Commit migrated from https://github.com/dotnet/coreclr/commit/
0b9b922e7a4197e478adb354189eab508a475410
Rahul Kumar [Thu, 23 Mar 2017 18:35:12 +0000 (11:35 -0700)]
Merge pull request dotnet/coreclr#10411 from rahku/fix10197
Re-enable tests
Commit migrated from https://github.com/dotnet/coreclr/commit/
af0eb06dd6f5f27067371d0141199704f1d2f778
Brian Sullivan [Thu, 23 Mar 2017 18:30:05 +0000 (11:30 -0700)]
Merge pull request dotnet/coreclr#10397 from briansull/ibc-dump
Improve the dumping of BasicBlock weights and edge counts in the JIT
Commit migrated from https://github.com/dotnet/coreclr/commit/
abe18069c56aec42b5d8bfa83c322994f232c7ee
Bruce Forstall [Thu, 23 Mar 2017 17:57:49 +0000 (10:57 -0700)]
Merge pull request dotnet/coreclr#10402 from BruceForstall/FixMulCseBug
Fix CSE bug with GT_MUL and GTF_MUL_64RSLT
Commit migrated from https://github.com/dotnet/coreclr/commit/
b6c36706c174e0cbd280dca5ec0a829171aaafe0
Andy Ayers [Mon, 20 Mar 2017 18:12:05 +0000 (11:12 -0700)]
Jit: track ref types for inlinee locals and args
The jit may use new temporaries for inline locals and args. For temps
representing ref type locals and args, propagate the class handle from
the appropriate signature. This makes more types to be available for
devirtualization.
Also in addition to capturing arg ref types, cleanup `impInlineFetchArg`
by commoning out the table lookups and adding a header comment.
Commit migrated from https://github.com/dotnet/coreclr/commit/
22668cc8a71140f8c8fa467e70d735cb0a00035e
Steve MacLean [Thu, 23 Mar 2017 17:38:50 +0000 (13:38 -0400)]
[Unix] runtest.sh crossgen should exit on failure (dotnet/coreclr#9907)
* Fix crossgen segfault
* Check crossgen in runtests.sh
* Do not use test -v
CI showed bash 4.2 feature test -v is not present on
OSX CI systems. Fall back to more standard bash test
Commit migrated from https://github.com/dotnet/coreclr/commit/
087a2eeb4c1384113fe68da1257b98fa99bd0484
Ilya Ivanov [Thu, 23 Mar 2017 14:46:08 +0000 (17:46 +0300)]
We have found and fixed a security weakness (CWE-188) using PVS-Studio tool: Analyzer warning: V557 Array overrun is possible. The value of 'dwCode - 1' index could reach 8.
PVS-Studio is a static code analyzer for C, C++ and C#: https://www.viva64.com/en/pvs-studio/
Commit migrated from https://github.com/dotnet/coreclr/commit/
baaff75f0c3c1f8439c201afe33eafd964e4475d
Joseph Tremoulet [Mon, 13 Mar 2017 18:49:16 +0000 (11:49 -0700)]
Scalarize single-field-to-lclVar block copy
Morph has some logic to scalarize struct copies where the RHS is a scalar
and the LHS is a single-field struct. This change adds the symmetric
logic where the LHS is a scalar and the RHS is a single-field struct.
This pattern shows up in Span<T> methods that initialize the data pointer
field, due to the way scalar replacement operates on spans.
Commit migrated from https://github.com/dotnet/coreclr/commit/
a9fbca32b572413dcccfe0314766edaed9c8934a
Atsushi Kanamori [Thu, 23 Mar 2017 14:02:28 +0000 (07:02 -0700)]
Move IReflect.cs to shared partition. (dotnet/coreclr#10415)
Commit migrated from https://github.com/dotnet/coreclr/commit/
8f485224cd9a5899e5f8e991f2db87cef5566b1b
Ilya [Thu, 23 Mar 2017 13:58:18 +0000 (16:58 +0300)]
I used PVS-Studio static analyzer to check this project. I would like to suggest a variant of the way to fix the error, detected with the help of V534 diagnostic. Description of the diagnostic: https://viva64.com/en/examples/v534/ (dotnet/coreclr#10414)
Incorrect variable 'i' from the outer loop is used in condition of the inner loop.
Commit migrated from https://github.com/dotnet/coreclr/commit/
5bcd08108f522524741805d97989e5f227a6bd6b
Stephen Toub [Thu, 23 Mar 2017 13:41:12 +0000 (09:41 -0400)]
Merge pull request dotnet/coreclr#10412 from dotnet-bot/master-UpdateDependencies
Update CoreClr, CoreFx to beta-25123-03, beta-25122-02, respectively (master)
Commit migrated from https://github.com/dotnet/coreclr/commit/
f0bafd7833fc46378971398db518de4f6aa4f8cb