platform/upstream/dotnet/runtime.git
5 years agoAdded stub for boehm.
Nathan Ricci [Fri, 23 Aug 2019 17:45:23 +0000 (13:45 -0400)]
Added stub for boehm.

Commit migrated from https://github.com/mono/mono/commit/707db63569617dc624ac27bb82b31181a8230525

5 years agoFixed fomatting issues.
Nathan Ricci [Fri, 23 Aug 2019 17:42:34 +0000 (13:42 -0400)]
Fixed fomatting issues.

Commit migrated from https://github.com/mono/mono/commit/cdb77f1391b434b6cd59f158eecbc6f42717605c

5 years agoRemoved start/stop the world gc api.
Nathan Ricci [Thu, 22 Aug 2019 20:50:58 +0000 (16:50 -0400)]
Removed start/stop the world gc api.

Commit migrated from https://github.com/mono/mono/commit/93ff9dab7be9a31d64eb44effa1106dc063e82a7

5 years agoAdded tracking for detached threads.
Nathan Ricci [Thu, 22 Aug 2019 18:14:39 +0000 (14:14 -0400)]
Added tracking for detached threads.

Commit migrated from https://github.com/mono/mono/commit/bfce92d9dd995d24f2563fef36ac77d2a15dee8f

5 years agoRemoved unneeded declarations.
Nathan Ricci [Wed, 21 Aug 2019 21:31:34 +0000 (17:31 -0400)]
Removed unneeded declarations.

Commit migrated from https://github.com/mono/mono/commit/6caa530970926c1b16f27e7b0574e4ca89f91e7f

5 years agoAdded stubs in null, boehm.
Nathan Ricci [Wed, 21 Aug 2019 20:55:51 +0000 (16:55 -0400)]
Added stubs in null, boehm.

Commit migrated from https://github.com/mono/mono/commit/b65443f324d39f9006b1b8b8e5e9a96097a2123f

5 years agoImplemented precise.
Nathan Ricci [Wed, 21 Aug 2019 20:27:02 +0000 (16:27 -0400)]
Implemented precise.

Commit migrated from https://github.com/mono/mono/commit/f913945e76e5df1ee80a204a43df8770a7af0dd9

5 years agostopped the world for precise.
Nathan Ricci [Wed, 21 Aug 2019 20:05:29 +0000 (16:05 -0400)]
stopped the world for precise.

Commit migrated from https://github.com/mono/mono/commit/dc8aeba59346c59703bd5d69974a9a63c7c02840

5 years agoTook changes from miguel's branch.
Nathan Ricci [Wed, 21 Aug 2019 19:54:07 +0000 (15:54 -0400)]
Took changes from miguel's branch.

Commit migrated from https://github.com/mono/mono/commit/56f44379d0eaf22fca1980ef7023032e37ce2bd4

5 years agoWorking on precise.
Nathan Ricci [Wed, 21 Aug 2019 19:51:45 +0000 (15:51 -0400)]
Working on precise.

Commit migrated from https://github.com/mono/mono/commit/65360da5d9801c35c7b77b7b573d64e2f907723d

5 years agoFixed alphabitization error.
Nathan Ricci [Wed, 21 Aug 2019 17:59:50 +0000 (13:59 -0400)]
Fixed alphabitization error.

Commit migrated from https://github.com/mono/mono/commit/0754f5ebe57c32b879cc98c98d653ba5c6e6b818

5 years agoGot rid of some debug code.
Nathan Ricci [Wed, 21 Aug 2019 17:55:20 +0000 (13:55 -0400)]
Got rid of some debug code.

Commit migrated from https://github.com/mono/mono/commit/cfb4afff4372fa129869afc9a30aed8d7264eed5

5 years agoImplemeneted imprecise.
Nathan Ricci [Wed, 21 Aug 2019 15:20:27 +0000 (11:20 -0400)]
Implemeneted imprecise.

Commit migrated from https://github.com/mono/mono/commit/53939d0790896a527abec02b42cfaa42b0a269d5

5 years agoPut things in correct order.
Nathan Ricci [Tue, 20 Aug 2019 22:28:35 +0000 (18:28 -0400)]
Put things in correct order.

Commit migrated from https://github.com/mono/mono/commit/37086aa1c4b9c070021d995cd2d8a2ce863ac59b

5 years agoModified sample project.
Nathan Ricci [Tue, 20 Aug 2019 21:38:23 +0000 (17:38 -0400)]
Modified sample project.

Commit migrated from https://github.com/mono/mono/commit/bf04a1946f1b8018469878fb1f98d80f9985a9d7

5 years agoAdded ical to netcore.
Nathan Ricci [Tue, 20 Aug 2019 21:37:58 +0000 (17:37 -0400)]
Added ical to netcore.

Commit migrated from https://github.com/mono/mono/commit/fb7895dddfc12fe33a5e3abf528ec3e195c1a3ff

5 years agoMerge branch 'master' of github.com:naricc/mono into naricc/GetTotalAllocatedBytes
Nathan Ricci [Tue, 20 Aug 2019 19:22:18 +0000 (15:22 -0400)]
Merge branch 'master' of github.com:naricc/mono into naricc/GetTotalAllocatedBytes

Commit migrated from https://github.com/mono/mono/commit/c1d01679c56b9e75d99dcf7e94bf28508eec422a

5 years ago[coop] Add a handle frame in construct_culture (mono/mono#16299)
Aleksey Kliger (λgeek) [Mon, 19 Aug 2019 15:01:09 +0000 (11:01 -0400)]
[coop] Add a handle frame in construct_culture (mono/mono#16299)

Otherwise we see warnings like these:

```
ves_icall_System_Globalization_CultureInfo_internal_get_cultures_raw USED 680 handles
```

Commit migrated from https://github.com/mono/mono/commit/2f0cbb5aa5801144aa887a164f4c95ef146686a8

5 years agoeglib: Remove broken executable test on Windows. (mono/mono#16295)
Vincent Povirk [Mon, 19 Aug 2019 11:09:14 +0000 (06:09 -0500)]
eglib: Remove broken executable test on Windows. (mono/mono#16295)

The strcmp is wrong, and it doesn't test anything meaningful anyway.

This flag is unused since mono/mono#16156 was merged.

Commit migrated from https://github.com/mono/mono/commit/9f790cd5e2c2b5b998ce9ccdf5c4d67d8ad31507

5 years ago[interp] Remove InterpFrame.locals, replace with reasonably efficient frame_locals...
Jay Krell [Mon, 19 Aug 2019 09:50:20 +0000 (02:50 -0700)]
[interp] Remove InterpFrame.locals, replace with reasonably efficient frame_locals macro.o (mono/mono#16317)

Contributes to mono/mono#16172.

Commit migrated from https://github.com/mono/mono/commit/8886f71b2cb957cdf3f967d8251ec9a6102e358f

5 years ago[interp] Put finally data back in locals instead of frame to save 16 bytes of stack...
Alexander Köplinger [Mon, 19 Aug 2019 09:24:44 +0000 (11:24 +0200)]
[interp] Put finally data back in locals instead of frame to save 16 bytes of stack. (mono/mono#16307)

* Put finally data back in locals instead of frame to save 16 bytes of stack.

Partial undo of mono/mono@f8fd60b5c088753a4a0ccb79483ebae73489e7a2.

* Add comments explaining goto main_loop vs. MINT_IN_DISPATCH.

Commit migrated from https://github.com/mono/mono/commit/e754bb1c430d5ae65056c01fd5ef1f370ff2150a

5 years ago[interp] Outline ves_array_element_address to save 16 bytes of stack on Linux/amd64...
Jay Krell [Mon, 19 Aug 2019 09:24:11 +0000 (02:24 -0700)]
[interp] Outline ves_array_element_address to save 16 bytes of stack on Linux/amd64/clang. (mono/mono#16304)

Contributes to mono/mono#16172.

Commit migrated from https://github.com/mono/mono/commit/60cd1b35565e8a4553cc1d70de204ecb96ed54fa

5 years agothread names: coop, constants, usually ignore-error. (mono/mono#16272)
Alexander Köplinger [Mon, 19 Aug 2019 09:23:23 +0000 (11:23 +0200)]
thread names: coop, constants, usually ignore-error. (mono/mono#16272)

- Convert setting thread name to be coop-compatible.

- For constant thread names, just retain the constant, not a copy.
  This includes producing and using constant unicode thread names on Windows.

- Make setting a thread name often non-fatal, except where mandated by public API.

- From earlier PR: mono_free (mono-publib.c) would no longer be referenced and therefore
  no longer exported. That broke profilers and maybe other externals.
  Choices:
     1 Use it instead of g_free randomly sometimes.
     2 Call it randomly sometimes.
     3 include it in external-only.c or object.c
     4 Mark it external only (breaks profiler).
     5 Use a .def file or Unix equivalent.

     5 is best, 2 is done here, the advantages/disadvantages
     among most choices are subtle. 3 is probably better than 2
     but is slightly bigger change, to put off -- you'd stop
     compiling mono-publib.c and move it to include/extra_redist.

     The advantage of not-.def file is perhaps that it is exposed
     by the compiler, so maybe easy to port and work with.
     People are more comfortable with obscure C extensions than
     any linker options, and there are multiple linkers to contend
     with. Arguably there are fewer compilers.

Commit migrated from https://github.com/mono/mono/commit/9001c4fa83aa2327038627e9f003ce9432a8e8d5

5 years agoReduce size of internal MonoErrors by 3 pointers, while trying to be compatible with...
Jay Krell [Mon, 19 Aug 2019 09:20:37 +0000 (02:20 -0700)]
Reduce size of internal MonoErrors by 3 pointers, while trying to be compatible with old size.(mono/mono#16218)

There is an incompatibility here.

If Mono hands off an InternalError and it is accessed
like an ExternalError, like memset(sizeof()), bad.

Hopefully nobody does that.

There is also compatability -- embedders can continue to embed MonoError
in their own data. Its size and hopefully alignment is unchanged.

Commit migrated from https://github.com/mono/mono/commit/cf0ce4f55ad92529bf969bef1cbf5cc6a502fdef

5 years ago[interp] Replace frame.args with frame.stack, the same except for type (mono/mono...
Jay Krell [Mon, 19 Aug 2019 09:19:10 +0000 (02:19 -0700)]
[interp] Replace frame.args with frame.stack, the same except for type (mono/mono#16316)

Contributes to mono/mono#16172.

Commit migrated from https://github.com/mono/mono/commit/047c7d35faa441e9d73364b681e5826a7c00051f

5 years ago[interp] Make sure we allocate stack for MINT_LD_DELEGATE_INVOKE_IMPL (mono/mono...
Vlad Brezae [Mon, 19 Aug 2019 08:59:21 +0000 (11:59 +0300)]
[interp] Make sure we allocate stack for MINT_LD_DELEGATE_INVOKE_IMPL (mono/mono#16224)

* [interp] Make sure we allocate stack for MINT_LD_DELEGATE_INVOKE_IMPL

This opcode is pushing a function pointer from the delegate, so it needs to have stack reserved.

* [interp] Fix overflow of stack space

Commit migrated from https://github.com/mono/mono/commit/975b543e92e296db338ac699c8d87c46f1fbbe42

5 years agowarning: mono-threads-wasm.c no previous prototype for function mono_background_exec...
Jay Krell [Mon, 19 Aug 2019 03:22:06 +0000 (20:22 -0700)]
warning: mono-threads-wasm.c no previous prototype for function mono_background_exec (mono/mono#16289)

Commit migrated from https://github.com/mono/mono/commit/cecea63691e412e0363de91a9bea594caf1ae2cc

5 years ago[interp] Reduce register/stack pressure slightly. (mono/mono#16303)
Jay Krell [Sun, 18 Aug 2019 14:36:33 +0000 (07:36 -0700)]
[interp] Reduce register/stack pressure slightly. (mono/mono#16303)

No savings on Linux/amd64/gcc/clang.

Commit migrated from https://github.com/mono/mono/commit/d1f47e7b48826abd41eaab5c492f41cf4d22ac3f

5 years agoAdd comments explaining goto main_loop vs. MINT_IN_DISPATCH.
Jay Krell [Sat, 17 Aug 2019 21:27:23 +0000 (14:27 -0700)]
Add comments explaining goto main_loop vs. MINT_IN_DISPATCH.

Commit migrated from https://github.com/mono/mono/commit/9a24e9a389130d81890a03cba1f413fbc9bec074

5 years agoMerge pull request mono/mono#16210 from EgorBo/opt-llvm-jit
Zoltan Varga [Sat, 17 Aug 2019 16:22:07 +0000 (12:22 -0400)]
Merge pull request mono/mono#16210 from EgorBo/opt-llvm-jit

Auto-detect current cpu in LLVM JIT

Commit migrated from https://github.com/mono/mono/commit/13fb0134a0d924a0d140e186bac83eb6ee40f8f9

5 years agoPut finally data back in locals instead of frame to save 16 bytes of stack.
Jay Krell [Sat, 17 Aug 2019 05:47:17 +0000 (22:47 -0700)]
Put finally data back in locals instead of frame to save 16 bytes of stack.

Partial undo of mono/mono@f8fd60b5c088753a4a0ccb79483ebae73489e7a2.

Commit migrated from https://github.com/mono/mono/commit/3fb7834afb70974092aa43ec0ff1d8188fdf2d68

5 years agothread names: coop, constants, usually ignore-error.
Jay Krell [Thu, 25 Jul 2019 10:19:02 +0000 (03:19 -0700)]
thread names: coop, constants, usually ignore-error.

- Convert setting thread name to be coop-compatible.

- For constant thread names, just retain the constant, not a copy.
  This includes producing and using constant unicode thread names on Windows.

- Make setting a thread name often non-fatal, except where mandated by public API.

- From earlier PR: mono_free (mono-publib.c) would no longer be referenced and therefore
  no longer exported. That broke profilers and maybe other externals.
  Choices:
     1 Use it instead of g_free randomly sometimes.
     2 Call it randomly sometimes.
     3 include it in external-only.c or object.c
     4 Mark it external only (breaks profiler).
     5 Use a .def file or Unix equivalent.

     5 is best, 2 is done here, the advantages/disadvantages
     among most choices are subtle. 3 is probably better than 2
     but is slightly bigger change, to put off -- you'd stop
     compiling mono-publib.c and move it to include/extra_redist.

     The advantage of not-.def file is perhaps that it is exposed
     by the compiler, so maybe easy to port and work with.
     People are more comfortable with obscure C extensions than
     any linker options, and there are multiple linkers to contend
     with. Arguably there are fewer compilers.

Commit migrated from https://github.com/mono/mono/commit/0c6cb9fbc3f97e15acf6be07eb46c19a288b3937

5 years ago[Coop] Convert mono_attach_load_agent. (mono/mono#15954)
Jay Krell [Fri, 16 Aug 2019 21:16:03 +0000 (14:16 -0700)]
[Coop] Convert mono_attach_load_agent. (mono/mono#15954)

Based on https://github.com/mono/mono/pull/15868.
Most cleanup and leak fixes moved and expanded to https://github.com/mono/mono/pull/15950.

Commit migrated from https://github.com/mono/mono/commit/16a81cf520d82a9e4c0ff10654a627e55dc51b58

5 years ago[netcore] Enable netcore resolution logic for mono_assembly_byname_lookup (mono/mono...
Ryan Lucia [Fri, 16 Aug 2019 20:54:47 +0000 (16:54 -0400)]
[netcore] Enable netcore resolution logic for mono_assembly_byname_lookup (mono/mono#16256)

* Use netcore_load_reference in mono_assembly_request_byname

* Add ALC static Resolve event code from CoreCLR

* Wire up the AssemblyResolve event

* Enable newly passing test

* Set requesting assembly in InternalLoad

* Remove infinite recursion

* Only call netcore_load_reference from mono_assembly_request_byname

* Remove test completely

Commit migrated from https://github.com/mono/mono/commit/1e457cdd1e5b1efc8860ab58a9fb7a00c82bc0c2

5 years agoChanges GC.cs
Nathan Ricci [Fri, 16 Aug 2019 15:48:35 +0000 (11:48 -0400)]
Changes GC.cs

Commit migrated from https://github.com/mono/mono/commit/325bbf541b08b8a829536e865f24807207282193

5 years agoImplemented imprecise version of get total bytes allocated.
Nathan Ricci [Fri, 16 Aug 2019 15:26:39 +0000 (11:26 -0400)]
Implemented imprecise version of get total bytes allocated.

Commit migrated from https://github.com/mono/mono/commit/029467271ee2b0907565555de467b494d48edacb

5 years agoIgnore NULL in mono_marshal_free_dynamic_wrappers and mono_free_method. (mono/mono...
Jay Krell [Fri, 16 Aug 2019 13:33:04 +0000 (06:33 -0700)]
Ignore NULL in mono_marshal_free_dynamic_wrappers and mono_free_method. (mono/mono#14150)

Commit migrated from https://github.com/mono/mono/commit/e54f03168d223debdab1717eb24055662211e4f8

5 years agoFill in more MONO_PATCH_INFO_NONE support. (mono/mono#13990)
Jay Krell [Fri, 16 Aug 2019 13:32:48 +0000 (06:32 -0700)]
Fill in more MONO_PATCH_INFO_NONE support. (mono/mono#13990)

Commit migrated from https://github.com/mono/mono/commit/66afab580309acb23a5ed022a2e424c400907c65

5 years ago[interp] Localize c, i32, o as suggested. (mono/mono#16268)
Jay Krell [Fri, 16 Aug 2019 13:32:07 +0000 (06:32 -0700)]
[interp] Localize c, i32, o as suggested. (mono/mono#16268)

This saves 16 stack bytes for clang, gcc is unmoved probably figured it out on its own.

Commit migrated from https://github.com/mono/mono/commit/f52bfb94d514d65d1a1532d2956b4099266da607

5 years ago[interp] Fix more MonoError reuse (mono_object_new_checked). (mono/mono#16263)
Jay Krell [Fri, 16 Aug 2019 13:26:49 +0000 (06:26 -0700)]
[interp] Fix more MonoError reuse (mono_object_new_checked). (mono/mono#16263)

* [interp] Fix more MonoError reuse (mono_object_new_checked).

* Inline mono_interp_new/mono_object_new_checked now that we are in outlined mono_interp_newobj.

Commit migrated from https://github.com/mono/mono/commit/4d9e6ae20e536394c9ff65c61238045db294c08e

5 years ago[corlib] Fix sharing mode validation rules (mono/mono#16247)
Steve Pfister [Fri, 16 Aug 2019 11:52:22 +0000 (07:52 -0400)]
[corlib] Fix sharing mode validation rules  (mono/mono#16247)

Fixes https://github.com/mono/mono/issues/16032

When we switched to corefx File.Copy on unix, the behavior changed where it opened a source and destination stream in order to pass the safe handles to Interop.Sys.CopyFile. This exposed a flaw in our sharing validation rules in MonoIO.Open, which threw an exception in this scenario:

new FileStream("source.txt", FileMode.OpenOrCreate, FileAccess.ReadWrite, FileShare.ReadWrite, 2048, FileOptions.DeleteOnClose);
new FileStream("source.txt", FileMode.Open, FileAccess.Read, FileShare.Read, 2048, FileOptions.None);

Simplified the FileShare check down to:

1. If the caller specifies FileShare.None, then it's an exclusive lock and no
   sharing is allowed.

2. If the caller specifies some other FileShare option, then FileShare.None
    cannot be specified.

Commit migrated from https://github.com/mono/mono/commit/da2c0159e9736ebb7f6d8fbe1ebc8671e4cab7e7

5 years ago[netcore] Add patch-local-dotnet-aot-llvm rule (mono/mono#16120)
Egor Bogatov [Fri, 16 Aug 2019 10:43:08 +0000 (13:43 +0300)]
[netcore] Add patch-local-dotnet-aot-llvm rule (mono/mono#16120)

* Add patch-local-dotnet-aot-llvm rule

* Update Makefile

* Add run-sample-local-dotnet-llvm

Commit migrated from https://github.com/mono/mono/commit/4dca4f66197fa118b02593b54f79570367ab46d2

5 years agointepreter: remove last element from various arrays (mono/mono#16134)
Jay Krell [Fri, 16 Aug 2019 08:37:20 +0000 (01:37 -0700)]
intepreter: remove last element from various arrays (mono/mono#16134)

add const
 combine lines for searchability

Commit migrated from https://github.com/mono/mono/commit/0c637a73a9663bf6ca984037c4a5eac16ac91913

5 years ago[interp] Fully outline enum_hasflag to save stack. (mono/mono#16228)
Jay Krell [Fri, 16 Aug 2019 07:13:22 +0000 (00:13 -0700)]
[interp] Fully outline enum_hasflag to save stack. (mono/mono#16228)

Alternative to https://github.com/mono/mono/pull/16197.
If you are going outline, you sometimes might as well take it all with you
instead of bouncing back and forth for a partial inlining.

Commit migrated from https://github.com/mono/mono/commit/35fc20b6375b338f8b9965fecfebb5e815e42c55

5 years agoMerge pull request mono/mono#16261 from vargaz/tp-no-random
Zoltan Varga [Fri, 16 Aug 2019 03:48:35 +0000 (23:48 -0400)]
Merge pull request mono/mono#16261 from vargaz/tp-no-random

[runtime] Use a PRNG in the threadpool instead of the os random number generator.

Commit migrated from https://github.com/mono/mono/commit/5461fb78c745ab48cb97f8b7c65a08632f725102

5 years agoMerge pull request mono/mono#16257 from EgorBo/llvm-ptr
Zoltan Varga [Fri, 16 Aug 2019 01:59:42 +0000 (21:59 -0400)]
Merge pull request mono/mono#16257 from EgorBo/llvm-ptr

Align C# pointers with LLVM pointers for primitive types

Commit migrated from https://github.com/mono/mono/commit/764091677eb717da8cf5799c2b625fd529c3e93a

5 years ago[mini] Cleanup alloca: call twice instead of once, and shrink allocation slightly...
Jay Krell [Thu, 15 Aug 2019 22:14:37 +0000 (15:14 -0700)]
[mini] Cleanup alloca: call twice instead of once, and shrink allocation slightly. (mono/mono#16158)

It is an actual function call at least on Windows.

Commit migrated from https://github.com/mono/mono/commit/6c05cfab5996387321164d84c267d3100b6bfb66

5 years ago[interp] Fix more MonoError reuse. (mono/mono#16262)
Jay Krell [Thu, 15 Aug 2019 22:06:50 +0000 (15:06 -0700)]
[interp] Fix more MonoError reuse. (mono/mono#16262)

Commit migrated from https://github.com/mono/mono/commit/b654aa1ca858666539a677e96d00f594fd81c630

5 years ago[Coop] Convert emit_invoke_call. (mono/mono#15964)
Jay Krell [Thu, 15 Aug 2019 21:56:33 +0000 (14:56 -0700)]
[Coop] Convert emit_invoke_call. (mono/mono#15964)

Removing calls to mono_string_new_checked.
Extracted from https://github.com/mono/mono/pull/15900.

Commit migrated from https://github.com/mono/mono/commit/dfbf1a1bd3a792997461f8a43bdb6b5bf7738382

5 years agoWrap more external-only functions in GC mode transitions. (mono/mono#15895)
Jay Krell [Thu, 15 Aug 2019 21:48:18 +0000 (14:48 -0700)]
Wrap more external-only functions in GC mode transitions. (mono/mono#15895)

mono_compile_method
mono_runtime_set_main_args
mono_runtime_run_main
mono_runtime_exec_managed_code
mono_load_remote_field
mono_load_remote_field_new
mono_store_remote_field
mono_store_remote_field_new

Commit migrated from https://github.com/mono/mono/commit/44ff0597b835d0af62f526169dba3b365c9c3411

5 years agoLlvm optimizations (mono/mono#16191)
Zoltan Varga [Thu, 15 Aug 2019 19:46:00 +0000 (15:46 -0400)]
Llvm optimizations (mono/mono#16191)

* [jit] Disable inlining for ThrowHelper methods for non-netcore as well. Add an OP_NOT_REACHED after calls to these methods to let LLVM know they don't return.

* [llvm] Use the cold calling convention instead of the preserveall one, it has the same effect and its better supported.

* [llvm] Call the aot init function using the cold cconv.

* [llvm] Make the condition in the poll function unlikely.

* [llvm] Add a wrapper around the GC poll icall so it can be called with a cold calling convention.

* Move the noreturn check before the code which is shared with calli.

Commit migrated from https://github.com/mono/mono/commit/870aec4aadfd8b523b62070137643b0cc3a97399

5 years agoAdd missing FCONV_TO_U8 on ILP32 (WatchOS 5) (mono/mono#16276)
Jo Shields [Thu, 15 Aug 2019 17:56:04 +0000 (13:56 -0400)]
Add missing FCONV_TO_U8 on ILP32 (WatchOS 5) (mono/mono#16276)

Commit migrated from https://github.com/mono/mono/commit/4ec4d7a3b3b8784a28551b192b01446aaff617a4

5 years agoRetain thread names as UTF8 instead of only UTF16. (mono/mono#15945)
Jay Krell [Thu, 15 Aug 2019 17:37:34 +0000 (10:37 -0700)]
Retain thread names as UTF8 instead of only UTF16. (mono/mono#15945)

Windows can still have its Unicode thread names, since we have UTF16 initially, just don't retain it.

This does penalize ves_icall_System_Threading_Thread_GetName_internal (non-netcore only),
which has to convert back to UTF16 each time.

But seems like a net win overall.

There is also a little prep work here for constant thread names and some temporary measures as multiple changes head toward the same code.

Rename `mono_thread_set_name_internal` to `mono_thread_set_name`.
Close possible race conditions.

Extracted from https://github.com/mono/mono/pull/15859.

Commit migrated from https://github.com/mono/mono/commit/7b64f1cd005ef4f8e7f0aa5655debca2754b1755

5 years ago[interp] Outline newobj and newobj_vt. (mono/mono#16267)
Jay Krell [Thu, 15 Aug 2019 17:23:24 +0000 (10:23 -0700)]
[interp] Outline newobj and newobj_vt. (mono/mono#16267)

In this variation, the exception handling and resume are split between the main function and the helper function, and no address-taken occurs on ip/sp/vt_sp.

The order is a little tangled but convincing.
The helper function returns MonoException* or checks context->has_resume_state and then returns, and then the caller does the checks again.

Based on past analysis this will conserve stack, but that was not double checked here.
i.e. due to `&valuetype_this`, though it is conditional and the code could be split up into inline and outline.

Commit migrated from https://github.com/mono/mono/commit/f35c755fea61f679a000cbf31b7249e0e320b689

5 years agoFix failing OSX Android lane (mono/mono#16274)
Jo Shields [Thu, 15 Aug 2019 14:37:04 +0000 (10:37 -0400)]
Fix failing OSX Android lane (mono/mono#16274)

Linker order matters when using .a files, so zlib.a MUST come after
sgen.a if sgen.a was compiled with support for compressed ppdb

Commit migrated from https://github.com/mono/mono/commit/dd6bd568a0067a1206e9460017d2f4edb63f2c32

5 years ago[exceptions] Don't debug hang on ThreadAbortException (mono/mono#16240)
Vlad Brezae [Thu, 15 Aug 2019 11:57:26 +0000 (14:57 +0300)]
[exceptions] Don't debug hang on ThreadAbortException (mono/mono#16240)

It is pretty much useless.

Commit migrated from https://github.com/mono/mono/commit/6fc089bf8b253df82a04822f7a34bf0c8c59ab52

5 years agoReduce redundant setting of thread name. (mono/mono#16253)
Jay Krell [Thu, 15 Aug 2019 08:56:38 +0000 (01:56 -0700)]
Reduce redundant setting of thread name. (mono/mono#16253)

Maintain a counter and only set if the counter has changed.
This cannot be fully thread safe, so is not.
Any thread can set any other thread name at any time.
You could be atomic to do better, and loop to do even better,
but the thread name could still be changed again right after the loop exists.

The previous code was also not reliable in this way, since again the name
could be changed right away.

mono/mono#16248

Commit migrated from https://github.com/mono/mono/commit/63e1828f7e1c9694f34fd7189df6abc5cde1f192

5 years ago[interp] [wasm] p vs. o on newobj (mono/mono#16264)
Jay Krell [Thu, 15 Aug 2019 08:42:12 +0000 (01:42 -0700)]
[interp] [wasm] p vs. o on newobj (mono/mono#16264)

Commit migrated from https://github.com/mono/mono/commit/5ec452666ad4c8a5d9cbab1c78b83789fc1f224f

5 years ago[interp] Fix some, not all, of the error management. (mono/mono#16232)
Jay Krell [Thu, 15 Aug 2019 08:41:49 +0000 (01:41 -0700)]
[interp] Fix some, not all, of the error management. (mono/mono#16232)

From mono/mono#16190.

Commit migrated from https://github.com/mono/mono/commit/fd4956fbf277ec56a13137e01b48efb98a5556f5

5 years ago[interp] Short-circuit MINT_STELEM_REF on NULL. (mono/mono#16229)
Jay Krell [Thu, 15 Aug 2019 08:39:45 +0000 (01:39 -0700)]
[interp] Short-circuit MINT_STELEM_REF on NULL. (mono/mono#16229)

Presumably this is not a useful semantic change,
to skip those functions, given NULL.

(We will probably want to outline all of this also, later).

Commit migrated from https://github.com/mono/mono/commit/7766f9b9262701d98eb79758e24d29aab614cc65

5 years ago[interp] Compute locals later to reduce register/stack pressure and conserve stack...
Jay Krell [Thu, 15 Aug 2019 08:39:27 +0000 (01:39 -0700)]
[interp] Compute locals later to reduce register/stack pressure and conserve stack. (mono/mono#16231)

i.e. do not def before a function call and use after, do both after.

Commit migrated from https://github.com/mono/mono/commit/fc724e6cf0c690b8c40ccfe12b0d2316747b1142

5 years ago[interp] Split leave into pieces, partially outlined, to conserve stack, (mono/mono...
Jay Krell [Thu, 15 Aug 2019 08:39:03 +0000 (01:39 -0700)]
[interp] Split leave into pieces, partially outlined, to conserve stack, (mono/mono#16213)

but without changing how exception handling macros access labels and locals.

This saves 16 bytes of stack on Linux/amd64/gcc and likely similar everywhere,
as it takes an address-taken local out of interp_exec_method_full (stackval tmp_sp).

See
https://github.com/mono/mono/pull/16171
https://github.com/mono/mono/pull/16171/commits/mono/mono@a6a8f0d5ffa875da9cda63444e401c37810a690f for a
full outlining.

Commit migrated from https://github.com/mono/mono/commit/dde3452690d2836d790054faaf719a958cee7bb8

5 years ago[cominterop] Fix copy-paste error in ComVisibleAttribute testing helper.
Nikolay Sivov [Wed, 14 Aug 2019 21:55:54 +0000 (00:55 +0300)]
[cominterop] Fix copy-paste error in ComVisibleAttribute testing helper.

This type was introduced with mono/mono@29a95bafd87830c430432546af4bf7076ba5542f.

Commit migrated from https://github.com/mono/mono/commit/5b66d3d5187906d708fd9c22e67e5581f117bb37

5 years agoEnable and document debug with sdb with netcore config.
Thays Grazia [Wed, 14 Aug 2019 22:51:42 +0000 (19:51 -0300)]
Enable and document debug with sdb with netcore config.

Commit migrated from https://github.com/mono/mono/commit/dcfec3966c027c4a9411b34138a530839b2b9889

5 years ago[runtime] Use a PRNG in the threadpool instead of the os random number generator...
Zoltan Varga [Wed, 14 Aug 2019 23:45:27 +0000 (19:45 -0400)]
[runtime] Use a PRNG in the threadpool instead of the os random number generator, its good enough, and its much faster.

Commit migrated from https://github.com/mono/mono/commit/928aab1b841bb92d0eace058d4860be63ef3d76a

5 years agoaddress feedback
Egor Bogatov [Wed, 14 Aug 2019 23:39:13 +0000 (02:39 +0300)]
address feedback

Commit migrated from https://github.com/mono/mono/commit/93eceec724659e85c12e165793926e705a44f761

5 years agoRemove ampersand from cfg->error per old agreement. (mono/mono#16219)
Jay Krell [Wed, 14 Aug 2019 23:07:56 +0000 (16:07 -0700)]
Remove ampersand from cfg->error per old agreement. (mono/mono#16219)

Commit migrated from https://github.com/mono/mono/commit/2463605f01643e21753cb73874ae683457280d77

5 years agohandle primitive pointers in llvm
Egor Bogatov [Wed, 14 Aug 2019 22:38:58 +0000 (01:38 +0300)]
handle primitive pointers in llvm

Commit migrated from https://github.com/mono/mono/commit/ed4be03b79b4337a33c688e0c9368af23ab9ed37

5 years ago[interp] Fix icall signature (mono/mono#16227)
Vlad Brezae [Wed, 14 Aug 2019 21:18:45 +0000 (00:18 +0300)]
[interp] Fix icall signature (mono/mono#16227)

Commit migrated from https://github.com/mono/mono/commit/4e793ad30c24b30097ba3e9865799b6d9e7e0390

5 years agoFix linking of OS-provided zlib (mono/mono#16177)
Jo Shields [Wed, 14 Aug 2019 20:58:07 +0000 (16:58 -0400)]
Fix linking of OS-provided zlib (mono/mono#16177)

* Fix linking of OS-provided zlib

This is a reduced version of https://github.com/mono/mono/pull/16091
without the Z_PREFIX stuff

* Get rid of HAVE_ZLIB, be explicit about HAVE_SYS_ZLIB vs HAVE_STATIC_ZLIB

* Proposed fixes from Alex

Commit migrated from https://github.com/mono/mono/commit/f2d813c90df3a6c4d15eab240b0a68ec055c8f5b

5 years ago[metadata] Create strongly typed versions of mono_assembly_request_prepare (mono...
Aleksey Kliger (λgeek) [Wed, 14 Aug 2019 19:07:26 +0000 (15:07 -0400)]
[metadata] Create strongly typed versions of mono_assembly_request_prepare (mono/mono#16094)

* [metadata] Create strongly typed versions of mono_assembly_request_prepare

Addresses the family of issues similar to Coverity mono/mono#1443346.

This came up as part of the Coverity review, and Coverity notices that this is
writting beyond the end of the structure.  While this is correct, this requires
that the idiom be properly followed - that is, that the structure being passed
is of the given size.

Replaced instead with a method that eliminates the room for error with methods
that will initialize the whole structure, and the actual size computation is
done inside the method with the proper type sizes.

While I used methods, I feel that this should use macros.

Commit migrated from https://github.com/mono/mono/commit/ce92c4376f31e9caf964938a3899d179bdc97e51

5 years agoignore stacktrace tests
Egor Bogatov [Wed, 14 Aug 2019 10:59:00 +0000 (13:59 +0300)]
ignore stacktrace tests

Commit migrated from https://github.com/mono/mono/commit/abb43f9361192c26ce2355a1f254852efd07abbf

5 years ago[interp] Reduce frame size by partially outlining load remote field. (mono/mono#16196)
Jay Krell [Wed, 14 Aug 2019 10:34:54 +0000 (03:34 -0700)]
[interp] Reduce frame size by partially outlining load remote field. (mono/mono#16196)

Extracted from https://github.com/mono/mono/pull/16171.
Ultimately over 100 bytes can be saved.

Tactically not outlined or indirected:
 vt_sp change
 ip advancement
 error handling

 Also partially fixes the error reuse from https://github.com/mono/mono/pull/16190.

Commit migrated from https://github.com/mono/mono/commit/d1c0974e46bf0edd5f337e72b6032e903d90b703

5 years agoMake small_id_mutex not recursive. (mono/mono#15485)
Jay Krell [Wed, 14 Aug 2019 10:33:58 +0000 (03:33 -0700)]
Make small_id_mutex not recursive. (mono/mono#15485)

(Later non-recursive Windows mutexes should be SRWLOCK and only statically initialized.)

Commit migrated from https://github.com/mono/mono/commit/60ac98ee29d267646629bc39558f44e4e5af8b4e

5 years agoUse ERROR_DECL. (mono/mono#16220)
Jay Krell [Wed, 14 Aug 2019 10:28:00 +0000 (03:28 -0700)]
Use ERROR_DECL. (mono/mono#16220)

Commit migrated from https://github.com/mono/mono/commit/8c5d0a790e4677150c71fc58949f0420e1a50cf1

5 years ago[interp] Remove address-taking of vt_sp. (mono/mono#16215)
Jay Krell [Wed, 14 Aug 2019 10:27:22 +0000 (03:27 -0700)]
[interp] Remove address-taking of vt_sp. (mono/mono#16215)

Theoretically could help reduce frame size but it has not been seen to.

Commit migrated from https://github.com/mono/mono/commit/74b0d01e07c01d0bbc40c2b80ca4d007b037270a

5 years ago[interp] Outline `mono_interp_calli_nat_dynamic_pinvoke` to reduce stack. (mono/mono...
Jay Krell [Wed, 14 Aug 2019 10:25:44 +0000 (03:25 -0700)]
[interp] Outline `mono_interp_calli_nat_dynamic_pinvoke` to reduce stack. (mono/mono#16201)

Now that we have that function, also change from malloc to alloca.

This is part of mono/mono#16171 and ultimately over 100 bytes were saved.

Commit migrated from https://github.com/mono/mono/commit/4c17442dc31553109a8792e0f6d32221392d798c

5 years agoCompletely replace mono_error_ok with is_ok and make first external_only. (mono/mono...
Jay Krell [Wed, 14 Aug 2019 10:24:50 +0000 (03:24 -0700)]
Completely replace mono_error_ok with is_ok and make first external_only. (mono/mono#16217)

Commit migrated from https://github.com/mono/mono/commit/136205ab45ca3fe01c49a321103e1563885c8da1

5 years agoSkip degenerate qsort: num < 2, size == 0, base == 0 (mono/mono#16016)
Jay Krell [Wed, 14 Aug 2019 10:22:40 +0000 (03:22 -0700)]
Skip degenerate qsort: num < 2, size == 0, base == 0 (mono/mono#16016)

Fixes https://github.com/mono/mono/issues/15994

Some is redundant for some qsort implementations.

Commit migrated from https://github.com/mono/mono/commit/12de10007cf9a2973452c9cf2df36692808fefb6

5 years agoFix warning LNK4221 warning in assembly-load-context.obj (mono/mono#16004)
Jay Krell [Wed, 14 Aug 2019 10:19:08 +0000 (03:19 -0700)]
Fix warning LNK4221 warning in assembly-load-context.obj (mono/mono#16004)

LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library

Commit migrated from https://github.com/mono/mono/commit/6873d5370d78c2385aa5a1782fed5fc9bd7d36f4

5 years ago[interp] Outline `get_virtual_method_fast` to save 16 bytes of stack. (mono/mono...
Jay Krell [Wed, 14 Aug 2019 10:17:23 +0000 (03:17 -0700)]
[interp] Outline `get_virtual_method_fast` to save 16 bytes of stack. (mono/mono#16198)

Ultimately over 100 bytes are savable in a few steps.

Commit migrated from https://github.com/mono/mono/commit/9123ac0197071f084f463899f082e44cd5722e08

5 years ago[interp] Outline `set_resume_state` to conserve stack in main interpreter loop (mono...
Jay Krell [Wed, 14 Aug 2019 10:17:01 +0000 (03:17 -0700)]
[interp] Outline `set_resume_state` to conserve stack in main interpreter loop (mono/mono#16200)

This is not intuitive but I definitely saw it.

Commit migrated from https://github.com/mono/mono/commit/dbf13301c8bb48982da0a1021619631d1c52c0db

5 years ago[debugger] Debugger tries to execute a single step when the thread is already termina...
Thays Grazia [Wed, 14 Aug 2019 01:47:28 +0000 (22:47 -0300)]
[debugger] Debugger tries to execute a single step when the thread is already terminated (mono/mono#16208)

* Debugger tries to execute a single step when the thread is already terminated.

* Fixing how to get thread tls.

Commit migrated from https://github.com/mono/mono/commit/f812d90fa1b62590169f9d12e4aae76ea76b1387

5 years agoauto-detect cpu in llvm jit
Egor Bogatov [Tue, 13 Aug 2019 19:24:54 +0000 (22:24 +0300)]
auto-detect cpu in llvm jit

Commit migrated from https://github.com/mono/mono/commit/6c514405387e6c47eb064ac922492d784f644ed7

5 years ago[runtime] Initialize thread suspend policy at startup, inline getter (mono/mono#16149)
Aleksey Kliger (λgeek) [Tue, 13 Aug 2019 19:16:05 +0000 (15:16 -0400)]
[runtime] Initialize thread suspend policy at startup, inline getter (mono/mono#16149)

* [runtime] Initialize thread suspend policy at startup, inline getter

On some benchmarks we saw mono_threads_suspend_policy() using a lot of CPU
time.

Rather than doing an init-on-first-use, initialize the policy once upfront when
the JIT it starting up and make the getter method static inline.

* move mono_threads_suspend_policy_init into mono_thread_info_init

* [mini] Initialize suspend policy for `mono --version`

Need to initialize the suspend policy before printing its name.  Otherwise the
suspend policy is unset since no other runtime initialization is done for `--version`.

Commit migrated from https://github.com/mono/mono/commit/592de53a1f687d115fef86978e56a7fe7b4340c2

5 years ago[netcore] Cleanup System.Private.CoreLib.csproj (mono/mono#16199)
Alexander Köplinger [Tue, 13 Aug 2019 14:41:03 +0000 (16:41 +0200)]
[netcore] Cleanup System.Private.CoreLib.csproj (mono/mono#16199)

- The eng/Versions.props was already imported by the arcade targets causing a double-import warning:

> warning MSB4011: "/Users/alexander/dev/mono/eng/Versions.props" cannot be imported again. It was already imported at "/Users/alexander/.nuget/packages/microsoft.dotnet.arcade.sdk/1.0.0-beta.19379.1/tools/DefaultVersions.props (17,3)". This is most likely a build authoring error. This subsequent import will be ignored.

- Remove BaseAddress and TRACE from the project file, this was done upstream at https://github.com/dotnet/coreclr/commit/mono/mono@bc430cdd2010bf7790854a60380d00c506c346a6

- Remove unecessary DebugSymbols/DebugType settings, we already set them in the global PropertyGroup

Commit migrated from https://github.com/mono/mono/commit/ff77b427f4f0c9ef7f926a302564ee239619e471

5 years ago[sre] Outline typebuilder_setup_fields loop body (mono/mono#16184)
Aleksey Kliger (λgeek) [Tue, 13 Aug 2019 13:31:31 +0000 (09:31 -0400)]
[sre] Outline typebuilder_setup_fields loop body (mono/mono#16184)

The loop body uses coop handles, so wrap it in HANDLE_FUNCTION_ENTER/HANDLE_FUNCTION_RETURN

Commit migrated from https://github.com/mono/mono/commit/1f4ac5d767570b5c4c73ce75b6c9c49bfcb5fc56

5 years ago[interp] Replace `mono_error_ok` with `is_ok`. (mono/mono#16193)
Jay Krell [Tue, 13 Aug 2019 13:30:28 +0000 (06:30 -0700)]
[interp] Replace `mono_error_ok` with `is_ok`. (mono/mono#16193)

The locally unknown function, despite being small/fast, forces saving values in stack and nonvolatile registers
around calling it.
Both nonvolatile registers and stack are at a premium here, whereas usually stack is cheap.
The macro is just a read from offset 0 and checking for zero.

Commit migrated from https://github.com/mono/mono/commit/ef199425a2867b20695cb1c4e6df4b699dd8891a

5 years ago[netcore] decimal should have alignment=8 (mono/mono#15666)
Egor Bogatov [Mon, 12 Aug 2019 19:57:47 +0000 (22:57 +0300)]
[netcore] decimal should have alignment=8 (mono/mono#15666)

* Fix System.Runtime.InteropServices tests

* Update marshal.c

* Update marshal.c

* Update marshal.c

Commit migrated from https://github.com/mono/mono/commit/c36f0a126ecb41ba44bb57e098cb6cece8124d68

5 years agoMerge pull request mono/mono#16151 from spouliot/ios-intr-enable-sre
Zoltan Varga [Mon, 12 Aug 2019 18:44:54 +0000 (14:44 -0400)]
Merge pull request mono/mono#16151 from spouliot/ios-intr-enable-sre

[sdk] Enable the SRE runtime code inside iOS builds

Commit migrated from https://github.com/mono/mono/commit/5bc4944bf09ccf0a56a28c8e5a957d6001f51063

5 years ago[interp] Fix stub_get_resume_state write to out parameter (mono/mono#16145)
Aleksey Kliger (λgeek) [Mon, 12 Aug 2019 17:09:59 +0000 (13:09 -0400)]
[interp] Fix stub_get_resume_state write to out parameter (mono/mono#16145)

Addresses Coverity CID 1452245

Commit migrated from https://github.com/mono/mono/commit/ad64c781eba4e9fcbf104a64828cdf7fc1d910a3

5 years ago[netcore] Pass MONO_ASMCTX_LOADFROM on LoadFrom calls (mono/mono#16075)
Ryan Lucia [Mon, 12 Aug 2019 15:46:12 +0000 (11:46 -0400)]
[netcore] Pass MONO_ASMCTX_LOADFROM on LoadFrom calls (mono/mono#16075)

Commit migrated from https://github.com/mono/mono/commit/cadd114f6435e732d532733cd92db49c11fabc6c

5 years ago[msbuild] Bump to track xplat-master and update roslyn (mono/mono#16155)
Ankit Jain [Mon, 12 Aug 2019 15:03:13 +0000 (11:03 -0400)]
[msbuild] Bump to track xplat-master and update roslyn (mono/mono#16155)

Prompted by mono/msbuildmono/mono#126:

This includes:

- merge mono-2019-06
- SDK update to track dotnet release/3.0.100-preview8
- Roslyn updated to 3.3.0-beta2-19381-14

Commit migrated from https://github.com/mono/mono/commit/c028454befe4ab6f9bf59f90e4136fc197014216

5 years ago[debugger] Cleanup MonoError on in isFixedSizeArray (mono/mono#16146)
Aleksey Kliger (λgeek) [Mon, 12 Aug 2019 13:50:58 +0000 (09:50 -0400)]
[debugger] Cleanup MonoError on in isFixedSizeArray (mono/mono#16146)

Cleanup MonoError on error paths.  Also change `return FALSE` to `return 0`.

Addresses Coverity CID 1452205

Commit migrated from https://github.com/mono/mono/commit/dd3f6e0d31a055f616e42561383e0365c8fc6e4c

5 years ago[mono] Fix some compiler warnings (mono/mono#16159)
Nikolay Sivov [Mon, 12 Aug 2019 10:42:59 +0000 (13:42 +0300)]
[mono] Fix some compiler warnings (mono/mono#16159)

* [mini] Remove unused variables.

* [mini] Remove unused function.

Single call site is conditionally compiled.

* [sgen] Remove unused variable.

* [utils] Fix misleading indentation warnings.

Commit migrated from https://github.com/mono/mono/commit/612e0644b6a183d15e66a3761d995b5f8b837d4b

5 years ago[remoting+interp] [remoting+debugger] Fix use of dangling local. (mono/mono#16173)
Jay Krell [Mon, 12 Aug 2019 10:35:30 +0000 (03:35 -0700)]
[remoting+interp] [remoting+debugger] Fix use of dangling local. (mono/mono#16173)

Commit migrated from https://github.com/mono/mono/commit/c70b4cc3cc8ef19b9b5c25a96ad23421d1b65175

5 years ago[interp] Remove unnecessary loops, that optimizer might handle. (mono/mono#16169)
Jay Krell [Mon, 12 Aug 2019 10:34:46 +0000 (03:34 -0700)]
[interp] Remove unnecessary loops, that optimizer might handle. (mono/mono#16169)

Commit migrated from https://github.com/mono/mono/commit/4e5544f02de02eb72df30c3a94cc650c3768ad0d

5 years ago[w32process-win32] Don't duplicate CreateProcess search logic. (mono/mono#16156)
Vincent Povirk [Mon, 12 Aug 2019 10:05:05 +0000 (05:05 -0500)]
[w32process-win32] Don't duplicate CreateProcess search logic. (mono/mono#16156)

When given a null application name, CreateProcess already
searches the path and appends .exe in some cases. .NET's
Process class behaves in the same way (see
https://github.com/mono/mono/pull/16089#issuecomment-519984244).

The duplicated logic is unnecessary and broken in several ways.
Failures are ignored and the command line arguments are
executed. Relative paths are expected not to end in "exe".
Many corner cases work differently from .NET and CreateProcess.

This change makes it impossible for process_complete_path to fail,
so I removed the gboolean return and pulled out the output
parameter. Its caller wasn't handling the return value correctly
anyway.

Commit migrated from https://github.com/mono/mono/commit/7413bb84ec909502d922cb0b45d8d998f7e5d259

5 years agoMerge pull request mono/mono#16136 from EgorBo/fix-inlining
Zoltan Varga [Mon, 12 Aug 2019 02:32:01 +0000 (22:32 -0400)]
Merge pull request mono/mono#16136 from EgorBo/fix-inlining

[netcore] Fix inlining

Commit migrated from https://github.com/mono/mono/commit/835282004ca3f466f809a7440b7e79f189cc86cc

5 years ago[interp] Fix overflow of execution stack (mono/mono#16115)
Vlad Brezae [Fri, 9 Aug 2019 17:28:30 +0000 (20:28 +0300)]
[interp] Fix overflow of execution stack (mono/mono#16115)

We were not tracking max_stack_height for a few opcodes.

Commit migrated from https://github.com/mono/mono/commit/b52830cf1120bdeaf693080e22b3af87e3aef9e8