platform/upstream/libSkiaSharp.git
11 years agochange SkDrawFilter::filter to return a bool, where false means don't-draw
reed@google.com [Mon, 26 Nov 2012 20:26:54 +0000 (20:26 +0000)]
change SkDrawFilter::filter to return a bool, where false means don't-draw
Review URL: https://codereview.appspot.com/6851111

git-svn-id: http://skia.googlecode.com/svn/trunk@6551 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agomust always include another skia header (unless you're SkTypes.h). In this case,
reed@google.com [Mon, 26 Nov 2012 20:18:00 +0000 (20:18 +0000)]
must always include another skia header (unless you're SkTypes.h). In this case,
we need SkScalar.h earlier so we can be sure to have int32_t defined.

inspired by https://codereview.appspot.com/6782122/

git-svn-id: http://skia.googlecode.com/svn/trunk@6548 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agocheck for bad enum use when adding contours
reed@google.com [Mon, 26 Nov 2012 18:16:27 +0000 (18:16 +0000)]
check for bad enum use when adding contours
Review URL: https://codereview.appspot.com/6849103

git-svn-id: http://skia.googlecode.com/svn/trunk@6547 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove legacy build-guards, now that webkit has rebaselined these.
reed@google.com [Mon, 26 Nov 2012 16:47:10 +0000 (16:47 +0000)]
remove legacy build-guards, now that webkit has rebaselined these.

SK_DISABLE_FAST_AA_STROKE_RECT
SK_IGNORE_FAST_BLURRECT
SK_DISABLE_EXTRACTSUBSET_OPAQUE_FIX
SK_IGNORE_CF_OPTIMIZATION
SK_IGNORE_NEW_STROKERECT
SK_DISABLE_GPU_BLUR
SK_IGNORE_ROTATED_FREETYPE_FIX

The changes should all be:

remove code for #ifdef
remove guard for #ifndef
Review URL: https://codereview.appspot.com/6858073

git-svn-id: http://skia.googlecode.com/svn/trunk@6546 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agochoose correct blitrow proc based on global alpha
reed@google.com [Mon, 26 Nov 2012 14:39:50 +0000 (14:39 +0000)]
choose correct blitrow proc based on global alpha

fixes https://bugs.webkit.org/show_bug.cgi?id=103062
add gm to exercise this new fix

git-svn-id: http://skia.googlecode.com/svn/trunk@6544 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoVisualize bitmaps in debugger
robertphillips@google.com [Mon, 26 Nov 2012 13:09:17 +0000 (13:09 +0000)]
Visualize bitmaps in debugger

https://codereview.appspot.com/6847084/

git-svn-id: http://skia.googlecode.com/svn/trunk@6541 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Thu, 22 Nov 2012 02:02:41 +0000 (02:02 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@6540 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove GrRandom API in favor of SkRandom.
tfarina@chromium.org [Wed, 21 Nov 2012 22:38:36 +0000 (22:38 +0000)]
Remove GrRandom API in favor of SkRandom.

TEST=tests
R=bsalomon@google.com

Review URL: https://codereview.appspot.com/6855062

git-svn-id: http://skia.googlecode.com/svn/trunk@6539 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Wed, 21 Nov 2012 21:36:34 +0000 (21:36 +0000)]
shape ops work in progress

git-svn-id: http://skia.googlecode.com/svn/trunk@6537 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd self-test that reveals SkChecksum weakness
epoger@google.com [Wed, 21 Nov 2012 19:04:17 +0000 (19:04 +0000)]
Add self-test that reveals SkChecksum weakness
Review URL: https://codereview.appspot.com/6845064

git-svn-id: http://skia.googlecode.com/svn/trunk@6535 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixed some compilation problems with debugger with robertphillips
rmistry@google.com [Wed, 21 Nov 2012 18:37:58 +0000 (18:37 +0000)]
Fixed some compilation problems with debugger with robertphillips

git-svn-id: http://skia.googlecode.com/svn/trunk@6534 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd default: to fix warning
reed@google.com [Wed, 21 Nov 2012 18:34:15 +0000 (18:34 +0000)]
add default: to fix warning

git-svn-id: http://skia.googlecode.com/svn/trunk@6533 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd drawing of paths to debugger
robertphillips@google.com [Wed, 21 Nov 2012 17:11:02 +0000 (17:11 +0000)]
Add drawing of paths to debugger

https://codereview.appspot.com/6850082/

git-svn-id: http://skia.googlecode.com/svn/trunk@6532 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSimple change to remove unnecessary #define statement.
sugoi@google.com [Wed, 21 Nov 2012 16:44:45 +0000 (16:44 +0000)]
Simple change to remove unnecessary #define statement.

BUG=http://code.google.com/p/chromium/issues/detail?id=137924
TEST=TestDeferredCanvasBitmapSizeThreshold unit test
Review URL: https://codereview.appspot.com/6845071

git-svn-id: http://skia.googlecode.com/svn/trunk@6531 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix typo: must use modified join in case the miterlimit forces us to use bevel
reed@google.com [Wed, 21 Nov 2012 16:36:34 +0000 (16:36 +0000)]
fix typo: must use modified join in case the miterlimit forces us to use bevel

git-svn-id: http://skia.googlecode.com/svn/trunk@6530 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse direction from isRect in strokeRect, and only stroke if it is closed
reed@google.com [Wed, 21 Nov 2012 15:48:20 +0000 (15:48 +0000)]
use direction from isRect in strokeRect, and only stroke if it is closed
Review URL: https://codereview.appspot.com/6846086

git-svn-id: http://skia.googlecode.com/svn/trunk@6528 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDeferred canvas can now be flushed if an image is beyond a certain size to avoid...
sugoi@google.com [Wed, 21 Nov 2012 15:47:04 +0000 (15:47 +0000)]
Deferred canvas can now be flushed if an image is beyond a certain size to avoid a costly image copy.

BUG=http://code.google.com/p/chromium/issues/detail?id=137924
TEST=TestDeferredCanvasBitmapSizeThreshold unit test
Review URL: https://codereview.appspot.com/6852071

git-svn-id: http://skia.googlecode.com/svn/trunk@6527 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd isRect variant that returns path closure and direction.
caryclark@google.com [Wed, 21 Nov 2012 15:18:06 +0000 (15:18 +0000)]
Add isRect variant that returns path closure and direction.

Add path test to verify that when isRect() returns false,
output parameters are unchanged.
Review URL: https://codereview.appspot.com/6855074

git-svn-id: http://skia.googlecode.com/svn/trunk@6524 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agolimit the rects width/height as well as its coords, when avoiding too-large
reed@google.com [Wed, 21 Nov 2012 14:14:10 +0000 (14:14 +0000)]
limit the rects width/height as well as its coords, when avoiding too-large
rects for blur special-case.
Review URL: https://codereview.appspot.com/6850084

git-svn-id: http://skia.googlecode.com/svn/trunk@6523 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodetect wrapped rect in path
caryclark@google.com [Wed, 21 Nov 2012 13:56:20 +0000 (13:56 +0000)]
detect wrapped rect in path

Allow a rect to start in the middle of a span, and
wrap all the way around.

Initialize variable to suppress warning.

Add tests to detect rects constructed from a stroked
path.
Review URL: https://codereview.appspot.com/6847082

git-svn-id: http://skia.googlecode.com/svn/trunk@6522 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Wed, 21 Nov 2012 02:02:25 +0000 (02:02 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@6521 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd SK_IGNORE_NEW_STROKERECT guard
reed@google.com [Tue, 20 Nov 2012 23:01:35 +0000 (23:01 +0000)]
add SK_IGNORE_NEW_STROKERECT guard
temp workaround for bug in isRect when I'm stroking and the rect isn't closed.

git-svn-id: http://skia.googlecode.com/svn/trunk@6520 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix regression from 6510 -- respect kStrokeAndFill setting for stroked rects
reed@google.com [Tue, 20 Nov 2012 21:33:05 +0000 (21:33 +0000)]
fix regression from 6510 -- respect kStrokeAndFill setting for stroked rects

git-svn-id: http://skia.googlecode.com/svn/trunk@6516 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agotest for StrokeAndFill as well in this GM
reed@google.com [Tue, 20 Nov 2012 21:32:30 +0000 (21:32 +0000)]
test for StrokeAndFill as well in this GM

git-svn-id: http://skia.googlecode.com/svn/trunk@6515 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodetect gigantoid matrices, and do nothing to avoid wacky overflows from float -> int
reed@google.com [Tue, 20 Nov 2012 19:45:16 +0000 (19:45 +0000)]
detect gigantoid matrices, and do nothing to avoid wacky overflows from float -> int

https://code.google.com/p/chromium/issues/detail?id=156231
Review URL: https://codereview.appspot.com/6842075

git-svn-id: http://skia.googlecode.com/svn/trunk@6513 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCorrect A8 gamma on Mac.
bungeman@google.com [Tue, 20 Nov 2012 19:40:23 +0000 (19:40 +0000)]
Correct A8 gamma on Mac.
This fixes https://code.google.com/p/chromium/issues/detail?id=161728 .
https://codereview.appspot.com/6851086/

git-svn-id: http://skia.googlecode.com/svn/trunk@6511 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd specialty strokeRect() to SkStroke, which can return much cleaner results
reed@google.com [Tue, 20 Nov 2012 19:00:28 +0000 (19:00 +0000)]
add specialty strokeRect() to SkStroke, which can return much cleaner results
Review URL: https://codereview.appspot.com/6843093

git-svn-id: http://skia.googlecode.com/svn/trunk@6510 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdditional OpenType tables.
bungeman@google.com [Tue, 20 Nov 2012 18:52:23 +0000 (18:52 +0000)]
Additional OpenType tables.
https://codereview.appspot.com/6850075/

git-svn-id: http://skia.googlecode.com/svn/trunk@6509 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSeparable mask blurs: Add compile-time flag. Fix reversed offsets in asymmetrical...
senorblanco@chromium.org [Tue, 20 Nov 2012 17:09:40 +0000 (17:09 +0000)]
Separable mask blurs:  Add compile-time flag.  Fix reversed offsets in asymmetrical blurs (this bug cancels itself out, but I thought it might be confusing for future readers).  Use correct stride in asymmetrical blurs (this is a real bug).

Review URL: https://codereview.appspot.com/6782089

git-svn-id: http://skia.googlecode.com/svn/trunk@6508 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix clang warning in GMSampleView.h
tfarina@chromium.org [Tue, 20 Nov 2012 16:36:20 +0000 (16:36 +0000)]
Fix clang warning in GMSampleView.h

../../samplecode/GMSampleView.h:23:7: warning: field 'fGM' will be initialized after field 'fShowSize' [-Wreorder]

R=bsalomon@google.com

Review URL: https://codereview.appspot.com/6856063

git-svn-id: http://skia.googlecode.com/svn/trunk@6507 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd restore() to SkAutoCanvasRestore
reed@google.com [Tue, 20 Nov 2012 15:12:21 +0000 (15:12 +0000)]
add restore() to SkAutoCanvasRestore

git-svn-id: http://skia.googlecode.com/svn/trunk@6505 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Tue, 20 Nov 2012 14:21:54 +0000 (14:21 +0000)]
shape ops work in progress

git-svn-id: http://skia.googlecode.com/svn/trunk@6503 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Tue, 20 Nov 2012 02:01:23 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@6500 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReverting r6489 to fix compiler error in Chrome
robertphillips@google.com [Tue, 20 Nov 2012 01:40:45 +0000 (01:40 +0000)]
Reverting r6489 to fix compiler error in Chrome

143>  LINK : program database E:\b\build\slave\win_layout\build\src\build\Debug\ui.dll.pdb missing; performing full link
143>     Creating library ..\build\Debug\lib\ui.lib and object ..\build\Debug\lib\ui.exp
143>throb_animation.obj : error LNK2001: unresolved external symbol "private: static void (__cdecl*const * const SkMatrix::gMapXYProcs)(class SkMatrix const &,float,float,struct SkPoint *)" (?gMapXYProcs@SkMatrix@@0QBQ6AXABV1@MMPAUSkPoint@@@ZB)

etc

git-svn-id: http://skia.googlecode.com/svn/trunk@6499 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoskip very large rects (for now) until we can pre-clip them to avoid floating
reed@google.com [Mon, 19 Nov 2012 21:09:14 +0000 (21:09 +0000)]
skip very large rects (for now) until we can pre-clip them to avoid floating
point precision errors.

git-svn-id: http://skia.googlecode.com/svn/trunk@6497 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd SkMatrix44::setColMajord, etc.
vollick@chromium.org [Mon, 19 Nov 2012 21:02:06 +0000 (21:02 +0000)]
Add SkMatrix44::setColMajord, etc.

We have accessors for efficiently getting the matirx data, and it would be nice
if we had similar methods for setting the matrix entries.

Review URL: https://codereview.appspot.com/6851063

git-svn-id: http://skia.googlecode.com/svn/trunk@6494 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoBreakdown profile time by command type in the overview pane
robertphillips@google.com [Mon, 19 Nov 2012 20:44:29 +0000 (20:44 +0000)]
Breakdown profile time by command type in the overview pane

https://codereview.appspot.com/6851073/

git-svn-id: http://skia.googlecode.com/svn/trunk@6492 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd support for new glShaderSource() signature from Khronos. Disabled by default.
senorblanco@chromium.org [Mon, 19 Nov 2012 20:43:10 +0000 (20:43 +0000)]
Add support for new glShaderSource() signature from Khronos.  Disabled by default.

Review URL: https://codereview.appspot.com/6853068

git-svn-id: http://skia.googlecode.com/svn/trunk@6491 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd missing SK_API define.
tfarina@chromium.org [Mon, 19 Nov 2012 19:43:18 +0000 (19:43 +0000)]
Add missing SK_API define.

For a detailed explanation of this, please refer to Nico Weber description
here: https://chromiumcodereview.appspot.com/10386108

R=bsalomon@google.com

Review URL: https://codereview.appspot.com/6849075

git-svn-id: http://skia.googlecode.com/svn/trunk@6489 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd support for SkImageRef_ashmem.
djsollen@google.com [Mon, 19 Nov 2012 19:34:23 +0000 (19:34 +0000)]
Add support for SkImageRef_ashmem.

This requires copying the ashmem utility wrapper functions from a
private android library into our source tree in order to be NDK
compliant.

Review URL: https://codereview.appspot.com/6846076

git-svn-id: http://skia.googlecode.com/svn/trunk@6488 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded Reload icon
robertphillips@google.com [Mon, 19 Nov 2012 18:25:09 +0000 (18:25 +0000)]
Added Reload icon

https://codereview.appspot.com/6849079/

git-svn-id: http://skia.googlecode.com/svn/trunk@6486 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd original resources back and update code to match
robertphillips@google.com [Mon, 19 Nov 2012 17:39:18 +0000 (17:39 +0000)]
Add original resources back and update code to match

https://codereview.appspot.com/6842061/

git-svn-id: http://skia.googlecode.com/svn/trunk@6484 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse SkPath::isNestedRects() to apply blurred nine-patch
reed@google.com [Mon, 19 Nov 2012 16:45:14 +0000 (16:45 +0000)]
use SkPath::isNestedRects() to apply blurred nine-patch
Review URL: https://codereview.appspot.com/6855063

git-svn-id: http://skia.googlecode.com/svn/trunk@6483 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix a memory leak in skdiff that happens when the
scroggo@google.com [Mon, 19 Nov 2012 16:30:08 +0000 (16:30 +0000)]
Fix a memory leak in skdiff that happens when the
directories do not contain the same files.

Only create the bitmaps when we need to use them.

Review URL: https://codereview.appspot.com/6850066

git-svn-id: http://skia.googlecode.com/svn/trunk@6481 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years ago3 minor fixes for debugger
robertphillips@google.com [Mon, 19 Nov 2012 16:26:40 +0000 (16:26 +0000)]
3 minor fixes for debugger

https://codereview.appspot.com/6842062/

git-svn-id: http://skia.googlecode.com/svn/trunk@6480 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agomodify gm to have a non-uniform donut for testing
reed@google.com [Mon, 19 Nov 2012 16:14:02 +0000 (16:14 +0000)]
modify gm to have a non-uniform donut for testing

git-svn-id: http://skia.googlecode.com/svn/trunk@6477 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoProtect against unref/ref of stencil buffer.
bsalomon@google.com [Mon, 19 Nov 2012 14:36:31 +0000 (14:36 +0000)]
Protect against unref/ref of stencil buffer.

Over the shoulder review from robertphillips@google.com

git-svn-id: http://skia.googlecode.com/svn/trunk@6476 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd two nested rect detector to path
caryclark@google.com [Mon, 19 Nov 2012 13:06:06 +0000 (13:06 +0000)]
add two nested rect detector to path

Tease apart existing one rect path detector so
that a new variant can detect two nested rects as well.

Add tests to verify that both one and two rect
detectors both work and return the correct results.

Suppress other warnings in PathTest.
Review URL: https://codereview.appspot.com/6850059

git-svn-id: http://skia.googlecode.com/svn/trunk@6475 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert r6469, "Turn on separable blur."
senorblanco@chromium.org [Sat, 17 Nov 2012 15:08:29 +0000 (15:08 +0000)]
Revert r6469, "Turn on separable blur."

git-svn-id: http://skia.googlecode.com/svn/trunk@6474 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Sat, 17 Nov 2012 02:01:23 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@6473 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to trigger rebuild after network hiccup
borenet@google.com [Fri, 16 Nov 2012 22:26:33 +0000 (22:26 +0000)]
Whitespace change to trigger rebuild after network hiccup

git-svn-id: http://skia.googlecode.com/svn/trunk@6472 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoIn SkBitmapHeap, defer adding owners for new bitmaps.
scroggo@google.com [Fri, 16 Nov 2012 20:34:37 +0000 (20:34 +0000)]
In SkBitmapHeap, defer adding owners for new bitmaps.

When using an SkFlatDictionary to flatten shaders, the
dictionary can try to insert a duplicate bitmap shader
that uses a bitmap which has been removed from the
bitmap heap.

This change was originally suggested by junov in
https://codereview.appspot.com/6713048/.

Add a test to verify that deferring the owners works.
Without the change to bitmap heap the test would fail
(and crash in debug mode).

Also remove an unused function from SkFlatDictionary.

BUG=http://code.google.com/p/chromium/issues/detail?id=143923

Review URL: https://codereview.appspot.com/6842051

git-svn-id: http://skia.googlecode.com/svn/trunk@6471 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Fri, 16 Nov 2012 20:16:50 +0000 (20:16 +0000)]
shape ops work in progress

git-svn-id: http://skia.googlecode.com/svn/trunk@6470 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTurn on separable blur.
senorblanco@chromium.org [Fri, 16 Nov 2012 19:26:22 +0000 (19:26 +0000)]
Turn on separable blur.

git-svn-id: http://skia.googlecode.com/svn/trunk@6469 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoExtract transform_scanline_XXXX functions into transform_scanline.h for code-sharing
epoger@google.com [Fri, 16 Nov 2012 18:44:18 +0000 (18:44 +0000)]
Extract transform_scanline_XXXX functions into transform_scanline.h for code-sharing
Review URL: https://codereview.appspot.com/6849065

git-svn-id: http://skia.googlecode.com/svn/trunk@6468 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Fri, 16 Nov 2012 18:15:12 +0000 (18:15 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@6466 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSeparable blur: subpixel blurring. We approximate intermediate values of blur for...
senorblanco@chromium.org [Fri, 16 Nov 2012 17:22:33 +0000 (17:22 +0000)]
Separable blur:  subpixel blurring.  We approximate intermediate values of blur for even kernel sizes by using a kernel of size N offset to the left in the first pass, a kernel of size N offset to the right in the second pass, and a centered kernel of size N + 1 in the third pass.  This required adding support for asymmetrical radii to the box blur.

Since this can only be done in the 3-pass blur for separable blurs, we turn off the optimization that drops to low quality for blurs of < 3 pixels.

Review URL: https://codereview.appspot.com/6843072

git-svn-id: http://skia.googlecode.com/svn/trunk@6464 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse correct blend proc instead of fourbyteinterp, since the src may not be opaque
reed@google.com [Fri, 16 Nov 2012 14:46:00 +0000 (14:46 +0000)]
use correct blend proc instead of fourbyteinterp, since the src may not be opaque
fixes DumpRenderTree failure

git-svn-id: http://skia.googlecode.com/svn/trunk@6457 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoflag the GM if we're in deferred-canvas mode, to work-around bug trying to
reed@google.com [Fri, 16 Nov 2012 13:41:45 +0000 (13:41 +0000)]
flag the GM if we're in deferred-canvas mode, to work-around bug trying to
get the context from its device.

git-svn-id: http://skia.googlecode.com/svn/trunk@6452 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofold kClear_Mode into kSrc_Mode, and make kSrc_Mode go faster
reed@google.com [Fri, 16 Nov 2012 13:20:41 +0000 (13:20 +0000)]
fold kClear_Mode into kSrc_Mode, and make kSrc_Mode go faster
Review URL: https://codereview.appspot.com/6851054

git-svn-id: http://skia.googlecode.com/svn/trunk@6451 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape op work in progress
caryclark@google.com [Fri, 16 Nov 2012 13:16:41 +0000 (13:16 +0000)]
shape op work in progress

git-svn-id: http://skia.googlecode.com/svn/trunk@6450 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse #if SK_SUPPORT_GPU to guard references to gpudevice
mike@reedtribe.org [Fri, 16 Nov 2012 02:31:03 +0000 (02:31 +0000)]
use #if SK_SUPPORT_GPU to guard references to gpudevice

git-svn-id: http://skia.googlecode.com/svn/trunk@6449 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse gpu surface to match canvas
mike@reedtribe.org [Fri, 16 Nov 2012 02:23:10 +0000 (02:23 +0000)]
use gpu surface to match canvas

change gm to reset shader when we start antialiasing

git-svn-id: http://skia.googlecode.com/svn/trunk@6448 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Fri, 16 Nov 2012 02:01:17 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@6447 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReorder the separable blur passes into XXX/YYY, with an image transpose on the last...
senorblanco@chromium.org [Thu, 15 Nov 2012 20:27:35 +0000 (20:27 +0000)]
Reorder the separable blur passes into XXX/YYY, with an image transpose on the last pass of each group.  This results in continuguous memory reads in all passes, giving a 22% speedup on theverge.skp over the previous separable implementation, and a 30%-50% improvement over the existing implementation (depending on platform).

Review URL: https://codereview.appspot.com/6851053

git-svn-id: http://skia.googlecode.com/svn/trunk@6445 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoneed this for prev. cl
reed@google.com [Thu, 15 Nov 2012 19:52:20 +0000 (19:52 +0000)]
need this for prev. cl

git-svn-id: http://skia.googlecode.com/svn/trunk@6444 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd bench for srcmode
reed@google.com [Thu, 15 Nov 2012 19:52:07 +0000 (19:52 +0000)]
add bench for srcmode

git-svn-id: http://skia.googlecode.com/svn/trunk@6443 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse DEF_BENCH() macro to clean up factory registrations -- no other change
reed@google.com [Thu, 15 Nov 2012 18:06:00 +0000 (18:06 +0000)]
use DEF_BENCH() macro to clean up factory registrations -- no other change

git-svn-id: http://skia.googlecode.com/svn/trunk@6442 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodraw offscreen so we can see the alpha-channel we are writing
reed@google.com [Thu, 15 Nov 2012 17:24:23 +0000 (17:24 +0000)]
draw offscreen so we can see the alpha-channel we are writing
todo: know when to use a gpu-surface

git-svn-id: http://skia.googlecode.com/svn/trunk@6436 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix debugger crash when SK_PICTURE_PROFILING_STUBS isn't defined
robertphillips@google.com [Thu, 15 Nov 2012 16:33:31 +0000 (16:33 +0000)]
Fix debugger crash when SK_PICTURE_PROFILING_STUBS isn't defined

https://codereview.appspot.com/6850060/

git-svn-id: http://skia.googlecode.com/svn/trunk@6433 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agowhitespace
epoger@google.com [Thu, 15 Nov 2012 16:32:15 +0000 (16:32 +0000)]
whitespace

git-svn-id: http://skia.googlecode.com/svn/trunk@6432 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoupdate srcmode GM to include aa/bw and gradients
reed@google.com [Thu, 15 Nov 2012 15:56:38 +0000 (15:56 +0000)]
update srcmode GM to include aa/bw and gradients
add 'G' key to sampleapp, to toggle showing the GM's bounds as an overlay

git-svn-id: http://skia.googlecode.com/svn/trunk@6431 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd profiling to debugger
robertphillips@google.com [Thu, 15 Nov 2012 14:57:57 +0000 (14:57 +0000)]
Add profiling to debugger

https://codereview.appspot.com/6817114/

git-svn-id: http://skia.googlecode.com/svn/trunk@6430 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd gm for srcmode (and clearmode) in prep for optimization work
reed@google.com [Thu, 15 Nov 2012 13:46:47 +0000 (13:46 +0000)]
add gm for srcmode (and clearmode) in prep for optimization work

git-svn-id: http://skia.googlecode.com/svn/trunk@6429 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove (unused) debugging global
reed@google.com [Thu, 15 Nov 2012 13:19:17 +0000 (13:19 +0000)]
remove (unused) debugging global

git-svn-id: http://skia.googlecode.com/svn/trunk@6428 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove unused (and undefined) SkColorSpace parameter.
mike@reedtribe.org [Thu, 15 Nov 2012 02:37:45 +0000 (02:37 +0000)]
remove unused (and undefined) SkColorSpace parameter.

git-svn-id: http://skia.googlecode.com/svn/trunk@6427 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agosilence excessive printf noise from SkScalerContext_FreeType::generateMetrics for...
mike@reedtribe.org [Thu, 15 Nov 2012 02:12:14 +0000 (02:12 +0000)]
silence excessive printf noise from SkScalerContext_FreeType::generateMetrics for glyph out-of-range.

git-svn-id: http://skia.googlecode.com/svn/trunk@6426 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Thu, 15 Nov 2012 02:01:17 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@6425 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd SkMatrix44::setTranspose
vollick@chromium.org [Wed, 14 Nov 2012 21:33:55 +0000 (21:33 +0000)]
Add SkMatrix44::setTranspose

It turned out that adding getDouble(...) and setDouble(...) made this change
easier, so I've included that in this cl as well.

Review URL: https://codereview.appspot.com/6845048

git-svn-id: http://skia.googlecode.com/svn/trunk@6424 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Wed, 14 Nov 2012 21:14:56 +0000 (21:14 +0000)]
shape ops work in progress

binary ops work for simple coincident case

git-svn-id: http://skia.googlecode.com/svn/trunk@6422 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove a warning for comparing signed and unsigned integers.
scroggo@google.com [Wed, 14 Nov 2012 21:08:53 +0000 (21:08 +0000)]
Remove a warning for comparing signed and unsigned integers.

Review URL: https://codereview.appspot.com/6851050

git-svn-id: http://skia.googlecode.com/svn/trunk@6420 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agomove setDevice() to protected: in preparation for its eventual demise
reed@google.com [Wed, 14 Nov 2012 19:07:24 +0000 (19:07 +0000)]
move setDevice() to protected: in preparation for its eventual demise

git-svn-id: http://skia.googlecode.com/svn/trunk@6416 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agomark SkCanvas::setDevice as DEPRECATED -- need to remove all callers in chrome
reed@google.com [Wed, 14 Nov 2012 14:40:07 +0000 (14:40 +0000)]
mark SkCanvas::setDevice as DEPRECATED -- need to remove all callers in chrome

git-svn-id: http://skia.googlecode.com/svn/trunk@6414 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Wed, 14 Nov 2012 02:01:22 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@6413 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd a conservativelyContainsRect function to SkPath.
bsalomon@google.com [Tue, 13 Nov 2012 21:51:38 +0000 (21:51 +0000)]
Add a conservativelyContainsRect function to SkPath.
Review URL: https://codereview.appspot.com/6852044

git-svn-id: http://skia.googlecode.com/svn/trunk@6411 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Tue, 13 Nov 2012 21:46:06 +0000 (21:46 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@6409 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agocomment-only change to gm/tests/run.sh
epoger@google.com [Tue, 13 Nov 2012 20:46:50 +0000 (20:46 +0000)]
comment-only change to gm/tests/run.sh

git-svn-id: http://skia.googlecode.com/svn/trunk@6407 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoBuild fix. Unreviewed.
senorblanco@chromium.org [Tue, 13 Nov 2012 20:41:43 +0000 (20:41 +0000)]
Build fix.  Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@6406 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAllow SkPicture-derived classes install their own SkPicturePlayback-derived object
robertphillips@google.com [Tue, 13 Nov 2012 20:41:18 +0000 (20:41 +0000)]
Allow SkPicture-derived classes install their own SkPicturePlayback-derived object

https://codereview.appspot.com/6851048/

git-svn-id: http://skia.googlecode.com/svn/trunk@6405 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoA new implementation of mask blurs, using separable X/Y passes. Disabled for now.
senorblanco@chromium.org [Tue, 13 Nov 2012 20:35:21 +0000 (20:35 +0000)]
A new implementation of mask blurs, using separable X/Y passes.  Disabled for now.

Review URL: https://codereview.appspot.com/6826086

git-svn-id: http://skia.googlecode.com/svn/trunk@6404 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd support for SK_MSCALAR_IS_FLOAT
vollick@chromium.org [Tue, 13 Nov 2012 20:12:00 +0000 (20:12 +0000)]
Add support for SK_MSCALAR_IS_FLOAT

The default is SK_MSCALAR_IS_FLOAT. You'll have to explicitly define SK_MSCALAR_IS_DOUBLE if that's what you want.

BUG=None

Review URL: https://codereview.appspot.com/6843049

git-svn-id: http://skia.googlecode.com/svn/trunk@6403 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdate filter tool to allow input directory.
djsollen@google.com [Tue, 13 Nov 2012 18:50:33 +0000 (18:50 +0000)]
Update filter tool to allow input directory.

Review URL: https://codereview.appspot.com/6847046

git-svn-id: http://skia.googlecode.com/svn/trunk@6399 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix linux compiler error with the debugger app.
djsollen@google.com [Tue, 13 Nov 2012 18:35:10 +0000 (18:35 +0000)]
Fix linux compiler error with the debugger app.

Review URL: https://codereview.appspot.com/6848045

git-svn-id: http://skia.googlecode.com/svn/trunk@6398 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded profiling stubs to SkPicturePlayback
robertphillips@google.com [Tue, 13 Nov 2012 18:28:06 +0000 (18:28 +0000)]
Added profiling stubs to SkPicturePlayback

https://codereview.appspot.com/6851044/

git-svn-id: http://skia.googlecode.com/svn/trunk@6397 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoChanging the visibility of SkMatrix44::determinant().
vollick@chromium.org [Tue, 13 Nov 2012 15:08:22 +0000 (15:08 +0000)]
Changing the visibility of SkMatrix44::determinant().

Review URL: https://codereview.appspot.com/6819080

git-svn-id: http://skia.googlecode.com/svn/trunk@6395 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake SkPath cache the result of cheapComputeDirection.
bsalomon@google.com [Tue, 13 Nov 2012 14:36:42 +0000 (14:36 +0000)]
Make SkPath cache the result of cheapComputeDirection.
Review URL: https://codereview.appspot.com/6810111

git-svn-id: http://skia.googlecode.com/svn/trunk@6394 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemoving files accidently submitted by Skia_Periodic_House_Keeping
rmistry@google.com [Tue, 13 Nov 2012 14:23:14 +0000 (14:23 +0000)]
Removing files accidently submitted by Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@6392 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd tests for degenerate serifs to computeDirection
reed@google.com [Tue, 13 Nov 2012 13:47:39 +0000 (13:47 +0000)]
add tests for degenerate serifs to computeDirection

git-svn-id: http://skia.googlecode.com/svn/trunk@6391 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMaintain failedTests list within GMMain object
epoger@google.com [Tue, 13 Nov 2012 03:41:55 +0000 (03:41 +0000)]
Maintain failedTests list within GMMain object
Review URL: https://codereview.appspot.com/6819121

git-svn-id: http://skia.googlecode.com/svn/trunk@6390 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Tue, 13 Nov 2012 02:01:55 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@6389 2bbb7eff-a529-9590-31e7-b0007b416f81