platform/upstream/libSkiaSharp.git
10 years agoChanged JSON formatting more, workaround bug where SkStringPrintf causes encoding...
commit-bot@chromium.org [Tue, 20 May 2014 17:35:10 +0000 (17:35 +0000)]
Changed JSON formatting more, workaround bug where SkStringPrintf causes encoding issues

BUG=skia:
R=bensong@google.com, jcgregorio@google.com, reed@google.com, bsalomon@google.com

Author: kelvinly@google.com

Review URL: https://codereview.chromium.org/294093002

git-svn-id: http://skia.googlecode.com/svn/trunk@14808 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoformalize named picture versions
commit-bot@chromium.org [Tue, 20 May 2014 17:31:08 +0000 (17:31 +0000)]
formalize named picture versions

BUG=skia:
R=mtklein@google.com, robertphillips@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/291913004

git-svn-id: http://skia.googlecode.com/svn/trunk@14807 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert ""Revert of eliminate config param -- it was always self's config (https:...
commit-bot@chromium.org [Tue, 20 May 2014 17:08:12 +0000 (17:08 +0000)]
Revert ""Revert of eliminate config param -- it was always self's config (https://codereview.chromium.org/246513002/)"""

This reverts commit 3dbceb4f8283b2fb1728d0daf010d036099a2eae.

BUG=skia:
R=bsalomon@google.com, robertphillips@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/291163005

git-svn-id: http://skia.googlecode.com/svn/trunk@14806 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaseline poppler (for me) and pictureshader/bleed on GPU (for Brian).
commit-bot@chromium.org [Tue, 20 May 2014 17:05:45 +0000 (17:05 +0000)]
Rebaseline poppler (for me) and pictureshader/bleed on GPU (for Brian).

BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/284313009

git-svn-id: http://skia.googlecode.com/svn/trunk@14805 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd function to get both min and max scale factors from matrix
commit-bot@chromium.org [Tue, 20 May 2014 17:02:03 +0000 (17:02 +0000)]
Add function to get both min and max scale factors from matrix

R=reed@google.com, jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/298473002

git-svn-id: http://skia.googlecode.com/svn/trunk@14804 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of SSE2 everywhere. (https://codereview.chromium.org/294963002/)
commit-bot@chromium.org [Tue, 20 May 2014 15:27:35 +0000 (15:27 +0000)]
Revert of SSE2 everywhere. (https://codereview.chromium.org/294963002/)

Reason for revert:
Making GM run fewer tests than expected?

Original issue's description:
> SSE2 everywhere.
>
> As of M35, Chrome will require SSE2 on Linux (it already did on Windows, and
> requires SSSE3 on Macs).  Android already requires SSE2 for x86 chips.
>
> This effectively just forces it on for 32-bit Linux builds; everyone else already had it.
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14800

R=reed@google.com, mtklein@chromium.org
TBR=mtklein@chromium.org, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/282093015

git-svn-id: http://skia.googlecode.com/svn/trunk@14803 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSince we're only using it on Linux now, just require poppler as a system dependency.
commit-bot@chromium.org [Tue, 20 May 2014 15:07:53 +0000 (15:07 +0000)]
Since we're only using it on Linux now, just require poppler as a system dependency.

The Ubuntu package needed is libpoppler-cpp-dev.

iconv and fontconfig were only used as Poppler dependencies.  bson_c is also unused.

BUG=skia:
R=reed@google.com, rmistry@google.com, borenet@google.com, halcanary@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/294683003

git-svn-id: http://skia.googlecode.com/svn/trunk@14802 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoPreserve GrContext's matrix when calling SkShader::asNewEffect.
commit-bot@chromium.org [Tue, 20 May 2014 15:06:29 +0000 (15:06 +0000)]
Preserve GrContext's matrix when calling SkShader::asNewEffect.

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/298713002

git-svn-id: http://skia.googlecode.com/svn/trunk@14801 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSSE2 everywhere.
commit-bot@chromium.org [Tue, 20 May 2014 14:54:09 +0000 (14:54 +0000)]
SSE2 everywhere.

As of M35, Chrome will require SSE2 on Linux (it already did on Windows, and
requires SSSE3 on Macs).  Android already requires SSE2 for x86 chips.

This effectively just forces it on for 32-bit Linux builds; everyone else already had it.

BUG=skia:
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/294963002

git-svn-id: http://skia.googlecode.com/svn/trunk@14800 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd Memcpy32 bench.
commit-bot@chromium.org [Tue, 20 May 2014 14:54:04 +0000 (14:54 +0000)]
Add Memcpy32 bench.

This compares 32-bit copies using memcpy, autovectorization, and when SSE2 is
available, aligned and unaligned SSE2.

Running this on my desktop (Intel(R) Xeon(R) CPU E5-2690 0 @ 2.90GHz), I see
all four perform essentially the same, except Clang's autovectorization looks
 a little better than GCC's.  memcpy is calling libc 2.19's __memcpy_sse2_unaligned.

BUG=skia:
R=reed@google.com, qiankun.miao@intel.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/290533002

git-svn-id: http://skia.googlecode.com/svn/trunk@14799 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRename SkMatrix::get(Max|Min)Stretch to get(Min|Max)Scale
commit-bot@chromium.org [Tue, 20 May 2014 14:53:45 +0000 (14:53 +0000)]
Rename SkMatrix::get(Max|Min)Stretch to get(Min|Max)Scale

R=reed@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/295713002

git-svn-id: http://skia.googlecode.com/svn/trunk@14798 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRemove legacy constructor for blur draw looper.
commit-bot@chromium.org [Tue, 20 May 2014 14:53:32 +0000 (14:53 +0000)]
Remove legacy constructor for blur draw looper.

Now that Android no longer uses the constructor, remove it, along
with the flag.

R=djsollen@google.com, reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/299683002

git-svn-id: http://skia.googlecode.com/svn/trunk@14797 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaselines for gpu dashing
commit-bot@chromium.org [Tue, 20 May 2014 13:43:34 +0000 (13:43 +0000)]
Rebaselines for gpu dashing
NOTREECHECKS=True
NOTRY=True
R=bsalomon@google.com
TBR=bsalomon@google.com
BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/291893004

git-svn-id: http://skia.googlecode.com/svn/trunk@14796 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years ago"Revert of eliminate config param -- it was always self's config (https://codereview...
reed@google.com [Tue, 20 May 2014 12:39:37 +0000 (12:39 +0000)]
"Revert of eliminate config param -- it was always self's config (https://codereview.chromium.org/246513002/)""

This reverts commit 65b9f33cab9f53821720f982667412e56a340093.

git-svn-id: http://skia.googlecode.com/svn/trunk@14795 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agobench rebase after 3b9e8be
commit-bot@chromium.org [Tue, 20 May 2014 11:58:08 +0000 (11:58 +0000)]
bench rebase after 3b9e8be
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true

Author: bensong@google.com

Review URL: https://codereview.chromium.org/289283005

git-svn-id: http://skia.googlecode.com/svn/trunk@14794 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Tue, 20 May 2014 03:05:34 +0000 (03:05 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@14793 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd missing include in SkBlurImage optimization
commit-bot@chromium.org [Mon, 19 May 2014 23:07:56 +0000 (23:07 +0000)]
Add missing include in SkBlurImage optimization

Adds the missing include for smmintrin.h in the
SkBlurImage_opts_SSE2.cpp file.

Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
BUG=chromium:374796
TEST=Unknown
R=tomhudson@chromium.org, vapier@chromium.org, reed@chromium.org, bsalomon@chromium.org, dgreid@chromium.org, dgarrett@chromium.org, michaelpg@chromium.org, vandebo@chromium.org

Author: henrik.smiding@intel.com

Review URL: https://codereview.chromium.org/290923002

git-svn-id: http://skia.googlecode.com/svn/trunk@14792 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUpdate valgrind suppression file
commit-bot@chromium.org [Mon, 19 May 2014 21:06:01 +0000 (21:06 +0000)]
Update valgrind suppression file

BUG=skia:
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/292453010

git-svn-id: http://skia.googlecode.com/svn/trunk@14791 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoPass in GrContext instead of SkGpuDevice for dashing and Sk2GrPaint conversion
commit-bot@chromium.org [Mon, 19 May 2014 19:35:57 +0000 (19:35 +0000)]
Pass in GrContext instead of SkGpuDevice for dashing and Sk2GrPaint conversion

BUG=skia:
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/292773002

git-svn-id: http://skia.googlecode.com/svn/trunk@14790 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix utf32 text in subpixel mode
commit-bot@chromium.org [Mon, 19 May 2014 19:04:02 +0000 (19:04 +0000)]
fix utf32 text in subpixel mode

BUG=skia:2568
R=scroggo@google.com, anders@kilohearts.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/290893003

git-svn-id: http://skia.googlecode.com/svn/trunk@14789 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix off-by-one error in texture coordinate calculations for rrect gpu
commit-bot@chromium.org [Mon, 19 May 2014 18:51:05 +0000 (18:51 +0000)]
fix off-by-one error in texture coordinate calculations for rrect gpu
blur; output now matches CPU

BUG=
R=bsalomon@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/292773003

git-svn-id: http://skia.googlecode.com/svn/trunk@14788 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agobench rebase after 71db882
commit-bot@chromium.org [Mon, 19 May 2014 18:19:21 +0000 (18:19 +0000)]
bench rebase after 71db882
R=robertphillips@google.com, fmalita@google.com
TBR=robertphillips@google.com
NOTRY=true

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/299453002

git-svn-id: http://skia.googlecode.com/svn/trunk@14787 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd gzip encoding responses.
commit-bot@chromium.org [Mon, 19 May 2014 17:38:52 +0000 (17:38 +0000)]
Add gzip encoding responses.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/298433002

git-svn-id: http://skia.googlecode.com/svn/trunk@14786 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert "Revert of eliminate config param -- it was always self's config (https:/...
commit-bot@chromium.org [Mon, 19 May 2014 17:29:16 +0000 (17:29 +0000)]
Revert "Revert of eliminate config param -- it was always self's config (https://codereview.chromium.org/246513002/)"

TBR=bsalomon@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/290883005

git-svn-id: http://skia.googlecode.com/svn/trunk@14785 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoChanged JSON formatting to fit BigQuery requirements
commit-bot@chromium.org [Mon, 19 May 2014 17:29:01 +0000 (17:29 +0000)]
Changed JSON formatting to fit BigQuery requirements

BUG=skia:
R=bensong@google.com, jcgregorio@google.com

Author: kelvinly@google.com

Review URL: https://codereview.chromium.org/290903002

git-svn-id: http://skia.googlecode.com/svn/trunk@14784 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMove zooming into its own component, imported via HTML Imports.
commit-bot@chromium.org [Mon, 19 May 2014 16:40:08 +0000 (16:40 +0000)]
Move zooming into its own component, imported via HTML Imports.

Also, start building our own polyfill library (polyfill.js) using Grunt and Bower.

Finally, refactor all the web pages so that the common header and footer material comes from templates.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/292433002

git-svn-id: http://skia.googlecode.com/svn/trunk@14783 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoTry out SkMatrix::Concat.
commit-bot@chromium.org [Mon, 19 May 2014 15:51:12 +0000 (15:51 +0000)]
Try out SkMatrix::Concat.

This should RVO to the same as doing it on the stack with setConcat.

BUG=skia:
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/293693002

git-svn-id: http://skia.googlecode.com/svn/trunk@14782 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agogradient api sans (deprecated) unitmapper
commit-bot@chromium.org [Mon, 19 May 2014 15:46:09 +0000 (15:46 +0000)]
gradient api sans (deprecated) unitmapper

BUG=skia:
R=robertphillips@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/293643004

git-svn-id: http://skia.googlecode.com/svn/trunk@14781 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agobench rebase after 8216506
commit-bot@chromium.org [Mon, 19 May 2014 15:44:50 +0000 (15:44 +0000)]
bench rebase after 8216506
R=robertphillips@google.com, fmalita@google.com
TBR=robertphillips@google.com
NOTRY=true

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/289413003

git-svn-id: http://skia.googlecode.com/svn/trunk@14780 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agomake render_pictures properly handle empty expectations file
commit-bot@chromium.org [Mon, 19 May 2014 15:25:10 +0000 (15:25 +0000)]
make render_pictures properly handle empty expectations file

note that this changes the parameters taken by ImageResultsAndExpectations::Parse()

BUG=skia:1942
R=scroggo@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/289063010

git-svn-id: http://skia.googlecode.com/svn/trunk@14779 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDon't clobber initial transform with SetMatrix.
commit-bot@chromium.org [Mon, 19 May 2014 15:15:24 +0000 (15:15 +0000)]
Don't clobber initial transform with SetMatrix.

BUG=skia:2378
R=reed@google.com, mtklein@google.com, robertphillips@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/290883004

git-svn-id: http://skia.googlecode.com/svn/trunk@14778 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoReal fix for Widnows build errors for GrDashingEffect
commit-bot@chromium.org [Mon, 19 May 2014 14:59:04 +0000 (14:59 +0000)]
Real fix for Widnows build errors for GrDashingEffect
NOTREECHECKS=True
NOTRY=True
R=bsalomon@google.com
TBR=bsalomon@google.com
BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/291903002

git-svn-id: http://skia.googlecode.com/svn/trunk@14777 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix build error for windows for Dashing CL
commit-bot@chromium.org [Mon, 19 May 2014 14:43:45 +0000 (14:43 +0000)]
Fix build error for windows for Dashing CL
NOTREECHECKS=True
NOTRY=True
R=bsalomon@google.com
TBR=bsalomon@google.com
BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/291803004

git-svn-id: http://skia.googlecode.com/svn/trunk@14776 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd Dashing gpu effect for simple dashed lines
commit-bot@chromium.org [Mon, 19 May 2014 14:32:49 +0000 (14:32 +0000)]
Add Dashing gpu effect for simple dashed lines

BUG=skia:
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/274673004

git-svn-id: http://skia.googlecode.com/svn/trunk@14775 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoThis adds a checkbox to the debugger to allow seeing the effect pathops has on the...
commit-bot@chromium.org [Mon, 19 May 2014 13:53:10 +0000 (13:53 +0000)]
This adds a checkbox to the debugger to allow seeing the effect pathops has on the clip. A new tab shows the C code that the pathops generate.

Once in place, this CL found a bug in the pathops code where it was not handling empty clip stack elements correctly. The Cl also has the change to SkCanvas to fix this bug.

R=robertphillips@google.com, reed@google.com

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/282283002

git-svn-id: http://skia.googlecode.com/svn/trunk@14774 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd choke point for performing a fake endRecording
commit-bot@chromium.org [Mon, 19 May 2014 12:36:15 +0000 (12:36 +0000)]
Add choke point for performing a fake endRecording

My goal here was to add a single location where we could patch up the created PicturePlayback. Unfortunately, the complexity of the recording process (e.g., the BBH) makes this quite complex.

I will investigate altering the behavior of SkPicturePlayback to account for a potentially unbalanced set of saves/saveLayers.

R=reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/283333007

git-svn-id: http://skia.googlecode.com/svn/trunk@14773 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoEnsure playing back a picture always balances saves and restores
commit-bot@chromium.org [Mon, 19 May 2014 12:26:58 +0000 (12:26 +0000)]
Ensure playing back a picture always balances saves and restores

This "fixes" the legacy interface's possible creation of pictures with unbalanced save/restores.

The Android dox will need to be updated once/if this lands.

R=reed@google.com, scroggo@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/286033005

git-svn-id: http://skia.googlecode.com/svn/trunk@14772 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix generation tests.
commit-bot@chromium.org [Fri, 16 May 2014 19:48:57 +0000 (19:48 +0000)]
Fix generation tests.

R=epoger@google.com
TBR=epoger
NOTRY=true

BUG=skia:2565

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/284313007

git-svn-id: http://skia.googlecode.com/svn/trunk@14771 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agomake buildbot_globals.py read global_variables.json file from googlesource
commit-bot@chromium.org [Fri, 16 May 2014 19:19:31 +0000 (19:19 +0000)]
make buildbot_globals.py read global_variables.json file from googlesource

BUG=skia:2564
NOTRY=True
R=borenet@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/291563008

git-svn-id: http://skia.googlecode.com/svn/trunk@14770 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix windows build.
commit-bot@chromium.org [Fri, 16 May 2014 18:27:11 +0000 (18:27 +0000)]
Fix windows build.

Windows won't let me insert #ifdefs inside macro expansion.

R=borenet@google.com
TBR=borenet
NOTRY=true

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/289853003

git-svn-id: http://skia.googlecode.com/svn/trunk@14769 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoGenerate Android.mk for DM.
commit-bot@chromium.org [Fri, 16 May 2014 18:11:51 +0000 (18:11 +0000)]
Generate Android.mk for DM.

ifdef out code that won't build where we don't have jsoncpp.

Include ctype instead of string.h for tolower.

Depends on https://codereview.chromium.org/282053002/

BUG=skia:2447
R=mtklein@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/290603002

git-svn-id: http://skia.googlecode.com/svn/trunk@14768 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoGenerate gm/Android.mk, minus JSON.
commit-bot@chromium.org [Fri, 16 May 2014 17:56:43 +0000 (17:56 +0000)]
Generate gm/Android.mk, minus JSON.

When running gyp_to_android.py, generate the makefile for gm.

For now, remove json functionality and do not depend on json. This
allows us to build and run until solving skbug.com/2448.

gm/gm_expectations.cpp:
gm/gm_expectations.h:
gm/gmmain.cpp:
Remove all json functionality when SK_BUILD_JSON_WRITER is not defined.
This flag is not defined when SK_BUILD_FOR_ANDROID is defined.

gyp/gm.gyp:
Depend on skia and cutils.

platform_tools/android/bin/gyp_to_android.py:
Generate gm/Android.mk.

platform_tools/android/gyp_gen/makefile_writer.py:
Build gm/Android.mk when building external/skia.

Depends on https://codereview.chromium.org/282053002/

BUG=skia:2447
BUG=skia:2448
R=epoger@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/281303003

git-svn-id: http://skia.googlecode.com/svn/trunk@14767 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoGreenify bench bot Perf-Win7-ShuttleA-HD2000-x86-Release at build 2272
commit-bot@chromium.org [Fri, 16 May 2014 17:46:09 +0000 (17:46 +0000)]
Greenify bench bot Perf-Win7-ShuttleA-HD2000-x86-Release at build 2272
R=bsalomon@google.com
TBR=bsalomon@google.com
NOTRY=true

Author: bensong@google.com

Review URL: https://codereview.chromium.org/290183002

git-svn-id: http://skia.googlecode.com/svn/trunk@14766 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix Gpu texture creation bug
commit-bot@chromium.org [Fri, 16 May 2014 17:22:51 +0000 (17:22 +0000)]
Fix Gpu texture creation bug

When creating a resizedTexture on a device that doesn't support non power of 2 tile (Tegras),
we were creating the new stretched texture but were not actually saving the result

BUG=skia:2561
R=bsalomon@google.com, robertphillips@google.com, jvanverth@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/284303005

git-svn-id: http://skia.googlecode.com/svn/trunk@14765 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDisable poppler on Windows since it no longer compiles in VS2013
commit-bot@chromium.org [Fri, 16 May 2014 16:35:48 +0000 (16:35 +0000)]
Disable poppler on Windows since it no longer compiles in VS2013

R=borenet@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/285293008

git-svn-id: http://skia.googlecode.com/svn/trunk@14764 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of remove unused (by clients) SkUnitMapper (https://codereview.chromium.org...
commit-bot@chromium.org [Fri, 16 May 2014 13:49:08 +0000 (13:49 +0000)]
Revert of remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/)

Reason for revert:
does not address all legacy callsites in chrome.

e.g.

[13:45:32.091872] ../../ui/native_theme/native_theme_base.cc:608:76: error: no matching function for call to â€˜SkGradientShader::CreateLinear(SkPoint [3], SkColor [3], NULL, int, SkShader::TileMode, NULL)’
[13:45:32.091919]            gradient_bounds, colors, NULL, 3, SkShader::kClamp_TileMode, NULL));

Original issue's description:
> remove unused (by clients) SkUnitMapper
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14761

R=robertphillips@google.com, scroggo@google.com, george@mozilla.com
TBR=george@mozilla.com, robertphillips@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: reed@google.com

Review URL: https://codereview.chromium.org/287063009

git-svn-id: http://skia.googlecode.com/svn/trunk@14763 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebase for https://codereview.chromium.org/283803003/
commit-bot@chromium.org [Fri, 16 May 2014 13:47:56 +0000 (13:47 +0000)]
Rebase for https://codereview.chromium.org/283803003/
NOTREECHECKS=True
NOTRY=True
R=bsalomon@google.com
TBR=bsalomon@google.com
BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/291483008

git-svn-id: http://skia.googlecode.com/svn/trunk@14762 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove unused (by clients) SkUnitMapper
commit-bot@chromium.org [Fri, 16 May 2014 13:35:01 +0000 (13:35 +0000)]
remove unused (by clients) SkUnitMapper

BUG=skia:
R=robertphillips@google.com, scroggo@google.com, george@mozilla.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/283273002

git-svn-id: http://skia.googlecode.com/svn/trunk@14761 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoGenerate bench/Android.mk from gyp.
commit-bot@chromium.org [Fri, 16 May 2014 13:15:41 +0000 (13:15 +0000)]
Generate bench/Android.mk from gyp.

For now, remove json functionality and do not depend on json. This
allows us to build and run until solving skbug.com/2448.

bench/DeferredSurfaceCopyBench.cpp:
Include GrRenderTarget last, so SK_SUPPORT_GPU will be set properly.

bench/ResultsWriter.h:
bench/benchmain.cpp:
Remove JSONResultsWriter when SK_BUILD_JSON_WRITER is not defined,
which is the case for the Android framework build.

gyp/bench.gyp:
Depend on skia and cutils (for android_atomic_inc etc).

gyp/common_conditions.gypi:
Define SK_BUILD_JSON_WRITER when skia_build_json_writer is set.

gyp/common_variables.gypi:
Add a flag for skia_build_json_writer, and set it only when
skia_android_framework is not set.

gyp/jsoncpp.gyp:
Do not build jsoncpp when skia_build_json_writer is not defined.
include/utils/SkJSONCPP.h:
Do not include json headers when SK_BUILD_JSON_WRITER is not defined.

platform_tools/android/bin/gyp_to_android.py:
Generate bench/Android.mk.

platform_tools/android/gyp_gen/gypd_parser.py:
Skip dest_dir when checking for include_dirs.

platform_tools/android/gyp_gen/makefile_writer.py:
Build bench/Android.mk when building external/skia.

platform_tools/android/gyp_gen/tool_makefile_writer.py:
Add a parameter for putting the binary into /data/local/tmp.

BUG=skia:2447
BUG=skia:2448
R=halcanary@google.com, reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/282053002

git-svn-id: http://skia.googlecode.com/svn/trunk@14760 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDM: find max component difference
commit-bot@chromium.org [Fri, 16 May 2014 13:03:46 +0000 (13:03 +0000)]
DM: find max component difference

So far unused except to back BitmapsEqual, but I want to play with it in CLs I'm working on.

BUG=skia:
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/290043005

git-svn-id: http://skia.googlecode.com/svn/trunk@14759 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agobench rebase after 1663d40
commit-bot@chromium.org [Fri, 16 May 2014 12:46:25 +0000 (12:46 +0000)]
bench rebase after 1663d40
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true

Author: bensong@google.com

Review URL: https://codereview.chromium.org/292503002

git-svn-id: http://skia.googlecode.com/svn/trunk@14758 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Fri, 16 May 2014 03:03:31 +0000 (03:03 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@14757 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd polyfill for pointer events, change code to handle both mouse and pointer events...
commit-bot@chromium.org [Thu, 15 May 2014 21:14:34 +0000 (21:14 +0000)]
Add polyfill for pointer events, change code to handle both mouse and pointer events equalls.
Mobile first!

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/286913005

git-svn-id: http://skia.googlecode.com/svn/trunk@14756 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agohack to expand 'pad' to account for very wide glyphs
commit-bot@chromium.org [Thu, 15 May 2014 20:48:52 +0000 (20:48 +0000)]
hack to expand 'pad' to account for very wide glyphs

BUG=crbug.com/373785
R=mtklein@google.com, robertphillips@google.com, bungeman@google.com, eae@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/288923006

git-svn-id: http://skia.googlecode.com/svn/trunk@14755 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd lua scripts to scrape dashing info
commit-bot@chromium.org [Thu, 15 May 2014 20:35:50 +0000 (20:35 +0000)]
Add lua scripts to scrape dashing info

BUG=skia:
R=reed@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/288883003

git-svn-id: http://skia.googlecode.com/svn/trunk@14754 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMove skPaint2GrPaint to SkGr.h/cpp
commit-bot@chromium.org [Thu, 15 May 2014 20:32:48 +0000 (20:32 +0000)]
Move skPaint2GrPaint to SkGr.h/cpp

BUG=skia:
R=bsalomon@google.com, brian@thesalomons.net, robertphillips@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/283803003

git-svn-id: http://skia.googlecode.com/svn/trunk@14753 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorefactor DM::SetupBitmap
commit-bot@chromium.org [Thu, 15 May 2014 17:33:31 +0000 (17:33 +0000)]
refactor DM::SetupBitmap

Seemed sort of repetitive.

BUG=skia:
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/286993005

git-svn-id: http://skia.googlecode.com/svn/trunk@14752 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFactor out DumpRecord method from dump_record tool for later use
commit-bot@chromium.org [Thu, 15 May 2014 16:10:37 +0000 (16:10 +0000)]
Factor out DumpRecord method from dump_record tool for later use

R=mtklein@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/282233003

git-svn-id: http://skia.googlecode.com/svn/trunk@14751 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd SSE4 check to BlurImage optimization.
commit-bot@chromium.org [Thu, 15 May 2014 15:59:39 +0000 (15:59 +0000)]
Add SSE4 check to BlurImage optimization.

Adds a build-time SSE4 check to SkBlurImage_opts_SSE2.cpp
in the SkBoxBlur_SSE2 function.

Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com, senorblanco@chromium.org

Author: henrik.smiding@intel.com

Review URL: https://codereview.chromium.org/281963002

git-svn-id: http://skia.googlecode.com/svn/trunk@14750 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRemove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag.
commit-bot@chromium.org [Thu, 15 May 2014 15:40:41 +0000 (15:40 +0000)]
Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag.

Neither Chrome nor Android uses this flag anymore.
Make sure all constructors touched that only have one parameter are marked as 'explicit'.

BUG=2187
R=scroggo@google.com, reed@google.com

Author: dominikg@chromium.org

Review URL: https://codereview.chromium.org/282203004

git-svn-id: http://skia.googlecode.com/svn/trunk@14749 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorender_pictures: add --mismatchPath flag
commit-bot@chromium.org [Thu, 15 May 2014 15:10:48 +0000 (15:10 +0000)]
render_pictures: add --mismatchPath flag

When set, it will only write out images that don't match expectations.

BUG=skia:1942
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/283123002

git-svn-id: http://skia.googlecode.com/svn/trunk@14748 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agodelete no-longer-used update-doxygen.sh
commit-bot@chromium.org [Thu, 15 May 2014 14:41:00 +0000 (14:41 +0000)]
delete no-longer-used update-doxygen.sh

BUG=skia:2470
NOTRY=True
R=borenet@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/290033002

git-svn-id: http://skia.googlecode.com/svn/trunk@14747 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agobench rebase after a1633da
commit-bot@chromium.org [Thu, 15 May 2014 13:25:53 +0000 (13:25 +0000)]
bench rebase after a1633da
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true

Author: borenet@google.com

Review URL: https://codereview.chromium.org/286073005

git-svn-id: http://skia.googlecode.com/svn/trunk@14746 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAlways inline SkFloatToFixed_arm.
commit-bot@chromium.org [Thu, 15 May 2014 09:46:20 +0000 (09:46 +0000)]
Always inline SkFloatToFixed_arm.

We have "inline" assembly for speed on ARM, but the compiler when
told to optimize for space wasn't inlining it, destroying any
possible performance improvement.

BUG=skbug:2550
R=mtklein@google.com, reed@google.com, tomhudson@google.com

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/281143002

git-svn-id: http://skia.googlecode.com/svn/trunk@14745 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Thu, 15 May 2014 03:03:58 +0000 (03:03 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@14744 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoEffects on the paint also prevent layer merge optimization.
commit-bot@chromium.org [Wed, 14 May 2014 20:27:56 +0000 (20:27 +0000)]
Effects on the paint also prevent layer merge optimization.

BUG=skia:
R=robertphillips@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/287953002

git-svn-id: http://skia.googlecode.com/svn/trunk@14743 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDM: tweaks
commit-bot@chromium.org [Wed, 14 May 2014 20:26:00 +0000 (20:26 +0000)]
DM: tweaks

  - translate filenames to task names instead of using a verbatim mode in WriteTask
  - add an option to write out only PNG data to the .png if you don't need -r to work

BUG=skia:
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/288823002

git-svn-id: http://skia.googlecode.com/svn/trunk@14742 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agocomment out info4 test until Rob can fix it
reed@google.com [Wed, 14 May 2014 18:58:16 +0000 (18:58 +0000)]
comment out info4 test until Rob can fix it

git-svn-id: http://skia.googlecode.com/svn/trunk@14741 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline_server: apply ignored-tests.txt within rebaseline_server, not just on...
commit-bot@chromium.org [Wed, 14 May 2014 18:04:46 +0000 (18:04 +0000)]
rebaseline_server: apply ignored-tests.txt within rebaseline_server, not just on the bots

(SkipBuildbotRuns)
BUG=skia:2514
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/287623006

git-svn-id: http://skia.googlecode.com/svn/trunk@14740 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDM: Add --skps.
commit-bot@chromium.org [Wed, 14 May 2014 17:55:32 +0000 (17:55 +0000)]
DM: Add --skps.

This does render_pictures, plus checks SkRecord optimizations.

Disable an SkRecord optimization that draws several bot SKPs wrong.  (To be investigated.)

BUG=skia:2378
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/270543004

git-svn-id: http://skia.googlecode.com/svn/trunk@14739 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove reference to (deleted) SkKernel33MaskFilter
commit-bot@chromium.org [Wed, 14 May 2014 17:42:42 +0000 (17:42 +0000)]
remove reference to (deleted) SkKernel33MaskFilter

BUG=skia:
R=caryclark@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/281163002

git-svn-id: http://skia.googlecode.com/svn/trunk@14738 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix goauth path
commit-bot@chromium.org [Wed, 14 May 2014 16:57:49 +0000 (16:57 +0000)]
Fix goauth path

BUG=skia:2551
R=scroggo@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/288763002

git-svn-id: http://skia.googlecode.com/svn/trunk@14737 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoupdate NeedsDeepCopy
commit-bot@chromium.org [Wed, 14 May 2014 16:32:31 +0000 (16:32 +0000)]
update NeedsDeepCopy

BUG=skia:
R=mtklein@google.com, scroggo@google.com, dominikg@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/289723002

git-svn-id: http://skia.googlecode.com/svn/trunk@14736 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agobench rebase after 9f3b925
commit-bot@chromium.org [Wed, 14 May 2014 16:30:41 +0000 (16:30 +0000)]
bench rebase after 9f3b925
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true

Author: bensong@google.com

Review URL: https://codereview.chromium.org/286823004

git-svn-id: http://skia.googlecode.com/svn/trunk@14735 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoReland the 4x -> 1x allocation from "4x allocation in PipeController is probably...
commit-bot@chromium.org [Wed, 14 May 2014 16:06:15 +0000 (16:06 +0000)]
Reland the 4x -> 1x allocation from "4x allocation in PipeController is probably overkill."

BUG=372671
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/283933002

git-svn-id: http://skia.googlecode.com/svn/trunk@14734 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd asADash to Lua for scraping
commit-bot@chromium.org [Wed, 14 May 2014 16:03:14 +0000 (16:03 +0000)]
Add asADash to Lua for scraping

BUG=skia:
R=robertphillips@google.com, reed@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/267423006

git-svn-id: http://skia.googlecode.com/svn/trunk@14733 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd warning about GOPATH to bug_chomper/run_server.sh
commit-bot@chromium.org [Wed, 14 May 2014 15:42:14 +0000 (15:42 +0000)]
Add warning about GOPATH to bug_chomper/run_server.sh

BUG=skia:2551
R=scroggo@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/285763003

git-svn-id: http://skia.googlecode.com/svn/trunk@14732 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoReland one more bug fix from "4x allocation in PipeController is probably overkill.".
commit-bot@chromium.org [Wed, 14 May 2014 15:38:25 +0000 (15:38 +0000)]
Reland one more bug fix from "4x allocation in PipeController is probably overkill.".

BUG=372671
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/285693007

git-svn-id: http://skia.googlecode.com/svn/trunk@14731 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoarm64make script - fix error preventing Release testing.
commit-bot@chromium.org [Wed, 14 May 2014 15:36:54 +0000 (15:36 +0000)]
arm64make script - fix error preventing Release testing.

R=scroggo@google.com, djsollen@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/258323002

git-svn-id: http://skia.googlecode.com/svn/trunk@14730 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd CPU backing store for GrAtlas to reduce texture uploads.
commit-bot@chromium.org [Wed, 14 May 2014 15:14:51 +0000 (15:14 +0000)]
Add CPU backing store for GrAtlas to reduce texture uploads.

This change creates a temporary copy of each GrPlot on the CPU
side. As we add glyphs to a plot, a dirty rectangle is tracked,
and just before we render text we upload all of the dirty areas
to the atlas texture. Once a plot is nearly full, we assume that
we may only be adding one or two glyphs before rendering, so we
delete the CPU backing memory to save space, and upload directly.

BUG=366225
R=robertphillips@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/269423007

git-svn-id: http://skia.googlecode.com/svn/trunk@14729 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAllow GrFontCache::dump() in all builds.
commit-bot@chromium.org [Wed, 14 May 2014 15:12:51 +0000 (15:12 +0000)]
Allow GrFontCache::dump() in all builds.

In testing Chrome last week, I discovered that dump() works fine in Release builds, so there's no reason to restrict it to Developer.

R=robertphillips@google.com, egdaniel@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/286803002

git-svn-id: http://skia.googlecode.com/svn/trunk@14728 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoReland bug fixes from "4x allocation in PipeController is probably overkill."
commit-bot@chromium.org [Wed, 14 May 2014 15:12:08 +0000 (15:12 +0000)]
Reland bug fixes from "4x allocation in PipeController is probably overkill."

BUG=372671
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/283093002

git-svn-id: http://skia.googlecode.com/svn/trunk@14727 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoStage fixes for underline position.
commit-bot@chromium.org [Wed, 14 May 2014 14:54:51 +0000 (14:54 +0000)]
Stage fixes for underline position.

R=reed@google.com

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/271333002

git-svn-id: http://skia.googlecode.com/svn/trunk@14726 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoManually revert "4x allocation in PipeController is probably overkill."
commit-bot@chromium.org [Wed, 14 May 2014 14:50:57 +0000 (14:50 +0000)]
Manually revert "4x allocation in PipeController is probably overkill."

This reverts commit 2d91efffdb57646a495de5bf859ff281ef86dd12.

Conflicts:
src/pipe/SkGPipeWrite.cpp

BUG=372671
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/277653004

git-svn-id: http://skia.googlecode.com/svn/trunk@14725 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd ownership dox for SkShader::asACompose.
commit-bot@chromium.org [Wed, 14 May 2014 14:28:34 +0000 (14:28 +0000)]
Add ownership dox for SkShader::asACompose.

Supplement the comment added in
http://code.google.com/p/skia/source/detail?r=14716

R=reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/288713002

git-svn-id: http://skia.googlecode.com/svn/trunk@14724 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoBy default, Chromium optimizes for size when compiling on Android.
commit-bot@chromium.org [Wed, 14 May 2014 13:34:42 +0000 (13:34 +0000)]
By default, Chromium optimizes for size when compiling on Android.
Forcing the SkAlphaMulQ() function inline can yield as much as a 5-10%
improvement in rasterization time for some of Chromium's telemetry
tests on the Nexus 10, since it's in the inner loop of complex blends.

R=mtklein@google.com, reed@google.com, tomhudson@google.com

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/283753003

git-svn-id: http://skia.googlecode.com/svn/trunk@14723 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoInline noop willFoo/didFoo into SkCanvas.h.
commit-bot@chromium.org [Wed, 14 May 2014 13:13:44 +0000 (13:13 +0000)]
Inline noop willFoo/didFoo into SkCanvas.h.

We've got our canvas subclasses all calling back up to these via
INHERITED, all noops.  That's fine but currently a little sad as they
can't be optimized away without link-time optimization, which we and
Chrome only do on Windows.  We actually make a call for each of these
today on non-Windows.

So, move the empty implementations into the header so those chaining
calls really can be optimized away.

BUG=skia:
R=reed@google.com, fmalita@google.com, mtklein@google.com, fmalita@chromium.org

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/287593005

git-svn-id: http://skia.googlecode.com/svn/trunk@14722 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUpdate layer-pre-rendering for Chrome flag
commit-bot@chromium.org [Wed, 14 May 2014 13:11:48 +0000 (13:11 +0000)]
Update layer-pre-rendering for Chrome flag

As currently plumbed into Chromium, EXPERIMENTAL_optimize can be called multiple times per picture. Additionally, Chromium generates a lot of pictures with no layers at all.

R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/283703007

git-svn-id: http://skia.googlecode.com/svn/trunk@14721 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoPing MySQL every minute in an attempt to keep the connection alive.
commit-bot@chromium.org [Wed, 14 May 2014 12:55:34 +0000 (12:55 +0000)]
Ping MySQL every minute in an attempt to keep the connection alive.

I've tried various MySQL server settings, and some TCP settings on the webtry server, none seem to keep the connection from hanging, so this is a brute-force solution.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/286543003

git-svn-id: http://skia.googlecode.com/svn/trunk@14720 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoComment out call broken call to pushMatrix in LuaCanvas
commit-bot@chromium.org [Tue, 13 May 2014 20:32:32 +0000 (20:32 +0000)]
Comment out call broken call to pushMatrix in LuaCanvas

BUG=skia:
R=robertphillips@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/271533013

git-svn-id: http://skia.googlecode.com/svn/trunk@14719 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoBugChomper: Get the oauth_client_secret from GS
commit-bot@chromium.org [Tue, 13 May 2014 19:18:55 +0000 (19:18 +0000)]
BugChomper: Get the oauth_client_secret from GS

BUG=skia:
NOTRY=true
(SkipBuildbotRuns)

R=jcgregorio@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/288593003

git-svn-id: http://skia.googlecode.com/svn/trunk@14718 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agobench rebase after f71be96
commit-bot@chromium.org [Tue, 13 May 2014 19:13:36 +0000 (19:13 +0000)]
bench rebase after f71be96
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true

Author: borenet@google.com

Review URL: https://codereview.chromium.org/276573012

git-svn-id: http://skia.googlecode.com/svn/trunk@14717 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd functions for inspecting SkShader.
commit-bot@chromium.org [Tue, 13 May 2014 18:14:45 +0000 (18:14 +0000)]
Add functions for inspecting SkShader.

Add a function to inspect an SkShader to determine if it is an
SkComposeShader.

Add a virtual function for determining if an SkShader is a custom
shader, which returns a custom set of information. The
implementation is in Android, and this function is only defined
if SK_BUILD_FOR_ANDROID_FRAMEWORK.

BUG=b/10650594
R=reed@google.com, scroggo@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/282733005

git-svn-id: http://skia.googlecode.com/svn/trunk@14716 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoBugChomper utility - rewrite in Go
commit-bot@chromium.org [Tue, 13 May 2014 18:03:45 +0000 (18:03 +0000)]
BugChomper utility - rewrite in Go

BUG=skia:
R=jcgregorio@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/274693002

git-svn-id: http://skia.googlecode.com/svn/trunk@14715 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFixed flaky test
commit-bot@chromium.org [Tue, 13 May 2014 17:47:08 +0000 (17:47 +0000)]
Fixed flaky test

BUG=skia:
R=bensong@google.com

Author: kelvinly@google.com

Review URL: https://codereview.chromium.org/283713005

git-svn-id: http://skia.googlecode.com/svn/trunk@14714 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdds dashboard link for one-line plot on each alert item.
commit-bot@chromium.org [Tue, 13 May 2014 17:38:17 +0000 (17:38 +0000)]
Adds dashboard link for one-line plot on each alert item.

BUG=skia:2523
NOTRY=true
R=kelvinly@google.com
TBR=rmistry@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/280663002

git-svn-id: http://skia.googlecode.com/svn/trunk@14713 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdds kelvinly@google.com to CQ_COMMITTERS
commit-bot@chromium.org [Tue, 13 May 2014 17:33:56 +0000 (17:33 +0000)]
Adds kelvinly@google.com to CQ_COMMITTERS

BUG=skia:
NOTRY=true
R=rmistry@google.com
TBR=rmistry@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/270383005

git-svn-id: http://skia.googlecode.com/svn/trunk@14712 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUpdate TSAN suppressions.
commit-bot@chromium.org [Tue, 13 May 2014 14:47:21 +0000 (14:47 +0000)]
Update TSAN suppressions.

BUG=skia:2459, skia:1792
R=bsalomon@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/288533002

git-svn-id: http://skia.googlecode.com/svn/trunk@14711 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRemove legacy SkLayerRasterizer flag for Android.
commit-bot@chromium.org [Tue, 13 May 2014 14:47:17 +0000 (14:47 +0000)]
Remove legacy SkLayerRasterizer flag for Android.

Android's uses of SkLayerRasterizer have been cleaned up and no longer require
the legacy API. Remove the flag for Android.
We still have to keep the legacy API around until Mozilla have cleaned up their
uses.

BUG=skia:2187
R=reed@google.com, djsollen@google.com

Author: dominikg@chromium.org

Review URL: https://codereview.chromium.org/279383006

git-svn-id: http://skia.googlecode.com/svn/trunk@14710 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAlways inline Filter_32_*_neon functions
commit-bot@chromium.org [Tue, 13 May 2014 14:47:11 +0000 (14:47 +0000)]
Always inline Filter_32_*_neon functions

The functions are rather performance critical and already marked
'inline'. However, Chrome for Android will not have these functions
inlined due to it being compiled with -Os and a small -finline-limit.

This avoids one call in the filtering functions.

Does not increase the library size.

BUG=chromium:363073
R=mtklein@google.com

Author: kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/280403005

git-svn-id: http://skia.googlecode.com/svn/trunk@14709 2bbb7eff-a529-9590-31e7-b0007b416f81