Thibault Saunier [Mon, 12 Aug 2019 01:20:21 +0000 (21:20 -0400)]
project: Properly handle NULL project asset ID
Thibault Saunier [Wed, 31 Jul 2019 01:24:07 +0000 (18:24 -0700)]
structured: Enhance error message when no clip duration set
Thibault Saunier [Wed, 31 Jul 2019 01:22:18 +0000 (18:22 -0700)]
structured-interface: Avoid setting invalid clip duration
Thibault Saunier [Wed, 17 Jul 2019 01:51:10 +0000 (21:51 -0400)]
track: Add a getter for restriction_caps
Thibault Saunier [Sun, 14 Jul 2019 01:27:46 +0000 (21:27 -0400)]
launch: Set user restriction caps even when loading projects
Thibault Saunier [Sun, 14 Jul 2019 01:26:35 +0000 (21:26 -0400)]
track: Enhance restriction capsfilter name
Thibault Saunier [Sat, 13 Jul 2019 17:25:48 +0000 (13:25 -0400)]
xml-formatter: Serialize DiscovererStreamInfo
We do not use it yet but it gives interesting information to
users
Thibault Saunier [Fri, 12 Jul 2019 20:15:35 +0000 (16:15 -0400)]
formatter: Plug lists of TimedValue leak
Thibault Saunier [Fri, 5 Jul 2019 13:40:57 +0000 (09:40 -0400)]
formatter: Better document metadata registration
And fix xges mimetype to match typefind mimetype
Thibault Saunier [Thu, 4 Jul 2019 20:51:54 +0000 (16:51 -0400)]
doc: Do not require the GStreamer cache generator
Thibault Saunier [Thu, 4 Jul 2019 19:58:44 +0000 (15:58 -0400)]
gesdemux: Compute sinkpad caps based on formatter mimetypes
Implement lazy loading asset cache so gesdemux use the formatters
assets while GES hasn't been initialized.
And set extensions to temporary files as some formatters require
the information (otio)
Thibault Saunier [Thu, 4 Jul 2019 00:15:23 +0000 (20:15 -0400)]
formatter: Add a method to retrieve the best formatter for a givent URI
Uses the file extension as hint falling back to the default formatter
if none is found
Make use of that function in when saving a project and not formatter
is specified.
Thibault Saunier [Tue, 5 Feb 2019 18:46:49 +0000 (15:46 -0300)]
Implement a formatter based on [OpenTimelineIO]
[OpenTimelineIO]: http://opentimeline.io/
Thibault Saunier [Fri, 19 Apr 2019 13:07:44 +0000 (09:07 -0400)]
formatter: Handle coma separated extensions in formatter metas
Thibault Saunier [Mon, 11 Mar 2019 22:25:23 +0000 (19:25 -0300)]
formatter: Duplicate const gchar* for metadatas
Thibault Saunier [Tue, 5 Feb 2019 19:08:10 +0000 (16:08 -0300)]
project: Expose the ges_project_add_formatter method
This method is useful when implementing a formatter outside
GES that end up converting to xges and uses the default formatter
to finally load the timeline.
Thibault Saunier [Thu, 11 Jul 2019 20:23:47 +0000 (16:23 -0400)]
Mark nested timeline assets as such
Adding a property to let the application know
Also make sure that the duration of nested timeline assets is reported
as CLOCK_TIME_NONE as those are extended as necessary.
And make a difference between asset duration and their max duration
As nested timelines can be extended 'infinitely' those max duration
is GST_CLOCK_TIME_NONE, but their duration is the real duration of
the timeline.
Thibault Saunier [Thu, 11 Jul 2019 19:54:27 +0000 (15:54 -0400)]
formatter: Enhance error reporting
And add a "loading-error" signal in GESProject so we can report
issue when loading async elements for the timeline.
Thibault Saunier [Thu, 11 Jul 2019 19:43:47 +0000 (15:43 -0400)]
xml-formatter: Fix loading sources
And fix the project file which couldn't be load now that we
properly check clips coherency
Thibault Saunier [Wed, 10 Jul 2019 23:36:21 +0000 (19:36 -0400)]
gesdemux: Add a testsrc to timelines if parent nleobject duration is too long
Thibault Saunier [Wed, 10 Jul 2019 16:06:01 +0000 (12:06 -0400)]
ges:validate: Properly error when editing container fails
Thibault Saunier [Wed, 10 Jul 2019 15:02:07 +0000 (11:02 -0400)]
nle: Handle nested timelines update when file changes
When we have nested timelines, we need to make sure the underlying
formatted file is reloaded when commiting the main composition to
take into account the new timeline.
In other to make the implementation as simple as possible we make
sure that whenever the toplevel composition is commited, the decodebin
holding the gesdemux is torn down so that a new demuxer is created
with the new content of the timeline.
To do that a we do a NleCompositionQueryNeedsTearDown query to which
gesdemux answers leading to a full nlecomposition stack
deactivation/activation cycle.
Thibault Saunier [Wed, 10 Jul 2019 14:15:31 +0000 (10:15 -0400)]
ges:validate: Add a way to execute actions on serialized timelines
This way we can modify nested timelines.
Thibault Saunier [Tue, 9 Jul 2019 05:03:56 +0000 (01:03 -0400)]
ges: Implement our own idle_add which uses the thread local maincontext
Thibault Saunier [Tue, 9 Jul 2019 04:28:29 +0000 (00:28 -0400)]
validate: Allow passing 'uri' to 'load-project'
The action type was thought to allow that but it wasn't implemented.
Thibault Saunier [Tue, 9 Jul 2019 04:07:16 +0000 (00:07 -0400)]
xml-formatter: Lower down borring debug to _LOG
Thibault Saunier [Tue, 9 Jul 2019 04:05:21 +0000 (00:05 -0400)]
project: Use asset ID as URI if possible
It was making no sense to consider it an empty timeline when the user
had passed the project URI when requesting the asset. Usually user
use `ges_project_new` with the URI but it is also valid to use
`ges_asset_request` with the uri as ID so let's handle that properly.
Thibault Saunier [Mon, 8 Jul 2019 23:25:32 +0000 (19:25 -0400)]
python: Add a better asset __repr__
Thibault Saunier [Mon, 8 Jul 2019 00:55:53 +0000 (20:55 -0400)]
ges: Implement subprojects
Subprojects simply consist of adding the GESProject
to the main project asset list. Then those are recursively
serialized in the main project in the <asset> not, when deserializing,
temporary files are created and those will be used in clips
as necessary
Thibault Saunier [Mon, 8 Jul 2019 00:35:14 +0000 (20:35 -0400)]
project: Fix our asset cache
It was not talking into account the fact that you can have
several assets with a same ID but different exactractable types.
Thibault Saunier [Sun, 14 Jul 2019 20:28:23 +0000 (16:28 -0400)]
asset: Handle trying to proxy an asset to itself
And avoid infinite recursion
Thibault Saunier [Wed, 3 Jul 2019 16:10:24 +0000 (12:10 -0400)]
gesdemux: Detect recursively loading the same project file
And error out when it is the case.
Thibault Saunier [Wed, 3 Jul 2019 16:09:23 +0000 (12:09 -0400)]
gesdemux: Create proper stream-ids
Thibault Saunier [Wed, 3 Jul 2019 14:10:42 +0000 (10:10 -0400)]
nle: Check seeking on deeply nested composition
Thibault Saunier [Sat, 29 Jun 2019 00:19:49 +0000 (20:19 -0400)]
track: Disable last gap by default
And let the GESPipeline logic handle that
Thibault Saunier [Sat, 29 Jun 2019 00:19:20 +0000 (20:19 -0400)]
nlecomposition: Drop all group-done but the last one
Thibault Saunier [Fri, 28 Jun 2019 21:35:40 +0000 (17:35 -0400)]
validate: Allow scenarios to set track types
Swayamjeet [Wed, 19 Jun 2019 10:22:21 +0000 (15:52 +0530)]
tests: Add ges-sample-path-recurse with projects location
So that project files are found when using nested timelines
Thibault Saunier [Sun, 23 Jun 2019 17:03:54 +0000 (13:03 -0400)]
validate: Add a way to use validate configs with scenarios
Config files should have the-scenario-name.scenario.config to be picked automatically
Thibault Saunier [Sun, 23 Jun 2019 17:03:04 +0000 (13:03 -0400)]
validate: Use proper sink and give them good names
Thibault Saunier [Sun, 23 Jun 2019 16:42:21 +0000 (12:42 -0400)]
validate: Create folders as needed when serializing timelines
Thibault Saunier [Sun, 23 Jun 2019 03:49:50 +0000 (23:49 -0400)]
nlesource: Wait for the seek to actualy happen before removing the probe
Make sure that an event resulting from the seek happens before removing
the pad probe, dropping anything while it is not the case.
This guarantees that the seek happens before `nlesource` outputs
anything. This was not necessary as with decodebin or usual source
flushing seeks lead to synchronous flush_start/flush_stop and we could
safely assume that once the seek is sent, it was happenning.
With nested `nlecomposition` this assumption is simply not true as
in the composition seeks are basically cached and happen later in
the composition updating thread.
This fixes races where we ended up removing the blocking probe before
the seek actually started to be executed in the nlecomposition
nested inside an nlesource which leaded to data from *before* the seek
to be outputed which means we could display wrong frames,
and it was leading to interesting deadlocks.
Thibault Saunier [Sun, 23 Jun 2019 03:25:57 +0000 (23:25 -0400)]
nlecomposition: Minor debugging enhancements
Thibault Saunier [Fri, 21 Jun 2019 15:45:20 +0000 (11:45 -0400)]
uri-asset: Fix retrieving a relocated asset sync twice
Add a simple test for that.
Thibault Saunier [Fri, 21 Jun 2019 14:47:34 +0000 (10:47 -0400)]
timeline: Make adding/removing track MT safe
It was almost the case already so make it happen fully
Thibault Saunier [Wed, 19 Jun 2019 22:14:52 +0000 (18:14 -0400)]
nlecomposition: Ensure flushes after seek have the right seqnum
Seeks that lead to a stack change lead to deactivating the current
stack. At that point we explicitely flush downstream as a reaction to
the flushing seek. Until now those flushes had a random seqnum, this
fails if we are a nested compostion as the parent composition will end
up dropping that flush which in turns might lead to deadlocks. For
example, the flush goes through a `compositor` which wants to flush
downstream to stop its srcpad task, but that flush wouldn't have
"released" its srcpad thread if the composition srcpad drops it, meaning
it won't be able to stop the task ever.
Thibault Saunier [Mon, 17 Jun 2019 22:23:43 +0000 (18:23 -0400)]
nlecomposition: Shutdown children when setting state to NULL
Otherwise if we shutdown a composition whith an nested composition
(inside a source in the test) and leak it, we end up with the nested
composition task still running (in READY) which is bad.
Add a test for that which leaks the pipeline on purpose.
Thibault Saunier [Mon, 17 Jun 2019 22:23:07 +0000 (18:23 -0400)]
nle: Parent the GstTask to ourself
This allows accessing the nlecomposition in gdb when a task is
'dangling' making debugging easier.
Swayamjeet [Tue, 11 Jun 2019 18:21:14 +0000 (23:51 +0530)]
tests: Implement nested timelines tests
Thibault Saunier [Mon, 17 Jun 2019 03:03:44 +0000 (23:03 -0400)]
nlecomposition: Properly set seqnum on flush events
Thibault Saunier [Mon, 17 Jun 2019 03:00:31 +0000 (23:00 -0400)]
timeline: Drop ASYNC_/START/DONE messages
When we have nested timelines, we do not want those messages to pop
to the parent timelines as we handle the sequence ourself in the
timeline.
Thibault Saunier [Sat, 15 Jun 2019 03:48:20 +0000 (23:48 -0400)]
demux: Create timeline from the streaming thread
First marshilling it to the main thread is dangerous as it is a blocking
operation and it should never happen there.
The asset cache is MT safe now so it is possible to load the timeline
from that thread directly
Thibault Saunier [Mon, 17 Jun 2019 01:27:47 +0000 (21:27 -0400)]
uri-asset: Implement multi threading support
Making sure to have 1 GstDiscoverer per thread.
Use that new feature in gesdemux by loading the timeline directly from
the streaming thread. Modifying the timeline is not supported allowed
anyway.
Thibault Saunier [Sun, 9 Jun 2019 23:35:21 +0000 (19:35 -0400)]
nle: Add a seeking test for nested composition
Thibault Saunier [Fri, 7 Jun 2019 20:12:26 +0000 (16:12 -0400)]
Use the new GstDiscoverer caching feature
Thibault Saunier [Fri, 7 Jun 2019 20:06:39 +0000 (16:06 -0400)]
timeline: Do not post upstream translated composition update messages
In the case of nested timeline in the toplevel timeline we ended up
with CompositionUpdate for seeks sent by our own composition to
granchildren composition. This was not causing essential issues
if all tracks where containing nested timelines but in cases
where one of the tracks only had a nested timelines, then we
were waiting forever for a `CompositionUpdateDone`.
CompositionUpdate translated into ASYNC_START/ASYNC_DONE should
be kept inside the GESTimeline and not travel up (possibly to some
parent GESTimeline).
Thibault Saunier [Fri, 7 Jun 2019 13:10:53 +0000 (09:10 -0400)]
structured-interface: Handle track-types in clip addition
The field was already expected in the launcher
Thibault Saunier [Fri, 7 Jun 2019 03:19:38 +0000 (23:19 -0400)]
Implement and use the GstStream API
Thibault Saunier [Thu, 6 Jun 2019 21:21:01 +0000 (17:21 -0400)]
timeline: Create stable stream IDs
Thibault Saunier [Thu, 6 Jun 2019 19:40:57 +0000 (15:40 -0400)]
docs: Generate ges plugin doc
Thibault Saunier [Thu, 6 Jun 2019 17:51:45 +0000 (13:51 -0400)]
plugins:ges: Factor out a GESBaseBin class
And use it in both gesdemux and gessrc
Thibault Saunier [Thu, 6 Jun 2019 17:02:33 +0000 (13:02 -0400)]
gesdemux: Emit no-more-pad as required
Thibault Saunier [Thu, 6 Jun 2019 16:46:08 +0000 (12:46 -0400)]
nlecomposition: Respect seek seqnum in output EOS/SEGMENT
Allowing a proper seek EOS handling with nested compositions
Thibault Saunier [Thu, 6 Jun 2019 15:26:45 +0000 (11:26 -0400)]
gesdemux: Properly combine flows
Thibault Saunier [Thu, 6 Jun 2019 14:16:50 +0000 (10:16 -0400)]
plugin: Make use of G_DECLARE
And remove useless .h files
Thibault Saunier [Sun, 16 Jun 2019 15:09:46 +0000 (11:09 -0400)]
xml-formatter: Plug some leaks
Thibault Saunier [Sat, 15 Jun 2019 20:44:50 +0000 (16:44 -0400)]
xml-formatter: Refactor the way we handle loading state
Thibault Saunier [Sat, 15 Jun 2019 19:11:38 +0000 (15:11 -0400)]
xml-formatter: Cleanup removing all now useless pending fields
Thibault Saunier [Sat, 23 Jun 2018 15:26:03 +0000 (11:26 -0400)]
xml-formatter: Load assets before their proxies
Paving the way to removing pending fields to make the code
simpler to follow.
Thibault Saunier [Sat, 15 Jun 2019 05:33:49 +0000 (01:33 -0400)]
assets: Recurse in the chain of proxies
When linking loaded proxies and trying to setup their targets
Thibault Saunier [Thu, 6 Jun 2019 13:48:32 +0000 (09:48 -0400)]
docs: Add gstges plugin
Thibault Saunier [Sun, 26 May 2019 13:55:03 +0000 (09:55 -0400)]
validate: Add action type to copy/paste clips
Thibault Saunier [Sun, 26 May 2019 00:20:07 +0000 (20:20 -0400)]
container: Handle children pasting failures
Thibault Saunier [Sat, 25 May 2019 22:51:08 +0000 (18:51 -0400)]
clip: Fix layer managament when copying a clip that was pasted
Thibault Saunier [Sat, 25 May 2019 20:05:00 +0000 (16:05 -0400)]
element: Properly handle the fact that pasting can return NULL
And fix paste annotation
Niels De Graef [Fri, 31 May 2019 21:13:48 +0000 (23:13 +0200)]
meson: Bump minimal GLib version to 2.44
This means we can use some newer features and get rid of some
boilerplate code using the G_DECLARE_* macros.
As discussed on IRC, 2.44 is old enough by now to start depending on it.
Mathieu Duponchelle [Wed, 29 May 2019 21:12:11 +0000 (23:12 +0200)]
doc: remove xml from comments
Thibault Saunier [Fri, 17 May 2019 23:54:51 +0000 (19:54 -0400)]
video-transition: When using non crossfade effect use 'over' operations
For smptealph element to work as expected the following compositing
element should mix with the default "over" operator, as described
in its documentation.
Thibault Saunier [Thu, 23 May 2019 22:43:06 +0000 (18:43 -0400)]
launcher: Remove duplicated track types option
Thibault Saunier [Thu, 23 May 2019 22:42:34 +0000 (18:42 -0400)]
docs: Minor documentation fixes
Thibault Saunier [Thu, 23 May 2019 21:20:56 +0000 (17:20 -0400)]
overrides: Make sure overrides are in hierarchy order
Otherwise method order resolution will not be correct
Thibault Saunier [Thu, 24 Jan 2019 22:39:48 +0000 (19:39 -0300)]
ges: Minor reorganisation of timeline-element.c
Thibault Saunier [Thu, 24 Jan 2019 11:43:00 +0000 (08:43 -0300)]
ges: Cleanup timeline-element.h indentation
Thibault Saunier [Wed, 1 May 2019 22:20:42 +0000 (18:20 -0400)]
project: Add a signal to notify when a new timeline is starting to load
Thibault Saunier [Thu, 23 May 2019 20:58:25 +0000 (16:58 -0400)]
tools: Initialize GStreamer before parsin options
We need it to be initialized to be able to parse our options
Thibault Saunier [Wed, 1 May 2019 21:28:26 +0000 (17:28 -0400)]
tools: Use a proper implementation of get_flags_from_string
Thibault Saunier [Wed, 1 May 2019 21:26:51 +0000 (17:26 -0400)]
tests: Simply include ges-internal.h instead of redefining the same macros
Thibault Saunier [Thu, 16 May 2019 13:07:03 +0000 (09:07 -0400)]
docs: Stop building the doc cache by default
And update the cache
Fixes https://gitlab.freedesktop.org/gstreamer/gst-docs/issues/36
Sebastian Dröge [Thu, 16 May 2019 12:09:51 +0000 (15:09 +0300)]
timeline-element: Mark edit() as Since: 1.18
Sebastian Dröge [Thu, 16 May 2019 12:06:14 +0000 (15:06 +0300)]
ges: Sprinkle around some Since: 1.16 markers
Thibault Saunier [Wed, 1 May 2019 17:19:42 +0000 (13:19 -0400)]
ges: Deprecate ges_play_sink_convert_frame
It has nothing to do in our namespace/API
Thibault Saunier [Wed, 1 May 2019 16:56:44 +0000 (12:56 -0400)]
More porting to markdown
Thibault Saunier [Wed, 1 May 2019 15:53:07 +0000 (11:53 -0400)]
title-clip: Enhance documentation
Thibault Saunier [Mon, 22 Oct 2018 06:22:52 +0000 (08:22 +0200)]
doc: Build documentation with hotdoc
Thibault Saunier [Mon, 22 Oct 2018 09:39:03 +0000 (11:39 +0200)]
docs: Minor fixes
Nicolas Dufresne [Tue, 7 May 2019 17:33:09 +0000 (13:33 -0400)]
doc: ges-track: Add ges_track_set_create_element_for_gap_func
Thibault Saunier [Sun, 5 May 2019 15:38:28 +0000 (11:38 -0400)]
launch: Fix caps restriction short names
Thibault Saunier [Sat, 4 May 2019 14:47:07 +0000 (10:47 -0400)]
python: Avoid warning about using deprecated methods
Fixes https://gitlab.freedesktop.org/gstreamer/gst-editing-services/issues/69
Thibault Saunier [Thu, 2 May 2019 15:41:10 +0000 (11:41 -0400)]
element: Make return value of setters mean something
Setters return values should return %FALSE **only** when the value
could not be set, not when unchanged or when the subclass handled
it itself!
This patches makes it so the return value is meaningul by allowing
subclasses return anything different than `TRUE` or `FALSE` (convention
is -1) to let the subclass now that it took care of everything and
no signal should be emited.
Thibault Saunier [Wed, 1 May 2019 16:09:45 +0000 (12:09 -0400)]
ges: Move `ges_container_edit` to GESTimelineElement
Now that the notion of layer has been moved down to #GESTimelineElement
(through the new #ges_timeline_element_get_layer_priority method), this
method make much more sense directly in the base class.