Shafik Yaghmour [Mon, 8 May 2023 18:13:08 +0000 (11:13 -0700)]
[Clang] Update warning on some designator initializer cases involving unions
Currently when using designated initializers in C++ we have a few
extension. Two extension which are dangerous involved assigning to
multiple members of union which will likely be a mistake since unions
can only have one active member. I have updated to be a warning by
default.
The second case if when we assign to multiple union members and one of
the previous members had a non-trivial destructor, which could lead to
leaking resources. This one is now an error by default.
Fixes: https://github.com/llvm/llvm-project/issues/62156
Differential Revision: https://reviews.llvm.org/D149694
Hanhan Wang [Mon, 8 May 2023 17:57:30 +0000 (10:57 -0700)]
[mlir][vector] Remove unused variable `srcShape`.
Differential Revision: https://reviews.llvm.org/D150130
Vassil Vassilev [Mon, 8 May 2023 10:48:03 +0000 (10:48 +0000)]
[clang-repl] Consider the scope spec in template lookups for deduction guides.
isDeductionGuideName looks up the underlying template and if the template name
is qualified we miss that qualification resulting in an error. This issue
resurfaced in clang-repl where we call isDeductionGuideName more often to
distinguish between if we had a statement or declaration.
This patch passes the CXXScopeSpec information down to LookupTemplateName to
make the lookup more precise.
Differential revision: https://reviews.llvm.org/D147319
Hanhan Wang [Thu, 4 May 2023 21:31:44 +0000 (14:31 -0700)]
[mlir][vector] Generalize vector.transpose lowering to n-D vectors
The existing vector.transpose lowering patterns only triggers if the
input vector is 2D. The revision extends the pattern to handle n-D
vectors which are effectively 2-D vectors (e.g., vector<1x4x1x8x1).
It refactors a common check about 2-D vectors from X86Vector
lowering to VectorUtils.h so it can be reused by both sides.
Reviewed By: dcaballe
Differential Revision: https://reviews.llvm.org/D149908
Craig Topper [Mon, 8 May 2023 17:40:05 +0000 (10:40 -0700)]
[RISCV] Use parseToken to simplify code. Add missing check for Identifier token.
Jake Egan [Mon, 8 May 2023 17:36:09 +0000 (13:36 -0400)]
[AIX] Adjust support of format function tests
escaped_output.unicode.pass.cpp is failing only on 32-bit AIX. The rest are passing.
Reviewed by: #libc, Mordante
Differential Revision: https://reviews.llvm.org/D149078
Kan Wu [Fri, 5 May 2023 23:29:50 +0000 (16:29 -0700)]
[MemProf] Add hot allocation type
Add "Hot" AllocationType (in addition to existing cold, notcold).
Use lifetime access density as metric to identify hot allocations.
Treat hot as notcold for MemProfContextDisambiguation for now
before the disambiguation for "hot" is done.
Reviewed By: tejohnson
Differential Revision: https://reviews.llvm.org/D149932
David Stone [Mon, 8 May 2023 17:27:36 +0000 (13:27 -0400)]
[clang][AST][NFC] Factor out check for structural equivalence of names.
We have four places that we try to decide which name to use for the
test for structural equivalence, and in each of those we evaluate
getTypedefNameForAnonDecl twice. Pull out the check into a function to
reduce duplication and evaluate things only once.
Differential Revision: https://reviews.llvm.org/D149981
Zhongyunde [Tue, 25 Apr 2023 11:36:12 +0000 (19:36 +0800)]
[MergeICmps] Adapt to non-eq comparisons, bugfix
Fix the last runtime issue as some sequent comparisons need be spilted.
For the origin equal comparisons chain, the new spilted Icmp chain will
still be end with equal, while for the new not-equal comparisons chain,
the new spilted Icmp chain will still be end with equal, so should address
this carefully, see detail wih case partial_sequent_ne
Thanks for @aeubanks, @glandium and @ayzhao report the runtime issue
and carefully examine.
Fix https://github.com/llvm/llvm-project/issues/59740.
Reviewed By: vitalybuka
Differential Revision: https://reviews.llvm.org/D141188
Valentin Clement [Mon, 8 May 2023 17:03:04 +0000 (10:03 -0700)]
[mlir][openacc] Cleanup acc.update from old data clause operands
Since the new data operand operations have been added in D148389 and
adopted on acc.update in D149909, the old clause operands are no longer
needed. This is a first patch to start cleaning the OpenACC operations
with data clause operands.
The `LegalizeDataOpForLLVMTranslation` will become obsolete when all
operations will be cleaned. For the time being only the appropriate
part are being removed.
`processOperands` will also receive some updates once all the operands
will be coming from an acc data operand operation.
Reviewed By: razvanlupusoru, jeanPerier
Differential Revision: https://reviews.llvm.org/D150053
Hans Wennborg [Mon, 8 May 2023 13:51:52 +0000 (15:51 +0200)]
Use LLVM-style include guard in regex_impl.h
The previous include guard (_REGEX_H_) is also used in a macOS SDK
header (xlocale.h), causing potential for trouble. This was previously
addressed in
2b8b90a7686858b1d22cae6fcfbd0904135112aa, but renaming the
macro in line with LLVM's other include guards seems like a better fix.
Differential revision: https://reviews.llvm.org/D150117
Craig Topper [Mon, 8 May 2023 16:52:52 +0000 (09:52 -0700)]
[RISCV] Implement shouldTransformSignedTruncationCheck.
This helps avoid constant materialization for the patterns
InstCombine emits for something like INT_MIN <= X && x <= INT_MAX.
See top of changed test files for more detailed explanation.
I've enabled this for i16 when Zbb is enabled. sext.b did not seem
to be a benefit due to the constants folding into addi/sltiu.
This an alternative to https://reviews.llvm.org/D149814
Reviewed By: reames
Differential Revision: https://reviews.llvm.org/D149977
Craig Topper [Mon, 8 May 2023 16:48:08 +0000 (09:48 -0700)]
[RISCV] Simplify matchRegisterNameHelper interface. NFC
This previously returned a bool to indicate success or failure and
returns a register through an output parameter.
Some callers used the bool to check for success. Some callers checked
for RISCV::NoRegister.
To make everything uniform, return the MCRegister directly and update
all callers to use MCRegister::isValid().
Reviewed By: barannikov88
Differential Revision: https://reviews.llvm.org/D150049
Dave Lee [Sun, 7 May 2023 23:51:59 +0000 (16:51 -0700)]
[lldb] Prevent mutation of CommandAlias::GetOptionArguments
Fix a mutation of `CommandAlias::m_option_args_sp`, which resulted in cases where
aliases would fail to run on second, and subsequent times.
For example, an alias such as:
```
command alias p1 p 1
```
When run the second time, the following error would be reported to the user:
```
error: expression failed to parse:
error: <user expression 1>:1:1: expression is not assignable
-- 1
^ ~
```
To fix this, `CommandAlias::Desugar` now constructs options to a freshly constructed
vector, rather than by appending to the results of `GetOptionArguments`.
rdar://
107770836
Differential Revision: https://reviews.llvm.org/D150078
Corentin Jabot [Sat, 6 May 2023 13:21:15 +0000 (15:21 +0200)]
[Clang] Improve compile times when forming a DeclRef outside of a capturing scope.
The logic of whether an entity needs to be captured has become
quite complex and the recent changes in https://reviews.llvm.org/D124351
ad a mesurable negative impact on compile times.
However, in the absence of capturing scopes (lambda, block, region)
we usually can avoid running most of that logic
(except that we do need to diagnostic when a nested function
refers to a local variable in the scope of the outer function.).
This patch track whether there is currently an active capturing
scope and exit `tryCaptureVariable` early when there isn't.
Reviewed By: aaron.ballman
Differential Revision: https://reviews.llvm.org/D150038
Jon Chesterfield [Mon, 8 May 2023 16:37:53 +0000 (17:37 +0100)]
[libc][rpc][nfc] Encapsulate access to outbox pointer
Reviewed By: jhuber6
Differential Revision: https://reviews.llvm.org/D150065
Valentin Clement [Mon, 8 May 2023 16:30:01 +0000 (09:30 -0700)]
[mlir][openacc] Add verifier for dataOperands on compute operations
Data operands associated with acc.parallel, acc.serial and
acc.kernels should comes from acc data entry/exit operations
or acc.getdeviceptr.
Reviewed By: razvanlupusoru, jeanPerier
Differential Revision: https://reviews.llvm.org/D149994
Valentin Clement [Mon, 8 May 2023 16:29:08 +0000 (09:29 -0700)]
[mlir][opeancc] Update acc.update verifier for dataOperands
Data operands associated with acc.update should comes
from acc data entry/exit operations or acc.getdeviceptr.
Reviewed By: razvanlupusoru
Differential Revision: https://reviews.llvm.org/D149990
Florian Hahn [Mon, 8 May 2023 16:28:50 +0000 (17:28 +0100)]
[VPlan] Record IR flags on VPWidenRecipe directly (NFC).
This patch introduces a VPRecipeWithIRFlags class to record various IR
flags for a recipe. This allows de-coupling of IR flags from the
underlying instructions. The main benefit is that it allows dropping of
IR flags from recipes directly, without the need to go through
State::MayGeneratePoisonRecipes. The plan is to remove
MayGeneratePoisonRecipes once all relevant recipes are transitioned.
It also allows dropping IR flags during VPlan-to-VPlan transforms, which
will be used in a follow-up patch to implement truncateToMinimalBitwidths
as VPlan-to-VPlan transform.
Reviewed By: Ayal
Differential Revision: https://reviews.llvm.org/D149079
Valentin Clement [Mon, 8 May 2023 16:28:13 +0000 (09:28 -0700)]
[mlir][openacc] Update acc.enter_data verifier for dataOperands
Data operands associated with acc.enter_data should comes
from acc data entry operations.
Reviewed By: razvanlupusoru
Differential Revision: https://reviews.llvm.org/D149991
Valentin Clement [Mon, 8 May 2023 16:26:34 +0000 (09:26 -0700)]
[mlir][openacc] Update acc.data verifier for dataOperands
Data operands associated with acc.data should comes
from acc data entry/exit operations or acc.getdeviceptr.
Reviewed By: razvanlupusoru
Differential Revision: https://reviews.llvm.org/D149992
Adrian Prantl [Mon, 8 May 2023 16:24:40 +0000 (09:24 -0700)]
Skip test when compiling with older versions of clang
Joseph Huber [Mon, 8 May 2023 13:38:24 +0000 (08:38 -0500)]
[libc] Make the opcode parameter a compile time constant
Currently the opcode is only valid if it is the same between all of the
ports. This is possible to violate if the opcode is places into a memory
location and then read in a non-uniform manner by the warp / wavefront.
Moving this to a compile time constant makes it impossible to break this
invariant.
Reviewed By: JonChesterfield
Differential Revision: https://reviews.llvm.org/D150115
Alvin Wong [Sat, 6 May 2023 18:28:44 +0000 (02:28 +0800)]
[X86][MC] Reject `call`/`jmp [offset fn_ref]` in Intel syntax
This syntax is confusing and likely invalid. In addition, MASM rejects
it and GAS seems to behave oddly with it. Therefore we shall reject this
syntax for both unconditional `call` and `jmp` instructions, as
discussed in D149579.
Depends on D150047
Differential Revision: https://reviews.llvm.org/D150048
Alvin Wong [Sat, 6 May 2023 15:27:59 +0000 (23:27 +0800)]
[X86][CodeGen] Do not add `offset` for memory reference using symbol
In the past, D71436 added writing the `offset` operator for some
legitimate cases. However, for memory references in Intel syntax, the
`offset` operator (`[offset sym]`) appears to be superfluous at best,
possibly wrong and contradictory at worst.
This patch bypasses writing the `offset` operator in
`X86AsmPrinter::PrintIntelMemReference` which affects exactly this
case. A similar code flow exists in `X86IntelInstPrinter.cpp` -
`X86IntelInstPrinter::printMemReference`.
The motivation for fixing this output is to allow us to reject the
confusing `call [offset fn_ref]` syntax in MC, as discussed in D149579.
Depends on D149579
Differential Revision: https://reviews.llvm.org/D150047
Alvin Wong [Mon, 1 May 2023 11:03:37 +0000 (19:03 +0800)]
[X86][MC] Fix parsing Intel syntax indirect branch with symbol only
Clang on Windows targets often requires indirect calls through the
import address table (IAT), and also .refptr stubs for MinGW target.
On 32-bit this generates assembly in the form of
`call dword ptr [__imp__func]`, which MC had failed to handle correctly.
64-bit targets are not affected because rip-relative addressing is used.
Reported on: https://github.com/llvm/llvm-project/issues/62010
Depends on D149695, D149920
Differential Revision: https://reviews.llvm.org/D149579
max [Sun, 7 May 2023 23:19:46 +0000 (18:19 -0500)]
[MLIR][python bindings] Add `PyValue.print_as_operand` (`Value::printAsOperand`)
Useful for easier debugging (no need to regex out all of the stuff around the id).
Differential Revision: https://reviews.llvm.org/D149902
Mehdi Amini [Fri, 21 Apr 2023 06:22:03 +0000 (00:22 -0600)]
Adopt Properties to store operations inherent Attributes in the Async dialect
This is part of an on-going migration to adopt Properties inside MLIR.
Differential Revision: https://reviews.llvm.org/D148883
Mehdi Amini [Fri, 21 Apr 2023 06:21:19 +0000 (00:21 -0600)]
Adopt Properties to store operations inherent Attributes in the ARMSVE dialect
This is part of an on-going migration to adopt Properties inside MLIR.
Differential Revision: https://reviews.llvm.org/D148882
Mehdi Amini [Fri, 21 Apr 2023 06:20:50 +0000 (00:20 -0600)]
Adopt Properties to store operations inherent Attributes in the ARMNeon dialect
This is part of an on-going migration to adopt Properties inside MLIR.
Differential Revision: https://reviews.llvm.org/D148881
Mehdi Amini [Fri, 21 Apr 2023 06:17:58 +0000 (00:17 -0600)]
Adopt Properties to store operations inherent Attributes in the AMX dialect
This is part of an on-going migration to adopt Properties inside MLIR.
Differential Revision: https://reviews.llvm.org/D148880
Mehdi Amini [Fri, 21 Apr 2023 05:36:14 +0000 (23:36 -0600)]
Adopt Properties to store operations inherent Attributes in the AMDGPU dialect
This is part of an on-going migration to adopt Properties inside MLIR.
Differential Revision: https://reviews.llvm.org/D148879
Mehdi Amini [Fri, 21 Apr 2023 05:04:00 +0000 (23:04 -0600)]
Adopt Properties to store operations inherent Attributes in the Affine dialect
This is part of an on-going migration to adopt Properties inside MLIR.
Differential Revision: https://reviews.llvm.org/D148878
Jonas Paulsson [Mon, 8 May 2023 13:46:36 +0000 (15:46 +0200)]
[MachineLateInstrsCleanup] Bugfix for handling of kill flags.
With
cb57b7a7, the kill flags are now tracked during the forward search over
the instructions and the call to findRegisterUseOperandIdx() should therefore
only check for killing uses.
As shown with the failing test CodeGen/Hexagon/vector-sint-to-fp.ll, it could
otherwise be the case that an undef use after the instruction that killed the
register will be inserted into MBBKills, and the kill flag will not be
cleared.
Teresa Johnson [Sat, 6 May 2023 14:14:56 +0000 (07:14 -0700)]
[MemProf] Control availability of hot/cold operator new from LTO link
Adds an LTO option to indicate that whether we are linking with an
allocator that supports hot/cold operator new interfaces. If not,
at the start of the LTO backends any existing memprof hot/cold
attributes are removed from the IR, and we also remove memprof metadata
so that post-LTO inlining doesn't add any new attributes.
This is done via setting a new flag in the module summary index. It is
important to communicate via the index to the LTO backends so that
distributed ThinLTO handles this correctly, as they are invoked by
separate clang processes and the combined index is how we communicate
information from the LTO link. Specifically, for distributed ThinLTO the
LTO related processes look like:
```
# Thin link:
$ lld --thinlto-index-only obj1.o ... objN.o -llib ...
# ThinLTO backends:
$ clang -x ir obj1.o -fthinlto-index=obj1.o.thinlto.bc -c -O2
...
$ clang -x ir objN.o -fthinlto-index=objN.o.thinlto.bc -c -O2
```
It is during the thin link (lld --thinlto-index-only) that we have
visibility into linker dependences and want to be able to pass the new
option via -Wl,-supports-hot-cold-new. This will be recorded in the
summary indexes created for the distributed backend processes
(*.thinlto.bc) and queried from there, so that we don't need to know
during those individual clang backends what allocation library was
linked. Since in-process ThinLTO and regular LTO also use a combined
index, for consistency we query the flag out of the index in all LTO
backends.
Additionally, when the LTO option is disabled, exit early from the
MemProfContextDisambiguation handling performed during LTO, as this is
unnecessary.
Depends on D149117 and D149192.
Differential Revision: https://reviews.llvm.org/D149215
Jake Egan [Mon, 8 May 2023 14:52:21 +0000 (10:52 -0400)]
[libc++][AIX] Remove LIBCXX-AIX-FIXME feature from test
This test was originally unsupported for `LIBCXX-AIX-FIXME` feature because we lacked `-fvisibility=hidden` support. AIX now has visibility support and the test passes in debug mode.
Reviewed By: #libc, Mordante
Differential Revision: https://reviews.llvm.org/D149255
Yonghong Song [Fri, 5 May 2023 21:41:13 +0000 (14:41 -0700)]
[Clang][BPF] Type print btf_type_tag properly
When running bcc tool execsnoop ([1]) which is built with latest llvm,
I hit the following error:
$ sudo ./execsnoop.py
/virtual/main.c:99:157: error: expected ')'
data.ppid = ({ typeof(pid_t) _val; __builtin_memset(&_val, 0, sizeof(_val)); bpf_probe_read(&_val, sizeof(_val),
(void *)&({ typeof(struct task_struct btf_type_tag(rcu)*) _val; __builtin_memset(&_val, 0, sizeof(_val));
^
bpf_probe_read(&_val, sizeof(_val), (void *)&task->real_parent); _val; })->tgid); _val; });
The failure reason is due to that the bcc rewriter printed type like
struct task_struct btf_type_tag(rcu)*
where the compiler cannot recognize what 'btf_type_tag(rcu)' is.
The above type is printed in [2] by UnaryOperator->getType().getAsString() (from clang)
in function ProbeVisitor::VisitUnaryOperator.
The original source type looks like ([3])
struct task_struct {
...
struct task_struct __rcu *real_parent;
...
}
where '__rcu' is a macro expanding to '__attribute__((btf_type_tag("rcu")))'.
Let us print btf_type_tag properly in clang so bcc tools and broader type printing
will work properly.
With this patch, the above rewrited source code looks like
data.ppid = ({ typeof(pid_t) _val; __builtin_memset(&_val, 0, sizeof(_val)); bpf_probe_read(&_val, sizeof(_val),
(void *)&({ typeof(struct task_struct __attribute__((btf_type_tag("rcu")))*) _val; __builtin_memset(&_val, 0, sizeof(_val));
bpf_probe_read(&_val, sizeof(_val), (void *)&task->real_parent); _val; })->tgid); _val; });
and execsnoop.py tool can run properly.
[1] https://github.com/iovisor/bcc/blob/master/tools/exitsnoop.py
[2] https://github.com/iovisor/bcc/blob/master/src/cc/frontends/clang/b_frontend_action.cc
[3] https://github.com/torvalds/linux/blob/master/include/linux/sched.h
Differential Revision: https://reviews.llvm.org/D150017
Simon Pilgrim [Mon, 8 May 2023 14:30:33 +0000 (15:30 +0100)]
[X86] vector-reduce-or-bool.ll - add common AVX prefix
Share with AVX512 to reduce duplication
Corentin Jabot [Sat, 6 May 2023 12:45:42 +0000 (14:45 +0200)]
[Clang] Correctly handle allocation in template arguments
Fixes #62462
Reviewed By: #clang-language-wg, erichkeane
Differential Revision: https://reviews.llvm.org/D150036
Dhruv Chawla [Mon, 8 May 2023 14:11:19 +0000 (16:11 +0200)]
[TargetLowering] Fix unnecessary call to `computeKnownBits` (NFCI)
In the SimplifyDemandedBits function, there is a fallthrough to the
default case in the case of ISD::ADD, ISD::MUL and ISD::SUB. This
leads to a call to computeKnownBits which is unnecessary as the
calls to SimplifyDemandedBits in the cases themselves handle the
calculation of the known bits. This information is discarded through
the Known2 variables.
By keeping this information around and calling
KnownBits::mul or KnownBits::computeForAddSub directly, the
unnecessary computation can be avoided. For now, the NSW bit is not
passed through to KnownBits as this is something that
computeKnownBits does not handle either. This requires updating
computeForAddCarry to handle the flag as well.
Differential Revision: https://reviews.llvm.org/D150110
Hristo Hristov [Sat, 6 May 2023 12:41:41 +0000 (15:41 +0300)]
[libc++][spaceship] Implement `operator<=>` for `array`
Implements part of P1614R2 "The Mothership has Landed"
Reviewed By: Mordante, #libc, philnik
Differential Revision: https://reviews.llvm.org/D132265
Samira Bazuzi [Mon, 8 May 2023 13:46:01 +0000 (13:46 +0000)]
[clang][dataflow] Remove deprecated pass-through APIs for DataflowAnalysisContext.
These were recently deprecated in https://reviews.llvm.org/D149464.
Reviewed By: ymandel, gribozavr2, xazax.hun
Differential Revision: https://reviews.llvm.org/D149869
Quentin Colombet [Mon, 8 May 2023 12:20:01 +0000 (14:20 +0200)]
[Transform] Support more case for the transform pad operation
Don't choke on `outs` arguments that are not produced by `tensor.empty` or
`tensor.extract_slice`.
When the `outs` argument has a static shape we have all the necessary
information to proceed with the padding.
This makes the `transform.structured.pad` a little bit more resilient.
Differential Revision: https://reviews.llvm.org/D150112
Tobias Gysi [Mon, 8 May 2023 13:27:49 +0000 (13:27 +0000)]
Revert "[mlir][mem2reg] Expose algorithm internals."
The commit causes build bot failures due to a missing dependencies:
https://buildkite.com/llvm-project/llvm-main/builds/7036#
0187fb40-e4b6-4471-a2a0-
2820b71c727b
This reverts commit
91cff8a71872cf49f0c5c9e5510f8065bfefa3c3.
Akshay Khadse [Mon, 8 May 2023 13:17:51 +0000 (21:17 +0800)]
Reapply [Coverity] Fix explicit null dereferences
This change fixes static code analysis errors
Reviewed By: skan
Differential Revision: https://reviews.llvm.org/D149506
Simon Pilgrim [Mon, 8 May 2023 12:50:26 +0000 (13:50 +0100)]
[X86] avx512-insert-extract.ll - add nounwind to silence cfi noise
Whitney Tsang [Mon, 8 May 2023 13:07:10 +0000 (06:07 -0700)]
[mlir][CallOpInterface] Add `setCalleeFromCallable` method
Currently `CallOpInterface` has a method `getCallableForCallee` to have a consistent way to get the callee from an operation with `CallOpInterface`, but missing a consistent way to set a callee for an operation with `CallOpInterface`.
A set callee method is useful for transformations that operate on `CallOpInterface`, and change the callee, e.g., a pass that specialize function, which clone the callee, and change the `CallOpInterface`'s callee to the cloned version. Without such method, transformation would need to understand the implementation for every operations with `CallOpInterface`, and have a type switch to handle them.
This review adds a method to set callee for operation with `CallOpInterface`.
Reviewed By: gysit, zero9178o
Differential Revision: https://reviews.llvm.org/D149763
Louis Dionne [Mon, 8 May 2023 12:59:01 +0000 (08:59 -0400)]
[libc++] Fix mistake in documentation of libcxx-lit script
Théo Degioanni [Mon, 8 May 2023 11:42:40 +0000 (11:42 +0000)]
[mlir][mem2reg] Expose algorithm internals.
This patch refactors the Mem2Reg infrastructure. It decouples
analysis from promotion, allowing for more control over the execution of
the logic. It also adjusts the interfaces to be less coupled to mem2reg
and more general. This will be useful for an upcoming revision
introducing generic SROA.
Reviewed By: gysit
Differential Revision: https://reviews.llvm.org/D149825
Jacques Pienaar [Mon, 8 May 2023 11:30:48 +0000 (04:30 -0700)]
[mlir][bytecode] Fix typo in DenseElementsAttr.
Was incorrectly marked as DenseIntElementsAttr (only used for
SparseElementsAttr).
Oleksandr "Alex" Zinenko [Mon, 8 May 2023 11:37:49 +0000 (13:37 +0200)]
[mlir] warn about passthrough in LLVM dialect doc
This mechanism has never been intended for anything but prototyping.
Mehdi Amini [Fri, 14 Apr 2023 04:40:24 +0000 (22:40 -0600)]
Adopt Properties to store operations inherent Attributes in the LLVM dialect
This is part of an on-going migration to adopt Properties inside MLIR.
Differential Revision: https://reviews.llvm.org/D148300
Sam McCall [Mon, 8 May 2023 11:07:11 +0000 (13:07 +0200)]
Reland "Give NullabilityKind a printing operator<<"
This reverts commit
5326c9e480d70e16c2504cb5143524aff3ee2605.
The problem that caused the revert was downstream
(missing dep in user of clang).
Wang, Xin10 [Mon, 8 May 2023 09:55:08 +0000 (05:55 -0400)]
Fix possible self assign issue for DIEValue
In DIEValue's operator assignment constructor, it didn't identify if
the two obj is the same.
I add code to identify them so that it will work correctly when we do
self assign here.
Reviewed By: skan
Differential Revision: https://reviews.llvm.org/D150020
Qiu Chaofan [Mon, 8 May 2023 09:51:36 +0000 (17:51 +0800)]
[PowerPC] Add target feature requirement to builtins
Clang has mechanism to specify required target features of a built-in
function. This patch adds such definitions to Altivec, VSX, HTM,
PairedVec and MMA builtins.
This will help frontend to detect incompatible target features of
bulitin when using target attribute syntax.
Reviewed By: nemanjai, kamaub
Differential Revision: https://reviews.llvm.org/D143467
Vassil Vassilev [Sun, 30 Apr 2023 17:23:04 +0000 (17:23 +0000)]
[clang-repl] Do not assert if we have weak references left.
Non-incremental Clang can also exit with the WeakRefReferences not empty upon
such example. This patch makes clang-repl consistent to what Clang does.
Differential revision: https://reviews.llvm.org/D148435
Job Noorman [Mon, 8 May 2023 08:05:46 +0000 (10:05 +0200)]
[JITLink][RISCV] Only generate PLT entries for external symbols
R_RISCV_CALL has been deprecated. [1] Both GCC and LLVM seem to not
generate it anymore and always use R_RISCV_CALL_PLT (even for calls that
do not need a PLT entry). Generating PLT entries based on relocation
type is not recommended and a better heuristic is to only generate them
when the target symbol is preemptable [2]. This patch implements this by
only generating PLT entries for undefined symbols.
[1] https://github.com/riscv-non-isa/riscv-elf-psabi-doc/pull/340
[2] https://github.com/riscv-non-isa/riscv-elf-psabi-doc/issues/98
Reviewed By: lhames
Differential Revision: https://reviews.llvm.org/D149525
eopXD [Mon, 8 May 2023 08:16:13 +0000 (01:16 -0700)]
[Clang][RISCV] Update vreinterpret.c test case with new script. NFC
Lorenzo Chelini [Fri, 5 May 2023 09:20:35 +0000 (11:20 +0200)]
[MLIR][Linalg] Rename `packElementWiseOp` to `packGenericOp` (NFC)
Commit
b4563ee17ce45728a323c2708e549627b0a8ee9c enabled propagation for
pack and unpack through non-elementwise operations, update comments and
methods names to reflect the changes made.
Rework some tests where the `linalg.generic` was reading from
`tensor.empty`, which is undefined behaviour.
Reviewed By: hanchung, qedawkins
Differential Revision: https://reviews.llvm.org/D149952
Vitaly Buka [Mon, 8 May 2023 07:47:53 +0000 (00:47 -0700)]
[NFC][ASAN] Sort includes
Vitaly Buka [Mon, 8 May 2023 07:47:36 +0000 (00:47 -0700)]
[NFC][ASAN] Add const to getter
sgokhale [Mon, 8 May 2023 07:51:07 +0000 (13:21 +0530)]
[CodeGen][ShrinkWrap] Split restore point
Try to reland D42600
Differential Revision: https://reviews.llvm.org/D42600
Vitaly Buka [Mon, 8 May 2023 07:41:22 +0000 (00:41 -0700)]
[test][lsan] Don't recompile the test
Vitaly Buka [Mon, 8 May 2023 07:31:10 +0000 (00:31 -0700)]
[test][sanitizer] Improve test expectation
Now we can fix sanitizers for the test one by one.
Vitaly Buka [Mon, 8 May 2023 07:26:39 +0000 (00:26 -0700)]
[test][sanitizer] Check pthread_create return value
Vitaly Buka [Mon, 8 May 2023 06:30:24 +0000 (23:30 -0700)]
[NFC][ASAN] Use alignof instead of constant
Vitaly Buka [Mon, 8 May 2023 06:29:48 +0000 (23:29 -0700)]
[NFC][ASAN] Extract ThreadRegistry initialization
Martin Braenne [Mon, 8 May 2023 06:38:42 +0000 (06:38 +0000)]
[clang][dataflow][NFC] Remove `SkipPast` parameter from `getStorageLocation(const ValueDecl &).
This parameter was already a no-op, so removing it doesn't change behavior.
Depends On D149144
Reviewed By: ymandel, xazax.hun, gribozavr2
Differential Revision: https://reviews.llvm.org/D149151
Jonas Paulsson [Sun, 2 Apr 2023 18:23:34 +0000 (20:23 +0200)]
[MachineLateInstrsCleanup] Improve compile time for huge functions.
It was discovered that this pass could be slow on huge functions, meaning 20%
compile time instead of the usual ~0.5% (with a test case spending ~19 mins
just in the backend).
The problem related to the necessary clearing of earlier kill flags when a
redundant instruction is removed. With this patch, the handling of kill flags
is now done by maintaining a map instead of scanning backwards in the
function. This remedies the compile time on the huge file fully.
Reviewed By: vpykhtin, arsenm
Differential Revision: https://reviews.llvm.org/D147532
Resolves https://github.com/llvm/llvm-project/issues/61397
sgokhale [Mon, 8 May 2023 06:55:51 +0000 (12:25 +0530)]
[CodeGen] Autogen tests as prerequisite for D42600
Autogenerating tests as suggested in D42600
WuXinlong [Mon, 8 May 2023 05:21:00 +0000 (13:21 +0800)]
[RISCV] Add MC support of RISCV zcmp Extension
This patch add the instructions of zcmp extension.
Instructions in zcmp extension try to optimise `mv` inst and the prologue & epilogue in functions
co-author: @Scott Egerton, @ZirconLiu, @Lukacma, @Heda Chen, @luxufan, @heyiliang, @liaochunyu
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D132819
Vitaly Buka [Mon, 8 May 2023 06:23:30 +0000 (23:23 -0700)]
[NFC][ASAN] Reformat the file
Noah Goldstein [Mon, 8 May 2023 05:34:39 +0000 (00:34 -0500)]
Revert "[InstCombine] Improve bswap + logic_op optimization"
The generic cast to `BinaryOperator` can break if `V` is not a
`BinaryOperator` (i.e a `ConstantExpr`). This occurs in things like
PPC linux build.
This reverts commit
fe733f54da6faca95070b36b1640dbca3e43d396.
LLVM GN Syncbot [Mon, 8 May 2023 05:27:42 +0000 (05:27 +0000)]
[gn build] Port
8d657c461a5a
Shengchen Kan [Sun, 7 May 2023 14:20:36 +0000 (22:20 +0800)]
[X86][AsmParser] Refactor code in AsmParser
1. Share code `optimizeInstFromVEX3ToVEX2` with MCInstLower
2. Move the code of optimization for shift/rotate to a separate file
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D150068
Joshua Cao [Tue, 25 Apr 2023 00:51:01 +0000 (17:51 -0700)]
[SCEV][reland] More precise trip multiples
We currently have getMinTrailingZeros(), from which we can get a SCEV's
multiple by computing 1 << MinTrailingZeroes. However, this only gets us
multiples that are a power of 2. This patch introduces a way to get max
constant multiples that are not just a power of 2. The logic is similar
to that of getMinTrailingZeros. getMinTrailingZerosImpl is replaced by
computing the max constant multiple, and counting the number of trailing
bits.
I have so far found this useful in two places:
1) Computing unsigned constant ranges. For example, if we have i8
{10,+,10}<nuw>, we know the max constant it can be is 250.
2) My original intent was to use this in getSmallConstantTripMultiples,
but it has no effect right now due to change from D110587. For
example, if we have backedge count `(6 * %N) - 1`, the trip count
becomes `1 + zext((6 * %N) - 1)`, and we cannot say that 6 is a
multiple of the SCEV. I plan to look further into this separately.
The implementation assumes the value is unsigned. It can probably be
extended to handle signed values as well.
If the code sees that a SCEV does not have <nuw>, it will fall back to
finding the max multiple that is a power of 2. Multiples that are a
power of 2 will still be a multiple even after the SCEV overflows. This
does not apply to other values. This is the 1st commit message:
---
This relands https://reviews.llvm.org/D141823. The verification fails
when expensive checks are turned on. This can occur when:
1. SCEV S's multiple is cached
2. SCEV S's no wrap flags are strengthened, and the multiple changes
3. SCEV verifier finds that S's cached and recomputed multiple are
different
We eliminate most cases by forgetting SCEVAddRecExpr's cached values
when the flags are modified, but there are still cases for other SCEV
types. We relax the check by making sure the cached multiple divides the
recomputed multiple, ensuring the cached multiple is correct,
conservative multiple.
Reviewed By: mkazantsev
Differential Revision: https://reviews.llvm.org/D149529
esmeyi [Mon, 8 May 2023 04:55:27 +0000 (00:55 -0400)]
[DWARF][MC] improve the error message when DwarfLineStrSection is null.
Summary: Currently the crush info is ambiguous when DwarfLineStrSection is null. The patch adds an assertion in the constructor of MCDwarfLineStr when DwarfLineStrSection is null.
Reviewed By: shchenz
Differential Revision: https://reviews.llvm.org/D149121
Fangrui Song [Mon, 8 May 2023 04:41:38 +0000 (21:41 -0700)]
[MC][ARM] Fix redundant errors for .quad/.8byte relocations on ELF
For a .quad/.8byte directive that needs a relocation, Mach-O emits one error
while ELF emits two. Emit just one for ELF and change the diagnostic to match
other ports.
Fangrui Song [Mon, 8 May 2023 03:57:07 +0000 (20:57 -0700)]
[MC] x86-32: properly report error for .quad relocation
Fix a llvm_unreachable crash in -DLLVM_ENABLE_ASSERTIONS=on builds and
possible accept-invalid in -DLLVM_ENABLE_ASSERTIONS=off builds.
wanglei [Mon, 8 May 2023 03:31:51 +0000 (11:31 +0800)]
[LoongArch] Add some comments to getBPReg. NFC
Fangrui Song [Mon, 8 May 2023 03:20:25 +0000 (20:20 -0700)]
[DWARFLinker] Remove an unused raw_svector_ostream
Fangrui Song [Mon, 8 May 2023 02:32:53 +0000 (19:32 -0700)]
MCDwarfFrameEmitter::EncodeAdvanceLoc: use SmallVectorImpl instead of raw_ostream. NFC
Similar to
49488490d195591bfc90daef111cd7293f8c80aa.
Remove MCDwarfFrameEmitter::EmitAdvanceLoc which is only called once.
LLVM GN Syncbot [Mon, 8 May 2023 01:38:47 +0000 (01:38 +0000)]
[gn build] Port
746cf7e38cc4
Nikolas Klauser [Sun, 7 May 2023 18:18:32 +0000 (11:18 -0700)]
[libc++] Use the __is_trivially_equality_comparable builtin
Reviewed By: ldionne, #libc
Spies: libcxx-commits
Differential Revision: https://reviews.llvm.org/D148553
Ian Anderson [Sun, 7 May 2023 00:26:49 +0000 (19:26 -0500)]
[libc++][Modules] Add missing includes and exports
Several headers are missing includes for things they use.
type_traits.is_enum needs to export type_traits.integral_constant so that clients can access its `value` member without explicitly including __type_traits/integral_constant.h themselves.
Make `subrange_fwd` a peer submodule to `subrange` rather than a submodule of it, and have `subrange` export `subrange_fwd`. That will make it easier to programmatically generate modules for the private detail headers, and it will accomplish the same effect that __ranges/subrange.h will make subrange_kind visible.
Reviewed By: Mordante, #libc
Differential Revision: https://reviews.llvm.org/D150055
Ian Anderson [Sun, 7 May 2023 00:50:33 +0000 (19:50 -0500)]
[libc++] test/libcxx/transitive_includes.sh.cpp dumps loads of unhelpful preprocessor output when it fails
Send stdout to dev/null since the preprocessor output isn't relevant to the test and is tons of noise when the test fails.
Reviewed By: Mordante, #libc, philnik
Differential Revision: https://reviews.llvm.org/D150056
Zhao Qi [Mon, 8 May 2023 00:40:06 +0000 (08:40 +0800)]
Reland D147524 "[LoongArch] Provide basic TargetTransformInfo implementation"
This patch only provides basic LoongArchTTIImpl, and more hooks
will be added to provide TTI machinery for LoongArch soon.
Reviewed By: SixWeining, xen0n
Differential Revision: https://reviews.llvm.org/D147524
Weining Lu [Mon, 8 May 2023 00:37:44 +0000 (08:37 +0800)]
Revert "[LoongArch] Provide basic TargetTransformInfo implementation"
This reverts commit
040a41a852933d3d1b855aebc8b054baa60f61e2.
Author name is wrong.
Roland McGrath [Sat, 6 May 2023 08:35:56 +0000 (01:35 -0700)]
[libc] Use Linux errno and signal strings for Fuchsia
The exact set of supported values is determined by the <errno.h>
and <signal.h> headers, which don't (yet) come from llvm-libc on
Fuchsia. The mappings of SIG* and E* codes to psignal/strsignal
and perror/strerror text used in Fuchsia libc today is the same
as for Linux.
Reviewed By: abrachet
Differential Revision: https://reviews.llvm.org/D150026
Noah Goldstein [Sun, 7 May 2023 21:46:49 +0000 (16:46 -0500)]
[KnownBits] Improve `KnownBits::rem(X, Y)` in cases where we can deduce low-bits of output
The first `cttz(Y)` bits in `X` are translated 1-1 in the output.
Alive2 Links:
https://alive2.llvm.org/ce/z/Qc47p7
https://alive2.llvm.org/ce/z/19ut5H
Reviewed By: RKSimon
Differential Revision: https://reviews.llvm.org/D149421
Noah Goldstein [Sun, 7 May 2023 21:46:46 +0000 (16:46 -0500)]
[KnownBits] Add tests for getting lowbits of `rem X, Y`; NFC
Reviewed By: foad
Differential Revision: https://reviews.llvm.org/D149420
Noah Goldstein [Sun, 7 May 2023 21:46:20 +0000 (16:46 -0500)]
[X86] Lower used `(atomicrmw xor p, SignBit)` as `(atomicrmw add p, SignBit)`
`(xor X, SignBit)` == `(add X, SignBit)`. For atomics whose result is
used, the `add` option is preferable because of the `xadd` instruction
which allows us to avoid either a CAS loop or a `btc; setcc; shl`.
Reviewed By: RKSimon
Differential Revision: https://reviews.llvm.org/D149689
Noah Goldstein [Sun, 7 May 2023 21:46:14 +0000 (16:46 -0500)]
[X86] Add tests for `(atomicrmw xor p, Imm)`; NFC
Reviewed By: RKSimon
Differential Revision: https://reviews.llvm.org/D149687
Arthur Eubanks [Sun, 7 May 2023 23:50:33 +0000 (16:50 -0700)]
Revert "[clang] Make predefined expressions string literals under -fms-extensions"
This reverts commit
856f384bf94513c89e754906b7d80fbe5377ab53.
Breaks bots, e.g. https://lab.llvm.org/buildbot/#/builders/123/builds/18775
Manoj Gupta [Sun, 7 May 2023 23:09:37 +0000 (16:09 -0700)]
Revert "[AArch64] Emit FNMADD instead of FNEG(FMADD)"
This reverts commit
ea228bd0bd0173ffd4aac497a312a852e8f7ffad.
Cuases a crash on AArch64. Testcase provided at D149260.
Fangrui Song [Sun, 7 May 2023 23:26:52 +0000 (16:26 -0700)]
[MC] MCDwarfLineAddr::Encode: use SmallVectorImpl instead of raw_ostream. NFC
Similar to D145791: most call sites need a SmallString, but have to provide a
raw_svector_ostream wrapper with unneeded abstraction and overhead:
raw_ostream::write =(inlinable)=> flush_tied_then_write (unneeded TiedStream check) =(virtual function call)=> raw_svector_ostream::write_impl ==> SmallVector append(ItTy in_start, ItTy in_end) (range; less efficient then push_back).
Just use SmallVectorImpl to simplify and optimize code. Unfortunately most call
sites use SmallString, so we have to use SmallVectorImpl<char> instead of
<uint8_t> to avoid large refactoring.
Vitaly Buka [Sun, 7 May 2023 23:12:04 +0000 (16:12 -0700)]
[NFC][HWASAN] Add more pthread interceptors
They are empty for now. Follow up patches will introduce behaviour
changes.
Vitaly Buka [Sat, 6 May 2023 21:50:34 +0000 (14:50 -0700)]
[NFC][LSAN] Add more pthread interceptors
They are empty for now. Follow up patches will introduce behaviour
changes.
Vitaly Buka [Sat, 6 May 2023 20:01:08 +0000 (13:01 -0700)]
[NFC][ASAN] Add more pthread interceptors
They are empty for now. Follow up patches will introduce behaviour
changes.
Vitaly Buka [Sun, 7 May 2023 06:58:32 +0000 (23:58 -0700)]
[NFC][HWASAN] Fix mutex in thread safety annotation