platform/upstream/dotnet/runtime.git
5 years agoAdd nullable annotations to System.Threading.Tasks ref assembly (dotnet/corefx#38265)
Santiago Fernandez Madero [Fri, 14 Jun 2019 03:13:21 +0000 (20:13 -0700)]
Add nullable annotations to System.Threading.Tasks ref assembly (dotnet/corefx#38265)

Commit migrated from https://github.com/dotnet/corefx/commit/3f94d610c133440eeb06f418540be6d8fd782ca0

5 years agoAdd nullable annotations to System.Threading.Thread ref assembly (dotnet/corefx#38236)
Santiago Fernandez Madero [Fri, 14 Jun 2019 00:10:11 +0000 (17:10 -0700)]
Add nullable annotations to System.Threading.Thread ref assembly (dotnet/corefx#38236)

Commit migrated from https://github.com/dotnet/corefx/commit/44d305e2f0a312bb0506e0e1ef1fcafeb07b2bb1

5 years agoAdd nullable annotations to System.Threading ref (dotnet/corefx#38223)
Santiago Fernandez Madero [Fri, 14 Jun 2019 00:09:44 +0000 (17:09 -0700)]
Add nullable annotations to System.Threading ref (dotnet/corefx#38223)

* Add nullable annotations to System.Threading

* Update nullable attributes

Commit migrated from https://github.com/dotnet/corefx/commit/6538c26973d574e9ef92790210f11d11fd2d750f

5 years agoDefine osx.10.15 RID (dotnet/corefx#38509)
Jeremy Barton [Fri, 14 Jun 2019 00:09:16 +0000 (17:09 -0700)]
Define osx.10.15 RID (dotnet/corefx#38509)

Commit migrated from https://github.com/dotnet/corefx/commit/2458de0ada6a2eac4c36cc07628f4e7b3a02ad73

5 years agoUpdate one annotation on System.Runtime ref assembly (dotnet/corefx#38529)
Santiago Fernandez Madero [Fri, 14 Jun 2019 00:08:49 +0000 (17:08 -0700)]
Update one annotation on System.Runtime ref assembly (dotnet/corefx#38529)

Commit migrated from https://github.com/dotnet/corefx/commit/b9bb7c8ec3c6011c0f5815edf38c211982193718

5 years agoEnable nullable context to System.Buffers (dotnet/corefx#38530)
Santiago Fernandez Madero [Fri, 14 Jun 2019 00:08:20 +0000 (17:08 -0700)]
Enable nullable context to System.Buffers (dotnet/corefx#38530)

Commit migrated from https://github.com/dotnet/corefx/commit/66d5a9410a2e163452e9e8b15328d3caf8c336d5

5 years agoUpdate corefx for compiler nullable attribute updates
Stephen Toub [Thu, 13 Jun 2019 20:55:11 +0000 (16:55 -0400)]
Update corefx for compiler nullable attribute updates

Commit migrated from https://github.com/dotnet/corefx/commit/3c129ac0340a3843ab5b00a9c730730e7b60729b

5 years agoTests for nullable reference types in Span apis (dotnet/corefx#38468)
Anirudh Agnihotry [Thu, 13 Jun 2019 22:14:00 +0000 (15:14 -0700)]
Tests for  nullable reference types in Span apis (dotnet/corefx#38468)

Commit migrated from https://github.com/dotnet/corefx/commit/159fbc07c938f5ee6f136c60559ca16dc295d859

5 years agoCorrecting some invalid array json inputs (dotnet/corefx#38323)
Anirudh Agnihotry [Thu, 13 Jun 2019 22:10:13 +0000 (15:10 -0700)]
Correcting some invalid array json inputs (dotnet/corefx#38323)

* correcting some invalid array json inputs

* adding comments and modifiers

* addressing feedback

* correcting issue number

Commit migrated from https://github.com/dotnet/corefx/commit/eaee16b5c9d3e020b5892a28a204ceb5da4d6a4a

5 years agoRemove inbox mark for both packages
Viktor Hofer [Thu, 13 Jun 2019 13:21:00 +0000 (15:21 +0200)]
Remove inbox mark for both packages

Commit migrated from https://github.com/dotnet/corefx/commit/2a26a601ca062223f36bfa0c4e51ea70cfd419f2

5 years agoAdd inbox for xamarin on ref context
Viktor Hofer [Wed, 12 Jun 2019 12:44:11 +0000 (14:44 +0200)]
Add inbox for xamarin on ref context

Commit migrated from https://github.com/dotnet/corefx/commit/1a4c723839585e8ffe82e508bc2a795dfa3fc4db

5 years agoAdd uap test target to ref context
Viktor Hofer [Wed, 12 Jun 2019 08:36:27 +0000 (10:36 +0200)]
Add uap test target to ref context

Commit migrated from https://github.com/dotnet/corefx/commit/5472beffe38d96b39639d57b8993de4064003433

5 years agoMark registration pkg inbox on Xamarin
Viktor Hofer [Wed, 12 Jun 2019 08:26:59 +0000 (10:26 +0200)]
Mark registration pkg inbox on Xamarin

Commit migrated from https://github.com/dotnet/corefx/commit/a57ca7747c2d67f63f5f5bb9eecb0cb4539d7ddc

5 years agoAdd uap configuration to registration tests
Viktor Hofer [Wed, 12 Jun 2019 08:25:42 +0000 (10:25 +0200)]
Add uap configuration to registration tests

Commit migrated from https://github.com/dotnet/corefx/commit/278614e178eaa7a185f8fa5930e5646175ce3fad

5 years agoRemove XamarinTfm support check
Viktor Hofer [Fri, 7 Jun 2019 22:31:07 +0000 (00:31 +0200)]
Remove XamarinTfm support check

Commit migrated from https://github.com/dotnet/corefx/commit/07778aa8dd42b456f1f932f54e0dd2bf3890c597

5 years agoRetarget RefContext and CompRegistration to NS2.1
Viktor Hofer [Tue, 4 Jun 2019 08:45:56 +0000 (10:45 +0200)]
Retarget RefContext and CompRegistration to NS2.1

Commit migrated from https://github.com/dotnet/corefx/commit/97a07058b7cdb4f066fd81562102a44adbde5338

5 years agoMove to up2date macOS pool
Viktor Hofer [Thu, 13 Jun 2019 15:54:11 +0000 (17:54 +0200)]
Move to up2date macOS pool

Commit migrated from https://github.com/dotnet/corefx/commit/6ea902fc02ed698e190fd891416677f51ac3770c

5 years agoChange test matrix and exclude arm64 from PRs
Viktor Hofer [Tue, 11 Jun 2019 21:19:36 +0000 (23:19 +0200)]
Change test matrix and exclude arm64 from PRs

Commit migrated from https://github.com/dotnet/corefx/commit/292042bc9f66778ec3424f394a20e11982e853d5

5 years agoIncrease work item timeout for arm64
Viktor Hofer [Tue, 11 Jun 2019 19:56:45 +0000 (21:56 +0200)]
Increase work item timeout for arm64

Commit migrated from https://github.com/dotnet/corefx/commit/f62a52674e3372d2adcda3e6d43bbc9e881088c3

5 years agoIncrease timeout on Linux
Viktor Hofer [Fri, 7 Jun 2019 15:39:52 +0000 (17:39 +0200)]
Increase timeout on Linux

Commit migrated from https://github.com/dotnet/corefx/commit/24d08259fba225f946a0fa3f0766183f7b019a0d

5 years agoFix stray non-surrogate char handling in TextEncoder (dotnet/corefx#38328)
Abhi Agarwal [Thu, 13 Jun 2019 18:00:18 +0000 (23:30 +0530)]
Fix stray non-surrogate char handling in TextEncoder (dotnet/corefx#38328)

Fixes issue https://github.com/aspnet/AspNetCore/issues/10573

Commit migrated from https://github.com/dotnet/corefx/commit/a741bb2d6b98773123b0d4578ec2a5f654313576

5 years ago[3.0 Bug fix]JsonSerializer.Parse throws for UInt64 backed enum with value -1 (dotnet...
Marco Rossignoli [Thu, 13 Jun 2019 17:10:01 +0000 (19:10 +0200)]
[3.0 Bug fix]JsonSerializer.Parse throws for UInt64 backed enum with value -1 (dotnet/corefx#38373)

* fix ulong enum converter

* save work

* address PR feedback

* add more tests

* remove -1 = Max support for unsigned

* address PR fedback

* update tests

* address PR feedback

* address PR feedback

* address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/42e11c64d878d5875dbc6f5d228cb034ee4b2e59

5 years ago[master] Update dependencies from dotnet/coreclr (dotnet/corefx#38505)
dotnet-maestro[bot] [Thu, 13 Jun 2019 16:33:31 +0000 (16:33 +0000)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#38505)

* Update dependencies from https://github.com/dotnet/coreclr build 20190612.2

- Microsoft.NET.Sdk.IL - 3.0.0-preview7.19312.2
- Microsoft.NETCore.ILAsm - 3.0.0-preview7.19312.2
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview7.19312.2

* Fix build errors

Commit migrated from https://github.com/dotnet/corefx/commit/5955ee2583d4509d37ecf55243e9e3c9af128487

5 years agoAdd [DebuggerDisplay] to Json types (dotnet/corefx#38275)
Jeremy Kuhne [Thu, 13 Jun 2019 05:58:08 +0000 (22:58 -0700)]
Add [DebuggerDisplay] to Json types (dotnet/corefx#38275)

* Add [DebuggerDisplay] to Json types

Note that there is an issue with turning the TokenType to string in Utf8JsonReader. Probably reflection related? I've been unable to create a more focused repro.

* Add some simple sanity tests

* Address some feedback.

* Use JsonValueType

Commit migrated from https://github.com/dotnet/corefx/commit/b506d4a4ff6ffe1a1877016811e2266eacc2ebbc

5 years agoAdd nullable annotations to System.Collections ref assembly (dotnet/corefx#38128)
Santiago Fernandez Madero [Thu, 13 Jun 2019 05:33:18 +0000 (00:33 -0500)]
Add nullable annotations to System.Collections ref assembly (dotnet/corefx#38128)

* Add nullable annotations to System.Collections ref assembly

* Run GenAPI again with correct attributes format and output

* Enable nullable to project

* Apply nullable feedback, include attributes and object constraint to notnull

Commit migrated from https://github.com/dotnet/corefx/commit/cc8137ede09cdf16811767a6fb262fb498d85e67

5 years agoDisable Socket_SendReceiveAsync_PropagateToStream_Success test on Windows (dotnet...
Stephen Toub [Thu, 13 Jun 2019 02:19:37 +0000 (22:19 -0400)]
Disable Socket_SendReceiveAsync_PropagateToStream_Success test on Windows (dotnet/corefx#38496)

It's hanging sporadically in CI.

Commit migrated from https://github.com/dotnet/corefx/commit/4d1a20fedc6d99c3dd9192359cad07b19def5cb9

5 years agoUpdating the OS matrix for CI
Jeremy Barton [Thu, 13 Jun 2019 01:39:28 +0000 (18:39 -0700)]
Updating the OS matrix for CI

PRs:
* Remove Debian 8 (not supported in 3.0)
* Add Debian 9 (minimum supported Debian in 3.0)
* Remove openSUSE 42 (end of support this month)
* Add SLES 15 (best upgrade for openSUSE 42)
* Remove Fedora 28 (end of support)
* Add Fedora 29 (best supported version)
* Remove macOS 10.12 (not supported in 3.0, effective end of support)

Full Runs:
* Remove Debian 8 (not supported in 3.0)
* Remove Ubuntu 18.10 (end of support next month)
* Remove openSUSE 42 (end of support this month)
* Remove Fedora 28 (end of support)
* Remove macOS 10.12 (not supported in 3.0, effective end of support)
* Add Windows 10 1903 ("19H1") (current release)

Commit migrated from https://github.com/dotnet/corefx/commit/dda4588873cde2740d15e32749ccfd13eb33db07

5 years agoAdd nullable annotations to System.Runtime.Extensions ref (dotnet/corefx#37905)
Santiago Fernandez Madero [Thu, 13 Jun 2019 01:00:32 +0000 (20:00 -0500)]
Add nullable annotations to System.Runtime.Extensions ref (dotnet/corefx#37905)

* Add nullable annotations to System.Runtime.Extensions ref

* Reflect nullable annotations now with attributes

* Address feedback from API Review

* Fix build errors after re-base

* Fix FrameworkName IEquatable implementation to be oblivous

Commit migrated from https://github.com/dotnet/corefx/commit/8ef985fa7c4fd2333a2d905e3f1f9f93e49c002f

5 years agoExpose and test Timer.ActiveCount
Koundinya Veluri [Mon, 10 Jun 2019 21:24:55 +0000 (14:24 -0700)]
Expose and test Timer.ActiveCount

- Depends on https://github.com/dotnet/coreclr/pull/25061
- Fixes https://github.com/dotnet/corefx/issues/38422

Commit migrated from https://github.com/dotnet/corefx/commit/e2c3de82029f2187b3b0ad36a060e5f7e2ac0e93

5 years agoAdd nullable annotations to System.Runtime.Intrinsics ref assembly (dotnet/corefx...
Santiago Fernandez Madero [Wed, 12 Jun 2019 22:20:28 +0000 (17:20 -0500)]
Add nullable annotations to System.Runtime.Intrinsics ref assembly (dotnet/corefx#37944)

Commit migrated from https://github.com/dotnet/corefx/commit/550c5f5fcc9d5b552be749a1b0c49d6f31e38ade

5 years agoDisable PerformanceCounter_NextValue_ProcessorCounter test (dotnet/corefx#38488)
Stephen Toub [Wed, 12 Jun 2019 19:59:17 +0000 (15:59 -0400)]
Disable PerformanceCounter_NextValue_ProcessorCounter test (dotnet/corefx#38488)

Commit migrated from https://github.com/dotnet/corefx/commit/cb52d275492b968a68245c3fe6ed0324acd5581c

5 years ago[master] Update dependencies from dotnet/arcade (dotnet/corefx#38474)
dotnet-maestro[bot] [Wed, 12 Jun 2019 17:41:32 +0000 (10:41 -0700)]
[master] Update dependencies from dotnet/arcade (dotnet/corefx#38474)

* Update dependencies from https://github.com/dotnet/arcade build 20190611.2

- Microsoft.DotNet.XUnitExtensions - 2.4.1-beta.19311.2
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.19311.2
- Microsoft.DotNet.VersionTools.Tasks - 1.0.0-beta.19311.2
- Microsoft.DotNet.ApiCompat - 1.0.0-beta.19311.2
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19311.2
- Microsoft.DotNet.Build.Tasks.Configuration - 1.0.0-beta.19311.2
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19311.2
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19311.2
- Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19311.2
- Microsoft.DotNet.CoreFxTesting - 1.0.0-beta.19311.2
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19311.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19311.2
- Microsoft.DotNet.RemoteExecutor - 1.0.0-beta.19311.2
- Microsoft.DotNet.GenFacades - 1.0.0-beta.19311.2

* Update `where T : object` constraint to be `where T : notnull`

* Update several TODO-NULLABLE comments

Commit migrated from https://github.com/dotnet/corefx/commit/28efaabc4349d11a95f8f31eb932c84f207916ab

5 years agoImprove performance Enumerable.Min() (dotnet/corefx#38393)
Tim [Wed, 12 Jun 2019 16:52:10 +0000 (00:52 +0800)]
Improve performance Enumerable.Min() (dotnet/corefx#38393)

* Fix Enumerable.Min() visit more elements for float sequence leading with NaN. (dotnet/corefx#38392)

* Remove unnecessary comments in tests.

* Use explicit type instead of var.

* Return nullable value instead of valueVal.

Commit migrated from https://github.com/dotnet/corefx/commit/09c7058715b16fe3ec854f5436306b483ddfe16d

5 years agoAdd regression test for SafeSocketHandle getting collected (dotnet/corefx#38471)
Stephen Toub [Wed, 12 Jun 2019 16:48:57 +0000 (12:48 -0400)]
Add regression test for SafeSocketHandle getting collected (dotnet/corefx#38471)

* Add regression test for SafeSocketHandle getting collected

* Uncomment ActiveIssue for Unix

Commit migrated from https://github.com/dotnet/corefx/commit/506700913df9cd22ea13c097cfb2834f8a15677e

5 years agoremoved wrong build instructions for openssl tuning (dotnet/corefx#38458)
Castaneda1914 [Wed, 12 Jun 2019 16:47:47 +0000 (19:47 +0300)]
removed wrong build instructions for openssl tuning (dotnet/corefx#38458)

Commit migrated from https://github.com/dotnet/corefx/commit/28c41fff6f830b8393fd6c7661f33f96aa27f965

5 years agoHPACK fixes and tests (dotnet/corefx#38324)
Cory Nelson [Wed, 12 Jun 2019 16:46:28 +0000 (09:46 -0700)]
HPACK fixes and tests (dotnet/corefx#38324)

* HPACK correctness tests/updates. Resolves dotnet/corefx#31316.

Fixes:
- Fix check allowing out-of-bounds write in IntegerEncoder when an integer requires more than one byte and there is not enough buffer space.
- Encode Content-Type with a "Literal Header Without Indexing -- Indexed Name" rather than with a literal name.

Updates: (ported from ASP.NET HPACK code)
- Dynamic table size update must be the first instruction in the header block. Throw an exception when not the case.
- Throw an exception when we've reached the end of header data and we are still mid-parse.

New:
- Asserts, documentation, and tests for IntegerEncoder and IntegerDecoder.
- Tests to verify HttpClient is correctly encoding the different variants of headers.
- HPackDecoder tests (ported from ASP.NET)

* Address review feedback and fix CI.

* Address review feedback.

* Fix licensing to use ASP.NET's licensing. Add a TPN.

Commit migrated from https://github.com/dotnet/corefx/commit/ed526597f3f0d4653588ba0129fcaf18e2e5a4ef

5 years agoDon't swallow OCE unconditionally (dotnet/corefx#38473)
David Fowler [Wed, 12 Jun 2019 16:09:54 +0000 (09:09 -0700)]
Don't swallow OCE unconditionally (dotnet/corefx#38473)

- Today we swallow OperationCanceledExceptions to avoid throwing if CancelPendingRead/CancelPendingFlush, this unintentionally swallows all exceptions that derive from OperationCancelled that were triggered by the ReadAsync call itself. This change rethrows the error unless we're in that specific case of having called one of those Cancel* methods.
- Added tests and did some other small test cleanup.

Commit migrated from https://github.com/dotnet/corefx/commit/b3d3267abca4ae5bd8d4542a02c08a3173ae1ab9

5 years ago[3.0 System.Text.Json]JsonExtensionData should allow non-JsonElement types during...
Marco Rossignoli [Wed, 12 Jun 2019 15:08:09 +0000 (17:08 +0200)]
[3.0 System.Text.Json]JsonExtensionData should allow non-JsonElement types during serialization (dotnet/corefx#38306)

* fix serialization

* serialize all as dictionary

* address PR feedback

* address PR feedback

* remove redundant test

Commit migrated from https://github.com/dotnet/corefx/commit/4e16caa67a6b15ce270c231720177818f50f1f84

5 years agoAdd AppDomain.CurrentDomain event asserts (dotnet/corefx#38351)
Steve MacLean [Wed, 12 Jun 2019 06:12:34 +0000 (02:12 -0400)]
Add AppDomain.CurrentDomain event asserts (dotnet/corefx#38351)

Add assets related to AppDomain events
Remove ApiCompat workaround

Commit migrated from https://github.com/dotnet/corefx/commit/f5399d9d24536697a3bc36339e13ba085fc28938

5 years agoEnsure JSON TryGetXXX sets values to default if returning false dotnet/corefx#37119...
Christopher Watford [Wed, 12 Jun 2019 06:01:10 +0000 (02:01 -0400)]
Ensure JSON TryGetXXX sets values to default if returning false dotnet/corefx#37119 (dotnet/corefx#37838)

* Add tests to ensure TryGetXXX returns default on false dotnet/corefx#37119

* Ensure TryGetXXX value is default when result is false dotnet/corefx#37119

* Ensure JsonDocument's TryGetXXX use default value on false dotnet/corefx#37119

* Ensure value never leaks on exception path per PR review

- Also use `0` with non-generic default assignments to primitive number types per PR review

Commit migrated from https://github.com/dotnet/corefx/commit/f2c2e2f5907c66f9c4912db55f2cb34923059ea6

5 years agoAdd nullable annotations to System.Runtime (dotnet/corefx#37855)
Santiago Fernandez Madero [Wed, 12 Jun 2019 04:56:16 +0000 (23:56 -0500)]
Add nullable annotations to System.Runtime (dotnet/corefx#37855)

* Add nullable annotations to System.Runtime

* Update to use Nullable property with new compiler

* Fix annotations from API Review

* Address nullable feedback from API Review

* Fix more nullable annotations based on review

* More attributes from review and annotate Uri members

* Enable covariant and contravariant nullable annotation mismatch warnings globally

* Fix build

Commit migrated from https://github.com/dotnet/corefx/commit/aa3a6f2b169a82c44007d84aec57050abd5eeb07

5 years agoUse HTTP Host header for Kerberos auth SPN calculation (dotnet/corefx#38465)
David Shulman [Wed, 12 Jun 2019 02:53:55 +0000 (19:53 -0700)]
Use HTTP Host header for Kerberos auth SPN calculation (dotnet/corefx#38465)

Fixed SocketsHttpHandler so that it will use the request's Host header,
if present, as part of building the Service Principal Name (SPN) when
doing Kerberos authentication. This now matches .NET Framework behavior.

Contributes to dotnet/corefx#34697 and dotnet/corefx#27745

Commit migrated from https://github.com/dotnet/corefx/commit/6cb854630083aac733d5b8001b266b872b56748e

5 years agoAddress System.Runtime and System.Runtime.Extensions nullable feedback (dotnet/corefx...
Santiago Fernandez Madero [Tue, 11 Jun 2019 21:52:22 +0000 (16:52 -0500)]
Address System.Runtime and System.Runtime.Extensions nullable feedback (dotnet/corefx#38459)

* Address System.Runtime and System.Runtime.Extensions nullable feedback

* PR Feedback

Commit migrated from https://github.com/dotnet/corefx/commit/e3dd986b1ba2ec80bba84aee5a4b4527db087ce2

5 years agoRemove flaky asserts in Marshal.R/WInt16 tests. (dotnet/corefx#38464)
Jeremy Koritzinsky [Tue, 11 Jun 2019 20:56:09 +0000 (13:56 -0700)]
Remove flaky asserts in Marshal.R/WInt16 tests. (dotnet/corefx#38464)

Commit migrated from https://github.com/dotnet/corefx/commit/e02b99b0997ec496873c844b72fccf03b1cca8d5

5 years ago[master] Update dependencies from dotnet/coreclr (dotnet/corefx#38449)
dotnet-maestro[bot] [Tue, 11 Jun 2019 20:02:32 +0000 (13:02 -0700)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#38449)

* Update dependencies from https://github.com/dotnet/coreclr build 20190610.2

- Microsoft.NET.Sdk.IL - 3.0.0-preview7.19310.2
- Microsoft.NETCore.ILAsm - 3.0.0-preview7.19310.2
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview7.19310.2

* Fix Debug.Print tests after Corelib bug fix

Commit migrated from https://github.com/dotnet/corefx/commit/5ccac16eb797202ce4b7b9e375f769ce31c1005b

5 years agoChange EstablishConnectionAndProcessOneRequestAsync test method to use WhenAllOrAnyFa...
Stephen Toub [Tue, 11 Jun 2019 20:01:14 +0000 (13:01 -0700)]
Change EstablishConnectionAndProcessOneRequestAsync test method to use WhenAllOrAnyFailed (dotnet/corefx#38462)

* Change EstablishConnectionAndProcessOneRequestAsync test method to use WhenAllOrAnyFailed

CI is currently hanging when the client operation fails in a way that the server never hears about the request, and waits forever.

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/0b5479dde70fc565c5edefac4259578865496e84

5 years agoProvide more exception details when PlatformDetection.ToVersion fails (dotnet/corefx...
Stephen Toub [Tue, 11 Jun 2019 20:00:42 +0000 (13:00 -0700)]
Provide more exception details when PlatformDetection.ToVersion fails (dotnet/corefx#38463)

Commit migrated from https://github.com/dotnet/corefx/commit/49b6ade10a35e44573da6e851bc09133d5922c0a

5 years agoRemove allocation for empty Activity.Baggage/Tags (dotnet/corefx#38389)
Stephen Toub [Tue, 11 Jun 2019 18:28:40 +0000 (11:28 -0700)]
Remove allocation for empty Activity.Baggage/Tags (dotnet/corefx#38389)

Accessing Activity.Baggage/Tags allocates an enumerable, even when there is no baggage or tags.  This fast-paths the empty case.

Commit migrated from https://github.com/dotnet/corefx/commit/ec93eb4e8a0b225c1bfca093396328e6ba1fe9d2

5 years agoResolves dotnet/corefx#37250. Re-enable tests that dotnet/corefx#38038 resolved....
Cory Nelson [Tue, 11 Jun 2019 18:11:16 +0000 (11:11 -0700)]
Resolves dotnet/corefx#37250. Re-enable tests that dotnet/corefx#38038 resolved. (dotnet/corefx#38461)

Commit migrated from https://github.com/dotnet/corefx/commit/5f5925c0c1a3a87e870db36ca6acce81dedf3bc9

5 years agoFix several comparison issues in ConcurrentBag (dotnet/corefx#38424)
Stephen Toub [Tue, 11 Jun 2019 15:34:32 +0000 (08:34 -0700)]
Fix several comparison issues in ConcurrentBag (dotnet/corefx#38424)

A failed assert now and again in CI highlighted that we weren't properly accounting for overflows in ConcurrentBag.  In a variety of cases we compare the head position to the tail position, e.g. `head < tail` to determine if there are items in the queue, but in some situations when a position is temporarily updated, head can temporarily progress beyond tail, and if it does and wraps around due to overflow, we can end up in a situation where the condition passes even though it shouldn't.  This fixes all of the comparisons to do the subtraction and compare to 0, to avoid the overflow issue.

Separately, TrySteal had an inverted condition that was checking whether the queue contained at least 2 elements rather than checking whether it contained <= 2.  Also fixed that by inverting the check, along with doing the comparison appropriately per the above.

Commit migrated from https://github.com/dotnet/corefx/commit/56496a6dc2583db7ec82e779235813e0b8d32611

5 years agoMake it so GenAPI is only used during online source build (dotnet/corefx#38433)
Eric StJohn [Tue, 11 Jun 2019 15:17:34 +0000 (08:17 -0700)]
Make it so GenAPI is only used during online source build (dotnet/corefx#38433)

Commit migrated from https://github.com/dotnet/corefx/commit/548e58ebe2346c04a3353a53e6d8c64ab38198d0

5 years ago[3.0 Bug fix]Fix JsonSerializer.WriteAsync (dotnet/corefx#38308)
Marco Rossignoli [Tue, 11 Jun 2019 04:56:58 +0000 (06:56 +0200)]
[3.0 Bug fix]Fix JsonSerializer.WriteAsync (dotnet/corefx#38308)

* fix serialization

* create tailored test

* cleanup namespace

* address some feedback

* add poco test

* update test

* simplify loop

Commit migrated from https://github.com/dotnet/corefx/commit/bab7cea4e612c8d0bd13b4a52a2c91ec974f4e96

5 years agoAdd debug state machine tracking to GoAwayFrame_NoPendingStreams_ConnectionClosed...
Stephen Toub [Tue, 11 Jun 2019 03:22:05 +0000 (20:22 -0700)]
Add debug state machine tracking to GoAwayFrame_NoPendingStreams_ConnectionClosed test (dotnet/corefx#38438)

Commit migrated from https://github.com/dotnet/corefx/commit/0b0df51dab6f641e2988846dd6913de2db30789c

5 years agoFix review comments in dotnet/corefx#38280 (dotnet/corefx#38406)
Liudmila Molkova [Tue, 11 Jun 2019 02:09:37 +0000 (19:09 -0700)]
Fix review comments in dotnet/corefx#38280 (dotnet/corefx#38406)

Commit migrated from https://github.com/dotnet/corefx/commit/6d37591d13dd58abc90b7f15b707f605e809be29

5 years agoRework Linux/Kerberos native interop layer (dotnet/corefx#38377)
David Shulman [Tue, 11 Jun 2019 02:06:08 +0000 (19:06 -0700)]
Rework Linux/Kerberos native interop layer (dotnet/corefx#38377)

The latest changes to the System.Net.Security.Native shim layer fixed a lot of important
bugs for Linux Kerberos usage. But this created a new problem since SqlClient ships
in out-of-band NuGet packages separate from the .NET Core runtime. SqlClient builds
out of the CoreFx repo and uses the common source includes for Kerberos authentication.
This created an unexpected dependency on the System.Net.Security.Native shim layer.
The recent changes to these API signatures caused problems with different combinations
of SqlClient NuGet packages and .NET Core 2.x versus .NET Core 3.0.

After discussion with the SqlClient team, we decided to rework the changes to these
native APIs so that they would remain compatible across all .NET Core versions.

Long-term, the plan is to implement dotnet/corefx#36896 to expose a Kerberos API in .NET Core which
could be used by SqlClient and other consumers.

Closes dotnet/corefx#37183
Closes dotnet/corefx#25205

Commit migrated from https://github.com/dotnet/corefx/commit/7f920b2984a97ce8643bc8e64a93e7bd4d8a059e

5 years agoUpdate System.Runtime.Caching owner to Steve (dotnet/corefx#38429)
Hong Li [Tue, 11 Jun 2019 01:01:20 +0000 (18:01 -0700)]
Update System.Runtime.Caching owner to Steve (dotnet/corefx#38429)

Commit migrated from https://github.com/dotnet/corefx/commit/9a42e7974e2cb99cec9cf30058d8681542186e09

5 years agoSome tests imported from Newtonsoft Json (dotnet/corefx#38153)
buyaa-n [Tue, 11 Jun 2019 00:51:30 +0000 (17:51 -0700)]
Some tests imported from Newtonsoft Json (dotnet/corefx#38153)

Tests imported from Newtonsoft Json

Commit migrated from https://github.com/dotnet/corefx/commit/ff6ce7de1c206a5d552d98395b22f47a8eba368e

5 years agoAdd System.Text.Encoding.CodePages library to the shared framework (dotnet/corefx...
Tarek Mahmoud Sayed [Mon, 10 Jun 2019 22:48:13 +0000 (23:48 +0100)]
Add System.Text.Encoding.CodePages library to the shared framework (dotnet/corefx#38357)

* Add System.Text.Encoding.CodePages library to the shared framework

* Temporarily suppress check for CodePages on netcoreapp3.0

Commit migrated from https://github.com/dotnet/corefx/commit/b3663523e0c0705600042e327150fab88ccebae3

5 years agoAdd more packages to Microsoft.Windows.Compatibility (dotnet/corefx#38352)
Eric StJohn [Mon, 10 Jun 2019 19:35:53 +0000 (12:35 -0700)]
Add more packages to Microsoft.Windows.Compatibility (dotnet/corefx#38352)

Commit migrated from https://github.com/dotnet/corefx/commit/687ec698a4120a818dc8860bebfcd7a91df9a572

5 years agoRevert "Enable test for MemoryBarrierProcessWide on ARM64." (dotnet/corefx#38401)
Stephen Toub [Mon, 10 Jun 2019 15:17:56 +0000 (11:17 -0400)]
Revert "Enable test for MemoryBarrierProcessWide on ARM64." (dotnet/corefx#38401)

* Revert "Enable test for MemoryBarrierProcessWide on ARM64. (dotnet/corefx#38386)"

This reverts commit dotnet/corefx@7e56d8bd8b224d834b782a98bfd7035f71c3f547.

* Update comment for new issue number

Commit migrated from https://github.com/dotnet/corefx/commit/8135319caa7e457ed61053ca1418313b88057b51

5 years agoEnable test for MemoryBarrierProcessWide on ARM64. (dotnet/corefx#38386)
Vladimir Sadov [Sun, 9 Jun 2019 22:29:56 +0000 (15:29 -0700)]
Enable test for MemoryBarrierProcessWide on ARM64. (dotnet/corefx#38386)

* Enable test for MemoryBarrierProcessWide on ARM64 since corresponding bug is closed.

Re:https://github.com/dotnet/coreclr/issues/20215

Commit migrated from https://github.com/dotnet/corefx/commit/7e56d8bd8b224d834b782a98bfd7035f71c3f547

5 years agoadd cancellation tests
campersau [Fri, 7 Jun 2019 13:50:16 +0000 (15:50 +0200)]
add cancellation tests

Commit migrated from https://github.com/dotnet/corefx/commit/46d9f33d96a1db41a9634b84dd68256db2eeed4f

5 years agoPass CancellationToken to DbDataReader
campersau [Fri, 7 Jun 2019 08:58:20 +0000 (10:58 +0200)]
Pass CancellationToken to DbDataReader

Commit migrated from https://github.com/dotnet/corefx/commit/2cae0df3a727ea1d8965978c8f3b0ffb3756de78

5 years agoAugment GetStateMachineData to recur (dotnet/corefx#38376)
Stephen Toub [Sun, 9 Jun 2019 09:40:35 +0000 (05:40 -0400)]
Augment GetStateMachineData to recur (dotnet/corefx#38376)

The GetStateMachineData test helper I previously added only output the top-level state machine's fields.  This change causes it to recur into awaiters, so we can get more details on exactly what's being awaited and what's causing a hang.

Commit migrated from https://github.com/dotnet/corefx/commit/48c3adf8ad0256689375060437c2e6262d5e805a

5 years agoAdded LeaveOpen option to StreamPipeReader and StreamPipeWriter. (dotnet/corefx#37667)
Anatoly Zhmur [Sun, 9 Jun 2019 06:34:08 +0000 (08:34 +0200)]
Added LeaveOpen option to StreamPipeReader and StreamPipeWriter. (dotnet/corefx#37667)

* Added LeaveOpen option to StreamPipeReader and StreamPipeWriter.

* Added leaveOpen to PipeReader/WriterStreams

* Fixed review comments.

Commit migrated from https://github.com/dotnet/corefx/commit/83f60a5955b0b66886ec81bcce9c16ec7e2ee2c3

5 years agoFix nullability annotations for corelib updates
Stephen Toub [Sun, 9 Jun 2019 01:20:11 +0000 (21:20 -0400)]
Fix nullability annotations for corelib updates

Commit migrated from https://github.com/dotnet/corefx/commit/200a36f6591317f258c189d2220f45776a6c4bf3

5 years agoAdd DisplayUnits to DiagnosticCounter reference assembly
Sung Yoon Whang [Sat, 8 Jun 2019 23:26:49 +0000 (16:26 -0700)]
Add DisplayUnits to DiagnosticCounter reference assembly

Commit migrated from https://github.com/dotnet/corefx/commit/6203eb73f97b31503972bbe357e393287f3ecc74

5 years agoEnable tracing context propagation without listener in presence of parent Activity...
Liudmila Molkova [Sun, 9 Jun 2019 01:55:57 +0000 (18:55 -0700)]
Enable tracing context propagation without listener in presence of parent Activity (dotnet/corefx#38280)

* Enable tracing context propagation without listener in presence of parent Activity
* tests for AppContext switch

Commit migrated from https://github.com/dotnet/corefx/commit/35ebd462cc03bddc7ac135b7ec218ebd8357f7b2

5 years ago[Tests]: JsonSerializer.Parse for json strings containing Enum (dotnet/corefx#37895)
Maryam Ariyan [Sat, 8 Jun 2019 16:50:19 +0000 (09:50 -0700)]
[Tests]: JsonSerializer.Parse for json strings containing Enum (dotnet/corefx#37895)

* Adding tests for Parsing json strings contains Enums

Related to: dotnet/corefx#37735

* Broke down new tests to make more readable

* nit + Add ActiveIssue test for bug found

Commit migrated from https://github.com/dotnet/corefx/commit/af8d3eee98e018cb3fcbcf9d87f3d38725342dc2

5 years agoApply feedback from JsonElement back into original logic from Utf8JsonReader (dotnet...
Maryam Ariyan [Sat, 8 Jun 2019 05:38:48 +0000 (22:38 -0700)]
Apply feedback from JsonElement back into original logic from Utf8JsonReader (dotnet/corefx#38205)

use const length for stackalloc but keep using unsafe span stackalloc pattern

Commit migrated from https://github.com/dotnet/corefx/commit/20ba99aaf60ba91180f304211b096e1147564a7c

5 years ago[Code Coverage] Test for Utf8JsonReader.TryGetGuid (dotnet/corefx#38321)
Maryam Ariyan [Sat, 8 Jun 2019 00:05:15 +0000 (17:05 -0700)]
[Code Coverage] Test for Utf8JsonReader.TryGetGuid (dotnet/corefx#38321)

* [Code Coverage] Test for Utf8JsonReader.TryGetGuid
- For value sequence

* nit + Improve failure messaging for Assert.True/False

* Add isFinalBlock false case too

Commit migrated from https://github.com/dotnet/corefx/commit/ff3ad21651536853d156525f50b296fd883e775e

5 years agoHttpClient: Try decode Location header using UTF-8 (dotnet/corefx#37852)
Krzysztof Wicher [Fri, 7 Jun 2019 21:38:02 +0000 (14:38 -0700)]
HttpClient: Try decode Location header using UTF-8 (dotnet/corefx#37852)

* Use desktop logic for parsing Location (try decode using UTF-8)

* Tests and feedback

* fix netfx

* Convert UTF-8 in non-allocating way without try .. catch

Commit migrated from https://github.com/dotnet/corefx/commit/02026907370c57380a9f091b54ee77873f276a68

5 years agoUpdate code coverage docs and remove regular runs
Viktor Hofer [Fri, 7 Jun 2019 20:36:54 +0000 (22:36 +0200)]
Update code coverage docs and remove regular runs

Commit migrated from https://github.com/dotnet/corefx/commit/4b6562e0da17ba1d92d72bc2406af9eea3e9337a

5 years agoAvoid using X509Certificate2's IntPtr ctor in SecureChannel (dotnet/corefx#38344)
Stephen Toub [Fri, 7 Jun 2019 20:10:54 +0000 (16:10 -0400)]
Avoid using X509Certificate2's IntPtr ctor in SecureChannel (dotnet/corefx#38344)

* Avoid using X509Certificate2's IntPtr ctor in SecureChannel

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/82e49157906d6c9c1ed7013e99d50dca74e7fafc

5 years agoAdd debug data to help diagnose HTTP2 test failure (dotnet/corefx#38345)
Stephen Toub [Fri, 7 Jun 2019 20:09:38 +0000 (16:09 -0400)]
Add debug data to help diagnose HTTP2 test failure (dotnet/corefx#38345)

The GoAwayFrame_AbortAllPendingStreams_StreamFailWithExpectedException test has been frequently hanging on some Linux distros.  This adds some diagnostics to help track it down in CI: every minute, it'll dump out the fields of the async state machine, which if nothing else will let us see which await it's stuck on and what is the state of each of the tasks.

Commit migrated from https://github.com/dotnet/corefx/commit/410a162f68eb319e8066ac7bf2d7bcd6e2ce47d0

5 years agoFix issue in NamedPipeServerStream.GetImpersonationUserName() (dotnet/corefx#37676)
Carlos Sanchez Lopez [Fri, 7 Jun 2019 19:35:43 +0000 (12:35 -0700)]
Fix issue in NamedPipeServerStream.GetImpersonationUserName() (dotnet/corefx#37676)

Fix for issue where NamedPipeServerStream.GetImpersonationUserName() throws unexpected InvalidationOperationException("The operation completed successfully") when impersonation is not allowed, when in fact it should simply return an empty string.

The fix will call GetNamedPipeHandleStateW once. If it fails, it will try to load sspicli.dll if it was not loaded, and will reattempt the call to GetNamedPipeHandleStateW.

This fix is only for Win32: UAP does not allow calling LoadLibraryEx, and Windows Nano says denies access to GetNamedPipeHandleStateW even after attempting to load sspicli.dll.

Commit migrated from https://github.com/dotnet/corefx/commit/30c7f263fc60a558cbabf388555ebea211bce642

5 years agoMove type to last argument in order to meet fx design guidelines for overloads ...
Eric StJohn [Fri, 7 Jun 2019 19:21:24 +0000 (12:21 -0700)]
Move type to last argument in order to meet fx design guidelines for overloads  (dotnet/corefx#38272)

* Make type name last in the Add*Resource methods

* Reformat Res.Extensions ref

Includes the missing interface definitions & reorders the members.

Commit migrated from https://github.com/dotnet/corefx/commit/0e86c5b5ae460780a78ee7145204a151deebe7e4

5 years agoAdded CopyToAsync(PipeWriter) (dotnet/corefx#38326)
David Fowler [Fri, 7 Jun 2019 16:06:30 +0000 (09:06 -0700)]
Added CopyToAsync(PipeWriter) (dotnet/corefx#38326)

* Added CopyToAsync(PipeWriter)
- Reuse existing CopyToAsync routine to implement the PipeWriter overload.
- Added tests for PipeWriter overload

* Remove delegate allocations

Commit migrated from https://github.com/dotnet/corefx/commit/d4f34564bc98aee98adf0861dd4771ff473ebdbe

5 years agoDisable System.Net.Sockets.Async.Stress.Tests on CI
Viktor Hofer [Fri, 7 Jun 2019 15:30:28 +0000 (17:30 +0200)]
Disable System.Net.Sockets.Async.Stress.Tests on CI

Commit migrated from https://github.com/dotnet/corefx/commit/a39c60d9057db9b56ecdca5049900a205ec60ac9

5 years agoDon't throw in the On* callbacks (dotnet/corefx#38327)
David Fowler [Fri, 7 Jun 2019 14:24:21 +0000 (07:24 -0700)]
Don't throw in the On* callbacks (dotnet/corefx#38327)

- We can't throw NotSupportedException in the OnWriterCompleted and OnReaderCompleted callbacks since consumers of the API won't know if it's safe to do so. We could add a SupportsOn* boolean but nooping is a much simpler solution without breaking existing callers. We can also add a boolean in the future so callers will know when they can register callbacks or not.

Commit migrated from https://github.com/dotnet/corefx/commit/672cc2c985d1f6f00afe853e678ed05de9757724

5 years agoAllow OperationCanceledExceptions to propagate out of ClientWebSocket.ConnectAsync...
Stephen Toub [Fri, 7 Jun 2019 10:53:54 +0000 (06:53 -0400)]
Allow OperationCanceledExceptions to propagate out of ClientWebSocket.ConnectAsync (dotnet/corefx#38204)

They're currently being wrapped in WebSocketExceptions, but they should be allowed to escape unwrapped.

Commit migrated from https://github.com/dotnet/corefx/commit/513f9f92cb81e87dee358018ce59a48249d1c51d

5 years agoRemoved lost and unused file (dotnet/corefx#38320)
Yoh Deadfall [Fri, 7 Jun 2019 10:12:33 +0000 (13:12 +0300)]
Removed lost and unused file (dotnet/corefx#38320)

Commit migrated from https://github.com/dotnet/corefx/commit/18198f5758b6aed66293eb0de675286902700899

5 years agoProcessNameMatchesScriptName: add missing Fact attribute (dotnet/corefx#38251)
Tom Deseyn [Fri, 7 Jun 2019 03:16:12 +0000 (05:16 +0200)]
ProcessNameMatchesScriptName: add missing Fact attribute (dotnet/corefx#38251)

* ProcessNameMatchesScriptName: add missing Fact attribute

* Skip test on RHEL6

Commit migrated from https://github.com/dotnet/corefx/commit/de1da50fc5f972348aba2fa40ff14e1cbadb13de

5 years agoFix calls to functions moved from PathInternal to Path
Stephen Toub [Fri, 31 May 2019 02:54:01 +0000 (22:54 -0400)]
Fix calls to functions moved from PathInternal to Path

Commit migrated from https://github.com/dotnet/corefx/commit/b60e3c347d0af66dc7f7788b736be7f5315c3ad1

5 years agoDelete CoreFX tests of COM lifetime control methods. (dotnet/corefx#38290)
Jeremy Koritzinsky [Fri, 7 Jun 2019 02:58:08 +0000 (19:58 -0700)]
Delete CoreFX tests of COM lifetime control methods. (dotnet/corefx#38290)

* Delete CoreFX tests of COM lifetime control methods.

* Remove deleted files from project file.

Commit migrated from https://github.com/dotnet/corefx/commit/500e6882a78c92ecfd584bd4d8ba8e49f4410eb7

5 years agoSimplify loop add with UnionWith method. (dotnet/corefx#38300)
Tim [Fri, 7 Jun 2019 02:56:56 +0000 (21:56 -0500)]
Simplify loop add with UnionWith method. (dotnet/corefx#38300)

Commit migrated from https://github.com/dotnet/corefx/commit/78c4949d341dc51739e4027611f267700e58b60e

5 years agoRemove Redundant counter : System.Collections.Immutable.ImmutableHashSet_1.SetEquals...
wcontayon [Fri, 7 Jun 2019 02:51:38 +0000 (02:51 +0000)]
Remove Redundant counter : System.Collections.Immutable.ImmutableHashSet_1.SetEquals (dotnet/corefx#38325)

Commit migrated from https://github.com/dotnet/corefx/commit/29c88546923bca1cdfba6091098c5d25bd09fd00

5 years agoNullable annotate System.Private.Uri (dotnet/corefx#38113)
Stephen Toub [Fri, 7 Jun 2019 01:57:41 +0000 (21:57 -0400)]
Nullable annotate System.Private.Uri (dotnet/corefx#38113)

* Nullable annotate System.Private.Uri

* Address PR feedback

* Fix unit tests project

Commit migrated from https://github.com/dotnet/corefx/commit/df452f1ee61004dd1d61811fdd80ab165c2d8b1b

5 years agoAdd nullable attributes to partial facade implementations (dotnet/corefx#38309)
Stephen Toub [Fri, 7 Jun 2019 01:54:11 +0000 (21:54 -0400)]
Add nullable attributes to partial facade implementations (dotnet/corefx#38309)

* Add nullable attributes to partial facade implementations

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/3ea7b55e275fb6367f67e7fb0432be4bb3902f09

5 years agoThrowing Jsonexception when trying to convert a value into a Dictionary (dotnet/coref...
Anirudh Agnihotry [Thu, 6 Jun 2019 23:32:42 +0000 (16:32 -0700)]
Throwing Jsonexception when trying to convert a value into a Dictionary (dotnet/corefx#38183)

* improving exception

* adding immutable check and moving check to proper place

* adding poco dictionary tests

* combining if conditions

Commit migrated from https://github.com/dotnet/corefx/commit/05171beb453577b516caa051ce2bea2ae48d4b83

5 years agoExpose SecurityDescriptor as protected (dotnet/corefx#38283)
Jeremy Kuhne [Thu, 6 Jun 2019 22:16:53 +0000 (15:16 -0700)]
Expose SecurityDescriptor as protected (dotnet/corefx#38283)

* Expose SecurityDescriptor as protected

Classes derived from ObjectSecurity depended on seeing the _securityDescriptor field, which is marked internal. Internal visibility no longer works as types have split into different assemblies and is causing failures, such as dotnet/corefx#35993.

This change also ran the UpdateVSConfigurations target on the changed libraries.

* Address feedback

Commit migrated from https://github.com/dotnet/corefx/commit/7570445805fe57966ff6494fcd582de8b79088a0

5 years agoMerge pull request dotnet/corefx#38317 from DustinCampbell/fix-38311
Dustin Campbell [Thu, 6 Jun 2019 22:13:53 +0000 (15:13 -0700)]
Merge pull request dotnet/corefx#38317 from DustinCampbell/fix-38311

Allow ReflectPropertyDescriptor to reflect over non-public members

Commit migrated from https://github.com/dotnet/corefx/commit/8dc48fad4eac24fd2997f6e73751fd7317e2b19b

5 years agoUpdate Reflection.Emit and String tests after changes due to nullable review (dotnet...
Santiago Fernandez Madero [Thu, 6 Jun 2019 21:01:05 +0000 (14:01 -0700)]
Update Reflection.Emit and String tests after changes due to nullable review (dotnet/corefx#38269)

* Update Reflection.Emit and String tests after changes due to nullable review

* Run darc update to update coreclr dependencies

* Add missing assert

Commit migrated from https://github.com/dotnet/corefx/commit/bdbdfaa286b94c44fadb2abd64e858b2e533a2cf

5 years agoRemove NetNative uapaot support (dotnet/corefx#38170)
Viktor Hofer [Thu, 6 Jun 2019 19:39:46 +0000 (21:39 +0200)]
Remove NetNative uapaot support (dotnet/corefx#38170)

* Remove NetNative uapaot support

* Remove uapaot assets from packages

* Disable emit lightweight and ilgen version check

Commit migrated from https://github.com/dotnet/corefx/commit/ab58ff6e649852b85fdb99b15992a2fa3a7d8834

5 years agoClean up code style in PropertyDescriptorTests.cs
Dustin Campbell [Thu, 6 Jun 2019 19:31:12 +0000 (12:31 -0700)]
Clean up code style in PropertyDescriptorTests.cs

Commit migrated from https://github.com/dotnet/corefx/commit/bce319455d8a71bc422249ffb5b1bed89cbffaa8

5 years agoAllow ReflectPropertyDescriptor to reflect over non-public members
Dustin Campbell [Thu, 6 Jun 2019 18:49:43 +0000 (11:49 -0700)]
Allow ReflectPropertyDescriptor to reflect over non-public members

Fixes dotnet/corefx#38311

On .NET Framework, ReflectPropertyDescriptor can access non-public members,
but has been disabled on .NET Core since ReflectPropertyDescriptor was ported.
Most PropertyDescriptor runtime scenarios don't require this behavior, but
design-time scenarios do. Component/Control designers can (and do) create new
PropertyDescriptors that expose non-public properties from runtime components
for design-time (e.g. for display in the Property Browser). In addition,
designers often create "shadow" properties which are used at design-time in place
of the actual properties on the runtime components. A shadowed property is normally
declared as private, but ReflectPropertyDescriptor still needs to be able to find
it.

Commit migrated from https://github.com/dotnet/corefx/commit/7cfe839e1d076b55fb14d5fa519f1b86d8833fa4

5 years agoMerge pull request dotnet/corefx#38312 from dotnet/MattGal-patch-1
Matt Galbraith [Thu, 6 Jun 2019 17:00:01 +0000 (10:00 -0700)]
Merge pull request dotnet/corefx#38312 from dotnet/MattGal-patch-1

Fix Debian 10 image

Commit migrated from https://github.com/dotnet/corefx/commit/a5eec2c658782103e5baf2a42f2112d5be063c66

5 years agoFix Debian 10 image
Matt Galbraith [Thu, 6 Jun 2019 16:47:22 +0000 (09:47 -0700)]
Fix Debian 10 image

Older image had missing home/helixbot folder which broke reporting;  tested and fixed in run e395a455-344e-411b-9ac2-1b3b89671ca3

@safern , @wfurt FYI

Commit migrated from https://github.com/dotnet/corefx/commit/e9bc423c0455a9c12702382e6f5cd7d0eeed7973

5 years agoImprove ReadOnlySequence.Slice docs (dotnet/corefx#38150)
Bradley Grainger [Thu, 6 Jun 2019 13:29:10 +0000 (06:29 -0700)]
Improve ReadOnlySequence.Slice docs (dotnet/corefx#38150)

* Improve ReadOnlySequence.Slice docs. Fixes dotnet/corefx#32021

* Synchronise documentation with dotnet-api-docs.

Commit migrated from https://github.com/dotnet/corefx/commit/7626863d5a48f771513f7d22977189aab14dcd0b

5 years agofix CopyToAsyncCore - cancellation and infinite loop (dotnet/corefx#37848)
Vladislav Richter [Thu, 6 Jun 2019 09:05:53 +0000 (11:05 +0200)]
fix CopyToAsyncCore - cancellation and infinite loop (dotnet/corefx#37848)

ReadResult result = await ReadAsync(cancellationToken).ConfigureAwait(false); should be before the try/finally block because if you cancel the read operation the finally clause will try to advance reader that is not in reading state and instead of OperationCancelledException you will end up with InvalidOperationException.

There is a bug either in PipeReader.CopyToAsyncCore() or ReadOnlySequence.TryGet():

When ReadOnlySequence.TryGet() reaches final segment it will return true and this final memory but it will also set position as default(SequencePosition) - I don't know if this is by design but CopyToAsyncCore() method does not take it in consideration and it will copy the memory but not advance the reader - this will cause it to repeat this data indefinitely.

* Fixed test CopyToAsyncWorks() to make sure that multiple separate reads from the reader produce expected result.
Added test to verify that cancellation between reads from the Reader throws OperationCancelledException.

Commit migrated from https://github.com/dotnet/corefx/commit/71aec681dd1247979e7956372abae8bbc02c9546