commit-queue@webkit.org [Wed, 4 Jul 2012 06:34:49 +0000 (06:34 +0000)]
[WK2][EFL] Ewk_View should report the load progress
https://bugs.webkit.org/show_bug.cgi?id=90457
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-03
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
The Ewk_View now reports the estimated load progress
of the page via the new "load,progress".
A method is also added to Ewk_View in order to
retrieve the current load progress.
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_load_progress_get):
(ewk_view_load_progress_changed):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/ewk_view_loader_client.cpp:
(didChangeProgress):
(ewk_view_loader_client_attach):
* UIProcess/API/efl/ewk_view_private.h:
Tools:
Update EFL MiniBrowser so that it listens for the
"load,progress" on the Ewk_View and updates its
window title accordingly.
* MiniBrowser/efl/main.c:
(title_set):
(on_title_changed):
(on_progress):
(browserCreate):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121830
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Wed, 4 Jul 2012 06:18:20 +0000 (06:18 +0000)]
[GTK] Don't show accel labels in context menu items
https://bugs.webkit.org/show_bug.cgi?id=90437
Reviewed by Martin Robinson.
When a context menu item is created with a GtkMenuItem that has
been created from a GtkAction, if the action has an accelerator,
it's shown in the menu item label, like menu items in a menu
bar. In that case we should reset the accel closure of the menu
item label, like GtkUIManager does for popup menus, to make sure
the accelerator is not shown. This isn't needed for all other
ContextMenuIem constructors, because the GtkAction is created
without accelerator by webkit in those cases.
* platform/gtk/ContextMenuItemGtk.cpp:
(WebCore::ContextMenuItem::ContextMenuItem):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121829
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 4 Jul 2012 05:49:44 +0000 (05:49 +0000)]
[EFL] Move BatteryClientEfl from WebKit to WebCore
https://bugs.webkit.org/show_bug.cgi?id=90063
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-03
Reviewed by Kenneth Rohde Christiansen.
Move BatteryClientEfl class from WebKit to WebCore
so that it can be reused in WebKit2.
Source/WebCore:
No new tests, no behavior change.
* PlatformEfl.cmake:
* platform/efl/BatteryClientEfl.cpp: Renamed from Source/WebKit/efl/WebCoreSupport/BatteryClientEfl.cpp.
(WebCore):
(WebCore::BatteryClientEfl::BatteryClientEfl):
(WebCore::BatteryClientEfl::setController):
(WebCore::BatteryClientEfl::startUpdating):
(WebCore::BatteryClientEfl::stopUpdating):
(WebCore::BatteryClientEfl::batteryControllerDestroyed):
(WebCore::BatteryClientEfl::setBatteryStatus):
(WebCore::BatteryClientEfl::timerFired):
(WebCore::BatteryClientEfl::getBatteryStatus):
(WebCore::BatteryClientEfl::setBatteryClient):
* platform/efl/BatteryClientEfl.h: Renamed from Source/WebKit/efl/WebCoreSupport/BatteryClientEfl.h.
(WebCore):
(BatteryClientEfl):
(WebCore::BatteryClientEfl::~BatteryClientEfl):
(WebCore::BatteryClientEfl::batteryStatus):
Source/WebKit:
* PlatformEfl.cmake:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121828
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 4 Jul 2012 05:19:27 +0000 (05:19 +0000)]
Add a comment in order to clarify why
BitmapImage::frameHasAlphaAtIndex returns true as default.
https://bugs.webkit.org/show_bug.cgi?id=90445
Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-03
Reviewed by Eric Seidel.
No new tests. This patch doesn't change behavior.
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::frameHasAlphaAtIndex):
(WebCore):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121827
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yosin@chromium.org [Wed, 4 Jul 2012 05:00:22 +0000 (05:00 +0000)]
[Chromium] Unreviewed gardening for Win build
* platform/chromium/TestExpectations: Add TEXT to http/tests/misc/last-modified-parsing.htl
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121826
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Wed, 4 Jul 2012 03:27:50 +0000 (03:27 +0000)]
disable failing mock-chromium-mac python unit tests
Unreviewed, build fix.
Disable these tests until I can figure out why they're failing
on the bots.
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(PortTest.disabled_test_chromium_mac_lion):
(PortTest.disabled_test_chromium_mac_lion_in_test_shell_mode):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121825
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leo.yang@torchmobile.com.cn [Wed, 4 Jul 2012 02:59:30 +0000 (02:59 +0000)]
[BlackBerry] Checkerboard shown when clicking on error page buttons
https://bugs.webkit.org/show_bug.cgi?id=90152
RIM PR #161867
Reviewed by George Staikos.
r121514 just made the race occur in lower possibility but can't avoid it.
This path is using another approach to fix the problem. When we are resetting
backingstore while committing a page we need to suspend backingstore and
screen update to make sure no other threads can update backingstore and screen.
* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::resetTiles):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121824
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 4 Jul 2012 02:34:16 +0000 (02:34 +0000)]
[chromium] Avoid calling getUniformLocation??() in the compositor startup
https://bugs.webkit.org/show_bug.cgi?id=90217
Patch by Alex Sakhartchouk <alexst@chromium.org> on 2012-07-03
Reviewed by Adrienne Walker.
Source/Platform:
Adding an entry point for bindUniformLocationCHROMIUM.
* chromium/public/WebGraphicsContext3D.h:
(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::bindUniformLocationCHROMIUM):
Source/WebCore:
This change allows chrome compositor to bind uniform locations instead of querying
them from the graphics context by using GL_CHROMIUM_bind_uniform_location.
The extention itself is tested in chromium and the change in webkit simply adds
plumbing to allow its usage. Existing pixel tests would be able to verify proper behaviour.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::tileCheckerboardProgram):
(WebCore::LayerRendererChromium::solidColorProgram):
(WebCore::LayerRendererChromium::headsUpDisplayProgram):
(WebCore::LayerRendererChromium::renderPassProgram):
(WebCore::LayerRendererChromium::renderPassProgramAA):
(WebCore::LayerRendererChromium::renderPassMaskProgram):
(WebCore::LayerRendererChromium::renderPassMaskProgramAA):
(WebCore::LayerRendererChromium::tileProgram):
(WebCore::LayerRendererChromium::tileProgramOpaque):
(WebCore::LayerRendererChromium::tileProgramAA):
(WebCore::LayerRendererChromium::tileProgramSwizzle):
(WebCore::LayerRendererChromium::tileProgramSwizzleOpaque):
(WebCore::LayerRendererChromium::tileProgramSwizzleAA):
(WebCore::LayerRendererChromium::textureProgram):
(WebCore::LayerRendererChromium::textureProgramFlip):
(WebCore::LayerRendererChromium::textureIOSurfaceProgram):
(WebCore::LayerRendererChromium::videoYUVProgram):
(WebCore::LayerRendererChromium::videoStreamTextureProgram):
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
* platform/graphics/chromium/ProgramBinding.cpp:
(WebCore::ProgramBindingBase::ProgramBindingBase):
(WebCore::ProgramBindingBase::~ProgramBindingBase):
(WebCore::ProgramBindingBase::init):
(WebCore::ProgramBindingBase::link):
(WebCore):
(WebCore::ProgramBindingBase::cleanup):
(WebCore::ProgramBindingBase::createShaderProgram):
(WebCore::ProgramBindingBase::cleanupShaders):
* platform/graphics/chromium/ProgramBinding.h:
(ProgramBindingBase):
(WebCore::ProgramBinding::initialize):
* platform/graphics/chromium/ShaderChromium.cpp:
(WebCore::VertexShaderPosTex::init):
(WebCore::VertexShaderPosTexYUVStretch::init):
(WebCore::VertexShaderPos::init):
(WebCore::VertexShaderPosTexTransform::init):
(WebCore::VertexShaderQuad::init):
(WebCore::VertexShaderTile::init):
(WebCore::VertexShaderVideoTransform::init):
(WebCore::FragmentTexAlphaBinding::init):
(WebCore::FragmentTexOpaqueBinding::init):
(WebCore::FragmentShaderOESImageExternal::init):
(WebCore::FragmentShaderRGBATexAlphaAA::init):
(WebCore::FragmentTexClampAlphaAABinding::init):
(WebCore::FragmentShaderRGBATexAlphaMask::init):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::init):
(WebCore::FragmentShaderYUVVideo::init):
(WebCore::FragmentShaderColor::init):
(WebCore::FragmentShaderCheckerboard::init):
* platform/graphics/chromium/ShaderChromium.h:
(VertexShaderPosTex):
(VertexShaderPosTexYUVStretch):
(VertexShaderPos):
(WebCore::VertexShaderPosTexIdentity::init):
(VertexShaderPosTexTransform):
(VertexShaderQuad):
(VertexShaderTile):
(VertexShaderVideoTransform):
(FragmentTexAlphaBinding):
(FragmentTexOpaqueBinding):
(FragmentShaderOESImageExternal):
(FragmentShaderRGBATexAlphaAA):
(FragmentTexClampAlphaAABinding):
(FragmentShaderRGBATexAlphaMask):
(FragmentShaderRGBATexAlphaMaskAA):
(FragmentShaderYUVVideo):
(FragmentShaderColor):
(FragmentShaderCheckerboard):
* platform/graphics/chromium/TextureCopier.cpp:
(WebCore::AcceleratedTextureCopier::AcceleratedTextureCopier):
(WebCore::AcceleratedTextureCopier::copyTexture):
* platform/graphics/chromium/TextureCopier.h:
(WebCore::AcceleratedTextureCopier::create):
(AcceleratedTextureCopier):
Source/WebKit/chromium:
Fixing the build error.
* tests/TextureCopierTest.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121823
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vollick@chromium.org [Wed, 4 Jul 2012 02:23:15 +0000 (02:23 +0000)]
Add vollick to the list of committers
https://bugs.webkit.org/show_bug.cgi?id=90512
Reviewed by Adrienne Walker.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121822
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Wed, 4 Jul 2012 02:13:13 +0000 (02:13 +0000)]
Improve webkit-patch rebaseline to work for more cases
https://bugs.webkit.org/show_bug.cgi?id=90504
Reviewed by Dirk Pranke.
-Makes it work for the build.chromium.org bots.
-Lets you rebaseline all builders instead of just one.
-Lets you pass in the builder or test to rebaseline.
* Scripts/webkitpy/common/net/buildbot/buildbot.py:
(Build.results_url):
Make this work for build.chromium.org builders as well.
* Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py:
(ChromiumBuilder):
(ChromiumBuilder.latest_cached_build):
ChromiumBuilder doesn't support large parts of the Builder interface.
This provides the bare minimum for this patch to work. Eventually,
we should create a single interface that can be supported for both
sets of buildbots.
* Scripts/webkitpy/layout_tests/port/builders.py:
(builder_path_from_name):
(all_builder_names):
memoizing here is incorrect because the test override _exact_matches,
so these can return different values. In either case, I'm pretty sure these
are not remotely hot codepaths.
* Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractParallelRebaselineCommand.__init__):
(Rebaseline):
(Rebaseline.__init__):
(Rebaseline._builders_to_pull_from):
(Rebaseline._builder_with_name):
(Rebaseline._tests_to_update):
(Rebaseline.execute):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(test_rebaseline.mock_builders_to_pull_from):
(test_rebaseline):
(test_rebaseline_command_line_flags):
(test_rebaseline_multiple_builders):
(test_rebaseline_multiple_builders.mock_builders_to_pull_from):
(test_rebaseline_multiple_builders.mock_tests_to_update):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121821
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yosin@chromium.org [Wed, 4 Jul 2012 02:05:49 +0000 (02:05 +0000)]
[Chromium] Rebaseline: svg/custom/pattern-userSpaceOnUse-userToBaseTransform.xhtml
* platform/chromium-win/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121820
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 4 Jul 2012 01:56:08 +0000 (01:56 +0000)]
[EFL] Enable CSS variables support at compile time
https://bugs.webkit.org/show_bug.cgi?id=90448
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-03
Reviewed by Kenneth Rohde Christiansen.
Turn on CSS_VARIABLES flag by default on EFL port.
.:
* Source/cmake/OptionsEfl.cmake:
* Source/cmakeconfig.h.cmake:
Tools:
* Scripts/webkitperl/FeatureList.pm:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121819
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
arv@chromium.org [Wed, 4 Jul 2012 00:47:01 +0000 (00:47 +0000)]
[V8] Remove enableFasterDOMStoreAccess which is never used
https://bugs.webkit.org/show_bug.cgi?id=90489
Reviewed by Adam Barth.
Source/WebCore:
No new tests. Dead code removal.
* bindings/v8/V8DOMMap.cpp:
* bindings/v8/V8DOMMap.h:
(WebCore):
Source/WebKit/chromium:
* src/WebScriptController.cpp:
(WebKit::WebScriptController::enableV8SingleThreadMode):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121818
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jsbell@chromium.org [Wed, 4 Jul 2012 00:23:35 +0000 (00:23 +0000)]
Binding: IDL type DOMString[] shouldn't match null
https://bugs.webkit.org/show_bug.cgi?id=84217
Reviewed by Kentaro Hara.
Similar to r121714, IDL overloads with T[] (which is only minimally supported)
were being treated as Nullable by default during overloaded method dispatching,
which deviates from the WebIDL specification. Extend the previous change to
look for Nullable (specified by "?" type suffix in the IDL) for array types.
Also, after inspection of the spec, use a strict "is this an Array?" test in
the JS generator rather than an "inherits from Array.prototype?" test, to
match the WebIDL spec.
IDL files with affected overloads are modified to include the "?" suffix
so that no behavior changes are introduced by this patch - the JS and V8
generator results before/after the change show no diffs apart from the stricter
isJSArray() test.
Test: bindings/scripts/test/TestObj.idl (a non-Nullable T[] overload)
* Modules/indexeddb/IDBDatabase.idl: Tag T[] overloads with ? suffix.
* Modules/indexeddb/IDBObjectStore.idl: Ditto.
* Modules/vibration/NavigatorVibration.idl: Ditto.
* bindings/scripts/CodeGeneratorJS.pm: Check isNullable for T[].
(GenerateParametersCheckExpression):
* bindings/scripts/CodeGeneratorV8.pm: Ditto.
(GenerateParametersCheckExpression):
* bindings/scripts/test/JS/JSTestObj.cpp: Rebaselined.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod9):
(WebCore):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
* bindings/scripts/test/TestObj.idl: Tag existing T[] with ?, add non-? T[].
* bindings/scripts/test/V8/V8TestObj.cpp: Rebaselined.
(WebCore::TestObjV8Internal::overloadedMethod9Callback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::overloadedMethodCallback):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121817
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Wed, 4 Jul 2012 00:14:25 +0000 (00:14 +0000)]
nrwt: clean up exception handling and make sure we log some more failures
https://bugs.webkit.org/show_bug.cgi?id=90503
Reviewed by Ojan Vafai.
There were several places where exceptions weren't getting
logged, most notably if you passed a bad value to --platform.
This change tests that and cleans things up a bit; more cleanup
will be possible when we rework the manager_worker_broker code.
* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(_BrokerConnection.raise_exception):
(_InlineWorkerConnection.raise_exception):
* Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker.run):
(Worker.kill_driver):
* Scripts/webkitpy/layout_tests/port/factory.py:
(PortFactory.get):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(run):
(main):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_unsupported_platfrom):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121816
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Wed, 4 Jul 2012 00:03:17 +0000 (00:03 +0000)]
Parameter 'id' is not used in getUserModifyProperty() of fast/dom/shadow/user-modify-inheritance.html.
https://bugs.webkit.org/show_bug.cgi?id=90434
Reviewed by Ryosuke Niwa.
* fast/dom/shadow/user-modify-inheritance.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121815
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 4 Jul 2012 00:01:24 +0000 (00:01 +0000)]
eventSender.beginDragWithFiles had been implemented in Windows, related tests should be removed from Skipped.
https://bugs.webkit.org/show_bug.cgi?id=87610
Patch by Xueqing Huang <huangxueqing@baidu.com> on 2012-07-03
Reviewed by Jessie Berlin.
* platform/win/Skipped:
* platform/win/fast/dom/Window: Removed.
* platform/win/fast/dom/Window/window-postmessage-clone-frames-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121814
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
japhet@chromium.org [Tue, 3 Jul 2012 23:54:03 +0000 (23:54 +0000)]
Source/WebCore: REGRESSION (r115654): Sometimes does not replace content for multipart/x-mixed-replace
https://bugs.webkit.org/show_bug.cgi?id=88436
Reviewed by Brady Eidson.
Test: http/tests/multipart/multipart-replace-non-html-content.php
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::commitData): We should only send receivedFirstData() once per main resource load,
rather than multiple times in a multipart load.
(WebCore::DocumentLoader::setupForReplaceByMIMEType): m_gotFirstByte isn't set to true until data is
actually committed, and multipart data is often not committed until the part is finished. Check
whether the SharedBuffer is non-null instead.
* testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::resetInternalsObject): The JSInternals object my have already been cleared if the window shell
was cleared as part of creation of a new Document. Check it before using it.
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=88436.
Reviewed by Brady Eidson.
* http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added.
* http/tests/multipart/multipart-replace-non-html-content.php: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121813
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Tue, 3 Jul 2012 23:53:26 +0000 (23:53 +0000)]
nrwt: fix mock port
https://bugs.webkit.org/show_bug.cgi?id=90500
Reviewed by Ojan Vafai.
The MockDRT code was never updated when we switched the chromium
ports to using "drt mode" by default. This change updates that
code, fixes a typo in the chromium port that went undetected
(default_test_timeout_ms -> default_timeout_ms), and adds tests
that actually exercise some of the mock ports. These tests are
useful in that they will exercise the port-specific code in an
end-to-end-manner, but they are a bit slow for some reason (>1s
each) that I need to look into.
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.stop):
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.default_timeout_ms):
* Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(TestChromiumAndroidPort.test_default_timeout_ms):
* Scripts/webkitpy/layout_tests/port/mock_drt.py:
(main):
(parse_options):
(MockTestShell):
(MockTestShell.output_for_test):
* Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
(MockDRTTest.assertTest):
(MockTestShellTest):
(MockTestShellTest.make_drt):
(MockTestShellTest.test_test_shell_parse_options):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(PortTest):
(PortTest.assert_mock_port_works):
(PortTest.test_chromium_mac_lion):
(PortTest.test_chromium_mac_lion_in_test_shell_mode):
(PortTest.test_qt_linux):
(PortTest.test_mac_lion):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121812
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Jul 2012 23:40:50 +0000 (23:40 +0000)]
Add AudioFIFO class and simplify AudioPullFIFO
https://bugs.webkit.org/show_bug.cgi?id=90398
Patch by Raymond Toy <rtoy@google.com> on 2012-07-03
Reviewed by Chris Rogers.
No new tests. This code will be used in audio back-end implementation.
Add AudioFIFO class to implement main parts of FIFO. Simplify
implementation of AudioPushFIFO by using AudioFIFO.
* WebCore.gypi: Add new files.
New AudioFIFO class
* platform/audio/AudioFIFO.cpp: Copied from Source/WebCore/platform/audio/AudioPullFIFO.cpp.
(WebCore):
(WebCore::AudioFIFO::AudioFIFO):
(WebCore::AudioFIFO::consume):
(WebCore::AudioFIFO::push):
(WebCore::AudioFIFO::findWrapLengths):
* platform/audio/AudioFIFO.h: Copied from Source/WebCore/platform/audio/AudioPullFIFO.h.
(WebCore):
(AudioFIFO):
(WebCore::AudioFIFO::framesInFifo):
(WebCore::AudioFIFO::updateIndex):
Use AudioFIFO
* platform/audio/AudioPullFIFO.cpp:
(WebCore::AudioPullFIFO::AudioPullFIFO):
(WebCore::AudioPullFIFO::consume):
(WebCore::AudioPullFIFO::fillBuffer):
* platform/audio/AudioPullFIFO.h:
(AudioPullFIFO):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121810
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Tue, 3 Jul 2012 23:31:57 +0000 (23:31 +0000)]
nrwt: make the worker class stand alone with a cleaner interface
https://bugs.webkit.org/show_bug.cgi?id=90409
Reviewed by Ojan Vafai.
Currently the Worker class derives from AbstractWorker, which is
kind of crufty and awkward; it would be better if we did not
rely on shared state.
This change changes that so that Worker derives from object, and
exposes the following interface:
__init__() - called in the manager process
safe_init() - called in the worker process to initialize
unpicklable state
handle() - a single routine to handle all messages
cleanup() - called so the worker can clean up
Also, all of the "administrative" messages that are handled by
the worker (notification of start/stop/etc.) move into
manager_worker_broker - this reduces worker.py to just handling
the mechanics of actually running each test.
For the moment, we do this by creating Yet Another wrapper/proxy
class in manager_worker_broker, but this will get simpler
shortly when the rest of m_w_b is cleaned up.
With this change worker is now in its new form but there will be
a follow-on change that cleans up some names and other minor
things.
This change is again mostly just moving things around and should
be covered by the (updated) existing tests.
* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(get):
(AbstractWorker.__init__):
(AbstractWorker.run):
(AbstractWorker):
(AbstractWorker.handle_stop):
(AbstractWorker.handle_test_list):
(AbstractWorker.yield_to_broker):
(AbstractWorker.post_message):
(_WorkerConnection.__init__):
(_Process.run):
* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
(_TestWorker):
(_TestWorker.__init__):
(_TestWorker.name):
(_TestWorker.cleanup):
(_TestWorker.handle):
(_TestWorker.safe_init):
(_TestWorker.stop):
(_TestsMixin.handle_finished_test):
(_TestsMixin.setUp):
(_TestsMixin.test_cancel):
(_TestsMixin.test_done):
* Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker):
(Worker.__init__):
(Worker.safe_init):
(Worker.handle):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121809
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Jul 2012 23:31:49 +0000 (23:31 +0000)]
[WK2] Add support for Battery Status API
https://bugs.webkit.org/show_bug.cgi?id=89558
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-03
Reviewed by Anders Carlsson.
Add support for Battery Status API to WebKit2.
* CMakeLists.txt:
* DerivedSources.pri:
* GNUmakefile.am:
* GNUmakefile.list.am:
* Platform/CoreIPC/MessageID.h:
* Shared/API/c/WKBase.h:
* Shared/APIObject.h:
* Shared/WebBatteryStatus.cpp: Added.
(WebKit):
(WebKit::WebBatteryStatus::WebBatteryStatus):
(WebKit::WebBatteryStatus::~WebBatteryStatus):
(WebKit::WebBatteryStatus::Data::encode):
(WebKit::WebBatteryStatus::Data::decode):
* Shared/WebBatteryStatus.h: Added.
(WebKit):
(WebBatteryStatus):
(Data):
(WebKit::WebBatteryStatus::create):
(WebKit::WebBatteryStatus::isCharging):
(WebKit::WebBatteryStatus::chargingTime):
(WebKit::WebBatteryStatus::dischargingTime):
(WebKit::WebBatteryStatus::level):
(WebKit::WebBatteryStatus::data):
(WebKit::WebBatteryStatus::type):
* Target.pri:
* UIProcess/API/C/WKAPICast.h:
(WebKit):
* UIProcess/API/C/WKBatteryManager.cpp: Added.
(WKBatteryManagerGetTypeID):
* UIProcess/API/C/WKBatteryManager.h: Added.
* UIProcess/WebBatteryManagerProxy.cpp: Added.
(WebKit):
(WebKit::WebBatteryManagerProxy::create):
(WebKit::WebBatteryManagerProxy::WebBatteryManagerProxy):
(WebKit::WebBatteryManagerProxy::~WebBatteryManagerProxy):
(WebKit::WebBatteryManagerProxy::invalidate):
(WebKit::WebBatteryManagerProxy::initializeProvider):
(WebKit::WebBatteryManagerProxy::didReceiveMessage):
(WebKit::WebBatteryManagerProxy::startUpdating):
(WebKit::WebBatteryManagerProxy::stopUpdating):
(WebKit::WebBatteryManagerProxy::providerDidChangeBatteryStatus):
(WebKit::WebBatteryManagerProxy::providerUpdateBatteryStatus):
* UIProcess/WebBatteryManagerProxy.h: Added.
(CoreIPC):
(WebKit):
(WebBatteryManagerProxy):
(WebKit::WebBatteryManagerProxy::clearContext):
(WebKit::WebBatteryManagerProxy::type):
* UIProcess/WebBatteryManagerProxy.messages.in: Added.
* UIProcess/WebBatteryProvider.cpp: Added.
(WebKit):
(WebKit::WebBatteryProvider::startUpdating):
(WebKit::WebBatteryProvider::stopUpdating):
* UIProcess/WebBatteryProvider.h: Added.
(WebKit):
(WebBatteryProvider):
* WebKit2.pri:
* WebProcess/Battery/WebBatteryManager.cpp: Added.
(WebKit):
(WebKit::WebBatteryManager::WebBatteryManager):
(WebKit::WebBatteryManager::~WebBatteryManager):
(WebKit::WebBatteryManager::didReceiveMessage):
(WebKit::WebBatteryManager::registerWebPage):
(WebKit::WebBatteryManager::unregisterWebPage):
(WebKit::WebBatteryManager::didChangeBatteryStatus):
(WebKit::WebBatteryManager::updateBatteryStatus):
* WebProcess/Battery/WebBatteryManager.h: Added.
(CoreIPC):
(WebKit):
(WebBatteryManager):
* WebProcess/Battery/WebBatteryManager.messages.in: Added.
* WebProcess/WebCoreSupport/WebBatteryClient.cpp: Added.
(WebKit):
(WebKit::WebBatteryClient::startUpdating):
(WebKit::WebBatteryClient::stopUpdating):
(WebKit::WebBatteryClient::batteryControllerDestroyed):
* WebProcess/WebCoreSupport/WebBatteryClient.h: Added.
(WebKit):
(WebBatteryClient):
(WebKit::WebBatteryClient::WebBatteryClient):
(WebKit::WebBatteryClient::~WebBatteryClient):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::didReceiveMessage):
* WebProcess/WebProcess.h:
(WebProcess):
(WebKit::WebProcess::batteryManager):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121808
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Tue, 3 Jul 2012 23:11:18 +0000 (23:11 +0000)]
nrwt: moving child process logging code into manager_worker_broker
https://bugs.webkit.org/show_bug.cgi?id=90408
Reviewed by Ojan Vafai.
Users of manager_worker_broker should not have to be aware of
whether they're in the same process or different processes and
configure logging themselves; mwb should hide this complexity.
We can't quite do this completely/correctly yet, since the
manager expects to get a list of messages to log, but this
change fixes the worker side of it, at least.
This is just moving code around, there is no new functionality
and this should be covered by existing tests.
* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(AbstractWorker.__init__):
(_WorkerConnection.__init__):
(_WorkerConnection.post_message):
(_WorkerConnection):
(_WorkerConnection.set_up_logging):
(_WorkerConnection.clean_up_logging):
(_InlineWorkerConnection.run):
(_MultiProcessWorkerConnection.run):
(_WorkerLogHandler):
(_WorkerLogHandler.__init__):
(_WorkerLogHandler.emit):
* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
(_TestWorker.run):
(_TestsMixin.handle_done):
* Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker.__init__):
(Worker.run):
(Worker._run_test):
(Worker.cleanup):
(Worker.run_single_test):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121807
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
msaboff@apple.com [Tue, 3 Jul 2012 22:57:00 +0000 (22:57 +0000)]
Enh: Hash Const JSString in Backing Stores to Save Memory
https://bugs.webkit.org/show_bug.cgi?id=86024
Reviewed by Oliver Hunt.
During garbage collection, each marking thread keeps a HashMap of
strings. While visiting via MarkStack::copyAndAppend(), we check to
see if the string we are visiting is already in the HashMap. If not
we add it. If so, we change the reference to the current string we're
visiting to the prior string.
To reduce the performance impact of this change, two throttles have
ben added. 1) We only try hash consting if a significant number of new
strings have been created since the last hash const. Currently this is
set at 100 strings. 2) If a string is unique at the end of a marking
it will not be checked during further GC phases. In some cases this
won't catch all duplicates, but we are trying to catch the growth of
duplicate strings.
* heap/Heap.cpp:
(JSC::Heap::markRoots):
* heap/MarkStack.cpp:
(JSC::MarkStackThreadSharedData::resetChildren):
(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::MarkStackThreadSharedData::reset):
(JSC::MarkStack::setup): Check to see if enough strings have been created
to hash const.
(JSC::MarkStack::reset): Added call to clear m_uniqueStrings.
(JSC::JSString::tryHashConstLock): New method to lock JSString for
hash consting.
(JSC::JSString::releaseHashConstLock): New unlock method.
(JSC::JSString::shouldTryHashConst): Set of checks to see if we should
try to hash const the string.
(JSC::MarkStack::internalAppend): New method that performs the hash consting.
(JSC::SlotVisitor::copyAndAppend): Changed to call the new hash
consting internalAppend().
* heap/MarkStack.h:
(MarkStackThreadSharedData):
(MarkStack):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
(JSGlobalData):
(JSC::JSGlobalData::haveEnoughNewStringsToHashConst):
(JSC::JSGlobalData::resetNewStringsSinceLastHashConst):
* runtime/JSString.h:
(JSString): Changed from using bool flags to using an unsigned
m_flags field. This works better with the weakCompareAndSwap in
JSString::tryHashConstLock(). Changed the 8bitness setting and
checking to use new accessors.
(JSC::JSString::JSString):
(JSC::JSString::finishCreation):
(JSC::JSString::is8Bit): Updated for new m_flags.
(JSC::JSString::setIs8Bit): New setter.
New hash const flags accessors:
(JSC::JSString::isHashConstSingleton):
(JSC::JSString::clearHashConstSingleton):
(JSC::JSString::setHashConstSingleton):
(JSC::JSRopeString::finishCreation):
(JSC::JSRopeString::append):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Tue, 3 Jul 2012 21:56:05 +0000 (21:56 +0000)]
Unreviewed chromium mac rebaselines.
* platform/chromium-mac-snowleopard/css1/formatting_model/floating_elements-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/block/float/010-expected.png:
* platform/chromium-mac-snowleopard/fast/block/float/010-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/block/float/independent-align-positioning-expected.png:
* platform/chromium-mac-snowleopard/fast/block/float/independent-align-positioning-expected.txt: Added.
* platform/chromium-mac/fast/block/float/010-expected.png:
* platform/chromium-mac/fast/block/float/010-expected.txt: Added.
* platform/chromium-mac/fast/block/float/independent-align-positioning-expected.png:
* platform/chromium-mac/fast/block/float/independent-align-positioning-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121805
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Jul 2012 21:44:07 +0000 (21:44 +0000)]
[BlackBerry] Turn on DFGJIT in Platform.h
https://bugs.webkit.org/show_bug.cgi?id=90482
Set ENABLE_DFG_JIT for PLATFORM(BLACKBERRY).
Patch by Yong Li <yoli@rim.com> on 2012-07-03
Reviewed by Rob Buis.
* wtf/Platform.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121804
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
japhet@chromium.org [Tue, 3 Jul 2012 21:37:28 +0000 (21:37 +0000)]
Protect this DocumentThreadableLoader in cancel() to handle reentrancy properly.
https://bugs.webkit.org/show_bug.cgi?id=90483
Reviewed by Abhishek Arya.
No new tests, covered by http/tests/xmlhttprequest/reentrant-cancel.html
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::cancel):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121803
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 3 Jul 2012 21:02:29 +0000 (21:02 +0000)]
[chromium] Don't archive build files generated by VS2010
https://bugs.webkit.org/show_bug.cgi?id=90493
Reviewed by Ojan Vafai.
In particular, the pch (pre compiled header) files are gigantic, making
release.zip almost a 1gb in size.
* BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121802
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 3 Jul 2012 20:26:08 +0000 (20:26 +0000)]
[chromium] Unreviewed, update .gitignore to handle VS2010 files.
Source/JavaScriptCore:
* JavaScriptCore.gyp/.gitignore:
Source/Platform:
* Platform.gyp/.gitignore:
Source/ThirdParty:
* glu/.gitignore:
Source/WebCore:
* WebCore.gyp/.gitignore:
Source/WebKit/chromium:
* .gitignore:
Source/WTF:
* WTF.gyp/.gitignore:
Tools:
* .gitignore:
* DumpRenderTree/DumpRenderTree.gyp/.gitignore:
* TestWebKitAPI/TestWebKitAPI.gyp/.gitignore:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 3 Jul 2012 20:23:41 +0000 (20:23 +0000)]
Have webkit-patch rebaseline use rebaseline-test-internal
https://bugs.webkit.org/show_bug.cgi?id=90491
Reviewed by Dirk Pranke.
This lets it handle new files, reduces duplicate code and lays the
groundwork for making rebaseline have a richer interface.
* Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
(MockBuild):
(MockBuild.__init__):
(MockBuilder.build):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractParallelRebaselineCommand._files_to_add):
(Rebaseline):
(Rebaseline._builder_to_pull_from):
(Rebaseline._tests_to_update):
(Rebaseline.execute):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(test_overrides_are_included_correctly):
(test_rebaseline):
(test_rebaseline.mock_builder_to_pull_from):
(test_rebaseline.mock_tests_to_update):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121800
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 3 Jul 2012 19:30:10 +0000 (19:30 +0000)]
Rename rebaseline-test to rebaseline-test-internal
https://bugs.webkit.org/show_bug.cgi?id=90485
Reviewed by Adam Barth.
It's now only used by other rebaseline commands. It's still useful to leave it
as it's own command to aid in debugging when something goes wrong. In a followup
patch, I'll make webkit-patch rebaseline cover any use-cases that rebaseline-test
might have covered.
We no longer need the --print-scm-changes option since the only caller always passes
that option in.
Also, make all the arguments command-line flags instead. Simplifies the code
a bit in my opinion.
* Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest):
(RebaselineTest.__init__):
(RebaselineTest.execute):
(AbstractParallelRebaselineCommand._rebaseline_commands):
(RebaselineExpectations.execute):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(test_rebaseline_all):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Jul 2012 19:19:22 +0000 (19:19 +0000)]
Add ability to symbolically set and dump JSC VM options.
See comments in runtime/Options.h for details on how the options work.
https://bugs.webkit.org/show_bug.cgi?id=90420
Patch by Mark Lam <mark.lam@apple.com> on 2012-07-03
Reviewed by Filip Pizlo.
* assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::finalizeCodeWithDisassembly):
* assembler/LinkBuffer.h:
(JSC):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::shouldOptimizeNow):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::likelyToTakeSlowCase):
(JSC::CodeBlock::couldTakeSlowCase):
(JSC::CodeBlock::likelyToTakeSpecialFastCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::likelyToTakeAnySlowCase):
(JSC::CodeBlock::jitAfterWarmUp):
(JSC::CodeBlock::jitSoon):
(JSC::CodeBlock::reoptimizationRetryCounter):
(JSC::CodeBlock::countReoptimization):
(JSC::CodeBlock::counterValueForOptimizeAfterWarmUp):
(JSC::CodeBlock::counterValueForOptimizeAfterLongWarmUp):
(JSC::CodeBlock::optimizeSoon):
(JSC::CodeBlock::exitCountThresholdForReoptimization):
(JSC::CodeBlock::exitCountThresholdForReoptimizationFromLoop):
* bytecode/ExecutionCounter.h:
(JSC::ExecutionCounter::clippedThreshold):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleInlining):
* dfg/DFGCapabilities.h:
(JSC::DFG::mightCompileEval):
(JSC::DFG::mightCompileProgram):
(JSC::DFG::mightCompileFunctionForCall):
(JSC::DFG::mightCompileFunctionForConstruct):
(JSC::DFG::mightInlineFunctionForCall):
(JSC::DFG::mightInlineFunctionForConstruct):
* dfg/DFGCommon.h:
(JSC::DFG::shouldShowDisassembly):
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
* dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):
* dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::shouldUseDoubleFormatAccordingToVote):
* heap/MarkStack.cpp:
(JSC::MarkStackSegmentAllocator::allocate):
(JSC::MarkStackSegmentAllocator::shrinkReserve):
(JSC::MarkStackArray::MarkStackArray):
(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::SlotVisitor::donateKnownParallel):
(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::drainFromShared):
* heap/MarkStack.h:
(JSC::MarkStack::mergeOpaqueRootsIfProfitable):
(JSC::MarkStack::addOpaqueRoot):
* heap/SlotVisitor.h:
(JSC::SlotVisitor::donate):
* jit/JIT.cpp:
(JSC::JIT::emitOptimizationCheck):
* jsc.cpp:
(printUsageStatement):
(parseArguments):
* runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
* runtime/JSGlobalData.cpp:
(JSC::enableAssembler):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::JSGlobalObject):
* runtime/Options.cpp:
(JSC):
(JSC::overrideOptionWithHeuristic):
(JSC::Options::initialize):
(JSC::Options::setOption):
(JSC::Options::dumpAllOptions):
(JSC::Options::dumpOption):
* runtime/Options.h:
(JSC):
(Options):
(EntryInfo):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121798
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Tue, 3 Jul 2012 19:12:13 +0000 (19:12 +0000)]
[Gtk][Gamepads] 'warning: comparison is always true due to limited range of data type [-Wtype-limits]' in GamepadsGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=90477
Reviewed by Martin Robinson.
Vector::find() returns value of type size_t, springing errors when
assigning the value to a variable of type unsigned. Use size_t type
for that variable instead.
No new tests - no changed functionality.
* platform/gtk/GamepadsGtk.cpp:
(WebCore::GamepadsGtk::unregisterDevice):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121797
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 3 Jul 2012 19:08:04 +0000 (19:08 +0000)]
Unreviewed gardening, give a bug number to slow inspector tests and
move into the slow section.
* platform/chromium/TestExpectations:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121796
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Jul 2012 19:07:06 +0000 (19:07 +0000)]
Fix LayoutUnit usage in RenderImage::imageDimensionsChanged
https://bugs.webkit.org/show_bug.cgi?id=90173
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-07-03
Reviewed by Eric Seidel.
The appropriate type should be used for storing width() and height() into local temporary variables.
No new tests, no change in behavior.
* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageDimensionsChanged):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121795
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Tue, 3 Jul 2012 19:04:04 +0000 (19:04 +0000)]
Suppress tests requiring rebaselining after r121789
Unreviewed, gardening.
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/Skipped:
* platform/qt/TestExpectations:
* platform/win/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121794
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Jul 2012 18:59:52 +0000 (18:59 +0000)]
[TextureMapper] Typo in edge-distance anti-aliasing code
https://bugs.webkit.org/show_bug.cgi?id=90475
Patch by Sergio Villar Senin <svillar@igalia.com> on 2012-07-03
Reviewed by Martin Robinson.
No new tests. This just fixes a typo.
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawQuad):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121793
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Tue, 3 Jul 2012 17:51:27 +0000 (17:51 +0000)]
Web Inspector: [Extensions API] Resource manipulations should be based on UISourceCode thus extending Sources Panel.
https://bugs.webkit.org/show_bug.cgi?id=89868
Reviewed by Pavel Feldman.
Source/WebCore:
Extensions API is now based on both ScriptsPanel acting as a UISourceCodeProvider and ResourceTreeModel.
Extensions API resource could be for any content provider now.
Extensions API resource.setContent implementation is now based on UISourceCode editing methods.
Drive-by StyleSource insremental editing timeout fix.
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._handleOpenURL):
(WebInspector.ExtensionServer.prototype._makeResource):
(WebInspector.ExtensionServer.prototype._onGetPageResources):
(WebInspector.ExtensionServer.prototype._getResourceContent):
(WebInspector.ExtensionServer.prototype._onGetResourceContent):
(WebInspector.ExtensionServer.prototype._onSetResourceContent):
(WebInspector.ExtensionServer.prototype._notifyResourceAdded):
(WebInspector.ExtensionServer.prototype._notifyResourceContentCommitted):
* inspector/front-end/JavaScriptSource.js:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.uiSourceCodes):
(WebInspector.ScriptsPanel.prototype.uiSourceCodeForURL):
(WebInspector.ScriptsPanel.prototype._addUISourceCode):
(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
* inspector/front-end/StylesPanel.js:
(WebInspector.StyleSource.prototype.workingCopyCommitted):
(WebInspector.StyleSource.prototype.workingCopyChanged):
(WebInspector.StyleSource.prototype._callOrSetTimeout):
(WebInspector.StyleSource.prototype._commitIncrementalEdit):
(WebInspector.StyleSource.prototype._clearIncrementalUpdateTimer):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.requestContent):
(WebInspector.UISourceCode.prototype.workingCopy):
(WebInspector.UISourceCode.prototype.setWorkingCopy):
(WebInspector.UISourceCode.prototype.isDirty):
LayoutTests:
* http/tests/inspector/extensions-test.js:
(initialize_ExtensionsTest):
(initialize_ExtensionsTest.completeTest):
(initialize_ExtensionsTest.InspectorTest.runExtensionTests):
* http/tests/inspector/resources/extension-main.js:
* inspector/extensions/extensions-resources.html:
* inspector/styles/styles-history.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121792
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 3 Jul 2012 17:49:41 +0000 (17:49 +0000)]
Unreviewed. Rolled DEPS.
* DEPS:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121791
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Tue, 3 Jul 2012 17:47:24 +0000 (17:47 +0000)]
Web Inspector: Anonymous scripts (evals) should not be added to Workspace.
https://bugs.webkit.org/show_bug.cgi?id=90467
Reviewed by Pavel Feldman.
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAdded):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeReplaced):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeRemoved):
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Tue, 3 Jul 2012 17:41:35 +0000 (17:41 +0000)]
CSS 2.1 failure: floats-wrap-top-below-inline-* fail
https://bugs.webkit.org/show_bug.cgi?id=88171
Reviewed by Eric Seidel.
Source/WebCore:
When shifting a line or element left or right to avoid a float use the height
of the line or element to determine whether the float is inside the element or
if it overlaps the bottom of the element.
Do this by passing the height of the element to the interval tree used to detect
the overlap with it's containing block's floats. The height is zero by default so
callers to logical[Left|Right]OffsetForLine will need to pass the height if they
want to use it to detect floats to avoid.
Tests: css2.1/
20110323/floats-wrap-top-below-bfc-001l.htm
css2.1/
20110323/floats-wrap-top-below-bfc-001r.htm
css2.1/
20110323/floats-wrap-top-below-bfc-002l.htm
css2.1/
20110323/floats-wrap-top-below-bfc-002r.htm
css2.1/
20110323/floats-wrap-top-below-bfc-003l.htm
css2.1/
20110323/floats-wrap-top-below-bfc-003r.htm
css2.1/
20110323/floats-wrap-top-below-inline-001l.htm
css2.1/
20110323/floats-wrap-top-below-inline-001r.htm
css2.1/
20110323/floats-wrap-top-below-inline-002l.htm
css2.1/
20110323/floats-wrap-top-below-inline-002r.htm
css2.1/
20110323/floats-wrap-top-below-inline-003l.htm
css2.1/
20110323/floats-wrap-top-below-inline-003r.htm
css2.1/
20110323/floats-zero-height-wrap-001.htm
css2.1/
20110323/floats-zero-height-wrap-002.htm
fast/block/float/floats-wrap-inside-inline-001.htm
fast/block/float/floats-wrap-inside-inline-002.htm
fast/block/float/floats-wrap-inside-inline-003.htm
fast/block/float/floats-wrap-inside-inline-004.htm
fast/block/float/floats-wrap-inside-inline-005.htm
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):
(WebCore::::collectIfNeeded):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::getClearDelta):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::availableLogicalWidthForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::startOffsetForLine):
(WebCore::RenderBlock::endOffsetForLine):
(WebCore::RenderBlock::pixelSnappedLogicalLeftOffsetForLine):
(WebCore::RenderBlock::pixelSnappedLogicalRightOffsetForLine):
(RenderBlock):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::FloatIntervalSearchAdapter):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::lowValue):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::highValue):
(FloatIntervalSearchAdapter):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::logicalBottomForLine):
(WebCore):
(WebCore::LineWidth::updateAvailableWidth):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::containingBlockAvailableLineWidthInRegion):
LayoutTests:
* css2.1/
20110323/floats-wrap-top-below-001l-expected.html: Added.
* css2.1/
20110323/floats-wrap-top-below-001r-expected.html: Added.
* css2.1/
20110323/floats-wrap-top-below-002l-expected.html: Added.
* css2.1/
20110323/floats-wrap-top-below-002r-expected.html: Added.
* css2.1/
20110323/floats-wrap-top-below-003l-expected.html: Added.
* css2.1/
20110323/floats-wrap-top-below-003r-expected.html: Added.
* css2.1/
20110323/floats-wrap-top-below-bfc-001l-expected.html: Added.
* css2.1/
20110323/floats-wrap-top-below-bfc-001l.htm: Added.
* css2.1/
20110323/floats-wrap-top-below-bfc-001r-expected.html: Added.
* css2.1/
20110323/floats-wrap-top-below-bfc-001r.htm: Added.
* css2.1/
20110323/floats-wrap-top-below-bfc-002l-expected.html: Added.
* css2.1/
20110323/floats-wrap-top-below-bfc-002l.htm: Added.
* css2.1/
20110323/floats-wrap-top-below-bfc-002r-expected.html: Added.
* css2.1/
20110323/floats-wrap-top-below-bfc-002r.htm: Added.
* css2.1/
20110323/floats-wrap-top-below-bfc-003l-expected.html: Added.
* css2.1/
20110323/floats-wrap-top-below-bfc-003l.htm: Added.
* css2.1/
20110323/floats-wrap-top-below-bfc-003r-expected.html: Added.
* css2.1/
20110323/floats-wrap-top-below-bfc-003r.htm: Added.
* css2.1/
20110323/floats-wrap-top-below-inline-001l-expected.html: Added.
* css2.1/
20110323/floats-wrap-top-below-inline-001l.htm: Added.
* css2.1/
20110323/floats-wrap-top-below-inline-001r-expected.html: Added.
* css2.1/
20110323/floats-wrap-top-below-inline-001r.htm: Added.
* css2.1/
20110323/floats-wrap-top-below-inline-002l-expected.html: Added.
* css2.1/
20110323/floats-wrap-top-below-inline-002l.htm: Added.
* css2.1/
20110323/floats-wrap-top-below-inline-002r-expected.html: Added.
* css2.1/
20110323/floats-wrap-top-below-inline-002r.htm: Added.
* css2.1/
20110323/floats-wrap-top-below-inline-003l-expected.html: Added.
* css2.1/
20110323/floats-wrap-top-below-inline-003l.htm: Added.
* css2.1/
20110323/floats-wrap-top-below-inline-003r-expected.html: Added.
* css2.1/
20110323/floats-wrap-top-below-inline-003r.htm: Added.
* css2.1/
20110323/floats-zero-height-wrap-001-expected.html: Added.
* css2.1/
20110323/floats-zero-height-wrap-001.htm: Added.
* css2.1/
20110323/floats-zero-height-wrap-002.htm: Added.
* css2.1/
20110323/floats-zero-height-wrap-002-expected.html: Added.
All of these are taken from the CSS test suite, including the expected.html files which have been renamed
from *-ref.html so that new-run-webkit-tests will parse use them.
* fast/block/float/floats-wrap-inside-inline-001-expected.html: Added.
* fast/block/float/floats-wrap-inside-inline-001.htm: Added.
The span should avoid a float even when its top and bottom does not overlap with the top of the span.
In this test the float starts and ends inside the span's first linebox.
* fast/block/float/floats-wrap-inside-inline-002-expected.html: Added.
* fast/block/float/floats-wrap-inside-inline-002.htm: Added.
The span should avoid a float even when its top and bottom does not overlap with the top of the span.
In this test the float overlaps the bottom of the span, but is below the span's first linebox.
* fast/block/float/floats-wrap-inside-inline-003-expected.html: Added.
* fast/block/float/floats-wrap-inside-inline-003.htm: Added.
An inline span should avoid a float even when its top and bottom does not overlap with the top of the span.
In this test the float starts and ends inside the span's first linebox.
* fast/block/float/floats-wrap-inside-inline-004-expected.html: Added.
* fast/block/float/floats-wrap-inside-inline-004.htm: Added.
The span should avoid a float even when its top and bottom does not overlap with the top of the span.
In this test the float overlaps inside the span and the span has height set by its style.
* fast/block/float/floats-wrap-inside-inline-005-expected.html: Added.
* fast/block/float/floats-wrap-inside-inline-005.htm: Added.
In this test the float starts and ends inside the span's second linebox, so only the second linebox should avoid the float.
* platform/chromium-win/css1/formatting_model/floating_elements-expected.txt:
This is a progression due to lineboxes now avoiding floats they overlap.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121789
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Tue, 3 Jul 2012 17:36:27 +0000 (17:36 +0000)]
[Qt][WTR] Get rid of using DumpRenderTreeSupportQt
https://bugs.webkit.org/show_bug.cgi?id=90262
Unreviewed build fix.
Reverting r121550 manually because it caused build
break on ARM and Mac. It turned out that the Qt build
system is too broken for this change now, first we have
to address two issues:
* symbol hiding was forbidden accidentally on x86 Linux
* Qt lacks a separate library for test support
* Tools.pro:
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::resetAfterTest):
(WTR::InjectedBundlePage::didClearWindowForFrame):
* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121788
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Tue, 3 Jul 2012 17:30:44 +0000 (17:30 +0000)]
Unreviewed chromium rebaseline for r121728.
* platform/chromium-mac/fast/multicol/vertical-rl/rules-with-border-before-expected.png: Added.
* platform/chromium-win/fast/multicol/vertical-rl/rules-with-border-before-expected.png:
* platform/chromium/fast/multicol/vertical-rl/rules-with-border-before-expected.png: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 3 Jul 2012 17:28:32 +0000 (17:28 +0000)]
[chromium] Handle trailing backslash on %VSINSTALLDIR%
https://bugs.webkit.org/show_bug.cgi?id=90410
Reviewed by Ojan Vafai.
* Scripts/webkitdirs.pm:
(buildChromiumVisualStudioProject): Handle VSINSTALLDIR ending in a backslash, the backslash escapes the closing double quote.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 3 Jul 2012 17:21:52 +0000 (17:21 +0000)]
Make the skia_test_expectations.txt file optional.
https://bugs.webkit.org/show_bug.cgi?id=90400
Reviewed by Dirk Pranke.
It used to be optional. This regressed at some point. It's important that it be
optional so that webkit-patch commands work in a pure-webkit checkout for chromium bots.
Specifically, this was breaking webkit-patch rebaseline-test when it would go to update
TestExpectations.
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.expectations_files):
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumDriverTest.test_expectations_dict):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Tue, 3 Jul 2012 17:17:12 +0000 (17:17 +0000)]
Unreviewed chromium rebaseline.
* platform/chromium-linux-x86/fast/line-grid: Added.
* platform/chromium-linux-x86/fast/line-grid/line-grid-into-columns-expected.txt: Added.
* platform/chromium-linux/fast/line-grid/line-grid-into-columns-expected.png:
* platform/chromium-linux/fast/line-grid/line-grid-into-columns-expected.txt: Added.
* platform/chromium-win-xp/fast/line-grid: Added.
* platform/chromium-win-xp/fast/line-grid/line-grid-into-columns-expected.txt: Added.
* platform/chromium-win/fast/line-grid/line-grid-into-columns-expected.png:
* platform/chromium-win/fast/line-grid/line-grid-into-columns-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121783
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rakuco@webkit.org [Tue, 3 Jul 2012 17:15:50 +0000 (17:15 +0000)]
[jhbuild][EFL] Bump libffi dependency.
https://bugs.webkit.org/show_bug.cgi?id=85373
Reviewed by Gustavo Noronha Silva.
Update libffi to 3.0.11, which fixes the build on some platforms
where 3.0.10 had problems.
* efl/jhbuild.modules:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Tue, 3 Jul 2012 17:14:54 +0000 (17:14 +0000)]
Unreviewed chromium TestExpectations update, marked a couple of tests as flaky on windows.
* platform/chromium/TestExpectations:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Tue, 3 Jul 2012 16:55:25 +0000 (16:55 +0000)]
Unreviewed chromium mac rebaseline.
* platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
* platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
* platform/chromium-mac/http/tests/misc/acid3-expected.txt:
* platform/chromium-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png:
* platform/chromium-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
* platform/chromium-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png:
* platform/chromium-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt:
* platform/chromium-win-xp/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos@webkit.org [Tue, 3 Jul 2012 16:34:07 +0000 (16:34 +0000)]
[BlackBerry] Enable microdata support for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=90429
Reviewed by Rob Buis.
.:
* Source/cmake/OptionsBlackBerry.cmake:
Tools:
* Scripts/webkitperl/FeatureList.pm:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121779
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Tue, 3 Jul 2012 16:29:06 +0000 (16:29 +0000)]
Web Inspector: Introduce Workspace make it UISourceCode provider for ScriptsPanel.
https://bugs.webkit.org/show_bug.cgi?id=90466
Reviewed by Pavel Feldman.
Introduced WebInspector.Workspace as a model (UISourceCode provider) behind ScriptsPanel.
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/ScriptsPanel.js:
* inspector/front-end/WebKit.qrc:
* inspector/front-end/Workspace.js: Added.
(WebInspector.CompositeUISourceCodeProvider):
(WebInspector.CompositeUISourceCodeProvider.prototype._registerUISourceCodeProvider):
(WebInspector.CompositeUISourceCodeProvider.prototype._handleUISourceCodeAdded):
(WebInspector.CompositeUISourceCodeProvider.prototype._handleUISourceCodeReplaced):
(WebInspector.CompositeUISourceCodeProvider.prototype._handleUISourceCodeRemoved):
(WebInspector.CompositeUISourceCodeProvider.prototype.uiSourceCodes):
(WebInspector.Workspace):
(WebInspector.Workspace.prototype.registerUISourceCodeProvider):
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121778
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Tue, 3 Jul 2012 16:22:10 +0000 (16:22 +0000)]
[Qt] Make use of .qmake.cache for caching features
Instead of loading() features from the files that need them (and re-running
a bunch of checks), we now run feature detection as part of configure.pro,
and have build-webkit write the computed feature-defines and CONFIG to
.qmake.cache, which is then loaded by qmake _before_ even defaults_pre
when building WebKit.pro.
At some point we'll be able to selectivly prevent running of config tests
in configure.pro, which means we don't need a separate code-path for
the build-webkit --help case.
We should also move the code in build-webkit that now uses .webkit.config
to detect clean builds, to use .qmake.cache, since we now store the same
thing there.
Original patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
https://bugs.webkit.org/show_bug.cgi?id=90461
Reviewed by Tor Arne Vestbø.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Tue, 3 Jul 2012 16:15:24 +0000 (16:15 +0000)]
-Wunused-private-field cleanup, linux edition
https://bugs.webkit.org/show_bug.cgi?id=90463
Reviewed by Stephen White.
* DumpRenderTree/chromium/DRTDevToolsAgent.h:
* DumpRenderTree/chromium/GamepadController.h:
(GamepadController):
* DumpRenderTree/chromium/NotificationPresenter.h:
(NotificationPresenter::NotificationPresenter):
(NotificationPresenter):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Jul 2012 16:04:50 +0000 (16:04 +0000)]
Unreviewed, rolling out r121766.
http://trac.webkit.org/changeset/121766
https://bugs.webkit.org/show_bug.cgi?id=90465
It caused flakey build errors on the bots (Requested by Ossy
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-03
.:
* Source/QtWebKit.pro:
* Source/api.pri:
* Source/tests.pri:
* WebKit.pro:
Source/WebCore:
* DerivedSources.pri:
* WebCore.pri:
Source/WebKit/qt:
* declarative/declarative.pro:
* declarative/public.pri:
* tests/qgraphicswebview/qgraphicswebview.pro:
Source/WebKit2:
* DerivedSources.pri:
* Target.pri:
Source/WTF:
* WTF.pri:
Tools:
* DumpRenderTree/qt/DumpRenderTree.pro:
* QtTestBrowser/QtTestBrowser.pro:
* Scripts/webkitdirs.pm:
(qtFeatureDefaults):
(buildQMakeProjects):
* Tools.pro:
* WebKitTestRunner/InjectedBundle/DerivedSources.pri:
* WebKitTestRunner/InjectedBundle/Target.pri:
* WebKitTestRunner/Target.pri:
* qmake/.qmake.conf: Removed.
* qmake/configure.pro:
* qmake/mkspecs/features/default_post.prf:
* qmake/mkspecs/features/default_pre.prf:
* qmake/mkspecs/features/features.prf:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos@webkit.org [Tue, 3 Jul 2012 16:00:22 +0000 (16:00 +0000)]
[BlackBerry] Enable Custom Scheme Handlers for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=90422
Reviewed by Rob Buis.
.:
* Source/cmake/OptionsBlackBerry.cmake:
Source/WebCore:
* page/NavigatorRegisterProtocolHandler.cpp:
(WebCore::initProtocolHandlerWhitelist): Disable the overrides as
they're undesired by BlackBerry
Source/WebKit/blackberry:
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore):
(WebCore::ChromeClientBlackBerry::isProtocolHandlerRegistered):
(WebCore::ChromeClientBlackBerry::unregisterProtocolHandler):
* WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
Tools:
* Scripts/webkitperl/FeatureList.pm:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos@webkit.org [Tue, 3 Jul 2012 15:53:31 +0000 (15:53 +0000)]
[BlackBerry] Enable RegisterProtocolHandler for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=90422
Reviewed by Rob Buis.
.:
* Source/cmake/OptionsBlackBerry.cmake:
Source/WebKit/blackberry:
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore):
(WebCore::ChromeClientBlackBerry::registerProtocolHandler):
* WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
Tools:
* Scripts/webkitperl/FeatureList.pm:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Jul 2012 15:48:38 +0000 (15:48 +0000)]
[GTK] Need to bump libsoup requirements (for `soup_cookie_jar_get_cookie_list`)
https://bugs.webkit.org/show_bug.cgi?id=90332
Patch by Priit Laes <plaes@plaes.org> on 2012-07-03
Reviewed by Gustavo Noronha Silva.
* configure.ac: Bump libsoup requirements to 2.39.2
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Tue, 3 Jul 2012 15:43:42 +0000 (15:43 +0000)]
[GTK] Add WebKitWebView::context-menu-dismissed signal to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=90386
Reviewed by Martin Robinson.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_class_init): Add context-menu-dismissed signal.
(contextMenuDismissed): Emit context-menu-dismissed signal.
(webkitWebViewPopulateContextMenu): Connect to deactivate signal
of the GtkMenu and emit WebKitWebView::context-menu-dismissed when
the gtk menu is deactivated.
* UIProcess/API/gtk/WebKitWebView.h:
(_WebKitWebViewClass): Add virtual methos for
context-menu-dismissed signal.
* UIProcess/API/gtk/tests/TestContextMenu.cpp:
(testContextMenuDismissed):
(beforeAll):
* UIProcess/gtk/WebContextMenuProxyGtk.h:
(WebKit::WebContextMenuProxyGtk::gtkMenu): Get the GtkMenu built
for the context menu proxy.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Jul 2012 15:40:02 +0000 (15:40 +0000)]
[EFL][WK2] Added missing WebPageProxy::ViewIsFocused flag to WebPageProxy::viewStateDidChange()
call in _ewk_view_smart_focus_out() function.
https://bugs.webkit.org/show_bug.cgi?id=89877
Patch by Piotr Roguski <p.roguski@samsung.com> on 2012-07-03
Reviewed by Andreas Kling.
Although name of the flag suggest it should be used only on focus in,
omitting it in case of focus out will prevent WebPageProxy::viewStateDidChange()
from sending Messages::WebPage::SetFocused(false).
* UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_focus_out):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ostapenko.viatcheslav@nokia.com [Tue, 3 Jul 2012 15:34:54 +0000 (15:34 +0000)]
[Qt][WK2] API tests randomly asserts in QQuickWebPage::setContentsScale(qreal)
https://bugs.webkit.org/show_bug.cgi?id=88679
Reviewed by Csaba Osztrogonác.
Viewport parameters cannot be calculated while viewport is not visible and
viewport size is 0, so let's delay calculation of viewport parameters until view
becomes visible.
* UIProcess/qt/QtViewportHandler.cpp:
(WebKit::QtViewportHandler::pageContentsSizeChanged):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Jul 2012 15:28:09 +0000 (15:28 +0000)]
[EFL] Add run API tests as a step on the build bots
https://bugs.webkit.org/show_bug.cgi?id=87252
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-03
Reviewed by Daniel Bates.
Run EFL API test suite on the build bots.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunEflAPITests):
(TestFactory.__init__):
(BuildAndTestFactory.__init__):
* Scripts/run-efl-tests: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Tue, 3 Jul 2012 15:27:06 +0000 (15:27 +0000)]
Web Inspector: Forward message loop instrumentation data to frontend.
https://bugs.webkit.org/show_bug.cgi?id=89584
Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-07-03
Reviewed by Yury Semikhatsky.
Transmit collected message loop tasks to inspector frontend.
Now "Program" should be a top-level event on browsers that
support message loop instrumentation.
Frontend was changed so that user will not see any changes.
Source/WebCore:
* inspector/InspectorTimelineAgent.cpp:
(TimelineRecordType):
Added new event type - "Program"
(WebCore::InspectorTimelineAgent::willProcessTask):
Begin "Program" event.
(WebCore::InspectorTimelineAgent::didProcessTask):
Finish "Program" event.
(WebCore::InspectorTimelineAgent::setHeapSizeStatistic):
Do not add counters to "Program" events.
(WebCore):
(WebCore::InspectorTimelineAgent::innerSetHeapSizeStatistic):
Renamed from "setHeapSizeStatistic"
* inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
* inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics.prototype._onRecordAdded):
Unwraps "Program" events.
(WebInspector.MemoryStatistics.prototype._innerRecordAdded):
Renamed from "_onRecordAdded"
* inspector/front-end/TimelineFrameController.js:
(WebInspector.TimelineFrameController.prototype._addRecord):
Unwraps "Program" events.
(WebInspector.TimelineFrameController.prototype._innerAddRecord):
Renamed from "_addRecord"
* inspector/front-end/TimelineModel.js:
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineCategoryStrips.prototype.update.appendRecord):
Filter out "Program" category.
(WebInspector.TimelineCategoryStrips.prototype.update):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
Filter out "Program" category.
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
Unwraps "Program" events.
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.categories):
Added "Program" category.
(WebInspector.TimelinePresentationModel.recordStyle):
Ditto.
(WebInspector.TimelinePresentationModel.prototype.addRecord):
Unwraps "Program" events.
(WebInspector.TimelinePresentationModel.prototype._addRecord):
Renamed from "addRecord"
LayoutTests:
* inspector/timeline/timeline-enum-stability-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Tue, 3 Jul 2012 15:23:20 +0000 (15:23 +0000)]
[Qt] Make use of .qmake.cache for caching features
Instead of loading() features from the files that need them (and re-running
a bunch of checks), we now run feature detection as part of configure.pro,
and have build-webkit write the computed feature-defines and CONFIG to
.qmake.cache, which is then loaded by qmake _before_ even defaults_pre
when building WebKit.pro.
At some point we'll be able to selectivly prevent running of config tests
in configure.pro, which means we don't need a separate code-path for
the build-webkit --help case.
We should also move the code in build-webkit that now uses .webkit.config
to detect clean builds, to use .qmake.cache, since we now store the same
thing there.
Original patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
https://bugs.webkit.org/show_bug.cgi?id=90461
Reviewed by Tor Arne Vestbø.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Tue, 3 Jul 2012 15:00:09 +0000 (15:00 +0000)]
inspector/debugger/script-snippet-model.html fails
https://bugs.webkit.org/show_bug.cgi?id=90385
Reviewed by Pavel Feldman.
Source/WebCore:
* inspector/front-end/ScriptSnippetModel.js:
LayoutTests:
* inspector/debugger/script-snippet-model-expected.txt:
* platform/chromium/inspector/debugger/script-snippet-model-expected.txt: Copied from LayoutTests/inspector/debugger/script-snippet-model-expected.txt.
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121765
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Tue, 3 Jul 2012 14:44:19 +0000 (14:44 +0000)]
[REGRESSION] Crash when copying a StyleRuleMedia with a NULL m_mediaQueries
https://bugs.webkit.org/show_bug.cgi?id=90459
Reviewed by Andreas Kling.
Source/WebCore:
Create StyleRuleMedia with a non-NULL MediaQuerySet. The respective NULL checks for it were all over the code,
except the copy constructor. Added the check, just in case.
* css/CSSParser.cpp:
(WebCore::CSSParser::createMediaRule):
* css/StyleRule.cpp:
(WebCore::StyleRuleMedia::StyleRuleMedia):
LayoutTests:
* inspector/styles/get-set-stylesheet-text-expected.txt:
* inspector/styles/resources/get-set-stylesheet-text.css:
(@media):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121764
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Tue, 3 Jul 2012 13:47:40 +0000 (13:47 +0000)]
Web Inspector: display time intervals measured with console.time() and console.timeEnd() in Timeline
https://bugs.webkit.org/show_bug.cgi?id=90442
Reviewed by Pavel Feldman.
Source/WebCore:
- added Time and TimeEnd record types produced by console.time() and console.timeEnd()
- connect Time to TimeEnd in "glue" mode to better visualize the interval;
- always make Time a top-level record;
* English.lproj/localizedStrings.js:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::startConsoleTimingImpl):
(WebCore::InspectorInstrumentation::stopConsoleTimingImpl):
* inspector/InspectorTimelineAgent.cpp:
(TimelineRecordType):
(WebCore::InspectorTimelineAgent::didStartTiming):
(WebCore):
(WebCore::InspectorTimelineAgent::didStopTiming):
* inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
* inspector/front-end/TimelineModel.js:
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.recordStyle):
(WebInspector.TimelinePresentationModel.categoryForRecord):
(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.prototype.addRecord):
(WebInspector.TimelinePresentationModel.prototype._findParentRecord):
(WebInspector.TimelinePresentationModel.Record):
(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):
LayoutTests:
- added Time & TimeEnd;
* inspector/timeline/timeline-enum-stability-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121763
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Jul 2012 13:43:13 +0000 (13:43 +0000)]
[Qt][Win] Fix broken QtWebKit5.lib linking
https://bugs.webkit.org/show_bug.cgi?id=88321
Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> Joel Dillon <joel.dillon@codethink.co.uk> on 2012-07-03
Reviewed by Kenneth Rohde Christiansen.
Source/JavaScriptCore:
The goal is to have different ports build systems define STATICALLY_LINKED_WITH_WTF
when building JavaScriptCore, if both are packaged in the same DLL, instead
of relying on the code to handle this.
The effects of BUILDING_* and STATICALLY_LINKED_WITH_* are currently the same
except for a check in Source/JavaScriptCore/config.h.
Keeping the old way for the WX port as requested by the port's contributors.
For non-Windows ports there is no difference between IMPORT and EXPORT, no
change is needed.
* API/JSBase.h:
JS symbols shouldn't be included by WTF objects anymore. Remove the export when BUILDING_WTF.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
Make sure that JavaScriptCore uses import symbols of WTF for the Win port.
* runtime/JSExportMacros.h:
Source/WebCore:
* platform/PlatformExportMacros.h:
Source/WTF:
Instead of letting a module's headers know which other modules depend on them,
have depending modules define explicitely that they want its symbols exported too.
JavaScriptCore should then be compiled with both BUILDING_JavaScriptCore and
STATICALLY_LINKED_WITH_WTF.
* wtf/ExportMacros.h:
Tools:
On windows the import/export definition is part of the symbol's signature.
Define STATICALLY_LINKED_WITH_$$library for each dependend module
that is being linked statically to make sure that they can be linked together
later on.
Also do not compile Assertions.cpp in DumpRenderTree anymore since all the
used symbols are exported and it would cause a duplicate symbols error.
* DumpRenderTree/qt/DumpRenderTree.pro:
* qmake/mkspecs/features/default_post.prf:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121762
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Tue, 3 Jul 2012 13:32:29 +0000 (13:32 +0000)]
[Qt] When calling accept() on the FilePickerContextObject with an empty list, early return and call reject().
https://bugs.webkit.org/show_bug.cgi?id=89755
Reviewed by Simon Hausmann.
When calling accept with an empty list of files we can just bailout
and call reject(). Any other processing is pointless.
* UIProcess/API/qt/tests/qmltests/WebView/tst_singleFileUpload.qml:
* UIProcess/qt/QtDialogRunner.cpp:
(WebKit::FilePickerContextObject::accept):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121761
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 3 Jul 2012 13:00:46 +0000 (13:00 +0000)]
cfg cleanup, pass BuildStep instances instead of BuildStep subclasses
https://bugs.webkit.org/show_bug.cgi?id=89001
Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-07-03
Reviewed by Csaba Osztrogonác.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(UploadBuiltProduct.__init__):
(UploadTestResults.__init__):
(ExtractTestResults.__init__):
(Factory.__init__):
(BuildFactory.__init__):
(TestFactory.__init__):
(BuildAndTestFactory.__init__):
(BuildAndPerfTestFactory.__init__):
(BuildAndPerfTestWebKit2Factory.__init__):
(DownloadAndPerfTestFactory.__init__):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Jul 2012 12:38:20 +0000 (12:38 +0000)]
Update unit test after r121724.
https://bugs.webkit.org/show_bug.cgi?id=90444
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-03
Reviewed by Csaba Osztrogonác.
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
(GardeningServerTest.test_rebaseline_new_port):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121759
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Jul 2012 12:37:50 +0000 (12:37 +0000)]
[EFL] Add new baselines after r121697, r121722 and r121728
https://bugs.webkit.org/show_bug.cgi?id=90446
Unreviewed gardening.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-03
* platform/efl/fast/dom/Element/getBoundingClientRect-expected.txt:
* platform/efl/fast/multicol/column-break-with-balancing-expected.png:
* platform/efl/fast/multicol/column-break-with-balancing-expected.txt: Added.
* platform/efl/fast/multicol/column-rules-expected.png:
* platform/efl/fast/multicol/column-rules-expected.txt: Added.
* platform/efl/fast/multicol/column-rules-stacking-expected.txt: Added.
* platform/efl/fast/multicol/columns-shorthand-parsing-expected.txt: Added.
* platform/efl/fast/multicol/nested-columns-expected.png:
* platform/efl/fast/multicol/nested-columns-expected.txt: Added.
* platform/efl/fast/multicol/shadow-breaking-expected.png:
* platform/efl/fast/multicol/shadow-breaking-expected.txt:
* platform/efl/fast/multicol/span/anonymous-split-block-crash-expected.png:
* platform/efl/fast/multicol/span/anonymous-split-block-crash-expected.txt: Added.
* platform/efl/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
* platform/efl/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
* platform/efl/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
* platform/efl/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Added.
* platform/efl/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Added.
* platform/efl/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
* platform/efl/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Added.
* platform/efl/fast/multicol/span/span-as-immediate-columns-child-expected.png:
* platform/efl/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Added.
* platform/efl/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
* platform/efl/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Added.
* platform/efl/fast/multicol/span/span-as-nested-columns-child-expected.png:
* platform/efl/fast/multicol/span/span-as-nested-columns-child-expected.txt: Added.
* platform/efl/fast/multicol/span/span-margin-collapsing-expected.png:
* platform/efl/fast/multicol/span/span-margin-collapsing-expected.txt: Added.
* platform/efl/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt: Added.
* platform/efl/fast/multicol/vertical-lr/column-rules-expected.png:
* platform/efl/fast/multicol/vertical-lr/column-rules-expected.txt:
* platform/efl/fast/multicol/vertical-lr/float-avoidance-expected.png:
* platform/efl/fast/multicol/vertical-lr/float-avoidance-expected.txt:
* platform/efl/fast/multicol/vertical-lr/nested-columns-expected.png:
* platform/efl/fast/multicol/vertical-lr/nested-columns-expected.txt: Copied from LayoutTests/platform/efl/fast/multicol/vertical-rl/nested-columns-expected.txt.
* platform/efl/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
* platform/efl/fast/multicol/vertical-rl/column-rules-expected.png:
* platform/efl/fast/multicol/vertical-rl/column-rules-expected.txt:
* platform/efl/fast/multicol/vertical-rl/float-avoidance-expected.png:
* platform/efl/fast/multicol/vertical-rl/float-avoidance-expected.txt:
* platform/efl/fast/multicol/vertical-rl/nested-columns-expected.png:
* platform/efl/fast/multicol/vertical-rl/nested-columns-expected.txt:
* platform/efl/fast/repaint/repaint-during-scroll-with-zoom-expected.png: Added.
* platform/efl/fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121758
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Tue, 3 Jul 2012 11:40:29 +0000 (11:40 +0000)]
Unreviewed GTK gardening, updating one baseline modified in r121745
to more suitable content.
* platform/gtk/fast/multicol/nested-columns-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121757
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pdr@google.com [Tue, 3 Jul 2012 10:29:08 +0000 (10:29 +0000)]
Fix text positioning with non-bmp characters.
https://bugs.webkit.org/show_bug.cgi?id=87681
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Previously when constructing metrics for tspans with non-bmp characters,
each non-bmp character treated as a skipped character in the same way that
spaces are ignored.
This made sense because the initial SVGCharacterDataMap for <text> is
indexed by character index (not string length) so the high portion of a
non-bmp character was treated as a skipped space. Unfortunately, this
led to a bug because skipped spaces lead to an offset in the positioning
values list but non-bmp characters do not.
This change switches the code to use a new offset for non-bmp characters,
surrogatePairCharacters, which does not affect the positioning values list.
Tests: svg/text/non-bmp-tspans-expected.svg
svg/text/non-bmp-tspans.svg
* rendering/svg/SVGTextMetricsBuilder.cpp:
(WebCore::SVGTextMetricsBuilder::measureTextRenderer):
LayoutTests:
* svg/text/non-bmp-tspans-expected.svg: Added.
* svg/text/non-bmp-tspans.svg: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121756
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Jul 2012 10:25:36 +0000 (10:25 +0000)]
[CSS Regions] Enabling regions on Windows lead to crash-on-launch for WebKit.exe
https://bugs.webkit.org/show_bug.cgi?id=90435
Patch by Mihai Balan <mibalan@adobe.com> on 2012-07-03
Reviewed by Csaba Osztrogonác.
Initial patch for enabling regions led to WebKit crashing on launch. Moving the
IDL declarations for CSS regions getter/setter at the end of the file solves the
problem. As per http://trac.webkit.org/changeset/95650 seems it has to do with
binary compatibility.
* Interfaces/IWebPreferences.idl: Mover getter/setter for CSS regions at the end of file
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121755
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Tue, 3 Jul 2012 10:12:47 +0000 (10:12 +0000)]
Improve test cases for network information APIs
https://bugs.webkit.org/show_bug.cgi?id=90162
Reviewed by Adam Barth.
Existing implementation doesn't test port implementation in network info APIs.
This patch lets test cases use bandwidth and metered functions implemented by port layer.
In addition, expected results need to check return type instead of property name.
Source/WebCore:
No new tests. Covered by existing tests.
* Modules/networkinfo/NetworkInfoConnection.cpp:
(WebCore::NetworkInfoConnection::bandwidth):
(WebCore::NetworkInfoConnection::metered):
LayoutTests:
* networkinformation/add-listener-from-callback-expected.txt:
* networkinformation/basic-all-types-of-events-expected.txt:
* networkinformation/basic-operation-expected.txt:
* networkinformation/multiple-frames-expected.txt:
* networkinformation/script-tests/add-listener-from-callback.js:
(checkNetworkInformation):
* networkinformation/script-tests/basic-all-types-of-events.js:
(checkNetworkInformation):
* networkinformation/script-tests/basic-operation.js:
* networkinformation/script-tests/multiple-frames.js:
(checkNetworkInformation):
(checkChildNetworkInformation):
* networkinformation/script-tests/updates.js:
(checkNetworkInformation):
* networkinformation/updates-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121754
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Jul 2012 10:07:56 +0000 (10:07 +0000)]
Unreviewed, rolling out r121749.
http://trac.webkit.org/changeset/121749
https://bugs.webkit.org/show_bug.cgi?id=90441
Tests crash on the paralel NRWT Qt bot (Requested by Ossy on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-03
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._build_driver):
* Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
(XvfbDriver._start):
(XvfbDriver._start.x_filter):
(XvfbDriver.stop):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121753
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Jul 2012 10:04:12 +0000 (10:04 +0000)]
[EFL] [WK2] Don't call eina_iterator_free() if iterator is NULL
https://bugs.webkit.org/show_bug.cgi?id=90076
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-03
Reviewed by Kenneth Rohde Christiansen.
Add a null check to prevent calling eina_iterator_free() when
iterator is NULL.
No new tests. This patch doesn't change behavior.
* platform/efl/FileSystemEfl.cpp:
(WebCore::listDirectory): Early return when iterator is NULL.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121752
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Tue, 3 Jul 2012 09:49:46 +0000 (09:49 +0000)]
Web Inspector: [Elements] Text formatting is not retained when editing <script> or <style> contents as text
https://bugs.webkit.org/show_bug.cgi?id=90440
Reviewed by Vsevolod Vlasov.
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._startEditingTextNode):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121751
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Tue, 3 Jul 2012 09:28:41 +0000 (09:28 +0000)]
Web Inspector: Save scroll selection and cursor position of SourceFrames in sources panel.
https://bugs.webkit.org/show_bug.cgi?id=90294
Reviewed by Yury Semikhatsky.
Source/WebCore:
Scroll and selection change handling is now delegated from TextViewer to SourceFrame.
SourceFrame now dispatches ScrollChanged and SelectionChanged events.
TabbedEditorContainer now saves scroll and selection information together
with the url history and restores scroll and selection on resource opening.
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.setExecutionLine):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.wasShown):
(WebInspector.SourceFrame.prototype.highlightLine):
(WebInspector.SourceFrame.prototype._innerHighlightLineIfNeeded):
(WebInspector.SourceFrame.prototype._clearLineHighlight):
(WebInspector.SourceFrame.prototype.revealLine):
(WebInspector.SourceFrame.prototype._innerRevealLineIfNeeded):
(WebInspector.SourceFrame.prototype._clearLineToReveal):
(WebInspector.SourceFrame.prototype.scrollToLine):
(WebInspector.SourceFrame.prototype._innerScrollToLineIfNeeded):
(WebInspector.SourceFrame.prototype._clearLineToScrollTo):
(WebInspector.SourceFrame.prototype.setSelection):
(WebInspector.SourceFrame.prototype._innerSetSelectionIfNeeded):
(WebInspector.SourceFrame.prototype._wasShownOrLoaded):
(WebInspector.SourceFrame.prototype.setContent):
(WebInspector.SourceFrame.prototype.commitEditing):
(WebInspector.SourceFrame.prototype.selectionChanged):
(WebInspector.SourceFrame.prototype.scrollChanged):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.selectionChanged):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.scrollChanged):
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer):
(WebInspector.TabbedEditorContainer.prototype._addScrollAndSelectionListeners):
(WebInspector.TabbedEditorContainer.prototype._removeScrollAndSelectionListeners):
(WebInspector.TabbedEditorContainer.prototype._scrollChanged):
(WebInspector.TabbedEditorContainer.prototype._selectionChanged):
(WebInspector.TabbedEditorContainer.prototype._appendFileTab):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
(WebInspector.TabbedEditorContainer.HistoryItem):
(WebInspector.TabbedEditorContainer.HistoryItem.fromObject):
(WebInspector.TabbedEditorContainer.HistoryItem.prototype.serializeToObject):
(WebInspector.TabbedEditorContainer.History):
(WebInspector.TabbedEditorContainer.History.fromObject):
(WebInspector.TabbedEditorContainer.History.prototype.index):
(WebInspector.TabbedEditorContainer.History.prototype.selectionRange):
(WebInspector.TabbedEditorContainer.History.prototype.updateSelectionRange):
(WebInspector.TabbedEditorContainer.History.prototype.scrollLineNumber):
(WebInspector.TabbedEditorContainer.History.prototype.updateScrollLineNumber):
(WebInspector.TabbedEditorContainer.History.prototype.update):
(WebInspector.TabbedEditorContainer.History.prototype.remove):
(WebInspector.TabbedEditorContainer.History.prototype.save):
(WebInspector.TabbedEditorContainer.History.prototype.set _serializeToObject):
* inspector/front-end/TextEditorModel.js:
(WebInspector.TextRange.fromObject):
(WebInspector.TextRange.prototype.clone):
(WebInspector.TextRange.prototype.serializeToObject):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._handleScrollChanged):
(WebInspector.TextViewer.prototype.scrollToLine):
(WebInspector.TextViewer.prototype._handleSelectionChange):
(WebInspector.TextViewer.prototype.setSelection):
(WebInspector.TextViewer.prototype.wasShown):
(WebInspector.TextViewer.prototype._handleFocused):
(WebInspector.TextViewer.prototype.willHide):
(WebInspector.TextViewerDelegate.prototype.selectionChanged):
(WebInspector.TextViewerDelegate.prototype.scrollChanged):
(WebInspector.TextEditorChunkedPanel.prototype.scrollToLine):
LayoutTests:
* inspector/tabbed-editors-history-expected.txt:
* inspector/tabbed-editors-history.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121750
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Tue, 3 Jul 2012 09:26:19 +0000 (09:26 +0000)]
[NRWT] XvfbDriver should choose the next free display
https://bugs.webkit.org/show_bug.cgi?id=88414
Reviewed by Dirk Pranke.
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._driver_class):
* Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
(XvfbDriver.__init__):
(XvfbDriver._start):
(XvfbDriver._start.next_free_id):
(XvfbDriver.stop):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121749
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Jul 2012 09:17:23 +0000 (09:17 +0000)]
Web Inspector: Make DirectoryContentView sortable
https://bugs.webkit.org/show_bug.cgi?id=90361
Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-07-03
Reviewed by Vsevolod Vlasov.
Source/WebCore:
* inspector/Inspector.json:
* inspector/InspectorFileSystemAgent.cpp:
(WebCore):
* inspector/front-end/DirectoryContentView.js:
(WebInspector.DirectoryContentView):
(WebInspector.DirectoryContentView.prototype.showEntries):
(WebInspector.DirectoryContentView.prototype._sort):
(WebInspector.DirectoryContentView.Node.comparator.isDirectoryCompare):
(WebInspector.DirectoryContentView.Node.comparator.nameCompare):
(WebInspector.DirectoryContentView.Node.comparator.typeCompare):
(WebInspector.DirectoryContentView.Node.comparator.sizeCompare):
(WebInspector.DirectoryContentView.Node.comparator):
(WebInspector.DirectoryContentView.Node.prototype._metadataReceived):
LayoutTests:
* http/tests/inspector/filesystem/get-metadata-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121748
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yosin@chromium.org [Tue, 3 Jul 2012 08:58:49 +0000 (08:58 +0000)]
[Chromium] Rebaseline: fast/box-sizing/box-sizing.html
* platform/chromium-mac-snowleopard/fast/box-sizing/box-sizing-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/box-sizing/box-sizing-expected.txt.
* platform/chromium-mac/fast/box-sizing/box-sizing-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121747
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Tue, 3 Jul 2012 08:45:08 +0000 (08:45 +0000)]
Web Inspector: WebInspector.TextViewer should be renamed WebInspector.TextEditor
https://bugs.webkit.org/show_bug.cgi?id=89939
Patch by Jan Keromnes <janx@linux.com> on 2012-07-03
Reviewed by Vsevolod Vlasov.
PerformanceTests:
* inspector/first-open-scripts.html.broken:
Source/WebCore:
Fixed LayoutTests and PerformanceTests accordingly.
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/AdvancedSearchController.js:
(WebInspector.SearchView):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype._onHidePopover):
(WebInspector.JavaScriptSourceFrame.prototype._addBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._removeBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._editBreakpointCondition.finishEditing):
(WebInspector.JavaScriptSourceFrame.prototype._editBreakpointCondition):
(WebInspector.JavaScriptSourceFrame.prototype.setExecutionLine):
(WebInspector.JavaScriptSourceFrame.prototype.clearExecutionLine):
(WebInspector.JavaScriptSourceFrame.prototype.onTextEditorContentLoaded):
(WebInspector.JavaScriptSourceFrame.prototype.toggleBreakpointOnCurrentLine):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.wasShown):
(WebInspector.SourceFrame.prototype.willHide):
(WebInspector.SourceFrame.prototype.defaultFocusedElement):
(WebInspector.SourceFrame.prototype.get textEditor):
(WebInspector.SourceFrame.prototype.clearMessages):
(WebInspector.SourceFrame.prototype.highlightLine):
(WebInspector.SourceFrame.prototype._clearLineHighlight):
(WebInspector.SourceFrame.prototype.revealLine):
(WebInspector.SourceFrame.prototype.setSelection):
(WebInspector.SourceFrame.prototype.setContent):
(WebInspector.SourceFrame.prototype.onTextEditorContentLoaded):
(WebInspector.SourceFrame.prototype._setTextEditorDecorations):
(WebInspector.SourceFrame.prototype.searchCanceled):
(WebInspector.SourceFrame.prototype.jumpToSearchResult):
(WebInspector.SourceFrame.prototype.addMessageToSource):
(WebInspector.SourceFrame.prototype.removeMessageFromSource):
(WebInspector.SourceFrame.prototype.inheritScrollPositions):
(WebInspector.TextEditorDelegateForSourceFrame):
* inspector/front-end/TextViewer.js: Removed.
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/textViewer.css: Removed.
Source/WebKit/blackberry:
* WebCoreSupport/inspectorBB.html:
LayoutTests:
* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* http/tests/inspector/live-edit-test.js:
(initialize_LiveEditTest.InspectorTest.replaceInSource):
(initialize_LiveEditTest):
* http/tests/inspector/resources-test.js:
(initialize_ResourceTest.InspectorTest.showResource.showResourceCallback):
(initialize_ResourceTest.InspectorTest.showResource):
* inspector/debugger/pause-in-inline-script.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121746
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Tue, 3 Jul 2012 08:37:25 +0000 (08:37 +0000)]
Unreviewed GTK gardening, updating baselines after r121697 and r121728
and adding text and pixel baselines required after r121722.
* platform/gtk/fast/dom/Element/getBoundingClientRect-expected.txt:
* platform/gtk/fast/multicol/column-break-with-balancing-expected.txt: Added.
* platform/gtk/fast/multicol/column-rules-expected.txt: Added.
* platform/gtk/fast/multicol/column-rules-stacking-expected.txt: Added.
* platform/gtk/fast/multicol/columns-shorthand-parsing-expected.txt: Added.
* platform/gtk/fast/multicol/nested-columns-expected.txt: Added.
* platform/gtk/fast/multicol/shadow-breaking-expected.txt:
* platform/gtk/fast/multicol/span/anonymous-split-block-crash-expected.txt: Added.
* platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
* platform/gtk/fast/multicol/span/generated-child-split-flow-crash-expected.txt:
* platform/gtk/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Added.
* platform/gtk/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Added.
* platform/gtk/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Added.
* platform/gtk/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Added.
* platform/gtk/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Added.
* platform/gtk/fast/multicol/span/span-as-nested-columns-child-expected.txt: Added.
* platform/gtk/fast/multicol/span/span-margin-collapsing-expected.txt: Added.
* platform/gtk/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt: Added.
* platform/gtk/fast/multicol/vertical-lr/column-rules-expected.txt:
* platform/gtk/fast/multicol/vertical-lr/float-avoidance-expected.txt:
* platform/gtk/fast/multicol/vertical-lr/nested-columns-expected.txt: Added.
* platform/gtk/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
* platform/gtk/fast/multicol/vertical-rl/column-rules-expected.txt:
* platform/gtk/fast/multicol/vertical-rl/float-avoidance-expected.txt:
* platform/gtk/fast/multicol/vertical-rl/nested-columns-expected.txt:
* platform/gtk/fast/repaint/repaint-during-scroll-with-zoom-expected.png: Added.
* platform/gtk/fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121745
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yosin@chromium.org [Tue, 3 Jul 2012 08:31:39 +0000 (08:31 +0000)]
[Chromium] Update text expectation for timeline-receive-response-event.html
* platform/chromium/TestExpectations: Add "TEXT"
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121744
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jochen@chromium.org [Tue, 3 Jul 2012 08:28:46 +0000 (08:28 +0000)]
[chromium] Unreviewed gardening.
platform/chromium/permissionclient/storage-permission.html consistently
passes
* platform/chromium/TestExpectations:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121743
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
charles.wei@torchmobile.com.cn [Tue, 3 Jul 2012 08:28:44 +0000 (08:28 +0000)]
IndexedDB: should make the LevelDB persistant to the directory indicated in PageGroupSettings::indexedDBDataBasePath
https://bugs.webkit.org/show_bug.cgi?id=88338
Reviewed by David Levin.
Source/WebCore:
If the indexedDB runs in main thread it can access the GroupSettings via the document;
otherwise, we need to pass the page GroupSettings to the worker thread so that accessible
to the indexedDB running in WorkerContext.
* Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::open):
* workers/DedicatedWorkerThread.cpp:
(WebCore::DedicatedWorkerThread::create):
(WebCore::DedicatedWorkerThread::DedicatedWorkerThread):
* workers/DedicatedWorkerThread.h:
(DedicatedWorkerThread):
* workers/DefaultSharedWorkerRepository.cpp:
(SharedWorkerProxy):
(WebCore::SharedWorkerProxy::groupSettings):
(WebCore):
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
* workers/SharedWorkerThread.cpp:
(WebCore::SharedWorkerThread::create):
(WebCore::SharedWorkerThread::SharedWorkerThread):
* workers/SharedWorkerThread.h:
(SharedWorkerThread):
* workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerContext):
* workers/WorkerThread.cpp:
(WebCore::WorkerThreadStartupData::create):
(WorkerThreadStartupData):
(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::groupSettings):
(WebCore):
* workers/WorkerThread.h:
(WorkerThread):
Source/WebKit/chromium:
* src/WebSharedWorkerImpl.cpp:
(WebKit::WebSharedWorkerImpl::startWorkerContext):
* src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::startWorkerContext):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121742
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Tue, 3 Jul 2012 08:24:58 +0000 (08:24 +0000)]
[Qt] Unreviewed gardening after r121728. Updated expectations to
fast/multicol/span/span-as-immediate-child-generated-content.html.
Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-07-03
* platform/qt/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
* platform/qt/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121741
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Tue, 3 Jul 2012 08:22:34 +0000 (08:22 +0000)]
[Qt][WK2] fast/viewport/viewport-91.html still fails after r121555 and r121661
https://bugs.webkit.org/show_bug.cgi?id=90376
Reviewed by Csaba Osztrogonác.
Source/WebCore:
No new tests, this is only a build alignment.
Export ViewportArguments::deprecatedTargetDPI since it is used in WebKit2.
* WebCore.exp.in:
Source/WebKit2:
layoutTestController.dumpConfigurationForViewport still need
to use the constant target DPI of 160.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::viewportConfigurationAsText):
LayoutTests:
Unskip passing test.
* platform/qt-5.0-wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121740
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yosin@chromium.org [Tue, 3 Jul 2012 08:20:09 +0000 (08:20 +0000)]
[Chromium] Rebaseline for Mac10.6
* platform/chromium-mac-snowleopard/fast/events/offsetX-offsetY-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121739
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Jul 2012 08:17:42 +0000 (08:17 +0000)]
[Chromium] Tests still crashing for Linux Release as well.
https://bugs.webkit.org/show_bug.cgi?id=89979
Patch by Michael Starzinger <mstarzinger@chromium.org> on 2012-07-03
Reviewed by Tony Chang.
* platform/chromium/TestExpectations:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121738
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yosin@chromium.org [Tue, 3 Jul 2012 08:10:15 +0000 (08:10 +0000)]
[Chromium] Rebaseline: Add missing expectation files introduced by r121722
* platform/chromium-mac-snowleopard/fast/repaint/repaint-during-scroll-with-zoom-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Added.
* platform/chromium-mac/fast/repaint/repaint-during-scroll-with-zoom-expected.png: Added.
* platform/chromium-mac/fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Added.
* platform/chromium-win-xp/fast/repaint/repaint-during-scroll-with-zoom-expected.png: Added.
* platform/chromium-win-xp/fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Added.
* platform/chromium-win/fast/repaint/repaint-during-scroll-with-zoom-expected.png: Added.
* platform/chromium-win/fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121737
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Tue, 3 Jul 2012 07:49:01 +0000 (07:49 +0000)]
[Qt] Unreviewed Gardening after r121697. Updated expected files.
Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-07-03
* platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.png:
* platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.txt:
* platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.png:
* platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121736
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hbono@chromium.org [Tue, 3 Jul 2012 07:06:06 +0000 (07:06 +0000)]
Calculate client positions from offsets.
https://bugs.webkit.org/show_bug.cgi?id=73640
Reviewed by Tony Chang.
This change calculates client positions from offset positions at run time to
remove platform-dependent constants from this test.
* fast/events/offsetX-offsetY-expected.txt:
* fast/events/offsetX-offsetY.html:
* platform/chromium-win/fast/events/offsetX-offsetY-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121735
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Jul 2012 07:01:58 +0000 (07:01 +0000)]
[EFL] Enable MICRODATA support
https://bugs.webkit.org/show_bug.cgi?id=90377
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-03
Reviewed by Kenneth Rohde Christiansen.
.:
Turn on MICRODATA support by default for EFL port.
* Source/cmake/OptionsEfl.cmake:
Tools:
Turn on MICRODATA flag for EFL port by default.
* Scripts/webkitperl/FeatureList.pm:
LayoutTests:
Unskip microdata test cases now that support has been
enabled for EFL port.
* platform/efl/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121734
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Jul 2012 06:54:42 +0000 (06:54 +0000)]
[EFL][WK2] Add API to deliver a Web Intent to a frame
https://bugs.webkit.org/show_bug.cgi?id=90067
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-03
Reviewed by Kenneth Rohde Christiansen.
Add ewk_view_intent_deliver() method on the Ewk_View
to deliver a Web Intent to the view's main frame.
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_intent_deliver):
* UIProcess/API/efl/ewk_view.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121733
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Jul 2012 06:27:10 +0000 (06:27 +0000)]
[EFL][WK2] Add API to inspect a Web Intent service
https://bugs.webkit.org/show_bug.cgi?id=90066
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-02
Reviewed by Kenneth Rohde Christiansen.
Add EFL API to inspect a Web Intent Service and emit
a signal on the view when a new intent service
registers.
* PlatformEfl.cmake:
* UIProcess/API/efl/EWebKit2.h:
* UIProcess/API/efl/ewk_intent_service.cpp: Added.
(_Ewk_Intent_Service):
(ewk_intent_service_ref):
(ewk_intent_service_unref):
(ewk_intent_service_action_get):
(ewk_intent_service_type_get):
(ewk_intent_service_href_get):
(ewk_intent_service_title_get):
(ewk_intent_service_disposition_get):
(ewk_intent_service_new):
* UIProcess/API/efl/ewk_intent_service.h: Added.
* UIProcess/API/efl/ewk_intent_service_private.h: Copied from Source/WebKit2/UIProcess/API/efl/ewk_view_loader_client.cpp.
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_intent_service_register):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/ewk_view_loader_client.cpp:
(registerIntentServiceForFrame):
(ewk_view_loader_client_attach):
* UIProcess/API/efl/ewk_view_private.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121732
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Jul 2012 06:24:19 +0000 (06:24 +0000)]
[WK2][EFL] Free Ewk_Intent calloc'd memory with free() instead of delete
https://bugs.webkit.org/show_bug.cgi?id=90433
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-02
Reviewed by Kenneth Rohde Christiansen.
Free calloc'd memory with free() instead of delete in Ewk_Intent.
Add blank lines before return statements for consistency.
* UIProcess/API/efl/ewk_intent.cpp:
(ewk_intent_unref):
(ewk_intent_action_get):
(ewk_intent_type_get):
(ewk_intent_service_get):
(ewk_intent_suggestions_get):
(ewk_intent_extra_get):
(ewk_intent_extra_names_get):
(ewk_intent_new):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121731
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yosin@chromium.org [Tue, 3 Jul 2012 04:42:46 +0000 (04:42 +0000)]
Layout Test inspector/timeline/timeline-receive-response-event.html is failing
https://bugs.webkit.org/show_bug.cgi?id=90430
Unreviewd build fix
* platform/chromium/TestExpectations: Mark timeline-receive-response-event.html flaky
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Jul 2012 04:25:35 +0000 (04:25 +0000)]
[TextureMapper] The TextureMapper should support edge-distance anti-antialiasing
https://bugs.webkit.org/show_bug.cgi?id=90308
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-07-02
Reviewed by Noam Rosenthal.
Source/WebCore:
Add an edge-distance anti-aliasing implementation for the TextureMapper. Currently
this implementation is not active for tiled layers. This implementation is based
on the one in the Chromium compositor originally written by David Raveman.
When a layer is transformed in a way that leaves its edge dimensions across pixel
boundaries, edge distance anti-aliasing will do a cheaper form of anti-aliasing
than full-scene anti-aliasing to make the transition from the layer pixel
to the background pixel smoother.
No new tests. This will be covered by pixel tests for Qt and GTK+ accelerated
compositing and 3D transforms, when those test harnesses are capable of
producing pixel output (in progress).
* platform/graphics/texmap/TextureMapper.h: Add an enum which is used to tell
the texture mapper what edges of a texture are exposed. This will be used for
properly dealing with tiled layers in the future.
* platform/graphics/texmap/TextureMapperBackingStore.cpp: Properly pass information
about exposed layer edges to the TextureMapper while painting.
* platform/graphics/texmap/TextureMapperBackingStore.h:
(TextureMapperTile): Modified arguments include exposed edges.
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawQuad): Renamed from drawRect, this method can now
draw quads that have non unit-rect texture coordinates. This is necessary because
the edge distance approach draws such quad.
(WebCore::TextureMapperGL::drawBorder): Call drawQuad now instead of drawRect.
(WebCore::TextureMapperGL::drawTexture): Pass the exposedEdges argument down.
(WebCore::TextureMapperGL::drawTextureRectangleARB): Call drawQuad now instead of
drawRect.
(WebCore::viewportMatrix): Added this helper which can calculate the viewport
transform based on the current OpenGL viewport settings.
(WebCore::scaleLineEquationCoeffecientsToOptimizeDistanceCalculation): Added this
helper which optimizes the fragment shader by precalculating some constant parts
of the distance calculation.
(WebCore::getStandardEquationCoeffecientsForLine): Given two end points of line segment
get the coeffecients of the line in the standard form of the line equation.
(WebCore::quadToEdgeArray): Converts a FloatQuad to an array of four sets of pre-scaled
line coefficients so that they can be passed to OpenGL.
(WebCore::scaledVectorDifference): Helper which helps expand a quad of arbitrary
orientation.
(WebCore::inflateQuad): Inflate a quad of arbitrary orientation. The transform may
flip it so we have to look at neighboring points to expand the quad.
(WebCore::TextureMapperGL::drawTextureWithAntialiasing): Activate the anti-aliasing
program and set up all uniforms.
(WebCore::TextureMapperGL::drawTexturedQuadWithProgram): Abstract out common operations
from drawTexture to be used with drawTextureWithAntialiasing.
* platform/graphics/texmap/TextureMapperGL.h:
(WebCore::TextureMapperGL::DrawQuad::DrawQuad): Add this small type which stores information
necessary to draw a quad -- it's original destination rect and the final size mapped to
texture coordinates.
(TextureMapperGL):
* platform/graphics/texmap/TextureMapperImageBuffer.cpp: Add the new exposedEdges argument.
* platform/graphics/texmap/TextureMapperImageBuffer.h: Ditto.
* platform/graphics/texmap/TextureMapperShaderManager.cpp: Add the new fragment shader for
doing edge-distance AA and a program which uses that shader.
* platform/graphics/texmap/TextureMapperShaderManager.h: Ditto.
Source/WebKit2:
* UIProcess/texmap/LayerBackingStore.cpp:
(WebKit::LayerBackingStore::paintToTextureMapper): Update the method to call paint with
the new argument.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121729
268f45cc-cd09-0410-ab3c-
d52691b4dbfc