Edward Hervey [Mon, 30 Dec 2013 15:34:08 +0000 (16:34 +0100)]
nettimeprovider: Remove dead code
err is always NULL by the point we reach this line
COVERITY CID
1037151
Stefan Sauer [Mon, 30 Dec 2013 13:47:19 +0000 (14:47 +0100)]
taglist: fix since marker again (1.3 -> 1.4)
Since markers should point to the appropriate stable version.
Stefan Sauer [Mon, 30 Dec 2013 13:40:40 +0000 (14:40 +0100)]
taglist: fix since-marker in docs (we're in 1.3.X)
Stefan Sauer [Mon, 30 Dec 2013 13:22:37 +0000 (14:22 +0100)]
taglist: add a tag for midi base note numbers
Audio files containing sampled instruments can have metadata describing the note
that was played on the instrument.
Sebastian Dröge [Mon, 30 Dec 2013 09:01:39 +0000 (10:01 +0100)]
pad: Don't ignore probe callback return value when immediately calling IDLE probe
https://bugzilla.gnome.org/show_bug.cgi?id=721096
Pedro Côrte-Real [Sun, 29 Dec 2013 14:06:55 +0000 (14:06 +0000)]
scripts: git-update.sh: fix for non-master branches
Pull from tracking branch instead of origin/master, so
that this works with e.g. 1.2 as well.
Sebastian Dröge [Fri, 27 Dec 2013 11:55:02 +0000 (12:55 +0100)]
parse: Use GLib malloc/free/realloc functions
https://bugzilla.gnome.org/show_bug.cgi?id=720100
Tim-Philipp Müller [Thu, 26 Dec 2013 12:16:26 +0000 (12:16 +0000)]
scripts: create-uninstalled-setup: re-use existing master branch if it exists
When creating separate checkout for non-master branches.
Erik Andresen [Thu, 26 Dec 2013 10:39:27 +0000 (11:39 +0100)]
docs: fix memory leak of appsink example in manual
https://bugzilla.gnome.org/show_bug.cgi?id=721076
Tim-Philipp Müller [Sun, 22 Dec 2013 22:33:12 +0000 (22:33 +0000)]
Automatic update of common submodule
From
dbedaa0 to
d48bed3
Tim-Philipp Müller [Sun, 22 Dec 2013 22:04:37 +0000 (22:04 +0000)]
po: update for string changes
Tim-Philipp Müller [Sun, 22 Dec 2013 21:56:03 +0000 (21:56 +0000)]
po: set gettext domain in Makevars so we don't have to patch the generated Makefile.in.in
https://bugzilla.gnome.org/show_bug.cgi?id=705455
Wim Taymans [Fri, 20 Dec 2013 13:41:06 +0000 (14:41 +0100)]
utils: Add round down 128 macro for completeness
Nicolas Dufresne [Wed, 13 Nov 2013 22:06:23 +0000 (17:06 -0500)]
utils: Add round up 128 macro
Sebastian Dröge [Fri, 20 Dec 2013 13:30:22 +0000 (14:30 +0100)]
funnel: Setting the PROXY_CAPS flag on the srcpad does not make much sense
funnel outputs whatever one of the upstreams currently outputs, a caps
query to a random upstream does not give the right answer here.
Sebastian Dröge [Fri, 20 Dec 2013 10:37:53 +0000 (11:37 +0100)]
funnel: Proxy CAPS and ALLOCATION queries
Thiago Santos [Mon, 18 Nov 2013 13:46:00 +0000 (10:46 -0300)]
multiqueue: post 100% buffering if single queue is not linked
This makes buffering stop in case a stream switch happens. This is
important for adaptive streams that can disable not-linked streams
to avoid consuming the network bandwidth.
https://bugzilla.gnome.org/show_bug.cgi?id=719575
William Jon McCann [Wed, 18 Dec 2013 10:19:46 +0000 (05:19 -0500)]
docs: fix project links
https://bugzilla.gnome.org/show_bug.cgi?id=720665
David Svensson Fors [Tue, 10 Dec 2013 14:53:54 +0000 (15:53 +0100)]
basesrc: use segment start if DTS for first buffer is unset
https://bugzilla.gnome.org/show_bug.cgi?id=720199
Matthieu Bouron [Thu, 12 Dec 2013 17:17:40 +0000 (17:17 +0000)]
gst-uninstalled: add gstreamer-vaapi paths
https://bugzilla.gnome.org/show_bug.cgi?id=720337
Tim-Philipp Müller [Sat, 14 Dec 2013 21:20:45 +0000 (21:20 +0000)]
tests: add unit test for bitreader, bytereader and bytewriter with no inlining used
Tim-Philipp Müller [Sat, 14 Dec 2013 18:38:41 +0000 (18:38 +0000)]
bytereader: add inline variant of gst_byte_reader_init()
Tim-Philipp Müller [Sat, 14 Dec 2013 18:31:38 +0000 (18:31 +0000)]
docs: fix docs for gst_queue_array_peek_head()
Sebastian Dröge [Sat, 14 Dec 2013 18:08:35 +0000 (19:08 +0100)]
parse: Don't define yyscan_t twice
https://bugzilla.gnome.org/show_bug.cgi?id=720316
Tim-Philipp Müller [Fri, 13 Dec 2013 22:51:32 +0000 (22:51 +0000)]
docs: moving plugins: minor 0.10 -> 1.0 fix
Spotted by Jay Fenlason
Wim Taymans [Wed, 11 Dec 2013 13:42:34 +0000 (14:42 +0100)]
queue: don't ignore event return value
Pass the event return value upstream.
Remove strange goto construct.
Edward Hervey [Tue, 10 Dec 2013 23:30:03 +0000 (18:30 -0500)]
gst-launch: Handle taglist copy failure
If we couldn't copy the tags, just return instead of trying to use bogus
values.
Edward Hervey [Tue, 10 Dec 2013 23:25:22 +0000 (18:25 -0500)]
gst-inspect: Index features are no more
So remove code that will never be used
Edward Hervey [Tue, 10 Dec 2013 22:53:24 +0000 (17:53 -0500)]
gstvalue: Fix comparision of double range
Checking twice the lower bound is great (you never know, it might change
between the two calls by someone using emacs butterfly-mode), but it's a bit
more useful to check the higher bound are also identical.
Detected by Coverity
Edward Hervey [Tue, 10 Dec 2013 22:09:07 +0000 (17:09 -0500)]
controller: Fix out-of-bounds detection
We want to abort if we higher than the maximum *OR* lower than the minimum
accepted value.
Detected by Coverity.
Tim-Philipp Müller [Sat, 7 Dec 2013 19:04:16 +0000 (19:04 +0000)]
tests: add unit test for registering the same category twice
Víctor Manuel Jáquez Leal [Sat, 7 Dec 2013 18:32:58 +0000 (19:32 +0100)]
info: return existing category if a debug category is registered twice
If a category with the same name is found when creating a new
one, the found category is returned instead of an invalid pointer.
Fixes issue with gst-vaapi (which uses an internal copy of the
codec parsers) caused by commit
ccba9130.
https://bugzilla.gnome.org/show_bug.cgi?id=720036
Sebastian Rasmussen [Sat, 7 Dec 2013 14:38:19 +0000 (15:38 +0100)]
docs: Fix typos in function/object descriptions
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=720029
Sebastian Rasmussen [Sat, 7 Dec 2013 14:40:32 +0000 (15:40 +0100)]
Fix some typos in code comments and debug messages
https://bugzilla.gnome.org/show_bug.cgi?id=720029
Stewart Brodie [Fri, 6 Dec 2013 20:50:19 +0000 (20:50 +0000)]
docs: clarify encoding of strings in GstStructures and taglists
https://bugzilla.gnome.org/show_bug.cgi?id=709262
Olivier Crête [Wed, 3 Jul 2013 00:27:59 +0000 (20:27 -0400)]
basesrc: Set format to TIME if do-timestamp is TRUE
https://bugzilla.gnome.org/show_bug.cgi?id=702842
Tim-Philipp Müller [Thu, 5 Dec 2013 00:26:13 +0000 (00:26 +0000)]
tools: gst-launch: don't try to remove already-removed GSource from main loop
It's considered a programming error in recent GLib versions now.
We may already have removed the source by returning FALSE from
the callback if it was fired. Fixes warning with newer GLibs
when interrupting a pipeline with Control-C.
Olivier Crête [Wed, 4 Dec 2013 22:35:18 +0000 (17:35 -0500)]
info: Make sure the same category is not added twice
Olivier Crête [Wed, 4 Dec 2013 22:35:02 +0000 (17:35 -0500)]
info: Protect __categories list in get_category with lock too
Sebastian Rasmussen [Tue, 3 Dec 2013 23:10:36 +0000 (00:10 +0100)]
docs: add missing files for distribution
* add some documentation files in docs/design
* add docs/list-ulink.xsl so check in docs/manual works
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=719814
Wim Taymans [Tue, 3 Dec 2013 20:46:19 +0000 (21:46 +0100)]
pad: add ACCEPT_INTERCEPT flag
Make a new flag on the pad that tweaks the default behaviour of the
accept-caps function. By default it will check for a subset of the
query-caps result but this is not always desirable. The query-caps
result contains all the constraints to make a good caps decision
upstream but sometimes, like for parsers, not all the constrained caps
fields are known upstream and then a subset check would fail. Switching
to an intersection makes this work again.
See https://bugzilla.gnome.org/show_bug.cgi?id=705024
https://bugzilla.gnome.org/show_bug.cgi?id=677401
Olivier Crête [Tue, 3 Dec 2013 03:22:36 +0000 (22:22 -0500)]
multiqueue: Wake up on reconfigure event
After patch
bda406c4, the state of the singlequeue was set to OK, but nothing
would then wake up the thread, as the other wakeup functions only look at
singlequeues that are marked as having received as not-linked.
https://bugzilla.gnome.org/show_bug.cgi?id=708200
Sebastian Rasmussen [Sat, 30 Nov 2013 11:15:37 +0000 (12:15 +0100)]
docs: add missing docs, fixing doc errors
* add many missing declarations to sections
* GstController has been removed, update docs
* skip GstIndex when generating documentation
* rephrase so gtkdoc doesn't imagine return value
* add missing argument description for gst_context_new()
* document GstOutputSelectorPadNegotiationMode and move to header-file
https://bugzilla.gnome.org/show_bug.cgi?id=719614
Sebastian Rasmussen [Sat, 30 Nov 2013 13:52:40 +0000 (14:52 +0100)]
docs: cosmetic changes in references/decriptions
* fix typo GstBufferFlag -> GstBufferFlags
* fix typo GstFeatures -> GstCapsFeatures
* fix typo GstAllocatorParams -> GstAllocationParams
* fix typo GstContrlSources -> GstControlSource
* do not refer to gstcheck as an object
* make references gtk_init() and tcase_set_timeout() not be references
* gst_element_get_pad() renamed gst_element_get_static_pad()
* gst_clock_id_wait_async_full() renamed gst_clock_id_wait_async()
* _drop_element() is really gst_queue_array_drop_element()
* gst_pad_accept_caps() was removed, do not refer to it
* separate GST_META_TAG_MEMORY_STR declaration from description
* do not describe removed gst_collect_pads_collect()
* correctly link to GstElementClass' virtual set_context()
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=719614
Olivier Crête [Fri, 29 Nov 2013 19:00:35 +0000 (14:00 -0500)]
parse: Manually insert priv_gst_parse_yyget/set_column prototypes for older flex
Older versions of flex (before 2.5.36) don't add the prototype, so it must
be added manually. We can't check by the version number, because Debian/Ubuntu
patched it into their 2.5.35 at some point.
Thiago Santos [Tue, 19 Nov 2013 14:41:54 +0000 (11:41 -0300)]
gstpad: drop assertion on gst_pad_peer_query_position
It is a 'both' query, so it can be sent both ways
Thiago Santos [Mon, 18 Nov 2013 21:11:56 +0000 (18:11 -0300)]
inputselector: handle gap events
Use gap events to advance the selector's pad position.
This is relevant to keep sync_streams mode working when one of the
streams doesn't have data all the time.
Wim Taymans [Fri, 29 Nov 2013 16:02:41 +0000 (17:02 +0100)]
Revert "ghostpad: copy sticky events to SRC ghostpads"
This reverts commit
8162a583a4dd68582bf186e2e47a8f0d68fa1980.
Automatically copying the sticky events makes it impossible for apps
and elements to filter the events with event probes. This causes
regressions (See #719437). The best option is to let the app/element
copy and filter the events themselves after the ghostpad target is
set.
Fabian Kirsch [Tue, 19 Nov 2013 14:03:35 +0000 (15:03 +0100)]
parse: fix segfaulting prototype-mismatch
Now YYDEBUG is always set, so check it's value
https://bugzilla.gnome.org/show_bug.cgi?id=712679
Jan Schmidt [Wed, 27 Nov 2013 07:32:22 +0000 (18:32 +1100)]
netclock: Fix docstring for round-trip-limit and uninit access warning.
Fix a typo in a doc string - the property is round-trip-limit, not
roundtrip-limit.
Remove a bogus GST_WARNING that can print an uninitialised variable
and is redundant anyway.
Carlos Rafael Giani [Tue, 26 Nov 2013 10:56:46 +0000 (11:56 +0100)]
netclock: Add round-trip-limit parameter
Sometimes, packets might take a very long time to return. Such packets
usually are way too late and destabilize the regression with their
obsolete data. On Wi-Fi, round-trips of over 7 seconds have been observed.
If the limit is set to a nonzero value, packets with a round-trip period
larger than the limit are ignored.
Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>
https://bugzilla.gnome.org/show_bug.cgi?id=712385
Olivier Crête [Tue, 26 Nov 2013 00:04:38 +0000 (19:04 -0500)]
query: Fix gi annotations of gst_structure_new_custom()
Jan Schmidt [Mon, 25 Nov 2013 15:43:54 +0000 (02:43 +1100)]
netclock: Fix C99 comment
Jan Schmidt [Mon, 25 Nov 2013 15:17:36 +0000 (02:17 +1100)]
netclock: Implement rolling-average filter on observations.
Keep a rolling average of the round trip time for network clock
observations, favouring shorter round trips as being more accurate.
Don't pass any clock observation to the clock slaving if it has a
round-trip time greater than 2 times the average.
Actual shifts in the network topology will be noticed after some
time, as the rolling average incorporates the new round trip times.
Jan Schmidt [Mon, 25 Nov 2013 09:33:42 +0000 (20:33 +1100)]
basesink: Add debug into gst_base_sink_default_query() for accept_caps
Philippe Normand [Thu, 14 Nov 2013 14:32:59 +0000 (15:32 +0100)]
gst-launch: exit with an error code when an error occured
If the pipeline failed to pre-roll or the user interrupted the
execution then set the exit code to a positive value.
https://bugzilla.gnome.org/show_bug.cgi?id=712300
Sebastian Rasmussen [Fri, 22 Nov 2013 00:35:18 +0000 (01:35 +0100)]
gstutils: Escape stream id format in comments
These must be escaped for gtk-doc to parse the comments without warnings.
https://bugzilla.gnome.org/show_bug.cgi?id=714989
Tim-Philipp Müller [Thu, 21 Nov 2013 15:04:04 +0000 (15:04 +0000)]
gst: g_memmove() is deprecated
Just use plain memmove(), g_memmove() is deprecated in
recent GLib versions.
https://bugzilla.gnome.org/show_bug.cgi?id=712811
Wim Taymans [Thu, 21 Nov 2013 13:13:16 +0000 (14:13 +0100)]
ghostpad: copy sticky events to SRC ghostpads
Update the sticky events on SRC ghostpads when retargeting. This ensures
that the ghostpad has the exect same sticky events as the target pad. We
don't want to do this for SINK ghostpads, they got the events from
downstream and we don't want to overwrite them with the target pad
events.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=707621
Wim Taymans [Thu, 21 Nov 2013 11:28:00 +0000 (12:28 +0100)]
pad: move debug function closer to the enum it debugs
Wim Taymans [Mon, 18 Nov 2013 20:39:54 +0000 (21:39 +0100)]
pluginloader: check read/write before closed
first try to read or write on the socket before checking the closed state. This
makes sure we handle all data on the socket before erroring out.
Wim Taymans [Mon, 18 Nov 2013 20:37:06 +0000 (21:37 +0100)]
poll: improve debug
So that we can see the return values of functions in the log.
Tim-Philipp Müller [Mon, 18 Nov 2013 15:28:32 +0000 (15:28 +0000)]
tests: fix GstBus unit test with latest GLib
g_source_remove() works on the default main context, and
we're doing things with a custom context. Fixes warning
with newer GLib versions.
Tim-Philipp Müller [Sat, 16 Nov 2013 12:24:56 +0000 (12:24 +0000)]
docs: cosmetic since marker fixes
Mark Nauwelaerts [Sat, 16 Nov 2013 14:17:57 +0000 (15:17 +0100)]
baseparse: ensure to preserve upstream timestamps
... rather than have subclass coming up with an internally parsed one.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=707230
Sebastian Dröge [Fri, 15 Nov 2013 06:32:48 +0000 (07:32 +0100)]
bin: Resync iterator if necessary
Sebastian Dröge [Wed, 13 Nov 2013 18:55:41 +0000 (19:55 +0100)]
value: Lists with all equal elements are equal to a single value
Otherwise caps containing f={X, X} are not compatible with f=X
https://bugzilla.gnome.org/show_bug.cgi?id=709253
Tim-Philipp Müller [Mon, 11 Nov 2013 16:47:06 +0000 (16:47 +0000)]
systemclock: add Since markers for new API
Edward Hervey [Mon, 11 Nov 2013 16:29:48 +0000 (17:29 +0100)]
win32: Really update the def files
Sebastian Dröge [Mon, 11 Nov 2013 16:02:35 +0000 (17:02 +0100)]
win32: Update def files
Sebastian Dröge [Mon, 11 Nov 2013 15:50:13 +0000 (16:50 +0100)]
gst-uninstalled: Also export LD_LIBRARY_PATH for gst-plugins-gl
Matthieu Bouron [Tue, 5 Nov 2013 12:22:51 +0000 (12:22 +0000)]
gst-uninstalled: export gst-plugins-gl DYLD_LIBRARY_PATH
https://bugzilla.gnome.org/show_bug.cgi?id=711488
Sebastian Dröge [Wed, 6 Nov 2013 17:46:19 +0000 (18:46 +0100)]
collectpads: Always send SEEK events to all pads, even if one fails
Sebastian Dröge [Wed, 6 Nov 2013 17:41:10 +0000 (18:41 +0100)]
collectpads: Update documentation for flushing seek handling
Sebastian Dröge [Wed, 6 Nov 2013 17:05:22 +0000 (18:05 +0100)]
collectpads: Don't leak seek events
Alessandro Decina [Mon, 16 Sep 2013 07:55:58 +0000 (09:55 +0200)]
collectpads: implement flushing seek support
Implement common flushing seek logic in GstCollectPads. Add new
API so that elements can opt-in to using the new logic
(gst_collect_pads_src_event_default) and can extend it
(gst_collect_pads_set_flush_function) to flush any internal
state.
See https://bugzilla.gnome.org/show_bug.cgi?id=706779 and
https://bugzilla.gnome.org/show_bug.cgi?id=706441 for the
background discussion.
API: gst_collect_pads_set_flush_function()
API: gst_collect_pads_src_event_default()
https://bugzilla.gnome.org/show_bug.cgi?id=708416
Alessandro Decina [Mon, 16 Sep 2013 06:35:37 +0000 (08:35 +0200)]
tests: collectpads: add flushing seek tests
https://bugzilla.gnome.org/show_bug.cgi?id=708416
Alessandro Decina [Mon, 16 Sep 2013 06:31:47 +0000 (08:31 +0200)]
tests: collectpads: tweak stub _collect to push all buffers
https://bugzilla.gnome.org/show_bug.cgi?id=708416
Alessandro Decina [Mon, 16 Sep 2013 06:26:25 +0000 (08:26 +0200)]
tests: collectpads: update my email address
https://bugzilla.gnome.org/show_bug.cgi?id=708416
Edward Hervey [Mon, 11 Nov 2013 12:27:27 +0000 (13:27 +0100)]
queue: Don't use gst_buffer_get_size() when possible
Makes qst_queue_locked_dequeue 20% faster
Wim Taymans [Mon, 11 Nov 2013 11:25:14 +0000 (12:25 +0100)]
systemclock: Add gst_system_clock_set_default
Used for setting the default system clock that is obtained through
gst_system_clock_obtain(), which is sometimes needed for unit
testing.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=711269
Stefan Sauer [Mon, 4 Nov 2013 17:57:18 +0000 (18:57 +0100)]
typefind: use g_get_prgname() for error message
Wim Taymans [Wed, 6 Nov 2013 09:15:59 +0000 (10:15 +0100)]
valve: proxy caps and allocation
Proxy the caps queries on the srcpad as well.
Proxy the allocation query on the sinkpad.
Tim-Philipp Müller [Tue, 5 Nov 2013 11:17:25 +0000 (11:17 +0000)]
Automatic update of common submodule
From
865aa20 to
dbedaa0
Reynaldo H. Verdejo Pinochet [Mon, 4 Nov 2013 21:56:37 +0000 (13:56 -0800)]
gst-inspect: Remove some dead code
Alessandro Decina [Mon, 4 Nov 2013 10:48:47 +0000 (11:48 +0100)]
memory: explicitly cast to GstLockFlags to avoid compiler warnings
Mark Nauwelaerts [Sat, 2 Nov 2013 14:36:19 +0000 (15:36 +0100)]
segment: resurrect sanitizing start and stop for seeking
Mark Nauwelaerts [Sat, 2 Nov 2013 14:42:07 +0000 (15:42 +0100)]
basesrc: mind boggling wrap when comparing offsets
Mark Nauwelaerts [Sat, 2 Nov 2013 14:38:13 +0000 (15:38 +0100)]
baseparse: try first frame pts and dts for a valid start timestamp
Mark Nauwelaerts [Sat, 2 Nov 2013 14:37:30 +0000 (15:37 +0100)]
baseparse: print proper variable in debug statement
Olivier Crête [Fri, 1 Nov 2013 16:35:59 +0000 (16:35 +0000)]
parse: Make the FATAL_ERRORS flag also work without a GError
Also add a unit tests
Matthieu Bouron [Wed, 23 Oct 2013 14:56:20 +0000 (15:56 +0100)]
gst-launch: fix potential uninitialized variable warning
https://bugzilla.gnome.org/show_bug.cgi?id=710758
Reynaldo H. Verdejo Pinochet [Thu, 31 Oct 2013 23:16:48 +0000 (16:16 -0700)]
docs: fix common typos emited/eachother/...
Sebastian Dröge [Wed, 30 Oct 2013 20:53:36 +0000 (21:53 +0100)]
utils: Add some attributes and reorganize code to fix compiler warnings
gstutils.c:3659:41: error: format string is not a string literal
[-Werror,-Wformat-nonliteral]
gchar *expanded = g_strdup_vprintf (stream_id, var_args);
https://bugzilla.gnome.org/show_bug.cgi?id=710621
Antonio Ospite [Fri, 25 Oct 2013 12:56:16 +0000 (14:56 +0200)]
pwg: rename the "samplerate" variable to make example code compilable
In one of the examples about gst_my_filter_setcaps() there is a variable
declared as "rate", but then the name "samplerate" is used when setting
the caps.
Use the name "rate" everywhere in gst_my_filter_setcaps().
https://bugzilla.gnome.org/show_bug.cgi?id=710876
Fabian Kirsch [Tue, 29 Oct 2013 17:09:32 +0000 (18:09 +0100)]
doc: fix forward reference about ghost pads
https://bugzilla.gnome.org/show_bug.cgi?id=711089
Tim-Philipp Müller [Mon, 28 Oct 2013 12:55:19 +0000 (12:55 +0000)]
docs: design: fix some fixes
Tim-Philipp Müller [Sat, 26 Oct 2013 08:48:06 +0000 (09:48 +0100)]
docs: flesh out gst-uninstalled entry in faq some more
https://bugzilla.gnome.org/show_bug.cgi?id=709916
Fabian Kirsch [Wed, 16 Oct 2013 13:00:41 +0000 (15:00 +0200)]
docs: FAQ update to mention create-uninstalled-setup.sh
https://bugzilla.gnome.org/show_bug.cgi?id=709916
Stefan Sauer [Fri, 25 Oct 2013 19:29:01 +0000 (21:29 +0200)]
registry: small cleanups and use object log variants more