platform/upstream/freerdp.git
6 years agoFixed signedness of MoniorCount
Armin Novak [Wed, 24 Oct 2018 15:22:43 +0000 (17:22 +0200)]
Fixed signedness of MoniorCount

6 years agoFixed initialisation in DEFINE_EVENT_ENTRY define
Armin Novak [Wed, 24 Oct 2018 14:50:05 +0000 (16:50 +0200)]
Fixed initialisation in DEFINE_EVENT_ENTRY define

6 years agoFixed another bunch of warnings.
Armin Novak [Wed, 24 Oct 2018 12:36:12 +0000 (14:36 +0200)]
Fixed another bunch of warnings.

6 years agoFixed -Wextra sign warnings
Armin Novak [Wed, 24 Oct 2018 11:20:46 +0000 (13:20 +0200)]
Fixed -Wextra sign warnings

6 years agoFixed warnings of uninitialized struct values.
Armin Novak [Wed, 24 Oct 2018 11:17:14 +0000 (13:17 +0200)]
Fixed warnings of uninitialized struct values.

6 years agoFixed cast warnings for thread wrapper
Armin Novak [Wed, 24 Oct 2018 11:17:04 +0000 (13:17 +0200)]
Fixed cast warnings for thread wrapper

6 years agoChanged size iterator variables to size_t
Armin Novak [Wed, 24 Oct 2018 11:05:49 +0000 (13:05 +0200)]
Changed size iterator variables to size_t

6 years agoMerge pull request #4947 from akallabeth/http_gw_fix
akallabeth [Tue, 23 Oct 2018 10:03:03 +0000 (12:03 +0200)]
Merge pull request #4947 from akallabeth/http_gw_fix

Fixed http gateway body length read.

6 years agoMerge pull request #4958 from nfedera/nf-fix-alsapulse-wrn-err
akallabeth [Tue, 23 Oct 2018 08:40:09 +0000 (10:40 +0200)]
Merge pull request #4958 from nfedera/nf-fix-alsapulse-wrn-err

channels/client: fix alsa/pulse warning and checks

6 years agochannels/client: fix alsa/pulse warning and checks
Norbert Federa [Tue, 23 Oct 2018 07:45:20 +0000 (09:45 +0200)]
channels/client: fix alsa/pulse warning and checks

- pa_stream_writable_size() returns (size_t) -1 on error
- fix missing cast in alsa client sound channel code

6 years agoMerge pull request #4957 from akallabeth/wave_2_pdu_fix
Norbert Federa [Tue, 23 Oct 2018 07:28:00 +0000 (09:28 +0200)]
Merge pull request #4957 from akallabeth/wave_2_pdu_fix

Wave 2 pdu fix

6 years agoMerge pull request #4932 from hardening/stream_static
akallabeth [Mon, 22 Oct 2018 19:16:36 +0000 (21:16 +0200)]
Merge pull request #4932 from hardening/stream_static

winpr: add some functions to use wStream in a static way

6 years agoCleaned up resource cleanup for rdpsnd alsa backend.
Armin Novak [Mon, 22 Oct 2018 12:53:46 +0000 (14:53 +0200)]
Cleaned up resource cleanup for rdpsnd alsa backend.

6 years agoMerge pull request #4796 from akallabeth/groegera_fixes
Bernhard Miklautz [Mon, 22 Oct 2018 12:50:21 +0000 (12:50 +0000)]
Merge pull request #4796 from akallabeth/groegera_fixes

Update X11-modifier key state on focus_in

6 years agoFixed memory leak in update_recv_surfcmd_surface_bits
Armin Novak [Mon, 22 Oct 2018 12:41:59 +0000 (14:41 +0200)]
Fixed memory leak in update_recv_surfcmd_surface_bits

6 years agoImplemented rdpsnd_pulse_get_volume
Armin Novak [Mon, 22 Oct 2018 11:02:00 +0000 (13:02 +0200)]
Implemented rdpsnd_pulse_get_volume

6 years agofixed return value check in rdpsnd_recv_volume_pdu
Armin Novak [Mon, 22 Oct 2018 10:27:19 +0000 (12:27 +0200)]
fixed return value check in rdpsnd_recv_volume_pdu

6 years agoSeal length in wave pdu alignment.
Armin Novak [Mon, 22 Oct 2018 10:16:18 +0000 (12:16 +0200)]
Seal length in wave pdu alignment.

6 years agoAlign wave pdu size
Armin Novak [Mon, 22 Oct 2018 10:00:07 +0000 (12:00 +0200)]
Align wave pdu size

6 years agoAdded missing length check and log message information.
Armin Novak [Mon, 22 Oct 2018 09:59:42 +0000 (11:59 +0200)]
Added missing length check and log message information.

6 years agoImproved debug logging for sound device handling.
Armin Novak [Mon, 22 Oct 2018 08:27:16 +0000 (10:27 +0200)]
Improved debug logging for sound device handling.

6 years agoRemoved unnecessary pulse context check.
Armin Novak [Mon, 22 Oct 2018 08:18:17 +0000 (10:18 +0200)]
Removed unnecessary pulse context check.

6 years agoUnified sound device reopen in a single function.
Armin Novak [Mon, 22 Oct 2018 08:04:02 +0000 (10:04 +0200)]
Unified sound device reopen in a single function.

6 years agoMerge pull request #4952 from eledoux/master
akallabeth [Fri, 19 Oct 2018 15:13:21 +0000 (17:13 +0200)]
Merge pull request #4952 from eledoux/master

gateway HTTP transport - fixed partial reads

6 years agoMerge pull request #4951 from nfedera/nf-fix-fnobjnew-fnstylecasts
akallabeth [Fri, 19 Oct 2018 12:00:14 +0000 (14:00 +0200)]
Merge pull request #4951 from nfedera/nf-fix-fnobjnew-fnstylecasts

fix issue with fnObjectFree and related casts

6 years agoMerge pull request #4949 from bmiklautz/floatbar_warning
akallabeth [Fri, 19 Oct 2018 11:47:42 +0000 (13:47 +0200)]
Merge pull request #4949 from bmiklautz/floatbar_warning

fix [x11]: compiler warnings in floatbar

6 years agoMerge pull request #4950 from bmiklautz/cleanup_pr_4581p2
akallabeth [Fri, 19 Oct 2018 11:00:51 +0000 (13:00 +0200)]
Merge pull request #4950 from bmiklautz/cleanup_pr_4581p2

fix [cache/pointer]: add missing callback checks

6 years agoRead byte by byte, the alignment may otherwise be broken.
Armin Novak [Fri, 19 Oct 2018 10:52:14 +0000 (12:52 +0200)]
Read byte by byte, the alignment may otherwise be broken.

6 years agoRead http request in 4byte chunks until '\r\n\r\n' is found
Armin Novak [Fri, 19 Oct 2018 09:59:28 +0000 (11:59 +0200)]
Read http request in 4byte chunks until '\r\n\r\n' is found

Avoid reading too much data in a single call to BIO_read as some
implementations may return a lot more data than is part of the response.

6 years agofixed partial reads
Emmanuel Ledoux [Fri, 19 Oct 2018 09:56:56 +0000 (11:56 +0200)]
fixed partial reads

6 years agoProperly parse ContentType to find length.
Armin Novak [Fri, 19 Oct 2018 09:39:22 +0000 (11:39 +0200)]
Properly parse ContentType to find length.

6 years agofix [x11]: compiler warnings in floatbar
Bernhard Miklautz [Fri, 19 Oct 2018 08:33:50 +0000 (10:33 +0200)]
fix [x11]: compiler warnings in floatbar

client/X11/xf_floatbar.c:530:27: warning: use of logical '&&' with constant
      operand [-Wconstant-logical-operand]
        if (event->xmotion.state && Button1Mask && mode > XF_FLOATBAR_MODE_DRAGGING)
                                 ^  ~~~~~~~~~~~
client/X11/xf_floatbar.c:534:32: warning: use of logical '&&' with constant
      operand [-Wconstant-logical-operand]
        else if (event->xmotion.state && Button1Mask && mode == XF_FLOATBAR_MODE_DRAGGING)
                                      ^  ~~~~~~~~~~~
clang 8.0.0-svn344413-1~exp1+0~20181012203207.819~1.gbpc91f27

6 years agofix issue with fnObjectFree and related casts
Norbert Federa [Fri, 19 Oct 2018 09:30:01 +0000 (11:30 +0200)]
fix issue with fnObjectFree and related casts

- remove unnecessary/dangerous OBJECT_xxx function-style casts
- fix -Wstrict-prototypes issue with OBJECT_NEW_FN definition

6 years agofix [cache/pointer]: add missing callback checks
Bernhard Miklautz [Fri, 19 Oct 2018 09:11:44 +0000 (11:11 +0200)]
fix [cache/pointer]: add missing callback checks

6 years agoMerge pull request #4948 from bmiklautz/cleanup_pr_4581
MartinHaimberger [Fri, 19 Oct 2018 09:10:23 +0000 (11:10 +0200)]
Merge pull request #4948 from bmiklautz/cleanup_pr_4581

new [cache/pointer]: don't require pointer functions to be set

6 years agonew [cache/pointer]: don't require pointer functions to be set
Bernhard Miklautz [Thu, 18 Oct 2018 12:32:08 +0000 (14:32 +0200)]
new [cache/pointer]: don't require pointer functions to be set

This as cleanup/rework of PR #4581.

6 years agoFixed http gateway body length read.
Armin Novak [Thu, 18 Oct 2018 14:58:53 +0000 (16:58 +0200)]
Fixed http gateway body length read.

6 years agoMerge pull request #4946 from mmattes/fix/floatbar_app_check_missing
akallabeth [Thu, 18 Oct 2018 14:40:22 +0000 (16:40 +0200)]
Merge pull request #4946 from mmattes/fix/floatbar_app_check_missing

added missing check for remote app where no floatbar exists

6 years agoMerge pull request #4945 from mmattes/fix/transferEncoding
akallabeth [Thu, 18 Oct 2018 13:37:24 +0000 (15:37 +0200)]
Merge pull request #4945 from mmattes/fix/transferEncoding

transferEncoding can be NULL, correct if happens in line 348

6 years agoadded missing check for remote app where no floatbar exists
Markus Mattes [Thu, 18 Oct 2018 13:33:01 +0000 (15:33 +0200)]
added missing check for remote app where no floatbar exists

6 years agoMerge pull request #4942 from akallabeth/rail_fixes_2.0
Norbert Federa [Thu, 18 Oct 2018 12:11:18 +0000 (14:11 +0200)]
Merge pull request #4942 from akallabeth/rail_fixes_2.0

Fix ORDER_TYPE_WINDOW reading

6 years agoMerge pull request #4941 from nfedera/nf-remove-stale-valgrind-macro
Norbert Federa [Thu, 18 Oct 2018 12:08:23 +0000 (14:08 +0200)]
Merge pull request #4941 from nfedera/nf-remove-stale-valgrind-macro

gateway/rpc: remove stale valgrind macro

6 years agoMerge pull request #4938 from akallabeth/warning_fixes_master
Norbert Federa [Thu, 18 Oct 2018 12:08:01 +0000 (14:08 +0200)]
Merge pull request #4938 from akallabeth/warning_fixes_master

Warning fixes and TSG abort condition fix

6 years agotransferEncoding can be NULL, verification happens in line 348
Markus Mattes [Thu, 18 Oct 2018 11:59:49 +0000 (13:59 +0200)]
transferEncoding can be NULL, verification happens in line 348

6 years agoFixed read_altsec_order ORDER_TYPE_WINDOW
Armin Novak [Thu, 18 Oct 2018 10:34:10 +0000 (12:34 +0200)]
Fixed read_altsec_order ORDER_TYPE_WINDOW

6 years agoFixed order to string format string.
Armin Novak [Thu, 18 Oct 2018 10:33:06 +0000 (12:33 +0200)]
Fixed order to string format string.

6 years agogateway/rpc: remove stale valgrind macro
Norbert Federa [Thu, 18 Oct 2018 09:45:18 +0000 (11:45 +0200)]
gateway/rpc: remove stale valgrind macro

6 years agoMerge pull request #4939 from nfedera/nf-fix-rdpsnd_server_send_formats
Martin Fleisz [Thu, 18 Oct 2018 09:12:59 +0000 (11:12 +0200)]
Merge pull request #4939 from nfedera/nf-fix-rdpsnd_server_send_formats

rdpsnd: always call rdpsnd_server_send_formats

6 years agoFixed TSG stream alignment (4 or 8)
Armin Novak [Thu, 18 Oct 2018 08:41:03 +0000 (10:41 +0200)]
Fixed TSG stream alignment (4 or 8)

6 years agordpsnd: always call rdpsnd_server_send_formats
Norbert Federa [Thu, 18 Oct 2018 08:15:24 +0000 (10:15 +0200)]
rdpsnd: always call rdpsnd_server_send_formats

Since the rdpsnd_server_send_formats function is no longer exported
we must always call it, even if the rdpsnd server application uses
its own thread.

6 years agoFixed tsg abort condition.
Armin Novak [Thu, 18 Oct 2018 08:15:51 +0000 (10:15 +0200)]
Fixed tsg abort condition.

6 years agoFixed compiler warnings (casts, ...)
Armin Novak [Thu, 18 Oct 2018 07:09:30 +0000 (09:09 +0200)]
Fixed compiler warnings (casts, ...)

6 years agoUSe const compare function pointer arguments
Armin Novak [Thu, 18 Oct 2018 07:06:55 +0000 (09:06 +0200)]
USe const compare function pointer arguments

6 years agowinpr: add some functions to use wStream in a static way
David Fort [Tue, 16 Oct 2018 09:33:03 +0000 (11:33 +0200)]
winpr: add some functions to use wStream in a static way

It's sometime useful to create a stream aliasing a buffer on the stack, and
it's nice if we don't need some extra malloc for this.

Example use:
   BYTE buffer[20];
   wStream s;

   Stream_StaticInit(&s, buffer, sizeof(buffer));
   Stream_Write_UINT16(&s, 0xff01);
   Stream_Free(&s, FALSE);

6 years agoMerge pull request #4600 from andreesteve/xfullscreen
akallabeth [Wed, 17 Oct 2018 15:27:29 +0000 (17:27 +0200)]
Merge pull request #4600 from andreesteve/xfullscreen

X11: Fix fullscreen toggle

6 years agoMerge pull request #4937 from akallabeth/server_rdpsnd_get_formats
MartinHaimberger [Wed, 17 Oct 2018 15:16:28 +0000 (17:16 +0200)]
Merge pull request #4937 from akallabeth/server_rdpsnd_get_formats

Fix Server rdpsnd get formats

6 years agoFixed missing return in server_rdpsnd_get_formats
Armin Novak [Wed, 17 Oct 2018 14:17:41 +0000 (16:17 +0200)]
Fixed missing return in server_rdpsnd_get_formats

6 years agoMerge pull request #4926 from akallabeth/primary_order_checks
Martin Fleisz [Wed, 17 Oct 2018 14:02:28 +0000 (16:02 +0200)]
Merge pull request #4926 from akallabeth/primary_order_checks

Order data validation and correction

6 years agoMerge pull request #4478 from smalleel/master
akallabeth [Wed, 17 Oct 2018 13:01:22 +0000 (15:01 +0200)]
Merge pull request #4478 from smalleel/master

Updated project site link to HTTPS

6 years agoMerge pull request #4933 from akallabeth/planar_alpha_fix
MartinHaimberger [Wed, 17 Oct 2018 12:40:00 +0000 (14:40 +0200)]
Merge pull request #4933 from akallabeth/planar_alpha_fix

Planar alpha fix

6 years agoMerge pull request #4936 from akallabeth/gw_leak_fix
MartinHaimberger [Wed, 17 Oct 2018 12:35:17 +0000 (14:35 +0200)]
Merge pull request #4936 from akallabeth/gw_leak_fix

Fixed bugs detected during scanbuild run

6 years agoRemoved debug log entries, simplified order support check.
Armin Novak [Wed, 17 Oct 2018 12:16:16 +0000 (14:16 +0200)]
Removed debug log entries, simplified order support check.

6 years agoFixed bugs detected during scanbuild run
Armin Novak [Wed, 17 Oct 2018 11:19:33 +0000 (13:19 +0200)]
Fixed bugs detected during scanbuild run

6 years agoMerge pull request #4902 from akallabeth/gw_refactor_3
akallabeth [Wed, 17 Oct 2018 10:23:10 +0000 (12:23 +0200)]
Merge pull request #4902 from akallabeth/gw_refactor_3

Gateway refactoring

6 years agoMerge pull request #4927 from akallabeth/cmdline_fixes
akallabeth [Wed, 17 Oct 2018 10:19:03 +0000 (12:19 +0200)]
Merge pull request #4927 from akallabeth/cmdline_fixes

Fixed command line setting of flags, unified string replace

6 years agoAdd command line option /relax-order-checks
Armin Novak [Wed, 17 Oct 2018 10:15:57 +0000 (12:15 +0200)]
Add command line option /relax-order-checks

6 years agoFixed division by 0 if invalid formats are used.
Armin Novak [Wed, 17 Oct 2018 09:36:32 +0000 (11:36 +0200)]
Fixed division by 0 if invalid formats are used.

6 years agoMerge pull request #4891 from akallabeth/rail_fixes
akallabeth [Wed, 17 Oct 2018 09:32:56 +0000 (11:32 +0200)]
Merge pull request #4891 from akallabeth/rail_fixes

Rail fixes #4846 and a crash

6 years agoAnnounce glyph orders if glyph cache is activated.
Armin Novak [Wed, 17 Oct 2018 08:47:23 +0000 (10:47 +0200)]
Announce glyph orders if glyph cache is activated.

6 years agoFixed length sanity check.
Armin Novak [Wed, 17 Oct 2018 08:09:37 +0000 (10:09 +0200)]
Fixed length sanity check.

6 years agoFixed order requirements.
Armin Novak [Wed, 17 Oct 2018 08:09:27 +0000 (10:09 +0200)]
Fixed order requirements.

6 years agoFixed const correctness of arguments.
Armin Novak [Tue, 16 Oct 2018 15:29:10 +0000 (17:29 +0200)]
Fixed const correctness of arguments.

6 years agoAdded parameter checks.
Armin Novak [Tue, 16 Oct 2018 15:26:57 +0000 (17:26 +0200)]
Added parameter checks.

6 years agoAdded parameter checks.
Armin Novak [Tue, 16 Oct 2018 15:23:24 +0000 (17:23 +0200)]
Added parameter checks.

6 years agoFixed missing argument check.
Armin Novak [Tue, 16 Oct 2018 15:14:56 +0000 (17:14 +0200)]
Fixed missing argument check.

6 years agoFixed missing input validation.
Armin Novak [Tue, 16 Oct 2018 15:10:03 +0000 (17:10 +0200)]
Fixed missing input validation.

6 years agoFixed missing value check
Armin Novak [Tue, 16 Oct 2018 15:09:29 +0000 (17:09 +0200)]
Fixed missing value check

6 years agoFixed glyph cache
Armin Novak [Tue, 16 Oct 2018 14:10:17 +0000 (16:10 +0200)]
Fixed glyph cache

6 years agoProper order checks.
Armin Novak [Tue, 16 Oct 2018 13:56:17 +0000 (15:56 +0200)]
Proper order checks.

6 years agoMerge pull request #4914 from Devolutions/winpr-dll-export
Marc-André Moreau [Tue, 16 Oct 2018 13:09:05 +0000 (09:09 -0400)]
Merge pull request #4914 from Devolutions/winpr-dll-export

Add WINPR_DLL definition to control WinPR symbol exporting

6 years agoCheck if incoming secondary alternate orders have been activated.
Armin Novak [Tue, 16 Oct 2018 11:59:37 +0000 (13:59 +0200)]
Check if incoming secondary alternate orders have been activated.

6 years agoCheck if incoming secondary orders have been activated.
Armin Novak [Tue, 16 Oct 2018 11:48:43 +0000 (13:48 +0200)]
Check if incoming secondary orders have been activated.

6 years agoSend brush support level from settings.
Armin Novak [Tue, 16 Oct 2018 11:48:29 +0000 (13:48 +0200)]
Send brush support level from settings.

6 years agoFor every order check if it is activated in settings before processing.
Armin Novak [Tue, 16 Oct 2018 11:02:15 +0000 (13:02 +0200)]
For every order check if it is activated in settings before processing.

6 years agoAdded a warning that the server sent an unsupported order
Armin Novak [Tue, 16 Oct 2018 10:46:44 +0000 (12:46 +0200)]
Added a warning that the server sent an unsupported order

6 years agoFixed arguments to *adust
Armin Novak [Tue, 16 Oct 2018 10:36:08 +0000 (12:36 +0200)]
Fixed arguments to *adust

6 years agoSeparate alpha handling for planar codec
Armin Novak [Tue, 16 Oct 2018 10:17:25 +0000 (12:17 +0200)]
Separate alpha handling for planar codec

If the destination does not support an alpha channel ignore it
when decoding and prevent data to be copied unnecessarily

6 years agoSiplified planar alpha / non alpha paths
Armin Novak [Tue, 16 Oct 2018 08:05:33 +0000 (10:05 +0200)]
Siplified planar alpha / non alpha paths

6 years agoFixed a memory leak in cleaning up brushes.
Armin Novak [Tue, 16 Oct 2018 06:45:06 +0000 (08:45 +0200)]
Fixed a memory leak in cleaning up brushes.

6 years agoAdjust rectangles where appropriate.
Armin Novak [Mon, 15 Oct 2018 14:34:44 +0000 (16:34 +0200)]
Adjust rectangles where appropriate.

6 years agoFixed memory leak with audio formats.
Armin Novak [Mon, 15 Oct 2018 14:33:56 +0000 (16:33 +0200)]
Fixed memory leak with audio formats.

6 years agoFixed MultiOpaqueRect
Armin Novak [Mon, 15 Oct 2018 13:27:17 +0000 (15:27 +0200)]
Fixed MultiOpaqueRect

Sanitize rectangle boundaries, the coordinates of old servers are often out of bound.

6 years agoFix bounding rectangle of OpaqueRect
Armin Novak [Mon, 15 Oct 2018 13:23:04 +0000 (15:23 +0200)]
Fix bounding rectangle of OpaqueRect

This order has often negative coordinates, sanitize before passing on.

6 years agoDeactivated unimplemented orders.
Armin Novak [Mon, 15 Oct 2018 13:22:50 +0000 (15:22 +0200)]
Deactivated unimplemented orders.

6 years agoRemoved checks for LineTo, that is handled by the drawing routines
Armin Novak [Mon, 15 Oct 2018 12:36:03 +0000 (14:36 +0200)]
Removed checks for LineTo, that is handled by the drawing routines

6 years agoFixed various issues with primary orders.
Armin Novak [Mon, 15 Oct 2018 12:30:38 +0000 (14:30 +0200)]
Fixed various issues with primary orders.

6 years agoFixed logging.
Armin Novak [Mon, 15 Oct 2018 11:56:19 +0000 (13:56 +0200)]
Fixed logging.

6 years agoUse dynamic logging and fix compiler warnings.
Armin Novak [Mon, 15 Oct 2018 11:20:47 +0000 (13:20 +0200)]
Use dynamic logging and fix compiler warnings.

6 years agoAdded altsec return value checks.
Armin Novak [Mon, 15 Oct 2018 11:15:57 +0000 (13:15 +0200)]
Added altsec return value checks.

6 years agoUnified logging.
Armin Novak [Mon, 15 Oct 2018 11:10:48 +0000 (13:10 +0200)]
Unified logging.