platform/upstream/xamarin-forms.git
8 years ago[Android] Fix warnings (#346)
Rui Marinho [Tue, 13 Sep 2016 11:51:57 +0000 (12:51 +0100)]
[Android] Fix warnings (#346)

8 years ago[iOS] ViewCells with Accessories will be properly laid out again (#338)
Samantha Houts [Tue, 13 Sep 2016 11:39:36 +0000 (04:39 -0700)]
[iOS] ViewCells with Accessories will be properly laid out again (#338)

* Add repro for 43161

* [iOS] Don't adjust ViewCell Bounds when there is an Accessory

* [iOS] Fix spacing

8 years ago[A] Fix regression on NavAnimationInProgress (#341)
Paul DiPietro [Tue, 13 Sep 2016 11:39:02 +0000 (06:39 -0500)]
[A] Fix regression on NavAnimationInProgress (#341)

8 years ago[iOS] - Revert setting the frame for ViewCell to try to hide the gap between cells...
Rui Marinho [Tue, 13 Sep 2016 11:38:16 +0000 (12:38 +0100)]
[iOS] - Revert setting the frame for ViewCell to try to hide the gap between cells when using a ContextActionCell (#351)

8 years agoRevert "[C] Prevent enabling a Button via setting a Command (#308)"
Rui Marinho [Tue, 13 Sep 2016 11:34:22 +0000 (12:34 +0100)]
Revert "[C] Prevent enabling a Button via setting a Command (#308)"

This reverts commit 368a375f13fc2e4b5ff00dbbdd7a2d6bb53988eb.

8 years agoAndroid AppCompat: Don't do NavigationPage menu updates for disposed page (#331)
Jani Lirkki [Mon, 12 Sep 2016 11:53:44 +0000 (14:53 +0300)]
Android AppCompat: Don't do NavigationPage menu updates for disposed page (#331)

8 years agoAfter Label.FormattedText property changed need invoke UpdateText method (#335)
Mikhail [Mon, 12 Sep 2016 11:52:31 +0000 (14:52 +0300)]
After Label.FormattedText property changed  need invoke UpdateText method (#335)

8 years ago[C] Prevent enabling a Button via setting a Command (#308)
Paul DiPietro [Mon, 12 Sep 2016 11:51:19 +0000 (06:51 -0500)]
[C] Prevent enabling a Button via setting a Command (#308)

8 years ago[iOS] Adjust Started/Ended hooks in pickers for iOS 10 (#339)
Paul DiPietro [Thu, 8 Sep 2016 22:00:57 +0000 (17:00 -0500)]
[iOS] Adjust Started/Ended hooks in pickers for iOS 10 (#339)

8 years ago[XamlC] throw exception on missing property (#336)
Stephane Delcroix [Thu, 8 Sep 2016 19:01:09 +0000 (21:01 +0200)]
[XamlC] throw exception on missing property (#336)

* Added unit test for 43450

* fix test

* [XamlC] instrument the compiler so we can test it

* [XamlC] throw on missing property

8 years ago[XamlC] replace the runtime type check by compiletime (#334)
Stephane Delcroix [Thu, 8 Sep 2016 18:51:01 +0000 (20:51 +0200)]
[XamlC] replace the runtime type check by compiletime (#334)

8 years ago[Xaml] support native views and native bindings (#266)
Stephane Delcroix [Thu, 8 Sep 2016 18:45:43 +0000 (20:45 +0200)]
[Xaml] support native views and native bindings (#266)

Allows including Native views directly in xaml.
Support for ios, android, UWP

8 years agoNative Bindings (#278)
Stephane Delcroix [Thu, 8 Sep 2016 18:39:05 +0000 (20:39 +0200)]
Native Bindings (#278)

* [C, I, A, W] Support Native Bindings

* fix tabs

8 years agoFix incorrect background property name on Win 8.1 phone and tablet styles (#329)
E.Z. Hart [Wed, 31 Aug 2016 19:57:35 +0000 (13:57 -0600)]
Fix incorrect background property name on Win 8.1 phone and tablet styles (#329)

8 years agoFix docs
Jason Smith [Wed, 31 Aug 2016 05:01:42 +0000 (22:01 -0700)]
Fix docs

8 years ago[Win] Fix FontAttributes unexpectedly changing a label's size (#325)
Paul DiPietro [Tue, 30 Aug 2016 18:47:09 +0000 (13:47 -0500)]
[Win] Fix FontAttributes unexpectedly changing a label's size (#325)

8 years ago[A] Check UserVisibleHint to prevent non-active tabs from firing SendAppearing in...
Paul DiPietro [Tue, 30 Aug 2016 18:34:37 +0000 (13:34 -0500)]
[A] Check UserVisibleHint to prevent non-active tabs from firing SendAppearing in OnResume (#328)

8 years agoKeyboardExtensions is now public (#326)
adrianknight89 [Tue, 30 Aug 2016 18:31:41 +0000 (13:31 -0500)]
KeyboardExtensions is now public (#326)

8 years ago[A] PanGestureRecognizer will consistently send Completed event (#313)
Samantha Houts [Tue, 30 Aug 2016 18:14:13 +0000 (11:14 -0700)]
[A] PanGestureRecognizer will consistently send Completed event (#313)

* Adjust gallery page for reproduction

* [A] Forward OnTouchEvent to Listener...

...and end scrolling on Up.

8 years agoUse character truncation in Windows (#321)
E.Z. Hart [Tue, 30 Aug 2016 18:12:27 +0000 (12:12 -0600)]
Use character truncation in Windows (#321)

Change layout order ViewCells on Windows to correct label length layout issues
Add extra layout pass on ViewCell load to make cells without margins visible

8 years agoFix for ListView BindingContext for Header/Footer (#312)
Jonathan Peppers [Tue, 30 Aug 2016 17:59:32 +0000 (12:59 -0500)]
Fix for ListView BindingContext for Header/Footer (#312)

* ListView - unit test showing BindingContext issue

Apparently the BC doesn't pass to Header and Footer

* ListView - support for passing BC to header and footer

* ListView - test checking BindingContext is set

Checking that it works to set the BindingContext first and the
Header/Footer after

8 years agoFix memory leak caused by BaseCellView and RendererHolder (#311)
E.Z. Hart [Tue, 30 Aug 2016 17:57:55 +0000 (11:57 -0600)]
Fix memory leak caused by BaseCellView and RendererHolder (#311)

8 years agoUpdate Makefile to support linux env (#309)
Kangho [Tue, 30 Aug 2016 17:55:00 +0000 (02:55 +0900)]
Update Makefile to support linux env (#309)

8 years agoPlatform Specifics (#301)
Samantha Houts [Tue, 30 Aug 2016 17:46:14 +0000 (10:46 -0700)]
Platform Specifics (#301)

* Playing around with how the platform specifics interfaces etc. might work

* Sample implementation of iOS navigation translucency

* Very slightly reduced code

* Better vendor stuff

* Drop single-implemenation interfaces

* Generics on NavigationPage

* On-demand vendor stuff

* Remove functionally duplicate classes and make ControlGallery work again

* Namespace all the things. XAML test.

* Can use Effect to attach platform specific

* Attach Effect on PropertyChanging for XAML support!

* Rename IConfigPlatform interfaces for readability

* Some renaming to match the documents

* Split class files

* Clear out test-only code

* Re-namespace

* Added On method to rendered Elements

* Allow for removal of platform suffix, convenience methods on specific platforms

* Creating a gallery page for specifics

* Add rudimentary Platform Specifics gallery; make CollapseStyle work on UWP;
Add CollapsedPaneWidth specific property

* Toolbar now working with both collapse styles

* MDP now displaying Content title; toolbar routing around title

* Add a gallery for the iOS NavigationPage stuff

* Add Navigation Page as detail page to verify it works with new Toolbar options

* Make titlebar/toolbar background colors consistent

* ToolbarPlacement now working on NavigationPage

* Toolbar Placement working for tabbed and nav pages

* Fix bug where phone doesn't get default toolbar placement on start

* [Core] Add PS WindowSoftInputModeAdjust

[Core] Make Application extendable

* Toolbar placement now working on Nav, Tabbed, and Master pages on desktop/phone

Remove unnecessary style indirection

Fix build errors

* [A] Add PlatformConfigurationExtensions

* SetSoftInputMode test page

* [A] SetSoftInputMode

Known issue: Status bar color does not work in AdjustResize mode

* [Core] Add PS Blur

* [iOS] Configure renderer for blur

* Add test page

* Move to blur VisualElement for broader support

* Move test pages to gallery

* Update docs

* Use lazy initializer for PlatformConfigurationRegistry

8 years agoThrow InvalidOperationException if AppLinkEntry.Thumbnail source is invalid (#299)
Jimmy Garrido [Tue, 30 Aug 2016 17:45:05 +0000 (10:45 -0700)]
Throw InvalidOperationException if AppLinkEntry.Thumbnail source is invalid (#299)

8 years agoAllow Custom Android MapRenderers to override the default MapView options (#285)
Marcus Lum [Tue, 30 Aug 2016 17:37:07 +0000 (13:37 -0400)]
Allow Custom Android MapRenderers to override the default MapView options (#285)

* Allow Custom Android MapRenderers to override the default MapView options

* Larger effort to use CreateNativeControl () everywhere instead of just in the Android AppCompat renderers.

8 years agoFix crash when ItemsSource is set to null (#320)
Jimmy Garrido [Thu, 25 Aug 2016 18:05:18 +0000 (11:05 -0700)]
Fix crash when ItemsSource is set to null (#320)

8 years agoFixed SinInOut description. (#319)
Mike Norman [Thu, 25 Aug 2016 16:11:01 +0000 (11:11 -0500)]
Fixed SinInOut description. (#319)

8 years agoFix regression by adding null check in Windows ListView selection (#314)
Paul DiPietro [Thu, 25 Aug 2016 00:55:15 +0000 (19:55 -0500)]
Fix regression by adding null check in Windows ListView selection (#314)

8 years ago[Android] Fix for NullReferenceException when using the wrong activit… (#286) beta-2.3.2-pre2
Oddbjørn Bakke [Wed, 17 Aug 2016 09:26:27 +0000 (11:26 +0200)]
[Android] Fix for NullReferenceException when using the wrong activit… (#286)

* [Android] Fix for NullReferenceException when using the wrong activity type.

On using FormsApplicationActivity or FormsAppCompatActivity as base Activity in a SplashScreen.
A NullReferenceException will be thrown in the KeyboardManager.
Added InvalidOperationException with "Forms.Init()" message instead, if the Forms.Context is null.

* Fixed indentation

8 years ago[WinRT] Remove preemptive setting of null upon action sheet closure (#305)
Paul DiPietro [Tue, 16 Aug 2016 19:13:12 +0000 (14:13 -0500)]
[WinRT] Remove preemptive setting of null upon action sheet closure (#305)

8 years ago[Xaml] Clone node tree on DT, allow markup to be evaluated multiple times (#295)
Stephane Delcroix [Tue, 16 Aug 2016 18:33:44 +0000 (20:33 +0200)]
[Xaml] Clone node tree on DT, allow markup to be evaluated multiple times (#295)

8 years ago[Windows] Correct enter/esc keypress behaviors for MessageDialog (#292)
Paul DiPietro [Tue, 16 Aug 2016 18:33:11 +0000 (13:33 -0500)]
[Windows] Correct enter/esc keypress behaviors for MessageDialog (#292)

8 years ago[iOS] Change when we updated the XF INavigationPageController after popping a page...
Rui Marinho [Tue, 16 Aug 2016 18:31:53 +0000 (19:31 +0100)]
[iOS] Change when we updated the XF INavigationPageController after popping a page natively, Cleanup UITest references (#291)

8 years agoFix for BindingExpression memory leak (#279)
Jonathan Peppers [Tue, 16 Aug 2016 18:19:21 +0000 (13:19 -0500)]
Fix for BindingExpression memory leak (#279)

* Unit test proving a memory leak with Binding

What we were seeing in our app was that Binding objects stay around when
bound to long-lived ViewModels, even when the View is long gone

* BindingExpression - INotifyPropertyChanged should use WeakReference

I had to make a WeakPropertyChangedProxy class for this, I could not
think of a way to get around creating a new object for this

8 years agoFix Entry/SearchBar color issues (#306)
E.Z. Hart [Tue, 16 Aug 2016 18:10:32 +0000 (12:10 -0600)]
Fix Entry/SearchBar color issues (#306)

* Fix disappearing Entry text on UWP Anniversary Edition
Fix background color reversion bug in UWP Phone
Move SearchBar styling on UWP to its own file
Make foreground/background color changes on UWP SearchBar/Entry consistent
Fix SearchBar color toggle bug on WP8

* Temporarily moving SDK target to previous version

* Fix build error on OSX

8 years agoInvalidate measure of Label when FormattedText changes (#303)
Akihiko Odaki [Tue, 16 Aug 2016 18:05:42 +0000 (03:05 +0900)]
Invalidate measure of Label when FormattedText changes (#303)

8 years ago[A] Pre-AppCompat ListView Indicator ... (#281)
Samantha Houts [Tue, 16 Aug 2016 17:59:36 +0000 (10:59 -0700)]
[A] Pre-AppCompat ListView Indicator ... (#281)

...will keep spinning on tab change.

8 years ago[iOS] Fixed bug that made pull-to-refresh indicator always visible after 2+ pulls...
Samantha Houts [Tue, 16 Aug 2016 17:56:37 +0000 (10:56 -0700)]
[iOS] Fixed bug that made pull-to-refresh indicator always visible after 2+ pulls (#307)

* Add repro for Bugzilla 43214

* [iOS] Undo change to ListViewRenderer

was attempting to prevent multiple unnecessary calls to SendRefreshing,
but this caused unintended problems.

8 years ago[Xaml] Simplify listnodes with single elements (#304)
Stephane Delcroix [Mon, 15 Aug 2016 20:18:26 +0000 (22:18 +0200)]
[Xaml] Simplify listnodes with single elements (#304)

8 years agoRefix mc ignorable (#302)
Stephane Delcroix [Mon, 15 Aug 2016 20:07:35 +0000 (22:07 +0200)]
Refix mc ignorable (#302)

* Revert "Fix mc ignorable (#298)"

This reverts commit 31c2be29d5982338ae178d1b0f107e23e7749782.

* [Xaml] fix mc:Ignorable

8 years ago[Xaml] x:Static in x:Arguments (#288)
Stephane Delcroix [Mon, 15 Aug 2016 20:06:11 +0000 (22:06 +0200)]
[Xaml] x:Static in x:Arguments (#288)

* [Xaml] Support x:Static as x:Arguments

* [XamlC] allow x:Static in x:Arguments

* fix typo, remove commented code

8 years agoAdded note about line endings to Page.xml. (#300)
Mike Norman [Fri, 12 Aug 2016 19:39:02 +0000 (14:39 -0500)]
Added note about line endings to Page.xml. (#300)

8 years agoFix mc ignorable (#298)
Stephane Delcroix [Fri, 12 Aug 2016 03:33:22 +0000 (05:33 +0200)]
Fix mc ignorable (#298)

* [Xaml] when ignoring nodes, ignore children as well

* [XamlC] ignore on xamlc too

8 years agoAdd Orange color to Color (#290)
Kangho [Thu, 11 Aug 2016 09:39:32 +0000 (18:39 +0900)]
Add Orange color to Color (#290)

* Add Orange color to Color

8 years ago[Win] Set BindingContext for default cell (#289)
Samantha Houts [Thu, 11 Aug 2016 09:31:45 +0000 (02:31 -0700)]
[Win] Set BindingContext for default cell (#289)

* Revise 41205 test case to use binding

* [Win] Set BindingContext for default cell

* [Win] SetInheritedBindingContext for Cell

8 years agoUnit tests for the PCL WeakEventManager (#280)
E.Z. Hart [Wed, 10 Aug 2016 11:51:33 +0000 (05:51 -0600)]
Unit tests for the PCL WeakEventManager (#280)

8 years agoAdd the key in the message on throwing a KeyNotFoundException (#282)
Rogier van der Hee [Tue, 9 Aug 2016 10:37:35 +0000 (12:37 +0200)]
Add the key in the message on throwing a KeyNotFoundException (#282)

* Add the key in the message on throwing a KeyNotFoundException for trying to access an invalid key in the ResourceDictionary. This helps a lot in tracking down what resource is actually missing.

* Fix test build, use C# 6 string interpolation

8 years ago[Android] Close the correct mode if it wasn't disposed (#283)
Rui Marinho [Tue, 9 Aug 2016 10:16:51 +0000 (11:16 +0100)]
[Android] Close the correct mode if it wasn't disposed (#283)

8 years agoEnable WebView to render local HTML files on WinRT platforms (#277)
E.Z. Hart [Wed, 3 Aug 2016 21:22:14 +0000 (15:22 -0600)]
Enable WebView to render local HTML files on WinRT platforms (#277)

* Enable WebView to render local HTML files on WinRT platforms

* Add test to demonstrate that the solution works even if
<head> isn't in the HTML string

8 years agoidentifer => identifier in ExportEffectAttribute.xml (#276)
Mike Norman [Wed, 3 Aug 2016 17:33:44 +0000 (12:33 -0500)]
identifer => identifier in ExportEffectAttribute.xml (#276)

8 years agoFixed https://github.com/xamarin/documentation/issues/1508 (#275)
Mike Norman [Wed, 3 Aug 2016 17:14:59 +0000 (12:14 -0500)]
Fixed https://github.com/xamarin/documentation/issues/1508 (#275)

8 years agoFix bugzilla41209 (#216)
Rui Marinho [Wed, 3 Aug 2016 09:07:50 +0000 (10:07 +0100)]
Fix bugzilla41209 (#216)

* [Android] Add custom FormsSeekbar to handle invalid pressed states send by other views

* [Controls] Fix sample , error only occurs with transparent background

8 years ago[Android] Fix ListView contextual actions not closing in AppCompat's NavigationPage...
Paul DiPietro [Wed, 3 Aug 2016 08:50:31 +0000 (03:50 -0500)]
[Android] Fix ListView contextual actions not closing in AppCompat's NavigationPage/TabbedPage (#272)

* [Android] Fix ListView contextual actions not closing upon navigation in AppCompat

The Platform type in the ListViewAdapter was being treated as the
non-AppCompat type, and the NavAnimationInProgress value was not
being set as necessary in the NavigationPageRenderer.

* [Android] Add fix for TabbedPage swipes not closing contextual actions

Similar fix where swiping to another tab with the context menu open would
not close it. Relies on the prior commit.

8 years ago[UWP/8.1] ListView respects keyboard selection (#182)
Paul DiPietro [Wed, 3 Aug 2016 00:28:36 +0000 (19:28 -0500)]
[UWP/8.1] ListView respects keyboard selection (#182)

The ListViewRenderer's OnControlSelectionChanged would fire when using
the keyboard to change the selection of a ListView, but the Element's
SelectedItem value was not being set due to it normally being tracked
via tap/click.

8 years ago[A, iOS] ListView Pull-To-Refresh indicator animates when navigating back to it ...
Samantha Houts [Tue, 2 Aug 2016 21:48:25 +0000 (14:48 -0700)]
[A, iOS] ListView Pull-To-Refresh indicator animates when navigating back to it (#274)

* Add repro for 33561

* [A] ListView refreshing on created shows indicator

* [iOS] Refresh indicator restarts when appeared

* Remove superfluous get

8 years agoAdd missing compiler directives to fix build error
E.Z. Hart [Tue, 2 Aug 2016 21:39:31 +0000 (15:39 -0600)]
Add missing compiler directives to fix build error

8 years ago[Android] By using the SetSingleLine(true), the developers are no (#234)
Depechie [Tue, 2 Aug 2016 20:59:56 +0000 (22:59 +0200)]
[Android] By using the SetSingleLine(true), the developers are no (#234)

longer able to use the SetMaxLines() in their own Custom Renderers
later on. So we force a single line by using the SetMaxLines(1) in the
base LabelRenderer and SetSingleLine(false)

8 years agoDispose of child renderers in FrameRenderer (#265)
E.Z. Hart [Tue, 2 Aug 2016 20:57:08 +0000 (14:57 -0600)]
Dispose of child renderers in FrameRenderer (#265)

* Dispose of child renderers in FrameRenderer

* Add missing null check

8 years agoChange SourceChanged event on ImageSource to weak event to allow Images (#268)
E.Z. Hart [Tue, 2 Aug 2016 20:54:57 +0000 (14:54 -0600)]
Change SourceChanged event on ImageSource to weak event to allow Images (#268)

referencing application-wide StaticResource ImageSources to be GCed

8 years ago[Android] Color.Accent is hardcoded (#270)
Michael Rumpler [Tue, 2 Aug 2016 20:54:40 +0000 (22:54 +0200)]
[Android] Color.Accent is hardcoded (#270)

8 years agoXaml convert on add (#273)
Stephane Delcroix [Tue, 2 Aug 2016 20:24:50 +0000 (22:24 +0200)]
Xaml convert on add (#273)

* [Xaml] add test for conversion on Set and Add

* [Xaml] Fix conversion on Add()

* [XamlC] use op_implicit before Add()

8 years ago[Android] Add null check to prevent crashes when long clicking a text entry in ListVi...
Paul DiPietro [Tue, 2 Aug 2016 16:15:35 +0000 (11:15 -0500)]
[Android] Add null check to prevent crashes when long clicking a text entry in ListView header/footer (#271)

When a text entry control (Entry, Editor, SearchBar, etc.) was being used in the header or
footer of a ListView on Android, a long click/press would cause a crash. This was occurring
in the HandleContextMode method because it expected to be a cell. Adding a null check and
breaking out of the method if the value from GetCellForPosition is null prevents this crash
from occurring.

8 years ago[Android] Fix focus/unfocus behavior on both Picker renderers (#264)
Paul DiPietro [Tue, 26 Jul 2016 17:01:01 +0000 (12:01 -0500)]
[Android] Fix focus/unfocus behavior on both Picker renderers (#264)

On AppCompat, focus and unfocus would not trigger when using the
Picker. On pre-Lollipop, unfocus would not trigger, but only when
tapping outside of the dialog.

8 years ago[XamlC] fix a bug in the debugging code introduced last week (#267)
Stephane Delcroix [Mon, 25 Jul 2016 19:40:34 +0000 (21:40 +0200)]
[XamlC] fix a bug in the debugging code introduced last week (#267)

8 years ago[XamlC] Fix the getter of getters (#263)
Stephane Delcroix [Thu, 21 Jul 2016 18:59:40 +0000 (20:59 +0200)]
[XamlC] Fix the getter of getters (#263)

8 years ago[8.1/UWP] ListView allows selection with enter key (#241)
Paul DiPietro [Tue, 19 Jul 2016 03:05:08 +0000 (22:05 -0500)]
[8.1/UWP] ListView allows selection with enter key (#241)

8 years agoAdd workaround for bugzilla 37792 (#181)
Vincent Costel [Tue, 19 Jul 2016 00:09:20 +0000 (20:09 -0400)]
Add workaround for bugzilla 37792 (#181)

8 years agoAndroid Custom Font support (#236)
Roy [Mon, 18 Jul 2016 23:38:05 +0000 (01:38 +0200)]
Android Custom Font support (#236)

* Implemented basic Support for Android Custom fonts

* Fixed Tabs

* Removed Private

* Changed behaviour to use UWP FontFamily style names

* Fixed Bug

8 years ago[Win] Setting TabbedPage.BarTextColor works (#244)
Samantha Houts [Mon, 18 Jul 2016 23:33:41 +0000 (16:33 -0700)]
[Win] Setting TabbedPage.BarTextColor works (#244)

[Win] TabbedPage BarBG takes precedence

8 years agoPrevent FormsAppCompatActivity from loading fragments we don't use on restart (#246)
E.Z. Hart [Mon, 18 Jul 2016 23:30:41 +0000 (17:30 -0600)]
Prevent FormsAppCompatActivity from loading fragments we don't use on restart (#246)

* Prevent FormsAppCompatActivity from loading fragments we don't use on restart

* Adding issues lost in merge

8 years ago[XamlC] correctly resolve override of virtual event handlers (#247)
Stephane Delcroix [Mon, 18 Jul 2016 23:30:08 +0000 (01:30 +0200)]
[XamlC] correctly resolve override of virtual event handlers (#247)

8 years ago[Android] Null reference exception fix (#252)
Toni Petrina [Mon, 18 Jul 2016 23:26:59 +0000 (01:26 +0200)]
[Android] Null reference exception fix (#252)

* Added null checks

* Replaced spaces with tabs

8 years agoixed issues where you could not force rotation with a NavigationPage on iOS. (#254)
ytn3rd [Mon, 18 Jul 2016 23:25:47 +0000 (09:25 +1000)]
ixed issues where you could not force rotation with a NavigationPage on iOS. (#254)

8 years agoFixes issue when setting NavigationPage.SetHasBackButton after page has navigated...
Stefan de Vogelaere [Mon, 18 Jul 2016 23:20:58 +0000 (01:20 +0200)]
Fixes issue when setting NavigationPage.SetHasBackButton after page has navigated (Android/AppCompat) (#256)

8 years ago[Android] Add dialog null check for AppCompat Picker OnClick (#257)
Paul DiPietro [Mon, 18 Jul 2016 23:20:20 +0000 (18:20 -0500)]
[Android] Add dialog null check for AppCompat Picker OnClick (#257)

Multiple, rapid taps on the Picker in AppCompat could potentially open
more than one dialog, causing a crash upon their being closed. Adding
a null check for the dialog prevents more than one from being created.

8 years agoFix for NullReferenceException when ItemSource has item removed and a… (#258)
Praga Siva [Mon, 18 Jul 2016 23:18:15 +0000 (07:18 +0800)]
Fix for NullReferenceException when ItemSource has item removed and a… (#258)

* fix for NullReferenceException when ItemSource has item removed and another inserted on iOS

* Update ViewCellRenderer.cs

Fix spacing issue

8 years ago[Xaml] allow the Previewer to provide their own Xaml files for any type (#262)
Stephane Delcroix [Mon, 18 Jul 2016 23:17:29 +0000 (01:17 +0200)]
[Xaml] allow the Previewer to provide their own Xaml files for any type (#262)

* [Xaml] allow the Previewer to provide their own Xaml files for any type

* [Xaml] use a Func instead of an interface, easier to use by reflection. Add tests

* [XamlC] move the InitializeComponent duplication to XamlC task

* [XamlC] generate branching code

* [XamlC] fix the XamlC issue

* [XamlC] make the API public

* [docs] fix docs

8 years agoWindows image loader error handling (#260)
E.Z. Hart [Mon, 18 Jul 2016 23:16:47 +0000 (17:16 -0600)]
Windows image loader error handling (#260)

* Repros for various image issues

* Log image loading errors

* Better repro instructions and user interface

* Image loading tests now running on WinRT/UWP phone/tablet/desktop

* Move FailImageSource into shared project

* Move FailImageSource into shared project

* Update docs

8 years ago[Android] Remove API check in ActivityIndicatorRenderer's UpdateColor method (#261)
Paul DiPietro [Mon, 18 Jul 2016 23:11:44 +0000 (18:11 -0500)]
[Android] Remove API check in ActivityIndicatorRenderer's UpdateColor method (#261)

8 years agoEnsure BindingContext is properly passed to CreateDefault in UWP ListView (#259)
Jason Smith [Mon, 18 Jul 2016 14:54:04 +0000 (07:54 -0700)]
Ensure BindingContext is properly passed to CreateDefault in UWP ListView (#259)

8 years agoRevert "[Xaml] allow the Previewer to provide their own Xaml files for any type"
Stephane Delcroix [Mon, 18 Jul 2016 08:02:01 +0000 (10:02 +0200)]
Revert "[Xaml] allow the Previewer to provide their own Xaml files for any type"

This reverts commit 962c8fd352e32309c9dcb7f8c2f07a335f18fc75.

8 years ago[Xaml] allow the Previewer to provide their own Xaml files for any type
Stephane Delcroix [Mon, 18 Jul 2016 08:00:06 +0000 (10:00 +0200)]
[Xaml] allow the Previewer to provide their own Xaml files for any type

8 years ago[Android] Handle creating a default GroupHeader if no GroupHeaderTemplate is provided...
Rui Marinho [Wed, 13 Jul 2016 08:59:49 +0000 (09:59 +0100)]
[Android] Handle creating a default GroupHeader if no GroupHeaderTemplate is provided (#248)

8 years agoUpdate docs for PoppedToRootEventArgs (#253)
Rui Marinho [Tue, 12 Jul 2016 18:24:04 +0000 (19:24 +0100)]
Update docs for PoppedToRootEventArgs (#253)

8 years ago[Android] TimePicker unfocuses on cancel (#238)
Paul DiPietro [Tue, 12 Jul 2016 14:59:32 +0000 (09:59 -0500)]
[Android] TimePicker unfocuses on cancel (#238)

Related to the prior fix of the DatePicker not unfocusing on the cancel button
being pressed, the TimePicker was not unfocusing, as well. A similar fix has
been applied.

8 years agoRestore incorrectly renamed InvalidateMeasure method (#251)
E.Z. Hart [Mon, 11 Jul 2016 19:28:36 +0000 (13:28 -0600)]
Restore incorrectly renamed InvalidateMeasure method (#251)

* Restore incorrectly renamed InvalidateMeasure method

* Update docs

8 years agoAdded PoppedToRootEventArgs to track popped pages when calling PopToRoot (#229)
Johan Karlsson [Mon, 11 Jul 2016 18:39:11 +0000 (20:39 +0200)]
Added PoppedToRootEventArgs to track popped pages when calling PopToRoot (#229)

8 years agoFix DatePicker dialog regression (#249)
Paul DiPietro [Mon, 11 Jul 2016 17:12:58 +0000 (13:12 -0400)]
Fix DatePicker dialog regression (#249)

KitKat doesn't use the cancel button, so it has to be accounted for.

8 years ago[All] Crash fixes for ListViews (#243)
Samantha Houts [Fri, 1 Jul 2016 20:51:38 +0000 (13:51 -0700)]
[All] Crash fixes for ListViews (#243)

* [Controls] Add repro for 42277

* [Android] No crash if GroupHeaderTemplate=null

* [Android] Fix DataTemplateSelector crash

* [Core] Expose ListProxy on TIL

* [iOS] Fix DataTemplateSelector crash

* [Win] Fix DataTemplateSelector crash

* [Docs] Update docs

* [Core] Implement ListProxy explicitly

Allows ListProxy property to stay internal.

* [Controls] Revert unnecessary change to shproj

8 years ago[iOS] Fix regression 2.3.1-pre1 UnevenRows (#242)
Rui Marinho [Thu, 30 Jun 2016 16:06:59 +0000 (17:06 +0100)]
[iOS] Fix regression 2.3.1-pre1 UnevenRows (#242)

* [Controls] Add test case for 39486

* [iOS] Fix math refactor error on calculating height

8 years ago[iOS] Default BarTextColor/BarBackgroundColor will no longer override values set... beta-2.3.1-pre1
Samantha Houts [Tue, 28 Jun 2016 10:25:45 +0000 (03:25 -0700)]
[iOS] Default BarTextColor/BarBackgroundColor will no longer override values set in custom renderers (#233)

* [Controls] Improve TabbedPage test case

iOS should default to the color used in a custom renderer instead of to
the global default color.

* [iOS] TabbedPage Bar*Color default is better

Will use the color set by a custom renderer, if any, instead of always
pulling from global appearance.

8 years ago[Android] Memory leak when MasterDetailPage Detail set to NavigationPage (#239)
E.Z. Hart [Mon, 27 Jun 2016 15:20:47 +0000 (09:20 -0600)]
[Android] Memory leak when MasterDetailPage Detail set to NavigationPage  (#239)

* Create repro

* Remove unnecessary cast

* Add null checks on weak references in PageContainer

* Remove master/detail fragments from manager when switching master/detail pages
Separate renderer ViewGroup removal from renderer disposal in FragmentContainer
Separate PageContainer disposal from renderer disposal in FragmentContainer
Remove Drawer Listener for NavigationPageRenderer in Dispose

* Fix missing spaces;
Add explicit SPACE_BEFORE_IF_PARENTHESES settings to DotSettings file

* Remove javascript rules

* Remove usage of .ForEach()

8 years ago[UITest] Update to 1.3.8, remove old projects (#240)
Rui Marinho [Fri, 24 Jun 2016 16:05:42 +0000 (17:05 +0100)]
[UITest] Update to 1.3.8, remove old projects  (#240)

* [UITests] Update to Xamarin UItest 1.3.8

* Remove legacy UITest projects

* Remove issue that uses reference to controls

* Update Xamarin.Forms.Core.iOS.UITests.csproj

* Update Xamarin.Forms.Core.Android.UITests.csproj

8 years ago[Controls] Fix use of internal extension methods (#237)
Rui Marinho [Wed, 22 Jun 2016 14:59:54 +0000 (15:59 +0100)]
[Controls] Fix use of internal extension methods (#237)

* [Controls] Fix use of internal extension methods

* [Controls] Update Xamarin UItest on controls

* Update package TestCloud

* Fix

* Revert "Fix"

This reverts commit 283f96a2210322bf37795dff61394938eb909f59.

* Fix reference

8 years ago[Android] Make sure to add a parent to the new group header cell (#228)
Rui Marinho [Sat, 18 Jun 2016 00:16:00 +0000 (01:16 +0100)]
[Android] Make sure to add a parent to the new group header cell (#228)

8 years ago[Android] Take in account status bar padding on master when using split behaviour...
Rui Marinho [Fri, 17 Jun 2016 18:55:06 +0000 (19:55 +0100)]
[Android] Take in account status bar padding on master when using split behaviour in MDP (#226)

8 years agoFix 39802 (#217)
Rui Marinho [Fri, 17 Jun 2016 16:29:43 +0000 (17:29 +0100)]
Fix 39802 (#217)

* [iOS] When using ContextActionsCell make sure we don't show the ContentCell separator

* [Android] Don't write separator view if not needed

8 years agoPrep Cell & friends for removal of InternalsVisibleTo (#142)
Samantha Houts [Fri, 17 Jun 2016 10:10:18 +0000 (03:10 -0700)]
Prep Cell & friends for removal of InternalsVisibleTo (#142)

* Prep Cell & friends for removal of InternalsVisibleTo

Includes:
- Cell
- EntryCell
- ListView
- MenuItem
- TableView
- ViewCell
- Toolbar

Moved extensions to Internal & removed TPH

* Update docs

* [Controls] Ignore Issue2411 on iOS <9

* [Controls] Formatting for Issue2411

8 years ago[Android] DatePicker unfocuses on cancel (#204)
Paul DiPietro [Thu, 16 Jun 2016 17:51:16 +0000 (13:51 -0400)]
[Android] DatePicker unfocuses on cancel (#204)

The DatePicker in Android would remain focused when being closed via the
cancel button, and a subsequent re-focus via something such as button
would not function as expected.