David Herrmann [Fri, 24 Jul 2015 10:37:12 +0000 (12:37 +0200)]
sd-bus: don't treat KDBUS_ITEM_TIMESTAMP as unknown item
In bus_kernel_translate_message(), we print a DEBUG message on unknown
items. But right now, we also print this message for KDBUS_ITEM_TIMESTAMP
despite parsing it properly. Fix this!
Daniel Mack [Fri, 24 Jul 2015 10:50:56 +0000 (12:50 +0200)]
Merge pull request #606 from dvdhrm/bus-proxy-pedantic-matches2
bus-proxy: never pass on unmatched broadcasts (v2)
Daniel Mack [Fri, 24 Jul 2015 10:04:30 +0000 (12:04 +0200)]
Merge pull request #695 from poettering/journal-fixes
Journal fixes
Daniel Mack [Fri, 24 Jul 2015 09:59:30 +0000 (11:59 +0200)]
Merge pull request #702 from ldzhong/fix
udev: fix parameter process
Lidong Zhong [Fri, 24 Jul 2015 08:37:17 +0000 (16:37 +0800)]
udev: fix parameter process
Daniel Mack [Fri, 24 Jul 2015 08:20:40 +0000 (10:20 +0200)]
Merge pull request #699 from ysbnim/master
exit-status: add missing string for EXIT_SMACK_PROCESS_LABEL
Daniel Mack [Fri, 24 Jul 2015 08:09:06 +0000 (10:09 +0200)]
Merge pull request #696 from poettering/automount-expiry-freq
automount: lower the idle polling frequency a bit
Daniel Mack [Fri, 24 Jul 2015 08:08:44 +0000 (10:08 +0200)]
Merge pull request #697 from poettering/service-bus-name
core: print a nicer warning when two units have the same BusName= set…
Sungbae Yoo [Thu, 23 Jul 2015 05:17:03 +0000 (14:17 +0900)]
exit-status: add a missing string for EXIT_SMACK_PROCESS_LABEL
Lennart Poettering [Fri, 24 Jul 2015 01:50:36 +0000 (03:50 +0200)]
core: print a nicer warning when two units have the same BusName= setting
This should make issues like #609 easier to debug.
Lennart Poettering [Fri, 24 Jul 2015 01:13:57 +0000 (03:13 +0200)]
automount: lower the idle polling frequency a bit
The autofs kernel idle logic requires us to poll the kernel for
idleness. This is of course suboptimal, but cannot be fixed without
kernel change.
Currently the polling frequency is set to 1/10 of the idle timeout. This
is quite high, as seen in #571. Let's lower this to 1/3.
Lennart Poettering [Fri, 24 Jul 2015 00:18:13 +0000 (02:18 +0200)]
journal: uppercase first character in verify error messages
In the english language the first character of a sentence is supposed to
be uppercase. Let's make sure this also applies to the journal
verification error messages.
Lennart Poettering [Fri, 24 Jul 2015 00:10:32 +0000 (02:10 +0200)]
journalctl: properly detect empty journal files
When we encounter a journal file with exactly zero entries, print a nice
message and exit, and don't print a weird error message.
Lennart Poettering [Fri, 24 Jul 2015 00:02:07 +0000 (02:02 +0200)]
journal: explain the error when we find a non-DATA object that is compressed
Only objects of type DATA may be compressed, generate a message about
that, like we do for all other errros.
Lennart Poettering [Fri, 24 Jul 2015 00:00:43 +0000 (02:00 +0200)]
journal: when verifying journal files, handle empty ones nicely
A journal file that carries no objects should be considered valid.
Lennart Poettering [Thu, 23 Jul 2015 23:55:45 +0000 (01:55 +0200)]
journal: avoid mapping empty data and field hash tables
When a new journal file is created we write the header first, then sync
and only then create the data and field hash tables in them. That means
to other processes it might appear that the files have a valid header
but not data and field hash tables. Our reader code should be able to
deal with this.
With this change we'll not map the two hash tables right-away after
opening a file for reading anymore (because that will of course fail if
the objects are missing), but delay this until the first time we access
them. On top of that, when we want to look something up in the hash
tables and we notice they aren't initialized yet, we consider them
empty.
This improves handling of some journal files reported in #487.
Lennart Poettering [Thu, 23 Jul 2015 23:40:44 +0000 (01:40 +0200)]
journal-verify: don't hit SIGFPE when determining progress
If we determine the progress based on a number of objects available,
don't blindly devide by the number of objects, given that it might be 0.
Daniel Mack [Thu, 23 Jul 2015 22:22:56 +0000 (00:22 +0200)]
Merge pull request #539 from poettering/tmpfiles-journal-acl
tmpfiles: don't recursively descend into journal directories in /var
Daniel Mack [Thu, 23 Jul 2015 22:04:49 +0000 (00:04 +0200)]
Merge pull request #694 from poettering/fileio-fixes
Fileio fixes
Lennart Poettering [Thu, 23 Jul 2015 21:47:54 +0000 (23:47 +0200)]
process: an empty environment block should be returned as such
An empty env block is completely valid, hence return it as such, and
don't turn it into an error.
Lennart Poettering [Thu, 23 Jul 2015 21:44:40 +0000 (23:44 +0200)]
process: return ESRCH when a PID is not valid anymore
so far, when we read something from /proc/$PID we would pass on the
ENOENT from the kernel as error, if the process was missing. With this
change we systematically convert this to ESRCH, which is the more
appropriate error code, and what all the other glibc/syscalls like
kill() use.
All code that calls these functions should be fine with this change. In
fact, one invocation of get_process_exe() in bus-creds.c already assumed
ESRCH would be returned if a process is missing, and this assumption is
now validated after the change.
Lennart Poettering [Thu, 23 Jul 2015 21:36:34 +0000 (23:36 +0200)]
fileio: get_status_field() don't clobber arg on OOM
According to our coding style guidelines we shouldn't clobber
pass-by-ref arguments on failure, hence don't do so here either.
Daniel Mack [Thu, 23 Jul 2015 21:20:18 +0000 (23:20 +0200)]
Merge pull request #692 from poettering/fd-copy-directory-all
copy: when we recursively copy a directory tree, copy everything
Lennart Poettering [Thu, 23 Jul 2015 19:41:22 +0000 (21:41 +0200)]
copy: when we recursively copy a directory tree, copy everything
Don't ignore hidden files and directories.
Fixes #386
Tom Gundersen [Thu, 23 Jul 2015 20:46:07 +0000 (22:46 +0200)]
Merge pull request #683 from ssahani/tun1
networkd: ip6gre add support for flowlabel
Lennart Poettering [Thu, 23 Jul 2015 19:56:09 +0000 (21:56 +0200)]
Merge pull request #670 from floppym/ptsuid
nspawn: Don't pass uid mount option for devpts
Lennart Poettering [Thu, 23 Jul 2015 19:38:01 +0000 (21:38 +0200)]
Merge pull request #678 from eworm-de/oracle-kvm
Oracle kvm
Daniel Mack [Thu, 23 Jul 2015 19:23:49 +0000 (21:23 +0200)]
Merge pull request #691 from teg/networkd-after-sysctl
units: order networkd after sysctl
Christian Hesse [Thu, 23 Jul 2015 19:18:36 +0000 (21:18 +0200)]
virt: handle Virtualbox 5.0 with kvm hypervisor
Virtualbox 5.0 now supports kvm hypervisor. In this case cpuid
identidies as "kvm", which breaks units depending on
ConditionVirtualization=oracle.
So return "oracle" even with kvm hypervisor.
Lennart Poettering [Thu, 23 Jul 2015 19:07:57 +0000 (21:07 +0200)]
Merge pull request #682 from ssahani/bridge
networkd: add bridge link properties
Tom Gundersen [Thu, 23 Jul 2015 18:58:33 +0000 (20:58 +0200)]
units: order networkd after sysctl
This way networkd will correctly and race-freely inherit the default settings
applied by sysctl.
Suggested in issue #468.
Susant Sahani [Thu, 23 Jul 2015 18:03:40 +0000 (23:33 +0530)]
man: add man for bridge params
Susant Sahani [Thu, 23 Jul 2015 18:01:58 +0000 (23:31 +0530)]
networkd: add bridge link properties
new bridge properties
br.network
[Match]
Name=enp0s25
[Network]
Bridge=br-test
[Bridge]
Cost=332
BPDUGuard = true
HairPin = true
FastLeave = true
RootBlock = true
UnicastFlood = true
Lennart Poettering [Thu, 23 Jul 2015 17:02:34 +0000 (19:02 +0200)]
Merge pull request #604 from heftig/master
build-sys: Use slim LTO objects if possible
Lennart Poettering [Thu, 23 Jul 2015 16:48:25 +0000 (18:48 +0200)]
Merge pull request #690 from teg/resolved-fixes-2
resolved: assorted fixes v2
Tom Gundersen [Sun, 19 Jul 2015 19:42:52 +0000 (21:42 +0200)]
resolve: transaction - stop processing packet when found to be invalid
We were stopping the transaction, but we need to stop processing the packet alltogether.
Tom Gundersen [Fri, 17 Jul 2015 21:42:18 +0000 (23:42 +0200)]
resolved: packet - fix segfault in truncate()
A size_t was being accessed as a char* due to the order of arguments being inverted.
Tom Gundersen [Thu, 23 Jul 2015 11:48:56 +0000 (13:48 +0200)]
resolved: rr - ignore pseudo types in NSEC(3) bitmaps
Tom Gundersen [Thu, 23 Jul 2015 11:28:09 +0000 (13:28 +0200)]
resolved: rr - fix parsing of NSEC3
We were appending rather than reading the bitmap.
Tom Gundersen [Thu, 23 Jul 2015 11:13:43 +0000 (13:13 +0200)]
resolved: rr - don't read past end of RR when parsing NSEC(3)
We can never read past the end of the packet, so this seems impossible
to exploit, but let's error out early as reading past the end of the
current RR is clearly an error.
Found by Lennart, based on patch by Daniel.
Tom Gundersen [Thu, 23 Jul 2015 11:09:35 +0000 (13:09 +0200)]
resolved: rr - SSHFP contains the fingerprint, not the key
Rename the field to make this clearer.
Tom Gundersen [Thu, 23 Jul 2015 10:57:58 +0000 (12:57 +0200)]
resolved: packet - fail on invalid zero-length data
Most blobs (keys, signatures, ...) should have a specific size given by
the relevant algorithm. However, as we don't use/verify the algorithms
yet, let's just ensure that we don't read out zero-length data in cases
where this does not make sense.
The only exceptions, where zero-length data is allowed are in the NSEC3
salt field, and the generic data (which we don't know anything about,
so better not make any assumptions).
Daniel Mack [Thu, 23 Jul 2015 14:13:51 +0000 (16:13 +0200)]
Merge pull request #687 from poettering/bitmap-fixes
bitmap: various clean-ups
Lennart Poettering [Thu, 23 Jul 2015 13:57:54 +0000 (15:57 +0200)]
bitmap: various clean-ups
a) use memcmp() to compare bitmaps efficiently
b) use UINT64_C() macro instead of ULL suffixes to get right suffix for
uint64_t constants
c) add a few assert()s
d) when comparing integers with 0 we generally try to make this explicit
with "!= 0".
e) remove redundant bitmap_isset() if check, as we don't have it in
bitmap_isset() either.
f) It should be fine to invoke bitmap_unset() on a NULL bitmap
Tom Gundersen [Thu, 23 Jul 2015 10:34:34 +0000 (12:34 +0200)]
Merge pull request #669 from poettering/dns-rr-memdup
resolve: unify memdup() code when parsing RRs
Susant Sahani [Thu, 23 Jul 2015 05:44:08 +0000 (11:14 +0530)]
networkd: ip6gre add support for flowlabel
Susant Sahani [Thu, 23 Jul 2015 09:09:43 +0000 (09:09 +0000)]
sd-netlink: add bridge NL params
Susant Sahani [Thu, 23 Jul 2015 09:09:11 +0000 (09:09 +0000)]
Add bridge NL params to missing.h
Tom Gundersen [Thu, 23 Jul 2015 09:35:55 +0000 (11:35 +0200)]
Merge pull request #677 from zonque/bitmap2
basic: bitmap: use uint64_t instead if long long unsigned
Daniel Mack [Thu, 23 Jul 2015 09:00:15 +0000 (11:00 +0200)]
Merge pull request #674 from ssahani/tunnel
ip6 tunnel: add support for DSCP
Susant Sahani [Thu, 23 Jul 2015 08:08:26 +0000 (13:38 +0530)]
man: add man for DSCP
David Herrmann [Thu, 23 Jul 2015 07:53:47 +0000 (09:53 +0200)]
Merge pull request #537 from poettering/nss-mymachines-userns
Hook up container userns with nss-mymachines
Daniel Mack [Thu, 23 Jul 2015 07:12:43 +0000 (09:12 +0200)]
Merge pull request #663 from poettering/tmpfiles-chattr-enotty
tmpfiles: downgrade errors when a file system does not support file a…
Daniel Mack [Thu, 23 Jul 2015 06:53:36 +0000 (08:53 +0200)]
Merge pull request #673 from poettering/dns-packet-append-type-window
resolved: make sure we alway initialize *start in dns_packet_append_t…
Daniel Mack [Thu, 23 Jul 2015 06:44:59 +0000 (08:44 +0200)]
basic: bitmap: use uint64_t instead if long long unsigned
long long unsigned is always 64 bit wide, so use a more readable type.
Daniel Mack [Thu, 23 Jul 2015 06:49:14 +0000 (08:49 +0200)]
Merge pull request #672 from poettering/bitmap-isclear
bitmap: bitmap_clear()
Susant Sahani [Thu, 23 Jul 2015 04:22:24 +0000 (09:52 +0530)]
networkd: ip6 tunnel add DSCP
This patch adds support for setting the
DSCP field in the ip6 tunnel.
when set it inherits DSCP field between inner and outer header.
Lennart Poettering [Thu, 23 Jul 2015 02:54:35 +0000 (04:54 +0200)]
resolved: make sure we alway initialize *start in dns_packet_append_type_window()
Lennart Poettering [Thu, 23 Jul 2015 02:51:57 +0000 (04:51 +0200)]
bitmap: bitmap_clear()
No need to actually reset the bitmap, we can just truncate it back zero
size. That not only makes bitmap_clear() quicker, but also subsequent
bitmap_isclear().
Lennart Poettering [Thu, 23 Jul 2015 02:04:19 +0000 (04:04 +0200)]
resolve: unify memdup() code when parsing RRs
Let's make dns_packet_read_public_key() more generic by renaming it to
dns_packet_read_memdup() (which more accurately describes what it
does...). Then, patch all cases where we memdup() RR data to use this
new call.
This specifically checks for zero-length objects, and handles them
gracefully. It will set zero length payload fields as a result.
Special care should be taken to ensure that any code using this call
can handle the returned allocated field to be NULL if the size is
specified as 0!
Mike Gilbert [Thu, 23 Jul 2015 02:34:57 +0000 (22:34 -0400)]
nspawn: Don't pass uid mount option for devpts
Mounting devpts with a uid breaks pty allocation with recent glibc
versions, which expect that the kernel will set the correct owner for
user-allocated ptys.
The kernel seems to be smart enough to use the correct uid for root when
we switch to a user namespace.
This resolves #337.
Tom Gundersen [Thu, 23 Jul 2015 01:58:47 +0000 (03:58 +0200)]
Merge pull request #667 from poettering/dns-rr-memleak
resolve: fix two minor memory leaks
Tom Gundersen [Thu, 23 Jul 2015 01:57:10 +0000 (03:57 +0200)]
Merge pull request #666 from poettering/drop-good-dns-server
resolve: drop dns_scope_good_dns_server()
Lennart Poettering [Thu, 23 Jul 2015 01:24:08 +0000 (03:24 +0200)]
resolve: fix two minor memory leaks
strv_extend() already strdup()s internally, no need to to this twice.
(Also, was missing OOM check...).
Use strv_consume() when we already have a string allocated whose
ownership we want to pass to the strv.
This fixes
50f1e641a93cacfc693b0c3d300bee5df0c8c460.
Lennart Poettering [Thu, 23 Jul 2015 01:10:42 +0000 (03:10 +0200)]
resolve: drop dns_scope_good_dns_server()
It's not used anymore since
29815b6c608b836cada5e349d06a96b63eaa65f3,
hence let's remove it from the sources.
Daniel Mack [Thu, 23 Jul 2015 00:32:29 +0000 (02:32 +0200)]
Merge pull request #665 from poettering/reword-journal-size-msg
journal: reword msg about enforced size limits a bit
Lennart Poettering [Thu, 23 Jul 2015 00:04:19 +0000 (02:04 +0200)]
journal: reword msg about enforced size limits a bit
http://lists.freedesktop.org/archives/systemd-devel/2015-July/033574.html
Daniel Mack [Wed, 22 Jul 2015 22:43:00 +0000 (00:43 +0200)]
Merge pull request #632 from Stebalien/cgls-nspawn
Machines can also be services
Steven Allen [Mon, 20 Jul 2015 15:57:45 +0000 (11:57 -0400)]
cgls: machines can also be services
This makes `systemd-cgls -M <machine name>` work with nspawn containers in
systemd 222.
Lennart Poettering [Wed, 22 Jul 2015 20:02:14 +0000 (22:02 +0200)]
tmpfiles: downgrade errors when a file system does not support file attributes
This downgrades errors from setting file attributes via tmpfiles to
warnings and makes them non-fatal.
Also, as a special case, if a file system does not support file
attributes at all, then the message is downgraded to debug, so that it
is not seen at all.
With this change reiserfs should not see any messages at all anymore
(since it apparently does not implement file attributes at all), but XFS
will still get a warning but no failure. The warning is something the
XFS kernel folks should fix though, by adjusting their file attributes
behaviour to be identical to ext234's.
Fixes #560.
Michal Schmidt [Wed, 22 Jul 2015 17:57:03 +0000 (19:57 +0200)]
Merge pull request #660 from michich/in-set
improve IN_SET macro
Michal Schmidt [Wed, 22 Jul 2015 15:50:44 +0000 (17:50 +0200)]
basic: more optimizable IN_SET macro
Making the array static allows gcc -O2 to generate smaller code:
"size systemd" before:
text data bss dec hex filename
1377286 128608 2632 1508526 1704ae systemd
After:
text data bss dec hex filename
1374326 128572 2664 1505562 16f91a systemd
(IN_SET still results in worse generated code than using
"x == FOO || x == BAR || ...". I don't think we'll be able to match
that with the C preprocessor.)
This change limits the use of IN_SET to sets with constant elements. All
present callers use constants. The compiler would report an "initializer
element is not constant" error otherwise.
Michal Schmidt [Wed, 22 Jul 2015 15:05:41 +0000 (17:05 +0200)]
basic: better readable IN_SET macro
Putting the set elements in an array variable and using ELEMENTSOF makes
it clearer what's going on.
Incidentally, it also makes gcc -O2 generate slightly smaller code:
"size systemd", before:
text data bss dec hex filename
1378318 128608 2632 1509558 1708b6 systemd
After:
text data bss dec hex filename
1377286 128608 2632 1508526 1704ae systemd
Lennart Poettering [Wed, 22 Jul 2015 17:06:36 +0000 (19:06 +0200)]
Merge pull request #654 from ssahani/nl
network: Add tunnel params
Tom Gundersen [Wed, 22 Jul 2015 12:17:12 +0000 (14:17 +0200)]
Merge pull request #647 from michich/job-logging
Job logging fixes and improvements
Michal Schmidt [Wed, 22 Jul 2015 11:41:33 +0000 (13:41 +0200)]
Merge pull request #651 from keszybz/ata_id-wwn-ordering
ata_id: unreverse WWN identifier
Susant Sahani [Wed, 22 Jul 2015 09:29:23 +0000 (14:59 +0530)]
sd-netlink: add tunnel params
Susant Sahani [Wed, 22 Jul 2015 09:28:52 +0000 (14:58 +0530)]
Tunnel NL params: Add to missing.h
Daniel Mack [Wed, 22 Jul 2015 08:21:46 +0000 (10:21 +0200)]
Merge pull request #652 from whot/hwdb-updates
hwdb: add Logitech MX Master DPI settings
Zbigniew Jędrzejewski-Szmek [Wed, 22 Jul 2015 04:23:47 +0000 (00:23 -0400)]
ata_id: unreverse WWN identifier
An endianness conversion was lost in
6024a6e302bad6bcf073fa84a41a6123305dc845.
Restore it. Now ata_id and scsi_id output match.
https://bugzilla.redhat.com/show_bug.cgi?id=1227503
Peter Hutterer [Mon, 13 Jul 2015 21:34:19 +0000 (07:34 +1000)]
hwdb: add Logitech MX Master DPI settings
Tom Gundersen [Tue, 21 Jul 2015 18:17:21 +0000 (20:17 +0200)]
Merge pull request #648 from michich/udev-log-priority
udev.log-priority crash fix and cleanup
Michal Schmidt [Tue, 21 Jul 2015 16:35:18 +0000 (18:35 +0200)]
udev: unify reporting of invalid cmdline keys
This way it does not need distinct string literals and it also preserves
the "rd." prefix.
Michal Schmidt [Tue, 21 Jul 2015 16:26:09 +0000 (18:26 +0200)]
udev: fix crash with invalid udev.log-priority
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1245293
Michal Schmidt [Tue, 21 Jul 2015 17:07:24 +0000 (19:07 +0200)]
core: adjust job completion message log levels
We do not print all non-OK job completion status messages to the console
in red, because not all of them are plain errors. We do however log the
same messages as LOG_ERR.
Differentiate the log levels by deducing them from the job result in a
way that more or less matches the color of the console message.
Michal Schmidt [Tue, 21 Jul 2015 15:26:28 +0000 (17:26 +0200)]
core: small refactor of job completion logging
Joins three log_struct() calls into one.
Michal Schmidt [Tue, 21 Jul 2015 14:20:18 +0000 (16:20 +0200)]
core: log completion of remaining job types
JOB_RESTART and failed JOB_VERIFY_ACTIVE completions were printed to
console but not to the log.
Michal Schmidt [Tue, 21 Jul 2015 14:15:19 +0000 (16:15 +0200)]
core: do not log done failed-condition jobs as if unit started
It is misleading to see "Started foo." in the log when the unit's
condition was false.
Michal Schmidt [Tue, 21 Jul 2015 13:51:16 +0000 (15:51 +0200)]
core: remove generic job completion messages from unit vtables
These units' message format strings are identical to the generic
strings. Since we can always rely on the fallback, these are now
redundant.
Michal Schmidt [Tue, 21 Jul 2015 12:54:24 +0000 (14:54 +0200)]
core: try harder to get job completion messages too
This is similar to "core: always try harder to get unit status
message format string", but for job completion status messages.
It makes generic status messages applicable for printing to the console.
And it rewrites the functions in a more table-based style.
Michal Schmidt [Mon, 20 Jul 2015 16:36:12 +0000 (18:36 +0200)]
core: unit_get_status_message_format() never returns NULL
unit_get_status_message_format() is used only with one of JOB_START,
JOB_STOP, JOB_RELOAD, all of which have fallback message strings
defined, so the function may never return NULL.
Daniel Mack [Tue, 21 Jul 2015 13:30:47 +0000 (15:30 +0200)]
bootchart: fix negative 'timeleft' condition
Fix the overrun case in sample acquistion and negative number calculations.
Reported by Stefan Sauer.
Fixes #642
Daniel Mack [Tue, 21 Jul 2015 15:20:55 +0000 (17:20 +0200)]
Merge pull request #643 from zonque/fileio
basic/fileio: fix write_string_file() fallout
Daniel Mack [Mon, 20 Jul 2015 21:17:37 +0000 (23:17 +0200)]
user-sessions: fix write_string_file() fallout
WRITE_STRING_FILE_ATOMIC is only valid if WRITE_STRING_FILE_CREATE is also
given. IOW, an atomic file write operation is only possible when creating a
file is also being asked for.
This is a regression from the recent write_string_file() rework.
Daniel Mack [Mon, 20 Jul 2015 21:17:37 +0000 (23:17 +0200)]
logind: fix write_string_file() fallout
WRITE_STRING_FILE_ATOMIC is only valid if WRITE_STRING_FILE_CREATE is also
given. IOW, an atomic file write operation is only possible when creating a
file is also being asked for.
This is a regression from the recent write_string_file() rework.
Michal Schmidt [Mon, 20 Jul 2015 15:18:13 +0000 (17:18 +0200)]
core: always try harder to get unit status message format string
The starting/stopping messages are printed to the console only if the
corresponding format string is defined in the unit's vtable. To avoid
excessive messages on the console, the unit types whose start/stop
jobs are instantaneous had the format strings intentionally undefined.
When logging the same event to the journal, a fallback to generic
Starting/Stopping/Reloading messages is used.
The problem of excessive console messages with instantaneous jobs
is already resolved in a nicer way ("core: fix confusing logging of
instantaneous jobs"), so there's no longer a need to have two ways of
getting the format strings. Let's fold them into one function with
the fallback to generic message strings.
Michal Schmidt [Thu, 16 Jul 2015 19:39:56 +0000 (21:39 +0200)]
core: correct return value from reload methods
Return 1 from *_reload() methods to signify "we did something", just
like in *_start(). This causes "Reloading foo..." messages to be logged.
"Reloaded foo." messages are already logged.
Michal Schmidt [Thu, 16 Jul 2015 18:08:30 +0000 (20:08 +0200)]
core: fix confusing logging of instantaneous jobs
For instantaneous jobs (e.g. starting of targets, sockets, slices, or
Type=simple services) the log shows the job completion
before starting:
systemd[1]: Created slice -.slice.
systemd[1]: Starting -.slice.
systemd[1]: Created slice System Slice.
systemd[1]: Starting System Slice.
systemd[1]: Listening on Journal Audit Socket.
systemd[1]: Starting Journal Audit Socket.
systemd[1]: Reached target Timers.
systemd[1]: Starting Timers.
...
The reason is that the job completes before the ->start() method returns
and only then does unit_start() print the "Starting ..." message.
The same thing happens when stopping units.
Rather than fixing the order of the messages, let's just not emit the
Starting/Stopping message at all when the job completes instantaneously.
The job completion message is sufficient in this case.
Tom Gundersen [Tue, 21 Jul 2015 09:19:00 +0000 (11:19 +0200)]
Merge pull request #636 from ssahani/tunnel
networkd: ip6 tunnel add support for flowlabel
Susant Sahani [Tue, 21 Jul 2015 04:37:10 +0000 (10:07 +0530)]
man: add man ipv6 flowlabel support for ip6 tunnels