platform/upstream/freerdp.git
10 years agoMerge pull request #1787 from hardening/oom_checks2
Marc-André Moreau [Mon, 14 Apr 2014 18:19:58 +0000 (14:19 -0400)]
Merge pull request #1787 from hardening/oom_checks2

Misc fixes to check OOM

10 years agoMerge pull request #1789 from MartinHaimberger/mh-memfixes
Marc-André Moreau [Mon, 14 Apr 2014 18:17:30 +0000 (14:17 -0400)]
Merge pull request #1789 from MartinHaimberger/mh-memfixes

Fixed misc leaks

10 years agoMerge pull request #1784 from hardening/collections_reallocs
Marc-André Moreau [Mon, 14 Apr 2014 18:17:05 +0000 (14:17 -0400)]
Merge pull request #1784 from hardening/collections_reallocs

Don't leak memory when realloc fails

10 years agoMerge pull request #1778 from awakecoding/smartcard
Marc-André Moreau [Mon, 14 Apr 2014 18:13:11 +0000 (14:13 -0400)]
Merge pull request #1778 from awakecoding/smartcard

Smart Card Complete Overhaul

10 years agochannels/smartcard: add more debug output
Marc-André Moreau [Sun, 13 Apr 2014 20:48:32 +0000 (16:48 -0400)]
channels/smartcard: add more debug output

10 years agochannels/smartcard: add more debug output
Marc-André Moreau [Sun, 13 Apr 2014 19:50:51 +0000 (15:50 -0400)]
channels/smartcard: add more debug output

10 years agolibwinpr-smartcard: improve GetStatusChange
Marc-André Moreau [Sun, 13 Apr 2014 04:43:12 +0000 (00:43 -0400)]
libwinpr-smartcard: improve GetStatusChange

10 years agolibwinpr-smartcard: implement PCSC/WinSCard reader name aliasing
Marc-André Moreau [Sun, 13 Apr 2014 03:38:15 +0000 (23:38 -0400)]
libwinpr-smartcard: implement PCSC/WinSCard reader name aliasing

10 years agochannels/smartcard: add pcsc-lite protocol value mapping
Marc-André Moreau [Sat, 12 Apr 2014 22:13:18 +0000 (18:13 -0400)]
channels/smartcard: add pcsc-lite protocol value mapping

10 years agochannels/smartcard: make PCSC implementation even closer to WinSCard
Marc-André Moreau [Sat, 12 Apr 2014 20:45:06 +0000 (16:45 -0400)]
channels/smartcard: make PCSC implementation even closer to WinSCard

10 years agochannels/smartcard: cleanup of sanitization
Marc-André Moreau [Sat, 12 Apr 2014 19:09:23 +0000 (15:09 -0400)]
channels/smartcard: cleanup of sanitization

10 years agochannels/smartcard: add more debug output, make distinction between reader and card...
Marc-André Moreau [Sat, 12 Apr 2014 18:31:54 +0000 (14:31 -0400)]
channels/smartcard: add more debug output, make distinction between reader and card state

10 years agochannels/smartcard: add more debug output
Marc-André Moreau [Sat, 12 Apr 2014 16:42:09 +0000 (12:42 -0400)]
channels/smartcard: add more debug output

10 years agolibwinpr-smartcard: fix SCardConnectW deadlock
Marc-André Moreau [Sat, 12 Apr 2014 16:15:04 +0000 (12:15 -0400)]
libwinpr-smartcard: fix SCardConnectW deadlock

10 years agolibwinpr-smartcard: fix deadlock in PCSC_SCardFreeMemory
Marc-André Moreau [Sat, 12 Apr 2014 15:24:47 +0000 (11:24 -0400)]
libwinpr-smartcard: fix deadlock in PCSC_SCardFreeMemory

10 years agochannels/smartcard: add more debug output
Marc-André Moreau [Fri, 11 Apr 2014 22:57:04 +0000 (18:57 -0400)]
channels/smartcard: add more debug output

10 years agochannels/smartcard: fix broken context/handle encoding/decoding
Marc-André Moreau [Fri, 11 Apr 2014 21:44:27 +0000 (17:44 -0400)]
channels/smartcard: fix broken context/handle encoding/decoding

10 years agochannels/smartcard: make handles completely opaque
Marc-André Moreau [Fri, 11 Apr 2014 20:27:01 +0000 (16:27 -0400)]
channels/smartcard: make handles completely opaque

10 years agochannels/smartcard: fix on Windows
Marc-André Moreau [Fri, 11 Apr 2014 18:13:06 +0000 (14:13 -0400)]
channels/smartcard: fix on Windows

10 years agochannels/smartcard: cleanup context/handle management
Marc-André Moreau [Fri, 11 Apr 2014 18:01:42 +0000 (14:01 -0400)]
channels/smartcard: cleanup context/handle management

10 years agofixed Wlog_Uninit to also free child logger
Martin Haimberger [Fri, 11 Apr 2014 09:07:50 +0000 (02:07 -0700)]
fixed Wlog_Uninit to also free child logger

10 years agousing setenv instead of putenv to prevent memleaks
Martin Haimberger [Fri, 11 Apr 2014 09:07:18 +0000 (02:07 -0700)]
using setenv instead of putenv to prevent memleaks

10 years agochannels/smartcard: added detailed debug tracing
Marc-André Moreau [Fri, 11 Apr 2014 06:17:36 +0000 (02:17 -0400)]
channels/smartcard: added detailed debug tracing

10 years agochannels/smartcard: cleanup and simplify ListReaders call
Marc-André Moreau [Fri, 11 Apr 2014 03:55:11 +0000 (23:55 -0400)]
channels/smartcard: cleanup and simplify ListReaders call

10 years agochannels/smartcard: minor fixes
Marc-André Moreau [Thu, 10 Apr 2014 21:36:42 +0000 (17:36 -0400)]
channels/smartcard: minor fixes

10 years agoMisc fixes to check OOM
Hardening [Thu, 10 Apr 2014 19:07:53 +0000 (21:07 +0200)]
Misc fixes to check OOM

10 years agoMerge pull request #1786 from nfedera/fix-2014-04-10-02
Marc-André Moreau [Thu, 10 Apr 2014 17:26:47 +0000 (13:26 -0400)]
Merge pull request #1786 from nfedera/fix-2014-04-10-02

core/server: only enable activated bitmap codecs

10 years agocore/server: only enable activated bitmap codecs
Norbert Federa [Thu, 10 Apr 2014 17:13:47 +0000 (19:13 +0200)]
core/server: only enable activated bitmap codecs

10 years agoMerge pull request #1785 from nfedera/fix-2014-04-10-01
Marc-André Moreau [Thu, 10 Apr 2014 15:47:22 +0000 (11:47 -0400)]
Merge pull request #1785 from nfedera/fix-2014-04-10-01

core: fix multifragment update capability exchange

10 years agocore: fix multifragment update capability exchange
Norbert Federa [Thu, 10 Apr 2014 15:22:06 +0000 (17:22 +0200)]
core: fix multifragment update capability exchange

10 years agolibwinpr-smartcard: more pcsc-lite fixes
Marc-André Moreau [Wed, 9 Apr 2014 21:44:39 +0000 (17:44 -0400)]
libwinpr-smartcard: more pcsc-lite fixes

10 years agoDon't leak memory when realloc fails
Hardening [Wed, 9 Apr 2014 19:53:42 +0000 (21:53 +0200)]
Don't leak memory when realloc fails

10 years agolibwinpr-smartcard: add proper locking by SCARDCONTEXT for pcsc-lite
Marc-André Moreau [Wed, 9 Apr 2014 19:32:18 +0000 (15:32 -0400)]
libwinpr-smartcard: add proper locking by SCARDCONTEXT for pcsc-lite

10 years agochannels/smartcard: pcsc-lite fixes
Marc-André Moreau [Wed, 9 Apr 2014 18:27:44 +0000 (14:27 -0400)]
channels/smartcard: pcsc-lite fixes

10 years agochannels/smartcard: fix some valgrind warnings
Marc-André Moreau [Wed, 9 Apr 2014 16:28:03 +0000 (12:28 -0400)]
channels/smartcard: fix some valgrind warnings

10 years agoMerge branch 'master' of github.com:FreeRDP/FreeRDP into smartcard
Marc-André Moreau [Wed, 9 Apr 2014 15:12:00 +0000 (11:12 -0400)]
Merge branch 'master' of github.com:FreeRDP/FreeRDP into smartcard

10 years agoMerge pull request #1775 from maksqwe/license_read_fix
Marc-André Moreau [Wed, 9 Apr 2014 15:11:01 +0000 (11:11 -0400)]
Merge pull request #1775 from maksqwe/license_read_fix

fix check for certificate_read_server_certificate()

10 years agoMerge branch 'master' of github.com:FreeRDP/FreeRDP into smartcard
Marc-André Moreau [Wed, 9 Apr 2014 14:41:05 +0000 (10:41 -0400)]
Merge branch 'master' of github.com:FreeRDP/FreeRDP into smartcard

10 years agochannels/smartcard: don't treat certain errors as errors
Marc-André Moreau [Wed, 9 Apr 2014 14:40:52 +0000 (10:40 -0400)]
channels/smartcard: don't treat certain errors as errors

10 years agoMerge pull request #1782 from hardening/oom_cases
Marc-André Moreau [Wed, 9 Apr 2014 14:39:31 +0000 (10:39 -0400)]
Merge pull request #1782 from hardening/oom_cases

Treat OOM cases

10 years agoMerge pull request #1781 from hardening/collections_fixes
Marc-André Moreau [Wed, 9 Apr 2014 14:39:07 +0000 (10:39 -0400)]
Merge pull request #1781 from hardening/collections_fixes

Fixes in case of OOM

10 years agoTreat OOM cases
Hardening [Wed, 9 Apr 2014 14:07:06 +0000 (16:07 +0200)]
Treat OOM cases

10 years agowinpr: fix failing unit tests
Marc-André Moreau [Wed, 9 Apr 2014 14:01:58 +0000 (10:01 -0400)]
winpr: fix failing unit tests

10 years agoFixes in case of OOM
Hardening [Wed, 9 Apr 2014 13:26:43 +0000 (15:26 +0200)]
Fixes in case of OOM

10 years agoMerge pull request #1780 from hardening/http_malloc_fixes
Marc-André Moreau [Wed, 9 Apr 2014 13:21:48 +0000 (09:21 -0400)]
Merge pull request #1780 from hardening/http_malloc_fixes

Fix corner cases in http parsing

10 years agoFix corner cases in http parsing
Hardening [Wed, 9 Apr 2014 13:00:38 +0000 (15:00 +0200)]
Fix corner cases in http parsing

This patch adds checks for malloc / strdup, and free all memory
when such call fails.

10 years agolibwinpr-smartcard: fix missing link dependency
Marc-André Moreau [Wed, 9 Apr 2014 04:10:45 +0000 (00:10 -0400)]
libwinpr-smartcard: fix missing link dependency

10 years agoMerge pull request #1776 from maksqwe/fix_console_parallel_cmd_args_parse
Marc-André Moreau [Wed, 9 Apr 2014 03:56:35 +0000 (23:56 -0400)]
Merge pull request #1776 from maksqwe/fix_console_parallel_cmd_args_parse

fix check args count for 'parallel' cmd

10 years agoMerge branch 'master' of github.com:FreeRDP/FreeRDP into smartcard
Marc-André Moreau [Wed, 9 Apr 2014 03:53:45 +0000 (23:53 -0400)]
Merge branch 'master' of github.com:FreeRDP/FreeRDP into smartcard

10 years agochannels/smartcard: improve SCardGetAttrib
Marc-André Moreau [Wed, 9 Apr 2014 03:52:24 +0000 (23:52 -0400)]
channels/smartcard: improve SCardGetAttrib

10 years agochannels/smartcard: harden parsing of expected padding
Marc-André Moreau [Wed, 9 Apr 2014 02:10:21 +0000 (22:10 -0400)]
channels/smartcard: harden parsing of expected padding

10 years agochannels/smartcard: Transmit_Return pioRecvPci implementation
Marc-André Moreau [Wed, 9 Apr 2014 01:36:47 +0000 (21:36 -0400)]
channels/smartcard: Transmit_Return pioRecvPci implementation

10 years agolibwinpr-smartcard: implement SCARD_AUTOALLOCATE
Marc-André Moreau [Wed, 9 Apr 2014 01:02:30 +0000 (21:02 -0400)]
libwinpr-smartcard: implement SCARD_AUTOALLOCATE

10 years agochannels/smartcard: fix ListReaders mszGroups parsing
Marc-André Moreau [Tue, 8 Apr 2014 22:55:50 +0000 (18:55 -0400)]
channels/smartcard: fix ListReaders mszGroups parsing

10 years agolibwinpr-smartcard: improve Mac OS X build
Marc-André Moreau [Tue, 8 Apr 2014 20:58:51 +0000 (16:58 -0400)]
libwinpr-smartcard: improve Mac OS X build

10 years agoremove unneeded check
Maks Naumov [Tue, 8 Apr 2014 19:48:17 +0000 (22:48 +0300)]
remove unneeded check

10 years agoMerge pull request #1777 from bmiklautz/issue/1771
Norbert Federa [Tue, 8 Apr 2014 17:51:40 +0000 (19:51 +0200)]
Merge pull request #1777 from bmiklautz/issue/1771

core: fixed client random size

10 years agocore: fixed client random size
Bernhard Miklautz [Tue, 8 Apr 2014 17:38:01 +0000 (19:38 +0200)]
core: fixed client random size

client random must be (bitlen / 8) + 8 - see [MS-RDPBCGR] 5.3.4.1

fixes #1771

10 years agofix check args count for 'parallel' cmd
Maks Naumov [Tue, 8 Apr 2014 17:23:02 +0000 (20:23 +0300)]
fix check args count for 'parallel' cmd

10 years agoMake certificate_read_server_certificate() return BOOL
Maks Naumov [Tue, 8 Apr 2014 12:59:34 +0000 (15:59 +0300)]
Make certificate_read_server_certificate() return BOOL

10 years agochannels/smartcard: fix GetStatusChange SCARD_E_TIMEOUT handling
Marc-André Moreau [Tue, 8 Apr 2014 16:00:04 +0000 (12:00 -0400)]
channels/smartcard: fix GetStatusChange SCARD_E_TIMEOUT handling

10 years agoMerge branch 'smartcard' of github.com:awakecoding/FreeRDP into smartcard
Marc-André Moreau [Tue, 8 Apr 2014 15:34:46 +0000 (11:34 -0400)]
Merge branch 'smartcard' of github.com:awakecoding/FreeRDP into smartcard

Conflicts:
channels/smartcard/client/smartcard_pack.c

10 years agochannels/smartcard: fix padding functions
Marc-André Moreau [Tue, 8 Apr 2014 15:32:48 +0000 (11:32 -0400)]
channels/smartcard: fix padding functions

10 years agolibwinpr-smartcard: add option to build statically against specialized pcsclite build
Marc-André Moreau [Tue, 8 Apr 2014 05:26:28 +0000 (01:26 -0400)]
libwinpr-smartcard: add option to build statically against specialized pcsclite build

10 years agochannels/smartcard: harden packing
Marc-André Moreau [Tue, 8 Apr 2014 03:45:11 +0000 (23:45 -0400)]
channels/smartcard: harden packing

10 years agochannels/smartcard: more code hardening
Marc-André Moreau [Mon, 7 Apr 2014 21:17:26 +0000 (17:17 -0400)]
channels/smartcard: more code hardening

10 years agochannels/smartcard: add more verbose debug output to transmit call
Marc-André Moreau [Mon, 7 Apr 2014 17:39:47 +0000 (13:39 -0400)]
channels/smartcard: add more verbose debug output to transmit call

10 years agochannels/smartcard: add more debug output to transmit calls
Marc-André Moreau [Mon, 7 Apr 2014 16:53:38 +0000 (12:53 -0400)]
channels/smartcard: add more debug output to transmit calls

10 years agochannels/smartcard: fix GetStatusChangeW
Marc-André Moreau [Mon, 7 Apr 2014 16:38:27 +0000 (12:38 -0400)]
channels/smartcard: fix GetStatusChangeW

10 years agochannels/smartcard: handle ntstatus codes
Marc-André Moreau [Mon, 7 Apr 2014 16:13:31 +0000 (12:13 -0400)]
channels/smartcard: handle ntstatus codes

10 years agochannels/smartcard: cleanup return codes
Marc-André Moreau [Mon, 7 Apr 2014 14:59:13 +0000 (10:59 -0400)]
channels/smartcard: cleanup return codes

10 years agochannels/smartcard: more unpacking
Marc-André Moreau [Mon, 7 Apr 2014 05:19:58 +0000 (01:19 -0400)]
channels/smartcard: more unpacking

10 years agochannels/smartcard: implement clean SCardStatusW
Marc-André Moreau [Mon, 7 Apr 2014 04:58:34 +0000 (00:58 -0400)]
channels/smartcard: implement clean SCardStatusW

10 years agochannels/smartcard: implement clean ListReadersW
Marc-André Moreau [Mon, 7 Apr 2014 04:10:27 +0000 (00:10 -0400)]
channels/smartcard: implement clean ListReadersW

10 years agochannels/smartcard: cleanup packing
Marc-André Moreau [Mon, 7 Apr 2014 03:08:40 +0000 (23:08 -0400)]
channels/smartcard: cleanup packing

10 years agochannels/smartcard: cleanup old unpacking code
Marc-André Moreau [Mon, 7 Apr 2014 01:28:59 +0000 (21:28 -0400)]
channels/smartcard: cleanup old unpacking code

10 years agochannels/smartcard: more unpacking
Marc-André Moreau [Mon, 7 Apr 2014 01:09:49 +0000 (21:09 -0400)]
channels/smartcard: more unpacking

10 years agochannels/smartcard: unpacking improvements
Marc-André Moreau [Sun, 6 Apr 2014 20:29:11 +0000 (16:29 -0400)]
channels/smartcard: unpacking improvements

10 years agochannels/smartcard: more 64-bit fixes
Marc-André Moreau [Sun, 6 Apr 2014 01:17:54 +0000 (21:17 -0400)]
channels/smartcard: more 64-bit fixes

10 years agochannels/smartcard: fix some 64-bit handling issues
Marc-André Moreau [Sun, 6 Apr 2014 00:46:20 +0000 (20:46 -0400)]
channels/smartcard: fix some 64-bit handling issues

10 years agoMerge branch 'smartcard' of github.com:awakecoding/FreeRDP into smartcard
Marc-André Moreau [Sun, 6 Apr 2014 00:06:12 +0000 (20:06 -0400)]
Merge branch 'smartcard' of github.com:awakecoding/FreeRDP into smartcard

10 years agochannels/smartcard: fix non-monolithic build
Marc-André Moreau [Sun, 6 Apr 2014 00:05:51 +0000 (20:05 -0400)]
channels/smartcard: fix non-monolithic build

10 years agochannels/smartcard: cleanup
Marc-André Moreau [Sat, 5 Apr 2014 23:58:48 +0000 (19:58 -0400)]
channels/smartcard: cleanup

10 years agochannels/smartcard: add async irp processing
Marc-André Moreau [Sat, 5 Apr 2014 21:51:13 +0000 (17:51 -0400)]
channels/smartcard: add async irp processing

10 years agochannels/smartcard: cancel outstanding IRPs on re-initialization
Marc-André Moreau [Sat, 5 Apr 2014 21:15:17 +0000 (17:15 -0400)]
channels/smartcard: cancel outstanding IRPs on re-initialization

10 years agochannels/smartcard: add outstanding irp list
Marc-André Moreau [Sat, 5 Apr 2014 20:57:31 +0000 (16:57 -0400)]
channels/smartcard: add outstanding irp list

10 years agochannels/smartcard: cleanup ConnectA/ConnectW parsing
Marc-André Moreau [Sat, 5 Apr 2014 20:06:46 +0000 (16:06 -0400)]
channels/smartcard: cleanup ConnectA/ConnectW parsing

10 years agochannels/smartcard: handle common headers in a common place
Marc-André Moreau [Sat, 5 Apr 2014 15:56:02 +0000 (11:56 -0400)]
channels/smartcard: handle common headers in a common place

10 years agoMerge branch 'smartcard' of github.com:awakecoding/FreeRDP into smartcard
Marc-André Moreau [Sat, 5 Apr 2014 15:23:01 +0000 (11:23 -0400)]
Merge branch 'smartcard' of github.com:awakecoding/FreeRDP into smartcard

10 years agochannels/smartcard: improve packing of data structures
Marc-André Moreau [Sat, 5 Apr 2014 15:22:48 +0000 (11:22 -0400)]
channels/smartcard: improve packing of data structures

10 years agolibwinpr-smartcard: ListReaders_Call fix
Marc-André Moreau [Fri, 4 Apr 2014 21:37:00 +0000 (17:37 -0400)]
libwinpr-smartcard: ListReaders_Call fix

10 years agolibwinpr-smartcard: fix compilation on Windows
Marc-André Moreau [Fri, 4 Apr 2014 20:45:11 +0000 (16:45 -0400)]
libwinpr-smartcard: fix compilation on Windows

10 years agolibwinpr-smartcard: add winscard.dll backend
Marc-André Moreau [Fri, 4 Apr 2014 19:50:04 +0000 (15:50 -0400)]
libwinpr-smartcard: add winscard.dll backend

10 years agolibwinpr-smartcard: implement dynamic API stubs
Marc-André Moreau [Fri, 4 Apr 2014 19:30:03 +0000 (15:30 -0400)]
libwinpr-smartcard: implement dynamic API stubs

10 years agochannels/smartcard: cleanup unpacking of data structures
Marc-André Moreau [Fri, 4 Apr 2014 17:57:28 +0000 (13:57 -0400)]
channels/smartcard: cleanup unpacking of data structures

10 years agochannels/smartcard: improve parsing
Marc-André Moreau [Fri, 4 Apr 2014 04:56:24 +0000 (00:56 -0400)]
channels/smartcard: improve parsing

10 years agochannels/smartcard: add clean definitions of packed data structures and RDP smartcard...
Marc-André Moreau [Thu, 3 Apr 2014 22:47:18 +0000 (18:47 -0400)]
channels/smartcard: add clean definitions of packed data structures and RDP smartcard IOCTLs

10 years agochannels/smartcard: refactoring
Marc-André Moreau [Thu, 3 Apr 2014 21:29:12 +0000 (17:29 -0400)]
channels/smartcard: refactoring

10 years agoMerge pull request #1769 from nfedera/fix-2014-04-03-01
Marc-André Moreau [Thu, 3 Apr 2014 19:58:45 +0000 (15:58 -0400)]
Merge pull request #1769 from nfedera/fix-2014-04-03-01

libfreerdp-core: fix transport_check_fds

10 years agolibfreerdp-core: fix transport_check_fds
Norbert Federa [Thu, 3 Apr 2014 19:42:32 +0000 (21:42 +0200)]
libfreerdp-core: fix transport_check_fds

This patch fixes an issue with hung clients connected to FreeRDP server:

- Removed the completely useless inner while loop which used the transport
  receive buffer stream position as break contition: The transport receive
  buffer stream is replaced after each iteration of this loop with a fresh
  instance from a pool which has the position set to 0. Thus it was
  technically impossible that this loop would ever be run twice.

- We must not always return if transport_read_nonblocking returns 0:
  transport_read_nonblocking() is also called in transport_write() and
  therefore it is possible that the stream position of the transport
  receive buffer is already > 0 when entering transport_check_fds.