Kazu Hirata [Mon, 25 Jul 2022 05:28:11 +0000 (22:28 -0700)]
Remove redundaunt override specifiers (NFC)
Identified with modernize-use-override.
Fangrui Song [Mon, 25 Jul 2022 05:19:00 +0000 (22:19 -0700)]
[llvm-objcopy] --compress-debug-sections: fix uninitialized ch_reserved for Elf64_Chdr
ch_reserved is uninitialized and the output is not deterministic. Fix it.
Rewrite and improve compress-debug-sections-zlib.test.
Kazu Hirata [Mon, 25 Jul 2022 05:02:58 +0000 (22:02 -0700)]
[clang] Remove redundant virtual specifies (NFC)
Identified with modernize-use-override.
Kazu Hirata [Mon, 25 Jul 2022 04:50:35 +0000 (21:50 -0700)]
[llvm] Remove redundaunt virtual specifiers (NFC)
Identified with modernize-use-override.
Kazu Hirata [Mon, 25 Jul 2022 03:51:06 +0000 (20:51 -0700)]
[clang] Remove unused forward declarations (NFC)
inclyc [Tue, 12 Jul 2022 16:12:12 +0000 (00:12 +0800)]
[clang] better error message for while loops outside of control flow
report an error when encountering 'while' token parsing declarator
```
clang/test/Parser/while-loop-outside-function.c:3:1: error: while loop outside of a function
while // expected-error {{while loop outside of a function}}
^
clang/test/Parser/while-loop-outside-function.c:7:1: error: while loop outside of a function
while // expected-error {{while loop outside of a function}}
^
```
Fixes: https://github.com/llvm/llvm-project/issues/34462
Differential Revision: https://reviews.llvm.org/D129573
Marius Hillenbrand [Mon, 25 Jul 2022 03:07:31 +0000 (08:37 +0530)]
[mlir][Arithmetic] Fix printing larger integer attributes in arith.const
For arith.constant operations of integer type, the operation generates
result names that include the value of the constant (i.e., the
IntegerAttr that defines the constant's value). That code currently
assumes integer widths of 64 bits or less and hits an assert with wider
constants or would create truncated and potentially ambiguous names when
built with assertions disabled.
To enable printing arith.constant ops for arbitrarily wide integer
types, change to use the IntegerAttr's function getValue() when
generating result names.
Also, add a regression test.
Reviewed By: bondhugula
Differential Revision: https://reviews.llvm.org/D129930
Fangrui Song [Mon, 25 Jul 2022 01:52:15 +0000 (18:52 -0700)]
[llvm-objcopy] Remove remnant .zdebug code
Warren Ristow [Mon, 25 Jul 2022 00:44:30 +0000 (17:44 -0700)]
[Reassociate][NFC] Consistent checking for FastMathFlags suitability
In D129523, it was noted that the approach to check whether a value can
have FastMathFlags was done in different ways, and they should be made
consistent. This patch makes minor changes to fix that.
Reviewed By: spatel
Differential Revision: https://reviews.llvm.org/D130408
Kazu Hirata [Sun, 24 Jul 2022 23:21:29 +0000 (16:21 -0700)]
Use llvm::less_first and llvm::less_second (NFC)
Amaury Séchet [Sun, 24 Jul 2022 22:02:59 +0000 (22:02 +0000)]
[NFC] Add parentheses in MathExtra.h
The code used to cause a warning:
llvm/include/llvm/Support/MathExtras.h:751:39: warning: suggest parentheses around ‘-’ in operand of ‘&’ [-Wparentheses]
751 | assert(Align != 0 && (Align & Align - 1) == 0 &&
|
Kazu Hirata [Sun, 24 Jul 2022 21:48:11 +0000 (14:48 -0700)]
Use any_of (NFC)
Kazu Hirata [Sun, 24 Jul 2022 21:48:09 +0000 (14:48 -0700)]
[Hexagon] Remove unused declaration CanReturnSmallStruct (NFC)
The declaration was introduced without a corresponding definition on
Dec 12, 2011 in commit
1213a7a57fdcb6c875b3f79103fc96d3e9d30b40.
Kazu Hirata [Sun, 24 Jul 2022 21:48:08 +0000 (14:48 -0700)]
[Hexagon] Remove unused declaration SelectZeroExtend (NFC)
The corresponding definition was removed on Jan 23, 2018 in commit
3780a0e1fae463e9195ae3fc2ba8424608310d8a.
Kazu Hirata [Sun, 24 Jul 2022 21:48:06 +0000 (14:48 -0700)]
[IPO] Use range-based for loops (NFC)
Sanjay Patel [Sun, 24 Jul 2022 21:05:40 +0000 (17:05 -0400)]
[ValueTracking] allow vector types in isImpliedCondition()
The matching of constants assumed integers, but we can handle
splat vector constants seamlessly with m_APInt.
Sanjay Patel [Sun, 24 Jul 2022 20:58:04 +0000 (16:58 -0400)]
[ValueTracking] add test for isImpliedCondition with vector types; NFC
Sanjay Patel [Fri, 22 Jul 2022 20:09:29 +0000 (16:09 -0400)]
[PhaseOrdering] add explanatory comment for test; NFC
This note was going to be added in D129650, but we
solved the problem by reverting another patch, and
I missed transferring the comment.
LLVM GN Syncbot [Sun, 24 Jul 2022 20:22:32 +0000 (20:22 +0000)]
[gn build] Port
b7aa9c4ac8e7
Nikolas Klauser [Sun, 24 Jul 2022 14:03:12 +0000 (16:03 +0200)]
[libc++] Granularize some more type_traits
Reviewed By: ldionne, #libc
Spies: libcxx-commits, mgorny
Differential Revision: https://reviews.llvm.org/D128948
Kazu Hirata [Sun, 24 Jul 2022 19:27:14 +0000 (12:27 -0700)]
[CodeGen] Remove a redundant void (NFC)
Identified with modernize-redundant-void-arg.
Kazu Hirata [Sun, 24 Jul 2022 19:27:12 +0000 (12:27 -0700)]
[ExecutionEngine] Fix a header guard (NFC)
Identified with llvm-header-guard.
Kazu Hirata [Sun, 24 Jul 2022 19:27:11 +0000 (12:27 -0700)]
Remove redundant string initialization (NFC)
Identified with readability-redundant-string-init.
Kazu Hirata [Sun, 24 Jul 2022 19:27:09 +0000 (12:27 -0700)]
[lldb] Remove redundant member initialization (NFC)
Identified with readability-redundant-member-init.
Kazu Hirata [Sun, 24 Jul 2022 19:27:08 +0000 (12:27 -0700)]
[lldb] Use nullptr instead of NULL (NFC)
Identified with modernize-use-nullptr.
Kazu Hirata [Sun, 24 Jul 2022 19:27:06 +0000 (12:27 -0700)]
[lldb] Use true instead of 0 (NFC)
Identified with modernize-use-bool-literals.
Kazu Hirata [Sun, 24 Jul 2022 19:27:05 +0000 (12:27 -0700)]
[llvm] Remove unused forward declarations (NFC)
Fangrui Song [Sun, 24 Jul 2022 18:20:49 +0000 (11:20 -0700)]
[ELF] Optimize some non-constant alignTo with alignToPowerOf2. NFC
My x86-64 lld executable is 2KiB smaller. .eh_frame writing gets faster as there
were lots of divisions.
LLVM GN Syncbot [Sun, 24 Jul 2022 17:43:27 +0000 (17:43 +0000)]
[gn build] Port
46ae26e7eb70
Andrew Turner [Sun, 24 Jul 2022 17:41:21 +0000 (10:41 -0700)]
[Driver] Enable some sanitizers on FreeBSD AArch64
They have been ported and tested to work on AArch64
(see D125883, D125758, and D125873).
Reviewed By: dim, MaskRay
Differential Revision: https://reviews.llvm.org/D130063
Jonas Toth [Sun, 24 Jul 2022 17:35:52 +0000 (19:35 +0200)]
[clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables
This patch connects the check for const-correctness with the new general
utility to add `const` to variables.
The code-transformation is only done, if the detected variable for const-ness
is not part of a group-declaration.
The check allows to control multiple facets of adding `const`, e.g. if pointers themself should be
marked as `const` if they are not changed.
Reviewed By: njames93
Differential Revision: https://reviews.llvm.org/D54943
Khem Raj [Sun, 24 Jul 2022 17:17:22 +0000 (10:17 -0700)]
[compiler-rt][CMake] Enable TF intrinsics on powerpc32 Linux
clang generates calls to these intrinsics when used for ppc32/linux, when using libgcc this works ok but when using compiler-rt for rtlib it fails with missing intrinsic symbols. also see [1]
[1] https://lists.llvm.org/pipermail/llvm-dev/2014-May/072784.html
Reviewed By: MaskRay, glaubitz
Differential Revision: https://reviews.llvm.org/D121379
Amaury Séchet [Sun, 24 Jul 2022 16:38:58 +0000 (16:38 +0000)]
[X86] Autogenerate atomic tests. NFC
Matt Arsenault [Wed, 15 Jun 2022 01:18:21 +0000 (21:18 -0400)]
RegAllocGreedy: Fix subranges when rematerializing dead subreg defs
This would create a new interval missing the subrange and hit this
verifier error:
*** Bad machine code: Live interval for subreg operand has no subranges ***
- function: test_remat_subreg_def
- basic block: %bb.0 (0xa568758) [0B;128B)
- instruction: 32B dead undef %4.sub0:vreg_64 = V_MOV_B32_e32 2, implicit $exec
Amaury Séchet [Sun, 24 Jul 2022 15:45:51 +0000 (15:45 +0000)]
[X86] Autogenerate cfguard-x86-64-vectorcall.ll. NFC
Matt Arsenault [Sat, 23 Jul 2022 19:07:03 +0000 (15:07 -0400)]
AMDGPU: Fix broken test checks
Simon Pilgrim [Sun, 24 Jul 2022 15:09:52 +0000 (16:09 +0100)]
[DAG] visitSMUL_LOHI/visitUMUL_LOHI - ensure we canonicalize constants to the RHS
Amaury Séchet [Sun, 24 Jul 2022 14:32:36 +0000 (14:32 +0000)]
[X86] Autogenerate some of the fp128 tests. NFC
Simon Pilgrim [Sun, 24 Jul 2022 14:23:13 +0000 (15:23 +0100)]
[DAG] getNode - assert that SMUL_LOHI/UMUL_LOHI nodes have the correct ops + types
Simon Pilgrim [Sun, 24 Jul 2022 13:48:18 +0000 (14:48 +0100)]
[X86] Regenerate hoist-and-by-const-from-lshr-in-eqcmp-zero.ll with common SSE2 prefix
Corentin Jabot [Sun, 24 Jul 2022 14:24:11 +0000 (16:24 +0200)]
[Clang] Add missing paper revisions in the release notes [NFC]
Corentin Jabot [Sun, 24 Jul 2022 06:55:49 +0000 (08:55 +0200)]
[clang] Fix incorrect constant folding of `if consteval`
Fixes https://github.com/llvm/llvm-project/issues/55638.
`if consteval` was evaluated incorrectly when in a
non-constant context that could be constant-folded.
Reviewed By: aaron.ballman
Differential Revision: https://reviews.llvm.org/D130437
Corentin Jabot [Sat, 23 Jul 2022 12:38:48 +0000 (14:38 +0200)]
[Clang] De-deprecate volatile compound operations
As per P2327R1,
|=, &= and ^= are no longer deprecated in all languages mode.
Reviewed By: aaron.ballman
Differential Revision: https://reviews.llvm.org/D130421
David Chisnall [Sun, 24 Jul 2022 10:56:12 +0000 (11:56 +0100)]
Fix crash in ObjC codegen introduced with
5ab6ee75994d645725264e757d67bbb1c96fb2b6
5ab6ee75994d645725264e757d67bbb1c96fb2b6 assumed that if `RValue::isScalar()` returns true then `RValue::getScalarVal` will return a valid value. This is not the case when the return value is `void` and so void message returns would crash if they hit this path. This is triggered only for cases where the nil-handling path needs to do something non-trivial (destroy arguments that should be consumed by the callee).
Reviewed By: triplef
Differential Revision: https://reviews.llvm.org/D123898
Simon Pilgrim [Sun, 24 Jul 2022 12:12:21 +0000 (13:12 +0100)]
[DAG] MaskedVectorIsZero - don't bother with (-1).isSubsetOf mask check. NFC.
Just use KnownBits::isZero() to ensure all the bits are known zero.
Simon Pilgrim [Sun, 24 Jul 2022 11:59:43 +0000 (12:59 +0100)]
[DAG] SimplifyMultipleUseDemandedBits - early-out for any scalable vector types
Noticed while working to remove SelectionDAG::GetDemandedBits - we were relying on the callers to have already bailed for scalable vectors
Simon Pilgrim [Sun, 24 Jul 2022 11:00:31 +0000 (12:00 +0100)]
[DAG] SimplifyDemandedVectorElts - if every and/mul element-pair has a zero/undef then just constant fold to zero
Simon Pilgrim [Sun, 24 Jul 2022 10:32:44 +0000 (11:32 +0100)]
[X86] combineAndnp - remove unused variable. NFC.
Simon Pilgrim [Sun, 24 Jul 2022 10:07:34 +0000 (11:07 +0100)]
[X86][SSE] Enable X86ISD::ANDNP constant folding
Simon Pilgrim [Sun, 24 Jul 2022 09:53:38 +0000 (10:53 +0100)]
[X86] Don't assume an AND/ANDNP element is undef/undemanded just because one element is undef
For mask ops like these, the other operand's corresponding element might be zero (result = zero) - so we must demand all the bits and that element.
This appears to be what D128570 was trying to fix - both sides of the funnel shift mask of the vXi64 (legalized to v2Xi32) were incorrectly simplifying the upper 32-bit halves to undef, resulting in bad folds later on.
I intend to address the test case regressions, but this close to the release branch I'd prefer to get a fix in first.
Fangrui Song [Sun, 24 Jul 2022 08:23:07 +0000 (01:23 -0700)]
[MC] Remove unused renameELFSection
Fangrui Song [Sun, 24 Jul 2022 08:17:34 +0000 (01:17 -0700)]
[MC] Delete dead zlib-gnu code and simplify writeSectionData
Nathan Ridge [Mon, 18 Jul 2022 07:48:04 +0000 (03:48 -0400)]
[clangd] Do not try to use $0 as a placeholder in completion snippets
$0 can only be used as a tab stop, not as a placeholder (e.g.
`${0:expression}` is not valid)
Fixes https://github.com/clangd/clangd/issues/1190
Differential Revision: https://reviews.llvm.org/D128621
Kazu Hirata [Sun, 24 Jul 2022 04:10:10 +0000 (21:10 -0700)]
Revert "[Orc] Use default member initialization (NFC)"
This reverts commit
d534967b6667c468b12e9ed5e3c482f590dde633.
The patch causes build failures, such as:
https://lab.llvm.org/buildbot/#/builders/121/builds/21760
Kazu Hirata [Sun, 24 Jul 2022 02:40:43 +0000 (19:40 -0700)]
[Hexagon] Remove unused declaration getByteVectorTy (NFC)
The declaration was introduced without a corresponding definition on
Sep 7, 2020 in commit
f5d07a05bbd41f827ccfa1bed7bfdfbab2be85dc.
Fangrui Song [Sun, 24 Jul 2022 02:32:13 +0000 (19:32 -0700)]
[Passes] Simplify ChangePrinter names. NFC
Brad Smith [Sun, 24 Jul 2022 02:09:58 +0000 (22:09 -0400)]
[libcxx] Remove static inline and make use of _LIBCPP_HIDE_FROM_ABI in __support/xlocale/__nop_locale_mgmt.h header
Reviewed By: ldionne
Differential Revision: https://reviews.llvm.org/D129949
Kazu Hirata [Sun, 24 Jul 2022 01:36:24 +0000 (18:36 -0700)]
[Analysis] Use default member initialization (NFC)
Kazu Hirata [Sun, 24 Jul 2022 01:36:23 +0000 (18:36 -0700)]
[Orc] Use default member initialization (NFC)
Identified with modernize-use-default-member-init
Craig Topper [Sat, 23 Jul 2022 23:40:29 +0000 (16:40 -0700)]
[RISCV] Add a continue to reduce nesting. NFC
NAKAMURA Takumi [Sun, 24 Jul 2022 00:28:08 +0000 (09:28 +0900)]
clang/include/clang/module.modulemap: Mark `Tooling/Inclusions/*.inc` as textual.
Fixes llvmorg-15-init-917-g46a6f5ae148a
Kazu Hirata [Sat, 23 Jul 2022 23:10:46 +0000 (16:10 -0700)]
[CodeGen] Use range-based for loops (NFC)
Kazu Hirata [Sat, 23 Jul 2022 22:47:53 +0000 (15:47 -0700)]
[IPO] Use std::array for AccessKind2Accesses (NFC)
Switching to std:array allow us to use fill.
While I am at it, this patch also converts one for loop to a
range-based one.
Augusto Noronha [Sat, 23 Jul 2022 22:37:15 +0000 (15:37 -0700)]
[lldb] Adapt lldb tests to changes in
71cdb8c6f144
Fangrui Song [Sat, 23 Jul 2022 22:30:15 +0000 (15:30 -0700)]
[LegacyPM] Remove {,PostInline}EntryExitInstrumenterPass
Following recent changes removing non-core features of the legacy
PM/optimization pipeline.
Amaury Séchet [Sat, 23 Jul 2022 21:51:50 +0000 (21:51 +0000)]
Autogenerate tests for win64-byval.ll . NFC
Nuno Lopes [Sat, 23 Jul 2022 21:32:30 +0000 (22:32 +0100)]
fix tests for commit
9df0b254d24eca098
Nuno Lopes [Sat, 23 Jul 2022 20:50:11 +0000 (21:50 +0100)]
[NFC] Switch a few uses of undef to poison as placeholders for unreachable code
Kazu Hirata [Sat, 23 Jul 2022 20:01:14 +0000 (13:01 -0700)]
[Vectorize] Remove isConsecutiveLoadOrStore (NFC)
The last use was removed on Jan 4, 2022 in commit
95a93722db2d10753f8887cf6a61380936d32f1c.
Kazu Hirata [Sat, 23 Jul 2022 19:29:05 +0000 (12:29 -0700)]
[AMDGPU] Remove a redundant variable (NFC)
ArrayRef has operator[], so we don't need to access the contents via
data().
Kazu Hirata [Sat, 23 Jul 2022 19:17:27 +0000 (12:17 -0700)]
Convert for_each to range-based for loops (NFC)
Kazu Hirata [Sat, 23 Jul 2022 18:35:19 +0000 (11:35 -0700)]
[Analysis] Remove a redundant return statement (NFC)
Identified with readability-redundant-control-flow.
Fangrui Song [Sat, 23 Jul 2022 18:32:02 +0000 (11:32 -0700)]
[AMDGPU] Change DEBUG_TYPE from isel to amdgpu-isel
to match all other *ISelDAGToDAG.cpp
Kazu Hirata [Sat, 23 Jul 2022 18:30:23 +0000 (11:30 -0700)]
[TableGen] Drop an unnecessary const from a return type (NFC)
This patch also drops "&" that binds to a temporary.
Identified with readability-const-return-type.
Kazu Hirata [Sat, 23 Jul 2022 17:50:26 +0000 (10:50 -0700)]
[ADT] Use default member initialization (NFC)
Identified with modernize-use-default-member-init.
Peter Klausler [Fri, 22 Jul 2022 18:51:20 +0000 (11:51 -0700)]
[flang] Correct IsHostAssociated() to be true for BLOCK constructs
The predicate IsHostAssocited() was implemented in a way that would
return true only for cases of host association into a module or inner
subprogram. Technically, the use of a name in a BLOCK construct
that is not declared therein is considered in the Fortran standard
to also be a form of host association, and this matters when doing
error checking on DATA statements.
Differential Revision: https://reviews.llvm.org/D130388
Simon Pilgrim [Sat, 23 Jul 2022 17:38:48 +0000 (18:38 +0100)]
[DAG] isSplatValue - don't attempt to merge any BITCAST sub elements if they contain UNDEFs
We still haven't found a solution that correctly handles 'don't care' sub elements properly - given how close it is to the next release branch, I'm making this fail safe change and we can revisit this later if we can't find alternatives.
NOTE: This isn't a reversion of D128570 - it's the removal of undef handling across bitcasts entirely
Fixes #56520
Simon Pilgrim [Sat, 23 Jul 2022 17:18:39 +0000 (18:18 +0100)]
[X86] Add test case for Issue #56520
Peter Klausler [Mon, 18 Jul 2022 21:12:21 +0000 (14:12 -0700)]
[flang] Clean up bogus semantic error on procedure pointer assignment
When a procedure pointer with no interface is associated with
an EXTERNAL name with no interface information, but it is later
inferred that the procedure pointer must be a subroutine because it
appears in a CALL statement, don't complain that the EXTERNAL name
is not also known to be a subroutine.
Subroutine vs. function errors are still caught in procedure pointer
assignment compatibility checking; this fix simply ensures that those
more nuanced tests are not overridded by the attribute set equality test.
Also, leave in some code for dumping the differing attributes in legitimate
error cases that was added in the coures of debugging the specific problem.
Differential Revision: https://reviews.llvm.org/D130385
Jez Ng [Sat, 23 Jul 2022 16:21:46 +0000 (12:21 -0400)]
[lld-macho][nfc] Reduce nesting of code added in D130125
Peter Klausler [Mon, 18 Jul 2022 20:13:03 +0000 (13:13 -0700)]
[flang] Don't fold zero-length substring references
In some contexts the code looks cleaner if we fold zero-length substring
references into empty character constants, but those don't work in
variable definition contexts and can lead to bogus semantic error
messages.
Differential Revision: https://reviews.llvm.org/D130383
Nico Weber [Sat, 23 Jul 2022 16:31:31 +0000 (12:31 -0400)]
Revert "[NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute." and follow-ups
This reverts commit
9429b67b8e300e638d7828bbcb95585f85c4df4d.
It broke the build on Windows, see comments on https://reviews.llvm.org/D130309
It also reverts these follow-ups:
Revert "Fix buildbot breakage after https://reviews.llvm.org/D130309."
This reverts commit
f959d815f4637890ebbacca379f1c38ab47e4e14.
Revert "Fix buildbot breakage after https://reviews.llvm.org/D130309."
This reverts commit
0bbce7a4c2d2bff622bdadd4323f93f5d90e6d24.
Revert "Cache the value for absolute path in FileSpec."
This reverts commit
dabe877248b85b34878e75d5510339325ee087d0.
Peter Klausler [Mon, 18 Jul 2022 18:30:29 +0000 (11:30 -0700)]
[flang] Fix name of dummy argument to intrinsic NEW_LINE(A='')
It should be A= but I misspelled it in the intrinsics table as X=.
Differential Revision: https://reviews.llvm.org/D130382
John Ericson [Fri, 22 Jul 2022 14:24:54 +0000 (14:24 +0000)]
Fix one stray `{LLVM -> CLANG}_TOOLS_INSTALL_DIR`
Follow up to D117977, where I missed this new usage after one rebase.
Thanks @tsteller in https://reviews.llvm.org/D117977#3670919 for
noticing.
Reviewed By: mstorsjo
Differential Revision: https://reviews.llvm.org/D130362
Kazu Hirata [Sat, 23 Jul 2022 16:22:27 +0000 (09:22 -0700)]
Use static_assert instead of assert (NFC)
Identified with misc-static-assert.
Jez Ng [Sat, 23 Jul 2022 16:11:46 +0000 (12:11 -0400)]
[lld-macho] Fold __objc_imageinfo sections
Previously, we treated it as a regular ConcatInputSection. However, ld64
actually parses its contents and uses that to synthesize a single image
info struct, generating one 8-byte section instead of `8 * number of
object files with ObjC code`.
I'm not entirely sure what impact this section has on the runtime, so I
just tried to follow ld64's semantics as closely as possible in this
diff. My main motivation though was to reduce binary size.
No significant perf change on chromium_framework on my 16-core Mac Pro:
base diff difference (95% CI)
sys_time 1.764 ± 0.062 1.748 ± 0.032 [ -2.4% .. +0.5%]
user_time 5.112 ± 0.104 5.106 ± 0.046 [ -0.9% .. +0.7%]
wall_time 6.111 ± 0.184 6.085 ± 0.076 [ -1.6% .. +0.8%]
samples 30 32
Reviewed By: #lld-macho, thakis
Differential Revision: https://reviews.llvm.org/D130125
Simon Pilgrim [Sat, 23 Jul 2022 15:56:39 +0000 (16:56 +0100)]
[X86] matchBinaryShuffle - limit SHUFFLE(X,Y) -> OR(X,Y) cases to where X + Y are the same width as the result
Minor bit of prep work toward not unnecessarily widening shuffle operands in combineX86ShufflesRecursively, instead only widening in combineX86ShuffleChain if we actual find a match - see Issue #45319
Jez Ng [Sat, 23 Jul 2022 15:47:44 +0000 (11:47 -0400)]
[lld-macho] Fix segfault when handling LTO + object file weak defs
which occurs when there are EH frames present in the object file's weak
def.
Reviewed By: abrachet
Differential Revision: https://reviews.llvm.org/D130409
Dmitry Vassiliev [Sat, 23 Jul 2022 14:28:18 +0000 (16:28 +0200)]
[IR] Fixed ambiguous call to llvm::report_fatal_error
This patch fixes the following error with MSVC 16.9.2:
llvm/lib/IR/GCStrategy.cpp(35): error C2668: 'llvm::report_fatal_error': ambiguous call to overloaded function
llvm/include/llvm/Support/ErrorHandling.h(75): note: could be 'void llvm::report_fatal_error(const llvm::Twine &,bool)'
llvm/include/llvm/Support/ErrorHandling.h(73): note: or 'void llvm::report_fatal_error(llvm::StringRef,bool)'
llvm/lib/IR/GCStrategy.cpp(35): note: while trying to match the argument list '(const std::string)'
Reviewed By: RKSimon, barannikov88
Differential Revision: https://reviews.llvm.org/D130407
Dmitri Gribenko [Sat, 23 Jul 2022 13:14:14 +0000 (15:14 +0200)]
Use llvm::sort instead of std::sort where possible
llvm::sort is beneficial even when we use the iterator-based overload,
since it can optionally shuffle the elements (to detect
non-determinism). However llvm::sort is not usable everywhere, for
example, in compiler-rt.
Reviewed By: nhaehnle
Differential Revision: https://reviews.llvm.org/D130406
Corentin Jabot [Sat, 23 Jul 2022 13:15:12 +0000 (15:15 +0200)]
[Clang] Update the status of N2393 in c_status.html
Dmitri Gribenko [Sat, 23 Jul 2022 13:07:49 +0000 (15:07 +0200)]
Use the range-based overload of llvm::sort where possible
Reviewed By: MaskRay
Differential Revision: https://reviews.llvm.org/D130403
Simon Pilgrim [Sat, 23 Jul 2022 12:11:07 +0000 (13:11 +0100)]
[DAG] Move OR(AND(X,C1),AND(OR(X,Y),C2)) -> OR(AND(X,OR(C1,C2)),AND(Y,C2)) fold to SimplifyDemandedBits
This will fix the SystemZ v3i31 memcpy regression in D77804 (with the help of D129765 as well....).
It should also allow us to /bend/ the oneuse limitation for cases where we can use demanded bits to safely peek though multiple uses of the AND ops.
Corentin Jabot [Sat, 23 Jul 2022 09:08:14 +0000 (11:08 +0200)]
[Clang] Adjust extension warnings for #warning
The #warning directive is standard in C++2b and C2x,
this adjusts the pedantic and extensions warning accordingly.
Reviewed By: aaron.ballman
Differential Revision: https://reviews.llvm.org/D130415
Corentin Jabot [Sat, 23 Jul 2022 10:18:01 +0000 (12:18 +0200)]
[Clang] Add support for Unicode identifiers (UAX31) in C2x mode.
This implements
N2836 Identifier Syntax using Unicode Standard Annex 31.
The feature was already implemented for C++,
and the semantics are the same.
Unlike C++ there was, afaict, no decision to
backport the feature in older languages mode,
so C17 and earlier are not modified and the
code point tables for these language modes are conserved.
Reviewed By: aaron.ballman
Differential Revision: https://reviews.llvm.org/D130416
Benjamin Kramer [Sat, 23 Jul 2022 11:25:23 +0000 (13:25 +0200)]
Simon Pilgrim [Sat, 23 Jul 2022 11:01:54 +0000 (12:01 +0100)]
[DAG] SimplifyDemandedBits - pull out repeated getValueType() calls. NFC.
Simon Pilgrim [Sat, 23 Jul 2022 10:13:37 +0000 (11:13 +0100)]
[DAG] ExpandIntRes_ADDSUB - create UADDO/USUBO instead of ADDCARRY/SUBCARRY if overflow is known to be zero
As noticed on D127115, when splitting ADD/SUB nodes we often end up with cases where overflow from the lower bits is impossible - in such cases we're better off breaking the carry chain dependency as soon as possible.
This path is being exercised by llvm/test/CodeGen/ARM/dsp-mlal.ll, although I haven't been able to get any codegen diff without a topological worklist.
Dimitrije Milosevic [Sat, 23 Jul 2022 08:24:15 +0000 (10:24 +0200)]
[MIPS][compiler-rt] Fix stat struct's size for O32 ABI
Add the MIPS O32 ABI value for the stat struct's size.
Differential Revision: https://reviews.llvm.org/D129749.
Simon Pilgrim [Sat, 23 Jul 2022 08:46:30 +0000 (09:46 +0100)]
[DAG] computeKnownBits - add basic shift-by-parts handling
Concat KnownBits from ISD::SHL_PARTS / ISD::SRA_PARTS / ISD::SRL_PARTS lo/hi operands and perform the KnownBits calculation by the shift amount on the extended type, before splitting the KnownBits based on the requested lo/hi result.