Dmitry Eremin [Wed, 4 Nov 2015 18:40:00 +0000 (13:40 -0500)]
staging: lustre: fix buffer overflow of string buffer
Buffer overflow of string buffer due to non null terminated string.
Use strlcpy() when it's justifiable.
Use sizeof(var) instead of constants.
Signed-off-by: Dmitry Eremin <dmitry.eremin@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629
Reviewed-on: http://review.whamcloud.com/9389
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
frank zago [Wed, 4 Nov 2015 18:39:59 +0000 (13:39 -0500)]
staging: lustre: remove libcfs_debug_set_level prototype from libcfs_private.h
The function libcfs_debug_set_level is used only internally so no reason
to expose it in libcfs_private.h. This is broken out from LU-5829 patch
http://review.whamcloud.com/13319.
Signed-off-by: frank zago <fzago@cray.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
frank zago [Wed, 4 Nov 2015 18:39:58 +0000 (13:39 -0500)]
staging: lustre: remove unnecessary EXPORT_SYMBOL in libcfs
A lot of symbols don't need to be exported at all because they are
only used in the module they belong to.
Signed-off-by: frank zago <fzago@cray.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5829
Reviewed-on: http://review.whamcloud.com/13319
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Liang Zhen [Wed, 4 Nov 2015 18:39:57 +0000 (13:39 -0500)]
staging: lustre: wrong parameter to cfs_hash_keycpy
cfs_hash_rehash_key() passed wrong parameter to cfs_hash_keycpy,
hnode should be the second parameter not the third one.
Signed-off-by: Liang Zhen <liang.zhen@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4362
Reviewed-on: http://review.whamcloud.com/8509
Reviewed-by: Bobi Jam <bobijam@gmail.com>
Reviewed-by: Johann Lombardi <johann.lombardi@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dan Carpenter [Tue, 3 Nov 2015 22:16:16 +0000 (01:16 +0300)]
staging: lustre: remove unused variable
The "->lr_lvb_data" struct member is never used. Delete it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aya Mahfouz [Thu, 29 Oct 2015 00:59:27 +0000 (02:59 +0200)]
staging: lustre: selftest.h: replace IS_PO2 by is_power_of_2
Replaces IS_PO2 by is_power_of_2. It is more accurate to use
is_power_of_2 since it returns 1 for numbers that are powers
of 2 only whereas IS_PO2 returns 1 for 0 and numbers that are
powers of 2.
Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aya Mahfouz [Thu, 29 Oct 2015 00:57:33 +0000 (02:57 +0200)]
staging: lustre: workitem.c: replace IS_PO2 by is_power_of_2
Replaces IS_PO2 by is_power_of_2. It is more accurate to use
is_power_of_2 since it returns 1 for numbers that are powers
of 2 only whereas IS_PO2 returns 1 for 0 and numbers that are
powers of 2.
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aya Mahfouz [Thu, 29 Oct 2015 00:54:09 +0000 (02:54 +0200)]
staging: lustre: ldlm_extent.c: replace IS_PO2 by is_power_of_2
Replaces IS_PO2 by is_power_of_2. It is more accurate to use
is_power_of_2 since it returns 1 for numbers that are powers
of 2 only whereas IS_PO2 returns 1 for 0 and numbers that are
powers of 2.
Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sunny Kumar [Fri, 6 Nov 2015 04:36:43 +0000 (10:06 +0530)]
staging: rdma: hfi1 : Prefer using the BIT macro
This patch replaces bit shifting on 1 with the BIT(x) macro
Signed-off-by: Sunny Kumar <sunnyk@cdac.in>
Acked-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amitoj Kaur Chawla [Wed, 4 Nov 2015 20:55:58 +0000 (02:25 +0530)]
staging: rdma: amso1100: c2: Remove wrapper function
This patch removes the c2_print_macaddr() wrapper function which calls
the pr_debug standard kernel function only.
c2_print_macaddr() has been replaced by directly calling pr_debug().
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Arthur Kepner [Thu, 5 Nov 2015 02:10:10 +0000 (21:10 -0500)]
staging/rdma/hfi1: optionally prescan rx queue for {B, F}ECNs - UC, RC
To more rapidly respond to Explicit Congestion Notifications, prescan the
receive queue, and process FECNs, and BECNs first. When a UC, or RC packet
containing a FECN, or BECN is found, immediately react to the ECN (either by
returning a CNP, or adjusting the injection rate). Afterward, the packet will
be processed normally.
Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Arthur Kepner <arthur.kepner@intel.com>
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Arthur Kepner [Thu, 5 Nov 2015 02:10:09 +0000 (21:10 -0500)]
staging/rdma/hfi1: don't cache "prescan head"
When HFI1_CAP_DMA_RTAIL is toggled off the "prescan head" can get out of sync
with the receive context's "head". This happens when, after prescan_rxq() newly
arrived packets are then received, and processed by an RX interrupt handler.
This is an unavoidable race, and to avoid getting out of sync we always start
prescanning at the current "rcd->head" entry.
Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Arthur Kepner <arthur.kepner@intel.com>
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mitko Haralanov [Fri, 30 Oct 2015 22:58:43 +0000 (18:58 -0400)]
staging/rdma/hfi1: Move macros to a common header
In preparation of implementing TID caching move EXP_TID macros to a common
header user_exp_rcv.h
Signed-off-by: Mitko Haralanov <mitko.haralanov@intel.com>
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mitko Haralanov [Fri, 30 Oct 2015 22:58:42 +0000 (18:58 -0400)]
staging/rdma/hfi1: Remove unnecessary include files
These includes were not used in file_ops.c
Signed-off-by: Mitko Haralanov <mitko.haralanov@intel.com>
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mitko Haralanov [Fri, 30 Oct 2015 22:58:41 +0000 (18:58 -0400)]
staging/rdma/hfi1: Clean up macro indentation
In preparation for implementing Expected TID caching we do some simple clean up
of header file macros.
Signed-off-by: Mitko Haralanov <mitko.haralanov@intel.com>
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ira Weiny [Fri, 30 Oct 2015 22:58:40 +0000 (18:58 -0400)]
staging/rdma/hfi1: Remove file pointer macros
Remove the following macros in favor of explicit use of struct hfi1_filedata and
various sub structures.
ctxt_fp
subctxt_fp
tidcursor_fp
user_sdma_pkt_fp
user_sdma_comp_fp
Reviewed-by: Mitko Haralanov <mitko.haralanov@intel.com>
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Fri, 6 Nov 2015 10:11:21 +0000 (19:11 +0900)]
staging: wilc1000: remove rates variable in host_int_add_station
Instead of using rates variable, it is used as add_sta_info->rates
directly.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Fri, 6 Nov 2015 10:11:20 +0000 (19:11 +0900)]
staging: wilc1000: use kmemdup in host_int_add_station
This patch replaces kmalloc followed by memcpy with kmemdup.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Fri, 6 Nov 2015 10:11:19 +0000 (19:11 +0900)]
staging: wilc1000: rename pstrAddStationMsg in host_int_add_station
This patch renames pstrAddStationMsg to add_sta_info to avoid camelcase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Fri, 6 Nov 2015 10:11:18 +0000 (19:11 +0900)]
staging: wilc1000: rename pstrStaParams in host_int_add_station
This patch renames pstrStaParams to sta_param to avoid camelcase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Fri, 6 Nov 2015 10:11:17 +0000 (19:11 +0900)]
staging: wilc1000: fix parameter name of host_int_add_station
This patch changes struct host_if_drv of host_int_add_station function
declaration from hWFIDrv to hif_drv.
With this change, first parameter of this function declaration and
definition has same name as hif_drv.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Fri, 6 Nov 2015 10:11:16 +0000 (19:11 +0900)]
staging: wilc1000: fix return type of host_int_add_station
This patch changes return type of host_int_add_station from s32 to int.
The result variable gets return value from wilc_mq_send that has return
type of int. It should be changed return type of this function as well
as data type of result variable.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Fri, 6 Nov 2015 10:11:15 +0000 (19:11 +0900)]
staging: wilc1000: rename pstrDelStationMsg in host_int_del_station
This patch renames pstrDelStationMsg to del_sta_info to avoid camelcase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Fri, 6 Nov 2015 10:11:14 +0000 (19:11 +0900)]
staging: wilc1000: rename pu8MacAddr in host_int_del_station
This patch changes pu8MacAddr to mac_addr that is second argument of
this function to avoid camelcase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Fri, 6 Nov 2015 10:11:13 +0000 (19:11 +0900)]
staging: wilc1000: fix parameter name of host_int_del_station
This patch changes struct host_if_drv of host_int_del_station function
declaration from hWFIDrv to hif_drv.
With this change, first parameter name of this function declaration and
definition has same name as hif_drv.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Fri, 6 Nov 2015 10:11:12 +0000 (19:11 +0900)]
staging: wilc1000: fix return type of host_int_del_station
This patch changes return type of host_int_del_station from s32 to int.
The result variable gets return value from wilc_mq_send that has return
type of int. It should be changed return type of this function as well
as data type of result variable.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Fri, 6 Nov 2015 10:11:11 +0000 (19:11 +0900)]
staging: wilc1000: fix parameter name of host_int_del_beacon
This patch changes struct host_if_drv of host_int_del_beacon function
declaration from hWFIDrv to hif_drv.
With this change, first parameter name of this function declaration and
definition has same name as hif_drv.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Fri, 6 Nov 2015 10:11:10 +0000 (19:11 +0900)]
staging: wilc1000: fix return type of host_int_del_beacon
This patch changes return type of host_int_del_beacon from s32 to int.
The result variable gets return value from wilc_mq_send that has return
type of int. It should be changed return type of this function as well
as data type of result variable.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Fri, 6 Nov 2015 09:40:23 +0000 (18:40 +0900)]
staging: wilc1000: remove os_private
This patch removes unused variable os_private and delete
struct wilc_wlan_os_context_t since there is no members in it. Remove it's
related code also.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Fri, 6 Nov 2015 09:40:22 +0000 (18:40 +0900)]
staging: wilc1000: change parameter type of hif_init
This patch changes parameter type wilc_wlan_inp_t with struct wilc and
modify it's related code. Pass wilc to the functions as well.
wilc will be used in later patch.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Fri, 6 Nov 2015 09:40:21 +0000 (18:40 +0900)]
staging: wilc1000: remove os_context
This patch removes variable os_context of wilc_sdio_t and wilc_spi_t because
os_context is not used, and delete it's related code.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Fri, 6 Nov 2015 09:40:20 +0000 (18:40 +0900)]
staging: wilc1000: linux_spi_init: remove parameter vp
This patch removes function parameter vp which is not used and modify it's
related codes.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Fri, 6 Nov 2015 09:40:19 +0000 (18:40 +0900)]
staging: wilc1000: linux_sdio_init: remove parameter pv
This patch removes function parameter pv which is not used and modify it's
related codes.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Fri, 6 Nov 2015 09:40:18 +0000 (18:40 +0900)]
staging: wilc1000: remove unused function pointer io_deinit
This patch removes function pointer io_deinit which is never used, and delete
it's related codes also.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Fri, 6 Nov 2015 09:40:17 +0000 (18:40 +0900)]
staging: wilc1000: remove function pointer io_init
This patch removes function pointer io_init of wilc_wlan_io_func_t and it's
related codes, and call the function linux_spi_init directly.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Fri, 6 Nov 2015 09:40:16 +0000 (18:40 +0900)]
staging: wilc1000: remove spi_max_speed of wilc_wlan_io_func_t
This patch removes spi_max_speed of wilc_wlan_io_func_t which is not used
anymore and removes union u and struct spi, which does not have members in it.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Fri, 6 Nov 2015 09:40:15 +0000 (18:40 +0900)]
staging: wilc1000: remove function pointer spi_max_speed
This patch removes function pointer spi_max_speed of wilc_spi_t and just call
the function linux_spi_set_max_speed directly.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Fri, 6 Nov 2015 09:40:14 +0000 (18:40 +0900)]
staging: wilc1000: remove spi_trx of wilc_wlan_io_func_t
This patch removes spi_trx of wilc_wlan_io_func_t which is not used anymore.
Delete it's related codes also.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Fri, 6 Nov 2015 09:40:13 +0000 (18:40 +0900)]
staging: wilc1000: remove function pointer spi_trx
This patch removes function pointer spi_trx and call linux_spi_write_read
directly.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Fri, 6 Nov 2015 09:40:12 +0000 (18:40 +0900)]
staging: wilc1000: remove function pointer spi_rx of wilc_wlan_io_func_t
This patch removes spi_rx of wilc_wlan_io_func_t and it's related codes since
it is not used anymore.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Fri, 6 Nov 2015 09:40:11 +0000 (18:40 +0900)]
staging: wilc1000: remove function pointer spi_rx of wilc_spi_t
This patch removes function pointer spi_rx of wilc_spi_t and just call
linux_spi_read instead.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Fri, 6 Nov 2015 09:40:10 +0000 (18:40 +0900)]
staging: wilc1000: remove function pointer spi_tx of wilc_wlan_io_function_t
This patch removes function pointer spi_tx of wilc_wlan_io_func_t because
it is not used anymore.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Fri, 6 Nov 2015 09:40:09 +0000 (18:40 +0900)]
staging: wilc1000: remove function pointer spi_tx of wilc_spi_t
This patch removes function pointer spi_tx of wilc_spi_t and call
linux_spi_write directly.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Fri, 6 Nov 2015 09:40:08 +0000 (18:40 +0900)]
staging: wilc1000: wilc_spi.c: add prefix wilc in all function name
This patch add prefix wilc for all functions name because the function name
such as spi_write, spi_read and spi_sync are same as linux spi function.
Hence, this should be done before restructuring wilc_spi.c and
linux_wlan_spi.c later.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Fri, 6 Nov 2015 09:40:07 +0000 (18:40 +0900)]
staging: wilc1000: call linux_sdio_init instead of io_init
Just call linux_sdio_init instead of io_init function pointer.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Fri, 6 Nov 2015 09:40:06 +0000 (18:40 +0900)]
staging: wilc1000: remove varialbe sdio_set_default_speed
This patch removes sdio_set_default_speed of wilc_wlan_io_func_t which is
not used anymore and also remove struct sdio since it is empty.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Fri, 6 Nov 2015 09:40:05 +0000 (18:40 +0900)]
staging: wilc1000: remove function pointer sdio_set_default_speed
This patch removes function pointer sdio_set_default_speed of wilc_sdio_t
and call linux_sdio_set_default_speed() directly.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Fri, 6 Nov 2015 09:40:04 +0000 (18:40 +0900)]
staging: wilc1000: remove sdio_set_max_speed
This patch removes sdio_set_max_speed of wilc_wlan_io_func_t which is not
used any more.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Fri, 6 Nov 2015 09:40:03 +0000 (18:40 +0900)]
staging: wilc1000: remove function pointer sdio_set_max_speed
This patch removes function pointer sdio_set_max_speed of wilc_sdio_t and
call the function directly.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Fri, 6 Nov 2015 09:40:02 +0000 (18:40 +0900)]
staging: wilc1000: remove sdio_cmd53 of wilc_wlan_io_func_t
This patch removes sdio_cmd53 of wilc_wlan_io_func_t which is not used.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Fri, 6 Nov 2015 09:40:01 +0000 (18:40 +0900)]
staging: wilc1000: remove function pointer sdio_cmd53
This patch removes function pointer sdio_cmd53 of wilc_sdio_t and just call
the function directly.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Fri, 6 Nov 2015 09:40:00 +0000 (18:40 +0900)]
staging: wilc1000: remove sdio_cmd52 of wilc_wlan_io_func_t
This patch removes sdio_cmd52 of wilc_wlan_io_func_t which is not used.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Fri, 6 Nov 2015 09:39:59 +0000 (18:39 +0900)]
staging: wilc1000: remove function pointer sdio_cmd52
This patch removes function pointer sdio_cmd52 of wilc_sdio_t and just call
the function directly.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Fri, 6 Nov 2015 09:39:58 +0000 (18:39 +0900)]
staging: wilc1000: separate hif_sdio and hif_spi into different module
hif_sdio and hif_spi objects are compiled all the time even though one of SPI
or SDIO is selected. This patch separates hif_sdio and hif_spi into different
modules using ifdef define.
After rework SPI and SDIO modules with only one hif interface, the define
WILC_SDIO will be removed. This is first path of this series.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:20:12 +0000 (11:20 +0900)]
staging: wilc1000: rename u8WidCnt of handle_cfg_param function
This patch renames u8WidCnt variable of handle_cfg_param function to wid_cnt
to avoid camelcase.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:20:11 +0000 (11:20 +0900)]
staging: wilc1000: rename strWIDList of handle_cfg_param function
This patch renames strWIDList variable of handle_cfg_param function to wid_list
to avoid camelcase.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:20:10 +0000 (11:20 +0900)]
staging: wilc1000: rename Handle_CfgParam function
This patch renames Handle_CfgParam function to handle_cfg_param
to avoid camelcase.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:20:09 +0000 (11:20 +0900)]
staging: wilc1000: rename Handle_GetMacAddress function
This patch renames Handle_GetMacAddress function to handle_get_mac_address
to avoid camelcase.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:20:08 +0000 (11:20 +0900)]
staging: wilc1000: rename Handle_SetMacAddress function
This patch renames Handle_SetMacAddress function to handle_set_mac_address
to avoid camelcase.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:20:07 +0000 (11:20 +0900)]
staging: wilc1000: rename Handle_get_IPAddress function
This patch renames Handle_get_IPAddress function to handle_get_ip_address
to avoid camelcase.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:20:06 +0000 (11:20 +0900)]
staging: wilc1000: rename Handle_set_IPAddress function
This patch renames Handle_set_IPAddress function to handle_set_ip_address
to avoid camelcase.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:20:05 +0000 (11:20 +0900)]
staging: wilc1000: rename Handle_SetOperationMode function
This patch renames Handle_SetOperationMode function to handle_set_operation_mode
to avoid camelcase.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:20:04 +0000 (11:20 +0900)]
staging: wilc1000: rename Handle_SetWfiDrvHandler function
This patch renames Handle_SetWfiDrvHandler function to handle_set_wfi_drv_handler
to avoid camelcase.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:20:03 +0000 (11:20 +0900)]
staging: wilc1000: rename Handle_SetChannel function
This patch renames Handle_SetChannel function to handle_set_channel
to avoid camelcase.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:20:02 +0000 (11:20 +0900)]
staging: wilc1000: remove typedef from wilc_hif_func_t
This patch removes typedef from the struct wilc_hif_func_t and
renames it to wilc_hif_func.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:20:01 +0000 (11:20 +0900)]
staging: wilc1000: remove typedef from wilc_cfg_rsp_t
This patch removes typedef from the struct wilc_cfg_rsp_t and
renames it to wilc_cfg_rsp.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:20:00 +0000 (11:20 +0900)]
staging: wilc1000: remove unused typedef wilc_wlan_cfg_func_t
This patch removes unused typedef wilc_wlan_cfg_func_t of wilc_wlan.h.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:19:59 +0000 (11:19 +0900)]
staging: wilc1000: remove typedef from wilc_cfg_frame_t
This patch removes typedef from the struct wilc_cfg_frame_t and
renames it to wilc_cfg_frame.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:19:58 +0000 (11:19 +0900)]
staging: wilc1000: fixes please don't use multiple blank lines
This patch fixes the checks reported by checkpatch.pl
for Please don't use multiple blank lines.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:19:57 +0000 (11:19 +0900)]
staging: wilc1000: fixes prefer using the BIT macro
This patch fixes the warning reported by checkpatch.pl
for prefer using the BIT macro.
And, removes unnecessary bit increase defines.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:19:56 +0000 (11:19 +0900)]
staging: wilc1000: wilc_wlan.h: alignment defines
This patch fixes alignment of defines.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:19:55 +0000 (11:19 +0900)]
staging: wilc1000: replace numeric type to kernel error type
This patch replaces numeric type to generic type by kernel style.
-5 -> -EIO
-105 -> -ENOBUFS
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:19:54 +0000 (11:19 +0900)]
staging: wilc1000: remove warnings line over 80 characters
This patch removes the warnings reported by checkpatch.pl
for line over 80 characters.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:19:53 +0000 (11:19 +0900)]
staging: wilc1000: fixes possible unnecessary 'out of memory' message
This patch fixes the warning reported by checkpatch.pl
for possible unnecessary 'out of memory' message
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:19:52 +0000 (11:19 +0900)]
staging: wilc1000: fixes space prohibited between function name and open parenthesis
This patch fixes the warning reported by checkpatch.pl
for space prohibited between function name and open parenthesis '('
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:19:51 +0000 (11:19 +0900)]
staging: wilc1000: rename tcp_PendingAck_index of struct txq_entry_t
This patch renames tcp_PendingAck_index of struct txq_entry_t to index
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:19:50 +0000 (11:19 +0900)]
staging: wilc1000: fixes alignment should match open parenthesis
This patch fixes the checks reported by checkpatch.pl
for alignment should match open parenthesis.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:19:49 +0000 (11:19 +0900)]
staging: wilc1000: wilc_wlan.c: remove unused pointer variables
This patch removes unused two pointer variable.
- Free_head
- Alloc_head
It's pointer variables unused inside code.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:13:10 +0000 (11:13 +0900)]
staging: wilc1000: rename drvHandler in wilc_wlan_cfg_get function
This patch rename drvHandler to drv_handler that is fifth argument of
wilc_wlan_cfg_get function to avoid camelcase.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:13:09 +0000 (11:13 +0900)]
staging: wilc1000: rename drvHandler in wilc_wlan_cfg_set function
This patch rename drvHandler to drv_handler that is seventh argument of
wilc_wlan_cfg_set function to avoid camelcase.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:13:08 +0000 (11:13 +0900)]
staging: wilc1000: rename drvHandler in wilc_wlan_cfg_commit function
This patch rename drvHandler to drv_handler that is third argument of
wilc_wlan_cfg_commit function to avoid camelcase.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:13:07 +0000 (11:13 +0900)]
staging: wilc1000: fixes braces {} are not necessary for any arm of this statement
This patch fixes the warning reported by checkpatch.pl
for braces {} are not necessary for any arm of this statement
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:13:06 +0000 (11:13 +0900)]
staging: wilc1000: fixes braces {} should be used on all arms of this statement
This patch fixes the error reported by checkpatch.pl
for braces {} should be used on all arms of this statement
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:13:05 +0000 (11:13 +0900)]
staging: wilc1000: rename bValue in set_machw_change_vir_if function
This patch rename bValue to value that is second argument of
set_machw_change_vir_if function to avoid camelcase.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:13:04 +0000 (11:13 +0900)]
staging: wilc1000: fixes a struct allocation to match coding standards
This patch fixes the checks reported by checkpatch.pl
for prefer kmalloc(sizeof(*rqe)...) over kmalloc(sizeof(struct rxq_entry_t)...)
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:13:03 +0000 (11:13 +0900)]
staging: wilc1000: rename pBSSID variable
This patch rename the pBSSID variable to bssid
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:13:02 +0000 (11:13 +0900)]
staging: wilc1000: fixes else should follow close brace '}'
This patch fixes the error reported by checkpatch.pl
for else should follow close brace '}'
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:13:01 +0000 (11:13 +0900)]
staging: wilc1000: rename pu32TxqCount in wilc_wlan_handle_txq function
This patch rename pu32TxqCount to txq_count that is second argument of
wilc_wlan_handle_txq function to avoid camelcase.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:13:00 +0000 (11:13 +0900)]
staging: wilc1000: remove unused argument of chip_sleep_manually function
This patch removes u32SleepTime that is second argument of
chip_sleep_manually function because it is not used in this function.
Remove argument in the function call also.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:12:59 +0000 (11:12 +0900)]
staging: wilc1000: fixes a struct allocation to match coding standards
This patch fixes the checks reported by checkpatch.pl
for prefer kmalloc(sizeof(*tqe)...) over kmalloc(sizeof(struct txq_entry_t)...)
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:12:58 +0000 (11:12 +0900)]
staging: wilc1000: rename is_TCP_ACK_Filter_Enabled function
This patch rename the is_TCP_ACK_Filter_Enabled function to
is_tcp_ack_filter_enabled to avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:12:57 +0000 (11:12 +0900)]
staging: wilc1000: rename Enable_TCP_ACK_Filter function
This patch rename the Enable_TCP_ACK_Filter function to enable_tcp_ack_filter
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:12:56 +0000 (11:12 +0900)]
staging: wilc1000: rename EnableTCPAckFilter variable
This patch rename the EnableTCPAckFilter variable to enabled
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:12:55 +0000 (11:12 +0900)]
staging: wilc1000: rename Dropped variable
This patch rename the Dropped variable to dropped
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:12:54 +0000 (11:12 +0900)]
staging: wilc1000: remove warnings line over 80 characters
This patch removes the warnings reported by checkpatch.pl
for line over 80 characters.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:12:53 +0000 (11:12 +0900)]
staging: wilc1000: rename Ack_no variable
This patch rename the Ack_no variable to ack_no
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:12:52 +0000 (11:12 +0900)]
staging: wilc1000: rename Data_offset variable
This patch rename the Data_offset variable to data_offset
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:12:51 +0000 (11:12 +0900)]
staging: wilc1000: rename Total_Length variable
This patch rename the Total_Length variable to total_length
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:12:50 +0000 (11:12 +0900)]
staging: wilc1000: remove do-nothing else condition case.
This patch removes do-nothing else condition case.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Fri, 6 Nov 2015 02:12:49 +0000 (11:12 +0900)]
staging: wilc1000: rename Session_index member variable
This patch rename the Ack Session_index variable to session_index
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>