junov@chromium.org [Fri, 11 Jan 2013 21:04:40 +0000 (21:04 +0000)]
Adding commandline option to gm to make it write image results for tests that fails due to pixel mismatches.
Review URL: https://codereview.appspot.com/7100043
git-svn-id: http://skia.googlecode.com/svn/trunk@7143
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 11 Jan 2013 20:54:44 +0000 (20:54 +0000)]
Fix leaks in blurrect benchs and gm.
Review URL: https://codereview.appspot.com/7071060
git-svn-id: http://skia.googlecode.com/svn/trunk@7142
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Fri, 11 Jan 2013 20:45:24 +0000 (20:45 +0000)]
Enable per-tile logging in bench_pictures
- Modify bench_pictures buildstep to translate "key: True" --> "--key" rather
than requiring "key: value" --> "--key value"
- Add whacky TileArgs helper which includes "timeIndividualTiles: True"
Review URL: https://codereview.appspot.com/7092046
git-svn-id: http://skia.googlecode.com/svn/trunk@7141
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Fri, 11 Jan 2013 20:30:41 +0000 (20:30 +0000)]
Add option to render PDFs to memory only.
Review URL: https://codereview.appspot.com/7097045
git-svn-id: http://skia.googlecode.com/svn/trunk@7140
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 11 Jan 2013 20:02:32 +0000 (20:02 +0000)]
SkImageDecoder_WIC should work on Win7 with Win8 SDK.
https://codereview.appspot.com/7099044/
git-svn-id: http://skia.googlecode.com/svn/trunk@7139
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Fri, 11 Jan 2013 16:08:07 +0000 (16:08 +0000)]
Fix typo, report in validate diff teh value of the pixel, not the address of the pixel.
git-svn-id: http://skia.googlecode.com/svn/trunk@7135
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Fri, 11 Jan 2013 14:19:52 +0000 (14:19 +0000)]
Rebaselined webpage image GMs for ['base-macmini'] on Google Storage.
git-svn-id: http://skia.googlecode.com/svn/trunk@7130
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 11 Jan 2013 13:54:30 +0000 (13:54 +0000)]
Make GrEffect::textureAccess non-virtual. Require subclasses to append their GrTAs.
Review URL: https://codereview.appspot.com/7062063
git-svn-id: http://skia.googlecode.com/svn/trunk@7129
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 11 Jan 2013 13:54:21 +0000 (13:54 +0000)]
Remove non-destructive playback from GrIODB.
Review URL: https://codereview.appspot.com/7057070
git-svn-id: http://skia.googlecode.com/svn/trunk@7128
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 11 Jan 2013 02:01:25 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7127
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Fri, 11 Jan 2013 01:42:39 +0000 (01:42 +0000)]
Whitespace change to trigger rebuilds
git-svn-id: http://skia.googlecode.com/svn/trunk@7126
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 10 Jan 2013 19:55:18 +0000 (19:55 +0000)]
Rename onFilterImageGPU to filterImageGPU(), to match skia convention. No change in functionality.
(Note that this does mean that clients must override onFilterImage() to implement the raster path, but filterImageGPU() to implement the GPU path.)
Review URL: https://codereview.appspot.com/7058078
git-svn-id: http://skia.googlecode.com/svn/trunk@7123
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 10 Jan 2013 18:56:18 +0000 (18:56 +0000)]
DirectWrite generatePath must transform the path by the current matrix.
https://codereview.appspot.com/7061061/
This will require at least the shadertext2 gm for DirectWrite to be rebaselined.
git-svn-id: http://skia.googlecode.com/svn/trunk@7121
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 10 Jan 2013 18:54:11 +0000 (18:54 +0000)]
Add display of more SkPaint fields in Debugger
https://codereview.appspot.com/7060063/
git-svn-id: http://skia.googlecode.com/svn/trunk@7120
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 10 Jan 2013 17:11:27 +0000 (17:11 +0000)]
gm: if no readPath is given, report all tests as "missing reference image" instead of "passed"
Review URL: https://codereview.appspot.com/7070066
git-svn-id: http://skia.googlecode.com/svn/trunk@7119
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 10 Jan 2013 16:58:02 +0000 (16:58 +0000)]
Fix assertion caused by change in 7117.
SkRect::intersect returns false if either rectange is empty.
SkCanvas::quickReject returns true if an empty rectange is entirely contained within the clip bounds.
git-svn-id: http://skia.googlecode.com/svn/trunk@7118
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 10 Jan 2013 16:31:09 +0000 (16:31 +0000)]
Properly reject clipped out draws in BBox pictures.
https://codereview.appspot.com/7057065/
git-svn-id: http://skia.googlecode.com/svn/trunk@7117
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 10 Jan 2013 15:56:44 +0000 (15:56 +0000)]
gm self-test: update expected dashing2.png images (in inputs/ dir) to reflect new behavior
TBR=reed1
Review URL: https://codereview.appspot.com/7068060
git-svn-id: http://skia.googlecode.com/svn/trunk@7116
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 10 Jan 2013 15:47:41 +0000 (15:47 +0000)]
Update order in third_party/externals svn:externals property to match DEPS.
With the previous order a clean svn checkout fails to pull jsoncpp correctly.
git-svn-id: http://skia.googlecode.com/svn/trunk@7115
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 10 Jan 2013 14:40:28 +0000 (14:40 +0000)]
Remove default clip/drawstate in GrIODB.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7070064
git-svn-id: http://skia.googlecode.com/svn/trunk@7114
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 10 Jan 2013 02:01:29 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7113
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 9 Jan 2013 23:29:39 +0000 (23:29 +0000)]
Fix incorrect sample cnt assert
git-svn-id: http://skia.googlecode.com/svn/trunk@7112
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 9 Jan 2013 22:02:58 +0000 (22:02 +0000)]
Ensure that SkMemoryStream does not crash dereferencing fData.
SkMemoryStream attempts to dereference fData in multiple places.
Instead of allowing it to be NULL, resulting in a crash, set it
to SkData::NewEmpty().
Add a test for SkStream that will crash when its SkData is set to NULL.
Review URL: https://codereview.appspot.com/7061059
git-svn-id: http://skia.googlecode.com/svn/trunk@7111
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Wed, 9 Jan 2013 21:04:52 +0000 (21:04 +0000)]
This takes the convex path tesselator from the Android code and hooks it into a
GrPathRenderer. GrAndroidPathRenderer is activated by gyp flag 'skia_android_path_rendering'.
A few changes to get this to work:
- Had to change SkPaint* param to SkStrokeRec& in ConvexPathVertices()
- Had to copy the vertex buffer created by the Android code to GrDrawTarget-generated vertex buffer, and convert float alpha to GrColor for AA paths
git-svn-id: http://skia.googlecode.com/svn/trunk@7110
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Wed, 9 Jan 2013 18:22:53 +0000 (18:22 +0000)]
Add clear after each image save, so that GPU images won't end up progressively compositing on top of one another.
git-svn-id: http://skia.googlecode.com/svn/trunk@7108
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 9 Jan 2013 16:36:30 +0000 (16:36 +0000)]
fix iOS build after adding modifierKeys to click events
git-svn-id: http://skia.googlecode.com/svn/trunk@7107
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Wed, 9 Jan 2013 13:33:22 +0000 (13:33 +0000)]
Rebaselined webpage image GMs for ['base-shuttle-win7-intel-angle'] on Google Storage.
git-svn-id: http://skia.googlecode.com/svn/trunk@7100
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 9 Jan 2013 02:01:30 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7099
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Wed, 9 Jan 2013 00:59:11 +0000 (00:59 +0000)]
speculative change to speedup blurrect bench for large radius, to see if the bots are timing out
git-svn-id: http://skia.googlecode.com/svn/trunk@7098
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 8 Jan 2013 21:46:05 +0000 (21:46 +0000)]
Turn off WarnAsError when building ANGLE projects on windows.
git-svn-id: http://skia.googlecode.com/svn/trunk@7096
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 8 Jan 2013 20:40:22 +0000 (20:40 +0000)]
Turn off warnings-as-error on 64bit windows build due to many size_t-related warnings.
git-svn-id: http://skia.googlecode.com/svn/trunk@7095
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 8 Jan 2013 20:31:53 +0000 (20:31 +0000)]
Enable warnings-as-errors on Windows.
Review URL: https://codereview.appspot.com/7066054
git-svn-id: http://skia.googlecode.com/svn/trunk@7094
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Tue, 8 Jan 2013 18:47:31 +0000 (18:47 +0000)]
gm: remove --diffPath option and all other pixel diff functionality.
If you want pixel diffs, you need to run skdiff instead; from now on,
gm will only tell you WHETHER the images differed (not HOW they differed).
Review URL: https://codereview.appspot.com/7064047
git-svn-id: http://skia.googlecode.com/svn/trunk@7093
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 8 Jan 2013 18:42:20 +0000 (18:42 +0000)]
Fix signed/unsigned comparison in PictureTest.cpp
git-svn-id: http://skia.googlecode.com/svn/trunk@7092
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Tue, 8 Jan 2013 17:59:54 +0000 (17:59 +0000)]
Rebaselined webpage image GMs for ['base-android-xoom'] on Google Storage.
git-svn-id: http://skia.googlecode.com/svn/trunk@7091
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Tue, 8 Jan 2013 17:57:12 +0000 (17:57 +0000)]
Rebaselined webpage image GMs for %s on Google Storage.
git-svn-id: http://skia.googlecode.com/svn/trunk@7090
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Tue, 8 Jan 2013 17:52:58 +0000 (17:52 +0000)]
Rebaselined webpage image GMs for %s on Google Storage.
git-svn-id: http://skia.googlecode.com/svn/trunk@7089
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 8 Jan 2013 17:24:44 +0000 (17:24 +0000)]
Fix signed/unsigned comparison warning in PictureTest.cpp
git-svn-id: http://skia.googlecode.com/svn/trunk@7088
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 8 Jan 2013 16:50:52 +0000 (16:50 +0000)]
translate modifier keys for xevents
git-svn-id: http://skia.googlecode.com/svn/trunk@7087
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 8 Jan 2013 16:33:41 +0000 (16:33 +0000)]
Fix macro redefinition warning on 10.6 bots in mesa code.
R=humper@google.com
Review URL: https://codereview.appspot.com/7063050
git-svn-id: http://skia.googlecode.com/svn/trunk@7086
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 8 Jan 2013 16:25:42 +0000 (16:25 +0000)]
fix linux build
git-svn-id: http://skia.googlecode.com/svn/trunk@7085
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 8 Jan 2013 16:22:44 +0000 (16:22 +0000)]
fix win build
git-svn-id: http://skia.googlecode.com/svn/trunk@7084
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 8 Jan 2013 16:17:50 +0000 (16:17 +0000)]
pass modifier keys to click events (e.g. control | shift etc.)
Review URL: https://codereview.appspot.com/7062054
git-svn-id: http://skia.googlecode.com/svn/trunk@7082
2bbb7eff-a529-9590-31e7-
b0007b416f81
humper@google.com [Tue, 8 Jan 2013 16:08:01 +0000 (16:08 +0000)]
fix GPU drawing for 8 bit alpha bitmaps
BUG=
Review URL: https://codereview.appspot.com/7070052
git-svn-id: http://skia.googlecode.com/svn/trunk@7081
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Tue, 8 Jan 2013 15:56:15 +0000 (15:56 +0000)]
$(SVN_VERSION) -> $SVN_VERSION in build-tot-chromium.sh
Review URL: https://codereview.appspot.com/7071053
git-svn-id: http://skia.googlecode.com/svn/trunk@7080
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Tue, 8 Jan 2013 14:43:40 +0000 (14:43 +0000)]
Script to checkout and build ToT chromium with ToT skia
Review URL: https://codereview.appspot.com/7036049
git-svn-id: http://skia.googlecode.com/svn/trunk@7079
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 8 Jan 2013 13:45:09 +0000 (13:45 +0000)]
Proposed fix to new stroking/path render selection system
https://codereview.appspot.com/7075043/
git-svn-id: http://skia.googlecode.com/svn/trunk@7076
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 8 Jan 2013 13:23:32 +0000 (13:23 +0000)]
fix warings. add SkTAbs()
git-svn-id: http://skia.googlecode.com/svn/trunk@7075
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 8 Jan 2013 13:07:25 +0000 (13:07 +0000)]
fix spelling: cannonical -> canonical
git-svn-id: http://skia.googlecode.com/svn/trunk@7074
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Tue, 8 Jan 2013 02:11:58 +0000 (02:11 +0000)]
Rebaselined webpage image GMs for ['base-shuttle-win7-intel-float'] on Google Storage.
git-svn-id: http://skia.googlecode.com/svn/trunk@7073
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 8 Jan 2013 02:01:29 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7072
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 7 Jan 2013 22:26:05 +0000 (22:26 +0000)]
fix warnings
Review URL: https://codereview.appspot.com/7060053
git-svn-id: http://skia.googlecode.com/svn/trunk@7070
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 7 Jan 2013 21:54:25 +0000 (21:54 +0000)]
fix warnings (float to int), and convert to skia-style
style examples:
- use const: (const SkRect&) instead of (SkRect&)
- spacing: (Type& r) instead of ( Type &r )
- use SK_OVERRIDE
Review URL: https://codereview.appspot.com/7066051
git-svn-id: http://skia.googlecode.com/svn/trunk@7069
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 7 Jan 2013 20:51:13 +0000 (20:51 +0000)]
disable warnings-as-error for JSON code, which has warnings (at least on mac)
Review URL: https://codereview.appspot.com/7064053
git-svn-id: http://skia.googlecode.com/svn/trunk@7068
2bbb7eff-a529-9590-31e7-
b0007b416f81
humper@google.com [Mon, 7 Jan 2013 20:28:16 +0000 (20:28 +0000)]
disable werror on 64 bit
BUG=
Review URL: https://codereview.appspot.com/7057057
git-svn-id: http://skia.googlecode.com/svn/trunk@7066
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 7 Jan 2013 20:27:52 +0000 (20:27 +0000)]
abandon SK_IGNORE_TREAT_AS_SPRITE as a flag, and use SK_IGNORE_TRANS_CLAMP_FIX
for the fixes in SkDraw.cpp and SkBitmapProcState.cpp
Also, change the call in SkDraw.cpp to pass 0 for subpixel bits, to match the
old logic.... we should have a runtime fix for this in the future, so a caller
*can* get subpixel-filtered images w/ just translate.
git-svn-id: http://skia.googlecode.com/svn/trunk@7065
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 7 Jan 2013 20:25:04 +0000 (20:25 +0000)]
fix warnings
Review URL: https://codereview.appspot.com/7073044
git-svn-id: http://skia.googlecode.com/svn/trunk@7064
2bbb7eff-a529-9590-31e7-
b0007b416f81
humper@google.com [Mon, 7 Jan 2013 20:08:56 +0000 (20:08 +0000)]
fix warning in render pdf tool
BUG=
Review URL: https://codereview.appspot.com/7033056
git-svn-id: http://skia.googlecode.com/svn/trunk@7063
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 7 Jan 2013 20:07:48 +0000 (20:07 +0000)]
Revert part of r7047 to check Xoom failures
https://codereview.appspot.com/7070049/
git-svn-id: http://skia.googlecode.com/svn/trunk@7062
2bbb7eff-a529-9590-31e7-
b0007b416f81
humper@google.com [Mon, 7 Jan 2013 19:54:40 +0000 (19:54 +0000)]
fix warning from scalar --> int32 conversion
BUG=
Review URL: https://codereview.appspot.com/7065050
git-svn-id: http://skia.googlecode.com/svn/trunk@7061
2bbb7eff-a529-9590-31e7-
b0007b416f81
humper@google.com [Mon, 7 Jan 2013 19:02:46 +0000 (19:02 +0000)]
hopefully fix gyp mistake for iOS
BUG=
Review URL: https://codereview.appspot.com/7065052
git-svn-id: http://skia.googlecode.com/svn/trunk@7058
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Mon, 7 Jan 2013 18:41:28 +0000 (18:41 +0000)]
Cleaned up warnings in Windows build.
git-svn-id: http://skia.googlecode.com/svn/trunk@7057
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 7 Jan 2013 17:35:10 +0000 (17:35 +0000)]
Fix warning-as-error for var used only in an assert (and therefore not in the release build).
git-svn-id: http://skia.googlecode.com/svn/trunk@7054
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 7 Jan 2013 17:23:00 +0000 (17:23 +0000)]
Remove GrTDArray.
Two dynamic array classes is enough.
R=reed@google.com
Review URL: https://codereview.appspot.com/7069047
git-svn-id: http://skia.googlecode.com/svn/trunk@7053
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 7 Jan 2013 17:21:07 +0000 (17:21 +0000)]
Attempt to fix NULL to intptr_t warning-as-error on mac build.
git-svn-id: http://skia.googlecode.com/svn/trunk@7052
2bbb7eff-a529-9590-31e7-
b0007b416f81
humper@google.com [Mon, 7 Jan 2013 16:47:43 +0000 (16:47 +0000)]
eliminate all warnings in non-thirdparty code on mac
Most of these issues were due to functions whose definitions appear in header files; I changed those functions to be 'static inline' instead of just 'static' or 'inline', which kills the warning for such functions.
Other functions that were static or anonymous-namespaced but were unused in cpp files were probably called at some point but are no longer; someone who knows more than I do should probably scrub all the functions I either deleted or #if 0'ed out and make sure that the right thing is happening here.
Lots of unused variables removed, and one nasty const issue handled.
There remains a single warning in thirdparty/externals/cityhash/src/city.cc on line 146 related to a signed/unsigned mismatch. I don't know if we have control over this library so I didn't fix this one, but perhaps someone could do something about that one.
BUG=
Review URL: https://codereview.appspot.com/7067044
git-svn-id: http://skia.googlecode.com/svn/trunk@7051
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Mon, 7 Jan 2013 16:30:35 +0000 (16:30 +0000)]
Rebaselined webpage image GMs for ['base-android-xoom'] on Google Storage.
git-svn-id: http://skia.googlecode.com/svn/trunk@7050
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Mon, 7 Jan 2013 16:27:33 +0000 (16:27 +0000)]
Rebaselined webpage image GMs for %s on Google Storage.
git-svn-id: http://skia.googlecode.com/svn/trunk@7049
2bbb7eff-a529-9590-31e7-
b0007b416f81
humper@google.com [Mon, 7 Jan 2013 15:48:19 +0000 (15:48 +0000)]
Show the paint's typeface information in the details pane of the debugger.
Also add a convenience constructor for SkMemoryStream that takes the SkData directly
(instead of having to construct an empty one and call setData).
Review URL: https://codereview.appspot.com/7065045
git-svn-id: http://skia.googlecode.com/svn/trunk@7048
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Mon, 7 Jan 2013 14:26:40 +0000 (14:26 +0000)]
This CL introduces a new path renderer.
Here are the characteristics :
- It uses the original path, before stroking
- It supports traight lines only (no curves)
- It supports butt or square caps only
- It supports miter or bevel joins only
- No AA support
Support for these will be added step by step later on.
A first pass at the benchmarks on my linux machine gave me these approximate speed improvements (running all bench with the option '--forceAA 0') :
path_stroke_small_long_line 4X
path_stroke_small_sawtooth 4X
path_stroke_big_rect 4X
path_stroke_small_rect 6X
path_stroke_big_triangle 4X
path_stroke_small_triangle 10X
lines_1_BW 1.5X
dashline_2_square 1.5X
dashline_1_square 1.5X
Also note that I can't submit this code until GrDrawTarget::isOpaque() is implemented, unless I just disable my renderer completely for now.
BUG=chromium:135111
TEST=The following gms are affected and may require rebaselining : lineclosepath, linepath, strokes_poly
Review URL: https://codereview.appspot.com/7026049
git-svn-id: http://skia.googlecode.com/svn/trunk@7047
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 7 Jan 2013 13:17:18 +0000 (13:17 +0000)]
shape ops work in progress
cubic to quadratic experiment
git-svn-id: http://skia.googlecode.com/svn/trunk@7046
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 7 Jan 2013 00:58:00 +0000 (00:58 +0000)]
re-add SkRefPtr to SkRefCnt.h until all uses of it have been removed from Chrome
git-svn-id: http://skia.googlecode.com/svn/trunk@7044
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Sun, 6 Jan 2013 02:06:03 +0000 (02:06 +0000)]
Whitespace change to trigger rebuilds
git-svn-id: http://skia.googlecode.com/svn/trunk@7043
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Sat, 5 Jan 2013 14:37:48 +0000 (14:37 +0000)]
Fix the computed (new) inverse matrix when we detect that a shader's matrix
can effectively be consider translate-only.
Review URL: https://codereview.appspot.com/7060043
git-svn-id: http://skia.googlecode.com/svn/trunk@7039
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 5 Jan 2013 02:02:05 +0000 (02:02 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7038
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 4 Jan 2013 23:06:44 +0000 (23:06 +0000)]
move include of src/effects into general, and out of gpu-specific
git-svn-id: http://skia.googlecode.com/svn/trunk@7037
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 4 Jan 2013 23:02:50 +0000 (23:02 +0000)]
disable some new tests until we debug an rtree failure
git-svn-id: http://skia.googlecode.com/svn/trunk@7036
2bbb7eff-a529-9590-31e7-
b0007b416f81
humper@google.com [Fri, 4 Jan 2013 20:29:03 +0000 (20:29 +0000)]
Added a new function to directly generate a blurred rectangle analytically.
Added two new microbenchmarks to demonstrate speedup over existing BlurSeparable approach.
Added new GM tests for blurred rectangles.
Review URL: https://codereview.appspot.com/7037050
git-svn-id: http://skia.googlecode.com/svn/trunk@7034
2bbb7eff-a529-9590-31e7-
b0007b416f81
vandebo@chromium.org [Fri, 4 Jan 2013 19:42:39 +0000 (19:42 +0000)]
Remove unused variable.
Review URL: https://codereview.appspot.com/7035062
git-svn-id: http://skia.googlecode.com/svn/trunk@7032
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Fri, 4 Jan 2013 19:41:13 +0000 (19:41 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@7031
2bbb7eff-a529-9590-31e7-
b0007b416f81
vandebo@chromium.org [Fri, 4 Jan 2013 19:31:24 +0000 (19:31 +0000)]
Remove SkRefPtr
(resubmit of https://codereview.appspot.com/7030059/)
TBR=junov@google.com
Review URL: https://codereview.appspot.com/7030065
git-svn-id: http://skia.googlecode.com/svn/trunk@7030
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 4 Jan 2013 18:52:16 +0000 (18:52 +0000)]
add SK_IGNORE_FAST_SCALEMATRIX_INVERT guard for new invert code
git-svn-id: http://skia.googlecode.com/svn/trunk@7025
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 4 Jan 2013 18:34:30 +0000 (18:34 +0000)]
Allow GrEffects with multiple textures.
It will work as long as the total number of textures sis less than GrDrawState::kNumStages. That will be fixed in a follow up CL.
Review URL: https://codereview.appspot.com/7040052
git-svn-id: http://skia.googlecode.com/svn/trunk@7023
2bbb7eff-a529-9590-31e7-
b0007b416f81
vandebo@chromium.org [Fri, 4 Jan 2013 18:11:21 +0000 (18:11 +0000)]
Revert "Remove SkRefPtr" - r7021
samplecode/ still needs to be updated.
Review URL: https://codereview.appspot.com/7032048
git-svn-id: http://skia.googlecode.com/svn/trunk@7022
2bbb7eff-a529-9590-31e7-
b0007b416f81
vandebo@chromium.org [Fri, 4 Jan 2013 17:59:42 +0000 (17:59 +0000)]
Remove SkRefPtr
Review URL: https://codereview.appspot.com/7030059
git-svn-id: http://skia.googlecode.com/svn/trunk@7021
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 4 Jan 2013 17:02:33 +0000 (17:02 +0000)]
special-case matrix invert for translate and scale
update unittest to use diff scale-x and scale-y values, and tests for non-invertible scale matrices
Review URL: https://codereview.appspot.com/7027055
git-svn-id: http://skia.googlecode.com/svn/trunk@7019
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 4 Jan 2013 16:33:44 +0000 (16:33 +0000)]
Fix Android texture cacheID issue (npot flag not generated correctly)
https://codereview.appspot.com/7042046/
git-svn-id: http://skia.googlecode.com/svn/trunk@7018
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 4 Jan 2013 15:46:42 +0000 (15:46 +0000)]
add matrixbench for invert_translate
git-svn-id: http://skia.googlecode.com/svn/trunk@7015
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Fri, 4 Jan 2013 15:29:06 +0000 (15:29 +0000)]
Fix Android compiler warnings.
Review URL: https://codereview.appspot.com/7040053
git-svn-id: http://skia.googlecode.com/svn/trunk@7014
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 4 Jan 2013 14:43:03 +0000 (14:43 +0000)]
add --exclude-config to opt out of 1 or more configs. This always is respected,
regardless of the ordering of --config and --exclude-config.
add --verbose [-v] to dump extra info, e.g. what configs are being run
changed --config to enforce a unique set of configs to be run, such that
--config 8888 --config 8888 results in just 1 run of 8888.
Review URL: https://codereview.appspot.com/7027053
git-svn-id: http://skia.googlecode.com/svn/trunk@7013
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 4 Jan 2013 14:04:08 +0000 (14:04 +0000)]
use DEF_BENCH to simplify registration
git-svn-id: http://skia.googlecode.com/svn/trunk@7012
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 4 Jan 2013 12:07:46 +0000 (12:07 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7010
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Fri, 4 Jan 2013 03:16:52 +0000 (03:16 +0000)]
reorder internal files, in preparation for refactoring. no functional change.
git-svn-id: http://skia.googlecode.com/svn/trunk@7009
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Fri, 4 Jan 2013 02:56:10 +0000 (02:56 +0000)]
remove dead code from SkPath::addOval
git-svn-id: http://skia.googlecode.com/svn/trunk@7008
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Thu, 3 Jan 2013 21:18:16 +0000 (21:18 +0000)]
shape ops work in progress
basic functionality works at this point
git-svn-id: http://skia.googlecode.com/svn/trunk@7004
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Thu, 3 Jan 2013 19:23:22 +0000 (19:23 +0000)]
* Extended skdiff to report alpha channel differences.
* Created a tools/tests/rebaseline.sh to copy output-actual into output-expected.
* Sample results are available here: http://www.corp.google.com/~rmistry/skia/gm-playback-windows/images-skdiff/
Review URL: https://codereview.appspot.com/7038048
git-svn-id: http://skia.googlecode.com/svn/trunk@7003
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 3 Jan 2013 15:29:03 +0000 (15:29 +0000)]
ran gm/tests/rebaseline.sh 5-6 times to update the self-test after 6984
git-svn-id: http://skia.googlecode.com/svn/trunk@6995
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 3 Jan 2013 15:22:40 +0000 (15:22 +0000)]
use SkTreatAsSprite in SkDraw (with guard for chrome if needed)
git-svn-id: http://skia.googlecode.com/svn/trunk@6994
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Thu, 3 Jan 2013 14:46:41 +0000 (14:46 +0000)]
Fix Windows warning: Changed implicit int32_t to SkScalar cast to explicit SkIntToScalar call.
git-svn-id: http://skia.googlecode.com/svn/trunk@6993
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Thu, 3 Jan 2013 13:55:15 +0000 (13:55 +0000)]
Yet another whitespace change
git-svn-id: http://skia.googlecode.com/svn/trunk@6991
2bbb7eff-a529-9590-31e7-
b0007b416f81