platform/upstream/coreclr.git
8 years agoMerge pull request #2225 from wtgodbe/prTestRun
William Godbe [Thu, 3 Dec 2015 20:04:53 +0000 (12:04 -0800)]
Merge pull request #2225 from wtgodbe/prTestRun

Mac tests will run automatically on PR

8 years agomac tests will run automatically on PR
William Godbe [Thu, 3 Dec 2015 20:04:05 +0000 (12:04 -0800)]
mac tests will run automatically on PR

8 years agoMerge pull request #2216 from hoyMS/master
Pat Gavlin [Thu, 3 Dec 2015 17:32:25 +0000 (09:32 -0800)]
Merge pull request #2216 from hoyMS/master

Porting CoreCLR JIT SelfHost tests

8 years agoMerge pull request #2210 from stephentoub/semaphore_in_mscorlib
Jan Kotas [Thu, 3 Dec 2015 16:41:17 +0000 (08:41 -0800)]
Merge pull request #2210 from stephentoub/semaphore_in_mscorlib

Port System.Threading.Semaphore from corefx to mscorlib

8 years agoMerge pull request #2205 from sergiy-k/executablememory
Sergiy Kuryata [Thu, 3 Dec 2015 07:20:22 +0000 (23:20 -0800)]
Merge pull request #2205 from sergiy-k/executablememory

Implement an allocator for executable (JIT) memory in PAL

8 years agoPorting the folloiwng CoreCLR JIT SelfHost tests:
Hongtao Yu [Wed, 2 Dec 2015 18:43:58 +0000 (10:43 -0800)]
Porting the folloiwng CoreCLR JIT SelfHost tests:

Jit\Methodical\arrays\dbg\arrres.exe
Jit\Methodical\arrays\rel\arrres.exe
Jit\Methodical\arrays\speed_dbg\arrres.exe
Jit\Methodical\arrays\speed_rel\arrres.exe

jit\methodical\explicit\basic\_dbgrefarg_c.csproj
jit\methodical\explicit\basic\_dbgrefarg_f4.csproj
jit\methodical\explicit\basic\_dbgrefarg_f8.csproj
jit\methodical\explicit\basic\_dbgrefarg_i1.csproj
jit\methodical\explicit\basic\_dbgrefarg_i2.csproj
jit\methodical\explicit\basic\_dbgrefarg_i4.csproj
jit\methodical\explicit\basic\_dbgrefarg_o.csproj
jit\methodical\explicit\basic\_dbgrefarg_s.csproj
jit\methodical\explicit\rotate\_dbgrotarg_double.csproj
jit\methodical\explicit\rotate\_dbgrotarg_float.csproj
jit\methodical\explicit\rotate\_dbgrotarg_objref.csproj
jit\methodical\explicit\rotate\_dbgrotarg_valref.csproj
jit\methodical\explicit\basic\_opt_dbgrefarg_c.csproj
jit\methodical\explicit\basic\_opt_dbgrefarg_f4.csproj
jit\methodical\explicit\basic\_opt_dbgrefarg_f8.csproj
jit\methodical\explicit\basic\_opt_dbgrefarg_i1.csproj
jit\methodical\explicit\basic\_opt_dbgrefarg_i2.csproj
jit\methodical\explicit\basic\_opt_dbgrefarg_i4.csproj
jit\methodical\explicit\basic\_opt_dbgrefarg_o.csproj
jit\methodical\explicit\basic\_opt_dbgrefarg_s.csproj
jit\methodical\explicit\rotate\_opt_dbgrotarg_double.csproj
jit\methodical\explicit\rotate\_opt_dbgrotarg_float.csproj
jit\methodical\explicit\rotate\_opt_dbgrotarg_objref.csproj
jit\methodical\explicit\rotate\_opt_dbgrotarg_valref.csproj
jit\methodical\explicit\basic\_opt_relrefarg_c.csproj
jit\methodical\explicit\basic\_opt_relrefarg_f4.csproj
jit\methodical\explicit\basic\_opt_relrefarg_f8.csproj
jit\methodical\explicit\basic\_opt_relrefarg_i1.csproj
jit\methodical\explicit\basic\_opt_relrefarg_i2.csproj
jit\methodical\explicit\basic\_opt_relrefarg_i4.csproj
jit\methodical\explicit\basic\_opt_relrefarg_o.csproj
jit\methodical\explicit\basic\_opt_relrefarg_s.csproj
jit\methodical\explicit\rotate\_opt_relrotarg_double.csproj
jit\methodical\explicit\rotate\_opt_relrotarg_float.csproj
jit\methodical\explicit\rotate\_opt_relrotarg_objref.csproj
jit\methodical\explicit\rotate\_opt_relrotarg_valref.csproj
jit\methodical\explicit\basic\_relrefarg_c.csproj
jit\methodical\explicit\basic\_relrefarg_f4.csproj
jit\methodical\explicit\basic\_relrefarg_f8.csproj
jit\methodical\explicit\basic\_relrefarg_i1.csproj
jit\methodical\explicit\basic\_relrefarg_i2.csproj
jit\methodical\explicit\basic\_relrefarg_i4.csproj
jit\methodical\explicit\basic\_relrefarg_o.csproj
jit\methodical\explicit\basic\_relrefarg_s.csproj

Porting the follwing test from CoreCLR JIT SelfHost:

jit\methodical\explicit\basic\_dbgrefarg_c.csproj
jit\methodical\explicit\basic\_dbgrefarg_f4.csproj
jit\methodical\explicit\basic\_dbgrefarg_f8.csproj
jit\methodical\explicit\basic\_dbgrefarg_i1.csproj
jit\methodical\explicit\basic\_dbgrefarg_i2.csproj
jit\methodical\explicit\basic\_dbgrefarg_i4.csproj
jit\methodical\explicit\basic\_dbgrefarg_o.csproj
jit\methodical\explicit\basic\_dbgrefarg_s.csproj
jit\methodical\explicit\rotate\_dbgrotarg_double.csproj
jit\methodical\explicit\rotate\_dbgrotarg_float.csproj
jit\methodical\explicit\rotate\_dbgrotarg_objref.csproj
jit\methodical\explicit\rotate\_dbgrotarg_valref.csproj
jit\methodical\explicit\basic\_opt_dbgrefarg_c.csproj
jit\methodical\explicit\basic\_opt_dbgrefarg_f4.csproj
jit\methodical\explicit\basic\_opt_dbgrefarg_f8.csproj
jit\methodical\explicit\basic\_opt_dbgrefarg_i1.csproj
jit\methodical\explicit\basic\_opt_dbgrefarg_i2.csproj
jit\methodical\explicit\basic\_opt_dbgrefarg_i4.csproj
jit\methodical\explicit\basic\_opt_dbgrefarg_o.csproj
jit\methodical\explicit\basic\_opt_dbgrefarg_s.csproj
jit\methodical\explicit\rotate\_opt_dbgrotarg_double.csproj
jit\methodical\explicit\rotate\_opt_dbgrotarg_float.csproj
jit\methodical\explicit\rotate\_opt_dbgrotarg_objref.csproj
jit\methodical\explicit\rotate\_opt_dbgrotarg_valref.csproj
jit\methodical\explicit\basic\_opt_relrefarg_c.csproj
jit\methodical\explicit\basic\_opt_relrefarg_f4.csproj
jit\methodical\explicit\basic\_opt_relrefarg_f8.csproj
jit\methodical\explicit\basic\_opt_relrefarg_i1.csproj
jit\methodical\explicit\basic\_opt_relrefarg_i2.csproj
jit\methodical\explicit\basic\_opt_relrefarg_i4.csproj
jit\methodical\explicit\basic\_opt_relrefarg_o.csproj
jit\methodical\explicit\basic\_opt_relrefarg_s.csproj
jit\methodical\explicit\rotate\_opt_relrotarg_double.csproj
jit\methodical\explicit\rotate\_opt_relrotarg_float.csproj
jit\methodical\explicit\rotate\_opt_relrotarg_objref.csproj
jit\methodical\explicit\rotate\_opt_relrotarg_valref.csproj
jit\methodical\explicit\basic\_relrefarg_c.csproj
jit\methodical\explicit\basic\_relrefarg_f4.csproj
jit\methodical\explicit\basic\_relrefarg_f8.csproj
jit\methodical\explicit\basic\_relrefarg_i1.csproj
jit\methodical\explicit\basic\_relrefarg_i2.csproj
jit\methodical\explicit\basic\_relrefarg_i4.csproj
jit\methodical\explicit\basic\_relrefarg_o.csproj
jit\methodical\explicit\basic\_relrefarg_s.csproj

Porting the folloiwng CoreCLR JIT SelfHost tests:

Jit\Methodical\arrays\dbg\arrres.exe
Jit\Methodical\arrays\rel\arrres.exe
Jit\Methodical\arrays\speed_dbg\arrres.exe
Jit\Methodical\arrays\speed_rel\arrres.exe

jit\methodical\explicit\basic\_dbgrefarg_c.csproj
jit\methodical\explicit\basic\_dbgrefarg_f4.csproj
jit\methodical\explicit\basic\_dbgrefarg_f8.csproj
jit\methodical\explicit\basic\_dbgrefarg_i1.csproj
jit\methodical\explicit\basic\_dbgrefarg_i2.csproj
jit\methodical\explicit\basic\_dbgrefarg_i4.csproj
jit\methodical\explicit\basic\_dbgrefarg_o.csproj
jit\methodical\explicit\basic\_dbgrefarg_s.csproj
jit\methodical\explicit\rotate\_dbgrotarg_double.csproj
jit\methodical\explicit\rotate\_dbgrotarg_float.csproj
jit\methodical\explicit\rotate\_dbgrotarg_objref.csproj
jit\methodical\explicit\rotate\_dbgrotarg_valref.csproj
jit\methodical\explicit\basic\_opt_dbgrefarg_c.csproj
jit\methodical\explicit\basic\_opt_dbgrefarg_f4.csproj
jit\methodical\explicit\basic\_opt_dbgrefarg_f8.csproj
jit\methodical\explicit\basic\_opt_dbgrefarg_i1.csproj
jit\methodical\explicit\basic\_opt_dbgrefarg_i2.csproj
jit\methodical\explicit\basic\_opt_dbgrefarg_i4.csproj
jit\methodical\explicit\basic\_opt_dbgrefarg_o.csproj
jit\methodical\explicit\basic\_opt_dbgrefarg_s.csproj
jit\methodical\explicit\rotate\_opt_dbgrotarg_double.csproj
jit\methodical\explicit\rotate\_opt_dbgrotarg_float.csproj
jit\methodical\explicit\rotate\_opt_dbgrotarg_objref.csproj
jit\methodical\explicit\rotate\_opt_dbgrotarg_valref.csproj
jit\methodical\explicit\basic\_opt_relrefarg_c.csproj
jit\methodical\explicit\basic\_opt_relrefarg_f4.csproj
jit\methodical\explicit\basic\_opt_relrefarg_f8.csproj
jit\methodical\explicit\basic\_opt_relrefarg_i1.csproj
jit\methodical\explicit\basic\_opt_relrefarg_i2.csproj
jit\methodical\explicit\basic\_opt_relrefarg_i4.csproj
jit\methodical\explicit\basic\_opt_relrefarg_o.csproj
jit\methodical\explicit\basic\_opt_relrefarg_s.csproj
jit\methodical\explicit\rotate\_opt_relrotarg_double.csproj
jit\methodical\explicit\rotate\_opt_relrotarg_float.csproj
jit\methodical\explicit\rotate\_opt_relrotarg_objref.csproj
jit\methodical\explicit\rotate\_opt_relrotarg_valref.csproj
jit\methodical\explicit\basic\_relrefarg_c.csproj
jit\methodical\explicit\basic\_relrefarg_f4.csproj
jit\methodical\explicit\basic\_relrefarg_f8.csproj
jit\methodical\explicit\basic\_relrefarg_i1.csproj
jit\methodical\explicit\basic\_relrefarg_i2.csproj
jit\methodical\explicit\basic\_relrefarg_i4.csproj
jit\methodical\explicit\basic\_relrefarg_o.csproj
jit\methodical\explicit\basic\_relrefarg_s.csproj

8 years agoMerge pull request #2202 from mikem8361/sosfixes
Mike McLaughlin [Thu, 3 Dec 2015 01:24:43 +0000 (17:24 -0800)]
Merge pull request #2202 from mikem8361/sosfixes

Some SOS fixes/cleanup (bpmd, setclrpath, setsostid).

8 years agoSome SOS fixes/cleanup (bpmd, setclrpath, setsostid).
Mike McLaughlin [Fri, 20 Nov 2015 02:13:25 +0000 (18:13 -0800)]
Some SOS fixes/cleanup (bpmd, setclrpath, setsostid).

Enable the module load notification when no module or methods are found.

setclrpath/setsostid print the current path/tid if no arguments. "setsostid -clear"
now clears the tid/os id mapping.

Added better exception hook to sos plugin to catch special CLRN exception. Before
multiple lldb "Exception breakpoints" where set each time bpmd added a new bp. Added
a "DoNotDeleteOrDisable" message to the exception breakpoint created.

Fix bpmd on release builds. RtlpRaiseException was being inlined and the ExceptionRecord
parameter was being optimized away causing the GetLastEventInformation api to failed
and the special CLRN exception to be ignored.

Add sos help support. "soshelp" displays help about a command.

8 years agoAddress code review feedback
Sergiy Kuryata [Wed, 2 Dec 2015 23:23:37 +0000 (15:23 -0800)]
Address code review feedback

8 years agoMerge pull request #2211 from wtgodbe/prTestRun
William Godbe [Wed, 2 Dec 2015 22:38:21 +0000 (14:38 -0800)]
Merge pull request #2211 from wtgodbe/prTestRun

Should allow for test suite runs on OSX on each PR

8 years agoFixed copyartifacts issue
William Godbe [Wed, 2 Dec 2015 22:37:13 +0000 (14:37 -0800)]
Fixed copyartifacts issue

8 years agoPort System.Threading.Semaphore from corefx to mscorlib
stephentoub [Wed, 2 Dec 2015 20:21:09 +0000 (15:21 -0500)]
Port System.Threading.Semaphore from corefx to mscorlib

In the full framework, System.Threading.Semaphore is defined in System.dll, which no longer exists in coreclr/corefx.  Thus Semaphore needs to be defined in either mscorlib in coreclr or in System.Threading.dll in corefx (either way it's exposed from the System.Threading contract).  Today it's implemented in System.Threading.dll in corefx, but this results in a very unnatural dependency on Unix from System.Threading.dll to libcoreclr's PAL layer.  This is because on Unix libcoreclr needs to emulate wait handles, and thus all of the implementation for a Win32 semaphore (for which Semaphore is a thin wrapper) is in libcoreclr.

To eliminate that unnatural dependency, this commit ports System.Threading.Semaphore to mscorlib.  It'll be type-forwarded as part of the System.Threading.dll partial facade.  A corresponding commit in corefx will remove all of the implementation from there.

8 years agoMerge pull request #2209 from wtgodbe/prTestRun
William Godbe [Wed, 2 Dec 2015 21:32:05 +0000 (13:32 -0800)]
Merge pull request #2209 from wtgodbe/prTestRun

Modifications to OS X PR test run

8 years agoAdded release
William Godbe [Wed, 2 Dec 2015 21:31:13 +0000 (13:31 -0800)]
Added release

8 years agoMerge pull request #2208 from wtgodbe/prTestRun
William Godbe [Wed, 2 Dec 2015 21:25:41 +0000 (13:25 -0800)]
Merge pull request #2208 from wtgodbe/prTestRun

resolved naming conflict

8 years agoresolved naming conflict
William Godbe [Wed, 2 Dec 2015 21:24:06 +0000 (13:24 -0800)]
resolved naming conflict

8 years agoMerge pull request #2199 from wtgodbe/prTestRun
William Godbe [Wed, 2 Dec 2015 20:06:25 +0000 (12:06 -0800)]
Merge pull request #2199 from wtgodbe/prTestRun

OS X tests should now be run with each PR

8 years agoFirst crack
William Godbe [Tue, 1 Dec 2015 23:51:29 +0000 (15:51 -0800)]
First crack

8 years agoImplement an allocator for executable (JIT) memory in PAL
Sergiy Kuryata [Wed, 2 Dec 2015 18:15:18 +0000 (10:15 -0800)]
Implement an allocator for executable (JIT) memory in PAL

This change improves performance of CoreCLR with Server GC enabled by
about 30% according to ASP.NET benchmarks on Linux. The table below shows
number of requests per second that an ASP.NET benchmark could handle on my
machine before and after the change.

Pipeline        Before          After           Improvement
16              230K Req/sec    305K Req/sec    33%
256             240K Req/sec    340K Req/sec    42%

The problem was that with Server GC enabled, the GC initialization code was
reserving a large chunck (about 18GB on my machine) of virtual address
space during runtime initialization. Unfortunately, due to implementation
details of MM on Linux, GC memory was located next to the location of
libcoreclr. As a result, the runtime could not allocate memory for JIT'ed
code close to the coreclr library. Because of that the JIT'ed code had to
use jump stubs to call functions from the runtime (which can become very
expensive, for example, for write barriers).

This change fixes this issue by implementing a simple allocator that tries
to reserve (during process startup) a chuck of virtual memory that is
located near the coreclr library (within 2GB range) that can be later used
for JIT'ed code.

8 years agoMerge pull request #2203 from dotnet-bot/from-tfs
Jan Kotas [Wed, 2 Dec 2015 18:07:38 +0000 (10:07 -0800)]
Merge pull request #2203 from dotnet-bot/from-tfs

Merge changes from TFS

8 years agoIntegrate GC fix to compensate for OS bug
Jan Kotas [Wed, 2 Dec 2015 17:03:26 +0000 (09:03 -0800)]
Integrate GC fix to compensate for OS bug

[tfs-changeset: 1553463]

8 years agoMerge pull request #2201 from dotnet-bot/from-tfs
Jan Kotas [Wed, 2 Dec 2015 10:52:29 +0000 (02:52 -0800)]
Merge pull request #2201 from dotnet-bot/from-tfs

Merge changes from TFS

8 years agoFix regression on desktop introduce by #2164
Jan Kotas [Wed, 2 Dec 2015 07:59:57 +0000 (23:59 -0800)]
Fix regression on desktop introduce by #2164

[tfs-changeset: 1553409]

8 years agoMerge pull request #2125 from wtgodbe/macRunTest
William Godbe [Tue, 1 Dec 2015 22:07:22 +0000 (14:07 -0800)]
Merge pull request #2125 from wtgodbe/macRunTest

runtest.sh now works on Mac as well as Linux

8 years agoruntest.sh now works on Mac as well as Linux
William Godbe [Fri, 20 Nov 2015 23:11:19 +0000 (15:11 -0800)]
runtest.sh now works on Mac as well as Linux

8 years agoMerge pull request #2194 from juergenhoetzel/pal-build-enable-ms-extensions
Jan Kotas [Tue, 1 Dec 2015 15:20:28 +0000 (07:20 -0800)]
Merge pull request #2194 from juergenhoetzel/pal-build-enable-ms-extensions

Enable Microsoft extensions for PAL compilation

8 years agoEnable Microsoft extensions for PAL compilation
Juergen Hoetzel [Mon, 30 Nov 2015 23:12:32 +0000 (00:12 +0100)]
Enable Microsoft extensions for PAL compilation

Clang 3.7 now requires passing the -fms-extensions flag to use the
__declspec language extension for declaration attributes.

Refs #2135

8 years agoMerge pull request #1671 from wtgodbe/QueryThreadCycleTime
William Godbe [Mon, 30 Nov 2015 22:13:26 +0000 (14:13 -0800)]
Merge pull request #1671 from wtgodbe/QueryThreadCycleTime

Implemented QueryThreadCycleTime (time.cpp) & GetThreadTimes (thread.…

8 years agoMerge pull request #2168 from pgavlin/EnvFileChange
Pat Gavlin [Mon, 30 Nov 2015 17:34:40 +0000 (09:34 -0800)]
Merge pull request #2168 from pgavlin/EnvFileChange

Clean up the CoreCLR test wrappers.

8 years agoMerge pull request #2180 from justinvp/charenumerator
Jan Kotas [Sat, 28 Nov 2015 13:59:05 +0000 (05:59 -0800)]
Merge pull request #2180 from justinvp/charenumerator

Remove duplicate code in CharEnumerator

8 years agoMerge pull request #2177 from juergenhoetzel/mismatched-new-delete
Jan Kotas [Sat, 28 Nov 2015 08:03:03 +0000 (00:03 -0800)]
Merge pull request #2177 from juergenhoetzel/mismatched-new-delete

Fix mismatched use of new and delete

8 years agoRemove duplicate code in CharEnumerator
Justin Van Patten [Sat, 28 Nov 2015 05:35:53 +0000 (21:35 -0800)]
Remove duplicate code in CharEnumerator

Change IEnumerator.Current to simply return Current, instead of
having duplicate code in both properties.

8 years agoFix mismatched use of new and delete
Juergen Hoetzel [Fri, 27 Nov 2015 22:11:00 +0000 (23:11 +0100)]
Fix mismatched use of new and delete

Clang > 2.7.0 emits warnings for mismatched uses of new and
delete (-Wmismatched-new-delete).

Refs #2135

8 years agoMerge pull request #2171 from manu-silicon/patch-1
Jan Kotas [Fri, 27 Nov 2015 06:36:55 +0000 (22:36 -0800)]
Merge pull request #2171 from manu-silicon/patch-1

Update cross compilation instructions

8 years agoUpdate cross compilation instructions
Manu [Thu, 26 Nov 2015 03:28:25 +0000 (12:28 +0900)]
Update cross compilation instructions

Provide exact instructions for installing the required packages to do
the cross compilation.

Add section about the manual change to the urcu header files as the fix
is only in later revisions of Ubuntu.

8 years agoMerge pull request #2169 from dotnet-bot/from-tfs
Aditya Mandaleeka [Thu, 26 Nov 2015 00:34:31 +0000 (16:34 -0800)]
Merge pull request #2169 from dotnet-bot/from-tfs

Merge changes from TFS

8 years agoMerge pull request #2162 from manu-silicon/patch-1
Jan Kotas [Wed, 25 Nov 2015 23:53:33 +0000 (15:53 -0800)]
Merge pull request #2162 from manu-silicon/patch-1

Use hkp protocol on port 80 to get mono

8 years agoIntegrate bug fixes from desktop
Jan Kotas [Wed, 25 Nov 2015 22:47:47 +0000 (14:47 -0800)]
Integrate bug fixes from desktop

[tfs-changeset: 1552157]

8 years agoMerge pull request #2167 from steveharter/StdArg
Jan Vorlicek [Wed, 25 Nov 2015 22:33:01 +0000 (23:33 +0100)]
Merge pull request #2167 from steveharter/StdArg

Fix unicode input on the command line

8 years agoMerge pull request #2138 from LLITCHEV/SysVTests
Lubomir Litchev [Wed, 25 Nov 2015 22:01:09 +0000 (14:01 -0800)]
Merge pull request #2138 from LLITCHEV/SysVTests

Fixes for Issues #s 2105 and 2106.

8 years agoMerge pull request #2166 from kyulee1/ildasm2
Jan Kotas [Wed, 25 Nov 2015 21:48:01 +0000 (13:48 -0800)]
Merge pull request #2166 from kyulee1/ildasm2

Enable ILDASM for Windows

8 years agoFix unicode input on the command line
Steve Harter [Wed, 25 Nov 2015 21:06:07 +0000 (15:06 -0600)]
Fix unicode input on the command line

8 years agoEnable ILDASM for Windows
Kyungwoo Lee [Tue, 24 Nov 2015 20:34:08 +0000 (12:34 -0800)]
Enable ILDASM for Windows

This enables building ILDASM with Cmake for Windows.
This ILDASM now depends on CoreCLR targeting cross-platform and thus I dropped some features like GUI/PDB -- default output is console.
Metadata related APIs in CoreCLR are directly exported, and used in ILDASM:
 MetaDataGetDispenser
 GetMetaDataInternalInterface
 GetMetaDataInternalInterfaceFromPublic
 GetMetaDataPublicInterfaceFromInternal
The code path is diverged by a definition FEATURE_CORECLR.
There are still Window specific components. Among others, resource file/dll generation is the one that should be ported.

8 years agoMerge pull request #2161 from jkotas/xunit-update
Jan Kotas [Wed, 25 Nov 2015 18:53:33 +0000 (10:53 -0800)]
Merge pull request #2161 from jkotas/xunit-update

Update xunit version to 2.1.0

8 years agoMerge pull request #2160 from alexandrnikitin/gentree-remove-duplication
Jan Kotas [Wed, 25 Nov 2015 18:38:45 +0000 (10:38 -0800)]
Merge pull request #2160 from alexandrnikitin/gentree-remove-duplication

Remove duplicate assignment in Compiler::gtNodeHasSideEffects

8 years agoClean up the CoreCLR test wrappers.
Pat Gavlin [Tue, 24 Nov 2015 23:40:03 +0000 (15:40 -0800)]
Clean up the CoreCLR test wrappers.

- Various simplifications to the Xunit wrapper and the test helper
- Allow the specification of the test env script and the CORE_ROOT
  directory at the command line on Windows.

8 years agoMerge pull request #2164 from janvorli/fix-wait-for-secondary-threads
Jan Kotas [Wed, 25 Nov 2015 16:09:13 +0000 (08:09 -0800)]
Merge pull request #2164 from janvorli/fix-wait-for-secondary-threads

Make app shutdown wait for secondary threads

8 years agoMake app shutdown wait for secondary threads
Jan Vorlicek [Wed, 25 Nov 2015 10:04:27 +0000 (11:04 +0100)]
Make app shutdown wait for secondary threads

This change makes the CoreCLR behavior the same as the desktop CLR
w.r.t. the app shutdown and secondary threads. Now the application
waits for secondary threads to exit before exiting.

8 years agoUse hkp protocol on port 80 to get mono
Manu [Wed, 25 Nov 2015 07:46:32 +0000 (16:46 +0900)]
Use hkp protocol on port 80 to get mono

Minor formatting to be consistent with the rest of the document.

8 years agoRemove duplicate assignment in Compiler::gtNodeHasSideEffects
Alexandr Nikitin [Wed, 25 Nov 2015 06:44:46 +0000 (08:44 +0200)]
Remove duplicate assignment in Compiler::gtNodeHasSideEffects

8 years agoUpdate auto-generated project.lock.json
Jan Kotas [Wed, 25 Nov 2015 06:33:48 +0000 (22:33 -0800)]
Update auto-generated project.lock.json

8 years agoUpdate xunit version to 2.1.0
Jan Kotas [Wed, 25 Nov 2015 06:00:18 +0000 (22:00 -0800)]
Update xunit version to 2.1.0

8 years agoMerge pull request #2156 from sergiy-k/disableconcurrentgc
Jan Kotas [Wed, 25 Nov 2015 02:17:04 +0000 (18:17 -0800)]
Merge pull request #2156 from sergiy-k/disableconcurrentgc

Don't enable Concurrent GC on Unix by default

8 years agoFixes for Issues #s 2105 and 2106.
Lubomir Litchev [Sun, 22 Nov 2015 18:41:34 +0000 (10:41 -0800)]
Fixes for Issues #s 2105 and 2106.

For issue 2105 after more analysis there might be a very rare situation
(since this is not hit by the tests we have in coreclr and corefx) where
(even though there are not XMM callee saved register on System V) a
circular dependency might occur when homing params passed in XMM
registers. Used the right instruction for doing copying of XMM reg to XMM
reg

For issue # 2106 make sure for 2 register passed struct to use the
already available scOtherReg in struct psiScope.

8 years agoMerge pull request #2152 from CarolEidt/ryujit-porting-doc
Carol Eidt [Wed, 25 Nov 2015 01:05:19 +0000 (17:05 -0800)]
Merge pull request #2152 from CarolEidt/ryujit-porting-doc

Document porting RyuJIT to different platforms

8 years agoDon't enable Concurrent GC on Unix by default
Sergiy Kuryata [Tue, 24 Nov 2015 22:28:33 +0000 (14:28 -0800)]
Don't enable Concurrent GC on Unix by default

This change temporary disables the code in Unix hosting APIs that switches Concurrent GC on by default on Unix because this feature is not supported yet and having this flag set causes a performance regression (this problem is tracked by issue https://github.com/dotnet/coreclr/issues/2155).

8 years agoMerge pull request #2154 from jashook/master
Jan Kotas [Tue, 24 Nov 2015 22:26:07 +0000 (14:26 -0800)]
Merge pull request #2154 from jashook/master

Small architecture specific changes to fix the build on linux arm64.

8 years agoSmall architecture specific changes to fix the build on linux arm64.
jashook [Tue, 24 Nov 2015 21:05:37 +0000 (13:05 -0800)]
Small architecture specific changes to fix the build on linux arm64.

8 years agoMerge pull request #2111 from davmason/master
David Mason [Tue, 24 Nov 2015 21:02:07 +0000 (13:02 -0800)]
Merge pull request #2111 from davmason/master

Porting EventSource from the nuget package to coreclr

8 years agoDocument porting RyuJIT to different platforms
Carol Eidt [Tue, 24 Nov 2015 20:25:32 +0000 (12:25 -0800)]
Document porting RyuJIT to different platforms

This document outlines the various RyuJIT components that must be modified
to port to a new platform.

8 years agoRestoring the fix to WriteEvent with null/empty arrays that was over written by my...
David Mason [Tue, 24 Nov 2015 19:26:50 +0000 (11:26 -0800)]
Restoring the fix to WriteEvent with null/empty arrays that was over written by my port.

8 years agoMerge remote-tracking branch 'upstream/master'
David Mason [Tue, 24 Nov 2015 19:20:29 +0000 (11:20 -0800)]
Merge remote-tracking branch 'upstream/master'

8 years agoMerge pull request #2149 from alexandrnikitin/optimizer-remove-unsed-var
Jan Kotas [Tue, 24 Nov 2015 19:12:14 +0000 (11:12 -0800)]
Merge pull request #2149 from alexandrnikitin/optimizer-remove-unsed-var

Remove unused variable from Optimizer Compiler::optHoistLoopExprsForTree method

8 years agoMerge pull request #2132 from AndyAyersMS/FixLinuxTestScript
Aditya Mandaleeka [Tue, 24 Nov 2015 19:01:42 +0000 (11:01 -0800)]
Merge pull request #2132 from AndyAyersMS/FixLinuxTestScript

Fix generated test script to properly check for debugger

8 years agoMerge pull request #2142 from steveharter/IcuPerf
Steve Harter [Tue, 24 Nov 2015 18:21:51 +0000 (12:21 -0600)]
Merge pull request #2142 from steveharter/IcuPerf

Improve DateTime.Parse performance by reducing string comparisons

8 years agoMerge pull request #2151 from dotnet-bot/from-tfs
Jan Kotas [Tue, 24 Nov 2015 17:36:42 +0000 (09:36 -0800)]
Merge pull request #2151 from dotnet-bot/from-tfs

Merge changes from TFS

8 years agoImprove DateTime.Parse performance by reducing string comparisons
Steve Harter [Fri, 20 Nov 2015 22:28:57 +0000 (16:28 -0600)]
Improve DateTime.Parse performance by reducing string comparisons

8 years agoOpen sourcing ILDASM
dotnet-bot [Tue, 24 Nov 2015 14:42:38 +0000 (06:42 -0800)]
Open sourcing ILDASM

[tfs-changeset: 1551732]

8 years agoMerge pull request #2148 from manu-silicon/build
Jan Kotas [Tue, 24 Nov 2015 11:43:31 +0000 (03:43 -0800)]
Merge pull request #2148 from manu-silicon/build

Build script now use current platform to compile

8 years agoMerge pull request #2147 from manu-silicon/minor
Jan Kotas [Tue, 24 Nov 2015 11:40:15 +0000 (03:40 -0800)]
Merge pull request #2147 from manu-silicon/minor

Consistency fix for shell variables

8 years agoRemove unused variable from Optimizer Compiler::optHoistLoopExprsForTree method
Alexandr Nikitin [Tue, 24 Nov 2015 10:52:03 +0000 (12:52 +0200)]
Remove unused variable from Optimizer Compiler::optHoistLoopExprsForTree method

8 years agoBuild script now use current platform to compile
Manu [Tue, 24 Nov 2015 02:58:58 +0000 (02:58 +0000)]
Build script now use current platform to compile

No need to specify the architecture to compile on Linux, we use
"uname -p" to infer it.
Removed __MSBuildBuildArch which was not really used, we can use
__BuildArch instead.
Added warning for x86.

8 years agoConsistency fix for shell variables
Manu [Mon, 23 Nov 2015 23:27:57 +0000 (08:27 +0900)]
Consistency fix for shell variables

Use 0 instead of false since later we compare it with 1.

8 years agoMerge pull request #2136 from gsfreema/docs
Jan Kotas [Mon, 23 Nov 2015 16:36:34 +0000 (08:36 -0800)]
Merge pull request #2136 from gsfreema/docs

Cleaning up Contributing Workflow documentation

8 years agoMerge pull request #2134 from jkotas/NO_CRT
Jan Kotas [Mon, 23 Nov 2015 16:35:16 +0000 (08:35 -0800)]
Merge pull request #2134 from jkotas/NO_CRT

Delete code under !NO_CRT define

8 years agoDelete code under !NO_CRT define
Jan Kotas [Sun, 22 Nov 2015 03:25:10 +0000 (19:25 -0800)]
Delete code under !NO_CRT define

It is always defined - even in internal builds

8 years agoCleaning up Contributing Workflow documentation
Gerald Scott Freeman [Sun, 22 Nov 2015 15:56:30 +0000 (10:56 -0500)]
Cleaning up Contributing Workflow documentation

The line 'Please following our commit messages guidance, below.' is
incorrect since the commit messages section is above.  To future proof
this line, I'm updating the line to provide a link to the Commit
Messages section.  Also, correcting 'Please following' to say 'Please
follow'.

8 years agoMerge pull request #2129 from maksqwe/GenTreeBoundsChk_fix
Chris McKinsey [Sat, 21 Nov 2015 23:06:01 +0000 (15:06 -0800)]
Merge pull request #2129 from maksqwe/GenTreeBoundsChk_fix

Fix GenTreeBoundsChk::gtThrowKind check in GenTree::Compare(). It was comparing the same field of op1 instead of op1 and op2.

8 years agoMerge pull request #2018 from AndyAyersMS/LessLogging
Jan Kotas [Sat, 21 Nov 2015 22:22:25 +0000 (14:22 -0800)]
Merge pull request #2018 from AndyAyersMS/LessLogging

Reduce volume of MSBuild logging when running tests via xunit

8 years agoMerge pull request #2133 from gsfreema/master
Jan Kotas [Sat, 21 Nov 2015 22:19:51 +0000 (14:19 -0800)]
Merge pull request #2133 from gsfreema/master

Fixing a grammar mistake in Documentation\README.md

8 years agoFixing a grammar mistake in Documentation\README.md
Gerald Scott Freeman [Sat, 21 Nov 2015 21:34:01 +0000 (16:34 -0500)]
Fixing a grammar mistake in Documentation\README.md

Simply using the correct conjugation of the verb 'support'.

8 years agoFix generated test script to properly check for debugger
Andy Ayers [Sat, 21 Nov 2015 19:15:48 +0000 (11:15 -0800)]
Fix generated test script to properly check for debugger

Also tried fixing the generated help to show that you need `=`. This should be conditional based on `HasParam` but since there is only one switch it works for now.

8 years agoFix GenTreeBoundsChk:: gtThrowKind check in GenTree::Compare()
Maks Naumov [Sat, 21 Nov 2015 14:57:26 +0000 (16:57 +0200)]
Fix GenTreeBoundsChk:: gtThrowKind check in GenTree::Compare()

8 years agoMerge pull request #2112 from ellismg/cache-ucollators
Stephen Toub [Sat, 21 Nov 2015 03:09:39 +0000 (22:09 -0500)]
Merge pull request #2112 from ellismg/cache-ucollators

Cache UCollators in a Locale

8 years agoMerge pull request #2127 from dotnet-bot/from-tfs
Jan Kotas [Sat, 21 Nov 2015 02:09:05 +0000 (18:09 -0800)]
Merge pull request #2127 from dotnet-bot/from-tfs

Merge changes from TFS

8 years agoMerge pull request #2117 from hickford/patch-1
Jan Kotas [Sat, 21 Nov 2015 00:34:14 +0000 (16:34 -0800)]
Merge pull request #2117 from hickford/patch-1

Add link from readme to CoreFX

8 years agoImplemented QueryThreadCycleTime (time.cpp) & GetThreadTimes (thread.cpp) for Unix...
William Godbe [Tue, 22 Sep 2015 21:42:37 +0000 (14:42 -0700)]
Implemented QueryThreadCycleTime (time.cpp) & GetThreadTimes (thread.cpp) for Unix and OS X, plus tests. Also added helper methods IsCurrentThread and GetThreadTimesInternal to time.cpp. Currently, GetThreadTimes returns all time as user time on Unix, since I don't yet know of a way to get user time and kernel time separately there.

8 years agoFix build breaks in desktop build
Jan Kotas [Fri, 20 Nov 2015 23:54:45 +0000 (15:54 -0800)]
Fix build breaks in desktop build

[tfs-changeset: 1550852]

8 years agoMerge pull request #2123 from stephentoub/cts_perf
Stephen Toub [Fri, 20 Nov 2015 23:32:59 +0000 (18:32 -0500)]
Merge pull request #2123 from stephentoub/cts_perf

Separate CancellationTokenSource linking into a derived class

8 years agoMerge pull request #2122 from adityamandaleeka/testArgsQuoteFix
Aditya Mandaleeka [Fri, 20 Nov 2015 23:19:12 +0000 (15:19 -0800)]
Merge pull request #2122 from adityamandaleeka/testArgsQuoteFix

Replace double quotes around test arguments with single quotes.

8 years agoMerge pull request #2096 from LLITCHEV/SysVTests
Lubomir Litchev [Fri, 20 Nov 2015 21:59:24 +0000 (13:59 -0800)]
Merge pull request #2096 from LLITCHEV/SysVTests

Fix for issue 2058.

8 years agoMerge pull request #2120 from kyulee1/osx
Jan Kotas [Fri, 20 Nov 2015 21:41:55 +0000 (13:41 -0800)]
Merge pull request #2120 from kyulee1/osx

Package spec for RyuJit on OSX

8 years agoMerge pull request #2121 from dotnet-bot/from-tfs
Jan Kotas [Fri, 20 Nov 2015 21:41:21 +0000 (13:41 -0800)]
Merge pull request #2121 from dotnet-bot/from-tfs

Merge changes from TFS

8 years agoCache UCollators in CompareInfo
Matt Ellis [Thu, 19 Nov 2015 23:00:20 +0000 (15:00 -0800)]
Cache UCollators in CompareInfo

Creating a UCollator is an expensive operation and we are presently
doing it on ever collation operation. We can improve this by caching
the UCollators we use for collation on the CompareInfo object itself.

This change introduces a new method GetSortHandle which gives back an
opaque wrapper which can be used in collation operations instead of a
culture name.

Internally we represent this is a struct holding the two types of
UCollators we care about (if we add additional collators per locale with
different options to handle other types of CompareOption flags, we can
cache these as well).  Collation methods can get a `const UCollator*`
reference from the sort handle which is safe to share across
threads (per the ICU Design Guidelines[1]).

Unfortunately, tracking the lifetime of the SortHandle itself is not as
straightfoward as I would like. Right now, we use a SafeHandle to wrap
the internal handle and rely on the finalizer of the class to clean up
the native resources. However this means that the following code sample
will create two finalizable objects:

```csharp
    var c1 = new CultureInfo("en-US").CompareInfo;
    var c2 = new CultureInfo("en-US").CompareInfo;
```

If this ends up being an issue, we could explore an approach where we
keep a cahce of SortHandles in managed code and pass out references to
that SortHandle which would let us share a single SortHandle for a given
locale across more than one CompareInfo object.

Wins are seeing in places where we previously did lots of string
comparisions in a tight loop (for example: dotnet/corefx#3811) moving
these operations down to ~6ms per iteration vs ~330ms on my local machine.

[1]: http://userguide.icu-project.org/design

8 years agoMerge pull request #2107 from pgavlin/SysVCleanup
Pat Gavlin [Fri, 20 Nov 2015 21:14:29 +0000 (13:14 -0800)]
Merge pull request #2107 from pgavlin/SysVCleanup

Small cleanups in SysV classification.

8 years agoSeparate CancellationTokenSource linking into a derived class
stephentoub [Fri, 20 Nov 2015 17:36:24 +0000 (12:36 -0500)]
Separate CancellationTokenSource linking into a derived class

The m_linkingRegistrations field is only used on CancellationTokenSource instances created by CreateLinkedTokenSource.  This commit creates a private LinkedCancellationTokenSource to contain that field and related logic, so that the field is pay for play.  This shaves off ~11% of normal CancellationTokenSource's memory consumption.

8 years agoReplace double quotes around test arguments with single quotes.
Aditya Mandaleeka [Fri, 20 Nov 2015 20:14:46 +0000 (12:14 -0800)]
Replace double quotes around test arguments with single quotes.

8 years agoFix build breaks in legacy build
Jan Kotas [Fri, 20 Nov 2015 18:58:46 +0000 (10:58 -0800)]
Fix build breaks in legacy build

[tfs-changeset: 1550765]

8 years agoAdded missing URL to .NET Foundation forums
Lee Coward [Fri, 20 Nov 2015 17:29:28 +0000 (09:29 -0800)]
Added missing URL to .NET Foundation forums

8 years agoGrammar fix-up
Lee Coward [Fri, 20 Nov 2015 17:27:24 +0000 (09:27 -0800)]
Grammar fix-up