John Corbally [Wed, 2 Oct 2019 16:31:55 +0000 (17:31 +0100)]
Fix relaxed precision and no perspective dEQP tests
In the RelaxedPrecision case, change epsilon to 2e-3 for a 16-bit float.
In the NoPerspective case, change epsilon to 3e-7 for a 32-bit float.
The epsilon is now relative to the correct value.
Affects:
dEQP-VK.spirv_assembly.instruction.graphics.cross_stage.interface_blocks.*
Components: Vulkan
VK-GL-CTS issue: 1818
Change-Id: Id21382ce4b1cb58458ec3fb521630ab75e1910a3
Matthew Netsch [Fri, 4 Oct 2019 21:09:39 +0000 (17:09 -0400)]
Fixes VS num instances assumption
Components: Vulkan
VK-GL-CTS Issue: 2022
Affects:
dEQP-VK.spirv_assembly.instruction.graphics.variable_pointers.graphics.writes*
Change-Id: Ie1d784733774ae357698cf8a5672fcccdb0c1e1e
Eric Werness [Fri, 16 Nov 2018 21:50:40 +0000 (13:50 -0800)]
Support Python3 as well in gen_release_info.py
The CMake file version check can end up picking python3 in some cases -
making the Python code compatible with python3 seems easier than
adjusting the version check.
Components: Frameworks
Change-Id: Iab37090ab813dcb7839490225ca2a4bf2f721c12
Marcin Kańtoch [Mon, 23 Sep 2019 16:41:58 +0000 (18:41 +0200)]
Add check if usage is supported for image format
dEQP-VK.image.swapchain_mutable* tests do not check
if the required usage is supported for image format
and image view format.
Components: Vulkan
Affects:
dEQP-VK.image.swapchain_mutable*
VK-GL-CTS issue: 2015
Change-Id: I6680d9e6ef1b03462afa01349b6f34d82ef40a17
Chris Forbes [Thu, 26 Sep 2019 14:51:32 +0000 (07:51 -0700)]
Exclude dEQP-VK.ssbo.layout.random.scalar.75 from Android CTS
This is already excluded from the Khronos mustpass lists.
VK-GL-CTS Issue: 1829
Google bug: b/
141657868
Google bug: b/
135200048
Components: Android
Change-Id: I6b453819314cc2e8245ac9d518ef4b481fe90887
Lingfeng Yang [Thu, 15 Aug 2019 22:41:23 +0000 (15:41 -0700)]
1d_image: enforce height 1 in decompress stage as well
Affects:
dEQP-VK.image.texel_view_compatible.compute.basic.1d_image*
Components: Vulkan
VK-GL-CTS issue: 1920
Change-Id: Id98f0a8dd132da5bcd6a3f1426021c8f36a48149
Yahan Zhou [Wed, 7 Aug 2019 19:44:50 +0000 (12:44 -0700)]
1d_image: basic: compute: texel_view_compatible: set size.y to 1
1d images need to have size.y=1. Otherwise Vulkan validation layer will
complain.
Affects:
dEQP-VK.image.texel_view_compatible.compute.basic.1d_image*
Components: Vulkan
VK-GL-CTS issue: 1920
Change-Id: I0dd24d612aafb416a74b5eb6f16bb55c76175a0f
Yahan Zhou [Fri, 9 Aug 2019 18:35:15 +0000 (11:35 -0700)]
Texel view compatible: Image: proper check for image format supports
The queried image usage is different from what is acutally used. Fix it
so that we would not end up with an unsupported usage.
Affects:
dEQP-VK.image.texel_view_compatible*
Components: Vulkan
Google bug:
139193497
VK-GL-CTS issue: 1920
Change-Id: Ib8db61808db5f9391a54b7722f965b6608e7e694
Stephen Gallimore [Thu, 18 Jul 2019 16:48:41 +0000 (17:48 +0100)]
Correct handling of independentResolveNone
Some depth/stencil resolve tests are incorrectly reported
as unsupported, when the device's supported features include
independentResolveNone but not independentResolve.
Affects:
dEQP-VK.renderpass2.depth_stencil_resolve.*
VK-GL-CTS Issue: 1882
Components: Vulkan
Change-Id: I51f3fbf1447084a052e8f57a5726435f7947384e
Chris Forbes [Wed, 14 Aug 2019 02:46:32 +0000 (19:46 -0700)]
Avoid timeouts in dEQP-VK.api.device_init.create_instance_device_intentional_alloc_fail
Components: Vulkan
Affects: dEQP-VK.api.device_init.create_instance_device_intentional_alloc_fail
VK-GL-CTS Issue: 1919
Google bug: b/
139391065
Change-Id: Id5f20ef22147431aef2eabb97f2c7ef5171ed2ae
Matthew Netsch [Wed, 28 Aug 2019 16:17:00 +0000 (12:17 -0400)]
Reduce long execution time in spirv_asm float16
Components: Vulkan
VK-GL-CTS Issue: 1959
Affects:
dEQP-VK.spirv_assembly.instruction.graphics.float16.*
Change-Id: Iddfa825ffe5bf32607043eb31b517dbba1ff62dc
Yanjun Zhang [Wed, 28 Aug 2019 00:35:26 +0000 (17:35 -0700)]
Fix pixels_resolution computation in GLSL shader
branch: vulkan-cts-1.1.3
Components: Vulkan
Affects:
dEQP-VK.image.texel_view_compatible.graphic.extended.*
VK-GL-CTS issue: 1890
Change-Id: I4aa3270545e0b873bdc8baacaf1fc3947004d003
Lingfeng Yang [Wed, 21 Aug 2019 15:45:10 +0000 (08:45 -0700)]
external fence tests: account for sync fd -1 in multiple export case
Spec allows for sync fd == -1 to be returned from vkGetFenceFdKHR
as a signal that the fence is signaled.
VK-GL-CTS issue: 1937
Components: Vulkan
Affects:
dEQP-VK.api.external.fence.sync_fd.export_multiple_times_temporary
Change-Id: I7391d180bdc1a585c7b57930fc1750d13f7151e1
(cherry picked from commit
e266d2f1ee82d20c06c3c48064f60ac4fecd8b1d)
Matthew Netsch [Mon, 26 Aug 2019 16:26:12 +0000 (12:26 -0400)]
Adds cubic filter to allowed ycbcr format features
Components: Vulkan
VK-GL-CTS Issue: 1938
Affects:
dEQP-VK.api.info.format_properties.*
Change-Id: I9f32b902820d7a50db9ae51a5ba61f8bab9042ba
Matthew Netsch [Wed, 21 Aug 2019 15:43:35 +0000 (11:43 -0400)]
Fixes stencil load/store flags in renderpass tests
Components: Vulkan
VK-GL-CTS Issue: 1939
Affects:
dEQP-VK.renderpass*.simple.*stencil
Change-Id: I042c08b9bee6ba00ea3237e24f3fb6b2f1aebd9b
Matthew Netsch [Wed, 14 Aug 2019 11:08:32 +0000 (16:38 +0530)]
Split compute workload into multiple submissions
Reduces workload per submission
Components: Vulkan
VK-GL-CTS Issue: 1751
Affects:
dEQP-VK.memory_model.message_passing.*
Change-Id: Ia9e9b63851b18ae1d5c1b65426ee864d760bf87c
Panagiotis Apostolou [Thu, 25 Jul 2019 10:29:18 +0000 (12:29 +0200)]
Add pipeline barriers flushing buffer data to host
This commit adds a few buffer pipeline barriers whose purpose is to flush
gpu caches, making the buffer data visible to the host.
Affects:
dEQP-VK.pipeline.push_constant.compute_pipeline.simple_test
dEQP-VK.glsl.builtin.precision.*
dEQP-VK.glsl.builtin.function.*
dEQP-VK.api.command_buffers.record_simul_use_secondary_one_primary
dEQP-VK.synchronization.op.single_queue.*
dEQP-VK.query_pool.occlusion_query.*
Components: Vulkan
VK-GL-CTS issue: 1898
Change-Id: Ic6a467b4d1db6cebebf34c8d386e519016fc3fe9
Alexander Galazin [Wed, 14 Aug 2019 11:52:47 +0000 (13:52 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: I7f00708e05e1cf20c6439e52287d21eacf32ca01
Stephen Gallimore [Wed, 31 Jul 2019 15:24:57 +0000 (16:24 +0100)]
Add result buffer invalidates to depth stencil resolve tests
Components: Vulkan
VK-GL-CTS issue: 1907
Affects: dEQP-VK.renderpass2.depth_stencil_resolve.*
Change-Id: I90920f6005b0d6a72a78c588f4c3abec81826516
Chris Forbes [Sun, 28 Jul 2019 20:34:13 +0000 (13:34 -0700)]
Add missing checks for sampleShading feature
These cases were missed in the previous pass as they were masked by the
(correct) check for fragmentStoresAndAtomics.
Components: Vulkan
Affects: dEQP-VK.glsl.builtin_var.*
VK-GL-CTS Issue: 1901
Change-Id: I4d19c5075d14f60ead4c6df6370fffc870cde68a
Ari Suonpaa [Tue, 23 Apr 2019 11:57:47 +0000 (14:57 +0300)]
Make random number usage platform independent
Generating multiple random numbers in argument
list can happen in different order depending on
implementation. This change makes these happen
in the same order with all implementations.
Affects:
dEQP-VK.api.granularity.*
dEQP-VK.draw.basic_draw.*
dEQP-VK.protected_memory.*
dEQP-VK.glsl.builtin.function.common.*
dEQP-VK.glsl.builtin.function.pack_unpack.*
dEQP-VK.glsl.texture_gather.*
dEQP-VK.spirv_assembly.*
dEQP-GLES3*.functional.shaders.builtin_functions.common.*
Components: Vulkan, OpenGL, Framework
(cherry picked from commit
0106f01209fe7abb7f4daf029318a1de17844c48)
VK-GL-CTS issue: 1591
Change-Id: Iaaff9625fd331ed7184efd50b89fc835c701ac6f
Arkadiusz Sarwa [Wed, 24 Jul 2019 10:41:42 +0000 (12:41 +0200)]
Fixes 64bit random values for 32bit CTS build
In 32bit build a 64bit random value is assigned
to 32bit value what cause different path of execution.
Components: Vulkan
VK-GL-CTS Issue: 1895
Affects:
dEQP-VK.memory.pipeline_barrier.all.*
Change-Id: I1f51b8b30be9a70ae82326609bc382431b8f3b80
Panagiotis Apostolou [Fri, 12 Jul 2019 09:25:43 +0000 (11:25 +0200)]
Pipeline barriers flushing buffer data to host
Adds pipeline barriers after vkCmdDispatch which essentially flushes gpu
caches and the buffer data becomes visible to the host.
Affects:
dEQP-VK.spirv_assembly.instruction.compute.*
dEQP-VK.spirv_assembly.instruction.graphics.opspecconstantop_opquantize.*
Components: Vulkan
VK-GL-CTS issue: 1880
Change-Id: Ib99a4ed9a1a2d57b286dea2251b3bc4a67002dfb
Boris Zanin [Mon, 8 Jul 2019 13:27:50 +0000 (15:27 +0200)]
Remove conformance version test from Android
Removes conformance version tests from android CTS.
Split tests designed to validate VK_KHR_driver_properties
into several smaller tests.
Add three more records into knownDriverIds.
Add:
* dEQP-VK.api.driver_properties.*
Remove:
* dEQP-VK.api.driver_properties
Components: vulkan
VK-GL-CTS issue: 1839
Change-Id: I9b591778c9833fd890c9af46cb87d9f5eb695dbd
Mike Byrne [Mon, 1 Jul 2019 10:53:36 +0000 (11:53 +0100)]
Fix Android WSI incremental present image tests
The pipeline for Android WSI incremental present image tests was not
provided with a valid scissor rect. This caused the tests to perform
incorrectly (and violates Vulkan requirements).
Affects: dEQP-VK.wsi.android.incremental_present.*
VK-GL-CTS Issue: 1867
Change-Id: I257ab8ae59a13e24fb299b6b47e925f3c105aecb
Components: Vulkan, AOSP
Alex Walters [Thu, 11 Jul 2019 14:17:53 +0000 (15:17 +0100)]
Exclude dEQP-VK.ssbo.layout.random.scalar.75
Remove dEQP-VK.ssbo.layout.random.scalar.75 from mustpass, added to
excluded test list. The shader length is quite extreme resulting in an
overly high runtime where certain devices can easily hit the watchdog.
Affects:
dEQP-VK.ssbo.layout.random.scalar.75
Components: Vulkan
VK-GL-CTS Issue: 1829
Change-Id: I57627fc895ed4a0e023e9f81e0cc6cdc203d2485
Yiwei Zhang [Sat, 22 Jun 2019 02:14:25 +0000 (19:14 -0700)]
Split shared_presentable_image tests into more dimensions to avoid timeout
Components: Vulkan
VK-GL-CTS Issue: 1842
Affects: dEQP-VK.wsi.*.shared_presentable_image.*
Change-Id: I957c106b756fab4be5b17f7d0a6d9ad2a14fce75
Mike Byrne [Mon, 24 Jun 2019 06:44:23 +0000 (07:44 +0100)]
Fix Android WSI shared presentable image test OOM
The dEQP-VK.wsi.android.shared_presentable_image.scale_down tests fail
intermittently with OOM errors. A simliar fix as implemented for
WSI incremental presentable image tests resolves this.
Affects: dEQP-VK.wsi.android.shared_presentable_image.scale_down.*
Components: Vulkan, AOSP
VK-GL-CTS Issue: 1858
Change-Id: Iee7a31560e46b6c449d14ec6e7c75d7406ae6d82
Mike Byrne [Tue, 25 Jun 2019 13:39:53 +0000 (14:39 +0100)]
Fix Android WSI shared presentable image tests
The pipeline for Android WSI shared presentable image tests was not
provided with a valid scissor rect. This caused the tests to perform
incorrectly (and violates Vulkan requirements).
Affects:
dEQP-VK.wsi.android.shared_presentable_image.scale_down.demand
dEQP-VK.wsi.android.shared_presentable_image.scale_down.continuous
VK-GL-CTS Issue: 1857
Change-Id: I060c12d7192945ecbe01dfcc8e89c03874b9b218
Components: Vulkan, AOSP
Mika Väinölä [Tue, 9 Apr 2019 13:28:45 +0000 (16:28 +0300)]
Fix Clang 8 and GCC 9 warnings
Rename some TYPE_LAST and STATE_LAST enums that produce variable
shadowing warnings with Clang 8. Reimplement tcu::Format::Hex methods
using stringstream and IO manipulators instead of format strings
and add a cast to deUint32 to fix warnings on GCC 9.
Component: Framework
VK-GL-CTS issue: 1631
Change-Id: Ide4b25c106810b725c5ed7caaaf676f02e81b368
(cherry picked from commit
31dd7a0b3c38181ebdaf10bdc95f8c591734c342)
Chris Forbes [Fri, 14 Jun 2019 19:38:05 +0000 (12:38 -0700)]
Fix sample read tests to use sample rate shading
- The first shader uses gl_SampleID, so needs to run with sample rate
shading.
- Require the sampleRateShading device feature
Affects: dEQP-VK.renderpass*.sampleread.*
Components: Vulkan
VK-GL-CTS Issue: 1832
Change-Id: Ic99ac60581a546deb674db273d6438af8b5b7595
Alex Walters [Tue, 11 Jun 2019 15:42:33 +0000 (16:42 +0100)]
Fix image_extent test to handle OOM errors
The image_extent tests attempt to create a window with the maximum
supported extents, though it is not always possible to create such
a window due to platform memory constraints.
As long as the error was an out of memory error, allow the test to
pass. This fix only applies to the image_extent sub-test.
Affects:
dEQP-VK.wsi.*.swapchain.create.image_extent
Components: Vulkan
VK-GL-CTS issue: 1780
Change-Id: I5ac5439417424d101f6dc8d4f92da79b8fda2313
Chris Forbes [Mon, 3 Jun 2019 14:38:47 +0000 (07:38 -0700)]
Check for toplevel sparse binding support bit in sparse pipeline tests
VK-GL-CTS Issue: 1806
Components: Vulkan
Bug: b/
130838280
Affects: dEQP-VK.pipeline.multisample.*sparse
Change-Id: I18f0960228e24dddcfee6d85c2c4ae647439a3c6
Alexander Galazin [Thu, 6 Jun 2019 11:25:43 +0000 (13:25 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: Ie2fcbf82b366c324d4b48ddeaffd0b5654cf2d60
Yiwei Zhang [Tue, 4 Jun 2019 02:18:13 +0000 (19:18 -0700)]
Add a checker for vkQueuePresent returning VK_SUBOPTIMAL_KHR
Components: Vulkan
VK-GL-CTS Issue: 1811
Affects: dEQP-VK.wsi.*
Affects: dEQP-VK.protected_memory.interaction.wsi.*
Change-Id: I81320fb9fee34c6d1ec006d0a66d482eb2f8fb7c
Chris Forbes [Mon, 3 Jun 2019 17:45:28 +0000 (10:45 -0700)]
Fix more sampleShading issues in dEQP-VK.pipeline.multisample_shader_builtin.*
The `pattern` case here does not require per-sample shading, and the
request for the feature is easily disabled. The `write` case could
potentially also run without per-sample shading, but is plumbed
differently, so I have not adjusted it to run per-pixel.
All remaining cases which used per-sample shading have been
adjusted to check for the sampleShading feature efore running.
VK-GL-CTS Issue: 1807
Affects: dEQP-VK.pipeline.multisample_shader_builtin.sample_mask.*
Components: Vulkan
Change-Id: Iab86205fa89ace6f55ad00ba3fc51e2745a28744
Martin Freebody [Fri, 24 May 2019 13:30:32 +0000 (14:30 +0100)]
Fix for SSBO offset alignment
Affects: dEQP-VK.ssbo.unsized_array_length.*
Components: Vulkan
VK-GL-CTS issue: 1796
Change-Id: I8953c2a58fe90a3165aa3255e542336a0c6d0a1e
(cherry picked from commit
eaa8fbf9c0e15e36e7c202947fbc13216761dbf6)
Yiwei Zhang [Thu, 16 May 2019 05:22:36 +0000 (22:22 -0700)]
Split incremental_present tests into more dimensions to avoid timeout
Components: Vulkan
VK-GL-CTS Issue: 1778
Affects: dEQP-VK.wsi.android.incremental_present.*
Bug:
132817706
Test: dEQP-VK.wsi.android.incremental_present.*
Change-Id: I54168fe61bda31654696fcfbd71b37ce29fc7ba4
Matthew Netsch [Tue, 28 May 2019 23:37:16 +0000 (19:37 -0400)]
Fixes protected memory swapchain image format oom
Some image format test cases (like the image extent cases)
could create configs too large for the protected heap
Components: Vulkan
VK-GL-CTS Issue: 1793
Affects:
dEQP-VK.protected_memory.interaction.wsi.android.swapchain.create.image_format
Change-Id: If98f43a85ff289d091e3bb7c75d998a666efac80
Chris Forbes [Tue, 28 May 2019 16:32:39 +0000 (09:32 -0700)]
Require variablePointersStorageBuffer feature in pointer_parameter tests
These tests declare OpCapability VariablePointersStorageBuffer but don't
check for the feature.
Components: Vulkan
Affects: dEQP-VK.spirv_assembly.instruction.graphics.pointer_parameter.buffer_memory_variable_pointers*
VK-GL-CTS Issue: 1792
Change-Id: I81fb83b473c484b151caf212ecd2348c72494f1d
Matthew Netsch [Thu, 23 May 2019 13:06:45 +0000 (09:06 -0400)]
Fixes precise occlusion query tests
Individual test cases were not isolated
so they interfered with each other
Components: Vulkan
VK-GL-CTS Issue: 1784
Affects:
dEQP-VK.query_pool.occlusion_query.*precise*
Change-Id: I6ad422612c80c6aa5efc90fd90e0e7ce91e9f8bb
Alexander Galazin [Fri, 24 May 2019 07:48:11 +0000 (09:48 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: Ided1b0de70eddb65bb70983ed341435dc3a99621
Jeff Bolz [Fri, 7 Dec 2018 01:38:40 +0000 (19:38 -0600)]
Waiver for device-scope core memory model tests.
https://gitlab.khronos.org/Tracker/vk-gl-cts/issues/1356
Components: Vulkan
Affects: dEQP-VK.memory_model.*core11*.device.*
Change-Id: Ibf5d1ca0232471246ac16a9491d9ae54d87c74a8
Ilkka Saarelainen [Wed, 15 May 2019 12:01:14 +0000 (15:01 +0300)]
Add GeometryPointSize feature check
Some tests were using gl_PointSize without checking if the
shaderTessellationAndGeometryPointSize feature is supported and enabled.
This CL adds the feature checks to those tests. If the feature is not
supported/enabled, an alternative geometry shader code without
gl_PointSize will be used.
Affects:
dEQP-VK.glsl.*geometry
dEQP-VK.ycbcr.*geometry*
dEQP-VK.query_pool.*
dEQP-VK.transform_feedback.simple.streams_pointsize*
Components: Vulkan
VK-GL-CTS issue: 1763
Change-Id: If58bb5129144bae8d51dca84a3d0c89b46be1343
(cherry picked from commit
d4b80f34b70ae497b6bb0573859209ae28197a35)
Toni Merilehti [Wed, 15 May 2019 14:49:42 +0000 (17:49 +0300)]
Add feature checks to shader builtin tests
Some shader builtin tests use SampleId and SamplePosition BuiltIns
in shaders, which both require the SampleRateShading OpCapability
and the sampleRateShading Vulkan feature. This CL adds the missing
feature checks when required by the shaders.
Affects:
dEQP-VK.pipeline.multisample_shader_builtin.sample_id.*
dEQP-VK.pipeline.multisample_shader_builtin.sample_position.*
Components: Vulkan
VK-GL-CTS issue: 1744
Change-Id: I4557b5cd79191f7ca1202562416d12d3b1d8ce60
(cherry picked from commit
3f2ce1e5bcf568fe0a65a4ed638e0589b8694482)
Chris Forbes [Fri, 17 May 2019 15:48:42 +0000 (08:48 -0700)]
Check for imageCubeArray feature in image tests
Components: Vulkan
Affects: dEQP-VK.image.*cube_array*
VK-GL-CTS Issue: #1781
Change-Id: Idbf3e96481336820520a46293ca3eaf74b21654d
Chris Forbes [Thu, 16 May 2019 00:18:47 +0000 (17:18 -0700)]
Check for required features in memory model tests
All of these tests expect to be able to write to storage buffers; check
for the vertexPipelineStoresAndAtomics or fragmentStoresAndAtomics
features as appropriate.
VK-GL-CTS Issue: 1777
Components: Vulkan
Affects: dEQP-VK.memory_model.*
Change-Id: I51adeda82ba7af22368c239a6abfc481479700f1
Bas Nieuwenhuizen [Thu, 2 May 2019 21:13:14 +0000 (23:13 +0200)]
Fix image sizes for formats that need a multiple of 2.
All these have in their format definition something like
"Images in this format must be defined with a width that is a multiple
of two."
in their format definition.
This patch makes sure we actually use even sizes for images with these
formats.
It is not ideal that I have to hardcode these lists but I don't know a
better source to get them from.
Affects:
dEQP-VK.api.invariance.random
Components: Vulkan
VK-GL-CTS issue: 1766
Change-Id: Ie19583db56e7ae483136e1fb4651ae625efb9c02
Alexander Galazin [Mon, 20 May 2019 09:40:23 +0000 (11:40 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: I782d2f2d769d92e11f7e558cdefb56d187fe53e6
Alexander Galazin [Mon, 20 May 2019 08:58:43 +0000 (10:58 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.1 into vk-gl-cts/vulkan-cts-1.1.2
Change-Id: I0fd601c9fc32f66eb7e45322801a930d4f33c4dc
Alexander Galazin [Mon, 20 May 2019 08:12:17 +0000 (10:12 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: Ib38bd02e2ed4c74ee845e19eb25b8de05fb0e312
Ari Suonpaa [Tue, 30 Apr 2019 10:36:09 +0000 (13:36 +0300)]
Check for largePoints feature and add 1px test variant
Pipeline multisample tests were using point size of 3
without checking for largePoints feature. Now the feature
is checked and a 1 pixel variant is also added.
Affects:
dEQP-VK.pipeline.multisample.*.primitive_point
New tests:
dEQP-VK.pipeline.multisample.*.primitive_point_1px
Components: Vulkan
VK-GL-CTS issue: 1739
Change-Id: I0eef68b8194a1026a98b19579d1d3c1b7f9c9cc7
(cherry picked from commit
c382ec855438509b201c4aa5eff6b730534f2f3c)
Boris Zanin [Thu, 16 May 2019 15:23:19 +0000 (17:23 +0200)]
Remove incorrect unroll_dont_unroll test
According SPIR-V validator: Unroll and DontUnroll
loop controls must not both be specified.
Remove tests:
* dEQP-VK.spirv_assembly.instruction.compute.loop_control.unroll_dont_unroll
Affects:
* dEQP-VK.spirv_assembly.instruction.compute.loop_control.*
VK-GL-CTS issue: 1779
Change-Id: Ib799f96a290bb08df1175f1dc6f6d212314665af
Chris Forbes [Wed, 15 May 2019 17:38:01 +0000 (10:38 -0700)]
Don't set sampleShadingEnable in dEQP-VK.pipeline.framebuffer_attachment.*
These tests don't need per-sample shading, and didn't check for whether
it was supported by the device.
Components: Vulkan
Affects: dEQP-VK.pipeline.framebuffer_attachment.*ms
VK-GL-CTS Issue: 1776
Change-Id: Ic8477262410e1531c1acabe494c2cf64c199dd6b
Lingfeng Yang [Fri, 8 Feb 2019 15:36:00 +0000 (07:36 -0800)]
Fix stack underflow in incremental present test
This uses the current object's m_queueFamilyIndex instead of a queue
family index that is on the stack, avoiding using a stale stack address
when the test runs.
VK-GL-CTS issue: 1585
Affects:
dEQP-VK.wsi.*.incremental_present.*
Components: Vulkan
Change-Id: I80228651b799d3444676cdcbf5cc845bcb195fe9
(cherry picked from commit
a268922558ed0c353a7d8b6845f8d6279b72af29)
Alexander Galazin [Thu, 9 May 2019 09:15:26 +0000 (11:15 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: I015156c0e368515b0cecc70775a82a5537baa341
Slawomir Cygan [Mon, 29 Apr 2019 11:45:02 +0000 (13:45 +0200)]
Fix regression in subgroups tests after merging
393912cd
This extends the additional verification to catch uninitialized memory from
commit
393912cd to tests added in 1.1.3, so after
393912cd.
This fixes regression that occured on master after
393912cd was merged.
Components: Vulkan
VK-GL-CTS Issue: 1757
Change-Id: Icb7fe91ee2839626d8ebc90ae2788f85b0e835b7
Affects: dEQP-VK.subgroups.basic.framebuffer.*tess*
Matthew Netsch [Thu, 25 Apr 2019 18:41:15 +0000 (14:41 -0400)]
Fixes linear support check for pipeline tests
Removes old workaround for certain formats
Components: Vulkan
VK-GL-CTS Issue: 1755
Affects:
dEQP-VK.pipeline.sampler.*
Change-Id: Ia35303f11132f84560f06c13c7a94e3f9be888db
Chris Forbes [Fri, 3 May 2019 20:53:14 +0000 (13:53 -0700)]
Check for depthBiasClamp feature before using it
VK-GL-CTS Issue: 1764
Affects: dEQP-VK.dynamic_state.rs_state.depth_bias_clamp
Change-Id: Iccd05a1eac2285125847a392c4065d36c88cb426
Chris Forbes [Wed, 1 May 2019 14:43:48 +0000 (07:43 -0700)]
Check for imageCubeArray support before using VK_IMAGE_VIEW_TYPE_CUBE_ARRAY
VK-GL-CTS Issue: 1761
Components: Vulkan
Affects: dEQP-VK.binding_model.shader_access.*cube_array*
Change-Id: I918227d1518c3d7f6cefd7931531aafb34fcf9f8
Alexander Galazin [Sun, 28 Apr 2019 08:36:59 +0000 (10:36 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: I71fc7f7b5ccaf55f0ad0ec40d4e0720bebbabb50
Graeme Leese [Tue, 9 Apr 2019 11:25:19 +0000 (12:25 +0100)]
Reduce expected precision of RGB10A2 filtering
The code in the YCbCr tests says that it was copied from the texture
explicit lod tests, but those tests give rgb10a2 a 'low' precision, not
'fp16'. Reduce the precision expected in the YCbCr tests.
Components: Vulkan
VK-GL-CTS Issue: 1731
Affects: dEQP-VK.ycbcr.*
dEQP-VK.protected_memory.interaction.ycbcr.*
Change-Id: Ib0ae233fc271ded2f9987fe448dcd351e509a0c4
(cherry picked from commit
5deebf4709ed3e2c3aaad3b8bb8703f236309b97)
Carl Ritson [Thu, 14 Mar 2019 16:25:30 +0000 (16:25 +0000)]
Fix memory initialisation in subgroups tests
Subgroup tests expand memory allocations to accommodate std140 layout
shaders; however, the extra memory is not initialised.
This changes initialisation to be based on the actually allocated
buffer size and adds additional verification to catch uninitialised
memory.
Affects:
dEQP-VK.subgroups.*
Components: Vulkan
VK-GL-CTS Issue: 1639
Change-Id: I0dfc0abb9bcbe63b5d1d5ad43e6fee99389fdfa2
Matthew Netsch [Wed, 24 Apr 2019 16:02:30 +0000 (12:02 -0400)]
Fixes pipeline tests to check for maxSamplerLodBias
Components: Vulkan
VK-GL-CTS Issue: 1750
Affects:
dEQP-VK.pipeline.sampler.*
Change-Id: I1ed594f0eb5cf8e249eda5eb31b114f1bfb93fd2
Alexander Galazin [Tue, 23 Apr 2019 18:10:25 +0000 (20:10 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: If4d754edf8a5c942ebf51fcbb3a71d87bfbc7856
Alexander Galazin [Tue, 23 Apr 2019 17:13:22 +0000 (19:13 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.1 into vk-gl-cts/vulkan-cts-1.1.2
Change-Id: I578c423d59f3c21357dd6f448f68cee5b46a98d0
Alexander Galazin [Tue, 23 Apr 2019 16:47:53 +0000 (18:47 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: I4e639df46cf1f19a0bde8a061fa54d0bc1f7732d
Boris Zanin [Thu, 11 Apr 2019 08:07:12 +0000 (10:07 +0200)]
Add float 16 calculation into FMA tests
Add one more calculation flavor into calculation
Float16 FMA tests.
Updates:
* dEQP-VK.spirv_assembly.instruction.compute.float16.arithmetic*.fma
* dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic*.fma*
Components: Vulkan
VK-GL-CTS issue: 1730
Change-Id: Ic3c378a75d23afcafb0f6ce7052351d70d4d30bc
(cherry picked from commit
67a010acd731667bcf067652d11ba494f0afff95)
Juan A. Suarez Romero [Mon, 15 Apr 2019 16:39:12 +0000 (16:39 +0000)]
Create YCbCr with PREDEFINED layout
This fixes validation errors due mismatch with the expected initial
layout.
Affects:
* dEQP-VK.ycbcr.conversion.*
Components: Vulkan
VK-GL-CTS issue: 1737
Change-Id: If30f5ebb73529850c6bbafcd8e42bed6143864c3
(cherry picked from commit
bcfe10d9aa5dbdb05296a5891e358b3581288845)
Chris Forbes [Mon, 15 Apr 2019 23:03:23 +0000 (16:03 -0700)]
Check for geometry shader support when testing adjacency topologies
Clipping tests would attempt to create pipelines using adjacency
topologies without checking for geometry shader support.
This seems to be a benign failure on most real implementations, but is a
VU violation.
Affects: dEQP-VK.clipping.clip_volume.*
VK-GL-CTS Issue: 1738
Change-Id: Iac6cfc6a669f2e533ce8ceaf4e7c2448b9fe4883
(cherry picked from commit
9c97d200e33e781ebb9f85df1195bcb84e013833)
ygole [Wed, 27 Mar 2019 11:38:37 +0000 (17:08 +0530)]
Add hasDisplay check after createWsiDisplay throws
Commit
b7efacd7b3 (Check if CTS has platform display for wsi-type) added
checks after createWsiDisplay failure to prevent reporting test failure
if native display for requested wsi-type isn't avaiable. This situation
can occur if vulkan driver supports multiple wsi extensions and only one
native display is available. Change did not fix all the places where
createWsiDisplay is called. The check is missing in file
vktImageMutableTests.cpp so fix it.
Affects: dEQP-VK.image.swapchain_mutable.*
Components: Vulkan, Framework
VK-GL-CTS issue: 1558
Change-Id: Iffc50a70ed48fb18c4d609c8d74b8e4615e4297d
(cherry picked from commit
984a7606ec93dfe90a17127357c7f0b0262bcd51)
Alexander Galazin [Fri, 22 Mar 2019 09:06:18 +0000 (10:06 +0100)]
Fix uninitialized variable reported by gcc 8.3
VK-GL-CTS issue: 1656
Components: Vulkan
Affects: dEQP-VK.sparse_resources.*
Change-Id: I298c795b05c0c204f04970da7a923f797c4478b8
(cherry picked from commit
1dadbfc46128054db7679bb662eba16b20a241c1)
Joan Orantos [Tue, 16 Apr 2019 13:42:20 +0000 (15:42 +0200)]
Fix element size for R16G16B16A16_UNORM.
The PlanarFormatDescription set for this format
was specifying 16 bytes instead of 8. This would
generate wrong input image on the test group
dEQP-VK.ycbcr.conversion.r16*
Components: Vulkan
Affects:
dEQP-VK.ycbcr.conversion.r16*
VK-GL-CTS issue: 1740
Change-Id: Ic364128febaa3b85b9ade767049e4f4f3f894357
Matthew Netsch [Fri, 5 Apr 2019 20:19:29 +0000 (16:19 -0400)]
Fixed buffer memory type for protected test
Components: Vulkan
VK-GL-CTS issue: 1727
Affects:
dEQP-VK.protected_memory.*
Change-Id: I07c5a57591f37aff558e3a634faa45ab33b2f776
Chris Forbes [Mon, 15 Apr 2019 23:03:23 +0000 (16:03 -0700)]
Check for geometry shader support when testing adjacency topologies
Clipping tests would attempt to create pipelines using adjacency
topologies without checking for geometry shader support.
This seems to be a benign failure on most real implementations, but is a
VU violation.
Affects: dEQP-VK.clipping.clip_volume.*
VK-GL-CTS Issue: 1738
Change-Id: Iac6cfc6a669f2e533ce8ceaf4e7c2448b9fe4883
Alexander Galazin [Thu, 11 Apr 2019 12:46:34 +0000 (14:46 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: I22ee52a20ef76af09b9e9ae5c4f7e8ee7073025c
Samuel Iglesias Gonsálvez [Fri, 5 Apr 2019 14:40:30 +0000 (16:40 +0200)]
Missing format checks for vertex attribute and color attachments in input_ouput tests
Input_output tests were not checking that the vertex attribute formats
were supported by the physical device. Added a similar check for the color
attachment.
Affects:
dEQP-VK.spirv_assembly.instruction.graphics.*input_output*
Components: Vulkan
VK-GL-CTS issue: 1726
Change-Id: I2987deeafc8d3cc119730993fcb30fb191be062c
Alexander Galazin [Fri, 5 Apr 2019 10:58:45 +0000 (12:58 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: I1e1913b4571e7a001879b3a0a597eafc0f48d828
Nikita Bart [Wed, 27 Mar 2019 13:13:00 +0000 (14:13 +0100)]
Handle BUFFER_DYNAMIC and UPDATE_AFTER_BIND interaction
"descriptorset_random" tests were violating the spec's requirement that
bindings with VK_DESCRIPTOR_BINDING_UPDATE_AFTER_BIND_BIT_EXT bit
cannot be used with BUFFER_DYNAMIC descriptor types in one set.
Testing of UPDATE_AFTER_BIND bindings is disabled
in order to conform to the requirement.
Fix validation of inline UBO with variable descriptor count
When used with variable descriptor count inline UBO's were read
and written out of allocated size, which is set in
VkDescriptorSetVariableDescriptorCountAllocateInfoEXT.descriptorCount
Components: Vulkan
Affects: dEQP-VK.binding_model.descriptorset_random.*
VK-GL-CTS issue: 1708
Change-Id: I9e97b701897961aedf8a746b72a1070ccd3b04e7
Alexander Galazin [Thu, 4 Apr 2019 18:52:02 +0000 (14:52 -0400)]
Merge "Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3" into vulkan-cts-1.1.3
Alexander Galazin [Thu, 4 Apr 2019 18:22:37 +0000 (20:22 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: I353dac50e06609d2783125bf22aee21f27c9939a
Anthony Pesch [Tue, 26 Mar 2019 16:24:17 +0000 (12:24 -0400)]
Fix buffer RAW hazards in MultiQueue synchronization tests
The MultiQueue tests emit barriers between command buffers for two reasons:
1. To express the data dependencies between different pipeline stages.
2. To transfer ownership of the resource between queue families.
The exclusive sharing mode tests need both of these barriers, while the
concurrent mode tests only need to describe the data dependency.
Previously, a barrier was only emitted for the exclusive tests, causing
the concurrent tests to not have a barrier expressing the data dependencies
between the pipeline stages. Now the data dependencies are described for
both the exlusive and concurrent tests, while the ownership transfer is
only performed for exclusive tests.
Affects: dEQP-VK.synchronization.op.multi_queue.*.write_*_read_*.buffer_*
Components: Vulkan
VK-GL-CTS issue: 1650
Change-Id: Ic3bc83a7dcab8686754aea5267afeb10090038d0
(cherry picked from commit
93dc8a343c7ea67a2c8ffb694b45ff44703fbe6f)
Piers Daniell [Wed, 3 Apr 2019 20:20:09 +0000 (14:20 -0600)]
Don't disown Win32 handle after import
For Win32 fences and semaphores, the Vulkan implementation does not take
ownership of the handle after import. It is up to the application to
maintain ownership while the handle is in use and to call
CloseHandle() after.
Affects:
dEQP-VK.api.external.*.opaque_win32*
Components: Vulkan
VK-GL-CTS issue: 1720
Change-Id: I4e26ef53c9bf27c30efd71992fd02a574f81b3a0
Alexander Galazin [Wed, 3 Apr 2019 07:17:40 +0000 (09:17 +0200)]
Whitelist Vulkan CTS 1.1.3.2
Components: Vulkan
Affects: dEQP-VK.api.driver_properties.properties
Change-Id: Ia9ecc8dad3b2a37212d19f1878abb02095c22298
Alexander Galazin [Fri, 29 Mar 2019 11:01:20 +0000 (12:01 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: Iac3d5efdad7fe20709154ca4ed6d05fdea11f8a8
Alexander Galazin [Fri, 29 Mar 2019 10:15:10 +0000 (11:15 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.1 into vk-gl-cts/vulkan-cts-1.1.2
Change-Id: Ic01781a17482429ea152af7df5ff752a2226b568
Igor Ostrowski [Tue, 12 Mar 2019 10:36:10 +0000 (11:36 +0100)]
Add handle compatibility check in win32 keyed mutex tests
Affects:
dEQP-VK.synchronization.win32_keyed_mutex.*
Components: Vulkan
VK-GL-CTS issue: 1669
Change-Id: I1ce4edae009d291100725fce9d87ae6ac826c4ae
Hsin-Hsiao Lin [Tue, 26 Mar 2019 08:14:02 +0000 (09:14 +0100)]
Do not expect bit-exact results on float
For float outputs annotated with RelaxedPrecision or with NoPerspective,
check them against an epsilon range, 6E-8, which is 0x0001 in fp16.
Affects:
dEQP-VK.spirv_assembly.instruction.graphics.cross_stage.basic_type.*
dEQP-VK.spirv_assembly.instruction.graphics.cross_stage.interface_blocks.*
Components: vulkan
VK-GL-CTS issue: 1670
Change-Id: I98454826a3f4afccd655b0228839970ba0213793
Alexander Galazin [Fri, 22 Mar 2019 20:11:55 +0000 (21:11 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: I4f48c3e9ca8593777c5a4ef6cd32050f8c839043
Alexander Galazin [Fri, 22 Mar 2019 20:10:39 +0000 (21:10 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.1 into vk-gl-cts/vulkan-cts-1.1.2
Change-Id: I328cee295acc9eb8c5204e5f3574879d9e21a609
Alexander Galazin [Fri, 22 Mar 2019 19:49:07 +0000 (20:49 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: If24571c09fd321c8417da919af0d2272a0ac2c57
Tony Zlatinski [Tue, 12 Feb 2019 16:50:28 +0000 (10:50 -0600)]
cmake: Add support for PNG_ARM_NEON_OPT NDK-r19
On Android, here is clang compiler change for
NDKs after ndk-r17c where the compiler intrinsics
for libpng are not part of the compiler for the
armeabi-v7a targets.
Add the supported png functions for these compiler
intrinsics, explicitly for 32-bit ARM builds.
Affects:
dEQP-VK.*
Components: Vulkan, Framework
VK-GL-CTS issue: 1638
Change-Id: Ib832f983294f5dd747720ed4a79a21e29a06f776
(cherry picked from commit
99a88af740c425bf250ce9cb2143aa6be3a778f2)
Alexander Galazin [Fri, 22 Mar 2019 15:25:50 +0000 (16:25 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.1 into vk-gl-cts/vulkan-cts-1.1.2
Change-Id: Ie1a2c3d42088338cc526a4b9bd22bdec070dd7b9
Alexander Galazin [Fri, 22 Mar 2019 13:09:57 +0000 (14:09 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: Iff99182ee48f808b2e1e93eea00ae17ec44efa3e
Jason Ekstrand [Sat, 15 Dec 2018 00:04:39 +0000 (18:04 -0600)]
Be more careful about Block decorations on structs
In spirv/SPIR-V@
9701a9f9 we changed the SPIR-V spec to say that
block-decorated structures could not be nested. This is needed for
sorting out certain variable pointers issues inside a SPIR-V parser.
Unfortunately, the mentioned group of CTS tests violates this rule.
Their %input_buffer type is a struct containing two instances of
%outer_struct and both %input_buffer and %outer_struct are decorated
Block. Fortunately, only one of the two struct types is actually
required for an input at any given type so we just need to be more
careful about the decorations.
Affects:
dEQP-VK.spirv_assembly.instruction.compute.variable_pointers.complex_types_compute.*
Components: Vulkan
VK-GL-CTS issue: 1518
Change-Id: I87a832fab94a9c06317d20b32afedf16b52ab2f2
(cherry picked from commit
1dbdfe34947fdb3e6d24226a58f02d0b8a515da8)
Tony Zlatinski [Tue, 12 Feb 2019 16:50:28 +0000 (10:50 -0600)]
cmake: Add support for PNG_ARM_NEON_OPT NDK-r19
On Android, here is clang compiler change for
NDKs after ndk-r17c where the compiler intrinsics
for libpng are not part of the compiler for the
armeabi-v7a targets.
Add the supported png functions for these compiler
intrinsics, explicitly for 32-bit ARM builds.
Affects:
dEQP-VK.*
Components: Vulkan, Framework
VK-GL-CTS issue: 1638
Change-Id: Ib832f983294f5dd747720ed4a79a21e29a06f776
Alexander Galazin [Tue, 19 Mar 2019 14:26:12 +0000 (15:26 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: Iacfb659e3cb7bcb1d144f843a9011472c18c63fe
Arkadiusz Sarwa [Mon, 21 Jan 2019 14:50:34 +0000 (15:50 +0100)]
Fix the limitation in allocation test
Change removes the limitation for number of allocations
in the test.
Components: Vulkan
VK-GL-CTS issue: 1569
Affects:
dEQP-VK.api.device_init.create_instance_device_intentional_alloc_fail
Change-Id: I038fcfcae46a6baaf691163166c74ea0d3831043
Alexander Galazin [Tue, 5 Mar 2019 16:57:27 +0000 (16:57 +0000)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: Ia68d7a02991fe815d1a311f59f3a5928f995069c
Alexander Galazin [Tue, 5 Mar 2019 16:09:54 +0000 (16:09 +0000)]
Merge vk-gl-cts/vulkan-cts-1.1.1 into vk-gl-cts/vulkan-cts-1.1.2
Change-Id: Iaff35efaad77acdd183dd07161fa0da31faaeac2