platform/upstream/efl.git
4 years agovg_common_json: Fix to duplication of mask and matte.
JunsuChoi [Tue, 25 Feb 2020 02:54:57 +0000 (11:54 +0900)]
vg_common_json: Fix to duplication of mask and matte.

Summary:
There is a case that uses a mask and a mat at the same time.
One of them did not apply. This patch modifies two attributes to be parent-child.

Test Plan: N/A

Reviewers: Hermet, smohanty, kimcinoo

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11399

Change-Id: I14b1e2ab38c042c6845b2232ca8a7b79abccc8c6

4 years agoemile_image: fix warning for COLORSPACE_PALETTE 53/225753/2
Taehyub Kim [Mon, 24 Feb 2020 09:03:03 +0000 (18:03 +0900)]
emile_image: fix warning for COLORSPACE_PALETTE

Change-Id: Idf34992f40015972853b4b4259cc9100c75d02ef

4 years agoefl_ui_win: fix return value 36/225736/2
Yeongjong Lee [Mon, 24 Feb 2020 05:20:57 +0000 (14:20 +0900)]
efl_ui_win: fix return value

@tizen_fix

Change-Id: I65920785747f2bf65dc952b22ab23c2607197d22

4 years agoefl_ui_win: fix casting warnings of Win_Keyboard_Mode 35/225735/2
Yeongjong Lee [Mon, 24 Feb 2020 05:19:45 +0000 (14:19 +0900)]
efl_ui_win: fix casting warnings of Win_Keyboard_Mode

@tizen_fix

Change-Id: I338a7bb0df8bba81a35519eb95a3035e01873e1c

4 years agobuild: fix compiler warnings related to const qualifier 16/225716/2
Yeongjong Lee [Mon, 24 Feb 2020 06:20:05 +0000 (15:20 +0900)]
build: fix compiler warnings related to const qualifier

@tizen_fix

Change-Id: I9992862a849c36227616ff91c4449107f7a4c1bb

4 years agoelm_interface_scrollable: comment out unused goto label 32/225732/2
Yeongjong Lee [Mon, 24 Feb 2020 03:56:04 +0000 (12:56 +0900)]
elm_interface_scrollable: comment out unused goto label

Fixes `-Wunused-label`
```
../src/lib/elementary/elm_interface_scrollable.c:1190:1: warning: label 'skip_bars' defined but not used [-Wunused-label]
 1190 | skip_bars:
```e

@tizen_fix

Change-Id: Ib4b9bc83d79379c02b5785a9961efca3a1127047

4 years agoelm_atspi_bridge: fix return type 12/225712/2
Yeongjong Lee [Mon, 24 Feb 2020 05:55:13 +0000 (14:55 +0900)]
elm_atspi_bridge: fix return type

Fixes `-Wint-conversion` compiler warning.
```
../src/lib/elementary/elm_atspi_bridge.c:7248:14: warning: returning 'void *' from a function with return type 'Eina_Bool' {aka 'unsigned char'} makes integer from pointer without a cast [-Wint-conversion]
  7248 |       return NULL;
```

@tizen_fix

Change-Id: Ie9d4ea80b209210616ef498e3122963cbe4cf169

4 years agoelm_atspi_bridge: correct EFL_EVNET_DEL callback parameters 00/225700/2
Yeongjong Lee [Mon, 24 Feb 2020 04:02:40 +0000 (13:02 +0900)]
elm_atspi_bridge: correct EFL_EVNET_DEL callback parameters

Fixes `-Wincompatible-pointer-types` compiler warnings.

@tizen_fix

Change-Id: I413ed239f6f5bfdad07b10823b6956af865f2614

4 years agoelm_config: remove redundant code 01/225701/2
Yeongjong Lee [Mon, 24 Feb 2020 04:53:30 +0000 (13:53 +0900)]
elm_config: remove redundant code

`theme_overlay_mmap` is freed by following step.
 `_elm_theme_file_clean` - `_elm_theme_clear` - `_elm_theme_free_internal` -
`_efl_ui_theme_efl_object_destructor`.
We don't need to call explicit del.

@tizen_fix

Change-Id: Icf522386e51321297b78746d9371b9476db56a38

4 years agoelementary: remove unused variable in tizen only code 76/225576/3
Yeongjong Lee [Fri, 21 Feb 2020 05:00:06 +0000 (14:00 +0900)]
elementary: remove unused variable in tizen only code

Fixes '-Wunused-variable' compiler warnings.

@tizen_fix
Change-Id: I462ca6212f97f00e628e839b19e1b05f4f1dd7ca

4 years agoecje_cc_handlers: fix warning 42/225742/1
Taehyub Kim [Mon, 24 Feb 2020 07:41:03 +0000 (16:41 +0900)]
ecje_cc_handlers: fix warning

Change-Id: Ibf2fc18f16ed6d9fc05c3c270647680a17f16ecb

4 years agobuild: comment out unused variables 82/225582/2
Yeongjong Lee [Fri, 21 Feb 2020 05:35:07 +0000 (14:35 +0900)]
build: comment out unused variables

Fixes '-Wunused-variable' compiler warnings.

@tizen_fix

Change-Id: I7237668cf83cdd985c61bff6e226082793ed4451

4 years agoelementary: return proper value when failed to get widget data 96/225496/2
Yeongjong Lee [Thu, 20 Feb 2020 08:26:22 +0000 (17:26 +0900)]
elementary: return proper value when failed to get widget data

Fixes '-Wreturn-type' compiler warning.

@tizen_fix
Change-Id: I96a404c41c6eacc9e3d9d6d02c9022c4be2663ce

4 years agoedje_cc_out: correct comment pair 91/225491/3
Yeongjong Lee [Thu, 20 Feb 2020 07:28:52 +0000 (16:28 +0900)]
edje_cc_out: correct comment pair

Fixes following compiler warning.
```
../src/bin/edje/edje_cc_out.c:751:9: warning: "/*" within comment [-Wcomment]
   751 |         /*
```

@tizen_fix

Change-Id: I21c88ac97892a2e9ce5ed0b4ab91f2a4c3359aa1

4 years agoelementary: add EINA_UNUSED for unused parameters 66/225466/3
Yeongjong Lee [Thu, 20 Feb 2020 06:33:33 +0000 (15:33 +0900)]
elementary: add EINA_UNUSED for unused parameters

@tizen_fix

Change-Id: Ia9307a02741281b8412b436b177090676f56cd23

4 years agoefl_ui_image: unload file before memfile_set 07/225607/1
Shinwoo Kim [Fri, 21 Feb 2020 04:16:32 +0000 (13:16 +0900)]
efl_ui_image: unload file before memfile_set

Summary:
If memfile_set does not remove prev file information, it is not possilbe to
load image using the same file information after memefile_set.

It means that below line 3 does not work because the same file information
remains for Efl.Ui.Image_Legacy.

1 |  elm_image_file_set(obj, "1.jpg", NULL)
2 |  elm_image_memfile_set(obj, img, size, "jpg", NULL)
3 |  elm_image_file_set(obj, "1.jpg", NULL)

This patch removes line calling _efl_ui_image_file_set_do becasue it is called
in efl_file_unload > _efl_ui_image_efl_file_unload.

Test Plan:
[Sample Code]
{F3848315}

[Reproduce Step]
1. File2
2. Memfile
3. File2

Reviewers: Hermet, jsuya

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11392

Change-Id: I0f583ff0e8ada23a1bad334b716c952f42b904c2

4 years agoelm_interface_scrollable: remove unused tizen only function 97/225597/1
Yeongjong Lee [Fri, 21 Feb 2020 06:21:49 +0000 (15:21 +0900)]
elm_interface_scrollable: remove unused tizen only function

`_elm_scroll_bar_size_reconfigure` is not used anymore.

Fixes `Wunused-function` compiler warning.

@tizen_fix
Change-Id: I850b10d8b7095f2c27a7ae609ca2ba1bd17cdb4a

4 years agoRevert "elementary: use array instead of list for subchildren" submit/tizen/20200220.222107
Jongmin Lee [Thu, 20 Feb 2020 22:06:01 +0000 (07:06 +0900)]
Revert "elementary: use array instead of list for subchildren"

This reverts commit cf583498a72be5f18b2dd6a4fb10ff1f1dbca53f.

4 years agoefl_ui_exact_model: use eina APIs to get the nth data
Yeongjong Lee [Thu, 20 Feb 2020 14:11:02 +0000 (09:11 -0500)]
efl_ui_exact_model: use eina APIs to get the nth data

Summary:
Also, fixes a compiler warning
```
../src/lib/elementary/efl_ui_exact_model.c:60:17: warning: variable 'tbuf' set but not used [-Wunused-but-set-variable]
```

Test Plan: ninja

Reviewers: cedric, zmike, bu5hm4n

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11380

4 years agocanvas proxy: fix broken proxy source clipping function.
Hermet Park [Thu, 20 Feb 2020 12:20:09 +0000 (21:20 +0900)]
canvas proxy: fix broken proxy source clipping function.

The issue is proxy source clipping is not applied properly,
Obviously that is a regression bug by the code refactoring.

Found out this condition is insane, looks like a wrongly introduced.

@fix

4 years agoEfl.Ui.Spotlight: Fix indicator initialization
Xavi Artigas [Thu, 20 Feb 2020 08:59:29 +0000 (09:59 +0100)]
Efl.Ui.Spotlight: Fix indicator initialization

This caused incorrectly-centered indicator icons in the homescreen example.

4 years agoelementary: use array instead of list for subchildren
Marcel Hollerbach [Mon, 17 Feb 2020 12:56:06 +0000 (13:56 +0100)]
elementary: use array instead of list for subchildren

this safes in the runtime of elm_test round about 9kb (*).
Additionally, using a array here is jumping way fewer times arround in
memory, as we do not need to jump from node to node in a list.

Additionally, this commit replaces a few abort disabler macros with a
error checking macro. (which cleans the log).

*: explanation: we have round about 600 widgets in elm_test, every
widget is normally refered once, every list node has 4 pointer, makes
round about 9600 bytes or rougly 9 KB. So the messured savings are more
or less explaining the reality.

Reviewed-by: Carsten Haitzler (Rasterman) <rasterman.com>
Differential Revision: https://phab.enlightenment.org/D11374

Change-Id: I8653d875ab8bd7db4a48910dc2ed08cee1e76623

4 years agoedje: guarantee the theme abi compatility.
Hermet Park [Thu, 20 Feb 2020 11:22:27 +0000 (20:22 +0900)]
edje: guarantee the theme abi compatility.

if old edj doesn't include "zoom_center" properly,
the initial value will be set with zero,

We can overwrite it in that case since zoom_center initial value is -1.

Change-Id: Id8fdc81bf9ad9749a0e887093773e8eca44a953d

4 years agoedje: Fixed issue that caused color_class changes to be applied to global styles. 63/225463/1
Woochanlee [Thu, 20 Feb 2020 05:30:59 +0000 (14:30 +0900)]
edje: Fixed issue that caused color_class changes to be applied to global styles.

There was issue because the application to the object, file, and global units to which color_class is applied is mixed.

Solved by dividing internal function according to the scope.

Change-Id: I42929c5558e5078a8bdcca1aec032a3bf6161bce

4 years agogengrid: fix item append wanted region adjust in mirrored screen submit/tizen/20200219.213751
SangHyeon Jade Lee [Wed, 19 Feb 2020 10:57:28 +0000 (19:57 +0900)]
gengrid: fix item append wanted region adjust in mirrored screen

Change-Id: If71bed64a95ef3b7bdc5b4a411b7e735702ee89b
Signed-off-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
4 years agogen : fix on_deletion check on item deletion
SangHyeon Jade Lee [Wed, 19 Feb 2020 07:19:51 +0000 (16:19 +0900)]
gen : fix on_deletion check on item deletion

Change-Id: I8200b249a2339def12a34275e08d2de41160e26c
Signed-off-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
4 years agoecore/evas: add key event cancel flag
Hosang Kim [Tue, 18 Feb 2020 08:07:54 +0000 (17:07 +0900)]
ecore/evas: add key event cancel flag

Add new event flag for canceling key event.

Change-Id: I105d763025795bd4196b8c6caa16bdc05f9b9f95
Signed-off-by: Hosang Kim <hosang12.kim@samsung.com>
4 years agoedje_text: Use legacy ellisis logic for evas text.
Subodh Kumar [Tue, 18 Feb 2020 13:37:06 +0000 (19:07 +0530)]
edje_text: Use legacy ellisis logic for evas text.
Some use cases are breaking like lock pin layout

@tizen_fix

Change-Id: Idcd96a7bd4155e893bd464c70aa8d1df7f990470

4 years agoedje: modify to respect user set fixed property
Wonki Kim [Wed, 19 Feb 2020 17:40:39 +0000 (12:40 -0500)]
edje: modify to respect user set fixed property

Summary:
this patch is related with @D11365.

rather than undoing optimization edje calc,
this patch introduces a user_set property which enables edje_calc
to respect user set property.

Reviewers: bu5hm4n, eagleeye, YOhoho, Hermet, zmike

Reviewed By: zmike

Subscribers: zmike, cedric, #reviewers, #committers, woohyun, eagleeye, bu5hm4n

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11366

4 years agodocs: A bit more info and formatting for Eina_Process_Cb
Xavi Artigas [Fri, 10 Jan 2020 16:35:37 +0000 (16:35 +0000)]
docs: A bit more info and formatting for Eina_Process_Cb

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11063

4 years agoeina: introduce eina_iterator_process
Marcel Hollerbach [Fri, 10 Jan 2020 15:35:57 +0000 (16:35 +0100)]
eina: introduce eina_iterator_process

this brings a functional-map function to the iterator implementations.
https://en.wikipedia.org/wiki/Map_(higher-order_function)

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D11062

4 years agoefl_ui_draggable: move these events back to legacy
Marcel Hollerbach [Sun, 26 Jan 2020 09:22:55 +0000 (10:22 +0100)]
efl_ui_draggable: move these events back to legacy

they are not used yet in efl.ui. namespace, and they are needed for
different events.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11196

4 years agoAdding "elm,calendar,ch_%d,weekend" and "elm,calendar,ch_%d,weekday" signals from...
rafspiny [Tue, 18 Feb 2020 16:12:45 +0000 (16:12 +0000)]
Adding "elm,calendar,ch_%d,weekend" and "elm,calendar,ch_%d,weekday" signals from "elm".

The calendar object in elementary needs to know which days are weekdays and which
are weekend days in order to properly change the state of the header's labels.
This code add a signal emission from e_calendar.c when setting the header.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11375

4 years agoeina_array: interpret the count of a NULL array as 0
Marcel Hollerbach [Mon, 17 Feb 2020 12:55:33 +0000 (13:55 +0100)]
eina_array: interpret the count of a NULL array as 0

this makes the usage way more convinient.

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11373

4 years agoecore_con: fix to check a return value of functions
Wonki Kim [Tue, 18 Feb 2020 00:58:16 +0000 (00:58 +0000)]
ecore_con: fix to check a return value of functions

this path fixes to check a return value of functions.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11371

4 years agoefl_con: add a default condition to switch statement
Wonki Kim [Tue, 18 Feb 2020 01:07:12 +0000 (01:07 +0000)]
efl_con: add a default condition to switch statement

this patch modifies conditions
to extract range conditions out of switch statement

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11370

4 years agoelm_spinner: Fixed to apply the %d format.
Woochanlee [Wed, 19 Feb 2020 12:09:15 +0000 (21:09 +0900)]
elm_spinner: Fixed to apply the %d format.

Summary:
The part object does not apply the logic in efl_ui_format, so it does not work correctly when you format it with %d.

This is the commit that gets the necessary part of the logic of efl_ui_format.

Test Plan: elementary_test

Reviewers: Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11378

4 years agoecore_wl2_input: cleanup cursor resources when a Ecore_Wl2_Input is destroy 83/225383/2
jeon [Wed, 19 Feb 2020 10:24:25 +0000 (19:24 +0900)]
ecore_wl2_input: cleanup cursor resources when a Ecore_Wl2_Input is destroy

Change-Id: I464f42ee9e845bee7def2c8fb577f0669c18da8a

4 years agoelm_list : fix build warnings. accepted/tizen/unified/20200221.093540 submit/tizen/20200218.214546
SangHyeon Jade Lee [Fri, 14 Feb 2020 06:35:53 +0000 (15:35 +0900)]
elm_list : fix build warnings.

Change-Id: I79ed9a4328d3a772a79f317d744bbaeb2f66e2d9

4 years agoelementary: remove unused functions 30/225230/2
Yeongjong Lee [Mon, 17 Feb 2020 06:41:31 +0000 (15:41 +0900)]
elementary: remove unused functions

elm_atspi_bridge: remove `_target_validation_check` which should have been
removed at commit 98d14ca80d3d5540760ff41d85f2c61e7bd40c6b.

efl_ui_widget: remove `_on_ewk_del` which should have been removed from commit
22a1e551be364c0d65cd6693b40bf9d9ceed67be.

efl_ui_win: remove _on_atspi_bus_connected` that is not used for tizen.

elementary_tizen: remove `widget_parent_set` which should have been removed at
commit a40eb658890da0ee142c91ff9f900ae797521252.

@tizen_fix

Change-Id: I9a4fd26c2c7ea1b3260e2961bc10cc65bb476938

4 years agobuild: comment out unused functions 18/225218/2
Yeongjong Lee [Tue, 18 Feb 2020 07:16:27 +0000 (16:16 +0900)]
build: comment out unused functions

@tizen_fix
Change-Id: I28cee3b69b7977a2a917e2dc9b1ceb27fd2af96d

4 years agoelementary_tizen/ctxpopup: rename widget_event to input_event_handler 16/225116/4
Yeongjong Lee [Mon, 17 Feb 2020 10:28:27 +0000 (19:28 +0900)]
elementary_tizen/ctxpopup: rename widget_event to input_event_handler

`widget_event` has been renamed to `input_event_handler` since commit
298d112dbb1151fe119480af275931b45828fafd.

For tizen elc_ctxpopup, KeyEvent will work again.

Also, Fixes compiler warnings.
```
 ../src/lib/elementary_tizen/elc_ctxpopup.c:1314:1: warning: '_elm_ctxpopup_efl_ui_widget_event' defined but not used [-Wunused-function]
  1314 | _elm_ctxpopup_efl_ui_widget_event(Eo *obj, Elm_Ctxpopup_Data *sd, Evas_Object *src EINA_UNUSED, Evas_Callback_Type type, void *event_info)
       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 ../src/lib/elementary_tizen/elc_ctxpopup.c:165:1: warning: '_key_action_move' defined but not used [-Wunused-function]
   165 | _key_action_move(Evas_Object *obj, const char *params)
```

@tizen_fix

Change-Id: I95faa5d0d5647df276be03de109e45c2baaf6bfe

4 years agoelm_conform: comment out unused CONFORMANT_KEY 74/225074/2
Yeongjong Lee [Mon, 17 Feb 2020 05:21:23 +0000 (14:21 +0900)]
elm_conform: comment out unused CONFORMANT_KEY

Change-Id: Idb4cc65936318550664b44b544509ce4516b080e

4 years agoedje_text: Restore legacy edje text x fit calculation.
Subodh Kumar [Mon, 17 Feb 2020 09:03:40 +0000 (14:33 +0530)]
edje_text: Restore legacy edje text x fit calculation.

Current fit calculation is breaking some use cases from Tizen 4.0
example: Edit mode ctxpopup text

@tizen_fix

Change-Id: I785e5f53ae795952e8c2ac21c0c5b4b35f41607d

4 years agoC#: Add error checking for Eina.Success_Flag return type
Felipe Magno de Almeida [Tue, 11 Feb 2020 17:48:26 +0000 (17:48 +0000)]
C#: Add error checking for Eina.Success_Flag return type

When a get and/or set from property is defined to return, explicitly,
a Eina.Success_Flag, the mono generator will check the return value
and generate an exception if the call fails.
Resolves T8383.

Reviewed-by: João Paulo Taylor Ienczak Zanette <joao.tiz@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D11281

4 years agocsharp: Add IntPtr to/from IEnumerable conversion for "accessor" types
João Paulo Taylor Ienczak Zanette [Tue, 18 Feb 2020 19:17:56 +0000 (19:17 +0000)]
csharp: Add IntPtr to/from IEnumerable conversion for "accessor" types

Adds a special case for "accessor" complex types in `implicit operator` for
structs and `IntPtr`s, in which an IEnumerator must be converted to/from an
IntPtr.

Reviewed-by: YeongJong Lee <cleanlyj@naver.com>
Reviewed-by: Felipe Magno de Almeida <felipe@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D11210

4 years agoeolian-mono: Make Get/Set internal for generated properties
Felipe Magno de Almeida [Thu, 30 Jan 2020 19:49:04 +0000 (16:49 -0300)]
eolian-mono: Make Get/Set internal for generated properties

Make Get and Set methods internal for properties that get the
property syntax generated.

Reviewed-by: João Paulo Taylor Ienczak Zanette <joao.tiz@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D11252

4 years agoRevert "canvas mask: fix incorrect render surface size."
Hermet Park [Tue, 18 Feb 2020 11:07:08 +0000 (20:07 +0900)]
Revert "canvas mask: fix incorrect render surface size."

This reverts commit e3af5eb27f70edf531d5d8de3e3f2c940536d396.

Seems previous is correct. My misunderstanding.

4 years agocanvas mask: fix incorrect render surface size.
Hermet Park [Tue, 18 Feb 2020 10:09:16 +0000 (19:09 +0900)]
canvas mask: fix incorrect render surface size.

This render context works on a mask surface,
Size should be mask's own, not canvas output size.

@fix

4 years agoEfl.Gfx.Path: Fix condition of for loop in current search 52/225252/1
JunsuChoi [Tue, 18 Feb 2020 07:23:11 +0000 (16:23 +0900)]
Efl.Gfx.Path: Fix condition of for loop in current search

END enum is 0. Fixed due to 064690d46e7ed67becf9710588e7c37a31ab807f
@fix

Change-Id: I9c70d34c102d57284ae93f1e211f960ebe1dc555

4 years agoecore: fix a memory leaking 36/225136/2
Wonki Kim [Mon, 17 Feb 2020 12:57:01 +0000 (21:57 +0900)]
ecore: fix a memory leaking

this patch fixes a memory leaking.

Change-Id: I909d038812f2a66c6bd5e503b16767e73472f5bc

4 years agoelm_atspi_ewk_wrapper: Prevent memory leak 78/225178/1
JunsuChoi [Tue, 18 Feb 2020 04:33:28 +0000 (13:33 +0900)]
elm_atspi_ewk_wrapper: Prevent memory leak

Change-Id: Id6e26224b2b4fdbf21134cdd2016ca0de37f8132

4 years agoedje: Disable the json vector animation feature with a flag. 64/225164/1
JunsuChoi [Mon, 17 Feb 2020 10:05:22 +0000 (19:05 +0900)]
edje: Disable the json vector animation feature with a flag.

Summary:
Json vector animation requires the json loader to be loaded.
Therefore, if the loader does not load,
it prints an appropriate error message and disables the feature.

Depends on D11228

Test Plan: N/A

Reviewers: Hermet, Jaehyun_Cho, id213sin

Reviewed By: Hermet

Subscribers: raster, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11230

Change-Id: I4c7b966189c8612d06ff44739d0e57b6d15c9faa

4 years agoedje: add json file support feature 63/225163/1
YoungBok Shin [Mon, 17 Feb 2020 09:59:09 +0000 (18:59 +0900)]
edje: add json file support feature

Summary:
It also starts to support following new edc properties.
This is backported patch from Tizen 5.0

1. frame
desc { "default"
   vector {
      frame: 0.5; // 0.0 ~ 1.0
   }
}

2. actions
program { "vector_animation";
   // VG_ANIM_PLAY, VG_ANIM_PLAY_BACK, VG_ANIM_LOOP,
   // VG_ANIM_STOP, VG_ANIM_PAUSE, VG_ANIM_RESUME
   action: VG_ANIM_PLAY;
   target: "your_vector_part";
}

@feature

Co-authored-by: Jaehyun Cho <jae_hyun.cho@samsung.com>
  - Fix to remove Efl.Canvas.Animation_Player on edje

Test Plan:
{F3840540}
{F3840542}
{F3840543}
make and test attached file

edje_cc -beta -id ./ json_edc.edc json.edj
gcc -o test test_edc.c -g `pkg-config --cflags --libs evas elementary rlottie`
./test

Reviewers: Hermet, Jaehyun_Cho, id213sin

Reviewed By: Hermet

Subscribers: segfaultxavi, raster, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11228

Change-Id: I3f27e381e5ae2ed76794ec738809c78f095cbc02

4 years agomono: Add "out" as a reserved word submit/tizen/20200217.221032
Xavi Artigas [Mon, 17 Feb 2020 11:35:00 +0000 (12:35 +0100)]
mono: Add "out" as a reserved word

This will turn it into kw_out just like it is done for "in".
Otherwise it cannot be used as a parameter name, for example.

4 years agoefl_ui_selection_manager: fix a compiler warning for Wayland support
Yeongjong Lee [Mon, 17 Feb 2020 09:48:11 +0000 (18:48 +0900)]
efl_ui_selection_manager: fix a compiler warning for Wayland support

Summary: `_sel_manager_seat_selection_get` is used only for x11.

Test Plan: meson build -Dx11=false -Dwl=true

Reviewers: Hermet, zmike

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11363

4 years agoefl_ui_selection_manager: remove unnecessary variable
Yeongjong Lee [Mon, 17 Feb 2020 09:47:54 +0000 (18:47 +0900)]
efl_ui_selection_manager: remove unnecessary variable

Summary: No logical changes.

Test Plan: meson build

Reviewers: Hermet, zmike

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11362

4 years agoels_cursor: Fix a compiler warning for Wayland support
Yeongjong Lee [Mon, 17 Feb 2020 06:36:03 +0000 (15:36 +0900)]
els_cursor: Fix a compiler warning for Wayland support

Summary:
`_curosors` is not used when Elementary is compiled for Wayland.
It Fixes a compiler warning.
```
../src/lib/elementary/els_cursor.c:46:26: warning: ‘_cursors’ defined but not used [-Wunused-variable]
 static struct _Cursor_Id _cursors[] =

```

Test Plan: meson build -Dx11=false -Dwl=true

Reviewers: zmike, Hermet, Jaehyun_Cho

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11360

4 years agoedje_multisense: fix a compiler warning for pulseaudio disable mode
Yeongjong Lee [Mon, 17 Feb 2020 06:35:57 +0000 (15:35 +0900)]
edje_multisense: fix a compiler warning for pulseaudio disable mode

Summary: `_out_fail` is not used when edje is compiled without pulseaudio.

Test Plan: meson build -Dpulseaudio=false

Reviewers: zmike, Hermet, Jaehyun_Cho

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11361

4 years agoelm - scroller wheel accel - limit to avoid over/underflow
Carsten Haitzler (Rasterman) [Sat, 15 Feb 2020 18:37:06 +0000 (18:37 +0000)]
elm - scroller wheel accel - limit to avoid over/underflow

limit wheell accel multiplier to 100,000 ... this way sane values of
wheel_event->z will not overflow. also up intermediate coors to long
longs and clamp to be sure.

4 years agoedje player - make it more useful with padding option
Carsten Haitzler (Rasterman) [Sat, 15 Feb 2020 14:36:09 +0000 (14:36 +0000)]
edje player - make it more useful with padding option

so you can see the overflow outside and edje object, add padding as an
option to move the obj inside the win. this means also nuking the
over-engineered box stacking thing... :)

4 years agoecore con - also be paranoid with same nul byte checks in path str
Carsten Haitzler (Rasterman) [Sat, 15 Feb 2020 11:56:13 +0000 (11:56 +0000)]
ecore con - also be paranoid with same nul byte checks in path str

this won't affect the target system which doesn't do abstract sockets
anyway, and it's just unlink "" ... but check if first byte is nul for
an asbtract socket and dont do lock files or unlinking in this case

4 years agoecore_con - on bsd if we get flock unlink old socket by force
Carsten Haitzler (Rasterman) [Sat, 15 Feb 2020 11:31:43 +0000 (11:31 +0000)]
ecore_con - on bsd if we get flock unlink old socket by force

trying to address other parts of the bsd socket hanging on bind() etc.
... unlink socket if we get the file lock as we should now have an
exclusive lock on the socket anyway - clear out the old one by force
once we have the lock.

4 years agoeina file - close on exec - doesnt exist on windows - vtorri
Carsten Haitzler (Rasterman) [Fri, 14 Feb 2020 13:18:53 +0000 (13:18 +0000)]
eina file - close on exec - doesnt exist on windows - vtorri

4 years agoevas: stop handdefining eo types
Marcel Hollerbach [Fri, 14 Feb 2020 16:06:29 +0000 (17:06 +0100)]
evas: stop handdefining eo types

that is just technical dept carrying arround.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11356

4 years agoefl_ui_spotlight_fade_manager: fix wrong typedef
Marcel Hollerbach [Fri, 14 Feb 2020 16:05:59 +0000 (17:05 +0100)]
efl_ui_spotlight_fade_manager: fix wrong typedef

the typedef used here is not really existing anymore.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11355

4 years agoelm_main: remove unreachable condition
Yeongjong Lee [Fri, 14 Feb 2020 13:34:36 +0000 (08:34 -0500)]
elm_main: remove unreachable condition

Summary: The condition `!*p` is always false because of line 1336.

Reviewers: zmike, Hermet, bu5hm4n

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11349

4 years agotests/evas: add simple test for skip_head property
Mike Blumenkrantz [Fri, 14 Feb 2020 13:33:49 +0000 (08:33 -0500)]
tests/evas: add simple test for skip_head property

Summary:
when using this property, there should be no mmap loaded after a call
to evas_object_image_file_set, and we want to make sure the image is
eventually loaded

ref T8378

Depends on D11340

Reviewers: raster

Reviewed By: raster

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8378

Differential Revision: https://phab.enlightenment.org/D11341

4 years agoevas: restore codepath for loading images from files with skip_head set
Mike Blumenkrantz [Fri, 14 Feb 2020 13:33:43 +0000 (08:33 -0500)]
evas: restore codepath for loading images from files with skip_head set

Summary:
this was never handled during refactoring because it had already been
removed from the tree by that point

fix T8378
Depends on D11339

Reviewers: raster

Reviewed By: raster

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8378

Differential Revision: https://phab.enlightenment.org/D11340

4 years agoRevert "evas: Compile out unused functions"
Mike Blumenkrantz [Fri, 14 Feb 2020 13:33:38 +0000 (08:33 -0500)]
Revert "evas: Compile out unused functions"

Summary:
This reverts commit 7d36ef88bcea82bfdc0146245e13d9e74572fa8f.
Depends on D11338

Reviewers: raster

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11339

4 years agoRevert "evas: remove image_load from the engine."
Mike Blumenkrantz [Fri, 14 Feb 2020 13:33:32 +0000 (08:33 -0500)]
Revert "evas: remove image_load from the engine."

Summary:
This reverts commit 867d826395f988b9a9cbc3b5f93bf57ce031885d.
Depends on D11337

Reviewers: raster

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11338

4 years agoRevert "evas: remove unused fonction evas_gl_common_image_load."
Mike Blumenkrantz [Fri, 14 Feb 2020 13:33:26 +0000 (08:33 -0500)]
Revert "evas: remove unused fonction evas_gl_common_image_load."

Summary:
This reverts commit fc7e244e99bbcaa8303e0e11a533d0d96b7525bd.
Depends on D11336

Reviewers: raster

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11337

4 years agoRevert "evas: remove unused function evas_common_load_image_from_file."
Mike Blumenkrantz [Fri, 14 Feb 2020 13:33:20 +0000 (08:33 -0500)]
Revert "evas: remove unused function evas_common_load_image_from_file."

Summary:
This reverts commit 7672d1050ea9e1050c27ce2eda68718ea054b638.
Depends on D11335

Reviewers: raster

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11336

4 years agoRevert "evas: remove unused function evas_cache_engine_image_request."
Mike Blumenkrantz [Fri, 14 Feb 2020 13:33:13 +0000 (08:33 -0500)]
Revert "evas: remove unused function evas_cache_engine_image_request."

Summary:
This reverts commit 90e1ca715402371575104814162bcddd3664a8ba.
Depends on D11334

Reviewers: raster

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11335

4 years agoRevert "evas: remove unused function evas_cache_image_request."
Mike Blumenkrantz [Fri, 14 Feb 2020 13:33:07 +0000 (08:33 -0500)]
Revert "evas: remove unused function evas_cache_image_request."

Summary: This reverts commit ee3f4e052956ceb49486efae72ece1eccd982b68.

Reviewers: raster

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11334

4 years agoecore x - fix debug printf format to print time
Carsten Haitzler (Rasterman) [Thu, 13 Feb 2020 19:27:42 +0000 (19:27 +0000)]
ecore x - fix debug printf format to print time

4 years agoefl_canvas_gesture: replace parse with import
Marcel Hollerbach [Mon, 3 Feb 2020 15:16:01 +0000 (16:16 +0100)]
efl_canvas_gesture: replace parse with import

we probebly want to use import here, as we want to rebuild this file
when efl_canvas_gesture_events is changed.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11273

4 years agoelm_test: add zoom recognizer handling to gesture test
Mike Blumenkrantz [Wed, 12 Feb 2020 14:02:48 +0000 (09:02 -0500)]
elm_test: add zoom recognizer handling to gesture test

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11330

4 years agoefl/gesture: remove Efl.Canvas.Gesture_Recognizer_Type
Mike Blumenkrantz [Tue, 11 Feb 2020 15:48:44 +0000 (10:48 -0500)]
efl/gesture: remove Efl.Canvas.Gesture_Recognizer_Type

this serves no purpose and isn't used anywhere

Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11323

4 years agoefl/gesture: rework custom gesture recognizer methodology
Mike Blumenkrantz [Tue, 11 Feb 2020 15:29:11 +0000 (10:29 -0500)]
efl/gesture: rework custom gesture recognizer methodology

this needs to return the actual gesture class type so that custom gesture
events can implement their own properties if necessary

Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11322

4 years agoefl/gesture: improve docs
Mike Blumenkrantz [Tue, 11 Feb 2020 15:10:57 +0000 (10:10 -0500)]
efl/gesture: improve docs

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11321

4 years agoefl/gesture: remove bespoke recognizer properties for tap timeout
Mike Blumenkrantz [Tue, 11 Feb 2020 15:10:05 +0000 (10:10 -0500)]
efl/gesture: remove bespoke recognizer properties for tap timeout

this should all be managed by efl.config

Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11320

4 years agoefl/gesture: un-@protected efl.canvas.gesture_recognizer::continues
Mike Blumenkrantz [Tue, 11 Feb 2020 15:08:23 +0000 (10:08 -0500)]
efl/gesture: un-@protected efl.canvas.gesture_recognizer::continues

recognizers need to be able to get and set this appropriately

Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11319

4 years agoefl/gesture: api renames for Efl.Canvas.Gesture_Touch
Mike Blumenkrantz [Fri, 7 Feb 2020 17:00:39 +0000 (12:00 -0500)]
efl/gesture: api renames for Efl.Canvas.Gesture_Touch

ref T8554

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11300

4 years agoefl/gesture: fix long tap timeout errors
Mike Blumenkrantz [Fri, 7 Feb 2020 16:54:40 +0000 (11:54 -0500)]
efl/gesture: fix long tap timeout errors

this is the timer pointer, and we need to be able to delete the timer when
the gesture ends

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11299

4 years agotests/gesture: add another tap test to check finger size works
Mike Blumenkrantz [Wed, 5 Feb 2020 14:55:50 +0000 (09:55 -0500)]
tests/gesture: add another tap test to check finger size works

add some move events in to shake up the recognizers and check whether
taps are still working

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11292

4 years agoefl/gesture: fix touch state tracking
Mike Blumenkrantz [Wed, 5 Feb 2020 14:48:57 +0000 (09:48 -0500)]
efl/gesture: fix touch state tracking

correctly set 'pressed' member of touch data only on press events and
don't change it on move events in order to avoid having mismatched states

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11291

4 years agoefl/gesture: remove recognizer::reset method
Mike Blumenkrantz [Tue, 4 Feb 2020 14:34:20 +0000 (09:34 -0500)]
efl/gesture: remove recognizer::reset method

this wasn't used and doesn't seem necessary

ref T8503

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11279

4 years agoefl/gesture: fix tap gesture type naming
Mike Blumenkrantz [Mon, 3 Feb 2020 17:16:27 +0000 (12:16 -0500)]
efl/gesture: fix tap gesture type naming

we use c_enum_naming_style in our enums, not cSharpEnumNamingStyle

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11275

4 years agoefl/gesture: remove gesture_touch::multi_touch
Mike Blumenkrantz [Mon, 3 Feb 2020 17:10:31 +0000 (12:10 -0500)]
efl/gesture: remove gesture_touch::multi_touch

this is redundant now that touch_count exists

ref T8554

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11274

4 years agoefl/gesture: rework gesture_recognizer::add to be a 'type' property
Mike Blumenkrantz [Fri, 31 Jan 2020 15:44:23 +0000 (10:44 -0500)]
efl/gesture: rework gesture_recognizer::add to be a 'type' property

this simplifies (and optimizes) a bunch of code by letting gesture recognizers
return directly the type of gesture they recognize for use internally

ref T8503

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11267

4 years agoefl/gesture: use new config value for thumbscroll friction
Mike Blumenkrantz [Fri, 31 Jan 2020 14:55:06 +0000 (09:55 -0500)]
efl/gesture: use new config value for thumbscroll friction

the old one used here is marked deprecated

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11263

4 years agoelm/config: fix thumbscroll config
Mike Blumenkrantz [Wed, 5 Feb 2020 17:22:20 +0000 (12:22 -0500)]
elm/config: fix thumbscroll config

this was broken a while ago by failing to correctly update all the configs

ref 6409cfa41b19f04ef7b4247d078d626e9ec77a8f

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11294

4 years agoefl/config: add missing gesture config value handlers
Mike Blumenkrantz [Thu, 30 Jan 2020 16:40:40 +0000 (11:40 -0500)]
efl/config: add missing gesture config value handlers

these are stored in the config here so they should be manageable here as well

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11250

4 years agoefl/config: merge all gesture manager config code into efl.config
Mike Blumenkrantz [Thu, 30 Jan 2020 16:46:59 +0000 (11:46 -0500)]
efl/config: merge all gesture manager config code into efl.config

this is all just duplicated code, so we can deduplicate it with minimal
effort to clean up the api

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11251

4 years agoefl/win: change a couple config init sets for gesture manager to use legacy config
Mike Blumenkrantz [Thu, 30 Jan 2020 16:39:52 +0000 (11:39 -0500)]
efl/win: change a couple config init sets for gesture manager to use legacy config

these values are deprecated, so stop setting them in efl_config

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11249

4 years agoefl/gesture: remove manager config
Mike Blumenkrantz [Thu, 30 Jan 2020 15:46:24 +0000 (10:46 -0500)]
efl/gesture: remove manager config

we can just use efl.config here instead of duplicating it

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11248

4 years agoefl/config: move C wrappers for this out of elm_config.h to Efl.h
Mike Blumenkrantz [Thu, 30 Jan 2020 15:45:39 +0000 (10:45 -0500)]
efl/config: move C wrappers for this out of elm_config.h to Efl.h

this is beta API and belongs in its proper header

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11247

4 years agoefl/gesture: move manager's recognizer cleanup function to eo
Mike Blumenkrantz [Wed, 29 Jan 2020 19:09:16 +0000 (14:09 -0500)]
efl/gesture: move manager's recognizer cleanup function to eo

this is needed by recognizers which use timers in order to do timeouts
on gestures

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11245

4 years agoevas_model_loader: fix 8f3bef248bb0002cbbd40052eb759d1b2ae29ce9
Marcel Hollerbach [Fri, 14 Feb 2020 07:58:43 +0000 (08:58 +0100)]
evas_model_loader: fix 8f3bef248bb0002cbbd40052eb759d1b2ae29ce9

The commit fixed a mem leak with freeing one element in the array, which
was never going to work, as only the array is a pointer you can
allocate.

This could have been discovered by simply running ninja test.