Martin Storsjo [Sat, 18 Nov 2017 06:23:48 +0000 (06:23 +0000)]
[X86] Output cfi directives for saved XMM registers even if no GPRs are saved
This makes sure that functions that only clobber xmm registers
(on win64) also get the right cfi directives, if dwarf exceptions
are enabled.
Differential Revision: https://reviews.llvm.org/D40191
llvm-svn: 318591
Craig Topper [Sat, 18 Nov 2017 05:09:55 +0000 (05:09 +0000)]
[X86] Fix typo in variable name. NFC
llvm-svn: 318590
Quentin Colombet [Sat, 18 Nov 2017 04:28:59 +0000 (04:28 +0000)]
[AArch64] Map G_LOAD on FPR when the definition goes to a copy to FPR
We used to detect loads feeding fp instructions, but we were
failing to take into account cases where this happens through copies.
For instance, loads can fed copies coming from the ABI lowering
of floating point arguments/results.
llvm-svn: 318589
Quentin Colombet [Sat, 18 Nov 2017 04:28:58 +0000 (04:28 +0000)]
[AArch64] Map G_STORE on FPR when the source comes from a FPR copy
We used to detect that stores were fed by fp instructions, but we were
failing to take into account cases where this happens through copies.
For instance, stores can be fed by copies coming from the ABI lowering
of floating point arguments.
llvm-svn: 318588
Quentin Colombet [Sat, 18 Nov 2017 04:28:58 +0000 (04:28 +0000)]
[RegisterBankInfo] Relax the assert of having matching type sizes on default mappings
Instead of asserting that the type sizes are exactly equal, we check
that the new size is big enough to contain the original type.
We have to relax this constrain because, right now, we sometimes
specify that things that are smaller than a storage type are legal
instead of widening everything to the size of a storage type.
E.g., we say that G_AND s16 is legal and we map that on GPR32.
This is something we may revisit in the future (either by changing
the legalization process or keeping track separately of the storage
size and the size of the type), but let us reflect the reality of
the situation for now.
llvm-svn: 318587
Quentin Colombet [Sat, 18 Nov 2017 04:28:56 +0000 (04:28 +0000)]
[AArch64][RegisterBankInfo] Teach instruction mapping about gpr32 -> fpr16 cross copies
Turns out this copies can actually occur because of the way we lower the
ABI for half.
llvm-svn: 318586
Rafael Espindola [Sat, 18 Nov 2017 02:12:53 +0000 (02:12 +0000)]
Reorder static functions. NFC.
llvm-svn: 318584
Rafael Espindola [Sat, 18 Nov 2017 02:05:59 +0000 (02:05 +0000)]
Split realPathFromHandle in two.
By having an UTF-16 version we avoid some code duplication in calling
GetFinalPathNameByHandleW.
llvm-svn: 318583
Eugene Zelenko [Sat, 18 Nov 2017 01:47:41 +0000 (01:47 +0000)]
[AST] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).
llvm-svn: 318582
Walter Lee [Sat, 18 Nov 2017 01:13:18 +0000 (01:13 +0000)]
[asan] Add a full redzone after every stack variable
We were not doing that for large shadow granularity. Also add more
stack frame layout tests for large shadow granularity.
Differential Revision: https://reviews.llvm.org/D39475
llvm-svn: 318581
Davide Italiano [Sat, 18 Nov 2017 00:54:31 +0000 (00:54 +0000)]
[ABI] Remove dead code that was copy-pasted all around. NFCI.
llvm-svn: 318580
Davide Italiano [Sat, 18 Nov 2017 00:52:29 +0000 (00:52 +0000)]
[Module] Throw away some more commented code. NFCI.
llvm-svn: 318579
Hans Wennborg [Sat, 18 Nov 2017 00:49:18 +0000 (00:49 +0000)]
Fix some -Wunused-variable warnings
llvm-svn: 318578
Davide Italiano [Sat, 18 Nov 2017 00:35:27 +0000 (00:35 +0000)]
[ABI/SysV] Remove more dead code. NFCI.
llvm-svn: 318577
Davide Italiano [Sat, 18 Nov 2017 00:34:09 +0000 (00:34 +0000)]
[Core] Garbage collect dead code untouched in years. NFCI.
This sketching can be resurrected if anybody needs it, although
I doubt is relevant these days.
llvm-svn: 318576
Evgeniy Stepanov [Sat, 18 Nov 2017 00:22:34 +0000 (00:22 +0000)]
Revert "[asan] Use dynamic shadow on 32-bit Android" and 3 more.
Revert the following commits:
r318369 [asan] Fallback to non-ifunc dynamic shadow on android<22.
r318235 [asan] Prevent rematerialization of &__asan_shadow.
r317948 [sanitizer] Remove unnecessary attribute hidden.
r317943 [asan] Use dynamic shadow on 32-bit Android.
MemoryRangeIsAvailable() reads /proc/$PID/maps into an mmap-ed buffer
that may overlap with the address range that we plan to use for the
dynamic shadow mapping. This is causing random startup crashes.
llvm-svn: 318575
Daniel Sanders [Sat, 18 Nov 2017 00:16:44 +0000 (00:16 +0000)]
[globalisel][tablegen] Generalize pointer-type inference by introducing ptypeN. NFC
ptypeN is functionally the same as typeN except that it informs the
SelectionDAG importer that an operand should be treated as a pointer even
if it was written as iN. This is important for patterns that use iN instead
of iPTR to represent pointers. E.g.:
(set GPR64:$dst, (load GPR64:$addr))
Previously, this was handled as a hardcoded special case for the appropriate
operands to G_LOAD and G_STORE.
llvm-svn: 318574
Evgeniy Stepanov [Fri, 17 Nov 2017 23:52:34 +0000 (23:52 +0000)]
[asan] Fix asan_device_setup on KitKat.
"ln" from toybox does not understand -f (force) flag.
llvm-svn: 318573
Reid Kleckner [Fri, 17 Nov 2017 23:52:33 +0000 (23:52 +0000)]
[lit] Try to improve Ctrl-C behavior on Windows
This functionality was broken during a refactor a while back because
'pool' is no longer in scope.
llvm-svn: 318572
Petr Hosek [Fri, 17 Nov 2017 23:51:53 +0000 (23:51 +0000)]
[CMake][runtimes] Don't passthrough prefixes for non-default targets
The passthrough is useful for setting up the options for the default
build, but we already have a different mechanism to pass CMake flags
to builds for builtins and runtimes targets so this is not really
needed there. Furthermore, when the flags are set for the default
build, with the prefix passthrough set we have to explicitly override
all options in other targets which can be cumbersome.
Differential Revision: https://reviews.llvm.org/D39988
llvm-svn: 318571
Eugene Zelenko [Fri, 17 Nov 2017 23:43:46 +0000 (23:43 +0000)]
[AST] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).
llvm-svn: 318570
Petr Hosek [Fri, 17 Nov 2017 23:29:46 +0000 (23:29 +0000)]
[libunwind][CMake] Provide option to disable instalation of the library
This is useful in cases where we only build static library and
libunwind.a is combined with libc++abi.a into a single archive in which
case we don't want to have libunwind.a installed separately. The same
option is already provided by libcxx CMake build.
This change also adds the install-unwind target for consistency with the
libcxxabi and libcxx CMake build.
Differential Revision: https://reviews.llvm.org/D40195
llvm-svn: 318569
Petr Hosek [Fri, 17 Nov 2017 23:25:09 +0000 (23:25 +0000)]
[libcxxabi][CMake] Provide option to disable installing of the library
This is useful in cases where we only build static library and
libc++abi.a is combined with libc++.a into a single archive in which
case we don't want to have libc++abi.a installed separately. The same
option is already provided by libcxx CMake build.
Differential Revision: https://reviews.llvm.org/D40194
llvm-svn: 318568
Anna Zaks [Fri, 17 Nov 2017 23:19:04 +0000 (23:19 +0000)]
Change code owner for Clang Static Analyzer to Devin Coughlin.
Differential Revision: https://reviews.llvm.org/D39964
llvm-svn: 318567
Zachary Turner [Fri, 17 Nov 2017 22:51:43 +0000 (22:51 +0000)]
Fix an issue with llvm lit tool substitutions.
When using an installed clang with an in-tree llvm, we were not
searching in the right paths for the tools.
llvm-svn: 318564
Petr Hosek [Fri, 17 Nov 2017 22:49:39 +0000 (22:49 +0000)]
[CMake][libcxxabi] Support merging objects when statically linking unwinder
When using LLVM unwinder and static unwinder option is set, merge
libunwind and libc++abi objects into a single archive. libc++ already
supports merging libc++abi.a and libc++.a into a single archive; with
this change, it is possible to also include libunwind.a in the same
archive which is useful when doing static link and using libc++ as
a default C++ library and compiler-rt as a default runtime library.
Differential Revision: https://reviews.llvm.org/D39949
llvm-svn: 318563
Michal Gorny [Fri, 17 Nov 2017 22:21:23 +0000 (22:21 +0000)]
[cmake] Use llvm-lit directory when provided for stand-alone build
After the recent lit test changes, clang attempts to run its tests
via llvm-lit by default. However, the llvm-lit binary is not present
when performing stand-alone build resulting in a failure out of the box.
To solve that, add the llvm-lit directory to CMake when performing
a stand-alone build and LLVM sources are provided. This includes
the CMake rules generating the llvm-lit binary and effectively makes
it possible for clang to use it.
Differential Revision: https://reviews.llvm.org/D40142
llvm-svn: 318562
Zhaoshi Zheng [Fri, 17 Nov 2017 22:05:19 +0000 (22:05 +0000)]
[NFC] Make r318597 compatible with clang-format
llvm-svn: 318561
Zhen Cao [Fri, 17 Nov 2017 21:59:43 +0000 (21:59 +0000)]
[MC] Fix regression tests on Windows when git “core.autocrlf” is set to true.
Differential Revision: https://reviews.llvm.org/D39737
This is the second attempt to commit this. The test was broken on Linux in the first attempt.
llvm-svn: 318560
Reid Kleckner [Fri, 17 Nov 2017 21:55:23 +0000 (21:55 +0000)]
Fix coverage test on Windows bot
llvm-svn: 318559
Rafael Espindola [Fri, 17 Nov 2017 21:40:38 +0000 (21:40 +0000)]
Don't use llvm/Config/config.h.
It is private to llvm. Instead use llvm/Config/llvm-config.h and check
LLVM_ON_UNIX. That is the same guard that clang uses before including
unistd.h.
llvm-svn: 318558
Matt Arsenault [Fri, 17 Nov 2017 21:35:32 +0000 (21:35 +0000)]
AMDGPU: Move hazard avoidance out of waitcnt pass.
This is mostly moving VMEM clause breaking into
the hazard recognizer. Also move another hazard
currently handled in the waitcnt pass.
Also stops breaking clauses unless xnack is enabled.
llvm-svn: 318557
Reid Kleckner [Fri, 17 Nov 2017 21:33:28 +0000 (21:33 +0000)]
Loosen -Wempty-body warning
Do not show it when `if` or `else` come from macros.
E.g.,
#define USED(A) if (A); else
#define SOME_IF(A) if (A)
void test() {
// No warnings are shown in those cases now.
USED(0);
SOME_IF(0);
}
Patch by Ilya Biryukov!
Differential Revision: https://reviews.llvm.org/D40185
llvm-svn: 318556
Vedant Kumar [Fri, 17 Nov 2017 21:18:32 +0000 (21:18 +0000)]
[llvm-profdata] Don't treat non-fatal merge errors as fatal
This fixes an issue seen on the coverage bot:
http://lab.llvm.org:8080/green/view/Experimental/job/clang-stage2-coverage-R/1930
Profile merging shouldn't fail if a single counter mismatch is detected.
llvm-svn: 318555
Alexander Shaposhnikov [Fri, 17 Nov 2017 20:50:54 +0000 (20:50 +0000)]
[lldb] Ensure that dwo/dwp are not double-indexed
DWO/DWP should not be indexed directly.
Instead, the corresponding base file should be used.
This diff adds an assert to DWARFCompileUnit::Index
and adjusts the methods
SymbolFileDWARF::FindCompleteObjCDefinitionTypeForDIE,
SymbolFileDWARF::GetObjCMethodDIEOffsets accordingly.
Differential revision: https://reviews.llvm.org/D39825
llvm-svn: 318554
Jonas Hahnfeld [Fri, 17 Nov 2017 20:46:55 +0000 (20:46 +0000)]
llvm-demangle-fuzzer: Link in Support
The refactoring in r318407 transiently includes abi-breaking.h
which defines EnableABIBreakingChecks. This breaks my Debug
build because this fuzzer did not link in Support with the symbol.
Differential Revision: https://reviews.llvm.org/D40190
llvm-svn: 318553
Alex Lorenz [Fri, 17 Nov 2017 20:44:25 +0000 (20:44 +0000)]
[ObjC][ARC] Honor noescape attribute for -Warc-retain-cycles
rdar://
35409566
Differential Revision: https://reviews.llvm.org/D40141
llvm-svn: 318552
Jun Bum Lim [Fri, 17 Nov 2017 20:38:25 +0000 (20:38 +0000)]
[LICM] Fix PR35342
Summary: This change fix PR35342 by replacing only the current use with undef in unreachable blocks.
Reviewers: efriedma, mcrosier, igor-laevsky
Reviewed By: efriedma
Subscribers: llvm-commits
Differential Revision: https://reviews.llvm.org/D40184
llvm-svn: 318551
Rafael Espindola [Fri, 17 Nov 2017 20:06:41 +0000 (20:06 +0000)]
Use TempFile in the implementation of LockFileManager.
This move some of the complexity over to the lower level TempFile.
It also makes it a bit more explicit where errors are ignored since we
now have a call to consumeError.
llvm-svn: 318550
Chandler Carruth [Fri, 17 Nov 2017 19:58:36 +0000 (19:58 +0000)]
[PM/Unswitch] Teach SimpleLoopUnswitch to do non-trivial unswitching,
making it no longer even remotely simple.
The pass will now be more of a "full loop unswitching" pass rather than
anything substantively simpler than any other approach. I plan to rename
it accordingly once the dust settles.
The key ideas of the new loop unswitcher are carried over for
non-trivial unswitching:
1) Fully unswitch a branch or switch instruction from inside of a loop to
outside of it.
2) Update the CFG and IR. This avoids needing to "remember" the
unswitched branches as well as avoiding excessively cloning and
reliance on complex parts of simplify-cfg to cleanup the cfg.
3) Update the analyses (where we can) rather than just blowing them away
or relying on something else updating them.
Sadly, #3 is somewhat compromised here as the dominator tree updates
were too complex for me to want to reason about. I will need to make
another attempt to do this now that we have a nice dynamic update API
for dominators. However, we do adhere to #3 w.r.t. LoopInfo.
This approach also adds an important principls specific to non-trivial
unswitching: not *all* of the loop will be duplicated when unswitching.
This fact allows us to compute the cost in terms of how much *duplicate*
code is inserted rather than just on raw size. Unswitching conditions
which essentialy partition loops will work regardless of the total loop
size.
Some remaining issues that I will be addressing in subsequent commits:
- Handling unstructured control flow.
- Unswitching 'switch' cases instead of just branches.
- Moving to the dynamic update API for dominators.
Some high-level, interesting limitationsV that folks might want to push
on as follow-ups but that I don't have any immediate plans around:
- We could be much more clever about not cloning things that will be
deleted. In fact, we should be able to delete *nothing* and do
a minimal number of clones.
- There are many more interesting selection criteria for which branch to
unswitch that we might want to look at. One that I'm interested in
particularly are a set of conditions which all exit the loop and which
can be merged into a single unswitched test of them.
Differential revision: https://reviews.llvm.org/D34200
llvm-svn: 318549
Peter Collingbourne [Fri, 17 Nov 2017 19:51:20 +0000 (19:51 +0000)]
COFF: Stop emitting a non-standard COFF symbol table into PEs.
Now that our support for PDB emission is reasonably good, there is
no longer a need to emit a COFF symbol table.
Also fix a bug where we would fail to emit a string table for long
section names if /debug was not specified.
Differential Revision: https://reviews.llvm.org/D40189
llvm-svn: 318548
Reid Kleckner [Fri, 17 Nov 2017 19:50:10 +0000 (19:50 +0000)]
All .xdata sections are eligble for ICF
Summary:
Many small functions have identical unwind info because they push the
same sets of CSRs in the same order and have the same stack and prologue
size. The VC linker merges duplicate .xdata, and so should LLD.
This reduces the .xdata section size of clang.exe from 1.8MB to 94KB.
Reviewers: pcc, ruiu
Subscribers: llvm-commits
Differential Revision: https://reviews.llvm.org/D40160
llvm-svn: 318547
Peter Collingbourne [Fri, 17 Nov 2017 19:49:41 +0000 (19:49 +0000)]
Enable PDB generation with lld in asan and cfi tests on Windows.
PDB emission now works well enough that we can rely on it for these
tests to pass.
Differential Revision: https://reviews.llvm.org/D40188
llvm-svn: 318546
Ahmed Bougacha [Fri, 17 Nov 2017 19:46:47 +0000 (19:46 +0000)]
[CodeGen] Compute the objc EH vtable address point using inbounds GEP.
The object is provided by the objc runtime and is never visible in the
module itself, but even so, the address point we compute points into it,
and "+16" is guaranteed not to overflow.
This matches the c++ vtable IRGen.
Note that I'm not entirely convinced the 'i8*' type is correct here: at
the IR level, we're accessing memory that's outside the global object.
But we don't control the allocation, so it's not obviously wrong either.
But either way, this is only in a global initializer, so I don't think
it's going to be mucked with. Filed PR35352 to discuss that.
llvm-svn: 318545
Ilya Biryukov [Fri, 17 Nov 2017 19:05:56 +0000 (19:05 +0000)]
[clangd] Release the old preamble before building a new one.
llvm-svn: 318544
Justin Bogner [Fri, 17 Nov 2017 18:51:20 +0000 (18:51 +0000)]
MIRParser: Avoid reading uninitialized memory on generic vregs
If a vreg's bank is specified in the registers block and one of its
defs or uses also specifies the bank, we end up checking that the
RegBank is equal to diagnose conflicting banks. The problem comes up
for generic vregs, where we weren't fully initializing the VRegInfo
when parsing the registers block, so we'd end up comparing a null
pointer to uninitialized memory.
This fixes a non-deterministic failure when round tripping through MIR
with generic vregs.
llvm-svn: 318543
Simon Pilgrim [Fri, 17 Nov 2017 18:35:49 +0000 (18:35 +0000)]
[X86] Merge scheduling tests for SHLD/SHRD
Reduces spsce used and makes it easier to compare the 2 values for the equivalent instructions
llvm-svn: 318541
Volodymyr Sapsai [Fri, 17 Nov 2017 18:28:05 +0000 (18:28 +0000)]
[ThinLTO] Remove too aggressive assertion in building function call graph.
The assertion was introduced in r317853 but there are cases when a call
isn't handled either as direct or indirect. In this case we add a
reference graph edge but not a call graph edge.
Reviewers: tejohnson
Reviewed By: tejohnson
Subscribers: mehdi_amini, inglorion, eraman, hiraditya, efriedma, llvm-commits
Differential Revision: https://reviews.llvm.org/D40056
llvm-svn: 318540
Sam Clegg [Fri, 17 Nov 2017 18:14:09 +0000 (18:14 +0000)]
[WebAssembly] Initial wasm linker implementation
This linker backend is still a work in progress but is
enough to link simple programs including linking against
library archives.
Differential Revision: https://reviews.llvm.org/D34851
llvm-svn: 318539
Eugene Zelenko [Fri, 17 Nov 2017 18:09:48 +0000 (18:09 +0000)]
[AST] Partially revert r318341 to fix two broken tests on llvm-clang-x86_64-expensive-checks-win (NFC).
llvm-svn: 318538
Martin Probst [Fri, 17 Nov 2017 18:06:33 +0000 (18:06 +0000)]
clang-format: remove trailing lines in lamdas and arrow functions.
Summary:
clang-format already removes empty lines at the beginning & end of
blocks:
int x() {
foo(); // lines before and after will be removed.
}
However because lamdas and arrow functions are parsed as expressions,
the existing logic to remove empty lines in UnwrappedLineFormatter
doesn't handle them.
This change special cases arrow functions in ContinuationIndenter to
remove empty lines:
x = []() {
foo(); // lines before and after will now be removed.
};
Reviewers: djasper
Subscribers: klimek, cfe-commits
Differential Revision: https://reviews.llvm.org/D40178
llvm-svn: 318537
Alexey Bataev [Fri, 17 Nov 2017 17:57:25 +0000 (17:57 +0000)]
[OPENMP] Codegen for `target simd` construct.
Added codegen support for `target simd` directive.
llvm-svn: 318536
Rafael Espindola [Fri, 17 Nov 2017 17:46:39 +0000 (17:46 +0000)]
Try to fix the windows build.
llvm-svn: 318535
Rafael Espindola [Fri, 17 Nov 2017 17:33:09 +0000 (17:33 +0000)]
Use TempFile in dsymutil.
I don't think there is any functionality change, but the code is
easier to understand IMHO.
llvm-svn: 318534
Rafael Espindola [Fri, 17 Nov 2017 17:31:20 +0000 (17:31 +0000)]
Revert "[MC] Fix regression tests on Windows when git “core.autocrlf” is set to true."
This reverts commit r318528.
MC/AsmParser/preserve-comments-crlf.s fails on linux.
llvm-svn: 318533
Michal Gorny [Fri, 17 Nov 2017 17:12:14 +0000 (17:12 +0000)]
[CMake] Allow for Solaris ld -V output on stdout
In recent versions of Solaris 11.4 (previously 12), ld -V output went to
stdout instead of stderr. Since AddLLVM.cmake only expects it on stderr,
Solaris ld wasn't properly detected and options not understood by it are
passed during the build.
The following patch fixes this, allowing for both variants.
Tested on i386-pc-solaris2.11.4 (on top of D35755 which is needed for
proper Solaris support).
Patch by Rainer Orth.
Differential Revision: https://reviews.llvm.org/D39601
llvm-svn: 318532
Evandro Menezes [Fri, 17 Nov 2017 16:42:15 +0000 (16:42 +0000)]
[AArch64] Adjust the cost model for Exynos M1 and M2
Improve the accuracy of the model by specifying the proper number of uops.
llvm-svn: 318531
Stephan Bergmann [Fri, 17 Nov 2017 16:34:36 +0000 (16:34 +0000)]
Indent code blocks so they are actually treated as such
llvm-svn: 318530
Dave Lee [Fri, 17 Nov 2017 16:27:21 +0000 (16:27 +0000)]
Fix skipping of flags in getClangStripDependencyFileAdjuster
Summary:
The ArgumentsAdjuster returned from `getClangStripDependencyFileAdjuster` will
skip dependency flags, and also their associated values for those flags that
take an argument. This change corrects the handling of the `-MD` and `-MMD`
flags, which do not take an argument.
Reviewers: saugustine, klimek, alexshap
Reviewed By: alexshap
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D40024
llvm-svn: 318529
Zhen Cao [Fri, 17 Nov 2017 16:17:56 +0000 (16:17 +0000)]
[MC] Fix regression tests on Windows when git “core.autocrlf” is set to true.
Differential Revision: https://reviews.llvm.org/D39737
llvm-svn: 318528
Jonas Hahnfeld [Fri, 17 Nov 2017 15:26:44 +0000 (15:26 +0000)]
[OMPT] Fix inaccuracies in worksharing tests
These tests were failing rarely on my MacBook when there was some
activity in the background. Read: one of a thousand executions?
* sections.c missed the sorting based on thread ids. This worked
as long as the master thread finished its section before the
worker thread started the second one but failed if the master
thread was put to sleep by the OS.
* The checks in single.c assumed that the master thread executes
the single region which works most of the time because it is
usually faster than the newly spawned worker thread.
Differential Revision: https://reviews.llvm.org/D39853
llvm-svn: 318527
Dmitry Preobrazhensky [Fri, 17 Nov 2017 15:15:40 +0000 (15:15 +0000)]
[AMDGPU][MC][GFX9][disassembler] Corrected decoding of op_sel_hi for v_mad_mix*
See bug 35148: https://bugs.llvm.org//show_bug.cgi?id=35148
Reviewers: tamazov, SamWot, arsenm
Differential Revision: https://reviews.llvm.org/D39492
llvm-svn: 318526
Krasimir Georgiev [Fri, 17 Nov 2017 15:10:49 +0000 (15:10 +0000)]
[clang-format] Add text proto filename detection
Summary: Adds text proto filename detection.
Reviewers: klimek
Reviewed By: klimek
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D40120
llvm-svn: 318525
Ben Dunbobbin [Fri, 17 Nov 2017 14:42:18 +0000 (14:42 +0000)]
[Support][CachePruning] Fix regression in pruning interval
Fixed broken comparison.
borked by: rL284966 (see: https://reviews.llvm.org/D25730).
Differential Revision: https://reviews.llvm.org/D40119
This is a second attempt to commit this.
The first attempt broke lld and gold tests that had been written against
the incorrect behaivour.
llvm-svn: 318524
Gabor Horvath [Fri, 17 Nov 2017 12:28:58 +0000 (12:28 +0000)]
[clang-tidy] Fix an oversight after renaming a check
llvm-svn: 318523
Gabor Horvath [Fri, 17 Nov 2017 12:23:30 +0000 (12:23 +0000)]
[clang-tidy] Add a check for undelegated copy of base classes
Finds copy constructors where the constructor don't call
the copy constructor of the base class.
```
class X : public Copyable {
X(const X &other) {} // Copyable(other) is missing
};
```
Differential Revision: https://reviews.llvm.org/D33722
llvm-svn: 318522
Andrew Ng [Fri, 17 Nov 2017 12:00:57 +0000 (12:00 +0000)]
[gold] Fix broken thin LTO cache test NFC
Fix test as it is assuming that the cache pruning is always being
performed by default. Explicitly set prune interval to 0s to ensure
pruning is always performed.
llvm-svn: 318520
George Rimar [Fri, 17 Nov 2017 11:57:47 +0000 (11:57 +0000)]
[ELF] - Teach LLD to use information from .debug_str for error reporting.
Recently we teached LLD to report line numbers for duplicate variables
definitions, though currently LLD is unable to do that for case when
strings are not built in .debug_info, but stored in .debug_str instead.
That is because out LLDDwarfObj does not handle .debug_str yet.
Patch fixes that.
Differential revision: https://reviews.llvm.org/D39542
llvm-svn: 318519
George Rimar [Fri, 17 Nov 2017 11:39:26 +0000 (11:39 +0000)]
[ELF] - Fix BB after r318516
Test did not run under windows because uses zlib.
Content of section changed because now strings
merging is applied.
llvm-svn: 318518
Philip Pfaffe [Fri, 17 Nov 2017 11:34:29 +0000 (11:34 +0000)]
[nfc] Iwyu: forward-declare/include raw_ostream in zone algo
llvm-svn: 318517
George Rimar [Fri, 17 Nov 2017 11:27:57 +0000 (11:27 +0000)]
[ELF] - Allow applying SHF_MERGE optimization for relocatable output.
This fixes PR35223.
Here I enabled SHF_MERGE section content merging for -r like
we do for regular linking.
Differential revision: https://reviews.llvm.org/D40026
llvm-svn: 318516
Manuel Klimek [Fri, 17 Nov 2017 11:17:15 +0000 (11:17 +0000)]
Implement more accurate penalty & trade-offs while breaking protruding tokens.
For each line that we break in a protruding token, compute whether the
penalty of breaking is actually larger than the penalty of the excess
characters. Only break if that is the case.
llvm-svn: 318515
Ilya Biryukov [Fri, 17 Nov 2017 10:09:02 +0000 (10:09 +0000)]
Use llvm-config.h instead of config.h
To fix standalone builds broken by r318411 (config.h is private to llvm).
llvm-svn: 318514
Rui Ueyama [Fri, 17 Nov 2017 08:17:36 +0000 (08:17 +0000)]
Ignore -no-ctors-in-init-array.
Patch by dxf@google.com.
llvm-svn: 318513
Rui Ueyama [Fri, 17 Nov 2017 08:17:21 +0000 (08:17 +0000)]
Add a missing #include.
llvm-svn: 318512
Martin Storsjo [Fri, 17 Nov 2017 08:06:49 +0000 (08:06 +0000)]
[MinGW] Define __ARM_DWARF_EH__ for MinGW/ARM
Since SVN r318510, the MinGW/ARM configuration defaults to
dwarf exception handling.
Differential Revision: https://reviews.llvm.org/D39533
llvm-svn: 318511
Martin Storsjo [Fri, 17 Nov 2017 08:04:40 +0000 (08:04 +0000)]
[ARM] Use dwarf exception handling on MinGW
Enabling and using dwarf exceptions seems like an easier path
to take, than to make the COFF/ARM backend output EHABI directives.
Previously, no EH model was enabled at all on this target.
There's no point in setting UseIntegratedAssembler to false since
GNU binutils doesn't support Windows on ARM, and since we don't
need to support external assembler, we don't need to use register
numbers in cfi directives.
Differential Revision: https://reviews.llvm.org/D39532
llvm-svn: 318510
Craig Topper [Fri, 17 Nov 2017 07:03:57 +0000 (07:03 +0000)]
[SelectionDAG] Allow custom vector widening through ReplaceNodeResults to handle nodes with chain outputs.
Previously we were assuming all results were vectors and calling SetWidenedVector, but if its a chain result we should just replace uses instead.
This fixes an error found by expensive checks after r318368.
llvm-svn: 318509
Max Kazantsev [Fri, 17 Nov 2017 06:49:26 +0000 (06:49 +0000)]
[IRCE] Remove folding of two range checks into RANGE_CHECK_BOTH
The logic of replacing of a couple `RANGE_CHECK_LOWER + RANGE_CHECK_UPPER`
into `RANGE_CHECK_BOTH` in fact duplicates the logic of range intersection which
happens when we calculate safe iteration space. Effectively, the result of intersection of
these ranges doesn't differ from the range of merged range check.
We chose to remove duplicating logic in favor of code simplicity.
Differential Revision: https://reviews.llvm.org/D39589
llvm-svn: 318508
Bruno Cardoso Lopes [Fri, 17 Nov 2017 04:26:07 +0000 (04:26 +0000)]
Change path used in a test from r318503 to work on windows
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/13565
llvm-svn: 318507
Matt Arsenault [Fri, 17 Nov 2017 04:18:26 +0000 (04:18 +0000)]
AMDGPU: Replace list of SMEM buffer opcodes
llvm-svn: 318506
Matt Arsenault [Fri, 17 Nov 2017 04:18:24 +0000 (04:18 +0000)]
AMDGPU: Fix breaking SMEM clauses
This was completely ignoring subregisters,
so was not very useful. Also only break them
if xnack is actually enabled.
llvm-svn: 318505
Eugene Zemtsov [Fri, 17 Nov 2017 03:28:58 +0000 (03:28 +0000)]
Fix LLDB build.
It was broken by r318489.
llvm-svn: 318504
Bruno Cardoso Lopes [Fri, 17 Nov 2017 03:24:11 +0000 (03:24 +0000)]
[PCH+Modules] Improve diagnosticts to help out users pass an extra header search path
When mixing PCH and Implicit Modules, missing a header search path
can lead to the implicit built PCM to complaint about not finding its
matching module map.
Instead of adding more magic to implicit modules engine, add a note to
help the user add the appropriate path.
rdar://problem/
33388847
llvm-svn: 318503
Vedant Kumar [Fri, 17 Nov 2017 02:58:23 +0000 (02:58 +0000)]
[llvm-profdata] Fix a dangling reference to an error string
llvm-svn: 318502
Aditya Nandakumar [Fri, 17 Nov 2017 02:44:55 +0000 (02:44 +0000)]
[GISel]: DCE copy instructions during legalization
We might have instructions such as ext(copy(trunc)), and while cleaning
up legalization artifacts, we can also dce the copies that are in
between legalization artifacts.
llvm-svn: 318501
Jason Molenda [Fri, 17 Nov 2017 01:55:50 +0000 (01:55 +0000)]
Update xcode project file to build new ppc64le files.
llvm-svn: 318500
Vedant Kumar [Fri, 17 Nov 2017 01:48:33 +0000 (01:48 +0000)]
[SelectionDAG] Consolidate (t|T)ransferDbgValues methods, NFC (reapply)
TransferDbgValues (capital 'T') is wired into ReplaceAllUsesWith, and
transferDbgValues (lowercase 't') is used elsewhere (e.g in Legalize).
Both functions should be doing the exact same thing. This patch
consolidates the logic into one place.
This was reverted in r318455 because some newly introduced asserts,
which I thought were NFC, were firing. I filed PR35338. For now I've
weakened the asserts.
Testing: check-llvm, check-clang, and a stage2 Rel+Deb build of clang
Differential Revision: https://reviews.llvm.org/D40104
llvm-svn: 318498
Rafael Espindola [Fri, 17 Nov 2017 01:37:50 +0000 (01:37 +0000)]
Remove IsLocal.
Since we always have Binding in the current symbol design IsLocal is
redundant.
llvm-svn: 318497
Jim Ingham [Fri, 17 Nov 2017 01:22:34 +0000 (01:22 +0000)]
Recognize another magic token sent in the LaunchInfo's EventData.
<rdar://problem/
32505028>
llvm-svn: 318496
Jim Ingham [Fri, 17 Nov 2017 01:19:59 +0000 (01:19 +0000)]
"source list -a" was calling DisplaySourceLinesWithNumbers incorrectly.
The parameters were just passed in the wrong order.
<rdar://problem/
35150446>
llvm-svn: 318495
Justin Lebar [Fri, 17 Nov 2017 01:15:43 +0000 (01:15 +0000)]
[CUDA] Remove implementations of nexttoward.
Summary:
__builtin_nexttoward lowers to a libcall, e.g. nexttowardf(), that CUDA
does not have.
Rather than try to implement it, we simply remove these functions --
nvcc doesn't support them either, and nextafter, which does work, does
essentially the same thing on GPUs, because GPUs don't have long double.
Reviewers: tra
Subscribers: cfe-commits, sanjoy
Differential Revision: https://reviews.llvm.org/D40152
llvm-svn: 318494
Walter Lee [Fri, 17 Nov 2017 01:15:31 +0000 (01:15 +0000)]
[asan] Test ASan instrumentation for shadow scale value of 5
Add additional RUN clauses to test for -asan-mapping-scale=5 in
selective tests, with special CHECK statements where needed.
Differential Revision: https://reviews.llvm.org/D39775
llvm-svn: 318493
David Blaikie [Fri, 17 Nov 2017 01:07:20 +0000 (01:07 +0000)]
Update for layering fix in LLVM CodeGen<>Target
llvm-svn: 318491
David Blaikie [Fri, 17 Nov 2017 01:07:10 +0000 (01:07 +0000)]
Fix a bunch more layering of CodeGen headers that are in Target
All these headers already depend on CodeGen headers so moving them into
CodeGen fixes the layering (since CodeGen depends on Target, not the
other way around).
llvm-svn: 318490
Zachary Turner [Fri, 17 Nov 2017 01:00:35 +0000 (01:00 +0000)]
Don't #include MemoryBuffer.h from Host.h.
It turns out this #include isn't used from Host.h anyway,
but by having it it causes circular include dependencies.
This issues only surfaced while I was working on a separate
patch, so I'm submitting this first so that it's independent
of the other, unrelated patch.
llvm-svn: 318489
Vitaly Buka [Fri, 17 Nov 2017 00:46:59 +0000 (00:46 +0000)]
[fuzzer] Initialize PcDescr buffer before calling __sanitizer_symbolize_pc
__sanitizer_symbolize_pc is not instrumented so msan assumes that PcDescr
was not initialized.
llvm-svn: 318488
Mandeep Singh Grang [Fri, 17 Nov 2017 00:43:24 +0000 (00:43 +0000)]
[PredicateInfo] Add comment about why we require stable sort
llvm-svn: 318487
Zachary Turner [Fri, 17 Nov 2017 00:41:18 +0000 (00:41 +0000)]
Re-revert "Refactor debuginfo-tests"
This is still broken because it causes certain tests to be
run twice with slightly different configurations, which is
wrong in some cases.
You can observe this by running:
ninja -nv check-all | grep debuginfo-tests
And seeing that it passes clang/test and clang/test/debuginfo-tests
to lit, which causes it to run debuginfo-tests twice. The fix is
going to involve either:
a) figuring out that we're running in this "deprecated" configuration,
and then deleting the clang/test/debuginfo-tests path, which should
cause it to behave identically to before, or:
b) make lit smart enough that it doesn't descend into a sub-suite if
that sub-suite already has a lit.cfg file.
llvm-svn: 318486
Dmitry Mikulin [Fri, 17 Nov 2017 00:30:24 +0000 (00:30 +0000)]
Current implementation of Value::replaceUsesExceptBlockAddr() uses UseList
iterator to walk the list which keeps changing inside the loop. When the
UseList contains several uses with the same user, we end processing the same
user more than once, which leads to an assert.
With this fix, unique users are saved and processed later to avoid
processing duplicates.
Differential Revision: https://reviews.llvm.org/D39864
llvm-svn: 318477