Andrei [Fri, 26 Jul 2019 10:48:52 +0000 (13:48 +0300)]
fixes #5575 (#6981)
Chris King [Fri, 26 Jul 2019 01:30:36 +0000 (15:30 -1000)]
update dot files
Gerald Versluis [Thu, 25 Jul 2019 16:40:56 +0000 (18:40 +0200)]
Added iOS version check for crashing code (#6862) fixes #6847
Rui Marinho [Thu, 25 Jul 2019 09:26:34 +0000 (10:26 +0100)]
[Tests]Update to Xamarin.UITest 3.0 and NUnit 3.0 (#6332)
* [UITests]Update to Xamarin.UITest 3.0
* [Tests] Move tests to Xamarin.UITests and NUnit 3.0
* [UITests] Use OneTimeSetUp
* suppress CS0436
Chris King [Thu, 25 Jul 2019 00:39:11 +0000 (14:39 -1000)]
update .create-stubs.bat for iOS
Stephane Delcroix [Wed, 24 Jul 2019 08:46:30 +0000 (10:46 +0200)]
[C] Obsolete Device.OpenUri (#6844)
* [C] Obsolete Device.OpenUri
also fix identation to use tabs
* fix CS618
* Update Xamarin.Forms.Core/Device.cs
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
Chris King [Tue, 23 Jul 2019 23:30:57 +0000 (13:30 -1000)]
update partial slns
Stephane Delcroix [Tue, 23 Jul 2019 16:12:59 +0000 (18:12 +0200)]
Merge branch '4.2.0'
Stephane Delcroix [Tue, 23 Jul 2019 16:12:34 +0000 (18:12 +0200)]
Merge branch '4.1.0' into 4.2.0
Pavel Yakovlev [Mon, 22 Jul 2019 16:53:28 +0000 (19:53 +0300)]
[Android] Fix previewer exceptions with TabbedPage (#6897)
* [Android] Fix previewer exceptions with TabbedPage
* - consolidated code
Rui Marinho [Sun, 21 Jul 2019 19:57:29 +0000 (20:57 +0100)]
Merge branch '4.2.0'
Rui Marinho [Sun, 21 Jul 2019 19:56:23 +0000 (20:56 +0100)]
Merge branch '4.1.0' into 4.2.0
Alan Grgic [Fri, 19 Jul 2019 10:58:59 +0000 (05:58 -0500)]
[iOS] Fix initial color of RefreshControl in ListViews (#6473) fixes #5728
* add reproduction
* make beginrefreshing occur after offset animation and ensure color is set before beginning refresh
Kevin Petit [Fri, 19 Jul 2019 10:50:02 +0000 (12:50 +0200)]
Fix - Prevent race condition between activity create and dispose. (#6596)
Daniel Luberda [Fri, 19 Jul 2019 10:43:39 +0000 (12:43 +0200)]
MacOS: Allow third party libs to display animated images correctly (#6302)
* Mac Animated NSImage support
Andrei Nitescu [Thu, 18 Jul 2019 18:59:06 +0000 (21:59 +0300)]
ITextAlignmentElement VerticalTextAlignment (Entry, SearchBar, EntryCell) (#6463)
Rui Marinho [Thu, 18 Jul 2019 14:35:32 +0000 (15:35 +0100)]
[Build] Update GitInfo
kingces95 [Thu, 18 Jul 2019 12:43:26 +0000 (02:43 -1000)]
opt-in init (#6149)
ksemenenko [Thu, 18 Jul 2019 12:28:23 +0000 (15:28 +0300)]
[Enhancement] Implements CharacterSpacing (#5167)
- fixes #4855
* TextElement.LetterSpacingProperty
ButtonRenderer
DatePickerRenderer
EditorRenderer
EntryRenderer.cs
LabelRenderer
PickerRenderer
SearchBarRenderer
TimePickerRenderer
fix renderers
LetterSpacingElement
Extensions ToEm
* iOS
Picker
* UWP
* removal of an unnecessary condition
* Remove ILetterSpacingElement.OnLetterSpacingChanged
Fix for PickerRenderer for Android
* Move LetterSpacing to TextElement
* UWP
* Span
* Span and LetterSpacing
* Tests
* fixes for renderers
* Renderers
* LetterSpacingGallery
* Android fixes
* Extensions
* delete macos code
* iOS and UWP Renderers
* Renderers for iOS
* Picker.Items
* UWP
* fix merge
* Renderers
* iOS renderers
* PickerRenderer.cs
* Material
* Material Renderer
* Picker placeholder
* InvalidateMeasure
* Update Xamarin.Forms.Core/Span.cs
Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* Update Xamarin.Forms.Core/ITextElement.cs
Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* remove LetterSpacing tests
* style
* Rename LetterSpacing to CharacterSpacing
* Update Xamarin.Forms.Controls/GalleryPages/CharacterSpacingGallery.xaml
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Update Xamarin.Forms.Material.Android/MaterialButtonRenderer.cs
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Update Xamarin.Forms.Material.Android/MaterialButtonRenderer.cs
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Update Xamarin.Forms.Material.Android/MaterialButtonRenderer.cs
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Update Xamarin.Forms.Material.Android/MaterialButtonRenderer.cs
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Update Xamarin.Forms.Material.iOS/MaterialButtonRenderer.cs
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Update Xamarin.Forms.Material.iOS/MaterialPickerRenderer.cs
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Update Xamarin.Forms.Material.iOS/MaterialButtonRenderer.cs
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Update Xamarin.Forms.Material.iOS/MaterialEditorRenderer.cs
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Update Xamarin.Forms.Material.iOS/MaterialButtonRenderer.cs
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Update Xamarin.Forms.Material.iOS/MaterialEditorRenderer.cs
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Update Xamarin.Forms.Material.iOS/MaterialButtonRenderer.cs
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Update Xamarin.Forms.Material.iOS/MaterialButtonRenderer.cs
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* SearchHandler
* UAP CharacterSpacing
* Update Xamarin.Forms.Core/Shell/SearchHandler.cs
Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
Gerald Versluis [Thu, 18 Jul 2019 11:43:27 +0000 (13:43 +0200)]
Added UITest for #2577 (#6728)
* Added UITest for issue 2577
* Added Wait statements
* Apply suggestions from code review
Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* AutomationId to const
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2577.cs
Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* All strings to const
Samantha Houts [Thu, 18 Jul 2019 03:06:02 +0000 (20:06 -0700)]
Merge branch '4.2.0'
Samantha Houts [Thu, 18 Jul 2019 03:03:30 +0000 (20:03 -0700)]
Merge branch '4.1.0' into 4.2.0
Samantha Houts [Thu, 18 Jul 2019 02:58:30 +0000 (19:58 -0700)]
Merge branch '4.0.0' into 4.1.0
Gerald Versluis [Thu, 18 Jul 2019 02:49:21 +0000 (04:49 +0200)]
[Bug][iOS] listview / observable collection throwing native error on load (#6576)
* Added reproduction and commented out the misbehaving code
* Fixed merge conflicts
# Conflicts:
# Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems
* Implemented UI test
* Somehow merged in a non-existing UI test
* Removed DetermineEstimatedRowHeight in WillDisplay
* Revert "Removed DetermineEstimatedRowHeight in WillDisplay"
This reverts commit
431178d923c3bf642aae83331a5dc5b57c4436de.
* Removed WillDisplay with DetermineEstimatedRowHeight
* Reinstate projitems
* Added some more test scenarios
* Removed commented code
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue6472.cs
fixes #6472
Pavel Yakovlev [Thu, 18 Jul 2019 01:29:08 +0000 (04:29 +0300)]
[Android] refactoring fixes layouts (#6390)
* [Android] refactoring fixes layouts (issues 1332, 1760, 5766, 5184, 6297)
* issue3000 and ToolbarItem tests should be passes
* MaybeRequestLayout extension method
* added automated UITest 5766
* fix 5766
* fix 6297
* merge 6297 into 5766 uitest
* rename test
E.Z. Hart [Tue, 16 Jul 2019 17:40:26 +0000 (11:40 -0600)]
Implement ItemsUpdatingScrollMode on Android and iOS (#6879)
shmin [Tue, 16 Jul 2019 16:07:36 +0000 (01:07 +0900)]
[Tizen] Fix slider thumb color issue (#6785)
Andrei Nitescu [Tue, 16 Jul 2019 16:06:01 +0000 (19:06 +0300)]
Label padding (#6299)
* Label padding
* Probably the biggest dilemma in the world
fixes #4784
Stephane Delcroix [Tue, 16 Jul 2019 10:26:33 +0000 (12:26 +0200)]
try to fix the build
Keith Dahlby [Tue, 16 Jul 2019 07:20:10 +0000 (02:20 -0500)]
[Core] Missing await in Device.InvokeOnMainThreadAsync(Func<Task>) (#6718)
* [Core] Use local functions
* [Core] Extract DeviceUnitTests
* [Core] Ensure actually called from main thread
* [Core] Add InvokeOnMainThread tests
WithAsyncTask is expected to fail.
* [Core] Rename local wrapper functions
* [Core] Avoid ambiguous call
CS0121: The call is ambiguous between the following methods or
properties: 'Device.InvokeOnMainThreadAsync(Action)' and
'Device.InvokeOnMainThreadAsync(Func<Task>)'
https://github.com/dotnet/roslyn/issues/14885
https://github.com/dotnet/csharplang/issues/98
Samantha Houts [Tue, 16 Jul 2019 02:17:48 +0000 (19:17 -0700)]
[Android] Unhook WebView.EvaluateJavascriptAsync on Dispose (#6674)
* Add repro for #6286 (doesn't crash, though)
* [Android] Unhook WebView.EvaluateJavascriptAsync on Dispose
fixes #6286
Rui Marinho [Mon, 15 Jul 2019 18:32:00 +0000 (19:32 +0100)]
[iOS] ItemsViewLayout needs strategy on the ctor (#6690)
Rui Marinho [Mon, 15 Jul 2019 18:23:27 +0000 (19:23 +0100)]
Update GitInfo.txt
Pavel Yakovlev [Mon, 15 Jul 2019 17:39:21 +0000 (20:39 +0300)]
[iOS] fixes material checkbox color (#6820) fixes #6816
Stephane Delcroix [Mon, 15 Jul 2019 12:00:46 +0000 (14:00 +0200)]
[X] allow x:Type markup as x:DataType value (#6843)
see discussion on #6492 and related issues
Andrei Nitescu [Mon, 15 Jul 2019 11:34:54 +0000 (14:34 +0300)]
Fixes binding to nullable types (#6860)
-fixes #6280
Stephane Delcroix [Mon, 15 Jul 2019 10:02:13 +0000 (12:02 +0200)]
[X] do not compile binding set as property values (#6837)
binding passed as properties don't have a valid datatype, so do not compile those.
- fixes #5240
adrianknight89 [Mon, 15 Jul 2019 08:30:26 +0000 (03:30 -0500)]
[Core] Add ability to show modal prompts (#6714)
* display prompts
* added keyboard
* moved null arguments to Page
* added test
* changed property name
* fix default literal issues
* fixes
Stephane Delcroix [Fri, 12 Jul 2019 14:23:52 +0000 (16:23 +0200)]
Merge branch '4.2.0'
Stephane Delcroix [Fri, 12 Jul 2019 14:22:56 +0000 (16:22 +0200)]
Merge branch '4.1.0' into 4.2.0
Stephane Delcroix [Fri, 12 Jul 2019 13:40:16 +0000 (15:40 +0200)]
[HR] properly reload merged rds
E.Z. Hart [Fri, 12 Jul 2019 11:07:57 +0000 (05:07 -0600)]
Don't force binding expression applications to queue (#6857)
* Don't force binding expression applications to queue; fixes #6609
* Make PropertyChangeBindingsOccurThroughMainThread test what it claims to test
Ravinder Jangra [Thu, 11 Jul 2019 23:03:12 +0000 (04:33 +0530)]
Add Scrollbar Visibility option to the CollectionView (#6602)
* Add Horizontal and Vertical Scrollbar Visibility option to the CollectionView
* bump gitinfo
* make requested changes
* Add Android implementation
* use ScrollBarVisibility.Default instead of 0 and other requested changes
fixes #6053
Samantha Houts [Thu, 11 Jul 2019 22:45:25 +0000 (15:45 -0700)]
Merge branch '4.2.0'
Samantha Houts [Thu, 11 Jul 2019 22:44:58 +0000 (15:44 -0700)]
Merge branch '4.1.0' into 4.2.0
Mike Schwörer [Thu, 11 Jul 2019 08:52:18 +0000 (10:52 +0200)]
Fixed: Button CornerRadius doesn't work in explicit style (#6753)
- fixes #5046
* Fixed #5046 - Button CornerRadius doesn't work in explicit style
* Added Unit Test
* Requested changes from PR
* Moved UnitTest to Xamarin.Forms.Xaml.UnitTests
* Update Xamarin.Forms.Xaml.UnitTests/ButtonCornerRadius.xaml.cs
Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* Do not add ButtonCornerRadius in csproj
* removed dangling changes in ButtonUnitTest.cs
Geoffrey Huntley [Thu, 11 Jul 2019 01:38:41 +0000 (11:38 +1000)]
cleanup: moved closing brace to new line (#6793)
Andrei Nitescu [Thu, 11 Jul 2019 01:35:25 +0000 (04:35 +0300)]
Add protected GetTemplateChild to ContentPage and ContentView #6747 (#6752)
fixes #6747
Kevin Petit [Thu, 11 Jul 2019 01:34:26 +0000 (03:34 +0200)]
[Android] Uniformize handler name (CollectionView) (#6720)
* CollectionView - Uniformize handler name.
* Address naming feedback.
* Revert BOM.
Joe Manke [Wed, 10 Jul 2019 17:18:42 +0000 (13:18 -0400)]
Auto-focus next view from Entry with ReturnType.Next (#6706)
* Automatically focus the next view after hitting the Return key on an Entry with ReturnType.Next
* UWP implementation
Stephane Delcroix [Wed, 10 Jul 2019 12:24:32 +0000 (14:24 +0200)]
Merge branch '4.2.0'
Stephane Delcroix [Wed, 10 Jul 2019 10:18:17 +0000 (12:18 +0200)]
[X] hide TypedBinding from Intelisense
Andrei Nitescu [Wed, 10 Jul 2019 02:03:16 +0000 (05:03 +0300)]
Fix Page implicit and inherited style with ControlTemplate #6657 (#6661)
* Fix Page implicit and inherited style with ControlTemplate #6657
* Update StyleTests.cs
fixes #6657
Alan Grgic [Wed, 10 Jul 2019 00:24:10 +0000 (19:24 -0500)]
[Android] Fix KeyNotFoundException during Shell Navigation (#6740)
* fix android shell nav crash
* add reproduction test
* add automation and address feedback
* move fragmet creation of stack items to after switch statement
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue6738.cs
Co-Authored-By: Shane Neuville <shane94@hotmail.com>
* [iOS] fix shell section disposals so multiple page renderers don't get assigned
Gerald Versluis [Tue, 9 Jul 2019 21:46:35 +0000 (23:46 +0200)]
Implemented Padding on WPF Button (#6791)
* Implemented Padding on WPF Button
* Update Padding when BorderWidth is updated
* Implemented Padding for ImageButton
* Apply suggestions from code review
Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
fixes #6790
Geoffrey Huntley [Tue, 9 Jul 2019 20:18:59 +0000 (06:18 +1000)]
cleanup: corrected spelling mistake (#6794)
Samantha Houts [Tue, 9 Jul 2019 17:50:41 +0000 (10:50 -0700)]
Merge branch '4.1.0' into 4.2.0
Peter Moore [Tue, 9 Jul 2019 10:10:13 +0000 (05:10 -0500)]
RelativeSource Binding (#4375)
RelativeSource Binding
- fixes #3847
Implement RelativeSource binding modes for Self, TemplatedParent, and FindAncestor. Add unit tests. Pare down TemplateBinding class to use RelativeSource binding mechanism.
* Include RelativeSource member in Binding.Clone
* Fix issue of unit tests being tricked by async in Binding.Apply; permit "Source={RelativeSource...}" in addition to "RelativeSource={RelativeSource..."; allow FindAncestor relative binding source mode to be based on BindingContext type or control type
* Fix unit test wasn't actually testing "Source={RelativeSource...}" syntax.
* Address @StephaneDelcroix's comments. Make FindAncestor relative source binding work even when the ancestor changes.
* Much better mechanism for detecting when a parent changes for relativesource
* Cleanup
* more cleanup
* more cleanup
* Remove async/await for identifying templated parent and ancestor type binding source
* Remove unused code; fix linting
* Update Xamarin.Forms.Core/Binding.cs
Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* Update Xamarin.Forms.Core/Binding.cs
Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* Update Xamarin.Forms.Core/Binding.cs
Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* Update Xamarin.Forms.Core/BindingExpression.cs
Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* Update Xamarin.Forms.Core/BindingExpression.cs
Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* Update Xamarin.Forms.Core/Binding.cs
Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* Ensure TemplateBinding works correctly when reparenting. Cleanup.
* Finish addressing comments; linting cleanup
* Remove private modifier where unneeded
Samantha Houts [Tue, 9 Jul 2019 01:55:31 +0000 (18:55 -0700)]
Merge branch '4.2.0'
Andrei Nitescu [Mon, 8 Jul 2019 23:51:37 +0000 (02:51 +0300)]
Fix for Switch on Android losing shadow #6798 (#6798)
Joe Manke [Mon, 8 Jul 2019 23:17:05 +0000 (19:17 -0400)]
Reimplement ITabStop to return the EditText on Android Material renderers that use TextInputLayout as the native Control (#6732)
fixes #5102
Stephane Delcroix [Mon, 8 Jul 2019 23:03:32 +0000 (01:03 +0200)]
[X] Allow x:Null for x:DataType (#6822)
- fixes #6648
Shane Neuville [Sun, 7 Jul 2019 22:08:31 +0000 (16:08 -0600)]
[Shell] Flyout TableView height fix and implement margins for Flyout Header (#6572)
* [ios] fix safeareas and use marging to offset flyout
* android fixes for margin
* [iOS] frame size and inset fixes
* android fix header offset
* Update Xamarin.Forms.Platform.iOS/Renderers/ShellTableViewController.cs
Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* top offset fixes
* add mask back in for scrolling header
* fix NRE when FlyoutHeader is null
* tweak Bugzilla26993Test
ShaneN [Sat, 6 Jul 2019 19:59:12 +0000 (13:59 -0600)]
Merge branch '4.2.0'
Shane Neuville [Sat, 6 Jul 2019 19:56:10 +0000 (13:56 -0600)]
Clear global routes on unit tests and process global routes in the right place (#6781)
* Clear global routes on unit tests and process global routes in the right place
* - route with current item in case shellSection is null
* inset ui test fix
* Fix ColorFilter for API 19
* add missing file
Christopher Dresel [Fri, 5 Jul 2019 18:29:42 +0000 (20:29 +0200)]
Fix for #6444: Propagate binding context for children of shell sections (#6730)
* Propagate binding context for children of shell sections
* Added a few more BindingContext Propagation tests
adrianknight89 [Thu, 4 Jul 2019 04:09:02 +0000 (23:09 -0500)]
Create UI test template for XAML pages (#5853)
* create template for XAML pages
* update existing template
* added BindingContext
* removed whitespace
* move BindingContext
* change class name to Issue
* fixed absolute path
Samantha Houts [Thu, 4 Jul 2019 03:58:43 +0000 (20:58 -0700)]
bump gitinfo
Samantha Houts [Thu, 4 Jul 2019 03:49:49 +0000 (20:49 -0700)]
Merge branch '4.1.0'
Andrei Nitescu [Thu, 4 Jul 2019 00:31:27 +0000 (03:31 +0300)]
Fix Map Gallery page (#6603)
Samantha Houts [Thu, 4 Jul 2019 00:16:32 +0000 (17:16 -0700)]
Merge branch '4.1.0'
David Roqueni [Thu, 4 Jul 2019 00:13:01 +0000 (17:13 -0700)]
Add Color.ToHex() (#6272)
* Updated Color to have ToHex() method. Created Unit tests to ensure method is working as expected.
* Updated ToHex() use uint values. Updated unit tests for ToHex.
fixes #6003
Andrei Nitescu [Thu, 4 Jul 2019 00:08:56 +0000 (03:08 +0300)]
Switch ThumbColor (#6312)
fixes #5415
Ravinder Jangra [Thu, 4 Jul 2019 00:05:55 +0000 (05:35 +0530)]
Add constructor in WkWebViewRenderer to use custom configuration (#6578)
Andrei Nitescu [Thu, 4 Jul 2019 00:05:17 +0000 (03:05 +0300)]
Map MoveToLastRegionOnLayoutChange Property (#6601)
fixes #6222
Pavel Yakovlev [Thu, 4 Jul 2019 00:03:13 +0000 (03:03 +0300)]
[UWP] fixes crash after reset corner radius (#6744)
Shane Neuville [Wed, 3 Jul 2019 23:57:46 +0000 (17:57 -0600)]
[Shell] Apply Query string parameters even if they aren't present and correctly apply them to nested pages (#6695)
* apply query string parameters if they aren't there
- apply query string parameters correctly to nested pages
* Update Xamarin.Forms.Core/Shell/Shell.cs
Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
fixes #6543
Shane Neuville [Wed, 3 Jul 2019 23:53:45 +0000 (17:53 -0600)]
Shell lifecycle (#6527)
* shell appearing and disappearing events
* life cycle UI tests and fixes
* - fix appearing on shell content to only fire when page gets created
- fix navigated to only fire after shell content is appearing
* OnNavigatedOnlyFiresOnce
fixes #6486
E.Z. Hart [Wed, 3 Jul 2019 23:46:47 +0000 (17:46 -0600)]
Unhook Page from embedded Application on disposal (#6735)
* Unhook Page from embedded Application on disposal
* Update Xamarin.Forms.Core/Application.cs
fixes #4671
Samantha Houts [Wed, 3 Jul 2019 23:42:03 +0000 (16:42 -0700)]
Merge branch '4.0.0' into 4.1.0
Pavel Yakovlev [Wed, 3 Jul 2019 23:24:57 +0000 (02:24 +0300)]
[UWP] fixes crash after reset text color (#6435)
Shane Neuville [Wed, 3 Jul 2019 23:22:23 +0000 (17:22 -0600)]
don't throw exception if registering same route factory to same route name (#6775)
nels83 [Wed, 3 Jul 2019 22:59:37 +0000 (00:59 +0200)]
[GTK] Fix navigation (#6692)
Commit
491947606d03647124bffffcea8547e135869027
introduced this change :
* [GTK] Don't recreate the toolbar on each change
However when changing page, toolbar needs to be recreated.
Shane Neuville [Wed, 3 Jul 2019 15:44:14 +0000 (09:44 -0600)]
Rename some tests to better identify purpose and change query to WaitForElement (#6759)
Shane Neuville [Wed, 3 Jul 2019 14:27:51 +0000 (08:27 -0600)]
[ios] Shell inset, general SafeArea fixes for shell and non shell embedded pages, entry scrolling fixes (#6457)
* [ios] insets, keyboard scroll, safearea
* ui tests
* small fixes
* ui tests
* additional ui test
* reset default padding more intelligently
* ios10 fixes
* ios10 fixes
* use safe area only if tabbar or navbar is present
* better searching for uiscrollview
* ios11 ui test fixes
* slight delay for scroll to resolve before checking
* Update Xamarin.Forms.Platform.iOS/Renderers/PageRenderer.cs
Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* Update Xamarin.Forms.Platform.iOS/Renderers/KeyboardInsetTracker.cs
Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/ShellInsets.cs
Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* try to fix ui tests apply pr suggestions
* more app center ios10 tweaks
* ios 10 fixes
* Update Xamarin.Forms.Platform.iOS/Renderers/ScrollViewRenderer.cs
Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* Update Xamarin.Forms.Platform.iOS/Renderers/ShellSectionRootRenderer.cs
Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* PR comments
* fix inset change thrashing and only send offset when changed
* add delay for loading url images and rename shell test
* add null check to extension
E.Z. Hart [Tue, 2 Jul 2019 21:34:45 +0000 (15:34 -0600)]
Implement CollectionView grouping on iOS (#6590)
* Implement CollectionView grouping for iOS
* Add grouping UI tests
* Fix invalidcast when source is not INotifyCollectionChanged
* Remove old TODO comments
* Apply suggestions from code review
Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* IsGroupingEnabled -> IsGrouped
* Update empty source workaround
* Fix incorrect group counting for empty collections
* Iron out all section counts; remove unsavory empty view workaround;
* Fix crash when filter is null
* Handle sections for add/remove to/from empty sources; check for empty sources when handling sections;
* Prevent random test failures for test 5793
* Remove now-unnecessary size check on transition from empty to non-empty source
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/CollectionViewGrouping.cs
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
Eilon Lipton [Tue, 2 Jul 2019 20:36:22 +0000 (13:36 -0700)]
Make building easier on Windows by setting PowerShell execution policy (attempt 2) (#6755)
* Make building easier on Windows by setting PowerShell execution policy
* Update build.cake to reference cmd as well as ps1
* remove . on instructions
Shane Neuville [Mon, 1 Jul 2019 16:42:41 +0000 (10:42 -0600)]
Cherry pick Issue4597 fixes back to branch 4.0.0 (#6724)
* Split up Issue4597 into separate testable chunks (#6654)
* split up tests
* fix tests for ios
* comment out tests for UWP for now
* - add delay for loading from uri
- rearrage components so switch is always visible
* add retry logic to url based tests so images can load
* fix automationid binding
* remove extra file
* fix tabs
ShaneN [Sun, 30 Jun 2019 16:02:55 +0000 (10:02 -0600)]
Merge branch '4.1.0'
ShaneN [Sun, 30 Jun 2019 16:02:26 +0000 (10:02 -0600)]
Merge branch '4.0.0' into 4.1.0
Shane Neuville [Sun, 30 Jun 2019 16:00:34 +0000 (10:00 -0600)]
request layout of measure changes force layout if it doesn't (#6704)
campersau [Sun, 30 Jun 2019 08:25:53 +0000 (10:25 +0200)]
fix NRE in InvokeOnMainThreadAsync (#6708)
Rui Marinho [Sat, 29 Jun 2019 14:19:17 +0000 (15:19 +0100)]
Merge branch '4.1.0'
Rui Marinho [Sat, 29 Jun 2019 14:18:41 +0000 (15:18 +0100)]
Merge branch '4.0.0' into 4.1.0
Shane Neuville [Sat, 29 Jun 2019 13:53:38 +0000 (07:53 -0600)]
Split up Issue4597 into separate testable chunks (#6654)
* split up tests
* fix tests for ios
* comment out tests for UWP for now
* - add delay for loading from uri
- rearrage components so switch is always visible
* add retry logic to url based tests so images can load
Samantha Houts [Fri, 28 Jun 2019 18:21:03 +0000 (11:21 -0700)]
Update README.md
Samantha Houts [Fri, 28 Jun 2019 18:11:56 +0000 (11:11 -0700)]
Update README.md
Kevin Petit [Fri, 28 Jun 2019 10:53:49 +0000 (12:53 +0200)]
[Android] Fix various issues in object dispose methods. (#6467)
* Android - Fix various issues in object dispose methods.
* Tear down old element before disposing the ItemViewAdapter.
* More fixes.
* NavigationPageRenderer - Reorder ResetToolbar and remove view before dispose
ShellSectionRenderer - Call base.Destroy last + Remove and destroy _scrollview
* Remove obsolete code.
* Fix build.
Felipe Momm [Fri, 28 Jun 2019 10:52:59 +0000 (07:52 -0300)]
[Shell] MenuItem font image fix (#6628) fixes #6559
* [Shell] FontImageSource not working with MenuItem
* [Shell] Adds missing Binding (FlyoutIcon) for ShellItem
* Revert changes and adjust to change the binding instead
* Replace magic strings for nameof
Shane Neuville [Fri, 28 Jun 2019 10:17:11 +0000 (04:17 -0600)]
return empty dictionary instead of null (#6675) fixes #6614
* return empty dictionary instead of null
* add warning if Element is being reparented
* fix warning message
* only fire warning if parent has inner children