David Shulman [Tue, 17 Jul 2018 02:51:03 +0000 (19:51 -0700)]
Fix HttpWebRequest when using system proxy settings (dotnet/corefx#31100)
While investigating other HttpClient/HttpWebRequest proxy-related bugs, I discovered that
HttpWebRequest was not honoring system proxy settings as defined on Windows with IE
settings or on Linux using environment variables.
The problem is due to how HttpClient and HttpWebRequest differ in how they represent
the default behavior of using system proxy settings with the various properties. Fixed
HttpWebRequest so that it will translate the system proxy settings to the internal
HttpClient/HttpClientHandler objects.
I also removed an invalid Assert in HttpConnection. This assert was firing when using a proxy
that was defined on the loopback adapter using IPv6 literal "[::1]". Due to issue dotnet/corefx#28863 with Uri,
the Uri.IdnHost property doesn't have the brackets for IPv6 literals. So, the Assert was
occuring.
I did not add any new CI tests because it is currently not possible to test system proxy settings
in CI since it involves changing machine configuration. But I ran manual tests.
Commit migrated from https://github.com/dotnet/corefx/commit/
72119235e294e711871cf453f2ffc66ba17ff23b
Matt Mitchell [Mon, 16 Jul 2018 22:57:37 +0000 (15:57 -0700)]
Fix line endings (CRLF->LF) (dotnet/corefx#31108)
Commit migrated from https://github.com/dotnet/corefx/commit/
37f5622a47dac3c1f4cd1ce77b388172d4f9eb95
Jiayi Yu [Mon, 16 Jul 2018 18:55:01 +0000 (11:55 -0700)]
Fix race conditions in DatataContractSerialization (dotnet/corefx#31065)
* Fix some race conditions in DatataContractSerialization
Commit migrated from https://github.com/dotnet/corefx/commit/
2b9fa079f9640a2a2af34eda8be681c9354ef7f0
Keerat Singh [Mon, 16 Jul 2018 17:11:37 +0000 (10:11 -0700)]
Merge pull request dotnet/corefx#30917 from keeratsingh/utf8-feature-extension
Add support for UTF8 Feature Extension
Commit migrated from https://github.com/dotnet/corefx/commit/
06b5dab217d1c00633f6ffad1d00e79669c95a8b
Afsaneh Rafighi [Mon, 16 Jul 2018 17:10:48 +0000 (10:10 -0700)]
Merge pull request dotnet/corefx#31063 from AfsanehR/GithubIssue30720
Added missing #ifnetcoreapp for PoolBlockingPeriod property.
Commit migrated from https://github.com/dotnet/corefx/commit/
6b7572fea79d5979b86acdd333e522d28d94a6df
dotnet-maestro-bot [Sat, 14 Jul 2018 15:30:09 +0000 (08:30 -0700)]
Update CoreClr, CoreFx, CoreSetup to preview1-26714-04, preview1-26714-03, preview1-26714-01, respectively (dotnet/corefx#31072)
Commit migrated from https://github.com/dotnet/corefx/commit/
c3e7ffac564b7133dd5442e2683c360bf8e77e86
Filip Navara [Sat, 14 Jul 2018 09:48:00 +0000 (11:48 +0200)]
Handle empty and disposed certificates in X509Store and X509Chain.
* Ignore removing empty or disposed certificates from X509Store.
* Fix X509Chain.Build with empty certificate.
Commit migrated from https://github.com/dotnet/corefx/commit/
906725f53f9f84a911bcddc60e72ba7abb8adaf8
dotnet-maestro-bot [Sat, 14 Jul 2018 04:45:54 +0000 (21:45 -0700)]
Update BuildTools, CoreClr, ProjectNTfs, ProjectNTfsTestILC to preview1-03013-03, preview1-26714-01, beta-26713-01, beta-26713-01, respectively (dotnet/corefx#31058)
Commit migrated from https://github.com/dotnet/corefx/commit/
bacf617d06bc96d3e98d61bd45e19ed06606b0d0
Jeremy Barton [Sat, 14 Jul 2018 02:09:11 +0000 (19:09 -0700)]
Provide a low-level API for reading and writing PKCSdotnet/corefx#12 (PFX) files
This change adds two top-level classes, Pkcs12Info and Pkcs12Builder, for
reading existing file blobs and creating new ones. These classes, and the
object model they expose/consume, are very raw on top of IETF RFC 7292.
Most user interaction with a PFX file/blob will continue to be with the
X509Certificate2 constructor (and Export method) and the
X509Certificate2Collection Import and Export methods.
Commit migrated from https://github.com/dotnet/corefx/commit/
64477348da1ff57a43deb65a4b12d32986ed00bd
Stephen Toub [Sat, 14 Jul 2018 00:19:41 +0000 (20:19 -0400)]
Fix TransformManyBlock's EnsureOrdered=false to not hold lock while iterating (dotnet/corefx#31059)
When EnsureOrdered is set to false (the default is true) and the max degree of parallelism isn't 1 (meaning it allows for parallelism), TransformManyBlock doesn't employ a reordering buffer but needs to then ensure that the collection it writes the results of the transform to is accessed in a thread-safe manner, so it takes a lock. Currently it takes the lock around the whole enumeration of the result. While that avoids lots of locking/unlocking for cases where the enumerable produces all of its results very quickly, it causes problems when the enumerable may be slow to produce results, as it then ends up serializing the processing of all of the enumerables. The fix is simply to take the lock if it's needed only while adding to the target collection, not while iterating the enumerable.
This change does have a small breaking change potential, in that it's possible someone could have set parallelism to > 1 and set EnsureOrdered to false, and then relied on the lock that was being taken exactly for its serialization, in order to make their delegate effectively thread-safe. But a) EnsureOrdered is a relatively new feature and this setting isn't the default, b) if you've set parallelism to something other than 1, by design you're asking for your delegate to run concurrently with itself. So the chances of actually breaking something with this bug fix are minimal.
Commit migrated from https://github.com/dotnet/corefx/commit/
b64500068a978f0fd96f1dfc8abf1e021b2b83b1
Dan Moseley [Sat, 14 Jul 2018 00:03:51 +0000 (17:03 -0700)]
Update issue-guide.md
Commit migrated from https://github.com/dotnet/corefx/commit/
3c56ee5053d018fc874e6d0d90669cfbb7ab5a9f
Stephen Toub [Fri, 13 Jul 2018 23:58:11 +0000 (19:58 -0400)]
Factor out large generic additions in System.Linq for uap build (dotnet/corefx#31025)
* Factor out large generic additions in System.Linq
New generic types in System.Linq are causing significant size-on-disk increases in AOT builds. This change addresses some of them:
- The many implementations of IPartition and IIListProvider are causing significant binary size increases for AOT. I've factored out the majority of those large changes to only be used in a netcoreapp build, not in a uap build. There are still code paths that test whether an object is IPartition or IIListProvider, but there are no types now in the UAP build that implement them.
- As part of this, I replaced several places where `EmptyPartition<TResult>.Instance` was being used directly to implement an `IEnumerable<T>`, changed them to use `Enumerable.Empty<T>`, and then changed `Enumerable.Empty<T>` so that on netcoreapp it returns `EmptyPartition<TResult>.Instance`, and on uap it returns `Array.Empty<T>`. This also means now that code paths lighting-up on partitions will also light-up on `Enumerable.Empty<T>`. It also means that I changed the empty partition's `IEnumerator.Reset` method to be a nop instead of throwing, to match the same behavior as array's `IEnumerator.Reset`.
- LargeArrayBuilder uses T[][], which introduces lots of new array types and corresponding interface instantiations, helper types, etc. I've specialized LargeArrayBuilder in the UAP build to just be a thin wrapper around ArrayBuilder; we still end up with unnecessary instantiations of LargeArrayBuilder, but they're relatively small, and it saves everything to do with those T[][] instantiations.
* Rename files from netcoreapp/uap to SpeedOpt/SizeOpt
* Fix tests for Reset-becoming-nop change
Commit migrated from https://github.com/dotnet/corefx/commit/
143df51926f2ad397fef9c9ca7ede88e2721e801
Brian Robbins [Fri, 13 Jul 2018 22:44:30 +0000 (15:44 -0700)]
Re-enable Test_BadEventSource_MismatchedIds_WithEtwListener. (dotnet/corefx#31027)
Commit migrated from https://github.com/dotnet/corefx/commit/
911dcaa6b49a8bcc1f39270b8c4f233bd21f7f8d
Afsaneh Rafighi [Fri, 13 Jul 2018 21:49:15 +0000 (14:49 -0700)]
adding more #if netcoreapp where needed
fix #if netcoreapp
Commit migrated from https://github.com/dotnet/corefx/commit/
4fca5c076e03c0c60130d77ab91684ecbaa0f4c5
dotnet-maestro-bot [Fri, 13 Jul 2018 19:44:16 +0000 (12:44 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup to preview1-03013-01, preview1-26713-10, preview1-26713-04, preview1-26713-01, respectively (dotnet/corefx#31055)
Commit migrated from https://github.com/dotnet/corefx/commit/
bff367af9bd900257c75ba08120c8d34a15182d1
Paulo Janotti [Fri, 13 Jul 2018 18:31:23 +0000 (11:31 -0700)]
Globalization coverage: use proper runtimeconfig.json (dotnet/corefx#31054)
Commit migrated from https://github.com/dotnet/corefx/commit/
33230b5fc1e0bf05952c796f75ca81a518f0721d
Steve Pfister [Fri, 13 Jul 2018 17:57:16 +0000 (13:57 -0400)]
Added a preprocessor check for CODEDOM. This will help support frameworks that have not fully incorporated all of corefx and want to use System.Configuration.ConfigurationManager (dotnet/corefx#30943)
Commit migrated from https://github.com/dotnet/corefx/commit/
16a1230577ed71b6f5c34d74bbd1bc14b44fb536
Hugh Bellamy [Fri, 13 Jul 2018 17:39:09 +0000 (18:39 +0100)]
Add Marshal tests and cleanup existing tests a little (dotnet/corefx#30928)
* Add Marshal tests and cleanup existing tests a little
* Split Marshal tests into their own files and add some new tests
* Enable test
* Address PR feedback
* Remove unecessary tests
Commit migrated from https://github.com/dotnet/corefx/commit/
cde110caff0ef993f0db2fde3892e9be6488c3e3
Stephen Toub [Fri, 13 Jul 2018 17:37:53 +0000 (13:37 -0400)]
Add more Int32/Int64 parsing tests (dotnet/corefx#31045)
Add more cases to the Int32 tests, then reuse most of those for Int64 as well.
Commit migrated from https://github.com/dotnet/corefx/commit/
ea000f28a9d24214545db2897fad3ecfcc6cfe6a
Filip Navara [Fri, 13 Jul 2018 17:37:40 +0000 (19:37 +0200)]
Enable compilation with -Wincompatible-pointer-types-discards-qualifiers for native code. (dotnet/corefx#30890)
* Enable compilation with -Wincompatible-pointer-types-discards-qualifiers for native code.
* Temporarily reenable -Wno-incompatible-pointer-types-discards-qualifiers for System.Net.Security.Native.
* Remove unnecessary casts.
* Use a different trick to implement CONST_CAST that doesn't rely on GCC extension.
* Address review comments.
* Fix build.
* Address review comments.
* Remove the duplicate error checks at EnumerateTrust.
* Re-add the code that sets pCertsOut = NULL on error.
* Formatting fixes.
Commit migrated from https://github.com/dotnet/corefx/commit/
810a623ac01236a7fabeabab9c3471fd1d2ede4d
Keerat Singh [Fri, 13 Jul 2018 17:18:52 +0000 (10:18 -0700)]
Added Utf8SupportTest.
Commit migrated from https://github.com/dotnet/corefx/commit/
7fc013c17fb2b2cea007b7403c175b81bcb2f8d3
Alfred Myers [Fri, 13 Jul 2018 14:50:41 +0000 (11:50 -0300)]
Make Thumbprint use GetCertHashString
Matches .NET Framework, and removes redundant work.
Commit migrated from https://github.com/dotnet/corefx/commit/
952b260f230afb771e8aa65586ea213418641082
Stephen Toub [Fri, 13 Jul 2018 13:17:06 +0000 (09:17 -0400)]
Remove stale comment
Commit migrated from https://github.com/dotnet/corefx/commit/
384fa4ad8ed793974218d767aa9e781fb4e99e7c
Filip Navara [Fri, 13 Jul 2018 13:08:05 +0000 (15:08 +0200)]
Expose new SignedXml members that were added in .NET 4.6.2.
Commit migrated from https://github.com/dotnet/corefx/commit/
77f783715f2cdfc00f213551f4d416d70faa81f9
Mike McLaughlin [Fri, 13 Jul 2018 02:36:16 +0000 (19:36 -0700)]
Update symbol uploader to version 1.0.0-beta-63112-02 (dotnet/corefx#31043)
Commit migrated from https://github.com/dotnet/corefx/commit/
041f9198463609caa621dd8e867a1755ecaad1f8
Luqun Lou [Fri, 13 Jul 2018 02:29:52 +0000 (19:29 -0700)]
Remove ExactSpelling = true (dotnet/corefx#31035)
Commit migrated from https://github.com/dotnet/corefx/commit/
fabaf360d608614dc7274373e7369f7cd2d3c3f2
Jiayi Yu [Thu, 12 Jul 2018 22:09:35 +0000 (15:09 -0700)]
Clean up CheckReaderCount and related functions (dotnet/corefx#30995)
* Clean up CheckReaderCount and related methods
Commit migrated from https://github.com/dotnet/corefx/commit/
4113317ebd94cb645ed7a7729cdc4bfe12d4bbaa
Keerat Singh [Thu, 12 Jul 2018 20:35:53 +0000 (13:35 -0700)]
Addressed Saurabh's review feedback.
Commit migrated from https://github.com/dotnet/corefx/commit/
0c591e408df1f3dc8293fb83c9259b6c1e4e9dae
Santiago Fernandez Madero [Thu, 12 Jul 2018 20:14:44 +0000 (13:14 -0700)]
Add placeholder configurations to Microsoft.CSharp and Microsoft.VisualBasic (dotnet/corefx#31033)
Commit migrated from https://github.com/dotnet/corefx/commit/
2a66228c6b466096af73d1ce546365b646b22754
David Shulman [Thu, 12 Jul 2018 19:45:39 +0000 (12:45 -0700)]
Disable PostRewindableStreamContentMultipleTimes test on NETFX (dotnet/corefx#31031)
PR dotnet/corefx#19082 changed .NET Core behavior to no longer dispose request content after send. However, the original behavior remains in .NET Framework. So, the test should be skipped on NETFX.
Closes dotnet/corefx#30987
Commit migrated from https://github.com/dotnet/corefx/commit/
2a5e017d506fc7a2b5a8a7e03a0b87068d28033b
Stephen Toub [Thu, 12 Jul 2018 18:52:31 +0000 (14:52 -0400)]
Expose/test CancellationTokenRegistration.Unregister (dotnet/corefx#31008)
* Expose/test CancellationTokenRegistration.Unregister
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
7e32ee3c9566e0273e479945e0b62750aedf069e
Wes Haggard [Thu, 12 Jul 2018 17:27:02 +0000 (10:27 -0700)]
Merge pull request dotnet/corefx#30853 from weshaggard/FixBlockStable
Allows include build number for packages blocked from going stable
Commit migrated from https://github.com/dotnet/corefx/commit/
626840ef01f614f7651b5c226198c0ad85482091
Anirudh Agnihotry [Thu, 12 Jul 2018 17:19:39 +0000 (10:19 -0700)]
MilliSecond Granualrity added to Copy operation on unix (dotnet/corefx#30996)
* test added
* Test Modified
* Adding Implementation
* tabs removed
* modifyingTest
* Fixing build on HFS
* Space around arithemetic operator
Commit migrated from https://github.com/dotnet/corefx/commit/
387aa6c624f0cc8b1c0c013dfddeb115f7c16e27
dotnet-maestro-bot [Thu, 12 Jul 2018 17:07:13 +0000 (10:07 -0700)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-26712-00, beta-26712-00, respectively (dotnet/corefx#31023)
Commit migrated from https://github.com/dotnet/corefx/commit/
2f19f47c8aebece3fe3f8b44b7f288781d57555a
dotnet-maestro-bot [Thu, 12 Jul 2018 14:44:00 +0000 (07:44 -0700)]
Update CoreClr, CoreFx, CoreSetup to preview1-26712-06, preview1-26712-04, preview1-26712-01, respectively (dotnet/corefx#31010)
Commit migrated from https://github.com/dotnet/corefx/commit/
3c150ba50dc08a1df3ee85cf9f869ff8f933febe
Stephen Toub [Thu, 12 Jul 2018 02:14:44 +0000 (22:14 -0400)]
Ensure ConcurrentBag's TryTake is linearizable (dotnet/corefx#30947)
For .NET Core 2.0, I ported the ThreadPool's work-stealing implementation to ConcurrentBag, leading to significant performance throughput and allocation improvements. However, there's a subtle difference in the concurrency guarantees the ThreadPool's implementation provided from what ConcurrentBag needs, which ends up breaking certain usage patterns on top of ConcurrentBag.
Specifically, ThreadPool's "steal" implementation need not be fully linearizable. It's possible for a thread to see the bag's count as 1, and then while the thread is doing a take/steal for its count to never drop below 1, but for the steal to still fail, even though there was always an item available. This is ok for the thread pool because it manages a known count of work items in the queues separately, and if it sees that there are still items available after a steal has failed, it'll try again. That "try again" logic provided above the work-stealing queue thus didn't make it over to ConcurrentBag, which breaks some usages of ConcurrentBag, in particular cases where a type like BlockingCollection is wrapping the bag and managing its own count. It's possible now for BlockingCollection to know that there's an item in the bag but to then fail to take it, which causes problems such as exceptions being thrown.
The fix is to port back the relevant portion of ConcurrentBag from .NET Core 1.x / .NET Framework, where local push operations on a list track the number of times the list transitions from empty to non-empty. A steal operation then looks at those counts prior to doing the steal, and if the steal fails, it looks again after: if the count has increased, it retries. This unfortunately means that local pushes on small lists are now more expensive than in .NET Core 2.0/2.1, as if there are <= 2 items in the list, it takes the lock, but this seems unavoidable given the work-stealing design.
Commit migrated from https://github.com/dotnet/corefx/commit/
864e82e39b06f7df0acefe822f5c7c48592b53e1
dotnet-maestro-bot [Thu, 12 Jul 2018 00:28:08 +0000 (17:28 -0700)]
Update CoreClr, CoreSetup to preview1-26711-07, preview1-26711-04, respectively (dotnet/corefx#31004)
Commit migrated from https://github.com/dotnet/corefx/commit/
5571df012717b710248d37f4192510fffa49003c
Keerat Singh [Wed, 11 Jul 2018 23:42:10 +0000 (16:42 -0700)]
Merge branch 'master' of https://github.com/dotnet/corefx into utf8-feature-extension
Commit migrated from https://github.com/dotnet/corefx/commit/
d57d3d34c66b7c70e77b7ba4204769575bcff559
Keerat Singh [Wed, 11 Jul 2018 23:41:55 +0000 (16:41 -0700)]
Addressed Uday's review feedback.
Commit migrated from https://github.com/dotnet/corefx/commit/
4b5ba1472d95e77e73309177d76858797f936c4b
Anirudh Agnihotry [Wed, 11 Jul 2018 22:34:47 +0000 (15:34 -0700)]
Porting StandardOleMarshalObject and IMarshal (dotnet/corefx#30931)
* Porting IMarshal
* Writing ref File and minor changes
* ported from .netfx
* formatting and adding aditional files
* Minor fixes
* Feedback addressed
Commit migrated from https://github.com/dotnet/corefx/commit/
f70599a192fcfbeefa52b8ae35a9b1391fe5b809
dotnet-maestro-bot [Wed, 11 Jul 2018 19:38:30 +0000 (12:38 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-03011-03, preview1-26711-05, preview1-26711-05, preview1-26711-01, beta-26711-00, beta-26711-00, respectively (dotnet/corefx#30973)
Commit migrated from https://github.com/dotnet/corefx/commit/
003ce301cd66c353aad84b770dae038de07b75d0
Paulo Janotti [Wed, 11 Jul 2018 17:13:09 +0000 (10:13 -0700)]
Tweaks to reflect current status for coverage. (dotnet/corefx#30967)
Commit migrated from https://github.com/dotnet/corefx/commit/
f8fc5e333e607236f3e2717e5d79d11ebc964622
Ricardo Arenas [Wed, 11 Jul 2018 15:39:53 +0000 (08:39 -0700)]
Merge pull request dotnet/corefx#30975 from riarenas/riarenas/always-run-end-script
Always run end.sh/ps1 step
Commit migrated from https://github.com/dotnet/corefx/commit/
e2c27b7d6fa230c89bf78c4a5ff2bb440fabe936
Maxim Lipnin [Wed, 11 Jul 2018 13:24:45 +0000 (16:24 +0300)]
Fixing Pkcs9SigningTime behavior on the X.509 Time UtcTime range [1950;2049)
Add AsnWriter.WriteUtcTime overload to align the behavior of Pkcs9SigningTime type on the X.509 Time range [1950;2049)
Commit migrated from https://github.com/dotnet/corefx/commit/
ba36ab8bcf157b8181e52a7b29a226d9202bf92d
Maxim Lipnin [Wed, 11 Jul 2018 13:18:23 +0000 (16:18 +0300)]
Bring the AlgorithmIdentifier.Parameters property back
Add AlgorithmIdentifier.Parameters, but always set it to the empty array.
There aren't any really understood scenarios for why someone would want to read the algorithm parameters. Combined with .NET Framework only assigning a non-empty value some of the time, never assigning the correct value, and not having a consistent incorrect value, the empty array seemed the best thing for now.
Commit migrated from https://github.com/dotnet/corefx/commit/
64bab987f50b399b78cc1dc23a8e42325e5e175a
Paulo Janotti [Wed, 11 Jul 2018 00:10:07 +0000 (17:10 -0700)]
Small updates regarding code coverage (dotnet/corefx#30966)
* Small updates regarding code coverage
* Update developer-guide.md
* PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
f9f200e53600fa4af761ce59e44921b607cbe905
Paulo Janotti [Tue, 10 Jul 2018 23:43:34 +0000 (16:43 -0700)]
Reduce coverage run timeout (dotnet/corefx#30972)
Commit migrated from https://github.com/dotnet/corefx/commit/
9a2ff8365d923b0efbefb97d6001707607a2991e
Santiago Fernandez Madero [Tue, 10 Jul 2018 23:42:08 +0000 (16:42 -0700)]
Cleanup in System.Drawing, remove usings and add Gdip alias to SafeNativeMethods (dotnet/corefx#30970)
Commit migrated from https://github.com/dotnet/corefx/commit/
9a507ddef293dbbefe89b4711a7b7d981fa227e8
Santiago Fernandez Madero [Tue, 10 Jul 2018 22:04:27 +0000 (15:04 -0700)]
Update netfx alias to target .NET 4.7.2 (dotnet/corefx#28883)
* Change netfx to target .NET 4.7.1
* Fix CoreFx.Private.TestUtilities to not reference System.Runtime.InteropServices.RuntimeInformation which is now inbox in netfx
* Fix StackTrace.Tests to be built against netstandard and run against netfx inbox
* Fix ValueTuple configurations to support net461 and add netfx placeholder configuration since in net471 it is now inbox
* Fix projects' package configurations that had netfx (net461) to still support net461 and netfx as a buildconfigurations
* Disable failing tests when running on .NET 4.7.1
* Make netfx target net472 and merge with master
* Update ActiveIssue comments to issue number only
* Workaround packages tests due to not installed targeting pack
* Match NSSupportPackage version to CLI's
* Remove netstandard support lib bin placing to runtime and testhost for netfx, fix reference paths to match new package
* Run UpdateVSConfigurations after merging conflicts with the newly updated SDK projects
* Add net461 package configuration to System.CodeDom
* Add net461 package configuration to System.Configuration.ConfigurationManager
* Add net461 package configuration to System.Security.Cryptography.Xml
* Add net461 package configuration to System.Security.Permissions
* Add net461 package configuration to System.ServiceModel.Syndication
Commit migrated from https://github.com/dotnet/corefx/commit/
faad2e63b35bed10fe18195987a413308b97eded
Ricardo Arenas [Tue, 10 Jul 2018 21:42:47 +0000 (14:42 -0700)]
always run end.ps1 step
Commit migrated from https://github.com/dotnet/corefx/commit/
eb3e94f9d4f49c1191ce6abe3c3fe05b69f21656
Wes Haggard [Tue, 10 Jul 2018 18:45:03 +0000 (11:45 -0700)]
Merge pull request dotnet/corefx#30949 from eerhardt/DowngradeCLIVersion
Downgrade CLI version to 2.1.401-preview-009081.
Commit migrated from https://github.com/dotnet/corefx/commit/
8d97d4d3d375b880d265f403eb55bf5570c1890d
Max Kerr [Tue, 10 Jul 2018 17:18:56 +0000 (10:18 -0700)]
Add support and tests for HTTP 308 Permanent Redirect (dotnet/corefx#30398)
This change adds support for 308 redirects to SocketsHttpHandler, and enables 308 redirects in our tests.
Fixes: dotnet/corefx#30389
Commit migrated from https://github.com/dotnet/corefx/commit/
12e41edba6c9b177f21e30001ce3c890c5225132
Eric Erhardt [Tue, 10 Jul 2018 16:50:03 +0000 (11:50 -0500)]
Downgrade CLI version to 2.1.401-preview-009081.
We temporarily needed to bump the CLI version to 3.0 builds because of https://github.com/dotnet/core-setup/issues/4291. But now that we have a 2.1 servicing build with this change, we can downgrade to that build.
Commit migrated from https://github.com/dotnet/corefx/commit/
f77c1474defafb16754a034edf67daa2f0f42732
Maryam Ariyan [Tue, 10 Jul 2018 16:09:46 +0000 (12:09 -0400)]
Proper fix for compilation issue caused by deprecated API in Mojave (dotnet/corefx#30815)
* Proper fix for compilation issue caused by deprecated API in macOS Mojave by
using dlsym to call available API rather than suppressing deprecation warnings.
Fixes: dotnet/corefx#30599
Commit migrated from https://github.com/dotnet/corefx/commit/
92b4826a7648b05678e9340e98af3453a9d064a2
Filip Navara [Tue, 10 Jul 2018 16:00:10 +0000 (18:00 +0200)]
Add support for custom macOS keychains exposed using X509Store API
Support the custom keychain-based stores only for StoreLocation.CurrentUser
Update documentation to reflect the changes.
Commit migrated from https://github.com/dotnet/corefx/commit/
188e1749df0a3ef53afb81dd2da29987bf17f15c
dotnet-maestro-bot [Tue, 10 Jul 2018 15:26:14 +0000 (08:26 -0700)]
Update CoreClr to preview1-26710-05 (dotnet/corefx#30944)
Commit migrated from https://github.com/dotnet/corefx/commit/
5d8630d1272dcd5ab83c6ed10313196de0a11b5f
Viktor Hofer [Tue, 10 Jul 2018 13:03:23 +0000 (15:03 +0200)]
Use IEqualityComparer<T> instead of IComparer<T> during HashSet serialization (dotnet/corefx#30912)
* Use IEqualityComparer<T> instead of IComparer<T> during HashSet serialization
* Enable type value assignability check for serializable types
* Enable typeobject integrity for netfx
Commit migrated from https://github.com/dotnet/corefx/commit/
fe5927a0f68717223528220c891a3b02d7331829
dotnet-maestro-bot [Tue, 10 Jul 2018 11:36:30 +0000 (04:36 -0700)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-26710-00, beta-26710-00, respectively (dotnet/corefx#30935)
Commit migrated from https://github.com/dotnet/corefx/commit/
81a246f3adf1eece3d981f1d8bb8ae9de12de9c6
Zeng Jiang [Tue, 10 Jul 2018 11:36:10 +0000 (19:36 +0800)]
Disable Marshal API test NullValueArguments_ThrowsAccessViolationException() of ObjectTests.cs for NetFx. (dotnet/corefx#30937)
Commit migrated from https://github.com/dotnet/corefx/commit/
f09fdb4a08992bce31f29b08f93ef3311dbcc181
dotnet-maestro-bot [Tue, 10 Jul 2018 03:05:15 +0000 (20:05 -0700)]
Update BuildTools, CoreClr, CoreSetup to preview1-03010-01, preview1-26710-01, preview1-26709-03, respectively (dotnet/corefx#30932)
Commit migrated from https://github.com/dotnet/corefx/commit/
28f10d9057311ee21969ce1416a5196788f97086
Afsaneh Rafighi [Tue, 10 Jul 2018 02:46:55 +0000 (19:46 -0700)]
Update PoolBlockPeriodTest to check if connection string is setup (dotnet/corefx#30856)
* check if connectionString is setup for PoolBlockPeriodTest
* update test per Stephen and Keerat's comments
Commit migrated from https://github.com/dotnet/corefx/commit/
caef3e7049ee5767719a7697afd36d8f4e57e705
Anirudh Agnihotry [Tue, 10 Jul 2018 00:35:11 +0000 (17:35 -0700)]
Test fot setting up appcontext.TargetFramework (dotnet/corefx#30885)
* Tests for targetFramework
* Feedback addressed
* Fixing tests for netfx
Commit migrated from https://github.com/dotnet/corefx/commit/
7c28084bb60689f15fc6119c3d11964a5335c4f5
Filip Navara [Tue, 10 Jul 2018 00:09:24 +0000 (02:09 +0200)]
Replace pkcs7_[new/content_new/set_type/add_certificate] with single pkcs7_sign call.
Replace pkcs7_[new/content_new/set_type/add_certificate] with single pkcs7_sign call via Pkcs7CreateCertificateCollection.
Commit migrated from https://github.com/dotnet/corefx/commit/
63d4ad5ca72e91ad6798c6f6c27af348002e98f3
Paulo Janotti [Mon, 9 Jul 2018 23:36:34 +0000 (16:36 -0700)]
Coverage runs are being aborted: increase timeout (dotnet/corefx#30922)
Commit migrated from https://github.com/dotnet/corefx/commit/
7e807db2a42cef08928db09377b9291aeaec42e9
Eric Erhardt [Mon, 9 Jul 2018 19:21:40 +0000 (14:21 -0500)]
Fix optional tooling restore (dotnet/corefx#30918)
With the SDK-style project change, all properties from the root Directory.Build.props are being imported into optional.csproj. The RestoreSources property overwrites any sources specified in the NuGet.config, which means the restore fails to find the packages.
The fix is to blank out RestoreSources so the NuGet.config sources are used.
Fix dotnet/corefx#30906
Commit migrated from https://github.com/dotnet/corefx/commit/
d327f8174110750a2e4a57bdaf8742efe2a56e56
Filip Navara [Mon, 9 Jul 2018 17:14:27 +0000 (19:14 +0200)]
Parse the OpenSSL version from the SSLeay numerical value instead of the SSLeay_version string.
Commit migrated from https://github.com/dotnet/corefx/commit/
711c42810b8b9f8b7736b7b175cf9e330932b5f3
Filip Navara [Mon, 9 Jul 2018 17:08:50 +0000 (19:08 +0200)]
Drop pal_asn1_print in favor of the managed code
* Drop pal_asn1_print in favor of the managed code that is already used on macOS.
* Add handling of T61 strings to ManagedCertificateFinder.DerStringToManagedString.
Commit migrated from https://github.com/dotnet/corefx/commit/
acb18506a56eda3a7e056cd597b20f4049f36038
Filip Navara [Mon, 9 Jul 2018 17:04:27 +0000 (19:04 +0200)]
Relax the error checking code to cater for different OpenSSL versions.
Commit migrated from https://github.com/dotnet/corefx/commit/
74e3d35a1e41f74e6549365338e79a335fadba78
Viktor Hofer [Mon, 9 Jul 2018 16:11:38 +0000 (18:11 +0200)]
Remove duplicate dependencies.props import (dotnet/corefx#30907)
Commit migrated from https://github.com/dotnet/corefx/commit/
774a0b4d3cf39d078d3c8c6b8ff02fd6a7a04022
Keerat Singh [Mon, 9 Jul 2018 15:42:25 +0000 (08:42 -0700)]
Merge branch 'master' of https://github.com/dotnet/corefx into utf8-feature-extension
Commit migrated from https://github.com/dotnet/corefx/commit/
0c7c62794ff9631e63d59bbd80527a0e5c99fa57
Filip Navara [Mon, 9 Jul 2018 15:04:46 +0000 (17:04 +0200)]
Replace SecureStringMarshal with Marshal calls. (dotnet/corefx#30908)
Commit migrated from https://github.com/dotnet/corefx/commit/
00454c4d8cc9c036d47336b9b320c08d5d700274
dotnet-maestro-bot [Mon, 9 Jul 2018 15:04:31 +0000 (08:04 -0700)]
Update CoreClr, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-26709-05, preview1-26709-01, beta-26709-00, beta-26709-00, respectively (dotnet/corefx#30902)
Commit migrated from https://github.com/dotnet/corefx/commit/
265b4f606baf9f6e7fe0c6e2d5e0be6b7f5a592f
dotnet-maestro-bot [Mon, 9 Jul 2018 02:09:41 +0000 (19:09 -0700)]
Update CoreClr, CoreSetup to preview1-26709-01, preview1-26708-03, respectively (dotnet/corefx#30901)
Commit migrated from https://github.com/dotnet/corefx/commit/
87ed90733ec4b307c4d39b541ad4ad893f438f4a
Eric Erhardt [Sun, 8 Jul 2018 20:58:13 +0000 (15:58 -0500)]
Merge pull request dotnet/corefx#29831 from wtgodbe/SdkProj
Convert all projects to SDK-style
Commit migrated from https://github.com/dotnet/corefx/commit/
0b0f63d47951773cc46393312d80b40176d3a413
dotnet-maestro-bot [Sun, 8 Jul 2018 15:17:45 +0000 (08:17 -0700)]
Update CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-26708-04, preview1-26708-04, preview1-26708-01, beta-26707-00, beta-26707-00, respectively (dotnet/corefx#30883)
Commit migrated from https://github.com/dotnet/corefx/commit/
af8f03ce8b0c6e16cb28dda27d637356fde4c99b
Stephen Toub [Sun, 8 Jul 2018 13:07:53 +0000 (09:07 -0400)]
Fix interop test expecting ArgumentNullException (dotnet/corefx#30895)
Commit migrated from https://github.com/dotnet/corefx/commit/
a51556435393cf9ad4b9a3fac9b27bcc5ae1ea9e
Eric Erhardt [Sat, 7 Jul 2018 16:03:56 +0000 (11:03 -0500)]
Merge master into SdkProj
Commit migrated from https://github.com/dotnet/corefx/commit/
99e21e612ddd8fbd23bb760e9c802ca2cfc01d4a
Zeng Jiang [Sat, 7 Jul 2018 00:21:05 +0000 (08:21 +0800)]
Port Marshal API tests from CoreCLR (dotnet/corefx#30690)
* Port Marshal API tests from CoreCLR
* Fix comments about Marshal API tests
* Fis comments from code review for porting Marshal API.
* Scope Marshal API tests about Variant type for Windows only
* Scope Marshal.*UTF8* API testcases only for NetCoreApp.
* Fix Marshal\PtrToStringTests.cs compile issue in linux
* Scope Marshal API test TestFieldAlignment_Variant test for Windows only
* Change the private property to public in a Struct in OffsetOfTest.cs
* Disable test NullValueArguments_ThrowsArgumentNullException with issue dotnet/corefx#30830
* Fix failing test NonGenericOffEqualsGenericOffset() in OffsetOfTests.cs
* Disable Marshal API test GetExceptionForHR_EqualsErrorCode() with dotnet/corefx#30866
Commit migrated from https://github.com/dotnet/corefx/commit/
9ebc30a73c52f78a3d9d2b79a8bb4e848f39b29b
Stephen Toub [Fri, 6 Jul 2018 21:07:51 +0000 (17:07 -0400)]
Update concurrent socket disposal test to accomoate UAP (dotnet/corefx#30874)
Apparently if a socket is disposed of while it's in use, we can get an SEHException back from the P/Invoke, presumably due to the OS code trying to throw an SEH exception out of the call. Just update the test to accomodate this when IsUap is true.
Commit migrated from https://github.com/dotnet/corefx/commit/
33f1a2a0cd9c2a4a6893a0794c747f66ad2cc401
Viktor Hofer [Fri, 6 Jul 2018 20:46:51 +0000 (22:46 +0200)]
Add CompareInfo and Span.IndexOf with string comparison benchmark tests (dotnet/corefx#30837)
* Add CompareInfo string perf tests
* Add Span.IndexOf with stringcomparison benchmark
* Add more permutations and different cultures
Commit migrated from https://github.com/dotnet/corefx/commit/
f641a94ce4b31e01666ff6585adc42afcb925693
Wes Haggard [Fri, 6 Jul 2018 20:04:24 +0000 (13:04 -0700)]
Merge pull request dotnet/corefx#30875 from gbalykov/update-tizen-rid-for-netcore-app
Add Tizen 5.0 RID for NETCoreApp
Commit migrated from https://github.com/dotnet/corefx/commit/
e38aaa519d47389acaf66eda36346662ffd033c2
Eric Erhardt [Fri, 6 Jul 2018 19:51:52 +0000 (14:51 -0500)]
Merge remote-tracking branch 'upstream/master' into SdkProj
Commit migrated from https://github.com/dotnet/corefx/commit/
b86cade27ef07e6be4bc6b4cd50a4ad0892de8bf
Eric Erhardt [Fri, 6 Jul 2018 19:51:08 +0000 (14:51 -0500)]
Set TargetFramework to workaround project system bug.
Commit migrated from https://github.com/dotnet/corefx/commit/
aa89672cb15f11f711ba4c0232b88b706ffe736f
Stephen Toub [Fri, 6 Jul 2018 18:36:57 +0000 (14:36 -0400)]
Merge pull request dotnet/corefx#30840 from dotnet-maestro-bot/master-UpdateDependencies
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-03005-04, preview1-26706-05, preview1-26706-05, preview1-26705-01, beta-26705-00, beta-26705-00, respectively (master)
Commit migrated from https://github.com/dotnet/corefx/commit/
8274060481903a4ffffcf53e448be7c7e497c55d
Stephen Toub [Fri, 6 Jul 2018 18:33:53 +0000 (14:33 -0400)]
Augment UnixFileSystemTypes with additional values (dotnet/corefx#30872)
Based on cross-referencing with Mono, adding in a few items it had that were missing here, and recategorizing a few to match its categorization (after also doing some internet searches to corroborate).
Commit migrated from https://github.com/dotnet/corefx/commit/
d96d7a1a98b0623e0171efe3731348942b484149
Stephen Toub [Fri, 6 Jul 2018 17:03:02 +0000 (13:03 -0400)]
Fix System.Drawing test for fixed Marshal.Read(null) behavior
Commit migrated from https://github.com/dotnet/corefx/commit/
ecb7b2551f3f115da05be112e324e017b4cd7f0e
Stephen Toub [Fri, 6 Jul 2018 16:22:47 +0000 (12:22 -0400)]
Disable failing EventSource test
Commit migrated from https://github.com/dotnet/corefx/commit/
079ad108a4b08b771801dec63f921eb185202969
dotnet-maestro-bot [Fri, 6 Jul 2018 14:25:32 +0000 (07:25 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-03005-04, preview1-26706-05, preview1-26706-05, preview1-26705-01, beta-26705-00, beta-26705-00, respectively
Commit migrated from https://github.com/dotnet/corefx/commit/
beda8c1e4eb00a3db36abc72f4f41af48dac5c9c
Stephen Toub [Fri, 6 Jul 2018 16:28:31 +0000 (12:28 -0400)]
Add more DateTime{Offset}.ParseExact "o"/"r" tests (dotnet/corefx#30860)
Commit migrated from https://github.com/dotnet/corefx/commit/
0956f3e2122802776ebe1ec614ead2dd4267def9
Jan Kotas [Fri, 6 Jul 2018 16:13:51 +0000 (09:13 -0700)]
Delete obsolete ResourceConsumption/ResourceExposure attributes (dotnet/corefx#30863)
These are leftovers from unfinished experiment that a long time ago.
Commit migrated from https://github.com/dotnet/corefx/commit/
501d1566e85d0777b66d6ad44ecd8efd30a0e149
Gleb Balykov [Fri, 6 Jul 2018 15:49:57 +0000 (18:49 +0300)]
Add Tizen 5.0 RID for NETCoreApp
Commit migrated from https://github.com/dotnet/corefx/commit/
94b7c995979e0fad54880607c7390e9af84208eb
Mateus Rodrigues de Morais [Fri, 6 Jul 2018 00:43:20 +0000 (21:43 -0300)]
Fixed getmntinfo() call on FreeBSD (dotnet/corefx#30851)
* fix test for System.IO.FileSystem.DriveInfo.Tests.dll
* change 1 for MNT_WAIT for better readability
* moved directives to beginning of the line
* removed special case for FreeBSD and made it general
Commit migrated from https://github.com/dotnet/corefx/commit/
0e021636e10782fdd0245fb0cb3ba3986b60dce8
Tomas Weinfurt [Fri, 6 Jul 2018 00:33:48 +0000 (17:33 -0700)]
changes to support FreeBSD build (dotnet/corefx#30832)
Commit migrated from https://github.com/dotnet/corefx/commit/
e3fb5bfd0f4a3b4be5170099a441562ce929b84f
Eric Erhardt [Fri, 6 Jul 2018 00:22:10 +0000 (19:22 -0500)]
Merge master into SdkProj
Commit migrated from https://github.com/dotnet/corefx/commit/
e72643b4aab4b33a33baad1fa74b0551cc2cf739
Eric Erhardt [Thu, 5 Jul 2018 19:26:05 +0000 (14:26 -0500)]
Fix up new projects and usages of dir.props/targets.
Commit migrated from https://github.com/dotnet/corefx/commit/
9b7b8c0b63b7c35a13a91310b141fca8ee2b3d6f
Viktor Hofer [Thu, 5 Jul 2018 21:02:56 +0000 (23:02 +0200)]
Update stable packages for System.Composition.*
Commit migrated from https://github.com/dotnet/corefx/commit/
c06df8e5f3877ddd3fd1a75b1d4d494268acce7f
Viktor Hofer [Thu, 5 Jul 2018 18:43:00 +0000 (20:43 +0200)]
Cleanup System.Composition
Commit migrated from https://github.com/dotnet/corefx/commit/
6b0c1b7b4be9b8085b2ac6d9390834500576b99d
Viktor Hofer [Thu, 5 Jul 2018 18:20:58 +0000 (20:20 +0200)]
Remove NS1.0 build from System.Composition.Runtime
Commit migrated from https://github.com/dotnet/corefx/commit/
024abaf4e2b11e1c48c012b20574e0fd30ee2f09
Viktor Hofer [Thu, 5 Jul 2018 17:52:28 +0000 (19:52 +0200)]
Delte unused System.ComponentModel.Composition code in favor of shared code
Commit migrated from https://github.com/dotnet/corefx/commit/
b21614896065ca6525b4caba23e450810860970f
Viktor Hofer [Thu, 5 Jul 2018 16:48:46 +0000 (18:48 +0200)]
Cleanup and remove NS1.0 build from System.Composition.TypedParts
Commit migrated from https://github.com/dotnet/corefx/commit/
3982f782e86adefbdf15385d6fc29279d66e1a54