Chris Michael [Wed, 29 Aug 2018 17:15:20 +0000 (13:15 -0400)]
evas-canvas: Add missing EINA_UNUSED for unused parameter
Wonki Kim [Wed, 29 Aug 2018 12:38:20 +0000 (21:38 +0900)]
scroller: removes unused variables
Summary: this patch removes some variables that are unused.
Reviewers: Hermet, eagleeye, zmike
Reviewed By: Hermet
Subscribers: #reviewers, cedric, #committers, zmike
Tags: #efl_widgets
Differential Revision: https://phab.enlightenment.org/D6593
Yeongjong Lee [Wed, 29 Aug 2018 12:11:00 +0000 (21:11 +0900)]
evas: call evas_find before safety check
Summary:
edje_edit_object_add
edje_object_add
emotion_object_add
evas_object_xxx_add
These APIs had allowed to set parent to EFL_CANVAS_OBJECT(Evas_Object) before
8bb11a17. we should call evas_find before safety check for backward compatibility.
Test Plan:
win = elm_win_add(NULL, "main", ELM_WIN_BASIC);
1. `rect = evas_object_rectangle_add(evas_object_evas_get(win));`
2. `rect = evas_object_rectangle_add(win);`
Check that 1. and 2. works.
Reviewers: Hermet, zmike
Reviewed By: Hermet
Subscribers: cedric, #reviewers, CHAN, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6909
Shinwoo Kim [Wed, 29 Aug 2018 07:05:35 +0000 (16:05 +0900)]
Elm.Mapbuf: do not set is_static_clip to its content
Summary:
If an object's is_static_clip is TRUE
then _evas_render_phase1_object_process does not draw the object and its smart
member from the below commit (1).
On the other hand, the Elm.Mapbuf sets is_static_clip to its content from the
below commit (2). So you cannot see the content. If the commit tried to solve
over-render, it could be changed to:
if (wd->content) evas_object_static_clip_set(wd->content, !wd->enabled);
from:
if (wd->content) evas_object_static_clip_set(wd->content, wd->enabled);
or there could be another way.
(1) commit
1bba6d5759d859d0db9ad5b5556883044d3a1b11
Author: Carsten Haitzler (Rasterman) <raster@rasterman.com>
Date: Wed Nov 23 13:57:27 2016 +0900
evas phase 1 process - shortcut objects that are pure static clips only
these objects don't actually produce - or should produce update
regions etc. etc. as the objects that are clipped should produce those.
they are not active objects. so skip them very early after just
ensuring they are in delete objects if needed.
(2) commit
7ca0a3dcac2ee7fc7d7ae62277dde05a3b77b276 (of core/elementary.git)
Author: Carsten Haitzler <raster@rasterman.com>
Date: Wed Jan 19 11:59:53 2011 +0000
fix over-render bug in map/mapbuf and with changed flags! that was
nasty to find!
SVN revision: 56220
Test Plan:
[Sample Code]
#include <Elementary.h>
EAPI_MAIN int
elm_main(int argc EINA_UNUSED, char **argv EINA_UNUSED)
{
Evas_Object *win, *bx, *mb, *layout, *icon;
unsigned int i, j;
char buf[255];
elm_policy_set(ELM_POLICY_QUIT, ELM_POLICY_QUIT_LAST_WINDOW_CLOSED);
win = elm_win_util_standard_add("mapbuf", "Mapbuf Example");
elm_win_autodel_set(win, EINA_TRUE);
bx = elm_box_add(win);
evas_object_size_hint_weight_set(bx, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
elm_win_resize_object_add(win, bx);
evas_object_show(bx);
mb = elm_mapbuf_add(win);
evas_object_size_hint_weight_set(mb, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
evas_object_size_hint_align_set(mb, EVAS_HINT_FILL, EVAS_HINT_FILL);
elm_box_pack_end(bx, mb);
layout = elm_layout_add(win);
evas_object_size_hint_weight_set(layout, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
elm_win_resize_object_add(win, layout);
snprintf(buf, sizeof(buf), "/home/kimcinoo/Upstream/efl/src/examples/elementary/layout_example.edj");
elm_layout_file_set(layout, buf, "example/mylayout");
evas_object_show(layout);
icon = elm_icon_add(win);
elm_icon_standard_set(icon, "home");
evas_object_size_hint_weight_set(icon, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
evas_object_size_hint_align_set(icon, EVAS_HINT_FILL, EVAS_HINT_FILL);
evas_object_show(icon);
elm_object_part_content_set(layout, "example/custom", icon);
elm_object_content_set(mb, layout);
evas_object_show(mb);
elm_mapbuf_enabled_set(mb, EINA_TRUE);
evas_object_resize(win, 240, 320);
evas_object_show(win);
elm_run();
return 0;
}
ELM_MAIN()
Reviewers: raster, Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6915
Wonki Kim [Wed, 29 Aug 2018 06:58:10 +0000 (15:58 +0900)]
scroller: refactory a momentum scroll animator
Summary:
this patch refactories a momentum scroll animator logics.
1. animation duration
animating runs within a one second now.
and if it needs more time to animate, it decrease intepolation progress by dividing some value.
current logic makes sense however, it is not easy to read to know how it works.
this patch modify current logic to calculate distance to move, and time to animate.
2. distance to move
we can apply simple physics something like mass of pan and friction of scroller itself.
but this patch apply just geometric seqeunce to calculate distance to go.
it's more easy to customize behavior of scroller than current sine graph based one.
3. accelerate logic
scroller sets 'extra_time' to accelerate a scroller for now.
but this patch modify logic not to use it.
however it uses current momenutum velocity as a bais of next momentum animating.
@feature
Reviewers: zmike, #reviewers, Hermet
Reviewed By: #reviewers, Hermet
Subscribers: Hermet, cedric, zmike
Tags: #efl, #do_not_merge
Differential Revision: https://phab.enlightenment.org/D6643
WooHyun Jung [Wed, 29 Aug 2018 06:56:46 +0000 (15:56 +0900)]
efl_selection_manager: sync with upstream structure member
@tizen_fix
Change-Id: I4a18abe125ebb923055b59b85b4a4de13afe73b9
Signed-Off-By: Hermet Park <chuneon.park@samsung.com>
SooChan Lim [Tue, 28 Aug 2018 06:01:18 +0000 (15:01 +0900)]
ecore_buffer: fix the typo
Change-Id: I46a8c114efac7be6b560caf3362ac7cecaef2a52
Taehyub Kim [Mon, 27 Aug 2018 06:48:35 +0000 (15:48 +0900)]
efl_selection_manager: support HTML format for copy and paste
Change-Id: I92b66bf5623c0de4acb8f12f27110191396edf33
Hermet Park [Mon, 27 Aug 2018 05:34:25 +0000 (14:34 +0900)]
elementary: disable elocation header dependency.
It's not mandatory yet(even in BETA API) in Tizen.
rootstrap had a issue if elocation package is not installed.
Change-Id: Ife649836fbbe21548e084a3803297b40169e4c4a
Jeonghyun Yun [Wed, 22 Aug 2018 10:48:41 +0000 (19:48 +0900)]
scroller: set focus to focus next object when next object is outside the viewport
@tizen_fix
Change-Id: I0e9717e6bea39903cc8683a353203162c6cfb60c
Signed-off-by: Jeonghyun Yun <jh0506.yun@samsung.com>
Taehyub Kim [Fri, 24 Aug 2018 03:19:42 +0000 (12:19 +0900)]
efl_selection_manager: fix getting wayland display in _wl_dnd_drop function
Change-Id: I937f14e879b93f95b736b88be61878c9476b4efc
Hermet Park [Wed, 29 Aug 2018 04:57:45 +0000 (13:57 +0900)]
evas gl: remove redundant code.
Reviewers: devilhorns, #committers, raster
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6901
Hermet Park [Mon, 27 Aug 2018 07:39:22 +0000 (07:39 +0000)]
evas cache: code refactoring.
rename to proper internal variables.
Differential Revision: https://phab.enlightenment.org/D6911
Hermet Park [Mon, 27 Aug 2018 05:43:34 +0000 (05:43 +0000)]
elementary main: fix typo
Differential Revision: https://phab.enlightenment.org/D6910
Jaehyun Cho [Mon, 27 Aug 2018 05:23:00 +0000 (05:23 +0000)]
elementary: Remove multiple class inheritance in eo
Up to now, there is no restriction on using multiple class inheritance
in eo.
This makes some language bindings more complicated if the language does
not support multiple class inheritance. e.g. C#.
To support language bindings in a neat way, multiple class inheritance
in eo is replaced with implementing interfaces.
To remove multiple class inheritance, each part class in elementary
should implement interfaces instead of inheriting from other widget
class because part class in elementary basically inherit from the class
Efl.Ui.Widget_Part.
Differential Revision: https://phab.enlightenment.org/D6904
Mike Blumenkrantz [Mon, 27 Aug 2018 03:15:09 +0000 (12:15 +0900)]
tests/elm: further reduce buffer render interval
Summary: this further increases the speed at which some tests perform
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric
Tags: #do_not_merge
Differential Revision: https://phab.enlightenment.org/D6765
Ross Vandegrift [Mon, 27 Aug 2018 03:10:12 +0000 (12:10 +0900)]
Format-string harden eina_strbuf_append_printf use
Summary:
gcc -Werror=format-security flags this for lacking a format string. Fixes:
https://phab.enlightenment.org/T7325
Reviewers: #committers, Hermet
Reviewed By: #committers, Hermet
Subscribers: Hermet, cedric, #reviewers, #committers, zmike
Tags: #efl
Maniphest Tasks: T7325
Differential Revision: https://phab.enlightenment.org/D6867
Mike Blumenkrantz [Mon, 27 Aug 2018 03:09:49 +0000 (12:09 +0900)]
efl/timer: correctly handle timer freeze during construction
Summary:
it is not correct to throw an error when methods are called during
construction
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: Hermet, cedric, #reviewers, #committers
Tags: #efl_main_loop
Differential Revision: https://phab.enlightenment.org/D6787
Jean Guyomarc'h [Mon, 27 Aug 2018 03:04:35 +0000 (12:04 +0900)]
ecore: fix built-in event types generation
Summary:
Ecore internally uses 10 events, from ECORE_EVENT_SIGNAL_USER=1 to
ECORE_EVENT_SYSTEM_TIMEDATE_CHANGED=10. The Ecore.Event.Message_Handler
singleton that holds the counter of events is initialized with -1.
This is followed in _ecore_event_init() by ten calls to
ecore_event_message_handler_type_new(), which increase the counter of
event by one each.
This results in an event counter to be 9 (-1 + 10) at the end of the
initialization of ecore_events. This means that the next event to be
created will have a value of 10, which will overlap with
ECORE_EVENT_SYSTEM_TIMEDATE_CHANGED. As such, these two distinct events
will be aliased and their associated handlers will be called at
unexpected times, with unexpected data.
By changing the constructor value from -1 to 0, we prevent this event
aliasing.
Fixes T6605
Reviewers: zmike, Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Maniphest Tasks: T6605
Differential Revision: https://phab.enlightenment.org/D6894
Xavi Artigas [Fri, 24 Aug 2018 15:10:57 +0000 (12:10 -0300)]
efl-mono: properly close XML comment
Summary:
XML document generation was skipping the rest of this file because of a missing
XMl closing tag. Fortunately, it was almost at the end of the file.
Reviewers: lauromoura, vitor.sousa, felipealmeida
Reviewed By: vitor.sousa
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6905
Lauro Moura [Fri, 24 Aug 2018 14:33:46 +0000 (11:33 -0300)]
csharp: Fix event registration in constructor.
Summary:
The binding user should be able to register to events inside the initialization callback given to the constructor.
Fixes T7346
Reviewers: segfaultxavi, felipealmeida, vitor.sousa
Reviewed By: segfaultxavi, vitor.sousa
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Maniphest Tasks: T7346
Differential Revision: https://phab.enlightenment.org/D6908
Marcel Hollerbach [Fri, 24 Aug 2018 14:04:33 +0000 (16:04 +0200)]
Revert "efl_ui_focus_manager: do not adjust values on a inactive manager"
Sorry this was a accident
This reverts commit
a6ee2061a31a73a7b71d2142912da583933ed6d2.
Mike Blumenkrantz [Tue, 14 Aug 2018 15:03:53 +0000 (11:03 -0400)]
elm/config: use correct function to return audio mute value
when setting this config value an elm function is used to store the
setting internally, so it's necessary to use the elm getter function
in order to correctly (and accurately) return the same state
resolves test failures in elm_config
Differential Revision: https://phab.enlightenment.org/D6825
Marcel Hollerbach [Wed, 22 Aug 2018 21:05:59 +0000 (23:05 +0200)]
efl_ui_focus_manager: do not adjust values on a inactive manager
Differential Revision: https://phab.enlightenment.org/D6903
Mike Blumenkrantz [Wed, 15 Aug 2018 17:03:55 +0000 (13:03 -0400)]
tests/eio: add explicit test for eio_monitor_path_get()
Differential Revision: https://phab.enlightenment.org/D6846
Felipe Magno de Almeida [Thu, 23 Aug 2018 02:47:47 +0000 (02:47 +0000)]
eolian-cxx: Remove test that can't be implemented
The feature required by this test was removed. When the feature is
reincluded with newer syntax the test will be rewritten and readded.
Differential Revision: https://phab.enlightenment.org/D6897
Stefan Schmidt [Wed, 22 Aug 2018 12:37:24 +0000 (14:37 +0200)]
examples: elementary: fix path for image include to dist
I missed the correct path for the added image resource in commit
ce3b2dcd99714a59984656d08e7de55248c234d7
Distcheck failed as it was not able to find the file.
Differential Revision: https://phab.enlightenment.org/D6893
Hermet Park [Thu, 23 Aug 2018 11:29:35 +0000 (07:29 -0400)]
ecore wl2: change logging level.
Summary: ease the error message to warning because it's not serious one.
Reviewers: devilhorns, ManMower
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6899
Hermet Park [Thu, 23 Aug 2018 10:18:37 +0000 (19:18 +0900)]
evas image: remove redundant code.
Yeongjong Lee [Wed, 29 Aug 2018 02:44:56 +0000 (11:44 +0900)]
Revert "ecore-evas/wayland: fix parent setting on canvas creation"
This reverts commit
8feceaaa8811d3698f2ae03ed00e2d421fd72928.
The patch(
feceaaa8811d3698f2ae03ed00e2d421fd72928) should not merge before
0fe553c ecore_wl2: Remove ecore_wl2_display_window_find
78f27a3 ecore_wl2: Replace window ids with pointers
Change-Id: I733f80255ba2ad7ef6bea5dec8566c3f6a537f5e
Yeongjong Lee [Mon, 27 Aug 2018 03:00:16 +0000 (12:00 +0900)]
ecore_buffer: move include to out side of extern "C"
Summary: This fixes ecore_buffer_queue_init, shutdown compile error.
Test Plan:
1. compile with --enable-ecore-buffer
2. gcc -o ecore_buffer_consumer_example ecore_buffer_consumer_example.c \
`pkg-config --libs --cflags eina ecore evas ecore-buffer ecore-evas`
3. check there is no error message like
`undefined reference to `ecore_buffer_queue_init'`
Reviewers: Hermet, zmike
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6898
Hosang Kim [Tue, 21 Aug 2018 12:19:06 +0000 (21:19 +0900)]
efl_input: fix problem that ref count does not become 0.
1.fix reusing instance logic.
2.change efl_del() to efl_unref().
@fix
https://phab.enlightenment.org/D6882
Change-Id: I90c580976661ce73ac8efc74f011814781ef7d58
Hosang Kim [Thu, 16 Aug 2018 10:24:21 +0000 (19:24 +0900)]
efl_debug: fix ttrace tag name for tizen tv.
Change-Id: I0817fff1ef824ace45248cb60098cdc36ca9e285
Wonki Kim [Mon, 25 Jun 2018 06:56:11 +0000 (15:56 +0900)]
eina: find a real path of dynamic library
In general case, user library path is specifed as /usr/lib/, however,
if the user library path is specified as /lib/ which is a symbolic link to /usr/lib/,
current eina_prefix_new logic will print warning messages.
(actually the logic finds a /usr/lib/ path once a fallback logic runs)
This patch modifies the logic to find a proper path of lib path even if it is specified as symlink.
Differential Revision: https://phab.enlightenment.org/D6869
Change-Id: Ib6b8f9ff15da7cfd3540d93dd8c7021d53678768
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Woochanlee [Fri, 24 Aug 2018 04:53:24 +0000 (13:53 +0900)]
Revert "evas: check evas class instead of using evas_find"
This reverts commit
283ba078109cf992a0c54a9cea0f7a753cc946d3.
Yeongjong Lee [Fri, 24 Aug 2018 00:54:47 +0000 (09:54 +0900)]
elm: keep deprecated API before it removed.
elm_panes_content_left_unset
elm_panes_content_right_unset
these APIs was deprecated since Tizen 5.0.
we shuold keep these APIs before it removed.
@tizen_fix
Change-Id: If4f858bdf2bea03e1487301637467029639cf52b
JengHyun Kang [Wed, 22 Aug 2018 05:02:37 +0000 (14:02 +0900)]
ecore_evas: choose a longer string's length using strncmp()
Change-Id: I62a573e5f94e2393724fa6c3039fba9423b16cc9
Radoslaw Cybulski [Tue, 14 Aug 2018 10:04:02 +0000 (12:04 +0200)]
fix for wrong object passed to _elm_widget_accessibility_highlight_grabbing_set
Change-Id: I97baa3f47b28244e610e534d1358446eb92bcf73
Shinwoo Kim [Fri, 17 Aug 2018 11:20:39 +0000 (20:20 +0900)]
efl_ui_win: check window data before using it
If user calls elm_win_focus_get with non-window object,
then window data would be NULL which makes a crash.
Change-Id: I3978f3058a63d6199fc656c710bf30003b4d1c30
Marcel Hollerbach [Sat, 18 Aug 2018 08:36:55 +0000 (10:36 +0200)]
ecore_cocoa: move MARKUP outside of ecore_cocoa
the elementary MARKUP stuff requires ecore_cocoa to be linked to evas to
find the function. However, ecore_XXXXX things should stay unrelated to
evas in most cases. Thus this was not a good idea and created a circular
dependency, this is fixed now.
Differential Revision: https://phab.enlightenment.org/D6865
Stefan Schmidt [Wed, 22 Aug 2018 09:38:37 +0000 (18:38 +0900)]
examples: ecore: add input_joystick example to build
Summary:
While the source have been there it was never part of the build. Also
fixed a warning of an unused parameter in the code.
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6890
Stefan Schmidt [Wed, 22 Aug 2018 09:37:44 +0000 (18:37 +0900)]
examples: elementary: add more examples to build
Summary:
Three more examples have been sitting in the src tree but have never
been hooked up to the build. Also adding a needed resource file and
fixing warnings in the newly build examples.
Depends on D6890
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6891
Mike Blumenkrantz [Wed, 22 Aug 2018 09:35:10 +0000 (18:35 +0900)]
ecore-evas/buffer: implement ignore_events method
Summary:
this is a simple implementation of ignore_events functionality which
sets pass_events if it's an image or prevents the emission of events
in other cases
the result should be that no user events are received. this deliberately
does not block the triggering of resize callbacks as in the original ticket
since this guarantees broken functionality and is just not a good idea
fix T4700
Reviewers: devilhorns, Hermet
Reviewed By: Hermet
Subscribers: Hermet, cedric, #reviewers, #committers
Tags: #efl_display_system
Maniphest Tasks: T4700
Differential Revision: https://phab.enlightenment.org/D6876
Carsten Haitzler (Rasterman) [Tue, 21 Aug 2018 09:17:15 +0000 (18:17 +0900)]
efl selection manager - avoid multiple selection get callbacks for req
do one request and get multiple returns if you have multiple windows.
this affected terminology in one proces, multiple windows the sel get
cb is called multiple times from one selection if you cnp between
windows a few times.
@fix
Stefan Schmidt [Tue, 21 Aug 2018 18:31:19 +0000 (14:31 -0400)]
examples: emile: make sure we ship the Makefile.examples file in dist
Summary: Depends on D6888
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6889
Stefan Schmidt [Tue, 21 Aug 2018 18:27:55 +0000 (14:27 -0400)]
examples: edje: fix warning from newly build edje-anchors example
Summary: Depends on D6887
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6888
Stefan Schmidt [Tue, 21 Aug 2018 18:27:49 +0000 (14:27 -0400)]
examples: edje: add forgotten edje-anchors example to build
Summary:
While this source was in tree it was never build. Adding it to the build
system.
Thanks Ross for spotting.
Depends on D6886
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6887
Stefan Schmidt [Tue, 21 Aug 2018 18:27:42 +0000 (14:27 -0400)]
examples: edje: remove unreferenced file in examples
Summary:
No reference to this one. Looks like a left over.
Depends on D6885
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6886
Stefan Schmidt [Tue, 21 Aug 2018 18:27:36 +0000 (14:27 -0400)]
examples: eina: fix warnings in newly build examples
Summary:
These examples ahve been in tree but not build for a long time. After
enabled them in the last commit these warnings popped up.
Depends on D6884
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6885
Stefan Schmidt [Tue, 21 Aug 2018 18:27:29 +0000 (14:27 -0400)]
examples: eina: add missing example source files to dist
Summary:
These have been missing from dist together with the xml resource file.
Adding them back to amke sure we ship them in our tarballs.
Thanks to Ross for spotting and reporting.
Depends on D6883
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6884
Stefan Schmidt [Tue, 21 Aug 2018 18:27:22 +0000 (14:27 -0400)]
examples: evas: we had a couple of files missing in the tarballs
Summary:
A few resource files and a README has not been taken into account during
dist. Make sure we list them correctly.
Thanks to Ross for spotting and reporting.
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6883
Lauro Moura [Tue, 21 Aug 2018 18:21:43 +0000 (14:21 -0400)]
cxx: Remove libeolian_cxx dependency on eo_cxx
Summary: Fixes T7324
Reviewers: felipealmeida, bu5hm4n, zmike
Reviewed By: felipealmeida, bu5hm4n, zmike
Subscribers: segfaultxavi, cedric, #reviewers, #committers, zmike
Tags: #efl
Maniphest Tasks: T7324
Differential Revision: https://phab.enlightenment.org/D6881
Hermet Park [Tue, 21 Aug 2018 14:38:54 +0000 (10:38 -0400)]
efl_ui_image: apply some image options as retained way.
Summary:
load_size will be applied when file is set,
orientation, flip would be applied when starting sizing calc.
These will gurantee applying options whether image is preset or not.
This is a regression bug by
ae51c81a686ca47c93eedc99beaf3a84f8a9cb96
Reviewers: #committers, zmike
Reviewed By: #committers, zmike
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6855
Mike Blumenkrantz [Tue, 21 Aug 2018 14:36:55 +0000 (10:36 -0400)]
evas: remove render2
Summary:
this is more or less a dead project, having not been actively developed
in over 2 years and instead forcing people to expend more time and energy
to keep it compiling across refactors
fix T7227
Reviewers: stefan_schmidt, Hermet, ManMower, devilhorns
Reviewed By: Hermet, devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7227
Differential Revision: https://phab.enlightenment.org/D6878
Mike Blumenkrantz [Tue, 21 Aug 2018 14:26:37 +0000 (10:26 -0400)]
elm/genlist: check for item invalidation after setting item focus on click
Summary:
if the item is deleted during a focus callback then the remainder of this function
must be skipped in order to avoid crashing when attempting to access deallocated
memory
ref T7292
Reviewers: SanghyeonLee
Reviewed By: SanghyeonLee
Subscribers: cedric, #reviewers, #committers
Tags: #efl_widgets
Maniphest Tasks: T7292
Differential Revision: https://phab.enlightenment.org/D6831
Mike Blumenkrantz [Tue, 21 Aug 2018 14:26:32 +0000 (10:26 -0400)]
elm/genlist: unset callbacks flag when destroying view object in unrealize
Summary:
failing to unset this prevents callbacks from being re-added when the item
is next realized, resulting in items which cannot be interacted with
ref T7292
Reviewers: SanghyeonLee
Reviewed By: SanghyeonLee
Subscribers: cedric, #reviewers, #committers
Tags: #efl_widgets
Maniphest Tasks: T7292
Differential Revision: https://phab.enlightenment.org/D6832
Mike Blumenkrantz [Mon, 6 Aug 2018 19:46:31 +0000 (15:46 -0400)]
ci: explicitly clone and build an external app during distcheck
Differential Revision: https://phab.enlightenment.org/D6789
Mike Blumenkrantz [Mon, 20 Aug 2018 21:01:32 +0000 (17:01 -0400)]
ci: use distcheck script
I forgot to enable this when I rebased the original version
Differential Revision: https://phab.enlightenment.org/D6877
Mike Blumenkrantz [Mon, 6 Aug 2018 19:40:54 +0000 (15:40 -0400)]
ci: disable backtracing on log errors
this is just spam that fills up the logs and sometimes causes builds to
abort when they reach the maximum log size
Differential Revision: https://phab.enlightenment.org/D6788
Hermet Park [Tue, 21 Aug 2018 05:04:58 +0000 (14:04 +0900)]
ui_spin_button: avoid duplicated calls.
Woochanlee [Tue, 21 Aug 2018 04:52:28 +0000 (13:52 +0900)]
efl_ui_spin_button: Addded direction feature.
Summary:
The Spin_Button class supports two types(horizontal, vertical).
User can use 'efl_ui_direction()' for spin_button.
@feature
Test Plan: elementary_test-> spin_button sample.
Reviewers: Hermet, Jaehyun_Cho
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6680
Yeongjong Lee [Tue, 21 Aug 2018 04:22:40 +0000 (13:22 +0900)]
efl_ui_focus_composition: remove unused variable
Summary: adapters variable has not been used since
ac4d75a1a.
Reviewers: bu5hm4n, Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6872
Derek Foreman [Mon, 20 Aug 2018 18:08:19 +0000 (14:08 -0400)]
ecore_wl2_dmabuf: Depend on ecore_wl2
Summary:
fix commit
87332f2e3ab2694f27913222ddadbadbca5c4d54 which added a
requirement to link with ecore_wl2 but no requirement that it be
built first.
ref T7327
@fix
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Maniphest Tasks: T7327
Differential Revision: https://phab.enlightenment.org/D6875
Marcel Hollerbach [Mon, 20 Aug 2018 17:15:56 +0000 (13:15 -0400)]
efl_object: add call for getting invalidating
Summary:
there is now invalidated & invalidating.
invalidated returns true when all children are invalidated, and the
object is / was requested to be invalidated.
invalidating return true when the object is called to be invalidated but
not all children are invalidated yet. However, the object is garanteed
to be invalidated in near future.
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric
Tags: #efl, #do_not_merge
Differential Revision: https://phab.enlightenment.org/D6722
Derek Foreman [Mon, 20 Aug 2018 17:06:57 +0000 (13:06 -0400)]
ecore_wl2_dmabuf: Link with ecore_wl2
Summary:
This generated .so file is only ever loaded with dlopen, so it hasn't
mattered that it doesn't appropriately link dependent libraries.
However, Debian builds this with strict linking, which breaks if the
.so doesn't depend on everything that supplies the functions it calls.
fix T7327
@fix
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Maniphest Tasks: T7327
Differential Revision: https://phab.enlightenment.org/D6874
Marcel Hollerbach [Mon, 20 Aug 2018 17:02:08 +0000 (13:02 -0400)]
configure: do not drop to max loglevel 3
Summary:
For the actaul release this might be helpfull, however, we are in a
freeze, people are getting theire alpha releases, that might contain
bugs, its just makes the workflow of fixing faster if we can get and
see debugging output.
Reviewers: devilhorns, stefan_schmidt
Reviewed By: devilhorns
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6548
Marcel Hollerbach [Mon, 20 Aug 2018 16:59:15 +0000 (12:59 -0400)]
eina_debug: switch to vpath
Summary:
eina debug was using the xdg runtime dir in a wrong manner. Since the
directory should be only used by the user, and the directory should be
be subject of any other usage. Additionally, apps tend to create files
like: $XDG_RUNTIME_DIR/foo.bar which is probebly not what you want in
$HOME.
ref T7107
Depends on D6747
Reviewers: zmike, stefan_schmidt, #committers
Reviewed By: zmike, #committers
Subscribers: #reviewers, cedric, #committers, zmike
Tags: #efl
Maniphest Tasks: T7107
Differential Revision: https://phab.enlightenment.org/D6748
Marcel Hollerbach [Mon, 20 Aug 2018 16:58:50 +0000 (12:58 -0400)]
efl_debugd: move to eina vpath
Summary:
the logic here was against the xdg standard, thus we migrate to
eina_vpath which uses the correct xdg standard
Depends on D6746
Reviewers: zmike, stefan_schmidt, #committers
Reviewed By: zmike, #committers
Subscribers: #reviewers, cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6747
Marcel Hollerbach [Mon, 20 Aug 2018 16:58:35 +0000 (12:58 -0400)]
ecore_con: migrate to eina_vpath
Summary:
the logic here was against the xdg standard, thus we migrate to
eina_vpath which uses the correct xdg standard
Depends on D6745
Reviewers: zmike, stefan_schmidt, #committers
Reviewed By: zmike, #committers
Subscribers: #reviewers, cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6746
Marcel Hollerbach [Mon, 20 Aug 2018 16:58:23 +0000 (12:58 -0400)]
quicklaunch: use xdg abstraction instead of direct env var
Summary:
there are defined ways what should happen in XDG_RUNTIME_DIR is not
defined, eina_vpath is the abstraction for doing this.
This ensures that the socket is created in the correct directory.
Depends on D6744
Reviewers: zmike, stefan_schmidt
Reviewed By: zmike
Subscribers: #reviewers, cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6745
Marcel Hollerbach [Mon, 20 Aug 2018 16:57:57 +0000 (12:57 -0400)]
move efreet xdg envvars to eina
Summary:
The contents of the XDG_ env vars are also usefull for eina subsystems,
thus we should init those env vars here.
Depends on D6751
Reviewers: zmike, stefan_schmidt, #committers
Reviewed By: zmike, #committers
Subscribers: #reviewers, cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6744
Marcel Hollerbach [Mon, 20 Aug 2018 16:56:51 +0000 (12:56 -0400)]
eina_vpath: introduce eina_vpath in style of snprintf
Summary:
this can be usefull for later regactor usages.
Depends on D6742
Reviewers: zmike, stefan_schmidt, #committers
Reviewed By: zmike, #committers
Subscribers: #reviewers, segfaultxavi, cedric, #committers, zmike
Tags: PHID-PROJ-55rnlag4d454jfmlmuhu
Differential Revision: https://phab.enlightenment.org/D6743
Marcel Hollerbach [Mon, 20 Aug 2018 16:56:30 +0000 (12:56 -0400)]
eina_vpath: fix homedirectory fetching
Summary:
the fetching of the homedirectorty did not work. pw_dir was never
prepended. Additionally you would get a silent NULL string back
if the system does not support HAVE_GETPWENT.
ref T7107
Depends on D6737
Reviewers: zmike
Reviewed By: zmike
Subscribers: #reviewers, raster, vtorri, cedric, #committers, zmike
Tags: #efl
Maniphest Tasks: T7107
Differential Revision: https://phab.enlightenment.org/D6742
Stefan Schmidt [Mon, 20 Aug 2018 15:00:09 +0000 (11:00 -0400)]
Revert "elm/win: move trigger for "shot" to first pre-render callback"
Summary:
This reverts commit
93228108efaf6097ac680664bdb9158b5cf57499.
The original commit resulted in a hang during the use of the shot engine
in our make doc target. During the doc run we generate screenshots for
the documentation using the shot engine.
It is not a clean revert as other things changed since this got in, but
I verified that the screenshots for the documentation is generated
correctly again. This might leave open the original issue T6929 which
the now reverted commit tried to address.
Fixes T7166
Reviewers: zmike, JackDanielZ, xavi
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7166
Differential Revision: https://phab.enlightenment.org/D6873
Marcel Hollerbach [Mon, 6 Aug 2018 13:02:19 +0000 (15:02 +0200)]
efl_ui_composition: remove all children in invalidate
When the element that iherits from composition is invalidated, all items
should be unregistered.
fix T7213
Differential Revision: https://phab.enlightenment.org/D6755
Shinwoo Kim [Mon, 20 Aug 2018 07:19:02 +0000 (16:19 +0900)]
elm/win: check object class before using it
Summary:
elm_win_focus_get with non Efl.Ui.Win object could return incorrect value.
If an object implements Efl.Ui.Focus.Object.focus { get; } then the return
value of elm_win_focus_get with this object depends upon the object status.
Reviewers: Hermet, YOhoho
Reviewed By: YOhoho
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6868
Hermet Park [Mon, 20 Aug 2018 05:39:37 +0000 (14:39 +0900)]
evas map: +comment for maintanance.
Wonki Kim [Mon, 20 Aug 2018 04:56:46 +0000 (13:56 +0900)]
scroller: remove unused ifdef blocks
Summary:
there are unused ifdef blocks and also there is a variable that accessed from nowhere.
this patch removes both of theme.
related with D6567
Reviewers: Hermet, eagleeye, devilhorns
Reviewed By: Hermet
Subscribers: cedric, zmike
Tags: #efl, #do_not_merge
Differential Revision: https://phab.enlightenment.org/D6585
Stefan Schmidt [Fri, 17 Aug 2018 23:11:23 +0000 (01:11 +0200)]
configure: switch to dev mode again
Stefan Schmidt [Fri, 17 Aug 2018 21:49:35 +0000 (23:49 +0200)]
release: Update NEWS and bump version for 1.21.0 release
Mike Blumenkrantz [Wed, 15 Aug 2018 17:03:13 +0000 (13:03 -0400)]
eio/sentry: destroy event handlers when deleting sentry
this will crash due to invalid memory access if an event is triggered after
the sentry is destroyed
Differential Revision: https://phab.enlightenment.org/D6845
Mike Blumenkrantz [Thu, 2 Aug 2018 16:48:46 +0000 (12:48 -0400)]
ci: use manual script for distcheck build
this adds a script which reimplements the distcheck rule generated from
automake and runs that script instad of 'make distcheck'
the benefit of this is that the distcheck script can run tests multiple times
to avoid intermittent failures which could potentially cause build errors.
distcheck builds are by far the longest and most costly of all ci builds, so
it's important to reduce failure rates in these builds to the absolute minimum
in order to keep ci build times low
cibuildme
fix T7094
Differential Revision: https://phab.enlightenment.org/D6734
Mike Blumenkrantz [Wed, 15 Aug 2018 12:38:19 +0000 (08:38 -0400)]
build: remove incorrect use of DEPENDENCIES for non-library file
if this is ever evaluated then it will trigger a build failure since it
is not a rule in this makefile which can ever be run
fix T6828
Differential Revision: https://phab.enlightenment.org/D6838
Mike Blumenkrantz [Wed, 15 Aug 2018 20:16:14 +0000 (16:16 -0400)]
ci: always use same version numbering for every build
if the version number ever changes then this destroys the entire ccache
as the version is used in various places in headers which are included
throughout the tree
Differential Revision: https://phab.enlightenment.org/D6848
Mike Blumenkrantz [Fri, 17 Aug 2018 15:11:08 +0000 (11:11 -0400)]
elm/list: correctly handle ELM_LIST_COMPRESS
according to the docs, this mode means that no content size hints should
be taken into account when calculating size hints for the overall object
fix T7313
Differential Revision: https://phab.enlightenment.org/D6860
Alastair Poole [Fri, 17 Aug 2018 11:37:59 +0000 (11:37 +0000)]
elm_code: fix crash on backspace and selection delete.
FIx backspace issue and also issue involving the cursor
position and deleting/cutting/backspace of selected text.
Now that we properly move the cursor around when making a
selection, it's important that we place the cursor in a
valid position in the widget following the removal of text.
Previously the cursor always remained in a "safe" position
however now it's crucial to update this position when
necessary.
@fix T7259
Differential Revision: https://phab.enlightenment.org/D6835
Hermet Park [Fri, 17 Aug 2018 19:12:19 +0000 (15:12 -0400)]
evas vg: prevent invalid access.
Summary:
Canvas allows objects become zombies.
Even though they were deleted they could be accessed by canvas
for second frames.
Reviewers: #committers, zmike
Reviewed By: #committers, zmike
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6849
Mike Blumenkrantz [Fri, 17 Aug 2018 17:10:50 +0000 (18:10 +0100)]
efl_ui/format: revert some patches to fix some regressions
Summary:
it seems that the original patch in this case introduced a regression
where format strings ending with %% in progressbar would not be
displayed correctly. a followup patch attempted to resolve this, but
this second patch introduced another regression where some format strings
would always display 0%
fixing compiler warnings is always valued, but in the case where the
patch to fix the warning creates regressions then we will live with the
warnings instead
This reverts commit
b4112b9735ce75bce95974a257aa1880fa52a6bf.
This reverts commit
be770d37fb05b8486907796dd16f4635bceb4ce1.
Subscribers: cedric, #reviewers, #committers
Tags: #efl_widgets
Differential Revision: https://phab.enlightenment.org/D6863
Derek Foreman [Fri, 17 Aug 2018 16:46:39 +0000 (12:46 -0400)]
efl_wl: Send unique keymap fds to clients
Summary:
Prevent wayland clients from being able to destroy the compositor's
singleton keymap by making individual copies for each client.
Reviewers: zmike, devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6862
Yeongjong Lee [Fri, 17 Aug 2018 16:42:35 +0000 (12:42 -0400)]
ecore_pipe: remove null check condition and fix segfualt on Windows
Summary:
This reverts commit
4917910b4911905236fa099bbc16b833b056ca07.
4917910b break backward compatibility.
Reproduction:
void pipe_handler(...);
pipe = ecore_pipe_add(pipe_handler, NULL);
ecore_pipe_write(pipe, NULL, 0);
Because of the null check condition, pipe_handler isn't called after
4917910b.
Some apps behavior which is written to expected to call pipe_handler was broken.
also, this patch fixed segfault during build on Windows
Test Plan: make on Windows
Reviewers: raster, zmike, vtorri
Reviewed By: zmike, vtorri
Subscribers: woohyun, cedric, #reviewers, #committers, zmike, vtorri
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6824
Shinwoo Kim [Fri, 17 Aug 2018 16:42:18 +0000 (12:42 -0400)]
eina_file: check copied using copied
Summary:
From (1) "the following commit" message, the changed condition in this patch
should check if the virtualized file is copied or not.
In eina_file_virtualize
head_padded = 16 * ((sizeof(Eina_File) + slen + 15) / 16);
file->global_map = ((char *)file) + head_padded;
In eina_file_dup
file->global_map != (void*)(file->filename + strlen(file->filename) + 1)
Because of this discord condition makes eina_file_dup copies always.
(1) This is "the following commit":
commit
4766316935589b6191e047ad697ab10ae2027a43
Author: Cedric Bail <cedric@osg.samsung.com>
Date: Wed Mar 8 10:13:36 2017 -0800
eina: force copy of not copied virtualized file while doing an eina_file_dup.
The other way around is pretty much impossible as you don't know who does
an eina_file_dup and for how long they keep there reference.
T5234
Reviewers: zmike, Hermet
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6857
Chris Michael [Fri, 17 Aug 2018 15:34:30 +0000 (11:34 -0400)]
Revert this patch. It was not supposed to land yet as it was awaiting
review
Revert "elementary: Check for valid focus manager before starting do loop"
This reverts commit
364ca1d2b2bb057da4d4d02dbeb2cbc2045b0ee3.
Mike Blumenkrantz [Fri, 17 Aug 2018 15:30:36 +0000 (11:30 -0400)]
elm/box_layout: rename variables
Summary:
the mnw and mnh variables were misleading in this context because they actually
refer to the max width and max height
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: devilhorns, cedric, #reviewers, #committers
Tags: #efl_widgets
Differential Revision: https://phab.enlightenment.org/D6859
Chris Michael [Mon, 13 Aug 2018 11:27:55 +0000 (07:27 -0400)]
elementary: Check for valid focus manager before starting do loop
Summary:
Apparently there are cases where efl_ui_focus_object_focus_manager_get
can return NULL. In order to trap for this, we can simply modify the
do loop slightly and check for a valid manager before we actually
start looping
Test Case: elementary_test -to "Panel Scrollable" and click Toggle
button
ref T7030
Depends on D6703
Reviewers: bu5hm4n, YOhoho
Subscribers: #reviewers, cedric, #committers, zmike
Tags: #efl_widgets_focus
Maniphest Tasks: T7030
Differential Revision: https://phab.enlightenment.org/D6704
Hermet Park [Fri, 17 Aug 2018 02:27:56 +0000 (11:27 +0900)]
elementary image: updated doc.
Mike Blumenkrantz [Thu, 16 Aug 2018 19:00:41 +0000 (20:00 +0100)]
elm/code: use evas as parent for evas object creation
Summary:
evas object types require an evas as the parent. this has always been
the case, though it has only begun to (again) be treated as an error
recently
fixes unit test failures
Subscribers: cedric, #reviewers, #committers
Tags: #efl_widgets_code
Differential Revision: https://phab.enlightenment.org/D6852
Mike Blumenkrantz [Thu, 16 Aug 2018 18:47:32 +0000 (19:47 +0100)]
tests/edje: fix object parenting for swallow tests
Summary:
recent safety check patches exposed issues here where tests were
incorrectly written to pass evas objects as edje object parents,
resulting in new test failures after this began to be detected and
treated as an error
Reviewers: netstar
Reviewed By: netstar
Subscribers: netstar, cedric, #reviewers, #committers
Tags: #efl_tests
Differential Revision: https://phab.enlightenment.org/D6851
Derek Foreman [Thu, 16 Aug 2018 17:39:34 +0000 (12:39 -0500)]
Remove EOLIAN_TESTS_EOS_GENERATED
Summary:
commit
74b56eedd1e0f7c51500bf880b59257ecea0bd0e added these to clean,
but the variable contains some non-generated files.
Turns out these files don't have to be part of the build at all, as
the tests that use them generate them in temp dirs.
Just remove the variable entirely.
Reviewers: bu5hm4n, zmike, q66
Reviewed By: bu5hm4n, zmike, q66
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6850
Derek Foreman [Thu, 16 Aug 2018 14:17:23 +0000 (10:17 -0400)]
ecore_evas: Fix elm warnings when building without wayland support
Summary:
efl_ui_win.c only includes private ecore_evas headers when building
for wayland, but wayland canvas creation functions are called even
in non-wayland builds.
Move the "hidden" wayland APIs to the public header so they don't
mess up non-wayland builds.
Reviewers: devilhorns, zmike
Reviewed By: devilhorns, zmike
Subscribers: devilhorns, cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6822
Mike Blumenkrantz [Thu, 16 Aug 2018 14:16:43 +0000 (10:16 -0400)]
tests/eio: disable efreet cache for eio tests
Summary:
having this enabled slows down test execution by a significant amount
for some reason
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl_tests
Differential Revision: https://phab.enlightenment.org/D6836