Wolfgang [Thu, 26 Mar 2020 01:15:17 +0000 (18:15 -0700)]
Fixing a sanitizer lint problem that was breaking some builds.
Mehdi Amini [Wed, 25 Mar 2020 20:19:16 +0000 (20:19 +0000)]
Remove overly verbose debug from GenericDomTreeConstruction
This particular debug shows all the time when I'm processing any MLIR
module:
discovered a new reachable node ^bb0
discovered a new reachable node ^bb0
discovered a new reachable node ^bb0
discovered a new reachable node ^bb0
...
(repeated x1875)
I think that printing all the basic blocks in the function is likely low
value enough that we can get away with removing this.
Differential Revision: https://reviews.llvm.org/D76813
Shoaib Meenai [Fri, 18 Oct 2019 21:11:29 +0000 (14:11 -0700)]
[libcxx] Fix .gitignore to not exclude test directories
We have several test directories whose names end in .spec. Ensure we
don't accidentally ignore them by removing a section of the .gitignore
that's irrelevant for libc++.
Differential Revision: https://reviews.llvm.org/D69195
Sam McCall [Wed, 25 Mar 2020 23:40:15 +0000 (00:40 +0100)]
[clangd] Add test for FindTarget+RecoveryExpr (which already works). NFC
Sam McCall [Wed, 25 Mar 2020 23:06:54 +0000 (00:06 +0100)]
[clangd] Work around gcc bug after
8f237f9b0
Lei Zhang [Wed, 25 Mar 2020 20:43:55 +0000 (16:43 -0400)]
[mlir][vulkan-runner] Add test to time a large vector add
Summary:
The test performs add on vector<16384xf32> with
number of workgroups = (128, 1, 1)
local workgroup size = (128, 1, 1)
On a NVIDIA Quadro P1000, I see the following results:
Command buffer submit time: 13us
Compute shader execution time: 19.616us
Differential Revision: https://reviews.llvm.org/D76799
Stanislav Mekhanoshin [Wed, 25 Mar 2020 18:06:34 +0000 (11:06 -0700)]
[AMDGPU] Preserve original symbol during attribute propagation
AMDGPUPropagateAttributes can swap names while cloning a function.
Only do it if original symbol was not externally visible.
Differential Revision: https://reviews.llvm.org/D76789
Siva Chandra Reddy [Wed, 25 Mar 2020 05:29:11 +0000 (22:29 -0700)]
[libc] Add a GNU extensions spec containing sincosf from math.h.
Reviewers: abrachet
Differential Revision: https://reviews.llvm.org/D76783
Gianfranco Costamagna [Wed, 25 Mar 2020 21:38:34 +0000 (22:38 +0100)]
Convert old python3 cgi method into the new html one
Summary: Patch by Gianfranco Costamagna
Reviewers: serge-sans-paille
Reviewed By: serge-sans-paille
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D76126
Florian Hahn [Tue, 24 Mar 2020 13:54:13 +0000 (13:54 +0000)]
[SCCP] Add a few constantexpr,undef tests for cond propagation
Louis Dionne [Wed, 25 Mar 2020 20:50:19 +0000 (16:50 -0400)]
[libc++] Fix CMake configuration breakage when libc++ is built neither static nor dynamic
Introduced by https://reviews.llvm.org/D72687. This condition can happen
when the tests are not being run at all, and we're only trying to generate
the libc++ headers.
Louis Dionne [Mon, 16 Mar 2020 18:58:31 +0000 (14:58 -0400)]
[libc++] Require the use of clang-verify in .fail.cpp tests that don't fail without it
Some tests do not fail at all when -verify is not supported, unless some
arbitrary warning flag is added to make them fail. We currently used
-Werror=unused-result to make them fail, but doing so makes the test
suite a lot more inscrutable. It seems better to just disable those
tests when -verify is not supported.
Differential Revision: https://reviews.llvm.org/D76256
Max Moroz [Wed, 25 Mar 2020 20:43:54 +0000 (13:43 -0700)]
[compiler-rt] Mark FDP non-template methods inline to avoid ODR violations.
Louis Dionne [Wed, 25 Mar 2020 20:25:47 +0000 (16:25 -0400)]
[libc++] Add a new %exec substitution
It allows executing arbitrary commands with the same environment as
normal .pass.cpp tests, which is handy.
Alex Zinenko [Wed, 25 Mar 2020 15:25:52 +0000 (16:25 +0100)]
[mlir] Provide CustomOpAsmParser::parseOptionalOperand
Summary:
Some operations have custom syntax where an operand is always followed by a
specific token of streams if the operand is present. Parsing such operations
requires the ability to optionally parse an operand. Provide a relevant
function in the custom Op parser.
Differential Revision: https://reviews.llvm.org/D76779
Tyker [Wed, 25 Mar 2020 18:49:04 +0000 (19:49 +0100)]
Ignore/Drop droppable uses for code-sinking in InstCombine
Summary:
This patch allows code-sinking in InstCombine to be performed when instruction have uses in llvm.assume.
Use are considered droppable when it is preferable to modify the User such that the use disappears rather than to prevent a transformation because of the use.
for now uses are considered droppable if they are in an llvm.assume.
Reviewers: jdoerfert, nikic, spatel, lebedev.ri, sstefan1
Reviewed By: jdoerfert
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D73832
Alina Sbirlea [Tue, 10 Mar 2020 22:19:29 +0000 (15:19 -0700)]
[CFG/BasicBlock] Rename pred_const to const_pred. [NFC]
Summary:
Rename `pred_const_range` to `const_pred_range` to make it consistent with
the other pred/succ iterator definitions.
Reviewers: nicholas, dblaikie, nlewycky
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D75962
Alina Sbirlea [Tue, 10 Mar 2020 18:33:02 +0000 (11:33 -0700)]
[CFG/BasicBlock] Rename succ_const to const_succ. [NFC]
Summary:
Rename `succ_const_iterator` to `const_succ_iterator` and
`succ_const_range` to `const_succ_range` for consistency with the
predecessor iterators, and the corresponding iterators in
MachineBasicBlock.
Reviewers: nicholas, dblaikie, nlewycky
Subscribers: hiraditya, bmahjour, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D75952
Erich Keane [Wed, 25 Mar 2020 19:05:07 +0000 (12:05 -0700)]
Implement post-commit comments for D75685/rG86e0a6c60627
@Anastasia made a pair of comments on D75685 after it was committed
requesting changes to the test. This patch updates the test based on
her comments.
River Riddle [Wed, 25 Mar 2020 19:18:11 +0000 (12:18 -0700)]
[mlir] Remove old VectorOps directory
This was accidentally re-added during a rebase.
Alexander Belyaev [Wed, 25 Mar 2020 19:13:43 +0000 (20:13 +0100)]
[Clang] Fix clang-tidy errors.
Frej Drejhammar [Wed, 25 Mar 2020 18:51:34 +0000 (11:51 -0700)]
[mlir][Parser] Fix attribute parser errors for ui64
Summary:
The attribute parser fails to correctly parse unsigned 64 bit
attributes as the check `isNegative ? (int64_t)-val.getValue() >= 0
: (int64_t)val.getValue() < 0` will falsely detect an overflow for
unsigned values larger than 2^63-1.
This patch reworks the overflow logic to instead of doing arithmetic
on int64_t use APInt::isSignBitSet() and knowledge of the attribute
type.
Test-cases which verify the de-facto behavior of the parser and
triggered the previous faulty handing of unsigned 64 bit attrbutes are
also added.
Differential Revision: https://reviews.llvm.org/D76493
Heejin Ahn [Wed, 25 Mar 2020 02:36:13 +0000 (19:36 -0700)]
[WebAssembly] Move event section before global section
Summary:
https://github.com/WebAssembly/exception-handling/issues/98
Also this moves many parts of code to make code align with the section
order, even if they don't affect the output.
Reviewers: tlively
Subscribers: dschuff, sbc100, hiraditya, sunfish, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D76752
Louis Dionne [Wed, 25 Mar 2020 18:30:06 +0000 (14:30 -0400)]
[libc++] Drop custom support for flaky tests from libc++ test suite
Instead, use the builtin support in lit. This makes the libc++ custom
test format slightly closer to the builtin ShTest format in behavior.
Erich Keane [Wed, 25 Mar 2020 18:32:00 +0000 (11:32 -0700)]
Fix vector type scalar checking when the scalar operand is dependent
As reported in PR45298 and PR45299, vector_size type checking would
crash when done in a situation where the scalar is dependent, such as
a member of the current instantiation.
This is because the scalar checking ensures that you can implicitly
convert a value to a vector-type as long as it doesn't require
truncation. It does this by using the constant evaluator to get the
value as a float. Unfortunately, if the scalar is dependent (such as a
member of the current instantiation), we would hit the assert in the
evaluator.
This patch suppresses the truncation- of-value check in the first phase
of translation. All values are properly errored upon instantiation. This
has one minor regression, in that previously in a non-asserts build,
template<typename T>
struct S {
float4 f(float4 f) {
return k + f;
}
static constexpr k = 1.1; // causes a truncation on conversion.
};
would error immediately. Because 'k' is value dependent (as a
member-of-the-current-instantiation), this would still be evaluatable
(despite normally asserting). Due to this patch, this diagnostic is
delayed until instantiation time.
Alexandre Ganea [Wed, 25 Mar 2020 17:53:26 +0000 (13:53 -0400)]
[ThinLTO] Don't rely on debug output for thinlto_samplepgo_icp3 test
Because using -print-imports is not thread-safe, make the test rely on llvm-dis instead.
Also cover the ICALL-PROM part as intended originally.
Differential Revision: https://reviews.llvm.org/D76775
Nico Weber [Wed, 25 Mar 2020 18:04:59 +0000 (14:04 -0400)]
revert parts of
d7888149aa813f that several bots do not like
Louis Dionne [Wed, 25 Mar 2020 18:00:25 +0000 (14:00 -0400)]
[libc++] NFC: Remove unused include from test
Eli Friedman [Wed, 25 Mar 2020 17:56:48 +0000 (10:56 -0700)]
[clang codegen] Address review comment on comment in constWithPadding.
Nico Weber [Wed, 25 Mar 2020 17:48:02 +0000 (13:48 -0400)]
Suppress a few -Wunreachable-code warnings.
No behavior change. Also fix a comment to say match reality.
Simon Pilgrim [Wed, 25 Mar 2020 17:26:10 +0000 (17:26 +0000)]
[X86][AVX] Combine shuffles to TRUNCATE/VTRUNC patterns
Add support for combining shuffles to AVX512 truncate instructions - another step toward fixing D56387/D66004. It also fixes SKX code on PR31443.
We could probably extend this further to handle non-VLX truncation cases.
Gil Rapaport [Wed, 18 Mar 2020 19:58:13 +0000 (21:58 +0200)]
[LV] Replace stored value with a VPValue (NFCI)
InnerLoopVectorizer's code called during VPlan execution still relies on
original IR's def-use relations to decide which vector code to generate,
limiting VPlan transformations ability to modify def-use relations and still
have ILV generate the vector code.
This commit introduces a VPValue for VPWidenMemoryInstructionRecipe to use as
the stored value. The recipe is generated with a VPValue wrapping the stored
value of the scalar store. This reduces ingredient def-use usage by ILV as a
step towards full VPlan-based def-use relations.
Differential Revision: https://reviews.llvm.org/D76373
Tyker [Wed, 25 Mar 2020 17:28:51 +0000 (18:28 +0100)]
[NFC] Rename function to match Coding Convention and fix typo in KnowledgeRetention
Nico Weber [Wed, 25 Mar 2020 17:23:47 +0000 (13:23 -0400)]
[gn build] try removing a duplicate include dir
Siva Chandra Reddy [Wed, 18 Mar 2020 19:46:33 +0000 (12:46 -0700)]
[libc] Add a simple x86_64 linux loader.
This adds a very simple loader. This will be extended to a full loader
in future patches. A utility rule to add unittests has been added to
serve us while we are building out the full loader.
Reviewers: abrachet, phosek
Differential Revision: https://reviews.llvm.org/D76412
Mikhail Maltsev [Wed, 25 Mar 2020 17:08:19 +0000 (17:08 +0000)]
[ARM,CDE] Implement predicated Q-register CDE intrinsics
Summary:
This patch implements the following CDE intrinsics:
T __arm_vcx1q_m(int coproc, T inactive, uint32_t imm, mve_pred_t p);
T __arm_vcx2q_m(int coproc, T inactive, U n, uint32_t imm, mve_pred_t p);
T __arm_vcx3q_m(int coproc, T inactive, U n, V m, uint32_t imm, mve_pred_t p);
T __arm_vcx1qa_m(int coproc, T acc, uint32_t imm, mve_pred_t p);
T __arm_vcx2qa_m(int coproc, T acc, U n, uint32_t imm, mve_pred_t p);
T __arm_vcx3qa_m(int coproc, T acc, U n, V m, uint32_t imm, mve_pred_t p);
The intrinsics are not part of the released ACLE spec, but internally at
Arm we have reached consensus to add them to the next ACLE release.
Reviewers: simon_tatham, MarkMurrayARM, ostannard, dmgreen
Reviewed By: simon_tatham
Subscribers: kristof.beyls, hiraditya, danielkiss, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D76610
Sam McCall [Tue, 24 Mar 2020 23:51:50 +0000 (00:51 +0100)]
[clangd] Support multiple cursors in selectionRange.
Summary:
One change: because there's no way to signal failure individually for
each cursor, we now "succeed" with an empty range with no parent if a
cursor doesn't point at anything.
Reviewers: usaxena95
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D76741
Gabor Marton [Wed, 25 Mar 2020 16:56:40 +0000 (17:56 +0100)]
[analyzer][NFC] Add missing LLVM header blurb (and license)
zoecarver [Wed, 25 Mar 2020 16:48:01 +0000 (09:48 -0700)]
Add method to TargetInfo to get CPU cache line size
Summary:
This patch adds a virtual method `getCPUCacheLineSize()` to `TargetInfo`. Currently, I've only implemented the method in `X86TargetInfo`. It's extremely important that each CPU's cache line size correct (e.g., we can't just define it as `64` across the board) so, it has been a little slow getting to this point.
I'll work on the ARM CPUs next, but that will probably come later in a different patch.
Tags: #clang
Differential Revision: https://reviews.llvm.org/D74918
Michael Kruse [Wed, 25 Mar 2020 14:26:14 +0000 (09:26 -0500)]
[clang] Reformat cindex. NFC.
to reduce spurios changes in patches after clang-formatting them. In
particular, these files contain long enums that clang-format reformats
in their entirety if e.g. an element is added.
Reviews having this problem include https://reviews.llvm.org/D76342 and
https://reviews.llvm.org/D71447.
Louis Dionne [Wed, 25 Mar 2020 15:11:31 +0000 (11:11 -0400)]
[libc++] Run the builders Docker containers 'as 'buildbot instead of 'root'
Dmitry Vyukov [Wed, 25 Mar 2020 16:03:29 +0000 (17:03 +0100)]
tsan: fix leak of ThreadSignalContext for fibers
When creating and destroying fibers in tsan a thread state
is created and destroyed. Currently, a memory mapping is
leaked with each fiber (in __tsan_destroy_fiber).
This causes applications with many short running fibers
to crash or hang because of linux vm.max_map_count.
The root of this is that ThreadState holds a pointer to
ThreadSignalContext for handling signals. The initialization
and destruction of it is tied to platform specific events
in tsan_interceptors_posix and missed when destroying a fiber
(specifically, SigCtx is used to lazily create the
ThreadSignalContext in tsan_interceptors_posix). This patch
cleans up the memory by inverting the control from the
platform specific code calling the generic ThreadFinish to
ThreadFinish calling a platform specific clean-up routine
after finishing a thread.
The relevant code causing the leak with fibers is the fiber destruction:
void FiberDestroy(ThreadState *thr, uptr pc, ThreadState *fiber) {
FiberSwitchImpl(thr, fiber);
ThreadFinish(fiber);
FiberSwitchImpl(fiber, thr);
internal_free(fiber);
}
I would appreciate feedback if this way of fixing the leak is ok.
Also, I think it would be worthwhile to more closely look at the
lifecycle of ThreadState (i.e. it uses no constructor/destructor,
thus requiring manual callbacks for cleanup) and how OS-Threads/user
level fibers are differentiated in the codebase. I would be happy to
contribute more if someone could point me at the right place to
discuss this issue.
Reviewed-in: https://reviews.llvm.org/D76073
Author: Florian (Florian)
Dmitry Vyukov [Wed, 25 Mar 2020 10:30:25 +0000 (11:30 +0100)]
compiler-rt: allow golang race detector to run on musl-c
tsan while used by golang's race detector was not working on alpine
linux, since it is using musl-c instead of glibc. Since alpine is very
popular distribution for container deployments, having working race
detector would be nice. This commits adds some ifdefs to get it working.
It fixes https://github.com/golang/go/issues/14481 on golang's issue tracker.
Reviewed-in: https://reviews.llvm.org/D75849
Author: graywolf-at-work (Tomas Volf)
Pavel Labath [Wed, 25 Mar 2020 15:07:05 +0000 (16:07 +0100)]
[lldb] add lit.local.cfg for breakpad tests
The reason is to add .yaml as a valid test suffix. The test folder
contains one yaml file, which wasn't being run because of that.
Unsurprisingly the test fails, but this was not because the underlying
functionality was broken, but rather because the test was setup
incorrectly (most likely due to overly aggressive simplification of the
test data on my part).
Therefore this patch also tweaks the test inputs in order to test what
they are supposed to test, and also updates some other breakpad tests
(because they depend on the same inputs as this one) to be more
realistic -- specifically it avoids putting symbols to the first page of
the module, as that's where normally the COFF header would reside.
Yvan Roux [Wed, 25 Mar 2020 15:40:30 +0000 (16:40 +0100)]
[ARM] Move ConstantIsland and LowOverheadLoops Passes.
Move ARM ConstantIsland and LowOverheadLopps passes later in the pipeline
such that they will be run after the upcoming Machine Outlining pass.
Differential Revision: https://reviews.llvm.org/D76065
Marcel Koester [Tue, 3 Mar 2020 10:07:14 +0000 (11:07 +0100)]
[mlir] Removed TanHOp lowering from ConvertStandardToLLVM since there is no reasonable TanH representation in LLVM.
Summary: The current ConvertStandardToLLVM phase lowers the standard TanHOp to function calls to external tanh symbols. However, this leads to misunderstandings since these external symbols are not defined anywhere. This commit removes the TanHOp lowering functionality from ConvertStandardToLLVM, adapts the LowerGpuOpsToNVVMOps and LowerGpuOpsToROCDLOps passes and adjusts the affected test cases.
Reviewers: mravishankar, herhut
Subscribers: jholewinski, mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, nicolasvasilache, csigg, arpith-jacob, mgester, lucyrfox, aartbik, liufengdb, Joonsoo, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D75509
LLVM GN Syncbot [Wed, 25 Mar 2020 15:36:51 +0000 (15:36 +0000)]
[gn build] Port
ce984129eaa
cdevadas [Wed, 25 Mar 2020 14:15:16 +0000 (14:15 +0000)]
[AMDGPU] Add SIPreEmitPeephole pass.
This pass can handle all the optimization
opportunities found just before code emission.
Presently it includes the handling of vcc branch
optimization that was handled earlier in SIInsertSkips.
Reviewed By: arsenm
Differential Revision: https://reviews.llvm.org/D76712
Simon Pilgrim [Wed, 25 Mar 2020 15:33:11 +0000 (15:33 +0000)]
[X86][AVX] Add common prefix to merge 32/64-bit AVX1 checks
Jonas Paulsson [Wed, 11 Mar 2020 14:18:35 +0000 (15:18 +0100)]
[SystemZ] Improve foldMemoryOperandImpl()
A spilled load of an immediate can use MVHI/MVGHI instead.
A compare of a spilled register against an immediate can use CHSI/CGHSI.
A logical compare can use CLFHSI/CLGHSI.
Review: Ulrich Weigand
Differential Revision: https://reviews.llvm.org/D76055
Fangrui Song [Tue, 24 Mar 2020 22:55:34 +0000 (15:55 -0700)]
[llvm-objdump] Replace array_pod_sort with llvm::stable_sort
llvm-objdump.cpp has 3 array_pod_sort() calls used for symbolization.
array_pod_start() calls qsort() internally and can have different
behaviors across different libcs. Use llvm::stable_sort instead.
Reviewed By: davidb, thopre
Differential Revision: https://reviews.llvm.org/D76739
Sean Fertile [Wed, 25 Mar 2020 14:17:49 +0000 (10:17 -0400)]
[PowerPC][AIX] ByVal formal arguments in a single register.
Adds support for passing ByVal formal arguments as long as they fit in a
single register.
Differential Revision: https://reviews.llvm.org/D76401
Erich Keane [Thu, 5 Mar 2020 16:10:00 +0000 (08:10 -0800)]
Add MS Mangling for OpenCL Pipe types, add mangling test.
SPIRV2.0 Spec only specifies Linux mangling, however our downstream has
use for a Windows mangling for these types.
Unfortunately, the SPIRV
spec specifies a single mangling for all pipe types, despite clang
allowing overloading on these types. Because of this, this patch
chooses to mangle the read/writability and element type for the windows
mangling.
The windows manglings in the test all demangle according to demangler:
"void __cdecl test1(struct __clang::ocl_pipe<int,1>)
"void __cdecl test2(struct __clang::ocl_pipe<float,0>)
"void __cdecl test2(struct __clang::ocl_pipe<int,1>)
"void __cdecl test3(struct __clang::ocl_pipe<int const,1>)
"void __cdecl test4(struct __clang::ocl_pipe<union
__clang::__vector<unsigned char,3>,1>)
"void __cdecl test5(struct __clang::ocl_pipe<union
__clang::__vector<int,4>,1>)
"void __cdecl test_reserved_read_pipe(struct __clang::_ASCLglobal<struct
Person > * __ptr64,struct __clang::ocl_pipe<struct Person,1>)
Differential Revision: https://reviews.llvm.org/D75685
Hans Wennborg [Wed, 25 Mar 2020 14:42:21 +0000 (15:42 +0100)]
Build fix: AttributeCommonInfo::AS_C2x
Sanjay Patel [Wed, 25 Mar 2020 14:33:59 +0000 (10:33 -0400)]
[VectorCombine] add shuffle tests; NFC
Goes with DD76727.
John Brawn [Wed, 25 Mar 2020 13:49:02 +0000 (13:49 +0000)]
Add an attribute plugin example
Differential Revision: https://reviews.llvm.org/D31343
John Brawn [Wed, 25 Mar 2020 10:53:30 +0000 (10:53 +0000)]
Don't normalise CXX11/C2X attribute names to start with ::
Currently square-bracket-style (CXX11/C2X) attribute names are normalised to
start with :: if they don't have a namespace. This is a bit odd, as such
names are rejected when parsing, so don't do this.
Differential Revision: https://reviews.llvm.org/D76704
sstefan1 [Wed, 25 Mar 2020 14:08:50 +0000 (14:08 +0000)]
OpenMP] Adding InaccessibleMemOnly and InaccessibleMemOrArgMemOnly for runtime calls.
Summary: Attempt to add more attributes for runtime calls.
Reviewers: jdoerfert
Subscribers: guansong, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D75010
Erich Keane [Wed, 18 Mar 2020 20:45:58 +0000 (13:45 -0700)]
[SYCL] Implement __builtin_unique_stable_name.
In order to support non-user-named kernels, SYCL needs some way in the
integration headers to name the kernel object themselves. Initially, the
design considered just RTTI naming of the lambdas, this results in a
quite unstable situation in light of some device/host macros.
Additionally, this ends up needing to use RTTI, which is a burden on the
implementation and typically unsupported.
Instead, we've introduced a builtin, __builtin_unique_stable_name, which
takes a type or expression, and results in a constexpr constant
character array that uniquely represents the type (or type of the
expression) being passed to it.
The implementation accomplishes that simply by using a slightly modified
version of the Itanium Mangling. The one exception is when mangling
lambdas, instead of appending the index of the lambda in the function,
it appends the macro-expansion back-trace of the lambda itself in the
form LINE->COL[~LINE->COL...].
Differential Revision: https://reviews.llvm.org/D76620
Raphael Isemann [Wed, 25 Mar 2020 10:52:33 +0000 (11:52 +0100)]
[lldb][NFC] lldb_assert->lldbassert in ClangExpressionParser
lldbassert is the macro that takes care of passing along line/file/function
to the lldb_assert function. Let's call that instead of manually calling the
function.
Sergej Jaskiewicz [Wed, 25 Mar 2020 12:27:05 +0000 (15:27 +0300)]
[libcxx] Allow tests to link with static libc++abi/libc++ even if the shared version is present
Summary:
This is essentially D71894, but for libc++.
This is needed for running libc++ tests over SSH.
Reviewers: EricWF, ldionne, phosek, mehdi_amini, mclow.lists, jroelofs, bcraig, #libc
Reviewed By: ldionne, phosek, #libc
Subscribers: mgorny, christof, dexonsmith, libcxx-commits
Tags: #libc
Differential Revision: https://reviews.llvm.org/D72687
Kerry McLaughlin [Wed, 25 Mar 2020 11:26:25 +0000 (11:26 +0000)]
[AArch64][SVE] Add SVE intrinsics for masked loads & stores
Summary:
Implements the following intrinsics for contiguous loads & stores:
- @llvm.aarch64.sve.ld1
- @llvm.aarch64.sve.st1
Reviewers: sdesmalen, andwar, efriedma, cameron.mcinally, dancgr, rengolin
Reviewed By: cameron.mcinally
Subscribers: tschuett, kristof.beyls, hiraditya, rkruppe, psnobl, danielkiss, cfe-commits, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D76688
Juneyoung Lee [Wed, 25 Mar 2020 11:24:40 +0000 (20:24 +0900)]
Rename test name, add more tests for codegenprepare
Sam Parker [Wed, 25 Mar 2020 11:12:03 +0000 (11:12 +0000)]
[ARM][MVE] Add HorizontalReduction flag
Add a target flag for instructions that reduce into one, or more,
scalar reg(s), including variants of:
- VADDV
- VABAV
- VMINV/VMAXV
- VMLADAV
Differential Revision: https://reviews.llvm.org/D76683
Richard Sandiford [Thu, 5 Mar 2020 20:33:19 +0000 (20:33 +0000)]
[Sema][SVE] Allow casting SVE types to themselves in C
Casts from an SVE type to itself aren't very useful, but they are
supposed to be valid, and could occur in things like macro expansions.
Such casts already work for C++ and are tested by sizeless-1.cpp.
This patch makes them work for C too.
Differential Revision: https://reviews.llvm.org/D76694
Richard Sandiford [Mon, 2 Mar 2020 18:58:03 +0000 (18:58 +0000)]
[Sema][SVE] Allow ?: to select between SVE types in C
When compiling C, a ?: between two values of the same SVE type
currently gives an error such as:
incompatible operand types ('svint8_t' (aka '__SVInt8_t') and 'svint8_t')
It's supposed to be valid to select between (cv-qualified versions of)
the same SVE type, so this patch adds that case.
These expressions already work for C++ and are tested by
SemaCXX/sizeless-1.cpp.
Differential Revision: https://reviews.llvm.org/D76693
Simon Tatham [Wed, 25 Mar 2020 09:46:08 +0000 (09:46 +0000)]
[ARM,MVE] Add missing tests for vqdmlash intrinsics.
Summary:
These were accidentally left out of D76123. I added tests for the
other three instructions in this small cross-product family (vqdmlah,
vqrdmlah, vqrdmlash) but missed this one.
Reviewers: miyuki
Reviewed By: miyuki
Subscribers: kristof.beyls, dmgreen, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D76714
Nathan James [Mon, 23 Mar 2020 13:42:17 +0000 (13:42 +0000)]
[clang-apply-replacements] No longer deduplucates replacements from the same TU
Summary:
clang-apply-replacements currently deduplicates all diagnostic replacements. However if you get a duplicated replacement from one TU then its expected that it should not be deduplicated. This goes some way to solving [[ https://bugs.llvm.org/show_bug.cgi?id=45150 | export-fixes to yaml adds extra newlines and breaks offsets. ]]
Take this example yaml.
```
---
MainSourceFile: '/home/nathan/test/test.cpp'
Diagnostics:
- DiagnosticName: readability-braces-around-statements
DiagnosticMessage:
Message: statement should be inside braces
FilePath: '/home/nathan/test/test.cpp'
FileOffset: 14
Replacements:
- FilePath: '/home/nathan/test/test.cpp'
Offset: 14
Length: 0
ReplacementText: ' {'
- FilePath: '/home/nathan/test/test.cpp'
Offset: 28
Length: 0
ReplacementText: '
}'
- DiagnosticName: readability-braces-around-statements
DiagnosticMessage:
Message: statement should be inside braces
FilePath: '/home/nathan/test/test.cpp'
FileOffset: 20
Replacements:
- FilePath: '/home/nathan/test/test.cpp'
Offset: 20
Length: 0
ReplacementText: ' {'
- FilePath: '/home/nathan/test/test.cpp'
Offset: 28
Length: 0
ReplacementText: '
}'
...```
The current behaviour is to deduplicate the text insertions at Offset 28 and only apply one of the replacements.
However as both of these replacements came from the same translation unit we can be confident they were both meant to be applied together
The new behaviour won't deduplicate the text insertion and instead insert both of the replacements.
If the duplicate replacement is found inside different translation units (from a header file change perhaps) then they will still be deduplicated as before.
Reviewers: aaron.ballman, gribozavr2, klimek, ymandel
Reviewed By: ymandel
Subscribers: ymandel, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D76054
Juneyoung Lee [Wed, 25 Mar 2020 08:18:19 +0000 (17:18 +0900)]
Add freeze(and x, const) case to codegenprepare's freeze-cmp.ll
Kazushi (Jam) Marukawa [Wed, 25 Mar 2020 08:19:52 +0000 (09:19 +0100)]
[VE] Change name of enum to CondCode
Summary: Change enum name for condition codes from CondCodes to CondCode.
Reviewers: arsenm, simoll, k-ishizaka
Reviewed By: arsenm
Subscribers: wdng, hiraditya, llvm-commits
Tags: #llvm, #ve
Differential Revision: https://reviews.llvm.org/D76747
Haojian Wu [Tue, 24 Mar 2020 12:43:25 +0000 (13:43 +0100)]
[AST] Build recovery expressions by default for C++.
Update the existing tests.
Reviewers: sammccall
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D76696
Max Moroz [Wed, 25 Mar 2020 07:39:17 +0000 (00:39 -0700)]
[compiler-rt] FuzzedDataProvider: make linter happy.
Juneyoung Lee [Wed, 25 Mar 2020 07:34:34 +0000 (16:34 +0900)]
Minor fixes to a comment in CodeGenPrepare
Max Moroz [Thu, 19 Mar 2020 19:39:37 +0000 (12:39 -0700)]
[compiler-rt] Refactor FuzzedDataProvider for better readability.
Summary: Separate class definition and actual methods implementation. The main
goal is to keep the list of available methods in a concise readable form inside
the class definition.
Reviewers: hctim, metzman
Subscribers: dberris, #sanitizers
Tags: #sanitizers
Differential Revision: https://reviews.llvm.org/D76651
Craig Topper [Wed, 25 Mar 2020 02:03:36 +0000 (19:03 -0700)]
[X86] Split masked instruction tests to enable D60940.
We need to split tests that rely on isel duplicating operations
for different masking conditions. Repeating the operation is
more costly than emitting the masking separately.
The change here is a mechanical splitting of tests that
call multiple intrinsics in one function into separate
functions that call one intrinsic. We could obviously avoid
the splitting by giving the intrinsics different operands, but
that would need closer scrutiny than just splitting.
Kai Luo [Wed, 25 Mar 2020 06:19:59 +0000 (06:19 +0000)]
[PowerPC] Pre-commit reduced test case for PR45297. NFC.
Siva Chandra Reddy [Tue, 24 Mar 2020 17:52:56 +0000 (10:52 -0700)]
[libc] Generate math.h instead of the static file it is currently.
Just enough to help a follow up patch adding cosf and sinf has been
added.
Reviewers: abrachet
Differential Revision: https://reviews.llvm.org/D76723
Uday Bondhugula [Wed, 25 Mar 2020 02:23:05 +0000 (07:53 +0530)]
[MLIR][NFC] std::is_same || -> llvm::is_one_of
Switch std::is_same disjunctions to llvm::is_one_of
Differential Revision: https://reviews.llvm.org/D76745
LLVM GN Syncbot [Wed, 25 Mar 2020 03:27:56 +0000 (03:27 +0000)]
[gn build] Port
ba1f4405c68
Petr Hosek [Wed, 25 Mar 2020 03:02:44 +0000 (20:02 -0700)]
[profile] Move RuntimeCounterRelocation and ProfileDumped into a separate file
This avoids the test failure that was introduced in rG32bddad where
this function pulls in the rest of InstrProfilingFile.c which is
undesirable in use cases when profile runtime is being used without
the rest of libc.
This also allows additional cleanup by eliminating another variable
from platforms that don't need it.
Differential Revision: https://reviews.llvm.org/D76750
Louis Dionne [Wed, 25 Mar 2020 02:53:47 +0000 (22:53 -0400)]
Revert "[libc++] Build the dylib with C++17 to allow aligned new/delete"
This reverts commit
1ac403bd145dadfa1004af29bd6c77f871caf42c, which
broke some non-libc++ build bots because they use an ancient CMake.
QingShan Zhang [Wed, 25 Mar 2020 02:37:26 +0000 (02:37 +0000)]
[NFC][Test][PowerPC] Add one test to verify the behavior of vector
mul/add for v8i16
Matt Arsenault [Wed, 25 Mar 2020 01:52:03 +0000 (21:52 -0400)]
AMDGPU/GlobalISel: Add a testcase for G_UNMERGE_VALUES legalization
I had a note that this doesn't work, but it seems to now.
Petr Hosek [Sat, 21 Mar 2020 23:41:00 +0000 (16:41 -0700)]
[profile] Make atexit hook a no-op on Fuchsia
On Fuchsia, we always use the continuous mode with runtime counter
relocation, so there's no need for atexit hook or support for dumping
the profile manually.
Differential Revision: https://reviews.llvm.org/D76556
Eric Fiselier [Wed, 25 Mar 2020 01:33:42 +0000 (21:33 -0400)]
[libc++] Update a bad documentation link
Matt Arsenault [Wed, 25 Mar 2020 01:21:59 +0000 (21:21 -0400)]
AMDGPU/GlobalISel: Add some end to end tests for fma selection
Adrian Prantl [Wed, 25 Mar 2020 00:56:36 +0000 (17:56 -0700)]
Revert "Allow remapping Clang module include paths"
to investigate why this commit broke a test in the LLDB testsuite.
This reverts commit
dca920a904c27f4c86e909ef2e4e343d48168cca.
Matt Arsenault [Wed, 25 Mar 2020 00:47:54 +0000 (20:47 -0400)]
AMDGPU/GlobalISel: Add select patterns for v_and_or_b32
Matt Arsenault [Wed, 25 Mar 2020 00:33:39 +0000 (20:33 -0400)]
AMDGPU/GlobalISel: Add load legalization tests
Matt Arsenault [Wed, 25 Mar 2020 00:27:00 +0000 (20:27 -0400)]
AMDGPU/GlobalISel: Add missing tests for G_FRINT selection
Adrian Prantl [Wed, 18 Mar 2020 22:30:20 +0000 (15:30 -0700)]
Allow remapping Clang module include paths
rdar://problem/
55685132
Differential Revision: https://reviews.llvm.org/D76385
Adrian Prantl [Wed, 18 Mar 2020 22:31:39 +0000 (15:31 -0700)]
Add an -object-path-prefix option to dsymutil
to remap object file paths (but no source paths) before
processing. This is meant to be used for Clang objects where the
module cache location was remapped using ``-fdebug-prefix-map``; to
help dsymutil find the Clang module cache.
<rdar://problem/
55685132>
Differential Revision: https://reviews.llvm.org/D76391
Matt Arsenault [Thu, 13 Feb 2020 20:52:32 +0000 (15:52 -0500)]
GlobalISel: Introduce bitcast legalize action
For some operations, the type is unimportant and only the number of
bits matters. For example I don't want to treat <4 x s8> as a legal
type, but I also don't want to decompose loads of this into smaller
pieces to get legal register types.
On AMDGPU in SelectionDAG, we legalize a number of operations (most
notably load and store) by coercing all types to vectors of i32. For
GlobalISel, I'm trying very hard to avoid doing this for every type,
but I don't think this strategy can be completely avoided. I'm trying
to avoid bitcasts for any legitimately legal type we can operate on,
since the intervening bitcasts have proven to be a hassle.
For loads, I think I can get away without ever casting the result
type, and handling any arbitrary bitwidth during selection (I will
eventually want new tablegen support to help with this, rather than
having to add every possible type as legal). The unmerge required to
do anything with the value should expand to the expected shifts. This
is trickier for stores, since it would now require handling a wide
array of truncates during selection which I don't want.
Future potentially interesting case are for vector indexing, where
sub-dword type should be indexed in s32 pieces.
MaheshRavishankar [Tue, 24 Mar 2020 22:55:36 +0000 (15:55 -0700)]
[mlir][GPU] Use StructAttr to drive lowering from loop.parallel to
gpu.launch
Current implementation of lowering from loop.parallel to gpu.launch
uses a DictionaryAttr to specify the mapping. Moving this attribute to
be auto-generated from specification as a StructAttr. This simplifies
a lot the logic of looking up and creating this attribute.
Differential Revision: https://reviews.llvm.org/D76165
Dan Liew [Tue, 24 Mar 2020 02:57:33 +0000 (19:57 -0700)]
Add a `Symbolizer::GetEnvP()` method that allows symbolizer implementations to customise the environment of the symbolizer binary.
Summary:
This change introduces the `Symbolizer::GetEnvP()` method that returns a
pointer to environment array used for spawning the symbolizer process.
The motivation is to allow implementations to customise the environment
if required. The default implementation just returns
`__sanitizer::GetEnviron()` which (provided it's implemented) should
preserve the existing behaviours of the various implementations.
This change has been plumbed through the `internal_spawn(...)` and
`StartSubprocess(...)` process spawning implementations.
For the `StartSubprocess()` implementation we need to call `execve()`
rather than `execv()` to pass the environment. However, it appears that
`internal_execve(...)` exists in sanitizer_common so this patch use that
which seems like a nice clean up.
Support in the Windows implementation of
`SymbolizerProcess:StartSymbolizerSubprocess()` has not been added
because the Windows sanitizer runtime doesn't implement `GetEnviron()`.
rdar://problem/
58789439
Reviewers: kubamracek, yln, dvyukov, vitalybuka, eugenis, phosek, aizatsky, rnk
Subscribers: #sanitizers, llvm-commits
Tags: #sanitizers
Differential Revision: https://reviews.llvm.org/D76666
Nikita Popov [Tue, 24 Mar 2020 21:39:25 +0000 (22:39 +0100)]
[LVI] Convert some checks to assertions; NFC
solveBlockValue() should only be called if the value isn't cached
yet. Similarly, it does not make sense to "solve" a constant.
Louis Dionne [Tue, 24 Mar 2020 22:06:23 +0000 (18:06 -0400)]
[libc++] Install a recent CMake in the Docker build bots
Louis Dionne [Thu, 27 Feb 2020 13:14:38 +0000 (08:14 -0500)]
[libc++] Build the dylib with C++17 to allow aligned new/delete
This allows simplifying the implementation of barriers.
Differential Revision: https://reviews.llvm.org/D75243
Mitch Phillips [Tue, 24 Mar 2020 21:37:07 +0000 (14:37 -0700)]
[GWP-ASan] Only pack frames that are stored.
Summary:
Backtrace() returns the number of frames that are *available*, rather
than the number of frames stored. When we pack, we supply the number of
frames we have stored. The number of available frames can exceed the
number of stored frames, leading to stack OOB read.
Fix up this problem.
Reviewers: eugenis
Reviewed By: eugenis
Subscribers: #sanitizers, morehouse, cferris, pcc
Tags: #sanitizers
Differential Revision: https://reviews.llvm.org/D76722
Eli Friedman [Fri, 20 Mar 2020 21:18:04 +0000 (14:18 -0700)]
[clang codegen] Clean up handling of vectors with trivial-auto-var-init.
The code was pretending to be doing something useful with vectors, but
really it was doing nothing: the element type of a vector is always a
scalar type, so constWithPadding would always just return the input constant.
Split off from D75661 so it can be reviewed separately.
While I'm here, also add testcase to show missing vector handling.
Differential Revision: https://reviews.llvm.org/D76528