Mike Blumenkrantz [Sun, 7 Sep 2014 16:49:19 +0000 (12:49 -0400)]
add docs for all the comp_object data keys
Mike Blumenkrantz [Sun, 7 Sep 2014 16:08:45 +0000 (12:08 -0400)]
throw CRI on e_object type errors
Mike Blumenkrantz [Sun, 7 Sep 2014 16:00:07 +0000 (12:00 -0400)]
fix client positioning when initial position is offscreen or size is huge
ref T1571
Mike Blumenkrantz [Sun, 7 Sep 2014 15:45:31 +0000 (11:45 -0400)]
remove misleading old comment
Mike Blumenkrantz [Sun, 7 Sep 2014 15:13:45 +0000 (11:13 -0400)]
add another main loop iteration after resuming for desklock visibility
fix T1498
Kai Huuhko [Sun, 7 Sep 2014 13:31:32 +0000 (16:31 +0300)]
l10n: update Finnish translations
Mike Blumenkrantz [Sun, 7 Sep 2014 13:21:39 +0000 (09:21 -0400)]
simplify eeze backlight detection
Mike Blumenkrantz [Sun, 7 Sep 2014 13:16:49 +0000 (09:16 -0400)]
only default to led subsystem backlight if it isn't a mail or kbd device
fix T1497
do backlights with subsystem=leds still exist or have they fixed that yet?
Chris Michael [Fri, 5 Sep 2014 19:52:09 +0000 (15:52 -0400)]
remove useless return
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Mike Blumenkrantz [Fri, 5 Sep 2014 19:04:10 +0000 (15:04 -0400)]
use e_auth hash function instead of eina hash for passwords
users should keep in mind that this is not the fort knox of password storage, and someone who copies your config file could rainbow table a short password stored with this hash very easily. at some point in the future, if someone has the interest and time, perhaps this can be improved
fix T1627
Mike Blumenkrantz [Fri, 5 Sep 2014 19:02:10 +0000 (15:02 -0400)]
add e_auth_hash_djb2 inline
all eina hash functions are now useless for any case where the hashed value needs to be stored, so it's necessary for e to provide its own hash function to use for password storage
Mike Blumenkrantz [Fri, 5 Sep 2014 19:00:51 +0000 (15:00 -0400)]
add short path to ensure ConfigureNotify event after request
fix T1485
Mike Blumenkrantz [Fri, 5 Sep 2014 18:29:39 +0000 (14:29 -0400)]
fix pointer crashes from wrong #ifdefs in
1f439893f1c6ee2987b024ad445a2852f2fcafdf
Mike Blumenkrantz [Fri, 5 Sep 2014 18:27:59 +0000 (14:27 -0400)]
clean up function/macro use in e_pointer
Chris Michael [Fri, 5 Sep 2014 16:27:01 +0000 (12:27 -0400)]
Revert "bugfix: Set pointer timer & poller members to NULL after we delete the"
This reverts commit
bb2dab1a5d6d83ee0c3c9a68de35c740aa9205d9.
Revert this because the macro already sets the pointers to NULL.
Chris Michael [Fri, 5 Sep 2014 16:20:54 +0000 (12:20 -0400)]
modules/notification: e_comp_object_util_zone_get Can return NULL so
we should check the return before trying to use it. Should fix Phab
T1618
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Fri, 5 Sep 2014 15:40:00 +0000 (11:40 -0400)]
bugfix: Set pointer timer & poller members to NULL after we delete the
timer/poller
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Fri, 5 Sep 2014 15:16:55 +0000 (11:16 -0400)]
modules/conf_display: Fix CID1039753 Unused pointer value
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Fri, 5 Sep 2014 15:12:44 +0000 (11:12 -0400)]
modules/conf_keybindings: Fix CID1039754 Unused pointer value
The "Don't know EINA_LIST_FOREACH macro" bandit strikes again !!
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Fri, 5 Sep 2014 15:10:54 +0000 (11:10 -0400)]
modules/conf: Fix CID1039755 Unused pointer value
If the function returned a handle to an object, the handle may be lost.
In _e_configure_fill_cat_list: Pointer returned from a function was
never used (CWE-563)
NB: Someone should have read EINA_LIST_FOREACH on this one ;)
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Fri, 5 Sep 2014 15:05:59 +0000 (11:05 -0400)]
modules/pager_plain: Fix CID1039809 Dereference before null check
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Fri, 5 Sep 2014 15:02:16 +0000 (11:02 -0400)]
modules/ibar: Fix Dereference before null check. Also remove extra
call to ibar_resize_handle (is already called from ibar_fill).
Fixes CID1039813
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Fri, 5 Sep 2014 14:57:21 +0000 (10:57 -0400)]
modules/fileman: Fix Dereference before null check
Fixes CID1039814
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Fri, 5 Sep 2014 14:50:25 +0000 (10:50 -0400)]
modules/everything: Fix dereference before null check
Fixes CID1039816
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Fri, 5 Sep 2014 14:47:53 +0000 (10:47 -0400)]
modules/everything: Fix dereference before null check
Fixes CID1039817
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Fri, 5 Sep 2014 14:44:07 +0000 (10:44 -0400)]
modules/bluez4: Fix dereference before null check
Fixes CID1039818
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Stefan Schmidt [Fri, 5 Sep 2014 12:40:49 +0000 (14:40 +0200)]
modules/everything: Last orrurance of missing parentheses
Again, a logic problem as without the parentheses this would evauluate to
false in all cases.
CID 1212002
Stefan Schmidt [Fri, 5 Sep 2014 12:38:36 +0000 (14:38 +0200)]
modules/everything: More parentheses fixes for correct logic
Without the correctparenthese this would always evaluate to false.
CID 1212000, CID 1212001
Stefan Schmidt [Fri, 5 Sep 2014 12:33:24 +0000 (14:33 +0200)]
modules/everything: Fix parentheses for CHECK_TYPE macro
Without these parentheses the logic would always be false.
CID 1211999, CID 1212003
Stefan Schmidt [Fri, 5 Sep 2014 12:20:18 +0000 (14:20 +0200)]
e_module: Remove dead code after return statement.
Never executed as we retrun before in any case.
CID 1039762
Stefan Schmidt [Fri, 5 Sep 2014 12:14:33 +0000 (14:14 +0200)]
module/connman: Remove dead code after return.
The if else above retruns in both cases. This code was never executed.
CID 1039761
Stefan Schmidt [Fri, 5 Sep 2014 10:12:13 +0000 (12:12 +0200)]
e_alert_main: Don't monitor in E in wayland only mode to avoid endless restarts
When running in Wayland only mode we don't have XCB available so a
xcb_connection would fail and we would restart endlessly.
I have been bitten by that often enough now. Better shutdown E cleanly and don't
use the watchdog functionality for now. This needs a wayland specific solution
anyway.
Stefan Schmidt [Fri, 5 Sep 2014 09:54:45 +0000 (11:54 +0200)]
e_comp_wl: Remove unused variable and mark parameter as unused.
Chris Michael [Thu, 4 Sep 2014 19:55:18 +0000 (15:55 -0400)]
bugfix: use existing compositor canvas pointer as the windows pointer
when doing wayland windows (internal dialogs), and in such a case
don't free the window pointer on window hide/destroy.
NB: This fixes the case when running wayland-only and dialogs would
actually show 2 pointers.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 4 Sep 2014 19:51:46 +0000 (15:51 -0400)]
bugfix: handle case of pointer_xy_get being called if we are not
wayland-only and also not working with an X client.
bugfix: Fix case of pointers_size_set not adjusting pointer structure
fields with new size when rendering wayland pointers.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 4 Sep 2014 16:49:31 +0000 (12:49 -0400)]
e-comp-wl: Remove blank line
Signed-off-by: Chris Michael <cp.michael@samsung.com>
vivek [Thu, 4 Sep 2014 16:48:29 +0000 (12:48 -0400)]
e_comp_wl: Handle surface opaque region in subsurface commit from cache
Summary: When we commit a subsurface from cache, we should adjust the
client's shape rectangles so that they get applied when rendering.
Signed-off-by: vivek <vivek.ellur@samsung.com>
Reviewers: devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1412
Chris Michael [Thu, 4 Sep 2014 14:05:59 +0000 (10:05 -0400)]
bugfix: wl-drm: Fix hard-coded screen size of the ecore_evas
NB: This makes use of newly added ecore_evas_screen_geometry_get of
the ecore_evas_drm code in order to get the current screen size and
adjust the ecore_evas accordingly.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Igor Murzov [Tue, 2 Sep 2014 22:56:27 +0000 (02:56 +0400)]
Update russian translation
Tom Hacohen [Wed, 3 Sep 2014 14:42:29 +0000 (15:42 +0100)]
Update gitignore.
Igor Murzov [Wed, 3 Sep 2014 13:11:19 +0000 (17:11 +0400)]
Improve messages in bindings configuration dialogs
Igor Murzov [Wed, 3 Sep 2014 11:28:47 +0000 (15:28 +0400)]
po/POTFILES.in: Add files of Pager Plain module
Mike Blumenkrantz [Wed, 3 Sep 2014 13:45:20 +0000 (09:45 -0400)]
non-client comp object creation checks "noshadow" edje flag on passed objects
returns theme functionality from e17
Igor Murzov [Tue, 2 Sep 2014 14:48:59 +0000 (18:48 +0400)]
xz is the preferred compression method these days.
bzip2 is deprecated.
vivek [Tue, 2 Sep 2014 12:34:52 +0000 (08:34 -0400)]
bugfix: Check for parent surface before creating popup
xdg_shell requires a parent surface in order to create a popup, so we
should check the validity of the parent resource and error out
accordingly
Summary: Signed-off-by: vivek <vivek.ellur@samsung.com>
Reviewers: devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1388
Mike Blumenkrantz [Mon, 1 Sep 2014 18:22:44 +0000 (14:22 -0400)]
use a non-conflicting data item for comp mirror creation
Mike Blumenkrantz [Mon, 1 Sep 2014 17:55:02 +0000 (13:55 -0400)]
shorten rendering path when creating comp mirrors from comp mirrors
Mike Blumenkrantz [Mon, 1 Sep 2014 16:33:31 +0000 (12:33 -0400)]
Install everything.pc in $prefix/libdata/pkgconfig on FreeBSD
fix T1605
Mike Blumenkrantz [Mon, 1 Sep 2014 16:32:23 +0000 (12:32 -0400)]
fix tw warnings
Mike Blumenkrantz [Sun, 31 Aug 2014 03:20:36 +0000 (23:20 -0400)]
redo tw download handlers to use a valid object check
fix T1544
Mike Blumenkrantz [Sat, 30 Aug 2014 11:30:24 +0000 (07:30 -0400)]
redo comp object util refs to be more consistent and not break evas
Mike Blumenkrantz [Sat, 30 Aug 2014 11:13:04 +0000 (07:13 -0400)]
don't break nocomp for client activate requests
Mike Blumenkrantz [Sat, 30 Aug 2014 11:12:49 +0000 (07:12 -0400)]
only add damages for nocomp clients if they are protocol-visible
Mike Blumenkrantz [Fri, 29 Aug 2014 19:28:17 +0000 (15:28 -0400)]
only use pixmap size shortcut on non-internal clients
this gets broken pretty easily since we resize all over the place
Mike Blumenkrantz [Fri, 29 Aug 2014 18:50:47 +0000 (14:50 -0400)]
systray should now update comp_x client pixmap size since it's handling window resizes
Mike Blumenkrantz [Fri, 29 Aug 2014 18:23:54 +0000 (14:23 -0400)]
yet another systray overhaul to avoid destroying batter after nocomp ends
bottom line, this is a pile-of-shit protocol to work with if you're compositing. at present, any xembeds which were present before a nocomp event will be permanently destroyed, and they can't be recovered until the app re-creates them. afaik, no app does this unless you restart it.
Mike Blumenkrantz [Fri, 29 Aug 2014 18:12:28 +0000 (14:12 -0400)]
fix stupid pixmap refresh logic
davemds [Sun, 31 Aug 2014 13:34:36 +0000 (15:34 +0200)]
Fix gadcon popup to reposition correctly on size changes
None was setting the visible flags, that is checked before reposition the popup
Mike Blumenkrantz [Fri, 29 Aug 2014 18:03:40 +0000 (14:03 -0400)]
todo--
Mike Blumenkrantz [Fri, 29 Aug 2014 17:54:08 +0000 (13:54 -0400)]
add -Wmaybe-uninitialized for non-release builds
Srivardhan Hebbar [Fri, 29 Aug 2014 17:49:17 +0000 (13:49 -0400)]
teamwork: Fixed sliders issue.
Summary:
This is a fix for bug T1553: [Teamwork Settings] Sliders Should Be Disabled When Select "Disable remote media fetching"
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: zmike, devilhorns
Subscribers: cedric
Maniphest Tasks: T1553
Differential Revision: https://phab.enlightenment.org/D1375
Gwanglim Lee [Fri, 29 Aug 2014 17:48:01 +0000 (13:48 -0400)]
added mobile policy module
Summary: mobile policy module provides user interface for small mobile devices like phones.
Test Plan: N/A
Reviewers: raster, devilhorns, zmike
Subscribers: seoz, zmike, cedric
Differential Revision: https://phab.enlightenment.org/D817
Seunghun Lee [Fri, 29 Aug 2014 17:46:25 +0000 (13:46 -0400)]
set the maximized valuable of E_Client before calling _e_client_frame_update when unmaximize the client.
Summary: since maximized valuable is used in _e_client_frame_update, so the valuable should be updated.
Test Plan:
(1) run any application.
(2) Maximize the app by key binding.
(3) Change the border type.
(4) Unmaximize the it by key binding.
(5) try to maximize it again, but couldn't
Reviewers: zmike
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1357
Mike Blumenkrantz [Fri, 29 Aug 2014 14:38:51 +0000 (10:38 -0400)]
Revert "mixer: Optionally select an external mixer application."
This reverts commit
e4e2550484f504c3d87314737022d454c337b6d5.
apparently some people don't know what "feature freeze" means...
Brian 'morlenxus' Miculcy [Fri, 29 Aug 2014 13:32:05 +0000 (15:32 +0200)]
mixer: Optionally select an external mixer application.
This feature allows to define an external mixer application, which replaces the internal mixer.
Examples: 'terminology -e alsamixer', 'pavucontrol'
@feature
maxerba [Fri, 29 Aug 2014 11:17:10 +0000 (13:17 +0200)]
Updating esperanto and french translations
Mike Blumenkrantz [Fri, 29 Aug 2014 04:16:15 +0000 (00:16 -0400)]
unset release mode
Mike Blumenkrantz [Fri, 29 Aug 2014 04:16:00 +0000 (00:16 -0400)]
todo----
Mike Blumenkrantz [Fri, 29 Aug 2014 04:01:04 +0000 (00:01 -0400)]
rc3
Mike Blumenkrantz [Fri, 29 Aug 2014 04:25:55 +0000 (00:25 -0400)]
require efl 1.11
Mike Blumenkrantz [Thu, 28 Aug 2014 16:49:50 +0000 (12:49 -0400)]
set X pixmap size on client init
Chris Michael [Thu, 28 Aug 2014 16:36:02 +0000 (12:36 -0400)]
fix dnd compiler warnings when building for wayland-only
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 28 Aug 2014 16:33:10 +0000 (12:33 -0400)]
fixed backlight compiler warnings when building for wayland-only
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 28 Aug 2014 16:30:29 +0000 (12:30 -0400)]
fix e_screensaver_update compiler warnings when building for
wayland-only
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 28 Aug 2014 16:22:09 +0000 (12:22 -0400)]
fix unused variable if building for wayland-only
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 28 Aug 2014 16:10:09 +0000 (12:10 -0400)]
remove call to show pointer during canvas_new function
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 28 Aug 2014 15:39:25 +0000 (11:39 -0400)]
destroy pointer when destroying window since we create new pointers
for every window again.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 28 Aug 2014 15:36:38 +0000 (11:36 -0400)]
add fixme note
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Tom Hacohen [Thu, 28 Aug 2014 15:30:17 +0000 (16:30 +0100)]
Tiling: Respect min size hints (set to floating if doesn't fit).
This fix floats all the windows that don't fit because of their min size
restrictions.
It can be made better, at the moment it is very simple. An example
broken case would be the following:
Assume we have 3 windows, A, B and C.
B and C both hand a min width of half the screen.
First we create A, then B. Everything works as they share the screen,
but when we add C, both B's and C's restrictions "fail" so they are both
set to float although in reality, floating C is enough. This can be
fixed by doing a live scan of the tree every time a window is floated,
though it's not essential at the moment.
Fixes T952.
Chris Michael [Thu, 28 Aug 2014 15:10:07 +0000 (11:10 -0400)]
fix pointer for stupid X11...but this breaks pointers in wayland (for
now) :(
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 28 Aug 2014 15:08:36 +0000 (11:08 -0400)]
create window pointer based on compositor type
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 28 Aug 2014 15:01:46 +0000 (11:01 -0400)]
fix X compositor to use e_pointer_window_new
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 28 Aug 2014 15:00:22 +0000 (11:00 -0400)]
add back 'pixels' field structure for pointer
Signed-off-by: Chris Michael <cp.michael@samsung.com>
MinJeong Kim [Wed, 27 Aug 2014 12:24:26 +0000 (08:24 -0400)]
Check whether attached buffer exists, before using it.
Summary:
Because attached buffer can be NULL for removing surface content,
check of pending.buffer should be done before getting resource value of the buffer.
Reviewers: devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1370
Jérémy Zurcher [Wed, 27 Aug 2014 07:22:27 +0000 (09:22 +0200)]
add missing 'pragma GCC diagnostic push'
Chris Michael [Tue, 26 Aug 2014 18:36:57 +0000 (14:36 -0400)]
use a new e_pointer for the window canvas
This fixes an issue where internal dialogs were not using the e
cursors but would default back to an x cursor
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 26 Aug 2014 18:11:28 +0000 (14:11 -0400)]
be sure to send the wl_data_device_send_enter when changing surface
focus and add some more debugging for dnd
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 26 Aug 2014 18:06:57 +0000 (14:06 -0400)]
trap return value of shm_buffer_get
This function Can fail to return an shm_buffer if the buffer_resource
is an EGL buffer.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 25 Aug 2014 14:22:31 +0000 (10:22 -0400)]
Add checks for client being a wl pixmap in some functions
If we don't do this, then when we run in X11 with wl client support,
we crash in various places (iconify, etc) when trying to work with
normal X clients.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 25 Aug 2014 13:51:49 +0000 (09:51 -0400)]
fix dereference of incomplete pointer type
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 11 Aug 2014 13:35:14 +0000 (09:35 -0400)]
Fix formatting
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 7 Aug 2014 16:24:42 +0000 (12:24 -0400)]
wl-x11: Declare keyboard strings as NULL (initially) to avoid crash
when updating keymap
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Mike Blumenkrantz [Tue, 5 Aug 2014 14:16:16 +0000 (10:16 -0400)]
move wl client_resize protocol calls to idler
Mike Blumenkrantz [Mon, 4 Aug 2014 18:54:09 +0000 (14:54 -0400)]
automatically enable pointer and keyboard for wayland-in-X
Mike Blumenkrantz [Mon, 4 Aug 2014 14:20:45 +0000 (10:20 -0400)]
reuse existing render post callback for wayland clients
Chris Michael [Sun, 3 Aug 2014 14:34:38 +0000 (10:34 -0400)]
Fix elm apps crashing from invalid e_remember
Don't set changes.icon during surface creation. There are functions
that get called when icccm.class changes and That is the place to set
changes.icon.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Additional authors: zmike
Chris Michael [Sun, 3 Aug 2014 13:41:44 +0000 (09:41 -0400)]
Fix inproper setting of window type during transient_set.
This fixes the issue of some wayland applications always showing up
with the e_border visible.
If we get a transient_set from wl_shell or xdg_shell, don't reset the
client's netwm.type. Some wayland applications are sending us
transient_set with parent to NULL....so don't explicitly set the
netwm.type to dialog.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Sun, 3 Aug 2014 13:40:15 +0000 (09:40 -0400)]
Reduce usage of EC_CHANGED.
Lock subsurface border type to borderless.
Remove commented out code.
Don't mark border.changed during pre_frame callback.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 29 Jul 2014 20:26:48 +0000 (16:26 -0400)]
reorder client idler and stacking functions so we can call them after
post_move.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 29 Jul 2014 17:30:15 +0000 (13:30 -0400)]
Reduce potential of unnecessary function calls:
- When we are doing client eval, don't check for Just changes in
property OR fetching. Rather we will check using an AND.
Signed-off-by: Chris Michael <cp.michael@samsung.com>