Fix SPIR-V assembly tests with bad cfgs

* Update SPIR-V assembly tests to not declare a continue target as a
merge block

Component: Vulkan

VK-GL-CTS Issue: 2122

Affects:
dEQP-VK.spirv_assembly.instruction.graphics.switch_block_order.out_of_order*
dEQP-VK.spirv_assembly.instruction.graphics.opphi.out_of_order*
dEQP-VK.spirv_assembly.instruction.graphics.loop.multi_block_loop_construct*
dEQP-VK.spirv_assembly.instruction.graphics.loop.multi_block_continue_construct*
dEQP-VK.spirv_assembly.instruction.graphics.loop.continue*
dEQP-VK.spirv_assembly.instruction.graphics.loop.break*
dEQP-VK.spirv_assembly.instruction.graphics.loop.return*

Change-Id: I370331414aae27b53ed79b448b72581e2352c3d7

Fix device group rendering CTS crash

dEQP-VK.device_group.* tests use --deqp-vk-device-group-id as the group
id to use and --deqp-vk-device-id as the index for the physical device
to use from that group when creating the logical device.

--deqp-vk-device-id is checked by the program, in general, to be valid
regarding the total number of physical devices in the system, but these
tests were not verifying it to be valid regarding the selected group.

In a machine with two devices in two separate groups (one device per
group), the program would accept the following options as valid, only to
segfault later:

  $ deqp-vk --deqp-vk-device-group-id=1 --deqp-vk-device-id=2 ...

  or

  $ deqp-vk --deqp-vk-device-group-id=2 --deqp-vk-device-id=2 ...

This commit checks the provided device id is valid for the selected
group.

Affected tests:
dEQP-VK.device_group.*

Components: Vulkan
VK-GL-CTS issue: 1553

Change-Id: Ied8f2fb73384303b793258cbaeaa7fad503a03c1

Add test checking depth/stencil resolve properties

Check VkPhysicalDeviceDepthStencilResolvePropertiesKHR values according
to the spec.

New tests:
dEQP-VK.renderpass2.depth_stencil_resolve.misc.properties

Components: Vulkan
VK-GL-CTS issue: 2089

Change-Id: I58bbf7a2d492a459cac35a213d10c144843bfd05

Test stencil-only images in unused attachment clear tests

Affected and new tests:
dEQP-VK.renderpass*.unused_clear_attachments.*

Components: Vulkan
VK-GL-CTS issue: 2106

Change-Id: I2dfa2aafe1afe8c3a90a652c3c7f8c15aea48657

Test VK_ATTACHMENT_UNUSED with depth/stencil resolve

This commit adds new tests to use VK_ATTACHMENT_UNUSED as the attachment
number for the depth/stencil resolve attachment and later verifies the
image has not been touched.

New tests:
dEQP-VK.renderpass2.depth_stencil_resolve.*unused_resolve*

Components: Vulkan
VK-GL-CTS issue: 2107

Change-Id: Ie00cf61c813b0993c8313c62f8f67a53505602ca

Add coverage for stencil image sampling

Add tests for sampling using nearest filter from following
stencil image formats: VK_FORMAT_S8_UINT, VK_FORMAT_D24_UNORM_S8_UINT,
VK_FORMAT_D32_SFLOAT_S8_UINT.

New tests:
dEQP-VK.texture.filtering.2d.formats.s8_uint.nearest
dEQP-VK.texture.filtering.2d.formats.d24_unorm_s8_uint_stencil.nearest
dEQP-VK.texture.filtering.2d.formats.d32_sfloat_s8_uint_stencil.nearest
dEQP-VK.texture.filtering.unnormal.formats.s8_uint.nearest
dEQP-VK.texture.filtering.unnormal.formats.d24_unorm_s8_uint_stencil.nearest
dEQP-VK.texture.filtering.unnormal.formats.d32_sfloat_s8_uint_stencil.nearest
dEQP-VK.texture.filtering.cube.formats.s8_uint.nearest
dEQP-VK.texture.filtering.cube.formats.d24_unorm_s8_uint_stencil.nearest
dEQP-VK.texture.filtering.cube.formats.d32_sfloat_s8_uint_stencil.nearest
dEQP-VK.texture.filtering.2d_array.formats.s8_uint.s8_uint_nearest
dEQP-VK.texture.filtering.2d_array.formats.d24_unorm_s8_uint_stencil.d24_unorm_s8_uint_stencil_nearest
dEQP-VK.texture.filtering.2d_array.formats.d32_sfloat_s8_uint_stencil.d32_sfloat_s8_uint_stencil_nearest
dEQP-VK.texture.filtering.3d.formats.s8_uint.s8_uint_nearest
dEQP-VK.texture.filtering.3d.formats.d24_unorm_s8_uint_stencil.d24_unorm_s8_uint_stencil_nearest
dEQP-VK.texture.filtering.3d.formats.d32_sfloat_s8_uint_stencil.d32_sfloat_s8_uint_stencil_nearest

Components: Vulkan

VK-GL-CTS issue: 2048

Change-Id: I43f28e6ec4eee5c04e444c9cded1c0a15b3d5e4c

dEQP-VK.graphicsfuzz.discards-in-control-flow

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.discards-in-control-flow

Change-Id: I219e0660fc74ba972a5e949cb7cb209cedbfca92

Merge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/master

Change-Id: I7c7197ea5881a8bdf500d19b834270807ed30ce9

Add VK_AMD_buffer_marker tests

This extension adds a new operation to execute pipelined writes
of small marker values into a VkBuffer object.

Components: Vulkan
VK-GL-CTS issue: 2104

New tests:
dEQP-VK.api.buffer_marker.*

Change-Id: I190b0b81564fe58707b6eae40f4768482b01699f

Merge vk-gl-cts/opengl-es-cts-3.2.5 into vk-gl-cts/opengl-es-cts-3.2.6

Change-Id: I069be78b5ad4a7299152d342c5cbfee6b7fc84f1

Merge vk-gl-cts/vulkan-cts-1.1.6 into vk-gl-cts/master

Change-Id: Ia98b822ba5c6e36b25d80836911e0e14c8db9929

Remove more tests due to GLSL ES 1.0/3.x differences

Components: OpenGL

VK-GL-CTS issue: 2116

Removed tests:
dEQP-GLES2.functional.shaders.functions.invalid.attribute_argument_vertex
dEQP-GLES2.functional.shaders.functions.invalid.varying_argument_fragment
dEQP-GLES2.functional.shaders.functions.invalid.varying_argument_vertex

Change-Id: I628242739fade1310e36065da785b12be0912284

Make asin and acos derived functions

The spec says that the precisions of these functions are derived from
formulae, rather than the requirements that were here before. The atan
code is simplified but there should be no functional change.

Components: Vulkan
VK-GL-CTS issue: 1975
Affects: dEQP-VK.glsl.builtin.precision.asin.*
         dEQP-VK.glsl.builtin.precision.acos.*
         dEQP-VK.glsl.builtin.precision.atan.*

Change-Id: I2f8fbed340b409e07526b7fc806f21bbea7ad607

Add AMD FMASK and EQAA extension tests

Adds tests for:
- VK_AMD_shader_fragment_mask
- VK_AMD_mixed_attachment_samples

VK_AMD_shader_fragment_mask extension provides efficient read access to the
fragment mask in compressed multisampled color surfaces. The fragment mask is
a lookup table that associates color samples with color fragment values.

VK_AMD_mixed_attachment_samples extension enables applications to use
multisampled rendering with a depth/stencil sample count that is larger than
the color sample count. Having a depth/stencil sample count larger than
the color sample count allows maintaining geometry and coverage information
at a higher sample rate than color information.

Components: Vulkan
VK-GL-CTS issue: 2104

Affected tests:
dEQP-VK.pipeline.multisample.sample_locations_ext.*

New tests:
dEQP-VK.pipeline.multisample.mixed_attachment_samples.*
dEQP-VK.pipeline.multisample.shader_fragment_mask.*

Change-Id: If4876eda00dcd2bac4f685252048c5afd58d3df5

Protected memory stack tests

Test use of stack in shaders in protected mode.

Add tests:
 * dEQP-VK.protected_memory.stack.stacksize_*

Components: Vulkan

VK-GL-CTS issue: 1075

Change-Id: I8b7439b7961f2f8539d94c3641c235a8e613b23e

Fix cbuffer packing test

Components: Vulkan

VK-GL-CTS issue: 2109

Affects:
dEQP-VK.spirv_assembly.instruction.compute.hlsl_cases.cbuffer_packing

Change-Id: Iebedd63004bceed7542a433da9be3d43a59fed2e

dEQP-VK.graphicsfuzz.uninit-element-cast-in-loop

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.uninit-element-cast-in-loop

Change-Id: Ia61e5ad2bdbba41b13bd70b7ba560339c2898b8f

Make qpLookupString lookup stricter

Do not allow the qpLookupString to use last element from the map
which must be reserved for map terminator.

Affects:
 * dEQP*

Components: framework

VK-GL-CTS issue: 2058

Change-Id: I29a493f4a81917137b62b94a3a281e8be53226a0

KHR-GLES31.core.constant_expressions.* add T&G tests to the test tree

KHR-GLES31.core.shader_macros* add T&G tests to the test tree

Even if geometry and tessellation shaders are not surpported the tests
need to be added to the test tree for the tests to be run and be marked
as not supported if necessary.

Components: Vulkan

VK-GL-CTS Issue: 1859

Affects:
KHR-GLES31.core.constant_expressions.*
KHR-GLES31.core.shader_macros*

Change-Id: I38960349d7e52b546f8e02af3d5190a8f7225588

Add --deqp-archive-dir command line option

Allows running in a different working directory from the archive
directory.

Components: Framework
VK-GL-CTS Issue: 2105

Change-Id: I803d735e7ca304069c881db90c195474f62c98f5

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: I6690ecfeeaf879819d23bb2a8a65c1713809e6a1

Add check comparing conformanceVersion to API version

Fail if reported conformanceVersion is older than API version.

Components: Vulkan

VK-GL-CTS Issue: 2091

Change-Id: If2a3337a11cc04c777ab28ea890eace994ced76e
Affects: dEQP-VK.api.driver_properties.conformance_version

Use cmake find_package for ZLIB and PNG libraries

This is the standard cmake way to find packages.

Change-Id: I193290c413fe917ceaad47519ababfb435c363cb

Enable storage image tests for more formats

On implementations that don't support the whole ExtendedFormat set, tests
that used any format from that set would return NotSupported. Changing
this to checking the actual format for storage image support allows us
still to run these tests on implementations where they're supported.

Component: Vulkan
VK-GL-CTS issue: 2090
Affects: dEQP-VK.image.mutable.*
         dEQP-VK.image.texel_view_compatible.*
         dEQP-VK.synchronization.*

Change-Id: I7de9c0bde1613d2cc1fc9f8490955c580a1939c1

Remove 16-bit storage from float16 composite tests

Remove the use of the 16-bit storage extension from float16 tests for
composite construct, insert and extract opcodes.

Component: Vulkan

VK-GL-CTS Issue: 1931

Affects:
dEQP-VK.spirv_assembly.instruction.*.float16.opcompositeconstruct*
dEQP-VK.spirv_assembly.instruction.*.float16.opcompositeinsert*
dEQP-VK.spirv_assembly.instruction.*.float16.opcompositeextract*

Change-Id: I8e17585148e7416e9bfbb3c500cffe27ae609599

Fix extension struct usage in descriptorset_random

dEQP-VK.binding_model.descriptorset_random tests were using extension
structures when creating the descriptor set layout without checking
first if the extension was supported.

Affected tests:
dEQP-VK.binding_model.descriptorset_random.*

Components: Vulkan
VK-GL-CTS issue: 1652

Change-Id: Ifc165293cb846316be4493a0f499b63719b61ac2

Re-align importing dedicated memory to spec

Re-implemented importing dedicated memory for synchronization test to
better align with the Vulkan spec. The current solution
makes the assumption that not requiring memory to be dedicated upon
import implies that the memory is required to not be dedicated, and this
does not appear to align with the spec.

Affects:
    * dEQP-VK.synchronization.signal_order.*

Components: Vulkan

VK-GL-CTS issue: 2071

Change-Id: Ie1ada8e4966e044ff0d265dce65f4a0680b311aa

Add index file for amber tests

This change adds index file for amber tests, making it possible to add
new amber tests without having to recompile the cts binary itself.
This change does not affect the tests themselves, just the way they are
discovered.

Affects: none

Components: Vulkan

VK-GL-CTS issue: 2086

Change-Id: Iba1d2b6cfe8816360fe520dec90621a71a4d2769

Extend maps with raygeneration types

Make QP to recognize ray tracing types
 * RayGenShader
 * AnyHitShader
 * ClosestHitShader
 * MissShader
 * IntersectionShader
 * CallableShader

Affects:
 * dEQP-VK.binding_model.descriptorset_random.*

Components: framework, vulkan

VK-GL-CTS issue: 2058, 1995

Change-Id: Idaba22c1fe07e040dbdcc143db2c9a5e52f2ae01

Merge vk-gl-cts/vulkan-cts-1.1.6 into vk-gl-cts/master

Change-Id: Id479d9ffe34b394d216d8961bdd06e76611fcf18

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: I163fd1d3c3f3a600e3a89031d350eb2b08f81e4d

Add memory barrier to VK transform_feedback tests

The transform feedback tests are reading the transform
feedback buffers which was written by the GPU from the
host. Added a memory barrier to make sure the data is up to
date when it is accessed by the host.

Affects: dEQP-VK.transform_feedback.*
Components: Vulkan
VK-GL-CTS issue: 2096

Change-Id: Ibf9f86e9c1f02bdbfe822f62c44c30155ed8c555

Merge vk-gl-cts/vulkan-cts-1.1.4 into vk-gl-cts/vulkan-cts-1.1.5

Change-Id: Idea5f48ee1eb6dfa2290d738cabff96c7e88daad

Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4

Change-Id: I9adaa87d0bf5d06a12bfc2fcd4b8a30568cefb48

Add tests for VK_EXT_fragment_density_map

Extension VK_EXT_fragment_density_map may reduce the amount of fragment shader calls
by broadcasting result of a single FS call to multiple pixels of a color attachment.

New tests:
dEQP-VK.renderpass2.fragment_density_map.*

Components: Vulkan

VK-GL-CTS issue: 1681

Change-Id: I1109c39f6b4100f380b99cb35ed7281c120157b1

Fix gerrit rebasing conflict

The new tests for sparse input attachments used the old syntax for
requiring extensions, so change it to the new method.

Change-Id: Ia0be4bce779f55b8d44fdc07b12d969f0bc88e43

Test sparse input attachments in VkSubpassDescription

According to specification VkSubpassDescription::pInputAttachments can
handle more input attachments than maxPerStageDescriptorInputAttachments
as long as the number of used input attachments is below this limit.
The rest must have VK_ATTACHMENT_UNUSED flag set in pInputAttachments.

New tests:
dEQP-VK.renderpass.suballocation.attachment_sparse_filling.*
dEQP-VK.renderpass2.suballocation.attachment_sparse_filling.*

Components: Vulkan

VK-GL-CTS issue: 2034

Change-Id: I10bec67b6fd8eb722d81bd8ee7344475b7b0511a

Add coverage for pipeline cache hit of active pipeline

This CL adds coverage to the dEQP-VK.pipeline.creation_feedback.*
tests for the case where the newly created pipeline has
a cache hit of another pipeline that was created previously,
and that other pipeline is still open and active.

Previously the test only had coverage for pipeline cache
hit of previous pipelines that were destroyed. This adds
coverage for both scenarios.

Affects:

dEQP-VK.pipeline.creation_feedback.*

Components: Vulkan

VK-GL-CTS issue: 2032

Change-Id: I7320d0bf075ea430eafbcf6c3b2518b985c024b8

Whitelist Vulkan CTS 1.1.6.2

Affects: dEQP-VK.api.driver_properties.properties

Components: Vulkan

Change-Id: I88e01d7a9c754c8a11cb5f4505257fd338eabbf7

Do not reset perf queries in multi submitted cmdbuffer

Some implementations can require multiple passes to gather values for
their performance queries. It's important not to reset the query pool
in a batch that can be submitted multiple times, otherwise the queries
result risk to never become available.

Compontents: Vulkan
Affects: dEQP-VK.query_pool.performance_query.*

Change-Id: Ief00457fc0808a7c5ee7c0bf6aaf7de7f3042ca5

Update VK_KHR_performance_query enumerate

Components: Vulkan
Affects: dEQP-VK.query_pool.performance_query.enumerate*

Change-Id: I443c1c9b7a1903063b27b77fc47cbb88259aa407
(cherry picked from commit bc519fecec3d1b27e0e5ee1a4947257260202eff)

Tests for VK_KHR_performance_query

Add tests:
 * dEQP-VK.query_pool.performance_query.*

Components: Vulkan

VK-GL-CTS issue: 1302

Update VK_KHR_performance_query headers

Align CTS header for VK_KHR_performance_query with API MR 3268
Components: Vulkan

Affects:
 dEQP-VK.query_pool.performance_query.*
 dEQP-VK.api.info.get_physical_device_properties2.features
 dEQP-VK.api.info.get_physical_device_properties2.properties

VK-GL-CTS issue: 1947

Change-Id: I4d3c62dace2d259061f78d3014deb05bc4eac9d7
(cherry picked from commit 32556493fcafd676ec5d8fcfd3492a8c30fa0f97)
(cherry picked from commit 57bdbad1c7d6d527a30ae211164edab945818def)

Remove tests that check non-zero values for reservedMustBeZero on all APIs

Although initially it was agreed to keep them for the APIs that still
include that field as reserved, and only remove them when the API
defines the field (baseInstance), in the end it was agreed to remove
it completely, as it is testing an undefined behaviour.

Components: OpenGL, OpenGL ES

VK-GL-CTS issue: 2029

Affects:
KHR-GL40.draw_indirect.misc-reservedMustBeZero-arrays
KHR-GL40.draw_indirect.misc-reservedMustBeZero-elements
KHR-GL41.draw_indirect.misc-reservedMustBeZero-arrays
KHR-GL41.draw_indirect.misc-reservedMustBeZero-elements
KHR-GLES31.core.draw_indirect.misc-reservedMustBeZero-arrays
KHR-GLES31.core.draw_indirect.misc-reservedMustBeZero-elements

Change-Id: Iafe3e711107da818a392ebcdfe50379cf3790d17

Don't check color outcome for tests that expect undefined behaviour

draw_indirect.misc-reservedMustBeZero-elements and its arrays
equivalent for both OpenGL and OpenGL ES tests the following paragraph
from the spec:

  "Results are undefined if reservedMustBeZero is non-zero, but must
   not lead to GL interruption or termination."

So it should check if there is no errors or crashes. But right now
those tests are also expecting a given color, that doesn't make sense
if the expected behaviour by spec is undefined.

This seems a C&P error from other tests.

Components: OpenGL, OpenGL ES

VK-GL-CTS issue: 2023

Affects:
KHR-GL41.draw_indirect.misc-reservedMustBeZero-arrays
KHR-GL41.draw_indirect.misc-reservedMustBeZero-elements
KHR-GLES31.core.draw_indirect.misc-reservedMustBeZero-arrays
KHR-GLES31.core.draw_indirect.misc-reservedMustBeZero-elements

Change-Id: I3e9a5d04893eec9359b55ea6c5130e940c943cf2

Check renderpass2 support in image clearing tests

This commit makes sure VK_KHR_create_renderpass2 is supported before
using it in some image clearing tests.

Affected tests:
dEQP-VK.api.image_clearing.*separate_layouts*

Components: Vulkan
VK-GL-CTS issue: 2101

Change-Id: Ib1a44b44f771bb31fd1ef798d2727370d143a1fa

Merge "Merge vk-gl-cts/vulkan-cts-1.1.6 into vk-gl-cts/master"

Replace imageAtomicExchange with imageAtomicCompSwap in vertex shader

Recently the test was changed in order to replace a imageAtomicAdd for
a imageAtomicExchange, as the test can't assume that the vertex shader
will be executed exactly one per vertex shader (see VK-GL-CTS issue
1910).

But imageAtomicExchange is also problematic because in some
architecture/driver, specially tile-based, the test can't also assume
that all the vertex shader executions would finish before
rasterization starts (so fragment shader execution). So when using
imageAtomicExchange could happend that a vertex shader execution would
override the value that the fragment shader already started to update.

Due this two restrictions, this patch changes the atomic operation on
the vertex shader to imageAtomicCompSwap, that sets the value of the
image at the vertex shader only if it is the initial value (so
zero). That would prevent any possible execution when the
rasterization already started to override the value of such image.

This patch also adds a comment on the code explaining the situation,
to avoid any possible future change to a simpler atomic operation by
mistake.

Components: OpenGL ES

VK-GL-CTS issue: 1997

Affects:
KHR-GLES31.core.shader_image_load_store.advanced-allStages-oneImage

Change-Id: Icbc34662f33839a1ced9f728cee45a1198e4b495

Move DE_3RD_PARTY_CXX*FLAGS definition to the end

Components: Framework

Change-Id: I67d550046e52eeb80467dc691f2c7c31423ebd8c

Merge vk-gl-cts/vulkan-cts-1.1.6 into vk-gl-cts/master

Change-Id: I033c9220c75bfe0747e6d7b75c7eb00f4619c383

Fix check of api features

Fixes the cherry pick 282341d2cf5da0d9aaea1547958eb54c3f84ee0f.

Compontents: Vulkan
Affects: dEQP-VK.api.info.get_physical_device_properties2.features

Change-Id: I1d102716767c7bef0b872a5ebe1eb1d77bcd11b5

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: I96bc5705c41b8ec87b7f14afc0cfa354b84cad4e

Merge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/master

Change-Id: Ie8ae10da8cc6b375e2d137d535d87cddc1170a49

dEQP-VK.graphicsfuzz.undefined-integer-in-function

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.undefined-integer-in-function

Change-Id: I3fa2b040bae1fa8b9c1db98488bfa95b170c1b59

dEQP-VK.graphicsfuzz.while-function-always-false

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.while-function-always-false

Change-Id: Ia741567432e6edd9071b92ea3adb6222bbbc163f

Split descriptor set indexing render pass workload

The render pass workload for descriptor set indexing tests which call
DynamicBuffersInstance::iterate should be split into multiple
submissions to prevent timeouts observed in
dEQP-VK.descriptor_indexing.uniform_buffer_dynamic_in_loop
test.

A number (16) of command buffers, each for a separate render area, are
created and submitted separately.

Affects: dEQP-VK.descriptor_indexing*

Components: Vulkan

VK-GL-CTS Issue: 2061

Change-Id: Ib232854a1224aadbd63eaad30e15f893eeb48f85

Investigation for Khronos issue;
https://gitlab.khronos.org/Tracker/vk-gl-cts/issues/2061

Change-Id: Ib232854a1224aadbd63eaad30e15f893eeb48f85

Reduce dEQP-VK.pipeline.render_to_image allocs to within platform limits

These tests allocate an image of upto 25% of VkMemoryHeap heapSize and
should be limited to the value in
PlatformMemoryLimits.totalSystemMemory.

Component: Vulkan

VK-GL-CTS Issue: 2087

Affects:
dEQP-VK.pipeline.render_to_image*

Change-Id: Ie7d775cc55fdb54e448fc1c973d1e17925711e47

Fix geometry shader limits regarding available image units

The test case KHR-GLES31.core.geometry_shader.api.max_image_uniforms
would fail if the implementations reports:

MAX_GEOMETRY_TEXTURE_IMAGE_UNITS < MAX_GEOMETRY_IMAGE_UNIFORMS

However, the latter was introduced with ARB_shader_image_load_store,
whereas the former refers to samplers. From the GLES 3.2 spec:

   "Note that image units used for image variables are independent
    of the texture image units used for sampler variables; the number
    of units provided by the implementation may differ.  Textures
    are bound independently and separately to image and texture image
    units".

In fact the ARB_shader_image_load_store spec doesn't mention any of
the MAX_{*}_TEXTURE_IMAGE_UNITS at all, and it only talks about
MAX_IMAGE_UNITS and MAX_{*}_IMAGE_UNIFORMS.

Specifically, the test calls glBindImageTexture for as many
units as reported by MAX_GEOMETRY_IMAGE_UNIFORMS and the spec for
glBindImageTexture only requires that:

   "An INVALID_VALUE error is generated if unit is greater than
    or equal tothe value of MAX_IMAGE_UNITS, (...)"

So this changes the test to fail only if:

MAX_IMAGE_UNITS < MAX_GEOMETRY_IMAGE_UNIFORMS

VK-GL-CTS issue: 2057
Components: OpenGL ES
Affects: KHR-GLES31.core.geometry_shader.api.max_image_uniforms
Change-Id: I24566a1372c486512b64ce5d4b329925d859e0af

Add tests for variable init from global variable

The existing OpVariable init tests were using
only constants as the initialization value. Now
also global scope variables are tested. There
are two variations for these global variables:
one where it's initialized from a constant and
one where the value is written in the code before
using the global as an initialization source.

Affects:

dEQP-VK.spirv_assembly.*.variable_init.*

New tests:

dEQP-VK.spirv_assembly.*.variable_init.*_from_*

Components: Vulkan

VK-GL-CTS issue: 1773

Change-Id: If19f8c3ec5b5da5626c41991add15eaa3183d77f

Revert "Remove NaNs from double compare tests"

This reverts commit fd434f47d86cd9f866c9e41adbb5d1d2b982a19b.

Affected tests:
dEQP-VK.spirv_assembly.instruction.*.64bit_compare.double.*

Components: Vulkan
VK-GL-CTS issue: 2066

Change-Id: Id0764ce159ca7edd96ec95864f62b928f3831718

dEQP-VK.graphicsfuzz.call-if-while-switch

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.call-if-while-switch

Change-Id: Ia0806ffc67be9f9b6eacdab6747bd8217bed7b46

Remove dead members from synchronization OperationContext

These are not used since the switch to `requireDeviceFunctionality`
test case API.

Components: Vulkan

Affects: dEQP-VK.synchronization.*

Change-Id: Ib6e0b817e5732e1be2e58b5b781a4f5af9d824a3

subgroups: Use common boilerplate for shader code

The code that set up the input values and wrote the output values to
appropriate locations was the same in all sets of subgroup tests and
duplicated into each of them, meaning any bugs had to be fixed multiple
times. Put all this common boilerplate into the TestUtils.

Components: Vulkan
Affects: dEQP-VK.subgroups.ballot_broadcast.*
         dEQP-VK.subgroups.arithmetic.*
         dEQP-VK.subgroups.clustered.*
         dEQP-VK.subgroups.quad.*

Change-Id: Ibde86869c33df4d057b9fd39705feeb9dff8c248

Fix descriptor_indexing.input_attachment subpass description

The input attachments in the subpass description did not match the
descriptor set layout and shader. Unused attachment references have
been inserted to pad out the subpass description.

Components: Vulkan

VK-GL-CTS Issue: 2072

Affects: dEQP-VK.descriptor_indexing.input_attachment*

Change-Id: Iab36be779007828ddb25fe0600305a19be448804

Merge vk-gl-cts/vulkan-cts-1.1.4 into vk-gl-cts/vulkan-cts-1.1.5

Change-Id: I74696bcb3e23aa3e8bde59ebea3137b262dd1394

dEQP-VK.graphicsfuzz.undefined-assign-in-infinite-loop

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.undefined-assign-in-infinite-loop

Change-Id: I8dac4a3fe6570bf3a38de206434af534862e0544

Check NaN support in double comparison tests

This commit makes sure NaNs are supported in shaders before using them
in double comparison tests, activating the needed extensions and
capabilities.

Affected and new tests:
dEQP-VK.spirv_assembly.instruction.*.64bit_compare.*

Components: Vulkan
VK-GL-CTS issue: 2066

Change-Id: I3d4d344a0fdaa574d7653d30d1ddc248eda0047e

Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4

Change-Id: Ia5d78f0656fb1a2b2e4f989ba556edc3154856f7

dEQP-VK.graphicsfuzz.conditional-return-in-infinite-while

Components: Vulkan

New tests:

dEQP-VK.graphicsfuzz.conditional-return-in-infinite-while

Change-Id: I9939759eb848c1a8bb9789eb0234bde10bc53335

Tests for VK_KHR_separate_depth_stencil_layouts

Test coverage for VK_KHR_separate_depth_stencil_layouts. See
https://gitlab.khronos.org/vulkan/vulkan/merge_requests/3172

This change modifies several test groups to use a single
image aspect bit for depth+stencil formats rather than the
VU required D+S aspects.

Where appropriate the tests are also modified to use
the new depth-only or stencil-only optimal layouts.

Affects:

dEQP-VK.api.copy_and_blit.*d16_unorm_s8_uint*
dEQP-VK.api.copy_and_blit.*d24_unorm_s8_uint*
dEQP-VK.api.copy_and_blit.*d32_sfloat_s8_uint*

dEQP-VK.api.image_clearing*d16_unorm_s8_uint*
dEQP-VK.api.image_clearing*d24_unorm_s8_uint*
dEQP-VK.api.image_clearing*d32_sfloat_s8_uint*

dEQP-VK.pipeline.stencil*d16_unorm_s8_uint*
dEQP-VK.pipeline.stencil*d24_unorm_s8_uint*
dEQP-VK.pipeline.stencil*d32_sfloat_s8_uint*

dEQP-VK.pipeline.depth*d16_unorm_s8_uint*
dEQP-VK.pipeline.depth*d24_unorm_s8_uint*
dEQP-VK.pipeline.depth*d32_sfloat_s8_uint*

dEQP-VK.*.depth_stencil_resolve*d16_unorm_s8_uint*
dEQP-VK.*.depth_stencil_resolve*d24_unorm_s8_uint*
dEQP-VK.*.depth_stencil_resolve*d32_sfloat_s8_uint*

Change-Id: I147f3736614cc897f1319c5aac5ed1fdba2d7b66
Compontents: Vulkan
(cherry picked from commit 39e17004ec33f0e546e6f391f933fb938e8c507d)

Whitelist Vulkan CTS 1.1.6.1

Affects: dEQP-VK.api.driver_properties.properties

Components: Vulkan

Change-Id: Id79758cf4688ec414176433edae0914826f088df

dEQP-VK.graphicsfuzz.loops-ifs-continues-call

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.loops-ifs-continues-call

Change-Id: I2210e55707fc698b5913166f05e833f8cc329dc5

dEQP-VK.graphicsfuzz.access-new-vector-inside-if-condition

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.access-new-vector-inside-if-condition

Change-Id: I61948b3e73e4e761a65783420df29f080fab7132

dEQP-VK.graphicsfuzz.two-nested-for-loops-with-returns

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.two-nested-for-loops-with-returns

Change-Id: I862653671a578c4910b691c0c7e78d9c373871de

dEQP-VK.graphicsfuzz.unreachable-discard-statement-in-if

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.unreachable-discard-statement-in-if

Change-Id: I88cf495fffb65b5288143b352628a737c621b933

dEQP-VK.graphicsfuzz.return-float-from-while-loop

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.return-float-from-while-loop

Change-Id: Ic3d8f5f7ec29de0e9af677a13b68f390fe40256d

dEQP-VK.graphicsfuzz.uninitialized-var-decrement-and-add

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.uninitialized-var-decrement-and-add

Change-Id: Iacb6064282253a8107d3d3aee04d133ab36503d7

dEQP-VK.graphicsfuzz.returned-boolean-in-vector

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.returned-boolean-in-vector

Change-Id: I6976dd7e81ee6056cd28ed8cc23846bac2a35ebe

Merge vk-gl-cts/vulkan-cts-1.1.6 into vk-gl-cts/master

Change-Id: I2db83dc66e6f9b7bc98171060d27192ea8353e7a

dEQP-VK.graphicsfuzz.always-false-if-in-do-while

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.always-false-if-in-do-while

Change-Id: I31714d74ce659d0c2a78f279d3477aafdfc7c6c1

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: I592b6674f5e3a5a1f2a6d050dcc7263b0e5d682c

dEQP-VK.graphicsfuzz.for-loop-with-return

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.for-loop-with-return

Change-Id: I567181e35ed9effa60edb390019cf75a8ec6eb43

dEQP-VK.graphicsfuzz.two-nested-infinite-loops-discard

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.two-nested-infinite-loops-discard

Change-Id: I10f80a5b5640b209c9dfb0b612ab232735cda7e2

Add missing write to PointSize

The primitive topology is POINT_LIST for test cases covering the vertex
stage, but the vertex shader in these cases isn't supplying a value for
PontSize.

Affects:

dEQP-VK.binding_model.buffer_device_address.*.vert

Components: Vulkan

VK-GL-CTS issue: 2080

Change-Id: Ibbbeb143bf957f9494b1df84e69bc4a01c891c6a

Fix missing image memory barrier in WSI display timing tests

The key part of the missing image memory barrier is changing
VK_IMAGE_LAYOUT_UNDEFINED to VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL
(for the first time).

Affects: dEQP-VK.wsi.android.display_timing.*

Components: Vulkan

VK-GL-CTS issue: 2079

Change-Id: I79e142c9c2a602e066a51e69e3aca9a1d2c0e650

Merge vk-gl-cts/vulkan-cts-1.1.6 into vk-gl-cts/master

Change-Id: Ic181ad20201d78dc31564319ab56cbb4323de1c9

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: I34ada51e1b9c00280fb9f9d60463989e05f11953

Add timelineSempahore to mandatory ext features

https://gitlab.khronos.org/vulkan/vulkan/merge_requests/3421
clarifies that timelineSemaphore is mandatory for
implementations exposing VK_KHR_timeline_semaphore

This CL updates the test to align with the MR.

Components: Vulkan

Affects: dEQP-VK.api.info.device.mandatory_features

Change-Id: I12f9c9e6b05a77109cb0207b748cc9ccfa872d9b
(cherry picked from commit 33cc61974078e64d66e64ccf67ecc906f7a7f3fb)

Merge vk-gl-cts/vulkan-cts-1.1.6 into vk-gl-cts/master

Change-Id: I67e8f8fc2b64060fca9e5a8016cf7d5b53ec5477

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: I3fd2e50726e016645834052ba95fa761f84c5686

Fix check in testMandatoryExtensions

Affects:
dEQP-VK.api.info.android.mandatory_extensions

Change-Id: Iec3b405cb168daa7dd7fc2183963778ef7d6eb0b
Components: Vulkan

Remove deprecated std::bind2nd() call

std::bind2nd() was deprecated in C++11 and removed in C++17.

Affects:
dEQP-VK.descriptor_indexing.*

Components: Vulkan

VK-GL-CTS issue: 2074

Change-Id: I408a39ce9f1632515e3ff6bcfb95966e19aa4b22

Test multiple overlapping cube maps

Test cube map images containing multiple overlapping cube maps.

Add tests:
 * dEQP-VK.image.misaligned_cube.*

Components: vulkan

VK-GL-CTS issue: 1889

Change-Id: I24eeba1eea1513e51cc3c4cd0b23d18e3ce8234d

Special-case RenderbufferStorageMultisampleEXT in codegen

Android has additional tests for this ES extension, which we had
observed was shipping broken on various Android devices. Unfortunately,
the ES extension which introduces this function specifies very different
semantics from the same-named function in desktop GL. In desktop GL,
this function is also defined to alias the core
RenderbufferStorageMultisample, and is assigned the same GLX opcode.

We had previously tried to unalias the function in the registry, but
that proved unworkable due to the GLX opcode aliasing.

Instead, add a special case in the CTS code generation.

Change-Id: Id62394cae2b2f01e0a91fdc4d9d357b634a26cf1
Components: Framework

Unsized internalformats not valid GetInternalFormat

Spec changed where unsized internal formats are not
valid for GetInternalFormativ
https://www.khronos.org/members/login/bugzilla/show_bug.cgi?id=15912

Components: OpenGL ES

VK-GL-CTS Issue: 2067

Affects:
dEQP-GLES3.functional.state_query.internal_format.*

Change-Id: I468c06bda3f077e02d8a811f32e0d3c894f1116b

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: I21178b89019aad73d0b1862e10d5590361fcdcc8

Add scissor matching renderArea to descriptor indexing tests

This fixes rendering outside of render area, what
is forbidden by spec.

This also fixes regression from 7b7ba4e0, where
looping the RenderPass caused workload execution time
to increase and trigger OS-specific device timeout.

Components: Vulkan

VK-GL-CTS Issue: 2069

Affects: dEQP-VK.descriptor_indexing.*

Change-Id: I40f665ff892d03004860583029eb393e09c1ae95

Merge vk-gl-cts/vulkan-cts-1.1.6 into vk-gl-cts/master

Change-Id: I563fc81549024a61aadc779285e8d4686c9c931a

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: I365220265de5dd5b239cca76b1ffcd0221404824

Remove 16-bit storage from float16 vector tests

Replace loads and stores of float16s with specialized function to
reinterpret as appropriate uints for vector extract dynamic, vector
insert dynamic and vector shuffle tests.

Component: Vulkan

VK-GL-CTS Issue: 1931

Affects:
dEQP-VK.spirv_assembly.instruction.*.float16.opvectorextractdynamic*
dEQP-VK.spirv_assembly.instruction.*.float16.opvectorinsertdynamic*
dEQP-VK.spirv_assembly.instruction.*.float16.opvectorshuffle*

Change-Id: I1757d2dc3dd8a45098b79ce519d26b351f298a00

dEQP-VK.graphicsfuzz.loop-dead-if-loop

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.loop-dead-if-loop

Change-Id: Ib621527105a57eabea346f7184d210ec8d66c5c1