Matthew Netsch [Fri, 8 Jul 2022 14:35:34 +0000 (07:35 -0700)]
Merge vk-gl-cts/vulkan-cts-1.3.3 to vk-gl-cts/main
Change-Id: I1efc306c54a53f9499fbcc2a0ad66f77220e391d
Sławomir Cygan [Fri, 17 Jun 2022 13:52:26 +0000 (15:52 +0200)]
Add missing 'FREE_DESCRIPTOR_SET' flag to a descriptor set pool
The test seems to test vkFreeDescriptors, however the pool is missing
a flag that is required for that function to be used.
Spec says: VUID-vkFreeDescriptorSets-descriptorPool-00312
descriptorPool must have been created with the VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT flag
Components: Vulkan
VK-GL-CTS Issue: 3779
Affects: dEQP-VK.api.descriptor_pool.zero_pool_size_count
Change-Id: I04c1e67fcbdffa4b0eb1bf7ffbb0231fbe0bc45d
Mika Väinölä [Tue, 8 Mar 2022 07:57:11 +0000 (09:57 +0200)]
Fix GCC 11 misleading indentation warning
Make it clearer that the assignment is not guarded by the if.
Components: Vulkan
VK-GL-CTS issue: 3555
Change-Id: If03e31c20877d99d8e10620bbda31942023ca13a
John Anthony [Fri, 24 Jun 2022 17:03:08 +0000 (19:03 +0200)]
Fix aliasing issues for physical device features
Make sure we only pass in one instance of the following feature
structs (including aliases) when getting supported features from a
physical device:
- VkPhysicalDeviceDescriptorIndexingFeatures
- VkPhysicalDeviceBufferDeviceAddressFeatures
Affects:
dEQP-VK.info.device_mandatory_features
Components: Vulkan
VK-GL-CTS issue: 3792
Change-Id: I290a46f0c5d220f616237063253bfb7be6d1f026
Piers Daniell [Thu, 23 Jun 2022 22:23:01 +0000 (16:23 -0600)]
Always include the required closest hit shader when tracing rays
The tests added in https://gerrit.khronos.org/c/vk-gl-cts/+/7865
neglected to set the SBT entry for a closest hit shader even
though the ray generation shader was calling traceRayEXT().
This can cause the implementation to dereference NULL data
and crash when it attempts to execute a hit shader.
This CL modifies the ray tracing pipeline and SBR to always have a
closest hit shader defined.
Affects:
dEQP-VK.ray_tracing_pipeline.pipeline_no_null_shaders_flag.*
Components: Vulkan
VK-GL-CTS issue: 3790
Change-Id: Ied3265639b6b5ab45998ac02d361106e14fa3808
Piotr Byszewski [Mon, 13 Jun 2022 10:55:21 +0000 (12:55 +0200)]
Fix regresion in FSR tests
FSR tests were recently repeated few times - for pipeline libraries
and for secondary command buffers in dynamic rendering cases. As a
result there were cases where delayed group creation with
createChildren had another nested call to createChildren. This CL
modifies code to use only tow delayed group creation calls - for
renderpass2 and dynamic_rendering sub-groups.
Components: Vulkan
VK-GL-CTS issue: 3760
Affects:
dEQP-VK.fragment_shading_rate.*
Change-Id: If8da1532c0c924ef812ab055de4c71c5b9ba86b4
Matthew Netsch [Thu, 7 Jul 2022 20:21:58 +0000 (20:21 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Change-Id: Ic26b0069d50734146363779c7d7f0362f5d33496
Sławomir Cygan [Fri, 17 Jun 2022 13:41:40 +0000 (15:41 +0200)]
Allow sample counting after multisample coverage
Vulkan specification was modified to allow counting samples
after mutlisample coverage and fragment shading.
The test uses a fragment shader that kills all pixels with
"gl_SampleMask[0] = 0x0" and than verifies the occlusion query results.
This change allows for 0 samples to be counted by a query in case
of `early_fragment_tests` mode being used. The QualityWarning is emitted
in this case.
Components: Vulkan
Vulkan Issue: 3085
VK-GL-CTS Issue: 3778
Affects: dEQP-VK.fragment_operations.early_fragment.sample_*
Change-Id: I86cf17b2d8849a9d543e8447569ac808928c30e6
Juha Heiskanen [Mon, 6 Jun 2022 11:56:43 +0000 (14:56 +0300)]
Early fragment depth test rounding issue bug fix
Small correction to vertex coordinates to avoid unexpected depth value
roundings.
Components: Vulkan
VK-GL-CTS Issue: 3732
Affects:
dEQP-VK.fragment_operations.early_fragment.early_fragment_tests_depth
dEQP-VK.fragment_operations.early_fragment.no_early_fragment_tests_depth
Change-Id: Ifa8f92a2c2e18acb4122a10498c9c21e7990e9f6
Matthew Netsch [Thu, 7 Jul 2022 19:49:10 +0000 (19:49 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: I300e223f9f8743cc0579547d535f8af333caeada
Ricardo Garcia [Thu, 16 Jun 2022 18:23:42 +0000 (20:23 +0200)]
Fix synchronization in compressed texture sampling tests
Tests sampling compressed textures contained multiple synchronization
errors, most of them related to:
* Render pass load operations not properly synchronized with previous
writes.
* Barriers that did not properly synchronize all layers of a cube map.
* Improper initial layout transitions.
Affected tests:
dEQP-VK.image.sample_texture.*
dEQP-VKSC.image.sample_texture.*
VK-GL-CTS issue: 3763
Components: Vulkan
Change-Id: I2f2572a7f6a05c55c904014fafc3a655dbb03ee3
Matthew Netsch [Thu, 7 Jul 2022 19:24:45 +0000 (19:24 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: I0f96a1f42fc6069ae185225b3794e37eea200a74
Matthew Netsch [Thu, 7 Jul 2022 18:56:48 +0000 (18:56 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: Ia16eafb924ac851fcda00d605e608af190b56997
Matthew Netsch [Thu, 7 Jul 2022 18:29:26 +0000 (18:29 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I1c3fa921a070b79cbcd31c213cfbb651c4d07530
Matthew Netsch [Thu, 7 Jul 2022 18:01:59 +0000 (18:01 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Change-Id: Id3635ffcac963dbd16ed489269205e90f92aa6a0
Max Andersson [Thu, 9 Jun 2022 12:40:46 +0000 (14:40 +0200)]
Change direction of IgnoreIntersection/TerminateRay tests
Changes the ray direction of the IgnoreIntersection and
TerminateRay tests such that it shoots the ray into the
center of the triangle, rather than exactly at one of
its edges.
Impacts tests:
dEQP-VK.ray_tracing_pipeline.misc.Op*
Components: Vulkan
VK-GL-CTS issue: 3771
Change-Id: Ic36cc125238323eb367412f220afe8907f700c8d
Matthew Netsch [Thu, 7 Jul 2022 17:36:30 +0000 (17:36 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6
Change-Id: I7ab0e9094c250af82f5aa28183fe5759e96f3e5f
Joe Withers [Fri, 1 Jul 2022 15:28:05 +0000 (16:28 +0100)]
Fix image feature checking in YCbCr filtering tests
The tests were using linear chroma filtering without checking for
support.
Components: Vulkan
Affects:
dEQP-VK.ycbcr.filtering.*
Change-Id: I2619667b8ebf78f3c2c1880501925a1348305b64
Matthew Netsch [Fri, 17 Jun 2022 05:55:01 +0000 (05:55 +0000)]
Merge "Merge vk-gl-cts/github-main into vk-gl-cts/main" into main
Matthew Netsch [Fri, 17 Jun 2022 05:36:53 +0000 (05:36 +0000)]
Merge "Merge vk-gl-cts/opengl-es-cts-3.2.8 into vk-gl-cts/main" into main
Matthew Netsch [Thu, 16 Jun 2022 21:17:55 +0000 (14:17 -0700)]
Merge vk-gl-cts/github-main into vk-gl-cts/main
Change-Id: I0c14ad0e023537bfdd81e6a108cd3f89f5482f42
Matthew Netsch [Fri, 17 Jun 2022 04:24:26 +0000 (21:24 -0700)]
Merge vk-gl-cts/opengl-es-cts-3.2.8 into vk-gl-cts/main
Change-Id: I9f1a96c9da4a259684498d383f33c98b5000fde4
Matthew Netsch [Fri, 17 Jun 2022 02:19:19 +0000 (02:19 +0000)]
Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/opengl-es-cts-3.2.8
Change-Id: Ie06650ccb16867acefd03d8c053b2e4996f7bc53
Matthew Netsch [Thu, 16 Jun 2022 20:48:34 +0000 (20:48 +0000)]
Merge vk-gl-cts/opengl-cts-4.6.2 into vk-gl-cts/main
Change-Id: Ie091edca0cd513ffb13143d2eb6dd7fd037edef4
Matthew Netsch [Thu, 16 Jun 2022 20:47:06 +0000 (13:47 -0700)]
Merge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/opengl-es-cts-3.2.7
Change-Id: I5eee40dacbbc0fd7b95c06a9e6f434f45ca8ecf9
Ari Suonpaa [Mon, 23 May 2022 04:53:17 +0000 (07:53 +0300)]
Fix signed integer overflow in framebuffer fetch tests
VK-GL-CTS Issue: 3473
Affects:
dEQP-GLES31.functional.shaders.framebuffer_fetch.framebuffer_format.*
Components: OpenGL ES
Change-Id: I5c971db231c9ea95b413df417e5cb2421aa857e1
Ari Suonpaa [Wed, 4 May 2022 06:10:27 +0000 (09:10 +0300)]
Add tests for mul extended using different bit sizes
Previously only 32bit variants of Op[S/U]MulExtended were tested.
This change tests all 8bit, 16bit, 32bit, and 64bit options.
VK-GL-CTS Issue: 3632
New tests:
dEQP-VK.spirv_assembly.instruction.compute.mul_extended.*
Components: Vulkan
Change-Id: I498062688cd738e9a019a6fa4df1c12ade1863ec
Ricardo Garcia [Fri, 10 Jun 2022 13:30:13 +0000 (15:30 +0200)]
Test shader group handle alignment
This commit adds a new test group that verifies the advertised supported
shader group handle alignment in shader binding tables works as
expected.
The new tests create shader binding tables with shader record buffers
that act as padding bytes to achieve the desired alignments. These
shader record buffers are also read from ray tracing shaders and
verified to have the right contents.
New tests:
dEQP-VK.ray_tracing_pipeline.shader_binding_table.handle_alignment.*
Components: Vulkan
VK-GL-CTS issue: 3298
Change-Id: Id2d4f11ed2fcf56ce30e1a5896d38416cbaf1b82
Mika Väinölä [Wed, 30 Mar 2022 08:01:31 +0000 (11:01 +0300)]
Test XFB queries without shader writes
Transform feedback outputs should be captured even if they are never
written to. Add variants of existing query tests that omit shader
writes and check that the XFB query counters are still incremented.
New tests:
dEQP-VK.transform_feedback.simple.*_omit_write_*
Affects:
dEQP-VK.transform_feedback.simple.*
Components: Vulkan
VK-GL-CTS issue: 3624
Change-Id: I001f331eea8ff8e93075f60a890ebd5cb95f456b
Ricardo Garcia [Wed, 8 Jun 2022 07:36:16 +0000 (09:36 +0200)]
Remove duplicate checkPipelineLibraryRequirements call
Affected tests:
dEQP-VK*.fragment_shading_rate.*.basic.*
Change-Id: If29cf6fb2e0feb95f9c2385f7ca0bb00c72db547
Components: Vulkan
Jari Komppa [Tue, 14 Jun 2022 08:32:48 +0000 (11:32 +0300)]
Disable IPC primitives on android
This change disables the IPC primitives on Android.
Affects: none
VK-GL-CTS issue: 3766
Components: Framework
Change-Id: I96aa21b4ac364f35f2599ada0ba30212bd2df91a
Ricardo Garcia [Thu, 9 Jun 2022 14:03:40 +0000 (16:03 +0200)]
Mix dynamic line stipple and dynamic primitive topology
On some implementations, dynamic topology can interact with dynamic line
stipple, affecting the state of it. This commits adds a new set of tests
that set the dynamic line stipple values, then switch dynamic topologies
and draw using them before finally switching to the right topology again
and drawing, so as to check the dynamic topology changes have not
affected line stipple values.
New tests:
dEQP-VK.rasterization.primitives.dynamic_stipple_and_topology.*
Affected tests:
dEQP-VK.rasterization.*
Components: Vulkan
VK-GL-CTS issue: 3667
Change-Id: Ia1930186ef3a534280cf040e1cd706a460fd9765
Marcin Zając [Thu, 3 Mar 2022 14:30:34 +0000 (15:30 +0100)]
isExtensionSupported renaming
The purpose of renaming function name to isExtensionStructSupport
is to make it a clearer emphasis on the fact that extension structure
of passed extension name was promoted in the core and is not guaranteed
to be supported by the device because of the optional nature of some extensions.
In most cases, the function has been replaced with more appropriate
isDeviceFunctionalitySupported.
Components: Vulkan
VK-GL-CTS Issue: 3149
Affect tests: *dEQP-VK.*
Change-Id: Ic0922bee2f1c178e5aaee9065a1d91260477410a
Piotr Byszewski [Wed, 1 Jun 2022 14:02:11 +0000 (16:02 +0200)]
Additional tests for UPDATE_AFTER_BIND
UPDATE_AFTER_BIND was tested with descriptor write updates
but not with copies. This change extends descriptor_copy
tests to check also UPDATE_AFTER_BIND.
This change also moves all case requirement checks to
checkSuppport function.
Components: Vulkan
VK-GL-CTS issue: 3638
Affects:
dEQP-VK.binding_model.descriptor_copy.*
New tests:
dEQP-VK.binding_model.descriptor_copy.graphics_uab.*
Change-Id: Ibc45f4f8c7550edc7a974dd33a4dd245c51105a9
Thomas Weber [Wed, 8 Jun 2022 11:10:07 +0000 (13:10 +0200)]
Add testing for VK_EXT_subpass_merge_feedback
This commit adds test cases for the VK_EXT_subpass_merge_feedback
extension.
Components: Vulkan
New Tests:
dEQP-VK.renderpass2.suballocation.subpass_merge_feedback.single_subpass
dEQP-VK.renderpass2.suballocation.subpass_merge_feedback.single_subpass_disallow_renderpass_merge
dEQP-VK.renderpass2.suballocation.subpass_merge_feedback.three_subpasses
dEQP-VK.renderpass2.suballocation.subpass_merge_feedback.three_subpasses_disallow_renderpass_merge
dEQP-VK.renderpass2.suballocation.subpass_merge_feedback.three_subpasses_disallow_subpass_merge
dEQP-VK.renderpass2.suballocation.subpass_merge_feedback.many_subpasses
Change-Id: I8d969f4069a828756aae74339aba88cb70074b3f
Matthew Netsch [Thu, 16 Jun 2022 19:54:06 +0000 (19:54 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main
Change-Id: I867ce0fbe8b02eca111330e6d7d9625aee25e41c
Piers Daniell [Mon, 13 Jun 2022 17:53:30 +0000 (11:53 -0600)]
Set pipeline layout for fragment_shading_rate tests
The Vulkan spec requires there be a valid pipeline layout, even
when pipeline libraries are being used.
Components: Vulkan
Affects:
dEQP-VK.fragment_shading_rate.*.pipeline_library.*
VK-GL-CTS issue: 3764
Change-Id: I83486240c2e5e15f13a5d9610ee66d2e37ef06b9
Matthew Netsch [Thu, 16 Jun 2022 18:39:31 +0000 (18:39 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Change-Id: I8bda2888165efe5813666980c95ab76b2481d7f1
Matthew Netsch [Thu, 16 Jun 2022 18:07:42 +0000 (18:07 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: Ie9da086ce3cfaa7b9aa768fdf700905f0512f446
Ricardo Garcia [Thu, 9 Jun 2022 08:55:46 +0000 (10:55 +0200)]
Synchronize clears and reads in transient attachment tests
These tests use a render pass with no draw operations to clear a color
or depth/stencil attachment and use it as an input attachment in a
second render pass, but they were missing a barrier to synchronize both
operations.
Affected tests:
dEQP-VK.fragment_operations.transient_attachment_bit*
Components: Vulkan
VK-GL-CTS issue: 3717
Change-Id: Ifcd1817fa631973e4f74866546dfad4e021a16bc
Matthew Netsch [Thu, 16 Jun 2022 17:57:30 +0000 (13:57 -0400)]
Merge pull request #326 from DadSchoorse/VK_EXT_non_seamless_cube_map
Vk ext non seamless cube map
Matthew Netsch [Thu, 16 Jun 2022 17:43:14 +0000 (17:43 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: I5830bb9dc3d462de2df81a0af118a40953315102
Mike Blumenkrantz [Tue, 26 Apr 2022 18:30:12 +0000 (14:30 -0400)]
fix dEQP-VK.subgroups.size_control.compute.required_subgroup_size_*_require_full_subgroups_spirv16
the spirv16 cases weren't fixed in an earlier change which addressed the same problem
Affects:
dEQP-VK.subgroups.size_control.compute.required_subgroup_size_max_require_full_subgroups_spirv16
dEQP-VK.subgroups.size_control.compute.required_subgroup_size_min_require_full_subgroups_spirv16
Change-Id: Ic70024e080cff8c824ffa126774f27f2d378c52d
Matthew Netsch [Thu, 16 Jun 2022 17:15:31 +0000 (17:15 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I4ce72e2de0508fd24ef31b5cf2ae190ad73ad2bc
Georg Lehmann [Sat, 4 Sep 2021 16:17:04 +0000 (18:17 +0200)]
Tests for VK_EXT_non_seamless_cube_map
Georg Lehmann [Fri, 3 Sep 2021 15:25:00 +0000 (17:25 +0200)]
Consistently use tcu::Samplers with seamlessCubeMap to match core Vulkan
Georg Lehmann [Tue, 17 May 2022 20:06:10 +0000 (22:06 +0200)]
Update Vulkan framework for VK_EXT_non_seamless_cube_map
Matthew Netsch [Thu, 16 Jun 2022 16:48:03 +0000 (16:48 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: Ieac8dac110e196cd1d83bff11be45fdec6a72f2b
Thomas Aven [Mon, 30 May 2022 09:38:02 +0000 (11:38 +0200)]
Add missing barrier in ray tracing tests
When running the CPU build acceleration structure tests, no acceleration
structure commands are recorded, resulting in a missing execution
barrier. Add the missing barrier between vkCmdClearColorImage and
vkCmdTraceRaysKHR. This barrier is the same barrier used in the
equivalent ray query tests.
Affects:
dEQP-VK.ray_tracing_pipeline.acceleration_structures.*
Components: Vulkan
VK-GL-CTS issue: 3750
Change-Id: Ib9fc047e6e3a45165e5028846f8f10e96aca53c1
Matthew Netsch [Thu, 16 Jun 2022 16:20:42 +0000 (16:20 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Change-Id: If7368ce72c121d0642e902c08c0f79d6c99ad73c
Matthew Netsch [Thu, 16 Jun 2022 15:55:55 +0000 (15:55 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6
Change-Id: I238c6805dbba58a1dddb7639663cd9c9b83b7f64
Mike Blumenkrantz [Sat, 11 Jun 2022 14:17:28 +0000 (10:17 -0400)]
stop crashing in gl tess isolines tests if xfb is broken
if no data is returned, don't try to count the data since it will
trigger a null deref and crash
Affects:
KHR-GL46.tessellation_shader.single.isolines_tessellation
Change-Id: I4f218c033c2a7291796eb25f4e0ae159b9e054b9
Matthew Netsch [Fri, 10 Jun 2022 14:51:04 +0000 (14:51 +0000)]
Merge "Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3" into vulkan-cts-1.3.3
Peter Kohaut [Thu, 9 Jun 2022 09:03:07 +0000 (11:03 +0200)]
Fix Android build
Fixes copy & paste error.
Disables Sys V shared memory for Android as it is unsupported.
Components: Vulkan
Affects:
*
VK-GL-CTS issue: 3756
Change-Id: I45a24916e57a8c77a1fb0e88e89927ca34069b52
(cherry picked from commit
c51f848880bf03bd8c303a34aee7d92185185a61)
Matthew Netsch [Thu, 9 Jun 2022 19:30:09 +0000 (12:30 -0700)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/main
Change-Id: Ib8d390597800227dfd8133588700a1a58d3d8c37
Matthew Netsch [Thu, 9 Jun 2022 19:25:38 +0000 (12:25 -0700)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Change-Id: Icf1eec1fba1f1272f424878113e510fa6fb8a92a
Ricardo Garcia [Wed, 1 Jun 2022 15:31:23 +0000 (17:31 +0200)]
Forbid implicit cast from Move<T> to bool
Take the following code:
Move<VkPipelineLayout> smartLayout = ...;
VkPipelineLayout rawLayout = smartLayout;
That builds and applies the following implicit conversions:
Move<T> -> bool -> VkPipelineLayout
Which doesn't make any sense (the raw handle ends up having value "1")
and it's arguably an easy typo to make, when the second line should
actually have been one of:
VkPipelineLayout rawLayout = *smartLayout;
VkPipelineLayout rawLayout = smartLayout.get();
This commit disallows the implicit conversions from Move<T> to bool and
makes the typo fail compilatoin on purpose.
It also fixes one instance of such typo in the affected test, which was
causing issues when implementing graphics pipeline libraries in RADV.
Note the test also touches vktRenderPassTests.cpp, but the change should
not affect any test result there.
Affected tests:
dEQP-VK.pipeline.pipeline_library.graphics_library.misc.timing.compare_link_times
VK-GL-CTS issue: 3735
Components: Vulkan
Change-Id: Id968a1e74f6246e592257f7b3675c80e3363feaf
Ricardo Garcia [Wed, 25 May 2022 10:36:00 +0000 (12:36 +0200)]
Fix extension checks in DRM format modifier tests
Some of the checks for supported extensions made the tests error out
instead of marking them as not supported.
Affected tests:
dEQP-VK.drm_format_modifiers.*
Components: Vulkan
VK-GL-CTS issue: 3720
Change-Id: I47c1f051128e425d5faae3bed5c2830218df4881
Ricardo Garcia [Wed, 1 Jun 2022 14:19:25 +0000 (16:19 +0200)]
Fix device and memory allocation mix-up
compute_transfer dynamic state tests were allocating memory on one
device and binding it to a buffer created on a separate device. This
commit fixes the issue and make sure the right devices and allocators
are always used.
Affected tests:
dEQP-VK.dynamic_state.monolithic.compute_transfer.*
VK-GL-CTS issue: 3727
Components: Vulkan
Change-Id: I8f8aeffd0d4946465af1a600d5f7331e4040638a
Peter Kohaut [Thu, 9 Jun 2022 09:03:07 +0000 (11:03 +0200)]
Fix Android build
Fixes copy & paste error.
Disables Sys V shared memory for Android as it is unsupported.
Components: Vulkan
Affects:
*
VK-GL-CTS issue: 3756
Change-Id: I45a24916e57a8c77a1fb0e88e89927ca34069b52
Graeme Leese [Fri, 20 May 2022 14:34:28 +0000 (15:34 +0100)]
Shrink the framebuffer in more graphicsfuzz tests
These are all resolution independent but use large framebuffers and are
executing slowly on some of our low-end platforms.
Components: Vulkan
Affects: dEQP-VK.graphicsfuzz.arr-value-set-to-arr-value-squared
dEQP-VK.graphicsfuzz.cov-array-copies-loops-with-limiters
dEQP-VK.graphicsfuzz.cov-blockfrequency-several-for-loops
dEQP-VK.graphicsfuzz.cov-do-while-negative-iterator-nested-loops-increment-array-element
dEQP-VK.graphicsfuzz.cov-dummy-function-loop-array-element-increment-never-read
dEQP-VK.graphicsfuzz.cov-for-array-initializing-modulo
dEQP-VK.graphicsfuzz.cov-function-loop-condition-variable-less-than-min-itself
dEQP-VK.graphicsfuzz.cov-function-loop-copy-array-elements-based-on-arguments
dEQP-VK.graphicsfuzz.cov-function-two-loops-limit-using-arguments-array-element-copies
dEQP-VK.graphicsfuzz.cov-increment-int-loop-counter-mod-array
dEQP-VK.graphicsfuzz.cov-initialize-integer-array-variable-divided-by-itself
dEQP-VK.graphicsfuzz.cov-instruction-simplify-inst-combine-calls-for-compare-function-call-result
dEQP-VK.graphicsfuzz.cov-integer-minus-one-increased-before-indexing-array
dEQP-VK.graphicsfuzz.cov-loop-clamp-to-one-empty-condition
dEQP-VK.graphicsfuzz.cov-loop-condition-bitfield-extract-set-array-elements
dEQP-VK.graphicsfuzz.cov-loop-condition-divide-by-uniform-always-false
dEQP-VK.graphicsfuzz.cov-loop-struct-array-field-set-value-self-dependency
dEQP-VK.graphicsfuzz.cov-nested-functions-struct-arrays-vector-lengths
dEQP-VK.graphicsfuzz.cov-nested-loop-not-greater-than-increment-array-element
dEQP-VK.graphicsfuzz.cov-nested-loop-undefined-smoothstep-never-executed
dEQP-VK.graphicsfuzz.cov-nested-loops-float-bits-to-int-increment-array
dEQP-VK.graphicsfuzz.cov-nested-loops-global-loop-counter-do-while-accumulate-float
dEQP-VK.graphicsfuzz.cov-nir-array-access
dEQP-VK.graphicsfuzz.cov-optimize-phis-for-for-do-while-if-if
dEQP-VK.graphicsfuzz.cov-optimize-phis-for
dEQP-VK.graphicsfuzz.cov-register-coalescer-live-intervals-target-instr-info-for-discard-for-discard
dEQP-VK.graphicsfuzz.cov-scaled-number-nested-loops
dEQP-VK.graphicsfuzz.cov-set-output-color-function-call-nested-loop
dEQP-VK.graphicsfuzz.cov-two-loops-global-loop-counter-shift-right-zero-increment-array-element
dEQP-VK.graphicsfuzz.cov-unused-matrix-copy-inside-loop
dEQP-VK.graphicsfuzz.cov-value-tracking-selection-dag-negation-clamp-loop
dEQP-VK.graphicsfuzz.flag-always-false-if
dEQP-VK.graphicsfuzz.nested-for-break-mat-color
Change-Id: I108ea54ee35f07911f062d89840d2577f2385528
Graeme Leese [Fri, 20 May 2022 14:38:35 +0000 (15:38 +0100)]
Remove superfluous 'resolution' from graphicsfuzz test
This wasn't referenced and doesn't seem related to the point of the
test, so remove it.
Components: Vulkan
Affects: dEQP-VK.graphicsfuzz.arr-value-set-to-arr-value-squared
Change-Id: I0057ccca5adb841d0c31d9ba06fe38ba70e78ed5
Younggwan Kim [Thu, 24 Feb 2022 13:47:25 +0000 (13:47 +0000)]
Add KHR-GLESEXT.fragment_shading_rate tests
add basic test and complex test for verify GL_EXT_fragment_shading_rate
extension.
- GLESEXT.fragment_shading_rate.api.basic
- GLESEXT.fragment_shading_rate.api.errors
- GLESEXT.fragment_shading_rate.complex.*
- GLESEXT.fragment_shading_rate.render_target.*
Change-Id: I6673c0643c038bf4b1e4b717b2916daf4b79a84c
Piotr Byszewski [Fri, 11 Mar 2022 09:29:00 +0000 (10:29 +0100)]
Run DR draw tests with secondary command buffers
Dynamic rendering tests in draw group were replaced with three
sub groups: primary_cmd_buff, partial_secondary_cmd_buff and
complete_secondary_cmd_buff.
* primary_cmd_buff subgroup contains previously existing dynamic
rendering tests where drawing is done in primary command buffer.
* partial_secondary_cmd_buff contains tests where drawing commands
are recorded in secondary command buffer but begin/endRendering
are recorded to primary command buffer.
* complete_secondary_cmd_buff executes tests with secondaries that
completely contain the dynamic render pass.
This change also removes 4 tests that were added 2 years ago:
* static_scissor_framebuffer_border_out
* dynamic_scissor_framebuffer_border_out
* static_scissor_oversized
* dynamic_scissor_oversized
Above tests render outside of the renderArea and are invalid.
Components: Vulkan
VK-GL-CTS issue: 3516
Affects:
dEQP-VK.draw.*
New tests:
dEQP-VK.draw.dynamic_rendering.partial_secondary_cmd_buff.*
dEQP-VK.draw.dynamic_rendering.complete_secondary_cmd_buff.*
Change-Id: If6a0d82b98948f155e9350f841931c329e474b07
Jari Komppa [Mon, 30 May 2022 09:28:04 +0000 (12:28 +0300)]
Add recipe for amber-verify run mode
Changes build check scripts to include a recipe for checking that amber
device requirements match with what CTS asks for.
Changes amber-verify code to also print out the errors in stderr to make
finding the errors easier by looking at the console log.
Affects: none
Components: Framework
VK-GL-CTS issue: 3368
Change-Id: Id064420425563111ac3e2038dd27d7becdccdcb6
Ari Suonpaa [Thu, 2 Jun 2022 05:10:45 +0000 (08:10 +0300)]
Add new test cases for VK_EXT_load_store_op_none
These new cases make sure one of the aspects in depth stencil
buffer stays unmodified when load and store ops are none and
only the other aspect is written.
VK-GL-CTS Issue: 3722
New tests:
dEQP-VK.*.load_store_op_none.depthstencil*
Components: Vulkan
Change-Id: I04611087bc39290e2cb5b461326c11b5eb8d2622
Peter Kohaut [Thu, 9 Jun 2022 11:15:25 +0000 (13:15 +0200)]
Update Vulkan headers
Components: Vulkan
Change-Id: I96104b2ed4bf5c9fadf2119c7ef70f9492f78eba
Matthew Netsch [Thu, 9 Jun 2022 18:25:33 +0000 (18:25 +0000)]
Merge vk-gl-cts/opengl-cts-4.6.2 into vk-gl-cts/main
Change-Id: Ia8e90590750d6428ab9f55ec9447f184be48d439
Mike Blumenkrantz [Wed, 11 May 2022 21:39:32 +0000 (17:39 -0400)]
further improve sparse texture shader typing
this handles the multisample-array mismatch
Affects:
KHR-GL46.sparse_texture2_tests.UncommittedRegionsAccess
Change-Id: I45a8fd3ab576fb833100d2fbea36936e279a1bb5
Mike Blumenkrantz [Wed, 11 May 2022 12:49:21 +0000 (08:49 -0400)]
fix GL sparse texture gather offset constness
the offsets array must be a constant value, which, as defined by the spec,
must be constant before optimizations, so declaring them in this way
was illegal
Affects:
KHR-GL46.sparse_texture2_tests.SparseTexture2Lookup
Change-Id: I8d03931e59ac15674ae55902f693338b2ce99cb2
Matthew Netsch [Thu, 9 Jun 2022 17:42:02 +0000 (17:42 +0000)]
Merge vk-gl-cts/opengl-es-cts-3.2.8 into vk-gl-cts/main
Change-Id: I643f0e3cbc9aa9d9012a6eba830d779b45cd643d
Matthew Netsch [Thu, 9 Jun 2022 17:14:49 +0000 (17:14 +0000)]
Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/opengl-es-cts-3.2.8
Change-Id: Iea933cfe50d4538966618000204b04bc2f60ba1e
Matthew Netsch [Thu, 9 Jun 2022 16:42:55 +0000 (16:42 +0000)]
Merge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/opengl-es-cts-3.2.7
Change-Id: I5a907b609b2763a74587533edac269be72027909
Ari Suonpaa [Wed, 25 May 2022 12:11:11 +0000 (15:11 +0300)]
Fix signed integer overflow in random indirect draw tests
VK-GL-CTS Issue: 3331
Affects:
dEQP-GLES31.functional.draw_indirect.random.*
Components: OpenGL ES
Change-Id: I75a57a0ee14f00d049e0c27628017c86b7078174
Ari Suonpaa [Wed, 18 May 2022 11:33:13 +0000 (14:33 +0300)]
Fix signed integer overflow in random shader tests
VK-GL-CTS Issue: 3334
Affects:
dEQP-GLES3.functional.shaders.random.*
Components: OpenGL ES, Framework
Change-Id: I8a0ea222ba62c08180244d34adc0f4f0b5e4db9e
Thomas Spurden [Mon, 11 Apr 2022 13:00:17 +0000 (14:00 +0100)]
Allow not supporting separate depth/stencil with combined formats
Components: OpenGL
Affects: dEQP-GLES3.functional.fbo.*
Change-Id: I2eb2433921b3d8f7da30d5d546c07da46bebb343
Matthew Netsch [Thu, 9 Jun 2022 03:55:12 +0000 (20:55 -0700)]
Update known conformance version for 1.3.3.0
Components: Vulkan, Framework
Affects:
dEQP-VK.api.driver_properties.conformance_version
Change-Id: Id2a541585bb9bff2c6b929d7b045c2c08fc58db6
Piotr Byszewski [Wed, 11 May 2022 14:44:02 +0000 (16:44 +0200)]
Split pipeline.txt mustpass into multiple files
Scripts that generate mustpass files were changed to allow
specification of test groups that should be spitted to separate
.txt files. With this change python dictionaries are heavily
used (not just lists) and because of that order of groups in
all .txt files has changed. (Dictionaries are sorted)
This change uses new functionality for pipeline group that now
will be splited to 3 files (each representing subgroup).
Components: Framework
VK-GL-CTS issue: 3641
Affects:
*
Change-Id: I8e339fa71cb2348a5074f53697f9d283c9ba9c35
Trevor David Black [Mon, 16 May 2022 03:43:09 +0000 (03:43 +0000)]
Add R8_UNORM to the external AHB memory tests
New Tests:
dEQP-VK.api.external.memory.android_hardware_buffer.image_formats.r8_unorm
Components: Vulkan
Change-Id: I40a76b4b6112ae6d0b053cf3427e313a6894a873
michal_jakubek [Wed, 20 Apr 2022 08:42:30 +0000 (10:42 +0200)]
More EXT_color_write_enable tests.
New tests:
dEQP-VK.pipeline.*.color_write_enable_maxa.*
Components: Vulkan
VK-GL-CTS issue: 3569
Change-Id: I9db26fe0cbee3134b174efcebf8a795b7b676a28
Matthew Netsch [Thu, 2 Jun 2022 14:08:13 +0000 (07:08 -0700)]
Merge vk-gl-cts/dev/VK_EXT_image_compression_control into vk-gl-cts/main
Change-Id: I893a082eb8816ed9ef7f20f0246781e19d999029
Matthew Netsch [Tue, 31 May 2022 21:21:26 +0000 (14:21 -0700)]
Merge vk-gl-cts/main into vk-gl-cts/dev/VK_EXT_image_compression_control
Change-Id: I67f8b39b34d0de496292c3f0db2d182d63a31140
Matthew Netsch [Thu, 2 Jun 2022 14:13:18 +0000 (07:13 -0700)]
Merge vk-gl-cts/dev/VK_KHR_fragment_shader_barycentric into vk-gl-cts/main
Change-Id: Iee05a3a148b62122de199cad70cda8f9f3f2170c
Matthew Netsch [Wed, 1 Jun 2022 19:55:08 +0000 (12:55 -0700)]
Merge vk-gl-cts/main into vk-gl-cts/dev/VK_KHR_fragment_shader_barycentric
Change-Id: Ib4407c269be86851031a8a6ce1abc93d4e553996
Matthew Netsch [Thu, 2 Jun 2022 14:07:03 +0000 (07:07 -0700)]
Merge vk-gl-cts/dev/VK_KHR_ray_tracing_maintenance1 into vk-gl-cts/main
Change-Id: I1b78dec2819e963937d831f1b8c3e11e2428184a
Matthew Netsch [Wed, 1 Jun 2022 17:59:31 +0000 (10:59 -0700)]
Merge vk-gl-cts/main into vk-gl-cts/VK_KHR_ray_tracing_maintenance1
Change-Id: I2502165363120c2aa71e0356f607fe895bdc8eb2
Matthew Netsch [Mon, 6 Jun 2022 19:58:19 +0000 (12:58 -0700)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/main
Change-Id: I0038924e2f520376d3dbe078d5ad0a2e60585f2b
Matthew Netsch [Mon, 6 Jun 2022 15:54:27 +0000 (08:54 -0700)]
Fix modifier tests - Add Invalidate memory before host read.
Test cases for extension VK_EXT_image_drm_format_modifier were failing randomly due to image mismatch.
This was due to after performing copyImagetoBuffer buffers are not invalidated before reading from host.
Added the invalidate operation for buffer before reading.
Components: Vulkan
VK-GL-CTS Issue: 3744
Affects:
dEQP-VK.drm_format_modifiers.*
Change-Id: I57b27bf9c0beea0ed822b36ea379b024f9d1690a
Jesse Archer [Fri, 20 May 2022 21:15:10 +0000 (14:15 -0700)]
Declare atomic_payload array coherent
Data in the release_acquire_atomic_payload uses atomic functions
on an array, so this array needs to be declared coherent.
Affected tests:
dEQP-VK.memory_model.message_passing.permuted_index.release_acquire_atomic_payload
Components: Vulkan
VK-GL-CTS issue: 3706
Change-Id: I6f285e3000368d083369bda5b3782a3b44c9b64d
Tomasz Owczarek [Tue, 10 May 2022 14:46:28 +0000 (15:46 +0100)]
Fix spec info in pipeline max varyings tests
Add missing VkSpecializationInfo to fragment shader stage.
Components: Vulkan
VK-GL-CTS issue: 3677
Affects:
dEQP-VK.pipeline.*.max_varyings*
Change-Id: Icf702ca953ad996e9081aa9197fbdcedd21dd191
Ricardo Garcia [Mon, 23 May 2022 14:43:16 +0000 (16:43 +0200)]
Add threshold to rasterization order depth checks
These tests compared floating point depth values expecting exact
matches, which was causing trouble for some implementations. This commit
adds an error threshold to the check.
Affected tests:
dEQP-VK.rasterization.rasterization_order_attachment_access.depth.*
Components: Vulkan
VK-GL-CTS issue: 3711
Change-Id: If6798dfd473f57341775e83d68188e39bdf27caa
Piotr Byszewski [Sat, 21 May 2022 21:49:08 +0000 (23:49 +0200)]
Fix test using LAYOUT_CREATE_INDEPENDENT_SETS_BIT
Original test plan for testing VK_EXT_graphics_pipeline_library had
one test that actually doesn't require pipeline library extension.
This test wrongfully created pipeline layout using
VK_PIPELINE_LAYOUT_CREATE_INDEPENDENT_SETS_BIT_EXT flag
violating VUID-VkPipelineLayoutCreateInfo-flags-parameter.
Components: Vulkan
VK-GL-CTS issue: 3704
Affects:
dEQP-VK.pipeline.pipeline_library.graphics_library.*
Change-Id: I6842fcfd7dd686af32f989cd1b0fcd2730305d9e
Matthew Netsch [Fri, 3 Jun 2022 21:43:02 +0000 (14:43 -0700)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: I4ff955997673df5a3ad35e6de3f5be8f0679dd2f
Piers Daniell [Fri, 3 Jun 2022 18:21:00 +0000 (12:21 -0600)]
Fix regression from CL-9387 to handle empty cache properly
The new program cache code from CL-9387 didn't handle the case where
cacheSearch() is called with an empty cache. It would look at the
first node key regardless, which is uninitialized data, and
attempt to follow the left/right node pointers, which were
also uninitialized. This could result in crash or worse.
This CL simply checks if the cache is empty, and if so doesn't
attempt to read the invalid first node.
Affects:
* (all tests with shaders)
VK-GL-CTS issue: 3565
Components: Vulkan, Framework
Change-Id: Ia813d8caf3170b0c1995bdc43a5f345b578ab615
Piers Daniell [Fri, 3 Jun 2022 20:38:57 +0000 (14:38 -0600)]
Fix deqp-vksc build break from CL-9046
This module was being compiled for deqp-vksc but referenced
tokens not in the Vulkan SC API.
This fix just ifdefs those references out for VULKANSC.
Components: Vulkan
VK-GL-CTS Issue: 3552
Affects:
dEQP-VK.ycbcr.subresource_offset.*
dEQP-VK.image.subresource_layout.*_offset
Change-Id: Ia8d4f16f134bc7d3357bb59f336e12dd92ab73e0
John Anthony [Thu, 12 May 2022 14:39:22 +0000 (16:39 +0200)]
Fix aliasing issue for globalPriorityQuery feature
Affects:
dEQP-VK.info.device_mandatory_features
Components: Vulkan
VK-GL-CTS issue: 3675
Change-Id: Id7e18078bcd9650667834915ed4bbe3453ede91c
Jari Komppa [Fri, 8 Apr 2022 11:51:17 +0000 (14:51 +0300)]
Separate create with unsupported feature tests
This change separates the create device with unsupported features tests
into separate tests so they can be ignored on case by case basis.
The change also changes the hierarchy of device_init.*, moving the
existing tests to new .basic leaves.
Affects:
dEQP-VK.api.device_init.*
New tests:
dEQP-VK.api.device_init.create_device_unsupported_features.*
Subsystem: Vulkan
VK-GL-CTS issue: 3585
Change-Id: I05b79cbc7b74eeaeeea256c7bf5fa0bd53e3d43d
Matthew Netsch [Fri, 3 Jun 2022 20:23:08 +0000 (13:23 -0700)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: If2b3f337e48dea10ccfb3fd457f17badde5c4f43
Matthew Netsch [Fri, 3 Jun 2022 19:47:51 +0000 (19:47 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I2b98a1c69c321ed574eae1878442a1b1cb5012d3
Connor Abbott [Thu, 24 Mar 2022 18:40:19 +0000 (19:40 +0100)]
Fix redundant writes to compressed texture
We already dispatch one workgroup per block, so there's no need to then
loop over all the blocks in the compute shader. Just write one block per
invocation.
Components: Vulkan
Affects:
dEQP-VK.image.sample_texture.128_bit_compressed_format*
dEQP-VK.image.sample_texture.64_bit_compressed_format*
VK-GL-CTS Issue: 3582
Change-Id: If1cf7d4a79e00dcfe735aa9c4d97220242283a12