rmistry [Fri, 13 Jun 2014 18:59:43 +0000 (11:59 -0700)]
Testing trybot triggering
CQ_EXTRA_TRYBOTS=tryserver.skia:Build-Ubuntu13.10-GCC4.8-x86_64-Debug-CrOS_Link-Trybot
BUG=skia:2659
NOTREECHECKS=true
TBR=
(SkipBuildbotRuns)
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
332933005
kkinnunen [Fri, 13 Jun 2014 06:06:28 +0000 (23:06 -0700)]
Extract "text align proc" functions as reusable classes
Extract "text align proc" as reusable classes. These classes need to be used
when writing GrTextContext subclasses.
Moves "text align proc" code that is duplicated in SkDraw and
SkBitmapTextContext to SkDrawProcs.h and SkTextMapState.h. This functionality is
also used in the new GrStencilAndCoverTextContext.
Creates new functor classes SkTextAlignProc and SkTextAlignProcScalar which
represent the previous "text align procs".
Moves TextMapState from SkDraw to SkTextMapStateProc and make it similar functor.
The transform should be comparable in speed, as the compiler can and does avoid
the call and eliminate some of the branches.
R=jvanverth@google.com, reed@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/
335573002
rs.prinja [Fri, 13 Jun 2014 05:55:08 +0000 (22:55 -0700)]
Randomize seed for SkDiscretePathEffect::filterPath()
Fix for https://code.google.com/p/skia/issues/detail?id=2581. Randomizes
the seed in SkDiscretePathEffect::filterPath(). Prior to this we were
using the path length as a seed.
Now, if we have two different paths with identical contents and we
apply an SkDiscretePathEffect to each, we obtain two different random
paths. Previously, we would obtain two overlapping paths (identical
path contents leading to the same seed).
BUG=skia:
R=reed@google.com, scroggo@google.com
Author: rs.prinja@samsung.com
Review URL: https://codereview.chromium.org/
311803002
reed [Fri, 13 Jun 2014 00:40:00 +0000 (17:40 -0700)]
hide Config in SkImageDecoder -- use SkColorType instead
patch from issue
334613003
TBR=scroggo
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
334793002
senorblanco [Thu, 12 Jun 2014 21:31:56 +0000 (14:31 -0700)]
New baselines for perlin noise tests affected by ce6a35.
New baselines for perlinnoise, imagefiltersclipped and
imagefiltersscaled GMs.
R=scroggo@google.com
TBR=scroggo
NOTRY=true
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/
336703002
robertphillips [Thu, 12 Jun 2014 19:56:58 +0000 (12:56 -0700)]
Remove SkPicture SK_SUPPORT_LEGACY_RECORDING_FLAG flag
Chromium/Blink should no longer need this flag after:
Chromium: Remove use of kUsePathBoundsForClip_RecordingFlag https://codereview.chromium.org/
322123002/
Blink: Remove use of kUsePathBoundsForClip_RecordingFlag https://codereview.chromium.org/
326953002/
R=mtklein@google.com, scroggo@google.com, reed@google.com, bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
328343002
reed [Thu, 12 Jun 2014 19:53:00 +0000 (12:53 -0700)]
rebaselines for removal of unitmapper
TBR=
NOTRY=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/
330513005
Stephen White [Thu, 12 Jun 2014 19:51:46 +0000 (15:51 -0400)]
Add more tests to ignore-tests.txt.
Add imagefiltersclipped and imagefiltersscaled to ignored-tests.txt
until they can be rebaselined, since they're failing on Android after
https://codereview.chromium.org/
332523006/.
TBR=scroggo
BUG=skia:
Review URL: https://codereview.chromium.org/
336663002
scroggo [Thu, 12 Jun 2014 19:10:24 +0000 (12:10 -0700)]
Revert of third try at landing improved blur rect; this time with more correctness (https://codereview.chromium.org/
331443003/)
Reason for revert:
Failing layout test: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux/32762/layout-test-results/virtual/gpu/fast/canvas/canvas-draw-canvas-on-canvas-shadow-pretty-diff.html
Original issue's description:
> third try at landing improved blur rect; this time with more correctness
>
> BUG=skia:2095
> R=bsalomon@google.com
> TBR=bsalomon
>
> Committed: https://skia.googlesource.com/skia/+/
72abfc2b4e7caead660f6b6a05e60d05eaf1a66f
R=bsalomon@google.com, reed@google.com, humper@google.com
TBR=bsalomon@google.com, humper@google.com, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2095
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
333763002
egdaniel [Thu, 12 Jun 2014 18:58:15 +0000 (11:58 -0700)]
Add another fail-ignore for flaky dashing4 gm
NOTREECHECKS=True
NOTRY=True
TBR=bsalomon@google.com
BUG=skia:
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
329223007
bensong [Thu, 12 Jun 2014 18:36:53 +0000 (11:36 -0700)]
Greenify bench bot Perf-Ubuntu12-ShuttleA-GTX660-x86-Release at build 968
R=bsalomon@google.com
TBR=scroggo@google.com
Bypassing trybots:
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
338453004
kelvinly [Thu, 12 Jun 2014 18:27:40 +0000 (11:27 -0700)]
Added in framework to get more bench data
BUG=skia:
NOTRY=true
R=jcgregorio@google.com, bensong@google.com
Author: kelvinly@google.com
Review URL: https://codereview.chromium.org/
331683003
senorblanco [Thu, 12 Jun 2014 18:24:19 +0000 (11:24 -0700)]
Fix tiled perlin noise.
It turns out that the perlin implementation we inherited from WebKit
does not actually generate tileable noise (see Chromium bug
http://crbug.com/383495).
The main problem is that when generating coordinates for gradient
interpolation, it was attempting to wrap both x and (x + 1)
simultaneously at the tile boundary (that is, either both or neither
are wrapped). This obviously won't work, since along the tile seams,
(x + 1) should be wrapped, but x should not. The same is true in y.
This patch fixes both the CPU and GPU paths, renames some variables to
more closely match the spec, and modifies the perlin noise GM to
actually test tiling. (Note that the clipping the GM was doing was
removed, since it's superfluous: it used to be necessary for image
filters, but isn't anymore, and this isn't an image filter GM anyway.)
R=sugoi@google.com, sugoi
TBR=senorblanco
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/
332523006
egdaniel [Thu, 12 Jun 2014 17:24:21 +0000 (10:24 -0700)]
Use vertex attributes for dash effect in gpu
This will allow us to batch dashed lines together when drawing. Also, this removes the need for
a coord transform matrix in the shader, thus we save the cost of uploading a new matrix uniform
everytime we do a simple transform to the dashed line we are drawing.
BUG=skia:
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
326103002
bensong [Thu, 12 Jun 2014 16:40:47 +0000 (09:40 -0700)]
manual bench rebase after 679426c using old algorithm
R=robertphillips@google.com
TBR=borenet@google.com, robertphillips@google.com
Bypassing trybots:
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
330103002
reed [Thu, 12 Jun 2014 16:21:31 +0000 (09:21 -0700)]
remove GetDeviceConfig/SetDeviceConfig
BUG=skia:
R=scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
332453002
krajcevski [Thu, 12 Jun 2014 16:20:38 +0000 (09:20 -0700)]
Use scratch with LATC data if possible
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
330593004
tfarina [Thu, 12 Jun 2014 15:50:56 +0000 (08:50 -0700)]
Cleanup: Delete sk_tools::make_filepath() in favor of SkOSPath::SkPathJoin().
BUG=None
TEST=make tools tests && out/Debug/tests
R=epoger@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/
327403002
bensong [Thu, 12 Jun 2014 15:25:04 +0000 (08:25 -0700)]
removes deprecated -q flag for gsutil.
BUG=skia:
NOTRY=true
R=kelvinly@google.com
TBR=kelvinly@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
333643005
bensong [Thu, 12 Jun 2014 15:05:43 +0000 (08:05 -0700)]
Really revert bench trigger changes.
BUG=skia:
NOTRY=true
R=kelvinly@google.com
TBR=kelvinly@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
324403009
egdaniel [Thu, 12 Jun 2014 15:02:43 +0000 (08:02 -0700)]
Rebase flakey windows dash4 gm
NOTREECHECKS=True
NOTRY=True
TBR=bsalomon@google.com
BUG=skia:2667
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
335443003
kelvinly [Thu, 12 Jun 2014 13:40:57 +0000 (06:40 -0700)]
Revert trigger changes
BUG=skia:
NOTRY=true
R=robertphillips@google.com, bensong@google.com, jcgregorio@google.com
Author: kelvinly@google.com
Review URL: https://codereview.chromium.org/
334673002
egdaniel [Thu, 12 Jun 2014 13:26:15 +0000 (06:26 -0700)]
Add expectations for dashing gm
TBR=bsalomon@google.com
BUG=skia:
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
330033002
rmistry [Thu, 12 Jun 2014 13:23:38 +0000 (06:23 -0700)]
Whitespace change to test trybot triggering
BUG=skia:
CQ_EXTRA_TRYBOTS=tryserver.skia:Build-Ubuntu13.10-GCC4.8-Arm7-Release-Android-Trybot
TBR=
(SkipBuildbotRuns)
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
333663002
scroggo [Thu, 12 Jun 2014 12:54:37 +0000 (05:54 -0700)]
manual bench rebase after 679426c
In response to:
- new SKPs
- Kelvin's changes around regression testing
R=robertphillips@google.com, kelvinly@google.com
TBR=robertphillips@google.com
Bypassing trybots:
NOTRY=true
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
332483004
robertphillips [Thu, 12 Jun 2014 12:51:22 +0000 (05:51 -0700)]
Remove SkPicture pointer from SkPicturePlayback
This CL simplifies the relationship between SkPicture and SkPicturePlayback by moving the path heap into SkPicturePlayback and removing SkPicturePlayback's SkPicture pointer.
R=mtklein@google.com, reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
334493002
borenet [Thu, 12 Jun 2014 07:43:39 +0000 (00:43 -0700)]
Update SKP version to 21
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
327213004
epoger [Thu, 12 Jun 2014 03:35:59 +0000 (20:35 -0700)]
rebaseline_server: delete no-longer-used weightedDiffMeasure
(replaced by perceptual diff)
NOTRY=True
R=rmistry@google.com
TBR=rmistry
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
334533003
epoger [Thu, 12 Jun 2014 03:02:26 +0000 (20:02 -0700)]
rebaseline_server: change 2 image expectations within unittests
NOTRY=True
R=rmistry@google.com
TBR=rmistry
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
329933002
mtklein [Thu, 12 Jun 2014 00:22:14 +0000 (17:22 -0700)]
Suppress libpoppler and its dependent liblcms in TSAN.
This will let us eventually turn PDF back on in DM.
BUG=skia:
R=halcanary@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
330433003
krajcevski [Wed, 11 Jun 2014 23:08:50 +0000 (16:08 -0700)]
Add ifdef to not use function pointer that we don't have yet on Chromium??
R=bsalomon@google.com, robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
326423003
krajcevski [Wed, 11 Jun 2014 23:07:50 +0000 (16:07 -0700)]
Allow compressed texture data to be updated.
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
326383003
epoger [Wed, 11 Jun 2014 21:01:35 +0000 (14:01 -0700)]
rebaseline_server: merge identical results (across multiple builders/configs) into a single row
BUG=skia:2534
R=jcgregorio@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
326013002
jvanverth [Wed, 11 Jun 2014 20:59:22 +0000 (13:59 -0700)]
Fix a number of issues with iOS build.
Set pointer to root view in window (for SampleApp)
Set up the correct function pointer for GL multisampling
Remove use of SkBitmap::setConfig()
Remove incomplete iOS implementation of SkFILE (use SkOSFile for now)
R=caryclark@google.com, reed@google.com, bsalomon@google.com, tfarina@chromium.org
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
322403007
humper [Wed, 11 Jun 2014 19:42:49 +0000 (12:42 -0700)]
third try at landing improved blur rect; this time with more correctness
BUG=skia:2095
R=bsalomon@google.com
TBR=bsalomon
Author: humper@google.com
Review URL: https://codereview.chromium.org/
331443003
krajcevski [Wed, 11 Jun 2014 19:26:49 +0000 (12:26 -0700)]
Texture compression unit tests along with a couple of bug fixes
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
330453005
mtklein [Wed, 11 Jun 2014 18:57:43 +0000 (11:57 -0700)]
SkNEW as default Create() for SkLazyPtr macros.
BUG=skia:
R=halcanary@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
326413003
robertphillips [Wed, 11 Jun 2014 18:37:55 +0000 (11:37 -0700)]
Remove picture pre-allocation from SkPictureRecorder
This CL improves the separation of the SkPicture and SkPictureRecord classes. It delays creation of the SkPicture (in SkPictureRecorder) until recording is actually completed. To accomplish this the SkRecord-derived classes now get SkPathHeap and SkPictureContentInfo members that are absorbed by the SkPicture when it is constructed.
As an ancillary change, this CL also moves the SkPictureContentInfo object from SkPicture to SkPicturePlayback. This is intended to centralize all the data in the SkPicturePlayback object.
R=mtklein@google.com, reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
324293004
scroggo [Wed, 11 Jun 2014 17:51:42 +0000 (10:51 -0700)]
Hide chooseFromOneChoice along with Chooser.
Fixes chrome canary.
R=reed@android.com
TBR=reed
NOTRY=true
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
329113003
krajcevski [Wed, 11 Jun 2014 17:38:47 +0000 (10:38 -0700)]
Add support for glCompressedTexSubImage2D
R=bsalomon@google.com, robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
329213002
reed [Wed, 11 Jun 2014 17:33:13 +0000 (10:33 -0700)]
hide SkImageDecoder::Chooser
BUG=skia:
R=scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
331433003
egdaniel [Wed, 11 Jun 2014 17:30:05 +0000 (10:30 -0700)]
Push dash checks into GrContext.
Add class to hold stroke and dash info.
R=bsalomon@google.com, robertphillips@google.com, jvanverth@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
311183002
halcanary [Wed, 11 Jun 2014 16:40:23 +0000 (09:40 -0700)]
Use new SkBaseMutex::assertHeld() in DiscardableMemoryPool
R=mtklein@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
324413003
tfarina [Wed, 11 Jun 2014 15:58:50 +0000 (08:58 -0700)]
Cleanup: Delete sk_tools::get_basename() in favor of SkOSPath::SkBasename().
BUG=None
TEST=make tests && out/Debug/tests
R=epoger@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/
321693002
kelvinly [Wed, 11 Jun 2014 15:05:11 +0000 (08:05 -0700)]
Narrowed expectation margins noticeably
BUG=skia:
NOTRY=true
R=bensong@google.com, bsalomon@google.com, jcgregorio@google.com, robertphillips@google.com
Author: kelvinly@google.com
Review URL: https://codereview.chromium.org/
323373002
reed [Wed, 11 Jun 2014 14:26:23 +0000 (07:26 -0700)]
Revert of second try at landing improved blur rect (https://codereview.chromium.org/
325703002/)
Reason for revert:
broke some fast/canvas layout tests
Original issue's description:
> second try at landing improved blur rect
>
> BUG=skia:2095
> TBR=bsalomon
>
> Committed: https://skia.googlesource.com/skia/+/
e9ea0d6b7d59ac3b7e257281e545b24bcc0d2a76
R=bsalomon@google.com, reed@chromium.org, humper@google.com
TBR=bsalomon@google.com, humper@google.com, reed@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:2095
Author: reed@google.com
Review URL: https://codereview.chromium.org/
322423002
reed [Wed, 11 Jun 2014 14:17:11 +0000 (07:17 -0700)]
remove SK_SUPPORT_LEGACY_DEVICE_CONFIG code
BUG=skia:
R=djsollen@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
327263002
mtklein [Wed, 11 Jun 2014 14:12:09 +0000 (07:12 -0700)]
Code reviews -> reviews@skia.org.
BUG=skia:
R=reed@google.com, skia-review@googlegroups.com, hcm@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
328613003
djordje.pesut [Wed, 11 Jun 2014 13:56:10 +0000 (06:56 -0700)]
MIPS: added optimization for functions from SkBlitRow.
gain is ~40%
following function are optimized:
S32_D565_Blend
S32A_D565_Opaque_Dither
S32_D565_Opaque_Dither
S32_D565_Blend_Dither
S32A_D565_Opaque
S32A_D565_Blend
S32_Blend_BlitRow32
R=djsollen@google.com, teodora.petrovic@gmail.com
Author: djordje.pesut@imgtec.com
Review URL: https://codereview.chromium.org/
326913004
egdaniel [Wed, 11 Jun 2014 13:51:51 +0000 (06:51 -0700)]
Move Dashing filterPath to a dashing utils file
From inside GrContext, we have a need to create an SkPath an original path and
some dashing info. We do not have access to the original path effect so we need
a way to make the FilterPath function accessible outside of the effect. So I moved
the core filterPath code (and all need helper functions) out of SkDashPathEffect
and created a SkDashPath in utils to store these helper functions.
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
576dcdc793a762ec63fbecdbfd5768066b548fe5
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
314623004
sugoi [Wed, 11 Jun 2014 13:31:29 +0000 (06:31 -0700)]
Support for larger than "signed 32b limit" sized bitmaps in BGRAConvolve2D.
The multiplication of 2 signed ints was producing a result larger than what's supported by a single signed int and the memory was accessed out of bounds. Using uint64_t solves the issue.
BUG=378491
R=reed@google.com, rmistry@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/
323013005
reed [Wed, 11 Jun 2014 13:09:50 +0000 (06:09 -0700)]
switch to colortype for deepcopy
BUG=skia:
R=robertphillips@google.com, bsalomon@google.com, reed@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
323283002
rmistry [Wed, 11 Jun 2014 13:03:31 +0000 (06:03 -0700)]
Whitespace change to test trybot triggering
BUG=skia:
TBR=
NOTREECHECKS=true
(SkipBuildbotRuns)
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
325213002
borenet [Wed, 11 Jun 2014 08:52:00 +0000 (01:52 -0700)]
Update SKP version to 20
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
329043002
krajcevski [Wed, 11 Jun 2014 00:25:28 +0000 (17:25 -0700)]
Add an LATC compressor to the A8 masks, and hide it behind an ifdef.
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
326223002
kelvinly [Tue, 10 Jun 2014 22:32:44 +0000 (15:32 -0700)]
Fix what I just broke
BUG=skia:
NOTRY=true
TBR=bensong@google.com
Author: kelvinly@google.com
Review URL: https://codereview.chromium.org/
328883003
kelvinly [Tue, 10 Jun 2014 22:24:39 +0000 (15:24 -0700)]
Fix broken rebaseline code
BUG=skia:
NOTRY=true
R=bensong@google.com
Author: kelvinly@google.com
Review URL: https://codereview.chromium.org/
327943003
krajcevski [Tue, 10 Jun 2014 22:06:47 +0000 (15:06 -0700)]
Split caching from allocation in GrClipMaskManager
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
324963005
kelvinly [Tue, 10 Jun 2014 22:05:08 +0000 (15:05 -0700)]
Try 1 at rebaseline
BUG=skia:
R=bensong@google.com, bsalomon@google.com, robertphillips@google.com
Author: kelvinly@google.com
Review URL: https://codereview.chromium.org/
324083007
reed [Tue, 10 Jun 2014 21:56:29 +0000 (14:56 -0700)]
fix when DEVICE_CONFIG is still defined
BUG=skia:
R=djsollen@google.com, bsalomon@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
329553005
krajcevski [Tue, 10 Jun 2014 21:52:28 +0000 (14:52 -0700)]
Add texture compression utility
R=robertphillips@google.com, egdaniel@google.com, halcanary@google.com, scroggo@google.com, reed@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
325733004
dandov [Tue, 10 Jun 2014 21:38:28 +0000 (14:38 -0700)]
SkShader::asNewEffect Refactoring
The new signature is:
bool asNewEffect(GrContext* context, const SkPaint& paint, GrColor* grColor, GrEffectRef** grEffect, const SkMatrix* localMatrixOrNull) const;
It will fix the hack for skcolorshader by modifying the GrColor parameter in SkGr::SkPaint2GrPaintShader.
BUG=skia:2646
R=jvanverth@google.com, bsalomon@google.com
Author: dandov@google.com
Review URL: https://codereview.chromium.org/
318923005
krajcevski [Tue, 10 Jun 2014 21:34:00 +0000 (14:34 -0700)]
Add Daniel and Pavel to committers list
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
316403003
mtklein [Tue, 10 Jun 2014 19:52:09 +0000 (12:52 -0700)]
Silence TSAN warnings about is_lcd_supported for now.
BUG=skia:1792
NOTRY=true
R=bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
328663006
robertphillips [Tue, 10 Jun 2014 18:45:46 +0000 (11:45 -0700)]
Fix error revealed by Android unit test
The issue is/was that the original Picture/PictureRecorder that is being partially replayed is not guaranteed to issue any more commands before attempting to modify the existing data. Such modification is prohibited if there is a extant copy-on-write snapshot. Rather then further complicate the SkWriter32::snapshot capability for a dis-preferred use case, this CL simply copies the operation data.
R=scroggo@google.com, reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
316063005
mtklein [Tue, 10 Jun 2014 18:13:47 +0000 (11:13 -0700)]
Clean up SkScaledImageCache at exit only in SK_DEVELOPER mode.
This is triggering ASAN failures in Chrome unit tests.
c.f. https://codereview.chromium.org/
308003014
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
326913007
robertphillips [Tue, 10 Jun 2014 16:23:06 +0000 (09:23 -0700)]
Remove unused 'deepCopy' parameter
This is split out of https://codereview.chromium.org/
316063005/ for clarity. Keeping in mind that SkPicture::FakeEndRecording is now only called from SkPictureRecorder, its deepCopy parameter is no longer necessary. This is b.c., given the new Picture recording semantics (where SkPictures can no longer be actively recording), cloning for thread safety only happens when an SkPicturePlayback has already been allocated (i.e., it happens in the SkPicturePlayback copy constructor.
R=scroggo@google.com, reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
324093003
fmalita [Tue, 10 Jun 2014 16:18:04 +0000 (09:18 -0700)]
Remove SK_IGNORE_CORRECT_HIGH_QUALITY_IMAGE_SCALE
Blink has been rebased.
R=humper@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
323093002
krajcevski [Tue, 10 Jun 2014 16:17:48 +0000 (09:17 -0700)]
Do a better job of enforcing the semantics of the setRequireUnpremultipliedColors flag
R=scroggo@google.com, halcanary@google.com, robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
322813005
robertphillips [Tue, 10 Jun 2014 14:20:48 +0000 (07:20 -0700)]
Remove legacy drawPicture entry point
With Skia
5713352a (Chromium should no longer need the legacy SkCanvas::drawPicture interface - https://codereview.chromium.org/
317193002/) this code should no longer be needed.
R=reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
324703002
jvanverth [Tue, 10 Jun 2014 13:42:56 +0000 (06:42 -0700)]
Gamma correction for distance field text.
Handles both non-LCD and LCD text. Uses a texture to look up the gamma correction values for a given text color or luminance.
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
4d517fdbb145cb95e5e935470df331e1b6667cfc
R=reed@google.com, bungeman@google.com, robertphillips@google.com, bsalomon@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
258883002
borenet [Tue, 10 Jun 2014 09:04:02 +0000 (02:04 -0700)]
Update SKP version to 19
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
322943003
tfarina [Tue, 10 Jun 2014 06:59:03 +0000 (23:59 -0700)]
Cleanup: Get rid of make_isize() function from gm.h.
This helper function is not necessary.
The same thing can be achieved by using SkISize::Make() provided by
SkTSize API.
BUG=skia:2645
TEST=make dm && out/Debug/dm
R=robertphillips@google.com, reed@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/
326523002
reed [Tue, 10 Jun 2014 03:40:05 +0000 (20:40 -0700)]
teach Nacl to not call setConfig
TBR=
NOTRY=True
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
327643003
reed [Tue, 10 Jun 2014 02:52:07 +0000 (19:52 -0700)]
hide SkBitmap::setConfig
patch from issue
325733002
TBR=scroggo
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
322963002
bsalomon [Mon, 9 Jun 2014 22:11:30 +0000 (15:11 -0700)]
GM/bench for text draws with various parameters and clip rects.
R=jvanverth@google.com, robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
319053002
humper [Mon, 9 Jun 2014 21:35:21 +0000 (14:35 -0700)]
second try at landing improved blur rect
BUG=skia:2095
R=bsalomon@google.com
TBR=bsalomon
Author: humper@google.com
Review URL: https://codereview.chromium.org/
325703002
krajcevski [Mon, 9 Jun 2014 21:29:11 +0000 (14:29 -0700)]
Add sampler options to SkScaledBitmapSampler
R=scroggo@google.com, halcanary@google.com, robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
321873003
mtklein [Mon, 9 Jun 2014 21:18:02 +0000 (14:18 -0700)]
Add assertHeld() to SkMutex.
BUG=skia:
R=bungeman@google.com, mtklein@google.com, reed@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
313823004
scroggo [Mon, 9 Jun 2014 20:06:34 +0000 (13:06 -0700)]
Revert of Gamma correction for distance field text. (https://codereview.chromium.org/
258883002/)
Reason for revert:
Memory leaks. I suspect this is due to the lack of destructors in SkAutoGlyphCache
Original issue's description:
> Gamma correction for distance field text.
>
> Handles both non-LCD and LCD text. Uses a texture to look up the gamma correction values for a given text color or luminance.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
4d517fdbb145cb95e5e935470df331e1b6667cfc
NOTRY=true
NOTREECHECKS=true
R=reed@google.com, bungeman@google.com, robertphillips@google.com, bsalomon@google.com, jvanverth@google.com, mtklein@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
323513005
tfarina [Mon, 9 Jun 2014 19:05:34 +0000 (12:05 -0700)]
Reland "Clean up Test's resourcePath code."
This relands commit
91359bed48bc006a4319da86eb26db3b2e6d4afb (Clean up
Test's resourcePath code."
BUG=None
TEST=make dm && out/Debug/dm
R=mtklein@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/
321723002
jvanverth [Mon, 9 Jun 2014 19:04:55 +0000 (12:04 -0700)]
Gamma correction for distance field text.
Handles both non-LCD and LCD text. Uses a texture to look up the gamma correction values for a given text color or luminance.
BUG=skia:
R=reed@google.com, bungeman@google.com, robertphillips@google.com, bsalomon@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
258883002
egdaniel [Mon, 9 Jun 2014 18:57:28 +0000 (11:57 -0700)]
Fix Assert for gpu ConicalTwoPointGradient edgecase to be correct bounds.
BUG=skia:
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
311373003
cdalton [Mon, 9 Jun 2014 18:16:58 +0000 (11:16 -0700)]
Generate path names on the client side
Pre-allocates a range of path names and manages allocations within
that range on the client side. This allows us to generate new path
objects in a feed-forward manner that doesn't require round trips to
the GL server.
BUG=skia:
R=bsalomon@google.com, markkilgard@gmail.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/
304403003
krajcevski [Mon, 9 Jun 2014 17:54:03 +0000 (10:54 -0700)]
New etcbitmap baselines
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
325783003
krajcevski [Mon, 9 Jun 2014 16:10:04 +0000 (09:10 -0700)]
Make sure to copy the LATC alias when copying the GrGLCaps
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
320273003
krajcevski [Mon, 9 Jun 2014 15:32:34 +0000 (08:32 -0700)]
Add LATC to alpha only pixel config
R=robertphillips@google.com, bsalomon@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
323853003
mtklein [Mon, 9 Jun 2014 15:04:15 +0000 (08:04 -0700)]
bench_record: No need for --flags if there are no RecordingFlags anymore.
BUG=skia:
R=robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
327533002
robertphillips [Mon, 9 Jun 2014 14:59:25 +0000 (07:59 -0700)]
Add some comments to GrRectanizer_skyline
R=jvanverth@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
324693002
bsalomon [Mon, 9 Jun 2014 14:59:06 +0000 (07:59 -0700)]
Add dump() to SkClipStack to help with debugging.
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
311263015
robertphillips [Mon, 9 Jun 2014 14:05:04 +0000 (07:05 -0700)]
Fix Chrome build after
9f1c241e (https://codereview.chromium.org/
316143003/)
Remove SkPicture::kUsePathBoundsForClip_RecordingFlag (https://codereview.chromium.org/
316143003/) removed an SkPicture flag on which Chromium still relies.
R=scroggo@google.com
TBR=scroggo@google.com
NOTRY=true
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
325723002
epoger [Mon, 9 Jun 2014 13:49:13 +0000 (06:49 -0700)]
remove GM result-grooming tools that use skia-autogen
BUG=skia:553
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
320443002
robertphillips [Mon, 9 Jun 2014 13:25:34 +0000 (06:25 -0700)]
Remove SkPicture::kUsePathBoundsForClip_RecordingFlag
The real question is whether we ever want to record a picture without using the path bounds for a conservative (but faster) clip answer?
R=reed@google.com, mtklein@google.com, djsollen@google.com, scroggo@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
316143003
robertphillips [Sun, 8 Jun 2014 20:17:54 +0000 (13:17 -0700)]
Chromium should no longer need the legacy SkCanvas::drawPicture interface
With:
Switch Blink to using new Skia SkCanvas::drawPicture method - https://codereview.chromium.org/
316863003/
Switch Chromium to new Skia SkCanvas::drawPicture method - https://codereview.chromium.org/
315963003/
Chromium/Blink should no longer need this flag.
Note: this patch cannot be landed until the Blink change rolls into Chromium.
R=jvanverth@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
317193002
robertphillips [Sun, 8 Jun 2014 20:12:44 +0000 (13:12 -0700)]
No longer limit SkPictureRecorder::partialReplay to Android
Toggling this for local testing is a bit of a chore.
R=mtklein@google.com, reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
316173004
mtklein [Sun, 8 Jun 2014 14:02:47 +0000 (07:02 -0700)]
Revert of Clean up Test's resourcePath code. (https://codereview.chromium.org/
319473003/)
Reason for revert:
Some benchmarks are written in a way that makes this change unsafe (e.g. const char* resPath = GetResourcePath().c_str(); in SkipZeroesBench) and Valgrind and ASAN caught that. We can try again after a more careful cleanup of GetResourcePath().
Original issue's description:
> Clean up resourcePath code.
>
> 1) Make the implementation of SetResourcePath/GetResourcePath of GM and SkBenchmark match with the one in Test.
> 2) Make gResourcePath a static pointer to const char and move it inside the classes.
>
> BUG=None
> TEST=make tests && out/Debug/tests
> make gm && out/Debug/gm
> make bench && out/Debug/bench
> R=mtklein@google.com
>
> Committed: https://skia.googlesource.com/skia/+/
52e4f413ffe2d281f9e90ff2147db08083ffcba7
R=tfarina@chromium.org
TBR=tfarina@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
320733002
robertphillips [Sun, 8 Jun 2014 12:55:05 +0000 (05:55 -0700)]
First pass at splitting out SkPictureRecord from SkPicture
This patch begins the process of splitting apart SkPicture, SkPicturePlayback and SkPictureRecord.
This is still a bit messy. In a follow up CL I hope to delay the creation of SkPictureRecorder's SkPicture until endRecording time.
R=reed@google.com, mtklein@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
318763004
tfarina [Sun, 8 Jun 2014 03:50:44 +0000 (20:50 -0700)]
Clean up resourcePath code.
1) Make the implementation of SetResourcePath/GetResourcePath of GM and SkBenchmark match with the one in Test.
2) Make gResourcePath a static pointer to const char and move it inside the classes.
BUG=None
TEST=make tests && out/Debug/tests
make gm && out/Debug/gm
make bench && out/Debug/bench
R=mtklein@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/
319473003
mtklein [Sun, 8 Jun 2014 03:27:44 +0000 (20:27 -0700)]
whitespace to trigger builds
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
5037fceeab7d29b99a6497bcdf1c97f03e532956
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
314313004
mtklein [Sun, 8 Jun 2014 00:19:04 +0000 (17:19 -0700)]
whitespace to trigger builds
BUG=skia:
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
314313004
projects / platform / upstream / libSkiaSharp.git / log