platform/upstream/gcc.git
5 years ago[arm] Make ACLE builtins use arm_* namespace for expanders
Kyrylo Tkachov [Mon, 29 Jul 2019 15:31:53 +0000 (15:31 +0000)]
[arm] Make ACLE builtins use arm_* namespace for expanders

The builtins from <arm_acle.h> use fairly general expander names such as
"crc", "mcr" etc.
These run the risk of being reserved by the midend in the future.
Let's namespace them to arm_* as is convention.

* config/arm/arm-builtins.c (acle_builtin_data): Expand VAR1 to
CODE_FOR_arm_##.
* config/arm/arm.md (<crc_variant>): Rename to...
(arm_<crc_variant>): ... This.
(<cdp>): Rename to...
(arm_<cdp>): ... This.
(<ldc>): Rename to...
(arm_<ldc>): ... This.
(<stc>): Rename to...
(arm_<stc>): ... This.
(<mcr>): Rename to...
(arm_<mcr>): ... This.
(<mrc>): Rename to...
(arm_<mrc>): ... This.
(<mcrr>): Rename to...
(arm_<mcrr>): ... This.
(<mrrc>): Rename to...
(arm_<mrrc>): ... This.

From-SVN: r273879

5 years agoPR libstdc++/51333 Define recursive_init_error constructor non-inline
Jonathan Wakely [Mon, 29 Jul 2019 14:27:19 +0000 (15:27 +0100)]
PR libstdc++/51333 Define recursive_init_error constructor non-inline

The recursive_init_error class is defined in a header, with an inline
constructor, but the definition of the vtable and destructor are not
exported from the shared library. With -fkeep-inline-functions the
constructor gets emitted in user code, and requires the (non-exported)
vtable. This fails to link.

As far as I can tell, the recursive_init_error class definition was
moved into <cxxabi.h> so it could be documented with Doxygen, not for
any technical reason. But now it's there (and documented), somebody
could be relying on it, by catching that type and possibly performing
derived-to-base conversions to the std::exception base class. So the
conservative fix is to leave the class definition in the header but make
the constructor non-inline. This still allows the type to be caught and
still defines its base class. User code can no longer construct objects
of that type, but that's not something we need to support.

PR libstdc++/51333
* libsupc++/cxxabi.h (__gnu_cxx::recursive_init_error): Do not define
constructor inline.
* libsupc++/guard_error.cc (__gnu_cxx::recursive_init_error): Define
constructor.
* testsuite/18_support/51333.cc: New test.

From-SVN: r273878

5 years agore PR tree-optimization/91257 (Compile-time and memory-hog hog)
Richard Biener [Mon, 29 Jul 2019 14:19:07 +0000 (14:19 +0000)]
re PR tree-optimization/91257 (Compile-time and memory-hog hog)

2019-07-29  Richard Biener  <rguenther@suse.de>

PR tree-optimization/91257
* tree-ssa-sccvn.h (struct vn_avail): New.
(struct vn_ssa_aux): Add avail member.
* tree-ssa-sccvn.c (class rpo_elim): Remove m_rpo_avail
member, add m_avail_freelist one.
(rpo_elim::~rpo_elim): Remove.
(rpo_elim::eliminate_avail): Adjust to new avail tracking
data structure.
(rpo_elim::eliminate_push_avail): Likewise.
(do_unwind): Likewise.
(do_rpo_vn): Likewise.

From-SVN: r273877

5 years agore PR tree-optimization/91257 (Compile-time and memory-hog hog)
Richard Biener [Mon, 29 Jul 2019 11:38:46 +0000 (11:38 +0000)]
re PR tree-optimization/91257 (Compile-time and memory-hog hog)

2019-07-29  Richard Biener  <rguenther@suse.de>

PR tree-optimization/91257
* tree-vrp.c (operand_less_p): Avoid dispatching to fold for
most cases, instead call compare_values which handles the
symbolic ranges we handle specially.
(compare_values_warnv): Do not call operand_less_p but open-code
the effective fold calls.  Avoid converting so much.

From-SVN: r273876

5 years agoFix ICE seen in tree-ssa-dce.c for new/delete pair.
Martin Liska [Mon, 29 Jul 2019 10:39:46 +0000 (12:39 +0200)]
Fix ICE seen in tree-ssa-dce.c for new/delete pair.

2019-07-29  Martin Liska  <mliska@suse.cz>

* tree-ssa-dce.c (eliminate_unnecessary_stmts): Do not
remove LHS of operator new call.  It's handled latter.
2019-07-29  Martin Liska  <mliska@suse.cz>

* g++.dg/cpp1y/new1.C (test_unused): Add new case that causes
ICE.

From-SVN: r273875

5 years agore PR middle-end/91267 (SEGV in value_range_base::equal_p)
Richard Biener [Mon, 29 Jul 2019 10:10:15 +0000 (10:10 +0000)]
re PR middle-end/91267 (SEGV in value_range_base::equal_p)

2019-07-29  Richard Biener  <rguenther@suse.de>

PR tree-optimization/91267
* vr-values.c (vr_values::update_value_range): Add early return
for effectively VARYING lattice entry.

* gcc.dg/torture/pr91267.c: New testcase.

From-SVN: r273874

5 years agoPrevent tree-ssa-dce.c from deleting stores at -Og
Richard Sandiford [Mon, 29 Jul 2019 08:52:56 +0000 (08:52 +0000)]
Prevent tree-ssa-dce.c from deleting stores at -Og

DCE tries to delete dead stores to local data and also tries to insert
debug binds for simple cases:

  /* If this is a store into a variable that is being optimized away,
     add a debug bind stmt if possible.  */
  if (MAY_HAVE_DEBUG_BIND_STMTS
      && gimple_assign_single_p (stmt)
      && is_gimple_val (gimple_assign_rhs1 (stmt)))
    {
      tree lhs = gimple_assign_lhs (stmt);
      if ((VAR_P (lhs) || TREE_CODE (lhs) == PARM_DECL)
  && !DECL_IGNORED_P (lhs)
  && is_gimple_reg_type (TREE_TYPE (lhs))
  && !is_global_var (lhs)
  && !DECL_HAS_VALUE_EXPR_P (lhs))
{
  tree rhs = gimple_assign_rhs1 (stmt);
  gdebug *note
    = gimple_build_debug_bind (lhs, unshare_expr (rhs), stmt);
  gsi_insert_after (i, note, GSI_SAME_STMT);
}
    }

But this doesn't help for things like "print *ptr" when ptr points
to the local variable (tests Og-dce-1.c and Og-dce-2.c).  It can
also introduce wrong debug info for earlier references (second test
in Og-dce-3.c) or make earlier references unavailable (first test
in Og-dce-3.c).

So for -Og I think it'd be better not to delete any stmts with
vdefs for now.  This also means that we can avoid the potentially
expensive vop walks (which already have a cut-off, but still).

The patch also fixes the Og failures in gcc.dg/guality/pr54970.c
(PR 86638).

2019-07-29  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
PR debug/86638
* tree-ssa-dce.c (keep_all_vdefs_p): New function.
(mark_stmt_if_obviously_necessary): Mark all stmts with vdefs as
necessary if keep_all_vdefs_p is true.
(mark_aliased_reaching_defs_necessary): Add a gcc_checking_assert
that keep_all_vdefs_p is false.
(mark_all_reaching_defs_necessary): Likewise.
(propagate_necessity): Skip the vuse scan if keep_all_vdefs_p is true.

gcc/testsuite/
* c-c++-common/guality/Og-dce-1.c: New test.
* c-c++-common/guality/Og-dce-2.c: Likewise.
* c-c++-common/guality/Og-dce-3.c: Likewise.

From-SVN: r273872

5 years agoDon't run DSE at -Og
Richard Sandiford [Mon, 29 Jul 2019 08:47:20 +0000 (08:47 +0000)]
Don't run DSE at -Og

This patch stops gimple and rtl DSE from running by default at -Og.
The idea is both to improve compile time and to stop us from deleting
stores that we can't track in debug info.

We could rein this back in future for stores to local variables
with is_gimple_reg_type, but at the moment we don't have any
infrastructure for switching between binds to specific values
and binds to evolving memory locations.  Even then, location
tracking only works for direct references to the variables, and doesn't
for example help with printing dereferenced pointers (see the next patch
in the series for an example).

I'm also not sure that DSE is important enough for -Og to justify the
compile time cost --  especially in the case of RTL DSE, which is pretty
expensive.

2019-07-29  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* common.opt (Og): Change the initial value of flag_dse to 0.
* opts.c (default_options_table): Move OPT_ftree_dse from
OPT_LEVELS_1_PLUS to OPT_LEVELS_1_PLUS_NOT_DEBUG.  Also add
OPT_fdse to OPT_LEVELS_1_PLUS_NOT_DEBUG.  Put the OPT_ftree_pta
entry before the OPT_ftree_sra entry.
* doc/invoke.texi (Og): Add -fdse and -ftree-dse to the list
of flags disabled by Og.

gcc/testsuite/
* c-c++-common/guality/Og-global-dse-1.c: New test.

From-SVN: r273871

5 years agoPrevent -Og from deleting stores to write-only variables
Richard Sandiford [Mon, 29 Jul 2019 08:46:54 +0000 (08:46 +0000)]
Prevent -Og from deleting stores to write-only variables

This patch prevents -Og from deleting stores to write-only variables,
so that the values are still available when debugging.  This seems
more convenient than forcing users to use __attribute__((used))
(probably conditionally, if it's not something they want in release
builds).

2019-07-29  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* tree-cfg.c (execute_fixup_cfg): Don't delete stores to write-only
variables for -Og.

gcc/testsuite/
* c-c++-common/guality/Og-static-wo-1.c: New test.
* g++.dg/guality/guality.exp: Separate the c-c++-common tests into
"Og" and "general" tests.  Run the latter at -O0 and -Og only.
* gcc.dg/guality/guality.exp: Likewise.

From-SVN: r273870

5 years agoAdd dg test for matching function bodies
Richard Sandiford [Mon, 29 Jul 2019 08:46:46 +0000 (08:46 +0000)]
Add dg test for matching function bodies

There isn't a 1:1 mapping from SVE intrinsics to SVE instructions,
but the intrinsics are still close enough to the instructions for
there to be a specific preferred sequence (or sometimes choice of
preferred sequences) for a given combination of operands.  Sometimes
these sequences will be one instruction, sometimes they'll be several.

I therefore wanted a convenient way of matching the exact assembly
implementation of a given function.  It's possible to do that using
single scan-assembler lines, but:

(a) they become hard to read for multiline matches
(b) the PASS/FAIL lines tend to be overly long
(c) it's useful to have a single place that skips over uninteresting
    lines, such as entry block labels and .cfi_* directives, without
    being overly broad

This patch therefore adds a new check-function-bodies dg-final test
that looks for specially-formatted comments.  As a demo, the patch
converts the SVE vec_init tests to use the new harness instead of
scan-assembler.

The regexps in parse_function_bodies are fairly general, but might
still need to be extended in future for targets like Darwin or AIX.

2019-07-29  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* doc/sourcebuild.texi (check-function-bodies): Document.

gcc/testsuite/
* lib/scanasm.exp (parse_function_bodies, check_function_body)
(check-function-bodies): New procedures.
* gcc.target/aarch64/sve/init_1.c: Use check-function-bodies
instead of scan-assembler.
* gcc.target/aarch64/sve/init_2.c: Likewise.
* gcc.target/aarch64/sve/init_3.c: Likewise.
* gcc.target/aarch64/sve/init_4.c: Likewise.
* gcc.target/aarch64/sve/init_5.c: Likewise.
* gcc.target/aarch64/sve/init_6.c: Likewise.
* gcc.target/aarch64/sve/init_7.c: Likewise.
* gcc.target/aarch64/sve/init_8.c: Likewise.
* gcc.target/aarch64/sve/init_9.c: Likewise.
* gcc.target/aarch64/sve/init_10.c: Likewise.
* gcc.target/aarch64/sve/init_11.c: Likewise.
* gcc.target/aarch64/sve/init_12.c: Likewise.

From-SVN: r273869

5 years agoGeneralise VEC_DUPLICATE folding for variable-length vectors
Richard Sandiford [Mon, 29 Jul 2019 08:42:19 +0000 (08:42 +0000)]
Generalise VEC_DUPLICATE folding for variable-length vectors

This patch uses the constant vector encoding scheme to handle
more cases of a VEC_DUPLICATE of another vector.  Duplicating
any fixed-length vector is fine, and duplicating a variable-length
vector is OK as long as that vector is also a duplicate of a
fixed-length sequence.

Other cases fell through to:

  if (VECTOR_MODE_P (mode) && GET_CODE (op) == CONST_VECTOR)

which was only expecting to deal with elementwise operations.

2019-07-29  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* simplify-rtx.c (simplify_const_unary_operation): Fold a
VEC_DUPLICATE of a fixed-length vector even if the result
is variable-length.  Likewise fold a duplicate of a
variable-length vector if the variable-length vector is
itself a duplicate of a fixed-length sequence.
(test_vector_ops_duplicate): Test more cases.

From-SVN: r273868

5 years agoImplement more rtx vector folds on variable-length vectors
Richard Sandiford [Mon, 29 Jul 2019 08:40:21 +0000 (08:40 +0000)]
Implement more rtx vector folds on variable-length vectors

This patch extends the tree-level folding of variable-length vectors
so that it can also be used on rtxes.  The first step is to move
the tree_vector_builder new_unary/binary_operator routines to the
parent vector_builder class (which in turn means adding a new
template parameter).  The second step is to make simplify-rtx.c
use a direct rtx analogue of the VECTOR_CST handling in fold-const.c.

2019-07-29  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* vector-builder.h (vector_builder): Add a shape template parameter.
(vector_builder::new_unary_operation): New function, generalizing
the old tree_vector_builder function.
(vector_builder::new_binary_operation): Likewise.
(vector_builder::binary_encoded_nelts): Likewise.
* int-vector-builder.h (int_vector_builder): Update template
parameters to vector_builder.
(int_vector_builder::shape_nelts): New function.
* rtx-vector-builder.h (rtx_vector_builder): Update template
parameters to vector_builder.
(rtx_vector_builder::shape_nelts): New function.
(rtx_vector_builder::nelts_of): Likewise.
(rtx_vector_builder::npatterns_of): Likewise.
(rtx_vector_builder::nelts_per_pattern_of): Likewise.
* tree-vector-builder.h (tree_vector_builder): Update template
parameters to vector_builder.
(tree_vector_builder::shape_nelts): New function.
(tree_vector_builder::nelts_of): Likewise.
(tree_vector_builder::npatterns_of): Likewise.
(tree_vector_builder::nelts_per_pattern_of): Likewise.
* tree-vector-builder.c (tree_vector_builder::new_unary_operation)
(tree_vector_builder::new_binary_operation): Delete.
(tree_vector_builder::binary_encoded_nelts): Likewise.
* simplify-rtx.c: Include rtx-vector-builder.h.
(distributes_over_addition_p): New function.
(simplify_const_unary_operation)
(simplify_const_binary_operation): Generalize handling of vector
constants to include variable-length vectors.
(test_vector_ops_series): Add more tests.

From-SVN: r273867

5 years agore PR c++/91222 (507.cactuBSSN_r build fails in warn_types_mismatch at ipa-devirt...
Jan Hubicka [Mon, 29 Jul 2019 08:18:38 +0000 (10:18 +0200)]
re PR c++/91222 (507.cactuBSSN_r build fails in warn_types_mismatch at ipa-devirt.c:1006 since r273571)

PR lto/91222
* ipa-devirt.c (warn_types_mismatch): Compare indentifiers
than INDENTIFIER_POINTER.

From-SVN: r273866

5 years agoDaily bump.
GCC Administrator [Mon, 29 Jul 2019 00:16:21 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r273864

5 years agoRelease cgraph_{node,edge} via ggc_free (PR ipa/89330).
Martin Liska [Sun, 28 Jul 2019 17:10:26 +0000 (19:10 +0200)]
Release cgraph_{node,edge} via ggc_free (PR ipa/89330).

2019-07-28  Martin Liska  <mliska@suse.cz>

PR ipa/89330
* cgraph.c (symbol_table::create_edge): Always allocate
a cgraph_edge.
(symbol_table::free_edge): Store summary_id to
edge_released_summary_ids if != -1;
* cgraph.h (NEXT_FREE_NODE): Remove.
(SET_NEXT_FREE_NODE): Likewise.
(NEXT_FREE_EDGE): Likewise.
(symbol_table::release_symbol): Store summary_id to
cgraph_released_summary_ids if != -1;
(symbol_table::allocate_cgraph_symbol): Always allocate
a cgraph_node.

From-SVN: r273857

5 years agoFix g++.dg/lto/pr89330 on Solaris
Rainer Orth [Sun, 28 Jul 2019 12:31:17 +0000 (12:31 +0000)]
Fix g++.dg/lto/pr89330 on Solaris

* g++.dg/lto/pr89330_0.C (dg-lto-options): Add -fPIC.
Require fpic support.

From-SVN: r273856

5 years ago[RS6000] rs6000_output_mi_thunk tidy
Alan Modra [Sun, 28 Jul 2019 09:30:41 +0000 (19:00 +0930)]
[RS6000] rs6000_output_mi_thunk tidy

Since svn r123193 (git 327202e27a) the comment about scratch regs was
no longer correct, and I think gen_sibcall could have been used even
then.

* gcc/config/rs6000/rs6000-call.c (rs6000_output_mi_thunk): Use
gen_sibcall.

From-SVN: r273855

5 years ago[RS6000] PR91135, __linux__ not defined with -mcall-aixdesc on 9.x and ppc64
Alan Modra [Sun, 28 Jul 2019 09:29:11 +0000 (18:59 +0930)]
[RS6000] PR91135, __linux__ not defined with -mcall-aixdesc on 9.x and ppc64

This patch makes the obvious fix for PR91135, and deletes extraneous
copies of GNU_USER_TARGET_D_OS_VERSIONS that appear in rs6000/linux.h
and rs6000/linux64.h.  Since all configurations using either of these
files also include linux.h there is no need to duplicate the macro.

PR target/91135
* config/rs6000/linux.h (GNU_USER_TARGET_D_OS_VERSIONS): Don't
define.
* config/rs6000/linux64.h (TARGET_OS_CPP_BUILTINS): Invoke
GNU_USER_TARGET_OS_CPP_BUILTINS for aixdesc abi.
(GNU_USER_TARGET_D_OS_VERSIONS): Don't define.

From-SVN: r273854

5 years ago[RS6000] Make assembler command line cpu match default for gcc
Alan Modra [Sun, 28 Jul 2019 09:26:13 +0000 (18:56 +0930)]
[RS6000] Make assembler command line cpu match default for gcc

When gcc is configured using --with-cpu=<cpu>, the specified cpu
effectively becomes a default -mcpu=<cpu> passed to gcc.  This then
affects the cpu passed to gas via ASM_CPU_SPEC.  If gcc is not
configured using --with-cpu then the cpu passed to gas is that given
by ASM_DEFAULT_SPEC, which currently does not match the default flags
selected in default64.h.  This patch makes ASM_DEFAULT_SPEC agree with
TARGET_DEFAULT flags.

rs6000/default64.h appears in three places in config.gcc, the first
one immediately followed by rs6000/freebsd64.h in $tm_file, and the
other two immediately followed by rs6000/linux64.h.  To be able to
define ASM_DEFAULT_SPEC in rs6000/default64.h we don't want to
redefine in the other two files.  rs6000/freebsd64.h is easy since
that file is always preceded by rs6000/default64.h, but
rs6000/linux64.h can appear without rs6000/default64.h (a
powerpc*-linux config where the default is -m32).  In that case we
will have TARGET_DEFAULT flags of 0 (from rs6000/sysv4.h) and want to
use -mppc without -m64 and -mppc64 with -m64.  This can be done by
using the rs6000/rtems.h ASM_DEFAULT_SPEC in rs6000/sysv4.h, a change
that won't affect sysv4 configurations where -m64 is invalid.

The patch also introduces ASM_DEFAULT_EXTRA for the altivec variant
targets so as to enable -maltivec by default.

PR target/91050
* config/rs6000/sysv4.h (ASM_DEFAULT_SPEC): Modify if -m64.
* config/rs6000/default64.h (ASM_DEFAULT_SPEC): Define.
* config/rs6000/freebsd64.h (ASM_DEFAULT_SPEC): Don't define.
* config/rs6000/linux64.h (ASM_DEFAULT_SPEC): Likewise.
* config/rs6000/rtems.h (ASM_DEFAULT_SPEC): Likewise.
* config/rs6000/rs6000.h (ASM_DEFAULT_EXTRA): Define and use
in asm_default spec.
* config/rs6000/eabialtivec.h (ASM_DEFAULT_EXTRA): Redefine.
* config/rs6000/linuxaltivec.h (ASM_DEFAULT_EXTRA): Redefine.

From-SVN: r273853

5 years agodocumentation_hacking.xml: Fix broken reference to the Doxygen manual.
Gerald Pfeifer [Sun, 28 Jul 2019 09:10:32 +0000 (09:10 +0000)]
documentation_hacking.xml: Fix broken reference to the Doxygen manual.

* doc/xml/manual/documentation_hacking.xml: Fix broken reference
to the Doxygen manual. Avoid a "here" link on the way.
Fix another broken link to Doxygen docblocks.

From-SVN: r273852

5 years ago* doc/include/gpl_v3.texi (Copying): Use https for www.gnu.org.
Gerald Pfeifer [Sun, 28 Jul 2019 08:41:20 +0000 (08:41 +0000)]
* doc/include/gpl_v3.texi (Copying): Use https for gnu.org.

From-SVN: r273851

5 years agoDaily bump.
GCC Administrator [Sun, 28 Jul 2019 00:16:59 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r273850

5 years ago[Darwin, PPC, testsuite] Fix fail for bmi2-bzhi64-1a.c
Iain Sandoe [Sat, 27 Jul 2019 07:43:15 +0000 (07:43 +0000)]
[Darwin, PPC, testsuite] Fix fail for bmi2-bzhi64-1a.c

This test is failing with older cpus because the included header needs both
altivec and vsx to be enabled to succeed in compiling.  Without this (if these
are not defaults for the cpu) there are errors like:

In file included from ... x86intrin.h:41,
                 from ... bmi2-bzhi64-1a.c:6:
 ... xmmintrin.h: In function '_mm_loadu_ps':
 ... xmmintrin.h:122:11:
error: incompatible types when returning type 'int' but '__m128' {aka '__vector(4) float'} was expected
<snip>
 ... xmmintrin.h: In function '_mm_cvtps_pi32':
 ... xmmintrin.h:996:3:
error: use of 'long long' in AltiVec types is invalid without '-mvsx'
<snip>

Fixed by adding -maltivec -mvsx to the options.

gcc/testsuite/

2019-07-27  Iain Sandoe  <iain@sandoe.co.uk>

* gcc.target/powerpc/bmi2-bzhi64-1a.c: Add options to enable altivec
and vsx.

From-SVN: r273844

5 years agoDaily bump.
GCC Administrator [Sat, 27 Jul 2019 00:16:32 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r273843

5 years ago[Darwin, testsuite] Handle Darwin's size command.
Iain Sandoe [Fri, 26 Jul 2019 18:58:02 +0000 (18:58 +0000)]
[Darwin, testsuite] Handle Darwin's size command.

Darwin's "size" command has a different header line, reflecting the Mach-O
section naming conventions.  This causes tests using the command to fail
because scanasm.exp expects and checks specific layout of the header line.

gcc/testsuite/

2019-07-26  Iain Sandoe  <iain@sandoe.co.uk>

* lib/scanasm.exp (object-size): Handle Darwin's size command.

From-SVN: r273839

5 years agoDefine __cpp_lib_endian feature test macro
Jonathan Wakely [Fri, 26 Jul 2019 13:30:42 +0000 (14:30 +0100)]
Define __cpp_lib_endian feature test macro

This macro was added as part of moving std::endian from <type_traits> to
<bit>.

* include/std/bit (__cpp_lib_endian): Define.
* include/std/version (__cpp_lib_endian): Define.
* testsuite/26_numerics/endian/2.cc: New.
* testsuite/26_numerics/endian/3.cc: New.
* testsuite/26_numerics/endian/4.cc: New.

From-SVN: r273828

5 years agoAArch64: Make processing less fragile in config.gcc
Tamar Christina [Fri, 26 Jul 2019 13:13:48 +0000 (13:13 +0000)]
AArch64: Make processing less fragile in config.gcc

Due to config.gcc all the options need to be on one line because of the grep
lines which would select only the first line of the option.

This causes it not to select the right bits on options that are spread over
multiple lines when the --with-arch configure option is used.  The issue happens
silently and you just get a compiler with an incorrect set of default flags.

The current rules are quite rigid:

   1) No space between the AARCH64_OPT_EXTENSION and the opening (.
   2) No space between the opening ( and the extension name.
   3) No space after the extension name before the ,.
   4) Spaces are only allowed after a , and around |.

This patch makes this a lot less fragile by using the C pre-processor to flatten
the list and then provides much more flexible regex using group matching to
process the options instead of string replacement.  This removes all the
restrictions above and makes the code a bit more readable.

gcc/ChangeLog:

PR target/89517
* config.gcc: Relax parsing of AARCH64_OPT_EXTENSION.
* config/aarch64/aarch64-option-extensions.def: Add new comments
and restore easier to read options.

From-SVN: r273827

5 years agoAdd rules to strip away unneeded type casts in expressions
Tamar Christina [Fri, 26 Jul 2019 13:05:39 +0000 (13:05 +0000)]
Add rules to strip away unneeded type casts in expressions

This patch moves part of the type conversion code from convert.c to match.pd
because match.pd is able to apply these transformations in the presence of
intermediate temporary variables.

Concretely it makes both these cases behave the same

  float e = (float)a * (float)b;
  *c = (_Float16)e;

and

  *c = (_Float16)((float)a * (float)b);

gcc/ChangeLog:

* convert.c (convert_to_real_1): Move part of conversion code...
* match.pd: ...To here.

gcc/testsuite/ChangeLog:

* gcc.dg/type-convert-var.c: New test.

From-SVN: r273826

5 years ago[PR 89330] Remove non-useful speculations from new_edges
Martin Jambor [Fri, 26 Jul 2019 08:44:51 +0000 (10:44 +0200)]
[PR 89330] Remove non-useful speculations from new_edges

2019-07-26  Martin Jambor  <mjambor@suse.cz>

PR ipa/89330
* ipa-inline-transform.c (check_speculations_1): New function.
(push_all_edges_in_set_to_vec): Likewise.
(check_speculations): Use check_speculations_1, new parameter
new_edges.
(inline_call): Pass new_edges to check_speculations.
* ipa-inline.c (add_new_edges_to_heap): Assert edge_callee is not
NULL.
(speculation_useful_p): Early return true if edge is inlined, remove
later checks for inline_failed.

testsuite/
* g++.dg/lto/pr89330_[01].C: New test.
* g++.dg/tree-prof/devirt.C: Added -fno-profile-values to dg-options.

From-SVN: r273825

5 years ago2019-07-26 François Dumont <fdumont@gcc.gnu.org>
François Dumont [Fri, 26 Jul 2019 05:05:48 +0000 (05:05 +0000)]
2019-07-26  François Dumont  <fdumont@gcc.gnu.org>

* testsuite/util/testsuite_iterators.h
(bidirectional_iterator_wrapper): Fix type comment.
(random_access_iterator_wrapper): Likewise.

From-SVN: r273824

5 years agoDaily bump.
GCC Administrator [Fri, 26 Jul 2019 00:16:24 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r273823

5 years agoRelocate std::endian from <type_traits> to <bit>
Jonathan Wakely [Thu, 25 Jul 2019 20:30:25 +0000 (21:30 +0100)]
Relocate std::endian from <type_traits> to <bit>

This change to an early C++2a feature was just approved (P1612R1).

* include/std/bit (endian): Move definition here as per P1612R1.
* include/std/type_traits (endian): Remove definition from here.
* testsuite/20_util/endian/1.cc: Rename to ...
* testsuite/26_numerics/endian/1.cc: ... here. Adjust header.

From-SVN: r273816

5 years agoWstringop-overflow-14.c: Disable for stricly aligned targets.
Martin Sebor [Thu, 25 Jul 2019 19:39:04 +0000 (19:39 +0000)]
Wstringop-overflow-14.c: Disable for stricly aligned targets.

gcc/testsuite/ChangeLog:
* gcc.dg/Wstringop-overflow-14.c: Disable for stricly aligned targets.

From-SVN: r273814

5 years agore PR tree-optimization/91183 (strlen of a strcpy result with a conditional source...
Martin Sebor [Thu, 25 Jul 2019 19:03:00 +0000 (19:03 +0000)]
re PR tree-optimization/91183 (strlen of a strcpy result with a conditional source not folded)

PR tree-optimization/91183
PR tree-optimization/86688

gcc/testsuite/ChangeLog:
* gcc.dg/strlenopt-70.c: Fix bugs.
* gcc.dg/strlenopt-71.c: Same.
* gcc.dg/strlenopt-72.c: Same.

From-SVN: r273812

5 years agore PR rtl-optimization/91223 (ICE: in curr_insn_transform, at lra-constraints.c:4459)
Vladimir Makarov [Thu, 25 Jul 2019 18:36:52 +0000 (18:36 +0000)]
re PR rtl-optimization/91223 (ICE: in curr_insn_transform, at lra-constraints.c:4459)

2019-07-25  Vladimir Makarov  <vmakarov@redhat.com>

PR rtl-optimization/91223
* lra-constraints.c (process_alt_operands): Fail for unsuccessful
matching with INOUT operand.

2019-07-25  Vladimir Makarov  <vmakarov@redhat.com>

PR rtl-optimization/91223
* gcc.target/i386/pr91223.c: New test.

From-SVN: r273810

5 years ago[Darwin, testsuite] Address PR91087 - XFAIL parts of pr16855.C.
Iain Sandoe [Thu, 25 Jul 2019 18:12:03 +0000 (18:12 +0000)]
[Darwin, testsuite] Address PR91087 - XFAIL parts of pr16855.C.

The testcase is failing to instrument part of the source because of a bug
in the ordering of static DTORs.  It seems unlikely that this is generically
fixable in the toolchain (and given that it's likely to be a dynamic loader
change would not be expected to be applied retrospectively to OS versions
that are out of support).  To avoid the testsuite noise, xfail the count lines
that don't match (we can adjust the xfails as/when the upstream bug is fixed).

dejagnu xfails do not seem to work when embedded in a line like:
  ~Test (void) { .... /* count(1) { xfail ... } */ }
the closing brace seems to confuse the parser.  The solution is to exapnd the
text onto three lines.

2019-07-25  Iain Sandoe  <iain@sandoe.co.uk>

PR gcov-profile/91087
* g++.dg/gcov/pr16855.C: Xfail the count lines for the DTORs and the
"final" line for the failure summaries.  Adjust source layout so that
dejagnu xfail expressions work.

From-SVN: r273809

5 years agore PR fortran/65819 (overzealous checking in gfc_check_dependency for identical=true)
Thomas Koenig [Thu, 25 Jul 2019 16:24:00 +0000 (16:24 +0000)]
re PR fortran/65819 (overzealous checking in gfc_check_dependency for identical=true)

2019-07-25  Thomas Koenig  <tkoenig@gcc.gnu.org>

PR fortran/65819
* dependency.h (gfc_dep_resovler): Add optional argument identical.
* dependency.c (gfc_check_dependency): Do not alway return 1 if
the symbol is the same. Pass on identical to gfc_dep_resolver.
(gfc_check_element_vs_element): Whitespace fix.
(gfc_dep_resolver): Adjust comment for function.  If identical is
true, return 1 if any overlap has been found.

2019-07-25  Thomas Koenig  <tkoenig@gcc.gnu.org>

PR fortran/65819
* gfortran.dg/dependency_54.f90: New test.

From-SVN: r273807

5 years agostmt.c (expand_case): Try to narrow the index type if it's larger than a word.
Eric Botcazou [Thu, 25 Jul 2019 16:16:32 +0000 (16:16 +0000)]
stmt.c (expand_case): Try to narrow the index type if it's larger than a word.

* stmt.c (expand_case): Try to narrow the index type if it's larger
than a word.  Tidy up.

From-SVN: r273805

5 years agocif-code.def (NEVER_CALL): New code.
Eric Botcazou [Thu, 25 Jul 2019 16:07:29 +0000 (16:07 +0000)]
cif-code.def (NEVER_CALL): New code.

* cif-code.def (NEVER_CALL): New code.
* ipa-inline.c (want_inline_small_function_p): Fix formatting issues.
Set the failure to CIF_NEVER_CALL if the IPA count is zero.

From-SVN: r273804

5 years agoFix low reg issue in Thumb-2 movsi patterns
Wilco Dijkstra [Thu, 25 Jul 2019 14:24:41 +0000 (14:24 +0000)]
Fix low reg issue in Thumb-2 movsi patterns

The Thumb-2 movsi patterns try to prefer low registers for loads and stores.
However this is done incorrectly by using 2 separate variants with 'l' and 'h'
register classes.  The register allocator will only use low registers, and
as a result we end up with significantly more spills and moves to high
registers.  Fix this by merging the alternatives and use 'l*r' to indicate
preference for low registers.  This saves ~400 instructions from the pr77308
testcase.

    gcc/
* config/arm/thumb2.md (thumb2_movsi_insn): Fix load/store low reg.
* config/arm/vfp.md (thumb2_movsi_vfp): Likewise.

From-SVN: r273802

5 years ago* ipa-devirt.c (add_type_duplicate): Fix return value.
Jan Hubicka [Thu, 25 Jul 2019 13:42:25 +0000 (15:42 +0200)]
* ipa-devirt.c (add_type_duplicate): Fix return value.

From-SVN: r273800

5 years agotree-vrp.c (extract_range_from_multiplicative_op): Add type parameter and use it...
Richard Biener [Thu, 25 Jul 2019 12:05:19 +0000 (12:05 +0000)]
tree-vrp.c (extract_range_from_multiplicative_op): Add type parameter and use it instead of guessing expression type from the...

2019-07-25  Richard Biener  <rguenther@suse.de>

* tree-vrp.c (extract_range_from_multiplicative_op): Add
type parameter and use it instead of guessing expression
type from the first operand.
(extract_range_from_binary_expr): Pass expr_type down.

From-SVN: r273797

5 years ago[arm][committed] Clean up code iterator usage in satsi* patterns
Kyrylo Tkachov [Thu, 25 Jul 2019 11:04:21 +0000 (11:04 +0000)]
[arm][committed] Clean up code iterator usage in satsi* patterns

GCC 10 now supports having RTL codes being code attributes (thanks
Richard) allowing us to map smax to smin and vice versa.
This means we can clean up their use in the saturation patterns that do
the cross product of [smin, smax] and use the pattern
predicate to cancel out the nonsense ones.

* config/arm/arm.md (SATrev): Change to code attribute.
(*satsi_<SAT:code>): Adjust for the above.
(*satsi_<SAT:code>_shift): Likewise.

From-SVN: r273796

5 years agogimple-loop-versioning.cc (loop_versioning::prune_loop_conditions): Make value_range...
Richard Biener [Thu, 25 Jul 2019 10:25:13 +0000 (10:25 +0000)]
gimple-loop-versioning.cc (loop_versioning::prune_loop_conditions): Make value_range * temporary const.

2019-07-25  Richard Biener  <rguenther@suse.de>

* gimple-loop-versioning.cc (loop_versioning::prune_loop_conditions):
Make value_range * temporary const.
* gimple-ssa-evrp-analyze.c (evrp_range_analyzer::try_find_new_range):
Likewise.
(evrp_range_analyzer::record_ranges_from_): Likewise.
(evrp_range_analyzer::pop_value_range): Return a const value_range *,
deal with having recorded a const one.
* gimple-ssa-evrp-analyze.h (evrp_range_analyzer::get_value_range):
Return a const value_range *.
(evrp_range_analyzer::pop_value_range): Likewise.
(evrp_range_analyzer::stack): Record const value_range *s.
* gimple-ssa-evrp.c (evrp_dom_walker::before_dom_children):
Adjust.
* gimple-ssa-sprintf.c (get_int_range): Likewise.
(format_integer): Likewise.
(sprintf_dom_walker::handle_gimple_call): Likewise.
* tree-ssa-dom.c (simplify_stmt_for_jump_threading): Likewise.
* tree-vrp.c (vrp_prop::set_def_to_varying): Add.
(vrp_prop::get_value_range): Adjust.
(vrp_prop::vrp_initialize): Use set_def_to_varying instead of
modifying the lattice in-place.
(vrp_prop::visit_stmt): Likewise.
* vr-values.c (vr_values::get_lattice_entry): New private method.
(vr_values::get_value_range): Wrap it and return a const
value_range *.
(vr_values::set_def_to_varying): New.
(vr_values::set_defs_to_varying): Use it.
(vr_values::update_value_range): Likewise.
(vr_values::vrp_stmt_computes_nonzero): Adjust.
(values::op_with_constant_singleton_va): Likewise.
(vr_values::extract_range_for_var_from_co): Likewise.
(vr_values::extract_range_from_ssa_name): Likewise.
(vr_values::extract_range_from_cond_expr): Likewise.
(vr_values::extract_range_basic): Likewise.
(compare_ranges): Take const value_range *, adjust.
(compare_range_with_value): Likewise.
(vrp_valueize): Adjust.
(vrp_valueize_1): Likewise.
(vr_values::get_vr_for_comparison): Return a const value_range *.
(vr_values::compare_name_with_value): Adjust.
(vr_values::compare_names): Likewise.
(vr_values::vrp_evaluate_conditional_warnv_with_ops_using_ranges):
Likewise.
(vr_values::vrp_evaluate_conditional): Likewise.
(find_case_label_ranges): Take a const value_range *.
(vr_values::vrp_visit_switch_stmt): Adjust.
(vr_values::extract_range_from_phi_node): Likewise.
(vr_values::simplify_div_or_mod_using_ran): Likewise.
(vr_values::simplify_abs_using_ranges): Likewise.
(test_for_singularity): Take a const value_range *.
(range_fits_type_p): Likewise.
(vr_values::simplify_cond_using_ranges_1): Adjust.
(vr_values::simplify_cond_using_ranges_2): Likewise.
(vr_values::simplify_switch_using_ranges): Likewise.
(vr_values::simplify_float_conversion_usi): Likewise.
(vr_values::two_valued_val_range_p): Likewise.
* vr-values.h (vr_values::get_value_range): Return a const
value_range *.
(vr_values::set_def_to_varying): New.
(vr_values::get_lattice_entry): New private method.
(vr_values::get_vr_for_comparison): Return a const value_range *.

From-SVN: r273792

5 years agoExtend DCE to remove unnecessary new/delete-pairs (PR c++/23383).
Martin Liska [Thu, 25 Jul 2019 09:36:38 +0000 (11:36 +0200)]
Extend DCE to remove unnecessary new/delete-pairs (PR c++/23383).

2019-07-25  Martin Liska  <mliska@suse.cz>
    Dominik Infuhr  <dominik.infuehr@theobroma-systems.com>

PR c++/23383
* common.opt: Add -fallocation-dce
* gimple.c (gimple_call_operator_delete_p): New.
* gimple.h (gimple_call_operator_delete_p): Likewise.
* tree-core.h (enum function_decl_type): Add OPERATOR_DELETE.
* tree-ssa-dce.c (mark_stmt_if_obviously_necessary): Handle
DECL_IS_OPERATOR_DELETE_P.
(mark_all_reaching_defs_necessary_1): Likewise.
(propagate_necessity): Likewise.
(eliminate_unnecessary_stmts): Handle
gimple_call_operator_delete_p.
* tree-streamer-in.c (unpack_ts_function_decl_value_fields):
Add packing of OPERATOR_DELETE.
* tree-streamer-out.c (pack_ts_function_decl_value_fields):
Similarly here.
* tree.h (DECL_IS_OPERATOR_DELETE_P): New.
(DECL_SET_IS_OPERATOR_DELETE): New.
(DECL_IS_REPLACEABLE_OPERATOR_NEW_P): Likewise.
2019-07-25  Martin Liska  <mliska@suse.cz>
    Dominik Infuhr  <dominik.infuehr@theobroma-systems.com>

PR c++/23383
* c-decl.c (merge_decls): Merge OPERATOR_DELETE flag.
2019-07-25  Martin Liska  <mliska@suse.cz>
    Dominik Infuhr  <dominik.infuehr@theobroma-systems.com>

PR c++/23383
* decl.c (cxx_init_decl_processing): Mark delete operators
with DECL_SET_IS_OPERATOR_DELETE.
2019-07-25  Martin Liska  <mliska@suse.cz
    Dominik Infuhr  <dominik.infuehr@theobroma-systems.com>

PR c++/23383
* g++.dg/cpp1y/new1.C: New test.
2019-07-25  Martin Liska  <mliska@suse.cz>
    Dominik Infuhr  <dominik.infuehr@theobroma-systems.com>

PR c++/23383
* testsuite/ext/bitmap_allocator/check_delete.cc: Add
-fno-allocation-dce.
* testsuite/ext/bitmap_allocator/check_new.cc: Likewise.
* testsuite/ext/new_allocator/check_delete.cc: Likewise.
* testsuite/ext/new_allocator/check_new.cc: Likewise.

Co-Authored-By: Dominik Infuehr <dominik.infuehr@theobroma-systems.com>
From-SVN: r273791

5 years agoCome up with function_decl_type and use it in tree_function_decl.
Martin Liska [Thu, 25 Jul 2019 09:36:19 +0000 (11:36 +0200)]
Come up with function_decl_type and use it in tree_function_decl.

2019-07-25  Martin Liska  <mliska@suse.cz>

* calls.c (maybe_warn_alloc_args_overflow): Use new macros
(e.g. DECL_SET_LAMBDA_FUNCTION and DECL_LAMBDA_FUNCTION_P).
* coverage.c (coverage_begin_function): Likewise.
* fold-const.c (tree_expr_nonzero_warnv_p): Likewise.
* gimple.c (gimple_call_nonnull_result_p): Likewise.
* ipa-icf.c (sem_item::compare_referenced_symbol_properties): Likewise.
(sem_item::hash_referenced_symbol_properties): Likewise.
* lto-streamer-out.c (hash_tree): Likewise.
* predict.c (expr_expected_value_1): Likewise.
* tree-inline.c (expand_call_inline): Likewise.
* tree-streamer-in.c (unpack_ts_function_decl_value_fields): Likewise.
* tree-streamer-out.c (pack_ts_function_decl_value_fields): Likewise.
* tree-core.h (enum function_decl_type): New enum.
(struct tree_function_decl): Remove operator_new_flag and lambda_function.
* tree.h (FUNCTION_DECL_DECL_TYPE): New.
(set_function_decl_type): Likewise.
(DECL_IS_OPERATOR_NEW_P): New.
(DECL_SET_IS_OPERATOR_NEW): Likewise.
(DECL_LAMBDA_FUNCTION): Likewise.
(DECL_LAMBDA_FUNCTION_P): Likewise.
(DECL_IS_OPERATOR_NEW): Remove.
(DECL_SET_LAMBDA_FUNCTION): Likewise.
2019-07-25  Martin Liska  <mliska@suse.cz>

* c-decl.c (merge_decls): Use new macros
(e.g. DECL_SET_LAMBDA_FUNCTION and DECL_LAMBDA_FUNCTION_P).
2019-07-25  Martin Liska  <mliska@suse.cz>

* decl.c (duplicate_decls): Use new macros
(e.g. DECL_SET_LAMBDA_FUNCTION and DECL_LAMBDA_FUNCTION_P).
(cxx_init_decl_processing): Likewise.
(grok_op_properties): Likewise.
* parser.c (cp_parser_lambda_declarator_opt): Likewise.
2019-07-25  Martin Liska  <mliska@suse.cz>

* lto-common.c (compare_tree_sccs_1): Use new macros
(e.g. DECL_SET_LAMBDA_FUNCTION and DECL_LAMBDA_FUNCTION_P).

From-SVN: r273790

5 years agoGeneralize get_most_common_single_value to return n_th value & count
Xiong Hu Luo [Thu, 25 Jul 2019 09:20:13 +0000 (09:20 +0000)]
Generalize get_most_common_single_value to return n_th value & count

Currently get_most_common_single_value could only return the max hist
<value, count>, add sort after reading from disk, then it return nth value
in later use.  Rename it to get_nth_most_common_value.

gcc/ChangeLog:

2019-07-15  Xiong Hu Luo  <luoxhu@linux.ibm.com>

* ipa-profile.c (get_most_common_single_value): Use
get_nth_most_common_value.
* profile.c (sort_hist_value): New function.
(compute_value_histograms): Call sort_hist_value to sort the
values after loading from disk.
* value-prof.c (get_most_common_single_value): Rename to ...
get_nth_most_common_value.  Add input params n, return
the n_th value and count.
(gimple_divmod_fixed_value_transform): Use
get_nth_most_common_value.
(gimple_ic_transform): Likewise.
(gimple_stringops_transform): Likewise.
* value-prof.h (get_most_common_single_value): Add input params
n, default to 0.

From-SVN: r273789

5 years agore PR testsuite/91245 (gnat.dg/float_value1.adb FAILs)
Eric Botcazou [Thu, 25 Jul 2019 08:01:20 +0000 (08:01 +0000)]
re PR testsuite/91245 (gnat.dg/float_value1.adb FAILs)

PR testsuite/91245
* gnat.dg/float_value1.adb: Only run on x86.

From-SVN: r273788

5 years agore PR tree-optimization/91236 (ICE in walk_non_aliased_vuses at gcc/tree-ssa-alias...
Richard Biener [Thu, 25 Jul 2019 06:57:46 +0000 (06:57 +0000)]
re PR tree-optimization/91236 (ICE in walk_non_aliased_vuses at gcc/tree-ssa-alias.c:3395 on aarch64)

2019-07-25  Richard Biener  <rguenther@suse.de>

PR tree-optimization/91236
* tree-ssa-sccvn.c (vn_walk_cb_data::push_partial_def): Fix
size of CONSTRUCTOR write.  Fix buffer size we pass to
native_encode_expr.

From-SVN: r273787

5 years agoPR tree-optimization/91183 - strlen of a strcpy result with a conditional source...
Martin Sebor [Thu, 25 Jul 2019 00:29:17 +0000 (00:29 +0000)]
PR tree-optimization/91183 - strlen of a strcpy result with a conditional source not folded

PR tree-optimization/91183 - strlen of a strcpy result with a conditional source not folded
PR tree-optimization/86688 - missing -Wstringop-overflow using a non-string local array in strnlen with excessive bound

gcc/ChangeLog:

PR tree-optimization/91183
PR tree-optimization/86688
* builtins.c (compute_objsize): Handle MEM_REF.
* tree-ssa-strlen.c (class ssa_name_limit_t): New.
(get_min_string_length): Remove.
(count_nonzero_bytes): New function.
(handle_char_store): Rename...
(handle_store): to this.  Handle multibyte stores via integer types.
(strlen_check_and_optimize_stmt): Adjust conditional and the called
function name.

gcc/testsuite/ChangeLog:

PR tree-optimization/91183
PR tree-optimization/86688
* gcc.dg/Wstringop-overflow-14.c: New test.
* gcc.dg/attr-nonstring-2.c: Remove xfails.
* gcc.dg/strlenopt-70.c: New test.
* gcc.dg/strlenopt-71.c: New test.
* gcc.dg/strlenopt-72.c: New test.
* gcc.dg/strlenopt-8.c: Remove xfails.

From-SVN: r273783

5 years agoDaily bump.
GCC Administrator [Thu, 25 Jul 2019 00:16:24 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r273782

5 years agoFix non-GNU style in previous commits
Jozef Lawrynowicz [Wed, 24 Jul 2019 21:37:29 +0000 (21:37 +0000)]
Fix non-GNU style in previous commits

2019-07-24  Jozef Lawrynowicz  <jozef.l@mittosystems.com>

* config.gcc (msp430*-*-*): Fix non-GNU style in r273774.
* config/msp430/msp430.h (ENDFILE_SPEC): Fix non-GNU style in
r273773.

From-SVN: r273775

5 years agoconfig.gcc (msp430*-*-*): Enable initfini_array by default unless explicitly disabled...
Jozef Lawrynowicz [Wed, 24 Jul 2019 21:13:54 +0000 (21:13 +0000)]
config.gcc (msp430*-*-*): Enable initfini_array by default unless explicitly disabled with...

2019-07-24  Jozef Lawrynowicz  <jozef.l@mittosystems.com>

* config.gcc (msp430*-*-*): Enable initfini_array by default unless
explicitly disabled with --disable-initfini-array.

From-SVN: r273774

5 years agomsp430.h (ENDFILE_SPEC): Wrap uses of crtn*.o in if-exists.
Jozef Lawrynowicz [Wed, 24 Jul 2019 21:08:34 +0000 (21:08 +0000)]
msp430.h (ENDFILE_SPEC): Wrap uses of crtn*.o in if-exists.

2019-07-24  Jozef Lawrynowicz  <jozef.l@mittosystems.com>

* config/msp430/msp430.h (ENDFILE_SPEC): Wrap uses of crtn*.o in
if-exists.

From-SVN: r273773

5 years agoPR driver/80545 - option -Wstringop-overflow not recognized by Fortran
Martin Sebor [Wed, 24 Jul 2019 20:34:03 +0000 (20:34 +0000)]
PR driver/80545 - option -Wstringop-overflow not recognized by Fortran

gcc/cp/ChangeLog:

PR driver/80545
* decl.c (finish_function): Use lang_mask.

gcc/testsuite/ChangeLog:

PR driver/80545
* gcc.misc-tests/help.exp: Add tests.
* lib/options.exp: Handle C++.

gcc/ChangeLog:

PR driver/80545
* diagnostic.c (diagnostic_classify_diagnostic): Use lang_mask.
(diagnostic_report_diagnostic): Same.
* diagnostic.h (diagnostic_context::option_enabled): Add an argument.
(diagnostic_context::lang_mask): New data member.
* ipa-pure-const.c (suggest_attribute): Use
lang_hooks.option_lang_mask ().
* opts-common.c (option_enabled): Handle new argument.
(get_option_state): Pass an additional argument.
* opts.c (print_filtered_help): Print supported languages for
unsupported options.  Adjust printing of current state.
* opts.h (option_enabled): Add argument.
* toplev.c (print_switch_values): Use lang_mask.
(general_init): Set global_dc->lang_mask.

From-SVN: r273771

5 years ago[Darwin] Partial reversion of 273749.
Iain Sandoe [Wed, 24 Jul 2019 19:59:22 +0000 (19:59 +0000)]
[Darwin] Partial reversion of 273749.

We still need to cater for pr80556, for the single-arch case.

2019-07-24  Iain Sandoe  <iain@sandoe.co.uk>

gcc/

PR bootstrap/87030
* config/i386/darwin.h (REAL_LIBGCC_SPEC): Revert r273749.

From-SVN: r273768

5 years agocgraphunit.c (symbol_table::compile): Start and stop TV_CGRAPH_IPA_PASSES and TV_CGRA...
Giuliano Belinassi [Wed, 24 Jul 2019 19:10:36 +0000 (19:10 +0000)]
cgraphunit.c (symbol_table::compile): Start and stop TV_CGRAPH_IPA_PASSES and TV_CGRAPH_FUNC_EXPANSION timers.

* cgraphunit.c (symbol_table::compile): Start and stop
TV_CGRAPH_IPA_PASSES and TV_CGRAPH_FUNC_EXPANSION timers.
* timevar.def (TV_CGRAPH_IPA_PASSES, TV_CGRAPH_FUNC_EXPANSION): New.

From-SVN: r273767

5 years agogimplify.c (flag_instrument_functions_exclude_p): Include namespace/class information...
Oliver Browne [Wed, 24 Jul 2019 18:08:51 +0000 (18:08 +0000)]
gimplify.c (flag_instrument_functions_exclude_p): Include namespace/class information in the printable name.

* gimplify.c (flag_instrument_functions_exclude_p): Include
namespace/class information in the printable name.
* opts.c (add_comma_separated_to_vector): Add NUL terminator
to tokens entered into the vector.

From-SVN: r273766

5 years agotree-nested.c (build_simple_mem_ref_notrap): New function.
Eric Botcazou [Wed, 24 Jul 2019 15:29:34 +0000 (15:29 +0000)]
tree-nested.c (build_simple_mem_ref_notrap): New function.

* tree-nested.c (build_simple_mem_ref_notrap): New function.
(get_static_chain): Call it instead of build_simple_mem_ref.
(get_frame_field): Likewise.
(get_nonlocal_debug_decl): Likewise.
(convert_nonlocal_reference_op): Likewise.

From-SVN: r273763

5 years ago[ARC] Fix and refurbish the interrupts.
Claudiu Zissulescu [Wed, 24 Jul 2019 12:21:38 +0000 (14:21 +0200)]
[ARC] Fix and refurbish the interrupts.

When entering an interrupt, not only the call save registers needs to
be place on stack but also the call clobbers one. More over, the
ARC700 return from interrupt instruction needs to be rtie, the same
like ARCv2 CPUs. While the ARC6xx family uses j.f [ilinkX]
instruction. Additionally, we need to save the state of the ZOL
machinery, namely the lp_count, lp_end and lp_start registers. For
architectures which are using extension registers (i.e., HS48) we need
to save/restore them as well.

gcc/
xxxx-xx-xx  Claudiu Zissulescu  <claziss@synopsys.com>

* config/arc/arc-protos.h (arc_output_function_epilogue): Delete
declaration.
(arc_compute_frame_size): Millicode is disabled when compiling
ISR.
(arc_return_address_register): Likewise.
(arc_compute_function_type): Likewise.
(arc_compute_frame_size): Likewise.
(secondary_reload_info): Likewise.
(arc_get_unalign): Likewise.
(arc_can_use_return_insn): Declare.
* config/arc/arc.c (AUX_LP_START): Define
(AUX_LP_END): Likewise.
(arc_frame_info): Update gmask member to 64-bit datum.
(GMASK_LEN): Update.
(arc_compute_function_type): Make it static, move it forward.
(arc_must_save_register): Update, consider the extra regs.
(arc_compute_millicode_save_restore_regs): Update to use the 64
bit gmask.
(arc_compute_frame_size): Likewise.
(arc_enter_leave_p): Likewise.
(arc_save_callee_saves): Likewise.
(arc_restore_callee_saves): Likewise.
(arc_save_callee_enter): Likewise.
(arc_restore_callee_leave): Likewise.
(arc_save_callee_milli): Likewise.
(arc_restore_callee_milli): Likewise.
(arc_expand_prologue): Add new interrupt handling.
(arc_return_address_register): Make it static, move it forward.
(arc_expand_epilogue): Add new interrupt handling.
(arc_get_unalign): Delete.
(arc_epilogue_uses): Make sure we do not remove the extra
saved/restored registers when interrupt.
(arc_can_use_return_insn): New function.
(push_reg): Likewise.
(pop_reg): Likewise.
(arc_save_callee_saves): Add ZOL and FPX aux registers saving
procedures.
(arc_restore_callee_saves): Likewise, but restoring.
* config/arc/arc.md (VUNSPEC_ARC_ARC600_RTIE): Define.
(R33_REG): Likewise.
(R34_REG): Likewise.
(R35_REG): Likewise.
(R36_REG): Likewise.
(R37_REG): Likewise.
(R38_REG): Likewise.
(R39_REG): Likewise.
(R45_REG): Likewise.
(R46_REG): Likewise.
(R47_REG): Likewise.
(R48_REG): Likewise.
(R49_REG): Likewise.
(R50_REG): Likewise.
(R51_REG): Likewise.
(R52_REG): Likewise.
(R53_REG): Likewise.
(R54_REG): Likewise.
(R55_REG): Likewise.
(R56_REG): Likewise.
(R58_REG): Likewise.
(type): Add rtie attribute.
(in_call_delay_slot): Use RETURN_ADDR_REGNUM.
(movsi_insn): Accept moves to lp_count.
(rtie): Update pattern.
(simple_return): Simplify it, don't use this pattern as a return
from an interrupt.
(arc600_rtie): New pattern.
(p_return_i): Clean up.
(return): Likewise.
* config/arc/builtins.def (rtie): Only available for non ARC6xx
family CPUs.
* config/arc/predicates.md (move_src_operand): Consider lp_count
as a register.

gcc/testsuite
xxxx-xx-xx  Claudiu Zissulescu  <claziss@synopsys.com>

* gcc.target/arc/arc.exp (check_effective_target_accregs): New
predicate.
* gcc.target/arc/builtin_special.c: Update test/
* gcc.target/arc/interrupt-1.c: Likewise.
* gcc.target/arc/interrupt-10.c: New test.
* gcc.target/arc/interrupt-11.c: Likewise.
* gcc.target/arc/interrupt-12.c: Likewise.

update

From-SVN: r273761

5 years agoS/390: Add add/sub/mul overflow check patterns
Andreas Krebbel [Wed, 24 Jul 2019 11:27:56 +0000 (11:27 +0000)]
S/390: Add add/sub/mul overflow check patterns

This patch implements the addv, subv, and mulv patterns for signed
integers.

gcc/ChangeLog:

2019-07-24  Andreas Krebbel  <krebbel@linux.ibm.com>

* config/s390/predicates.md (addv_const_operand): New predicate.
* config/s390/s390-modes.def (CCO): New condition code mode.
* config/s390/s390.c (s390_match_ccmode_set): Handle E_CCOmode.
(s390_branch_condition_mask): Likewise.
* config/s390/s390.md ("addv<mode>4", "subv<mode>4")
("mulv<mode>4"): New expanders.
("*addv<mode>3_ccoverflow", "*addv<mode>3_ccoverflow_const")
("*subv<mode>3_ccoverflow", "*mulv<mode>3_ccoverflow"): New
pattern definitions.

gcc/testsuite/ChangeLog:

2019-07-24  Andreas Krebbel  <krebbel@linux.ibm.com>

* gcc.target/s390/addsub-signed-overflow-1.c: New test.
* gcc.target/s390/addsub-signed-overflow-2.c: New test.
* gcc.target/s390/mul-signed-overflow-1.c: New test.
* gcc.target/s390/mul-signed-overflow-2.c: New test.

From-SVN: r273759

5 years agore PR middle-end/91166 ([SVE] Unfolded ZIPs of constants)
Prathamesh Kulkarni [Wed, 24 Jul 2019 07:20:24 +0000 (07:20 +0000)]
re PR middle-end/91166 ([SVE] Unfolded ZIPs of constants)

2019-07-24  Prathamesh Kulkarni  <prathamesh.kulkarni@linaro.org>

PR middle-end/91166
* match.pd (vec_perm_expr(v, v, mask) -> v): New pattern.
(define_predicates): Add entry for uniform_vector_p.
(vec_same_elem_p): New match pattern.

testsuite/
* gcc.target/aarch64/sve/pr91166.c: New test.

From-SVN: r273758

5 years agoFix off-by-one in simple-object-elf.c (PR lto/91228).
Martin Liska [Wed, 24 Jul 2019 07:00:48 +0000 (09:00 +0200)]
Fix off-by-one in simple-object-elf.c (PR lto/91228).

2019-07-24  Martin Liska  <mliska@suse.cz>

PR lto/91228
* simple-object-elf.c (simple_object_elf_copy_lto_debug_sections):
Find first '\0' starting from gnu_lto + 1.

From-SVN: r273757

5 years agoFixup ChangeLog entry for revision 273570.
Bin Cheng [Wed, 24 Jul 2019 01:40:59 +0000 (01:40 +0000)]
Fixup ChangeLog entry for revision 273570.

From-SVN: r273756

5 years agoDaily bump.
GCC Administrator [Wed, 24 Jul 2019 00:16:23 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r273753

5 years ago[Darwin] Fix PR87030 add missed commit hunks.
Iain Sandoe [Tue, 23 Jul 2019 23:20:31 +0000 (23:20 +0000)]
[Darwin] Fix PR87030 add missed commit hunks.

Messed up the commit, and missed changes to gcc/config.gcc and to the comments
in some of the headers.

2019-07-24  Iain Sandoe  <iain@sandoe.co.uk>

gcc/

PR bootstrap/87030
* config/i386/darwin.h (REAL_LIBGCC_SPEC): Move from here...
* config/i386/darwin32-biarch.h .. to here.
* config/i386/darwin64-biarch.h: Adjust comments.
* config/rs6000/darwin32-biarch.h: Likewise.
* config/rs6000/darwin64-biarch.h: Likewise.
* config.gcc: Missed commit from r273746
(*-*-darwin*): Don't include CPU t-darwin here.
(i[34567]86-*-darwin*): Adjust to use biarch files. Produce
an error message if i686-darwin configuration is attempted for
Darwin >= 18.

From-SVN: r273749

5 years agore PR fortran/54072 (BOZ with -std=f2008: wrongly accepted to TRANSFER/ABS/...; two...
Steven G. Kargl [Tue, 23 Jul 2019 23:02:07 +0000 (23:02 +0000)]
re PR fortran/54072 (BOZ with -std=f2008: wrongly accepted to TRANSFER/ABS/...; two BOZ not rejected for IOR/IEOR/IAND)

2019-07-23  Steven G. Kargl  <kargl@gcc.gnu.org>

 PR fortran/54072
 * check.c (gfc_invalid_boz): Fix comment.
 (illegal_boz_arg): New function.
 (gfc_check_transfer): Use to arguments.
 (gfc_check_storage_size): Ditto.
 (gfc_check_complex): Remove leftover comment from BOZ patch.
 * primary.c (match_boz_constant): Remove leftover comment.

2019-07-23  Steven G. Kargl  <kargl@gcc.gnu.org>

 PR fortran/54072
 * gfortran.dg/illegal_boz_arg_1.f90: New tests.

From-SVN: r273748

5 years agoarith.c (gfc_convert_integer, [...]): Move to ...
Steven G. Kargl [Tue, 23 Jul 2019 21:43:21 +0000 (21:43 +0000)]
arith.c (gfc_convert_integer, [...]): Move to ...

2019-07-23  Steven G. Kargl  <kargl@gcc.gnu.org>

* arith.c (gfc_convert_integer, gfc_convert_real, gfc_convert_complex):
Move to ...
* primary.c (convert_integer, convert_real, convert_complex): ... here.
Rename and make static functions.
(match_integer_constant): Use convert_integer
(match_real_constant): Use convert_real.
(match_complex_constant: Use convert_complex.
* arith.h (gfc_convert_integer, gfc_convert_real, gfc_convert_complex):
Remove prototypes.
* array.c (match_array_cons_element): A BOZ cannot be a data
statement value.  Jump to a common exit point.
* check.c (gfc_invalid_boz): New function.  Emit error or warning
for a BOZ in an invalid context.
(boz_args_check): Move to top of file to prevent need of forward
declaration.
(is_boz_constant): New function.  Check that BOZ expr is constant.
(gfc_b z2real): New function. In-place conversion of BOZ literal
constant to REAL in accordance to F2018.
(gfc_boz2int): New function. In-place conversion of BOZ literal
  onstant to INTEGER in accordance to F2018.
(gfc_check_achar, gfc_check_char, gfc_check_float): Use gfc_invalid_boz.
Convert BOZ as needed.
(gfc_check_bge_bgt_ble_blt): Enforce F2018 requirements on BGE,
BGT, BLE, and BLT intrinsic functions.
(gfc_check_cmplx): Re-organize to check kind, if present, first.
Convert BOZ real and/or imaginary parts as needed in accordance to
F2018.
(gfc_check_complex):  Use gfc_invalid_boz.  Convert BOZ as needed.
(gfc_check_dcmplx, gfc_check_dble ): Convert BOZ as needed.
(gfc_check_dshift):  Make dshift[lr] conform to F2018 standard.
 gfc_check_float (gfc_expr *a)
(gfc_check_iand_ieor_ior):  Make IAND, IEOR, and IOR conform to
F2018 standard.
(gfc_check_int): Conform to F2018 standard.
(gfc_check_intconv): Deprecate SHORT and LONG aliases for INT2 and
INT.  Simply return for a BOZ argument. See gfc_simplify_intconv.
(gfc_check_merge_bits): Make MERGE_BITS conform to Fortran 2018
standard.
(gfc_check_real): Remove incorrect comment. Check kind, if present,
first.  Simply return for a BOZ argument. See gfc_simplify_real.
(gfc_check_and): Re-do error handling for BOZ arguments.  Remove
special casing ts.type != BT_INTEGER or BT_LOGICAL.
* decl.c (match_old_style_init): Check for BOZ in old-style
initialization.  Issue error or warning depending on
-fallow-invalid-boz option.  Issue error if variable is not an
INTEGER or REAL and the value is BOZ.
* expr.c (gfc_copy_expr): Copy a BT_BOZ gfc_expr.
(gfc_check_assign): Re-do error handling for a BOZ in an assignment
statement.  Do in-place conversion of RHS based on LHS type of
INTEGER or REAL.
* gfortran.h (gfc_expr): Add a boz component.  Remove is_boz component.
(gfc_boz2int, gfc_boz2real, gfc_invalid_boz): New prototypes.
* interface.c (gfc_extend_assign): Guard against replacing an
intrinsic involving a BOZ literal constant on RHS.
* invoke.texi: Doument -fallow-invalid-boz.
* lang.opt: New option. -fallow-invalid-boz.
* libgfortran.h (bt): Elevate BOZ to a basic type.
* misc.c (gfc_basic_typename, gfc_typename): Translate BT_BOZ to BOZ.
* primary.c (convert_integer, convert_real, convert_complex): to here.
Rename and make static functions.
* primary.c(match_boz_constant): Rewrite parsing of a BOZ. Re-do
error handling.  Deprecate 'X' for hexidecimal and postfix notation.
Use -fallow-invalid-boz and gfc_invalid_boz to accept deprecated code.
* resolve.c (resolve_ordinary_assign): Rework a RHS that is a
BOZ literal constant.  Use gfc_invalid_boz to allow previous
nonstandard behavior.  Remove range checking of BOZ conversion.
* simplify.c (convert_boz): Remove function.
(simplify_cmplx): Remove conversion of BOZ constants, because
conversion is done in gfc_check_cmplx.
(gfc_simplify_float): Remove conversion of BOZ constant, because
conversion is done in gfc_check_float.
(simplify_intconv): Use gfc_boz2int to convert BOZ to INTEGER.
Remove range checking for BOZ conversion.
(gfc_simplify_real): Use k, if present, to determine kind.  Convert
BOZ to REAL.  Remove range checking for BOZ conversion.
target-memory.c (gfc_convert_boz): Rewrite to deal with convert of
a BOZ to a REAL value.

2019-07-23  Steven G. Kargl  <kargl@gcc.gnu.org>

* gfortran.dg/achar_5.f90: Fix for new BOZ handling.
* arithmetic_overflow_1.f90: Ditto.
* gfortran.dg/boz_11.f90: Ditto.
* gfortran.dg/boz_12.f90: Ditto.
* gfortran.dg/boz_4.f90: Ditto.
* gfortran.dg/boz_5.f90: Ditto.
* gfortran.dg/boz_6.f90: Ditto.
* gfortran.dg/boz_7.f90: Ditto.
* gfortran.dg/boz_8.f90: Ditto.
* gfortran.dg/dec_structure_6.f90: Ditto.
* gfortran.dg/dec_union_1.f90: Ditto.
* gfortran.dg/dec_union_2.f90: Ditto.
* gfortran.dg/dec_union_5.f90: Ditto.
* gfortran.dg/dshift_3.f90: Ditto.
* gfortran.dg/gnu_logical_2.f90: Ditto.
* gfortran.dg/int_conv_1.f90: Ditto.
* gfortran.dg/ishft_1.f90: Ditto.
* gfortran.dg/nan_4.f90: Ditto.
* gfortran.dg/no_range_check_3.f90: Ditto.
* gfortran.dg/pr16433.f: Ditto.
* gfortran.dg/pr44491.f90: Ditto.
* gfortran.dg/pr58027.f90: Ditto.
* gfortran.dg/pr81509_2.f90: Ditto.
* gfortran.dg/unf_io_convert_1.f90: Ditto.
* gfortran.dg/unf_io_convert_2.f90: Ditto.
* gfortran.fortran-torture/execute/intrinsic_fraction_exponent.f90:
Ditto.
* gfortran.fortran-torture/execute/intrinsic_mvbits.f90: Ditto.
* gfortran.fortran-torture/execute/intrinsic_nearest.f90: Ditto.
* gfortran.fortran-torture/execute/seq_io.f90: Ditto.
* gfortran.dg/gnu_logical_1.F: Delete test.
* gfortran.dg/merge_bits_3.f90: New test.
* gfortran.dg/merge_bits_3.f90: Ditto.
* gfortran.dg/boz_int.f90: Ditto.
* gfortran.dg/boz_bge.f90: Ditto.
* gfortran.dg/boz_complex_1.f90: Ditto.
* gfortran.dg/boz_complex_2.f90: Ditto.
* gfortran.dg/boz_complex_3.f90: Ditto.
* gfortran.dg/boz_dble.f90: Ditto.
* gfortran.dg/boz_dshift_1.f90: Ditto.
* gfortran.dg/boz_dshift_2.f90: Ditto.
* gfortran.dg/boz_float_1.f90: Ditto.
* gfortran.dg/boz_float_2.f90: Ditto.
* gfortran.dg/boz_float_3.f90: Ditto.
* gfortran.dg/boz_iand_1.f90: Ditto.
* gfortran.dg/boz_iand_2.f90: Ditto.

2019-07-23  Steven G. Kargl  <kargl@gcc.gnu.org>

* testsuite/libgomp.fortran/reduction4.f90: Update BOZ usage
* testsuite/libgomp.fortran/reduction5.f90: Ditto.

From-SVN: r273747

5 years ago[Darwin] Fix PR87030 and tidy config fragments.
Iain Sandoe [Tue, 23 Jul 2019 20:31:26 +0000 (20:31 +0000)]
[Darwin] Fix PR87030 and tidy config fragments.

This is about 32/64b host and multilib support across the range of Darwin
systems.

Prior to Darwin8 (OS X 10.4), the toolchains support only PowerPC and only 32b.

On Darwin8 it is possible to target a 64b multilib, but with support limited
to a few of the main libraries on the system (not a recommended configuration).

From Darwin9 to Darwin17 (OSX 10.5 to 10.13) it is possible to have either
32 or 64b hosted toolchains, with support for a 64 or 32b multilib respectively.

On Darwin9 the kernel is 32b, but with support for 64b executables, so it's
conventional to build a 32b host toolchain supporting a 64b multilib.  However
this is not enforced (merely a convention).

There is also some platform hardware supporting Darwin10/11 which is only 32b
and for which the same situation applies.  However, from Darwin10 to Darwin17,
the majority of platform hardware supports a 64b kernel and it's conventional
to build a 64b host toolchain with support for a 32b multilib.

On/from Darwin18 (OS X 10.14), the development headers (in the SDK) no longer
expose the interfaces for the 32b multilib support (although sufficient runtime
support remains installed that the testsuite can be run for a 32b multilib).

The PR is raised against this latter situation since the absence of exposed
interfaces causes a 'default' bootstrap fail regardless of the availability of
the runtimes.  Given the number of permutations, I felt it warranted a general
solution, especially since the current scheme of target headers and t-make
fragments has become somewhat messy.

The changes here enforce the single 32b PowerPC multilib for Darwin < 8 and the
single X86 64b multilib for Darwin >= 18.  This means that there is no longer
any need to configure Darwin18+ '--disable-multilib', but also that if you want
to use the ability to continue to test the compiler's 32b multilib there, you
need to make a configuration targeting an earlier OS version (and using the
SDK from that).

gcc/

PR bootstrap/87030
* config.gcc (*-*-darwin*): Don't include CPU t-darwin here.
(i[34567]86-*-darwin*): Adjust to use biarch files. Produce
an error message if i686-darwin configuration is attempted for
Darwin >= 18.
(x86_64-*-darwin*): Switch to single multilib for Darwin >= 18.
(powerpc-*-darwin*): Use biarch files where needed.
(powerpc64-*-darwin*): Likewise.
* config/i386/darwin.h (REAL_LIBGCC_SPEC): Move to new biarch file.
(DARWIN_ARCH_SPEC, DARWIN_SUBARCH_SPEC): Revise for default single
arch case.
* config/i386/darwin32-biarch.h: New.
* config/i386/darwin64.h: Rename.
* gcc/config/i386/darwin64-biarch.h: To this.
* config/i386/t-darwin: Rename.
* gcc/config/i386/t-darwin32-biarch: To this.
* config/i386/t-darwin64: Rename.
* gcc/config/i386/t-darwin64-biarch: To this.
* config/rs6000/darwin32-biarch.h: New.
* config/rs6000/darwin64.h: Rename.
* config/rs6000/darwin64-biarch.h: To this.
(DARWIN_ARCH_SPEC, DARWIN_SUBARCH_SPEC): Revise for default single
arch case.
* config/rs6000/t-darwin8: Rename.
* config/rs6000/t-darwin32-biarch: To this.
* config/rs6000/t-darwin64 Rename.
* config/rs6000/t-darwin64-biarch: To this.

From-SVN: r273746

5 years agoAdd PR markers to recent DSE changes. And...
Jeff Law [Tue, 23 Jul 2019 20:05:48 +0000 (14:05 -0600)]
Add PR markers to recent DSE changes.  And...

PR tree-optimization/86061
* gcc.dg/tree-ssa/pr86061.c: New test.

From-SVN: r273745

5 years agocompiler: use correct value type in 2-case select send
Ian Lance Taylor [Tue, 23 Jul 2019 17:20:36 +0000 (17:20 +0000)]
compiler: use correct value type in 2-case select send

    In the channel-send case, the value to be sent may needs an
    (implicit) type conversion to the channel element type. This CL
    ensures that we use the correct value type for the send.

    Fixes golang/go#33235.

    Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/187177

From-SVN: r273743

5 years agoconfigure.ac (ACX_PROG_CXX_WARNING_OPTS): Revert r273311.
Martin Sebor [Tue, 23 Jul 2019 17:03:13 +0000 (17:03 +0000)]
configure.ac (ACX_PROG_CXX_WARNING_OPTS): Revert r273311.

gcc/ChangeLog:
* configure.ac (ACX_PROG_CXX_WARNING_OPTS): Revert r273311.

From-SVN: r273742

5 years agogdbinit.in: add reload-gdbhooks (rh) command
Vladislav Ivanishin [Tue, 23 Jul 2019 14:05:14 +0000 (14:05 +0000)]
gdbinit.in: add reload-gdbhooks (rh) command

gcc/ChangeLog:

2019-07-23  Vladislav Ivanishin <vlad@ispras.ru>

* gdbinit.in (reload-gdbhooks): New command with an attached doc string.
(rh): New alias for it.

From-SVN: r273738

5 years agomake gdbhooks.py idempotent with respect to reloading
Vladislav Ivanishin [Tue, 23 Jul 2019 13:57:43 +0000 (13:57 +0000)]
make gdbhooks.py idempotent with respect to reloading

gcc/ChangeLog:

2019-07-23  Vladislav Ivanishin <vlad@ispras.ru>

* gdbhooks.py: Pass replace=True to
gdb.printing.register_pretty_printer.

From-SVN: r273737

5 years agore PR debug/91231 (ICE in dwarf2out_inline_entry, at dwarf2out.c:27642)
Richard Biener [Tue, 23 Jul 2019 10:45:59 +0000 (10:45 +0000)]
re PR debug/91231 (ICE in dwarf2out_inline_entry, at dwarf2out.c:27642)

2019-07-23  Richard Biener  <rguenther@suse.de>

PR debug/91231
* lto-streamer-in.c (input_function): Drop inline-entry markers
that ended up with an unknown location block.

From-SVN: r273733

5 years agore PR tree-optimization/83518 (Missing optimization: useless instructions should...
Richard Biener [Tue, 23 Jul 2019 10:00:24 +0000 (10:00 +0000)]
re PR tree-optimization/83518 (Missing optimization: useless instructions should be dropped)

2019-07-23  Richard Biener  <rguenther@suse.de>

PR tree-optimization/83518
* tree-ssa-sccvn.c (vn_reference_lookup_3): Handle aggregate
init from a constant even when partial defs are already recorded.

c/
* gimple-parser.c (c_parser_parse_gimple_body): When we have
a CFG also rebuild cgraph edges.

* gcc.dg/tree-ssa/ssa-fre-79.c: New testcase.

From-SVN: r273732

5 years agoi386-common.c: Use PROCESSOR_ZNVER2 scheduler for znver2.
Jan Hubicka [Tue, 23 Jul 2019 09:38:49 +0000 (11:38 +0200)]
i386-common.c: Use PROCESSOR_ZNVER2 scheduler for znver2.

* i386-common.c: Use PROCESSOR_ZNVER2 scheduler for znver2.
* config/i386/znver1.md: Enable patterns for znver2 and add store
variants which use extra AGU unit.

From-SVN: r273731

5 years agoi386-options.c (ix86_option_override_internal): Default PARAM_AVOID_FMA_MAX_BITS...
Jan Hubicka [Tue, 23 Jul 2019 09:35:18 +0000 (09:35 +0000)]
i386-options.c (ix86_option_override_internal): Default PARAM_AVOID_FMA_MAX_BITS to 256 for znver2.

* config/i386/i386-options.c (ix86_option_override_internal): Default
PARAM_AVOID_FMA_MAX_BITS to 256 for znver2.

From-SVN: r273730

5 years ago* config/i386/x86-tune.def (X86_TUNE_AVOID_256FMA_CHAINS): Set of ZNVER2.
Jan Hubicka [Tue, 23 Jul 2019 09:32:44 +0000 (11:32 +0200)]
* config/i386/x86-tune.def (X86_TUNE_AVOID_256FMA_CHAINS): Set of ZNVER2.

From-SVN: r273729

5 years agox86-tune-costs.h (znver2_memcpy): Update.
Jan Hubicka [Tue, 23 Jul 2019 09:27:11 +0000 (11:27 +0200)]
x86-tune-costs.h (znver2_memcpy): Update.

* config/i386/x86-tune-costs.h (znver2_memcpy): Update.
(znver2_costs): Update 256 bit SSE costs and multiplication.

From-SVN: r273728

5 years ago[Ada] Aspect CPU may depend on a discriminant of a task type
Ed Schonberg [Tue, 23 Jul 2019 08:13:41 +0000 (08:13 +0000)]
[Ada] Aspect CPU may depend on a discriminant of a task type

2019-07-23  Ed Schonberg  <schonberg@adacore.com>

gcc/ada/

* sem_ch13.adb (Check_Aspect_At_End_Of_Declarations,
Freeze_Entity_Checks): Include Aspect_CPU with other aspects
whose expresssion may depend on a discriminant, and thus require
that components of the type be made visible.

gcc/testsuite/

* gnat.dg/task4.adb: New testcase.

From-SVN: r273726

5 years ago[Ada] Plug small loophole in Generate_Range_Check
Eric Botcazou [Tue, 23 Jul 2019 08:13:32 +0000 (08:13 +0000)]
[Ada] Plug small loophole in Generate_Range_Check

The Generate_Range_Check routine is responsible for generating range
checks in the scalar case.  It automatically deals with possible
overflow in the process when the source and the target base types are
different.

However there is one case where overflow is not dealt with correctly,
namely when the target base type is narrower than the source base type
and both are floating-point types. In this case, the routine will
convert the source type to the target base type without checking for
overflow. In practice this does not matter much because the conversion
would yield an infinity on overflow, which would then fail the
subsequent range check. However it's more correct to have a proper
overflow check with -gnateF than relying on the infinity.

2019-07-23  Eric Botcazou  <ebotcazou@adacore.com>

gcc/ada/

* checks.adb (Convert_And_Check_Range): Add Suppress parameter
and pass it in the call to Insert_Actions.  Rename local
variable.
(Generate_Range_Check): Minor comment fixes.  Pass Range_Check
in the first call to Convert_And_Check_Range and All_Checks in
the second call.
* exp_ch4.adb (Expand_N_Type_Conversion): Reset the
Do_Overflow_Check flag in the float-to-float case too if there
is also a range check.

gcc/testsuite/

* gnat.dg/range_check5.adb: New testcase.

From-SVN: r273725

5 years ago[Ada] Eliminate redundant overflow checks for conversions from fixed-point
Eric Botcazou [Tue, 23 Jul 2019 08:13:26 +0000 (08:13 +0000)]
[Ada] Eliminate redundant overflow checks for conversions from fixed-point

This eliminates redundant overflow checks that are generated for
conversions from fixed-point to integer types when range checks are also
enabled (which is the default), as the former checks are subsumed into
the latter checks.

No functional changes.

2019-07-23  Eric Botcazou  <ebotcazou@adacore.com>

gcc/ada/

* checks.adb (Activate_Overflow_Check): Remove redundant
argument.
* exp_ch4.adb (Discrete_Range_Check): Reset the overflow flag.
(Expand_N_Type_Conversion): Do not reset it here.

From-SVN: r273724

5 years ago[Ada] Minor tweak to -gnatR output
Eric Botcazou [Tue, 23 Jul 2019 08:13:21 +0000 (08:13 +0000)]
[Ada] Minor tweak to -gnatR output

This makes sure that the numbers present in the -gnatR output are
printed in decimal format in all cases, since the hexadecimal format is
not compatible with the JSON syntax.

2019-07-23  Eric Botcazou  <ebotcazou@adacore.com>

gcc/ada/

* repinfo.adb (List_Component_Layout): Pass Decimal to UI_Write.
(Write_Val): Likewise.

From-SVN: r273723

5 years ago[Ada] Iterators are view-specific
Ed Schonberg [Tue, 23 Jul 2019 08:13:15 +0000 (08:13 +0000)]
[Ada] Iterators are view-specific

Operational aspects, such as Default_Iterator, are view-specific, and if
such an aspect appears on the full view of a private type, an object of
the type cannot be iterated upon if it is not in the scope of the full
view, This patch diagnoses properly an attempt to iterate over such an
object.

2019-07-23  Ed Schonberg  <schonberg@adacore.com>

gcc/ada/

* aspects.ads: New table Operational_Aspect, used to distinguish
between aspects that are view-specific, such as those related to
iterators, and representation aspects that apply to all views of
a type.
* aspects.adb (Find_Aspect): If the aspect being sought is
operational, do not ecamine the full view of a private type to
retrieve it.
* sem_ch5.adb (Analyze_Iterator_Specification): Improve error
message when the intended domain of iteration does not implement
the required iterator aspects.

gcc/testsuite/

* gnat.dg/iter5.adb: Add an expected error.
* gnat.dg/iter6.adb: New testcase.

From-SVN: r273722

5 years ago[Ada] Issue error on SPARK ownership rule violation
Yannick Moy [Tue, 23 Jul 2019 08:13:09 +0000 (08:13 +0000)]
[Ada] Issue error on SPARK ownership rule violation

A modified rule in SPARK RM specifies that object declarations of
anonymous access type should only occur immediately in subprogram, entry
or block. Now checked.

There is no impact on compilation.

2019-07-23  Yannick Moy  <moy@adacore.com>

gcc/ada/

* sem_spark.ads (Is_Local_Context): New function.
* sem_spark.adb (Check_Declaration): Issue errors on violations
of SPARK RM 3.10(4)
(Process_Path): Do not issue error on borrow/observe during
elaboration, as these are caught by the new rule.

From-SVN: r273721

5 years ago[Ada] Fix binding of ghost units with finalizer
Yannick Moy [Tue, 23 Jul 2019 08:13:01 +0000 (08:13 +0000)]
[Ada] Fix binding of ghost units with finalizer

Linking of an enabled ghost unit which requires a finalizer lead to an
error, as the name generated by the binder for calling the finalizer was
not the same as the name chosen by the compiler. Now fixed.

2019-07-23  Yannick Moy  <moy@adacore.com>

gcc/ada/

* exp_ch7.adb (Create_Finalizer): Force finalizer not to be
Ghost enabled.
* exp_dbug.adb (Get_External_Name): Explain special case of
Ghost finalizer.

gcc/testsuite/

* gnat.dg/ghost6.adb, gnat.dg/ghost6_pkg.ads: New testcase.

From-SVN: r273720

5 years agox86/AVX512: improve generated code for mask-to-vector-register conversions
Jan Beulich [Tue, 23 Jul 2019 08:07:49 +0000 (08:07 +0000)]
x86/AVX512: improve generated code for mask-to-vector-register conversions

Conversion of comparison results to full vectors does, when VPMOVM2* are
unavailable, not require any intermediate VMOVDQ{A,U}*: Simply use
embedded masking on VPTERNLOG* right away, which is available with
AVX512F (while VPMOVM2{D,Q} are available only with AVX512DQ).

Note that the chosen immediate is only one of many possible ones; I was
trying to make the insn here distinguishable from the pre-existing uses
of vpternlog.

gcc/
2019-07-23  Jan Beulich  <jbeulich@suse.com>

* config/i386/sse.md (<avx512>_cvtmask2<ssemodesuffix><mode>):
Require only AVX512F.
(*<avx512>_cvtmask2<ssemodesuffix><mode>): Likewise.  Add
alternative expanding to vpternlog.

From-SVN: r273719

5 years agolibiberty: Check zero value shstrndx in simple-object-elf.c
Ren Kimura [Tue, 23 Jul 2019 07:33:32 +0000 (07:33 +0000)]
libiberty: Check zero value shstrndx in simple-object-elf.c

From-SVN: r273718

5 years agoUse -flto instead of -flto=N in DWARF producer string.
Martin Liska [Tue, 23 Jul 2019 07:31:50 +0000 (09:31 +0200)]
Use -flto instead of -flto=N in DWARF producer string.

2019-07-23  Martin Liska  <mliska@suse.cz>

* dwarf2out.c (gen_producer_string): Canonize -flto=N
to -flto in dwarf producer string.

From-SVN: r273717

5 years agotree-cfg.c (label_for_bb): Remove global var.
Richard Biener [Tue, 23 Jul 2019 06:58:39 +0000 (06:58 +0000)]
tree-cfg.c (label_for_bb): Remove global var.

2019-07-23  Richard Biener  <rguenther@suse.de>

* tree-cfg.c (label_for_bb): Remove global var.
(main_block_label): Take label_for_bb as argument.
(cleanup_dead_labels_eh): Likewise, adjust.
(cleanup_dead_labels): Adjust.

From-SVN: r273716

5 years ago[rs6000] Add documentation for __builtin_mtfsf
Paul A. Clarke [Tue, 23 Jul 2019 02:54:28 +0000 (02:54 +0000)]
[rs6000] Add documentation for __builtin_mtfsf

2019-07-22  Paul A. Clarke  <pc@us.ibm.com>

[gcc]

* doc/extend.texi (Basic PowerPC Built-in Functions Available on all
Configurations): Add documentation for __builtin_mtfsf.

From-SVN: r273715

5 years agoRISC-V: Add -malign-data= option.
Ilia Diachkov [Tue, 23 Jul 2019 01:29:34 +0000 (01:29 +0000)]
RISC-V: Add -malign-data= option.

gcc/
Ilia Diachkov  <ilia.diachkov@optimitech.com>
* config/riscv/riscv-opts.h (struct riscv_align_data): New.
* config/riscv/riscv.c (riscv_constant_alignment): Use
riscv_align_data_type.
* config/riscv/riscv.h (RISCV_EXPAND_ALIGNMENT): New.
(DATA_ALIGNMENT): Use RISCV_EXPAND_ALIGNMENT.
(LOCAL_ALIGNMENT): Use RISCV_EXPAND_ALIGNMENT.
* config/riscv/riscv.opt (malign-data): New.
* doc/invoke.texi (RISC-V Options): Document -malign-data=.

From-SVN: r273714

5 years agocompiler: follow-on fix for finalizing imported methods
Ian Lance Taylor [Tue, 23 Jul 2019 00:34:38 +0000 (00:34 +0000)]
compiler: follow-on fix for finalizing imported methods

    This patch is a revision to CL 185518, which added code to perform
    finalization of methods on types created by the importer and not
    directly reachable until inlining is done.

    The original fix invoked the finalization code at the end of
    Import::read_types(), but it turns out this doesn't handle the case
    where a type with methods is read in due to a reference from something
    later in the export data (a function or variable). The fix is to move
    the import finalization call to the end of Import::import().

    Testcase for this bug is in CL 187057.

    Fixes golang/go#33219.

    Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/187058

From-SVN: r273713

5 years agoDaily bump.
GCC Administrator [Tue, 23 Jul 2019 00:16:30 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r273712

5 years agocgraph.c (dump_graphviz): New function.
Giuliano Belinassi [Mon, 22 Jul 2019 21:41:48 +0000 (21:41 +0000)]
cgraph.c (dump_graphviz): New function.

* cgraph.c (dump_graphviz): New function.
* cgraph.h (dump_graphviz): New function.
* symtab.c (dump_graphviz): New function.

* lang.opt (flag_dump_callgraph): New flag.
* lto-dump.c (dump_symtab_graphviz): New function.
(dump_tool_help): New option.
(lto_main): Handle graphviz dumping.

From-SVN: r273708

5 years agoRename testsuite directory to match P0553R4 stable names
Jonathan Wakely [Mon, 22 Jul 2019 16:57:40 +0000 (17:57 +0100)]
Rename testsuite directory to match P0553R4 stable names

* testsuite/26_numerics/bit/bitops.count/*: Rename to ...
* testsuite/26_numerics/bit/bit.count/*: Here.

From-SVN: r273707

5 years agoAdjust std::rotl, std::rotr etc to match final P0553R4 proposal
Jonathan Wakely [Mon, 22 Jul 2019 16:53:36 +0000 (17:53 +0100)]
Adjust std::rotl, std::rotr etc to match final P0553R4 proposal

This proposal has now been accepted for C++20, with a few changes. This
patch adjusts std::rotl and std::rotr to match the final specification
and declares the additions for C++2a mode even when __STRICT_ANSI__ is
defined.

* include/std/bit (__rotl, __rotr): Change second parameter from
unsigned int to int and handle negative values.
(rotl, rotr): Remove check for __STRICT_ANSI__. Change second
parameter from unsigned int to int. Add nodiscard attribute.
* testsuite/26_numerics/bit/bitops.rot/rotl.cc: Rename to ...
* testsuite/26_numerics/bit/bit.rotate/rotl.cc: Here. Test negative
shifts.
* testsuite/26_numerics/bit/bitops.rot/rotr.cc: Rename to ...
* testsuite/26_numerics/bit/bit.rotate/rotr.cc: Here. Test negative
shifts.

From-SVN: r273706

5 years agoChange std::ceil2 to be undefined if the result can't be represented
Jonathan Wakely [Mon, 22 Jul 2019 16:53:27 +0000 (17:53 +0100)]
Change std::ceil2 to be undefined if the result can't be represented

* include/std/bit (__ceil2): Make unrepresentable results undefined,
as per P1355R2. Add debug assertion. Perform one left shift, not two,
so that out of range values cause undefined behaviour. Ensure that
shift will still be undefined if left operand is promoted.
* testsuite/26_numerics/bit/bit.pow.two/ceil2.cc: Replace checks for
unrepresentable values with checks that they are not core constant
expressions.
* testsuite/26_numerics/bit/bit.pow.two/ceil2_neg.cc: New test.

From-SVN: r273705

5 years ago[aarch64]: add usra and ssra combine patterns
Sylvia Taylor [Mon, 22 Jul 2019 16:21:17 +0000 (16:21 +0000)]
[aarch64]: add usra and ssra combine patterns

This patch adds support to combine:

1) ushr and add into usra, example:

ushr    v0.16b, v0.16b, 2
add     v0.16b, v0.16b, v2.16b
---
usra    v2.16b, v0.16b, 2

2) sshr and add into ssra, example:

sshr    v1.16b, v1.16b, 2
add     v1.16b, v1.16b, v3.16b
---
ssra    v3.16b, v1.16b, 2

Committed on behalf of Sylvia Taylor <sylvia.taylor@arm.com>.
Reviewed-by: <James.greenhalgh@arm.com>
gcc/ChangeLog:

        * config/aarch64/aarch64-simd.md
        (*aarch64_simd_sra<mode>): New.
        * config/aarch64/iterators.md
        (SHIFTRT): New iterator.
        (sra_op): New attribute.

gcc/testsuite/ChangeLog:

        * gcc.target/aarch64/simd/ssra.c: New test.
        * gcc.target/aarch64/simd/usra.c: New test.

From-SVN: r273703