Stephen Toub [Wed, 21 Jul 2021 01:48:39 +0000 (21:48 -0400)]
Re-enable async method state machine clearing test (#56007)
Thays Grazia [Wed, 21 Jul 2021 01:32:42 +0000 (22:32 -0300)]
[wasm][debugger] Fix step behavior (#55915)
* Creating test to close 49143.
* Creating test to close https://github.com/dotnet/runtime/issues/49141
* Adding test for https://github.com/dotnet/runtime/issues/49218.
* Fix behavior of step to be the same of what we see when debugging using debugger-libs+mono or coreclr.
Fix error message of evaluate calling methods.
Adding test for https://github.com/dotnet/runtime/issues/49142
* Improving test to test what @radical asked.
* Changing what was suggested by @radical.
dotnet-maestro[bot] [Wed, 21 Jul 2021 01:07:25 +0000 (18:07 -0700)]
[main] Update dependencies from mono/linker (#55813)
* Update dependencies from https://github.com/mono/linker build
20210715.1
Microsoft.NET.ILLink.Tasks
From Version 6.0.100-preview.6.21362.3 -> To Version 6.0.100-preview.6.21365.1
* Update dependencies from https://github.com/mono/linker build
20210716.2
Microsoft.NET.ILLink.Tasks
From Version 6.0.100-preview.6.21362.3 -> To Version 6.0.100-preview.6.21366.2
* Suppress type hierarchy warnings
Suppress type hierarchy warnings for
DynamicallyAccessedMembers attribute on types that
have members with RequiresUnreferencedCode (or derived
types with such members).
* Feedback
Remove unnecessary local method
* Fix typo
* Update dependencies from https://github.com/mono/linker build
20210719.3
Microsoft.NET.ILLink.Tasks
From Version 6.0.100-preview.6.21362.3 -> To Version 6.0.100-preview.6.21369.3
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Sven Boemer <sbomer@gmail.com>
Kunal Pathak [Tue, 20 Jul 2021 22:23:59 +0000 (15:23 -0700)]
Handle contained BITCAST for STORE_LCL_FLD (#55852)
* Do not mark BITCAST as contained for STORE_LCL_FLD
* Add unit test
* Handle contained BITCAST in STORE_LCL_FLD
* Return 100
Stephen Toub [Tue, 20 Jul 2021 22:07:00 +0000 (18:07 -0400)]
Revert "Eliminate backtracking in the interpreter for patterns with .* (#51508)" (#56031)
This reverts commit
7eb749c8b78609865edcad67f57084aa382632a3.
Stephen Toub [Tue, 20 Jul 2021 22:06:25 +0000 (18:06 -0400)]
Revamp caching scheme in PoolingAsyncValueTaskMethodBuilder (#55955)
* Revamp caching scheme in PoolingAsyncValueTaskMethodBuilder
The current scheme caches one instance per thread in a ThreadStatic, and then has a locked stack that all threads contend on; then to avoid blocking a thread while accessing the cache, locking is done with TryEnter rather than Enter, simply skipping the cache if there is any contention. The locked stack is capped by default at ProcessorCount*4 objects.
The new scheme is simpler: one instance per thread, one instance per core. This ends up meaning fewer objects may be cached, but it also almost entirely eliminates contention between threads trying to rent/return objects. As a result, under heavy load it can actually do a better job of using pooled objects as it doesn't bail on using the cache in the face of contention. It also reduces concerns about larger machines being more negatively impacted by the caching. Under lighter load, since we don't cache as many objects, it does mean we may end up allocating a bit more, but generally not much more (and the size of the object we do allocate is a reference-field smaller).
* Address PR feedback
Sergey Andreenko [Tue, 20 Jul 2021 22:05:33 +0000 (15:05 -0700)]
Fix tizen arm32 issue. (#55987)
* Add asserts that we don't expect LONG copies on arm32.
* Fix tizen.
Natalia Kondratyeva [Tue, 20 Jul 2021 21:08:51 +0000 (23:08 +0200)]
HTTP/3 & QUIC: fix abort read on dispose and cancellation (#55724)
Fix abort on cancellation for HTTP/3 content stream, fix dispose when read was aborted by cancellation token.
Fixes #48624
FatTiger [Tue, 20 Jul 2021 20:53:46 +0000 (04:53 +0800)]
Use MethodInfo.Equals to judge equality and remove special comparator
Fix #453285
Karel Zikmund [Tue, 20 Jul 2021 20:31:55 +0000 (22:31 +0200)]
Disable test Connect_DualMode_DnsConnect_RetrievedEndPoints_Success on Linux (#56003)
Disabled test tracked by #54677 and #55709
Mateo Torres-Ruiz [Tue, 20 Jul 2021 19:38:28 +0000 (12:38 -0700)]
Set use shell execute (#56010)
Santiago Fernandez Madero [Tue, 20 Jul 2021 19:13:19 +0000 (12:13 -0700)]
Fix System.Data.SqlClient dependency version on compat pack (#55956)
Karel Zikmund [Tue, 20 Jul 2021 17:49:33 +0000 (19:49 +0200)]
Disable SendStreamLimitRequestsConcurrently_Succeeds (#56001)
Disabled test tracked by #56000
Gleb Balykov [Tue, 20 Jul 2021 17:40:19 +0000 (20:40 +0300)]
Add profile-use-only mode for MultiCoreJit (#55005)
* Add profile-use-only mode for MultiCoreJit
- memory consumption is reduced if profile is not gathered
- disk/flash life is increased if profile is not saved each time
* Remove non-set m_fAppxMode
Eric StJohn [Tue, 20 Jul 2021 17:36:08 +0000 (10:36 -0700)]
Prepare for arcade changes that enable testing of meta-packages (#55976)
Natalia Kondratyeva [Tue, 20 Jul 2021 17:21:45 +0000 (19:21 +0200)]
[QUIC] Fix cancelling shutdown completion source (#55993)
Fixes #55706
Tomas Weinfurt [Tue, 20 Jul 2021 17:20:51 +0000 (10:20 -0700)]
remove unnecessary call (#55795)
* remove unnecessary call
* fix typo
Tomas Weinfurt [Tue, 20 Jul 2021 17:07:20 +0000 (10:07 -0700)]
mitigation for quic tests hangs (#55985)
Nikita Balabaev [Tue, 20 Jul 2021 16:39:01 +0000 (18:39 +0200)]
Fix #51171: Eager validation of named options (#55922)
Karel Zikmund [Tue, 20 Jul 2021 14:58:59 +0000 (16:58 +0200)]
Disable QuicStreamTests_MsQuicProvider.ReadOutstanding_ReadAborted_Throws (#55997)
Disable test: System.Net.Quic.Tests.QuicStreamTests_MsQuicProvider.ReadOutstanding_ReadAborted_Throws
Tracked by #55948
Jan Vorlicek [Tue, 20 Jul 2021 13:51:45 +0000 (15:51 +0200)]
Fix x86 Linux build with clang < 10 (#55924)
There is a bug in clang that was fixed in version 10 and that causes
the build of the src/coreclr/vm/i386/jithelp.S to fail with
'error: cannot use more than one symbol in memory operand'.
The problem is that it doesn't support the `offset` keyword and
it thinks it is just another symbol.
The fix is to use att syntax for the offending instruction.
Stephen Toub [Tue, 20 Jul 2021 13:29:20 +0000 (09:29 -0400)]
Replace a few unnecessary uses of Convert.ToString (#55831)
* Replace a few unnecessary uses of Convert.ToString
* Update src/libraries/System.Private.Xml/src/System/Xml/Schema/ContentValidator.cs
Co-authored-by: Christopher Watford <83599748+watfordsuzy@users.noreply.github.com>
Co-authored-by: Christopher Watford <83599748+watfordsuzy@users.noreply.github.com>
Stephen Toub [Tue, 20 Jul 2021 13:28:45 +0000 (09:28 -0400)]
Fix % used in PerCoreLockedStacks (#55959)
* Fix % used in PerCoreLockedStacks
s_lockedStackCount will be a const in tier 1, and the JIT can optimize % by a const to something other than idiv.
* Address PR feedback
Andrii Kurdiumov [Tue, 20 Jul 2021 13:23:47 +0000 (19:23 +0600)]
Disable implicit imports in tools (#55828)
Alexander Nikolaev [Tue, 20 Jul 2021 13:09:01 +0000 (15:09 +0200)]
Complete Http2Stream after sending Reset or EndOfStream to server (#55835)
It changes the order of Complete and Send Reset/Send EndOfStream operations to prevent creation of a new Http2Stream while the old one has not yet written the final frame to wire.
Fixes #1586
Alexander Köplinger [Tue, 20 Jul 2021 10:14:22 +0000 (12:14 +0200)]
Cleanup iOS/Android samples to use xharness (#55926)
Instead of manually calling adb or simctl.
Tomas Weinfurt [Tue, 20 Jul 2021 03:42:04 +0000 (20:42 -0700)]
add RID for Alpine 3.14 (#55857)
Stephen Toub [Tue, 20 Jul 2021 02:44:43 +0000 (22:44 -0400)]
Update analyzer rulesets (#55925)
Eirik Tsarpalis [Tue, 20 Jul 2021 02:44:20 +0000 (05:44 +0300)]
fix discrepancy in STJ test namespaces (#55958)
David Wrighton [Tue, 20 Jul 2021 02:29:13 +0000 (19:29 -0700)]
Improve crossgen2 help text (#55977)
- Add handling of "-?" and no command line arguments.
- Print out default values for --targetos and --targetarch
- Describe behavior of response files
- Describe the behavior of the -- switch
- Describe in much greater detail the valid values for the --instruction-set switch
Fix #47486
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Karel Zikmund [Tue, 20 Jul 2021 01:44:54 +0000 (03:44 +0200)]
Disable ConnectTimeout_PlaintextStreamFilterTimesOut_Throws (#55932)
Disable test ConnectTimeout_PlaintextStreamFilterTimesOut_Throws
Disabled test tracked by #55931
Stephen Toub [Tue, 20 Jul 2021 01:18:52 +0000 (21:18 -0400)]
Revert UnicodeDebug.cs to not depend on the Debug.Assert interpolated string handler (#55954)
Turns out we use this file outside of corelib, in projects that build for pre-.NET 6, and the change was causing lots of string formatting for asserts that pass.
Larry Ewing [Tue, 20 Jul 2021 00:53:25 +0000 (19:53 -0500)]
Link with EmccCompileOptimizationFlag==-Oz by default in release (#55939)
Steve Pfister [Mon, 19 Jul 2021 20:15:37 +0000 (16:15 -0400)]
[mono] Split iOS/tvOS/MacCatalyst runtime packs into their own workload (#55851)
The ios/tvos/maccatalyst runtime packs need to be installable on Windows and as a result each need their own workload.
The microsoft-net-runtime-ios/tv/maccatalyst workloads will still function the same by extending the new runtimes-* workloads.
Bruce Forstall [Mon, 19 Jul 2021 20:03:22 +0000 (13:03 -0700)]
Add an assert concerning branch to BBJ_CALLFINALLY blocks (#55858)
In the FEATURE_EH_CALLFINALLY_THUNKS case, BBJ_CALLFINALLY blocks live
in the EH region enclosing the `try` block that needs to call the finally.
However, we need all flow to the BBJ_CALLFINALLY to come from that try block;
we don't want flow optimizations to otherwise branch directly to this
BBJ_CALLFINALLY block. Add an assert to verify this is the case. The assert
also covers the non-FEATURE_EH_CALLFINALLY_THUNKS case.
Layomi Akinrinade [Mon, 19 Jul 2021 17:22:33 +0000 (10:22 -0700)]
Switch handwritten test serializer contexts to use source generator (#55844)
Vitek Karas [Mon, 19 Jul 2021 16:54:03 +0000 (18:54 +0200)]
Fixes building Host tests from VS (#55917)
When building the Host tests projects from VS the CrossGen2 related properties are not set (probably because the build type is not set to Core - which doesn't matter for the tests).
Changed the includes to be conditional.
Andy Ayers [Mon, 19 Jul 2021 15:39:28 +0000 (08:39 -0700)]
JIT: refactor how opaque VNs are represented (#55853)
Use a unary function to capture opaque VN loop dependence, rather than factoring
that out as part of the owning chunk. As a result the VN chunk data no longer
has a per-loop component (no dependence on MAX_LOOP_NUM).
This gives us the flexibility to address #54118 by doing something similar for
`MapUpdate` VNs.
Marie Píchová [Mon, 19 Jul 2021 15:14:34 +0000 (15:14 +0000)]
disabled test (#55912)
Miha Zupan [Mon, 19 Jul 2021 14:41:13 +0000 (07:41 -0700)]
Wait for the request line before cancelling the request in EventSource_UnsuccessfulRequest_LogsStartFailedStop (#55913)
xtqqczze [Mon, 19 Jul 2021 14:39:25 +0000 (15:39 +0100)]
Delete IDE dispose analyzer rules (#55920)
The IDE dispose analyzer rules have been deleted from Roslyn:
https://github.com/dotnet/roslyn/commit/
eeba499ecf839ec35bca25062d69d2fc5c4885b9
Marie Píchová [Mon, 19 Jul 2021 14:38:30 +0000 (14:38 +0000)]
Comments from code review (#55819)
* Comments
* Update src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicStream.cs
* Update src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicStream.cs
Co-authored-by: Natalia Kondratyeva <knatalia@microsoft.com>
Co-authored-by: Natalia Kondratyeva <knatalia@microsoft.com>
Stephen Toub [Mon, 19 Jul 2021 14:37:27 +0000 (10:37 -0400)]
Fix WriteGatherAtOffset IOVector count (#55909)
Jakob Botsch Nielsen [Mon, 19 Jul 2021 08:01:44 +0000 (10:01 +0200)]
Add --debuginfo to superpmi (#55808)
Adeel Mujahid [Mon, 19 Jul 2021 07:49:06 +0000 (10:49 +0300)]
Fix mono build on illumos (#55897)
Maxim Lipnin [Mon, 19 Jul 2021 06:09:35 +0000 (09:09 +0300)]
Disable some library tests due to failures/crash (#55826)
Ankit Jain [Mon, 19 Jul 2021 05:55:28 +0000 (01:55 -0400)]
[wasm] Use compile rsp instead of link, for compiling native files (#55848)
.. and fix logging that broke recently.
`tasks/Common/Utils.cs`:
TaskLoggingHelper Utils.Logger is a static field, which must be set by
task else any methods in Utils, eg. RunProcess, silently fail to log
any messages. Also, this would be a problem when building multiple
projects in parallel, since the logger is a task-specific one.
Instead, we pass logger as an arg to all the methods.
Ankit Jain [Mon, 19 Jul 2021 05:02:01 +0000 (01:02 -0400)]
[wasm] Add support for using custom native libraries (#55797)
Radek Doulik [Mon, 19 Jul 2021 03:32:33 +0000 (05:32 +0200)]
[wasm] Run browser tests on helix/windows (#52699)
* [wasm] Run browser tests on helix/windows
* Build just wasm/browsertests on helix/windows
* Use $(ChromiumRevision) in windows links
* Fix conditions
* Set PATH differently
* Use backslash in PATH on windows
* Try different version of chromium
* Pass scenario and browser host to build
And set browser path on windows to be able to start chrome
from xharness
* Try to get more info from the helix workitems
* Fix dir separator, add broser path
* Create WasmBuildSupportDir
* Revert "Try to get more info from the helix workitems"
This reverts commit
8807434a33a09a27f2c21cb321b743f155955cb2.
* Put the dir cmds back, fix mkdir call
* More debug info
* Bump xharness
* Bump xharness again
With darc this time
* StressLogAnalyzer didn't print the number of messages correctly if it exceeded the int range (2 billion). (#54832)
Fix is to just use 64 bit ints instead.
* Found a race condition where the LOH flag on a segment is set too late. This gives another thread the chance to allocate in a fresh LOH region that doesn't have the LOH flag set just yet and trip over an assert in Object::ValidateInner. (#54839)
The fix is simply to set the flag in get_new_region before the region is put on the list for the LOH generation.
* Try to show the chrome logs
* Use different path for chrome logs
* Use newer image with font for chrome
The chrome was crashing, because it didn't find any sans-serif font.
* Increase timeouts
* Disable tests which timeout
* Remove debug calls
* Put back normal scenario
* Do not set scenario in build args
* Add browser sample exclusion
* Restore the platform matrix
* Remove the wasm build test changes
That will be handled in https://github.com/dotnet/runtime/pull/54451
* Remove duplicate exclusion
* Suggested property name change
* Fix last merge
* Simplify condition
We don't pass Scenario anymore
* Include chrome and chromedriver in the payload
Co-authored-by: Peter Sollich <petersol@microsoft.com>
Jeremy Koritzinsky [Sun, 18 Jul 2021 23:46:19 +0000 (18:46 -0500)]
Disable array support for the COM variant wrapper classes when built-in COM is disabled. (#55756)
* Disable array support for the COM variant wrapper classes when built-in COM is disabled.
Fixes #55600
* Fix config call.
* Fix one more location of wrapper class usage.
* Fix method name.
* Add trimming test.
* Fix AV in IsArrayOfWrappers
* Fix trimming test
* Apply suggestions from code review
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
* Set Trim=true
Co-authored-by: Elinor Fung <elfung@microsoft.com>
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Mikel Blanchard [Sun, 18 Jul 2021 19:04:17 +0000 (12:04 -0700)]
System.Text.Json: stackalloc constants + misc PR feedback (#55350)
* Follow-up feedback from #54186.
* Code review.
* Code review.
* Dedicated constant for the max number of chars permitted to be allocated on the stack.
Emmanuel André [Sun, 18 Jul 2021 17:30:16 +0000 (19:30 +0200)]
Fix WaitForConnectionAsync when NamedPipeServerStream is disposed (#52825)
* Fix WaitForConnectionAsync when NamedPipeServerStream is disposed
* Align Unix implementation on broken pipe IO exception as on Windows
* Add missing methods to test against ObjectDisposedException
* Apply suggestions from code review
Co-authored-by: Stephen Toub <stoub@microsoft.com>
* Rebase and fix suggestions
* Cancel Accept on dispose
* Improve test
* Apply suggestions from code review
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Tal Aloni [Sun, 18 Jul 2021 14:18:25 +0000 (17:18 +0300)]
Bugfix: System.Xml.Serialization: Compiler.GetTempAssemblyName is not deterministic under .NET Core (#46499)
* Bugfix: System.Xml.Serialization: Compiler.GetTempAssemblyName is not persistent under .NET Core
The implementation of String.GetHashCode() was persistent by default in .NET Framework. allowing to predictably name an XmlSerializers.{HashCode}.dll containing the pre-generated serializers.
In .NET Core / .NET 5, String.GetHashCode() is no longer persistent, so the value of ns.GetHashCode() will change during each run, preventing it from picking up the XmlSerializers dll correctly.
* Remove trailing whitespace
* Use truncated SHA512
* Fixed compilation
* Dispose SHA512 instance
* Fixed compilation
* Update src/libraries/System.Private.Xml/src/System/Xml/Serialization/Compiler.cs
Co-authored-by: Stephen Toub <stoub@microsoft.com>
* Update src/libraries/System.Private.Xml/src/System/Xml/Serialization/Compiler.cs
Co-authored-by: Stephen Toub <stoub@microsoft.com>
* Update Compiler.cs
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Prashanth Govindarajan [Sun, 18 Jul 2021 13:06:23 +0000 (06:06 -0700)]
Eliminate backtracking in the interpreter for patterns with .* (#51508)
* First cut of look up table for speeding up Go()
* More efficient .* in RegexInterpreter
* sq
* Get more debug info
* Remove assert and add unit test
* Potential unit test
* temp
* Fix a bug
* sq
* Add extra protection to the backtracking optimization
* Add unit test
* Revert
* RegexCompiler changes
* sq
* Remove debug unit tests
* Add a length to the AsSpan call
* Address RegexCompiler comments and add unit tests
John Salem [Sun, 18 Jul 2021 12:45:44 +0000 (05:45 -0700)]
set CLOEXEC on diagnostic server FDs (#55850)
* set CLOEXEC on diagnostic server FDs
* Add assert and comment
* fix compiler warning
* simplify asserts to appease all the different builds
Jeremy Barton [Sun, 18 Jul 2021 11:05:25 +0000 (04:05 -0700)]
Reduce the nullability bypasses in CryptoPool.Return (#55782)
* Reduce the nullability bypasses in CryptoPool.Return
This is a walk over src/libraries/.../*.cs to find any calls to
CryptoPool.Return which needed a "!" because of nullability
flow.
A couple of the bypasses were identifying legitimate issues,
and were resolved by moving the Rent to the last thing before
the try.
A couple were because of the use of ArraySegment which
can't structurally promise the array is non-null. But those
were usually preceded by a call to ZeroMemory, and there
is a CryptoPool.Return(ArraySegment) which does that
already, so those "!"s were removed by changing to that
overload.
* Apply feedback
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Co-authored-by: Stephen Toub <stoub@microsoft.com>
dotnet-maestro[bot] [Sun, 18 Jul 2021 11:03:16 +0000 (07:03 -0400)]
[main] Update dependencies from dnceng/internal/dotnet-optimization dotnet/arcade dotnet/icu dotnet/roslyn-analyzers (#55812)
* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20210715.5
optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
From Version 1.0.0-prerelease.21364.4 -> To Version 1.0.0-prerelease.21365.5
* Update dependencies from https://github.com/dotnet/arcade build
20210715.11
Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
From Version 6.0.0-beta.21364.3 -> To Version 6.0.0-beta.21365.11
* Update dependencies from https://github.com/dotnet/icu build
20210716.2
Microsoft.NETCore.Runtime.ICU.Transport
From Version 6.0.0-preview.7.21363.1 -> To Version 6.0.0-rc.1.21366.2
* Update dependencies from https://github.com/dotnet/arcade build
20210716.1
Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
From Version 6.0.0-beta.21364.3 -> To Version 6.0.0-beta.21366.1
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20210716.2
Microsoft.CodeAnalysis.NetAnalyzers
From Version 6.0.0-rc1.21362.2 -> To Version 6.0.0-rc1.21366.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Stephen Toub [Sun, 18 Jul 2021 11:01:36 +0000 (07:01 -0400)]
Fix strings in ApplicationId.ToString (#55879)
In rolling out usage of StringBuilder.Append's support for interpolated strings, I mistook this occurrence as a StringBuilder rather than a ValueStringBuidler. This reverts the changes to its ToString, but also switches to use EncodeToUtf16 rather than a custom loop.
Stephen Toub [Sun, 18 Jul 2021 10:39:34 +0000 (06:39 -0400)]
Update Roslyn to 4.0.0-3.21367.2 (#55878)
naminodarie [Sun, 18 Jul 2021 10:31:10 +0000 (19:31 +0900)]
Add VersionCheck (#55763)
Tomas Weinfurt [Sun, 18 Jul 2021 10:12:40 +0000 (03:12 -0700)]
enable two quic tests (#55880)
Kunal Pathak [Sun, 18 Jul 2021 06:42:24 +0000 (23:42 -0700)]
Consider CALLFINALLY block as pred of finally block during assertion props (#55674)
* Consider CALLFINALLY block as one of the pred of handler block during assertion prop
* Add test case
* Do not perform jump threading for first block of try-region
* fix bbNum
* revert dataflow changes
Jan Kotas [Sat, 17 Jul 2021 22:32:54 +0000 (15:32 -0700)]
Refactor runtime-specific logic out of CustomAttributeData (#55870)
CustomAttributeData is meant to be abstract base class of reflection object model. Move the runtime-specific part
into a separate RuntimeCustomAttributeData type.
Mike McLaughlin [Sat, 17 Jul 2021 19:15:04 +0000 (12:15 -0700)]
Fix System.Reflection.Metadata.MetadataUpdater.IsSupported (#55874)
Issue: https://github.com/dotnet/aspnetcore/issues/34440
Kevin Jones [Sat, 17 Jul 2021 19:14:36 +0000 (15:14 -0400)]
Use RetryHelper to improve reliability of revocation tests (#55873)
Alfonso Gregory [Sat, 17 Jul 2021 04:39:31 +0000 (00:39 -0400)]
Remove old snow leopard hack (#55825)
* Remove old hack
It’s been a long time since snow leopard and the issue should be fixed by now
* Remove declaration
* Remove unnecessary include
Aleksey Kliger (λgeek) [Sat, 17 Jul 2021 04:37:59 +0000 (00:37 -0400)]
Don't probe mono aot-cache directory for AOT images (#55832)
We don't have a global AOT cache directory on any platform
Fixes https://github.com/dotnet/runtime/issues/33080
Koundinya Veluri [Sat, 17 Jul 2021 01:37:57 +0000 (18:37 -0700)]
Fix debugger thread context validation after recent change (#55839)
Followup fix to https://github.com/dotnet/runtime/pull/55185
Layomi Akinrinade [Fri, 16 Jul 2021 23:14:40 +0000 (16:14 -0700)]
Reimplement dynamic member access for collection converters correctly (#55846)
David Wrighton [Fri, 16 Jul 2021 23:04:41 +0000 (16:04 -0700)]
Fix nested calls to Assembly Load Start tracing (#55700)
The name_with_pid test ends up testing the behavior of event tracing in the presence of composite images.
In the presence of a composite image, it might happen attempting to send trace data may force an attempt to load System.Private.CoreLib thus causing an stackoverflow as attempting to report the load of System.Private.CoreLib will trigger a load of System.Private.CoreLib, etc. This fix steps around the issue by using a thread local variable to skip subsequent attempts to report the load of System.Private.CoreLib.
Fixes #55786
Chris Ross [Fri, 16 Jul 2021 21:36:53 +0000 (14:36 -0700)]
Fix SslServerAuthenticationOptions.ApplicationProtocols empty list error #55447 (#55772)
Jeremy Barton [Fri, 16 Jul 2021 21:34:07 +0000 (14:34 -0700)]
Disable S.S.C.OpenSSL tests on the platforms that are PNSE.
Jeremy Barton [Fri, 16 Jul 2021 20:32:36 +0000 (13:32 -0700)]
Re-enable some netfx tests (#55837)
The patch states on the test machines should be in sync now...
WizardBrony [Fri, 16 Jul 2021 20:32:23 +0000 (16:32 -0400)]
Access modifier cleanup in Task (#55842)
* Update Task.cs
* Update TaskFactory.cs
Ulrich Weigand [Fri, 16 Jul 2021 19:58:19 +0000 (21:58 +0200)]
[mono] Allow overriding GetCustomAttributesData routines (#55726)
* Merge common bits of Mono and CoreCLR CustomAttributeData implementation
* Have CustomAttributeData.GetCustomAttributes call target.GetCustomAttributesData
to allow derived classes to override the latter (like in CoreCLR)
* Use Constructor, ConstructorArguments, and NamedArguments in internal
routines to allow them being overridden (like with CoreCLR).
Anirudh Agnihotry [Fri, 16 Jul 2021 17:35:38 +0000 (10:35 -0700)]
update branding to rc1 (#55775)
Jan Vorlicek [Fri, 16 Jul 2021 17:35:06 +0000 (19:35 +0200)]
Fix UMEntryThunkCache::GetUMEntryThunk (#55834)
The function was initializing UMThunkMarshInfo allocated from Stub heap
without using the ExecutableWriterHolder. That causes a crash when a
hosting application calls coreclr_create_delegate.
This was discovered in .NET 6 Preview 6 when running a xamarin app that
uses a special host.
This code path is exercised only by coreclr_create_delegate.
Eric StJohn [Fri, 16 Jul 2021 16:55:43 +0000 (09:55 -0700)]
Fix case of DefaultValue using enum backing type. (#55793)
Tarek Mahmoud Sayed [Fri, 16 Jul 2021 16:26:44 +0000 (09:26 -0700)]
Fix string comparison with ordinal casing with Surrogates (#55771)
* Fix string comparison with ordinal casing with Surrogates
* Address the feedback
Alexander Nikolaev [Fri, 16 Jul 2021 15:13:03 +0000 (17:13 +0200)]
Fix Http2Connection.GetIdleTicks (#55820)
There is currently a wrong operand order in the subtraction.
Fixes #43877
Stephen Toub [Fri, 16 Jul 2021 14:49:42 +0000 (10:49 -0400)]
Streamline rent/return on ArrayPool (#55710)
* Streamline rent/return on ArrayPool
- Stop storing and using a _bucketArraySizes. It's cheaper to recompute the shift on each use than it is to index into the array (with a bounds check). Plus less memory.
- The 99% case is renting a positive length for pooled array sizes (especially now that we've bumped the limit up to a gig). Move the checks for lengths <= 0 to after the check for whether the length is poolable.
- Move arrays into locals to enable the JIT to eliminate some bounds checks.
- Use ThrowHelpers where we already have them
- Move non-generic helpers out of generic class into Utilities
- Consolidate buffer allocation in Rent to a single line
- Reorganize TLS checks to be as early as possible
- Use FastMod instead of % in per-core stacks
* Address PR feedback
Tomas Weinfurt [Fri, 16 Jul 2021 14:17:58 +0000 (07:17 -0700)]
increase default timout on RunClientServer methods (#55798)
Maxim Lipnin [Fri, 16 Jul 2021 13:56:18 +0000 (16:56 +0300)]
Make Named Pipe Server Stream name fit into allowed length on Android (#55731)
* Make Named Pipe Server Stream name fit into allowed length on Android
* Apply Stephen's suggestion
* Remove redundant parameter
* Take into account possible null terminator
Alexander Köplinger [Fri, 16 Jul 2021 13:53:05 +0000 (15:53 +0200)]
Remove unnecessary intrinsics in mono/mini/intrinsics.c (#55806)
- System.Environment.IsRunningOnWindows doesn't exist in the dotnet/runtime corelib
- Microsoft.CodeAnalysis.CompilerServer.MemoryHelper.IsMemoryAvailable was used to workaround a bug that was fixed 2 years ago with https://github.com/dotnet/roslyn/pull/38239 and should no longer be relevant
Karel Zikmund [Fri, 16 Jul 2021 13:52:52 +0000 (15:52 +0200)]
Disable SocketsHttpHandlerTest_Http3_MsQuic.ClientSettingsReceived_Success test (#55811)
Started failing too frequently - see #55774
dotnet-maestro[bot] [Fri, 16 Jul 2021 10:49:24 +0000 (10:49 +0000)]
Update dependencies from https://github.com/dotnet/emsdk build
20210715.1 (#55784)
[main] Update dependencies from dotnet/emsdk
Stephen Toub [Fri, 16 Jul 2021 10:38:51 +0000 (06:38 -0400)]
Use more string interpolation (#55738)
* Use more string interpolation
I previously did a pass looking for opportunities. Finding a few more, as well as fixing some misuse of existing methods.
* Update src/libraries/System.Diagnostics.Process/tests/ProcessStartInfoTests.cs
Co-authored-by: halgab <24685886+halgab@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Co-authored-by: halgab <24685886+halgab@users.noreply.github.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Peter Sollich [Fri, 16 Jul 2021 09:58:27 +0000 (11:58 +0200)]
Add a time-based decay to the linear allocation model. (#55174)
Real world scenario that motivated this allocated a huge amount of data once a day, leading to high gen 0 and gen 1 budgets (several GB).
After this, there was relatively little activity, causing gen 1 budget to take several hours to normalize.
The new logic discounts the previous desired allocation over a period of 5 minutes.
Alexander Nikolaev [Fri, 16 Jul 2021 09:37:04 +0000 (11:37 +0200)]
Annotate WebSockets.RegisterPrefixes with [Obsolete] (#55640)
Fixes #50530
Alexander Nikolaev [Fri, 16 Jul 2021 09:33:49 +0000 (11:33 +0200)]
Mitigate race condition in EventSource_ConnectionPoolAtMaxConnections_LogsRequestLeftQueue test (#55729)
There is a unavoidable race condition between updating event counters and reading their values in WaitForEventCountersAsync. It waits for at least 2 sets of EventCounter event groups to ensure the last group is captured after any actual work (tests check that counters reset back to 0 if there is nothing happening).
Since it looks for `requests-started` which occurs before `http11-requests-queue-duration` event, what it may see is only the tail of the last group and the start of the second, without waiting for a fresh `http11-requests-queue-duration`. In this, the assert `Assert.Equal(0, http11requestQueueDurations[^1])` on the line 549 will see a non-zero counter value and fail.
This PR changes the condition to `< 3` to guarantee there is at least one full group of events in the window.
Co-authored by @MihaZupan
Fixes #46073
Maxim Lipnin [Fri, 16 Jul 2021 08:47:08 +0000 (11:47 +0300)]
Skip System.IO.IsolatedStorage.Tests.HelperTests.GetDataDirectory(scope: Machine) on Android (#55719)
Michal Strehovský [Fri, 16 Jul 2021 07:51:25 +0000 (09:51 +0200)]
Delete dead WinRT code in Activator (#55721)
Tarek Mahmoud Sayed [Fri, 16 Jul 2021 04:01:18 +0000 (21:01 -0700)]
Fix Unicode BiDi Category (#55790)
Steve Berdy [Fri, 16 Jul 2021 02:32:43 +0000 (22:32 -0400)]
Remove sourceFullPath from Unix FileSystem.MoveDirectory exception (#55658)
* Update Path.Windows.cs
* Change helper method to internal
Switched method from a private protection level to an internal protection level. Also removed trailing whitespace.
* Removed sourceFullPath from Unix FileSystem.MoveDirectory thrown exception
* Undo commit from main fork branch
* Revert FileSystem.Windows.cs changes
Tanner Gooding [Fri, 16 Jul 2021 01:23:31 +0000 (18:23 -0700)]
Add a System.Runtime.Experimental package so users can still use the generic math preview (#55678)
* Add a System.Runtime.Experimental package so users can still use the generic math preview
This reverts commit
f6eb259db626d563c15ba340feb6f440d1e1c8ee.
* Simplify S.R.Experimental so it only produces a ref and its build version is 100 higher
* Ensure a nuget package is being produced and resolve PR feedback
* Update src/libraries/System.Runtime.Experimental/Directory.Build.props
* Add a reference to System.Runtime.Experimental so mono can build
* Disable System.Runtime.Experimental.Tests on WASM AOT
dotnet-maestro[bot] [Thu, 15 Jul 2021 22:27:46 +0000 (15:27 -0700)]
[main] Update dependencies from 8 repositories (#55636)
* Update dependencies from https://github.com/dotnet/arcade build
20210713.2
Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
From Version 6.0.0-beta.21359.3 -> To Version 6.0.0-beta.21363.2
* Update dependencies from https://github.com/dotnet/icu build
20210713.1
Microsoft.NETCore.Runtime.ICU.Transport
From Version 6.0.0-preview.7.21362.1 -> To Version 6.0.0-preview.7.21363.1
* Update dependencies from https://github.com/dotnet/xharness build
20210713.1
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 1.0.0-prerelease.21357.4 -> To Version 1.0.0-prerelease.21363.1
* Update dependencies from https://github.com/mono/linker build
20210713.1
Microsoft.NET.ILLink.Tasks
From Version 6.0.100-preview.6.21362.3 -> To Version 6.0.100-preview.6.21363.1
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20210712.2
Microsoft.CodeAnalysis.NetAnalyzers
From Version 6.0.0-rc1.21356.1 -> To Version 6.0.0-rc1.21362.2
* Update dependencies from https://github.com/dotnet/emsdk build
20210714.1
Microsoft.NET.Workload.Emscripten.Manifest-6.0.100
From Version 6.0.0-preview.7.21363.1 -> To Version 6.0.0-preview.7.21364.1
* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20210714.4
optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
From Version 1.0.0-prerelease.21362.2 -> To Version 1.0.0-prerelease.21364.4
* Update dependencies from https://github.com/dotnet/arcade build
20210714.3
Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
From Version 6.0.0-beta.21359.3 -> To Version 6.0.0-beta.21364.3
* Update dependencies from https://github.com/dotnet/xharness build
20210714.1
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 1.0.0-prerelease.21357.4 -> To Version 1.0.0-prerelease.21364.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build
20210714.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 1.0.1-alpha.0.21362.1 -> To Version 1.0.1-alpha.0.21364.1
* Revert linker change
* Roll back the version
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Andy Gocke <angocke@microsoft.com>
Co-authored-by: Larry Ewing <lewing@microsoft.com>
Kevin Jones [Thu, 15 Jul 2021 22:09:02 +0000 (18:09 -0400)]
Use pbeWithSHAAnd3-KeyTripleDES-CBC for SignedXml certificate.
This changes the PKCS12 from being using RC2 to 3DES so that the test
passes on Android, which does not support RC2.
Radek Doulik [Thu, 15 Jul 2021 21:40:57 +0000 (23:40 +0200)]
[wasm] Support mono runtime components (#55680)
* [wasm] Support mono runtime components
* Do not use diagnostics_tracing component
* Allow custom @(_MonoComponent)
* Update src/mono/wasm/build/WasmApp.Native.targets
* Select components only with native workload
* Fixing CI when linking with stubs
* Adding what @radical asked for.
* Update sendtohelixhelp.proj
Fix helix work item prefix
Co-authored-by: Larry Ewing <lewing@microsoft.com>
Co-authored-by: Thays <thaystg@gmail.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
hrrrrustic [Thu, 15 Jul 2021 20:54:13 +0000 (23:54 +0300)]
StringSegment behavior (#55501)
* Add tests for old issue
* Add test for new issue
* fix behavior for old issue
* fix behavior for new issue
* Update IndexOf checks for consistency
Co-authored-by: Günther Foidl <gue@korporal.at>
Co-authored-by: Günther Foidl <gue@korporal.at>
Ankit Jain [Thu, 15 Jul 2021 20:49:16 +0000 (16:49 -0400)]
[wasm] Misc follow up improvements for workloads testing (#55647)
* [wasm] Move UseMonoRuntime=true to WasmApp.props
* Move workloads installation for testing bits to
.. `src/libraries/workloads-testing.targets`.
* [wasm] EmccCompile: don't log `stderr` messages as warnings
emcc emits some (debug?) messages on stderr too, which are not always
errors. Emitting them as warning can be break the build too, when
running with warningsAsErrors .
* [wasm] Fix helix work item prefix
* improve readability of messages from parallel EmccCompile
* Improve emscripten version mismatch message, and convert to a warning
* Fix typo, so WBT runs can be differentiated correctly