Yongjoo Ahn [Thu, 15 Jun 2023 04:11:04 +0000 (13:11 +0900)]
[fix] Fix mem leak in Single API
- Destroy ml_tensors_info_h in ml_single_close
- Call gst_tensors_info_free
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Tue, 13 Jun 2023 12:35:46 +0000 (21:35 +0900)]
[fix] Fix memi leak in pipeline API
- Free GstTensorsConfig using gst_tensors_config_free
- Initialize ml_tensors_info_s before set a new one
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
SuYeon [Wed, 14 Jun 2023 02:22:18 +0000 (11:22 +0900)]
fix svace issue.
error param should be paased to 'json_parser_load_from_data' since error_report acess to error message.
Signed-off-by: SuYeon <suyeon5.kim@samsung.com>
gichan2-jang [Tue, 13 Jun 2023 02:41:24 +0000 (11:41 +0900)]
[Tizen] Update coverage auto measurement script
- Exclude 'ml-api-common-tizen-feature-check.c' and
'ml-api-inference-tizen-privilege-check.c' from the coverage report.
- Change test directory before running the tests.
Error:
[DEBUG]:[ RUN ] [mMLAgentTest.call_method
Error : GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name org.tizen.machinelearning.service was not provided by any .service files
[DEBUG]:../tests/daemon/unittest_ml_agent.cc:87: Failure
Signed-off-by: gichan2-jang <gichan2.jang@samsung.com>
Wook Song [Tue, 13 Jun 2023 01:21:48 +0000 (10:21 +0900)]
API/Client: Revise JSON cstring conversion code
This patch revises the mechanism that creates ml_option_h typed data
from a JSON cstring.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Sangjung Woo [Mon, 12 Jun 2023 08:31:41 +0000 (17:31 +0900)]
[ml-service] Add 'app_common_internal.h' to support Tizen v7.0
In case of Tizen 7.0, app_get_res_control_global_resource_path() is
defined in app_common_internal.h. So this patch includes
app_common_internal.h to support both of Tizen 7.0 and latest Tizen.
Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
Jaeyun Jung [Thu, 1 Jun 2023 05:53:49 +0000 (14:53 +0900)]
[Test] feature for tf-lite
Enable testcase if tensorflow-lite ver2.x is available.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Thu, 1 Jun 2023 05:58:35 +0000 (14:58 +0900)]
[Service] common log-util
Code clean, use common log-util in ml-agent code.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Wook Song [Mon, 22 May 2023 08:06:17 +0000 (17:06 +0900)]
API/Client: Use nested scope for JSON handling
This is a trivial patch for code cleaning. Toward better readability,
nested scope and g_auto* are used for JSON handling.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Wook Song [Wed, 24 May 2023 10:15:09 +0000 (19:15 +0900)]
Daemon/DBus: Replace NULL with "" for the DBus out parameters
When the out parameter type is set to "s" (which means a string type
value), it should not be a NULL value. This patch fixes such a case
in the DBus callback implementation for the pipeline.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Wook Song [Mon, 22 May 2023 07:32:52 +0000 (16:32 +0900)]
API/Client: Replace g_new0 with g_try_new0
g_new0 would not work as the author intended. This patch replaces g_new0
macros with g_try_new0 macros so that memory allocation failure is
checked at runtime.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Wook Song [Mon, 22 May 2023 06:50:32 +0000 (15:50 +0900)]
API/Client: Revise null-checks for output parameters
This patch revises null-checks for the output parameters, which
require memory allocation at the callee side, to return an error when
the argument is NULL and to warn the leak possibility when the
dereference is not NULL.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Wook Song [Mon, 22 May 2023 02:46:30 +0000 (11:46 +0900)]
Daemon: Change the directory including header file to 'include'
To keep consistency with the C-Level API's header file directory, this
patch changes the directory including ML Agent Service's header files to
'include' from 'includes'.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Jaeyun Jung [Wed, 3 May 2023 11:49:06 +0000 (20:49 +0900)]
[Service] deleting activated model
Add util functions in service-db,
1. prevent deleting activated model,
2. add util function to check model registration.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Sangjung Woo [Thu, 18 May 2023 04:56:46 +0000 (13:56 +0900)]
[Service] Fix the wrong requires section of pkgconfig file
This patch fixes the wrong requires section of ML Service package config file.
Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
Wook Song [Thu, 18 May 2023 04:32:23 +0000 (13:32 +0900)]
Tests: Revise the unittests package
This patch revised the meson build script and Tizen's rpm spec file to
include files which are required by the test daemon,
machine-learning-agent-test.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Yongjoo Ahn [Mon, 15 May 2023 05:00:30 +0000 (14:00 +0900)]
[Release] Change the name tizen 7.5 into tizen 8.0
- Tizen X.5 is not going to be used. Change tizen 7.5 to tizen 8.0
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
gichan2-jang [Thu, 11 May 2023 10:11:14 +0000 (19:11 +0900)]
[Tizen] Fix script for converage auto measurement
Fix script for coverage auto measuremnt
- Set MLAPI PATH
Signed-off-by: gichan2-jang <gichan2.jang@samsung.com>
Jaeyun Jung [Thu, 4 May 2023 07:06:12 +0000 (16:06 +0900)]
[Service] functions for transaction
Code clean, add internal util function for DB transaction.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Thu, 4 May 2023 04:40:09 +0000 (13:40 +0900)]
[Service] logutil in service-db
Code clean, use common logutil in service-db.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Thu, 4 May 2023 05:16:33 +0000 (14:16 +0900)]
[Build/Service] fix indent
Fix build error, clang-format of service-db.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Wed, 3 May 2023 06:24:28 +0000 (15:24 +0900)]
[Service/Log] printing internal value
The ID from pipeline hashtable in daemon is internal value.
This PR hides this internal ID value.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Tue, 2 May 2023 07:28:53 +0000 (16:28 +0900)]
[C-Api/CodeClean] remove unnecessary code
Code clean,
1. fix indent and remove unnecessary lines.
2. replace function to compare pkg type (case-insensitive).
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Wed, 3 May 2023 07:29:16 +0000 (16:29 +0900)]
[clang-format] line-comment length
clang-format, ignore line-comment length.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Tue, 2 May 2023 04:32:56 +0000 (13:32 +0900)]
[Service] handle invalid version
Raise exception when given version number is 0.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Wook Song [Tue, 2 May 2023 05:43:29 +0000 (14:43 +0900)]
Formatting/CC: Apply .clang-format to the C++ source files
This patch applies .clang-format to all of the .cc files, which are
source files written in C++.
find . -name "*.cc" -exec clang-format-15 --style=file:.clang-format {} \;
Signed-off-by: Wook Song <wook16.song@samsung.com>
Jaeyun Jung [Tue, 2 May 2023 07:13:26 +0000 (16:13 +0900)]
[C-Api] Tizen API guide
Update API description, fix design guide.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Wook Song [Tue, 2 May 2023 05:54:42 +0000 (14:54 +0900)]
API/C: Add the missing header to the pipeline-internal header file
This patch adds a missing internal header, 'nnstreamer.h', which defines
data structures and types required by the
'ml-api-inference-pipeline-internal.h' file.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Wook Song [Tue, 2 May 2023 04:17:32 +0000 (13:17 +0900)]
Tests: Add test cases for gdbus-util
This patch adds unit test cases for the helper functions in the
gdbus-util.c file.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Yongjoo Ahn [Tue, 2 May 2023 04:06:00 +0000 (13:06 +0900)]
[test] Add a negative testcase for ml_service_launch_pipeline
- Add an erroneous pipeline launch case with invalid tensor_filter
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Jaeyun Jung [Tue, 2 May 2023 03:33:45 +0000 (12:33 +0900)]
[Service] invalid table schema
Fix invalid table schema and cleanup service-db test.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Tue, 2 May 2023 03:27:16 +0000 (12:27 +0900)]
[C-Api/CodeClean] remove duplicated code
Code clean, remove duplicated code.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Yongjoo Ahn [Fri, 28 Apr 2023 02:26:39 +0000 (11:26 +0900)]
[CodeClean] Change variable name
- Change variable name not to hide the parameter of cb
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Fri, 28 Apr 2023 02:25:47 +0000 (11:25 +0900)]
[CodeClean] Fix memleak of pkg_info
- Free pkg_info handle when the callback is returned
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
gichan [Thu, 27 Apr 2023 05:51:43 +0000 (14:51 +0900)]
[TEST] Set `is-updatable` prop of single test
Set `is-updatable` prop of single test
*line coverage: 80.1%
Signed-off-by: gichan <gichan2.jang@samsung.com>
Yongjoo Ahn [Thu, 27 Apr 2023 04:42:10 +0000 (13:42 +0900)]
[build] Add missing errno.h in ml-agent-dbus-interface.c
- Add missing header <errno.h> to the source file.
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Wook Song [Tue, 25 Apr 2023 12:25:08 +0000 (21:25 +0900)]
Meson/LCOV: Apply a workaround to increase lcov of 'service-db.cc'
This patch applies a simple workaround to increase the line coverage of
the 'service-db.cc' file.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Wook Song [Fri, 14 Apr 2023 06:57:08 +0000 (15:57 +0900)]
MLAgent: Introduce libml-agentd
This patch defines APIs of the ML Agent Daemon whose backend is GDBus
and exports them to the outer space of the daemon so that the tightly
coupled dependency between the libcapi-ml-service and daemon is
eliminated.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Jaeyun Jung [Tue, 25 Apr 2023 03:48:45 +0000 (12:48 +0900)]
[Test] remove unnecessary test
Code clean, remove empty testcase.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Tue, 25 Apr 2023 03:41:00 +0000 (12:41 +0900)]
[Test/Meson] common dependency
Use predefined dependencies in meson script.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Mon, 24 Apr 2023 10:54:19 +0000 (19:54 +0900)]
[Meson] dependency to tizen pkgs
Code clean, define dependencies to tizen packages.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Mon, 24 Apr 2023 08:35:49 +0000 (17:35 +0900)]
[Build] error ml-svc on ubuntu
Fix error when building ml-svc on ubuntu.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
gichan [Mon, 24 Apr 2023 05:51:25 +0000 (14:51 +0900)]
Tizen] Exclude test files for SAM
Exclude test files for SAM
Signed-off-by: gichan <gichan2.jang@samsung.com>
Yelin Jeong [Fri, 21 Apr 2023 02:00:17 +0000 (11:00 +0900)]
[C-API] revert fill dimension 1
This patch reverts fill dimension to default value 1.
In C# API, interop function ml_tensors_info_get_tensor_dimension
is used with length 4 dimension array instead of 16.
Signed-off-by: Yelin Jeong <yelini.jeong@samsung.com>
Wook Song [Thu, 20 Apr 2023 05:43:24 +0000 (14:43 +0900)]
Daemon/PkgMrg: Eliminate duplicate code blocks
This is a trivial patch for the elimination of the duplicate code
blocks.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Wook Song [Thu, 20 Apr 2023 04:56:17 +0000 (13:56 +0900)]
Tests/PkgMgr: Add functions for emulation of Tizen's Pkg Manager APIs
This patch adds helper functions for the emulation of Tizen's Package
Manager APIs and utilities for unit test cases of ML Agent Service APIs.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Yongjoo Ahn [Fri, 21 Apr 2023 01:32:52 +0000 (10:32 +0900)]
[CodeClean] Fix memleak in pkgmgr
- Use g_autofree gchar to prevent memleak;
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Thu, 20 Apr 2023 03:11:03 +0000 (12:11 +0900)]
[build] Add empty build dep for tizen appfw for local build/test
- Add an empty build dep for tizen appfw, used by servce API
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Mon, 17 Apr 2023 06:39:28 +0000 (15:39 +0900)]
[pkgmgr] Parse rpk's "model_description.json" to fill app_info and register
- When rpk is installed, parse the provided model_description.json file
and register models described in the json.
TODO: Handle when the rpk package is removed or updated.
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Mon, 17 Apr 2023 06:13:23 +0000 (15:13 +0900)]
[service] Check and parse app_info of tizen application (the caller)
In a Tizen application context,
`ml_service_model_register` fill app_info column. RPK cannot call this
API, so the value of key `is_rpk` is always false.
`ml_service_model_get*` APIs should parse the app_info and update the
path in case of models from 'RPK'.
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Wook Song [Wed, 19 Apr 2023 02:47:55 +0000 (11:47 +0900)]
Tests/Dbus: Move DBus-related files to the tests/dbus directory
This patch relocates the dbus interface for the unit tests to the tests
directory. According to the changes, the meson build files are alse
updated as well.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Yongjoo Ahn [Mon, 17 Apr 2023 06:05:17 +0000 (15:05 +0900)]
[service] Add "app_info" column to the model DB
- Add a new column "app_info" to the service DB's tblModel table.
- This app_info is a json string consists of tizen application
information which owns model.
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Wook Song [Wed, 19 Apr 2023 04:16:09 +0000 (13:16 +0900)]
Tests/Meson: Revise meson build scripts in tests
This patch revises the meson build scripts related to the test
sub-directory.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Yelin Jeong [Tue, 11 Apr 2023 10:46:43 +0000 (19:46 +0900)]
[C-API] Fix set tensor dimension order
This patch fixes the order of ml_tensors_info_set_tensor_dimension.
If tensors_info is not extended, user may regard dimension array's length to 4.
Signed-off-by: Yelin Jeong <yelini.jeong@samsung.com>
Yongjoo Ahn [Mon, 17 Apr 2023 06:46:19 +0000 (15:46 +0900)]
[agent] Change tizen log functions of ml-agent
- Let ml-agent logs be more verbose in Tizen.
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Sangjung Woo [Thu, 13 Apr 2023 00:15:22 +0000 (09:15 +0900)]
[C-Api] Revert fill dim (default 1) commit
Because of native TC failure, this patch reverts the fill dim (default
1) commit.
Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
Jaeyun Jung [Fri, 7 Apr 2023 07:50:33 +0000 (16:50 +0900)]
[C-Api] fill dim (default 1)
When calling get-dimension(), fill remained dim - default dim is 1.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Yelin Jeong [Thu, 23 Mar 2023 04:56:33 +0000 (13:56 +0900)]
[Test] add tests to increase ML_TENSOR_RANK_LIMIT
This patch adds some TCs for increased ML_TENSOR_RANK_LIMIT.
Signed-off-by: Yelin Jeong <yelini.jeong@samsung.com>
Yelin Jeong [Thu, 23 Mar 2023 04:55:19 +0000 (13:55 +0900)]
[C-API] Increase ML_TENSOR_RANK_LIMIT
This patch increases ML_TENSOR_RANK_LIMIT from 4 to 16.
Signed-off-by: Yelin Jeong <yelini.jeong@samsung.com>
Jaeyun Jung [Tue, 4 Apr 2023 10:22:30 +0000 (19:22 +0900)]
[CodeClean] fix indent
Trivial, fix indent and init null to global val.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Yelin Jeong [Fri, 31 Mar 2023 08:14:19 +0000 (17:14 +0900)]
[Single] Add input and output ranks
This patch adds input and output ranks to ml_single.
Input and output ranks are used when user explicitly sets rank property.
Signed-off-by: Yelin Jeong <yelini.jeong@samsung.com>
Jaeyun Jung [Mon, 3 Apr 2023 02:35:15 +0000 (11:35 +0900)]
[Service] init handle id
Init-zero to connect the signals of model-dbus.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Mon, 3 Apr 2023 02:37:43 +0000 (11:37 +0900)]
[Service] common log util
Use common log util in model-dbus impl.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Wook Song [Thu, 30 Mar 2023 05:05:20 +0000 (14:05 +0900)]
Meson/LCOV: Fix wrong code coverage ratio for ml-agent sources
The changes in 2b1df86 make two sets of object files for the
'machine-learning-agent' and 'machine-learning-agent-test' executables,
which leads to the wrong code coverage ratio for the ml-agent daemon
source files. This patch fixes it.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Yongjoo Ahn [Wed, 29 Mar 2023 08:50:54 +0000 (17:50 +0900)]
[CodeClean] Remove unnecessary code in service api test
- Remove some unused code.
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Wed, 29 Mar 2023 08:39:52 +0000 (17:39 +0900)]
[agent] Remove unused exceptions
- Let std::exception catch those runtime errors.
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Wed, 29 Mar 2023 08:37:42 +0000 (17:37 +0900)]
[CodeClean] Remove pipeline module related code from gdbus-util
- Move pipeline related code in gdbus-util to proper src.
- Adjust function names to the model-impl.
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Wed, 29 Mar 2023 08:52:27 +0000 (17:52 +0900)]
[test] Add some negative test for ml-agent
- Add some negative test for ml-agent.
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Wook Song [Wed, 29 Mar 2023 02:47:00 +0000 (11:47 +0900)]
Meson: Add a missing build dependency, 'nnstreamer-internal'
This patch fixes build errors because of a missing header file,
'nnstreamer_internal.h', which should be included in the build
dependencies by meson.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Yongjoo Ahn [Tue, 21 Mar 2023 06:59:58 +0000 (15:59 +0900)]
[test] Add unittest for service DB
- Add negative testcases for service DB.
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Wed, 22 Mar 2023 08:14:04 +0000 (17:14 +0900)]
[agent/DB] Prevent sql injection by using `sqlite3_bind_text`
- Use `sqlite3_bind_text` instead of formatted string to prevent sql
injection attack.
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Jaeyun Jung [Mon, 27 Mar 2023 09:33:49 +0000 (18:33 +0900)]
[Build/Test] daemon for unittest
Cleanup build script, move test-daemon into 'tests' dir and fix file names.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Fri, 24 Mar 2023 07:42:08 +0000 (16:42 +0900)]
[Service] do not free handle in error case
If called service-destroy function, do not free allocated handle if an error from dbus or database is raised.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Mon, 27 Mar 2023 05:58:15 +0000 (14:58 +0900)]
[Build/Android] temporal block flatbuffer
Fix error, temporal block flatbuffer when building android library.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Yongjoo Ahn [Fri, 24 Mar 2023 02:01:42 +0000 (11:01 +0900)]
[test] Add negative tests for service APIs
- Add negative TC with DBUS unconnected.
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Fri, 24 Mar 2023 04:13:08 +0000 (13:13 +0900)]
[service] Change error code `not_support` into `io_error`
- If failed to connect with dbus, return ML_ERROR_IO_ERROR
rather than ML_ERROR_NOT_SUPPORTED, which should be check with tizen
feature.
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Wed, 22 Mar 2023 08:09:50 +0000 (17:09 +0900)]
[test] Fix mem leak of ml_option
- Add missing `ml_option_destroy`
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Wed, 22 Mar 2023 08:09:02 +0000 (17:09 +0900)]
[agent] Print exception message
- Print exception message rather than simple error log
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Jaeyun Jung [Mon, 20 Mar 2023 07:44:34 +0000 (16:44 +0900)]
[CodeClean] handle error case
Code clean, handle res-leak if error occurs.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Yongjoo Ahn [Tue, 7 Mar 2023 11:22:47 +0000 (20:22 +0900)]
[test][service] Add testcases using ml_service_model APIs
- Add some TCs using the new APIs.
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Tue, 7 Mar 2023 11:18:40 +0000 (20:18 +0900)]
[service/model] Implement new APIS ml_service_model_*
- Add build dependency for the json-glib in .spec and meson.build
- Implement new APIs using dbus glib apis.
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Tue, 7 Mar 2023 11:16:52 +0000 (20:16 +0900)]
[common/option] Implement new API ml_option_get.
- Implement ml_option_get which returns the paired value of given key
in the ml_option instance.
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Tue, 7 Mar 2023 11:03:52 +0000 (20:03 +0900)]
[daemon] Implement dbus method callbacks
- Implement callback for each dbus methods:
register, update_description, activate,
get, get_activated, get_all, delete
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Tue, 7 Mar 2023 10:54:13 +0000 (19:54 +0900)]
[daemon][DB] Update/Add service-db methods in sqlite3 backend
- Update set_model, get_model, delete_model methods.
- Add udpate_model_description, activate_model methods.
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Tue, 7 Mar 2023 10:43:19 +0000 (19:43 +0900)]
[daemon] Add dbus methods to handle model service APIs
- Update model-dbus.xml.
- Update the header interface dbus-interface.h
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
gichan [Mon, 20 Mar 2023 05:21:10 +0000 (14:21 +0900)]
[Tizen] Fix gcno file path of gcov pacakge.
Tizen line coverage automation tool includes build dir path.
Fix gcno file path of gcov pacakge for compatibility with the tool.
Signed-off-by: gichan <gichan2.jang@samsung.com>
Jaeyun Jung [Fri, 24 Feb 2023 05:27:24 +0000 (14:27 +0900)]
[Service/Model] define new API
Define new function and info handle for machine learning models.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Thu, 9 Mar 2023 07:11:59 +0000 (16:11 +0900)]
[Service] handle table version
Handle table version. If table schema is changed, we should implement data migration later.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Mon, 13 Mar 2023 07:23:21 +0000 (16:23 +0900)]
[Service] validate model path
Validate model path when registering a model to database.
It should be an absolute path and not symbol link file.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Mon, 13 Mar 2023 06:52:01 +0000 (15:52 +0900)]
[Test] name to root directory
Fix name to root directory, use prefix 'MLAPI_'.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Fri, 10 Mar 2023 08:15:46 +0000 (17:15 +0900)]
[Build] remove dependency to leveldb
Change database to sqlite, remove dependency to leveldb.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Yongjoo Ahn [Wed, 22 Feb 2023 09:15:15 +0000 (18:15 +0900)]
[service] Add TCs using ml_service_delete_pipeline
- Add some negative testcases.
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Wed, 22 Feb 2023 09:11:29 +0000 (18:11 +0900)]
[agent][DB] Fix "delete_pipeline" to check the number of changed rows
- Check the number of changed rows after the DELETE query
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Jaeyun Jung [Fri, 17 Feb 2023 07:52:31 +0000 (16:52 +0900)]
[Service/CodeClean] separate method to init database
Code clean, sepatate method to initialize ml-service database.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Fri, 17 Feb 2023 07:56:18 +0000 (16:56 +0900)]
[Build] dependency to pkgmgr on ubuntu
Fix build error on ubuntu, dependency to pkgmgr.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Sangjung Woo [Wed, 15 Feb 2023 05:18:17 +0000 (14:18 +0900)]
[Service/PkgMgr] Add skeleton code for the package manager
To get the event from the package manager, the callback function should
be registered in ML Agent. This patch adds the skeleton code to get the
install, uninstall, and upgrade event of the resource package from the
package manager. Related work such as update the database of ML Agent
should be needed.
Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
Yongjoo Ahn [Mon, 13 Feb 2023 06:50:43 +0000 (15:50 +0900)]
[service] Add simple test using the new API
- Add a simple TC using API `ml_service_model_register`
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Mon, 13 Feb 2023 06:47:26 +0000 (15:47 +0900)]
[service] Initial commit for the C-API `ml_service_model_register`
- Initial commit for the new API, which register model
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Mon, 13 Feb 2023 06:34:24 +0000 (15:34 +0900)]
[service] Add util function to get model daemon proxy
- Add function to get proxy of the model d-bus interface
- "mlsm" stands for MachineLearningServiceModel
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Mon, 13 Feb 2023 06:27:51 +0000 (15:27 +0900)]
[agent] Add initial commit for "model_register" method to the daemon
- Add initial commit of "model_register" method.
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>