Jacek Blaszczynski [Fri, 9 Mar 2018 03:31:19 +0000 (04:31 +0100)]
Fix ConvertScalarToVector128(U)Int64 codegen and improve tests
Egor Chesakov [Fri, 9 Mar 2018 06:43:13 +0000 (22:43 -0800)]
Don't build superpmi as crosscomponent (#16729)
* Don't build superpmi as crosscomponent
* Replace install with _install in all superpmi CMakeLists.txt files
Luqun Lou [Fri, 9 Mar 2018 02:37:38 +0000 (18:37 -0800)]
Update UsingYourBuild.md (#16842)
This topic is about DotnetCli instead of CoreRun -- CoreRun is next topic
Tarek Mahmoud Sayed [Fri, 9 Mar 2018 01:03:32 +0000 (17:03 -0800)]
Fix Compile error
Tarek Mahmoud Sayed [Thu, 8 Mar 2018 21:56:43 +0000 (13:56 -0800)]
Collapse AsSpan().Slice(...) into .AsSpan(...) (dotnet/corefx#27867)
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Sergey Andreenko [Fri, 9 Mar 2018 01:17:31 +0000 (17:17 -0800)]
[RyuJit] Fix DCE in liveness. (#16845)
* add repro
* fix
Sung Yoon Whang [Fri, 9 Mar 2018 00:25:20 +0000 (18:25 -0600)]
Disable some GC tests from GCStress runs (#16846)
Anirudh Agnihotry [Thu, 8 Mar 2018 20:55:00 +0000 (12:55 -0800)]
RemoveRelativeSegments moved from path to pathinternal (#16829)
Andon Andonov [Thu, 8 Mar 2018 20:47:19 +0000 (21:47 +0100)]
Pass generic context argument for shared instance methods on generic interfaces (#16690)
* Add checks and regression test
* Uncomment InvokeConsumer tests
* Revert JIT Interface Check
Carol Eidt [Thu, 8 Mar 2018 20:45:28 +0000 (12:45 -0800)]
Merge pull request #16809 from sdmaclea/PR-Enable-crypto-test
[Arm64] Enable crypto test
Tanner Gooding [Tue, 6 Mar 2018 16:48:42 +0000 (08:48 -0800)]
Updating the x86 hardware-intrinsics tests to properly accept filter arguments
Stephen Toub [Thu, 8 Mar 2018 19:26:14 +0000 (14:26 -0500)]
Fix inlining of IAsyncStateMachineBox (#16830)
Prior to .NET Core 2.1, if a task was awaited in a default context (or if ConfigureAwait(false) was used), and if the task was then completed on a non-default context (e.g. code running a non-default TaskScheduler calling SetResult on a TaskCompletionSource), its await continuations are not allowed to be inlined, due to concerns that we could be running an arbitrary amount of unknown code in a scheduling environment that's not amenable to it, like a UI thread. The optimizations added in 2.1 erroneously ended up bypassing that IsValidLocationForInlining check, leading to continuations getting inlined in places they weren't previously.
This commit fixes that. Previously we'd made the IAsyncStateMachineBox interface inherit ITaskCompletionAction, with its Invoke interface method just delegating to MoveNext; then the box could be added to a task as a continuation. But that ITaskCompletionAction logic isn't specific to async/await and doesn't invoke IsValidLocationForInlining. We instead need to follow the Action logic that is meant to be used for async/await. I've removed the ITaskCompletionAction from IAsyncStateMachineBox, replacing it just with a MoveNext interface method, and added a case for IAsyncStateMachineBox to Task's RunContinuations logic. I then duplicated the AwaitTaskContinuation.RunOrScheduleAction logic that's there for Action and tweaked it for IAsyncStateMachineBox. In the process I cleaned up a little code to use some newer C# features.
Sergey Andreenko [Thu, 8 Mar 2018 18:24:38 +0000 (10:24 -0800)]
Delete incorrect assert in stackLevelSetter. (#16816)
* add repro
* delete the assert
Jan Kotas [Thu, 8 Mar 2018 18:18:50 +0000 (10:18 -0800)]
Make member visibility first accross corlib (#16836)
Mechanical find&replace to match https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md
Matt Mitchell [Thu, 8 Mar 2018 18:17:20 +0000 (10:17 -0800)]
Set helix source correctly for prodcon build (#16412) (#16837)
* Set helix source correctly for prodcon build
dotnet-maestro-bot [Thu, 8 Mar 2018 17:13:30 +0000 (11:13 -0600)]
Update CoreClr, CoreFx to preview2-26308-06, preview2-26308-06, respectively (#16835)
Michelle McDaniel [Thu, 8 Mar 2018 17:07:40 +0000 (09:07 -0800)]
Turn perf jobs back on (#16824)
Tanner Gooding [Wed, 7 Mar 2018 20:15:31 +0000 (12:15 -0800)]
Updating isRMWRegOper, OperIsCommutative, and canBeContained to handle HWIntrinsic nodes
Jan Kotas [Thu, 8 Mar 2018 14:09:03 +0000 (06:09 -0800)]
Move String to shared corelib partition (#16749)
Jeremy Kuhne [Wed, 7 Mar 2018 23:58:06 +0000 (15:58 -0800)]
Dial back `\\?\ ` insertion (dotnet/corefx#27827)
Only premptively adding for FileSystemInfo if we end in period or space.
Long path is taken care of later.
Clean up code a little and add test for DirectoryInfo.Move.
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Jan Vorlicek [Thu, 8 Mar 2018 11:44:33 +0000 (12:44 +0100)]
Fix ensuring primary stack size (#16698)
1. Make it happen for Alpine only (it was incorrectly being done for
OSX too.
2. Do it only when the Initialize is called for CLR initialization
Jan Kotas [Wed, 7 Mar 2018 23:27:00 +0000 (15:27 -0800)]
Add back method needed by CoreRT
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
dotnet-maestro-bot [Thu, 8 Mar 2018 04:32:11 +0000 (22:32 -0600)]
Update BuildTools, CoreFx to preview2-02607-03, preview2-26308-02, respectively (#16821)
Matt Mitchell [Thu, 8 Mar 2018 02:22:20 +0000 (18:22 -0800)]
Workaround coreclr issue (#16828)
VSTS does not seem to be correctly honoring the working directory for batch script steps. Explicitly qualify the setup_vs_env.cmd path
Sergey Andreenko [Thu, 8 Mar 2018 01:26:27 +0000 (17:26 -0800)]
[RyuJIt] Clean and fix gen return (#16725)
* create genSimpleReturn for arm64
* create genFloatReturn for x86
* create genLongReturn for x86 and arm
* merge genReturn
Luqun Lou [Thu, 8 Mar 2018 01:19:46 +0000 (17:19 -0800)]
Fix for issue 14144 (#16674)
Sergey Andreenko [Thu, 8 Mar 2018 00:51:56 +0000 (16:51 -0800)]
an additional assert for fgValueNumberHelperCallFunc (#16789)
Jan Kotas [Wed, 7 Mar 2018 22:47:49 +0000 (14:47 -0800)]
Delete AsReadOnly* APIs that are no longer part of the public surface (#16799)
Hugh Zabriskie [Wed, 7 Mar 2018 22:39:22 +0000 (14:39 -0800)]
Perf fix for month-day parsing ambiguity (#16782)
* Perf fix for month-day parsing ambiguity
* Use DateTime.TryCreate
Eugene Rozenfeld [Wed, 7 Mar 2018 22:16:49 +0000 (14:16 -0800)]
Remove dead code found by ILLink. (#16759)
I'm preparing changes to enable running ILLink on SPC
(similarly to what we do on corefx assemblies).
There will be a separate PR for those changes.
This PR just removes the dead code flagged by ILLink from the sources.
Jarret Shook [Wed, 7 Mar 2018 21:37:02 +0000 (13:37 -0800)]
Address issue 16800 (#16810)
kasper3 [Wed, 7 Mar 2018 21:03:35 +0000 (23:03 +0200)]
Remove libuuid from scripts and docs (#16805)
Steve MacLean [Wed, 7 Mar 2018 21:01:13 +0000 (16:01 -0500)]
[Arm64] Enable crypto test
dotnet-maestro-bot [Wed, 7 Mar 2018 19:56:51 +0000 (13:56 -0600)]
Update CoreFx to preview2-26307-06 (#16798)
Fei Peng [Wed, 7 Mar 2018 14:40:45 +0000 (06:40 -0800)]
fix inconsistent AVX/AVX2 intrinsic names (#16772)
dotnet-maestro-bot [Wed, 7 Mar 2018 06:33:16 +0000 (00:33 -0600)]
Update BuildTools, CoreClr, CoreFx to preview2-02606-05, preview2-26307-01, preview2-26307-03, respectively (#16791)
Jarret Shook [Wed, 7 Mar 2018 03:03:36 +0000 (19:03 -0800)]
Merge pull request #16662 from jashook/remove_vs2015_dependencies
Remove vs2015 build dependencies
Noah Falk [Wed, 7 Mar 2018 03:02:44 +0000 (19:02 -0800)]
Add debugger usage note (#16788)
Tanner Gooding [Tue, 6 Mar 2018 16:49:24 +0000 (08:49 -0800)]
Updating the x86 hardware-intrin test templates to use named format arguments
Mandar Sahasrabuddhe [Wed, 7 Mar 2018 00:42:46 +0000 (06:12 +0530)]
CoreFX #24343 Vector Ctor using Span (#16733)
* CoreFX #24343 Vector using Span
dotnet/corefx#24343
* CoreFX #24343 Vector using Span
dotnet/corefx#24343
* CoreFX #24343 Vector using Span
dotnet/corefx#24343
Jan Kotas [Wed, 7 Mar 2018 00:37:51 +0000 (16:37 -0800)]
Revert "Fix handling of incorrect assemblies on Unix (#16747)" (#16790)
This reverts commit
383736b96b643ba46ad290fc86601fc2d62a9436.
jashook [Mon, 5 Mar 2018 21:35:19 +0000 (13:35 -0800)]
Remove vs2015 build dependencies
Davis Goodin [Tue, 6 Mar 2018 23:33:27 +0000 (17:33 -0600)]
Merge pull request #16785 from dotnet-maestro-bot/master-UpdateDependencies
Update BuildTools, CoreClr, CoreFx to preview2-02606-04, preview2-26306-01, preview2-26306-04, respectively (master)
dotnet-maestro-bot [Tue, 6 Mar 2018 21:27:48 +0000 (13:27 -0800)]
Update BuildTools, CoreClr, CoreFx to preview2-02606-04, preview2-26306-01, preview2-26306-04, respectively
Michelle McDaniel [Tue, 6 Mar 2018 20:37:23 +0000 (12:37 -0800)]
Disable Perf Runs on Commit (#16781)
We need to disable these jobs on commit until dotnet/core-eng#2808 is fixed.
Koundinya Veluri [Tue, 6 Mar 2018 19:42:13 +0000 (11:42 -0800)]
Fix hang on Ctrl+C when tiering is enabled (#16719)
Fix hang on Ctrl+C when tiering is enabled
- When the work thread count is nonzero at the time of Ctrl+C, by the time `TieredCompilationManager::Shutdown(BOOL)` runs (during `DllMain` for process detach), the background worker thread has already been torn down abruptly and it does not get a chance to exit gracefully and set the event, and Shutdown() hangs the process waiting for the event forever.
- It looks like there is no benefit to waiting for the work to complete, fixed by removing the wait and the event
- In the MusicStore benchmark it looks like the arch folder was missing in the 'publish' folder path. In case there is a difference in bin directory layout between the CI dotnet and current dotnet, changed to check for both paths.
Brian Robbins [Tue, 6 Mar 2018 19:31:40 +0000 (11:31 -0800)]
Convert Byte Arrays to Hexidecimal Strings When Writing to LTTng via EventSource (#16762)
Levi Broderick [Tue, 6 Mar 2018 17:11:52 +0000 (09:11 -0800)]
Fix potential buffer overrun in ClearWithReferences
Brian Sullivan [Tue, 6 Mar 2018 18:29:37 +0000 (10:29 -0800)]
Merge pull request #16700 from briansull/fix_dyn_blk
Fix morph issue with a fixed size block copy
Brian Robbins [Tue, 6 Mar 2018 10:51:22 +0000 (02:51 -0800)]
Add tracepointprovider.cpp directly to PAL instead of to a separate tracepointprovider library. (#16771)
Levi Broderick [Tue, 6 Mar 2018 02:18:23 +0000 (18:18 -0800)]
Fix whitespace
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Levi Broderick [Tue, 6 Mar 2018 02:00:07 +0000 (18:00 -0800)]
Fix whitespace
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Levi Broderick [Tue, 6 Mar 2018 01:26:38 +0000 (17:26 -0800)]
Improve performance of Span.Clear for referential T
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Ruben Ayrapetyan [Tue, 6 Mar 2018 06:37:43 +0000 (06:37 +0000)]
Fix handling of incorrect assemblies on Unix (#16747)
* Return DPTR from PEDecoder::FindFirstSection()
Change type of the function's return value
to PTR_IMAGE_SECTION_HEADER instead of (IMAGE_SECTION_HEADER *)
* Fix handling of incorrect assemblies on Unix
This fixes the regression that was introduced by #10772 and is
caused by a missing check for validity of loaded assembly file.
Related issue: #15544
Marco Rossignoli [Tue, 6 Mar 2018 03:31:06 +0000 (04:31 +0100)]
address PR feedback (#16761)
Jacek Blaszczynski [Thu, 1 Mar 2018 18:27:49 +0000 (19:27 +0100)]
Add LoadHigh, LoadLow, and SetScalarVector128 SSE2 HW intrinsics tests
Jacek Blaszczynski [Thu, 1 Mar 2018 18:26:29 +0000 (19:26 +0100)]
Implement LoadHigh, LoadLow, and SetScalarVector128 SSE2 HW intrinsics
Fei Peng [Mon, 5 Mar 2018 21:23:15 +0000 (13:23 -0800)]
Simplify SSE/SSE4.1 intrinsics
dotnet-maestro-bot [Tue, 6 Mar 2018 01:58:43 +0000 (19:58 -0600)]
Update BuildTools, CoreClr to preview2-02606-01, preview2-26305-12, respectively (#16760)
Jan Vorlicek [Tue, 6 Mar 2018 01:21:09 +0000 (02:21 +0100)]
Remove libuuid usage (#16643)
* Remove libuuid usage
This change removes dependency on the libuuid library that is used for GUID creation only.
It implements it using a random generator instead.
It also modifies return type of PAL_Random to VOID since it was always
returning TRUE and none of the existing callers were checking it.
1. Port the GUID creation to managed code.
2. Modify the PAL_Random to have 6 times better perf so that the perf of the
CoCreateGuid that is used in the native runtime doesn't degrade that much
w.r.t the previous state when the libuuid was used.
3. Use Interop.GetRandomBytes on Unix and fix Windows
JC Aguilera [Tue, 6 Mar 2018 00:35:20 +0000 (16:35 -0800)]
SCEP package version update
Carol Eidt [Mon, 5 Mar 2018 21:41:07 +0000 (22:41 +0100)]
Merge pull request #16727 from CarolEidt/NoIndirByte
Don't force byte regs for indir address
Sergey Andreenko [Mon, 5 Mar 2018 21:38:31 +0000 (13:38 -0800)]
[ARM32] RyuJIT support for profiler ELT callbacks (#16728)
* add assert that argReg was PreSpilled
* genProfilingEnterCallback for RyuJit arm
* fix genProfilingLeaveCallback for RyuJit arm
* call genProfilingLeaveCallback for arm from genJmpMethod
JC Aguilera [Mon, 5 Mar 2018 20:43:48 +0000 (12:43 -0800)]
Update SCEP package version
Tanner Gooding [Wed, 28 Feb 2018 04:53:11 +0000 (20:53 -0800)]
Updating the CompareEqual{Ordered|Unordered}Scalar intrinsics to have slightly better codegen
dotnet-maestro-bot [Mon, 5 Mar 2018 19:13:14 +0000 (13:13 -0600)]
Update CoreClr, CoreFx to preview2-26305-04, preview2-26305-02, respectively (#16755)
Marco Rossignoli [Mon, 5 Mar 2018 18:09:24 +0000 (19:09 +0100)]
Scrub error messages for missing arguments(throw new) (#16753)
Vance Morrison [Mon, 5 Mar 2018 18:08:35 +0000 (10:08 -0800)]
Change COMPLus -> COMPlus
JC Aguilera [Mon, 5 Mar 2018 17:34:47 +0000 (09:34 -0800)]
Remove ConfigFile parameter which is not set on previous tasks
Carol Eidt [Mon, 5 Mar 2018 17:33:47 +0000 (18:33 +0100)]
Merge pull request #16731 from tannergooding/hwintrin-avx
Implementing the ConvertToVector AVX hardware intrinsics
Jan Kotas [Mon, 5 Mar 2018 16:36:39 +0000 (08:36 -0800)]
Delete dead code in PAL related to file locks (#16754)
Jan Vorlicek [Mon, 5 Mar 2018 15:15:24 +0000 (16:15 +0100)]
Remove flock usage from InternalCreateFile in PAL (#16752)
This flock is causing issues on filesystems that don't support locking.
An issue with loading managed assemblies from such a filesystem due to
this issue was recently hit by someone.
Since the locking in the PAL is not really needed and due to the
advisory nature of the flock doesn't guarantee anything, this change is
removing the flock from that function.
dotnet-maestro-bot [Mon, 5 Mar 2018 04:36:47 +0000 (22:36 -0600)]
Update CoreClr, CoreFx to preview2-26305-01, preview2-26305-01, respectively (#16740)
Jan Kotas [Mon, 5 Mar 2018 04:05:50 +0000 (20:05 -0800)]
Fix encoding methods for Span.Empty (#16748)
* Fix encoding methods for Span.Empty
Encoding had a historic confusion about handling null pointers. Make sure that this confusion is not leaking into the new Span methods.
* Use GetNonNullPinnableReference helper method
Stephen Toub [Sun, 4 Mar 2018 20:55:34 +0000 (15:55 -0500)]
Delete stale TryFormat and {Try}Parse overloads (#16746)
dotnet bot [Sun, 4 Mar 2018 17:10:39 +0000 (09:10 -0800)]
Clear executable bit on several .cs files (#16743)
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Sergey Andreenko [Sun, 4 Mar 2018 09:10:12 +0000 (01:10 -0800)]
fix legacy backend (#16741)
Jan Kotas [Sun, 4 Mar 2018 07:13:55 +0000 (23:13 -0800)]
Clear executable bit on several .cs files
Brian Robbins [Sun, 4 Mar 2018 05:00:42 +0000 (21:00 -0800)]
Update TraceLogging to use NULL-terminated strings instead of counted strings (#16672)
Brian Robbins [Sun, 4 Mar 2018 04:56:43 +0000 (20:56 -0800)]
Fix use of EventPipeConfiguration after it has been freed on shutdown. (#16704)
dotnet-maestro-bot [Sun, 4 Mar 2018 03:32:42 +0000 (21:32 -0600)]
Update CoreClr to preview2-26304-01 (#16739)
Ahson Khan [Sun, 4 Mar 2018 01:55:31 +0000 (17:55 -0800)]
Fix MemoryDebugView and override Memory.ToString similar to Span (#16732)
* Fix MemoryDebugView and add Memory.ToString similar to Span
* Simplify implementation of ToString
Ahson Khan [Sun, 4 Mar 2018 01:48:07 +0000 (17:48 -0800)]
Remove StringSpanHelpers and start using MemoryExtensions (#16718)
* Remove StringSpanHelpers and start using MemoryExtensions
* Address PR feedback.
dotnet-maestro-bot [Sat, 3 Mar 2018 20:56:01 +0000 (14:56 -0600)]
Update CoreClr, CoreFx to preview2-26303-09, preview2-26303-04, respectively (master) (#16730)
* Update CoreClr, CoreFx to preview2-26303-09, preview2-26303-04, respectively
* Add System.Runtime.Intrinsics.Experimental to test dependencies
Tanner Gooding [Sat, 3 Mar 2018 06:03:09 +0000 (22:03 -0800)]
Implementing tests for more of the AVX hardware intrinsics
Tanner Gooding [Fri, 2 Mar 2018 16:07:15 +0000 (08:07 -0800)]
Implementing some more of the AVX intrinsics
Fei Peng [Sat, 3 Mar 2018 00:34:03 +0000 (16:34 -0800)]
Implement AVX/AVX BroadcastScalarToVector*
Carol Eidt [Sat, 3 Mar 2018 03:15:21 +0000 (04:15 +0100)]
Merge pull request #15777 from dotnetrt/sse2part2
Implement Shuffle* Sse2 Intel hardware intrinsics
Egor Chesakov [Sat, 3 Mar 2018 00:39:36 +0000 (16:39 -0800)]
Use TARGET_POINTER_SIZE macro (#16640)
* Replace sizeof(void*) with TARGET_POINTER_SIZE in TYPEINFO in src/inc/cortypeinfo.h
* Replace sizeof(LPVOID) with TARGET_POINTER_SIZE in DEFINEELEMENTTYPEINFO in src/vm/siginfo.cpp
* Define TARGET_POINTER_SIZE as POINTERSIZE_BYTES in src/ToolBox/SOS/Strike/util.h
Carol Eidt [Fri, 2 Mar 2018 19:08:42 +0000 (11:08 -0800)]
Don't force byte regs for indir address
JC Aguilera [Fri, 2 Mar 2018 23:40:31 +0000 (15:40 -0800)]
Merge pull request #16638 from jcagme/master
Install and uninstall SCEP
Juan Carlos Aguilera Mendez [Fri, 2 Mar 2018 23:33:13 +0000 (15:33 -0800)]
final set of comments been addressed
Juan Carlos Aguilera Mendez [Fri, 2 Mar 2018 23:20:19 +0000 (15:20 -0800)]
Remove variable
Juan Carlos Aguilera Mendez [Fri, 2 Mar 2018 23:13:55 +0000 (15:13 -0800)]
Remove creation of Auth'd nuget.config
Stephen Toub [Fri, 2 Mar 2018 19:41:23 +0000 (14:41 -0500)]
Fix netstandard build references to UnsafeTask
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Jacek Blaszczynski [Wed, 28 Feb 2018 05:11:12 +0000 (06:11 +0100)]
Add Shuffle* Sse2 hardware intrinsics tests
Jacek Blaszczynski [Wed, 28 Feb 2018 05:08:55 +0000 (06:08 +0100)]
Implement Shuffle* SSE2 hardware intrinsics
Juan Carlos Aguilera Mendez [Fri, 2 Mar 2018 22:21:46 +0000 (14:21 -0800)]
Yet one more reverted change in PR
Juan Carlos Aguilera Mendez [Fri, 2 Mar 2018 22:20:43 +0000 (14:20 -0800)]
One more reverted change in PR
Juan Carlos Aguilera Mendez [Fri, 2 Mar 2018 22:19:44 +0000 (14:19 -0800)]
Merge branch 'master' of https://github.com/jcagme/coreclr