Brian Osman [Fri, 31 Mar 2017 14:59:10 +0000 (10:59 -0400)]
Allow FPs to elevate default precision for the entire fragment program
Currently, GrConfigConversionEffect is able to round-trip on many mobile
GPUs because it uses highp for all intermediate variables (including the
texture fetch result). Separating the texture sample into a different
processor breaks that.
This is a blunt instrument, not to be used lightly.
Bug: skia:
Change-Id: I2ab365e3da79628069e2eb727c43c2bf45bfd789
Reviewed-on: https://skia-review.googlesource.com/10162
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Mike Reed [Fri, 31 Mar 2017 13:20:50 +0000 (09:20 -0400)]
clean up (partially) colortable api
Needs this to land: https://codereview.chromium.org/
2789853002/
Bug: skia:
Change-Id: I38d916a546b7fa64d000d973e695ddda24a589e7
Reviewed-on: https://skia-review.googlesource.com/10600
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Matt Sarett <msarett@google.com>
Ethan Nicholas [Fri, 31 Mar 2017 13:33:41 +0000 (09:33 -0400)]
skslc can now be compiled with no Skia dependencies, in preparation for its eventual
role in Skia's build process.
This reverts commit
bcf35f86d50b784b165de703b404998dd4299f6a.
BUG=skia:
Change-Id: Id0a12dfc4d804d69a3c6bf60fed37e89ee130f02
Reviewed-on: https://skia-review.googlesource.com/10802
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Mike Klein [Fri, 31 Mar 2017 14:29:40 +0000 (10:29 -0400)]
jumper, another batch of blend modes
Change-Id: I0c48ec80eee8b7c7e9fb980efa8ed1dad5ad9768
Reviewed-on: https://skia-review.googlesource.com/10924
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Mike Klein [Fri, 31 Mar 2017 13:29:01 +0000 (09:29 -0400)]
jumper, more blend modes
Change-Id: I17ce08a7ec62ef8ffe8ae567079d669a87ef9a9c
Reviewed-on: https://skia-review.googlesource.com/10921
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Brian Salomon [Fri, 31 Mar 2017 12:08:15 +0000 (12:08 +0000)]
Revert "Respect kRectsMustMatchForMSAASrc_BlitFramebufferFlag in dst setup"
This reverts commit
e0ff6ab272dcc5c4d6f3b509da7e0e97acada814.
Reason for revert: a bunch of bots failed.
Original change's description:
> Respect kRectsMustMatchForMSAASrc_BlitFramebufferFlag in dst setup
>
> Crurently, when preparing a texture for blitFramebuffer, we ignore the
> kRectsMustMatchForMSAASrc_BlitFramebufferFlag, and may attempt to
> copy from one src rect to a different dst rect.
>
> This change updates initDescForDstCopy and setupDstTexture to allocate
> larger textures if necessary and accomodate this flags requirements.
>
> Bug: 658277
> Change-Id: I500f10dba5700f5f7a7acad04bcdbc9ac9994835
> Reviewed-on: https://skia-review.googlesource.com/10247
> Commit-Queue: Brian Salomon <bsalomon@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>
>
TBR=bsalomon@google.com,ericrk@chromium.org,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Change-Id: I7fbd6c2652fe71c707d3120b035e0365fbc7fa66
Reviewed-on: https://skia-review.googlesource.com/10920
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Mike Klein [Wed, 29 Mar 2017 16:41:13 +0000 (12:41 -0400)]
ok, most features can be vias
This refactors most features out of ok's core into vias:
-w --> a .png dumping via, "png", opening the door to other types
-m/-s --> a filtering via "filter"
Everything now can print a brief help message too.
Change-Id: I9e653aab98fd57182a6d458c7a80052130980284
Reviewed-on: https://skia-review.googlesource.com/10509
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Eric Karl [Thu, 30 Mar 2017 22:19:07 +0000 (15:19 -0700)]
Respect kRectsMustMatchForMSAASrc_BlitFramebufferFlag in dst setup
Crurently, when preparing a texture for blitFramebuffer, we ignore the
kRectsMustMatchForMSAASrc_BlitFramebufferFlag, and may attempt to
copy from one src rect to a different dst rect.
This change updates initDescForDstCopy and setupDstTexture to allocate
larger textures if necessary and accomodate this flags requirements.
Bug: 658277
Change-Id: I500f10dba5700f5f7a7acad04bcdbc9ac9994835
Reviewed-on: https://skia-review.googlesource.com/10247
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Brian Salomon [Thu, 30 Mar 2017 20:48:26 +0000 (16:48 -0400)]
Respect xfer barriers in InstancedRendering::Op
Fixes a bug introduced when this Op stopped storing a GrPipeline.
Change-Id: I1a39814cebe18b321ea369f005bb7759f233cfe6
Reviewed-on: https://skia-review.googlesource.com/10804
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Mike Klein [Fri, 31 Mar 2017 00:07:52 +0000 (20:07 -0400)]
tell Google3 we do not need executable stack
Change-Id: I5ff3599448d027fcac43a53e98a801ce672ce5ee
Reviewed-on: https://skia-review.googlesource.com/10861
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Mike Klein [Thu, 30 Mar 2017 22:30:50 +0000 (18:30 -0400)]
avoid deprecated SkRect::MakeFromIRect
Change-Id: I55a5fd92b4b53b2676983233619cee4875967e01
Reviewed-on: https://skia-review.googlesource.com/10860
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Matt Sarett [Thu, 30 Mar 2017 21:23:48 +0000 (17:23 -0400)]
SkColorSpaceXformCanvas: setMatrix(), clipRect() in constructor
BUG=703363
Change-Id: Ie0053940dd041614b93400e34145118fb0742cae
Change-Id: Ie0053940dd041614b93400e34145118fb0742cae
Reviewed-on: https://skia-review.googlesource.com/10806
Commit-Queue: Matt Sarett <msarett@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Matt Sarett [Thu, 30 Mar 2017 20:10:45 +0000 (16:10 -0400)]
Add more overrides to SkColorSpaceXformCanvas
Number of matching gms is unchanged.
Bug: skia:
Change-Id: I43961c716899ddacc560dd7888d4427563cdf7ca
Reviewed-on: https://skia-review.googlesource.com/10805
Commit-Queue: Matt Sarett <msarett@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Mike Klein [Wed, 29 Mar 2017 21:32:50 +0000 (17:32 -0400)]
Turn on SkJumper all the time, try 2.
Rebased on top of _win.S change, which I hope lands first.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel,win_chrome_official,win_chromium_dbg_ng,win_chromium_rel_ng,win_chromium_compile_dbg_ng,win_chromium_compile_rel_ng,win_clang;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I30e97dbb55b8a42251b46f5607096ca12bc670b9
Reviewed-on: https://skia-review.googlesource.com/10462
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Herb Derby <herb@google.com>
Ethan Nicholas [Thu, 30 Mar 2017 18:11:58 +0000 (14:11 -0400)]
fixed skslc SPIR-V memory error
BUG=skia:6446
Change-Id: Ibc55124db60d6a05964ddcd02d285e313379f93e
Reviewed-on: https://skia-review.googlesource.com/10756
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Kevin Lubick [Thu, 30 Mar 2017 18:50:09 +0000 (14:50 -0400)]
Add Linux HD2000 jobs
Bug: skia:6400
NOTRY=TRUE
Change-Id: I253ef2d0b137a4a36f26dcabb8cc4a1919ed9b60
Reviewed-on: https://skia-review.googlesource.com/10759
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Ben Wagner [Thu, 30 Mar 2017 19:01:32 +0000 (15:01 -0400)]
Remove Galaxy J5 bot.
NOTRY=true
Change-Id: I9288e5928a08fc57545866aad1cc8b70f86eed6d
Reviewed-on: https://skia-review.googlesource.com/10801
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Jim Van Verth [Thu, 30 Mar 2017 18:28:08 +0000 (14:28 -0400)]
Add glPolygonMode support.
Mainly added because it's useful for rendering in wireframe mode.
Change-Id: I84dab43ce5b56a48d47dd16d4c98fa7648bb1f0b
Reviewed-on: https://skia-review.googlesource.com/10530
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Mike Klein [Wed, 29 Mar 2017 23:29:13 +0000 (19:29 -0400)]
make _win.S know if it's 64-bit
I think this is the root of my Windows / Chrome problems.
Even on 32-bit builds, Chrome compiles nacl64.exe in 64-bit mode.
So to make things simple, always put _win.S in the sources,
and no-op it away when assembling for 32-bit.
Change-Id: I19f163491739a6c0cbdedd0ce353f1d2289907ae
Reviewed-on: https://skia-review.googlesource.com/10637
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Ethan Nicholas [Thu, 30 Mar 2017 18:42:48 +0000 (18:42 +0000)]
Revert "skslc can now be compiled with no Skia dependencies, in preparation for"
This reverts commit
7833466da45bfa1e078427c4a6db94d41c5c1535.
Reason for revert: Vulkan assertion failure
Original change's description:
> skslc can now be compiled with no Skia dependencies, in preparation for
> its eventual role in Skia's build process.
>
> Bug: skia:
> Change-Id: Iaa9933f4fc4a64bec60aa897c509a3513f457a78
> Reviewed-on: https://skia-review.googlesource.com/10282
> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
>
TBR=egdaniel@google.com,benjaminwagner@google.com,ethannicholas@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Change-Id: Ic64cac2395abb406116885ddd725f74a434c8c49
Reviewed-on: https://skia-review.googlesource.com/10758
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Ethan Nicholas [Thu, 30 Mar 2017 17:45:54 +0000 (13:45 -0400)]
skslc can now be compiled with no Skia dependencies, in preparation for
its eventual role in Skia's build process.
Bug: skia:
Change-Id: Iaa9933f4fc4a64bec60aa897c509a3513f457a78
Reviewed-on: https://skia-review.googlesource.com/10282
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Matt Sarett [Thu, 30 Mar 2017 16:41:48 +0000 (12:41 -0400)]
Make xformer class for SkCSXCanvas, use for draw loopers
Fixes draw looper gms in gbr-8888 config.
Bug: skia:
Change-Id: I0a9306cc0523c82f2ad9516752d79c1d86b1e295
Reviewed-on: https://skia-review.googlesource.com/10644
Commit-Queue: Matt Sarett <msarett@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Ben Wagner [Thu, 30 Mar 2017 14:19:24 +0000 (10:19 -0400)]
Use the rounded text size for gasp.
When comparing against gasp ranges always use the rounded (gdi) size.
Previously the truncated size was used, but it appears other
implementations are using the rounded size.
BUG=chromium:706693
Change-Id: I0f545175bf2d5f4e8db610b26c2f3e21a89eeb2a
Reviewed-on: https://skia-review.googlesource.com/10751
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Ben Wagner <bungeman@google.com>
Robert Phillips [Thu, 30 Mar 2017 14:58:57 +0000 (10:58 -0400)]
Minor cleanup (remove unused GrRenderTargetContext::asTexture method)
Change-Id: I719204e9870b3c849a5c60d967359a70138e6c9c
Reviewed-on: https://skia-review.googlesource.com/10753
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Brian Salomon [Thu, 30 Mar 2017 14:22:28 +0000 (10:22 -0400)]
Use correct tolerance for conic chopping in MSAA and default path renderers
Bug: 706581
Change-Id: I16b3037380508316fc73ab7a8cebf960de66938e
Reviewed-on: https://skia-review.googlesource.com/10752
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
bungeman [Wed, 29 Mar 2017 22:05:45 +0000 (18:05 -0400)]
Update instructions on Skia/Chromium multi try.
Change-Id: I7ac583dbf04d18210847c54f7c69cf8a4f46deea
Reviewed-on: https://skia-review.googlesource.com/10597
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Ben Wagner <bungeman@google.com>
bungeman [Wed, 29 Mar 2017 17:38:53 +0000 (13:38 -0400)]
Use last value for axis for variation position.
SkFontArguments::VariationPosition may be over specified. If there are
multiple values for a given axis, ensure the last value specified is
used, since that's what css-fonts-4 requires.
BUG=chromium:674878
Change-Id: I6704c15c520c89efb9ee84659a3e16e0d07691c9
Reviewed-on: https://skia-review.googlesource.com/10513
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Brian Salomon [Thu, 30 Mar 2017 12:21:32 +0000 (08:21 -0400)]
Renames of processor analysis-related classes and method.
GrProcesserSet::FragmentProcessorAnalysis->GrProcessorSet::Analysis
GrPipelineAnalysisColor->GrProcessorAnalysisColor
GrPipelineAnalysisCoverage->GrProcessorAnalysisCoverage
GrMeshDrawOp::getFragmentProcessorAnalysisInputs->GrMeshDrawOp::getProcessorAnalysisInputs
Change-Id: I28ad19dfab5f4ac1788c4eacdec5e1af2a701dd0
Reviewed-on: https://skia-review.googlesource.com/10747
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Brian Salomon [Thu, 30 Mar 2017 01:28:20 +0000 (21:28 -0400)]
Don't perform analysis twice in InstancedRendering::Op
Change-Id: Ie0aeeb7bf63090b0c27a9b062cce0cdc561a1d7e
Reviewed-on: https://skia-review.googlesource.com/10583
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Robert Phillips [Thu, 30 Mar 2017 12:02:11 +0000 (08:02 -0400)]
Add GrSurfaceProxy* parameter to GrContext::flush
Split out of: https://skia-review.googlesource.com/c/10284/ (Omnibus: Remove GrSurface-derived classes from ops)
Change-Id: I12c66a6fa826c2363b21ece56391fb352d12d6b3
Reviewed-on: https://skia-review.googlesource.com/10541
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Robert Iannucci [Wed, 29 Mar 2017 21:41:50 +0000 (14:41 -0700)]
[recipes.cfg] Disable autoroller
Bug: skia:
Change-Id: Ie87deb32bf2fb257b1aac25bdef9d5c978d0320b
Reviewed-on: https://skia-review.googlesource.com/10542
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
Matt Sarett [Thu, 30 Mar 2017 00:00:18 +0000 (20:00 -0400)]
Reverse clamp logic in SkColorSpaceXform
Follow-up from https://skia-review.googlesource.com/c/10581/
Bug: skia:
Change-Id: I499f0908e1375854202c1cfd476827500fc89237
Reviewed-on: https://skia-review.googlesource.com/10645
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Mike Klein [Wed, 29 Mar 2017 22:21:14 +0000 (18:21 -0400)]
Don't export stage symbols.
Chromium Mac bots are getting tripped up by stages being visible.
.hidden and .private_extern are -fvisibilty=hidden for ELF and MACH-O.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Mac-Clang-arm-Debug-iOS
Change-Id: I8dbb04f514eead4ab480664f2674db4b57611b84
Reviewed-on: https://skia-review.googlesource.com/10622
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Matt Sarett [Wed, 29 Mar 2017 21:12:26 +0000 (17:12 -0400)]
565 color xforms: make sure we clamp if necessary
Bug: skia:
Change-Id: I48528a0ff8dd199e0cd1649f973b5722384eacf3
Reviewed-on: https://skia-review.googlesource.com/10581
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>
Mike Klein [Wed, 29 Mar 2017 20:33:06 +0000 (16:33 -0400)]
jumper, revert to generating .S files
I went with the unified-in-one-.cpp approach mostly to make it easy to
roll out SkJumper. I no longer see any difficultly rolling out the
assembly files, and it's possible the unified .cpp approach just makes
things harder.
Let's see if it's any easier to get Chrome's official build to work with
normal assembly files. It's not going to be a problem to roll out.
This is a partial revert of https://skia-review.googlesource.com/c/9336.
CQ_INCLUDE_TRYBOTS=skia.primary:Test-Win2k8-MSVC-GCE-CPU-AVX2-x86_64-Debug,Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Debug,Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Debug,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug
Change-Id: Idfdbd2d322452b44bc0adaf6dc299cc7649bc51e
Reviewed-on: https://skia-review.googlesource.com/10561
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Jim Van Verth [Wed, 29 Mar 2017 18:37:28 +0000 (14:37 -0400)]
Fix is_convex() check for inset polys.
Change-Id: I1a8a24132b0cf9eb80dd586bf2f1b930adb7b582
Reviewed-on: https://skia-review.googlesource.com/10525
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Brian Salomon [Wed, 29 Mar 2017 18:25:04 +0000 (14:25 -0400)]
Make analysis optional to GrPipeline::init().
GrXPFactory::createXferProcessor now takes GrPipelineAnalysisColor and GrPipelineAnalysisCoverage rather than GrProcessorSet::FragmentProcessorAnalysis.
This will make it so ops do not have to retain the analysis or rerun it to create pipelines at flush time.
Change-Id: Ib28ba65de425b20c2647329275f209aec168c3df
Reviewed-on: https://skia-review.googlesource.com/10474
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Greg Daniel [Tue, 28 Mar 2017 19:40:53 +0000 (15:40 -0400)]
Remove blacklist of Vulkan GPUMemoryTest
This was blacklisted on Nvidia Windows. A recent change was made that may
be a possible fix for this test involving the uploading of initial mip map
memory.
BUG=skia:6092
Change-Id: Ie75c4665bea1f5139a674b9e0f53a9aac4a97f98
Reviewed-on: https://skia-review.googlesource.com/10285
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Robert Phillips [Wed, 29 Mar 2017 17:06:57 +0000 (13:06 -0400)]
More GrSurfaceProxy-clean up
Split out of: https://skia-review.googlesource.com/c/10484/ (Omnibus: Push instantiation of GrTextures later (post TextureSampler))
Change-Id: I1ee39a23c749e420dce0ad561ee1c8b09bdcc763
Reviewed-on: https://skia-review.googlesource.com/10485
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
bungeman [Wed, 29 Mar 2017 15:32:02 +0000 (11:32 -0400)]
Use FontWeight symbols when available on Mac.
Newer versions of macOS have NSFontWeightXXX symbols and iOS has
UIFontWeightXXX symbols to provide the conversion between [-1, 1]
CTFontDescriptor weights and [0, 1000] CSS weights. Currently the
values these symbols provide are hard coded (for expediency), but the
symbols should be used when available since the values may change
without notice.
Change-Id: I0875c6a96c5b14e456f91bccf7a84f0306a3d63a
Reviewed-on: https://skia-review.googlesource.com/10163
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Ben Wagner <bungeman@google.com>
Robert Phillips [Wed, 29 Mar 2017 16:08:49 +0000 (12:08 -0400)]
Miscellaneous GrSurfaceProxy-related cleanup
This is pulled out of: https://skia-review.googlesource.com/c/10284/ (Remove GrSurface-derived classes from ops)
Change-Id: I083c0beefe4899b3517d0b0569bb25096809f410
Reviewed-on: https://skia-review.googlesource.com/10483
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Brian Salomon [Wed, 29 Mar 2017 16:09:15 +0000 (12:09 -0400)]
Remove GrPipelineOptimizations computation from GrPipeline::init and nest in GrMeshDrawOp.
Change-Id: I4a702c83857606c1cb050294c408922eef5769ea
Reviewed-on: https://skia-review.googlesource.com/10414
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Kevin Lubick [Wed, 29 Mar 2017 15:19:01 +0000 (11:19 -0400)]
Add skia_use_egl flag
This allows us to specify it for Linux Arm devices (like chromebooks, and
possibly RPIs)
Bug: skia:6442
Change-Id: I043bc3b3686caf28fedfe1a6ab1dfd300cc4f066
Reviewed-on: https://skia-review.googlesource.com/10469
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Greg Daniel [Tue, 28 Mar 2017 18:56:46 +0000 (14:56 -0400)]
Fix copy offset when uploading initial mip data in Vulkan
This is a fix to an original fix which was reverted
BUG=skia:
Change-Id: I21fcda28a5d342984784a35d2b3e985c6e4199cf
Reviewed-on: https://skia-review.googlesource.com/10290
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Ben Wagner [Wed, 29 Mar 2017 14:27:56 +0000 (10:27 -0400)]
Remove SK_IGNORE_DW_GRAY_FIX.
Users have been updated and this define is no longer used.
Change-Id: I0430039978171c16ffe19fb3037897bcdf313e42
Reviewed-on: https://skia-review.googlesource.com/10417
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Forrest Reiling [Tue, 28 Mar 2017 06:22:20 +0000 (23:22 -0700)]
Add unistd.h include to GrVkGpu.cpp on unix for sleep
Fixes Fuchsia build
Change-Id: Ieb3b7092586495f5153ba18d14a94d8dcdab1dbd
Reviewed-on: https://skia-review.googlesource.com/10261
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Ben Wagner [Wed, 29 Mar 2017 14:02:00 +0000 (10:02 -0400)]
Marker for driver update on Win10 Golo GT610
BUG=chromium:705001
NOTRY=true
Change-Id: I84c888cec3ed644be4ef1bf5f7ea219bf3b8ded3
Reviewed-on: https://skia-review.googlesource.com/10411
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Brian Salomon [Tue, 28 Mar 2017 20:32:05 +0000 (16:32 -0400)]
Remove GrXferProcessor::getOptimizations.
This replaces GrXferProcessor::getOptimizations with a new function on GrXPFactory. The results are made available via FragmentProcessorAnalysis.
Bug: skia:
Change-Id: I535985458c9d13ad858cac94e957e2fdbe332036
Reviewed-on: https://skia-review.googlesource.com/10218
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Robert Phillips [Tue, 28 Mar 2017 21:11:19 +0000 (17:11 -0400)]
Retract GrPipeline from setRenderTargetState calls
Split out of: https://skia-review.googlesource.com/c/10284/ (Remove GrSurface-derived classes from ops)
Change-Id: Ib3dda649875b8da31def20476e4b5a87a4aa7cac
Reviewed-on: https://skia-review.googlesource.com/10320
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Robert Phillips [Tue, 28 Mar 2017 20:21:27 +0000 (16:21 -0400)]
Remove GrSurface::flushWrites
Change-Id: Ifac5af00ef852ee212964baa113b490a03e0168d
Reviewed-on: https://skia-review.googlesource.com/10293
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Kevin Lubick [Wed, 29 Mar 2017 12:00:06 +0000 (08:00 -0400)]
Update Galaxy S7s to March 2017 patch
Bug: skia:6434
NOTRY=true
NOTREECHECKS=true
Change-Id: I7daaccbf14facb4dec8929e0e819add7c4e41a46
Reviewed-on: https://skia-review.googlesource.com/10398
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
recipe-roller [Tue, 28 Mar 2017 23:11:58 +0000 (16:11 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
build:
https://crrev.com/
bb49d6609717078440ca257a1960cd34033bd047 build_scan.py: Add scripts/master to path (hinoka@google.com)
TBR=iannucci@chromium.org
Change-Id: I6ccf0620c27c3bbcda4c9093a6e8ef79fbd0f967
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://skia-review.googlesource.com/10335
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
recipe-roller [Tue, 28 Mar 2017 23:02:09 +0000 (16:02 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
build:
https://crrev.com/
bb49d6609717078440ca257a1960cd34033bd047 build_scan.py: Add scripts/master to path (hinoka@google.com)
TBR=iannucci@chromium.org
Change-Id: I10045227a914796ac5cae9f5f638b2b084ad15a6
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://skia-review.googlesource.com/10334
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
recipe-roller [Tue, 28 Mar 2017 22:51:47 +0000 (15:51 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
build:
https://crrev.com/
bb49d6609717078440ca257a1960cd34033bd047 build_scan.py: Add scripts/master to path (hinoka@google.com)
TBR=iannucci@chromium.org
Change-Id: Ia2d6af47decbe6dee57071f5606c898cf517d919
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://skia-review.googlesource.com/10333
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
recipe-roller [Tue, 28 Mar 2017 22:42:16 +0000 (15:42 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
build:
https://crrev.com/
bb49d6609717078440ca257a1960cd34033bd047 build_scan.py: Add scripts/master to path (hinoka@google.com)
TBR=iannucci@chromium.org
Change-Id: I82c58c585d6a3e470aee13b788c32c52cc6e6297
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://skia-review.googlesource.com/10332
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
recipe-roller [Tue, 28 Mar 2017 22:32:02 +0000 (15:32 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
build:
https://crrev.com/
d67cc72477ac9cf51dac9ff5aa56fd5f996f09d9 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
https://crrev.com/
720ae5cfa1f63afa71fa2e753a3d43cc0b166b28 [recipes.cfg] set autoroll recipe options (iannucci@chromium.org)
depot_tools:
https://crrev.com/
b2e5564353be2974b1241d1bd57b3259100b14ea [recipes.cfg] set autoroll recipe options (iannucci@chromium.org)
TBR=borenet@google.com
Change-Id: I5f5f7f8186224fb35c5fb34df07a79616c08aac7
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://skia-review.googlesource.com/10331
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
recipe-roller [Tue, 28 Mar 2017 22:22:02 +0000 (15:22 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
build:
https://crrev.com/
d67cc72477ac9cf51dac9ff5aa56fd5f996f09d9 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
https://crrev.com/
720ae5cfa1f63afa71fa2e753a3d43cc0b166b28 [recipes.cfg] set autoroll recipe options (iannucci@chromium.org)
depot_tools:
https://crrev.com/
b2e5564353be2974b1241d1bd57b3259100b14ea [recipes.cfg] set autoroll recipe options (iannucci@chromium.org)
TBR=borenet@google.com
Change-Id: Ie6076adc7f44992cf63ee7ed86f70896a6cec5b7
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://skia-review.googlesource.com/10330
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Brian Salomon [Tue, 28 Mar 2017 20:51:02 +0000 (16:51 -0400)]
Add debug helper for finding leaks in GrMemoryPool.h
Change-Id: I1d11769f9e99606af5e7752b3a6d055a5bf6a48d
Reviewed-on: https://skia-review.googlesource.com/10289
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
recipe-roller [Tue, 28 Mar 2017 22:12:46 +0000 (15:12 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
build:
https://crrev.com/
d67cc72477ac9cf51dac9ff5aa56fd5f996f09d9 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
https://crrev.com/
720ae5cfa1f63afa71fa2e753a3d43cc0b166b28 [recipes.cfg] set autoroll recipe options (iannucci@chromium.org)
depot_tools:
https://crrev.com/
b2e5564353be2974b1241d1bd57b3259100b14ea [recipes.cfg] set autoroll recipe options (iannucci@chromium.org)
TBR=borenet@google.com
Change-Id: Ie827fe882fc5ec16a539b590d1b76575766118a1
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://skia-review.googlesource.com/10329
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
recipe-roller [Tue, 28 Mar 2017 22:08:13 +0000 (15:08 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
build:
https://crrev.com/
d67cc72477ac9cf51dac9ff5aa56fd5f996f09d9 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
https://crrev.com/
720ae5cfa1f63afa71fa2e753a3d43cc0b166b28 [recipes.cfg] set autoroll recipe options (iannucci@chromium.org)
depot_tools:
https://crrev.com/
b2e5564353be2974b1241d1bd57b3259100b14ea [recipes.cfg] set autoroll recipe options (iannucci@chromium.org)
TBR=borenet@google.com
Change-Id: I8e4aea83c0d89e6933d1563bd790bd85cc5e33f2
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://skia-review.googlesource.com/10328
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Matt Sarett [Tue, 28 Mar 2017 21:49:23 +0000 (17:49 -0400)]
Fix msan errors in webp decoder
Bug: skia:
Change-Id: I919a24fc61137c4a30160c97ad69fa4a2eadd031
Reviewed-on: https://skia-review.googlesource.com/10325
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>
Kevin Lubick [Tue, 28 Mar 2017 19:45:41 +0000 (15:45 -0400)]
Add extra_asmflags
This makes it easier to cross-compile for non-Android ARM (e.g. Raspberry PI)
Bug: skia:
Change-Id: I4414d933bc38d56009aefcbe10e68f7c70964d9c
Reviewed-on: https://skia-review.googlesource.com/10291
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Robert Iannucci [Tue, 28 Mar 2017 19:11:12 +0000 (12:11 -0700)]
[recipes.cfg] set autoroll recipe options
Bug: skia:
Change-Id: Icdc01ffba00dfda37bcb467f2a4a33aef0991f56
Reviewed-on: https://skia-review.googlesource.com/10245
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Matt Sarett [Tue, 28 Mar 2017 18:34:20 +0000 (14:34 -0400)]
Add codec and color xform support for 565
Bug: skia:
Change-Id: I23184acc4e17d38861d27ab81172048a24c400d2
Reviewed-on: https://skia-review.googlesource.com/10288
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Matt Sarett <msarett@google.com>
Matt Sarett [Tue, 28 Mar 2017 19:27:06 +0000 (15:27 -0400)]
Implement SkBlurDrawLooper with SkLayerDrawLooper
This allows us to delete SkBlurDrawLooper (and leave only one draw
looper implementation).
BUG=skia:
Change-Id: I549af86b81babf19e3649bdffffe2fdb0b308d5a
Reviewed-on: https://skia-review.googlesource.com/10101
Commit-Queue: Matt Sarett <msarett@google.com>
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Mike Klein [Tue, 28 Mar 2017 18:16:22 +0000 (14:16 -0400)]
turn on hidden visibility flags on iOS
These new images came up when I turned them off the other day:
https://gold.skia.org/search?blame=
eec23d113149569414e325ac6fd5a9253945628b&fdiffmax=-1&fref=false&frgbamax=-1&head=true&include=false&limit=50&match=gamma_correct&match=name&metric=combined&neg=false&pos=false&query=source_type%3Dgm&sort=desc&unt=true
Some sort of ODR problem? :/
Change-Id: I9b2575948c3bd5710476e6501e8ec27933c277f6
Reviewed-on: https://skia-review.googlesource.com/10287
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Greg Daniel [Tue, 28 Mar 2017 18:00:32 +0000 (18:00 +0000)]
Revert "Fix copy offset when uploading initial mip data in Vulkan"
This reverts commit
f6c360f7ce738411ba2d97f188e30aef0504dfc7.
Reason for revert: breaking write tests.
Original change's description:
> Fix copy offset when uploading initial mip data in Vulkan
>
> BUG=skia:
>
> Change-Id: Id25e5f39d1393b8dec325d85afb4bc22a11f6bda
> Reviewed-on: https://skia-review.googlesource.com/10283
> Commit-Queue: Greg Daniel <egdaniel@google.com>
> Reviewed-by: Jim Van Verth <jvanverth@google.com>
>
TBR=egdaniel@google.com,jvanverth@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Change-Id: If7f9eccc7f1ba923393a14c5e11678610986faa6
Reviewed-on: https://skia-review.googlesource.com/10286
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Robert Iannucci [Tue, 28 Mar 2017 16:53:04 +0000 (09:53 -0700)]
Manually roll recipes (trivial)
build:
https://crrev.com/
cd172a28588cc11a2ea2d3ee591bbcb7a1fc3ba8 Dart: Remove ie10 from builders, remove some FYI builders
https://crrev.com/
f0b49fc15bf7bc2d9e39210e091f0dd4481da1c4 Revert "chromite: Change cbuildbot/api to to cbuildbot_launch."
https://crrev.com/
988789b7bf6b0bdf1033ee178da4e28340137dab Roll recipe dependencies (trivial).
depot_tools:
https://crrev.com/
5904e2a3d7b88b8609681c7354bf2ae2c1f2bed6 Roll recipe dependencies (trivial).
recipe_engine:
https://crrev.com/
4fcdb75517198a9ca32c7c4aecbe2e6f54b8b6c2 [package.proto] convert deps from list to map.
Bug: skia:
Change-Id: I7aa2236d39e2ec6f882d589a4719dca4baca7500
Reviewed-on: https://skia-review.googlesource.com/10243
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Greg Daniel [Tue, 28 Mar 2017 14:51:51 +0000 (10:51 -0400)]
Fix copy offset when uploading initial mip data in Vulkan
BUG=skia:
Change-Id: Id25e5f39d1393b8dec325d85afb4bc22a11f6bda
Reviewed-on: https://skia-review.googlesource.com/10283
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Robert Phillips [Tue, 28 Mar 2017 15:59:48 +0000 (11:59 -0400)]
Fix gaussianedge GM
Change-Id: Ia4523ea13992b325cb59f42e4458a199c7a98c4b
Reviewed-on: https://skia-review.googlesource.com/10219
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Matt Sarett [Mon, 27 Mar 2017 19:07:35 +0000 (15:07 -0400)]
Use SkTransferFunctionBehavior for raster pixel conversions
Fixes some gbr-8888 behaviors.
BUG=skia:
Change-Id: I1351b043129f7ed0e125bfdb626a0ecaf64c15cc
Reviewed-on: https://skia-review.googlesource.com/10169
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Matt Sarett <msarett@google.com>
Greg Daniel [Tue, 28 Mar 2017 14:24:43 +0000 (10:24 -0400)]
Always initialize testing textures in vulkan with some data
BUG=skia:
Change-Id: I0fb99df77496835446f13d886ba29a5ea579ff54
Reviewed-on: https://skia-review.googlesource.com/10281
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Mike Klein [Tue, 28 Mar 2017 13:30:11 +0000 (09:30 -0400)]
ok, unify failure and crash logging
Just as deferred and locked crash logging makes crashes easier to read,
so does deferred and locked failure logging make failures easier to read.
Change-Id: I71578d61b0056f8d7e692149762def1f155c0387
Reviewed-on: https://skia-review.googlesource.com/10280
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Matt Sarett [Fri, 24 Mar 2017 20:35:22 +0000 (16:35 -0400)]
SkImage_Generator::onMakeColorSpace avoid 565
I forgot that if a png has the significant bit
chunk set to R=5, G=6, B=5, we will recommend
a decode to 565.
We need to avoid this. The codec does not
support color correct 565.
BUG=skia:
Change-Id: Ieb74bfaf100504d9748e4b8014a8a4e425428c7a
Reviewed-on: https://skia-review.googlesource.com/10166
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Matt Sarett <msarett@google.com>
Mike Klein [Tue, 28 Mar 2017 02:51:23 +0000 (22:51 -0400)]
ok, plumb in GrContextFactory
Didn't know what options would be useful here (path renderers?), so I've
left them default. Obviously we can thread them through TestSrc options.
I now have "841 ok" and no failures on my Linux laptop, though I imagine
the GPU tests are all just no-op'd by the TODO at the bottom of the file.
Change-Id: Id934c0bdb5de96d96f2a391106b5d20116f41979
Reviewed-on: https://skia-review.googlesource.com/10213
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Stephen White [Mon, 27 Mar 2017 20:11:31 +0000 (16:11 -0400)]
GrTessellator: speed up linearized quadratic Beziers.
Linerization of quadratic Beziers was using recursive midpoint
subdivision, which can exceed the number of required points by
up to 2X if the second-last recursion level is just over the flatness
threshold. (This is particularly bad for circular arcs, since all
segments have a similar midpoint distance.)
Instead, compute the points of maximum curvature, and progressively
increase the number of segments until the flatness
metric is satisfied at the points of maximum curvature.
This is good for a 15-20% boost on MotionMark Fill Paths, and makes the
performance on Canvas Arcs with the verb limit removed competitive
with the software+upload path renderer.
NOTE: this cause minor pixel diffs in a number of path-related GMs.
BUG=skia:
Change-Id: Ia2c22e00e45acec538b15a23c6edcb7a7d4566b7
Reviewed-on: https://skia-review.googlesource.com/9956
Commit-Queue: Stephen White <senorblanco@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Robert Iannucci [Tue, 28 Mar 2017 03:52:15 +0000 (20:52 -0700)]
Manually roll recipes (trivial)
Also converts recipes.cfg to new JSONPB format.
build:
https://crrev.com/
cf2a231cfaea22f03affe7d3ccdf8634d35a855d flutter: rename libsky_shell.so to libflutter.so
https://crrev.com/
47f1d3af26e30e7120f18450f28dd9ad095f69ba Roll recipe dependencies (trivial).
https://crrev.com/
67b26be7760cdce0e165e39e3d7cc88101725429 Allow passing arg to `repo sync` in chromite module
https://crrev.com/
6b2f23904dfb05b0b382cea4a9db373ec1041696 chromium: Adding tansell@chromium.org as OWNER for Chromium recipes.
https://crrev.com/
3966f1d05c265be673d4a4e52983370680bd2741 Dart: Add gclient runhooks to SDK builder recipe.
https://crrev.com/
3f370ccee1f85de227a40a27f384b1fd47811148 Install goma for cbuildbots.
https://crrev.com/
c9ea42272c232c77bffb476a64243ca6663fff44 Roll recipe dependencies (trivial).
https://crrev.com/
2458a11e565207234a11f0745b6c04c042e7d636 Roll recipe dependencies (trivial).
https://crrev.com/
c255c84a5881e193dcc7c6037cc37badb35c26c9 flutter: rename sky_shell to flutter_tester
https://crrev.com/
49099195df9831c746bc6437aea4b50bce14965d chromite: Change cbuildbot/api to to cbuildbot_launch.
https://crrev.com/
0ce9a9f88802d6be5e016b8a4efc190a21441e29 Roll recipe dependencies (trivial).
https://crrev.com/
e2406a2458aa7697979d6df86e92892077f16822 Roll recipe dependencies (trivial).
depot_tools:
https://crrev.com/
2e401be12ef1ec44f4a81c6bc8acaf793c71e4de Roll recipe dependencies (trivial).
https://crrev.com/
8b5b594115480a6b4c4bbe384cc7afaecd814a4b add "generic" infra path config
https://crrev.com/
284e34ae2878ddd2cda671554b444db8512fa2ab Revert "add "generic" infra path config"
https://crrev.com/
f7023e7cf0a6606080d9f53c5a9e6e8271443914 Roll recipe dependencies (trivial).
https://crrev.com/
757f20796948ff4a9264dad5293bdff2f94d9c43 Reland: add "generic" infra path config
https://crrev.com/
e663133f6f2695efba0705e82ee581f6eb424e6c Roll recipe dependencies (trivial).
recipe_engine:
https://crrev.com/
51395b1ba1ea684f5e99d2bb03c934f2ac441984 [recipes.cfg] ONLY support jsonpb.
https://crrev.com/
230fcdf5d57a084071e3617885b3286353ab1350 [package.proto] add options for autoroller recipe to recipes.cfg.
https://crrev.com/
8ec7b6d3ca59e7c178ad1b03e4408da556fddafa [recipes.cfg] set canonical_url and autoroller options
Bug:
Change-Id: I8308cf3633258703a3bd24ab49bf6e0db6c87cc9
Reviewed-on: https://skia-review.googlesource.com/10242
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Mike Klein [Mon, 27 Mar 2017 21:16:00 +0000 (17:16 -0400)]
ok, make tests really work
Here's how things work now:
~/skia (tests)> ninja -C out ok; and out/ok test
ninja: Entering directory `out'
[2/2] link ok
112 ok../tests/TestConfigParsing.cpp:336
configs[i]->getBackend().equals(expectedConfigs[i].backend)
211 ok, 1 failed../tests/ShadowUtilsTest.cpp:25 Expected shadow
tessellation to fail but it did not.
../tests/ShadowUtilsTest.cpp:30 Expected shadow tessellation to fail but it did not.
../tests/ShadowUtilsTest.cpp:36 Expected shadow tessellation to fail but it did not.
../tests/ShadowUtilsTest.cpp:42 Expected shadow tessellation to fail but it did not.
637 ok, 2 failed
Change-Id: I84b108d4fabb538a2674831dd1ca64b149d7d265
Reviewed-on: https://skia-review.googlesource.com/10209
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Brian Salomon [Mon, 27 Mar 2017 21:32:18 +0000 (17:32 -0400)]
Revert "Fix SkImage_Gpu::getROPixels"
This reverts commit
f4d443fd1bd8cffbcd7a07a48f3488ae871414e9.
Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=705156
Original change's description:
> Fix SkImage_Gpu::getROPixels
>
> The dstColorSpace is a badly named parameter. It's a hint about where/how
> the returned pixels are going to be used. Raster and GPU are meant to
> ignore that information - codecs use it to drive our decoding heuristic.
>
> I've adopted that name in several places, although it's quite bad. Maybe
> usageColorSpace would be better?
>
> Bug: skia:
> Change-Id: I99acaac4bed57ed8acd8433e1c5b39a60c3af09e
> Reviewed-on: https://skia-review.googlesource.com/10109
> Reviewed-by: Matt Sarett <msarett@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>
>
TBR=msarett@google.com,robertphillips@google.com,brianosman@google.com,reed@google.com,reviews@skia.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: Id46226e41ca287ef3351710815ae2e842da4d293
Reviewed-on: https://skia-review.googlesource.com/10210
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Ben Wagner [Thu, 23 Mar 2017 21:26:12 +0000 (17:26 -0400)]
Omit ImageStorageLoad on IntelBayTrail Ubuntu
BUG=skia:6358
NOTRY=true
Change-Id: I1d85bc37008988220c0454e8ec4a72bef2ec043d
Reviewed-on: https://skia-review.googlesource.com/10100
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Greg Daniel [Mon, 27 Mar 2017 20:18:03 +0000 (16:18 -0400)]
Minor fix to VkWrapTest
We need to make sure we cleanup the VkImage created when testing the
wrapping of a render target.
BUG=skia:
Change-Id: I60ea7e880fecccca309a250cc3b19eb29d6aa89c
Reviewed-on: https://skia-review.googlesource.com/10206
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Mike Klein [Mon, 27 Mar 2017 18:16:04 +0000 (14:16 -0400)]
ok: add basic unit test support
Plenty TODO remaining.
This can actually kind of run without a test reporter or GrContext:
$ out/ok test
784 ok, 56 crashed
... lots of stack traces ...
Most tests don't use the reporter unless they're going to fail.
Change-Id: I7333e2c63ade5e671ebf60022d19390f1fc1c93a
Reviewed-on: https://skia-review.googlesource.com/10201
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@google.com>
csmartdalton [Mon, 27 Mar 2017 18:32:29 +0000 (12:32 -0600)]
Add a simple tool for isolating a path from an SKP
BUG=skia:
Change-Id: I5ca9bbd43919e3f65ea940847c68f85cc78dfeda
Reviewed-on: https://skia-review.googlesource.com/10130
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Mike Klein [Mon, 27 Mar 2017 18:28:07 +0000 (14:28 -0400)]
quiet some annoying logging in unit tests
Noticed all these while adding some unit test support to ok.
Change-Id: Ie33b96da95840628657211cb28b2134fd314a48a
Reviewed-on: https://skia-review.googlesource.com/10202
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Jim Van Verth [Mon, 27 Mar 2017 18:25:29 +0000 (14:25 -0400)]
Add height function to shadow tessellators.
Prep work for adding perspective support.
Bug: skia:
Change-Id: Id07d3050afb3f0d001b885e482adb8d03125b619
Reviewed-on: https://skia-review.googlesource.com/10167
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Herb Derby [Mon, 27 Mar 2017 17:35:15 +0000 (13:35 -0400)]
Change SkMemory to the more accurately named SkMalloc.
Change-Id: I6b08a74234b99bac866bad71014b94f7ec2d4bc8
Reviewed-on: https://skia-review.googlesource.com/10188
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Brian Salomon [Mon, 27 Mar 2017 17:09:36 +0000 (13:09 -0400)]
Split GrPipelineInput into separate color and coverage types, the latter of which is just an enum.
Assign names that indicate that they aren't just for the input phase since I plan to use them at the boundary between FPs and XPs as well.
Renamed GrProcOptInfo to GrColorFragmentProcessorAnalysis. This is now only used on the color side and the new name seems clearer to me.
Change GrMeshDrawOp::getFragmentProcessorAnalysisInputs to use the new color/coverage types directly rather than a class that has been reduced to simply bundling them together.
Change-Id: If93bae74c9d590486eecdf63f302418c96deab65
Reviewed-on: https://skia-review.googlesource.com/10161
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Mike Klein [Mon, 27 Mar 2017 16:43:44 +0000 (12:43 -0400)]
ok: alias 565 -> sw:ct=565
This is mostly a demo, and to make sure it's easy.
If I'm thinking right, other non-ct options should Just Work.
Change-Id: I295db0fa04921ccdd766e1870e367594ca802462
Reviewed-on: https://skia-review.googlesource.com/10190
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Robert Phillips [Mon, 27 Mar 2017 15:08:16 +0000 (11:08 -0400)]
Remove GrFragmentProcessor-derived class' GrTexture-based ctors
Split out into:
https://skia-review.googlesource.com/c/8881/ (Switch GrTextureStripAtlas over to GrTextureProxies)
https://skia-review.googlesource.com/c/8942/ (Wrap cached GrTextures in GrTextureProxies (e.g., blur profiles, nine-patch blurs, etc.))
https://skia-review.googlesource.com/c/8997/ (Clean up/remove unused GrFragmentProcessor-derived ctors)
https://skia-review.googlesource.com/c/9191/ (Switch SkImageGenerator over to generating GrTextureProxies)
https://skia-review.googlesource.com/c/9448/ (Switch GrYUVProvider over to GrTextureProxies)
https://skia-review.googlesource.com/c/9559/ (Preparatory Proxification)
https://skia-review.googlesource.com/c/9626/ (Consolidate Proxy caching code in GrResourceProvider)
https://skia-review.googlesource.com/c/9683/ (More pre-emptive proxification)
https://skia-review.googlesource.com/c/9917/ (Make experimental Perlin noise shader take texture proxies)
https://skia-review.googlesource.com/c/9961/ (rename makeCopyForTextureParams to isACopyNeededForTextureParams)
https://skia-review.googlesource.com/c/9945/ (Make SkImageCacherator be deferred)
https://skia-review.googlesource.com/c/10180/ (Add new proxy-based DetermineDomainMode w/ test)
Change-Id: Ia33389d92360e542a9d2bf395948deb04d017465
Reviewed-on: https://skia-review.googlesource.com/8823
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Kevin Lubick [Mon, 27 Mar 2017 16:22:52 +0000 (12:22 -0400)]
Update ATT Galaxy S7 to Android N
This updates both Galaxy S7s to use the longer device_os added in
https://chrome-internal-review.googlesource.com/c/339125/
to avoid subtle version skew when Galaxy S7 applies an update but doesn't
toggle Android version.
BUG=skia:
NOTRY=true
Change-Id: I7c0a3197592f8738abae46ffb3e31dc0f50d2b6a
Reviewed-on: https://skia-review.googlesource.com/10178
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Robert Phillips [Mon, 27 Mar 2017 14:14:08 +0000 (10:14 -0400)]
Add new proxy-based DetermineDomainMode w/ test
split out of: https://skia-review.googlesource.com/c/8823/ (Remove GrFragmentProcessor-derived class' GrTexture-based ctors)
Change-Id: Ibf54da589710382254b416e4801d83e9f5663f44
Reviewed-on: https://skia-review.googlesource.com/10180
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Mike Klein [Mon, 27 Mar 2017 03:22:44 +0000 (23:22 -0400)]
ok: handle concurrent crashes better
lockf() is a simple way to prevent interlaced stack traces when there
are concurrent crashes. After a crashing process rethrows its signal
and dies for real, the OS unlocks the file for other processes.
I tested this by making SkCanvas::drawRRect() crash on Linux:
20-odd GM crashes with interlaced stack traces before, none after.
Change-Id: I99930756b8c85c552eef7c3a77778e4c00d34c42
Reviewed-on: https://skia-review.googlesource.com/10177
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Brian Salomon [Mon, 27 Mar 2017 14:17:38 +0000 (10:17 -0400)]
Fully initialize array of previous edges in GrGLConvexPolyEffect to please MSAN
BUG=skia:6416
Change-Id: I99c29cd8cb90844e50ed288ba57e28774bf2444c
Reviewed-on: https://skia-review.googlesource.com/10183
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Robert Iannucci [Sat, 25 Mar 2017 01:18:15 +0000 (18:18 -0700)]
Manually roll recipes (trivial)
All up to date!
build:
https://crrev.com/
f2c0ca26abeccab331fc6bd8c7c0514165a78e54 Roll recipe dependencies (trivial).
https://crrev.com/
843d18d4c63d75f0eb68a2df934baab02c0bf6c4 swarming: Improve collect_isolated_script_task error handling.
https://crrev.com/
9af80f3466b63bdd4a5d75345795c3516a20a522 Roll recipe dependencies (trivial).
https://crrev.com/
feba551470a06709553c1e96d0a03f13deca07ed WebRTC: Fix packaging of iOS API Framework.
https://crrev.com/
b82322f802034133234fc7016150d842d6b9e987 V8: Add more indirect dependencies.
https://crrev.com/
6067fa67669785c0fc3172dcb80dd0de2d452d19 swarming: collect_isolated_script_task changes.
https://crrev.com/
379d0539704468101ca772ba0c0b084ed164daa7 WebRTC: Add rtc_enable_bwe_test_logging=true to more configs bots.
https://crrev.com/
323e766b5401d5649909df231ecf7c581fce298a Enable service tests on kernel builders
https://crrev.com/
fb25c3b3af9ae0e62d55ce8837470e6939256ae2 Remove unused skia_swarming and CT recipe modules
https://crrev.com/
890c03dc5c040219372674ac321765460e01d016 Add gen/skia/public/interfaces to generated bindings paths
https://crrev.com/
1f580164c505a6d5f4c80c1a298cdb461e3fafdc Remove unused recipe expectations
https://crrev.com/
36ee491ef076c973bb7debf85ca21f422f4da279 Roll recipe dependencies (trivial).
https://crrev.com/
2fa361b5f8b4f7fb70fe01928897f8a08427258d Roll recipe dependencies (trivial).
https://crrev.com/
dcd5ed1a860a2dc0825a8ea49f7b130b6c947d92 Rename Quadro M2000 machines to Quadro P400.
https://crrev.com/
7c59a8aef946bf372345a47b70f3a013e7af34ad Roll recipe dependencies (trivial).
https://crrev.com/
47899c1186474197f5fe8d17390b8d6299f89fee crashpad: Make tests work with paths instead of configuration names
https://crrev.com/
df7c8aed80f6fa17717a4eef7d22c8a359e5c080 Use isolate go binary on iOS FYI builders
https://crrev.com/
7e669897df98ea92c5d63d6f4be03ac5f3380908 Roll recipe dependencies (trivial).
https://crrev.com/
78eaaf5947ea93387ec9ff7c578bf32676500194 Run new recipes 'test' command
https://crrev.com/
03c61e3c727963a97435adcb7fda3351e420e4a6 WebRTC: Add webrtc_perf_tests to Android trybots.
https://crrev.com/
18868576df07b88794c5b5402f011a165bb61fb7 Fix recipe tests
https://crrev.com/
eca15296bf0f928789c471f134c7cc9f8e34452d Add patch size estimation to Android perf builders.
https://crrev.com/
b71ef7dff40d848b8878373eedb599fe98709a04 WebRTC: Add bwe_simulations_tests sanity check.
https://crrev.com/
ce3f62b49d89a8e02f006159e3a460b0c856c3fb Enable uploading images to skia gold in parallel
https://crrev.com/
b05c4bc3761d4c41d70952e0bcf2efa71cb174af Roll recipe dependencies (trivial).
https://crrev.com/
d87947e7dc733a192b4d29fd32cfb7c8c9791daa Roll recipe dependencies (trivial).
https://crrev.com/
26c73a64dd8f6c17f73cdbc5b2324df2ccda3389 Remove NVIDIA Shield GPU.FYI bot
https://crrev.com/
ad447d745f0b15d374d977f0a355e4d910861f33 Gatekeeper: Pass in credentials for accessing Milo
https://crrev.com/
4e48b5ec0b17fa90512a2abb5c8302556c468cf4 Make 'Android Builder (dbg)' download VR test APKs
https://crrev.com/
379e6a8c13e2c12fe10676c3ff31d8864aadbca7 Use isolate go binary for all iOS builders
https://crrev.com/
ddc2f1946cebc0fee8a726704277a9ee08c64900 Simplify layout_test_wrapper.py (take 2).
https://crrev.com/
b69e0ff7c3c6609297730fc796fc0863805c1662 Fix command argument list in layout_test_wrapper.py.
https://crrev.com/
30584dea7ace8de1ac915cb186ca68b99e176cf9 chromium: Fixing the results handler for LayoutTests.
https://crrev.com/
b192b269842218eb78a467e9a520ff9b6c2446db Rename Win AMD R5 230 to R7 240 after GPU swap.
https://crrev.com/
4ff14cf2450222d65926c67acb2e319bc2cd96b7 Hacks to run locally
https://crrev.com/
e4d63fc7eac4b4f7d4e24d5252a83a189a760931 Revert "Hacks to run locally"
https://crrev.com/
62e780a27c4f11cec2a63a113ffc3273dcff3320 WebRTC: Add low_bandwidth_audio_test on desktop.
https://crrev.com/
26805613e283cd0c796bfe37143026bc89bb1446 WebRTC: Add building of low_bandwidth_audio_test to perf bots
https://crrev.com/
ac4da194a237c33a590c3518515c2ea148037f86 chromium: Fixing the test results handler for skipped tests.
https://crrev.com/
786366148079983fd99174150715b5b819d7a303 chromium: Process the full WebKit Layout Tests results.
https://crrev.com/
8bcb947602f5586c890174bf48529761ec1e6289 chromium: Change WebKit Layout Tests results upload.
https://crrev.com/
072216afe61f9604972a1aceedabc34685053b6e Revert "chromium: Process the full WebKit Layout Tests results."
https://crrev.com/
d7dea9fe527267a9cb0137ea7642cc289d6a7365 WebRTC: Use test name instead of command for perf_dashboard_id fallback.
https://crrev.com/
ba9dbab1eca7aee547b9b844ca5b415f0af81b57 Move to new angler device.
https://crrev.com/
fca33caaf9efacc4011304ab7ad3791c2b06a2a5 WebRTC: Remove low_bandwidth_audio_test on Mac and Windows.
https://crrev.com/
898c6ac014d81e25bdc2f2ffa499d6cf623ff82d Roll recipe dependencies (trivial).
https://crrev.com/
ef3b843e396d4bf5dc58809dbc6fe9999e1b8b5f Revert "Gatekeeper: Pass in credentials for accessing Milo"
https://crrev.com/
107f5de0aa9ad771f0e4ac7b9572b4081c7782ad Roll recipe dependencies (trivial).
https://crrev.com/
9d5c32ab34717333e7aedfabdd4118163b7f5eeb Roll recipe dependencies (trivial).
https://crrev.com/
4d8948186392e550f9113e0a0fd3bf8892da7894 Roll recipe dependencies (trivial).
https://crrev.com/
aa51b056ae211e3918489aa37b24a10f7feaec48 Roll recipe dependencies (trivial).
https://crrev.com/
ee25e07fc187ccbb2af62fe56bcc9444c3c5b9d3 [recipes.cfg] convert to JSON
https://crrev.com/
bd7fdc1212522513f464ca3f189018872ff26eca Revert "[recipes.cfg] convert to JSON"
https://crrev.com/
8d686035a02029411b43079563ecfe9a0c3777c3 Decommission Linux Release (AMD R5 230) GPU.FYI bot
https://crrev.com/
b9ede07dcc65de05933ce80fa23a0507fcd7c3c5 [remote_run] bump canary version of recipes-py.
https://crrev.com/
4d843c3c4e2253fdbb674d91390bbcd03361e0fc [Findit] Run compile on last good revision if the culprit is the first revision in regression range.
https://crrev.com/
6c1d2f31109446c7ae7d2e1fec69437a68e02da0 Gatekeeper: Use milo
https://crrev.com/
655fd4581bc29b89d0bbde07c71d2df3ff9095c9 reland "Gatekeeper: Pass in credentials for accessing Milo""
https://crrev.com/
d13b1feb856b8159917c591c806a606e4fe5e4d3 Gatekeeper: Don't be verbose
https://crrev.com/
e3eedb9983fa7966f99536baae6ebc26272fd60d Retry tests without the patch on iOS try bot failures
https://crrev.com/
c15677597961c6f980914ce5e25e95d02323c722 [remote_run] bump prod version of recipes-py
https://crrev.com/
b40d5bac94616d5df8e6317fd4c8919a0ec67e3b chromium: Make layout-test-wrapper produce the full results.
https://crrev.com/
c8b04fa68d968242aae885947bacdb7116d6886b Reland: [recipes.cfg] convert to JSON
https://crrev.com/
17f33c9a7735dba20c9d80f954eeaabdd28e72d1 [remote_run.py] bump kitchen canary version
https://crrev.com/
63e56fb2bd232f5929c0376d681ef18312058168 chromium.fyi: Remove BlinkStep from Linux RandomOrder bots.
https://crrev.com/
dda63076137c0ef95b5d64f62a5c67d9e6bf84be Roll recipe dependencies (trivial).
https://crrev.com/
e7de363248f87ec5e004375edb55d4ff4a148c3c Manually roll recipes.cfg
https://crrev.com/
3325687c9d892d7dee9ea639c9557a4920032c91 Invoke dart-sdk-* builders via recipes, add trigger at the end
https://crrev.com/
111855ccccb7ac786af35256462317fe714f698f Add new Dart analyze source recipe and builder to FYI
https://crrev.com/
7616b7167c887b266c2ba12c5796717b53b075f8 V8: Bump shards on slowest bots
https://crrev.com/
739b537a90ab43eda58b0d16f87a38f151b02b4a Roll recipe dependencies (trivial).
https://crrev.com/
26d3abcaa429c315ebfe56ecf1bc503b1ccaca97 Roll recipe dependencies (trivial).
https://crrev.com/
7486b36c875fa1410613e8eea0f6d084bfe8a0b2 Add maksim.sisov@chromium.org to Ozone Linux bot
https://crrev.com/
4dbb302e82655768d714dff8b58601a321bef8a7 Roll recipe dependencies (trivial).
depot_tools:
https://crrev.com/
e08398fde847b8afe7822652b79c2b0dcd16308a Roll recipe dependencies (trivial).
https://crrev.com/
c07db621521d62557d089b3e94484c1831395487 Roll recipe dependencies (trivial).
https://crrev.com/
e718958ca03fc0766459fecf7820a300b206d7be define builder_cache base path
https://crrev.com/
b87fa094099214b2f2c433f2590c6c62f1493e7f Roll recipe dependencies (trivial).
https://crrev.com/
14db1dfd88b987c9119f59f75f1f27b8e7c49602 Revert "define builder_cache base path"
https://crrev.com/
7a1f04d377764d9039cde0c4aa4b55c42a411c23 Implement presubmit API to get the old contents of an affected file.
https://crrev.com/
2da34fea2979af25cf1c7ff5f5e5dfbb70d2339c Fix typo in pydoc for OldContents().
https://crrev.com/
42494916d40bb9f92d7fe4732f9a5623bcbb67e6 Roll recipe dependencies (trivial).
https://crrev.com/
8d63166147f518efdc84f6b9082b4161e0188991 Roll recipe dependencies (trivial).
https://crrev.com/
d75686454bb0ad8d4718ff6bf9613772ca8027b5 gerrit_util: Use httplib2 for communication instead of httplib.
https://crrev.com/
25ab6a34c2d37ed806e49c334c8b79404d03c8f1 Revert "gerrit_util: Use httplib2 for communication instead of httplib."
https://crrev.com/
89d04858c88d91acf491e259d293ba3206713357 gerrit_util: Use httplib2 for communication instead of httplib.
https://crrev.com/
05c96f1fab336629a713713094049e1edecbc651 Roll recipe dependencies (trivial).
https://crrev.com/
3a16ed155e3f7ac56db71f207d5779fc97c3bae8 Use Bug: footer for Gerrit CLs
https://crrev.com/
8ec608527e095382a640f3cb1c30464ad1dce850 bot_update: don't retry rebasing Gerrit patches.
https://crrev.com/
2add8a99684cdc6c68a25e2dd7dba6dcf680c129 Roll recipe dependencies (trivial).
https://crrev.com/
e9b94890b6de526673e6995e1395353b1e752299 [recipes.cfg] convert to JSON
https://crrev.com/
f14709556d5d51394ac8f7d603d14795eba2c883 Move recipes to their own subdirectory
https://crrev.com/
5afa324b6a6908060b8ca2c5138e637ae4507885 Roll recipe dependencies (trivial).
https://crrev.com/
f83e262e6d10b480df069129c3eddfab0a22c4b7 Adjust paths in bot_update.py after moving recipes to subdir
https://crrev.com/
bb86fbbef1e7b8eb279a88f4548f059527d2810b git cl upload for Gerrit: warn if uploader is not CL owner.
https://crrev.com/
296bd843290fd661d2645322137c9d9925c4cfd7 Update to packaging script for VS 2017
https://crrev.com/
ce0080373244a65ba8f8bc8766096e96472e51e3 Roll recipe dependencies (trivial).
https://crrev.com/
cb23864e6801c27e0fb9a2ec908e1e8a24382a71 Roll recipe dependencies (trivial).
https://crrev.com/
5be3bdd70e1d95b88c93ca38c0c870e2399dede7 Roll recipe dependencies (trivial).
recipe_engine:
https://crrev.com/
fb61dcf4145be9d98f85d02af72a498f09782800 [autoroll] cache commit_metadata operations.
https://crrev.com/
6488afec4a1b4ac51a8601e308c42cd6a176c190 [recipes.cfg] upgrade recipes.cfg to JSON.
https://crrev.com/
157bae7bdfe2608d4bff84eaa90db0fdae71e26b Add structured JSON result output to new 'test' command
https://crrev.com/
ef924b01de36ab3c70e79f7782acb3f66ffdd3fd [package.proto] Make recipe json loading forwards-compatible
https://crrev.com/
3e8a9964590120020a29e2749a99c043197d088b repo_test_util: use new 'test' command
https://crrev.com/
033f8117b5cb6de01ad56606aca0437b2ba7cd7c Update documentation about recipe tests
https://crrev.com/
3125a3b89e18dff89cf6d59f0a0486d832521bf1 [recipes.cfg] Switch to json for real, add canonical_repo_url.
https://crrev.com/
fd0d8541ec8f579c68bf8214acfaf08f23117882 autoroll: use new 'test' command
https://crrev.com/
e3bd68e54e94d7ec339fd7c8d90544975386f4fe Add support for recipe/test filters in new 'test' command
https://crrev.com/
4439877a3ea1acd4c3f4cf805fba138aeb5b16a5 [test_test.py] make root_dir realpath.
https://crrev.com/
84b34416f3e1b1582cf81ab7ffea34f1e84b1c95 [package.py] No trailing whitespace in json proto dump.
Bug: skia:
Change-Id: I0f4b1a8fcac9d0b3fc20a713b2caf3b1ba629db7
Reviewed-on: https://skia-review.googlesource.com/10127
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Robert Iannucci [Sat, 25 Mar 2017 01:11:15 +0000 (18:11 -0700)]
Manually roll recipes
build:
crrev.com/
232ecb4e8e9a3175db1c14449dca0230ae01b80c Switch to an explicit swarming.summary placeholder instead of json.output.
Bug: skia:
Change-Id: I7c0dd6ce6225d48541c574ff6f38ea70e1823f1f
Reviewed-on: https://skia-review.googlesource.com/10126
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Robert Iannucci [Sat, 25 Mar 2017 00:45:40 +0000 (17:45 -0700)]
Manually roll recipes (trivial)
build:
https://crrev.com/
758ae9ec2bff2bb48071f78b80af3f84177870e4 Roll recipe dependencies (trivial).
https://crrev.com/
0796b26a2bbec373b875a604d1adfa6b8a7b9b75 Roll recipe dependencies (trivial).
https://crrev.com/
a14699eda6eb7971c71167d36901e2a374f6b744 Remove old recipe expectations
https://crrev.com/
2e802841367cdd8c47fb5a1b42f898948265b402 Roll recipe dependencies (trivial).
https://crrev.com/
34cf1f66235a1b70e97519055cbcff298971dd19 Remove recipe roller master from Kitchen whitelist
https://crrev.com/
f4a7f3ea36bd971090d02fa8dac321f0bfc867c1 Roll recipe dependencies (trivial).
depot_tools:
https://crrev.com/
0d6b46e32b99c7f6b7ecef5cde843aaf4e43449a git cl comment: require explicit --codereview with -i|--issue flag.
https://crrev.com/
aebadcc3a4349a0845fcab60242c6b146d0db1c8 Roll recipe dependencies (trivial).
https://crrev.com/
742adbd76f8d4c730866ba02d2e4b71524ce9049 Run new recipes 'test' command
https://crrev.com/
328f60d1a072d24b07e2726d447aa7c089c7b07e Roll recipe dependencies (trivial).
recipe_engine:
https://crrev.com/
aa0a2d61cd31decf9a5c048b677ba38eb209a1c6 Correctly handle tricky characters in test names in new 'test' command
https://crrev.com/
81de92519dd374d9b193362034fae8861476bc5f [autoroll] make autoroller propagate changes to recipes.py.
https://crrev.com/
0ee0446195595e5df02fc2dc82e4988b601b113e Carefully clean more unused recipe expectation directories in new 'test' command
https://crrev.com/
803d6ead998b4bbca601fb3a984e76ddc063806d Fix autoroll command.
Bug: skia:
Change-Id: I1a2bf0bf64b3ec9b27df785fcbf7d4b9e28727ac
Reviewed-on: https://skia-review.googlesource.com/10125
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Mike Klein [Mon, 27 Mar 2017 00:11:48 +0000 (20:11 -0400)]
focus hidden-visibility flags
This makes things like dladdr and backtrace_symbols not totally useless on Linux.
Change-Id: I26666a76c5b50fbf88aaf9709c869de0a697bb02
Reviewed-on: https://skia-review.googlesource.com/10176
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Robert Iannucci [Sat, 25 Mar 2017 00:28:27 +0000 (17:28 -0700)]
Manually roll recipes
Removes unused recipe expectation.
build:
https://crrev.com/
e0f3d95ef043b98fcceb1f34b03f9b8fac091eb9 Roll recipe dependencies (trivial).
depot_tools:
https://crrev.com/
0bbe6fa00ef873080c4f6d145ea7a00497eeed3f Roll recipe dependencies (trivial).
recipe_engine:
https://crrev.com/
e300f3a3b8193b84b88599faa30c0301e155c906 Handle unused recipe expectations in new 'test' command
Bug: skia:
Change-Id: I3f00821de5b7f5158c6da2ff1206f2e1ec133e0f
Reviewed-on: https://skia-review.googlesource.com/10124
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Robert Iannucci [Sat, 25 Mar 2017 00:13:22 +0000 (17:13 -0700)]
Manually roll recipes (trivial)
build:
https://crrev.com/
440839111a2a562ca2ac214817d821cd480146a8 V8: Bump shards on arm branch builders
https://crrev.com/
7b6d0f6ecffaef81bbbcb8ffc5a522df08fd7e02 Roll recipe dependencies (trivial).
https://crrev.com/
5be20abc2276ab5ae7ab83707ed4966710475aec gatekeeper_ng: whitelist more masters for CBE
https://crrev.com/
1efede1c3cd2b2435cb27cac164fcd61a98199ae Roll recipe dependencies (trivial).
https://crrev.com/
4715a9958d426ec473c6f3e62dd58687640484e4 Roll recipe dependencies (trivial).
https://crrev.com/
973870a62af1f77ac5356fbabd9a471a4fdf6c91 Add 'CFI ThinLTO Linux ToT' buildbot (recipes part).
https://crrev.com/
d2d4c12efbc6df3fc7d1a2eca3d461f1b6b2efb4 Roll recipe dependencies (trivial).
https://crrev.com/
82f8e1417a99f8251595f6f9a75bdbe0e400e8b5 Don't write .isolate as JSON
https://crrev.com/
55807bc812e28d83f30a2efbebc8ba113693eaae Push bisect changes to prod.
https://crrev.com/
b08eff6b36e7c66482b38fa179da7f4992da60d6 Roll recipe dependencies (trivial).
https://crrev.com/
03fd1250afda1212ca9b63b43c49ae5a68e0e53d chromium: Rework layout test results archiving.
https://crrev.com/
f30cd17e8aaf3def5994b8384da96ef56e80b3dd Add a cast audio bot.
https://crrev.com/
6e47d11dafc3ca058652d7c93a60080462f0961e Temporary workaround missing commit_position in blink_downstream DEPS.
depot_tools:
https://crrev.com/
625986dba7852518199ec002fd4cece02929f4ab git cl comment: implement adding comment for Gerrit.
https://crrev.com/
680253d31518b5865a45be4d63bc1ed74a4f16e9 git cl description: don't bother if description diff is trailing whitespace.
https://crrev.com/
d8aa49f35b8d3e981d0afc3d539aae35a2f89415 git cl comment: refactor fetching comments for Rietveld and add tests.
https://crrev.com/
5a0cf20452b7dac174dd0377f5b030379ba543ef git cl comment: implement fetching comments for Gerrit.
https://crrev.com/
ecf3dbe49fcf18982c5d8fbfd8a9ed30d6d9e714 Roll recipe dependencies (trivial).
https://crrev.com/
e86f6de84296601c61a3d3e6d7655e596535c4d6 Fix smoke test to not hard-code python executable location.
recipe_engine:
https://crrev.com/
78f105cbebb6e8dc99d64638d400868851cb0c40 Add --train support to the new 'test' command
Bug: skia:
Change-Id: Ib1abe064f6684dcd6bdbdbe2f17c5fa9c506299a
Reviewed-on: https://skia-review.googlesource.com/10123
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
UpdateSKPs [Sun, 26 Mar 2017 06:57:09 +0000 (06:57 +0000)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=update-skps@skia.org
NO_MERGE_BUILDS
Change-Id: I78f9d076d702bdc7b7e0e58d60fd5b3c320707b8
Reviewed-on: https://skia-review.googlesource.com/10131
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>