gbalykov [Wed, 31 May 2017 15:39:43 +0000 (18:39 +0300)]
Fix issues with RelativePointer instead of RelativeFixupPointer (dotnet/coreclr#12004)
Commit migrated from https://github.com/dotnet/coreclr/commit/
3530e3f5751f4b0e12b8f45bf7fe2a2a309cfebb
Atsushi Kanamori [Wed, 31 May 2017 15:23:02 +0000 (08:23 -0700)]
Expose Enumerator members out of EnvironmentAugments. (dotnet/coreclr#11980)
Expose Enumerator members out of EnvironmentAugments.
Commit migrated from https://github.com/dotnet/coreclr/commit/
38528f6662f24c37e11bac67a56ff7269e8e4f6e
Krzysztof Wicher [Wed, 31 May 2017 03:02:47 +0000 (20:02 -0700)]
Merge pull request dotnet/coreclr#11995 from ViktorHofer/SerializationFollowUp
Internal hashtable serialization attribute removed
Commit migrated from https://github.com/dotnet/coreclr/commit/
b2150d5fc16eddec33702fd89168487d76f06108
Maoni Stephens [Wed, 31 May 2017 01:29:29 +0000 (18:29 -0700)]
Allowing larger segment size for SOH, in preparation for enabling it for NoGC region. (dotnet/coreclr#11923)
This is just so that I can test with larger SOH seg size to make sure we are not getting AVs.
More perf changes will happen with the NoGC region changes.
Commit migrated from https://github.com/dotnet/coreclr/commit/
984f6719a3c4b0ad35cba6b9d819a33935bc0b3e
gbalykov [Wed, 31 May 2017 01:25:04 +0000 (04:25 +0300)]
Remove relocations from SECTION_MethodDesc for ngened images (dotnet/coreclr#11394)
Commit migrated from https://github.com/dotnet/coreclr/commit/
4ee1c192d1638b4bc69db59c0807a2b8c2b5bd3c
Viktor Hofer [Wed, 31 May 2017 00:46:43 +0000 (02:46 +0200)]
Internal hashtable serialization attribute removed
Commit migrated from https://github.com/dotnet/coreclr/commit/
ddeae7ea5fb8ad5374acb4eeb237ea8e688db897
Viktor Hofer [Wed, 31 May 2017 00:16:32 +0000 (02:16 +0200)]
Coretype variables renamed back to netfx counterpart for reflection based serialization (dotnet/coreclr#11910)
* Variables renamed for reflection based serialization
* Make EqualityComparers serialize like desktop
* add missing interfaces
* TimeZone serializable added
* Internal hashtable serializable
* Removed TimeZone as serializable type
* Remove Lazy<T>'s [Serializable] attribute for 2.0
For performance, Lazy was completely rewritten for .NET Core 2.0 and has an entirely different format than desktop; trying to get it to match the desktop serialization format would require either reverting or providing a complicated custom serialization/deserialization implementation to try to match. Lazy can also wrap an Exception that occurred from trying to instantiate the object, and the only exception types that are serializable as of now in core are the base Exception and AggregateException. As such, we're cutting it from the list of supported types in 2.0. An easy workaround is simply to do what the implementation does: serialize lazy.Value instead of lazy.
* tiny fixes to equalitycomparer.cs
Commit migrated from https://github.com/dotnet/coreclr/commit/
48d5a81782370f45cb06231ffa707147c6c79fc5
Carol Eidt [Tue, 30 May 2017 23:28:05 +0000 (16:28 -0700)]
Merge pull request dotnet/coreclr#11977 from mskvortsov/FixDoubleRegArgNext
[RyuJIT/arm32] Fix double argument passing
Commit migrated from https://github.com/dotnet/coreclr/commit/
e368c0903d0f4952ac8c4676e24d7d86b906b632
Pat Gavlin [Tue, 30 May 2017 23:06:23 +0000 (16:06 -0700)]
Merge pull request dotnet/coreclr#11872 from hqueue/arm/ryujit/dodge_lowering_long_cmp
[RyuJIT/ARM32] Dodge lowering long compares
Commit migrated from https://github.com/dotnet/coreclr/commit/
cf90a2cc552851d6ec7bf7a99e68a9aae7b4b8a1
Sergey Andreenko [Tue, 30 May 2017 23:02:20 +0000 (16:02 -0700)]
Skip cast nodes for the tail call check. (dotnet/coreclr#11986)
Fix dotnet/coreclr#11983
Commit migrated from https://github.com/dotnet/coreclr/commit/
0e3494f208edb21d40e36374dab718e08a8502c8
Jan Kotas [Tue, 30 May 2017 16:21:04 +0000 (09:21 -0700)]
Fix build break
Commit migrated from https://github.com/dotnet/coreclr/commit/
d67545d8cbd1962221e5bc7ce04bba69abfdfac1
Marek Safar [Tue, 30 May 2017 06:29:57 +0000 (08:29 +0200)]
Moves windows specific field to Debug.Windows.cs file (dotnet/corertdotnet/coreclr#3733)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
53ae19db3271dc2511ff5ea34b26e6d12cbe4e7a
Gaurav Khanna [Tue, 30 May 2017 19:15:05 +0000 (12:15 -0700)]
Remove Debian Armel (dotnet/coreclr#11978)
Commit migrated from https://github.com/dotnet/coreclr/commit/
dc3ca3ece7f1e95d08e534c32c69595e743645a1
Mikhail Skvortcov [Tue, 30 May 2017 15:47:54 +0000 (18:47 +0300)]
RyuJIT/arm32: Fix double argument passing
Commit migrated from https://github.com/dotnet/coreclr/commit/
c25f8454b016bd54f581459832cb855be63d2672
Vance Morrison [Tue, 30 May 2017 16:09:29 +0000 (09:09 -0700)]
Fix failures in ETW logging on 4GB aware 32 bit processes (dotnet/coreclr#11941)
We incorrectly cast a 32 bit pointer to a 64 bit poitner using as a SIGNED integer.
If this is a 32 bit process that is using more than 2GB of memory this can result in
sign rather than zero extension. This makes the poitner invalid at the OS level
and causes the OS API to fail.
We disovered this in Visual Studio when debugging large (Rosyln) scenarios.
There were numerous failures which causes sever slowdowns becasue the
EventSource logged OutputDebugString events when the OS API failed.
The fix is to use unsigned extension. Note that I have confirmed that casting
from a IntPtr or a void* to a ulong does zero extension (that is it uses the target type
to determine whether to use sign or zero extension).
To be useful for Visual Studio, this needs to be ported to the desktop runtime.
Commit migrated from https://github.com/dotnet/coreclr/commit/
fef0f8b9c3a29b291894666f19340d99849ab40b
Carol Eidt [Tue, 30 May 2017 15:31:47 +0000 (08:31 -0700)]
Merge pull request dotnet/coreclr#11972 from hseok-oh/ryujit/issue_11971
[RyuJIT/ARM32] Fix offset of struct argument when using stack
Commit migrated from https://github.com/dotnet/coreclr/commit/
85603db02dee063acd8d6f9f5e853cd407cff134
Carol Eidt [Tue, 30 May 2017 15:30:15 +0000 (08:30 -0700)]
Merge pull request dotnet/coreclr#11973 from hseok-oh/ryujit/issue_11837
[RyuJIT/ARM32] Fix assertion failed 'remainingSize == TARGET_POINTER_SIZE'
Commit migrated from https://github.com/dotnet/coreclr/commit/
e30d6ca6ddd86f03c9b0d84d87de25af4f40e75d
Hyeongseok Oh [Tue, 30 May 2017 10:05:35 +0000 (19:05 +0900)]
[RyuJIT/ARM32] Fix assertion failed 'remainingSize == TARGET_POINTER_SIZE'
Fix assertion failed by 'remainingSize == TARGET_POINTER_SIZE'
Fix to check register allocation correctly
Commit migrated from https://github.com/dotnet/coreclr/commit/
86454ad75a8fa8619fa21f199a2264c8fbc2d228
Hyeongseok Oh [Tue, 30 May 2017 09:58:33 +0000 (18:58 +0900)]
[RyuJIT/ARM32] Fix offset of struct argument when using stack
Fix offset value when struct argument is passed on stack
Commit migrated from https://github.com/dotnet/coreclr/commit/
99cd56e15b8122fdc965f109066105014d25c823
Tom Deseyn [Mon, 29 May 2017 13:46:10 +0000 (15:46 +0200)]
Implement GetCurrentProcessCpuCount for Unix and merge NumberOfProcesors implementations. (dotnet/coreclr#11742)
* Implement GetCurrentProcessCpuCount for Unix and merge NumberOfProcessors implementations.
* Split GetCurrentProcessCpuCount in PAL and non-PAL parts
* gcenv.unix.cpp: GetCurrentProcessAffinityMask: revert, GetCurrentProcessCpuCount: add implementation
* bugfix: #if instead of #ifdef HAVE_SCHED_GETAFFINITY
* Remove PAL_GetCurrentProcessCpuCount
* gcenv.unix: implement GetCurrentProcessAffinityMask, GetCurrentProcessCpuCount
* numa.cpp: initialize g_cpuToAffinity[i].Number when numa.h is missing
* cleanup
* mscorwks_unixexports.src: Add GetProcessAffinityMask
* PR feedback
* Add GetProcessAffinityMask to mscordac_unixexports.src
Commit migrated from https://github.com/dotnet/coreclr/commit/
ee454e11d0c73820dde10ab710f9d6eccd4471f1
Buyduck [Mon, 29 May 2017 11:26:41 +0000 (14:26 +0300)]
added DWARF exprloc for static value class fields (dotnet/coreclr#11911)
Commit migrated from https://github.com/dotnet/coreclr/commit/
c08d7df65036795bc3284e18624827303a097c88
Morgan Brown [Sat, 27 May 2017 02:13:06 +0000 (19:13 -0700)]
Fix build breaks
* Remove UnitySerializationHolder references
* Remove the fields of StrongNameKeyPair
* Initialize BadImageFormatException._fusionLog
* Remove MemberInfoSerializationHolder references
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
42b5e15d656ac466ece6587005ffb646d4c9e9a3
Morgan Brown [Sun, 28 May 2017 04:07:32 +0000 (21:07 -0700)]
IDeserializationCallback cleanup
Throws PlatformNotSupportedException from IDeserializationCallback and IObjectReference implementations on types that are no longer serializable.
Commit migrated from https://github.com/dotnet/coreclr/commit/
68570e183b2dc53682079d8ab4dac24f893aebfa
mikedn [Sat, 27 May 2017 23:09:11 +0000 (02:09 +0300)]
Fix tool initialization detection (dotnet/coreclr#11912)
init-tools.cmd attempts to create a file in a directory that doesn't exist. File creation fails and next time the script is run initialization will be performed again. That wastes a lot of time.
Commit migrated from https://github.com/dotnet/coreclr/commit/
a90081b1d83f0447cace40b18ee908117d12b645
dotnet bot [Sat, 27 May 2017 23:07:59 +0000 (16:07 -0700)]
Update CoreClr to preview1-25327-01 (dotnet/coreclr#11949)
Commit migrated from https://github.com/dotnet/coreclr/commit/
37c61722c3062d45f8ff3008424e02a759357afb
Rich Lander [Sat, 27 May 2017 18:46:13 +0000 (11:46 -0700)]
Update test coverage statements in workflow doc
Commit migrated from https://github.com/dotnet/coreclr/commit/
76963543e01df297ada420804f71c27977879edc
Rich Lander [Sat, 27 May 2017 05:01:25 +0000 (22:01 -0700)]
Update license links
Commit migrated from https://github.com/dotnet/coreclr/commit/
ce8bcb81f993fbdfc8c0a9f36ecec8bc317ce8e1
dotnet bot [Sat, 27 May 2017 05:00:51 +0000 (22:00 -0700)]
Update CoreClr, CoreFx to preview1-25326-02, preview1-25324-02, respectively (dotnet/coreclr#11932)
Commit migrated from https://github.com/dotnet/coreclr/commit/
d71eec734916f75dd05dba986434458ea11e5cd3
Rich Lander [Sat, 27 May 2017 04:56:27 +0000 (21:56 -0700)]
Update contributor docs (dotnet/coreclr#11944)
* Update contributor docs
* Update
* Added up-for-grabs and ports
* Update binary licensing
* Update\
* Simplify developer workflow doc
* Update per feedback
Commit migrated from https://github.com/dotnet/coreclr/commit/
8ca5a626ec508f75dce2ede92fd7748472a07a08
José Rivero [Sat, 27 May 2017 01:01:05 +0000 (18:01 -0700)]
Enable linux perf runs (dotnet/coreclr#11905)
- Removing `[assembly: MeasureInstructionsRetired]` from performance tests.
- Due to this issue: https://github.com/Microsoft/xunit-performance/issues/231, we are blocked from running on performance tests on Linux.
The tag is not used by infrastructure and it is passed during runtime when profiling on Windows.
- Adding the option to execute CoreRun with the stability prefix.
- Moving file to be archived by Jenkins and updating groovy file.
- Setting the maximum number of iterations.
Commit migrated from https://github.com/dotnet/coreclr/commit/
70ea7d4a2379827f55582fd4d3fd57ab767c6fa1
Morgan Brown [Sat, 27 May 2017 00:45:37 +0000 (17:45 -0700)]
ISerializable cleanup (dotnet/coreclr#11873)
Changes to throw PlatformNotSupportedException from ISerializable.GetObjectData and serialization constructors on non-Serializable types. Also removes private serialization constructors and some unneeded code that was used to support serializing non-serializable types. A few tests testing GetObjectData implementations are also removed. For Exception types, we call base instead of throwing from GetObjectData to be consistent with the many Exceptions that don't override GetObjectData
Commit migrated from https://github.com/dotnet/coreclr/commit/
b479cee9fdcee2cb4035fda788d34e724e32a222
Brian Robbins [Fri, 26 May 2017 21:39:42 +0000 (14:39 -0700)]
Move rundown to the same code-site where we do ETW rundown before EEShutdown is marked as started. (dotnet/coreclr#11937)
Commit migrated from https://github.com/dotnet/coreclr/commit/
c1bf59fbe4f0c54020ad9990bad33ccda4ae4519
Brian Sullivan [Fri, 26 May 2017 18:08:01 +0000 (11:08 -0700)]
Merge pull request dotnet/coreclr#11920 from briansull/crossgen-tuning
Remove the check that requires an instrumented flags for SPC when collecting IBC data
Commit migrated from https://github.com/dotnet/coreclr/commit/
6b837711f8cb1c572aec725a85c83decb00fc4da
Sergey Andreenko [Fri, 26 May 2017 16:13:08 +0000 (09:13 -0700)]
Fix BitSetUint64, clean and improve the surrounding code. (dotnet/coreclr#11721)
1. Add the functions that were not implemented in bitsetasuint64inclass/
2. BitSetUint64: make copy_constructor public
3. delete VARSET_INIT_NOCOPY and ALLVARSET_INIT_NOCOPY
4. delete VARSET_INIT and ALLVARSET_INIT.
5. Use the correct const type for VARSET_TP.
Commit migrated from https://github.com/dotnet/coreclr/commit/
d85104ea4e8a6328323f31a06107e3579a098093
Carol Eidt [Fri, 26 May 2017 15:13:27 +0000 (08:13 -0700)]
Merge pull request dotnet/coreclr#11823 from hqueue/arm/ryujit/lsra_gc_helper
[RyuJIT/ARM][LSRA] Update register mask for GC helper
Commit migrated from https://github.com/dotnet/coreclr/commit/
6e3aaf4b40ac36f97dd73864851aaffad1280a7f
Jan Kotas [Fri, 26 May 2017 14:17:51 +0000 (07:17 -0700)]
EETypeHashTable lookups can deadlock with GC during comparison with unrestored persisted TypeHandles (dotnet/coreclr#11922)
Commit migrated from https://github.com/dotnet/coreclr/commit/
a3c193780b8e055678feb06b2499cf8e7b41810c
Petr Bred [Fri, 26 May 2017 14:17:05 +0000 (17:17 +0300)]
Fix compile with disabled FEATURE_READYTORUN option (dotnet/coreclr#11875)
- just remove FEATURE_READYTORUN definitions
in clrdefinitions.cmake to turn off option
Signed-off-by: Petr Bred <bredpetr@gmail.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
8a934c90711e0d1a915e309941a34db832395076
Hyung-Kyu Choi [Fri, 26 May 2017 07:12:33 +0000 (16:12 +0900)]
[RyuJIT/ARM32] Update RMB for helper function
Make RBM_CALLEE_TRASH be consistent with CORINFO_HELP_STOP_FOR_GC helper
which is JIT_RareDisableHelper defined in vm/arm/asmhelpers.S
Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
c7598734c5bd0939bbcc9abe32f265a54ea973b4
Michal Strehovský [Fri, 26 May 2017 01:24:34 +0000 (18:24 -0700)]
Merge pull request dotnet/corertdotnet/coreclr#3709 from dotnet/nmirror
Merge nmirror to master
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
3613e93bb364a82efa1a0d0b82c89b996b043c52
Joseph Tremoulet [Fri, 26 May 2017 05:41:38 +0000 (01:41 -0400)]
Merge pull request dotnet/coreclr#11917 from JosephTremoulet/RationalCall
Clear GTF_CALL from non-calls in rationalize
Commit migrated from https://github.com/dotnet/coreclr/commit/
74c988e2a5a59bb04df78088c9bb41206100cd24
Brian Sullivan [Thu, 25 May 2017 22:27:15 +0000 (15:27 -0700)]
Remove the check that requires an instrumented flags for mscorlib when collecting IBC data
This is not needed for CoreCLR and blocks some valuable usage cases.
Commit migrated from https://github.com/dotnet/coreclr/commit/
fa29376a493f76cb6328030f12e46c0943a6daa0
Carol Eidt [Thu, 25 May 2017 22:01:33 +0000 (15:01 -0700)]
Merge pull request dotnet/coreclr#11878 from CarolEidt/ContainLclVars
Make non-tracked lclVars contained
Commit migrated from https://github.com/dotnet/coreclr/commit/
54370b62cda87d91d1660faa58e95f63b4b0d92c
Pat Gavlin [Thu, 25 May 2017 21:55:27 +0000 (14:55 -0700)]
Merge pull request dotnet/coreclr#11919 from pgavlin/XunitTestResults
Add XUnit results for Windows_NT x86 jobs.
Commit migrated from https://github.com/dotnet/coreclr/commit/
c633bdea4a6adf084122ad027c03fb590d2f6b9d
Pat Gavlin [Thu, 25 May 2017 21:35:24 +0000 (14:35 -0700)]
Merge pull request dotnet/coreclr#11880 from mskvortsov/FixSetRegToCond
[RyuJIT/arm32] Fix genRegSetToCond() for FP case
Commit migrated from https://github.com/dotnet/coreclr/commit/
a30462946d3bc1e3f829adc05cae459cea8f130e
Pat Gavlin [Thu, 25 May 2017 21:29:48 +0000 (14:29 -0700)]
Add XUnit results for Windows_NT x86 jobs.
Commit migrated from https://github.com/dotnet/coreclr/commit/
42d7d1f6e49ab78cbf6242f3e02eeffa90670c5e
Carol Eidt [Fri, 28 Apr 2017 22:32:07 +0000 (15:32 -0700)]
Make untracked lclVars contained
Make untracked lclVars contained where possible.
Commit migrated from https://github.com/dotnet/coreclr/commit/
205136aa1f74739879ce66e812732a553dfe05e3
Brian Robbins [Thu, 25 May 2017 19:28:24 +0000 (12:28 -0700)]
Implement Activity ID / Related Activity ID for EventSources Writing to EventPipe (dotnet/coreclr#11904)
* Implement thread-local storage of activity ids.
* Plumb the activity id and related activity id into the trace file.
Commit migrated from https://github.com/dotnet/coreclr/commit/
7ca2692405f255ce4a87d2c3ec263d938cf274fc
Joseph Tremoulet [Thu, 25 May 2017 19:14:48 +0000 (15:14 -0400)]
Clear GTF_CALL from non-calls in rationalize
Since rationalization hoists comma antecedents out into separate
statements, any side-effects that the antecedent had might no longer apply
to the comma's ancestor nodes. Moreover, in LIR, side-effect flags need
only describe the immediate node; summary flags are computed when Ranges
are constructed. So, update rationalize to clear the `GTF_CALL` flag from
any node that is not a call. Failure to do so gives an
overly-conservative view of side-effects, which can inhibit dead store
removal.
Commit migrated from https://github.com/dotnet/coreclr/commit/
14641370874346619e391f333218da275f81508e
Jarret Shook [Thu, 25 May 2017 15:46:08 +0000 (08:46 -0700)]
Merge pull request dotnet/coreclr#11834 from jashook/renable_arm64_span_test
[Arm64 Windows] Renable SpanBench
Commit migrated from https://github.com/dotnet/coreclr/commit/
ed1342ba2409cd8bc736380017ee39eaa1701cf2
Hyeongseok Oh [Tue, 16 May 2017 10:37:03 +0000 (19:37 +0900)]
[ARM32/Linux] Copy tests.zip only for CI test
Copy tests.zip only from x64 Windows build for CI test
We can reduce saved build results of linux/arm in CI machine
Commit migrated from https://github.com/dotnet/coreclr/commit/
821669e2a5c33e146e1fefa958f38ea56f740094
Tomáš Matoušek [Thu, 25 May 2017 06:48:05 +0000 (23:48 -0700)]
Adds System.Runtime.CompilerServices.Runtimefeature.PortablePdb (dotnet/coreclr#11845)
Commit migrated from https://github.com/dotnet/coreclr/commit/
6c4d14e1b2b6bcb975496bb9b4ea9befa53781fd
Aditya Mandaleeka [Thu, 25 May 2017 06:47:28 +0000 (23:47 -0700)]
Remove g_fEEManagedEXEStartup and g_fEEIJWStartup. (dotnet/coreclr#11907)
Commit migrated from https://github.com/dotnet/coreclr/commit/
823180af6da15413f98bfc12d95423f1a80c0b01
Brian Robbins [Thu, 25 May 2017 01:19:22 +0000 (18:19 -0700)]
Mark the EventPipe crst as host breakable. (dotnet/coreclr#11899)
Commit migrated from https://github.com/dotnet/coreclr/commit/
42d80a7fa4aa7dece7291b9d1be54955470dd625
dotnet bot [Thu, 25 May 2017 01:15:00 +0000 (18:15 -0700)]
Update CoreClr, CoreFx to preview1-25323-01, preview1-25323-02, respectively (master) (dotnet/coreclr#11809)
* Update CoreClr, CoreFx to preview1-25323-01, preview1-25323-02, respectively
* Update corefx package versions in projects
Commit migrated from https://github.com/dotnet/coreclr/commit/
715845bfa33576badfd1a62177ea85581a5f105e
Jonghyun Park [Thu, 25 May 2017 00:42:31 +0000 (09:42 +0900)]
[x86/Linux] Reentrant PEImage::Load (dotnet/coreclr#11867)
* [x86/Linux] Reentrant PEImage::Load
* Use HasLoadedLayout and add comments
Commit migrated from https://github.com/dotnet/coreclr/commit/
6cc2fb7a26040d6ab5a2f899008100a9d4f8622c
Pat Gavlin [Wed, 24 May 2017 23:45:04 +0000 (16:45 -0700)]
Merge pull request dotnet/coreclr#11894 from pgavlin/gh11804
Never enregister type-punned regStruct lclVars.
Commit migrated from https://github.com/dotnet/coreclr/commit/
284e31f746fe8c80c091b5e67a922100a9c95b0f
Xiang Fan [Wed, 24 May 2017 22:51:38 +0000 (15:51 -0700)]
Fix Issue 11861 (dotnet/coreclr#11886)
* Fix issues exposed by building with MSVC and /permissive-.
Using full-qualified name to declare members inside class is ill-formed and incorrectly allowed by MSVC.
MSVC now gives error when /permissive- is used.
* Add a forward declaration for SafeAddRef from utilcode.h.
SafeAddRef in holder.h calls SafeAddRef in utilcode.h. The latter hasn't been declared yet, so it isn't a valid candidate during overload resolution.
It happens to work in MSVC default mode because of the lack of two phase name lookup.
Commit migrated from https://github.com/dotnet/coreclr/commit/
0ad57d9177ac88aabbf9354b985c5ac192a307e7
gbalykov [Wed, 24 May 2017 22:50:26 +0000 (01:50 +0300)]
Allow RelativePointer::SetValue usage for non-DAC builds only (dotnet/coreclr#11891)
Commit migrated from https://github.com/dotnet/coreclr/commit/
f853a04ea9c80bf63419a07fe3fe2fefb23d25aa
Joseph Tremoulet [Wed, 24 May 2017 22:12:28 +0000 (18:12 -0400)]
Merge pull request dotnet/coreclr#11893 from JosephTremoulet/WeakenIBRAssert
Weaken type assertion in gtNewLclNode
Commit migrated from https://github.com/dotnet/coreclr/commit/
da79431bd20de055dae9a4de5696286018a1c47a
Joseph Tremoulet [Wed, 24 May 2017 21:44:28 +0000 (17:44 -0400)]
Merge pull request dotnet/coreclr#11883 from JosephTremoulet/PromotedStructRefs
Update full-struct references to promoted IBR args
Commit migrated from https://github.com/dotnet/coreclr/commit/
ce0170d41761d604b6f5bb8cf2a0139ae86e1c2c
Brian Robbins [Wed, 24 May 2017 21:43:54 +0000 (14:43 -0700)]
Indicate if thread time events are in managed or native code. (dotnet/coreclr#11892)
Commit migrated from https://github.com/dotnet/coreclr/commit/
cd88c6919e75617fad6a6c6e772ee16f09d53ac2
Jarret Shook [Wed, 24 May 2017 20:37:59 +0000 (13:37 -0700)]
Merge pull request dotnet/coreclr#11832 from jashook/add_1_mod_1_case
Add the case 1 % 1 to our bringup test
Commit migrated from https://github.com/dotnet/coreclr/commit/
2c83d8d2dbd8a99cdb99180f4371c1a5d7211a6f
Pat Gavlin [Wed, 24 May 2017 19:34:09 +0000 (12:34 -0700)]
Never enregister type-punned regStruct lclVars.
Type-punned lclVars--i.e. lclVars that are accessed via
`(INDIR Tx (ADDR (LCLVAR Ty V)))`--are currently considered
enregisterable if they are SIMD-typed, have not been the accessed by
field, and have not otherwise been declared unenregisterable. This
appears to be an oversight, as the JIT is not able to generate correct
code for the type-punned access if the lclVar is in fact enregistered.
This change removes the special case for these SIMD-typed lclVars.
Fixes dotnet/coreclr#11804.
Commit migrated from https://github.com/dotnet/coreclr/commit/
e1bc678f35adb2d3f1ca40d0414bde2407159c2d
Joseph Tremoulet [Wed, 24 May 2017 20:08:36 +0000 (16:08 -0400)]
Weaken type assertion in gtNewLclNode
Implicit byref parameters originally have struct type in both the lvaTable
and on their appearances in the IR. In fgRetypeImplicitByRefArgs, the
types in the lvaTable are updated, and subsequently, during global morph,
in fgMorphImplicitByRefArgs, the types of their appearances in the IR are
updated. Weaken an assertion in lcl var creation to allow the type
disagreement for implicit byref parameter references during global morph.
Fixes dotnet/coreclr#11831.
Commit migrated from https://github.com/dotnet/coreclr/commit/
f0df32af682d50ecf3c6302f82ccbf0d3eaca8e9
Joseph Tremoulet [Wed, 24 May 2017 19:37:15 +0000 (15:37 -0400)]
Improve comments around implicit byref rewrite
A number of fields on the LclVarDsc get hijacked during the multi-stage
rewrite of implicit-by-reference parameters; add comments at the fields'
declarations as well as the hijacking uses.
Commit migrated from https://github.com/dotnet/coreclr/commit/
5e61addb63e2c3714c0bea6217239915112f25bc
Steve MacLean [Wed, 24 May 2017 18:31:44 +0000 (14:31 -0400)]
[Arm64/Win] Revise JIT_MemSet (dotnet/coreclr#11420)
* [Arm64/Win] Revise JIT_MemSet
This is the Windows equivalent of dotnet/coreclr#11217 which merged
* [Arm64/Win] Use csel<con> for csel
MS Assembler expects csel<cond> for the csel instruction
Commit migrated from https://github.com/dotnet/coreclr/commit/
7bdf517d73dc8332e30af25deddb880a3b533794
Jonghyun Park [Wed, 24 May 2017 17:34:59 +0000 (02:34 +0900)]
[x86/Linux] Thread-safe UMThunkMarshInfo::RunTimeInit (dotnet/coreclr#11864)
Commit migrated from https://github.com/dotnet/coreclr/commit/
44285ef65b626db7954066ff596d6be07c7dd7a2
Joseph Tremoulet [Wed, 24 May 2017 16:23:52 +0000 (12:23 -0400)]
Update full-struct references to promoted IBR args
Update fgMorphImplicitByRefArgs to rewrite references to struct-promoted
implicit-by-reference parameters as references to the new struct temps
created in fgRetypeImplicitByRefArgs; fgMorphStructField isn't updating
these because it's only interested in field references, and runs upstream
of fgRetypeImplicitByRefArgs where the full struct temp is created,
anyway.
Invert the sense of lvPromoted for implicit byref args in the interim
between fgRetypeImplicitByRefArgs and fgMarkDemotedImplicitByRefArgs,
since now fgMarkDemotedImplicitByRefArgs needs to update both and would
look horribly backwards the other way around.
Fixes dotnet/coreclr#11814.
Commit migrated from https://github.com/dotnet/coreclr/commit/
0057a2f81e3a48e4b3e15bbb2f1b78d8ceb399e6
Mikhail Skvortcov [Wed, 24 May 2017 15:01:36 +0000 (18:01 +0300)]
RyuJIT/arm32: Fix genRegSetToCond for FP cases
Commit migrated from https://github.com/dotnet/coreclr/commit/
da9da2996d04b76ffb210013f4a2254eb5262ca4
Hyung-Kyu Choi [Wed, 24 May 2017 07:42:09 +0000 (16:42 +0900)]
Fix format
Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
5e33fedd9f49f074d3ece70238271a1ad2a18000
Hyung-Kyu Choi [Wed, 24 May 2017 07:19:30 +0000 (16:19 +0900)]
[RyuJIT/ARM32] Dodge lowering long compares
Let's dodge lowering long compares to avoid ryujit/arm32 failure
and enable it later when required implementaion is available.
Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
89ec2f7c01d8d3cde390023cc2bc076997a70573
Swaroop Sridhar [Tue, 23 May 2017 21:33:36 +0000 (14:33 -0700)]
ILLink performance: Disable Roslyn Test
Temporarily disable roslyn test, since it is failing in the lab.
Commit migrated from https://github.com/dotnet/coreclr/commit/
a125a6e786f09045a28a7d3e4a2c612602f9d220
Morgan Brown [Wed, 24 May 2017 00:11:24 +0000 (17:11 -0700)]
Scale back [Serializable] on CoreCLR types (dotnet/coreclr#11765)
Removes SerializableAttribute from CoreCLR types not intended to be serializable as well as adding special handling to MulticastDelegate to prevent serializing delegates (which can't be correctly serialized cross platform/runtime).
Commit migrated from https://github.com/dotnet/coreclr/commit/
ebda0e66df0dd19688cf8a88375bb31c184f5037
Brian Robbins [Tue, 23 May 2017 23:11:44 +0000 (16:11 -0700)]
Return early if EventPipeBuffer is empty. (dotnet/coreclr#11855)
Commit migrated from https://github.com/dotnet/coreclr/commit/
f0e21f4d46161edb7222b478af2b519fc808b9ad
Jan Kotas [Tue, 23 May 2017 22:09:03 +0000 (15:09 -0700)]
Delete special handling of IJW RVA fields at NGen time (dotnet/coreclr#11818)
Mixed mode managed C++ is not supported by CoreCLR so this is not needed for anything.
Fixes dotnet/coreclr#11761
Commit migrated from https://github.com/dotnet/coreclr/commit/
4229c5d7ea196c93dc8b76c8718929a2e4ff94ed
Joseph Tremoulet [Tue, 23 May 2017 21:57:56 +0000 (17:57 -0400)]
Merge pull request dotnet/coreclr#11694 from JosephTremoulet/IconHoist
Don't hoist IConHandle statics above cctors
Commit migrated from https://github.com/dotnet/coreclr/commit/
1bcbea8102ace0cda74b9ecb3e05151944610e42
jashook [Tue, 23 May 2017 17:13:38 +0000 (10:13 -0700)]
[Arm64 Windows] Renable SpanBench
Commit migrated from https://github.com/dotnet/coreclr/commit/
0a2896679337b2efc600b52ff32e6ac78a1626d0
jashook [Tue, 23 May 2017 16:50:33 +0000 (09:50 -0700)]
Add the case 1 % 1 to our bringup test
Addresses lack of coverage shown in dotnet/coreclr#7168.
Commit migrated from https://github.com/dotnet/coreclr/commit/
d7cca91397a0b6b8b9ac0ac8ebffd6afd7c899dd
Bruce Forstall [Tue, 23 May 2017 16:38:03 +0000 (09:38 -0700)]
Merge pull request dotnet/coreclr#11366 from ruben-ayrapetyan/remove-zap-code-relocs-for-linux-arm32
Change relocations in ngen-ed code with PC-relative constants for Linux ARM32
Commit migrated from https://github.com/dotnet/coreclr/commit/
b2164d274f13023e5546fab849f6f15381ba4475
Pat Gavlin [Tue, 23 May 2017 15:29:45 +0000 (08:29 -0700)]
Merge pull request dotnet/coreclr#10275 from mikedn/x86-cmp-long-lower
Lower long compares that are materialized into a register
Commit migrated from https://github.com/dotnet/coreclr/commit/
49ac50b66ffac78eddb69ae7b64f790b9cc3ab27
Mike McLaughlin [Tue, 23 May 2017 15:01:25 +0000 (08:01 -0700)]
Remove "corerun" sos plugin command. (dotnet/coreclr#11812)
It broke building on debug osx and isn't used or needed anymore.
Commit migrated from https://github.com/dotnet/coreclr/commit/
b375dc46dfefded3ac6b69bb7f2b085b5f28fcfe
Ruben Ayrapetyan [Wed, 5 Apr 2017 18:08:32 +0000 (21:08 +0300)]
Direct mapping of IL-assembly images that don't contain writeable sections.
Commit migrated from https://github.com/dotnet/coreclr/commit/
31b5ee0bc7df328fd9187d25dbadebe7c1623d38
Ruben Ayrapetyan [Fri, 7 Apr 2017 10:25:42 +0000 (13:25 +0300)]
Extract PEImage::CreateLayoutMapped and PEImage::CreateLayoutFlat from PEImage::GetLayoutInternal.
Commit migrated from https://github.com/dotnet/coreclr/commit/
155f8c247b35549a5d48523f9e6715a94b939d01
Hyung-Kyu Choi [Tue, 23 May 2017 12:46:46 +0000 (21:46 +0900)]
[RyuJIT/ARM][LSRA] Update register mask for GC helper
CORINFO_HELP_STOP_FOR_GC helper preserves integer and double return register.
Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
b54878f5d0107d99b45c2f54184a07c4b9331ff5
Pat Gavlin [Tue, 23 May 2017 06:09:25 +0000 (23:09 -0700)]
Merge pull request dotnet/coreclr#10990 from mikedn/narrow-test
Narrow TEST instructions when possible
Commit migrated from https://github.com/dotnet/coreclr/commit/
11e2bc8e98a84a8e2bba0bdb80b5ec9a952abf92
Mike Danes [Sun, 19 Mar 2017 12:57:19 +0000 (14:57 +0200)]
Delete long compare support from x86 codegen
Commit migrated from https://github.com/dotnet/coreclr/commit/
fec30c465014468073e6feafae6c8e7646f7ff51
Mike Danes [Sat, 18 Mar 2017 00:39:25 +0000 (02:39 +0200)]
Lower long compares that are materialized into a register
Commit migrated from https://github.com/dotnet/coreclr/commit/
e5d76089a7af352759ed395ecc3c2e61bd6f9640
Mike Danes [Sat, 18 Mar 2017 09:02:35 +0000 (11:02 +0200)]
Introduce GT_CMP and GT_SETCC(condition)
Commit migrated from https://github.com/dotnet/coreclr/commit/
7a4b14e5366bba52d188695c803c9e27e103d362
Michal Strehovský [Tue, 23 May 2017 01:27:19 +0000 (18:27 -0700)]
Use sigInst.methInstCount != 0 to detect generic methods (dotnet/coreclr#11780)
`methInstCount` is the thing that RyuJIT uses to detect generic virtual
methods in another place. `CORINFO_CALLCONV_GENERIC` reporting was added
because nobody knew about `methInstCount`. We already report
`methodInstCount` in CoreRT. We can delete a couple of lines on the
CoreRT side by switching to this scheme.
Commit migrated from https://github.com/dotnet/coreclr/commit/
b7751d55b3f584e118c0dcba3ede6ed752c1175c
Bruce Forstall [Tue, 23 May 2017 00:51:45 +0000 (17:51 -0700)]
Merge pull request dotnet/coreclr#11810 from BruceForstall/FixUninitWarning
Fix VC++ C4201 warning on desktop build
Commit migrated from https://github.com/dotnet/coreclr/commit/
e2b4629d8cd3c11f93f787f80b469cbed955b74d
Bruce Forstall [Tue, 23 May 2017 00:51:22 +0000 (17:51 -0700)]
Merge pull request dotnet/coreclr#11797 from BruceForstall/CommonizeAdr
Handle INS_adr in emitIns_R_L on both arm32 and arm64
Commit migrated from https://github.com/dotnet/coreclr/commit/
7db329b4b7faf0d75849712b2a70c0f107119540
José Rivero [Mon, 22 May 2017 23:50:05 +0000 (16:50 -0700)]
Bump the version of the xUnit-Performance package (dotnet/coreclr#11793)
- In a previous PR this was reverted and broke the Profile On/Off perf runs
Commit migrated from https://github.com/dotnet/coreclr/commit/
2711964dd0f60cafcaceec40097ffdbdf522f64d
Joseph Tremoulet [Mon, 22 May 2017 21:27:30 +0000 (17:27 -0400)]
Quiet warning C2220
This warning reports "potentially uninitialized local variable
`fieldOffset` used". The use is guarded by a check on `fieldHnd` being
non-null, and `fieldOffset` gets initialized properly on all paths that
set `fieldHnd` to something other than null, so the fix is simply to
initialize `fieldOffset` to 0 at its declaration so the compiler won't
complain.
Resolves dotnet/coreclr#11800.
Commit migrated from https://github.com/dotnet/coreclr/commit/
acfbd811e8a107f15085b32a9d30f3148d044e00
Bruce Forstall [Mon, 22 May 2017 23:07:08 +0000 (16:07 -0700)]
Fix VC++ C4201 warning on desktop build
Fixes dotnet/coreclr#11808
Commit migrated from https://github.com/dotnet/coreclr/commit/
12f387850d90d0580e23c9da498242ccf2ce0161
Joseph Tremoulet [Mon, 22 May 2017 21:23:50 +0000 (17:23 -0400)]
Fix off-by-one error
The code in loop hoisting visiting a comma for a static init helper call
and static field access tried to clear the childrenHoistable bit for the
field, but had an off-by-one error and was instead clearing the bit for
the helper call, which could lead to missed legal helper call hoists.
Update that code to simply assert that the flag is already set for the
field (using the correct index), which must be true since the check is
guarded by a check that childIsCctorDependent is true for it.
Commit migrated from https://github.com/dotnet/coreclr/commit/
357318f3e97df53d5c0ffc51598096a7fc0f5662
Russ Keldorph [Mon, 22 May 2017 18:24:09 +0000 (11:24 -0700)]
Revert "Fixed tests build on Linux"
Commit migrated from https://github.com/dotnet/coreclr/commit/
a16a8a852077b0c471cf12ef75dc5e8a41333533
Bruce Forstall [Mon, 22 May 2017 20:08:42 +0000 (13:08 -0700)]
Merge pull request dotnet/coreclr#11776 from parjong/fix/x86_STDMETHODCALLTYPE_as_cdecl
[x86/Linux] Set CDECL as STDMETHODCALLTYPE
Commit migrated from https://github.com/dotnet/coreclr/commit/
c41d51e46069b3b21b8a0361688e2557586f353c
Bruce Forstall [Mon, 22 May 2017 20:06:34 +0000 (13:06 -0700)]
Merge pull request dotnet/coreclr#11778 from hqueue/arm/ryujit/float_ld_st
[RyuJIT/ARM32] Implement and add NYI assertion for load/store for float
Commit migrated from https://github.com/dotnet/coreclr/commit/
21deb6f87b1b8edaedae3a1c9a4adf73547f4ca9
Bruce Forstall [Mon, 22 May 2017 18:34:15 +0000 (11:34 -0700)]
Handle INS_adr in emitIns_R_L on both arm32 and arm64
Commit migrated from https://github.com/dotnet/coreclr/commit/
48794652d5077bce1f759df58b1550941717fb56
Pat Gavlin [Mon, 22 May 2017 19:59:33 +0000 (12:59 -0700)]
Merge pull request dotnet/coreclr#11750 from pgavlin/gh11734
Fix legality checks in SetRegOptionalForBinOp.
Commit migrated from https://github.com/dotnet/coreclr/commit/
6be915a5aa21e4639bdcd0a228a7f8e851420dd7