Seungha Yang [Wed, 7 Oct 2020 18:15:21 +0000 (03:15 +0900)]
decklink: Update doc
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1665>
Seungha Yang [Wed, 7 Oct 2020 16:39:42 +0000 (01:39 +0900)]
decklink: Update Windows headers with SDK 11.2
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1665>
Seungha Yang [Wed, 7 Oct 2020 16:33:35 +0000 (01:33 +0900)]
decklink: Update OSX headers with SDK 11.2
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1665>
Tim [Tue, 25 Jun 2019 09:51:32 +0000 (11:51 +0200)]
decklink: Updated DeckLink SDK to 11.2 to support DeckLink 8K Pro
Updated Decklink SDK to version 11.2 in order to support newer cards like the Decklink 8K Pro.
This required to replace the duplex property by a profile property.
Profile values can be the following:
- bmdProfileOneSubDeviceFullDuplex
- bmdProfileOneSubDeviceHalfDuplex
- bmdProfileTwoSubDevicesFullDuplex
- bmdProfileTwoSubDevicesHalfDuplex
- bmdProfileFourSubDevicesHalfDuplex
Fixes #987
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1665>
Seungha Yang [Wed, 7 Oct 2020 08:37:25 +0000 (17:37 +0900)]
mfvideosrc: Fix invalid memory access when outputting jpeg
Don't access unknown-dangerous-nonsense address
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1662>
Sebastian Dröge [Thu, 8 Oct 2020 15:50:12 +0000 (18:50 +0300)]
Revert "webrtc: Save the media kind in the transceiver"
This reverts commit
f54d8e99457996303b8477b1f3a710f0fabd1cc6.
It breaks the CI until the C# bindings are fixed.
Sebastian Dröge [Thu, 8 Oct 2020 15:49:57 +0000 (18:49 +0300)]
Revert "rtpsender: Add API to set the priority"
This reverts commit
a8b287c76472c8d7fd38800807c482d020ff4a63.
It breaks the CI until the C# bindings are fixed.
Sebastian Dröge [Thu, 8 Oct 2020 15:49:56 +0000 (18:49 +0300)]
Revert "rtptransceiver: Store the SSRC of the current stream"
This reverts commit
d1da271f255101dbe95a426d9f5065d300b53e5a.
It breaks the CI until the C# bindings are fixed.
Sebastian Dröge [Thu, 8 Oct 2020 15:49:55 +0000 (18:49 +0300)]
Revert "webrtcbin: Remove unused function"
This reverts commit
39723dbe934186c11f7b2a2b04c0af7932a1509c.
It breaks the CI until the C# bindings are fixed.
Sebastian Dröge [Thu, 8 Oct 2020 15:49:54 +0000 (18:49 +0300)]
Revert "webrtc: Set the DSCP markings based on the priority"
This reverts commit
8ba08598bbe51f3b1f063ae22605f9608865f16b.
It breaks the CI until the C# bindings are fixed.
Sebastian Dröge [Thu, 8 Oct 2020 15:49:53 +0000 (18:49 +0300)]
Revert "webrtc: Document more objects"
This reverts commit
ad68c6b1eb7c73c66dc9d1dbf1a8cc47fd489c61.
It breaks the CI until the C# bindings are fixed.
Sebastian Dröge [Thu, 8 Oct 2020 15:49:50 +0000 (18:49 +0300)]
Revert "webrtc: Add hotdoc style since tags"
This reverts commit
63a5fa818c31ecbe43891c077a38b6b162d73c28.
It breaks the CI until the C# bindings are fixed.
Olivier Crête [Tue, 6 Oct 2020 20:52:48 +0000 (16:52 -0400)]
webrtc: Add hotdoc style since tags
We're stuck having to add a separate comment for now.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1425>
Olivier Crête [Sat, 3 Oct 2020 01:38:00 +0000 (21:38 -0400)]
webrtc: Document more objects
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1425>
Olivier Crête [Wed, 8 Jul 2020 21:24:36 +0000 (17:24 -0400)]
webrtc: Set the DSCP markings based on the priority
This matches how the WebRTC javascript API works and the Chrome implementation.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1425>
Olivier Crête [Thu, 9 Jul 2020 17:45:20 +0000 (13:45 -0400)]
webrtcbin: Remove unused function
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1425>
Olivier Crête [Thu, 9 Jul 2020 17:42:35 +0000 (13:42 -0400)]
rtptransceiver: Store the SSRC of the current stream
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1425>
Olivier Crête [Thu, 9 Jul 2020 17:39:03 +0000 (13:39 -0400)]
rtpsender: Add API to set the priority
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1425>
Olivier Crête [Wed, 8 Jul 2020 23:13:33 +0000 (19:13 -0400)]
webrtc: Save the media kind in the transceiver
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1425>
Jan Alexander Steffens (heftig) [Tue, 6 Oct 2020 11:39:23 +0000 (13:39 +0200)]
srt: Remove unused sa_family tracking
Now that SRT no longer needs the family when creating the socket, this
code has become useless.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1659>
Niklas Hambüchen [Fri, 2 Oct 2020 01:39:40 +0000 (03:39 +0200)]
srt: Move off deprecated `srt_socket()`.
See https://github.com/Haivision/srt/blob/
73ee1e1a3e3adc2702a9a5057d101ef80447b38c/docs/API-functions.md#srt_socket
`srt_create_socket()` was added in
https://github.com/Haivision/srt/commit/
4b897ba92d34f1829a1c6e419eeab17f0763a0fc
and srt `v1.3.0` is the first release that has it.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1659>
Jan Alexander Steffens (heftig) [Thu, 1 Oct 2020 15:31:13 +0000 (17:31 +0200)]
srt: Register a log handler
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1659>
Jan Alexander Steffens (heftig) [Fri, 25 Sep 2020 17:17:35 +0000 (19:17 +0200)]
srt: Avoid removing invalid sockets from the polls
This would provoke error messages from SRT.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1659>
Jan Alexander Steffens (heftig) [Fri, 25 Sep 2020 17:08:17 +0000 (19:08 +0200)]
srt: Fix use of srt_startup
`srt_startup` can also return 1 if it was successful. Avoid warning in
this case.
Avoid a race when checking whether we need to call it at all.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1659>
Jan Alexander Steffens (heftig) [Tue, 6 Oct 2020 10:35:12 +0000 (12:35 +0200)]
srt: Fix parameter types used for socket options
The [SRT documentation][1] specifies exact types for the socket options.
Make sure we match these.
This reverts the linger workaround in commit
84f8dbd932029220ee86154dd
and extends srt_constant_params to support other types than int.
[1]: https://github.com/Haivision/srt/blob/master/docs/APISocketOptions.md
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1659>
Seungha Yang [Tue, 29 Sep 2020 09:52:43 +0000 (18:52 +0900)]
d3d11upload: Allow passthrough for system memory
... like how d3d11download and gl{upload,download} do.
This should've been part of the commit
9b72b04daddafb1c86cb6ab5923c593a70bc4166
but I missed.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1645>
Víctor Manuel Jáquez Leal [Sun, 4 Oct 2020 08:01:31 +0000 (10:01 +0200)]
va: allocator: refactor flush methods for both allocators
Since the logic is the same, it can be generalized in a single common
function.
Also the methods run the common function with a lock and signal the
buffers' conditional.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1626>
Víctor Manuel Jáquez Leal [Sat, 3 Oct 2020 14:37:54 +0000 (16:37 +0200)]
va: allocator: refactor GstVaDmabufAllocator
Move code down to group it.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1626>
Víctor Manuel Jáquez Leal [Sat, 3 Oct 2020 14:30:14 +0000 (16:30 +0200)]
va: allocator: refactor GstVaBuffersurface
Move code up and add namespace to methods, and renaming
_creating_buffer_surface() to the canonical
gst_va_buffer_surface_new()
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1626>
Víctor Manuel Jáquez Leal [Wed, 30 Sep 2020 17:35:14 +0000 (19:35 +0200)]
va: implement pooled allocators
1. Allocators don't implement memory free() methods since all the memories will
implement dispose() returning FALSE
2. Memory/miniobject dispose() will act as memory release, enqueueing the
release memory
3. A new allocator's method prepare_buffer() which queries the released memory
queue and will add the requiered memories to the buffer.
4. Allocators added a GCond to synchronize dispose() and prepare_buffer()
5. A new allocator's method flush() which will free for real the memories.
While the bufferpool will
1. Remove all the memories at reset_buffer()
2. Implement acquire_buffer() calling allocator's prepare_buffer()
3. Implement flush_start() calling allocator's flush()
4. start() is disabled since it pre-allocs buffers but also calls
our reset_buffer() which will drop the memories and later the
buffers are ditched, something we don't want. This approach avoids
buffer pre-allocation.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1626>
Víctor Manuel Jáquez Leal [Wed, 30 Sep 2020 13:54:18 +0000 (15:54 +0200)]
va: allocator: user gst_clear_object() for _buffer_surface_unref()
Event if this function is only used by gst_va_dmabuf_memories_setup(), it might
get reused later by GstVaDmabufAllocator's functions. This change makes the
function less fragile.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1626>
Víctor Manuel Jáquez Leal [Wed, 30 Sep 2020 13:53:39 +0000 (15:53 +0200)]
va: allocator: renamed gst_va_dmabuf_memory_release()
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1626>
Víctor Manuel Jáquez Leal [Wed, 30 Sep 2020 13:48:12 +0000 (15:48 +0200)]
va: allocator: renamed available_mems queue
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1626>
Víctor Manuel Jáquez Leal [Wed, 30 Sep 2020 13:45:54 +0000 (15:45 +0200)]
va: allocator: rename gst_va_dmabuf_allocator_setup_buffer()
Since it's related with GstVaDmabufAllocator.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1626>
Víctor Manuel Jáquez Leal [Tue, 29 Sep 2020 13:03:11 +0000 (15:03 +0200)]
va: allocator: calculated surface frame internally
Instead of using gst_buffer_get_size() just add the memory sizes reported by
exported fd.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1626>
Víctor Manuel Jáquez Leal [Mon, 28 Sep 2020 14:59:44 +0000 (16:59 +0200)]
va: allocator: make GstVaMemory shareable
Renamed the first variable member of GstVaMemory from parent to mem in
order to avoid confusion with GstMemory's parent.
When freeing the structure, memory's parent is check in order to
decide if surfaces has to be destroyed or not, since only the parent
class have to destroy it.
Removed GST_MEMORY_FLAG_NO_SHARE in memory initialization, since it is
deprecated.
Implemented allocator's share virtual method which creates a new
shallow GstVaMemory structure based on the passed one which will be
it's parent.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1626>
Víctor Manuel Jáquez Leal [Mon, 28 Sep 2020 14:50:16 +0000 (16:50 +0200)]
va: allocator: remove copy method for GstVaMemory
Since the memory has to be shareable. That will be address in the next
commits.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1626>
Víctor Manuel Jáquez Leal [Thu, 24 Sep 2020 15:32:47 +0000 (17:32 +0200)]
va: allocator: remove va allocator mem_is_span() vmethod
Since it is the default by base class.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1626>
Seungha Yang [Wed, 30 Sep 2020 18:47:13 +0000 (03:47 +0900)]
d3d11upload/d3d11download: Make use of staging buffer
... instead of direct cpu map for d3d11memory object. In this way,
we don't need per GstD3D11Memory staging texture.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1627>
Seungha Yang [Sat, 3 Oct 2020 09:53:46 +0000 (18:53 +0900)]
d3d11: Don't hold staging texture
Staging texture is used for memory transfer between system and
gpu memory. Apart from d3d11{upload,download} elements, however,
it should happen very rarely.
Before this commit, d3d11bufferpool was allocating at least one
staging texture in order to calculate cpu accessible memory size,
and it wasn't freed for later use of the texture unconditionally.
But it will increase system memory usage. Although GstD3D11memory
object is implemented so that support CPU access, most memory
transfer will happen in d3d11{upload,download} elements.
By this commit, the initial staging texture will be freed immediately
once cpu accessible memory size is calculated.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1627>
Seungha Yang [Fri, 25 Sep 2020 18:27:39 +0000 (03:27 +0900)]
d3d11: Move to G_DECLARE_FINAL_TYPE
... and remove unnecessary forward declaration.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1627>
Víctor Manuel Jáquez Leal [Sun, 4 Oct 2020 14:33:47 +0000 (16:33 +0200)]
va: caps: centralize caps feature discovering
These function were repeated in the different implemented
elements. This patch centralize them.
The side effect is dmabuf memory type is no longer checked with the
current VAContext, but assuming that dmabuf is a consequence of caps
negotiation from dynamic generated caps templates, where the context's
memory types are validated, there's no need to validate them twice.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1644>
Víctor Manuel Jáquez Leal [Sun, 4 Oct 2020 10:43:35 +0000 (12:43 +0200)]
va: filter: fix counter variable reuse
There was a bug reusing the counter variable i in nested loops. Also
the patch makes the code cleaner.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1643>
Lars Lundqvist [Wed, 2 Oct 2019 09:17:09 +0000 (11:17 +0200)]
curlbasesink: Add curl seek callback
Adding functionality to handle SEEK_SET enables rewinding of sent data.
In the HTTP case, this happens after an HTTP 401 has been received from
the other end. This will result in the sent data being resent.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1616>
Sebastian Dröge [Tue, 29 Sep 2020 12:52:21 +0000 (15:52 +0300)]
decklink: Correctly order the different dependent mode tables
One was forgotten in
309f6187fef890c7ffa49305f38e89beac3b1423.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1617>
Seungha Yang [Fri, 18 Sep 2020 15:26:35 +0000 (00:26 +0900)]
wasapisrc: Make sure that wasapisrc produces data in loopback mode
An oddness of wasapi loopback feature is that capture client will not
produce any data if there's no outputting sound to corresponding
render client. In other words, if there's no sound to render,
capture task will stall. As an option to solve such issue, we can
add timeout to wake up from capture thread if there's no incoming data
within given time interval. But it seems to be glitch prone.
Another approach is that we can keep pushing silence data into
render client so that capture client can keep capturing data
(even if it's just silence).
This patch will choose the latter one because it's more straightforward
way and it's likely produce glitchless sound than former approach.
A bonus point of this approach is that loopback capture on Windows7/8
will work with this patch. Note that there's an OS bug prior to Windows10
when loopback capture client is running with event-driven mode.
To work around the bug, event signalling should be handled manually
for read thread to wake up.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1588>
Matthew Waters [Tue, 29 Sep 2020 13:46:00 +0000 (23:46 +1000)]
wpesrc: fix some caps leaks using the non-GL output
Always chain up to the parent _stop() implementation as it unrefs some
caps (among other things).
Fixes: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1409
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1618>
Hosang Lee [Tue, 16 Jun 2020 02:16:37 +0000 (11:16 +0900)]
smoothstreaming: clear live adapter on seek
In live streaming, buffers sent by souphttpsrc are pushed to the live
adapter. The buffers in the adapter are sent out of mssdemux when it
is greater than 4096 bytes.
Occasionally, when seeking in live streams, if seek occurs just
after the last data chunk was received, and if this data chunk is
smaller than 4096 bytes, it will be kept in the live adapter.
This remaining data in the live adapter will be erroneously prepended
to the new data that is downloaded after seek and pushed out.
When qtdemux receives this data, since it does not start with
a moof box, it is impossible to demux the fragment, and bogus
size error will occur.
Clear out the live adapter on seek so that no unnecessary remaining
data is pushed out together with the new fragment after seeking.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1345>
Víctor Manuel Jáquez Leal [Wed, 30 Sep 2020 08:47:45 +0000 (10:47 +0200)]
va: simplify VPP detection
Also the previous code failed if VPP was not present blacklisting the
plugin.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1619>
Haihao Xiang [Mon, 15 Jun 2020 07:24:07 +0000 (15:24 +0800)]
msdk: call vaExportSurfaceHandle() to get DMABuf FD
Compared to vaAcquireBufferHandle(), vaExportSurfaceHandle() may
provide the handle details, so we needn't call vaDeriveImage().
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1353>
Ederson de Souza [Wed, 1 Jul 2020 16:03:21 +0000 (09:03 -0700)]
tests/avtp: Fix coverity issues
Fixes sign extension issues, unchecked return values and some constant
expression results.
CID:
1465073,
1465074,
1465075,
1465076,
1465077
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1398>
Ederson de Souza [Wed, 8 Jul 2020 16:08:31 +0000 (09:08 -0700)]
avtp: Change "%lu" for G_GUINT64_FORMAT
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1398>
raghavendra [Fri, 25 Sep 2020 16:30:26 +0000 (22:00 +0530)]
srtobject: typecast SRTO_LINGER to linger
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1615>
He Junyan [Wed, 23 Sep 2020 17:24:40 +0000 (01:24 +0800)]
codecparsers: vp8parser: clear the frame_hdr before parsing.
Uninited frame_hdr may have garbage and may contain some wrong
results after the parsing process.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1587>
He Junyan [Sun, 20 Sep 2020 15:29:00 +0000 (23:29 +0800)]
va: Implement the VA vp8 decoder.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1587>
He Junyan [Mon, 21 Sep 2020 15:08:05 +0000 (23:08 +0800)]
va: codestyle: Clear all tabs in header files
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1587>
He Junyan [Mon, 21 Sep 2020 04:51:53 +0000 (12:51 +0800)]
va: util: make the _format_changed a common decoder function.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1587>
Víctor Manuel Jáquez Leal [Thu, 24 Sep 2020 10:36:26 +0000 (12:36 +0200)]
va: h264dec: allocate output buffers according DPB size
Instead of allocating the maximal number of references for output
buffers, this patch reduces the memory foot print in many cases by
just allocating the output buffers required for the DPB.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1595>
Víctor Manuel Jáquez Leal [Thu, 24 Sep 2020 10:29:49 +0000 (12:29 +0200)]
va: decoder: store output buffer rather than surface
GstVaDecodePicture stored the processed VASurfaceID, under the
assumption that the bufferpool with keep the referenced buffers, but
this approach is fragil.
This patch changes GstVaDecodePicture to store the output buffer,
which already contains its VASurfaceID, and provides a new method to
retrieve the VASurfaceID directly from picture.
Based on He Junyan <junyan.he@intel.com> patches for
https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1587
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1594>
Matthew Waters [Wed, 23 Sep 2020 10:08:46 +0000 (20:08 +1000)]
vtdec/vulkan: use Shared storage mode for IOSurface textures
Fixes a debug assertion with i(Pad)OS 14:
'IOSurface textures must use MTLStorageModeShared'
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1592>
Jan Alexander Steffens (heftig) [Wed, 23 Sep 2020 15:04:55 +0000 (17:04 +0200)]
mpegtsmux: Restore intervals when creating TsMux
Otherwise the settings from the properties would be overwritten with
the defaults.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1593>
Víctor Manuel Jáquez Leal [Sat, 19 Sep 2020 12:26:42 +0000 (14:26 +0200)]
va: vpp: global lock to handle shared buffers
Add a global mutex to exclusive access to shared stream buffers, such
as DMABufs or VASurfaces after a tee:
LIBVA_DRIVER_NAME=iHD \
gst-launch-1.0 v4l2src ! tee name=t t. ! queue ! \
vapostproc skin-tone=9 ! xvimagesink \
t. ! queue ! vapostproc ! xvimagesink
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1529>
Víctor Manuel Jáquez Leal [Sun, 16 Aug 2020 07:18:11 +0000 (09:18 +0200)]
va: add vapostproc element
Video postprocessor for VA-API
Funcionalities: resize frames, change format, import buffers, apply
filters (such as denoise, sharpen, orientation, if driver offers them).
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1529>
Víctor Manuel Jáquez Leal [Thu, 20 Aug 2020 11:49:33 +0000 (13:49 +0200)]
va: allocator: export composed layer for YUY2 and UYVY
This is a result of an error reported by i965 driver which only can
export composed layer for these formats. This seems to work too with
iHD. These formats are not exposed as native surfaces in Gallium.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1529>
Víctor Manuel Jáquez Leal [Wed, 19 Aug 2020 14:52:10 +0000 (16:52 +0200)]
va: allocator: add gst_va_dmabuf_buffer_setup()
This function will take an array of DMABuf GstMemory and an array of
fd, and create a VASurfaceID with those fds. Later that VASurfaceID is
attached to each DMABuf through GstVaBufferSurface.
In order to free the surface GstVaBufferSurface now have GstVaDisplay
member, and _buffer_surface_unref() were added.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1529>
Víctor Manuel Jáquez Leal [Wed, 19 Aug 2020 14:48:39 +0000 (16:48 +0200)]
va: allocator: try to get VASurfaceID from every DMABuf allocator
Relax the check of the allocator type, because now the qdata can be
attached for other DMABuf allocators.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1529>
Víctor Manuel Jáquez Leal [Sat, 12 Sep 2020 11:10:18 +0000 (13:10 +0200)]
va: allocator: try to create surface without fourcc but chroma only
There are, in VPP, surfaces that doesn't support 4:2:2 fourccs but it
supports the chroma. So this patch gives that opportunity to the
driver.
This patch also simplifiies
gst_va_video_surface_format_from_image_format() to just an iterator
for surfaces available formats.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1529>
Víctor Manuel Jáquez Leal [Wed, 19 Aug 2020 14:45:49 +0000 (16:45 +0200)]
va: allocator: create surfaces with VASurfaceAttribExternalBuffers
Add a new parameter to _create_surfaces(): a pointer to
VASurfaceAttribExternalBuffers.
If it's defined the memory type is changed to DRM_PRIME, also a new item is
added to the VASurfaceAttrib array with
VASurfaceAttribExternalBufferDescriptor.
Also, the VASurfaceAttrib for pixel format is not mandatory anymore. If fourcc
parameter is 0, is not added in the array, relying on the chroma. This is
useful when creating surfaces for uploading or downloading images.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1529>
Víctor Manuel Jáquez Leal [Thu, 20 Aug 2020 11:46:12 +0000 (13:46 +0200)]
va: pool: use gst_object_replace() for allocator
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1529>
Víctor Manuel Jáquez Leal [Wed, 16 Sep 2020 17:14:30 +0000 (19:14 +0200)]
va: device: use gst_clear_object()
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1529>
Víctor Manuel Jáquez Leal [Tue, 18 Aug 2020 17:12:46 +0000 (19:12 +0200)]
va: caps: expose gst_caps_set_format_array()
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1529>
Víctor Manuel Jáquez Leal [Tue, 22 Sep 2020 17:59:41 +0000 (19:59 +0200)]
va: vah264dec: fix documentation
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1591>
Víctor Manuel Jáquez Leal [Wed, 23 Sep 2020 08:58:43 +0000 (10:58 +0200)]
codecs: h264: unref leaked caps
Unref a leaked caps at set_latency().
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1590>
Haihao Xiang [Mon, 20 Jul 2020 02:13:13 +0000 (10:13 +0800)]
msdk: add support for AV1 decoding
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1448>
Víctor Manuel Jáquez Leal [Sat, 19 Sep 2020 19:43:24 +0000 (21:43 +0200)]
va: utils: use GstObject for GstVaDisplay in context
Thus application could fetch the GstVaDisplay through the sync bus
without knowning the specific implementation, and sharing it or
extract properties.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1586>
Víctor Manuel Jáquez Leal [Sat, 19 Sep 2020 19:36:58 +0000 (21:36 +0200)]
va: utils: fix code style and wrong log message
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1586>
Philippe Normand [Mon, 14 Sep 2020 08:48:48 +0000 (09:48 +0100)]
wpe: Plug event leak
Handled events don't go through the default pad event handler, so they need to
be unreffed in this case.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1568>
Jan Schmidt [Mon, 24 Aug 2020 15:57:55 +0000 (01:57 +1000)]
wpesrc: Don't crash if WPE doesn't generate a buffer.
On creating a 2nd wpesrc in a new pipeline in an app that already
has a runnig wpesrc, WPE sometimes doesn't return a buffer on request,
leading to a crash. This commit fixes the crash, but not the underlying
failure - a 2nd wpesrc can still error out instead.
Partially fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1386
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1568>
Philippe Normand [Fri, 11 Sep 2020 11:51:56 +0000 (12:51 +0100)]
wpe: Plug SHM buffer leaks
Fixes #1409
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1568>
Philippe Normand [Thu, 10 Sep 2020 13:39:58 +0000 (14:39 +0100)]
wpe: Move webview load waiting to WPEView
As waiting for the load to be finished is specific to the WebView, it should be
done from our WPEView, not from the WPEContextThread. This fixes issues where
multiple wpesrc elements are created in sequence. Without this patch the first
view might receive erroneous buffer notifications.
Fixes #1386
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1568>
Sanchayan Maity [Fri, 11 Sep 2020 12:47:20 +0000 (18:17 +0530)]
audiobuffersplit: Add support for specifying output buffer size
Currently for buffer splitting only output duration can be specified.
Allow specifying a buffer size in bytes for splitting.
Consider a use case of the below pipeline
appsrc ! rptL16pay ! capsfilter ! rtpbin ! udpsink
Maintaining MTU for RTP transfer is desirable but in a scenario
where the buffers being pushed to appsrc do not adhere to this,
an audiobuffersplit element placed between appsrc and rtpL16pay
with output buffer size specified considering the MTU can help
mitigate this.
While rtpL16pay already has a MTU setting, in case of where an
incoming buffer has a size close to MTU, for eg. with a MTU of
1280, a buffer of size 1276 bytes would be split into two buffers,
one of 1268 and other of 8 bytes considering RTP header size of
12 bytes. Putting audiobuffersplit between appsrc and rtpL16pay
can take care of this.
While buffer duration could still be used being able to specify
the size in bytes is helpful here.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1578>
Philippe Normand [Thu, 10 Sep 2020 12:05:23 +0000 (13:05 +0100)]
wpe: Use proper callback for TLS errors signal handling
The load-failed and load-failed-with-tls-errors signals expect distinct callback
signatures.
Fixes #1388
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1566>
Víctor Manuel Jáquez Leal [Sun, 20 Sep 2020 06:31:23 +0000 (08:31 +0200)]
va: h264dec: add documentation
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1585>
Haihao Xiang [Tue, 10 Dec 2019 11:54:43 +0000 (19:54 +0800)]
msdk: enable GPUCopy
Note it works for system memory only
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/910>
Haihao Xiang [Tue, 10 Dec 2019 11:47:03 +0000 (19:47 +0800)]
msdk: call MFXInitEx instead of MFXInit
MFXInitEx has more control than MFXInit. The current setting in this
commit is identical to MFXInit
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/910>
Víctor Manuel Jáquez Leal [Sat, 19 Sep 2020 12:08:46 +0000 (14:08 +0200)]
va: decoder: render picture only if data
Call vaRenderPicture() only if buffer or slice data is available.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1584>
Víctor Manuel Jáquez Leal [Thu, 17 Sep 2020 17:54:28 +0000 (19:54 +0200)]
va: decoder: warn if decode fails on a surface
Instead of logging error if a step fails, it logs a warning message
reducing the noise and obeying the rule for errors since the program
doesn't end
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1584>
Víctor Manuel Jáquez Leal [Thu, 17 Sep 2020 17:52:29 +0000 (19:52 +0200)]
va: h264dec: check is pad has fixed caps at caps query
Otherwise it will always reply with the possible driver caps, which
generates problems with Web MSE players.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1583>
Seungha Yang [Fri, 18 Sep 2020 20:39:32 +0000 (05:39 +0900)]
va: h264dec: Don't need to set pts/dts/duration on outputting frame
It will be handled by videodecoder baseclass
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1582>
Olivier Crête [Thu, 26 Mar 2020 00:50:01 +0000 (20:50 -0400)]
webrtcbin: Accept end-of-candidate pass it to libnice
libnice now supports the concept of end-of-candidate, so use the API
for it. This also means that if you don't do that, the webrtcbin will
never declared the connection as failed.
This requires bumping the dependency to libnice 0.1.16
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1139>
Nicolas Dufresne [Thu, 17 Sep 2020 21:39:25 +0000 (17:39 -0400)]
kmssink: Do not source using padded width/height
The width/height from the video meta can be padded width, height. But when
sourcing from padded buffer, we only want to use the valid pixels. This
rectangle is from the crop meta, orther it is deduces from the caps. The width
and height from the caps is save in the parent class, use these instead of the
GstVideoInfo when settting the src rectangle.
This fixes an issue with 1080p video displaying repeated or green at the
padded bottom 8 lines (seen with v4l2codecs).
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1580>
Seungha Yang [Thu, 17 Sep 2020 16:41:35 +0000 (01:41 +0900)]
d3d11: Add support for packed 8bits 4:2:2 YUV formats
Note that newly added formats (YUY2, UYVY, and VYUY) are not supported
render target view formats. So such formats can be only input of d3d11convert
or d3d11videosink. Another note is that YUY2 format is a very common
format for hardware en/decoders on Windows.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1581>
Olivier Crête [Wed, 26 Aug 2020 21:48:06 +0000 (17:48 -0400)]
webrtcbin: Merge the RTX SSRCs from all transceivers when bundling
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1545>
Marian Cichy [Tue, 15 Sep 2020 15:09:57 +0000 (17:09 +0200)]
avtp: avtpaafdepay: fix crash when building caps
gst_caps_new_simple gets wrong types for rate and channel which
may lead to a crash.
As 64-bit values for rate, depth, format, channels does not
make much sense and since any other functionality in gstreamer
expects G_TYPE_INT for channels and rate, we should stick to that
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1576>
Haihao Xiang [Tue, 9 Jun 2020 02:10:12 +0000 (10:10 +0800)]
h265parse: recognize more HEVC extension streams
There are streams which have the right general_profile_idc and
general_profile_compatibility_flag, but don't have the right extension
flags. We may try to use chroma_format_idc and bit_depth to
recognize these streams.
e.g.
https://www.itu.int/wftp3/av-arch/jctvc-site/bitstream_exchange/draft_conformance/SCC/IBF_Disabled_A_MediaTek_2.zip
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1328>
Haihao Xiang [Fri, 5 Jun 2020 05:01:06 +0000 (13:01 +0800)]
h265parser: select the right profile for high throughput SCC stream
Currently screen-extended-high-throughput-444 is recognized as
screen-extended-main-444, screen-extended-high-throughput-444-10 is
recognized as screen-extended-main-444-10 because they have the same
extension flags, so without this patch, it is possible that a decoder
which supports SCC but doesn't support throughput SCC will try to decode
a throughput SCC stream.
e.g.
https://www.itu.int/wftp3/av-arch/jctvc-site/bitstream_exchange/draft_conformance/SCC/HT_A_SCC_Apple_2.zip
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1328>
Randy Li (ayaka) [Tue, 8 Sep 2020 06:43:49 +0000 (14:43 +0800)]
msdk: vpp: fixup passthrough checking for DMA
I think it is just a typo from
e1a90f1ec9
msdkvpp: Disable passthrough if memory capsfeature changes
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1559>
Emmanuel Gil Peyrot [Tue, 15 Sep 2020 15:51:51 +0000 (17:51 +0200)]
waylandsink: Use memfd_create() when available
This (so-far) Linux- and FreeBSD-only API lets users create file
descriptors purely in memory, without any backing file on the filesystem
and the race condition which could ensue when unlink()ing it.
It also allows seals to be placed on the file, ensuring to every other
process that we won’t be allowed to shrink the contents, potentially
causing a SIGBUS when they try reading it.
This patch is best viewed with the -w option of git log -p.
It is an almost exact copy of Wayland commit
6908c8c85a2e33e5654f64a55cd4f847bf385cae, see
https://gitlab.freedesktop.org/wayland/wayland/merge_requests/4
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1577>
Seungha Yang [Thu, 10 Sep 2020 12:19:43 +0000 (21:19 +0900)]
codecs: vp9decoder: Relying on upstream vp9parse for super frame handling
By this way, we can simplify the decoding flow. Moreover, we don't
need to worry about the case where multiple visible-frames are
composed in one super-frame, since upstream vp9parse will split
them per frame unit.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1567>
Seungha Yang [Thu, 10 Sep 2020 12:42:49 +0000 (21:42 +0900)]
codecs: vp9decoder: Remove unused pts variable
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1567>