Martin Storsjö [Thu, 2 Jun 2022 09:57:51 +0000 (12:57 +0300)]
[ARM] Fix a test case typo. NFC.
The test looked for the wrong string, but it happened to match as
it was a substring of the actual output.
This fixes a typo from
d8e67c1cccd8fcb62230166caea744592288da17.
Nikita Popov [Thu, 2 Jun 2022 08:53:32 +0000 (10:53 +0200)]
[llvm-ocaml] Add and use opaque pointer compatible bindings
Add bindings for LLVMConstGEP2, LLVMAddAlias2, LLVMBuildLoad2,
LLVMBuildInvoke2, LLVMBuildGEP2, LLVMBuildInBoundsGEP2,
LLVMBuildStructGEP2, LLVMBuildPtrDiff2 and use these in tests.
Gabor Marton [Tue, 31 May 2022 15:49:52 +0000 (17:49 +0200)]
[analyzer][NFC] Move overconstrained check from reAssume to assumeDualImpl
Depends on D126406. Checking of the overconstrained property is much
better suited here.
Differential Revision: https://reviews.llvm.org/D126707
Martin Storsjö [Thu, 19 May 2022 10:17:24 +0000 (13:17 +0300)]
[clang] [ARM] Add __builtin_sponentry like on aarch64
This is used for calling the SEH aware setjmp on MinGW.
Differential Revision: https://reviews.llvm.org/D126764
Martin Storsjö [Thu, 19 May 2022 10:16:53 +0000 (13:16 +0300)]
[ARM] Implement lowering of the sponentry intrinsic
This is needed for SEH based setjmp on Windows.
Differential Revision: https://reviews.llvm.org/D126763
Martin Storsjö [Fri, 26 Nov 2021 13:17:47 +0000 (15:17 +0200)]
[ARM] Adjust the frame pointer when it's needed for SEH unwinding
For functions that require restoring SP from FP (e.g. that need to
align the stack, or that have variable sized allocations), the prologue
and epilogue previously used to look like this:
push {r4-r5, r11, lr}
add r11, sp, #8
...
sub r4, r11, #8
mov sp, r4
pop {r4-r5, r11, pc}
This is problematic, because this unwinding operation (restoring sp
from r11 - offset) can't be expressed with the SEH unwind opcodes
(probably because this unwind procedure doesn't map exactly to
individual instructions; note the detour via r4 in the epilogue too).
To make unwinding work, the GPR push is split into two; the first one
pushing all other registers, and the second one pushing r11+lr, so that
r11 can be set pointing at this spot on the stack:
push {r4-r5}
push {r11, lr}
mov r11, sp
...
mov sp, r11
pop {r11, lr}
pop {r4-r5}
bx lr
For the same setup, MSVC generates code that uses two registers;
r11 still pointing at the {r11,lr} pair, but a separate register
used for restoring the stack at the end:
push {r4-r5, r7, r11, lr}
add r11, sp, #12
mov r7, sp
...
mov sp, r7
pop {r4-r5, r7, r11, pc}
For cases with clobbered float/vector registers, they are pushed
after the GPRs, before the {r11,lr} pair.
Differential Revision: https://reviews.llvm.org/D125649
Martin Storsjö [Fri, 26 Nov 2021 12:28:16 +0000 (14:28 +0200)]
[ARM] Add SEH opcodes in frame lowering
Skip inserting regular CFI instructions if using WinCFI.
This is based a fair amount on the corresponding ARM64 implementation,
but instead of trying to insert the SEH opcodes one by one where
we generate other prolog/epilog instructions, we try to walk over the
whole prolog/epilog range and insert them. This is done because in
many cases, the exact number of instructions inserted is abstracted
away deeper.
For some cases, we manually insert specific SEH opcodes directly where
instructions are generated, where the automatic mapping of instructions
to SEH opcodes doesn't hold up (e.g. for __chkstk stack probes).
Skip Thumb2SizeReduction for SEH prologs/epilogs, and force
tail calls to wide instructions (just like on MachO), to make sure
that the unwind info actually matches the width of the final
instructions, without heuristics about what later passes will do.
Mark SEH instructions as scheduling boundaries, to make sure that they
aren't reordered away from the instruction they describe by
PostRAScheduler.
Mark the SEH instructions with the NoMerge flag, to avoid doing
tail merging of functions that have multiple epilogs that all end
with the same sequence of "b <other>; .seh_nop_w, .seh_endepilogue".
Differential Revision: https://reviews.llvm.org/D125648
jacquesguan [Thu, 2 Jun 2022 03:00:02 +0000 (03:00 +0000)]
[LegalizeTypes][VP] Add widen and split support for VP FP integer casting op.
This patch adds widen and split support for VP_FPTOSI, VP_FPTOUI, VP_SITOFP and VP_UITOFP.
Differential Revision: https://reviews.llvm.org/D126847
lewuathe [Thu, 2 Jun 2022 08:38:20 +0000 (10:38 +0200)]
[mlir][complex] Lower complex.sin/cos to libm
Lower sin/cos operation in complex dialect to libm as a baseline. This follows up to https://reviews.llvm.org/D125550.
Reviewed By: pifon2a
Differential Revision: https://reviews.llvm.org/D126755
Nikita Popov [Thu, 2 Jun 2022 08:22:59 +0000 (10:22 +0200)]
[llvm-ocaml] Add LLVMBuildCall2 binding
Add binding for the opaque pointer compatible LLVMBuildCall2
API and use it in tests.
lewuathe [Thu, 2 Jun 2022 08:33:13 +0000 (10:33 +0200)]
[mlir][complex] Sanity check for tan operation in complex dialect
Add a sanity check for newly added tan operation in complex dialect. It follows-up to https://reviews.llvm.org/D126685.
Differential Revision: https://reviews.llvm.org/D126858
owenca [Wed, 1 Jun 2022 08:06:02 +0000 (01:06 -0700)]
[clang-format] Handle do-while loops for RemoveBracesLLVM
Also updates the unit tests to match the updated LLVM Coding
Standards.
Differential Revision: https://reviews.llvm.org/D126758
Stanislav Gatev [Thu, 24 Feb 2022 17:07:41 +0000 (17:07 +0000)]
[clang][dataflow] Add transfer functions for structured bindings
This is part of the implementation of the dataflow analysis framework.
See "[RFC] A dataflow analysis framework for Clang AST" on cfe-dev.
Differential Revision: https://reviews.llvm.org/D120495
Reviewed-by: ymandel, xazax.hun
Benjamin Kramer [Thu, 2 Jun 2022 07:56:11 +0000 (09:56 +0200)]
[IRTests] With opaque ptrs we can test that there is no bitcast inserted
Nikita Popov [Tue, 31 May 2022 09:58:35 +0000 (11:58 +0200)]
[IR] Enable opaque pointers by default
This enabled opaque pointers by default in LLVM. The effect of this
is twofold:
* If IR that contains *neither* explicit ptr nor %T* types is passed
to tools, we will now use opaque pointer mode, unless
-opaque-pointers=0 has been explicitly passed.
* Users of LLVM as a library will now default to opaque pointers.
It is possible to opt-out by calling setOpaquePointers(false) on
LLVMContext.
A cmake option to toggle this default will not be provided. Frontends
or other tools that want to (temporarily) keep using typed pointers
should disable opaque pointers via LLVMContext.
Differential Revision: https://reviews.llvm.org/D126689
Amir Ayupov [Thu, 2 Jun 2022 07:26:23 +0000 (00:26 -0700)]
[BOLT][NFC] Use colors in CFG dumps
Use color coding to distinguish nodes:
- Entry nodes have bold border
- Scalar (non-loopy) code is milk white
- Outer loops are light yellow
- Innermost loops are light blue
`-print-loops` needs to be enabled to provide BinaryLoopInfo.
Examples:
{
F23170673}
{
F23170680}
Reviewed By: rafauler
Differential Revision: https://reviews.llvm.org/D126248
Venkata Ramanaiah Nalamothu [Thu, 2 Jun 2022 06:32:44 +0000 (12:02 +0530)]
[lldb, test] Fix typos in the lldb tests
Reviewed By: JDevlieghere
Differential Revision: https://reviews.llvm.org/D126596
Weining Lu [Thu, 2 Jun 2022 06:57:23 +0000 (14:57 +0800)]
[LoongArch] Add the missing ld.d instruction definition
Amir Ayupov [Thu, 2 Jun 2022 06:40:55 +0000 (23:40 -0700)]
[BOLT][NFC] Print block instructions in dumpGraph as part of node label
Reuse the option `-dot-tooltip-code` to put block instructions into the label.
This way, the instructions are displayed by default when used with dot viewer.
When the .dot file is used with dot2html, instructions are hidden by default,
and are shown by clicking on a node.
{
F23169510}
Reviewed By: rafauler
Differential Revision: https://reviews.llvm.org/D126237
Amir Ayupov [Thu, 2 Jun 2022 06:37:04 +0000 (23:37 -0700)]
[BOLT][UTILS] Add dot2html helper tool to embed dot into html
To be rendered in browser using d3-graphviz.
Example: {
F23169510}
Reviewed By: rafauler
Differential Revision: https://reviews.llvm.org/D126218
jacquesguan [Fri, 20 May 2022 07:31:07 +0000 (07:31 +0000)]
[mlir][Arithmetic] Add constant folder for RemF.
This patch adds the constant folder for RemF.
Differential Revision: https://reviews.llvm.org/D126045
Weining Lu [Thu, 2 Jun 2022 06:18:08 +0000 (14:18 +0800)]
[LoongArch] Fix register type in FCMP_*_D instructions definition
The correct type is FPR64 but not FPR32.
Tobias Hieta [Thu, 2 Jun 2022 06:20:21 +0000 (08:20 +0200)]
[NFC][workflow] Fix issue where the workflow would say all PR's already exists
LLVM GN Syncbot [Thu, 2 Jun 2022 06:04:25 +0000 (06:04 +0000)]
[gn build] Port
a15ae4139cea
Mark de Wever [Thu, 2 Jun 2022 06:02:19 +0000 (08:02 +0200)]
[libc++][doc] Fixes unwanted list nesting.
Mark de Wever [Mon, 16 May 2022 15:12:18 +0000 (17:12 +0200)]
[libc++] Make to_chars base 10 header only.
The functions to_chars and from_chars should offer 128-bit support. This
is the first step to implement 128-bit version of to_chars. Before
implementing 128-bit support the current code will be polished.
This moves the code from the dylib to the header in prepartion of
P2291 "Add Constexpr Modifiers to Functions to_chars and from_chars for
Integral Types in <charconv> Header"
Note some more cleanups will be done in follow-up commits
- Remove the _LIBCPP_AVAILABILITY_TO_CHARS from to_chars. With all code
in the header the availablilty macro is no longer needed. This
requires enabling the unit tests for additional platforms.
- The code in the dylib can switch to using the header implementation.
This allows removing the code duplicated in the header and the dylib.
Reviewed By: #libc, ldionne
Differential Revision: https://reviews.llvm.org/D125704
Richard [Sat, 14 May 2022 23:57:10 +0000 (17:57 -0600)]
[clang-tidy] Reject invalid enum initializers in C files
C requires that enum values fit into an int. Scan the macro tokens
present in an initializing expression and reject macros that contain
tokens that have suffixes making them larger than int.
C forbids the comma operator in enum initializing expressions, so
optionally reject comma operator.
Differential Revision: https://reviews.llvm.org/D125622
Fixes #55467
eopXD [Thu, 2 Jun 2022 03:39:38 +0000 (20:39 -0700)]
[LSR] Early exit for RateFormula when it is already losing. NFC
This patch does not effect any behavior of the current code.
The codebase implicitly implies that `Cost::RateFormula` is only called
when the `Cost` is not in losing status, or else there may be possible
to trigger the assertion of `Cost::isValid`.
The intention here is to prevent mis-use where future development
allow `Cost` that is already loser to call `Cost::RateFormula` - Early
exit when `Cost` is already losing.
Reviewed By: Meinersbur, #loopoptwg
Differential Revision: https://reviews.llvm.org/D125670
jacquesguan [Wed, 1 Jun 2022 06:29:09 +0000 (06:29 +0000)]
[mlir] Support convert token type from LLVM IR.
This patch supports the token type for converting from LLVM IR.
Differential Revision: https://reviews.llvm.org/D126756
Fangrui Song [Thu, 2 Jun 2022 03:05:01 +0000 (20:05 -0700)]
[test] Fix LLVMgold.so tests after D125847
Florian Mayer [Wed, 1 Jun 2022 23:43:59 +0000 (16:43 -0700)]
[libunwind] Add more information to eh_frame_hdr version error
This makes it easier to find the offending ELF file.
Reviewed By: #libunwind, MaskRay
Differential Revision: https://reviews.llvm.org/D126841
Nico Weber [Thu, 2 Jun 2022 02:33:36 +0000 (22:33 -0400)]
unbreak Modules/cxx20-export-import.cpp with LLVM_APPEND_VC_REV after
8c8a2679a20f
See revision
b8b7a9dcdcbc for prior art.
Snehasish Kumar [Wed, 1 Jun 2022 22:20:53 +0000 (22:20 +0000)]
[memprof] Print out the segment information in YAML format.
This change prints out the segment information in the raw profile in
YAML format for testing. Since we don't capture build ids yet, we print
out <None> for now.
Reviewed By: tejohnson
Differential Revision: https://reviews.llvm.org/D126840
jacquesguan [Thu, 26 May 2022 03:14:27 +0000 (03:14 +0000)]
[LegalizeTypes][VP] Add widen and split support for VP_SIGN_EXTEND and VP_ZERO_EXTEND.
Differential Revision: https://reviews.llvm.org/D126442
Snehasish Kumar [Wed, 1 Jun 2022 22:20:53 +0000 (22:20 +0000)]
[memprof] Update summary output.
Update the YAML format print out of the profile to include a summary
instead of displaying the headers in the raw file buffer. This allows us
to release the raw buffer early saving memory.
Reviewed By: tejohnson
Differential Revision: https://reviews.llvm.org/D126834
Matthias Braun [Thu, 2 Jun 2022 01:51:35 +0000 (18:51 -0700)]
Fix compilation in gold-plugin triggered by D125847
Siva Chandra Reddy [Wed, 25 May 2022 21:07:23 +0000 (21:07 +0000)]
[libc] Add pthread_create and pthread_join functions.
They do not yet support all the feature/attributes in pthread_attr_t.
Future changes will add such support.
Reviewed By: lntue
Differential Revision: https://reviews.llvm.org/D126718
Joe Loser [Tue, 31 May 2022 00:21:56 +0000 (18:21 -0600)]
[libc++][test] Enable constexpr string comparison tests
Some tests in `string.view.comparison` are not enabled due to previous lack of
support for `constexpr std::string`. Now that it is implemented, we can enable
these tests.
Differential Revision: https://reviews.llvm.org/D126737
Chris Bieneman [Thu, 2 Jun 2022 01:18:41 +0000 (20:18 -0500)]
Fix DXContainer test on ppcbe
Silly mistake, the code here was byteswapping in-place which corrupts
the data structure that is used later to write the correct file.
Alexander Yermolovich [Thu, 2 Jun 2022 01:15:41 +0000 (18:15 -0700)]
[BOLT][DWARF] Fix TU Index handling for DWARF4/5
When we generate split dwarf with -fdebug-types-section we will have
.debug_types.dwo sections. These go into TU Index when we run llvm-dwp. BOLT was
not handling DWP input correctly with this section.
Added support for handling DWP with TU Index as an input and output for DWARF4.
Added support for handling DWP with TU Index as an input for DWARF5
Reviewed By: maksfb
Differential Revision: https://reviews.llvm.org/D126087
Matt Arsenault [Fri, 22 Apr 2022 23:15:58 +0000 (19:15 -0400)]
BranchFolder: Require NoPHIs
The pass doesn't handle SSA and breaks any phis.
Matt Arsenault [Wed, 4 May 2022 12:12:51 +0000 (13:12 +0100)]
AMDGPU: Add release notes about atomic load and store
Matt Arsenault [Wed, 18 May 2022 15:00:41 +0000 (16:00 +0100)]
AMDGPU: Fix missing c++ mode comment
Matthias Braun [Wed, 18 May 2022 03:33:22 +0000 (20:33 -0700)]
LTO: Decide upfront whether to use opaque/non-opaque pointer types
LTO code may end up mixing bitcode files from various sources varying in
their use of opaque pointer types. The current strategy to decide
between opaque / typed pointers upon the first bitcode file loaded does
not work here, since we could be loading a non-opaque bitcode file first
and would then be unable to load any files with opaque pointer types
later.
So for LTO this:
- Adds an `lto::Config::OpaquePointer` option and enforces an upfront
decision between the two modes.
- Adds `-opaque-pointers`/`-no-opaque-pointers` options to the gold
plugin; disabled by default.
- `--opaque-pointers`/`--no-opaque-pointers` options with
`-plugin-opt=-opaque-pointers`/`-plugin-opt=-no-opaque-pointers`
aliases to lld; disabled by default.
- Adds an `-lto-opaque-pointers` option to the `llvm-lto2` tool.
- Changes the clang driver to pass `-plugin-opt=-opaque-pointers` to
the linker in LTO modes when clang was configured with opaque
pointers enabled by default.
This fixes https://github.com/llvm/llvm-project/issues/55377
Differential Revision: https://reviews.llvm.org/D125847
Hendrik Greving [Thu, 2 Jun 2022 00:46:50 +0000 (00:46 +0000)]
[ValueTypes] Define MVTs for v128i2/v64i4 as well as i2 and i4.
Adds MVT::v128i2, MVT::v64i4, and implied MVT::i2, MVT::i4.
Keeps MVT::i2, MVT::i4 lowering actions as expand, which should be
removed once targets set this explicitly.
Adjusts 11 lit tests to reflect slightly different behavior during
DAG combine.
Differential Revision: https://reviews.llvm.org/D125247
Fangrui Song [Thu, 2 Jun 2022 00:33:14 +0000 (17:33 -0700)]
[Polly] Fix -Wreorder-ctor. NFC
Quentin Colombet [Thu, 2 Jun 2022 00:14:03 +0000 (17:14 -0700)]
[RegisterClassInfo] Invalidate cached information if ignoreCSRForAllocationOrder changes
Even if CSR list is same between functions, we could have had a different
allocation order if ignoreCSRForAllocationOrder is evaluated differently.
Hence invalidate cached register class information if
ignoreCSRForAllocationOrder changes.
Patch by Srividya Karumuri <srividya_karumuri@apple.com>
Differential Revision: https://reviews.llvm.org/D126565
Fangrui Song [Thu, 2 Jun 2022 00:04:58 +0000 (17:04 -0700)]
[Object] Fix namespace style issues in D122069
https://llvm.org/docs/CodingStandards.html#use-namespace-qualifiers-to-implement-previously-declared-functions
Shilei Tian [Wed, 1 Jun 2022 23:53:36 +0000 (19:53 -0400)]
[OMPIRBuilder] Add the support for compare capture
This patch adds the support for `compare capture` in `OMPIRBuilder`.
Reviewed By: jdoerfert
Differential Revision: https://reviews.llvm.org/D120007
Philip Reames [Wed, 1 Jun 2022 23:08:19 +0000 (16:08 -0700)]
[RISCV] Split fixed-vector-strided-load-store.ll so it can be autogened
I've gotten tired of updating register allocation changes by hand, let's just autogen this even if we have to duplicate it.
Alexey Bataev [Wed, 1 Jun 2022 22:40:00 +0000 (15:40 -0700)]
Revert "[SLP]Improve shuffles cost estimation where possible."
This reverts commit
fd5a6ce9dcb77b7821c95355d73af0b3b2020647 to fix
a crash detected by a buildbot
https://lab.llvm.org/buildbot/#/builders/179/builds/3805/steps/11/logs/stdio.
Joseph Huber [Wed, 1 Jun 2022 19:28:34 +0000 (15:28 -0400)]
[Binary] Promote OffloadBinary to inherit from Binary
We use the `OffloadBinary` to create binary images of offloading files
and their corresonding metadata. This patch changes this to inherit from
the base `Binary` class. This allows us to create and insepect these
more generically. This patch includes all the necessary glue to
implement this as a new binary format, along with added the magic bytes
we use to distinguish the offloading binary to the `file_magic`
implementation.
Reviewed By: tra
Differential Revision: https://reviews.llvm.org/D126812
Craig Topper [Wed, 1 Jun 2022 22:37:48 +0000 (15:37 -0700)]
[RISCV] Use MachineRegisterInfo::use_instr_begin instead of use_begin+getParent. NFCI
David Tenty [Tue, 10 May 2022 15:39:58 +0000 (11:39 -0400)]
[clang][AIX] add option mdefault-visibility-export-mapping
The option mdefault-visibility-export-mapping is created to allow
mapping default visibility to an explicit shared library export
(e.g. dllexport). Exactly how and if this is manifested is target
dependent (since it depends on how they map dllexport in the IR).
Three values are provided for the option:
* none: the default and behavior without the option, no additional export linkage information is created.
* explicit: add the export for entities with explict default visibility from the source, including RTTI
* all: add the export for all entities with default visibility
This option is useful for targets which do not export symbols as part of
their usual default linkage behaviour (e.g. AIX), such targets
traditionally specified such information in external files (e.g. export
lists), but this mapping allows them to use the visibility information
typically used for this purpose on other (e.g. ELF) platforms.
Reviewed By: MaskRay
Differential Revision: https://reviews.llvm.org/D126340
Matthias Springer [Wed, 1 Jun 2022 21:59:58 +0000 (23:59 +0200)]
[mlir][sparse][NFC] Switch InitOp to bufferization::AllocTensorOp
Now that we have an AllocTensorOp (previously InitTensorOp) in the bufferization dialect, the InitOp in the sparse dialect is no longer needed.
Differential Revision: https://reviews.llvm.org/D126180
Chris Bieneman [Wed, 1 Jun 2022 21:45:49 +0000 (16:45 -0500)]
Temporarily disabling this test on arm
This is failing on an arm32 builder, and it is going to take me a while
to debug. To not block further progress I'm disabling this test on
arm32 configuraitons.
wren romano [Tue, 31 May 2022 22:26:52 +0000 (15:26 -0700)]
[mlir][sparse] Using non-empty function name suffix for OverheadType::kIndex
The trick of using an empty token in the `FOREVERY_O` x-macro relies on preprocessor behavior which is only standard since C99 6.10.3/4 and C++11 N3290 16.3/4 (whereas it was undefined behavior up through C++03 16.3/10). Since the `ExecutionEngine/SparseTensorUtils.cpp` file is required to be compile-able under C++98 compatibility mode (unlike the C++11 used elsewhere in MLIR), we shouldn't rely on that behavior.
Also, using a non-empty suffix helps improve uniformity of the API, since all other primary/overhead suffixes are also non-empty. I'm using the suffix `0` since that's the value used by the `SparseTensorEncoding` attribute for indicating the index overhead-type.
Depends On D126720
Reviewed By: aartbik
Differential Revision: https://reviews.llvm.org/D126724
Florian Hahn [Wed, 1 Jun 2022 21:11:06 +0000 (22:11 +0100)]
[LV] Update var name to Exiting, in line with terminology (NFC)
Recently the terminology used has been changed from Exit->Exiting in
line with common LLVM loop terminology. Update a remaining use of the
old terminology.
Huan Nguyen [Wed, 1 Jun 2022 20:59:28 +0000 (13:59 -0700)]
[BOLT][TEST] Replace cache+ option with ext-tsp
Replace "cache+" with "ext-tsp" in all BOLT tests
Test Plan:
```
ninja check-bolt
grep -rnw . -e "cache+"
```
no more tests containing "cache+"
"cache+" and "ext-tsp" are aliases
Reviewed By: rafauler
Differential Revision: https://reviews.llvm.org/D126714
Nicolai Hähnle [Tue, 24 May 2022 23:57:14 +0000 (01:57 +0200)]
update_mir_test_checks: Better handling of common prefixes
Support the pattern where a test file uses multiple prefixes per run line:
one prefix that is unique to the run line, and additional prefixes that are
common with other run lines.
Decide on a per-function basis which prefix(es) to emit, based on which run
lines have the same output.
Move the renaming of vregs earlier, so that we can compare the output as it
would actually be printed in check lines.
Differential Revision: https://reviews.llvm.org/D126411
Benjamin Kramer [Wed, 1 Jun 2022 20:49:34 +0000 (22:49 +0200)]
[bazel] Add a missing dependency after
f3bdb56d61e3
Chris Bieneman [Wed, 1 Jun 2022 20:50:20 +0000 (15:50 -0500)]
Temporarily disabling this test on arm
This is failing on an arm32 builder, and it is going to take me a while
to debug. To not block further progress I'm disabling this test on
arm32 configuraitons.
Peter Klausler [Wed, 1 Jun 2022 18:05:55 +0000 (11:05 -0700)]
[flang][NFC] Document intentional non-support for an extension
F18 doesn't accept INTEGER operands to the intrinsic LOGICAL operations;
some compilers do. This usage is not portable, and not just because it's
non-conforming -- the bit representations of LOGICAL also vary between
compilers and options. The "MIL-STD" bit intrinsics IAND() & al. have been
avaiable since the late 70's and should be used instead.
Differential Revision: https://reviews.llvm.org/D126798
Maksim Panchenko [Wed, 1 Jun 2022 19:29:34 +0000 (12:29 -0700)]
[BOLT][NFC] Remove unused variable
Reviewed By: Amir
Differential Revision: https://reviews.llvm.org/D126808
LLVM GN Syncbot [Wed, 1 Jun 2022 20:34:21 +0000 (20:34 +0000)]
[gn build] Port
129c056d6269
Chris Bieneman [Wed, 1 Jun 2022 14:10:28 +0000 (09:10 -0500)]
[ObjectYAML][DX] Support yaml2dxcontainer
This patch adds a the first bits of support for a yaml representation
of dxcontainer files.
Since the YAML representation's primary purpose is testing
infrastructure, the yaml representation supports both verbose and a
more friendly format by making computable sizes and offsets optional.
If provided they are validated to be correct, otherwise they are
computed on the fly during emission.
As I expand the format I'll be able to make more size fields optional,
and I will continue to make the format easier to work with.
Depends on D124804
Reviewed By: lhames
Differential Revision: https://reviews.llvm.org/D124944
Paul Robinson [Wed, 1 Jun 2022 18:02:10 +0000 (11:02 -0700)]
[PS5] Add PS5OSTargetInfo class, update affected tests
Paul Robinson [Wed, 1 Jun 2022 15:53:26 +0000 (08:53 -0700)]
Refactor PS4OSTargetInfo into a base class and PS4 subclass; prep for PS5
Hendrik Greving [Wed, 1 Jun 2022 20:26:34 +0000 (13:26 -0700)]
Revert "[ValueTypes] Define MVTs for v128i2/v64i4 as well as i2 and i4."
This reverts commit
430ac5c3029c52e391e584c6d4447e6e361fae99.
Due to failures in Clang tests.
Differential Revision: https://reviews.llvm.org/D125247
Florian Hahn [Wed, 1 Jun 2022 20:19:03 +0000 (21:19 +0100)]
[LV] Add additional tests for pointer select support.
Additional test cases for D114487.
Chris Bieneman [Mon, 2 May 2022 23:09:36 +0000 (18:09 -0500)]
[Object][DX] Parse DXContainer Parts
DXContainer files are structured as parts. This patch adds support for
parsing out the file part offsets and file part headers.
Reviewed By: kuhar
Differential Revision: https://reviews.llvm.org/D124804
Hendrik Greving [Fri, 6 May 2022 23:02:31 +0000 (16:02 -0700)]
[ValueTypes] Define MVTs for v128i2/v64i4 as well as i2 and i4.
Adds MVT::v128i2, MVT::v64i4, and implied MVT::i2, MVT::i4.
Keeps MVT::i2, MVT::i4 lowering actions as `expand`, which should be
removed once targets set this explicitly.
Adjusts 11 lit tests to reflect slightly different behavior during
DAG combine.
Differential Revision: https://reviews.llvm.org/D125247
Adrian Prantl [Wed, 1 Jun 2022 19:10:39 +0000 (12:10 -0700)]
Revert "[Driver] Enable to use C++20 standalne by -fcxx-modules"
This reverts commit
a544710cd43ba9f7729a613c58729f146e792a8e.
See discussion in D120540.
This breaks C++ Clang modules on Darwin and also more than a dozen
tests in the LLDB testsuite. I think we need to be more careful to
separate out the enabling of Clang C++ modules and C++20
modules. Either by having -fmodules-ts control the HaveModules flag,
or by adding a way to explicitly turn them off.
Adrian Prantl [Wed, 1 Jun 2022 19:10:30 +0000 (12:10 -0700)]
Revert "[NFC] Use %clang instead of %clang++ in tests"
This reverts commit
738c20e6df01217b6364c3b75d0ced6b6fb6277e as a dependency of D120540.
Adrian Prantl [Wed, 1 Jun 2022 19:10:12 +0000 (12:10 -0700)]
Revert "[Driver][Modules] Remove dependence on linking support from clang/test/Driver/modules.cpp"
This reverts commit
35b1cfc76f08faabf3f27c0bd054acc7c854a6ca as a dependency of D120540.
Mark de Wever [Sat, 14 May 2022 16:03:42 +0000 (18:03 +0200)]
[NFC][libc++][format] Improves naming.
Based on review comments in D110499.
Depends on D110499
Reviewed By: ldionne, #libc
Differential Revision: https://reviews.llvm.org/D125610
Nico Weber [Wed, 1 Jun 2022 18:53:08 +0000 (14:53 -0400)]
[lld/mac] clang-format after
f5709066e3b
Michael Eisel [Wed, 1 Jun 2022 18:49:19 +0000 (14:49 -0400)]
[lld/mac] Cache file IDs of symbols in emitStabs for faster sorting
This reduces the time emitStabs() takes by about 275ms, or 3% of overall
linking time for the project I'm on. Although the parent function is run in
parallel, it's one of the slowest tasks in that concurrent batch (I have
another optimization for another slow task as well).
Differential Revision: https://reviews.llvm.org/D126785
Rob Suderman [Wed, 1 Jun 2022 18:35:26 +0000 (11:35 -0700)]
[mlir][math] Add math.ctlz expansion to control flow + arith operations
Ctlz is an intrinsic in LLVM but does not have equivalent operations in SPIR-V.
Including a decomposition gives an alternative path for these platforms.
Reviewed By: NatashaKnk
Differential Revision: https://reviews.llvm.org/D126261
Yang Keao [Wed, 1 Jun 2022 18:09:58 +0000 (13:09 -0500)]
[Polly] Migrate -polly-mse to the new pass manager.
This patch implements the `MaximalStaticExpansion` and its printer in NPM.
Reviewed By: Meinersbur
Differential Revision: https://reviews.llvm.org/D125870
Nathaniel McVicar [Wed, 1 Jun 2022 18:33:56 +0000 (11:33 -0700)]
[ccache] Add Windows support
Windows builds can't receive environment variables on the command line or make use of RULE_LAUNCH_COMPILE with ccache.
Reviewed By: stella.stamenova, Ericson2314
Differential Revision: https://reviews.llvm.org/D126575
Stella Laurenzo [Tue, 31 May 2022 20:46:06 +0000 (13:46 -0700)]
[mlir] Add global_load and global_store ops to ml_program.
* Adds simple, non-atomic, non-volatile, non-synchronized direct load/store ops.
Differential Revision: https://reviews.llvm.org/D126230
Aaron Ballman [Wed, 1 Jun 2022 18:22:24 +0000 (14:22 -0400)]
Fix an incorrect bit-width for storing attribute syntax information
This field corresponds to the Syntax enumeration, and that gained
another entry in
1fdf952deeb9a02aa34794af3c1a7d13a30e068e. However,
the bit-field for storing the syntax used was not adjusted to handle
the extra field.
This turns out to be unobservable for HLSL attributes at the moment, so
there is no test coverage. But it's also not really an NFC change
either.
Alexander Belyaev [Wed, 1 Jun 2022 18:12:23 +0000 (20:12 +0200)]
[mlir] Add conversion and tests for complex.[sqrt|atan2] to Arith.
Differential Revision: https://reviews.llvm.org/D126799
Anders Waldenborg [Fri, 27 May 2022 23:21:16 +0000 (01:21 +0200)]
[clang] Add tests for (const) weak variables
This adds tests checking the behavior of const variables declared with
weak attribute.
Both checking that they can not be used in places where a constant
expression is required and that a dynamic initializer is emitted when
used as an initializer expression.
Differential Revision: https://reviews.llvm.org/D126578
bixia1 [Tue, 31 May 2022 23:17:45 +0000 (16:17 -0700)]
[mlir][sparse] Enable the test for operator expm1.
Reviewed By: aartbik
Differential Revision: https://reviews.llvm.org/D126732
Stanislav Mekhanoshin [Wed, 1 Jun 2022 17:44:19 +0000 (10:44 -0700)]
[AMDGPU] Change GISel error handling for TFE on GFX90A
Differential Revision: https://reviews.llvm.org/D126797
Alexey Bataev [Thu, 9 Dec 2021 18:34:08 +0000 (10:34 -0800)]
[SLP]Improve shuffles cost estimation where possible.
Improved/fixed cost modeling for shuffles by providing masks, improved
cost model for non-identity insertelements.
Differential Revision: https://reviews.llvm.org/D115462
Andrew Browne [Wed, 25 May 2022 22:40:01 +0000 (15:40 -0700)]
[DFSan] Remove deprecated flag from build-libc-list.py
Reviewed By: vitalybuka
Differential Revision: https://reviews.llvm.org/D126429
Siva Chandra Reddy [Fri, 27 May 2022 05:25:36 +0000 (05:25 +0000)]
[libc] Keep all thread state information separate from the thread structure.
The state is now stored on the thread's stack memory. This enables
implementing pthread API like pthread_detach which takes the pthread_t
structure argument by value.
Reviewed By: lntue
Differential Revision: https://reviews.llvm.org/D126716
Adrian Prantl [Wed, 1 Jun 2022 17:33:25 +0000 (10:33 -0700)]
Revert "Adapt LLDB for D120540."
This reverts commit
ca73de43744503a557b1f3709c0ff4751798702f.
That patch was just hiding the problem, instead of fixing it.
Joseph Huber [Mon, 9 May 2022 18:26:01 +0000 (14:26 -0400)]
[Libomptarget] Add basic support for dynamic shared memory on AMDGPU
This patchs adds the arguments necessary to allocate the size of the
dynamic shared memory via the `LIBOMPTARGET_SHARED_MEMORY_SIZE`
environment variable. This patch only allocates the memory, AMDGPU has a
limitation that shared memory can only be accessed from the kernel
directly. So this will currently only work with optimizations to inline
the accessor function.
Reviewed By: JonChesterfield
Differential Revision: https://reviews.llvm.org/D125252
Yi Kong [Wed, 1 Jun 2022 15:53:59 +0000 (23:53 +0800)]
[BOLT] Add `-o` option to merge-fdata
Differential Revision: https://reviews.llvm.org/D126788
Fangrui Song [Wed, 1 Jun 2022 17:28:14 +0000 (10:28 -0700)]
ar_to_bc.sh: Ignore non-bitcode files in archives
The script uses llvm-link to link LLVM bitcode files.
5426da8ffa4a6d55adab21026ce6ebe8f1cc6ef2 used -DLLVM_DISABLE_ASSEMBLY_FILES=ON
to ignore object files compiled from lib/Support/BLAKE3/*.S.
A better approach (which fits Bazel better) is to ignore non-bitcode files.
Reviewed By: akyrtzi
Differential Revision: https://reviews.llvm.org/D126728
Nico Weber [Tue, 31 May 2022 19:46:12 +0000 (15:46 -0400)]
sanitizers: Do not include crypt.h if SANITIZER_INTERCEPT_CRYPT_R is undef
sanitizer_intercept_overriders.h might override SANITIZER_INTERCEPT_CRYPT_R to
be undefined. There's no need to require crypt.h in that case.
(The motivation is that crypt() moved from glibc into its own package at some
point, which makes intercepting it and building with a single sysroot that
supports both pre-bullseye and post-bullseye a bit hairy.)
Differential Revision: https://reviews.llvm.org/D126696
Aart Bik [Thu, 26 May 2022 22:17:31 +0000 (15:17 -0700)]
[mlir][python][ctypes] fix ctype python binding complication for complex
There is no direct ctypes for MLIR's complex (and thus np.complex128
and np.complex64) yet, causing the mlir python binding methods for
memrefs to crash. This revision fixes this by passing complex arrays
as tuples of floats, correcting at the boundaries for the proper view.
NOTE: some of these changes (4 -> 2) were forced by the new "linting"
Reviewed By: mehdi_amini
Differential Revision: https://reviews.llvm.org/D126422
Brooks Davis [Wed, 1 Jun 2022 16:56:37 +0000 (12:56 -0400)]
compiler-rt: Allow build without __c11_atomic_fetch_nand
Don't build atomic fetch nand libcall functions when the required
compiler builtin isn't available. Without this compiler-rt can't be
built with LLVM 13 or earlier.
Not building the libcall functions isn't optimal, but aligns with the
usecase in FreeBSD where compiler-rt from LLVM 14 is built with an LLVM
13 clang and no LLVM 14 clang is built.
Reviewed By: efriedma
Differential Revision: https://reviews.llvm.org/D126710
Balazs Benics [Wed, 1 Jun 2022 16:53:19 +0000 (18:53 +0200)]
[analyzer][NFC] Add test for
3a07280290564e294c957c94c918a6680714b417
I'm adding a test demonstraing that the issue reported by @mikaelholmen
is fixed.
Differential Revision: https://reviews.llvm.org/D126198
Alexey Bataev [Tue, 31 May 2022 20:51:27 +0000 (13:51 -0700)]
[SLP]Fix PR55796: insert point for extractelements from different basic blocks.
Extractelement instructions may come from different basic blocks, need
to take it into account when looking for a last instruction in the
bundle to prevent compiler crash.
Differential Revision: https://reviews.llvm.org/D126777
Stephen Long [Wed, 1 Jun 2022 16:39:32 +0000 (09:39 -0700)]
[MSVC] Fix pragma alloc_text failing for C files
`isExternCContext()` is returning false for functions in C files
Reviewed By: rnk, aaron.ballman
Differential Revision: https://reviews.llvm.org/D126559