platform/upstream/gflags.git
10 years agoLook for shlwapi.h also in case of MinGW.
Andreas Schuh [Wed, 19 Mar 2014 17:15:36 +0000 (17:15 +0000)]
Look for shlwapi.h also in case of MinGW.

10 years agoUse strtoll as defined by windows_port.h for strto64.
Andreas Schuh [Wed, 19 Mar 2014 16:53:19 +0000 (16:53 +0000)]
Use strtoll as defined by windows_port.h for strto64.

10 years agoUse OS_WINDOWS #define instead of _WIN32 and WINDOWS.
Andreas Schuh [Wed, 19 Mar 2014 16:46:56 +0000 (16:46 +0000)]
Use OS_WINDOWS #define instead of _WIN32 and WINDOWS.

The OS_WINDOWS #define has previously been used in gflags.cc before the CMake migration.

10 years agoMerge remote-tracking branch 'github/cmake-migration'
Andreas Schuh [Wed, 19 Mar 2014 16:08:35 +0000 (16:08 +0000)]
Merge remote-tracking branch 'github/cmake-migration'

10 years agoRemove GFLAGS_NAMESPACE and version macros from public headers again.
Andreas Schuh [Wed, 19 Mar 2014 16:05:02 +0000 (16:05 +0000)]
Remove GFLAGS_NAMESPACE and version macros from public headers again.

10 years agoSimplify check for strtoll and strtoq.
Andreas Schuh [Wed, 19 Mar 2014 15:56:26 +0000 (15:56 +0000)]
Simplify check for strtoll and strtoq.

10 years agoFix conditional compilation of tests using glob expressions.
Andreas Schuh [Wed, 19 Mar 2014 15:55:43 +0000 (15:55 +0000)]
Fix conditional compilation of tests using glob expressions.

10 years agoAdd .gitattributes file to normalize all files to LF.
Andreas Schuh [Wed, 19 Mar 2014 14:48:03 +0000 (14:48 +0000)]
Add .gitattributes file to normalize all files to LF.

10 years agoConvert line endings to Unix format.
unknown [Wed, 19 Mar 2014 14:27:08 +0000 (15:27 +0100)]
Convert line endings to Unix format.

10 years agoReplace GFLAGS_HAVE_* #defines by HAVE_* again.
Andreas Schuh [Wed, 19 Mar 2014 14:24:52 +0000 (14:24 +0000)]
Replace GFLAGS_HAVE_* #defines by HAVE_* again.

10 years agoNo need to export CommandLineFlagInfo data only structure from DLL.
Andreas Schuh [Wed, 19 Mar 2014 11:35:30 +0000 (11:35 +0000)]
No need to export CommandLineFlagInfo data only structure from DLL.

10 years agoFix bug in SafeFOpen showing up in Cygwin. Errno only guaranteed to be set on failure.
Andreas Schuh [Wed, 19 Mar 2014 11:29:43 +0000 (11:29 +0000)]
Fix bug in SafeFOpen showing up in Cygwin. Errno only guaranteed to be set on failure.

10 years agoFix check for pthreads library on Ubuntu.
Andreas Schuh [Tue, 18 Mar 2014 22:39:59 +0000 (22:39 +0000)]
Fix check for pthreads library on Ubuntu.

10 years agoAdd missing CheckTypeSizeMap.cmake.in file.
Andreas Schuh [Tue, 18 Mar 2014 22:06:13 +0000 (22:06 +0000)]
Add missing CheckTypeSizeMap.cmake.in file.

Copied from CMake master branch.

10 years agoFix DLL build on Windows and use PathMatchSpec instead of fnmatch.
Andreas Schuh [Tue, 18 Mar 2014 22:03:10 +0000 (22:03 +0000)]
Fix DLL build on Windows and use PathMatchSpec instead of fnmatch.
Expose as few system variables as possible through public interface.
Perform STRIP_FLAGS_HELP test using CMake instead of Bash.
Change file path separator used by gflags_reporting.cc to backslash on Windwos.

10 years agoModify CheckTypeSize.cmake module so it works with older CMake versions.
Andreas Schuh [Tue, 18 Mar 2014 21:59:48 +0000 (21:59 +0000)]
Modify CheckTypeSize.cmake module so it works with older CMake versions.

10 years agoFix unit tests for Windows and CygWin.
Andreas Schuh [Mon, 17 Mar 2014 21:49:10 +0000 (21:49 +0000)]
Fix unit tests for Windows and CygWin.

10 years agoAdd missing errno.h include statement and use int instead of errno_t.
Andreas Schuh [Mon, 17 Mar 2014 21:38:21 +0000 (21:38 +0000)]
Add missing errno.h include statement and use int instead of errno_t.

10 years agoFix up use of SafeFOpen.
Andreas Schuh [Mon, 17 Mar 2014 21:27:01 +0000 (21:27 +0000)]
Fix up use of SafeFOpen.

10 years agoEnable test case which tests invalid negative value for uint64 flag.
Andreas Schuh [Mon, 17 Mar 2014 21:22:51 +0000 (21:22 +0000)]
Enable test case which tests invalid negative value for uint64 flag.

10 years agoCreate temporary directory for unit tests in specified --test_tmpdir if possible.
Andreas Schuh [Mon, 17 Mar 2014 21:21:59 +0000 (21:21 +0000)]
Create temporary directory for unit tests in specified --test_tmpdir if possible.

10 years agoUse _strtoi64 and _strtoui64 on Windows.
Andreas Schuh [Mon, 17 Mar 2014 21:21:21 +0000 (21:21 +0000)]
Use _strtoi64 and _strtoui64 on Windows.

10 years agoFix VS linker warning regarding locally defined FLAGS_tryfromenv symbol.
Andreas Schuh [Mon, 17 Mar 2014 21:20:24 +0000 (21:20 +0000)]
Fix VS linker warning regarding locally defined FLAGS_tryfromenv symbol.

10 years agoFix VS security warnings using SafeGetEnv and SafeFOpen utility functions.
Andreas Schuh [Mon, 17 Mar 2014 21:19:35 +0000 (21:19 +0000)]
Fix VS security warnings using SafeGetEnv and SafeFOpen utility functions.

10 years agoMinor CMake coding style change of version_numbers function.
Andreas Schuh [Mon, 17 Mar 2014 21:16:31 +0000 (21:16 +0000)]
Minor CMake coding style change of version_numbers function.

10 years agoPass --test_tmpdir and --srcdir to unittests.
Andreas Schuh [Mon, 17 Mar 2014 21:15:52 +0000 (21:15 +0000)]
Pass --test_tmpdir and --srcdir to unittests.

10 years agoRequire at least CMake 2.8.4 to avoid Cygwin legacy warning.
Andreas Schuh [Mon, 17 Mar 2014 20:54:48 +0000 (20:54 +0000)]
Require at least CMake 2.8.4 to avoid Cygwin legacy warning.

10 years agoAdd missing execute_test.cmake script.
Andreas Schuh [Mon, 17 Mar 2014 16:12:56 +0000 (16:12 +0000)]
Add missing execute_test.cmake script.

10 years agoRename FindThreadsCXX module.
Andreas Schuh [Mon, 17 Mar 2014 13:44:03 +0000 (13:44 +0000)]
Rename FindThreadsCXX module.

10 years agoFix typo in documentation and path of execute_test.cmake script.
Andreas Schuh [Mon, 17 Mar 2014 13:41:46 +0000 (13:41 +0000)]
Fix typo in documentation and path of execute_test.cmake script.

10 years agoRemove obsolete set(GFLAGS_INTTYPES_FORMAT) call.
Andreas Schuh [Mon, 17 Mar 2014 13:38:48 +0000 (13:38 +0000)]
Remove obsolete set(GFLAGS_INTTYPES_FORMAT) call.

10 years agoMinor style change to be consistent.
Andreas Schuh [Mon, 17 Mar 2014 13:36:34 +0000 (13:36 +0000)]
Minor style change to be consistent.

10 years agoFix preprocessor conditions to use new GFLAGS_* defines.
Andreas Schuh [Mon, 17 Mar 2014 13:33:26 +0000 (13:33 +0000)]
Fix preprocessor conditions to use new GFLAGS_* defines.

10 years agoModify CheckCXXLibraryExists to use CMakeFiles directory.
Andreas Schuh [Mon, 17 Mar 2014 13:25:04 +0000 (13:25 +0000)]
Modify CheckCXXLibraryExists to use CMakeFiles directory.

10 years agoAdd CheckCXXLibraryExists.cmake module and use it in FindTreadsCXX.cmake.
Andreas Schuh [Mon, 17 Mar 2014 13:17:44 +0000 (13:17 +0000)]
Add CheckCXXLibraryExists.cmake module and use it in FindTreadsCXX.cmake.

10 years agoFix previous change of FindThreadsCxx.cmake by copying needed source file from CMake...
Andreas Schuh [Mon, 17 Mar 2014 12:38:41 +0000 (12:38 +0000)]
Fix previous change of FindThreadsCxx.cmake by copying needed source file from CMake installation, changing the file name extension only.

10 years agoUse CheckForPthreads.cxx to find pthreads library on Ubuntu.
Andreas Schuh [Mon, 17 Mar 2014 12:35:28 +0000 (12:35 +0000)]
Use CheckForPthreads.cxx to find pthreads library on Ubuntu.

10 years agoMerge pull request #7 from andy-held/cmake-migration
Andreas Schuh [Mon, 17 Mar 2014 12:16:26 +0000 (12:16 +0000)]
Merge pull request #7 from andy-held/cmake-migration

Fix case in CMake module includes.

10 years ago* fixed letter case of included file names
Andreas Franek [Mon, 17 Mar 2014 08:38:15 +0000 (09:38 +0100)]
* fixed letter case of included file names
* C language definition is needed for CheckForPthreads.c

10 years agoCheck if pthread_rwlock_t is available and use it if so.
Andreas Schuh [Sat, 15 Mar 2014 14:31:21 +0000 (14:31 +0000)]
Check if pthread_rwlock_t is available and use it if so.

10 years agoFix build with Xcode 5, system checks, set LANGUAGE to CXX.
Andreas Schuh [Sat, 15 Mar 2014 14:15:33 +0000 (14:15 +0000)]
Fix build with Xcode 5, system checks, set LANGUAGE to CXX.

10 years agoRemove obsolete gflags_unittest.sh script.
Andreas Schuh [Fri, 14 Mar 2014 20:34:30 +0000 (20:34 +0000)]
Remove obsolete gflags_unittest.sh script.

10 years agoMigrate unit tests to CMake/CTest. Fix preprocessor directive in gflags_unittest.cc.
Andreas Schuh [Fri, 14 Mar 2014 20:32:37 +0000 (20:32 +0000)]
Migrate unit tests to CMake/CTest. Fix preprocessor directive in gflags_unittest.cc.

10 years agoIssue #73 Merge gflags_config.h into gflags_declare.h. Configuration of gflags.h...
Andreas Schuh [Fri, 14 Mar 2014 16:29:51 +0000 (16:29 +0000)]
Issue #73 Merge gflags_config.h into gflags_declare.h. Configuration of gflags.h no longer needed.

10 years agoIssue #73 Fix missing STL DLL export warnings of Visual Studio according to KB168958.
Andreas Schuh [Fri, 14 Mar 2014 16:08:52 +0000 (16:08 +0000)]
Issue #73 Fix missing STL DLL export warnings of Visual Studio according to KB168958.

10 years agoFix build on Windows using Visual Studio. Add gflags_config.h.
Andreas Schuh [Fri, 14 Mar 2014 13:30:22 +0000 (13:30 +0000)]
Fix build on Windows using Visual Studio. Add gflags_config.h.

10 years agoAdd header files to add_library targets so they show up in IDEs.
Andreas Schuh [Fri, 14 Mar 2014 13:29:11 +0000 (13:29 +0000)]
Add header files to add_library targets so they show up in IDEs.

10 years agoMinor update of README.
Andreas Schuh [Wed, 6 Nov 2013 20:56:03 +0000 (20:56 +0000)]
Minor update of README.

10 years agoIgnore .DS_Store files of OS X.
Andreas Schuh [Tue, 5 Nov 2013 12:09:52 +0000 (12:09 +0000)]
Ignore .DS_Store files of OS X.

10 years agoBe more specific about what to ignore.
Andreas Schuh [Tue, 5 Nov 2013 12:03:29 +0000 (12:03 +0000)]
Be more specific about what to ignore.

10 years agoMerge pull request #3 from dominichamon/cmake-migration
Andreas Schuh [Tue, 5 Nov 2013 11:56:17 +0000 (03:56 -0800)]
Merge pull request #3 from dominichamon/cmake-migration

Adding gitignore for generated files

10 years agoMerge pull request #4 from daniperez/cmake-migration
Andreas Schuh [Tue, 5 Nov 2013 00:56:31 +0000 (16:56 -0800)]
Merge pull request #4 from daniperez/cmake-migration

Exporting binary tree to CMake registry

10 years agoexporting binary tree to CMake registry
Dani Perez [Tue, 22 Oct 2013 21:03:27 +0000 (23:03 +0200)]
exporting binary tree to CMake registry

This eases integration with other applications making use
of gflags without needing to install it in the system.
find_package looks in the registry for existing software.

10 years agoAdding gitignore for generated files
Dominic Hamon [Fri, 20 Sep 2013 21:14:23 +0000 (14:14 -0700)]
Adding gitignore for generated files

10 years agoRemove reference to README_windows.
Andreas Schuh [Thu, 1 Aug 2013 02:53:59 +0000 (03:53 +0100)]
Remove reference to README_windows.

10 years agoDocument finding and linking to gflags using CMake.
Andreas Schuh [Thu, 1 Aug 2013 02:46:29 +0000 (03:46 +0100)]
Document finding and linking to gflags using CMake.

10 years agoAdd negative compilation tests.
Andreas Schuh [Thu, 1 Aug 2013 02:31:47 +0000 (03:31 +0100)]
Add negative compilation tests.

10 years agoAdd gflags library which is built with NO_THREADS definition.
Andreas Schuh [Thu, 1 Aug 2013 01:04:37 +0000 (02:04 +0100)]
Add gflags library which is built with NO_THREADS definition.

10 years agoAdd missing unittest2 and unittest3 executables.
Andreas Schuh [Thu, 1 Aug 2013 00:59:32 +0000 (01:59 +0100)]
Add missing unittest2 and unittest3 executables.

10 years agoEnable build and execution of tests again using CTest.
Andreas Schuh [Thu, 1 Aug 2013 00:47:13 +0000 (01:47 +0100)]
Enable build and execution of tests again using CTest.

10 years agoInstall Bash completion script.
Andreas Schuh [Thu, 1 Aug 2013 00:06:36 +0000 (01:06 +0100)]
Install Bash completion script.

10 years agoGive basic CMake based build instructions in INSTALL file.
Andreas Schuh [Wed, 31 Jul 2013 23:52:46 +0000 (00:52 +0100)]
Give basic CMake based build instructions in INSTALL file.

10 years agoSet PACKAGE_VERSION_EXACT to FALSE if major.minor version is not equal to the request...
Andreas Schuh [Wed, 31 Jul 2013 23:27:40 +0000 (00:27 +0100)]
Set PACKAGE_VERSION_EXACT to FALSE if major.minor version is not equal to the requested version.

10 years agoMove definition of configure_sources CMake function to utils module.
Andreas Schuh [Wed, 31 Jul 2013 23:17:53 +0000 (00:17 +0100)]
Move definition of configure_sources CMake function to utils module.

10 years agoUse gflags as target name instead of PACKAGE_NAME to not make things unnecessarily...
Andreas Schuh [Wed, 31 Jul 2013 23:17:13 +0000 (00:17 +0100)]
Use gflags as target name instead of PACKAGE_NAME to not make things unnecessarily generic.

10 years agoFix relative path to installation prefix in CMake config file.
Andreas Schuh [Wed, 31 Jul 2013 23:10:15 +0000 (00:10 +0100)]
Fix relative path to installation prefix in CMake config file.

10 years agoInstall CMake config file inside lib/ directory on Unix.
Andreas Schuh [Wed, 31 Jul 2013 23:01:21 +0000 (00:01 +0100)]
Install CMake config file inside lib/ directory on Unix.

10 years agoConfigure and install CMake package configuration file to help find_package locate...
Andreas Schuh [Wed, 31 Jul 2013 22:55:50 +0000 (23:55 +0100)]
Configure and install CMake package configuration file to help find_package locate the gflags package.

11 years agoFix configuration on Windows and add src directory to include path.
Andreas Schuh [Wed, 22 May 2013 10:02:04 +0000 (11:02 +0100)]
Fix configuration on Windows and add src directory to include path.

11 years agoAdd missing windows portability definitions.
Andreas Schuh [Tue, 21 May 2013 23:06:08 +0000 (00:06 +0100)]
Add missing windows portability definitions.

11 years agoMove public header files to src/ subdirectory. Copy them to <prefix>/include/<ns...
Andreas Schuh [Sun, 21 Apr 2013 02:38:25 +0000 (03:38 +0100)]
Move public header files to src/ subdirectory. Copy them to <prefix>/include/<ns>/ upon installation.

11 years agoSet CMAKE_BUILD_TYPE to Release by default. Require CMake >=2.8.
Andreas Schuh [Sun, 21 Apr 2013 02:09:43 +0000 (03:09 +0100)]
Set CMAKE_BUILD_TYPE to Release by default. Require CMake >=2.8.

11 years agoAdd CMakeLists.txt and adapt source files accordingly.
Andreas Schuh [Sun, 21 Apr 2013 02:05:35 +0000 (03:05 +0100)]
Add CMakeLists.txt and adapt source files accordingly.

11 years agoMove public header files to separate subdirectory.
Andreas Schuh [Sat, 20 Apr 2013 23:11:52 +0000 (00:11 +0100)]
Move public header files to separate subdirectory.

11 years agoRemove build tool related files, operating system packages, and move unit tests to...
Andreas Schuh [Sat, 20 Apr 2013 21:45:51 +0000 (22:45 +0100)]
Remove build tool related files, operating system packages, and move unit tests to separate subdirectory.

11 years agoUpdate NEWS: Git repository hosted on GitHub.
Andreas Schuh [Sat, 20 Apr 2013 22:49:37 +0000 (22:49 +0000)]
Update NEWS: Git repository hosted on GitHub.

git-svn-id: https://gflags.googlecode.com/svn/trunk@84 6586e3c6-dcc4-952a-343f-ff74eb82781d

11 years agoTest commit via git-svn, only adding blank lines to NEWS.
Andreas Schuh [Sat, 20 Apr 2013 22:14:36 +0000 (22:14 +0000)]
Test commit via git-svn, only adding blank lines to NEWS.

git-svn-id: https://gflags.googlecode.com/svn/trunk@83 6586e3c6-dcc4-952a-343f-ff74eb82781d

11 years agoAdd DEFINE_validator macro for convenient registration of a flag validator.
Andreas Schuh [Sat, 20 Apr 2013 18:35:34 +0000 (18:35 +0000)]
Add DEFINE_validator macro for convenient registration of a flag validator.

git-svn-id: https://gflags.googlecode.com/svn/trunk@82 6586e3c6-dcc4-952a-343f-ff74eb82781d

11 years agoUse static_cast to avoid comparison of signed and unsigned integer warning in util.h.
Andreas Schuh [Mon, 14 Jan 2013 15:11:53 +0000 (15:11 +0000)]
Use static_cast to avoid comparison of signed and unsigned integer warning in util.h.

git-svn-id: https://gflags.googlecode.com/svn/trunk@81 6586e3c6-dcc4-952a-343f-ff74eb82781d

11 years agoFix deprecation warnings of VC++ regarding strdup and unlink. Add solution files...
Andreas Schuh [Tue, 20 Nov 2012 14:48:22 +0000 (14:48 +0000)]
Fix deprecation warnings of VC++ regarding strdup and unlink. Add solution files for VS 2010 and VS 2012.

git-svn-id: https://gflags.googlecode.com/svn/trunk@80 6586e3c6-dcc4-952a-343f-ff74eb82781d

11 years agoAdd "build/" subdirectory to ignore list.
Andreas Schuh [Sun, 11 Nov 2012 20:33:21 +0000 (20:33 +0000)]
Add "build/" subdirectory to ignore list.

git-svn-id: https://gflags.googlecode.com/svn/trunk@79 6586e3c6-dcc4-952a-343f-ff74eb82781d

11 years agoUse project name (gflags) within include guards to avoid conflict with gperftools...
Andreas Schuh [Sun, 11 Nov 2012 20:32:35 +0000 (20:32 +0000)]
Use project name (gflags) within include guards to avoid conflict with gperftools as reported by chen3feng (issue #62, code.google.com/p/gflags/issues/detail?id=62).

git-svn-id: https://gflags.googlecode.com/svn/trunk@78 6586e3c6-dcc4-952a-343f-ff74eb82781d

12 years agoFix "invalid suffix on literal; C++11 requires a space between literal and identifier...
Andreas Schuh [Tue, 29 May 2012 15:19:11 +0000 (15:19 +0000)]
Fix "invalid suffix on literal; C++11 requires a space between literal and identifier" errors as reported by code.google.com/p/gflags/issues/detail?id=54.

git-svn-id: https://gflags.googlecode.com/svn/trunk@77 6586e3c6-dcc4-952a-343f-ff74eb82781d

12 years agoFixed a typo in the email address.
Craig Silverstein [Thu, 2 Feb 2012 22:49:44 +0000 (22:49 +0000)]
Fixed a typo in the email address.

git-svn-id: https://gflags.googlecode.com/svn/trunk@76 6586e3c6-dcc4-952a-343f-ff74eb82781d

12 years agoWed Jan 25 15:09:14 2012 Google Inc. <google-gflags@googlegroups.com>
Craig Silverstein [Wed, 25 Jan 2012 23:59:40 +0000 (23:59 +0000)]
Wed Jan 25 15:09:14 2012  Google Inc. <google-gflags@googlegroups.com>

* gflags: version 2.0
* Changed the 'official' gflags email in setup.py/etc
* Renamed google-gflags.sln to gflags.sln
* Changed copyright text to reflect Google's relinquished ownership

git-svn-id: https://gflags.googlecode.com/svn/trunk@74 6586e3c6-dcc4-952a-343f-ff74eb82781d

12 years agoTue Dec 20 19:48:57 2011 Google Inc. <opensource@google.com>
Craig Silverstein [Wed, 21 Dec 2011 04:28:52 +0000 (04:28 +0000)]
Tue Dec 20 19:48:57 2011  Google Inc. <opensource@google.com>

* google-gflags: version 1.7
* Add CommandLineFlagInfo::flag_ptr pointing to current storage (musji)
* PORTING: flush after writing to stderr, needed on cygwin
* PORTING: Clean up the GFLAGS_DLL_DECL stuff better
* Fix a bug in StringPrintf() that affected large strings (csilvers)
* Die at configure-time when g++ isn't installed

git-svn-id: https://gflags.googlecode.com/svn/trunk@72 6586e3c6-dcc4-952a-343f-ff74eb82781d

12 years agoClarify thread-safety comment for FlagSaver.
Craig Silverstein [Thu, 1 Dec 2011 01:58:29 +0000 (01:58 +0000)]
Clarify thread-safety comment for FlagSaver.

Tested:
blaze test base:commandlineflags_unittest

R=csilvers
DELTA=4  (3 added, 0 deleted, 1 changed)

Revision created by MOE tool push_codebase.
MOE_MIGRATION=3791

git-svn-id: https://gflags.googlecode.com/svn/trunk@71 6586e3c6-dcc4-952a-343f-ff74eb82781d

12 years agoThe last bit of rolling back commandlineflag categories:
Craig Silverstein [Thu, 3 Nov 2011 23:37:01 +0000 (23:37 +0000)]
The last bit of rolling back commandlineflag categories:
remove the 'categories' field from CommandLineFlagInfo.  (Note
the code to fill this field was removed from
FillComandLineFlagInfo previously, so it's been an empty
string for some time now.)

R=ncalvin
DELTA=1  (0 added, 1 deleted, 0 changed)

Revision created by MOE tool push_codebase.
MOE_MIGRATION=3616

git-svn-id: https://gflags.googlecode.com/svn/trunk@70 6586e3c6-dcc4-952a-343f-ff74eb82781d

12 years agoGet rid of the old FlagRegisterer constructor.
Craig Silverstein [Thu, 3 Nov 2011 23:28:30 +0000 (23:28 +0000)]
Get rid of the old FlagRegisterer constructor.

R=jkline,georgevdd
DELTA=27  (0 added, 27 deleted, 0 changed)

Revision created by MOE tool push_codebase.
MOE_MIGRATION=3609

git-svn-id: https://gflags.googlecode.com/svn/trunk@69 6586e3c6-dcc4-952a-343f-ff74eb82781d

12 years agoStarting the rollback of flag categories.
Craig Silverstein [Thu, 3 Nov 2011 23:25:32 +0000 (23:25 +0000)]
Starting the rollback of flag categories.

I left in the old FlagRegisterer constructor.
I also left in 'categories' in CommandLineFlagInfo for now,
though I never use it.  I doubt anyone else does either, but I
want to minimize the number of ways this rollback can break
the build.  I will remove it in a subsequent CL.

R=ncalvin
DELTA=121  (28 added, 55 deleted, 38 changed)

Revision created by MOE tool push_codebase.
MOE_MIGRATION=3574

git-svn-id: https://gflags.googlecode.com/svn/trunk@68 6586e3c6-dcc4-952a-343f-ff74eb82781d

12 years agoAdd a 'flag_ptr' field to CommandLineFlagInfo that points to the current storage...
Craig Silverstein [Thu, 3 Nov 2011 23:18:00 +0000 (23:18 +0000)]
Add a 'flag_ptr' field to CommandLineFlagInfo that points to the current storage of the flag (i.e. &FLAGS_foo).

R=csilvers
DELTA=15  (15 added, 0 deleted, 0 changed)

Revision created by MOE tool push_codebase.
MOE_MIGRATION=3301

git-svn-id: https://gflags.googlecode.com/svn/trunk@67 6586e3c6-dcc4-952a-343f-ff74eb82781d

12 years agoA user reported a bug that configure should die when g++ isn't
Craig Silverstein [Thu, 3 Nov 2011 23:16:21 +0000 (23:16 +0000)]
A user reported a bug that configure should die when g++ isn't
installed, but wasn't:
http://code.google.com/p/google-perftools/issues/detail?id=217

This turned out to be a bug in autoconf:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=357378

The workaround is simple: check for CXX before checking for
CC.  This means that if g++ is installed but gcc isn't, we
won't die (at cc-checking time), but I tested, and the
configure script dies later.  In any case, it seems unlikely
someone would have a c++ compiler installed but not a c
compiler.

This fixes the 4 opensource projects I work on that are
susceptible to this.

R=iant
DELTA=1437  (694 added, 694 deleted, 49 changed)

Revision created by MOE tool push_codebase.
MOE_MIGRATION=3222

git-svn-id: https://gflags.googlecode.com/svn/trunk@66 6586e3c6-dcc4-952a-343f-ff74eb82781d

12 years agoNow I can get rid of the old constructor!
Craig Silverstein [Thu, 3 Nov 2011 23:12:52 +0000 (23:12 +0000)]
Now I can get rid of the old constructor!

R=jkline,ncalvin
DELTA=28  (0 added, 27 deleted, 1 changed)

Revision created by MOE tool push_codebase.
MOE_MIGRATION=3169

git-svn-id: https://gflags.googlecode.com/svn/trunk@65 6586e3c6-dcc4-952a-343f-ff74eb82781d

12 years agohttp://code.google.com/p/google-gflags/issues/detail?id=45
Craig Silverstein [Thu, 3 Nov 2011 23:11:24 +0000 (23:11 +0000)]
code.google.com/p/google-gflags/issues/detail?id=45
reports that the error isn't always getting flushed on
cygwin.  So do that explicitly.

R=desovski
DELTA=1  (1 added, 0 deleted, 0 changed)

Revision created by MOE tool push_codebase.
MOE_MIGRATION=3140

git-svn-id: https://gflags.googlecode.com/svn/trunk@64 6586e3c6-dcc4-952a-343f-ff74eb82781d

12 years agoReport category names via the xml help output (but not, yet,
Craig Silverstein [Thu, 3 Nov 2011 23:09:49 +0000 (23:09 +0000)]
Report category names via the xml help output (but not, yet,
during 'normal' help output).

R=ncalvin
DELTA=3  (3 added, 0 deleted, 0 changed)

Revision created by MOE tool push_codebase.
MOE_MIGRATION=3066

git-svn-id: https://gflags.googlecode.com/svn/trunk@63 6586e3c6-dcc4-952a-343f-ff74eb82781d

12 years agoAdd back in a backwards-compatible constructor for
Craig Silverstein [Thu, 3 Nov 2011 23:09:19 +0000 (23:09 +0000)]
Add back in a backwards-compatible constructor for
FlagRegisterer.

Because this backwards-compatible API is intended to be
short-lived, I did it in the simplest, least invasive way
possible, which involved cutting-and-pasting.

R=ncalvin,jkline
DELTA=27  (27 added, 0 deleted, 0 changed)

Revision created by MOE tool push_codebase.
MOE_MIGRATION=3065

git-svn-id: https://gflags.googlecode.com/svn/trunk@62 6586e3c6-dcc4-952a-343f-ff74eb82781d

12 years agoNOTE: I'm checking this in just to have a record in source control of the idea. ...
Craig Silverstein [Thu, 3 Nov 2011 23:08:41 +0000 (23:08 +0000)]
NOTE: I'm checking this in just to have a record in source control of the idea.  We've decided for now it doesn't make sense to go forward with flag categories -- and the __VA_ARGS__ for macros has caused lots of problems with uncaught accidental commas, already -- so a future commit will back this out.  (Actually, it's all a series of commits, for annoying technical reasons.)

Add support for flag categories.

In this CL, all you can do is set categories in the DEFINE_*
macros and then retrieve them via GetCommandLineFlagInfo and
similar.

In future CLs, we will start to give some semantic meaning to
particular flag values, as described in the designdoc.  In
particular, we will start to use flag categories to revamp
--help output.

Implementation-wise: to keep categories an optional macro
argument, I had to use __VA_ARGS__, which means future gflags
releases will no longer work with MSVC 7.1.  We're at MSVC 10
now, so I'm pretty much ok with that.

The downside of __VA_ARGS__ is there is no error if you
specify more args after the ones we expect.  To get around
that, I only use __VA_ARGS_ in this idiom:
static const OptionalDefineArgs var = { __VA_ARGS__ };
The new OptionalDefineArgs struct defines all the args that
may be optionally specified in the DEFINE_* macros.  For now,
that's only the 'categories' arg, though in theory more could be
added later.

R=titus,ncalvin
DELTA=92  (54 added, 3 deleted, 35 changed)

Revision created by MOE tool push_codebase.
MOE_MIGRATION=3057

git-svn-id: https://gflags.googlecode.com/svn/trunk@61 6586e3c6-dcc4-952a-343f-ff74eb82781d

12 years agoClean up the 'GFLAGS_DLL_DECL' stuff better: reduce use outside of windows/ directory.
Craig Silverstein [Thu, 18 Aug 2011 11:39:20 +0000 (11:39 +0000)]
Clean up the 'GFLAGS_DLL_DECL' stuff better: reduce use outside of windows/ directory.

R=jyrki
DELTA=33  (0 added, 27 deleted, 6 changed)

Revision created by MOE tool push_codebase.
MOE_MIGRATION=3016

git-svn-id: https://gflags.googlecode.com/svn/trunk@60 6586e3c6-dcc4-952a-343f-ff74eb82781d

12 years agoFix a bug in StringPrintf() that caused it to not print large strings properly.
Craig Silverstein [Thu, 4 Aug 2011 00:02:52 +0000 (00:02 +0000)]
Fix a bug in StringPrintf() that caused it to not print large strings properly.

R=nilton
DELTA=1  (0 added, 0 deleted, 1 changed)

Revision created by MOE tool push_codebase.
MOE_MIGRATION=2886

git-svn-id: https://gflags.googlecode.com/svn/trunk@59 6586e3c6-dcc4-952a-343f-ff74eb82781d

12 years agoAdd a new unittest case, that tests the --help output for a
Craig Silverstein [Thu, 4 Aug 2011 00:02:39 +0000 (00:02 +0000)]
Add a new unittest case, that tests the --help output for a
really long helpstring.  Opensource gflags had a bug where we
were cutting off the output too soon; this test should protect
against such a thing.

R=nilton
DELTA=16  (16 added, 0 deleted, 0 changed)

Revision created by MOE tool push_codebase.
MOE_MIGRATION=2885

git-svn-id: https://gflags.googlecode.com/svn/trunk@58 6586e3c6-dcc4-952a-343f-ff74eb82781d