platform/upstream/bluez.git
4 years agomesh: Fix clean up of node's DBUS assosiated resources
Inga Stotland [Wed, 3 Jul 2019 23:02:44 +0000 (16:02 -0700)]
mesh: Fix clean up of node's DBUS assosiated resources

This consolidates multiple places where node's object paths,
interfaces, etc. are de-allocated, into one routine:
free_node_dbus_resources().
This also addresses memory leaks assosiated with inconsistent freeing
of object path strings.

Change-Id: If11ec87748384b43dd7f6b7ef06d88439cf0323c
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Fix checks when restoring internal model state
Inga Stotland [Wed, 3 Jul 2019 20:53:41 +0000 (13:53 -0700)]
mesh: Fix checks when restoring internal model state

This fixes incorrect conditional checks in restore_model_state()
which could lead to dereferencing a NULL pointer.

Change-Id: I65631b3cd22c9e5f5e43aa62e093c227182749b8
Wrong: if (l_queue_isempty(mod->bindings) || !mod->cbs->bind) ...
Fixed: if (!l_queue_isempty(mod->bindings) && cbs->bind) ...
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Fix memory leak on dbus message creation
Brian Gix [Wed, 3 Jul 2019 16:34:03 +0000 (09:34 -0700)]
mesh: Fix memory leak on dbus message creation

Change-Id: I82a29b20859c1310ff17acf8e181de822b9a4952
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Allow to set-up the CRPL with application
Jakub Witowski [Tue, 2 Jul 2019 12:31:41 +0000 (14:31 +0200)]
mesh: Allow to set-up the CRPL with application

This adds an optional CRPL property to org.bluez.mesh.Application1
interface, allowing to indicate the depth of reply protection list.

Change-Id: I838ecb7f4f5396d46a67fe20ca87c8944331eb82
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Register D-Bus management interface
Michał Lowas-Rzechonek [Fri, 28 Jun 2019 08:27:34 +0000 (10:27 +0200)]
mesh: Register D-Bus management interface

When application Attach()es itself, start exposing both Node1 and
Management1 D-Bus interfaces.

Change-Id: I2a94441cce59cee62e219ee40b07d6f3124290df
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Clear nodes queue on get_managed_objects_cb() fails
Jakub Witowski [Fri, 28 Jun 2019 09:50:49 +0000 (11:50 +0200)]
mesh: Clear nodes queue on get_managed_objects_cb() fails

Currently when the get_managed_objects_cb() fails it frees
the node resources but the node still remains on the "nodes" queue.

This implementation calls node_remove() instead of
free_node_resources()."

Change-Id: I2a2e03c671d85e9ee318fb8ae30b7d67e4855ffc
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agotest: test-mesh - Correctly stop periodic publication
Inga Stotland [Sun, 30 Jun 2019 06:43:56 +0000 (23:43 -0700)]
test: test-mesh - Correctly stop periodic publication

This changes the order of checks for an updated publication period:
check for zero period first, and if this is the case, stop sending
the periodic model publications.

Change-Id: I2693c5a593fa23e59dd2e015348f1fd96a30c88f
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Fix and clean up model publication code
Inga Stotland [Sun, 30 Jun 2019 06:43:55 +0000 (23:43 -0700)]
mesh: Fix and clean up model publication code

This adds proper checks for model publication removal:
the publication is not virtual and the publication address is set to zero,
i.e., UNASSIGNED_ADDRESS.
Also removes double memory allocation for model publication and
miscellaneous redundancies.

Change-Id: Ib41b16a583de598c38ffd176bca5812f1bf96375
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Fix virtual address processing
Inga Stotland [Sun, 30 Jun 2019 06:43:54 +0000 (23:43 -0700)]
mesh: Fix virtual address processing

This tightens up the accounting for locally stored virtual addresses.
Alos, use meaningful variable names to identify components of a
mesh virtual address.

Change-Id: Iea7ed8035bacd8ea41deda7738ace39b57a8eb2e
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Clean up model.c and cfg-server.c
Inga Stotland [Sun, 30 Jun 2019 06:43:53 +0000 (23:43 -0700)]
mesh: Clean up model.c and cfg-server.c

This removes a number of redundancies, fixes naming conventions and
style.

Change-Id: I6b7d7027451ee043f89e5afe17ec9a0eebb0ef5b
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Fix D-Bus node path
Michał Lowas-Rzechonek [Fri, 28 Jun 2019 08:27:33 +0000 (10:27 +0200)]
mesh: Fix D-Bus node path

According to doc/mesh-api.txt, node object should be located at
/org/bluez/mesh/node.

Change-Id: I94a39b7b092e14b7a082fd7dfd17e11c1960b568
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Fixed handling of IVI flag in app layer
Michał Lowas-Rzechonek [Thu, 27 Jun 2019 07:40:42 +0000 (09:40 +0200)]
mesh: Fixed handling of IVI flag in app layer

Since IV Index is used in application nonces, we need to honor IVI flag
not only in network layer crypto, but also in application layer.

This means that if IVI field of incoming packet is different than in
current IV Index, try to decode *both* net and app layers using IV Index
decreased by one.

Change-Id: Ieaacc703dac4aa8b9a58ea6bf01a92b1893e9b7b
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Modify check of the node directory name upon removal
Inga Stotland [Mon, 24 Jun 2019 17:41:42 +0000 (10:41 -0700)]
mesh: Modify check of the node directory name upon removal

This removes check for "mesh" as the parent directory name and, instead,
verifies that the node configuration directory name is the hexadecimal
string representating the node's UUID.

Change-Id: Id7ec5d7cb4c609fea7ea79232da8c78cc18f09af
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Fix to duplicated model Ids saved to storage
Rafał Gajda [Wed, 26 Jun 2019 15:49:02 +0000 (17:49 +0200)]
mesh: Fix to duplicated model Ids saved to storage

Mesh daemon internally implements the Config Server SIG model.

When generating node, if the Mesh Element in mesh application
returns modelId 0 among its supported models, it should be skipped,
otherwise it will be duplicated and saved in the storage file.

This patch fixes correctly skipping Config Server model during node
creation.

Change-Id: Ic2bc3df4e21ec5b2e4f5678a70443fa458f69aa4
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Remove unused error code from Leave()
Jakub Witowski [Wed, 19 Jun 2019 09:18:56 +0000 (11:18 +0200)]
mesh: Remove unused error code from Leave()

This removes NotFound error from mesh-api.txt from Leave() function.

Change-Id: I00efdb4781f24f6866208bf7a76075b78813a325
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Move HCI handling to mesh-io-generic
Michał Lowas-Rzechonek [Mon, 24 Jun 2019 07:32:28 +0000 (09:32 +0200)]
mesh: Move HCI handling to mesh-io-generic

This patch separates 'mesh' module from 'mesh_io', particularly
regarding configuration and initialization.

Main code is no longer aware of MGMT and HCI usage - querying available
HCI interfaces now happens in mesh-io-generic.

MGMT code is now extracted into mesh-mgmt module, which mesh-io-generic
uses to query interfaces.

Change-Id: I698752859bc7c1218410e83fc1a04a381539984b
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Remove redundant checks when adding a net key
Inga Stotland [Wed, 12 Jun 2019 15:04:37 +0000 (08:04 -0700)]
mesh: Remove redundant checks when adding a net key

This patch cleans up redundant checks in add_key() and mesh_net_set_key():
no need to check the result of l_queue_push_tail() and no need to check
if subnet is valid after it was successfully created.

Change-Id: I5c9b0a7483d70db955b57d9c2d4587b5996934fe
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agobuild: Add missing mesh & btpclient dependencies
Brian Gix [Wed, 12 Jun 2019 15:09:50 +0000 (08:09 -0700)]
build: Add missing mesh & btpclient dependencies

btpclient and bluetooth mesh fail to build on their own until
certain ELL and generated header files have been built, which
can cause a build to fail if derived objects are generated in
wrong order.

Change-Id: I4e50d13e8fbd2718cc6a1fc3ee6bef5db0d46e94
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Fix segmentation fault after adding second netkey via NET_KEY_ADD opcode
Jakub Witowski [Mon, 10 Jun 2019 08:46:05 +0000 (10:46 +0200)]
mesh: Fix segmentation fault after adding second netkey via NET_KEY_ADD opcode

Segmentation fault was caused by passing subnet pointer to the
start_network_beacon() which was NULL

Change-Id: Ic09f390fe7c056028acc948f5feb3f34a0e50b4f
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Clean up style
Inga Stotland [Thu, 6 Jun 2019 01:18:32 +0000 (18:18 -0700)]
mesh: Clean up style

This cleans up some stylistic issues. Plus, don't check the return
value of l_new(): if memory allocation fails, the execution stops.

Change-Id: I86e7980ab218fab1d761ce52c41fd936b00e155e
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Make "elements" mandatory in node configuration
Inga Stotland [Thu, 6 Jun 2019 01:18:31 +0000 (18:18 -0700)]
mesh: Make "elements" mandatory in node configuration

This patch modifies the behavior of node configuration parsing:
if "elements" property is not present, th configuration file
for this node is regarded as malformed.

Also, clean up style.

Change-Id: I3a869f74cf103f04fdb99f991c0156932372354e
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Do not daemonize, run in foreground or as service
Inga Stotland [Tue, 4 Jun 2019 06:07:48 +0000 (23:07 -0700)]
mesh: Do not daemonize, run in foreground or as service

This removes call to daemon(). "--nodetach" option is retained
to set umask().

Also, adds description for dbus-debug option.

Change-Id: I534dfb17161e2866a1b87c78d6d72b492c20c768
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Enable mesh package build in Tizen
Anupam Roy [Tue, 17 Dec 2019 15:10:01 +0000 (20:40 +0530)]
mesh: Enable mesh package build in Tizen

Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Add bluetooth mesh package in Tizen
Anupam Roy [Fri, 13 Dec 2019 09:18:34 +0000 (14:48 +0530)]
mesh: Add bluetooth mesh package in Tizen

bluetooth mesh support is presently by-default enabled
in buid spec file.

Change-Id: Ice98f3a8dad6a4d3a6f999bfae0ed9c674e83b19
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Fix compilation issues
Anupam Roy [Tue, 17 Dec 2019 14:48:11 +0000 (20:18 +0530)]
mesh: Fix compilation issues

Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agobuild: Add support for systemd bluetooth-mesh service
Inga Stotland [Tue, 4 Jun 2019 06:07:47 +0000 (23:07 -0700)]
build: Add support for systemd bluetooth-mesh service

This adds support for installing systemd bluetooth-mesh service unit
and D-Bus service file that references this systemd unit.

Change-Id: I8306de2261244ead765bdae9b6b7bed00f069a61
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: ELL encrypt dependancy README section added
Brian Gix [Fri, 31 May 2019 15:56:43 +0000 (08:56 -0700)]
mesh: ELL encrypt dependancy README section added

Due to known AEAD encryption deficiencies in old versions of the
kernel, we have added a section on identifying and back-porting
mesh to otherwise non-supporting platforms.

Change-Id: I71ecc5164dbd29cc7fd33278712ab746c961fa82
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Convert crypto to use ELL wrappers
Brian Gix [Wed, 29 May 2019 17:28:18 +0000 (10:28 -0700)]
mesh: Convert crypto to use ELL wrappers

Use ELL implementations of aead-ccm(aes), ecb(aes) and cmac(aes). These
standard encryption and hashing routines are provided by ELL.

Change-Id: I4c82199cf8a58c6a09de8a8afcc74bb3cf584376
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Fix long MIC usage in segmented messages
Jakub Witowski [Fri, 24 May 2019 14:48:10 +0000 (07:48 -0700)]
mesh: Fix long MIC usage in segmented messages

Contrary to the comment, implementation used a 8-byte MIC even if this
generated an additional segment.

Change-Id: I7e718efbe401a3312871f2a4567050dc1805a508
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Implement remote dev key methods for keyring
Brian Gix [Fri, 24 May 2019 14:48:09 +0000 (07:48 -0700)]
mesh: Implement remote dev key methods for keyring

Implements following org.bluez.mesh.Management1 methods:
ImportRemoteNode()
DeleteRemoteNode()

These methods are used to maintain Device Key keyring storage.

Change-Id: I8ea4508ca9e2717e0f2779ebff88ce0b2fa9c0a8
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Implement Key Refresh Phasing in keyring
Brian Gix [Fri, 24 May 2019 14:48:08 +0000 (07:48 -0700)]
mesh: Implement Key Refresh Phasing in keyring

Implements following org.bluez.mesh.Management1 methods:
CompleteAppKeyUpdate()
SetKeyPhase()

These methods are used to maintain Key Refresh settings
in the keyring storage.

Change-Id: Ic987cbb477710b35af4c40b5de60466a8ff2cdd8
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Implement App Key keyring storage handling
Brian Gix [Fri, 24 May 2019 14:48:07 +0000 (07:48 -0700)]
mesh: Implement App Key keyring storage handling

Implements following org.bluez.mesh.Management1 methods:
CreateAppKey()
ImportAppKey()
UpdateAppKey()
DeleteAppKey()

These methods are used to maintain App Key keyring storage.

Change-Id: I16cf6fb5e503e8474f35f383e8a7129cf4aae335
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Implement Net Key keyring storage handling
Brian Gix [Fri, 24 May 2019 14:48:06 +0000 (07:48 -0700)]
mesh: Implement Net Key keyring storage handling

Implements following org.bluez.mesh.Management1 methods:
CreateSubnet()
ImportSubnet()
UpdateSubnet()
DeleteSubnet()

These methods are used to maintain Net Key keyring storage.

Change-Id: Iff079138608495589063efb57571118975bbe281
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Centralize definition of PRIMARY_NET_IDX
Brian Gix [Fri, 24 May 2019 14:48:05 +0000 (07:48 -0700)]
mesh: Centralize definition of PRIMARY_NET_IDX

Change-Id: I8982c1b778f4990d425e3eed9160fbcaeca5dc85
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Add new method for Key Refresh procedure
Brian Gix [Fri, 24 May 2019 14:48:04 +0000 (07:48 -0700)]
mesh: Add new method for Key Refresh procedure

This adds a new method CompleteAppKeyUpdate() on
org.bluez.mesh.Management1 interface to be used by the application
at the completion of a Key Refresh procedure. This method should
be called for each app key that is being updated during the
procedure, and must be performed prior to changing the phase of
the bound net key to phase 3.

Change-Id: I7bb869c9af78c58df0d567c745026b59fef97ce8
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomeshctl: Retry recvmsg if data is not ready
Steve Brown [Tue, 21 May 2019 20:03:13 +0000 (16:03 -0400)]
meshctl: Retry recvmsg if data is not ready

Commit d6eec1b67d6d ("meshctl: Switch from write to sendmsg for Acquire*")
causes a regression by returning an error if recvmsg has no data available.
Fix it by retrying until data is received.

Change-Id: I9f950f4ac7688dc3b89ccdc940f3ba60bc781737
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Remove unnecessary includes from .c files
Inga Stotland [Wed, 15 May 2019 19:00:19 +0000 (12:00 -0700)]
mesh: Remove unnecessary includes from .c files

Change-Id: Ifb8be3d309ad1a99b9397f608d9fe1023d6480d8
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Update copyright dates
Inga Stotland [Wed, 15 May 2019 19:00:18 +0000 (12:00 -0700)]
mesh: Update copyright dates

Change-Id: I66dc7b41b7b09e22b57624493647fe286101e984
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Save generated Net and Dev keys in KeyRing
Brian Gix [Wed, 15 May 2019 16:34:17 +0000 (09:34 -0700)]
mesh: Save generated Net and Dev keys in KeyRing

When creating a network from scratch, we need to save all
keys that are created into the KeyRing for use by Config
Client application.

Change-Id: I477c99dbab5973c34059bb63a5b0576034b8b3b4
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Fix file open error checking and permissions
Brian Gix [Wed, 15 May 2019 16:34:16 +0000 (09:34 -0700)]
mesh: Fix file open error checking and permissions

Change-Id: Ie3836862c91e779fc208b920071aa970d9681bc3
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Add "create" command to test app
Brian Gix [Wed, 15 May 2019 16:34:15 +0000 (09:34 -0700)]
mesh: Add "create" command to test app

Like "join" this command generates a UUID and calls CreateNetwork()
and displays the UUID and token.

Change-Id: I5e28c5ae4acd85fa1547c7f21933bd851f765424
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Add skeleton for org.bluez.mesh.Management1 interface
Inga Stotland [Tue, 14 May 2019 22:54:07 +0000 (15:54 -0700)]
mesh: Add skeleton for org.bluez.mesh.Management1 interface

This adds bare-bones imlementation of methods on org.bluez.mesh.Management1
interface.

Change-Id: If6a00b26a5f5732e005f3ba2ca6f1fb2015dee10
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Add check for org.bluez.mesh.Provisioner1 interface
Inga Stotland [Tue, 14 May 2019 22:54:06 +0000 (15:54 -0700)]
mesh: Add check for org.bluez.mesh.Provisioner1 interface

This adds check for the presence of org.bluez.mesh.Provisioner1
interface when collecting information about mesh application
that is received in callback of GetManagedObjects() method.
Set "provisioner" flag in the node structure to trueto indicate
that the node may act aa a provisioner.

Change-Id: I599740694dde48955e2492acf13d3812d5938828
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Add key storage
Brian Gix [Thu, 9 May 2019 21:33:21 +0000 (14:33 -0700)]
mesh: Add key storage

This implements internal key storage add/delete/fetch for the three
basic key types managed in Mesh: Network, Application and Device.

This key storage is separate from keys assigned to nodes within the
mesh, and are used to support Configuration Client functionality.

Change-Id: Ie582b6c0de2ed81c3b9e35cd5f1fc63674be2334
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Reconfigure node storage tree
Brian Gix [Thu, 9 May 2019 21:33:20 +0000 (14:33 -0700)]
mesh: Reconfigure node storage tree

Add a tree structure to a nodes data storage, in order to safely handle
Replay Protection list, Refactor local Sequence Numbers, and add Key
storage for Config Client nodes.

Change-Id: Ib66ad23430b8fc6c4864f83a69c3afb6ed10b9bf
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Add CreateNetwork method() implementation
Inga Stotland [Wed, 8 May 2019 21:50:08 +0000 (14:50 -0700)]
mesh: Add CreateNetwork method() implementation

This implements CreateNetwork() method on org.bluez.mesh.Network1
interface. Invoking this method generates a self-provisioned
local node associated with a brand new mesh network. This new
network is bare bones: only one network key is defined. The new node
assumes the role of mesh network manager and will be able to use
soon to be implemented methods of org.bluez.mesh.Management1 interface
to provision remote nodes into its network and to add/update/remove
network and application keys.

Change-Id: I2b4e37e98582a272fba9c421c010691a1e921db3
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Use node uuids as storage directory names
Michał Lowas-Rzechonek [Wed, 8 May 2019 14:24:45 +0000 (16:24 +0200)]
mesh: Use node uuids as storage directory names

Instead of keeping track of unique 16bit node identifiers, reuse their
UUIDs to create both storage directories and dbus objects.

Because of that:
 - UUID is no longer stored in the JSON file, it's inferred from the
   directory name instead
 - Join(), CreateNetwork() and ImportLocalNode() APIs return an error if
   given UUID already registered within the daemon

Change-Id: I86032691fa81003c5503880c4bbf9a76aa7bd26e
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Unify processing of GetManagedObjects result
Inga Stotland [Mon, 29 Apr 2019 19:45:09 +0000 (12:45 -0700)]
mesh: Unify processing of GetManagedObjects result

This combines processing of results obtained from GetManagedObjects
request for both Attach() and Join() methods

Change-Id: I4cfc035f5433c4946d9e7eeaf0fdc5298b4b33ed
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Consolidate processing of mesh element properties
Inga Stotland [Mon, 29 Apr 2019 19:45:08 +0000 (12:45 -0700)]
mesh: Consolidate processing of mesh element properties

Consolidate functions to parse and process properties of mesh
element objects. Also, add validation of element composition
when processing Attach() method.

Change-Id: I34fd3db467c75fe80e61e79801e096eeb233136b
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Clean up processing of Attach() method
Inga Stotland [Mon, 29 Apr 2019 19:45:07 +0000 (12:45 -0700)]
mesh: Clean up processing of Attach() method

This changes the prototype for the callback function of
Attach() method call: remove unused node_path argument and make the
callback more generalized and re-usable for other method calls.

Change-Id: I6aab7fb6a8afdd32e14f785cb09f15dfbf021816
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Remove Node interface if node owner disconnects
Inga Stotland [Mon, 29 Apr 2019 19:45:06 +0000 (12:45 -0700)]
mesh: Remove Node interface if node owner disconnects

This unregisters Node interface associated with a specific node
application when this application disconnects from D-Bus.

Change-Id: Ia01f2b898e2a79c54433fcf6ed46467166aff815
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Add APIs for Provisioner and Config Client
Brian Gix [Thu, 18 Apr 2019 22:15:18 +0000 (15:15 -0700)]
mesh: Add APIs for Provisioner and Config Client

The added D-Bus APIs enable Applications to function in a Provisioner
Initiator role, and as a Configuration Client.

Change-Id: I9d038b7fded415a3a43e5d41f5c94218fce96e9a
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Fix the cleanup of failed Join call
Inga Stotland [Thu, 18 Apr 2019 04:33:32 +0000 (21:33 -0700)]
mesh: Fix the cleanup of failed Join call

This fixes the accidental swap of conditional checks: on failure,
remove agent info if agent is registered and remove temporary node,
if one has been created.

Change-Id: Ied17e66039641c6133ee3f83e687e9adcff6b22a
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Fix structure memeber initialization
Inga Stotland [Mon, 22 Apr 2019 15:25:55 +0000 (08:25 -0700)]
mesh: Fix structure memeber initialization

This fixes incorrectly reversed assignment of "friend" value in
convert_node_to_storage()

Change-Id: Ief74507a1aa41b3376f42d8ee1d3beccf85fa218
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Allow only one app attachment per node
Inga Stotland [Mon, 22 Apr 2019 04:51:11 +0000 (21:51 -0700)]
mesh: Allow only one app attachment per node

If a node is already attached to an application process,
disallow another appication to attach to the same node.
This means that an Attach() method called with the token
identifying a node that is already in use, returns an error
org.bluez.mesh.Error.AlreadyExists

Change-Id: Ifde6a2c13ed5d0c044086c58bbb5013fe9f8eb59
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agotest: Enable test-mesh to send raw vendor commands
Inga Stotland [Thu, 18 Apr 2019 06:31:10 +0000 (23:31 -0700)]
test: Enable test-mesh to send raw vendor commands

This adds a sample vendor model to the first element of the
mesh node. A new menu entry allows to generate and send a raw
vendor command.

Change-Id: Ic620c0f39e44a414b4ef89938026582f2305c2bd
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agotest: Drive test-mesh with a string-based menu
Inga Stotland [Thu, 18 Apr 2019 06:31:09 +0000 (23:31 -0700)]
test: Drive test-mesh with a string-based menu

Switch to  string interactive commands to drive testing
of bluetooth-meshd. Re-work the menu to allow global setting of
destination address and AppKey index for outbound mesh messages.

Change-Id: Id9d8eb5b8b8d8b439ff6f00c6db583f7638af616
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Fix network information cleanup
Inga Stotland [Thu, 18 Apr 2019 04:13:06 +0000 (21:13 -0700)]
mesh: Fix network information cleanup

This fixes issues caused by accessing invalidated entries of nets
queue that were left around when removing network info in
mesh_net_detach()

Change-Id: Ic19c0232cbb095a658b8be56ea06f989d07dabfb
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Fix decryption when on more than one Network
Brian Gix [Mon, 15 Apr 2019 21:16:44 +0000 (14:16 -0700)]
mesh: Fix decryption when on more than one Network

Multiple networks use different IV Index's, so we should only use
decryption cache after successful decoding.

Change-Id: Iddd0841de1471e1f4682aa243ede503747f63bd7
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Create and store random token per node
Brian Gix [Thu, 4 Apr 2019 22:43:14 +0000 (15:43 -0700)]
mesh: Create and store random token per node

Fix issue with device key being used as a token. Token now seperate, and
with a portable representation in the node database.

Change-Id: Iefeaaf2c424e4fd03772be990a7f0ac382df57ea
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Store node state variables prior to response
Brian Gix [Thu, 21 Mar 2019 20:55:18 +0000 (13:55 -0700)]
mesh: Store node state variables prior to response

Remotely set node state variables need to be saved to the file system
or other NVM prior to returning success status.

Change-Id: I1fc365fbb082e218319526becc02078b3a112ba1
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Fix json-c calling conventions
Brian Gix [Thu, 21 Mar 2019 20:55:17 +0000 (13:55 -0700)]
mesh: Fix json-c calling conventions

Fix issue assuming that failed calls to json_object_object_get_ex() will
always NULL the out parameter. Re-coded to always check the returned
boolean for success or failure.

Change-Id: Ia9f1bb85b443c5b17e8e7e9ddee35f2beca2b763
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Fix adding model app key binding
Inga Stotland [Fri, 22 Mar 2019 02:26:10 +0000 (19:26 -0700)]
mesh: Fix adding model app key binding

This fixes the situation when a new app key binding is being
added to a model and the list of bindings does not exist yet.
If the list does not exist, it is created and the binding is
added to it.

Also, remove unnecessary memory alloc check when model subscriptions
are added.

Change-Id: I3ee84aefee6acdc45f2c12e5a65c70e9f19669fd
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Correctly initialize node's vendor models
Inga Stotland [Thu, 21 Mar 2019 07:32:40 +0000 (00:32 -0700)]
mesh: Correctly initialize node's vendor models

This fixes vendor model initialization based on node properties
collected during Join() method call.

Change-Id: Ie7fc4c004717a86086db323d86e1d113a20c03b3
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Fix bug with adding more than one app key
Stotland, Inga [Mon, 11 Mar 2019 19:00:01 +0000 (12:00 -0700)]
mesh: Fix bug with adding more than one app key

Fixed problem where if the appKeys array already exists, that
new add key requests were rejected.

Change-Id: I416c2b2848ea15e53f9c2ddc168dc928d455466e
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agotest: Add unified test for mesh node example app
Inga Stotland [Sun, 10 Mar 2019 07:53:13 +0000 (23:53 -0800)]
test: Add unified test for mesh node example app

This adds one script, test-mesh, to replace three test-join,
example-onoff-server and example-onoff-client.
This is menu driven test that allows provisioning (join) and/or
connecting existing (attach) nodes.

Change-Id: Id102fcdc3ee9d4809d12f8b799dfc953341fe114
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Store model publication settings in config file
Inga Stotland [Fri, 8 Mar 2019 22:58:20 +0000 (14:58 -0800)]
mesh: Store model publication settings in config file

This adds functionality to enable storing model publication
parameters in node configuration file.

Also, fix calculations of model publication period.

Change-Id: I85c14f623f3b75e0744ed8dc78b55d0150f4b3b8
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Save model subscription updates to config file
Inga Stotland [Fri, 8 Mar 2019 22:58:19 +0000 (14:58 -0800)]
mesh: Save model subscription updates to config file

This adds functionality in Config Server model to save changes in
node configuration file when model subscriptions are added, deleted or
overwritten.

Change-Id: I2f949cca75a86ef2605eea1bd2dcfd325d4726f2
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Add json config functions to save pub/sub updates
Inga Stotland [Fri, 8 Mar 2019 22:58:18 +0000 (14:58 -0800)]
mesh: Add json config functions to save pub/sub updates

This adds functions to save updates to model subscriptions and
publication in JSON format.

Change-Id: I5f34ae2f596a7d1c97f887ac6211d206fee9d4fd
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Set node ID for a newly provisioned node
Inga Stotland [Fri, 8 Mar 2019 22:56:34 +0000 (14:56 -0800)]
mesh: Set node ID for a newly provisioned node

When a new node is created after successful provisioning, a 4-digit
hex node id needs to be generated and preserved.

Change-Id: Ia1e85e14d6e5fa90464f0f4ce4216ce903e7bd43
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Enable local loopback
Brian Gix [Fri, 8 Mar 2019 22:40:16 +0000 (14:40 -0800)]
mesh: Enable local loopback

Implements mechanism to allow direct messaging between local
nodes without requiring an external relay node.

Change-Id: I7f7eac5194cebd126be689178af18d390bdf6a0a
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Fix array processing in Send, Publish, Join
Inga Stotland [Fri, 1 Mar 2019 23:53:15 +0000 (15:53 -0800)]
mesh: Fix array processing in Send, Publish, Join

Use correct parameters when calling l_dbus_message_iter_get_fixed_array().
Also, check the return value and the length of the processed array and
return an error if the checks fail.

Change-Id: I8c4f4ad5ea9a1596782e606a01c849e374cc2d84
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agodoc/mesh-api: Fix Attach() method signature
Inga Stotland [Thu, 28 Feb 2019 23:24:56 +0000 (15:24 -0800)]
doc/mesh-api: Fix Attach() method signature

Correct return arguments for Attach() method.
Also, fix some grammar and formatting.

Change-Id: I699ee4cf6ed323a5837b944b9c3dc7940fc221ef
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Implement Leave() method on Network interface
Inga Stotland [Fri, 22 Feb 2019 06:31:48 +0000 (22:31 -0800)]
mesh: Implement Leave() method on Network interface

This implements D-Bus Leave() method that results in complete removal
of node information from the system, including configuration files
from storage directory.

Change-Id: I0ff0c49e768bd3a04f8e8d10a59b91b20562c43a
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Cleanup storage save and remove procedures
Inga Stotland [Fri, 22 Feb 2019 06:31:47 +0000 (22:31 -0800)]
mesh: Cleanup storage save and remove procedures

To remove a node config directory completely, the directory
needs to be empty. Both node.json and node,json.bak files must
are deleted.

Also, change storage_save_config() type to void to eliminate
meaningless checks.

Change-Id: Idacf96ed74e8b4818dea061efbe242107df8cdac
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Re-arrange node cleanup functions
Inga Stotland [Fri, 22 Feb 2019 06:31:46 +0000 (22:31 -0800)]
mesh: Re-arrange node cleanup functions

Rename node_free() to node_remove() and consolidate clean up operations.
Change declarations for internally used functions to static.

Change-Id: I22aba42a8c1d7632a8f8dc1bb81ceb92caaa70da
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Fix type checking for 32 vs 64 bit systems
Brian Gix [Wed, 27 Feb 2019 18:12:55 +0000 (10:12 -0800)]
mesh: Fix type checking for 32 vs 64 bit systems

Change-Id: I3636c1633d504f0bc4f04b8068503453cc111938
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Fix for file naming convention
Brian Gix [Wed, 20 Feb 2019 23:21:42 +0000 (15:21 -0800)]
mesh: Fix for file naming convention

Change-Id: I8a1ffd35187be78936194737105fa749fb32a528
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Return correct error code for AppKey List command
Inga Stotland [Thu, 14 Feb 2019 03:45:27 +0000 (19:45 -0800)]
mesh: Return correct error code for AppKey List command

If AppKey List command is called with a network key index that
is not valid for the node, return Invalid NetKey Index error code

Change-Id: I77e4065e710b536ba641fd49ca2eeb5b5d7e47be
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Save newly added or updated app key to config file
Inga Stotland [Thu, 14 Feb 2019 03:45:26 +0000 (19:45 -0800)]
mesh: Save newly added or updated app key to config file

This separates mesh_db_app_key_add() into distinct functions:
mesh_db_app_key_add() and mesh_db_app_key_update() which will be called
based on whether an application key is newly added or updated.

Change-Id: I897fe6ba17c4994f55c6514fb3c9e5e4602835e3
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Separate functions for app key add and update
Inga Stotland [Thu, 14 Feb 2019 03:45:25 +0000 (19:45 -0800)]
mesh: Separate functions for app key add and update

This splits appkey_key_add() into two separate functions:
app_key_add() and app_key_update().
Fix checks for miscellaneous invalid conditions and return
appropriate error status.

Change-Id: I938afa1eb355337f43b3c2e4f23205edbb7c3834
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Use l_malloc instead of l_new with a cast
Marcel Holtmann [Sat, 16 Feb 2019 07:23:43 +0000 (08:23 +0100)]
mesh: Use l_malloc instead of l_new with a cast

Change-Id: Ie2308b4cf1a15428aefe65e39c21df6da2627006
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Use PRIx64 instead of %16.16lx
Marcel Holtmann [Sat, 16 Feb 2019 07:00:08 +0000 (08:00 +0100)]
mesh: Use PRIx64 instead of %16.16lx

Change-Id: I11f0e5ebc81e4b20abd0747a9c578a70afb0fe1e
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Save newly added or updated net key to config file
Inga Stotland [Thu, 7 Feb 2019 03:55:37 +0000 (19:55 -0800)]
mesh: Save newly added or updated net key to config file

This separates mesh_db_net_key_add() into distinct functions:
mesh_db_net_key_add() and mesh_db_net_key_update() which will be called
based on whether a network key was newly added or updated.

Change-Id: I7af60c622c39f813a5aab64b5ae936943a1cfcb8
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Save key refresh phase state to node config file
Inga Stotland [Thu, 7 Feb 2019 03:55:36 +0000 (19:55 -0800)]
mesh: Save key refresh phase state to node config file

This adds implementation for saving the key refresh phase to
a node configuration file in JSON format. When the key refresh
procedure is finished, the old network keys are remove from the
configuration file.

Change-Id: I33341489ae538cf9734c0a68025865d53f49548f
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Declare internal functions as static
Inga Stotland [Thu, 7 Feb 2019 03:55:35 +0000 (19:55 -0800)]
mesh: Declare internal functions as static

This renames mesh_net_key_refresh_finish() to key_refresh_finish() and
mesh_net_key_phase_two() to key_refresh_phase_wo() and changes the
function declaration to static since they are called only within net.c

Change-Id: Ic24e0f6168bd2407d29f786d5664368d721015a3
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Add function to restore net key state from storage
Inga Stotland [Thu, 7 Feb 2019 03:55:34 +0000 (19:55 -0800)]
mesh: Add function to restore net key state from storage

This creates subnet state based on saved network key state:
current keys and, if present, updated keys.
Secure network beacon is generated according to key refresh phase.

Change-Id: I3f89ffb8181afc5d66966ee8e369125875a2c262
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Separate functions for net key add and update
Inga Stotland [Thu, 7 Feb 2019 03:55:33 +0000 (19:55 -0800)]
mesh: Separate functions for net key add and update

This splits mesh_net_key_add() into two separate functions:
mesh_net_key_add() and mesh_net_key_update().
mesh_net_key_update() essentially replaces mesh_net_kr_phase_one()
since switching to Key Refresh phase one can only be triggered
by successful network key update.

Change-Id: I9be2f9784ebb094906107bd8923694199e0900f3
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agoTODO: Fix complexity level for Bluetooth mesh items
Inga Stotland [Mon, 4 Feb 2019 23:31:01 +0000 (15:31 -0800)]
TODO: Fix complexity level for Bluetooth mesh items

Change-Id: Ib90ce697f36c7bdffb07ebf13049ad00effa27cc
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Add D-Bus policy for Bluetooth mesh daemon
Inga Stotland [Sat, 19 Jan 2019 03:58:37 +0000 (19:58 -0800)]
mesh: Add D-Bus policy for Bluetooth mesh daemon

This adds new D-Bus policy file bluetooth-mesh.conf

Change-Id: I39bdf73540f11ee60f09cbf17e4b8490c7b2ccf3
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Rename mesh daemon executable to bluetooth-meshd
Inga Stotland [Sat, 19 Jan 2019 03:58:36 +0000 (19:58 -0800)]
mesh: Rename mesh daemon executable to bluetooth-meshd

Change-Id: Iba5efaeeda8de4e5fe569cc5616f1e0fca5c2b55
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agoTODO: Add Bluetooth mesh items
Inga Stotland [Mon, 4 Feb 2019 19:15:34 +0000 (11:15 -0800)]
TODO: Add Bluetooth mesh items

Change-Id: I27f947041a9b3a9614786728b112d8a9864c83fb
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Remove unnecessary variable initialization
Inga Stotland [Sat, 2 Feb 2019 06:49:35 +0000 (22:49 -0800)]
mesh: Remove unnecessary variable initialization

Change-Id: Ie8728738b7c4a372008d7ce3863f2f4be4fdc6d3
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Add README file
Inga Stotland [Fri, 1 Feb 2019 00:22:41 +0000 (16:22 -0800)]
mesh: Add README file

    This file contains instructions for Bluetooth mesh daemon
    configuration and description of the persistent storage.

Change-Id: I7db9c5dd9662c571f1a22e8116f06adf3c041d3a
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Add MGMT bypass when specifying controller
Brian Gix [Thu, 31 Jan 2019 20:50:22 +0000 (12:50 -0800)]
mesh: Add MGMT bypass when specifying controller

If Daemon is started with an explicit controller specified, the
MGMT search for an unused shared controller is bypassed, and
the controller is opened directly.

Change-Id: I204b0db6ff185fade58bc9bd4d4fb6556920e22b
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Fix logic when cleaning up incomplete provisioning
Inga Stotland [Sat, 19 Jan 2019 06:53:18 +0000 (22:53 -0800)]
mesh: Fix logic when cleaning up incomplete provisioning

Do not call acceptor_cancel() if the provisioning has been completed,
either fail or success. Acceptor automatically takes care of cleanup
on completion, either successful or not.

4 years agomesh: Fix Relaying for multiple nodes
Brian Gix [Fri, 18 Jan 2019 17:39:44 +0000 (09:39 -0800)]
mesh: Fix Relaying for multiple nodes

Relay is now a cooperation between all the nodes on the daemon.
If any one or more nodes have relay enabled and a received packet
is addressed to a Group, or a non-present Unicast address, then the
packet's TTL is decremented and it is resent.

Change-Id: I27d5555a9d530fc91a0c8f835feba9f2563ff68d
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Cleanup PB-ADV transport on Prov Close
Brian Gix [Mon, 14 Jan 2019 22:52:15 +0000 (14:52 -0800)]
mesh: Cleanup PB-ADV transport on Prov Close

PB-ADV always used for provisioning, so must always  be cleaned up.

Change-Id: I37bc5f68e032b32942b0e909d3836d260a5c2f1e
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Clean up when finishing the Join call
Inga Stotland [Sat, 12 Jan 2019 02:40:55 +0000 (18:40 -0800)]
mesh: Clean up when finishing the Join call

Consolidate multiple instances where the pending Join data is freed
into calling one function free_pending_join_call().

Also, add checks for NULL data in cleanup functions for storage, agent
and provisioning acceptor.

Change-Id: I7a93d4f003f090f705be2f1f7af96349d10bdd1c
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
4 years agomesh: Fix reading device UUID from Join() call
Inga Stotland [Sat, 12 Jan 2019 02:40:54 +0000 (18:40 -0800)]
mesh: Fix reading device UUID from Join() call

Supply correct parameters to l_dbus_message_iter_get_fixed_array
to get the location from where to read UUID value.

Change-Id: I0e2af0142882efb4d1079953a2a380dd9606dbdd
Signed-off-by: Anupam Roy <anupam.r@samsung.com>