Make escaping work properly with non-ASCII UTF-8 strings

Basically, we need to only unescape \ and " otherwise things won't
work with non-ASCII characters.

https://bugs.freedesktop.org/show_bug.cgi?id=48502

Signed-off-by: David Zeuthen <davidz@redhat.com>

Add udev rules for identifying devices which should not be shown

Copied from udisks1 branch, see

 http://cgit.freedesktop.org/udisks/tree/data/80-udisks.rules?h=udisks1&id=1.0.4#n178

and adjusted to use the partition properties set by blkid and to use
UDISKS_IGNORE instead of UDISKS_PRESENTATION_HIDE.

Signed-off-by: David Zeuthen <davidz@redhat.com>

Fix unmounting large disks when not asked to

udisks2 was "Cleaning up mount point" claiming the device no longer existed.
Disk size may be larger than INT_MAX for large disks.

https://bugs.freedesktop.org/show_bug.cgi?id=48155

Signed-off-by: David Zeuthen <davidz@redhat.com>

Convert some g_warning() uses to udisks_warning()

Signed-off-by: David Zeuthen <davidz@redhat.com>

Change some D-Bus types from bytestring ('ay') to UTF8 ('s')

We are 100% sure that the changed items are always UTF-8 especially
because udisks_device_udev_string() guarantees this and this function
is used before setting the affected properties.

This breaks the D-Bus API but there is no change in the libudisks2.so
ABI since byte-strings and UTF-8 strings are mapped the same way when
GDBus is being used. It may require restarting the system, but apart
from that there is minimal interference from this change.

The remaining byte-strings in the API are things that either comes
from configuration files (such as /etc/fstab and /etc/crypttab), the
kernel (e.g. sysfs paths) or udev rules (e.g. device symlinks). We
could require UTF-8 here and just reject items that are not valid
UTF-8 but there's really no point in that.

Signed-off-by: David Zeuthen <davidz@redhat.com>

Clarify docs for Filesystem.Mount() and Filesystem.Unmount()

Signed-off-by: David Zeuthen <davidz@redhat.com>

Update docs

Signed-off-by: David Zeuthen <davidz@redhat.com>

Fix how we sign the tarballs

This mistake was pointed out by Adam Sampson <ats@offog.org>, thanks
for noticing!

Signed-off-by: David Zeuthen <davidz@redhat.com>

Pass --readonly to cryptsetup(8) if device to unlock is read-only

With this fix, locked SD cards with LUKS now work.

Signed-off-by: David Zeuthen <davidz@redhat.com>

Post-release version bump to 1.94.0

Signed-off-by: David Zeuthen <davidz@redhat.com>

Update NEWS for release

Signed-off-by: David Zeuthen <davidz@redhat.com>

Tweak the docs some

Signed-off-by: David Zeuthen <davidz@redhat.com>

Properly escape all device files

At least in the default install, udev never includes a space or quote
in the device file but better safe than sorry.

Signed-off-by: David Zeuthen <davidz@redhat.com>

Ensure that the loop file name we pass to the kernel is always NUL-terminated

Signed-off-by: David Zeuthen <davidz@redhat.com>

Ensure that whatever we pass as -t to mount(8) is in a whitelist

IOW, ensure that you can't pass e.g. 'nfs../blah' to load the whole NFS
stack. Now we error out, like this

 $ udisksctl mount --block-device /dev/sdc3 -t nfs../blah
 Error mounting /dev/sdc3: GDBus.Error:org.freedesktop.UDisks2.Error.OptionNotPermitted: Requested filesystem type `nfs../blah' is neither well-known nor in /proc/filesystems nor in /etc/filesystems

This is a bug that was already fixed for udisks 1.x, see

 https://bugs.freedesktop.org/show_bug.cgi?id=32232
 CVE-2010-4661: Arbitrary kernel module load

But we apparently forgot to fix this in the move from udisks 1.x to
2.x. Pointed out by Sebastian Krahmer <krahmer@suse.de>, thanks!

Signed-off-by: David Zeuthen <davidz@redhat.com>

Force MediaRemovable to TRUE for e.g. SD cards using the mmc layer

Otherwise udisks_client_get_drive_info() will return

 drive-removable-media-flash-sd

for /dev/mmcblk0p1 instead of

 media-flash-sd

and we want the latter.

Signed-off-by: David Zeuthen <davidz@redhat.com>

Run gtkdoc-rebase to fix up links for GLib types

Signed-off-by: David Zeuthen <davidz@redhat.com>

Add a section about /org/freedesktop/UDisks2/jobs/* objects

Signed-off-by: David Zeuthen <davidz@redhat.com>

Add a section about /org/freedesktop/UDisks2/drives/* objects

Signed-off-by: David Zeuthen <davidz@redhat.com>

Reword the section about block device objects a little bit

Signed-off-by: David Zeuthen <davidz@redhat.com>

Add a section about /org/freedesktop/UDisks2/block_devices/* objects

Signed-off-by: David Zeuthen <davidz@redhat.com>

Don't include sys/acl.h - it's not needed

Signed-off-by: David Zeuthen <davidz@redhat.com>

Post-release version bump to 1.93.0

Signed-off-by: David Zeuthen <davidz@redhat.com>

Update NEWS for release

Signed-off-by: David Zeuthen <davidz@redhat.com>

Move to /usr-only setup and get rid of hardcoded paths to /lib and sbin

With the whole OS in /usr, tricks like these are no longer
needed. Howver, distros with different content in e.g. /sbin and
/usr/sbin will have to move things like the /usr/sbin/umount.udisks2
binary themselves etc.

Signed-off-by: David Zeuthen <davidz@redhat.com>

client: Fix bit shifts of flags on 32 bit

Also, the flags should be unsigned, not signed.

Signed-off-by: David Zeuthen <davidz@redhat.com>

Use /run/media/$USER for mounting

Also use ACLs on the $USER sub-directory so only $USER (and not any
other user) can access the mounted filesystem.

Signed-off-by: David Zeuthen <davidz@redhat.com>

Don't free object twice when deleting a loop device

Duh!

Signed-off-by: David Zeuthen <davidz@redhat.com>

Avoid using $XDG_RUNTIME_DIR/media for now

Needs a bit more thought on the security side.

Signed-off-by: David Zeuthen <davidz@redhat.com>

Post-release version bump to version 1.92.0

Signed-off-by: David Zeuthen <davidz@redhat.com>

Update NEWS for release

Signed-off-by: David Zeuthen <davidz@redhat.com>

Fix a couple of uninitialized warnings and simplify SMART self-test handling

In particular, this fixes a crash when running a SMART self-test on a
drive and then yanking it.

Signed-off-by: David Zeuthen <davidz@redhat.com>

Shut up valgrind complaing about LOOP_GET_STATUS64 ioctl

Signed-off-by: David Zeuthen <davidz@redhat.com>

Use g_dbus_interface_dup_object() and check return value

This fixes potential (multi-threading related) problems where the
GDBusObject is removed just before or in the middle of handling a
call. Also bump required GLib version to (unreleased) 2.31.13 since
that's the version this API was introduced in.

Signed-off-by: David Zeuthen <davidz@redhat.com>

Do coldplug for block devices twice

Otherwise we may miss some associations between LUKS devices and other
block devices. This bug only became evident once we started sorting
block devices before processing them.

Signed-off-by: David Zeuthen <davidz@redhat.com>

Make sure that Drive:SortKey sorts e.g. sdz before sdaa

Also make sure that we e.g. process sdb before sdad to get
Drive:SortKey set using sdb rather than sdad.

With this change we get the expected output that corresponds to kernel
probing order. Which (on good days) may correspond to slot and
enclosure order.

MODEL                     REVISION  SERIAL               DEVICE
--------------------------------------------------------------------------
HP LOGICAL VOLUME         3.00      5001438008F61790     sda
SEAGATE ST3300657SS       0006      3SJ1S7K600009051M0CE sdad sdb
SEAGATE ST3300657SS       0006      3SJ1S4MH00009052RG6Z sdae sdc
SEAGATE ST3300657SS       0006      3SJ1RFP900009051HZ5S sdaf sdd
SEAGATE ST3300657SS       0006      3SJ1S66L00009052QGZA sdag sde
SEAGATE ST3300657SS       0006      3SJ1RPFJ00009052BZ10 sdah sdf
SEAGATE ST3300657SS       0006      3SJ1RWZ100009101T12H sdai sdg
SEAGATE ST3300657SS       0006      3SJ1S7C500009052RKPP sdaj sdh
SEAGATE ST3300657SS       0006      3SJ1S40K00009101T1XU sdak sdi
SEAGATE ST3300657SS       0006      3SJ1RJS700009050VYEA sdal sdj
SEAGATE ST3300657SS       0006      3SJ1RSJC00009052MWTB sdam sdk
SEAGATE ST3300657SS       0006      3SJ1QNMQ00009052NECM sdan sdl
SEAGATE ST3300657SS       0006      3SJ1S3NE00009101TB5Y sdao sdm
WDC WD1002FAEX-00Y9A0     01.01V10  WD-WCAW30012560      sdn
WDC WD1002FAEX-00Y9A0     01.01V10  WD-WCAW30064749      sdo
WDC WD1002FAEX-00Y9A0     01.01V10  WD-WCAW30039741      sdp
WDC WD1002FAEX-00Y9A0     01.01V10  WD-WCAW30064055      sdq
WDC WD1002FAEX-00Y9A0     01.01V10  WD-WCAW30030732      sdr
WDC WD1002FAEX-00Y9A0     01.01V10  WD-WCAW30010853      sds
WDC WD1002FAEX-00Y9A0     01.01V10  WD-WCAW30024753      sdt
WDC WD1002FAEX-00Y9A0     01.01V10  WD-WCAW30065104      sdu
WDC WD1002FAEX-00Y9A0     01.01V10  WD-WCAW30031826      sdv
WDC WD1002FAEX-00Y9A0     01.01V10  WD-WCAW30025874      sdw
WDC WD1002FAEX-00Y9A0     01.01V10  WD-WCAW30063724      sdx
WDC WD1002FAEX-00Y9A0     01.01V10  WD-WCAW30064486      sdy
WDC WD1002FAEX-00Y9A0     01.01V10  WD-WCAW30032003      sdz
WDC WD1002FAEX-00Y9A0     01.01V10  WD-WCAW30021345      sdaa
WDC WD1002FAEX-00Y9A0     01.01V10  WD-WCAW30067287      sdab
WDC WD1002FAEX-00Y9A0     01.01V10  WD-WCAW30014347      sdac

Signed-off-by: David Zeuthen <davidz@redhat.com>

udisksctl: sort the drives using Drive:SortKey for 'status' verb

Signed-off-by: David Zeuthen <davidz@redhat.com>

udisksctl: nuke PORT column in output of 'status' verb

Signed-off-by: David Zeuthen <davidz@redhat.com>

With /media and /run on tmfs, switch to temporary store for mounted-fs

Signed-off-by: David Zeuthen <davidz@redhat.com>

Prefer mounting in /run/user/$USER/media instead of /media

Signed-off-by: David Zeuthen <davidz@redhat.com>

Fix .gir make dependencies

Make UDisks-2.0.gir build depend on libudisks2.la. This fixes parallel builds,
as well as ensures that the gir/typelibs are updated on any code change that
affects the library.

For mount options, switch from comment=udisks to x-udisks

Recent util-linux (2.21+) supports any x-* option.

Signed-off-by: David Zeuthen <davidz@redhat.com>

Fix 'make distcheck'

Signed-off-by: David Zeuthen <davidz@redhat.com>

Update POTFILES.in

Signed-off-by: David Zeuthen <davidz@redhat.com>

Use gobject-introspection Makefile

Signed-off-by: David Zeuthen <davidz@redhat.com>

Add targets for release management

Right now it's hard-coded for me but we can change that later if
needed etc.

Signed-off-by: David Zeuthen <davidz@redhat.com>

Add Transifex URL to README file

Signed-off-by: David Zeuthen <davidz@redhat.com>

Add Danish translation

This is just to check that the translations are actually being used
properly.

Signed-off-by: David Zeuthen <davidz@redhat.com>

Move polkit .policy file from policy/ to data/

Signed-off-by: David Zeuthen <davidz@redhat.com>

Also update the error name in D-Bus docs

Signed-off-by: David Zeuthen <davidz@redhat.com>

Use org.freedesktop.UDisks2.* for errors, not org.freedesktop.UDisks.*

This will break apps using the D-Bus library but will not break apps
using the libudisks2 library.

Signed-off-by: David Zeuthen <davidz@redhat.com>

Fix up doc page

Signed-off-by: David Zeuthen <davidz@redhat.com>

Remove copyright and license from docs and add link to online docs

Signed-off-by: David Zeuthen <davidz@redhat.com>

Add 2012 to copyright years

Signed-off-by: David Zeuthen <davidz@redhat.com>

Rename systemd service to udisks2 and fix a couple of typos

Signed-off-by: David Zeuthen <davidz@redhat.com>

Install a systemd service file if systemd is used

This makes dbus defer starting udisks to systemd instead of doing it
itself and thus puts the daemon under proper systemd supervision.

Can be disabled by passing --without-systemdsystemunitdir to configure

Signed-off-by: David Zeuthen <davidz@redhat.com>

Fix use of memset(3)

Pointed out here https://bugs.freedesktop.org/show_bug.cgi?id=45039

Signed-off-by: David Zeuthen <davidz@redhat.com>

Ensure PATH is set

Apparently PATH may be empty if activated by recent D-Bus daemons.

Signed-off-by: David Zeuthen <davidz@redhat.com>

Post-release version bump to version 1.91.0

Signed-off-by: David Zeuthen <davidz@redhat.com>

Update NEWS for release

Signed-off-by: David Zeuthen <davidz@redhat.com>

Fix typos in udisks(8) man page and reword a couple of things

Signed-off-by: David Zeuthen <davidz@redhat.com>

Clarify access control rules in udisks(8) man page

Signed-off-by: David Zeuthen <davidz@redhat.com>

Fix hints for PC floppy drives

Signed-off-by: David Zeuthen <davidz@redhat.com>

Don't accept a blank options string when adding/updating fstab entries

Signed-off-by: David Zeuthen <davidz@redhat.com>

Change how devices referenced in /etc/fstab and /etc/crypttab are handled

Hitherto we've required extra authorization (typically requiring the
user to authenticate as root) if a device is referenced in fstab or
crypttab and this actually limits the utility of these files -
e.g. why should the user need to authenticate as root just because
there are options in the fstab entry for the device? In fact, this
behavior is so annoying that people use e.g. the 'users' option for a
device which opens up extra security hole insofar that remote users
can now access the device.

Therefore, change the behavior so we treat fstab and crypttab devices
just like any other device, e.g. require the filesystem and
filesystem-system authorizations.

We also introduce options comment=udisks-auth [1] and x-udisks-auth
that can be used in fstab and crypttab respectively to force admin
authentication (the polkit actions in question are filesystem-fstab
encrypted-unlock-crypttab).

This has also been hooked up in GNOME's Disks
application

 http://people.freedesktop.org/~david/udisks-fstab-option-udisks-auth.png
 http://people.freedesktop.org/~david/udisks-crypttab-option-x-udisks-auth.png

Also mention this behavior in the udisks(8) man page.

Note that if a device is mounted at start-up, a user just can't
willy-nilly unmount the device - by default, he will still need to
authenticate as root in order to unmount the device (the polkit
action in question is 'filesystem-unmount-others')

[1] : this will be changed to x-udisks-auth when a future util-linux
release supporting arbitrary x-* options lands

Signed-off-by: David Zeuthen <davidz@redhat.com>

Just call it "fstab device" instead of "non-user fstab device"

Signed-off-by: David Zeuthen <davidz@redhat.com>

Add some safe and useful ntfs-3g allowed mount options

Remove invalid assertion that all managed mounts are in /media

This is not true as we support mounting items referenced in /etc/fstab.

Signed-off-by: David Zeuthen <davidz@redhat.com>

Don't set Drive:Ejectable to TRUE for floppy drives

Signed-off-by: David Zeuthen <davidz@redhat.com>

Adjust sort-key calculation

Signed-off-by: David Zeuthen <davidz@redhat.com>

Fix up how Drive:SortKey and Drive:TimeMediaDetected is calculated

Signed-off-by: David Zeuthen <davidz@redhat.com>

Add work-around for kernel devices not going on media removal if mounted

Signed-off-by: David Zeuthen <davidz@redhat.com>

Use reading/writing instead of backup/restore in authentication prompts

Signed-off-by: David Zeuthen <davidz@redhat.com>

Add convenience routines to get block devices by label and uuid

Signed-off-by: David Zeuthen <davidz@redhat.com>

Fix escaping issues when handling LABEL= and UUID= entries in fstab and crypttab

Signed-off-by: David Zeuthen <davidz@redhat.com>

Nuke debug spew

Signed-off-by: David Zeuthen <davidz@redhat.com>

Add some more thumb drive matches

Signed-off-by: David Zeuthen <davidz@redhat.com>

Support new ID_DRIVE_THUMB udev property and 'thumb' media type

This will also set Drive:Removable to FALSE to override what the
hardware (wrongly) reports. So also add new Drive:Ejectable property
since we still want to display an Eject icon for thumb drives.

Use the icon 'media-removable' for drives of this type.

http://people.freedesktop.org/~david/gdu2-ID_DRIVE_THUMB-support.png

Signed-off-by: David Zeuthen <davidz@redhat.com>

Force ReadOnly to TRUE for optical drives

At least do this until the kernel sets the 'ro' property properly.

Signed-off-by: David Zeuthen <davidz@redhat.com>

Fix loop device cleanup if backing device is not known

Signed-off-by: David Zeuthen <davidz@redhat.com>

Don't fail LoopSetup() because fstat(2) fails

With this change, this method now works with fds from a GVfs FUSE
mount (where not even uid 0 may open files on).

Signed-off-by: David Zeuthen <davidz@redhat.com>

Add Encrypted.ChangePassphrase() method

Signed-off-by: David Zeuthen <davidz@redhat.com>

Fix up docs

Signed-off-by: David Zeuthen <davidz@redhat.com>

Add Block.OpenForRestore() method

Signed-off-by: David Zeuthen <davidz@redhat.com>

Add Block.OpenForBackup() method used for creating disk images

See

 http://people.freedesktop.org/~david/gdu2-create-disk-image-1.png
 http://people.freedesktop.org/~david/gdu2-create-disk-image-2.png
 http://people.freedesktop.org/~david/gdu2-create-disk-image-3.png
 http://people.freedesktop.org/~david/gdu2-create-disk-image-4.png
 http://people.freedesktop.org/~david/gdu2-create-disk-image-5.png
 http://people.freedesktop.org/~david/gdu2-create-disk-image-6.png
 http://people.freedesktop.org/~david/gdu2-create-disk-image-7.png

Signed-off-by: David Zeuthen <davidz@redhat.com>

Don't cleanup loop devices if backing device has major 0

E.g. NFS mounts.

Signed-off-by: David Zeuthen <davidz@redhat.com>

Fix compile warning

Signed-off-by: David Zeuthen <davidz@redhat.com>

UDisksCleanup: Nuke error handling from user-level API

Signed-off-by: David Zeuthen <davidz@redhat.com>

Greatly simplify cleanup logic and routines

Signed-off-by: David Zeuthen <davidz@redhat.com>

Use /etc/bash_completion.d, not /etc/profile.d for bash completion script

Also use _DATA, not _SCRIPTS, to ensure that the installed file is not
executable.

Signed-off-by: David Zeuthen <davidz@redhat.com>

integration tests: small simplification

Introduce "no_options" constant for an empty options variant.

Use non-deprecated mutex and thread primitives in GLib 2.31 and later

Signed-off-by: David Zeuthen <davidz@redhat.com>

Add new Job:Objects property and set it

This can be used to render spinners, e.g.

 http://people.freedesktop.org/~david/gdu2-spinners.png

Signed-off-by: David Zeuthen <davidz@redhat.com>

Don't distribute generated sources in tarballs

... instead, insist that these sources are regenerated at build time.

Signed-off-by: David Zeuthen <davidz@redhat.com>

Update misc files

Signed-off-by: David Zeuthen <davidz@redhat.com>

Move udisks man page to section 8

... from section 7. This is to avoid conflicts with the udisks(7) man
page from udisks 1.x.

Signed-off-by: David Zeuthen <davidz@redhat.com>

Add shell-snippet showing how to update the ATA smart data

  gdbus call --system --dest org.freedesktop.UDisks2 \
             --object-path /org/freedesktop/UDisks2/drives/WDC_WD1002FAEX_00Y9A0_WD_WCAW30039835 \
             --method org.freedesktop.UDisks2.Drive.Ata.SmartUpdate \
             "{'atasmart_blob': <'$ATA_SMART_BLOB'>}"

Signed-off-by: David Zeuthen <davidz@redhat.com>

Add new Block:HintPartitionable property

This can be used in the UI to determine if a "Format Disk" (to
e.g. create a partition table) button should be offered.

Signed-off-by: David Zeuthen <davidz@redhat.com>

Add ReadOnly property to the Block interface

Signed-off-by: David Zeuthen <davidz@redhat.com>

Wipe device before formatting it

It's better to not trust various mkfs tools etc. to get it right.

Signed-off-by: David Zeuthen <davidz@redhat.com>