navin patidar [Sun, 10 Aug 2014 14:44:26 +0000 (20:14 +0530)]
staging: rtl8188eu: Remove unused function rtw_IOL_append_WD_cmd()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 10 Aug 2014 14:44:25 +0000 (20:14 +0530)]
staging: rtl8188eu: Remove unused function rtw_IOL_cmd_boundary_handle()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 10 Aug 2014 14:44:24 +0000 (20:14 +0530)]
staging: rtl8188eu: Remove unused function rtw_IOL_accquire_xmit_frame()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 10 Aug 2014 14:44:23 +0000 (20:14 +0530)]
staging: rtl8188eu: Hal8188EPhyCfg.h: Remove unused function declaration
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 10 Aug 2014 14:44:22 +0000 (20:14 +0530)]
staging: rtl8188eu: Remove unused function storePwrIndexDiffRateOffset()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 10 Aug 2014 14:44:21 +0000 (20:14 +0530)]
staging: rtl8188eu: Remove odm_RegConfig8188E.[h, c] files
driver doesn't require these files anymore.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 10 Aug 2014 14:44:20 +0000 (20:14 +0530)]
staging: rtl8188eu: Cleanup and simplify Baseband configuration code
Cleanup and consolidate Baseband configuration related code in
HalHWImg8188E_BB.c file.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 10 Aug 2014 14:44:19 +0000 (20:14 +0530)]
staging: rtl8188eu: Remove unused function odm_ConfigMAC_8188E()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 10 Aug 2014 14:44:18 +0000 (20:14 +0530)]
staging: rtl8188eu: Remove unused function odm_ConfigRFReg_8188E()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 10 Aug 2014 14:44:17 +0000 (20:14 +0530)]
staging: rtl8188eu: Remove unused functions odm_ConfigRF_Radio[A, B]_8188E()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 10 Aug 2014 14:44:16 +0000 (20:14 +0530)]
staging: rtl8188eu: Cleanup and simplify RF configuration code
Cleanup and consolidate RF configuration related code in
HalHWImg8188E_RF.c file.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 10 Aug 2014 14:44:15 +0000 (20:14 +0530)]
staging: rtl8188eu: Cleanup and simplify MAC configuration code
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 10 Aug 2014 14:44:14 +0000 (20:14 +0530)]
staging: rtl8188eu: Cleanup firmware initialization code
Using rtl8188ee's (drivers/net/wireless/rtlwifi/rtl8188ee/fw.c) neat and clean
firmware initialization code to replace rtl8188eu's messy firmware
initialization code.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jeremiah Mahler [Tue, 12 Aug 2014 07:03:44 +0000 (00:03 -0700)]
staging: rtl8192u/ieee80211: Fix sparse ieee80211_debug_init/_exit not declared warning
A sparse warning is generated about 'ieee80211_debug_init' and
'ieee80211_debug_exit' not being declared.
drivers/staging/rtl8192u/ieee80211/ieee80211_module.c:275:12: warning:
symbol 'ieee80211_debug_init' was not declared. Should it be static?
drivers/staging/rtl8192u/ieee80211/ieee80211_module.c:297:13: warning:
symbol 'ieee80211_debug_exit' was not declared. Should it be static?
These functions are used outside of this file so using static will not
work. The prototypes are given in r8192U_core.c but sparse nonetheless
still gives a warning. Fix the sparse warning by moving these
prototypes from r8192U_core.c to ieee80211.h.
Signed-off-by: Jeremiah Mahler <jmmahler@gmail.com>
Cc: Joel Pelaez Jorge <joelpelaez@gmail.com>
Cc: Andrea Merello <andrea.merello@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>
Cc: Joe Perches <joe@perches.com>
Cc: Himangi Saraogi <himangi774@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Cc: Ana Rey <anarey@gmail.com>
Cc: Chaitanya Hazarey <c@24.io>
Cc: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Teodora Baluta <teobaluta@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ovidiu Toader [Mon, 11 Aug 2014 03:04:36 +0000 (20:04 -0700)]
drivers/staging/rtl8192u/r8192U_wx.c: fix warnings issued by sparse
This minor patch motivated by eudyptula challenge fixes the following warnings issued
by `sparse' in drivers/staging/rtl8192u/r8192U_wx.c:
.../r8192U_wx.c:27:5: warning: symbol 'rtl8180_rates' was not declared. Should it be static?
.../r8192U_wx.c:961:22: warning: symbol 'r8192_get_wireless_stats' was not declared. Should it be static?
.../r8192U_wx.c:990:24: warning: symbol 'r8192_wx_handlers_def' was not declared. Should it be static?
Signed-off-by: Ovidiu Toader <ovi@phas.ubc.ca>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Sun, 10 Aug 2014 12:32:11 +0000 (14:32 +0200)]
Staging: bcm: Bcmchar.c: Renamed variable "uiOperation" -> "operation"
Renamed variable "uiOperation" -> "operation" in
bcm_char_ioctl_gpio_set_request().
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Sun, 10 Aug 2014 12:32:10 +0000 (14:32 +0200)]
Staging: bcm: Bcmchar.c: Renamed variable "uiBit" -> "bit"
Renamed variable "uiBit" -> "bit" in bcm_char_ioctl_gpio_set_request().
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Sun, 10 Aug 2014 12:32:09 +0000 (14:32 +0200)]
Staging: bcm: Bcmchar.c: Renamed variable "ucResetValue" -> "reset_val"
Renamed variable "ucResetValue" -> "reset_val" in
bcm_char_ioctl_gpio_set_request().
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Sun, 10 Aug 2014 12:32:08 +0000 (14:32 +0200)]
Staging: bcm: Bcmchar.c: Renamed variable "uiTempVar" -> "tmp"
Renamed variable "uiTempVar" -> "tmp" in
bcm_char_ioctl_reg_write_private()
bcm_char_ioctl_eeprom_reg_read()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Sun, 10 Aug 2014 12:32:07 +0000 (14:32 +0200)]
Staging: bcm: Bcmchar.c: Renamed variable "sWrmBuffer" -> "wrm_buff"
Renamed variable "sWrmBuffer" -> "wrm_buff" in
bcm_char_ioctl_reg_write_private()
bcm_char_ioctl_eeprom_reg_read()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Sun, 10 Aug 2014 12:32:06 +0000 (14:32 +0200)]
Staging: bcm: Bcmchar.c: Renamed variable "Bufflen" -> "buff_len"
Renamed variable "Bufflen" -> "buff_len" in
bcm_char_ioctl_reg_read_private().
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Sun, 10 Aug 2014 12:32:05 +0000 (14:32 +0200)]
Staging: bcm: Bcmchar.c: Renamed variable "IoBuffer" -> "io_buff"
Renamed variable "IoBuffer" -> "io_buff" in
bcm_char_ioctl_reg_read_private()
bcm_char_ioctl_reg_write_private()
bcm_char_ioctl_reg_write_private()
bcm_char_ioctl_eeprom_reg_read()
bcm_char_ioctl_gpio_set_request()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Sun, 10 Aug 2014 12:32:04 +0000 (14:32 +0200)]
Staging: bcm: Bcmchar.c: Renamed variable "sRdmBuffer" -> "rdm_buff"
Renamed variable "sRdmBuffer" -> "rdm_buff" in
bcm_char_ioctl_reg_read_private()
bcm_char_ioctl_reg_write_private()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Sun, 10 Aug 2014 12:32:03 +0000 (14:32 +0200)]
Staging: bcm: Bcmchar.c: Renamed variable "Packet" -> "packet"
Renamed variable "Packet" -> "packet" in bcm_char_read().
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Sun, 10 Aug 2014 12:32:02 +0000 (14:32 +0200)]
Staging: bcm: Bcmchar.c: Renamed variable "PktLen" -> "pkt_len"
Renamed variable "PktLen" -> "pkt_len" in bcm_char_read().
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Sun, 10 Aug 2014 12:32:01 +0000 (14:32 +0200)]
Staging: bcm: Bcmchar.c: Renamed variable "pTarang" -> "tarang"
Renamed variable "pTarang" -> "tarang" in
bcm_char_open()
bcm_char_release()
bcm_char_read()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Sun, 10 Aug 2014 12:32:00 +0000 (14:32 +0200)]
Staging: bcm: Bcmchar.c: Renamed variable "ulDSDMagicNumInUsrBuff" -> "dsd_magic_num_in_usr_buff"
Renamed variable "ulDSDMagicNumInUsrBuff" ->
"dsd_magic_num_in_usr_buff" in handle_flash2x_adapter().
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Sun, 10 Aug 2014 12:31:59 +0000 (14:31 +0200)]
Staging: bcm: Bcmchar.c: Renamed variable "Status" -> "status"
Renamed variable "Status" -> "status" in
bcm_handle_nvm_read_cmd()
handle_flash2x_adapter()
bcm_char_ioctl_reg_read_private()
bcm_char_ioctl_reg_write_private()
bcm_char_ioctl_reg_write_private()
bcm_char_ioctl_eeprom_reg_read()
bcm_char_ioctl_gpio_set_request()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Sun, 10 Aug 2014 12:31:58 +0000 (14:31 +0200)]
Staging: bcm: Bcmchar.c: Renamed variable "stNVMReadWrite" -> "nvm_rw"
Renamed variable "stNVMReadWrite" -> "nvm_rw" in
bcm_handle_nvm_read_cmd()
handle_flash2x_adapter()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Sun, 10 Aug 2014 12:31:57 +0000 (14:31 +0200)]
Staging: bcm: Bcmchar.c: Renamed variable "pReadData" -> "read_data"
Renamed variable "pReadData" -> "read_data" in
bcm_handle_nvm_read_cmd()
handle_flash2x_adapter()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Sun, 10 Aug 2014 12:31:56 +0000 (14:31 +0200)]
Staging: bcm: Bcmchar.c: Renamed variable "Adapter" -> "ad"
Renamed variable "Adapter" -> "ad" in
bcm_handle_nvm_read_cmd()
handle_flash2x_adapter()
bcm_char_open()
bcm_char_release()
bcm_char_read()
bcm_char_ioctl_reg_read_private()
bcm_char_ioctl_reg_write_private()
bcm_char_ioctl_reg_write_private()
bcm_char_ioctl_eeprom_reg_read()
bcm_char_ioctl_gpio_set_request()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Sun, 10 Aug 2014 12:31:55 +0000 (14:31 +0200)]
Staging: bcm: Bcmchar.c: Fixed indentation of function arguments
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Hema Prathaban [Thu, 14 Aug 2014 07:20:04 +0000 (12:50 +0530)]
staging: lustre: lustre: ptlrpc: Donot initialise null
This patch fixes the following error using checkpatch.pl
Error: Do not initialise statics to 0 or NULL
Signed-off-by: Hema Prathaban <hemaklnce@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Hema Prathaban [Wed, 13 Aug 2014 10:52:41 +0000 (16:22 +0530)]
staging: lustre: lustre: ptlrpc: Fix pointer declaration
This patch fixes the following checkpatch.pl issue in client.c:
ERROR: "foo * bar" should be "foo *bar"
Signed-off-by: Hema Prathaban <hemaklnce@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Hema Prathaban [Tue, 12 Aug 2014 11:56:38 +0000 (17:26 +0530)]
staging: lustre: lustre: ptlrpc: Fix requires space
Fix checkpatch.pl issues spaces required.
Signed-off-by: Hema Prathaban <hemaklnce@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 12 Aug 2014 02:18:29 +0000 (22:18 -0400)]
staging/lustre/lnet: Fix potential uninitialized variable warning
Greg reports that with one of the patches in his queue
there's now an unused variable warning in lnet_parse_ip2nets
for ipaddrs variable.
Apparently the warning is a false positive as in all cases where
lnet_ipaddr_enumerate can return without setting ipaddrs to something
a negative return value is returned that is then checked
before we actually use ipaddrs.
Assign ipaddrs to NULL to quiet this.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Srikrishan Malik [Mon, 11 Aug 2014 18:27:39 +0000 (23:57 +0530)]
staging: lustre: Cleanup variable declarations in mdc_enqueue()
Changes:
- move const union vars to the top
- move rc to bottom
- do not initialize req
- set lvb_type to enum member instead of 0
- change __u64 to u64
- fix inconsistant columnization
Signed-off-by: Srikrishan Malik <srikrishanmalik@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Srikrishan Malik [Mon, 11 Aug 2014 18:27:38 +0000 (23:57 +0530)]
staging: lustre: remove parentheses usage with return
Fix the following checkpatch error:
ERROR: return is not a function, parentheses are not required
Signed-off-by: Srikrishan Malik <srikrishanmalik@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Srikrishan Malik [Mon, 11 Aug 2014 18:27:37 +0000 (23:57 +0530)]
staging: lustre: move else on the same line as closing brace
Fix the following checkpatch error:
ERROR: else should follow close brace '}'
Signed-off-by: Srikrishan Malik <srikrishanmalik@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Srikrishan Malik [Mon, 11 Aug 2014 18:27:36 +0000 (23:57 +0530)]
staging: lustre: Fix misplaced opening brace warnings
Fixes the following checkpatch error:
ERROR: that open brace { should be on the previous line
Signed-off-by: Srikrishan Malik <srikrishanmalik@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Srikrishan Malik [Mon, 11 Aug 2014 18:27:35 +0000 (23:57 +0530)]
staging: lustre: Added space between type name and *
Fixes the following checkpatch error:
ERROR: "(foo*)" should be "(foo *)"
Signed-off-by: Srikrishan Malik <srikrishanmalik@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Srikrishan Malik [Wed, 13 Aug 2014 14:01:16 +0000 (19:31 +0530)]
] staging: lustre: fix multi line strings
Fixes the following checkpatch warning:
WARNING: quoted string split across lines
Signed-off-by: Srikrishan Malik <srikrishanmalik@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Srikrishan Malik [Mon, 11 Aug 2014 18:27:33 +0000 (23:57 +0530)]
staging: lustre: add blank lines after declarations
Fixes the following checkpatch warning:
WARNING: Missing a blank line after declarations
Signed-off-by: Srikrishan Malik <srikrishanmalik@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Srikrishan Malik [Mon, 11 Aug 2014 18:27:32 +0000 (23:57 +0530)]
staging: lustre: replace c99 style comments with C89
Fixes the following checkpatch error:
ERROR: do not use C99 // comments
Signed-off-by: Srikrishan Malik <srikrishanmalik@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Srikrishan Malik [Mon, 11 Aug 2014 18:27:31 +0000 (23:57 +0530)]
staging: lustre: Add missing spaces around operators and braces.
Fixes the following checkpatch errors:
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required after that close brace '}'
Signed-off-by: Srikrishan Malik <srikrishanmalik@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Srikrishan Malik [Mon, 11 Aug 2014 18:27:30 +0000 (23:57 +0530)]
staging: lustre: fix lines over 80 chars
Fixes the following checkpatch warning:
WARNING: line over 80 characters
Signed-off-by: Srikrishan Malik <srikrishanmalik@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Srikrishan Malik [Mon, 11 Aug 2014 18:27:29 +0000 (23:57 +0530)]
staging: lustre: move open brace to next line after functions
Fixes the following checkpatch error:
ERROR: open brace '{' following function declarations go on the next line
Signed-off-by: Srikrishan Malik <srikrishanmalik@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Srikrishan Malik [Mon, 11 Aug 2014 18:27:28 +0000 (23:57 +0530)]
staging: lustre: remove spaces from start of line
Fixes the following checkpatch warning:
WARNING: please, no spaces at the start of a line
Signed-off-by: Srikrishan Malik <srikrishanmalik@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Srikrishan Malik [Mon, 11 Aug 2014 18:27:27 +0000 (23:57 +0530)]
staging: lustre: remove space between function name and and open parenthesis
Fixes following checkpatch warning:
WARNING: space prohibited between function name and open parenthesis '('
Signed-off-by: Srikrishan Malik <srikrishanmalik@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Junien Fridrick [Sun, 10 Aug 2014 23:05:38 +0000 (23:05 +0000)]
staging: lustre: fix coding style issue: missing space after 'if'
Coding style issue reported by checkpatch.pl
Signed-off-by: Junien Fridrick <linux.kernel@junien.fridrick.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ragnar B. Johannsson [Sun, 10 Aug 2014 22:23:50 +0000 (22:23 +0000)]
staging: vt6656: add blank line after declaration
Adds a blank line after declaration to comply with coding style.
Signed-off-by: Ragnar B. Johannsson <ragnar@igo.is>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ragnar B. Johannsson [Sun, 10 Aug 2014 22:23:49 +0000 (22:23 +0000)]
staging: vt6656: fix incorrect indentation
Use tabs, not spaces.
Signed-off-by: Ragnar B. Johannsson <ragnar@igo.is>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ragnar B. Johannsson [Sun, 10 Aug 2014 22:23:48 +0000 (22:23 +0000)]
staging: vt6656: remove unnecessary braces
Removes unnecessary braces to comply with coding style.
Signed-off-by: Ragnar B. Johannsson <ragnar@igo.is>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 10 Aug 2014 14:47:03 +0000 (15:47 +0100)]
staging: vt6655: remove typedef from struct vnt_private
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 10 Aug 2014 14:47:02 +0000 (15:47 +0100)]
staging: vt6655: device_main Replace DEVICE_INFO with size of pointer
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 10 Aug 2014 14:47:01 +0000 (15:47 +0100)]
staging: vt6655: rf/wpactl/wroute use struct vnt_private
Replacing PSDevice.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 10 Aug 2014 14:47:00 +0000 (15:47 +0100)]
staging: vt6655: hostap/ioctl/iwctl use struct vnt_private
Replacing PSDevice.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 10 Aug 2014 14:46:59 +0000 (15:46 +0100)]
staging: vt6655: bssdb/datarate/dpc/power/rxtx use struct vnt_private
Replacing PSDevice.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 10 Aug 2014 14:46:58 +0000 (15:46 +0100)]
staging: vt6655: channel/wcmd/wctl/wmgr use struct vnt_private *
Replacing PSDevice.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 10 Aug 2014 14:46:57 +0000 (15:46 +0100)]
staging: vt6655: card change PSDevice to struct vnt_private
Repacing void *pDeviceHandler
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 10 Aug 2014 14:46:56 +0000 (15:46 +0100)]
staging: vt6655: baseband replace PSDevice
Coverting all functions to struct vnt_private.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 10 Aug 2014 14:46:55 +0000 (15:46 +0100)]
staging: vt6655: device.h use change __device_info to vnt_private
Coverting all functions to struct vnt_private in device.h and device_main.c
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 10 Aug 2014 11:22:02 +0000 (12:22 +0100)]
staging: vt6655: upc.h replace read and write memory functions
Update to the newer memory functions
readb -> ioread8
readw -> ioread16
readl -> ioread32
writeb -> iowrite8
writew -> iowrite16
writel -> iowrite32
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 10 Aug 2014 11:22:01 +0000 (12:22 +0100)]
staging: vt6655: upc.h: Remove unused macros
PCBv* are not used
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 10 Aug 2014 11:22:00 +0000 (12:22 +0100)]
staging: vt6655: CARDbSetBeaconPeriod call CARDbGetCurrentTSF to get TBTT
There is already a function to get next TBTT.
Replace code with CARDqGetNextTBTT.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 10 Aug 2014 11:21:59 +0000 (12:21 +0100)]
staging: vt6655: CARDqGetNextTBTT calculate qwTSF using do_div
Use do_div to compute equation as shown replacing existing code.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 10 Aug 2014 11:21:58 +0000 (12:21 +0100)]
staging: vt6655: Replace and remove typedef QWORD/ DQWORD
Replace the variables with u64/__le64.
The endian variant is needed in some places endian correction is
needed.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 10 Aug 2014 11:21:57 +0000 (12:21 +0100)]
staging: vt6655: BSSvSecondTxData remove #if 1 else directive
There is a code alignment error after this directive realign
code
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 10 Aug 2014 11:21:56 +0000 (12:21 +0100)]
staging: vt6655: Remove TxInSleep macro
TxInSleep is always enabled remove the macro and any
else code.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 9 Aug 2014 19:15:56 +0000 (20:15 +0100)]
staging: vt6655: rxtx: Replace typedef struct tagSMICHDRHead
With struct vnt_mic_hdr replacing pointer assigments in
s_vFillTxKey.
The size of new struture is the same as old with packing
Create the struture rxtx.h where it is only used.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Martin Berglund [Thu, 7 Aug 2014 22:08:34 +0000 (23:08 +0100)]
staging: vt6655: wpactl.c: Fix sparse warnings
Add missing __user macro casting in the function wpa_set_keys.
This is okay since the function handles the possibility of
param->u.wpa_key.key and param->u.wpa_key.seq pointing to
kernelspace using a flag, fcpfkernel.
Signed-off-by: Martin Berglund <martin@rogsta.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sanjeev Sharma [Fri, 8 Aug 2014 04:23:07 +0000 (09:53 +0530)]
staging:r819xU: coding style: Fixed commenting style
This is a patch to the r819xU_phyreg.h file that fixes
commenting style warning
Signed-off-by: Sanjeev Sharma <Sanjeev_Sharma@mentor.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andreas Schlick [Thu, 7 Aug 2014 17:20:50 +0000 (19:20 +0200)]
staging: rtl8723au: Remove unnecessary bit masking.
Signed-off-by: Andreas Schlick <ninox@posteo.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andreas Schlick [Thu, 7 Aug 2014 17:20:49 +0000 (19:20 +0200)]
staging: rtl8723au: Move open braces to the previous line.
Correct coding style errors in rtw_efuse.c. checkpatch.pl reported:
ERROR: that open brace { should be on the previous line
Signed-off-by: Andreas Schlick <ninox@posteo.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Konrad Zapalowicz [Wed, 6 Aug 2014 20:17:10 +0000 (22:17 +0200)]
staging: dgnc: Remove unnecessary 'return' statement
This commit fixes the checkpath warning 'void function return
statements are not generally useful' caused by the 'return' at the end
of 'void' function.
Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Konrad Zapalowicz [Wed, 6 Aug 2014 20:17:09 +0000 (22:17 +0200)]
staging: dgnc: Fix missing blank line after declarations
This commit fixes the missing blank lines after declarations checkpath
warnings found in dgnc_cls.c file.
Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Konrad Zapalowicz [Wed, 6 Aug 2014 19:01:26 +0000 (21:01 +0200)]
staging: dgnc: Remove 'volatile' modifier where it is not needed
This commit fixes the checkpath warning about misused 'volatile'
modifier. In this case the 'volatile' was not needed as it was used
for regular automatic variable. Thos commit removes the 'volatile'.
Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Konrad Zapalowicz [Wed, 6 Aug 2014 19:01:25 +0000 (21:01 +0200)]
staging: dgnc: Fix braces {} are not necessary for single statement blocks
This commit fixes the following checkpath warning in dgnc_neo.c file:
'braces {} are not necessary for single statement blocks'
Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Konrad Zapalowicz [Wed, 6 Aug 2014 19:01:24 +0000 (21:01 +0200)]
staging: dgnc: Fix that open brace { should be on the previous line
This commit fixes the following checkpath error in dgnc_neo.c file:
'that open brace { should be on the previous line'
Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Konrad Zapalowicz [Wed, 6 Aug 2014 19:01:23 +0000 (21:01 +0200)]
staging: dgnc: Fix missing blank line after declarations
This commit deals with the checkapth warnings 'missing line after
declarations' in the dgnc_neo.c file.
Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Konrad Zapalowicz [Wed, 6 Aug 2014 19:01:22 +0000 (21:01 +0200)]
staging: dgnc: Fix included header from 'asm'
This commit fixes the checkpatch warning:
drivers/staging/dgnc/dgnc_neo.c:37:
WARNING: Use #include <linux/io.h> instead of <asm/io.h>
Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Konrad Zapalowicz [Wed, 6 Aug 2014 12:21:25 +0000 (14:21 +0200)]
staging: dgnc: Update the TODO file
It turned out that the TODO file contained the invalid information as
some of the work has already been done. This commit updates it with the
current status of what is left to be done.
Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Konrad Zapalowicz [Wed, 6 Aug 2014 13:40:11 +0000 (15:40 +0200)]
staging: dgnc: Siplify the dgnc_start function
This commit slightly simplifies the sgnc_start() function by
rearranging it. As a result the indentation level is reduced.
This is not the functional change.
Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Konrad Zapalowicz [Wed, 6 Aug 2014 12:21:23 +0000 (14:21 +0200)]
staging: dgnc: Move utility functions out of dgnc_driver.c
This commit moves the utility functions out of dgnc_driver.c file and
puts them in the new dgnc_utils.{c,h} files. The accompanying changes
adjust the existing code to work with this design.
Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Konrad Zapalowicz [Wed, 6 Aug 2014 12:21:22 +0000 (14:21 +0200)]
staging: dgnc: Remove unnecessary functions from dgnc_driver.c
This commit slightly cleans up the dgnc_driver.c file. The changes
include removing one-line proxy functions as they were not needed.
Additionaly the pci 'remove' function is deleted because it was no
need for it.
Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Konrad Zapalowicz [Wed, 6 Aug 2014 12:21:21 +0000 (14:21 +0200)]
staging: dgnc: Fix frame size is larger than 1024B
This comit fixes the following sparse warnign:
drivers/staging/dgnc/dgnc_tty.c:572:1:
warning: the frame size of 1060 bytes is larger than 1024 bytes
[-Wframe-larger-than=]
This was caused by having buffer as an automatic variable. This commit
moves it from the stack to the heap.
Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Konrad Zapalowicz [Wed, 6 Aug 2014 12:21:20 +0000 (14:21 +0200)]
staging: dgnc: Fix no spaces before tabs checkpath warning
This commit corrects the 'no space before tabs' checkpath warning.
Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Konrad Zapalowicz [Tue, 12 Aug 2014 06:08:37 +0000 (08:08 +0200)]
staging: dgnc: Fix externs should be avoided in the .c files
This commit fixes the following checkpatch warnings:
WARNING: externs should be avoided in .c files
#80: FILE: drivers/staging/dgnc/dgnc_driver.c:80:
+int dgnc_init_module(void);
#81: FILE: drivers/staging/dgnc/dgnc_driver.c:81:
+void dgnc_cleanup_module(void);
This was caused by putting the declarations for module init and module
exit fucntions on the top of the file. The fix removes these
declarations plus it also corrects the type of the init/exit functions.
Due to the dependency between init and exit functions the
dgnc_cleanup_module had to be put first.
Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lars Hamre [Fri, 8 Aug 2014 01:21:42 +0000 (21:21 -0400)]
Staging: nokia_h4p: removed unnecessary return statement in nokia_fw.c
This is a patch to the nokia_fw.c file that removes an unnecessary return statement found by the checkpatch.pl tool
Signed-off-by: Lars Hamre <hamham91@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
A Raghavendra Rao [Thu, 7 Aug 2014 08:40:39 +0000 (14:10 +0530)]
Staging: wlan-ng: fix sparse warning in prism2fw.c
Fix the following sparse warning :
In file included from drivers/staging/wlan-ng/prism2usb.c:5:0:
drivers/staging/wlan-ng/prism2fw.c: In function
‘read_cardpda.constprop.43’:
drivers/staging/wlan-ng/prism2fw.c:792:1: warning: the frame size of
1068 bytes is larger than 1024 bytes [-Wframe-larger-than=]
The variable to 'struct p80211msg_p2req_readpda' was previously being created
on the stack, which inturn exeeded the frame size limit, resulting in a
sparse warning. This patch alloctes the memory to the structure dynamically
and the operations are left unchanged.
Signed-off-by: A Raghavendra Rao <arrao@cdac.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Quentin Lambert [Mon, 4 Aug 2014 19:10:24 +0000 (21:10 +0200)]
staging: slicoss: fix a blank line coding style issue
Add 2 missing blank lines after declaration.
Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Falzoi [Tue, 5 Aug 2014 21:24:18 +0000 (23:24 +0200)]
Staging: rts5208: Remove CONFIG_RTS5208_DEBUG option
CONFIG_RTS5208_DEBUG is no more needed, we rely on dynamic debug config options
instead.
Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Falzoi [Tue, 5 Aug 2014 21:24:17 +0000 (23:24 +0200)]
Staging: rts5208: Use dev_dbg and print_hex_dump_bytes to dump memory
Use dev_dbg with %*ph format specifier and print_hex_dump_bytes to dump memory
instead of relying on custom macro.
Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Quentin Lambert [Mon, 4 Aug 2014 19:07:07 +0000 (21:07 +0200)]
staging: imx-drm: fix a blank line coding style issue
Add missing blank lines after declaration.
Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Julia Lawall [Fri, 8 Aug 2014 10:07:50 +0000 (12:07 +0200)]
imx-drm: imx-drm-core: delete unneeded test before of_node_put
Of_node_put supports NULL as its argument, so the initial test is not
necessary.
Suggested by Uwe Kleine-König.
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e;
@@
-if (e)
of_node_put(e);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christoph Jaeger [Mon, 4 Aug 2014 12:54:56 +0000 (14:54 +0200)]
staging: ozwpan: Use list helpers
Make use of the various list helper functions to improve readability.
Signed-off-by: Christoph Jaeger <email@christophjaeger.info>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christoph Jaeger [Fri, 8 Aug 2014 06:01:09 +0000 (08:01 +0200)]
staging: ozwpan: Use slab cache for oz_tx_frame allocation
Use a slab cache rather than rolling our own free list.
Signed-off-by: Christoph Jaeger <email@christophjaeger.info>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christoph Jaeger [Fri, 8 Aug 2014 06:00:42 +0000 (08:00 +0200)]
staging: ozwpan: Use slab cache for oz_elt_info allocation
Use a slab cache rather than rolling our own free list.
Signed-off-by: Christoph Jaeger <email@christophjaeger.info>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christoph Jaeger [Fri, 8 Aug 2014 05:59:24 +0000 (07:59 +0200)]
staging: ozwpan: Use slab cache for oz_urb_link allocation
Use a slab cache rather than rolling our own free list.
Signed-off-by: Christoph Jaeger <email@christophjaeger.info>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christoph Jaeger [Mon, 4 Aug 2014 12:54:52 +0000 (14:54 +0200)]
staging: ozwpan: Simplify app interface
Simplify the somewhat overcomplicated application interface; improves
readability and saves a bunch of lines.
Use designated struct initializers for clarity.
Signed-off-by: Christoph Jaeger <email@christophjaeger.info>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
projects / platform / kernel / linux-rpi.git / log