platform/upstream/efl.git
4 years agoavahi - let's disable by default as there doesn't seem to be a use
Carsten Haitzler (Rasterman) [Mon, 2 Mar 2020 19:02:09 +0000 (19:02 +0000)]
avahi - let's disable by default as there doesn't seem to be a use

i asked why we should have it by default etc. and what it's needed
for. i cant't find any... and no answer soc off by default to trim efl
down.

4 years agoefl-wl: add toplevel_added event for adding a new toplevel surface
Mike Blumenkrantz [Tue, 3 Mar 2020 18:42:47 +0000 (13:42 -0500)]
efl-wl: add toplevel_added event for adding a new toplevel surface

Summary: Depends on D11443

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11444

4 years agoefl-wl: ensure that child_added event is called only when a parent is set
Mike Blumenkrantz [Tue, 3 Mar 2020 18:42:43 +0000 (13:42 -0500)]
efl-wl: ensure that child_added event is called only when a parent is set

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11443

4 years agodoxygen docs: Fix several group problems
Xavi Artigas [Tue, 3 Mar 2020 17:46:36 +0000 (18:46 +0100)]
doxygen docs: Fix several group problems

@ingroup before @addgroup, circular group dependencies...

4 years agodoxygen docs: fix insufficiently namespaced group names
Xavi Artigas [Tue, 3 Mar 2020 16:49:23 +0000 (17:49 +0100)]
doxygen docs: fix insufficiently namespaced group names

These led to clashes, since group names must be globally unique.

4 years agodoxygen docs: fix multiple defined @section's
Xavi Artigas [Tue, 3 Mar 2020 10:09:47 +0000 (11:09 +0100)]
doxygen docs: fix multiple defined @section's

Section names must be globally unique.
We rarely reference sections so we don't actually need to use @section
and a simple header suffices.

4 years agoefl-wl: add function to get pid of a surface
Mike Blumenkrantz [Tue, 3 Mar 2020 17:27:43 +0000 (12:27 -0500)]
efl-wl: add function to get pid of a surface

Summary: this is useful for tracking surfaces of specific clients

Reviewers: bu5hm4n, devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11438

4 years agotests_: elementary: remove not used allocation in collection view test
Stefan Schmidt [Mon, 2 Mar 2020 15:46:19 +0000 (16:46 +0100)]
tests_: elementary: remove not used allocation in collection view test

Allocated but never used (and never freed). Seems like a copy and paste
bug to me.

CID: 1412363

Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11442

4 years agotests_: elementary: free memory in error path
Stefan Schmidt [Mon, 2 Mar 2020 15:40:38 +0000 (16:40 +0100)]
tests_: elementary: free memory in error path

Make sure we free the iterator here as well.

CID: 1409658

Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11441

4 years agotests/gesture: add test for gesture sequence
Mike Blumenkrantz [Mon, 2 Mar 2020 15:23:31 +0000 (10:23 -0500)]
tests/gesture: add test for gesture sequence

ensure that tap continues working after complex gestures

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11440

4 years agoefl/gesture: deduplicate some code
Mike Blumenkrantz [Thu, 20 Feb 2020 18:55:40 +0000 (13:55 -0500)]
efl/gesture: deduplicate some code

also remove a misleading comment

no functional changes

Differential Revision: https://phab.enlightenment.org/D11395

4 years agotests/gesture: add a couple rotate gesture tests
Mike Blumenkrantz [Thu, 20 Feb 2020 18:48:14 +0000 (13:48 -0500)]
tests/gesture: add a couple rotate gesture tests

these end up triggering a lot of corner cases in other recognizers too,
but the tests themselves are fairly minimal

Differential Revision: https://phab.enlightenment.org/D11391

4 years agotests/gesture: verify rotate gesture event counting in existing tests
Mike Blumenkrantz [Wed, 19 Feb 2020 17:57:26 +0000 (12:57 -0500)]
tests/gesture: verify rotate gesture event counting in existing tests

these magically pass already

Differential Revision: https://phab.enlightenment.org/D11390

4 years agotests/elm: add util function for doing a multi-press drag around
Mike Blumenkrantz [Thu, 20 Feb 2020 18:24:52 +0000 (13:24 -0500)]
tests/elm: add util function for doing a multi-press drag around

same as existing function, but takes a finger id

Differential Revision: https://phab.enlightenment.org/D11389

4 years agotests/elm: fix drag_around helper to handle negative angles
Mike Blumenkrantz [Thu, 20 Feb 2020 18:16:51 +0000 (13:16 -0500)]
tests/elm: fix drag_around helper to handle negative angles

oops

Differential Revision: https://phab.enlightenment.org/D11388

4 years agoefl/gesture: fix flick internal touch id tracking
Mike Blumenkrantz [Thu, 20 Feb 2020 18:47:33 +0000 (13:47 -0500)]
efl/gesture: fix flick internal touch id tracking

need to always make sure we set this when a gesture is being tracked so
we know which touch point we're watching

Differential Revision: https://phab.enlightenment.org/D11387

4 years agoefl/gesture: fix momentum gesture recognizer to properly continue its gestures
Mike Blumenkrantz [Thu, 20 Feb 2020 18:22:47 +0000 (13:22 -0500)]
efl/gesture: fix momentum gesture recognizer to properly continue its gestures

it's not enough to just check the value for this in the recognizer; we need to
always modify the recognizer property here to correctly manage object lifetimes
and generate the correct events (e.g., not emitting momentum gestures while
multiple fingers are moving simultaneously)

also update a couple existing unit test checks which were wrong

Differential Revision: https://phab.enlightenment.org/D11386

4 years agoefl/gesture: correctly filter tap events based on the processing touch point
Mike Blumenkrantz [Thu, 20 Feb 2020 18:20:32 +0000 (13:20 -0500)]
efl/gesture: correctly filter tap events based on the processing touch point

if the recognizer is processing using a touch point other than the first finger,
e.g., in the case where multiple fingers are pressed simultaneously, then
the recognizer needs to also detect distance based on that finger

more fixes for triggering tap events while fingers are moving

Differential Revision: https://phab.enlightenment.org/D11385

4 years agoefl/gesture: fix internal gesture object management
Mike Blumenkrantz [Thu, 20 Feb 2020 18:17:58 +0000 (13:17 -0500)]
efl/gesture: fix internal gesture object management

when a gesture ends and is not set to continue, the gesture object must
be preserved until the entire touch sequence ends in order to ensure that
all the touch point states are accurately detected and updated and so
additional instances of that gesture are not accidentally triggered

this fixes weird corner cases where you could tap with two fingers and
then get a long press event while dragging the second finger around as
long as you did it quickly enough

Differential Revision: https://phab.enlightenment.org/D11384

4 years agoefl/gesture: port 'rotate' gesture from elm to new gesture framework
Mike Blumenkrantz [Wed, 19 Feb 2020 15:24:04 +0000 (10:24 -0500)]
efl/gesture: port 'rotate' gesture from elm to new gesture framework

this is a 1:1 port with minimal changes other than what's necessary to
integrate into the new framework

Differential Revision: https://phab.enlightenment.org/D11383

4 years agoefl/gesture: move some internal recognizer functions to be reusable
Mike Blumenkrantz [Wed, 19 Feb 2020 14:49:08 +0000 (09:49 -0500)]
efl/gesture: move some internal recognizer functions to be reusable

no functional changes

Differential Revision: https://phab.enlightenment.org/D11382

4 years agoefl/gesture: rename long_tap -> long_press
Mike Blumenkrantz [Tue, 18 Feb 2020 15:16:51 +0000 (10:16 -0500)]
efl/gesture: rename long_tap -> long_press

this is consistent with the rest of efl naming

ref T8503

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11376

4 years agoefl/gesture: remove empty efl.object implementations from gesture objects
Mike Blumenkrantz [Fri, 14 Feb 2020 14:40:55 +0000 (09:40 -0500)]
efl/gesture: remove empty efl.object implementations from gesture objects

these are no longer needed

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11354

4 years agoefl/gesture: remove 'type' member from Efl_Canvas_Gesture_Data
Mike Blumenkrantz [Fri, 14 Feb 2020 14:36:53 +0000 (09:36 -0500)]
efl/gesture: remove 'type' member from Efl_Canvas_Gesture_Data

this is no longer used

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11353

4 years agotests/gesture: add custom gesture to custom recognizer test
Mike Blumenkrantz [Fri, 14 Feb 2020 13:50:13 +0000 (08:50 -0500)]
tests/gesture: add custom gesture to custom recognizer test

this adds a simple custom gesture implementation with basic motion
accumulator properties to verify (and give an example of) the custom
gesture capability that can be used by apps alongside custom recognizers

Differential Revision: https://phab.enlightenment.org/D11352

4 years agoefl_ui_spotlight_scroll: improve scroll behaviour
Marcel Hollerbach [Sat, 22 Feb 2020 16:25:27 +0000 (17:25 +0100)]
efl_ui_spotlight_scroll: improve scroll behaviour

when the mouse motion was used, we need to mark this event as processed.
Otherwise a click event will be emitted which is wrong.

Additionally, we should only scroll when we are definitly not clicking.
Right now, the scrolling animation would dance arround on a real TS.

Additionally², this commit introduces a little macro which calculates
the distance of a position.

4 years agoexactness: check success of mkdir
Stefan Schmidt [Wed, 26 Feb 2020 14:07:12 +0000 (15:07 +0100)]
exactness: check success of mkdir

Evaluate return code of mkdir() and print error if it fails.

CID: 1419844

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11429

4 years agoRevert "elm_label: sizing eval is called _on_label_resize to ensure label size."
Stefan Schmidt [Mon, 2 Mar 2020 15:46:06 +0000 (16:46 +0100)]
Revert "elm_label: sizing eval is called _on_label_resize to ensure label size."

This reverts commit 3d57fc0c92d10337c441ec830361751de510e9b1.

The change broke elementary tests on my local machine as well as on CI.
Please redo the change and bring it back after testing with the test
suites we have.

4 years agoecore_wl: removes unreachable statements
Wonki Kim [Mon, 2 Mar 2020 09:26:39 +0000 (18:26 +0900)]
ecore_wl: removes unreachable statements

Summary: this patch removes unreachable statements

Reviewers: Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11437

4 years agofreeq - up numbers for fq blocks and other limits to defer big batches
Carsten Haitzler (Rasterman) [Fri, 28 Feb 2020 18:47:50 +0000 (18:47 +0000)]
freeq - up numbers for fq blocks and other limits to defer big batches

this should improve some perf by upping the max a free queu can baloon
up to 256k items and 32m of data (whichever is hit first).

4 years agodocs: Give some doc love to Evas_Object_Vg
Xavi Artigas [Fri, 28 Feb 2020 11:36:57 +0000 (12:36 +0100)]
docs: Give some doc love to Evas_Object_Vg

4 years agodoxygen: fix missing @p tag
Xavi Artigas [Fri, 28 Feb 2020 11:08:51 +0000 (12:08 +0100)]
doxygen: fix missing @p tag

4 years agodoxygen: fix invalid anchor names
Xavi Artigas [Fri, 28 Feb 2020 11:07:45 +0000 (12:07 +0100)]
doxygen: fix invalid anchor names

4 years agodoxygen: fix missing endcond tag
Xavi Artigas [Fri, 28 Feb 2020 11:05:26 +0000 (12:05 +0100)]
doxygen: fix missing endcond tag

4 years agodoxygen: fix missing titles in addgroup
Xavi Artigas [Fri, 28 Feb 2020 10:43:52 +0000 (11:43 +0100)]
doxygen: fix missing titles in addgroup

4 years agodoxygen: fix invalid eolian_main_intro ref
Xavi Artigas [Fri, 28 Feb 2020 10:39:23 +0000 (11:39 +0100)]
doxygen: fix invalid eolian_main_intro ref

4 years agodoxygen: fix duplicated toc sections
Xavi Artigas [Fri, 28 Feb 2020 10:01:56 +0000 (11:01 +0100)]
doxygen: fix duplicated toc sections

4 years agodoxygen: remove deprecated (and unused) configuration
Xavi Artigas [Fri, 28 Feb 2020 10:01:37 +0000 (11:01 +0100)]
doxygen: remove deprecated (and unused) configuration

4 years agodoxygen: remove duplicated sections
Xavi Artigas [Fri, 28 Feb 2020 10:01:03 +0000 (11:01 +0100)]
doxygen: remove duplicated sections

Unified widgets simply copied elm's headers, duplicating doxygen sections.

4 years agodoxygen: fix missing end group tag
Xavi Artigas [Fri, 28 Feb 2020 09:53:49 +0000 (10:53 +0100)]
doxygen: fix missing end group tag

4 years agodoxygen: fix duplicated intro sections
Xavi Artigas [Fri, 28 Feb 2020 09:52:59 +0000 (10:52 +0100)]
doxygen: fix duplicated intro sections

4 years agoexactness: inspect: use logical OR instead bitwise XOR
Stefan Schmidt [Wed, 26 Feb 2020 16:18:07 +0000 (17:18 +0100)]
exactness: inspect: use logical OR instead bitwise XOR

Coverity pointed these out as we deferences after null check.
Looking into it showed these use of a bitwise operator on vars where it
does not make any sense (to me). They look like wrongly done NULL
checks. Switchign them over to a logical OR operator.

CID: 1419876, 1419869, 1419868, 1419862, 1419854, 1419849

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11432

4 years agoexactness: inspect: remove unreachable code
Stefan Schmidt [Wed, 26 Feb 2020 14:46:22 +0000 (15:46 +0100)]
exactness: inspect: remove unreachable code

If dt equals EX_FONTS_DIR we would have returned already.

CID: 1419879

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11430

4 years agoexactness: handle error cases for saving an image
Stefan Schmidt [Wed, 26 Feb 2020 14:02:23 +0000 (15:02 +0100)]
exactness: handle error cases for saving an image

Handle the error case and propagate the error upwards.

CID: 1419855

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11428

4 years agoexactness: use eina_strdup() to avoid extra NULL checking
Stefan Schmidt [Wed, 26 Feb 2020 10:35:20 +0000 (11:35 +0100)]
exactness: use eina_strdup() to avoid extra NULL checking

strdup() would not be happy about a NULL to copy, but we have
eina_strdup in place already to handle this gracefully.

CID: 1419846

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11421

4 years agoexactness: check return code from ecore_evas_init
Stefan Schmidt [Wed, 26 Feb 2020 09:38:54 +0000 (10:38 +0100)]
exactness: check return code from ecore_evas_init

Check if we can initialize correctly and return failure if not.

CID: 1419872, 1419864, 1419867, 1419850

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11420

4 years agoexactness: avoid leak on leaving scope
Stefan Schmidt [Tue, 25 Feb 2020 10:42:17 +0000 (11:42 +0100)]
exactness: avoid leak on leaving scope

Before we leave the fucntion here we need to free our temporaray paths
variable.

CID: 1419860

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11411

4 years agoexactness: player: allow space for the terminating null
Stefan Schmidt [Tue, 25 Feb 2020 10:20:21 +0000 (11:20 +0100)]
exactness: player: allow space for the terminating null

Allocate extra space for the terminating null byte and / of the string.
Switch to snprintf() as well.

CID: 1419863

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11410

4 years agoelm_slider: Add return value check
JunsuChoi [Wed, 26 Feb 2020 07:35:28 +0000 (16:35 +0900)]
elm_slider: Add return value check

Summary:
Calling eina_value_get() without checking return value.
CID: 1400991

Test Plan: N/A

Reviewers: YOhoho, Hermet, Jaehyun_Cho, CHAN

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11416

4 years agotest/suite_helpers : Fix warnings about use to uninitialized value.
JunsuChoi [Wed, 26 Feb 2020 07:34:44 +0000 (16:34 +0900)]
test/suite_helpers : Fix warnings about use to uninitialized value.

Summary:
remove warnings.
../src/tests/elementary/suite_helpers.c:779:86: warning: ?idy2? may be used uninitialized in this function [-Wmaybe-uninitialized].
...

Test Plan: N/A

Reviewers: YOhoho, Hermet, Jaehyun_Cho

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11417

4 years agoelementary_test/ui_spotlight: Fix warnings about use to uninitialized value.
JunsuChoi [Wed, 26 Feb 2020 07:33:21 +0000 (16:33 +0900)]
elementary_test/ui_spotlight: Fix warnings about use to uninitialized value.

Summary:
remove warnings.
../src/bin/elementary/test_ui_spotlight.c:1126:9: warning: 'view' may be used uninitialized in this function [-Wmaybe-uninitialized]
...

Test Plan: N/A

Reviewers: YOhoho, Hermet, Jaehyun_Cho

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11418

4 years agoexactness: injector: free local buffers
Stefan Schmidt [Tue, 25 Feb 2020 11:34:18 +0000 (12:34 +0100)]
exactness: injector: free local buffers

Make sure we free local resources before we break.

CID: 1419845

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11414

4 years agoexactness: inspect: free image before leaving scope
Stefan Schmidt [Tue, 25 Feb 2020 11:29:01 +0000 (12:29 +0100)]
exactness: inspect: free image before leaving scope

We need to amke sure we free this images before we return.

CID: 1419848

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11413

4 years agoexactness: close file we opened
Stefan Schmidt [Tue, 25 Feb 2020 10:59:51 +0000 (11:59 +0100)]
exactness: close file we opened

We only opened it read only, but this should still be closed before
leaving.

CID: 1419853

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11412

4 years agoexactness: inspect: free local allocation before leaving scope
Stefan Schmidt [Tue, 25 Feb 2020 09:51:29 +0000 (10:51 +0100)]
exactness: inspect: free local allocation before leaving scope

Before we leave the scope here this needs to get free'd up or it will
leak.

CID: 1419877

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11408

4 years agoexactness: inspect: fix memory leak of buffer in error path
Stefan Schmidt [Tue, 25 Feb 2020 09:36:39 +0000 (10:36 +0100)]
exactness: inspect: fix memory leak of buffer in error path

If we hit this error path we need to release the allocated buffer.

CID: 1419878

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11407

4 years agoEcore_Win32: free 'compose' field when needed, fix memory leak
Vincent Torri [Tue, 25 Feb 2020 15:27:14 +0000 (10:27 -0500)]
Ecore_Win32: free 'compose' field when needed, fix memory leak

Reviewers: raster, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11415

4 years agoEvil: add evil_utf8_to_utf16() API ; use evil_utf16_to_utf8() in Ecore_Win32
Vincent Torri [Tue, 25 Feb 2020 14:23:48 +0000 (09:23 -0500)]
Evil: add evil_utf8_to_utf16() API ; use evil_utf16_to_utf8() in Ecore_Win32

Summary: use existing utf-16 to utf-8 conversion function in Ecore_Win32. Add API to convert utf-8 to utf-16 in Evil for copy'n paste on Windows

Test Plan: compilation

Reviewers: raster, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11406

4 years agotests/elm: verify image file_set -> memfile_set -> file_set
Mike Blumenkrantz [Tue, 25 Feb 2020 14:23:46 +0000 (09:23 -0500)]
tests/elm: verify image file_set -> memfile_set -> file_set

Summary:
ref D11392
Depends on D11397

Reviewers: kimcinoo, Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11398

4 years agotests/elm: fix elm_icon test
Mike Blumenkrantz [Tue, 25 Feb 2020 14:23:44 +0000 (09:23 -0500)]
tests/elm: fix elm_icon test

Summary:
* this was left as a duplicated efl_ui_image test
* elm_image doesn't have a legacy api for setting icons
* elm_icon doesn't actually have any tests for icon loading
Depends on D11396

Reviewers: kimcinoo, Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11397

4 years agotest_efl_gfx_vg_value_provider: expand buffer to avoid truncation by snprintf
Yeongjong Lee [Tue, 25 Feb 2020 11:23:30 +0000 (12:23 +0100)]
test_efl_gfx_vg_value_provider: expand buffer to avoid truncation by snprintf

Test Plan: compile with `-Wformat-truncation`

Reviewers: raster, Hermet, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11405

4 years agoelm/image: restore legacy behavior of elm_image_file_get
Mike Blumenkrantz [Tue, 25 Feb 2020 03:17:12 +0000 (12:17 +0900)]
elm/image: restore legacy behavior of elm_image_file_get

Summary:
this should operate on the internal image object to reflect the file
state there instead of the outer object

Reviewers: kimcinoo, Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11396

4 years agoefl_ui/image_zoomable: add icon setting fallback for fdo icons
Mike Blumenkrantz [Mon, 24 Feb 2020 14:34:45 +0000 (15:34 +0100)]
efl_ui/image_zoomable: add icon setting fallback for fdo icons

Summary:
same as D11381
ref 697308a16f77e3e7b7dac6e74293850a3950e3d3

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11403

4 years agoEfl.Ui.Image: Add fallback when icon is not found in default theme
Xavi Artigas [Mon, 24 Feb 2020 14:02:30 +0000 (09:02 -0500)]
Efl.Ui.Image: Add fallback when icon is not found in default theme

Summary:
If _icon_standard_set() fails, _icon_freedesktop_set() is tried.

This was causing missing icons in the homescreen example, which uses
application icons which are obviously not present in the default theme.

Thanks to @bu5hm4n!

Test Plan: The homescreen sample application from the examples repository now correctly shows all missing icons.

Reviewers: bu5hm4n, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers, bu5hm4n

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11381

4 years agoelm : move unrealize callback call before the content caching.
SangHyeon Jade Lee [Mon, 24 Feb 2020 13:52:09 +0000 (08:52 -0500)]
elm : move unrealize callback call before the content caching.

Summary:
item edje and contents are cached for performance improvement in genlist & gengrid.
but to provide elm_genlist(gengrid)_all_contents_unset method before the contents
are being cached, unrealize callback must be come before the unrealize process.

currently,
item_unrealize
1.unrealize process
2.contents cached
3.unrealize callback
4.all_contents_unset : nothing to unset in the item.

by this patch,
item_unrealize
1.unrealize callback
2.all_contents_unset : contents are unset.
3.unrealize process
4.contents(null) cached

Reviewers: bu5hm4n, cedric, eagleeye, zmike

Reviewed By: zmike

Subscribers: zmike, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11402

4 years agoRevert "elm_spinner: Fixed to apply the %d format."
Jaehyun Cho [Fri, 21 Feb 2020 09:07:13 +0000 (09:07 +0000)]
Revert "elm_spinner: Fixed to apply the %d format."

This reverts commit b8a24679a6f7995ccc1da19eb86c6c2ef6826d1a.

Differential Revision: https://phab.enlightenment.org/D11394

4 years agoeina: Fix warnings about unused variables on Windows
Christopher Michael [Sun, 23 Feb 2020 12:38:05 +0000 (07:38 -0500)]
eina: Fix warnings about unused variables on Windows

NB: Patch from vtorri

4 years agoci: travis: ensure we update brew as well to avoid a problem on Travis
Stefan Schmidt [Fri, 21 Feb 2020 08:15:53 +0000 (09:15 +0100)]
ci: travis: ensure we update brew as well to avoid a problem on Travis

We normally did not use update as it could take up a few minutes for
every macos build and the packages have been recent enough. Since a few
hours we see build problems now on Travis:
Error: Unknown command: bundle

A way to get them fixed (until Travis updates their images for macos) is
to use the update command.
https://travis-ci.community/t/macos-build-fails-because-of-homebrew-bundle-unknown-command/7296/9

Also moving to a newer osx image here to avoid falling further behind on
the dependencies.

4 years agogl_generic: do not return when RGBA_Image is NULL 15/226515/3
Shinwoo Kim [Tue, 3 Mar 2020 08:08:45 +0000 (17:08 +0900)]
gl_generic: do not return when RGBA_Image is NULL

From following commit
_rotate_image_data does not work if RGBA_Image (im1->im) is NULL.

   0abf1ee [evas_gl] change oreint_set() ... like sw backend

But there is a case the RGBA_Imange is NULL as below.

   Evas_Object *proxy;
   proxy = evas_object_image_add(evas);
   evas_object_image_source_set(proxy, source);
   evas_object_image_save(proxy, "file name", NULL, NULL);

And the following is its stack when the RGBA_Image is NULL

   (#0) _rotate_image_data
   (#1) eng_image_data_map
   (#2) _efl_canvas_image_internal_efl_file_save_save
   (#3) efl_file_save
   (#4) evas_object_image_save

*tizen_fix

Change-Id: Ifa1fd452836a5048f11313ea8c746dd684838470

4 years agoevas: ++safety by prevent invalid accesses. 29/226529/1
Hermet Park [Tue, 3 Mar 2020 10:17:29 +0000 (19:17 +0900)]
evas: ++safety by prevent invalid accesses.

Change-Id: Ib1637f6ff6bd2093a2d525641339cae4553f96e2

4 years agoelc_popup: support eext popup 60/226160/2
Taehyub Kim [Thu, 27 Feb 2020 07:33:44 +0000 (16:33 +0900)]
elc_popup: support eext popup

Change-Id: Ifeeb71ad863522d5e67cd5427cf7288b79fd6d8f

4 years agoevas event: fix typo at map coord transform. 89/226389/3
Hermet Park [Mon, 2 Mar 2020 07:55:40 +0000 (16:55 +0900)]
evas event: fix typo at map coord transform.

Change-Id: If03fd054ece3de57f7e728184babdbee299bd771

4 years agoelm_label: sizing eval is called _on_label_resize to ensure label size. 88/226388/1
Bowon Ryu [Mon, 2 Mar 2020 07:53:10 +0000 (16:53 +0900)]
elm_label: sizing eval is called _on_label_resize to ensure label size.

Summary:
EFL should guarantee size of label in various situations that the label is resized.
elm_layout_sizing_eval called on on_label_resize.

Test Plan: N/A

Reviewers: YOhoho, zmike, Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, Hermet, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11435

Change-Id: I531d2333a1b5d9ff9fd273cb8a70767f96b153e2

4 years agoevas_render: Keep to tizen_only logic about proxy_subrender 37/226037/2
JunsuChoi [Wed, 26 Feb 2020 07:55:00 +0000 (16:55 +0900)]
evas_render: Keep to tizen_only logic about proxy_subrender

The tizen only code added in 76b89b8 is the code to use the proxy's source region if it exists.
(evas proxy: use part of source / 76b89b8)
However, this logic became a separate condition with the addition of 2ab3149dd3,
and the value assign for w and h is overwritten.
(evas proxy: make it work for load_region / 2ab3149dd3)
Therefore, modify the code to keep the tizen only code.

@tizen_only
CID: 1125046, 1125041

Change-Id: I98e541913ffbc90ad381334772d9e398158a1639

4 years agoevas_model_load_ply: Prevent memory leak 97/226097/1
JunsuChoi [Thu, 27 Feb 2020 00:55:37 +0000 (09:55 +0900)]
evas_model_load_ply: Prevent memory leak

Summary:
If use ein_str_split, have to free the first element of the array
and free the array.

Test Plan: N/A

Reviewers: Hermet, YOhoho, bu5hm4n, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11419

Change-Id: Ibd8327fc249dd7a503fdb7b7b1527e25c90e87a1

4 years agoelm_config: remove explict null terminator for snprintf 90/225890/2
Yeongjong Lee [Tue, 25 Feb 2020 07:25:41 +0000 (16:25 +0900)]
elm_config: remove explict null terminator for snprintf

snprintf will add a null terminator at the end of string.
Also, this fixes `Wformat-contains-nul` compiler warnings.
```
../src/lib/elementary/elm_config.c: In function '_product_color_overlay_get':
../src/lib/elementary/elm_config.c:1383:87: warning: embedded '\0' in format [-Wformat-contains-nul]
 1383 |         snprintf(config_path, sizeof(config_path), "%s/config/%s/%s_color_overlays.cfg\0",
      |                                                                                       ^~
../src/lib/elementary/elm_config.c: In function '_elm_config_product_font_overlay_get':
../src/lib/elementary/elm_config.c:1538:86: warning: embedded '\0' in format [-Wformat-contains-nul]
 1538 |         snprintf(config_path, sizeof(config_path), "%s/config/%s/%s_font_overlays.cfg\0",
      |
```

@tizen_fix

Change-Id: Id2c73c9186b820e9398bd3d8a5cc27432edee09a

4 years agowayland_egl: use glsym_func_bool instead of glsym_func_int 03/225903/2
Yeongjong Lee [Tue, 25 Feb 2020 08:04:58 +0000 (17:04 +0900)]
wayland_egl: use glsym_func_bool instead of glsym_func_int

return type of `glsym_eglDestroySyncKHR` is EGLBoolean.

@tizen_fix
Change-Id: I20c9b6371a26f9a6a2ce88cabd83364e74267ed1

4 years agoedje_load: fix possible null pointer dereference 43/226043/2
Jaehyun Cho [Wed, 26 Feb 2020 07:52:38 +0000 (16:52 +0900)]
edje_load: fix possible null pointer dereference

Change-Id: I526c65fa0530c4064d06b903db7bde18b6f0d764

4 years agoevas: software_engine: free allocation on error path 29/226029/1
Stefan Schmidt [Tue, 25 Feb 2020 09:57:24 +0000 (10:57 +0100)]
evas: software_engine: free allocation on error path

When we allocated s but fail to allocate l we need to make sure to free
the first allocation before erroring out.

CID: 1419874

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11409

Change-Id: I4016c7bab0347519e03345f4bb46d16377479dc4

4 years agoedje/style: Fix a problem where embedded font does not load in edj 63/225963/1
Bowon Ryu [Mon, 24 Feb 2020 11:16:40 +0000 (20:16 +0900)]
edje/style: Fix a problem where embedded font does not load in edj

Summary:
When edje_font_is_embedded the path of the font must be "font=edje/fonts/%s"
The previous code is "font=%s"
This causes the font to not load properly when edje_font_is_embedded.

Test Plan:
edje_cc test.edc
edje_player test.edj

collections {
    group { "main";
        fonts {
            // Set any two fonts in your local path.
            font: "ANYFONT_1.TTF" "font_1";
            font: "ANYFONT_2.TTF" "font_2";
        }
        styles {
            style { name: "textblock_style_1";
                base: "font=font_1 font_size=30 color=#ffffff";
            }
            style { name: "textblock_style_2";
                base: "font=font_2 font_size=30 color=#ffffff";
            }
        }
        parts {
            spacer { "base";
                scale;
                desc { "default";
                    min: 600 250;
                    max: 600 250;
                }
            }
            rect { "bg";
                scale;
                desc { "default";
                    rel.to: "base";
                    color: 5 5 5 255;
                }
            }
            textblock { "tb1";
                scale;
                desc { "default";
                    rel.to: base;
                    rel1.relative: 0 0;
                    rel2.relative: 1 0.5;
                    text.text: "THIS IS FONT 1";
                    text.style: "textblock_style_1";
                }
            }
            textblock { "tb2";
                scale;
                desc { "default";
                    rel.to: base;
                    rel1.relative: 0 0.5;
                    rel2.relative: 1 1;
                    text.text: "THIS IS FONT 2";
                    text.style: "textblock_style_2";
                }
            }
        }
    }
}

Reviewers: smohanty, CHAN, Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11401

Change-Id: I53241e39de9c337a7959c6ed05a60dfc88eebcd2

4 years agoedje_cc_handlers: fix warning 09/225909/1
Taehyub Kim [Tue, 25 Feb 2020 08:32:31 +0000 (17:32 +0900)]
edje_cc_handlers: fix warning

Change-Id: Ie6f527dbfccf39e4b70f7c7b47457ecf8eb14ee6

4 years agoefl_ui_selection_manager: change parameter to unsigned int from Ecore_Wl2_Window * 31/225731/2
Yeongjong Lee [Mon, 24 Feb 2020 07:01:46 +0000 (16:01 +0900)]
efl_ui_selection_manager: change parameter to unsigned int from Ecore_Wl2_Window *

Tizen has not been appied patch which is to replace window ids with pointers
from upstream.
```
commit 78f27a3efff24ba3b935cc9e2620718e51af9304
Author: Derek Foreman <derekf@osg.samsung.com>
Date:   Fri Jul 6 10:16:21 2018 -0400

ecore_wl2: Replace window ids with pointers
```

To fix casting compiler warnings, we need to change parameter to `unsigned int`
from `Ecore_Wl2_Window *`.

@tizen_fix

Change-Id: Ifba51ba7f933a817ba98600924a956feb1c2f6b4

4 years agoefl_ui_selection_manager: fix casting warning for elm_win_wl_window_get API 30/225730/2
Yeongjong Lee [Mon, 24 Feb 2020 06:48:47 +0000 (15:48 +0900)]
efl_ui_selection_manager: fix casting warning for elm_win_wl_window_get API

@tizen_fix

Change-Id: If4f3f8c63b26f0feb57c6e70e064b2e36f05fefc

4 years agoelm_genlist: add content_loop_get method for genlist eo 83/225583/3
Yeongjong Lee [Fri, 21 Feb 2020 05:38:30 +0000 (14:38 +0900)]
elm_genlist: add content_loop_get method for genlist eo

Fixes `-Wunused-function`.

@tizen_fix

Change-Id: I09f47346794e3d0d751b00fa1a48fb86ec061c0a

4 years agoelementary_tizen: fix compiler warnings 26/225626/2
Yeongjong Lee [Fri, 21 Feb 2020 07:36:59 +0000 (16:36 +0900)]
elementary_tizen: fix compiler warnings

 - Unused functions, variables and label are removed.
 - ELM_FOCUS enum is replaced with EFL_UI_FOCUS_DIRECTION enum.

note:
`_elm_genlist_efl_object_finalize` should have been removed at commit
84819f36f83696caa143fdf72e9f4f1cdbcc1200.

@tizen_fix

Change-Id: I14ce88ab7ef0a02c43ff2db57e537d0746cd35a2

4 years agoevas_engine: fix warning 70/225770/2
Taehyub Kim [Mon, 24 Feb 2020 09:32:47 +0000 (18:32 +0900)]
evas_engine: fix warning

Change-Id: I4f79a8565d17cefb6f948675c20ca6487674f41a

4 years agoefl_ui_slider: remove unused functions 03/225703/2
Yeongjong Lee [Mon, 24 Feb 2020 05:06:13 +0000 (14:06 +0900)]
efl_ui_slider: remove unused functions

@tizen_fix
Change-Id: Iacdeefd5d780aa1c085141eb07b89dec135a95d7

4 years agodatabase_expr: fix memory leak when type error happens 34/225834/2
Jaehyun Cho [Mon, 24 Feb 2020 14:52:25 +0000 (15:52 +0100)]
database_expr: fix memory leak when type error happens

Summary: Memory leak is fixed when type error happens.

Reviewers: q66

Reviewed By: q66

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11400

Change-Id: Ifa3f5f1d7bea3f0e3499a98729c31ce7094f7283

4 years agoevas_gl_context: fix warning 68/225768/3
Taehyub Kim [Mon, 24 Feb 2020 09:31:03 +0000 (18:31 +0900)]
evas_gl_context: fix warning

Change-Id: Ib7834dfc78a3df3bb6d3d6ed808bad662a8718ee

4 years agovg_common_json: Fix to duplication of mask and matte.
JunsuChoi [Tue, 25 Feb 2020 02:54:57 +0000 (11:54 +0900)]
vg_common_json: Fix to duplication of mask and matte.

Summary:
There is a case that uses a mask and a mat at the same time.
One of them did not apply. This patch modifies two attributes to be parent-child.

Test Plan: N/A

Reviewers: Hermet, smohanty, kimcinoo

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11399

Change-Id: I14b1e2ab38c042c6845b2232ca8a7b79abccc8c6

4 years agoemile_image: fix warning for COLORSPACE_PALETTE 53/225753/2
Taehyub Kim [Mon, 24 Feb 2020 09:03:03 +0000 (18:03 +0900)]
emile_image: fix warning for COLORSPACE_PALETTE

Change-Id: Idf34992f40015972853b4b4259cc9100c75d02ef

4 years agoefl_ui_win: fix return value 36/225736/2
Yeongjong Lee [Mon, 24 Feb 2020 05:20:57 +0000 (14:20 +0900)]
efl_ui_win: fix return value

@tizen_fix

Change-Id: I65920785747f2bf65dc952b22ab23c2607197d22

4 years agoefl_ui_win: fix casting warnings of Win_Keyboard_Mode 35/225735/2
Yeongjong Lee [Mon, 24 Feb 2020 05:19:45 +0000 (14:19 +0900)]
efl_ui_win: fix casting warnings of Win_Keyboard_Mode

@tizen_fix

Change-Id: I338a7bb0df8bba81a35519eb95a3035e01873e1c

4 years agobuild: fix compiler warnings related to const qualifier 16/225716/2
Yeongjong Lee [Mon, 24 Feb 2020 06:20:05 +0000 (15:20 +0900)]
build: fix compiler warnings related to const qualifier

@tizen_fix

Change-Id: I9992862a849c36227616ff91c4449107f7a4c1bb

4 years agoelm_interface_scrollable: comment out unused goto label 32/225732/2
Yeongjong Lee [Mon, 24 Feb 2020 03:56:04 +0000 (12:56 +0900)]
elm_interface_scrollable: comment out unused goto label

Fixes `-Wunused-label`
```
../src/lib/elementary/elm_interface_scrollable.c:1190:1: warning: label 'skip_bars' defined but not used [-Wunused-label]
 1190 | skip_bars:
```e

@tizen_fix

Change-Id: Ib4b9bc83d79379c02b5785a9961efca3a1127047

4 years agoelm_atspi_bridge: fix return type 12/225712/2
Yeongjong Lee [Mon, 24 Feb 2020 05:55:13 +0000 (14:55 +0900)]
elm_atspi_bridge: fix return type

Fixes `-Wint-conversion` compiler warning.
```
../src/lib/elementary/elm_atspi_bridge.c:7248:14: warning: returning 'void *' from a function with return type 'Eina_Bool' {aka 'unsigned char'} makes integer from pointer without a cast [-Wint-conversion]
  7248 |       return NULL;
```

@tizen_fix

Change-Id: Ie9d4ea80b209210616ef498e3122963cbe4cf169

4 years agoelm_atspi_bridge: correct EFL_EVNET_DEL callback parameters 00/225700/2
Yeongjong Lee [Mon, 24 Feb 2020 04:02:40 +0000 (13:02 +0900)]
elm_atspi_bridge: correct EFL_EVNET_DEL callback parameters

Fixes `-Wincompatible-pointer-types` compiler warnings.

@tizen_fix

Change-Id: I413ed239f6f5bfdad07b10823b6956af865f2614

4 years agoelm_config: remove redundant code 01/225701/2
Yeongjong Lee [Mon, 24 Feb 2020 04:53:30 +0000 (13:53 +0900)]
elm_config: remove redundant code

`theme_overlay_mmap` is freed by following step.
 `_elm_theme_file_clean` - `_elm_theme_clear` - `_elm_theme_free_internal` -
`_efl_ui_theme_efl_object_destructor`.
We don't need to call explicit del.

@tizen_fix

Change-Id: Icf522386e51321297b78746d9371b9476db56a38

4 years agoelementary: remove unused variable in tizen only code 76/225576/3
Yeongjong Lee [Fri, 21 Feb 2020 05:00:06 +0000 (14:00 +0900)]
elementary: remove unused variable in tizen only code

Fixes '-Wunused-variable' compiler warnings.

@tizen_fix
Change-Id: I462ca6212f97f00e628e839b19e1b05f4f1dd7ca

4 years agoecje_cc_handlers: fix warning 42/225742/1
Taehyub Kim [Mon, 24 Feb 2020 07:41:03 +0000 (16:41 +0900)]
ecje_cc_handlers: fix warning

Change-Id: Ibf2fc18f16ed6d9fc05c3c270647680a17f16ecb