Sanjay Patel [Wed, 3 Feb 2021 14:22:51 +0000 (09:22 -0500)]
[LoopVectorize] add test for fake min/max; NFC
This goes with the dyn_cast fix:
0fa61304d247a61
That was made after noticing that the assert was over-reaching here:
bbed5f2f8a ( D95690 )
Simon Pilgrim [Wed, 3 Feb 2021 13:26:36 +0000 (13:26 +0000)]
[X86][SSE] Support variable-index float/double vector insertion on SSE41+ targets (PR47924)
Extends D95779 to permit insertion into float/doubles vectors while avoiding a lot of aliased memory traffic.
The scalar value is already on the simd unit, so we only need to transfer and splat the index value, then perform the select.
SSE4 codegen is a little bulky due to the tied register requirements of (non-VEX) BLENDPS/PD but the extra moves are cheap so shouldn't be an actual problem.
Differential Revision: https://reviews.llvm.org/D95866
Anastasia Stulova [Wed, 3 Feb 2021 14:04:13 +0000 (14:04 +0000)]
[OpenCL][Docs] Fix command line flag in the example.
Fixed incorrect example of clang command line with
the builtin function declarations in OpenCLSupport.
Tags: #clang
Ilya Mirsky [Mon, 18 Jan 2021 00:02:44 +0000 (18:02 -0600)]
[Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item
Patch by Ilya Mirsky!
Fixes: http://llvm.org/PR44343
Reviewed By: rsmith
Differential Revision: https://reviews.llvm.org/D71714
Anastasia Stulova [Wed, 3 Feb 2021 11:05:00 +0000 (11:05 +0000)]
[OpenCL] Fix address space in binding of initializer lists to referencs
Prevent materializing temporaries in the address space of the references
they are bind to. The temporaries should always be in the same address
space - private for OpenCL.
Tags: #clang
Differential Revision: https://reviews.llvm.org/D95608
Matthew Parkinson [Wed, 3 Feb 2021 11:28:43 +0000 (11:28 +0000)]
Fix MLIR Async Runtime DLL on Windows
The AsyncRuntime declares prototypes for extern "C" functions inside a
namespace in the header, but not inside that namespace in the
definition. This causes Visual Studio to treat them as different
entities and thus the dllexport is ignored for the definitions.
Using the same namespace fixes this issue.
Secondly, this commit moves the dllexport to be consistent with the
JITs expectation.
This is an update to https://reviews.llvm.org/D95386 that fixes the
compile issues in old versions of Visual studio.
Differential Revision: https://reviews.llvm.org/D95933
Ben Shi [Wed, 3 Feb 2021 12:00:06 +0000 (20:00 +0800)]
[clang][AVR][NFC] Fix a typo
Fix a typo in commit
d38973aa4d6a2c8be97b9781ca7325ca3eb0c40d
Utkarsh Saxena [Mon, 1 Feb 2021 20:17:53 +0000 (21:17 +0100)]
[clangd] Report xref for base methods.
See: https://github.com/clangd/clangd/issues/668
```
struct A { virtual void foo() = 0; };
struct B : A { void foo() override; };
```
Find refs on `B::foo()` will show:
- decls of `A::foo()` (new)
- decls of `B::foo()`
- refs to `A::foo()` (new)
- refs to `B::foo()`.
Differential Revision: https://reviews.llvm.org/D95852
Praveen [Wed, 3 Feb 2021 10:18:30 +0000 (15:48 +0530)]
[Flang][OpenMP] Add semantic checks for invalid branches into or out of OpenMP constructs
OpenMP 4.5 - Check invalid branches into OpenMP strucutred blocks.
Check invalid branches leaving OpenMP structured blocks.
Test cases : omp-do-cycle.f90, omp-invalid-branch.f90
Resolve related test cases marked as XFAIL
Reviewed By: kiranchandramohan
Differential Revision: https://reviews.llvm.org/D92735
Sven van Haastregt [Wed, 3 Feb 2021 10:23:52 +0000 (10:23 +0000)]
[OpenCL] Add cl_khr_subgroup_non_uniform_vote to TableGen BIFs
Add the builtin functions brought by the
cl_khr_subgroup_non_uniform_vote extension to
`-fdeclare-opencl-builtins`.
Sven van Haastregt [Tue, 2 Feb 2021 17:20:38 +0000 (17:20 +0000)]
[OpenCL] Add cl_khr_subgroup_ballot to TableGen BIFs
Add the builtin functions brought by the cl_khr_subgroup_ballot
extension to `-fdeclare-opencl-builtins`.
Also add placeholder comments for the other Extended Subgroup
Functions from the OpenCL Extension Specification.
Add a comment clarifying the scope of the test.
Differential Revision: https://reviews.llvm.org/D95523
Ben Shi [Wed, 3 Feb 2021 10:23:01 +0000 (18:23 +0800)]
[clang][AVR] Improve avr-ld command line options
Reviewed By: dylanmckay, MaskRay
Differential Revision: https://reviews.llvm.org/D93579
Sebastian Neubauer [Wed, 3 Feb 2021 10:00:30 +0000 (11:00 +0100)]
Revert "[AMDGPU] Add a new Clamp Pattern to the GlobalISel Path."
This reverts commits
62af0305b7cc..
677a3529d3e6 from D93708.
They cause failures in the sanitizer builds because of uninitialized
values.
A fix is in D95878, but it might take some time until this is pushed,
so reverting the changes for now.
Caroline Concatto [Thu, 28 Jan 2021 08:46:44 +0000 (08:46 +0000)]
[AArch64][SVE]Add cost model for broadcast shuffle
This patch adds a cost model for SK_Broadcast in
AArch64TTIImpl::getShuffleCost with scalable vector.
Without this patch, the scalable vector type relies on BasicTTIImpl cost
implementation and assert.
Differential Revision: https://reviews.llvm.org/D95598
Andre Vieira [Wed, 3 Feb 2021 09:28:42 +0000 (09:28 +0000)]
[LIBC] Add optimized memcpy routine for AArch64
This patch adds an optimized memcpy routine for AArch64 tuned and benchmarked
on Neoverse-N1.
Differential Revision: https://reviews.llvm.org/D92235
David Sherwood [Fri, 29 Jan 2021 11:46:41 +0000 (11:46 +0000)]
[VPlan][NFC] Introduce constructors for VPIteration
This patch adds constructors to VPIteration as a cleaner way of
initialising the struct and replaces existing constructions of
the form:
{Part, Lane}
with
VPIteration(Part, Lane)
I have also added a default constructor, which is used by VPlan.cpp
when deciding whether to replicate a block or not.
This refactoring will be required in a later patch that adds more
members and functions to VPIteration.
Differential Revision: https://reviews.llvm.org/D95676
Wang, Pengfei [Wed, 3 Feb 2021 08:04:12 +0000 (16:04 +0800)]
[X86] Correct types in tablegen multiclasses found by D95874.
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D95926
Sam McCall [Wed, 3 Feb 2021 07:30:45 +0000 (08:30 +0100)]
[clang-include-fixer] Pre-reserve vector size. NFC
Martin Storsjö [Wed, 4 Nov 2020 21:51:18 +0000 (23:51 +0200)]
[libcxx] Implement the read_symlink function for windows
Differential Revision: https://reviews.llvm.org/D91172
Martin Storsjö [Wed, 4 Nov 2020 21:55:10 +0000 (23:55 +0200)]
[libcxx] Implement the permissions function for windows
Differential Revision: https://reviews.llvm.org/D91171
Petr Hosek [Sat, 13 Jul 2019 21:02:07 +0000 (14:02 -0700)]
[InstrProfiling] Use !associated metadata for counters, data and values
C identifier name input sections such as __llvm_prf_* are GC roots so
they cannot be discarded. In LLD, the SHF_LINK_ORDER flag overrides the
C identifier name semantics.
The !associated metadata may be attached to a global object declaration
with a single argument that references another global object, and it
gets lowered to SHF_LINK_ORDER flag. When a function symbol is discarded
by the linker, setting up !associated metadata allows linker to discard
counters, data and values associated with that function symbol.
Note that !associated metadata is only supported by ELF, it does not have
any effect on non-ELF targets.
Differential Revision: https://reviews.llvm.org/D76802
Kazu Hirata [Wed, 3 Feb 2021 06:52:48 +0000 (22:52 -0800)]
[AsmPrinter] Use ListSeparator (NFC)
Kazu Hirata [Wed, 3 Feb 2021 06:52:46 +0000 (22:52 -0800)]
[Transforms/Utils] Use range-based for loops (NFC)
Kazu Hirata [Wed, 3 Feb 2021 06:52:45 +0000 (22:52 -0800)]
[CodeGen] Drop unnecessary const from return types (NFC)
Identified with const-return-type.
LLVM GN Syncbot [Wed, 3 Feb 2021 05:46:53 +0000 (05:46 +0000)]
[gn build] Port
fcf03e728007
Hsiangkai Wang [Tue, 15 Dec 2020 23:23:35 +0000 (07:23 +0800)]
[RISCV] Load/store vector mask types.
Use vle1.v/vse1.v to load/store vector mask types.
Differential Revision: https://reviews.llvm.org/D93364
Pushpinder Singh [Tue, 19 Jan 2021 08:13:47 +0000 (13:43 +0530)]
[OpenMP] Add OpenMP offloading toolchain for AMDGPU
This patch adds AMDGPUOpenMPToolChain for supporting OpenMP
offloading to AMD GPU's.
Originally authored by Greg Rodgers
Reviewed By: jdoerfert
Differential Revision: https://reviews.llvm.org/D94961
Hsiangkai Wang [Mon, 1 Feb 2021 08:08:46 +0000 (16:08 +0800)]
[RISCV] Add new vector instructions in v0.10.
* Add new vector instructions in v0.10.
- load/store for mask value vle1.v vse1.v
- vsetivli for 0-31 immediate vector length.
* Rename vector instructions in v0.10.
- vfrsqrte7 -> vfrsqrt7
- vfrece7 -> vfrec7
* Reserve memory width encodings for EEW>128b.
Differential Revision: https://reviews.llvm.org/D95781
Arthur Eubanks [Thu, 28 Jan 2021 00:15:44 +0000 (16:15 -0800)]
[Docs] Update HowToSubmitABug
With the new PM imminent, bugpoint will diverge from opt, meaning it may
not reproduce a crash with the same arguments passed to opt. We need to
specify alternatives to bugpoint for reducing crashes.
I looked at the rest of the document to see if anything could be
improved. Major highlights:
* Run -Xclang -disable-llvm-passes instead of -O0 for skipping IR passes
* Mention the files that clang dumps on a crash
* Remove outdated reference to `delta` and plug `creduce` instead
* Mention llvm-reduce on top of bugpoint
* Mention --print-before-all --print-module-scope
* Mention sanitizers in addition to valgrind
* Mention opt-bisect for miscompiles
Reviewed By: fhahn, MaskRay
Differential Revision: https://reviews.llvm.org/D95578
Nathan James [Wed, 3 Feb 2021 05:18:00 +0000 (05:18 +0000)]
[NFC] Fix typo in comment
Jianzhou Zhao [Tue, 2 Feb 2021 18:09:22 +0000 (18:09 +0000)]
[dfsan] Wrap memmove
Reviewed-by: morehouse
Differential Revision: https://reviews.llvm.org/D95883
Nathan James [Wed, 3 Feb 2021 05:11:28 +0000 (05:11 +0000)]
[clang-tidy] Fix crash in readability-identifier-naming check
`isParamInMainLikeFunction` didn't check if the function had an identifer name before calling getName() which could lead to an assert.
Serguei Katkov [Tue, 2 Feb 2021 09:25:11 +0000 (16:25 +0700)]
[Statepoint] Handle 'undef' operand tied to def
FixupStatepoints pass does not take into account the undef use
it skips may have a tied def. So when defs are handled pass
considers that tied-use should be spilled and triggers an assert.
FixupStatepoints should skip undef def as well.
Reviewers: reames, dantrushin
Reviewed By: dantrushin
Subscribers: llvm-commits
Differential Revision: https://reviews.llvm.org/D95858
Yang Fan [Wed, 3 Feb 2021 03:04:58 +0000 (11:04 +0800)]
[CSSPGO] Fix MSVC initializing truncation warning (NFC)
MSVC warning:
```
\llvm-project\llvm\include\llvm\Transforms\IPO\SampleProfileProbe.h(65): warning C4305: 'initializing': truncation from 'double' to 'const float'
```
Yang Fan [Wed, 3 Feb 2021 02:48:39 +0000 (10:48 +0800)]
[clang-format] Fix MSVC "unsafe use of type 'bool' in operation" warning (NFC)
MSVC warning:
```
\llvm-project\clang\lib\Format\BreakableToken.cpp(1002): warning C4804: '-': unsafe use of type 'bool' in operation
```
Fangrui Song [Wed, 3 Feb 2021 02:28:37 +0000 (18:28 -0800)]
[yaml2obj][wasm] Support numeric relocation type
Differential Revision: https://reviews.llvm.org/D95661
Yang Fan [Wed, 3 Feb 2021 02:21:45 +0000 (10:21 +0800)]
[VFS] Fix Wreturn-type gcc warning (NFC)
GCC warning:
```
In file included from /llvm-project/llvm/lib/Support/VirtualFileSystem.cpp:13:
/llvm-project/llvm/include/llvm/Support/VirtualFileSystem.h: In static member function ‘static bool llvm::vfs::RedirectingFileSystem::RemapEntry::classof(const llvm::vfs::RedirectingFileSystem::Entry*)’:
/llvm-project/llvm/include/llvm/Support/VirtualFileSystem.h:681:5: warning: control reaches end of non-void function [-Wreturn-type]
681 | }
| ^
```
Chen Zheng [Wed, 3 Feb 2021 02:01:19 +0000 (21:01 -0500)]
[PowerPC] [NFC] fix wording typos
Post commit comments address for D92071.
Med Ismail Bennani [Wed, 3 Feb 2021 01:46:50 +0000 (02:46 +0100)]
[lldb/test] Stop recording fundamental return types (NFC)
It seems that recording fundamental return type is bogus.
This can trigger asserts when running a test with reproducers so this
patch updates the `SBTarget::IsLoaded` test to stop recording them.
Differential Revision: https://reviews.llvm.org/D95686
Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>
Matt Arsenault [Tue, 2 Feb 2021 21:22:32 +0000 (16:22 -0500)]
AMDGPU: Fix adding extra operands for i128 asm constraints
We don't register i128 as a legal type with addRegisterClass, but it
appears in the list of legal register types. This inconsistency
resulted in the asm constraint lowering trying to use 2 128-bit
registers for these operands. This would leave behind a dead def that
would waste registers.
Regresses GlobalISel tests for i128 load/store, but these aren't very
important right now. Ideally these would not depend on the list of
register types.
Matt Arsenault [Sat, 30 Jan 2021 18:15:53 +0000 (13:15 -0500)]
AMDGPU: Don't consider global pressure when bundling soft clauses
This should only consider whether the pressure impact of the bundle at
the given point in the program will decrease the occupancy. High VGPR
pressure was incorrectly blocking the formation of scalar bundles, and
vice versa. This was also blocking bundling from high pressure
situations at other points in the program.
Jessica Paquette [Tue, 2 Feb 2021 22:21:33 +0000 (14:21 -0800)]
[GlobalISel] Check if branches use the same MBB in matchOptBrCondByInvertingCond
If the G_BR + G_BRCOND in this combine use the same MBB, then it will infinite
loop. Don't allow that to happen.
Differential Revision: https://reviews.llvm.org/D95895
Siva Chandra [Tue, 2 Feb 2021 07:43:05 +0000 (23:43 -0800)]
[libc] Add hardware implementations of ceil and ceilf for aarch64.
This change also introduces a new source layout for adding machine
specific and generic implementations. To keep the scope of this change
small, this new pattern is only applied for ceil, ceilf and ceill.
Follow up changes will switch all math functions in to the new pattern.
Reviewed By: lntue
Differential Revision: https://reviews.llvm.org/D95850
Lei Zhang [Tue, 2 Feb 2021 23:30:41 +0000 (18:30 -0500)]
[mlir] Fix scf.for single iteration canonicalization check
We should be check whether lb + step >= ub to determine
whether this is a single iteration. Previously we were
checking lb + lb >= ub.
Reviewed By: ftynse
Differential Revision: https://reviews.llvm.org/D95440
Diego Caballero [Tue, 2 Feb 2021 22:39:41 +0000 (00:39 +0200)]
[mlir][Vector] Add lowering to LLVM for vector.bitcast
Add the conversion pattern for vector.bitcast to lower it to
the LLVM Dialect.
Reviewed By: ThomasRaoux, aartbik
Differential Revision: https://reviews.llvm.org/D95579
Fangrui Song [Tue, 2 Feb 2021 23:18:00 +0000 (15:18 -0800)]
[FileCheck] Make --allow-unused-prefixes cl::ZeroOrMore
cl::ZeroOrMore allows the option to be specified multiple times, which makes
downstream projects possible to specify a default value in lit configuration
while some tests can override the value.
peter klausler [Tue, 2 Feb 2021 22:39:05 +0000 (14:39 -0800)]
[flang] Add TypeAndShape::MeasureElementSizeInBytes()
Split up MeasureSizeInBytes() so that array element sizes can be
calculated accurately; use the new API in some places where
DynamicType::MeasureSizeInBytes() was being used but the new
API performs better due to TypeAndShape having precise CHARACTER
length information.
Differential Revision: https://reviews.llvm.org/D95897
Arthur Eubanks [Tue, 2 Feb 2021 22:45:45 +0000 (14:45 -0800)]
[test][NewPM] Pin various tests to the legacy PM
tut-simplify-cfg hasn't been ported to the new PM.
llvm-lto2's -enable-new-pm defaults to the CMake flag, so the legacy PM extension test needs to be pinned.
Reviewed By: MaskRay, ychen
Differential Revision: https://reviews.llvm.org/D95898
LLVM GN Syncbot [Tue, 2 Feb 2021 22:57:59 +0000 (22:57 +0000)]
[gn build] Port
4f58b1bd2974
Kyungwoo Lee [Tue, 2 Feb 2021 03:32:32 +0000 (22:32 -0500)]
[AArch64] Homogeneous Prolog and Epilog Size Optimization
Second land attempt. MachineVerifier DefRegState expensive check errors fixed.
Prologs and epilogs handle callee-save registers and tend to be irregular with
different immediate offsets that are not often handled by the MachineOutliner.
Commit D18619/
a5335647d5e8 (combining stack operations) stretched irregularity
further.
This patch tries to emit homogeneous stores and loads with the same offset for
prologs and epilogs respectively. We have observed that this canonicalizes
(homogenizes) prologs and epilogs significantly and results in a greatly
increased chance of outlining, resulting in a code size reduction.
Despite the above results, there are still size wins to be had that the
MachineOutliner does not provide due to the special handling X30/LR. To handle
the LR case, his patch custom-outlines prologs and epilogs in place. It does
this by doing the following:
* Injects HOM_Prolog and HOM_Epilog pseudo instructions during a Prolog and
Epilog Injection Pass.
* Lowers and optimizes said pseudos in a AArchLowerHomogneousPrologEpilog Pass.
* Outlined helpers are created on demand. Identical helpers are merged by the linker.
* An opt-in flag is introduced to enable this feature. Another threshold flag
is also introduced to control the aggressiveness of outlining for application's need.
This reduced an average of 4% of code size on LLVM-TestSuite/CTMark targeting arm64/-Oz.
Differential Revision: https://reviews.llvm.org/D76570
Mitch Phillips [Tue, 2 Feb 2021 22:46:25 +0000 (14:46 -0800)]
Revert "[GWP-ASan] Add aligned allocations."
This reverts commit
9dc06762470cb5a6cde8de5833cb75262e1bacb0.
Should not have been committed, was a bad rebase. Review still
continuing on D94830.
Mitch Phillips [Tue, 2 Feb 2021 22:32:28 +0000 (14:32 -0800)]
[GWP-ASan] Add locking around unwinder for atfork protection.
Unwinders (like libc's backtrace()) can call their own locks (like the
libdl lock). We need to let the unwinder release the locks before
forking. Wrap a new lock around the unwinder for atfork protection.
Reviewed By: eugenis
Differential Revision: https://reviews.llvm.org/D95889
Mitch Phillips [Thu, 14 Jan 2021 23:16:56 +0000 (15:16 -0800)]
[GWP-ASan] Add aligned allocations.
Adds a new allocation API to GWP-ASan that handles size+alignment
restrictions.
Differential Revision: https://reviews.llvm.org/D94830
Richard Smith [Wed, 27 Jan 2021 07:36:01 +0000 (23:36 -0800)]
Diagnose if a SLEB128 is too large to fit in an int64_t.
Previously we'd hit UB due to an invalid left shift operand.
Also fix the WASM emitter to properly use SLEB128 encoding instead of
ULEB128 encoding for signed fields so that negative numbers don't
result in overly-large values that we can't read back any more.
In passing, don't diagnose a non-canonical ULEB128 that fits in a uint64_t but
has redundant trailing zero bytes.
Reviewed By: dblaikie, aardappel
Differential Revision: https://reviews.llvm.org/D95510
Jianzhou Zhao [Thu, 28 Jan 2021 22:36:47 +0000 (22:36 +0000)]
[dfsan] Clean TLS after sigaction callbacks
DFSan uses TLS to pass metadata of arguments and return values. When an
instrumented function accesses the TLS, if a signal callback happens, and
the callback calls other instrumented functions with updating the same TLS,
the TLS is in an inconsistent state after the callback ends. This may cause
either under-tainting or over-tainting.
This fix follows MSan's workaround.
https://github.com/llvm/llvm-project/commit/
cb22c67a21e4b5e1ade65141117a70be318be072
It simply resets TLS at restore. This prevents from over-tainting. Although
under-tainting may still happen, a taint flow can be found eventually if we
run a DFSan-instrumented program multiple times. The alternative option is
saving the entire TLS. However the TLS storage takes 2k bytes, and signal calls
could be nested. So it does not seem worth.
This diff fixes sigaction. A following diff will be fixing signal.
Reviewed-by: morehouse
Differential Revision: https://reviews.llvm.org/D95642
Florian Hahn [Tue, 2 Feb 2021 17:01:40 +0000 (17:01 +0000)]
[ConstraintElimination] Skip pointer casts.
We should be able to look through pointer casts that do not impact the
value.
Martin Storsjö [Wed, 4 Nov 2020 21:51:12 +0000 (23:51 +0200)]
[libcxx] Implement the canonical function for windows
Differential Revision: https://reviews.llvm.org/D91170
Martin Storsjö [Wed, 4 Nov 2020 21:46:12 +0000 (23:46 +0200)]
[libcxx] Implement the current_path function for windows
Differential Revision: https://reviews.llvm.org/D91169
Louis Dionne [Tue, 2 Feb 2021 19:59:35 +0000 (14:59 -0500)]
[libc++] Add new queues for specific macOS system versions
This will allow running back-deployment testing on macOS only on systems
running the right version of macOS. For the time being, we're cheating
because we don't have actual machines running older than 10.15.
Mehdi Amini [Tue, 2 Feb 2021 20:53:59 +0000 (20:53 +0000)]
Revert "Fix namespace for MLIR Async Runtime"
This reverts commit
b7d80058ff4649d1a15ef930269458dbb17145d9.
The mlir-windows buildbot is broken.
Reid Kleckner [Mon, 1 Feb 2021 23:18:42 +0000 (15:18 -0800)]
Disable CFI in __get_elem to allow casting a pointer to uninitialized memory
Fixes usage of shared_ptr with CFI enabled, which is llvm.org/pr48993.
Differential Revision: https://reviews.llvm.org/D95827
Dave Lee [Mon, 1 Feb 2021 20:01:32 +0000 (12:01 -0800)]
[lldb] Convert assertTrue(a == b) to assertEqual(a, b)
Convert `assertTrue(a == b)` to `assertEqual(a, b)` to produce better failure messages.
These were mostly done via regex search & replace, with some manual fixes.
Differential Revision: https://reviews.llvm.org/D95813
Christopher Tetreault [Tue, 2 Feb 2021 20:09:09 +0000 (12:09 -0800)]
Revert "Ensure that InstructionCost actually implements a total ordering"
This reverts commit
b481cd519e07b3ad2bd3e81c89b0dd8efd68d6bc.
River Riddle [Tue, 2 Feb 2021 19:32:52 +0000 (11:32 -0800)]
[mlir][Pattern] Create a new IRRewriter class to enable sharing code with pattern rewrites
This revision adds two new classes, RewriterBase and IRRewriter. RewriterBase is a new shared base class between IRRewriter and PatternRewriter. PatternRewriter will continue to be the base class used to perform rewrites within a rewrite pattern. IRRewriter on the other hand, is a new class that allows for tracking IR rewrites from outside of a rewrite pattern. In this revision all of the old API from PatternRewriter is moved to RewriterBase, but the distinction between IRRewriter and PatternRewriter is kept on the chance that a necessary API divergence happens in the future.
Currently if you want to have some utility that transforms a piece of IR and share it between pattern and non-pattern code, you have to duplicate it. This revision enables the creation of utilities that can be invoked from rewrite patterns and normal transformation code:
```c++
void someSharedUtility(RewriterBase &rewriter, ...) {
// Some interesting IR mutation here.
}
// Some RewritePattern
LogicalResult MyPattern::matchAndRewrite(Operation *op, PatternRewriter &rewriter) {
...
someSharedUtility(rewriter, ...);
...
}
// Some Pass
void MyPass::runOnOperation() {
...
IRRewriter rewriter(...);
someSharedUtility(rewriter, ...);
}
```
Differential Revision: https://reviews.llvm.org/D94638
Eric Schweitz [Tue, 2 Feb 2021 18:56:50 +0000 (10:56 -0800)]
[flang][NFC] Update the CG rewrite pass.
Add description and dependencies.
Differential Revision: https://reviews.llvm.org/D95888
Hongtao Yu [Fri, 11 Dec 2020 20:18:31 +0000 (12:18 -0800)]
[CSSPGO] Introducing distribution factor for pseudo probe.
Sample re-annotation is required in LTO time to achieve a reasonable post-inline profile quality. However, we have seen that such LTO-time re-annotation degrades profile quality. This is mainly caused by preLTO code duplication that is done by passes such as loop unrolling, jump threading, indirect call promotion etc, where samples corresponding to a source location are aggregated multiple times due to the duplicates. In this change we are introducing a concept of distribution factor for pseudo probes so that samples can be distributed for duplicated probes scaled by a factor. We hope that optimizations duplicating code well-maintain the branch frequency information (BFI) based on which probe distribution factors are calculated. Distribution factors are updated at the end of preLTO pipeline to reflect an estimated portion of the real execution count.
This change also introduces a pseudo probe verifier that can be run after each IR passes to detect duplicated pseudo probes.
A saturated distribution factor stands for 1.0. A pesudo probe will carry a factor with the value ranged from 0.0 to 1.0. A 64-bit integral distribution factor field that represents [0.0, 1.0] is associated to each block probe. Unfortunately this cannot be done for callsite probes due to the size limitation of a 32-bit Dwarf discriminator. A 7-bit distribution factor is used instead.
Changes are also needed to the sample profile inliner to deal with prorated callsite counts. Call sites duplicated by PreLTO passes, when later on inlined in LTO time, should have the callees’s probe prorated based on the Prelink-computed distribution factors. The distribution factors should also be taken into account when computing hotness for inline candidates. Also, Indirect call promotion results in multiple callisites. The original samples should be distributed across them. This is fixed by adjusting the callisites' distribution factors.
Reviewed By: wmi
Differential Revision: https://reviews.llvm.org/D93264
Eric Schweitz [Tue, 2 Feb 2021 17:57:26 +0000 (09:57 -0800)]
[flang][NFC] Update #include.
Differential Revision: https://reviews.llvm.org/D95882
Christopher Tetreault [Tue, 2 Feb 2021 17:14:55 +0000 (09:14 -0800)]
Ensure that InstructionCost actually implements a total ordering
Previously, operator== would consider the actual equality of the pairs
(lhs.Value, lhs.State) == (rhs.Value, rhs.State). However, if an invalid
cost was involved in a call to operator<, only the state would be
compared. Thus, it was not the case that ({2, Invalid} < {3, Invalid} ||
{2, Invalid} > {3, Invalid} || {2, Invalid} == {3, Invalid}).
This patch implements a true total ordering, where cost state is
considered first, then value. While it's not really imporant that
{2, Invalid} be considered to be less than {3, Invalid}, it's not a
problem either. This patch also implements operator== in terms of
operator<, so the two definitions will be kept in sync.
Reviewed By: sdesmalen
Differential Revision: https://reviews.llvm.org/D95803
peter klausler [Mon, 1 Feb 2021 23:23:58 +0000 (15:23 -0800)]
[flang] Implement IEEE_SUPPORT_xxx inquiry functions
Implement IEEE_SUPPORT_DATATYPE() and other inquiry intrinisic
functions from the intrinsic module IEEE_ARITHMETIC, folding all of
their results to .TRUE.
Differential Revision: https://reviews.llvm.org/D95830
peter klausler [Mon, 1 Feb 2021 23:26:48 +0000 (15:26 -0800)]
[flang] Detect UBOUND() error on assumed-size array
UBOUND() is not allowed on the last dimension of an
assumed-size array dummy argument.
Differential Revision: https://reviews.llvm.org/D95831
Fangrui Song [Tue, 2 Feb 2021 19:22:46 +0000 (11:22 -0800)]
[test] Default clang/test to FileCheck --allow-unused-prefixes=false
Matthew Parkinson [Tue, 2 Feb 2021 18:15:19 +0000 (18:15 +0000)]
Fix namespace for MLIR Async Runtime
The MLIR Async runtime uses different namespacing for the header file,
and the definitions of its C API. The header file places the extern "C"
functions inside namespace mlir::runtime, and the definitions are not
in a namespace. This causes issues in cl.exe. It treats the declaration
and definition as different, and thus does not apply dllexport to the
definition, which leads to the mlir_async_runtime.dll containing no
definitions, and the mlir_async_runtime.lib not being generated.
This patch moves the namespace to cover the definitions, and thus
generates the dll correctly on Windows with cl.exe.
This was tested with Visual Studio C++ 19.28.29336.
Differential Revision: https://reviews.llvm.org/D95386
Michał Górny [Tue, 2 Feb 2021 19:09:45 +0000 (13:09 -0600)]
[MLIR] [CMake] Support building MLIR standalone
Add the necessary bits to CMakeLists to make it possible to configure
MLIR against installed LLVM, and build it with minimal need for LLVM
source tree. The latter is only necessary to run unittests, and if it
is missing then unittests are skipped with a warning.
This change includes the necessary changes to tests, in particular
adding some missing substitutions and defining missing variables
for lit.site.cfg.py substitution.
Reviewed By: stephenneuendorffer
Differential Revision: https://reviews.llvm.org/D85464
Co-authored-by: Isuru Fernando <isuruf@gmail.com>
Christian Sigg [Tue, 2 Feb 2021 14:42:16 +0000 (15:42 +0100)]
[mlir] Delay adding the __resume function
The __resume function trips up LLVM's 'X86 DAG->DAG Instruction Selection' unless optimizations are disabled.
Only adding the __resume function when it's needed allows lowering through AsyncToLLVM and LLVM without '-O0' as long as the coroutine functionality is not used.
Reviewed By: ezhulenev
Differential Revision: https://reviews.llvm.org/D95868
Mehdi Amini [Tue, 2 Feb 2021 18:47:10 +0000 (18:47 +0000)]
Fix CMake LLVM_TARGETS_TO_BUILD "Native" option to work with JIT
LLVM_TARGETS_TO_BUILD accepts both "host" or "Native" for auto-selecting
the target from the environment. However the way "Native" was plumbed
would lead to the JIT environment being disabled. This patch is making
"Native" works just as "host".
Reviewed By: rnk
Differential Revision: https://reviews.llvm.org/D95837
Fraser Cormack [Tue, 2 Feb 2021 14:40:52 +0000 (14:40 +0000)]
[RISCV] Fix incorrect RVV sdiv/udiv lowering
Due to a clerical error, the sdiv operation was mapping to vdivu and
udiv to vdiv, when the opposite mapping is the correct one.
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D95869
Craig Topper [Tue, 2 Feb 2021 18:32:14 +0000 (10:32 -0800)]
[RISCV] Correct types in tablegen multiclasses found by D95874.
Vladislav Vinogradov [Tue, 2 Feb 2021 18:33:08 +0000 (18:33 +0000)]
[mlir] Return new Operation from `Rewriter::replaceOpWithNewOp`
It will allow to perform additional manipulation with the newly created Operation.
For example, custom attributes propagation/changes.
Reviewed By: ftynse
Differential Revision: https://reviews.llvm.org/D95525
Jonas Devlieghere [Tue, 2 Feb 2021 18:28:59 +0000 (10:28 -0800)]
[debugserver] Fix -Wmissing-field-initializers warnings on arm64
Vladislav Vinogradov [Tue, 2 Feb 2021 18:27:26 +0000 (18:27 +0000)]
[mlir] Print more verbose message in case of type inference error
Include the types into the error message.
Reviewed By: ftynse
Differential Revision: https://reviews.llvm.org/D95854
Vladislav Vinogradov [Tue, 2 Feb 2021 18:26:31 +0000 (18:26 +0000)]
[mlir] Allow to use constant lambda as callbacks for `TypeConverter`
Reviewed By: rriddle
Differential Revision: https://reviews.llvm.org/D95787
Vladislav Vinogradov [Tue, 2 Feb 2021 18:26:05 +0000 (18:26 +0000)]
[mlir][NFC] Add missing include guards to MlirOptMain.h
Reviewed By: mehdi_amini
Differential Revision: https://reviews.llvm.org/D95533
Vladislav Vinogradov [Tue, 2 Feb 2021 18:24:06 +0000 (18:24 +0000)]
[mlir][NFC] Use explicit `mlir` namespace in generated code
This makes the generated code independent from actual namespace of its users.
Reviewed By: rriddle
Differential Revision: https://reviews.llvm.org/D95520
Jonas Devlieghere [Tue, 2 Feb 2021 18:23:22 +0000 (10:23 -0800)]
[debugserver] Fix -Wsign-compare warnings on arm64
Fangrui Song [Tue, 2 Feb 2021 18:23:14 +0000 (10:23 -0800)]
[ConstraintElimination] Fix -Wunused-function in -DLLVM_ENABLE_ASSERTIONS=off build
Craig Topper [Tue, 2 Feb 2021 18:05:33 +0000 (10:05 -0800)]
[RISCV] Use a ComplexPattern to merge isel patterns for vector load/store with GPR and FrameIndex addresses.
This reduces the isel table size by about 3000 bytes.
Reviewed By: frasercrmck
Differential Revision: https://reviews.llvm.org/D95844
Jonas Devlieghere [Tue, 2 Feb 2021 18:19:23 +0000 (10:19 -0800)]
[debugserver] Fix -Wunused-function warnings on arm64
Mike Rice [Tue, 2 Feb 2021 04:17:56 +0000 (20:17 -0800)]
[OpenMP] Fix iterations calculation for dependent counters.
The number of iterations calculation was failing in some cases with more
than two collpased loops. Now the LoopIterationSpace selected matches
InitDependOnLC and CondDependOnLC.
Differential Revision: https://reviews.llvm.org/D95834
Greg McGary [Tue, 19 Jan 2021 15:44:42 +0000 (07:44 -0800)]
[lld-macho][NFC] refactor relocation handling
Add per-reloc-type attribute bits and migrate code from per-target file into target independent code, driven by reloc attributes.
Many cleanups
Differential Revision: https://reviews.llvm.org/D95121
Martin Storsjö [Wed, 4 Nov 2020 21:32:13 +0000 (23:32 +0200)]
[libcxx] Implement the space function for windows
Differential Revision: https://reviews.llvm.org/D91168
Fangrui Song [Tue, 2 Feb 2021 17:47:06 +0000 (09:47 -0800)]
[ELF] Delete unused --warn-ifunc-textrel
The option catches incompatibility between `R_*_IRELATIVE` and DT_TEXTREL/DF_TEXTREL
before glibc 2.29. Newer glibc versions are more common nowadays and I don't
think this option has ever been used. Diagnosing this problem is also
straightforward by reading the stack trace.
Hongtao Yu [Fri, 22 Jan 2021 23:52:46 +0000 (15:52 -0800)]
[CSSPGO] Passing the clang driver switch -fpseudo-probe-for-profiling to the linker.
As titled.
Reviewed By: wmi, wenlei
Differential Revision: https://reviews.llvm.org/D95271
Jonas Devlieghere [Tue, 2 Feb 2021 17:40:08 +0000 (09:40 -0800)]
[debugserver] Fix -Winconsistent-missing-override warnings on arm64
Fangrui Song [Tue, 2 Feb 2021 17:41:05 +0000 (09:41 -0800)]
[MC] Upgrade DWARF version to 5 upon .file 0
Without `-dwarf-version`, llvm-mc uses the default `MCContext::DwarfVersion` 4.
Without `-gdwarf-N`, Clang cc1as uses `clang::driver::ToolChain::GetDefaultDwarfVersion`
which is 4 on many toolchains. Note: `clang -c` can synthesize .debug_info without -g.
There is currently a MCParser warning upon `.file 0` and MCParser errors upon
`.loc 0` if the DWARF version is less than 5. This causes friction to the
following usage:
```
clang -S -g -gdwarf-5 a.c
// MC warning due to .file 0, MC error due to .loc 0
clang -c a.s
llvm-mc -filetype=obj a.s
```
My idea is that we can just upgrade `MCContext::DwarfVersion` to 5 upon
`.file 0` to make the above commands work.
The downside is that for an explicit version `clang -c -gdwarf-4 a.s`, it can be
argued that the new behavior drops the probably intended diagnostic. I think the
downside is small because in most cases DWARF version for an assembly action
should either match the original compile action or be omitted.
Ongoing discussion taking a similar action for GNU as: https://sourceware.org/pipermail/binutils/2021-January/114980.html
Differential Revision: https://reviews.llvm.org/D94882
Florian Hahn [Tue, 2 Feb 2021 16:59:18 +0000 (16:59 +0000)]
[ConstraintElimination] Add test with pointer bitcast.
Fangrui Song [Tue, 2 Feb 2021 17:35:27 +0000 (09:35 -0800)]
[test] Add basic _Unwind_ForcedUnwind + exception tests
Forced unwinding is like a foreign exception, which can be caught by `catch (...)` and rethrown.
If not rethrown, `__cxa_end_cath` will call `_Unwind_DeleteException` to destroy the object.
The behavior going through empty `throw()` and non-empty `throw(int)` is not
clear (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98785), so I do not add such
tests.
Differential Revision: https://reviews.llvm.org/D95200
Fangrui Song [Tue, 2 Feb 2021 17:34:08 +0000 (09:34 -0800)]
[MC] Support SHF_GNU_RETAIN as section flag 'R'
On Linux target triples, GNU as sets EI_OSABI to ELFOSABI_GNU when SHF_GNU_RETAIN is used。
On `*-*-freebsd`, it usually sets EI_OSABI to ELFOSABI_FREEBSD.
GNU ld respects SHF_GNU_RETAIN only for ELFOSABI_FREEBSD/ELFOSABI_GNU.
https://sourceware.org/bugzilla/show_bug.cgi?id=27282
MC doesn't set ELFOSABI_GNU for SHF_GNU_RETAIN/STB_GNU_UNIQUE/STT_GNU_IFUNC.
MC assembled object files do not have special semantics in GNU ld.
Reviewed By: psmith
Differential Revision: https://reviews.llvm.org/D95730
Fangrui Song [Tue, 2 Feb 2021 17:19:53 +0000 (09:19 -0800)]
[yaml2obj/obj2yaml/llvm-readobj] Support SHF_GNU_RETAIN
In binutils, the flag is defined for ELFOSABI_GNU and ELFOSABI_FREEBSD.
It can be used to mark a section as a GC root.
In practice, the flag has generic semantics and can be applied to many
EI_OSABI values, so we consider it generic.
Differential Revision: https://reviews.llvm.org/D95728
Sanjay Patel [Tue, 2 Feb 2021 16:02:07 +0000 (11:02 -0500)]
[ExpandReductions] add test for fmin with FMF; NFC
Jeroen Dobbelaere [Tue, 2 Feb 2021 16:55:06 +0000 (17:55 +0100)]
[InlineFunction] Only update noalias scopes once for an instruction.
Inlining sometimes maps different instructions to be inlined onto the same instruction.
We must ensure to only remap the noalias scopes once. Otherwise the scope might disappear (at best).
This patch ensures that we only replace scopes for which the mapping is known.
This approach is preferred over tracking which instructions we already handled in a SmallPtrSet,
as that one will need more memory.
Reviewed By: nikic
Differential Revision: https://reviews.llvm.org/D95862