[flang] Merge pull request flang-compiler/f18#751 from flang-compiler/sjs-style-update

Update C++style.md

Original-commit: flang-compiler/f18@ab0cce154634900f64c8a6184d5e0302f790e5d6
Reviewed-on: https://github.com/flang-compiler/f18/pull/751

[flang] Update C++style.md

Original-commit: flang-compiler/f18@d453fdda31dc6ff479d21fc3009c07c076b51a71
Reviewed-on: https://github.com/flang-compiler/f18/pull/751

[flang] Update C++style.md

Add guidelines for error messages and commas.  Add a version number for clang-format. Add spaces before ### sections to restart numbering.

Original-commit: flang-compiler/f18@3e8db49f34e2dc47ce5b89af6099710f708f64c3
Reviewed-on: https://github.com/flang-compiler/f18/pull/751
Tree-same-pre-rewrite: false

[flang] Merge pull request flang-compiler/f18#758 from flang-compiler/tsk-modfiles

Improve module file reading and writing

Original-commit: flang-compiler/f18@b5f48dfc461db37650a54aea3e29531b577fd871
Reviewed-on: https://github.com/flang-compiler/f18/pull/758

[flang] Fix tests that use the same .mod file

The tests run by `test_any.sh` don't redirect their .mod files to
a different directory so they occasionally fail when the same file
is accessed by different tests at the same time. With locking of
module files implemented, this problem reproduces much more reliably

Work around it by changing the module names to be distinct. Also remove
some comments left over when copied from `test_symbols.sh` tests.

Original-commit: flang-compiler/f18@f7b5c5f0fcbbac4736940761e6d43ec76a3a372a
Reviewed-on: https://github.com/flang-compiler/f18/pull/758

[flang] Improve module file reading and writing

Fix problems with writing a mod file while another compilation is
reading or writing. Write to a temp and then rename it:
- compute the new contents of the .mod file
- if it already exists, check if it is already correct
- if not, write new contents to a temp file
- rename the temp to the final destination

`mkstemps()` seems to be the best way to create the temp file.
It returns a file descriptor, so change the rest of the mod file
writing to use POSIX open/read/write/close. This seems to set
errno more reliably too.

There is some extra work around creating the temp to make it have
the same directory and suffix as the final file (so that if one gets
left behind by a crash, "rm *.mod" still cleans it up).
`mkstemps()` creates file with 0600 permissions so try to change it
to what it would have been if we just wrote the file.

Change module file reading to only read the file once; we used to
read it to verify the checksum and then again to parse it.
Instead, change `Parsing` so that we can get the file contents
after `Prescan()` and use that to verify the checksum. Also, it has
a mechanism for searching directories for files, so make use of that
instead of duplicating that functionality in `ModFileReader`.
This requires some changes to how errors are returned so they can
be reported in the right place.

Original-commit: flang-compiler/f18@d0d54971a5547820f8ed0271eb9818557bc8bc82
Reviewed-on: https://github.com/flang-compiler/f18/pull/758
Tree-same-pre-rewrite: false

[flang] Merge pull request flang-compiler/f18#760 from flang-compiler/pmk-fix-build

Fix build on OSX

Original-commit: flang-compiler/f18@61dcae34429c0c49d05b0b0652f0811f56923d49
Reviewed-on: https://github.com/flang-compiler/f18/pull/760

[flang] Fix build on OSX

Original-commit: flang-compiler/f18@453b03af1c594e32b1a3b6f994da5bfc9bc7eca7
Reviewed-on: https://github.com/flang-compiler/f18/pull/760

[flang] Merge pull request flang-compiler/f18#755 from flang-compiler/pmk-spec-expr

Check specification expression constraints (10.1.11)

Original-commit: flang-compiler/f18@0c99f8dc8e583fd7425514cff0ce31bc8b1a13db
Reviewed-on: https://github.com/flang-compiler/f18/pull/755

[flang] Address review comments

Original-commit: flang-compiler/f18@2393157d3fa9cdb870035986b6f56c81f481c4e7
Reviewed-on: https://github.com/flang-compiler/f18/pull/755

[flang] Clean up test results

Original-commit: flang-compiler/f18@7d3180160c83577f7bfb108ac047ce18b6ab1166
Reviewed-on: https://github.com/flang-compiler/f18/pull/755
Tree-same-pre-rewrite: false

[flang] Prep for review

Original-commit: flang-compiler/f18@8be02a41c7e0312a95ee4ea399318eb20c45ccce
Reviewed-on: https://github.com/flang-compiler/f18/pull/755
Tree-same-pre-rewrite: false

[flang] Remove dead code

Original-commit: flang-compiler/f18@4d90aad3614a00e0c37595a0643d1b282148c6cd
Reviewed-on: https://github.com/flang-compiler/f18/pull/755
Tree-same-pre-rewrite: false

[flang] Build with all compilers * versions

Original-commit: flang-compiler/f18@7332caa613696aa61dad848d8ed5790294edc7b9
Reviewed-on: https://github.com/flang-compiler/f18/pull/755
Tree-same-pre-rewrite: false

[flang] Complete conversions, delete old visitor

Original-commit: flang-compiler/f18@6ce1da55c8f62f60a3f3727ce8f2d01394d4133b
Reviewed-on: https://github.com/flang-compiler/f18/pull/755
Tree-same-pre-rewrite: false

[flang] more conversions to Traverse

Original-commit: flang-compiler/f18@e8668e23687f8cf0ae4a2300ed23a93a95b67470
Reviewed-on: https://github.com/flang-compiler/f18/pull/755
Tree-same-pre-rewrite: false

[flang] Refinements; replace several clients of old Visitor with new Traverse

Original-commit: flang-compiler/f18@0b44a86e31c0c7f84cf0c8dcafbedfb5e0e09c9f
Reviewed-on: https://github.com/flang-compiler/f18/pull/755
Tree-same-pre-rewrite: false

[flang] Redo IsInitialDataTarget

Original-commit: flang-compiler/f18@988c38e1f53115291a5e2a0c7e059cbb42bf096b
Reviewed-on: https://github.com/flang-compiler/f18/pull/755
Tree-same-pre-rewrite: false

[flang] Repackaging; tests pass

Original-commit: flang-compiler/f18@1fa7bb7717a1feb2e93e40c907ffe49c10f45332
Reviewed-on: https://github.com/flang-compiler/f18/pull/755
Tree-same-pre-rewrite: false

[flang] progress

Original-commit: flang-compiler/f18@b5e3e709cb0f9ee61124af3422372b01132e07be
Reviewed-on: https://github.com/flang-compiler/f18/pull/755
Tree-same-pre-rewrite: false

[flang] add test

Original-commit: flang-compiler/f18@ad2fa9dfdf2da204ad1c9ef510133b8ba43b41aa
Reviewed-on: https://github.com/flang-compiler/f18/pull/755
Tree-same-pre-rewrite: false

[flang] checkpoint

Original-commit: flang-compiler/f18@96ade8e6e9004a3f556defbb6f252214c9e38459
Reviewed-on: https://github.com/flang-compiler/f18/pull/755
Tree-same-pre-rewrite: false

[flang] checkpoint

Original-commit: flang-compiler/f18@782f44fe7d1cc23f6edac4b18104f932a6884490
Reviewed-on: https://github.com/flang-compiler/f18/pull/755
Tree-same-pre-rewrite: false

[flang] Merge pull request flang-compiler/f18#756 from flang-compiler/ps-do

Implementation of semantic checks C1135, C1167, and C1168

Original-commit: flang-compiler/f18@e43377f999862e22ddd141f95d9988a1ad5da8a4
Reviewed-on: https://github.com/flang-compiler/f18/pull/756

[flang] More responses to pull request comments.

Original-commit: flang-compiler/f18@0fb4cf1c9b3fe36e2c5075981e0d7ce61cb49aae
Reviewed-on: https://github.com/flang-compiler/f18/pull/756

[flang] More responses to comments in the pull request.  The big change was to
implement an enum class to indicate whether the statement being checked
is a CYCLE or EXIT statement.  This change rippled through a few
interfaces, resulting in cleaner, more readable code.  Thanks for the
tip, Tim!

Original-commit: flang-compiler/f18@e167c3d39fa95c93f402a0bfdf916dc10dbd80e1
Reviewed-on: https://github.com/flang-compiler/f18/pull/756
Tree-same-pre-rewrite: false

[flang] Responses to a comments in my previous pull request.

Original-commit: flang-compiler/f18@e0d73a45ac0f6de78bfa9db18d730b11555dcfc0
Reviewed-on: https://github.com/flang-compiler/f18/pull/756
Tree-same-pre-rewrite: false

[flang] Implementation of semantic checks C1135, C1167, and C1168

These constraints state that CYCLE and EXIT statements should not leave DO
CONCURRENT, CRITICAL, or CHANGE TEAM constructs.

I added checking code to check-do.cc and removed some superseded code from
check-do.cc and semantics.cc.  The new code uses the construct stack
implemented in my previous pull request.

I also added a new test -- dosemantics11.f90 and modified the tests
dosemantics10.f90, doconcurrent05.f90, and doconcurrent06.f90 to adapt to
the new error messages.  I converted these latter two tests to use
test_error.sh since they only reported errors.

Original-commit: flang-compiler/f18@b0bea7da64ee73a66a761b851d9e1f922ac94e16
Reviewed-on: https://github.com/flang-compiler/f18/pull/756
Tree-same-pre-rewrite: false

[flang] Merge pull request flang-compiler/f18#749 from flang-compiler/jpr-fix-724-2

Allow more argument types in some specific intrinsic

Original-commit: flang-compiler/f18@e379451c7f319b0bb811022af269f7ad45b190ac
Reviewed-on: https://github.com/flang-compiler/f18/pull/749

[flang] Fix typos and style in some comments

Original-commit: flang-compiler/f18@621ded353f6179045e8fc4c18ef13a4aa05293b9
Reviewed-on: https://github.com/flang-compiler/f18/pull/749

[flang] Refactor IntrinsicProcTable::Implementation::Probe for readability

Original-commit: flang-compiler/f18@4a7211e42bfc1d709246b13cc659356d738edd45
Reviewed-on: https://github.com/flang-compiler/f18/pull/749
Tree-same-pre-rewrite: false

[flang] Address editorial comments and use oxford comma

Original-commit: flang-compiler/f18@88a8d1be035b8aacab277526ebc09802cf22e176
Reviewed-on: https://github.com/flang-compiler/f18/pull/749
Tree-same-pre-rewrite: false

[flang] Allow more argument types in some specific intrinsic
Fix flang-compiler/f18#724.
Allow all type kinds for arguments in restricted specific conversion
intrinisc (no warning, this is ubiquitous).
Allow MAX/MIN restricted intrinsic (AMAX0...) to be replaced by the
related generic foolowed by a type conversion to the expected result
type of the specific. Emit a warning because xlf and ifort are doing so
but pgfortran is converting the arguments instead.

Original-commit: flang-compiler/f18@c07adb94ed2b2b46284d6a4a4b23c4189ea1d936
Reviewed-on: https://github.com/flang-compiler/f18/pull/749
Tree-same-pre-rewrite: false

[flang] Merge pull request flang-compiler/f18#752 from flang-compiler/tsk-issue746

Handle alternative names for relational operators

Original-commit: flang-compiler/f18@c448c2b1a59876e60db7134dda3594f6a991c2ef
Reviewed-on: https://github.com/flang-compiler/f18/pull/752

[flang] Handle alternative names for relational operators

10.1.6.2 says:
> The operators <, <=, >, >=, ==, and /= always have the same interpretations
> as the operators .LT., .LE., .GT., .GE., .EQ., and .NE., respectively.
That means we have to treat `operator(<)` like `operator(.lt.)`,
for example. `<>` is a third alias for `.NE.`.

We can't just choose always to use one form (e.g. replacing `operator(.lt.)`
with `operator(<)`). This is because all symbols names are `CharBlock`s
referring to the cooked character stream so that they have proper source
provenance. Also, if a user prefers one style and uses it consistently,
that's the form they should see in messages.

So the fix is to use whatever form is found in the source, but also to
look up symbols by the other names when necessary. To assist this, add
`GenericSpecInfo::GetAllNames()` to return all of the names of a generic
spec. Each place a generic spec can occur we have to use these to look
for the symbol.

Also reorganize the `AddUse()` overloads to work with this change.

Fixes flang-compiler/f18#746.

Original-commit: flang-compiler/f18@7f06f175d5033f0728f67b1be25ecd53df1f8de5
Reviewed-on: https://github.com/flang-compiler/f18/pull/752

[flang] Merge pull request flang-compiler/f18#754 from flang-compiler/tsk6

Clean up temp dirs

Original-commit: flang-compiler/f18@6e8f90127adf6bdce291f35ec28cf3054c727f0d
Reviewed-on: https://github.com/flang-compiler/f18/pull/754

[flang] Clean up temp dirs

A temp directory is created in `common.sh` and it is cleaned up by
`trap ... EXIT`. If the test script has its own trap, as this one does,
it seems to replace the first one. So the cleanup from `common.sh` was
not being executed when the `%t` feature was used and empty temp
directories were being left in the directory where the tests ran.

Since we already have a temp directory that is cleaned up, just use
that for `%t` and don't bother with another `mktemp`.

Original-commit: flang-compiler/f18@f61d62ddec011c1a6462ece12af29c5f0b16e60a
Reviewed-on: https://github.com/flang-compiler/f18/pull/754

[flang] [OpenMP] Simplify `OmpObject` with `std::variant`

Instead of using an `ENUM_CLASS Kind` to distinguish a `Designator`
or common-block name, change it to `std::variant`. If the `Name`
is available, then it is common-block name.

Original-commit: flang-compiler/f18@abf5db6171bc57eeddb58d22cd09e2344b023cad

[flang] Merge pull request flang-compiler/f18#743 from flang-compiler/jpr-fix-726

Prevent RESULT name from being the same as the function name

Original-commit: flang-compiler/f18@648d6b9eeaac17134ec5850493a3e60d7c7ad09b
Reviewed-on: https://github.com/flang-compiler/f18/pull/743

[flang] Address comment: make error a warning instead and ignore RESULT
Instead of emitting an error when RESULT has the same name as the
function, emit a warning and ignore RESULT in the rest of the
compilation.

Original-commit: flang-compiler/f18@8ce3862d39cee904b719ed68752237b20d9e154f
Reviewed-on: https://github.com/flang-compiler/f18/pull/743

[flang] Prevent RESULT name from being the same as the function.
Fix flang-compiler/f18#726.
Add test and error messsage for such scenario and set error on the
result symbol because it is unclear what it is inside the function.

Original-commit: flang-compiler/f18@a3d5b5af0d4a2537e2cd1cf84cae16e622d2c50c
Reviewed-on: https://github.com/flang-compiler/f18/pull/743
Tree-same-pre-rewrite: false

[flang] Merge pull request flang-compiler/f18#740 from flang-compiler/tsk5

Fix bugs with use-association renames

Original-commit: flang-compiler/f18@61d5c7a8c1caaf38b32bea32554c7691af5764f8
Reviewed-on: https://github.com/flang-compiler/f18/pull/740

[flang] Fix bugs with use-associated derived type with rename

When a derived type is use-associated with a rename, like
`use m, only: t2 => t1`
we need to record in the `DerivedTypeSpec` both the local-name in this
scope and the symbol for the derived type.

In most cases we need to work the the type symbol and its
`DerivedTypeDetails`, but when writing the type to the module file
we need the local-name. The name of the type symbol may be hidden
or not use-associated.

When analyzing a `parser::Name` we don't want to follow use-associations
because we could end up with the wrong name in a `DataRef` (i.e. the
use-name rather than the local-name). But that means that
`GetNamedConstantValue()` does have to follow them or named constants
won't always be folded.

Fixes flang-compiler/f18#729.

Original-commit: flang-compiler/f18@50d8921c6909d913774b4630b51bd3eb30ee34fc
Reviewed-on: https://github.com/flang-compiler/f18/pull/740

[flang] Fix renames in module files

When a module contains a use-association with rename, we have to be
careful to use the correct name (i.e. the local-name, not the use-name)
when writing out its `.mod` file.

When analyzing a `Name` in an expression, follow the use-association
for details, attributes, and constant values; but if we need to make a
`Designator` or `ProcedureDesignator`, use the local name.

Original-commit: flang-compiler/f18@8f07b803e141e34b3e512f8f02ef228186abe80f
Reviewed-on: https://github.com/flang-compiler/f18/pull/740
Tree-same-pre-rewrite: false

[flang] Refactoring

Eliminate two of the three overloadings of `Scope::MakeDerivedType()`.
Keep the one that has `Category` first because that's the order the
constructor of `DeclTypeSpec` uses.

In `mod-file.cc`, eliminate some calls to `PutLower()`. Symbols and
names are already lower case so they don't need to be converted.

In `modfile03.f90`, move the expected `.mod` file comments to right
after the corresponding modules. That makes it easier to work with.

Original-commit: flang-compiler/f18@86874d9bf8398391d3c24b0f0c8ed6c1e2c88185
Reviewed-on: https://github.com/flang-compiler/f18/pull/740
Tree-same-pre-rewrite: false

[flang] Merge pull request flang-compiler/f18#741 from flang-compiler/tsk-issue733

Fix bug merging generics on USE

Original-commit: flang-compiler/f18@5cedc81d15960f3a7349781d3f5f555abb0692c9
Reviewed-on: https://github.com/flang-compiler/f18/pull/741

[flang] Address review comment

Original-commit: flang-compiler/f18@134190f75e0481a63fe97343977bb3fe895c9a5c
Reviewed-on: https://github.com/flang-compiler/f18/pull/741

[flang] Better handling of merged generics

If a generic name is use-associated from two different modules and they
both have a specific procedure or both have a derived type with the same
name, report it as an error.

Original-commit: flang-compiler/f18@42369af96d3cca7ca2050592e728e04de8124bd8
Reviewed-on: https://github.com/flang-compiler/f18/pull/741
Tree-same-pre-rewrite: false

[flang] Fix bug merging generics on USE

When we use-associate the same generic name from two different modules
they are merged together. If the same specific procedure occurs in both
generics it should only occur once in the merged one.

Similarly, it's not an error if they both have a derived type or
specific procedure named the same as the generic, as long as they are
the same symbol.

Fixes flang-compiler/f18#733.

Original-commit: flang-compiler/f18@d37db076914ea40aece502b13b9059dc4c1b319b
Reviewed-on: https://github.com/flang-compiler/f18/pull/741
Tree-same-pre-rewrite: false

[flang] Merge pull request flang-compiler/f18#719 from DavidTruby/target

Semantic checks for target construct

Original-commit: flang-compiler/f18@2752d09c3a7f599c27de14fcef3846f9db39e97e
Reviewed-on: https://github.com/flang-compiler/f18/pull/719

[flang] Changed missing tofrom:scalar error message to be more descriptive

Original-commit: flang-compiler/f18@18e0a55a026f96e7afecafedd385efa697391ac2
Reviewed-on: https://github.com/flang-compiler/f18/pull/719

[flang] Added tofrom:scalar check for defaultmap clause

Original-commit: flang-compiler/f18@1025649b647f670aa05d7779319591440dae6c27
Reviewed-on: https://github.com/flang-compiler/f18/pull/719
Tree-same-pre-rewrite: false

[flang] Semantic checks for target construct

Original-commit: flang-compiler/f18@373391bc03359e11a80022f5058c5e91ec08cd0a
Reviewed-on: https://github.com/flang-compiler/f18/pull/719
Tree-same-pre-rewrite: false

[flang] Merge pull request flang-compiler/f18#745 from flang-compiler/pmk-call

Implement checks for test/semantics/call02.f90

Original-commit: flang-compiler/f18@45604a2d72d5d541b5de68aadb482d2f06d2c66a
Reviewed-on: https://github.com/flang-compiler/f18/pull/745

[flang] Remove periods from the ends of messages, per review comment

Original-commit: flang-compiler/f18@0ce32de0d62be7e6eb447fde074e661011b6fc1c
Reviewed-on: https://github.com/flang-compiler/f18/pull/745

[flang] Implement checks for test/semantics/call02.f90

Original-commit: flang-compiler/f18@38eaaa72fffe1b1f2fccec97a1a2a428f47da98f
Reviewed-on: https://github.com/flang-compiler/f18/pull/745
Tree-same-pre-rewrite: false

[flang] Improve flag dumping for -funparse-with-symbols

Original-commit: flang-compiler/f18@768fb1b36925c1e1ed563562ef01146c2bba4b2b

[flang] Merge pull request flang-compiler/f18#736 from flang-compiler/pmk-fix-expo

Do not emit a bogus exponent on zero (0.e-1)

Original-commit: flang-compiler/f18@ab19f2e9a7a9daa57ed1c1767cc182bf7fff98e6
Reviewed-on: https://github.com/flang-compiler/f18/pull/736

[flang] Do not emit a bogus exponent (0.e-1)

Original-commit: flang-compiler/f18@3d0b13d7ed146eae2641a4e6218d353314c7496f
Reviewed-on: https://github.com/flang-compiler/f18/pull/736

[flang] Merge pull request flang-compiler/f18#738 from flang-compiler/pmk-fix-735

Fix bug flang-compiler/f18#735

Original-commit: flang-compiler/f18@675ccd4208cc6061b7e3fe9b6c02441ceaea2e06
Reviewed-on: https://github.com/flang-compiler/f18/pull/738

[flang] tweak test results

Original-commit: flang-compiler/f18@360c6717e790b7160655677e6f160c4d467383f8
Reviewed-on: https://github.com/flang-compiler/f18/pull/738

[flang] Fix bug flang-compiler/f18#735

Original-commit: flang-compiler/f18@dccb16d492685cbe02771c2f78a60cbd46fc1bac
Reviewed-on: https://github.com/flang-compiler/f18/pull/738
Tree-same-pre-rewrite: false

[flang] Improve error message (add types)

Original-commit: flang-compiler/f18@48b8f32d516e38cfd80f4759c4b78a08a24ebdf3
Reviewed-on: https://github.com/flang-compiler/f18/pull/738
Tree-same-pre-rewrite: false

[flang] Merge pull request flang-compiler/f18#734 from flang-compiler/jpr-fix-700

Add NEW_LINE intrinsic to the intrinsic table

Original-commit: flang-compiler/f18@9c10e02d396f3e1ce7cd636fc58f3093abc3c53a
Reviewed-on: https://github.com/flang-compiler/f18/pull/734

[flang] Add NEW_LINE intrinsic to the intrinsic table
NEW_LINE intrinsic folding was already implemented but it had not
yet been added the the intrinsic table and was therefore not yet
recognised an intrinsic.
Add related tests.

Original-commit: flang-compiler/f18@42fcf5b5f1e63267a024afaad39f012982c8abc1
Reviewed-on: https://github.com/flang-compiler/f18/pull/734

[flang] Merge pull request flang-compiler/f18#737 from flang-compiler/pmk-m-in-m

Allow module, submodule, and program names to be used as local identi…

Original-commit: flang-compiler/f18@ffc90d0b1c352ddb55e346469061a6b775e51803
Reviewed-on: https://github.com/flang-compiler/f18/pull/737

[flang] Extend comments

Original-commit: flang-compiler/f18@9f918c2559698a893aaa917dc7b109c226c6d49f
Reviewed-on: https://github.com/flang-compiler/f18/pull/737

[flang] Allow module, submodule, and program names to be used as local identifiers.  Check for USE of m in m.

Original-commit: flang-compiler/f18@9abfd9e45001bba6f5e4b5a6e08674ce92789052
Reviewed-on: https://github.com/flang-compiler/f18/pull/737
Tree-same-pre-rewrite: false

[flang] Merge pull request flang-compiler/f18#698 from tinlun/master

Added -fget-definition and -fget-symbols-sources.

Original-commit: flang-compiler/f18@24caaea2bf729fdc46d29981b10c668d92b0ccb9
Reviewed-on: https://github.com/flang-compiler/f18/pull/698

[flang] Using new Prov to Cooked mappings for get-definition.

Original-commit: flang-compiler/f18@5a42c5c9e19c5a56fdc256db56d32e3564e72765
Reviewed-on: https://github.com/flang-compiler/f18/pull/698

[flang] FindOffsetLineAndColumn also uses SourcePosition.

New tests for COMMON and BLOCK.
Added CHECK-ONCE to test_any.sh. Make sure pattern only occurs once.

Original-commit: flang-compiler/f18@ad82dafcf905c521904a0120462ad1636917fc8c
Reviewed-on: https://github.com/flang-compiler/f18/pull/698
Tree-same-pre-rewrite: false

[flang] Added -fget-definitions and -fget-all-symbols.

- -fget-definitions finds the definition of the symbol under specified source
position.
- -fget-all-symbols finds definition locations of all symbols in a document. For
symbols found in other modules, shows which module the symbol came from.
- Tests.
- New structure SourcePosition with file, line, column information.

Original-commit: flang-compiler/f18@e0099b0900b47ff1d8903c2462bb8a42ecc7999b
Reviewed-on: https://github.com/flang-compiler/f18/pull/698
Tree-same-pre-rewrite: false

[flang] Merge pull request flang-compiler/f18#731 from flang-compiler/pmk-fix-728

Recover better from syntax errors on USE statements

Original-commit: flang-compiler/f18@2c45d65b88e1cffa59d0eafa08c5ee5762a86155
Reviewed-on: https://github.com/flang-compiler/f18/pull/731

[flang] Recover better from syntax errors on USE statements

Original-commit: flang-compiler/f18@29968698d9afe367de92d536e54a048cc998b359
Reviewed-on: https://github.com/flang-compiler/f18/pull/731

[flang] Merge pull request flang-compiler/f18#732 from flang-compiler/pmk-call

Begin semantic checks for calls

Original-commit: flang-compiler/f18@4d6ae6fab014b3e7c48572e2f843425f0796721b
Reviewed-on: https://github.com/flang-compiler/f18/pull/732

[flang] Address review comment

Original-commit: flang-compiler/f18@65dc8d4996b74148a06bc73d59c318a2bf38fe07
Reviewed-on: https://github.com/flang-compiler/f18/pull/732

[flang] Add static declaration checker; get call01.f90 to pass

Original-commit: flang-compiler/f18@7cc5bc76174d36c90b8273b0a892a229d8787af2
Reviewed-on: https://github.com/flang-compiler/f18/pull/732
Tree-same-pre-rewrite: false

[flang] Check recursive calls for NON_RECURSIVE and assumed-length CHARACTER(*)

Original-commit: flang-compiler/f18@92777f8f669284ecd0fc4f73bd20f82e148ceba3
Reviewed-on: https://github.com/flang-compiler/f18/pull/732
Tree-same-pre-rewrite: false

[flang] commit to switch branches

Some groundwork

Original-commit: flang-compiler/f18@64ebeb511cc823e8ea7ad9647d0475542930f506
Reviewed-on: https://github.com/flang-compiler/f18/pull/732
Tree-same-pre-rewrite: false

[flang] Merge pull request flang-compiler/f18#686 from flang-compiler/ps-stmt-stack

Changes to add an executable construct stack

Original-commit: flang-compiler/f18@2fc28c75386ee70e01a21533ee18bc1cba149e4c
Reviewed-on: https://github.com/flang-compiler/f18/pull/686

[flang] Combined the implementations to ```Pre()``` and ```Post()``` functions that
call `PushConstruct()``` and ```PopConstruct()``` following a genius
suggestion from Peter.

Original-commit: flang-compiler/f18@be2a03ebf479be8eda2529e6c47a7d44a073c455
Reviewed-on: https://github.com/flang-compiler/f18/pull/686

[flang] Changed ```PushConstruct()``` to be a template, which moves the implicit
creation of the ```ConstructNode``` into ```PushConstruct()```.

Original-commit: flang-compiler/f18@3984566858743c1b18a7a53cb899e68bf951154a
Reviewed-on: https://github.com/flang-compiler/f18/pull/686
Tree-same-pre-rewrite: false

[flang] Responses to review comments

I changed the interface of ```PushConstruct()``` to take an rvalue reference as its only parameter and made the construction of the ```ConstructNode```s explicit in all of the ```Pre()``` functions for the various construct types.

Original-commit: flang-compiler/f18@f8be813874ac7a8021bd5e8138c7b421e166ea22
Reviewed-on: https://github.com/flang-compiler/f18/pull/686
Tree-same-pre-rewrite: false

[flang] Responses to review comments and team meeting

The most significant change is that I replaced the stack of
ExecutableConstruct's with a stack composed of ConstructNode's, each of which
is a variant of the constructs that made up the type ExecutableConstruct.  This
change allows the nodes of the stack to be extended to include the types needed
for OMP semantic checking.

I also extended the existing test to include some correct DO loops with CYCLE
and EXIT statements to test the code more completely.

Original-commit: flang-compiler/f18@d26f34e3a4cf72f1b6c56ececf24afa7a6299ffd
Reviewed-on: https://github.com/flang-compiler/f18/pull/686
Tree-same-pre-rewrite: false

[flang] Changes to add an executable construct stack
I added a stack of ExecutableConstruct's to SemanticsContext along with
functions to push and pop constructs.  I added code to the SemanticsVisitor
to use these new functions.  I also added functions Pre and Post functions
for UnlabeledStatement's so that we could isolate the source positions for
statements embedded in "if" statements to improve error messages.

I also added code to check-do.[h,cc] to use this new infrastructure to check
for CYCLE and EXIT statements that are not contained within DO constructs
along with a test.

Original-commit: flang-compiler/f18@b8370bdeb899791b9c841a7bd86e61412a92af22
Reviewed-on: https://github.com/flang-compiler/f18/pull/686
Tree-same-pre-rewrite: false

[flang] Merge pull request flang-compiler/f18#730 from flang-compiler/ps-issue725

Fixed the declarations of IEEE_SUPPORT_FLAG and IEEE_SUPPORT_HALTING

Original-commit: flang-compiler/f18@238b9ee459599e3803a1d536479a4a2d9dc09723
Reviewed-on: https://github.com/flang-compiler/f18/pull/730

[flang] Fixed the declarations of IEEE_SUPPORT_FLAG and IEEE_SUPPORT_HALTING to
be functions rather than subroutines.  Note that Table 17.3 in the
standard summarizes the contents of IEEE_EXCEPTIONS with the details
specified in section 17.11.

Original-commit: flang-compiler/f18@fca58d479d2ab4578a029980f5144d11a46d5e78
Reviewed-on: https://github.com/flang-compiler/f18/pull/730

[flang] Merge pull request flang-compiler/f18#723 from flang-compiler/sjs-storage-size

Add storage_size intrinsic.

Original-commit: flang-compiler/f18@f2ffcfafd2b04703879581df8727b98ffb508ea3
Reviewed-on: https://github.com/flang-compiler/f18/pull/723

[flang] Update comment to reflect that STORAGE_SIZE is implemented.

Original-commit: flang-compiler/f18@3c2431bbf8025856bd19e2c7b66aaf06b6acdbfe
Reviewed-on: https://github.com/flang-compiler/f18/pull/723

[flang] Add storage_size intrinsic.

Original-commit: flang-compiler/f18@bcde26a7c1373c3ccbcc8e216cf37c8b3530b06d
Reviewed-on: https://github.com/flang-compiler/f18/pull/723
Tree-same-pre-rewrite: false

[flang] Merge pull request flang-compiler/f18#699 from flang-compiler/jpr-fix-695

Implement folding of x**y where y is real or complex

Original-commit: flang-compiler/f18@0efc573230a2038f64597c11b0e1a733c5bf5fff
Reviewed-on: https://github.com/flang-compiler/f18/pull/699

[flang] address comment: add ',' for better formatting

Original-commit: flang-compiler/f18@0c854999853463b2113d672836cb343e98ae1c61
Reviewed-on: https://github.com/flang-compiler/f18/pull/699

[flang] Implement folding of x**y where y is real or complex
This was a TODO. The implementation uses the host runtime
function pow, either from libm or libpgmath.

Original-commit: flang-compiler/f18@ee581121120fe67a0990b8a41663b85b868035a7
Reviewed-on: https://github.com/flang-compiler/f18/pull/699
Tree-same-pre-rewrite: false

[flang] Merge pull request flang-compiler/f18#722 from flang-compiler/sjs-error-unit

Define iso_fortran_env error_unit.

Original-commit: flang-compiler/f18@cb1752d5cb3913c14d819b328be7ff36cd8a406d
Reviewed-on: https://github.com/flang-compiler/f18/pull/722

[flang] Define iso_fortran_env error_unit.
Provisionally use a value of 0 to match PGI.

Original-commit: flang-compiler/f18@ec7f0a0968d5552f9f95d1c24256d6fe40d36770
Reviewed-on: https://github.com/flang-compiler/f18/pull/722

[flang] Merge pull request flang-compiler/f18#721 from flang-compiler/pmk-fix-errormsg

Fix expected error messages in tests to correspond with recent update…

Original-commit: flang-compiler/f18@ffbc017c45527a3ac4825cbe33e732eee1f0ecee
Reviewed-on: https://github.com/flang-compiler/f18/pull/721

[flang] Fix expected error messages in tests to correspond with recent update to compiler

Original-commit: flang-compiler/f18@95202dd31384c042165184acd6ed2ec1c752ee0c
Reviewed-on: https://github.com/flang-compiler/f18/pull/721

[flang] Merge pull request flang-compiler/f18#711 from flang-compiler/pmk-call-tests

Tests for call semantics

Original-commit: flang-compiler/f18@8fada8d5cd99e85bfe8c2fdd4defd7da36017ffc
Reviewed-on: https://github.com/flang-compiler/f18/pull/711

[flang] Fix some Fortran and use existing messages for errors already caught.

Original-commit: flang-compiler/f18@2d360e78ea3a872501f05904ec39f3c3ea3172a4
Reviewed-on: https://github.com/flang-compiler/f18/pull/711

[flang] Finish test/semantics/call12.f90

Original-commit: flang-compiler/f18@d002f0ce377de4b71fd15a0fdee87c013476e93b
Reviewed-on: https://github.com/flang-compiler/f18/pull/711
Tree-same-pre-rewrite: false